From owner-freebsd-fs@freebsd.org Sun Jun 2 21:00:40 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0110F15BFB20 for ; Sun, 2 Jun 2019 21:00:40 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 7933680655 for ; Sun, 2 Jun 2019 21:00:39 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: by mailman.ysv.freebsd.org (Postfix) id 3B13E15BFB05; Sun, 2 Jun 2019 21:00:39 +0000 (UTC) Delivered-To: fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F1D3015BFAF5 for ; Sun, 2 Jun 2019 21:00:38 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 685E080642 for ; Sun, 2 Jun 2019 21:00:38 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 90CF210024 for ; Sun, 2 Jun 2019 21:00:37 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x52L0bUJ011957 for ; Sun, 2 Jun 2019 21:00:37 GMT (envelope-from bugzilla-noreply@FreeBSD.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x52L0bVO011952 for fs@FreeBSD.org; Sun, 2 Jun 2019 21:00:37 GMT (envelope-from bugzilla-noreply@FreeBSD.org) Message-Id: <201906022100.x52L0bVO011952@kenobi.freebsd.org> X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@FreeBSD.org using -f From: bugzilla-noreply@FreeBSD.org To: fs@FreeBSD.org Subject: Problem reports for fs@FreeBSD.org that need special attention Date: Sun, 2 Jun 2019 21:00:37 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 Jun 2019 21:00:40 -0000 To view an individual PR, use: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=(Bug Id). The following is a listing of current problems submitted by FreeBSD users, which need special attention. These represent problem reports covering all versions including experimental development code and obsolete releases. Status | Bug Id | Description ------------+-----------+--------------------------------------------------- New | 203492 | mount_unionfs -o below causes panic Open | 144447 | [zfs] sharenfs fsunshare() & fsshare_main() non f Open | 211491 | System hangs after "Uptime" on reboot with ZFS Open | 221909 | [ZFS] Add a sysctl to toggle send_corrupt_data Open | 235665 | panic: handle_written_inodeblock: live inodedep Open | 237067 | ZFS: Crash in vdev_dtl_reassess when using GELI w 6 problems total for which you should take action. From owner-freebsd-fs@freebsd.org Sun Jun 2 21:21:33 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B5E0D15C0C71 for ; Sun, 2 Jun 2019 21:21:33 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 474EE815DA for ; Sun, 2 Jun 2019 21:21:33 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 0535A15C0C70; Sun, 2 Jun 2019 21:21:33 +0000 (UTC) Delivered-To: fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E662115C0C6F for ; Sun, 2 Jun 2019 21:21:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7C314815D8 for ; Sun, 2 Jun 2019 21:21:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id C7126104CA for ; Sun, 2 Jun 2019 21:21:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x52LLVpM024362 for ; Sun, 2 Jun 2019 21:21:31 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x52LLVUD024356 for fs@FreeBSD.org; Sun, 2 Jun 2019 21:21:31 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 237517] ZFS parallel mounting sometimes misses mounting intermediate filesystems Date: Sun, 02 Jun 2019 21:21:30 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.0-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: fullermd@over-yonder.net X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 Jun 2019 21:21:33 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D237517 fullermd@over-yonder.net changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fullermd@over-yonder.net --- Comment #8 from fullermd@over-yonder.net --- This bit me on a server recently, which upgraded across a few months of stable/12, then came up with little things like /usr/local masked away.=20 Adjusting libzfs to effectively serialize the mounting turned out to be my = best solution. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Sun Jun 2 21:22:46 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A6B1115C0E49 for ; Sun, 2 Jun 2019 21:22:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 1F661818FB for ; Sun, 2 Jun 2019 21:22:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id CFEE215C0E44; Sun, 2 Jun 2019 21:22:45 +0000 (UTC) Delivered-To: fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BB54915C0E43 for ; Sun, 2 Jun 2019 21:22:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4F995818F9 for ; Sun, 2 Jun 2019 21:22:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 85A5B104FC for ; Sun, 2 Jun 2019 21:22:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x52LMiXg063683 for ; Sun, 2 Jun 2019 21:22:44 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x52LMie5063680 for fs@FreeBSD.org; Sun, 2 Jun 2019 21:22:44 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 237517] ZFS parallel mounting sometimes misses mounting intermediate filesystems Date: Sun, 02 Jun 2019 21:22:43 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.0-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: fullermd@over-yonder.net X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 Jun 2019 21:22:46 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D237517 --- Comment #9 from fullermd@over-yonder.net --- Created attachment 204788 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D204788&action= =3Dedit Hack to serialize libzfs's mounting Apply and rebuild/install src/cddl/libzfs/ --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Mon Jun 3 14:41:29 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B324F15B324D for ; Mon, 3 Jun 2019 14:41:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 47092839CF for ; Mon, 3 Jun 2019 14:41:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 07B7515B324C; Mon, 3 Jun 2019 14:41:29 +0000 (UTC) Delivered-To: fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E11AD15B324B for ; Mon, 3 Jun 2019 14:41:28 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7DACE839C9 for ; Mon, 3 Jun 2019 14:41:28 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 8FB2F198EE for ; Mon, 3 Jun 2019 14:41:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x53EfRSl090358 for ; Mon, 3 Jun 2019 14:41:27 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x53EfRsl090357 for fs@FreeBSD.org; Mon, 3 Jun 2019 14:41:27 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 147881] [zfs] [patch] ZFS "sharenfs" doesn't allow different "exports" options for different hosts Date: Mon, 03 Jun 2019 14:41:27 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: Richard.Conto@gmail.com X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Jun 2019 14:41:30 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D147881 --- Comment #12 from Richard S. Conto --- I considered re-writing my patch to use a FreeBSD specific attribute for my syntax (or an expanded one that would allow white-space in the pathnames - = but that would have involved modifying how the "exportfs" command parsed .../exports files.) But frankly, this was a sort of proof-of-concept that addressed a need for adapting to the FreeBSD .../exports file format that wasn't being addressed. And the FreeBSD project didn't care enough. Of course there are compatibility issues with the Solaris version of ZFS - because "sharenfs" is implemented as a hack to begin with. Pushing the administration of ZFS mount points into a hand-administered /etc/exports files ignores scalability issues. The FreeBSD .../exports file format doesn't scale well and is an ugly hack itself. A proper fix to this should include revisiting whether that file format should be extended or supplemented. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Mon Jun 3 16:15:27 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8753E15B604B for ; Mon, 3 Jun 2019 16:15:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 1E0B988802 for ; Mon, 3 Jun 2019 16:15:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id D63D615B604A; Mon, 3 Jun 2019 16:15:26 +0000 (UTC) Delivered-To: fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C3B5315B6049 for ; Mon, 3 Jun 2019 16:15:26 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5F58988801 for ; Mon, 3 Jun 2019 16:15:26 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 96CA21A62E for ; Mon, 3 Jun 2019 16:15:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x53GFPEY015917 for ; Mon, 3 Jun 2019 16:15:25 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x53GFPIF015916 for fs@FreeBSD.org; Mon, 3 Jun 2019 16:15:25 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 147881] [zfs] [patch] ZFS "sharenfs" doesn't allow different "exports" options for different hosts Date: Mon, 03 Jun 2019 16:15:24 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: dgilbert@eicat.ca X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Jun 2019 16:15:27 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D147881 --- Comment #13 from dgilbert@eicat.ca --- So where do we go to have this "larger" conversation? Is there a PR for the exports format? Is there anyone working on the issue? Can I work on the i= ssue (still need to have the discussion since the format needs to make people ha= ppy to get adopted)... --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Mon Jun 3 21:24:50 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E822315BE82F for ; Mon, 3 Jun 2019 21:24:49 +0000 (UTC) (envelope-from ronald-lists@klop.ws) Received: from smarthost1.greenhost.nl (smarthost1.greenhost.nl [195.190.28.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id CE23D707E7 for ; Mon, 3 Jun 2019 21:24:48 +0000 (UTC) (envelope-from ronald-lists@klop.ws) Received: from smtp.greenhost.nl ([213.108.110.112]) by smarthost1.greenhost.nl with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hXuRa-0002u7-Sl; Mon, 03 Jun 2019 23:24:40 +0200 Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes To: "freebsd-fs@freebsd.org" , "Rick Macklem" Subject: Re: RFC: should an incremental reload of exports for mountd be optional? References: Date: Mon, 03 Jun 2019 23:24:40 +0200 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: "Ronald Klop" Message-ID: In-Reply-To: User-Agent: Opera Mail/12.16 (FreeBSD) X-Authenticated-As-Hash: 398f5522cb258ce43cb679602f8cfe8b62a256d1 X-Virus-Scanned: by clamav at smarthost1.samage.net X-Spam-Level: -- X-Spam-Score: -2.0 X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED, BAYES_00 autolearn=disabled version=3.4.2 X-Scan-Signature: e462de357cb394d64966911c06262bc8 X-Rspamd-Queue-Id: CE23D707E7 X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of ronald-lists@klop.ws designates 195.190.28.88 as permitted sender) smtp.mailfrom=ronald-lists@klop.ws X-Spamd-Result: default: False [-1.68 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:195.190.28.64/27]; MX_GOOD(-0.01)[mx2.greenhost.nl,mx1.greenhost.nl]; RCPT_COUNT_TWO(0.00)[2]; NEURAL_HAM_SHORT(-0.42)[-0.419,0]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:47172, ipnet:195.190.28.0/24, country:NL]; SUBJECT_ENDS_QUESTION(1.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.997,0]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[klop.ws]; TO_MATCH_ENVRCPT_SOME(0.00)[]; IP_SCORE(-0.46)[ip: (-1.48), ipnet: 195.190.28.0/24(-0.46), asn: 47172(-0.36), country: NL(0.01)]; MID_RHS_NOT_FQDN(0.50)[]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Jun 2019 21:24:50 -0000 On Fri, 31 May 2019 23:50:10 +0200, Rick Macklem wrote: > Hi, > > I have created a patch for PR#237860 that improves the time it takes to > reload > the exports file(s) for an NFS file server from seconds->milliseconds by > only doing > system calls for the changes to the exports file(s). (Assumes each > reload includes > changes to only a small fraction of the entries.) > > I made it a non-default option of "-I", but asomers@ asked why it needed > to be > optional. > > Basically, I made it optional because I felt the patch might still be > buggy and not > handle some case of an exports file change that I missed. > > However, I can see the argument of making it non-optional (or optional > but enabled > by default) so that sysadmins don't need to add "-I" to avoid long > periods where the > nfsd threads are suspended. > If it is broken, the deamon would need to be restarted to do a full > reload, but that > would also be the case if a sysadmin specified the "-I" option. > > So, the question is... "do you think this should be an option or just > always enabled?". always enabled +1 > Thanks , rick > _______________________________________________ > freebsd-fs@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-fs > To unsubscribe, send any mail to "freebsd-fs-unsubscribe@freebsd.org" From owner-freebsd-fs@freebsd.org Mon Jun 3 21:26:49 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CA07A15BE8C1 for ; Mon, 3 Jun 2019 21:26:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 5BF6170892 for ; Mon, 3 Jun 2019 21:26:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 18C9D15BE8C0; Mon, 3 Jun 2019 21:26:49 +0000 (UTC) Delivered-To: fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 04ADF15BE8BF for ; Mon, 3 Jun 2019 21:26:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 917E870891 for ; Mon, 3 Jun 2019 21:26:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id CAE9C1D207 for ; Mon, 3 Jun 2019 21:26:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x53LQlOq054202 for ; Mon, 3 Jun 2019 21:26:47 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x53LQl7Y054196 for fs@FreeBSD.org; Mon, 3 Jun 2019 21:26:47 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 147881] [zfs] [patch] ZFS "sharenfs" doesn't allow different "exports" options for different hosts Date: Mon, 03 Jun 2019 21:26:46 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: Richard.Conto@gmail.com X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Jun 2019 21:26:50 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D147881 --- Comment #14 from Richard S. Conto --- If I knew, I'd try. The format of the "exports" files in Linux, FreeBSD, and Solaris are differ= ent. The FreeBSD "fsshare" utility is an attempt to approximate some of the functionality without considering the other aspects of Solaris sharing (including CIFS file sharing) and system administration that ZFS filesystem attributes encode. Having a FreeBSD specific attribute for this seems like the best solution, = as "nfsshare" is really a Solaris specific solution. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Mon Jun 3 22:10:19 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 59DEE15BF730 for ; Mon, 3 Jun 2019 22:10:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id E494971D66 for ; Mon, 3 Jun 2019 22:10:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id A002215BF72F; Mon, 3 Jun 2019 22:10:18 +0000 (UTC) Delivered-To: fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8B86F15BF72E for ; Mon, 3 Jun 2019 22:10:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1BA1A71D63 for ; Mon, 3 Jun 2019 22:10:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 42D821D7E1 for ; Mon, 3 Jun 2019 22:10:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x53MAHFi094713 for ; Mon, 3 Jun 2019 22:10:17 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x53MAHMw094712 for fs@FreeBSD.org; Mon, 3 Jun 2019 22:10:17 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 147881] [zfs] [patch] ZFS "sharenfs" doesn't allow different "exports" options for different hosts Date: Mon, 03 Jun 2019 22:10:17 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: dgilbert@eicat.ca X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Jun 2019 22:10:19 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D147881 --- Comment #15 from dgilbert@eicat.ca --- (In reply to Richard S. Conto from comment #14) ... hrm... this is becoming _the_ place to discuss this, it seems. Several people I've talked to have already noticed the activity. Anyways... someone proposed the ';' solution ... to make multiple lines.=20 Someone else, I think (somewhere) said that there are hard limits on the le= ngth of zfs attributes. The auto-snapshot bit in zfs-tools uses a "custom" attribute. Putting these all together makes me think: freebsd.org:export_0 =3D freebsd.org:export_1 =3D ... it may even be true that export_<*> is available where the suffix could just be something meaninful to the admin in question. To be clear, "" is the /etc/exports line without the path. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Mon Jun 3 22:15:38 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CD8B315BF964 for ; Mon, 3 Jun 2019 22:15:38 +0000 (UTC) (envelope-from pen@lysator.liu.se) Received: from mail.lysator.liu.se (mail.lysator.liu.se [130.236.254.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id ADD90720C3 for ; Mon, 3 Jun 2019 22:15:36 +0000 (UTC) (envelope-from pen@lysator.liu.se) Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id 5C8D840004; Tue, 4 Jun 2019 00:15:28 +0200 (CEST) Received: from [192.168.1.79] (h-99-68.A785.priv.bahnhof.se [158.174.99.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id 2DEB940002; Tue, 4 Jun 2019 00:15:28 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: RFC: should an incremental reload of exports for mountd be optional? From: Peter Eriksson In-Reply-To: Date: Tue, 4 Jun 2019 00:15:27 +0200 Cc: "freebsd-fs@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: To: Rick Macklem X-Mailer: Apple Mail (2.3445.104.11) X-Virus-Scanned: ClamAV using ClamSMTP X-Rspamd-Queue-Id: ADD90720C3 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dmarc=pass (policy=none) header.from=liu.se; spf=pass (mx1.freebsd.org: domain of pen@lysator.liu.se designates 130.236.254.3 as permitted sender) smtp.mailfrom=pen@lysator.liu.se X-Spamd-Result: default: False [-2.23 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+a:mail.lysator.liu.se]; MV_CASE(0.50)[]; RCVD_COUNT_THREE(0.00)[3]; RCVD_IN_DNSWL_MED(-0.20)[3.254.236.130.list.dnswl.org : 127.0.11.2]; MX_GOOD(-0.01)[v-mailfilter03.sunet.se,e-mailfilter04.sunet.se,v-mailfilter03.sunet.se,e-mailfilter04.sunet.se,v-mailfilter03.sunet.se,e-mailfilter04.sunet.se,v-mailfilter03.sunet.se,e-mailfilter04.sunet.se]; RCPT_COUNT_TWO(0.00)[2]; NEURAL_HAM_SHORT(-0.72)[-0.720,0]; DMARC_POLICY_ALLOW(-0.50)[liu.se,none]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; SUBJECT_ENDS_QUESTION(1.00)[]; ASN(0.00)[asn:2843, ipnet:130.236.0.0/16, country:SE]; MID_RHS_MATCH_FROM(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.99)[-0.995,0]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-0.999,0]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_TLS_LAST(0.00)[]; IP_SCORE(-0.00)[country: SE(-0.01)] X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Jun 2019 22:15:39 -0000 My vote goes to: Enabled by default (with an option to disable it in case problems pop = up). - Peter > On 31 May 2019, at 23:50, Rick Macklem wrote: >=20 > Hi, >=20 > I have created a patch for PR#237860 that improves the time it takes = to reload > the exports file(s) for an NFS file server from seconds->milliseconds = by only doing > system calls for the changes to the exports file(s). (Assumes each = reload includes > changes to only a small fraction of the entries.) >=20 > I made it a non-default option of "-I", but asomers@ asked why it = needed to be > optional. >=20 > Basically, I made it optional because I felt the patch might still be = buggy and not > handle some case of an exports file change that I missed. >=20 > However, I can see the argument of making it non-optional (or optional = but enabled > by default) so that sysadmins don't need to add "-I" to avoid long = periods where the > nfsd threads are suspended. > If it is broken, the deamon would need to be restarted to do a full = reload, but that > would also be the case if a sysadmin specified the "-I" option. >=20 > So, the question is... "do you think this should be an option or just = always enabled?". >=20 > Thanks , rick > _______________________________________________ > freebsd-fs@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-fs > To unsubscribe, send any mail to "freebsd-fs-unsubscribe@freebsd.org" From owner-freebsd-fs@freebsd.org Mon Jun 3 22:29:06 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9B5D315BFC89 for ; Mon, 3 Jun 2019 22:29:06 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com [209.85.167.66]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1ABA47267E for ; Mon, 3 Jun 2019 22:29:04 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-lf1-f66.google.com with SMTP id y198so4358965lfa.1 for ; Mon, 03 Jun 2019 15:29:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OOgxBlTfDDLv6Xnz/8jUHfkAwVdQjRGvmMriKV+TtkU=; b=b5kP+awuCL6K6dxIIOfFK/N4TiRXh7bbocFlb8JAHBgLsHrAJqE50lCMUhaKzk4Vws OARdpLrhapr5iW4wGgCY5KO2S2b86wvjeW0HXqCniXT5YnZyBl/6QuGI+Et1yhd6xTIo rKF6vQkIj1WX5sXgmjzS6x6eGHYO56TYTZeLDTOAd7X7BqZC+xjNktI3f7HZFa6zywFJ XsyRdrxZLQz31x32XHzy2MUIv0yAr8AS8KrvN0NkDVBrnAx40xNdaBZB1MGfZVzC9/v/ DzypbWqWpBE4QnNGzNCyMz3Wj2F4kzz9hHQdKW2E09WwrgalmBleDp62jj6sha/yyPe+ GveA== X-Gm-Message-State: APjAAAVjURPyYX1aBIbBpJzoe2I6IfPG4YE8zV3mx+u0X5rDdWLzhSBU Ou96vBWoofTH+OxOgWiU79IZFobSq8i2LiU6oJg= X-Google-Smtp-Source: APXvYqxD2GJgXKOiODdhR9oJld3C9eTw0igzyP+6gyJfxB9R8FWGItJ/GK48PrGYzYeNkGkNKf1ndXmx/vMSpKb5Qa8= X-Received: by 2002:ac2:5324:: with SMTP id f4mr343181lfh.156.1559600943036; Mon, 03 Jun 2019 15:29:03 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Alan Somers Date: Mon, 3 Jun 2019 16:28:51 -0600 Message-ID: Subject: Re: RFC: should an incremental reload of exports for mountd be optional? To: Peter Eriksson Cc: Rick Macklem , "freebsd-fs@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 1ABA47267E X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of asomers@gmail.com designates 209.85.167.66 as permitted sender) smtp.mailfrom=asomers@gmail.com X-Spamd-Result: default: False [-3.07 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; NEURAL_HAM_SHORT(-0.97)[-0.973,0]; FORGED_SENDER(0.30)[asomers@freebsd.org,asomers@gmail.com]; IP_SCORE(-1.08)[ip: (0.31), ipnet: 209.85.128.0/17(-3.39), asn: 15169(-2.29), country: US(-0.06)]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[asomers@freebsd.org,asomers@gmail.com]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; SUBJECT_ENDS_QUESTION(1.00)[]; PREVIOUSLY_DELIVERED(0.00)[freebsd-fs@freebsd.org]; DMARC_NA(0.00)[freebsd.org]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[66.167.85.209.list.dnswl.org : 127.0.5.0]; RCVD_TLS_LAST(0.00)[]; RWL_MAILSPIKE_POSSIBLE(0.00)[66.167.85.209.rep.mailspike.net : 127.0.0.17]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Jun 2019 22:29:06 -0000 I think that it should be always enabled. If the only reason not to is a fear of bugs in the new method, then the old method can be selected by some back-doorish workaround, like an environment variable. -Alan On Mon, Jun 3, 2019 at 4:16 PM Peter Eriksson wrote: > > My vote goes to: > > Enabled by default (with an option to disable it in case problems pop up). > > - Peter > > > > On 31 May 2019, at 23:50, Rick Macklem wrote: > > > > Hi, > > > > I have created a patch for PR#237860 that improves the time it takes to reload > > the exports file(s) for an NFS file server from seconds->milliseconds by only doing > > system calls for the changes to the exports file(s). (Assumes each reload includes > > changes to only a small fraction of the entries.) > > > > I made it a non-default option of "-I", but asomers@ asked why it needed to be > > optional. > > > > Basically, I made it optional because I felt the patch might still be buggy and not > > handle some case of an exports file change that I missed. > > > > However, I can see the argument of making it non-optional (or optional but enabled > > by default) so that sysadmins don't need to add "-I" to avoid long periods where the > > nfsd threads are suspended. > > If it is broken, the deamon would need to be restarted to do a full reload, but that > > would also be the case if a sysadmin specified the "-I" option. > > > > So, the question is... "do you think this should be an option or just always enabled?". > > > > Thanks , rick > > _______________________________________________ > > freebsd-fs@freebsd.org mailing list > > https://lists.freebsd.org/mailman/listinfo/freebsd-fs > > To unsubscribe, send any mail to "freebsd-fs-unsubscribe@freebsd.org" > > _______________________________________________ > freebsd-fs@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-fs > To unsubscribe, send any mail to "freebsd-fs-unsubscribe@freebsd.org" From owner-freebsd-fs@freebsd.org Mon Jun 3 23:13:39 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5FA2D15C0B3B for ; Mon, 3 Jun 2019 23:13:39 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from CAN01-QB1-obe.outbound.protection.outlook.com (mail-eopbgr660065.outbound.protection.outlook.com [40.107.66.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "GlobalSign Organization Validation CA - SHA256 - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7F85374369; Mon, 3 Jun 2019 23:13:36 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from YQXPR01MB3128.CANPRD01.PROD.OUTLOOK.COM (52.132.93.160) by YQXPR01MB3189.CANPRD01.PROD.OUTLOOK.COM (52.132.90.79) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1943.22; Mon, 3 Jun 2019 23:13:35 +0000 Received: from YQXPR01MB3128.CANPRD01.PROD.OUTLOOK.COM ([fe80::f9fe:559f:fdc:9e5a]) by YQXPR01MB3128.CANPRD01.PROD.OUTLOOK.COM ([fe80::f9fe:559f:fdc:9e5a%3]) with mapi id 15.20.1943.018; Mon, 3 Jun 2019 23:13:35 +0000 From: Rick Macklem To: Alan Somers , Peter Eriksson CC: "freebsd-fs@freebsd.org" Subject: Re: RFC: should an incremental reload of exports for mountd be optional? Thread-Topic: RFC: should an incremental reload of exports for mountd be optional? Thread-Index: AQHVF/n5fA6XHqwN4UmNwJInW+ldyaaKg72AgAADv4CAAAwEhw== Date: Mon, 3 Jun 2019 23:13:35 +0000 Message-ID: References: , In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 510979e4-73bf-471c-7098-08d6e8791a7e x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:YQXPR01MB3189; x-ms-traffictypediagnostic: YQXPR01MB3189: x-ms-exchange-purlcount: 1 x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-forefront-prvs: 0057EE387C x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(39860400002)(366004)(396003)(376002)(136003)(189003)(199004)(51444003)(4326008)(33656002)(66476007)(66556008)(6246003)(74482002)(110136005)(5660300002)(64756008)(73956011)(76176011)(76116006)(66446008)(66946007)(229853002)(305945005)(99286004)(53546011)(8936002)(486006)(476003)(14454004)(6506007)(186003)(2906002)(71190400001)(71200400001)(11346002)(478600001)(102836004)(74316002)(52536014)(55016002)(86362001)(256004)(966005)(53936002)(81166006)(46003)(81156014)(25786009)(9686003)(6306002)(68736007)(786003)(7696005)(446003)(316002)(8676002)(6436002)(14444005); DIR:OUT; SFP:1101; SCL:1; SRVR:YQXPR01MB3189; H:YQXPR01MB3128.CANPRD01.PROD.OUTLOOK.COM; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: uoguelph.ca does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: IpzZQgwgIowBlLDXQthCTORipzQCPfffKFztE8f9cA2ChIa9hkhrNJAoO+EOGwZUnR34w+4JmNV5v5I4Xh3dP8iIZLW8vrLFjQXdq9G7CrVvNT0ME5Fk4lE0y6SWzKi7skZy4SztZyJtOL+hHrwu6Owl8MU0mMrd2fJvvy2tbTkclfGeFa21o+HtznwoyEyEwOnOXSWVGlcJiREAbiQUM05IiewXcD1/hAcMIUPkwFtWoRTZyZJvbmgKPkB/wTka2r7U5poZMbHY6FDx1amm+S5xflPLRyhiiTqX6m7C2F+cKIbAE8SJpbFuIZK0o5bEP5IFpD6VKUEm2ZElvomKqO1pQCW8PIg3fJwupb2pDexr3LbprhOAhPWYREoqhi4oIhxzMXohjDvF/9/TnYhiZDdpPo2/rPKJ/SYfFi3yDu8= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: uoguelph.ca X-MS-Exchange-CrossTenant-Network-Message-Id: 510979e4-73bf-471c-7098-08d6e8791a7e X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jun 2019 23:13:35.2075 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be62a12b-2cad-49a1-a5fa-85f4f3156a7d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rmacklem@uoguelph.ca X-MS-Exchange-Transport-CrossTenantHeadersStamped: YQXPR01MB3189 X-Rspamd-Queue-Id: 7F85374369 X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of rmacklem@uoguelph.ca designates 40.107.66.65 as permitted sender) smtp.mailfrom=rmacklem@uoguelph.ca X-Spamd-Result: default: False [-3.30 / 15.00]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:40.107.0.0/16]; FROM_HAS_DN(0.00)[]; MIME_GOOD(-0.10)[text/plain]; SUBJECT_ENDS_QUESTION(1.00)[]; DMARC_NA(0.00)[uoguelph.ca]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MX_GOOD(-0.01)[mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com]; NEURAL_HAM_SHORT(-0.98)[-0.977,0]; RCVD_IN_DNSWL_NONE(0.00)[65.66.107.40.list.dnswl.org : 127.0.3.0]; IP_SCORE(-1.02)[ipnet: 40.64.0.0/10(-2.84), asn: 8075(-2.18), country: US(-0.06)]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:8075, ipnet:40.64.0.0/10, country:US]; RCVD_TLS_LAST(0.00)[] X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Jun 2019 23:13:39 -0000 Thanks everyone for your comments. I just committed the patch with the incremental reload of exports always enabled. If people run into problems, I can add some "backdoor" way to disable it, as suggested by asomers@. A restart of the daemon will always do a full reload to work around any reload failures. rick ________________________________________ From: Alan Somers Sent: Monday, June 3, 2019 6:28:51 PM To: Peter Eriksson Cc: Rick Macklem; freebsd-fs@freebsd.org Subject: Re: RFC: should an incremental reload of exports for mountd be opt= ional? I think that it should be always enabled. If the only reason not to is a fear of bugs in the new method, then the old method can be selected by some back-doorish workaround, like an environment variable. -Alan On Mon, Jun 3, 2019 at 4:16 PM Peter Eriksson wrote: > > My vote goes to: > > Enabled by default (with an option to disable it in case problems pop up)= . > > - Peter > > > > On 31 May 2019, at 23:50, Rick Macklem wrote: > > > > Hi, > > > > I have created a patch for PR#237860 that improves the time it takes to= reload > > the exports file(s) for an NFS file server from seconds->milliseconds b= y only doing > > system calls for the changes to the exports file(s). (Assumes each relo= ad includes > > changes to only a small fraction of the entries.) > > > > I made it a non-default option of "-I", but asomers@ asked why it neede= d to be > > optional. > > > > Basically, I made it optional because I felt the patch might still be b= uggy and not > > handle some case of an exports file change that I missed. > > > > However, I can see the argument of making it non-optional (or optional = but enabled > > by default) so that sysadmins don't need to add "-I" to avoid long peri= ods where the > > nfsd threads are suspended. > > If it is broken, the deamon would need to be restarted to do a full rel= oad, but that > > would also be the case if a sysadmin specified the "-I" option. > > > > So, the question is... "do you think this should be an option or just a= lways enabled?". > > > > Thanks , rick > > _______________________________________________ > > freebsd-fs@freebsd.org mailing list > > https://lists.freebsd.org/mailman/listinfo/freebsd-fs > > To unsubscribe, send any mail to "freebsd-fs-unsubscribe@freebsd.org" > > _______________________________________________ > freebsd-fs@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-fs > To unsubscribe, send any mail to "freebsd-fs-unsubscribe@freebsd.org" From owner-freebsd-fs@freebsd.org Mon Jun 3 23:19:43 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1DBF615C0CEF for ; Mon, 3 Jun 2019 23:19:43 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 245DA746BB for ; Mon, 3 Jun 2019 23:19:42 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-lj1-f195.google.com with SMTP id m15so9563742ljg.13 for ; Mon, 03 Jun 2019 16:19:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nrb1ZHanvHXQdUjBIUMD6z/Xcl2ytfbOZUeJOViZycI=; b=B6i+ZiwLVjaUeag4YxGh2bagsIgoUnJtYQpycAZ/CVSNiE0oltm0ESVo5erRlig/i6 EXPu5PefiJRYf9mhaxiPVf13RaA1epb+3FL9xPX+pHKhmHQv778INEM6FwWBIk9rLG2l 8czC66jmkYKnC1lAZamPxShZ6q7ZBWLRP8AO5Rq9mjt+qRHWaT63cbqX/p2N26K5MbID 1xF0haWkAyZ7oilmZ+cdfiKACs7wN1DHzPKsDlCT2Wi0iAuSWOi32q1uBEy1/KCzxeBj ZcKUBmOy+4lpeLml0Jang60RKnJm1V7EOwBD/GlDW16caA0Dakgdxmt789ro4Yk++LKG z36A== X-Gm-Message-State: APjAAAXQ8WUb74qT0lviEtAbX1xE+jUhmG198eSGnnvk7JjJ0zTo3lWQ 3HOPxxW6tM2vtyG9fkP9UtXVj/cg8lRZ8atXPuY= X-Google-Smtp-Source: APXvYqyO40ZCEr1oO88tZx7q4qpZ2VvLz1XYQeTapg1Sdt7Xgh/4I1EuiTWQ8+odv9ECSpkT2SzI/T4UVikfQDFCekw= X-Received: by 2002:a2e:5dc4:: with SMTP id v65mr7857047lje.138.1559603980036; Mon, 03 Jun 2019 16:19:40 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Alan Somers Date: Mon, 3 Jun 2019 17:19:28 -0600 Message-ID: Subject: Re: RFC: should an incremental reload of exports for mountd be optional? To: Rick Macklem Cc: Peter Eriksson , "freebsd-fs@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 245DA746BB X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of asomers@gmail.com designates 209.85.208.195 as permitted sender) smtp.mailfrom=asomers@gmail.com X-Spamd-Result: default: False [-3.13 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; NEURAL_HAM_SHORT(-0.98)[-0.977,0]; FORGED_SENDER(0.30)[asomers@freebsd.org,asomers@gmail.com]; IP_SCORE(-1.15)[ipnet: 209.85.128.0/17(-3.39), asn: 15169(-2.29), country: US(-0.06)]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[asomers@freebsd.org,asomers@gmail.com]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; SUBJECT_ENDS_QUESTION(1.00)[]; PREVIOUSLY_DELIVERED(0.00)[freebsd-fs@freebsd.org]; DMARC_NA(0.00)[freebsd.org]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[195.208.85.209.list.dnswl.org : 127.0.5.0]; RCVD_TLS_LAST(0.00)[]; RWL_MAILSPIKE_POSSIBLE(0.00)[195.208.85.209.rep.mailspike.net : 127.0.0.17]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Jun 2019 23:19:43 -0000 Will a restart of the daemon cause clients to get HUPped if they try to access an exported filesystem while mountd is restarting? -Alan On Mon, Jun 3, 2019 at 5:13 PM Rick Macklem wrote: > > Thanks everyone for your comments. I just committed the patch with > the incremental reload of exports always enabled. > If people run into problems, I can add some "backdoor" way to disable > it, as suggested by asomers@. > > A restart of the daemon will always do a full reload to work around any > reload failures. > > rick > > ________________________________________ > From: Alan Somers > Sent: Monday, June 3, 2019 6:28:51 PM > To: Peter Eriksson > Cc: Rick Macklem; freebsd-fs@freebsd.org > Subject: Re: RFC: should an incremental reload of exports for mountd be optional? > > I think that it should be always enabled. If the only reason not to > is a fear of bugs in the new method, then the old method can be > selected by some back-doorish workaround, like an environment > variable. > -Alan > > On Mon, Jun 3, 2019 at 4:16 PM Peter Eriksson wrote: > > > > My vote goes to: > > > > Enabled by default (with an option to disable it in case problems pop up). > > > > - Peter > > > > > > > On 31 May 2019, at 23:50, Rick Macklem wrote: > > > > > > Hi, > > > > > > I have created a patch for PR#237860 that improves the time it takes to reload > > > the exports file(s) for an NFS file server from seconds->milliseconds by only doing > > > system calls for the changes to the exports file(s). (Assumes each reload includes > > > changes to only a small fraction of the entries.) > > > > > > I made it a non-default option of "-I", but asomers@ asked why it needed to be > > > optional. > > > > > > Basically, I made it optional because I felt the patch might still be buggy and not > > > handle some case of an exports file change that I missed. > > > > > > However, I can see the argument of making it non-optional (or optional but enabled > > > by default) so that sysadmins don't need to add "-I" to avoid long periods where the > > > nfsd threads are suspended. > > > If it is broken, the deamon would need to be restarted to do a full reload, but that > > > would also be the case if a sysadmin specified the "-I" option. > > > > > > So, the question is... "do you think this should be an option or just always enabled?". > > > > > > Thanks , rick > > > _______________________________________________ > > > freebsd-fs@freebsd.org mailing list > > > https://lists.freebsd.org/mailman/listinfo/freebsd-fs > > > To unsubscribe, send any mail to "freebsd-fs-unsubscribe@freebsd.org" > > > > _______________________________________________ > > freebsd-fs@freebsd.org mailing list > > https://lists.freebsd.org/mailman/listinfo/freebsd-fs > > To unsubscribe, send any mail to "freebsd-fs-unsubscribe@freebsd.org" From owner-freebsd-fs@freebsd.org Tue Jun 4 00:07:58 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CD4DF15C1F65 for ; Tue, 4 Jun 2019 00:07:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 460167607E for ; Tue, 4 Jun 2019 00:07:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id F063D15C1F64; Tue, 4 Jun 2019 00:07:56 +0000 (UTC) Delivered-To: fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B195115C1F63 for ; Tue, 4 Jun 2019 00:07:56 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4D0287607B for ; Tue, 4 Jun 2019 00:07:56 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 8D3D51E8C1 for ; Tue, 4 Jun 2019 00:07:55 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x5407trD008683 for ; Tue, 4 Jun 2019 00:07:55 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x5407tIa008675 for fs@FreeBSD.org; Tue, 4 Jun 2019 00:07:55 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 147881] [zfs] [patch] ZFS "sharenfs" doesn't allow different "exports" options for different hosts Date: Tue, 04 Jun 2019 00:07:54 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: rmacklem@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Jun 2019 00:07:58 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D147881 --- Comment #16 from Rick Macklem --- Personally, I think Quentin Rameau's patch is all you need. I don't think embedded comments in the sharenfs property are needed and it just makes the patch much more involved. The one slightly scary thing about it is that "; ;" is allowed and results in the file system being exported read/write to the world, because it will generate a line with just the mountpoint in it. (I never use ZFS, so I don't know if a blank sharenfs property is allowed and results in the same thing?) It might be safer to not allow that case? One other change would be to take the "const" off the argument for translate_opts() and don't have it strlcpy() the shareopts, since they have already be copied by the caller with Quentin's patch. I don't recommend changing the exports(5) syntax for two reasons: 1- Any change must be 100% backwards compatible or it is a POLA violation and can't go in FreeBSD. (ie. Any exports file that worked before must still work and provide the same semantics.) 2 - Parsing of exports file(s) is done by a function called get_exportlist_one() in src/usr.sbin/mountd/mountd.c and, if you look at it, you will find the code convoluted and difficult to modify without breaking it. I'm not a ZFS guy, so I can't help w.r.t. getting this in FreeBSD. I'd suggest you post on a FreeBSD mailing list about this and hope that someone on the ZFS side is interested in getting the patch in. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Tue Jun 4 00:30:16 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AFA6315C243A for ; Tue, 4 Jun 2019 00:30:16 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from CAN01-QB1-obe.outbound.protection.outlook.com (mail-eopbgr660074.outbound.protection.outlook.com [40.107.66.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "GlobalSign Organization Validation CA - SHA256 - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 51BCF767A2; Tue, 4 Jun 2019 00:30:14 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from YQXPR01MB3128.CANPRD01.PROD.OUTLOOK.COM (52.132.93.160) by YQXPR01MB2342.CANPRD01.PROD.OUTLOOK.COM (52.132.91.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1943.22; Tue, 4 Jun 2019 00:30:13 +0000 Received: from YQXPR01MB3128.CANPRD01.PROD.OUTLOOK.COM ([fe80::f9fe:559f:fdc:9e5a]) by YQXPR01MB3128.CANPRD01.PROD.OUTLOOK.COM ([fe80::f9fe:559f:fdc:9e5a%3]) with mapi id 15.20.1943.018; Tue, 4 Jun 2019 00:30:13 +0000 From: Rick Macklem To: Alan Somers CC: Peter Eriksson , "freebsd-fs@freebsd.org" Subject: Re: RFC: should an incremental reload of exports for mountd be optional? Thread-Topic: RFC: should an incremental reload of exports for mountd be optional? Thread-Index: AQHVF/n5fA6XHqwN4UmNwJInW+ldyaaKg72AgAADv4CAAAwEh4AAAiAAgAAOB/w= Date: Tue, 4 Jun 2019 00:30:13 +0000 Message-ID: References: , In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8aa3e1d1-c2a6-4dc4-8dad-08d6e883cf22 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600148)(711020)(4605104)(1401327)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:YQXPR01MB2342; x-ms-traffictypediagnostic: YQXPR01MB2342: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0058ABBBC7 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(346002)(39860400002)(366004)(376002)(396003)(199004)(189003)(6916009)(786003)(316002)(2906002)(52536014)(296002)(186003)(229853002)(99286004)(9686003)(446003)(476003)(54906003)(486006)(14444005)(5660300002)(7696005)(14454004)(68736007)(6436002)(46003)(478600001)(55016002)(11346002)(102836004)(256004)(71200400001)(74482002)(6246003)(71190400001)(33656002)(53936002)(74316002)(66476007)(66556008)(64756008)(66446008)(66946007)(76116006)(6506007)(86362001)(8676002)(305945005)(73956011)(25786009)(76176011)(8936002)(81166006)(53546011)(4326008)(81156014); DIR:OUT; SFP:1101; SCL:1; SRVR:YQXPR01MB2342; H:YQXPR01MB3128.CANPRD01.PROD.OUTLOOK.COM; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: uoguelph.ca does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 9ul4YRe7VAB0kqzXD8WlKCEDMusMMJ/D30QvStREAQeo+pXn1R8/wTviKxA9Bn5ULOQ8o52HDF704Vhvm7S82pmQBLnnwfcMBHZ4qEorQtHzo+YIsCRtAaGuzGD3iNVpkE67N9CrbxwhwZlhE2n3msdti8WnmYdZDdiM0IN75Fs76dbivRpPyRaOiXKurhTFyke6WjGy3Erw6U3evj8ipzKjnsqBJn2ilER9dDOSP2pIUnxCogIVy+Zjs0MfWus8p4bY1oPH1uUAQIEEETldu71PMpUmRv5VdAbBedo0lMisCBkfGn7yZ3iCm1NFJuyoTD2Pi1OxMRIs5/+WCkL8/1Lbv/hrbcBE+aJWHOxjRVOV/d0JO/UFfuFBlYPOwmTGMstDLmLg7vuzt+gl1U7Q9jv0PhQPdzHO2ebogTv4NHc= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: uoguelph.ca X-MS-Exchange-CrossTenant-Network-Message-Id: 8aa3e1d1-c2a6-4dc4-8dad-08d6e883cf22 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jun 2019 00:30:13.1622 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be62a12b-2cad-49a1-a5fa-85f4f3156a7d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rmacklem@uoguelph.ca X-MS-Exchange-Transport-CrossTenantHeadersStamped: YQXPR01MB2342 X-Rspamd-Queue-Id: 51BCF767A2 X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of rmacklem@uoguelph.ca designates 40.107.66.74 as permitted sender) smtp.mailfrom=rmacklem@uoguelph.ca X-Spamd-Result: default: False [-3.24 / 15.00]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:40.107.0.0/16]; FROM_HAS_DN(0.00)[]; MIME_GOOD(-0.10)[text/plain]; SUBJECT_ENDS_QUESTION(1.00)[]; DMARC_NA(0.00)[uoguelph.ca]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MX_GOOD(-0.01)[cached: mx2.hc184-76.ca.iphmx.com]; NEURAL_HAM_SHORT(-0.92)[-0.915,0]; RCVD_IN_DNSWL_NONE(0.00)[74.66.107.40.list.dnswl.org : 127.0.3.0]; IP_SCORE(-1.02)[ipnet: 40.64.0.0/10(-2.84), asn: 8075(-2.18), country: US(-0.06)]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:8075, ipnet:40.64.0.0/10, country:US]; RCVD_TLS_LAST(0.00)[] X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Jun 2019 00:30:17 -0000 Alan Somers wrote: >Will a restart of the daemon cause clients to get HUPped if they try >to access an exported filesystem while mountd is restarting? >-Alan I'm not sure what you mean by HUPped, but during a restart of mountd, extan= t mounts should continue to work. What will fail during the mountd restart is new NFSv3 mount attempts, becau= se they won't be able to talk to mountd via the Mount protocol. Usually the failure will be rpcbind not having MOUNTPROG registered. Then a retry of the mount (which will happen after something like 30sec if = you don't C the mount command) will succeed, assuming mountd has restarte= d. Unmounts will complain the MOUNTPROG wasn't registered, but the umount will work anyhow. Then "showmount", which is never guaranteed to return correct info, will re= port it as still mounted. Since "showmount" never knows about NFSv4 mounts and just returns its guess at what is mounted, I don't find it useful anyhow. NFSv4 mounts should continue to work when mountd isn't running, since they= don't use the Mount protocol. And, since they don't use the Mount protocol= , "showmount" never knows about them. So, I restart can cause some disruption, but they are mostly just delays wh= en doing new NFSv3 mounts on the server. rick On Mon, Jun 3, 2019 at 5:13 PM Rick Macklem wrote: > > Thanks everyone for your comments. I just committed the patch with > the incremental reload of exports always enabled. > If people run into problems, I can add some "backdoor" way to disable > it, as suggested by asomers@. > > A restart of the daemon will always do a full reload to work around any > reload failures. > > rick > [stuff snipped]= From owner-freebsd-fs@freebsd.org Tue Jun 4 00:44:14 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 881A115C2A57 for ; Tue, 4 Jun 2019 00:44:14 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com [209.85.167.65]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8A12C77332 for ; Tue, 4 Jun 2019 00:44:13 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-lf1-f65.google.com with SMTP id u10so7993986lfm.12 for ; Mon, 03 Jun 2019 17:44:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4kTTZxKA5JOi7VZ68fZCUyGvtUZlVZm9QjJviv5nxgE=; b=L2tA1LgTqvgPOOVr1FaZASGGalAGgRVTgNCGerfjOB2LT26Skm9RmGrpo21uj4jrXq 1F/oWP/EV/wLRJkdiFT9dQd6lmJhNHzcG3V8U76Bm6bQRfTQ7AS4fy9gxNBoHjAWa4As NcpMFPn4yyQtAUTNbW6cGdhlvbKmGBN80rqt4miezbo0tCQmkuqlEmL0kR3Cub5RAKRz RKFCPUXW05AtjN41PYUOVV54h+lPCgBm6EJn6VLvODbogOInNwEraRkAfpVpwRb1waxL o5bLI8D1JPkW9beOzYqztSAggUH/LHXM0Rc5kPcgvWSCwlJpn98Qq+ePre55Pv/RsKEy 0Nhw== X-Gm-Message-State: APjAAAXohFDpIMuYW0vxI03N/BzL/Kme1MI1dKSm5sNethXrVqsjOdM5 UqCNQUdnxxEqPZs0HWXesgA5qhM+sEKKiFVUpVs= X-Google-Smtp-Source: APXvYqzlDBRcXWfQnT3EcbpVknlKs9n+Fd03wvzS65NG3UK2ULnpoOMIjLjGAWsdATejc1w43+2nz0EGHoYOEZKmkwU= X-Received: by 2002:a19:671c:: with SMTP id b28mr14962859lfc.164.1559609045951; Mon, 03 Jun 2019 17:44:05 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Alan Somers Date: Mon, 3 Jun 2019 18:43:54 -0600 Message-ID: Subject: Re: RFC: should an incremental reload of exports for mountd be optional? To: Rick Macklem Cc: Peter Eriksson , "freebsd-fs@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 8A12C77332 X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of asomers@gmail.com designates 209.85.167.65 as permitted sender) smtp.mailfrom=asomers@gmail.com X-Spamd-Result: default: False [-3.20 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; NEURAL_HAM_SHORT(-0.94)[-0.936,0]; FORGED_SENDER(0.30)[asomers@freebsd.org,asomers@gmail.com]; IP_SCORE(-1.25)[ip: (-0.54), ipnet: 209.85.128.0/17(-3.39), asn: 15169(-2.29), country: US(-0.06)]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[asomers@freebsd.org,asomers@gmail.com]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; SUBJECT_ENDS_QUESTION(1.00)[]; PREVIOUSLY_DELIVERED(0.00)[freebsd-fs@freebsd.org]; DMARC_NA(0.00)[freebsd.org]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[65.167.85.209.list.dnswl.org : 127.0.5.0]; RCVD_TLS_LAST(0.00)[]; RWL_MAILSPIKE_POSSIBLE(0.00)[65.167.85.209.rep.mailspike.net : 127.0.0.17]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Jun 2019 00:44:14 -0000 On Mon, Jun 3, 2019 at 6:30 PM Rick Macklem wrote: > > Alan Somers wrote: > >Will a restart of the daemon cause clients to get HUPped if they try > >to access an exported filesystem while mountd is restarting? > >-Alan > I'm not sure what you mean by HUPped, but during a restart of mountd, extant > mounts should continue to work. Perhaps it wasn't SIGHUP, but I recall that a few years ago there was a problem where all NFS I/O would fail while mountd was reloading. I think it's the problem that you fixed in r241568. > > What will fail during the mountd restart is new NFSv3 mount attempts, because > they won't be able to talk to mountd via the Mount protocol. Usually the > failure will be rpcbind not having MOUNTPROG registered. > Then a retry of the mount (which will happen after something like 30sec if you > don't C the mount command) will succeed, assuming mountd has restarted. > Unmounts will complain the MOUNTPROG wasn't registered, but the umount > will work anyhow. > > Then "showmount", which is never guaranteed to return correct info, will report it > as still mounted. Since "showmount" never knows about NFSv4 mounts and just > returns its guess at what is mounted, I don't find it useful anyhow. > > NFSv4 mounts should continue to work when mountd isn't running, since they don't use the Mount protocol. And, since they don't use the Mount protocol, "showmount" > never knows about them. > > So, I restart can cause some disruption, but they are mostly just delays when doing > new NFSv3 mounts on the server. > > rick > > On Mon, Jun 3, 2019 at 5:13 PM Rick Macklem wrote: > > > > Thanks everyone for your comments. I just committed the patch with > > the incremental reload of exports always enabled. > > If people run into problems, I can add some "backdoor" way to disable > > it, as suggested by asomers@. > > > > A restart of the daemon will always do a full reload to work around any > > reload failures. > > > > rick > > > [stuff snipped] From owner-freebsd-fs@freebsd.org Tue Jun 4 02:03:08 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CC7C515C4842 for ; Tue, 4 Jun 2019 02:03:08 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from CAN01-TO1-obe.outbound.protection.outlook.com (mail-eopbgr670064.outbound.protection.outlook.com [40.107.67.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "GlobalSign Organization Validation CA - SHA256 - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9833081570; Tue, 4 Jun 2019 02:03:07 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from YQXPR01MB3128.CANPRD01.PROD.OUTLOOK.COM (52.132.93.160) by YQXPR01MB0279.CANPRD01.PROD.OUTLOOK.COM (10.165.131.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1943.21; Tue, 4 Jun 2019 02:03:06 +0000 Received: from YQXPR01MB3128.CANPRD01.PROD.OUTLOOK.COM ([fe80::f9fe:559f:fdc:9e5a]) by YQXPR01MB3128.CANPRD01.PROD.OUTLOOK.COM ([fe80::f9fe:559f:fdc:9e5a%3]) with mapi id 15.20.1943.018; Tue, 4 Jun 2019 02:03:05 +0000 From: Rick Macklem To: Alan Somers CC: Peter Eriksson , "freebsd-fs@freebsd.org" Subject: Re: RFC: should an incremental reload of exports for mountd be optional? Thread-Topic: RFC: should an incremental reload of exports for mountd be optional? Thread-Index: AQHVF/n5fA6XHqwN4UmNwJInW+ldyaaKg72AgAADv4CAAAwEh4AAAiAAgAAOB/yAAAmQAIAAExYI Date: Tue, 4 Jun 2019 02:03:05 +0000 Message-ID: References: , In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1999d52e-8cf0-4cb9-d13e-08d6e890c8b1 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:YQXPR01MB0279; x-ms-traffictypediagnostic: YQXPR01MB0279: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0058ABBBC7 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(376002)(136003)(346002)(366004)(39860400002)(189003)(199004)(71200400001)(68736007)(296002)(81156014)(4744005)(486006)(8676002)(316002)(54906003)(81166006)(8936002)(71190400001)(786003)(14444005)(102836004)(6506007)(55016002)(256004)(76176011)(46003)(11346002)(476003)(186003)(74482002)(5660300002)(6916009)(6246003)(73956011)(7696005)(446003)(76116006)(305945005)(14454004)(52536014)(6436002)(66556008)(64756008)(66446008)(66946007)(66476007)(229853002)(74316002)(25786009)(4326008)(99286004)(9686003)(478600001)(2906002)(86362001)(33656002)(53936002); DIR:OUT; SFP:1101; SCL:1; SRVR:YQXPR01MB0279; H:YQXPR01MB3128.CANPRD01.PROD.OUTLOOK.COM; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: uoguelph.ca does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 2aiypY8IuN/YWX7tN52wqR4JBosMnAi5mB7rjjMQ18Xa+P5it+O6xSEKE+tSKIWYHZ+sswvipASgq3/CBAq0uxeCyLMv7id+QDLZHIgoGvpfIUhRg/yT975RrJgMCOj9zddx/2m8FdKuzBx0AsDYlLKBXrBPmDS0ACPdTXCquvcpJ99/9IcKc2/6FVW85jlcofFwTAZRhg1Ea3IRSOxi1pRY4vPsCcd9eoUT7a5BfVJHbyqUbKV7FwiIO53jJ59iQ2A2/DO3yBDudktXxeH/LWiLXseQhfst1rAk6ej6i3m/AjfvyxYbu8Mo3iHLp9p/LfywVhYyaG8UCrpqEnFFbK69xRAIGeyTDWslV354fVXmDM4p6v0X1OI0LLZo8+l6Ybpmdsp9705NCEGSnyb4CIiNbFchPJlXqzOI/s5r2Ko= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: uoguelph.ca X-MS-Exchange-CrossTenant-Network-Message-Id: 1999d52e-8cf0-4cb9-d13e-08d6e890c8b1 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jun 2019 02:03:05.8155 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be62a12b-2cad-49a1-a5fa-85f4f3156a7d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rmacklem@uoguelph.ca X-MS-Exchange-Transport-CrossTenantHeadersStamped: YQXPR01MB0279 X-Rspamd-Queue-Id: 9833081570 X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of rmacklem@uoguelph.ca designates 40.107.67.64 as permitted sender) smtp.mailfrom=rmacklem@uoguelph.ca X-Spamd-Result: default: False [-0.37 / 15.00]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; NEURAL_HAM_MEDIUM(-0.84)[-0.844,0]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:40.107.0.0/16]; FROM_HAS_DN(0.00)[]; MIME_GOOD(-0.10)[text/plain]; SUBJECT_ENDS_QUESTION(1.00)[]; DMARC_NA(0.00)[uoguelph.ca]; NEURAL_SPAM_SHORT(0.46)[0.464,0]; NEURAL_HAM_LONG(-0.68)[-0.677,0]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MX_GOOD(-0.01)[cached: mx2.hc184-76.ca.iphmx.com]; RCVD_IN_DNSWL_NONE(0.00)[64.67.107.40.list.dnswl.org : 127.0.3.0]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[] X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Jun 2019 02:03:09 -0000 Alan Somers wrote: >On Mon, Jun 3, 2019 at 6:30 PM Rick Macklem wrote: >> >> Alan Somers wrote: >> >Will a restart of the daemon cause clients to get HUPped if they try >> >to access an exported filesystem while mountd is restarting? >> >-Alan >> I'm not sure what you mean by HUPped, but during a restart of mountd, ex= tant >> mounts should continue to work. > >Perhaps it wasn't SIGHUP, but I recall that a few years ago there was >a problem where all NFS I/O would fail while mountd was reloading. I >think it's the problem that you fixed in r241568. So long as the "-S" option is being specified, there shouldn't be a problem= . With "-S" both the initial load when started/restarted and a reload due to = SIGHUP will suspend the nfsd threads while deleting/loading exports in the kernel. The patch just committed was mainly to make the duration of suspension duri= ng a reload much shorter. rick [stuff snipped] From owner-freebsd-fs@freebsd.org Wed Jun 5 05:38:55 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0950715C603D for ; Wed, 5 Jun 2019 05:38:55 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from CAN01-QB1-obe.outbound.protection.outlook.com (mail-eopbgr660050.outbound.protection.outlook.com [40.107.66.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "GlobalSign Organization Validation CA - SHA256 - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7A4976CC81; Wed, 5 Jun 2019 05:38:53 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from YQXPR01MB3128.CANPRD01.PROD.OUTLOOK.COM (52.132.93.160) by YQXPR01MB3736.CANPRD01.PROD.OUTLOOK.COM (52.132.92.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1965.12; Wed, 5 Jun 2019 05:38:51 +0000 Received: from YQXPR01MB3128.CANPRD01.PROD.OUTLOOK.COM ([fe80::f9fe:559f:fdc:9e5a]) by YQXPR01MB3128.CANPRD01.PROD.OUTLOOK.COM ([fe80::f9fe:559f:fdc:9e5a%3]) with mapi id 15.20.1943.018; Wed, 5 Jun 2019 05:38:51 +0000 From: Rick Macklem To: Alexander Motin , "mmacy@ixsystems.com" , "ryan@ixsystems.com" , "pjd@freebsd.org" , Peter Eriksson CC: "freebsd-fs@freebsd.org" Subject: RFC: patching fsshare in ZFS Thread-Topic: RFC: patching fsshare in ZFS Thread-Index: AQHVG2D0yISfnX1rEEaIeN2nOcwYOA== Date: Wed, 5 Jun 2019 05:38:51 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c50f9637-af5e-4778-e0bc-08d6e9781740 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:YQXPR01MB3736; x-ms-traffictypediagnostic: YQXPR01MB3736: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 00594E8DBA x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(39860400002)(396003)(346002)(376002)(136003)(199004)(189003)(55016002)(256004)(14444005)(478600001)(53936002)(14454004)(316002)(786003)(74482002)(4326008)(25786009)(99286004)(5660300002)(2201001)(52536014)(486006)(6506007)(71190400001)(71200400001)(7696005)(305945005)(64756008)(66446008)(66556008)(76116006)(73956011)(46003)(476003)(33656002)(68736007)(8676002)(186003)(86362001)(66476007)(66946007)(2501003)(6436002)(81156014)(81166006)(110136005)(9686003)(102836004)(8936002)(2906002)(74316002); DIR:OUT; SFP:1101; SCL:1; SRVR:YQXPR01MB3736; H:YQXPR01MB3128.CANPRD01.PROD.OUTLOOK.COM; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: uoguelph.ca does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: c9IFICl+02ZPruxHJVeg+KRf+GvkJcZQpwjCsk//tU1KK6PPcQ1A33gHvv9sQj/1HrJlzBa3ixIzSupGnsAaIV7eIsDY+6Pr3aSBpavPBunVHp+0DtZ0mkT9xq1HLPcDeuBpewadKUMQas8+jDxq468YyhUx81OK2VaCWKDBmOv+ilZskNUTuaccPKDwLLc/JYjHnF+H8q26GhCqilpm9KuLXEobSGOHXYvcxfDNuvikGMfqwUvgFXZq6Iqgj0YlsKv/lKy/U3vpTxxIgKyKILfNQbo6Zt/xCxelfghDypOR+1BTxSSWuTKMXkvz9qmfmizY6Wj27918P22PaLT03w88aqICaq22QQE9Pg+wC/ubGbznL4DqxszZ1taMap0hzrq6DzooLlkfry4YGLcJ0GOTlrcsX6B38A9wV05ibuE= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: uoguelph.ca X-MS-Exchange-CrossTenant-Network-Message-Id: c50f9637-af5e-4778-e0bc-08d6e9781740 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jun 2019 05:38:51.4279 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be62a12b-2cad-49a1-a5fa-85f4f3156a7d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rmacklem@uoguelph.ca X-MS-Exchange-Transport-CrossTenantHeadersStamped: YQXPR01MB3736 X-Rspamd-Queue-Id: 7A4976CC81 X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of rmacklem@uoguelph.ca designates 40.107.66.50 as permitted sender) smtp.mailfrom=rmacklem@uoguelph.ca X-Spamd-Result: default: False [-1.41 / 15.00]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; NEURAL_HAM_MEDIUM(-0.97)[-0.970,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:40.107.0.0/16]; NEURAL_HAM_LONG(-0.97)[-0.967,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[uoguelph.ca]; RCPT_COUNT_FIVE(0.00)[6]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_SPAM_SHORT(0.83)[0.832,0]; MX_GOOD(-0.01)[mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com]; RCVD_IN_DNSWL_NONE(0.00)[50.66.107.40.list.dnswl.org : 127.0.3.0]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[] X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Jun 2019 05:38:55 -0000 Hi, First off, sorry for sending this to all you guys. (I used to send this stu= ff to Josh P, but I'm not sure which of you guys are best for FreeNAS/NFS related stuff. If you let me know who you'd rather I email, then I'll only bother them;-) I try to avoid ZFS like the plague, but there are a couple of things relate= d the nfsshare property that I think would be nice to patch. 1 - There is a simple patch by Quentin Rameau in PR#147881 that adds suppor= t for ";" to be used as a separator in the nfsshare property, so that m= ultiple lines of exports can be generated. For example, for an nfsshare property of "-maproot=3Droot host1; -ro host2", the following two exports lines w= ould be generated (assuming /tank/vol1 is the file system mountpoint) /tank/vol1 -maproot=3Droot host1 /tank/vol1 -ro host2 Right now, I think the nfsshare property only generates one line per f= ile system, which has to apply to all clients, giving them all the same options. (I made a couple of comments related to this patch in the PR.) One question is whether an nfsshare property that is a null string or = just whitespace is currently allowed? (I couldn't see anything in fsshare()= that disallows it, but I don't know anything about the code used to set the= property.) 2 - Peter has some NFS servers with 20000-72000+ file systems being exporte= d. The current code in fsshare.c copies the exports file and then append= s the new entry for a file system and then replaces the exports file with the = new one. I think this file copying happens for every file system, which seems= like a lot of overhead. (I forget what Peter said w.r.t. how long this takes, b= ut I think it was quite a while.) My guess is that Pawel did this so that the update to the file would= happen atomically. It seems to me that if mountd held a read lock on the export file wh= ile reading it and fsshare() held a write lock on the file while appending the new = entry, that the file copying could be avoided? - The main problem I see w.r.t. doing this is that an old mountd bin= ary that doesn't read lock the file could be broken by the fsshare() change. --> One way to avoid this would be to have the new mountd write mo= re than just the pid in the MOUNTD_PID file so that fsshare() could = tell if mountd was going to be read locking the file. OR Just don't MFC the change and assume that the new mountd wou= ld be released when the new fsshare() is (in FreeBSD13?). Anyhow, I can tweak mountd.c and fsshare.c, but that's as far as I can take= it. Others would need to do testing and whatever it takes to get a change to fs= share.c into the ZFS sources. So, what do you think about this? rick From owner-freebsd-fs@freebsd.org Wed Jun 5 07:50:12 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 05DF015C8B28 for ; Wed, 5 Jun 2019 07:50:12 +0000 (UTC) (envelope-from pen@lysator.liu.se) Received: from mail.lysator.liu.se (mail.lysator.liu.se [IPv6:2001:6b0:17:f0a0::3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7E402703B2; Wed, 5 Jun 2019 07:50:11 +0000 (UTC) (envelope-from pen@lysator.liu.se) Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id 7AE1940020; Wed, 5 Jun 2019 09:50:07 +0200 (CEST) Received: from [IPv6:2001:6b0:17:fc08:44fc:d1e1:765d:527c] (unknown [IPv6:2001:6b0:17:fc08:44fc:d1e1:765d:527c]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id F2AFA4001D; Wed, 5 Jun 2019 09:50:06 +0200 (CEST) From: Peter Eriksson Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: RFC: patching fsshare in ZFS Date: Wed, 5 Jun 2019 09:50:06 +0200 References: To: Rick Macklem , Alexander Motin , "mmacy@ixsystems.com" , "ryan@ixsystems.com" , "pjd@freebsd.org" , "freebsd-fs@freebsd.org" In-Reply-To: Message-Id: X-Mailer: Apple Mail (2.3445.104.11) X-Virus-Scanned: ClamAV using ClamSMTP X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Jun 2019 07:50:12 -0000 Hi all! =20 I=E2=80=99ve been experimenting a little with adding support for a = simple BerkelyDB-based =E2=80=9Cexports=E2=80=9D database to mountd in = order to speed things up for the ZFS share code. The changes to mountd = are fairly simple, and the corresponding stuff was pretty simple to add = to the ZFS code too last I tried it. Speeds things up quite a bit - no = need to do linear searches through the /etc/zfs/exports file and no need = to rewrite the file for changes either=E2=80=A6 With N*10000 NFS shared = filesystems like we do this can be pretty nice to have.=20 My current DB-based code supports multiple exports entries per filsystem = by separating the =E2=80=9Crows=E2=80=9D in the database entry for a = filesystem with NUL characters. Let me know if there is some interest in this for others than just me. - Peter > 2 - Peter has some NFS servers with 20000-72000+ file systems being = exported. > The current code in fsshare.c copies the exports file and then = appends the new > entry for a file system and then replaces the exports file with = the new one. > I think this file copying happens for every file system, which = seems like a lot > of overhead. (I forget what Peter said w.r.t. how long this = takes, but I think it > was quite a while.) > My guess is that Pawel did this so that the update to the file = would happen > atomically. > It seems to me that if mountd held a read lock on the export = file while reading it > and fsshare() held a write lock on the file while appending the = new entry, that > the file copying could be avoided? > - The main problem I see w.r.t. doing this is that an old mountd = binary that doesn't > read lock the file could be broken by the fsshare() change. > --> One way to avoid this would be to have the new mountd = write more than > just the pid in the MOUNTD_PID file so that fsshare() = could tell if mountd was > going to be read locking the file. > OR > Just don't MFC the change and assume that the new mountd = would be > released when the new fsshare() is (in FreeBSD13?). >=20 > Anyhow, I can tweak mountd.c and fsshare.c, but that's as far as I can = take it. >=20 > Others would need to do testing and whatever it takes to get a change = to fsshare.c > into the ZFS sources. >=20 > So, what do you think about this? rick >=20 >=20 From owner-freebsd-fs@freebsd.org Wed Jun 5 12:09:01 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 770EF15ABABD; Wed, 5 Jun 2019 12:09:01 +0000 (UTC) (envelope-from lev@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1A4C5804B7; Wed, 5 Jun 2019 12:09:01 +0000 (UTC) (envelope-from lev@FreeBSD.org) Received: from onlyone.not-for.work (onlyone.not-for.work [IPv6:2a01:4f8:201:6350::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: lev/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id CE808B80; Wed, 5 Jun 2019 12:09:00 +0000 (UTC) (envelope-from lev@FreeBSD.org) Received: from lion.home.serebryakov.spb.ru (unknown [IPv6:2001:470:923f:1:6d39:7af7:f5e8:48b6]) (Authenticated sender: lev@serebryakov.spb.ru) by onlyone.not-for.work (Postfix) with ESMTPSA id 55AFD1B34B; Wed, 5 Jun 2019 15:08:57 +0300 (MSK) Date: Wed, 5 Jun 2019 15:08:56 +0300 From: Lev Serebryakov Reply-To: lev@FreeBSD.org Organization: FreeBSD Message-ID: <1644469784.20190605150856@serebryakov.spb.ru> To: Slawa Olhovchenkov , Ian Lepore CC: freebsd-fs@freebsd.org, freebsd-hackers@FreeBSD.org, Alexander Motin Subject: Re: Commit r345200 (new ARC reclamation threads) looks suspicious to me. In-Reply-To: <20190531151202.GG47119@zxy.spb.ru> References: <55989579-a228-498e-2842-453cad6f315f@FreeBSD.org> <174f71126ca39907370a8904c07546b712ad91b9.camel@freebsd.org> <20190531151202.GG47119@zxy.spb.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 1A4C5804B7 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.96 / 15.00]; local_wl_from(0.00)[FreeBSD.org]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.96)[-0.959,0]; ASN(0.00)[asn:11403, ipnet:96.47.64.0/20, country:US] X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Jun 2019 12:09:01 -0000 Hello Slawa, Friday, May 31, 2019, 6:12:02 PM, you wrote: > What about arc_no_grow, for example? > arc_no_grow set in arc_reap_cb_check(), called from arc_reap_zthr > thread and in arc_lowmem(). > arc_no_grow test in arc_adapt(), called from > arc_read()/arc_get_data_impl() called from many unsynced thread. > How synced visibility of this varibale? I don;t like this one either. It is set under mutex (t->zthr_lock of reap thread/timer), but looks like tit is read by many other threads... And `arc_lowmem()` uses `arc_adjust_lock`... -- Best regards, Lev mailto:lev@FreeBSD.org From owner-freebsd-fs@freebsd.org Wed Jun 5 16:53:57 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 98B4D15B32F9 for ; Wed, 5 Jun 2019 16:53:57 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7F77A8ACB6 for ; Wed, 5 Jun 2019 16:53:56 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-lf1-f46.google.com with SMTP id m15so19620605lfh.4 for ; Wed, 05 Jun 2019 09:53:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=jYypzL7l6g2FeKGCPxnMtycWbtnzVLrAet2wBlqikuM=; b=jfRA3sL3skB4PEXPCIbI+QJzWGh/JnS2g+HVRBflWnXnfa93O65d0icbsztTV2jM3O aYKoQL3oyLPneCxSi8ozjybq3sD5Zg6ZVpz5VwWiSA2+pW2QePmM6fRCXbWxr0R1iik+ SyqB9p67hGauLHC5kIVAJ/lZv/PlW7SEYMYQsnronL+3nq6BkTmcB6pxHfmDLTjTcux0 Q8EA9tSofDbO8nJjQepOnAeHbXbEU/mNMrvjq59XRy17fUrJBYALV7ar1XpU/ujUcRP5 I0wv7dAuQtIX3DR31nBlzukvu5J3TJVgbpjlylSN66XU/ArgnuNV1hl0BC8GoPZGn7f5 QVyg== X-Gm-Message-State: APjAAAXXIFKHtUXcfCFUaPzwT49v4cwU0Gz569p8sW+6fiiv/bh/lxsv LYgez8nBoM0YQ71hdKHuu2DTvF8iY6tnHoRZtSp3Ag== X-Google-Smtp-Source: APXvYqyOAprPhtMIyYdIQ3KY9LqmyuML4g+hjVFleoYIKEhaNEzqM2u0DRZ5xIVdb8YKevEgktlYPdLuSgP3bMv8C+c= X-Received: by 2002:ac2:5324:: with SMTP id f4mr3683722lfh.156.1559752186686; Wed, 05 Jun 2019 09:29:46 -0700 (PDT) MIME-Version: 1.0 From: Alan Somers Date: Wed, 5 Jun 2019 10:29:35 -0600 Message-ID: Subject: Regression test for vn_io_fault To: freebsd-fs Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 7F77A8ACB6 X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of asomers@gmail.com designates 209.85.167.46 as permitted sender) smtp.mailfrom=asomers@gmail.com X-Spamd-Result: default: False [-3.94 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; RCVD_COUNT_TWO(0.00)[2]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-fs@freebsd.org]; DMARC_NA(0.00)[freebsd.org]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_TRACE(0.00)[0:+]; TO_DN_ALL(0.00)[]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; NEURAL_HAM_SHORT(-0.65)[-0.651,0]; RCVD_IN_DNSWL_NONE(0.00)[46.167.85.209.list.dnswl.org : 127.0.5.0]; RCVD_TLS_LAST(0.00)[]; FORGED_SENDER(0.30)[asomers@freebsd.org,asomers@gmail.com]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[asomers@freebsd.org,asomers@gmail.com]; IP_SCORE(-1.28)[ip: (-0.63), ipnet: 209.85.128.0/17(-3.39), asn: 15169(-2.30), country: US(-0.06)]; TO_DOM_EQ_FROM_DOM(0.00)[] X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Jun 2019 16:53:57 -0000 r236321 added vn_io_fault(), a mechanism for avoiding lock order reversals when a process reads from one file into a mmap()ed buffer backed by another file. From the description in the comments of vn_io_fault() it seems like it would be possible to write a reliable test that would trigger the LOR. But I can't find any evidence in svn, or bugzilla of such a test program. None in Phabricator either, which probably wasn't even running when that commit was made. Did anybody ever write a test program? If so, I volunteer to ATFify it. -Alan From owner-freebsd-fs@freebsd.org Wed Jun 5 18:06:01 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7152815B4AD5 for ; Wed, 5 Jun 2019 18:06:01 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id BD65A8D216; Wed, 5 Jun 2019 18:06:00 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id x55I5qff040221 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 5 Jun 2019 21:05:55 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua x55I5qff040221 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id x55I5qUX040220; Wed, 5 Jun 2019 21:05:52 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Wed, 5 Jun 2019 21:05:52 +0300 From: Konstantin Belousov To: Alan Somers Cc: freebsd-fs Subject: Re: Regression test for vn_io_fault Message-ID: <20190605180552.GX75280@kib.kiev.ua> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.0 (2019-05-25) X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on tom.home X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Jun 2019 18:06:01 -0000 On Wed, Jun 05, 2019 at 10:29:35AM -0600, Alan Somers wrote: > r236321 added vn_io_fault(), a mechanism for avoiding lock order > reversals when a process reads from one file into a mmap()ed buffer > backed by another file. From the description in the comments of > vn_io_fault() it seems like it would be possible to write a reliable > test that would trigger the LOR. But I can't find any evidence in > svn, or bugzilla of such a test program. None in Phabricator either, > which probably wasn't even running when that commit was made. Did > anybody ever write a test program? If so, I volunteer to ATFify it. The test program is in tools/test/upsdl. I object against removing non-atf version on principle, atf tests are not debuggable. Also this is racing test, so it is not as simple as doing N runs where N is fixed. Anyway, test for the ups@ race is included into stress2, where it belongs. From owner-freebsd-fs@freebsd.org Wed Jun 5 18:58:36 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C658B15B5E87 for ; Wed, 5 Jun 2019 18:58:35 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3B7408EB11; Wed, 5 Jun 2019 18:58:35 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-lj1-x22a.google.com with SMTP id i21so9576995ljj.3; Wed, 05 Jun 2019 11:58:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+dFkNh7uYGL1WETmgWOey18o2r+KPP7CdUs6kFuy7HA=; b=tMqBgOdqrakrueEx6Nhj2zgivdtVPqByuJWPmGCDmBSRABEOfu2Ou1sVVOavPww9/T sBwIBN2SYG4zMLmRwRGtDcfeiqxSDE+jDRuQEoNdBiEOUDttRtgY/KE5K1bEME0w2Oi9 y86AkCAMTgkaHEUGAqlmA6v8lKzfGzIDFkuFMyFqStAqV2sbI+X/3BSIDjsbxdnYzR0f S8aKken9/lwUery3k48MEmdY1Glj8NkNZgsiU7ticA9JCf5Tlv1oJhd70YTm2EQg9HqJ ePEo5WuhuuuhmtRL8oN1zbK7q+LVFBLODZUJuSr6VI2LKduvPI/jIXjs9zkf2x39Yvyy UHgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+dFkNh7uYGL1WETmgWOey18o2r+KPP7CdUs6kFuy7HA=; b=dCzgn1pxlXc03+fyyMcev8ryFfu09mq2WOi1nig1hsV17FcDN3u1uXqE/pE91fB8qC lxswwjoIlNFOv3gdCuHZfk6Ql/fM/mdY+ntKe3dJEvO2mMrVQDlXUw3xz0Zyz7FzJeBh 2IIkcPjTC0eEKWGdrXnD1O4IQRo/gOY7UusiTMqjPnwhR3IjDvBEzsMPDmFRGpj/cMy9 Ry1sFkx/F1FTO0QPQEbW1AETeRyq0drGtnxPZhRKnAIlAmefu/Zydb1FZ/g7I0tNHZf6 E8Q0IOYVB8XiyJb0i9qzpaN0DxHCei8CuJsgA75dw2u9PWOabUexCn/HbiJBF4dOo3z9 6ydg== X-Gm-Message-State: APjAAAVpTnsRh2xgXJippjKx5xIDt2pB9bNpjsAs2WW75zqiM2vnnRVc viIfQFnFIe1aZy62K+7sIpUBhp63W0shsSB9xSI= X-Google-Smtp-Source: APXvYqy00Vksj48w6OiAcXFH0xwQmOJ7YPKtStEcjxXOr39WPZddRtCxgNOaZwG7Rk9lIor6XyroYh+O9qaxn1hOVp8= X-Received: by 2002:a2e:63d1:: with SMTP id s78mr22097181lje.166.1559761113612; Wed, 05 Jun 2019 11:58:33 -0700 (PDT) MIME-Version: 1.0 References: <20190605180552.GX75280@kib.kiev.ua> In-Reply-To: <20190605180552.GX75280@kib.kiev.ua> From: alan somers Date: Wed, 5 Jun 2019 12:58:21 -0600 Message-ID: Subject: Re: Regression test for vn_io_fault To: Konstantin Belousov Cc: Alan Somers , freebsd-fs X-Rspamd-Queue-Id: 3B7408EB11 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.93 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.93)[-0.932,0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Jun 2019 18:58:36 -0000 Thanks for the link. But I can't tell what the expected failure mode is. Is it supposed to run until it deadlocks? My idea is to rely on witness. It would just run once, and then query witness to see if there was a LOR. -Alan On Wed, Jun 5, 2019, 12:06 PM Konstantin Belousov wrote: > On Wed, Jun 05, 2019 at 10:29:35AM -0600, Alan Somers wrote: > > r236321 added vn_io_fault(), a mechanism for avoiding lock order > > reversals when a process reads from one file into a mmap()ed buffer > > backed by another file. From the description in the comments of > > vn_io_fault() it seems like it would be possible to write a reliable > > test that would trigger the LOR. But I can't find any evidence in > > svn, or bugzilla of such a test program. None in Phabricator either, > > which probably wasn't even running when that commit was made. Did > > anybody ever write a test program? If so, I volunteer to ATFify it. > The test program is in tools/test/upsdl. I object against removing > non-atf version on principle, atf tests are not debuggable. Also this is > racing test, so it is not as simple as doing N runs where N is fixed. > > Anyway, test for the ups@ race is included into stress2, where it belongs. > From owner-freebsd-fs@freebsd.org Wed Jun 5 19:13:17 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6600115B64B6 for ; Wed, 5 Jun 2019 19:13:17 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7CF5F8F385; Wed, 5 Jun 2019 19:13:16 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id x55JD8ra055514 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 5 Jun 2019 22:13:12 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua x55JD8ra055514 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id x55JD8sS055513; Wed, 5 Jun 2019 22:13:08 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Wed, 5 Jun 2019 22:13:08 +0300 From: Konstantin Belousov To: alan somers Cc: Alan Somers , freebsd-fs Subject: Re: Regression test for vn_io_fault Message-ID: <20190605191308.GY75280@kib.kiev.ua> References: <20190605180552.GX75280@kib.kiev.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.0 (2019-05-25) X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on tom.home X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Jun 2019 19:13:17 -0000 On Wed, Jun 05, 2019 at 12:58:21PM -0600, alan somers wrote: > Thanks for the link. But I can't tell what the expected failure mode is. > Is it supposed to run until it deadlocks? My idea is to rely on witness. > It would just run once, and then query witness to see if there was a LOR. Yes, the failure is a deadlock. I doubt that witness can catch it at all, with the current structure of page fault handler. Try to turn use of vn_io_fault off and see witness warnings with upsdl. > -Alan > > On Wed, Jun 5, 2019, 12:06 PM Konstantin Belousov > wrote: > > > On Wed, Jun 05, 2019 at 10:29:35AM -0600, Alan Somers wrote: > > > r236321 added vn_io_fault(), a mechanism for avoiding lock order > > > reversals when a process reads from one file into a mmap()ed buffer > > > backed by another file. From the description in the comments of > > > vn_io_fault() it seems like it would be possible to write a reliable > > > test that would trigger the LOR. But I can't find any evidence in > > > svn, or bugzilla of such a test program. None in Phabricator either, > > > which probably wasn't even running when that commit was made. Did > > > anybody ever write a test program? If so, I volunteer to ATFify it. > > The test program is in tools/test/upsdl. I object against removing > > non-atf version on principle, atf tests are not debuggable. Also this is > > racing test, so it is not as simple as doing N runs where N is fixed. > > > > Anyway, test for the ups@ race is included into stress2, where it belongs. > > From owner-freebsd-fs@freebsd.org Thu Jun 6 11:05:51 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0886615AF035 for ; Thu, 6 Jun 2019 11:05:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 9158E8F3C9 for ; Thu, 6 Jun 2019 11:05:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 4D9E915AF034; Thu, 6 Jun 2019 11:05:50 +0000 (UTC) Delivered-To: fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3A91715AF033 for ; Thu, 6 Jun 2019 11:05:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BDE318F3C7 for ; Thu, 6 Jun 2019 11:05:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id E267C1654A for ; Thu, 6 Jun 2019 11:05:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x56B5mhq078033 for ; Thu, 6 Jun 2019 11:05:48 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x56B5mg1078032 for fs@FreeBSD.org; Thu, 6 Jun 2019 11:05:48 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 236480] [zfs] [panic] solaris assert: dn->dn_type != DMU_OT_NONE Date: Thu, 06 Jun 2019 11:05:48 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: avg@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Jun 2019 11:05:51 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D236480 Andriy Gapon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mav@FreeBSD.org --- Comment #22 from Andriy Gapon --- (In reply to ncrogers from comment #16) Yes, I thought that mmacy would be more active on this issue. I understand that he focuses on ZoF, but we still have in-tree ZFS to take = care about and we are going to have it for a while in stable branches. So, ignoring a bug like this is not good. Now, I could commit the simpler fix, but I do not want to interfere with any possible on-going work to bring in the full fix (or the large dnode support= as was committed to illumos). --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Thu Jun 6 15:18:47 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D913D15B6771 for ; Thu, 6 Jun 2019 15:18:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 6230071143 for ; Thu, 6 Jun 2019 15:18:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 1D95215B6770; Thu, 6 Jun 2019 15:18:47 +0000 (UTC) Delivered-To: fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0B3E715B676F for ; Thu, 6 Jun 2019 15:18:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9C71471140 for ; Thu, 6 Jun 2019 15:18:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id CC3CD188BC for ; Thu, 6 Jun 2019 15:18:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x56FIjLS014370 for ; Thu, 6 Jun 2019 15:18:45 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x56FIjvN014368 for fs@FreeBSD.org; Thu, 6 Jun 2019 15:18:45 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 236480] [zfs] [panic] solaris assert: dn->dn_type != DMU_OT_NONE Date: Thu, 06 Jun 2019 15:18:44 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: dennis.noordsij@alumni.helsinki.fi X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Jun 2019 15:18:48 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D236480 --- Comment #23 from Dennis Noordsij -= -- I would like to confirm that after applying this patch my database-server uptime is now 36 days without any issue (previously I would make it 2 weeks= or so). It's certainly better than nothing. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Thu Jun 6 15:36:31 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5653F15B74A1 for ; Thu, 6 Jun 2019 15:36:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id E5B4072097 for ; Thu, 6 Jun 2019 15:36:30 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id A5C9A15B749F; Thu, 6 Jun 2019 15:36:30 +0000 (UTC) Delivered-To: fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 91E8B15B749E for ; Thu, 6 Jun 2019 15:36:30 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2B4CC72093 for ; Thu, 6 Jun 2019 15:36:30 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 6C17A18B99 for ; Thu, 6 Jun 2019 15:36:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x56FaTxT096869 for ; Thu, 6 Jun 2019 15:36:29 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x56FaTus096868 for fs@FreeBSD.org; Thu, 6 Jun 2019 15:36:29 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 236480] [zfs] [panic] solaris assert: dn->dn_type != DMU_OT_NONE Date: Thu, 06 Jun 2019 15:36:27 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: julien@perdition.city X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Jun 2019 15:36:31 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D236480 --- Comment #24 from Julien Cigar --- I would add a "+1", I've applied the patch on our "dev" machine (small HPE Proliant Microserver) 1,5 months ago and it hasn't deadlocked so far. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Fri Jun 7 11:21:46 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2C8F015A9C33 for ; Fri, 7 Jun 2019 11:21:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id BAA586F72B for ; Fri, 7 Jun 2019 11:21:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 7B0F715A9C32; Fri, 7 Jun 2019 11:21:45 +0000 (UTC) Delivered-To: fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 69AD315A9C31 for ; Fri, 7 Jun 2019 11:21:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 089A86F727 for ; Fri, 7 Jun 2019 11:21:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 61CB034A0 for ; Fri, 7 Jun 2019 11:21:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x57BLiR5051075 for ; Fri, 7 Jun 2019 11:21:44 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x57BLiKZ051074 for fs@FreeBSD.org; Fri, 7 Jun 2019 11:21:44 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 204622] [zfs] [patch] Improve 'zpool labelclear' command Date: Fri, 07 Jun 2019 11:21:44 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: feature, patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: martymac@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: Overcome By Events X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: resolution Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Jun 2019 11:21:46 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D204622 Ganael LAPLANCHE changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |Overcome By Events --=20 You are receiving this mail because: You are the assignee for the bug.=