From owner-freebsd-hackers@freebsd.org Mon Aug 12 09:14:31 2019 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4512EAB510; Mon, 12 Aug 2019 09:14:31 +0000 (UTC) (envelope-from agapon@gmail.com) Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 466VXj6k39z436B; Mon, 12 Aug 2019 09:14:29 +0000 (UTC) (envelope-from agapon@gmail.com) Received: by mail-pg1-f180.google.com with SMTP id w3so11961492pgt.13; Mon, 12 Aug 2019 02:14:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:from:subject:openpgp:message-id:date :user-agent:mime-version:content-language:content-transfer-encoding; bh=tzVpj/gNw2BPOSdi7D8ic5+J4emHm2UKnA7aX0gBpCE=; b=Pfq5Z1tZ6+xdCz+0PIhspeZrg+0fgHB4EilQKJErXGHrTvdQpq1UsyhzyfBpUjehXD +7xO/gdzErEX1WZG4//J44FF/jAwhsExyewfVSY8O6novRDN4BpppxNwpHRexxrkb/Rz N2odaTeC0A6Lt/rKn3PA4tQD6i5E6HCzpTJNk1XKwd5D5gGDNdwxEc+s9AVxTOsa0L69 I901uc8viJeG0N8TcmshPko+1PYKksQIJcT95hUaA9I8+DHKIFxBkiv+or1lsgJYU5aD SwJuwmmmy/6DhrAxVEEwcqyK0Uyn35PYHNMKpXt5dJ4pdyLueyenErkfhqzdIxRRp3o7 oVig== X-Gm-Message-State: APjAAAVLV/+AmiVlBNHtH+X6HFuVhaTpqRUTbnAeVlb+TN/xtwq31MC5 OVhGdP4Z3dIy2KGP8BCIH26s/G3z X-Google-Smtp-Source: APXvYqyT2wRdlodRhsXEykrwxx1iENAX6d/WvJS1tgUat84XhNRHRATXabADiahfhcs5Gi7dugZ3xg== X-Received: by 2002:a17:90a:21c1:: with SMTP id q59mr6511269pjc.6.1565601268101; Mon, 12 Aug 2019 02:14:28 -0700 (PDT) Received: from [192.168.1.36] (broadband-82-140-206-197.atc.tvcom.ru. [82.140.206.197]) by smtp.googlemail.com with ESMTPSA id c12sm14921067pfc.22.2019.08.12.02.14.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Aug 2019 02:14:27 -0700 (PDT) To: FreeBSD Current , "freebsd-hackers@freebsd.org" From: Andriy Gapon Subject: userret: assert td_lk_slocks == 0 Openpgp: preference=signencrypt Message-ID: <94110a73-3c55-e87e-96ae-475014e45596@FreeBSD.org> Date: Mon, 12 Aug 2019 12:14:25 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 466VXj6k39z436B X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of agapon@gmail.com designates 209.85.215.180 as permitted sender) smtp.mailfrom=agapon@gmail.com X-Spamd-Result: default: False [-6.13 / 15.00]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[FreeBSD.org]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCVD_COUNT_THREE(0.00)[3]; IP_SCORE(-3.14)[ip: (-9.89), ipnet: 209.85.128.0/17(-3.38), asn: 15169(-2.39), country: US(-0.05)]; NEURAL_HAM_SHORT(-0.99)[-0.989,0]; RCPT_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_NONE(0.00)[180.215.85.209.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FORGED_SENDER(0.30)[avg@FreeBSD.org,agapon@gmail.com]; RECEIVED_SPAMHAUS_PBL(0.00)[197.206.140.82.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.11]; MIME_TRACE(0.00)[0:+]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[avg@FreeBSD.org,agapon@gmail.com] X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Aug 2019 09:14:31 -0000 I am trying to debug a leak of a shared vnode lock and I noticed that there is no check for td_lk_slocks in userret. There are checks for td_rw_rlocks and td_sx_slocks. I wonder if there is any valid scenario where a thread is allowed to retain a shared lock manager lock across system calls. Thanks! -- Andriy Gapon