From owner-freebsd-python@freebsd.org Sun Jun 30 04:09:21 2019 Return-Path: Delivered-To: freebsd-python@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8F0CA15C9F74 for ; Sun, 30 Jun 2019 04:09:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 240736F196 for ; Sun, 30 Jun 2019 04:09:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id CD04D15C9F72; Sun, 30 Jun 2019 04:09:20 +0000 (UTC) Delivered-To: python@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8B1F515C9F70 for ; Sun, 30 Jun 2019 04:09:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 008A86F192 for ; Sun, 30 Jun 2019 04:09:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 17D8B8A73 for ; Sun, 30 Jun 2019 04:09:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x5U49Ijx051270 for ; Sun, 30 Jun 2019 04:09:18 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x5U49ILl051269 for python@FreeBSD.org; Sun, 30 Jun 2019 04:09:18 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: python@FreeBSD.org Subject: [Bug 238887] devel/py-llfuse: fix build with GCC-based architectures Date: Sun, 30 Jun 2019 04:09:19 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: needs-patch, needs-qa X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: koobs@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: pkubaj@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc bug_status assigned_to keywords Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-python@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FreeBSD-specific Python issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Jun 2019 04:09:21 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D238887 Kubilay Kocak changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |python@FreeBSD.org Status|New |Open Assignee|ports-bugs@FreeBSD.org |pkubaj@FreeBSD.org Keywords| |needs-patch, needs-qa --- Comment #2 from Kubilay Kocak --- Reporter is committer, assign accordingly @Piotr -Werror should be patched out here too (it shouldn't be used/enabled= in packaged/distributed/released code. setup.py does the following: DEVELOPER_MODE =3D os.path.exists(os.path.join(basedir, 'MANIFEST.in')) if DEVELOPER_MODE: print('found MANIFEST.in, running in developer mode') compile_args.append('-Werror') compile_args.append('-Wfatal-errors') The conditional for DEVELOPER_MODE is too widely-scoped, as source distributions (sdists) are released to end-users, and the presence of a MANIFEST.in shouldn't mean DEVELOPER_MODE. A slightly better form might be to check for the presence of a git checkout, though this is also problematic, as users can depend on packages via their = git URL's.=20 The check should probably be an explicit opt-in via the presence of an environment variable DEVELOPER_MODE=3Dyes or similar. Either way, I'd patch the conditional to be False, along with the patch provided fixing the warning. If you can, please report this '-Werror should be opt-in, not based on MANIFEST.in' issue upstream, with a PR if you can manage it Note also, both the build (warning=3Derror) fix, and the -Werror removal ar= e: Approved by: portmgr (blanket(s): build fix, ports compliance) --=20 You are receiving this mail because: You are on the CC list for the bug.=