From owner-freebsd-scsi@freebsd.org Sun Feb 10 21:00:50 2019 Return-Path: Delivered-To: freebsd-scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 645E014DBC66 for ; Sun, 10 Feb 2019 21:00:50 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id EDFB56ACEE for ; Sun, 10 Feb 2019 21:00:49 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: by mailman.ysv.freebsd.org (Postfix) id AD40614DBC65; Sun, 10 Feb 2019 21:00:49 +0000 (UTC) Delivered-To: scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9BC6214DBC64 for ; Sun, 10 Feb 2019 21:00:49 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3D1966ACE6 for ; Sun, 10 Feb 2019 21:00:49 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 829A215F99 for ; Sun, 10 Feb 2019 21:00:48 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x1AL0m3O055315 for ; Sun, 10 Feb 2019 21:00:48 GMT (envelope-from bugzilla-noreply@FreeBSD.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x1AL0mwI055289 for scsi@FreeBSD.org; Sun, 10 Feb 2019 21:00:48 GMT (envelope-from bugzilla-noreply@FreeBSD.org) Message-Id: <201902102100.x1AL0mwI055289@kenobi.freebsd.org> X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@FreeBSD.org using -f From: bugzilla-noreply@FreeBSD.org To: scsi@FreeBSD.org Subject: Problem reports for scsi@FreeBSD.org that need special attention Date: Sun, 10 Feb 2019 21:00:48 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 10 Feb 2019 21:00:50 -0000 To view an individual PR, use: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=(Bug Id). The following is a listing of current problems submitted by FreeBSD users, which need special attention. These represent problem reports covering all versions including experimental development code and obsolete releases. Status | Bug Id | Description ------------+-----------+--------------------------------------------------- Open | 221952 | cam iosched: Fix trim statistics 1 problems total for which you should take action. From owner-freebsd-scsi@freebsd.org Wed Feb 13 09:08:08 2019 Return-Path: Delivered-To: freebsd-scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7C71414E8BFE for ; Wed, 13 Feb 2019 09:08:08 +0000 (UTC) (envelope-from peter.blok@bsd4all.org) Received: from smtpq1.tb.mail.iss.as9143.net (smtpq1.tb.mail.iss.as9143.net [212.54.42.164]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id DDB3A80504; Wed, 13 Feb 2019 09:08:06 +0000 (UTC) (envelope-from peter.blok@bsd4all.org) Received: from [212.54.42.134] (helo=smtp10.tb.mail.iss.as9143.net) by smtpq1.tb.mail.iss.as9143.net with esmtp (Exim 4.86_2) (envelope-from ) id 1gtqWK-0005qw-Ne; Wed, 13 Feb 2019 10:07:56 +0100 Received: from 5ed231fb.cm-7-3a.dynamic.ziggo.nl ([94.210.49.251] helo=wan0.bsd4all.org) by smtp10.tb.mail.iss.as9143.net with esmtp (Exim 4.86_2) (envelope-from ) id 1gtqWK-0004E7-M3; Wed, 13 Feb 2019 10:07:56 +0100 Received: from newnas (localhost [127.0.0.1]) by wan0.bsd4all.org (Postfix) with ESMTP id 1EBA0FC; Wed, 13 Feb 2019 10:07:56 +0100 (CET) X-Virus-Scanned: amavisd-new at bsd4all.org Received: from wan0.bsd4all.org ([127.0.0.1]) by newnas (newnas.bsd4all.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 964vF702FQ93; Wed, 13 Feb 2019 10:07:54 +0100 (CET) Received: from [192.168.1.65] (unknown [192.168.1.65]) by wan0.bsd4all.org (Postfix) with ESMTPSA id 87C48F2; Wed, 13 Feb 2019 10:07:54 +0100 (CET) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Subject: Re: iSCSI stall From: peter.blok@bsd4all.org In-Reply-To: <3579EC93-825D-4908-B177-673363111BEF@bsd4all.org> Date: Wed, 13 Feb 2019 10:07:53 +0100 Cc: mav@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <6329694E-4BF7-4467-A3A7-2556AA0C3FD6@bsd4all.org> References: <3579EC93-825D-4908-B177-673363111BEF@bsd4all.org> To: freebsd-scsi@freebsd.org X-Mailer: Apple Mail (2.3445.102.3) X-SourceIP: 94.210.49.251 X-Ziggo-spambar: / X-Ziggo-spamscore: 0.0 X-Ziggo-spamreport: CMAE Analysis: v=2.3 cv=aPGOVo1m c=1 sm=1 tr=0 a=7fK1ynn72W3Z/oi6DA4Tww==:17 a=IkcTkHD0fZMA:10 a=CFTnQlWoA9kA:10 a=6Q3WNqvRAAAA:8 a=6I5d2MoRAAAA:8 a=X-ym7V0z0cYcq1pNt-kA:9 a=QEXdDO2ut3YA:10 a=I8PBwKCn76L9oNdl0isp:22 a=IjZwj45LgO3ly-622nXo:22 X-Ziggo-Spam-Status: No X-Spam-Status: No X-Spam-Flag: No X-Rspamd-Queue-Id: DDB3A80504 X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of peter.blok@bsd4all.org designates 212.54.42.164 as permitted sender) smtp.mailfrom=peter.blok@bsd4all.org X-Spamd-Result: default: False [-1.54 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_FIVE(0.00)[6]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; R_SPF_ALLOW(-0.20)[+a:smtp.ziggo.nl/16]; MV_CASE(0.50)[]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; DMARC_NA(0.00)[bsd4all.org]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-0.94)[-0.940,0]; IP_SCORE(0.00)[country: NL(0.02)]; NEURAL_SPAM_SHORT(0.08)[0.076,0]; MX_GOOD(-0.01)[smtp.bsd4all.org]; RCPT_COUNT_TWO(0.00)[2]; FROM_NO_DN(0.00)[]; NEURAL_HAM_MEDIUM(-0.77)[-0.773,0]; RCVD_IN_DNSWL_LOW(-0.10)[164.42.54.212.list.dnswl.org : 127.0.5.1]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:33915, ipnet:212.54.32.0/20, country:NL]; MID_RHS_MATCH_FROM(0.00)[]; RECEIVED_SPAMHAUS_PBL(0.00)[251.49.210.94.zen.spamhaus.org : 127.0.0.11] X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Feb 2019 09:08:08 -0000 Hi, Did not get any response on this, but it seems the commits 344072, = 344075 and 344076 have fixed the issue. My assumption is that the target = doesn=E2=80=99t handle re-ordering with non-offset CDBs very well. Normally every time when the backup (zfs recv on target) ran, it hung a = couple of times and now it went thru without a glitch and without any = quirks. Peter > On 16 Jan 2019, at 10:05, peter.blok@bsd4all.org wrote: >=20 > Hi, >=20 > I have a ReadyNAS RND4000 as an iSCSI target. The target is the only = device in a ZFS pool and is receiving backups thru zfs receive. The = initiator is FreeBSD 11.x (recent stable at this moment), but this = probably happens with 12.0 as well. >=20 > During a zfs receive it stalls. Nothing happens anymore. When I send a = TUR via camcontrol everything continues. Any other target on any other = platform works fine. >=20 > When I take a network trace it looks as if it is around SYNCHRONIZE = CACHE. If this takes too long in the target and before the reply is back = some new READ CDBs are send, it seems to hang only showing Nop-In and = Nop-out. The moment I send a TUR it continues replying with the data of = the READs that were owed. >=20 > It is not a big deal, but it irritates me and I would like to create a = work-around for this, assuming it is caused by the target and there is = probably no way to fix it there. One test was to create a quirk to = reduce the tags to 1, but that didn=E2=80=99t help. Although it is 1 it = still seems to send multiple CDB concurrently. >=20 > In the past I have attempted to port FreeBSD to the ReadyNAS, but got = stuck on fan control. I wasn=E2=80=99t able to control the fan and it = made too much noise. I was able to get the network up and running. >=20 > Any tips? >=20 >=20 >=20 >=20 > _______________________________________________ > freebsd-scsi@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-scsi > To unsubscribe, send any mail to = "freebsd-scsi-unsubscribe@freebsd.org" From owner-freebsd-scsi@freebsd.org Wed Feb 13 15:34:31 2019 Return-Path: Delivered-To: freebsd-scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A7B4B14CF299 for ; Wed, 13 Feb 2019 15:34:31 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-yb1-xb2a.google.com (mail-yb1-xb2a.google.com [IPv6:2607:f8b0:4864:20::b2a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C0C118FB60 for ; Wed, 13 Feb 2019 15:34:30 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: by mail-yb1-xb2a.google.com with SMTP id s76so1054149ybs.10 for ; Wed, 13 Feb 2019 07:34:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=k7YFrWiMrob0HEhNnMKHuGrbizifSxODr3ELSR8kMGw=; b=Ix6qwfw6vk9Xyd7yGgPMT7tf5QKmz9FAjTJLZp0giQ3fRjxY8/bL0NwcBKfg4410AY c3rZS6H9vpKS8+wF2M1UtsXxgfhGDxA2eW4IoHlx1dUatZRDqX8dyfb9kbAcfh90fQkq UfBy32AOk6mnCvXJcJkPsMo1xo8I+SVwB84M4gQj476l7OkUgfdyFgdkXTVvcW2eL98X 5Fd7NAQ5lWblN3btGFa0lzszi/TVjSa8oBBJUOAnFXkSyLSFtM4IK8Dir92IEAvvs6s5 Fj1lG98qpbpGn5E7bLFrSkEOwO2goD4wc2NRPblQNMXHTTH4jswCjgHHsGKauidDxFoK bj0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:openpgp :autocrypt:message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=k7YFrWiMrob0HEhNnMKHuGrbizifSxODr3ELSR8kMGw=; b=HU7VePU8i801a6bO7/X8nukEqC8Adbu64kqwTs/fAdSMPVLD34IJdAiJMDjua5X5b2 6LdqyotNfHzun+mCabNDZZ/1yLJzEku8boV5uUkJOZiB4QpS1xPfIvQ4PxK23k2Pwm5s aJebAtjHFtE2M+0BMtK7qtQQog91PDXr4VpTUKe4DBkOB9gF6JqDcigJPwBEJhtPsFo3 sb8r/m6uth+9MRdWEuIVuMHDxhagknWS4AN8Rv3VXE7cH3XybUFuiITxN9eiXzIzTCSf /DPEVoG1qbAilh+gQewwojOYtjlvizVByzy2U6GsnQCkjpfAiDc3f6I9Av8UzZqCaVqr 5a0g== X-Gm-Message-State: AHQUAuYikUIvsUwZTB2smB7kzUeFSW3hn3iiR3ghmGH+HS07hD7y6PRV 2y7o2CZqSKAlXg5s55GoHLc9GsS5 X-Google-Smtp-Source: AHgI3IZTil+2pK2diqTYvJOah+Xh4tQFIfVmG1yoEySxJL4i7zFGCJa1rm6JfoFvuUA+UYmbIToqtQ== X-Received: by 2002:a25:2ad3:: with SMTP id q202mr1010840ybq.442.1550072069519; Wed, 13 Feb 2019 07:34:29 -0800 (PST) Received: from mavoffice.ixsystems.com ([12.189.233.129]) by smtp.gmail.com with ESMTPSA id 205sm1814194ywf.35.2019.02.13.07.34.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Feb 2019 07:34:28 -0800 (PST) Sender: Alexander Motin Subject: Re: iSCSI stall To: peter.blok@bsd4all.org, freebsd-scsi@freebsd.org References: <3579EC93-825D-4908-B177-673363111BEF@bsd4all.org> <6329694E-4BF7-4467-A3A7-2556AA0C3FD6@bsd4all.org> From: Alexander Motin Openpgp: preference=signencrypt Autocrypt: addr=mav@FreeBSD.org; prefer-encrypt=mutual; keydata= xsBNBFOzxAwBCADkPrax0pI2W/ig0CK9nRJJwsHitAGEZ2HZiFEuti+6/4UVxj81yr4ak/4g 9bKUyC7rMEAp/ZHNhd+MFCPAAcHPvtovnfykqE/vuosCS3wlSLloix2iKVLks0CwbLHGAyne 46lTQW74Xl/33c3W1Z6d8jD9gVFT/xaVzZ0U9xdzOmsYAZaAj4ki0tuxO9F7L+ct9grRe7iP g8t9hai7BL4ee3VRwk2JXnKb7UvBiVITKYWKz1jRvZIrjPokgEcCLOSlv7x/1kjuFnj3xWZU 7HSFFT8J93epBbrSSCsYsppIk2fZH41kaaFXsMQfTPH8wkeM6qwrvOh4HiQM08R+9tThABEB AAHNIUFsZXhhbmRlciBNb3RpbiA8bWF2QEZyZWVCU0Qub3JnPsLAlwQTAQoAQQIbAwULCQgH AwUVCgkICwUWAwIBAAIeAQIXgAIZARYhBOmM88TmnMPNDledVYMYw5VbqyJ/BQJZYMKuBQkN McyiAAoJEIMYw5VbqyJ/tuUIAOG3ONOSNYqjK4eTZ1TVh9jdUBAhWk5nhDFnODN49Wj0AbYm 7aIqy8O1hnCDSZG5LttjSAo3UfXJZDKQM0BLb0gpRMBnAYqO6tdolLNqAbPGJBnGoPjsh24y 6KcbDaNnis+lD4GwPXwQM+92wZGhCUFElPV9NciZGVS65TNIgk7X+yEjjhD1MSWKKijZ1r9Z zIt4OzUTxxNOvzdlABZS88nNRdJkatOQJPmFdd1mpP6UzTNCiLUo1pIqOEtJgvVVDYq5WHY6 tciWWYdmZG/tIBexJmv2mV2OLVjXR6ZeKmntVH14H72/wRHJuYHQC+r5SVRcWWayrThsY6jZ Yr4+raTOwE0EU7PEDAEIAOZgWf2cJIu+58IzP2dkXE/urj3tr4OqrB/yHGWUf71Lz6D0Fi6Z AXgDtmcFLGPfMyWuLAvSM+xmoguk7zC4hRBYvQycmIhuqBq1jO1Wp/Z+lpoPM/1cDYLn8Flv mI/c40MhUZh345DA4jYWWaZNjQHUWVQ1fPf595vdVVMPT/abE8E5DaF6fSkRmqFTmfYRkfbt 3ytU8NdUapDcJVY7cEP2nJBVNZPnOIObR/ZIgSxjjrG5o34yXoqeup8JvwEv+/NylzzuyXEZ R1EdEIzQ/a1nh/0j4NXtzZEqKW4aTWlmSqb6wN8jh1OSOOqkYsfnE3nfxcZbxi4IRoNQYlm5 9R8AEQEAAcLAZQQYAQoADwUCU7PEDAIbDAUJBaOagAAKCRCDGMOVW6sif7FRB/4k9y/GaGqU fcJiXdQHRAKHCUvbKMFgeEDHOg33qx+POS2Ah85/PXVa2jYBldCZDmYc+zl48aEMd163a7s3 0gJaB7CYElwxlKUk6c+5gwoYIJuJJzSzW0JzSD5ch7RIRxbfxrKdsiHrUW8AeduZWzlK6VaW RmWILgLmxfLdhEVFWxbr99GSeVFZaZwn6tl/8CvBcgYoARvJvl0V5zS1akQfEISYkwL9EfUI W44EOHranL5qUXkedXBYp6fRsooGrIimfwYxaC8FbXhk3FMgMjDMRiVq4POHo1iGeYETsUrL NM6184E25gPVtX2fb3RhM8Xh6BkwCZ6ZYbQ+AcD4F/cKwsB8BBgBCgAmAhsMFiEE6YzzxOac w80OV51VgxjDlVurIn8FAllgwtgFCQ0xzMwACgkQgxjDlVurIn9OqAf9FAcKWS95wTTbraXA qg/+bQyHgjlMtGCgkmfxLsbUGeqiFgmSIuoDrF7q6sYPs6p00CXXZRuuNZt0lX7O95re8mgz gxm5iJisZpdbHMVepYlw/AxT2wCHwxGCEe64Lm+A9vjlOd+3D3/6fSLwZ9WFCE6p6lQZ1CDg 09xe+JKSgC+KDqmn0tzGKyfSCuhRAq3XkZyxL1hxBaDeP0eeKlzoy7jXodf3wVvXXc0cmpza B5McuRHK4EU6jIioHo30YqPM4AjPHGxV2X1N6/Aayungzj9EXNZtKCxs6dsTvjniWa5VkZ9F 4SOdSbxEen1DZRYpeWnd7GVmO86n+5USkKCXPg== Message-ID: <7142e6ae-638d-a667-87d2-f14c881236a9@FreeBSD.org> Date: Wed, 13 Feb 2019 10:34:28 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <6329694E-4BF7-4467-A3A7-2556AA0C3FD6@bsd4all.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: C0C118FB60 X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=Ix6qwfw6; spf=pass (mx1.freebsd.org: domain of mavbsd@gmail.com designates 2607:f8b0:4864:20::b2a as permitted sender) smtp.mailfrom=mavbsd@gmail.com X-Spamd-Result: default: False [-5.97 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; TO_DN_NONE(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; RCPT_COUNT_TWO(0.00)[2]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; FORGED_SENDER(0.30)[mav@FreeBSD.org,mavbsd@gmail.com]; IP_SCORE(-2.78)[ip: (-9.31), ipnet: 2607:f8b0::/32(-2.53), asn: 15169(-1.97), country: US(-0.07)]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[mav@FreeBSD.org,mavbsd@gmail.com]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_SHORT(-0.99)[-0.989,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-scsi@freebsd.org]; DMARC_NA(0.00)[FreeBSD.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[a.2.b.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; RCVD_TLS_LAST(0.00)[] X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Feb 2019 15:34:31 -0000 Hi Peter, If those commits helped (I did hope they improve performance in some configurations like this), then I guess this NAS has some problems with ordered tag handling in its iSCSI target, and this change workarounded it. Our iSCSI initiator does not specially care about ordered requests, just forwards the flag straight to the target, so it should not change anything on our side. On 13.02.2019 04:07, peter.blok@bsd4all.org wrote: > Hi, > > Did not get any response on this, but it seems the commits 344072, 344075 and 344076 have fixed the issue. My assumption is that the target doesn’t handle re-ordering with non-offset CDBs very well. > > Normally every time when the backup (zfs recv on target) ran, it hung a couple of times and now it went thru without a glitch and without any quirks. > > Peter > > >> On 16 Jan 2019, at 10:05, peter.blok@bsd4all.org wrote: >> >> Hi, >> >> I have a ReadyNAS RND4000 as an iSCSI target. The target is the only device in a ZFS pool and is receiving backups thru zfs receive. The initiator is FreeBSD 11.x (recent stable at this moment), but this probably happens with 12.0 as well. >> >> During a zfs receive it stalls. Nothing happens anymore. When I send a TUR via camcontrol everything continues. Any other target on any other platform works fine. >> >> When I take a network trace it looks as if it is around SYNCHRONIZE CACHE. If this takes too long in the target and before the reply is back some new READ CDBs are send, it seems to hang only showing Nop-In and Nop-out. The moment I send a TUR it continues replying with the data of the READs that were owed. >> >> It is not a big deal, but it irritates me and I would like to create a work-around for this, assuming it is caused by the target and there is probably no way to fix it there. One test was to create a quirk to reduce the tags to 1, but that didn’t help. Although it is 1 it still seems to send multiple CDB concurrently. >> >> In the past I have attempted to port FreeBSD to the ReadyNAS, but got stuck on fan control. I wasn’t able to control the fan and it made too much noise. I was able to get the network up and running. >> >> Any tips? >> >> >> >> >> _______________________________________________ >> freebsd-scsi@freebsd.org mailing list >> https://lists.freebsd.org/mailman/listinfo/freebsd-scsi >> To unsubscribe, send any mail to "freebsd-scsi-unsubscribe@freebsd.org" > -- Alexander Motin From owner-freebsd-scsi@freebsd.org Wed Feb 13 18:02:29 2019 Return-Path: Delivered-To: freebsd-scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B5EC814D3EAB for ; Wed, 13 Feb 2019 18:02:29 +0000 (UTC) (envelope-from moerke@abv.bg) Received: from smtp-out.abv.bg (smtp-out.abv.bg [194.153.145.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.abv.bg", Issuer "Go Daddy Secure Certificate Authority - G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D71D86E0A5 for ; Wed, 13 Feb 2019 18:02:26 +0000 (UTC) (envelope-from moerke@abv.bg) Received: from nm43.abv.bg (nm42.ni.bg [192.168.151.179]) by smtp-out.abv.bg (Postfix) with ESMTP id 68F781802868 for ; Wed, 13 Feb 2019 20:02:15 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=abv.bg; s=smtp-out; t=1550080935; bh=FmWS3NqqLzUKoba5cHSUxzFfa0AOa7+bgyUBSRuUxlo=; h=Date:From:To:Subject:From; b=zGN60u7XUURhAYdivt76lnnhtUco7NZccsXo8tEUA0zS5swKDdXkfW15BIXHFmYIx qsN34m2pTHilcEg/Fuxk9Fvif+eVgXhKgOtCgzKKhdJSDpoO0n4/psBKPLNERA69U0 fl3aW6z83fp1zfu28hewMjfTiAcgjSYIjGRJVfLk= Received: from nm42.abv.bg (localhost [127.0.0.1]) by nm43.abv.bg (Postfix) with ESMTP id 572EA9D7EA for ; Wed, 13 Feb 2019 20:02:15 +0200 (EET) Date: Wed, 13 Feb 2019 20:02:15 +0200 (EET) From: Krasimir Velkov To: freebsd-scsi@freebsd.org Message-ID: <503097732.142480.1550080935357@nm42.abv.bg> Subject: SATA affiliation missing from SATA phys MIME-Version: 1.0 X-Mailer: AbvMail 3.0 X-Originating-IP: 84.21.202.109 X-Rspamd-Queue-Id: D71D86E0A5 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=abv.bg header.s=smtp-out header.b=zGN60u7X; dmarc=pass (policy=none) header.from=abv.bg; spf=pass (mx1.freebsd.org: domain of moerke@abv.bg designates 194.153.145.70 as permitted sender) smtp.mailfrom=moerke@abv.bg X-Spamd-Result: default: False [-4.39 / 15.00]; HAS_XOIP(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:194.153.145.0/24]; FREEMAIL_FROM(0.00)[abv.bg]; TO_DN_NONE(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[abv.bg:+]; MX_GOOD(-0.01)[smx.abv.bg,pmx.abv.bg,smx.abv.bg,pmx.abv.bg,smx.abv.bg,pmx.abv.bg,smx.abv.bg,pmx.abv.bg,smx.abv.bg,pmx.abv.bg,smx.abv.bg,pmx.abv.bg,smx.abv.bg,pmx.abv.bg,smx.abv.bg,pmx.abv.bg,smx.abv.bg,pmx.abv.bg,smx.abv.bg,pmx.abv.bg,smx.abv.bg,pmx.abv.bg,smx.abv.bg,pmx.abv.bg,smx.abv.bg,pmx.abv.bg,smx.abv.bg,pmx.abv.bg,smx.abv.bg,pmx.abv.bg,smx.abv.bg,pmx.abv.bg,smx.abv.bg,pmx.abv.bg]; DMARC_POLICY_ALLOW(-0.50)[abv.bg,none]; NEURAL_HAM_SHORT(-0.29)[-0.294,0]; FROM_EQ_ENVFROM(0.00)[]; IP_SCORE(0.01)[country: BG(0.03)]; MIME_TRACE(0.00)[0:+,1:+]; FREEMAIL_ENVFROM(0.00)[abv.bg]; ASN(0.00)[asn:13147, ipnet:194.153.145.0/24, country:BG]; RCVD_IN_DNSWL_LOW(-0.10)[70.145.153.194.list.dnswl.org : 127.0.5.1]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.99)[-0.992,0]; R_DKIM_ALLOW(-0.20)[abv.bg:s=smtp-out]; URIBL_BLOCKED(0.00)[abv.bg.multi.uribl.com]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-scsi@freebsd.org]; RCPT_COUNT_ONE(0.00)[1]; DWL_DNSWL_LOW(-1.00)[abv.bg.dwl.dnswl.org : 127.0.5.1]; RCVD_TLS_LAST(0.00)[] Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Feb 2019 18:02:29 -0000 Hey guys, I have a couple of freebsd 12.0 controllers (each has an LSI 9300-8e HBA) and one JBOD box with a single LSI 3x40 SAS EXPANDER. The JBOD box is connected to both controllers and according to all information I found on the Internet, SATA disks CANNOT be accessed by two SAS Initiators at the same time and have SATA affiliations. The problem is that the aforementioned affiliations are not being honored and both initiators end up accessing the SATA disks which leads to an affiliation conflict and one of the initiators freezing. Here is an example for a SATA disk: smp_rep_phy_sata --phy=0 /dev/ses4 Report phy SATA response: expander change count: 83 phy identifier: 0 STP I_T nexus loss occurred: 0 affiliations supported: 0 affiliation valid: 0 STP SAS address: 0x500304801eeba8c0 register device to host FIS: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 affiliated STP initiator SAS address: 0x0 STP I_T nexus loss SAS address: 0x0 affiliation context: 0 current affiliation contexts: 0 maximum affiliation contexts: 0 there is no affiliated STP initiator SAS address and sending operations to the phy works for both initiator hosts. I found absolutely no information on how to enable/disable SATA affiliation for the SAS EXPANDER. Tried issuing commands with both camcontrol and smp_phy_control without any success: camcontrol smppc /dev/ses4 -vvv -p 0 -o sataportsel camcontrol: error sending command (pass6:mpr5:0:200:0): PHY CONTROL. 40 91 00 00 00 00 00 00 00 00 07 00 00 ... (pass6:mpr5:0:200:0): CAM status: SMP Status Error (pass6:mpr5:0:200:0): SMP status: SMP Function Failed (0x2) I have absolutely no idea how to proceed. Has anybody bumped into something similar? Thanks, Krasimir Velkov From owner-freebsd-scsi@freebsd.org Fri Feb 15 17:24:24 2019 Return-Path: Delivered-To: freebsd-scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 87B1314E1B78 for ; Fri, 15 Feb 2019 17:24:24 +0000 (UTC) (envelope-from peter.blok@bsd4all.org) Received: from smtpq2.mnd.mail.iss.as9143.net (smtpq2.mnd.mail.iss.as9143.net [212.54.34.165]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 0B7B77300E; Fri, 15 Feb 2019 17:24:22 +0000 (UTC) (envelope-from peter.blok@bsd4all.org) Received: from [212.54.34.120] (helo=smtp12.mnd.mail.iss.as9143.net) by smtpq2.mnd.mail.iss.as9143.net with esmtp (Exim 4.86_2) (envelope-from ) id 1guhDh-0006IK-Cu; Fri, 15 Feb 2019 18:24:13 +0100 Received: from 5ed231fb.cm-7-3a.dynamic.ziggo.nl ([94.210.49.251] helo=wan0.bsd4all.org) by smtp12.mnd.mail.iss.as9143.net with esmtp (Exim 4.86_2) (envelope-from ) id 1guhDh-0007Cg-AG; Fri, 15 Feb 2019 18:24:13 +0100 Received: from newnas (localhost [127.0.0.1]) by wan0.bsd4all.org (Postfix) with ESMTP id 0A771F7; Fri, 15 Feb 2019 18:24:13 +0100 (CET) X-Virus-Scanned: amavisd-new at bsd4all.org Received: from wan0.bsd4all.org ([127.0.0.1]) by newnas (newnas.bsd4all.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id isY8P2QlQoxm; Fri, 15 Feb 2019 18:24:12 +0100 (CET) Received: from [192.168.1.65] (unknown [192.168.1.65]) by wan0.bsd4all.org (Postfix) with ESMTPSA id 4B86EED; Fri, 15 Feb 2019 18:24:12 +0100 (CET) From: peter.blok@bsd4all.org Message-Id: <426C1AF9-7E30-4174-88C0-1FBFE6341A1D@bsd4all.org> Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Subject: Re: iSCSI stall Date: Fri, 15 Feb 2019 18:24:11 +0100 In-Reply-To: <7142e6ae-638d-a667-87d2-f14c881236a9@FreeBSD.org> Cc: freebsd-scsi@freebsd.org To: Alexander Motin References: <3579EC93-825D-4908-B177-673363111BEF@bsd4all.org> <6329694E-4BF7-4467-A3A7-2556AA0C3FD6@bsd4all.org> <7142e6ae-638d-a667-87d2-f14c881236a9@FreeBSD.org> X-Mailer: Apple Mail (2.3445.102.3) X-SourceIP: 94.210.49.251 X-Ziggo-spambar: / X-Ziggo-spamscore: 0.0 X-Ziggo-spamreport: CMAE Analysis: v=2.3 cv=SYKJicZu c=1 sm=1 tr=0 a=7fK1ynn72W3Z/oi6DA4Tww==:17 a=CFTnQlWoA9kA:10 a=6I5d2MoRAAAA:8 a=6Q3WNqvRAAAA:8 a=2GToYnZcBhCU6EHnupkA:9 a=QEXdDO2ut3YA:10 a=ioCW4vYGWj-Fin33:21 a=_W_S_7VecoQA:10 a=IjZwj45LgO3ly-622nXo:22 a=I8PBwKCn76L9oNdl0isp:22 X-Ziggo-Spam-Status: No X-Spam-Status: No X-Spam-Flag: No X-Rspamd-Queue-Id: 0B7B77300E X-Spamd-Bar: +++ Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of peter.blok@bsd4all.org designates 212.54.34.165 as permitted sender) smtp.mailfrom=peter.blok@bsd4all.org X-Spamd-Result: default: False [3.43 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(0.00)[+a:smtp.ziggo.nl/16]; MV_CASE(0.50)[]; MX_GOOD(-0.01)[smtp.bsd4all.org]; RCPT_COUNT_TWO(0.00)[2]; NEURAL_HAM_SHORT(-0.39)[-0.395,0]; RCVD_IN_DNSWL_LOW(-0.10)[165.34.54.212.list.dnswl.org : 127.0.5.1]; MIME_TRACE(0.00)[0:+,1:+]; RCVD_TLS_LAST(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; ASN(0.00)[asn:33915, ipnet:212.54.32.0/20, country:NL]; MID_RHS_MATCH_FROM(0.00)[]; RECEIVED_SPAMHAUS_PBL(0.00)[251.49.210.94.zen.spamhaus.org : 127.0.0.11]; ARC_NA(0.00)[]; RCVD_COUNT_FIVE(0.00)[6]; R_DKIM_NA(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; DMARC_NA(0.00)[bsd4all.org]; NEURAL_SPAM_MEDIUM(0.84)[0.835,0]; BAD_REP_POLICIES(0.10)[]; IP_SCORE(0.00)[country: NL(0.02)]; NEURAL_SPAM_LONG(0.60)[0.598,0]; FROM_NO_DN(0.00)[]; RBL_SENDERSCORE(2.00)[165.34.54.212.bl.score.senderscore.com] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Feb 2019 17:24:24 -0000 Hi Alexander, I suspected re-ordering too and that=E2=80=99s why I changed max_tags to = 1, but that didn=E2=80=99t work the way I expected. In the wireshark = trace I still saw multiple CDB READ arriving,without a data transfer. If = one of the CDBs was a SYNC CACHE everything stalled without any data = transfer. When I did send a TUR, the data transfer happened and = everything continued. The CDB read had to be orgination from some ZFS (meta)operation, because = bulk of the data was arroving thru zfs recv and most of the CDB were = writes. It did not stall all the time in similar sequences. I did not have the exact target source code, nor build capability and = time to debug, so I=E2=80=99m very glad those commits fixed it. Peter > On 13 Feb 2019, at 16:34, Alexander Motin wrote: >=20 > Hi Peter, >=20 > If those commits helped (I did hope they improve performance in some > configurations like this), then I guess this NAS has some problems = with > ordered tag handling in its iSCSI target, and this change workarounded > it. Our iSCSI initiator does not specially care about ordered = requests, > just forwards the flag straight to the target, so it should not change > anything on our side. >=20 > On 13.02.2019 04:07, peter.blok@bsd4all.org = wrote: >> Hi, >>=20 >> Did not get any response on this, but it seems the commits 344072, = 344075 and 344076 have fixed the issue. My assumption is that the target = doesn=E2=80=99t handle re-ordering with non-offset CDBs very well. >>=20 >> Normally every time when the backup (zfs recv on target) ran, it hung = a couple of times and now it went thru without a glitch and without any = quirks. >>=20 >> Peter >>=20 >>=20 >>> On 16 Jan 2019, at 10:05, peter.blok@bsd4all.org wrote: >>>=20 >>> Hi, >>>=20 >>> I have a ReadyNAS RND4000 as an iSCSI target. The target is the only = device in a ZFS pool and is receiving backups thru zfs receive. The = initiator is FreeBSD 11.x (recent stable at this moment), but this = probably happens with 12.0 as well. >>>=20 >>> During a zfs receive it stalls. Nothing happens anymore. When I send = a TUR via camcontrol everything continues. Any other target on any other = platform works fine. >>>=20 >>> When I take a network trace it looks as if it is around SYNCHRONIZE = CACHE. If this takes too long in the target and before the reply is back = some new READ CDBs are send, it seems to hang only showing Nop-In and = Nop-out. The moment I send a TUR it continues replying with the data of = the READs that were owed. >>>=20 >>> It is not a big deal, but it irritates me and I would like to create = a work-around for this, assuming it is caused by the target and there is = probably no way to fix it there. One test was to create a quirk to = reduce the tags to 1, but that didn=E2=80=99t help. Although it is 1 it = still seems to send multiple CDB concurrently. >>>=20 >>> In the past I have attempted to port FreeBSD to the ReadyNAS, but = got stuck on fan control. I wasn=E2=80=99t able to control the fan and = it made too much noise. I was able to get the network up and running. >>>=20 >>> Any tips? >>>=20 >>>=20 >>>=20 >>>=20 >>> _______________________________________________ >>> freebsd-scsi@freebsd.org mailing list >>> https://lists.freebsd.org/mailman/listinfo/freebsd-scsi >>> To unsubscribe, send any mail to = "freebsd-scsi-unsubscribe@freebsd.org" >>=20 >=20 > --=20 > Alexander Motin From owner-freebsd-scsi@freebsd.org Sat Feb 16 00:53:23 2019 Return-Path: Delivered-To: freebsd-scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6811F14F07EF for ; Sat, 16 Feb 2019 00:53:23 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id F32C66807C for ; Sat, 16 Feb 2019 00:53:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id B789214F07EC; Sat, 16 Feb 2019 00:53:22 +0000 (UTC) Delivered-To: scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A4FB714F07E9 for ; Sat, 16 Feb 2019 00:53:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 38C7F68076 for ; Sat, 16 Feb 2019 00:53:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 60198124BA for ; Sat, 16 Feb 2019 00:53:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x1G0rLXo007781 for ; Sat, 16 Feb 2019 00:53:21 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x1G0rLcD007777 for scsi@FreeBSD.org; Sat, 16 Feb 2019 00:53:21 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: scsi@FreeBSD.org Subject: [Bug 229551] src/sys/dev/trm/trm.c:2484: bad if logic Date: Sat, 16 Feb 2019 00:53:21 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: avos@freebsd.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: scsi@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc bug_status keywords assigned_to Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Feb 2019 00:53:23 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D229551 Andriy Voskoboinyk changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |avos@freebsd.org Status|New |Open Keywords| |patch Assignee|bugs@FreeBSD.org |scsi@FreeBSD.org --- Comment #1 from Andriy Voskoboinyk --- I assume that (pDCB->DevMode & TAG_QUEUING_) && (pDCB->DevMode & EN_DISCONNECT_) should be changed to ((pDCB->DevMode & TAG_QUEUING_) || (pDCB->DevMode & EN_DISCONNECT_)) however, I don't think this fix should be committed to the tree without tes= ting with real device and / or specs verification. --=20 You are receiving this mail because: You are the assignee for the bug.=