Date: Sun, 20 Oct 2019 13:33:42 +0200 From: Dimitry Andric <dim@FreeBSD.org> To: freebsd-stable stable <freebsd-stable@freebsd.org> Subject: Re: Is it necessary to bump target triple for lib32 Message-ID: <71258350-5A9A-4055-869B-857A16759C30@FreeBSD.org> In-Reply-To: <CAPH9q1r%2BDChJtGxpt-QzDBd4hsRBiiwt0ie5DR4-uWkP_=AFoA@mail.gmail.com> References: <CAPH9q1r%2BDChJtGxpt-QzDBd4hsRBiiwt0ie5DR4-uWkP_=AFoA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_856CE1B5-CAAA-4026-A608-6780E85EDE3E Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii On 19 Oct 2019, at 05:51, Jeremy <jeremy.m.cox@gmail.com> wrote: > > While I was doing a buildworld for FreeBSD 12 stable (r353745) for amd64, I > noticed the target triple was set at x86_64-unknown-freebsd12.0 while it > was building the 32 bit libraries. I was wondering if it was necessary to > bump it to 12.1 now that 12.1 is getting ready for release, or if it > doesn't matter either way. I believe the relevant commit was from > (r338268). In any case, buildworld completed with no issues. > > If it's not necessary, sorry for the noise. You are right, this is coming from Makefile.libcompat: $ grep freebsd12 Makefile.libcompat LIB32CPUFLAGS+= -target x86_64-unknown-freebsd12.0 LIB32CPUFLAGS= -target mipsel-unknown-freebsd12.0 LIB32CPUFLAGS= -target mips-unknown-freebsd12.0 Glen, I think you have a list somewhere of the files that need to have their versions bumped for releng branches, could you please add Makefile.libcompat to it too? Maybe at one point we should have one source of truth for that obtaining that version number... :) -Dimitry --Apple-Mail=_856CE1B5-CAAA-4026-A608-6780E85EDE3E Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.2 iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCXaxGFgAKCRCwXqMKLiCW ozzwAJ0dhyiGXMI78xObNclZdDr6INXgNQCgxn1TKacIOw9S9SYwTdmhIs64nM0= =5Kpc -----END PGP SIGNATURE----- --Apple-Mail=_856CE1B5-CAAA-4026-A608-6780E85EDE3E--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?71258350-5A9A-4055-869B-857A16759C30>