From owner-freebsd-testing@freebsd.org Tue Feb 26 22:55:42 2019 Return-Path: Delivered-To: freebsd-testing@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6650D1507132 for ; Tue, 26 Feb 2019 22:55:42 +0000 (UTC) (envelope-from lwhsu.freebsd@gmail.com) Received: from mail-yw1-f67.google.com (mail-yw1-f67.google.com [209.85.161.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 98F7B8006B for ; Tue, 26 Feb 2019 22:55:41 +0000 (UTC) (envelope-from lwhsu.freebsd@gmail.com) Received: by mail-yw1-f67.google.com with SMTP id x21so6565277ywx.11 for ; Tue, 26 Feb 2019 14:55:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=Wk7odRJLPnAWnxaxeHiqbNDY7PJ/4nKc2QhqP4jC0vU=; b=KBU8eTOqmzjhtqBNHNPkkofTZUW1OFLbH/R5vvE1z9zbplzUQRqUjQ8Hm5R7DDwq1Y b4rKVmpC7t93L1R9lFmfM4xPcX7DPe2gbkQdoesoJ+4sJqWBuPSmcN9J4gy+eUcLuBSc gpIWovqtzolgFQ3ZJHR+0ITELrjMLLP1G0fADpgK53a/YN62HjMPgjbp1h6OTIHydkGB GA4fTXH5zDgFZOyKCaO+E6aHeicDpAPVGsTtAAx8yugUoEB8IHqlzyB5kFrNFwCWXyK/ ezQ/sxtXfJlqOqoMGFBjwaQiWgS1vpNRiu3Cs09lVPlJ2AJjdMotQhcwzbWki3uBOC8t KoxQ== X-Gm-Message-State: AHQUAuaNIqYcfDY8RBzEP3hPri883FXxRT4dfjhXZeS7NrtSFUvZl9If eH0kkLNWTEJPlnqTe86ccaQ2KZ2HXYaFDfzGy267+ZaL X-Google-Smtp-Source: AHgI3IajoOq9JD3nHYedEAnyZqCTJRf//2Zmda+1ZlhSWw0AKRu8Mgd2YmEtq9A9SvUz2G6ADvy51xKI3V8MZSuCx8A= X-Received: by 2002:a25:25d4:: with SMTP id l203mr6197359ybl.490.1551221344158; Tue, 26 Feb 2019 14:49:04 -0800 (PST) MIME-Version: 1.0 From: Li-Wen Hsu Date: Wed, 27 Feb 2019 06:48:48 +0800 Message-ID: Subject: FreeBSD CI Weekly Report 2019-02-24 To: freebsd-testing@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 98F7B8006B X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of lwhsufreebsd@gmail.com designates 209.85.161.67 as permitted sender) smtp.mailfrom=lwhsufreebsd@gmail.com X-Spamd-Result: default: False [-3.94 / 15.00]; RWL_MAILSPIKE_GOOD(0.00)[67.161.85.209.rep.mailspike.net : 127.0.0.18]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; TO_DN_NONE(0.00)[]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; NEURAL_HAM_SHORT(-0.76)[-0.759,0]; FORGED_SENDER(0.30)[lwhsu@freebsd.org,lwhsufreebsd@gmail.com]; MIME_TRACE(0.00)[0:+]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TAGGED_FROM(0.00)[]; TO_DOM_EQ_FROM_DOM(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.996,0]; FROM_NEQ_ENVFROM(0.00)[lwhsu@freebsd.org,lwhsufreebsd@gmail.com]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-testing@freebsd.org]; DMARC_NA(0.00)[freebsd.org]; RCPT_COUNT_ONE(0.00)[1]; IP_SCORE(-1.18)[ipnet: 209.85.128.0/17(-3.81), asn: 15169(-2.01), country: US(-0.07)]; RCVD_IN_DNSWL_NONE(0.00)[67.161.85.209.list.dnswl.org : 127.0.5.0]; RCVD_TLS_LAST(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Feb 2019 22:55:42 -0000 (bcc -current and -stable for more audience) FreeBSD CI Weekly Report 2019-02-24 =================================== Here is a summary of the FreeBSD Continuous Integration results for the period from 2019-02-18 to 2019-02-24. During this period, we have: * 2214 builds (98.7% passed, 1.3% failed) were executed on aarch64, amd64, armv6, armv7, i386, mips, mips64, powerpc, powerpc64, powerpcspe, riscv64, sparc64 architectures for head, stable/12, stable/11 branches. * 575 test runs (32.2% passed, 65.5% unstable, 2.3% exception) were executed on amd64, i386, riscv64 architectures for head, stable/12, stable/11 branches. * 7 doc buils (100% passed) If any of the issues found by CI are in your area of interest or expertise please investigate the PRs listed below. Web version of this report is available at https://hackmd.io/s/rJAJu2RSE and archive is available at http://hackfoldr.org/freebsd-ci-report/, any help is welcome. ## Fixed Tests * https://ci.freebsd.org/job/FreeBSD-head-amd64-test/ * lib.libc.sys.sendfile_test.hdtr_positive_v4 * lib.libc.sys.sendfile_test.hdtr_positive_v6 Fixed (Remove expected failure) in https://svnweb.freebsd.org/changeset/base/344310 ## Failing Tests * https://ci.freebsd.org/job/FreeBSD-head-amd64-test_zfs/ * There are ~60 failing cases, including flakey ones, see https://ci.freebsd.org/job/FreeBSD-head-amd64-test_zfs/lastCompletedBuild/testReport/ for more details * https://ci.freebsd.org/job/FreeBSD-head-amd64-dtrace_test/ * common.rates.t_dtrace_contrib.tst_switchrate_d * common.syscall.t_dtrace_contrib.tst_args_d * common.ip.t_dtrace_contrib.tst_ipv4localsctp_ksh * common.ip.t_dtrace_contrib.tst_localsctpstate_ksh * https://ci.freebsd.org/job/FreeBSD-head-i386-test/ * sys.netmap.ctrl-api-test.main * sys.opencrypto.runtests.main * lib.libc.regex.exhaust_test.regcomp_too_big * lib.libregex.exhaust_test.regcomp_too_big * sys.kern.coredump_phnum_test.coredump_phnum WIP: https://reviews.freebsd.org/D18495 * https://ci.freebsd.org/job/FreeBSD-stable-12-i386-test/ * sbin.bectl.bectl_test.bectl_mount * sys.netmap.ctrl-api-test.main * sys.opencrypto.runtests.main * lib.libc.regex.exhaust_test.regcomp_too_big * lib.libregex.exhaust_test.regcomp_too_big * sys.kern.coredump_phnum_test.coredump_phnum WIP: https://reviews.freebsd.org/D18495 * https://ci.freebsd.org/job/FreeBSD-stable-11-amd64-test/ * usr.bin.procstat.procstat_test.kernel_stacks * https://ci.freebsd.org/job/FreeBSD-stable-11-i386-test/ * sys.netmap.ctrl-api-test.main * sys.opencrypto.runtests.main * usr.bin.procstat.procstat_test.kernel_stacks * local.kyua.* (31 cases) * local.lutok.* (3 cases) ## Disabled Tests * lib.libc.sys.mmap_test.mmap_truncate_signal https://bugs.freebsd.org/211924 * sys.fs.tmpfs.mount_test.large https://bugs.freebsd.org/212862 * sys.fs.tmpfs.link_test.kqueue https://bugs.freebsd.org/213662 * sys.kqueue.libkqueue.kqueue_test.main https://bugs.freebsd.org/233586 * usr.bin.procstat.procstat_test.command_line_arguments https://bugs.freebsd.org/233587 * usr.bin.procstat.procstat_test.environment https://bugs.freebsd.org/233588 ## Open Issues ### Cause build fails * [233339: genassym.o build race](https://bugs.freebsd.org/233339) * Patch available: https://people.freebsd.org/~bdrewery/patches/PR233339.diff * [233735: Possible build race: genoffset.o /usr/src/sys/sys/types.h: error: machine/endian.h: No such file or directory](https://bugs.freebsd.org/233735) * [233769: Possible build race: ld: error: unable to find library -lgcc_s](https://bugs.freebsd.org/233769) ### Others [Tickets related to testing@](https://preview.tinyurl.com/y9maauwg) ## Other News * After creating pipeline for clang800-import branch in project/, now we support adding pipeline for other projects. Please contact jenkins-admin through "Testing & CI" component of "Services" product on https://bugs.freebsd.org From owner-freebsd-testing@freebsd.org Wed Feb 27 13:00:49 2019 Return-Path: Delivered-To: freebsd-testing@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 564E5151C7A3; Wed, 27 Feb 2019 13:00:49 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id EF91F7566A; Wed, 27 Feb 2019 13:00:48 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com [209.85.208.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id A0BC75E6C; Wed, 27 Feb 2019 13:00:48 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-lj1-f169.google.com with SMTP id z7so13710903lji.0; Wed, 27 Feb 2019 05:00:48 -0800 (PST) X-Gm-Message-State: AHQUAuaDksdg5ZY28U5ZRcT3n//Y9olD42j/bAV51h8kFPcpLn9UWbz1 W2BKdxAsrcGhPc7vMvcYc8SOfcgupxPXRx8EcUI= X-Google-Smtp-Source: APXvYqxQySV40zsI3j5BHQGlqg5Oq7bM2WjZRUGdnWr6aSDzZg1HbrCClW+0s4CJqCuLo0fniR/fK1nHUmivn5netZ8= X-Received: by 2002:a2e:9ec2:: with SMTP id h2mr1381055ljk.186.1551272447143; Wed, 27 Feb 2019 05:00:47 -0800 (PST) MIME-Version: 1.0 References: <20190227035542.GA60321@www.zefox.net> <4c983cf9d039bf95bd19433cbf640f2ae68b0580.camel@freebsd.org> In-Reply-To: <4c983cf9d039bf95bd19433cbf640f2ae68b0580.camel@freebsd.org> From: Kyle Evans Date: Wed, 27 Feb 2019 07:00:35 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Kernel build failure on rpi2 at 344613 To: Ian Lepore , freebsd-testing@freebsd.org Cc: bob prohaska , "freebsd-arm@freebsd.org" , Li-Wen Hsu Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: EF91F7566A X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.93 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.94)[-0.936,0]; ASN(0.00)[asn:11403, ipnet:2610:1c1:1::/48, country:US]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Feb 2019 13:00:49 -0000 On Tue, Feb 26, 2019 at 11:06 PM Ian Lepore wrote: > > On Tue, 2019-02-26 at 19:55 -0800, bob prohaska wrote: > > In trying to make world and kernel on RPI2 at r344613 buildworld ran > > to > > completion, but buildkernel stopped wtih > > --- machdep_boot.o --- > > /usr/src/sys/arm/arm/machdep_boot.c:170:34: error: too few arguments > > to function call, single argument 'cmdline' was not specified > > boothowto |= boot_parse_cmdline(); > > ~~~~~~~~~~~~~~~~~~ ^ > > /usr/src/sys/sys/boot.h:37:1: note: 'boot_parse_cmdline' declared > > here > > int boot_parse_cmdline(char *cmdline); > > ^ > > 1 error generated. > > *** [machdep_boot.o] Error code 1 > > > > make[2]: stopped in /usr/obj/usr/src/sys/RPI2 > > > > The machine is running > > FreeBSD www.zefox.com 11.2-STABLE FreeBSD 11.2-STABLE #0 r343555: Wed > > Jan 30 04:55:19 PST 2019 bob@www.zefox.com:/usr/obj/usr/src/sys/R > > PI2 arm > > > > Any idea how to get past this impediment? > > > > Thanks for reading, > > > > bob prohaska > > > > Fix should be committed soon; to get moving right away, apply this > patch: > > https://svnweb.freebsd.org/base/head/sys/arm/arm/machdep_boot.c?r1=336244&r2=336262&view=patch > I clearly failed to catch it, but I'm also trying to decide why Jenkins' stable/11 job didn't catch it... machdep_boot is standard arm*, but the build didn't skip a beat. CC'ing lwhsu@/freebsd-testing@ because that seems like it might be indicative of a slightly larger problem. In either case, thanks for the pointer! MFC is getting committed momentarily. From owner-freebsd-testing@freebsd.org Wed Feb 27 15:44:18 2019 Return-Path: Delivered-To: freebsd-testing@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6730515203D1 for ; Wed, 27 Feb 2019 15:44:18 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound1.eu.mailhop.org (outbound1.eu.mailhop.org [52.28.251.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 69A59838C9 for ; Wed, 27 Feb 2019 15:44:17 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1551281286; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=kKKvsiZC2TI066dzyiIwzwt9td5eeSSb+jZrrUz0J144Bs7Glwkfx0Z/jhr2BtTHCeQzJQ370aKVt 8VcQnaJP0BBZE5s5wDKH0CY3vT/oZJnsEVvkE8FLQ/tYF5wduoVBtyYOSG+bXlg9nLOpfbQyf97y3x n8BSQ5896dH9zzQ4TpYV6nWQAGEKhoykI4hRL94aDexbg9qh6dv/07cDg8q3tcGRYX4kYjQF6uQXz0 A5C3rZILrJpA58n5Aip21iN1mHgpN0xlMFpbO42gYxDcwG625taHx39M7aOVHcxc+TUF6LYR5i7h4Z BYy4Di5hK4ejv0YbCGl+cefMWgDclMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:dkim-signature:from; bh=Az6hiNyspiBZgQAnXqhyLVs+svA286PeqhO2HLHhRaM=; b=H+rYkDpT2s8vIWNDe2t6XWtJy8gT7uC8wGRqH6X5AtVPNP6/4K1Df0k5aqPEaoR1oKQemA+1pUESe 7lV7xkZv4zwt+HM7qTqTPhJ77SsKxoPA+y+ndyXOrWGRXaRP4UOPSzBp34n+NVNdGUvKC6sia2SSeX w4KUonefioBbzY7Li4gktFBjhX1D42wKyZ3/EtbZlE3HMaMIM9Zt4BUfnItIjkMa65qNAWCbQmomb9 ErQ+7kTLXXY/nqp40bdTQ6xXCdn9PydQnBZqffiyu8k3PvdqbFZM59ElCV6rouhHn6zNyBIqjMPNiW sThsteVDFngTvmoE7yPRZwVrsJxrx2A== ARC-Authentication-Results: i=1; outbound3.eu.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:from; bh=Az6hiNyspiBZgQAnXqhyLVs+svA286PeqhO2HLHhRaM=; b=WQRKs1J3uy1sPUgMCqNhPFLQn6JsYRWjS1Y6qau7TwdLfMm6oLc437KrUir5CRNk+ftzKRNkVBoZl 0Z77HrwIkxCN2Nv6q1YA6s9RukJSMS0CKnZ3wqA/HHfpgblIZKFMnWxMR+0UF3pD5NI2UIqf7Orkx0 8FL3SmGI0YNjwDaTnIxFLocxkOmD4pHRZjqq7BdA2IJMjZc5xQQ3Ux+0BFjlp+NpHUiJY4eAnGKLb+ rqz0FVcIK2Dk3mbhafsX2mpaA5PGjgaHHHvb0y5bYpom0rwDbbpzVfFR5/ge2f/NT7iL4I9Xb+VqjS j6uFF6Ys+bxMYlY1RlFbktPaaXX0+Ww== X-MHO-RoutePath: aGlwcGll X-MHO-User: 3f4c16e0-3aa4-11e9-908b-352056dbf2de X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound3.eu.mailhop.org (Halon) with ESMTPSA id 3f4c16e0-3aa4-11e9-908b-352056dbf2de; Wed, 27 Feb 2019 15:27:54 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id x1RFRpEm004248; Wed, 27 Feb 2019 08:27:51 -0700 (MST) (envelope-from ian@freebsd.org) Message-ID: <8ecba76475a9e59f966e4db6e52e36a171bf0707.camel@freebsd.org> Subject: Re: Kernel build failure on rpi2 at 344613 From: Ian Lepore To: Kyle Evans , freebsd-testing@freebsd.org Cc: "freebsd-arm@freebsd.org" , Li-Wen Hsu Date: Wed, 27 Feb 2019 08:27:51 -0700 In-Reply-To: References: <20190227035542.GA60321@www.zefox.net> <4c983cf9d039bf95bd19433cbf640f2ae68b0580.camel@freebsd.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 69A59838C9 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.98 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.983,0]; ASN(0.00)[asn:16509, ipnet:52.28.0.0/16, country:US]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Feb 2019 15:44:18 -0000 On Wed, 2019-02-27 at 07:00 -0600, Kyle Evans wrote: > On Tue, Feb 26, 2019 at 11:06 PM Ian Lepore wrote: > > > > On Tue, 2019-02-26 at 19:55 -0800, bob prohaska wrote: > > > In trying to make world and kernel on RPI2 at r344613 buildworld > > > ran > > > to > > > completion, but buildkernel stopped wtih > > > --- machdep_boot.o --- > > > /usr/src/sys/arm/arm/machdep_boot.c:170:34: error: too few > > > arguments > > > to function call, single argument 'cmdline' was not specified > > > boothowto |= boot_parse_cmdline(); > > > ~~~~~~~~~~~~~~~~~~ ^ > > > /usr/src/sys/sys/boot.h:37:1: note: 'boot_parse_cmdline' declared > > > here > > > int boot_parse_cmdline(char *cmdline); > > > ^ > > > 1 error generated. > > > *** [machdep_boot.o] Error code 1 > > > > > > make[2]: stopped in /usr/obj/usr/src/sys/RPI2 > > > > > > The machine is running > > > FreeBSD www.zefox.com 11.2-STABLE FreeBSD 11.2-STABLE #0 r343555: > > > Wed > > > Jan 30 04:55:19 PST 2019 bob@www.zefox.com:/usr/obj/usr/src/s > > > ys/R > > > PI2 arm > > > > > > Any idea how to get past this impediment? > > > > > > Thanks for reading, > > > > > > bob prohaska > > > > > > > Fix should be committed soon; to get moving right away, apply this > > patch: > > > > https://svnweb.freebsd.org/base/head/sys/arm/arm/machdep_boot.c?r1=336244&r2=336262&view=patch > > > > I clearly failed to catch it, but I'm also trying to decide why > Jenkins' stable/11 job didn't catch it... machdep_boot is standard > arm*, but the build didn't skip a beat. CC'ing lwhsu@/freebsd- > testing@ > because that seems like it might be indicative of a slightly larger > problem. > > In either case, thanks for the pointer! MFC is getting committed > momentarily. > _______________________________________________ > That code is conditional on option LINUX_BOOT_ABI, but that option should be on for GENERIC and all rpi builds. -- Ian From owner-freebsd-testing@freebsd.org Wed Feb 27 15:50:05 2019 Return-Path: Delivered-To: freebsd-testing@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6A3FD152059B; Wed, 27 Feb 2019 15:50:05 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1157283A72; Wed, 27 Feb 2019 15:50:05 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id B682570CF; Wed, 27 Feb 2019 15:50:04 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-lj1-f175.google.com with SMTP id w6so14400314ljd.7; Wed, 27 Feb 2019 07:50:04 -0800 (PST) X-Gm-Message-State: AHQUAubdn7f1Jq+qk1F/U7zLC/XWHpLbC+FqC8CQN9jLfXynFHFGHzjK /KDeFwd+NtqVfzXvEKT2DzYVifTB96Li5tI9/QY= X-Google-Smtp-Source: APXvYqzN35mUpTbP6GEKYclrcOuTzpnkJlk4i7eZ9XwWfkknUiRhLjSdfO3EiKBpp28qlwc4vwE0BRyh+gVTLiaa5Bk= X-Received: by 2002:a2e:9ec2:: with SMTP id h2mr1840737ljk.186.1551282603153; Wed, 27 Feb 2019 07:50:03 -0800 (PST) MIME-Version: 1.0 References: <20190227035542.GA60321@www.zefox.net> <4c983cf9d039bf95bd19433cbf640f2ae68b0580.camel@freebsd.org> <8ecba76475a9e59f966e4db6e52e36a171bf0707.camel@freebsd.org> In-Reply-To: <8ecba76475a9e59f966e4db6e52e36a171bf0707.camel@freebsd.org> From: Kyle Evans Date: Wed, 27 Feb 2019 09:49:32 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Kernel build failure on rpi2 at 344613 To: Ian Lepore Cc: Kyle Evans , freebsd-testing@freebsd.org, "freebsd-arm@freebsd.org" , Li-Wen Hsu Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 1157283A72 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.96 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_LONG(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.97)[-0.966,0]; ASN(0.00)[asn:11403, ipnet:2610:1c1:1::/48, country:US] X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Feb 2019 15:50:05 -0000 On Wed, Feb 27, 2019 at 9:44 AM Ian Lepore wrote: > > On Wed, 2019-02-27 at 07:00 -0600, Kyle Evans wrote: > > On Tue, Feb 26, 2019 at 11:06 PM Ian Lepore wrote: > > > > > > On Tue, 2019-02-26 at 19:55 -0800, bob prohaska wrote: > > > > In trying to make world and kernel on RPI2 at r344613 buildworld > > > > ran > > > > to > > > > completion, but buildkernel stopped wtih > > > > --- machdep_boot.o --- > > > > /usr/src/sys/arm/arm/machdep_boot.c:170:34: error: too few > > > > arguments > > > > to function call, single argument 'cmdline' was not specified > > > > boothowto |= boot_parse_cmdline(); > > > > ~~~~~~~~~~~~~~~~~~ ^ > > > > /usr/src/sys/sys/boot.h:37:1: note: 'boot_parse_cmdline' declared > > > > here > > > > int boot_parse_cmdline(char *cmdline); > > > > ^ > > > > 1 error generated. > > > > *** [machdep_boot.o] Error code 1 > > > > > > > > make[2]: stopped in /usr/obj/usr/src/sys/RPI2 > > > > > > > > The machine is running > > > > FreeBSD www.zefox.com 11.2-STABLE FreeBSD 11.2-STABLE #0 r343555: > > > > Wed > > > > Jan 30 04:55:19 PST 2019 bob@www.zefox.com:/usr/obj/usr/src/s > > > > ys/R > > > > PI2 arm > > > > > > > > Any idea how to get past this impediment? > > > > > > > > Thanks for reading, > > > > > > > > bob prohaska > > > > > > > > > > Fix should be committed soon; to get moving right away, apply this > > > patch: > > > > > > > https://svnweb.freebsd.org/base/head/sys/arm/arm/machdep_boot.c?r1=336244&r2=336262&view=patch > > > > > > > I clearly failed to catch it, but I'm also trying to decide why > > Jenkins' stable/11 job didn't catch it... machdep_boot is standard > > arm*, but the build didn't skip a beat. CC'ing lwhsu@/freebsd- > > testing@ > > because that seems like it might be indicative of a slightly larger > > problem. > > > > In either case, thanks for the pointer! MFC is getting committed > > momentarily. > > _______________________________________________ > > > That code is conditional on option LINUX_BOOT_ABI, but that option > should be on for GENERIC and all rpi builds. > Ahh, I missed that. stable/11's CI build only does BEAGLEBONE IMX6 VIRT; we should add RPI2 or RPI-B to that list to broaden the horizons a bit. From owner-freebsd-testing@freebsd.org Wed Feb 27 18:05:48 2019 Return-Path: Delivered-To: freebsd-testing@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A06541500CD2 for ; Wed, 27 Feb 2019 18:05:48 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 94FD788FF6 for ; Wed, 27 Feb 2019 18:05:47 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-lf1-f50.google.com with SMTP id v185so1773619lfa.11 for ; Wed, 27 Feb 2019 10:05:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=i9+ZdWl0fnA5ii8cf4DOb64WB7JBfrzlJsEzLrhc7Ag=; b=KlnfKl4xu176LO+ksIveq/VHff6BbjqRZvKDK2UVRvGecxW0orFh3zw73pis1HkzPF dbFZHtGNa2RFHASoY3mbeZoBYkt8XglE1FFMbDBnLO1kMzzLCuO317hYk2FEnfqMhfzF ZjhGl9kTleJT07bvbt7M8nWr1Yy93dO3dmfocdXuOpTaEbvA46yYhfbPf74UzqK0Z8x2 5Ns9Dbhkzlius67rtcLlxXqvICPVlegDovijCK2Wt+MrFKfMKI9cz+m8AI9bMuwNHO7B YHl/K9FlgIbmg25WmH/6SJvTgGqqHW082r7xZWnrG8NwwwFCbbPw1M23/ZVM9UTGDfrN DAGw== X-Gm-Message-State: AHQUAuaaUv3J29zWYbhqdZ3S5qIDMuzzOi87XmGoBNTVcoBSO7g1wD0S q2wMOcDTXkDyyieM740W14GJwrkJlgf7MKZyuOk0qg== X-Google-Smtp-Source: AHgI3Ib4Dz5hHy5wQZKdHmHXgiQmbLikB79ktggZs/1LPDswzGzNsV2PjNQ4XQBJfGt/mN6CRVJi8OMXPBa+S6PJaks= X-Received: by 2002:a19:4948:: with SMTP id l8mr1770263lfj.156.1551290353321; Wed, 27 Feb 2019 09:59:13 -0800 (PST) MIME-Version: 1.0 From: Alan Somers Date: Wed, 27 Feb 2019 10:59:01 -0700 Message-ID: Subject: atf-c++ vs GoogleTest vs share/mk To: "freebsd-testing@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 94FD788FF6 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of asomers@gmail.com designates 209.85.167.50 as permitted sender) smtp.mailfrom=asomers@gmail.com X-Spamd-Result: default: False [-4.03 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; RCVD_COUNT_TWO(0.00)[2]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-testing@freebsd.org]; DMARC_NA(0.00)[freebsd.org]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_TRACE(0.00)[0:+]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; NEURAL_HAM_SHORT(-0.85)[-0.845,0]; RCVD_IN_DNSWL_NONE(0.00)[50.167.85.209.list.dnswl.org : 127.0.5.0]; TO_DN_EQ_ADDR_ALL(0.00)[]; RCVD_TLS_LAST(0.00)[]; FORGED_SENDER(0.30)[asomers@freebsd.org,asomers@gmail.com]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[asomers@freebsd.org,asomers@gmail.com]; IP_SCORE(-1.18)[ipnet: 209.85.128.0/17(-3.81), asn: 15169(-2.02), country: US(-0.07)]; TO_DOM_EQ_FROM_DOM(0.00)[] X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Feb 2019 18:05:48 -0000 So it turns out to be impossible to use GoogleMock with atf-c++. The problem is that atf-c++'s only way to report a test failure is ATF_FAIL, which immediately terminates the program on failure. That conflicts with the way that GoogleMock uses pthreads, which is to report a failure while a pthread mutex is locked. atf-c++ has many other shortcomings, too. It lacks the ATF_CHECK_* macros, and its syntax is surprisingly inconsistent with atf-c's. So I tried writing a C++ program that uses atf-c instead. But the Makefiles in share/mk make that a frustrating proposition. They don't want C++ programs to link to atf-c, and they don't want atf-c programs to be built in C++ mode. Googletest would probably work fine, but I would sorely miss ATF's test case isolation features. So what should I do? Should I fix atf-c++? That would entail basically copying over everything from atf-c, which would be a lot of work. Or should I hack atf.test.mk to allow C++ programs to use atf-c? That would be ugly, but easier. Or should I just switch to Googletest, and live with its fragile cleanup handlers? -Alan From owner-freebsd-testing@freebsd.org Wed Feb 27 19:46:15 2019 Return-Path: Delivered-To: freebsd-testing@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 49A0215030B8 for ; Wed, 27 Feb 2019 19:46:15 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com [IPv6:2607:f8b0:4864:20::42c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 35E538CA35; Wed, 27 Feb 2019 19:46:14 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf1-x42c.google.com with SMTP id d25so8495300pfn.8; Wed, 27 Feb 2019 11:46:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=6GXDeQd3OSc/f8qyJrn6gf8cNbPfgQRtWekPysF7lBM=; b=e7OScNnZ+dxJU5UXt0/+fF0tSs/ocQ9ahdd3147TE7XGDNP1INvgZgmabNpqlGreWG z2NibKv7ku2AbM1rgh5ZbwZ2oKSHHjYxaxJYmJba1tzqDWpnk0k0u6ssx6R0knDFD+Yk 29UZj3dDdzjJvPO8PmbOytLLcNLGW1Vn4l1k53MfVlyOB9M1hqqL98YITFWqfTee2YeE Y9hZTFXIfr7rBxDU4LXwqpWWgYfb0rcrENlItSBigDrXIyL4ij8bAb4dNJ3RnOGDi5+h gU5juknveiZV6Yx5hX7xrxeCiGekvtrSQSvec89b+Ttzcqqy2xhJeDZo4ILkH44BIKDJ XCvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=6GXDeQd3OSc/f8qyJrn6gf8cNbPfgQRtWekPysF7lBM=; b=ZwzCFklwtQd7iHnJo4d4qwy/D1KpaiQ+oXgOmSrWdJ8opYFeek1nQaHhv3QcVJISqB KcakAaccaBuS5+IDLtpIP3ti2w05YYsjp4F1Wyd2Cwa0CaTU2ykK5Ny6hIu/RhRt9/Zz qJt3pQM6PDOy/+Nwim6irORT7X4BK9JE7iFrGqYBomo7dXE7qH4vQKJx/mNUHscRkeFi CYgRSeSBPbPcbvB1esnHhPIpcuS2SDEJbI0yldUudLR2pw3//v+/jrIUBMniPycw5UdO 0Tmi/wA8bW9+nrNwBZ0OON7zZS4R+Ut7tbPILIVL8dFwIa+5/dcg4Fd3pZQy9YLTwD1s wAVQ== X-Gm-Message-State: AHQUAuamL1gvZQxIJ0jkuX9BL/GxXj/vzwagODj1q3EXsrmpzuIk3Ry0 goKeWKF2u7QcSskFXHuye1DcKo62 X-Google-Smtp-Source: AHgI3IbIkHl6M77uP8qqqk9WH0DrUurQB2QOEkjamcBYZV1o6xVez5AwkAhrcSp81GwJtYrGwwP26Q== X-Received: by 2002:a62:b502:: with SMTP id y2mr3354388pfe.212.1551296772688; Wed, 27 Feb 2019 11:46:12 -0800 (PST) Received: from [172.17.7.154] (163-64-212-66.spl.org. [66.212.64.163]) by smtp.gmail.com with ESMTPSA id m64sm41140612pfi.149.2019.02.27.11.46.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Feb 2019 11:46:12 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Subject: Re: atf-c++ vs GoogleTest vs share/mk From: Enji Cooper In-Reply-To: Date: Wed, 27 Feb 2019 11:46:11 -0800 Cc: "freebsd-testing@freebsd.org" , Ed Maste , Julio Merino , "Jonathan T. Looney" Content-Transfer-Encoding: quoted-printable Message-Id: References: To: Alan Somers X-Mailer: Apple Mail (2.3445.102.3) X-Rspamd-Queue-Id: 35E538CA35 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=e7OScNnZ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of yaneurabeya@gmail.com designates 2607:f8b0:4864:20::42c as permitted sender) smtp.mailfrom=yaneurabeya@gmail.com X-Spamd-Result: default: False [-6.20 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_FROM(0.00)[gmail.com]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; MV_CASE(0.50)[]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; NEURAL_HAM_SHORT(-0.98)[-0.976,0]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; MID_RHS_MATCH_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; IP_SCORE(-2.71)[ip: (-8.77), ipnet: 2607:f8b0::/32(-2.69), asn: 15169(-2.02), country: US(-0.07)]; RCVD_IN_DNSWL_NONE(0.00)[c.2.4.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0] X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Feb 2019 19:46:15 -0000 > On Feb 27, 2019, at 9:59 AM, Alan Somers wrote: >=20 > So it turns out to be impossible to use GoogleMock with atf-c++. The > problem is that atf-c++'s only way to report a test failure is > ATF_FAIL, which immediately terminates the program on failure. That > conflicts with the way that GoogleMock uses pthreads, which is to > report a failure while a pthread mutex is locked. atf-c++ has many > other shortcomings, too. It lacks the ATF_CHECK_* macros, and its > syntax is surprisingly inconsistent with atf-c=E2=80=99s. Yes, I=E2=80=99ve brought that up before in the past. This is part of = the reason why I want to abandon/kill off atf-c++ in favor of something = more functionally complete, i.e., googletest > So I tried writing a C++ program that uses atf-c instead. But the > Makefiles in share/mk make that a frustrating proposition. They don't > want C++ programs to link to atf-c, and they don't want atf-c programs > to be built in C++ mode. Well=E2=80=A6 yeah. This makes sense. > Googletest would probably work fine, but I would sorely miss ATF's > test case isolation features. In what ways? Using plain tests builds in some level of isolation, but = it=E2=80=99s not perfect, and this is the direction I=E2=80=99m taking = Googletest for a first iteration. > So what should I do? Should I fix atf-c++? That would entail > basically copying over everything from atf-c, which would be a lot of > work. Or should I hack atf.test.mk to allow C++ programs to use > atf-c? That would be ugly, but easier. Or should I just switch to > Googletest, and live with its fragile cleanup handlers? Using Googletest with Googlemock is the way that I intend to have things = work. Adding ATF into the mix as another layer seems like the ultimate = path to pain, since ATF=E2=80=99s libraries require full stack = management in order to do things like handle sandboxing, etc, and = Googlemock does some clever things with C++ that seems like they would = conflict with ATF=E2=80=99s goals. I=E2=80=99ll work on closing out the first iteration of = googletest.test.mk by the end of the week and work on getting the code = committed to ^/head. In parallel, I=E2=80=99ll focus on adding = googletest driver support to kyua (I have part of it done, but there are = still some missing pieces around test listing and results parsing), = which is the next required phase in order to make googletest function = more flexibly with kyua. Thanks, -Enji PS I appreciate the reminder about documenting my work and my goals on = the wiki. I=E2=80=99ll do that now.= From owner-freebsd-testing@freebsd.org Wed Feb 27 20:43:01 2019 Return-Path: Delivered-To: freebsd-testing@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3F2391504BCE for ; Wed, 27 Feb 2019 20:43:01 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 85A0E8F0C4; Wed, 27 Feb 2019 20:42:59 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-lf1-f46.google.com with SMTP id g12so13451046lfb.13; Wed, 27 Feb 2019 12:42:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=mrfczeiX4hHclqckP+gAuBXZOG8eZdoWvIc1O8TA+mw=; b=oRhIiP3tCxEkb4nr0YztfwpZ2n0WF1MdUhhd8hIU5J91JvpiJ/DCD/UNtSB2hpUSmT zIdPvHLjqeDTNPPugY6f1A6wVOrkELuk75jBZvnv4ayNIrrBJOwSVpBEjRyEoY12UFKJ fj06ZoHe3yyxeseCqyQ9UTmMsrhEi8VdH/6re7aTTVhwEfCkdNm5RpYhqoaVAgHtbD4F c3foKkQlv+gLzBtQgDzOHuOTxco72G1Yt04f3AO64aMemwcRy2Eax74hKdi4TU+z/SLE yB+/ST5oNb0+I3P+KDMvySJToC84PuVj9/rrhkf+UtN7sqwbXCRQPCbChdOKimbpylZY mQkg== X-Gm-Message-State: AHQUAuaoDOYde5xmpdat6fnWJblLHiif66AK+8h5rzEfjGCaD6oMX45Y JftpHwLvEYL5erpyAlfXE77XHM2K+RvGpeuCuI4= X-Google-Smtp-Source: AHgI3Ib8JotaBlbyXPgDf1GJ2iV0ASEyH7J3YwK9bm0KUvjpgnrQaEauQnaQAqQ+yhRZOzh5bxOAfib4KTqZONYWzs4= X-Received: by 2002:ac2:415a:: with SMTP id c26mr2129485lfi.62.1551300170885; Wed, 27 Feb 2019 12:42:50 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Alan Somers Date: Wed, 27 Feb 2019 13:42:38 -0700 Message-ID: Subject: Re: atf-c++ vs GoogleTest vs share/mk To: Enji Cooper Cc: "freebsd-testing@freebsd.org" , Ed Maste , Julio Merino , "Jonathan T. Looney" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 85A0E8F0C4 X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of asomers@gmail.com designates 209.85.167.46 as permitted sender) smtp.mailfrom=asomers@gmail.com X-Spamd-Result: default: False [-3.37 / 15.00]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; DMARC_NA(0.00)[freebsd.org]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; NEURAL_HAM_SHORT(-0.18)[-0.177,0]; RCVD_IN_DNSWL_NONE(0.00)[46.167.85.209.list.dnswl.org : 127.0.5.0]; RCVD_TLS_LAST(0.00)[]; FORGED_SENDER(0.30)[asomers@freebsd.org,asomers@gmail.com]; FREEMAIL_TO(0.00)[gmail.com]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[asomers@freebsd.org,asomers@gmail.com]; IP_SCORE(-1.18)[ipnet: 209.85.128.0/17(-3.81), asn: 15169(-2.02), country: US(-0.07)]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Feb 2019 20:43:01 -0000 On Wed, Feb 27, 2019 at 12:46 PM Enji Cooper wrote: > > > > On Feb 27, 2019, at 9:59 AM, Alan Somers wrote: > > > > So it turns out to be impossible to use GoogleMock with atf-c++. The > > problem is that atf-c++'s only way to report a test failure is > > ATF_FAIL, which immediately terminates the program on failure. That > > conflicts with the way that GoogleMock uses pthreads, which is to > > report a failure while a pthread mutex is locked. atf-c++ has many > > other shortcomings, too. It lacks the ATF_CHECK_* macros, and its > > syntax is surprisingly inconsistent with atf-c=E2=80=99s. > > Yes, I=E2=80=99ve brought that up before in the past. This is part of the= reason why I want to abandon/kill off atf-c++ in favor of something more f= unctionally complete, i.e., googletest > > > So I tried writing a C++ program that uses atf-c instead. But the > > Makefiles in share/mk make that a frustrating proposition. They don't > > want C++ programs to link to atf-c, and they don't want atf-c programs > > to be built in C++ mode. > > Well=E2=80=A6 yeah. This makes sense. > > > Googletest would probably work fine, but I would sorely miss ATF's > > test case isolation features. > > In what ways? Using plain tests builds in some level of isolation, but it= =E2=80=99s not perfect, and this is the direction I=E2=80=99m taking Google= test for a first iteration. Having $PWD be a disposable tmpdir is convenient, but I'm even more concerned about what happens if a googletest segfaults. In that case, its cleanup routines won't run. That could potentially be catastrophic for the entire test run if the test program does something like alter network configuration. Or do you have a plan for this? > > > So what should I do? Should I fix atf-c++? That would entail > > basically copying over everything from atf-c, which would be a lot of > > work. Or should I hack atf.test.mk to allow C++ programs to use > > atf-c? That would be ugly, but easier. Or should I just switch to > > Googletest, and live with its fragile cleanup handlers? > > Using Googletest with Googlemock is the way that I intend to have things = work. Adding ATF into the mix as another layer seems like the ultimate path= to pain, since ATF=E2=80=99s libraries require full stack management in or= der to do things like handle sandboxing, etc, and Googlemock does some clev= er things with C++ that seems like they would conflict with ATF=E2=80=99s g= oals. > > I=E2=80=99ll work on closing out the first iteration of googletest.test.m= k by the end of the week and work on getting the code committed to ^/head. = In parallel, I=E2=80=99ll focus on adding googletest driver support to kyua= (I have part of it done, but there are still some missing pieces around te= st listing and results parsing), which is the next required phase in order = to make googletest function more flexibly with kyua. Cool. Feel free to add me as a reviewer. > > Thanks, > -Enji > > PS I appreciate the reminder about documenting my work and my goals on th= e wiki. I=E2=80=99ll do that now. From owner-freebsd-testing@freebsd.org Wed Feb 27 20:53:50 2019 Return-Path: Delivered-To: freebsd-testing@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B8C931504F25 for ; Wed, 27 Feb 2019 20:53:49 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 898CC8F725; Wed, 27 Feb 2019 20:53:48 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pl1-x62e.google.com with SMTP id q3so8588610pll.4; Wed, 27 Feb 2019 12:53:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=ppuWvmlsoZ6FyBdGGtHKNeOV1hGnHyvLUPIPIaM44PA=; b=Sqszd7v7xvcs7IDyeelLDljrb9MASNI84CI1Z0YDPjHsAodgeuLcLkC3dhO+KlmlCs sc12z1D5r8QNkl8jyGahCq/G6lNx5Qh9ZJ6Y0NKtusoRsmEfe6Qv3DDrdMcVcaMthJIM u+boQkc+hxvsoiEPrSMsbAtEsSDoRxsc/bG7k2A7HbWyTGkvXjZegkz9z+P5uq3cy2aB N6F9m8nBfpL7Ua5B+gO5GwQeGhbRiC4AsBbncydGJzAXpQBxLd9vahBU8V+3M6pfplEA 4KbZhWEFLCVmgS3vJGj85ai9z1834bex1fbqgzbQkOpNeYCyVLdZkw6LLc4itDFm2TG6 0GGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=ppuWvmlsoZ6FyBdGGtHKNeOV1hGnHyvLUPIPIaM44PA=; b=DsHYjJsORFPzFd6b2lGc+b70q2FjqfXTU0HqvEJwyHZoxHY1DYlezb+9GNc2MX4tQR vLQ0FT0X3w/Yepg3wwwX4IJbRyXTbXbNhaFvnWNvWQR+UpZzGI0EI0c3PlbeO0VFjRDA b4uYCBat+i7vPHZXFNTMb0N2BiypENGjFamNPxvJfUgveoUTkbxJQoZOpwJBVgwmVQNF O52/JUL9d7G04ANtR3G0b2yWZrYNwrAbQgGXvUyah4ZfnioY6KbXQKht87mWvcIrf6XT +rtmFxbDDp7daJ0ReQ7jNdn2xyNK/TDL9im+Or8ThZ0XVFgFSr3AK+jQPrSPAFM7xeOp V3Xg== X-Gm-Message-State: AHQUAuaE5xKuYt2ozNzdhiiL9ahgn2tLM31vOpZSJL+ntXI6ciAxJT9C IhcuX2t6H2eOr8K9n5VmjF3Nr2QS X-Google-Smtp-Source: AHgI3IYh434RbtBaom6yBwaeEdHzx5QToTBpq9ICS3K0x+T+Cde6RFz7DK//ctDoYOKOS1vwYHTVeQ== X-Received: by 2002:a17:902:6949:: with SMTP id k9mr4268666plt.188.1551300827339; Wed, 27 Feb 2019 12:53:47 -0800 (PST) Received: from [172.17.7.154] (163-64-212-66.spl.org. [66.212.64.163]) by smtp.gmail.com with ESMTPSA id l2sm24434243pgj.64.2019.02.27.12.53.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Feb 2019 12:53:46 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Subject: Re: atf-c++ vs GoogleTest vs share/mk From: Enji Cooper In-Reply-To: Date: Wed, 27 Feb 2019 12:53:45 -0800 Cc: "freebsd-testing@freebsd.org" , Ed Maste , Julio Merino , "Jonathan T. Looney" Content-Transfer-Encoding: quoted-printable Message-Id: References: To: Alan Somers X-Mailer: Apple Mail (2.3445.102.3) X-Rspamd-Queue-Id: 898CC8F725 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=Sqszd7v7; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of yaneurabeya@gmail.com designates 2607:f8b0:4864:20::62e as permitted sender) smtp.mailfrom=yaneurabeya@gmail.com X-Spamd-Result: default: False [-6.33 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_FROM(0.00)[gmail.com]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; MV_CASE(0.50)[]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; NEURAL_HAM_SHORT(-0.98)[-0.978,0]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; MID_RHS_MATCH_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; IP_SCORE(-2.84)[ip: (-9.43), ipnet: 2607:f8b0::/32(-2.69), asn: 15169(-2.02), country: US(-0.07)]; RCVD_IN_DNSWL_NONE(0.00)[e.2.6.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0] X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Feb 2019 20:53:50 -0000 > On Feb 27, 2019, at 12:42 PM, Alan Somers wrote: >=20 > On Wed, Feb 27, 2019 at 12:46 PM Enji Cooper = wrote: >>=20 >>=20 >>> On Feb 27, 2019, at 9:59 AM, Alan Somers = wrote: >>>=20 >>> So it turns out to be impossible to use GoogleMock with atf-c++. = The >>> problem is that atf-c++'s only way to report a test failure is >>> ATF_FAIL, which immediately terminates the program on failure. That >>> conflicts with the way that GoogleMock uses pthreads, which is to >>> report a failure while a pthread mutex is locked. atf-c++ has many >>> other shortcomings, too. It lacks the ATF_CHECK_* macros, and its >>> syntax is surprisingly inconsistent with atf-c=E2=80=99s. >>=20 >> Yes, I=E2=80=99ve brought that up before in the past. This is part of = the reason why I want to abandon/kill off atf-c++ in favor of something = more functionally complete, i.e., googletest >>=20 >>> So I tried writing a C++ program that uses atf-c instead. But the >>> Makefiles in share/mk make that a frustrating proposition. They = don't >>> want C++ programs to link to atf-c, and they don't want atf-c = programs >>> to be built in C++ mode. >>=20 >> Well=E2=80=A6 yeah. This makes sense. >>=20 >>> Googletest would probably work fine, but I would sorely miss ATF's >>> test case isolation features. >>=20 >> In what ways? Using plain tests builds in some level of isolation, = but it=E2=80=99s not perfect, and this is the direction I=E2=80=99m = taking Googletest for a first iteration. >=20 > Having $PWD be a disposable tmpdir is convenient, This is already handled via kyua, just like it is with plain tests (and = ATF and TAP tests for that matter). > but I'm even more concerned about what happens if a googletest = segfaults. In that case, > its cleanup routines won't run. That could potentially be > catastrophic for the entire test run if the test program does > something like alter network configuration. Or do you have a plan for > this? I will look into how Googletest currently handles segfaults, etc, and = raise that as a point of concern with the upstream project if need be, = as I don=E2=80=99t know how exactly this is handled in exceptional = cases. Cheers, -Enji= From owner-freebsd-testing@freebsd.org Thu Feb 28 18:05:20 2019 Return-Path: Delivered-To: freebsd-testing@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D9B0F1511487 for ; Thu, 28 Feb 2019 18:05:19 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B555277555; Thu, 28 Feb 2019 18:05:18 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf1-x431.google.com with SMTP id d25so10084158pfn.8; Thu, 28 Feb 2019 10:05:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=c7i/IolAijj4Hfae4XiWX/x0fN0NvT1OsSKbBv0R4e0=; b=JxXrbNMMD3EIPfySymJQHynTuMBkInVGgdCaopztuusiyMh/O1B5UqaUxghvkBkdoB Yoo1MvNdAAe2o7Gf/5e4HDYiFAOoyreYGwpmNNQEsVUIkXX2ho8k/4ED4KLWMcAMlVM3 WLNFKZlIqZkwuiVbkWxrNF1O6MumR+t96bGnRsAY65jbP4k+ui5lI3zCsOlA0hRJO8cV jSCGLA6jtelHGuRQxhUzyVsCspAJDzlIfBwqLbjFOth8YsDdijeXxTTIHJYWNl2FGOFn XjlqyhvQR01mafoC9HBwM/VYo9fCNQDyFEv/+g3nneIdjUl8BE5Ok1DPqPuqKCHiVZ12 qkeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=c7i/IolAijj4Hfae4XiWX/x0fN0NvT1OsSKbBv0R4e0=; b=E9ud8AuGyXMepsMDfc47J7EOJv/GRldfRl6+irPXCGKZZl398/PnQKwglQlD4OsssH L7z9DZtfzSs/0F2KII/Hi6MycDmP/bSZkhdAQSPPC3I1ppT1y7AnFRF7O7PXX3jepJ/s nESFTRzBRvNvYIFgj9yf2/KhsV45JSEsS8aakbWpiIf9XhGN7m9NeNGh2OESvZsyMCXm jpp5GnX77Zh21X9maUjO4Uj4Tq+/mX+CTmw0iFafk11agANamSbejMko/uUuGP2pihNX wCKu58StWt+Llqak+5QnAyJOIrFL7bzG4UQ8mTGJo5HR12By/6KNJqtlf8GnhLf3u9Hm V2Lg== X-Gm-Message-State: APjAAAU+Y7HZ9nKK3jAlWmrdSRf4UzWhHorJg6xXMV1WHhglQGfxATL1 ha8Y2fkV81koXILdFBM58nabN/56 X-Google-Smtp-Source: APXvYqygcZ38t5Je2PJjjZksSM5+l+qMXWbhU+C8/eBAo4I4veodmgh6EFUQxhsytsjH4tzz5OBskA== X-Received: by 2002:a65:63c8:: with SMTP id n8mr439610pgv.158.1551377117226; Thu, 28 Feb 2019 10:05:17 -0800 (PST) Received: from [192.168.20.21] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id p7sm7472207pfn.17.2019.02.28.10.05.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 Feb 2019 10:05:16 -0800 (PST) From: "Enji Cooper (yaneurabeya)" Message-Id: <39472FE6-1A00-4938-9629-4AB741E45004@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Subject: Re: atf-c++ vs GoogleTest vs share/mk Date: Thu, 28 Feb 2019 10:05:15 -0800 In-Reply-To: Cc: "freebsd-testing@freebsd.org" , Ed Maste , Julio Merino , "Jonathan T. Looney" To: Alan Somers References: X-Mailer: Apple Mail (2.3445.102.3) X-Rspamd-Queue-Id: B555277555 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=JxXrbNMM; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of yaneurabeya@gmail.com designates 2607:f8b0:4864:20::431 as permitted sender) smtp.mailfrom=yaneurabeya@gmail.com X-Spamd-Result: default: False [-6.11 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_FROM(0.00)[gmail.com]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; MV_CASE(0.50)[]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; NEURAL_HAM_SHORT(-0.78)[-0.783,0]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+,1:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; MID_RHS_MATCH_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; IP_SCORE(-2.81)[ip: (-9.27), ipnet: 2607:f8b0::/32(-2.71), asn: 15169(-2.03), country: US(-0.07)]; RCVD_IN_DNSWL_NONE(0.00)[1.3.4.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Feb 2019 18:05:20 -0000 > On Feb 27, 2019, at 12:53, Enji Cooper wrote: =E2=80=A6 > I will look into how Googletest currently handles segfaults, etc, and = raise that as a point of concern with the upstream project if need be, = as I don=E2=80=99t know how exactly this is handled in exceptional = cases. One thing to note as well (to potentially adjust expectations for = readers) is that Kyua handling ATF crashes and cleaning up requires a = deeper understanding of the ATF interface in Kyua. It=E2=80=99s a best = effort, e.g., if the program crashes while cleaning up, it can leave = orphan directories behind or not fully clean up the system (I=E2=80=99ve = seen this happen before and I have also triggered scenarios like this). = This is to be expected, but I just wanted to be explicit about the fact = that the interface does not aim for a perfect solution=E2=80=94it=E2=80=99= s a good enough one for general cases. This aligns with other test frameworks I=E2=80=99ve used in the past. Cheers, -Enji=