From owner-freebsd-transport@freebsd.org Tue Jul 30 03:13:27 2019 Return-Path: Delivered-To: freebsd-transport@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8BA23BF42F for ; Tue, 30 Jul 2019 03:13:27 +0000 (UTC) (envelope-from Richard.Scheffenegger@netapp.com) Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-eopbgr790071.outbound.protection.outlook.com [40.107.79.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "GlobalSign Organization Validation CA - SHA256 - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ACFF88D77 for ; Tue, 30 Jul 2019 03:13:24 +0000 (UTC) (envelope-from Richard.Scheffenegger@netapp.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KgvQqabk3ztsLs5W88rhrJ80VFYG0Gn44OGhsu0zR9B2txoaG5nscaWSl1nlw5KX0dqYas6MXyXZgqpjWiQGvlExZ75o6SH+oCws5oVunX84IjiilLnfHJq8Dd9HlA6U2p+rRHOd224d/7SN34OyWkLXadQvCKYO5IsAg9pXFAxZtexBizyHhGAyBGF0/iqxDJdhN+JTNLrZogtzISb2wb1n3d/+XyP9Q1JCDwQD0/tOcRWl/RrFFi+F7C3mZAlSp9zQGX/k/0yaKv0r4myReyezu7Vy67+L9yZ9YefaIkuFJz+BA2Jtz+l9xWelLh3J9VykaSHjz/AEqMP7b6OfZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RAR9xro+O5iCFJaPJeZhMrtLaYYwTeFYpM+SY4S/zI8=; b=BV+dHH1ZEy+TwlAsjQs7nU3I7pY1cLB4zcl+Fn/X4Zu7dY5kTrX42cHz6XrV7q95TD85VwDC7TiN5y8A1gfpkP4E0TaynPRlsRxT43XeKA1KxI3qndi08PU1GIhMvd92leDADQKaovjm7qH5Af4ZpvgSAIKf9h4NjbFzRh1hdpGXldoycLfX4uN0CKNN0Z5PJXKIWVVyz8zOB5qUrRKA9EzTO288CNbt4tiPW6kWmMvkFZxDw6cwRwv5JhgjbX9J5EN5Vme7uoyjJ1O7JJ0kaToZFKjuRoH6rWkn8TLc+E7aLWx1kRTYoY/Zzclcku2iGIlPCnMgGKuz6YSJn3BFOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=netapp.com;dmarc=pass action=none header.from=netapp.com;dkim=pass header.d=netapp.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netapp.onmicrosoft.com; s=selector2-netapp-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RAR9xro+O5iCFJaPJeZhMrtLaYYwTeFYpM+SY4S/zI8=; b=EzSyH8lgWBJHCWG8JWQ4SGU8Edkvw4frnqMtCUHrsN4AJvetarbX1Mx2+4JhWb611RvxVbikSit//TOePqVvY0C5CyYRIQpVpP9zWiIVD1/wTChBVF+7vUx1s+SHKpuCrkIiDCDXeFRyoc6stDPPjh6pWRVan7/Z8ctLBpdNdYA= Received: from SN4PR0601MB3728.namprd06.prod.outlook.com (10.167.151.152) by SN4PR0601MB3613.namprd06.prod.outlook.com (10.167.150.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2115.15; Tue, 30 Jul 2019 03:13:22 +0000 Received: from SN4PR0601MB3728.namprd06.prod.outlook.com ([fe80::4dd2:be1d:4e16:c75e]) by SN4PR0601MB3728.namprd06.prod.outlook.com ([fe80::4dd2:be1d:4e16:c75e%6]) with mapi id 15.20.2115.005; Tue, 30 Jul 2019 03:13:22 +0000 From: "Scheffenegger, Richard" To: "freebsd-transport@freebsd.org" Subject: tcpcb cleanup? Thread-Topic: tcpcb cleanup? Thread-Index: AdVGgaScnkxGHtT0QAqU2QFN+3Fo5Q== Date: Tue, 30 Jul 2019 03:13:22 +0000 Message-ID: Accept-Language: de-AT, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-dg-ref: PG1ldGE+PGF0IG5tPSJib2R5LnR4dCIgcD0iYzpcdXNlcnNcc3JpY2hhcmRcYXBwZGF0YVxyb2FtaW5nXDA5ZDg0OWI2LTMyZDMtNGE0MC04NWVlLTZiODRiYTI5ZTM1Ylxtc2dzXG1zZy1mOWI3ZmEwYS1iMjc3LTExZTktYjYwMC0wMDE5ZDJlNGVjZDdcYW1lLXRlc3RcZjliN2ZhMGItYjI3Ny0xMWU5LWI2MDAtMDAxOWQyZTRlY2Q3Ym9keS50eHQiIHN6PSIxMzU1IiB0PSIxMzIwODkyOTk5ODI4NzQyNDEiIGg9IlNUc2NkSWlLQ2ZnRXN4UmM5ZmVYTkZoWXRlVT0iIGlkPSIiIGJsPSIwIiBibz0iMSIvPjwvbWV0YT4= x-dg-rorf: x-originating-ip: [24.142.218.243] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fb8f7f9d-2e3a-45de-f77e-08d7149be139 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:SN4PR0601MB3613; x-ms-traffictypediagnostic: SN4PR0601MB3613: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 0114FF88F6 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(136003)(346002)(376002)(366004)(39860400002)(396003)(199004)(189003)(102836004)(2351001)(6506007)(81156014)(8676002)(52536014)(64756008)(81166006)(5660300002)(186003)(26005)(66946007)(66476007)(8936002)(25786009)(7696005)(68736007)(66556008)(7736002)(76116006)(99286004)(3480700005)(6436002)(6116002)(9686003)(74316002)(66446008)(6916009)(256004)(14454004)(305945005)(478600001)(66066001)(55016002)(33656002)(316002)(7116003)(476003)(486006)(2906002)(5640700003)(86362001)(53936002)(2501003)(71190400001)(3846002)(71200400001); DIR:OUT; SFP:1101; SCL:1; SRVR:SN4PR0601MB3613; H:SN4PR0601MB3728.namprd06.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: netapp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: N7UvJIsfVKSemyY2KhdtrXpNO02/7wFJWnBxY0xZ9tNXHX4hMYLiwV6rynuNysmxSkJDVUaVSzqkvPCAtJlUVrD5MPfQTpRXPR60FNsPfXKWw53NLSNK6R+BPe3oLy67iVlBNAcZAXbWlwIz6NVTjpBmF1IwUvSr1sLXVk9+l73ZzZGXhPt3S0vy61ZU0B2SuU2Qy62BYTnt1NEC6Wg2xV1DzUxknlfePUBGMx9BaWWhGR1NU0WpKTAggTA7nXgDE8kM6p0BaeoIsy7QY1MBxao0HC8GxsdOyO1LsLfhzA+VOZUIUNtaXheKQHIihoihsd2t5eprdvJB7MmWD837TU/BzOs322y8o7RNo/Te4CXctlUwQrEaJPeu3vvZSH+dvldIKfZ2KonaAG+II+Ucm5abzWAJog0pfz+QtuRI1Gs= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: netapp.com X-MS-Exchange-CrossTenant-Network-Message-Id: fb8f7f9d-2e3a-45de-f77e-08d7149be139 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jul 2019 03:13:22.5374 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4b0911a0-929b-4715-944b-c03745165b3a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: srichard@netapp.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR0601MB3613 X-Rspamd-Queue-Id: 4ACFF88D77 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=netapp.onmicrosoft.com header.s=selector2-netapp-onmicrosoft-com header.b=EzSyH8lg; spf=pass (mx1.freebsd.org: domain of Richard.Scheffenegger@netapp.com designates 40.107.79.71 as permitted sender) smtp.mailfrom=Richard.Scheffenegger@netapp.com X-Spamd-Result: default: False [-4.10 / 15.00]; RCVD_TLS_LAST(0.00)[]; NEURAL_HAM_MEDIUM(-0.99)[-0.992,0]; R_DKIM_ALLOW(-0.20)[netapp.onmicrosoft.com:s=selector2-netapp-onmicrosoft-com]; HAS_XOIP(0.00)[]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:40.107.0.0/16]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[netapp.com]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCPT_COUNT_ONE(0.00)[1]; RCVD_COUNT_THREE(0.00)[3]; IP_SCORE(-1.08)[ipnet: 40.64.0.0/10(-3.12), asn: 8075(-2.24), country: US(-0.05)]; MX_GOOD(-0.01)[cached: mx1.netapp.iphmx.com]; DKIM_TRACE(0.00)[netapp.onmicrosoft.com:+]; RCVD_IN_DNSWL_NONE(0.00)[71.79.107.40.list.dnswl.org : 127.0.3.0]; NEURAL_HAM_SHORT(-0.62)[-0.618,0]; TO_DN_EQ_ADDR_ALL(0.00)[]; MIME_BASE64_TEXT(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; SUBJECT_ENDS_QUESTION(1.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:8075, ipnet:40.64.0.0/10, country:US]; ARC_ALLOW(-1.00)[i=1] X-BeenThere: freebsd-transport@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions of transport level network protocols in FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Jul 2019 03:13:27 -0000 SGksDQoNCkkndmUgYmVlbiBsb29raW5nIGludG8gdGhlIGNhY2hlIGxpbmUgYWxpZ25tZW50IHRv ZGF5IChiZWNhdXNlIEQxODgxMSkuDQoNCkZvdW5kIHRoYXQgdGhlIGNvbW1lbnRlZCBjYWNoZSBs aW5lcyBvbmx5IGFsaWduIHRvIGxpbmUgMyAtIHRoZW4gdGhleSBkcmlmdCBmcm9tIHRoZSBjb21t ZW50cy4NCg0KRm9yIGV4YW1wbGUsIHRfcnR0dXBkYXRlZCBpcyBkZWZpbmVkIGFzIHVfbG9uZyAo OCBieXRlcyksIHdoaWxlIGl0IHJlYWxseSBvbmx5IHRyYWNrcyBpZiBhdCBsZWFzdCBzb21lIChz bWFsbCkgbnVtYmVyIG9mIHJ0dCBzYW1wbGVzIHdlcmUgY29sbGVjdGVkLCB0byBzdGFydCB0aGUg IHVzZSBvZiB0aGUgcnR0IHZhcnMuLi4NCg0KUmVhbGlzdGljYWxseSwgYSB1aW50OF90IHdpdGgg YSBsaW1pdGVkIGluY3JlbWVudCAoaWYgKHg8MjU1KSB4KyspIHdvdWxkIHNlcnZlIHRoZSB2ZXJ5 IHNhbWUgZnVuY3Rpb24uLi4NCg0KT3RoZXIgZXhhbXBsZTogdF9zbmR6ZXJvd2luIChpbiB0Y3Bj YikgYXBwZWFycyB0byBiZSBvbmx5IGEgY291bnRlciwgYmV0dGVyIHBsYWNlZCBpbnRvIHRoZSB0 Y3BzdGF0IHN0cnVjdHVyZSwgd2hlcmUgbm9uLWZ1bmN0aW9uYWwgY291bnRlcnMgYmVsb25nIElN SE8uIChwZXJoYXBzIGEgcGVyLXNlc3Npb24gdmFyaWFudCkuDQoNCg0KDQoNCkFuZCB0aGUgb3Ro ZXIgdmFyaWFibGVzIGNvdWxkIHByb2JhYmx5IGJlIGRlZmluZWQgaW4gdGhlIGV4cGxpY2l0IHR5 cGVzICh1aW50MTYvMzIvNjQpLCB0byBiZSBtb3JlIGNlcnRhaW4gb2YgdGhlIGFsaWdubWVudCAt IHBsdXMgbWFraW5nIHN1cmUgdGhhdCBhbGlnbm1lbnQgYm91bmRhcmllcyBiZXR3ZWVuIGRpZmZl cmVudCBzaXplZCB0eXBlcyBkb24ndCByZXN1bHQgaW4gdW5pbnRlbnRpb25hbCBzaGlmdGluZyBv ZiB0aGUgYWxpZ25tZW50IChsaWtlIGl0IHNlZW1zIGN1cnJlbnRseSB0byBiZSB0aGUgY2FzZSku DQoNCkFub3RoZXIgcHJpbWUgZXhhbXBsZTogc3RydWN0IHNhY2toaW50IGlzIDQwIGJ5dGVzLCBv bmx5IDI0IG9mIHRoZXNlIGFyZSBhY3R1YWxseSB1c2VkOyBhbmQgaWRlYWxseSwgc2Fja2Jsa3Ms IHNuZF9mYWNrIHNoYXJlIHRoZSBzYW1lIGxpbmUsIHdoaWxlIHNhY2toaW50IGFuZCBzbmRfaG9s ZXMgd291bGQgZG8gdGhlIHNhbWUgKGN1cnJlbnRseSwgYm90aCBhcmUgZGlzdHJpYnV0ZWQgYWNy b3NzIDIpCS4uLi4NCg0KDQpBbnkgYXBwZXRpdGUgdG8gZ2V0IHRoZSAoaGlnaGVyKSBjYWNoZSBs aW5lcyBhbGlnbmVkIGluIHRjcGNiPw0KDQpCZXN0IHJlZ2FyZHMsDQogICBSaWNoYXJkDQoNCg0K From owner-freebsd-transport@freebsd.org Tue Jul 30 12:40:36 2019 Return-Path: Delivered-To: freebsd-transport@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 28906A23D1 for ; Tue, 30 Jul 2019 12:40:36 +0000 (UTC) (envelope-from rrs@netflix.com) Received: from mail-qk1-x72f.google.com (mail-qk1-x72f.google.com [IPv6:2607:f8b0:4864:20::72f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0E2BE97DC0 for ; Tue, 30 Jul 2019 12:40:35 +0000 (UTC) (envelope-from rrs@netflix.com) Received: by mail-qk1-x72f.google.com with SMTP id t8so46448180qkt.1 for ; Tue, 30 Jul 2019 05:40:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=3/5exdH/2R5NqbdVa0vrbV6ARJrzCjySce1vR3ffFn8=; b=m218VgB+1OQtSRKns8sycpg+UqA1QKSNTF46MKE2bM0icS7n9jZH21MLpiJl3+Umf3 EDrP9rmg87iRchtBFbs+vyLiLWHw0VOHkrZWFyDZ7nKHx4/+ys/dY3KllbkFd7+vpE4h KENAV547sgL5MzlbU82S/u1XUg/8bekdjfhbRDDH28XOXh+rwAmENDP/Yj4YYS8Osrai 0LmwvuV8g9KDmhzt8I8JzFUCHnH1prYfwHpv8KfvKMfDtFNRQZ/yTi91C4jUx9T5TmVh AIGnSARPNa2IwEFN/0wnfFEMpfDFPJyMTKLJwOxmlG9hh/NiN0rDmSe/u0cDqeu/Ir7k A6Pw== X-Gm-Message-State: APjAAAWJSAf9jElvUUYmE06L75hWpcOfzB3TmWIPpDWclxg5zYFuHdJm dOKUT04ntrnna0/EzaKyNT1yCzubDQM= X-Google-Smtp-Source: APXvYqz+chfqGkc99OpN+Bt+elwUDXF5QjN2r8D3mbGiYoIM8Yy2/faf8p9CiSVQ/rJXoGkkT1RZRA== X-Received: by 2002:a37:bac2:: with SMTP id k185mr75330476qkf.211.1564490433949; Tue, 30 Jul 2019 05:40:33 -0700 (PDT) Received: from ?IPv6:2607:fb10:7061:7fd::2a68? ([2607:fb10:7061:7fd::2a68]) by smtp.gmail.com with ESMTPSA id r36sm34675314qte.71.2019.07.30.05.40.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 30 Jul 2019 05:40:33 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: tcpcb cleanup? From: Randall Stewart In-Reply-To: Date: Tue, 30 Jul 2019 08:40:32 -0400 Cc: "freebsd-transport@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: To: "Scheffenegger, Richard" X-Mailer: Apple Mail (2.3445.9.1) X-Rspamd-Queue-Id: 0E2BE97DC0 X-Spamd-Bar: --------------- X-Spamd-Result: default: False [-15.48 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; MV_CASE(0.50)[]; RCVD_COUNT_THREE(0.00)[3]; MX_GOOD(-0.01)[cached: alt1.aspmx.l.google.com]; DKIM_TRACE(0.00)[netflix.com:+]; RCPT_COUNT_TWO(0.00)[2]; NEURAL_HAM_SHORT(-0.95)[-0.949,0]; DMARC_POLICY_ALLOW(-0.50)[netflix.com,reject]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; SUBJECT_ENDS_QUESTION(1.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[netflix.com:s=google]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-transport@freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; WHITELIST_DMARC(-7.00)[netflix.com:D:+]; RCVD_IN_DNSWL_NONE(0.00)[f.2.7.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; IP_SCORE(-3.02)[ip: (-9.51), ipnet: 2607:f8b0::/32(-3.09), asn: 15169(-2.45), country: US(-0.05)]; WHITELIST_SPF_DKIM(-3.00)[netflix.com:d:+,netflix.com:s:+] X-BeenThere: freebsd-transport@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions of transport level network protocols in FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Jul 2019 12:40:36 -0000 Yes As I said in comments to your removal of the sack field, they have drifted since my first work. I am not too concerned since the first 3 cache lines are the most used = and most important. I do intend to do a re-analysis once I get BBR and the latest Rack in to = see if we could improve things.. though it is doubtful that we will gain much = (but you never know) ;) R > On Jul 29, 2019, at 11:13 PM, Scheffenegger, Richard = wrote: >=20 > Hi, >=20 > I've been looking into the cache line alignment today (because = D18811). >=20 > Found that the commented cache lines only align to line 3 - then they = drift from the comments. >=20 > For example, t_rttupdated is defined as u_long (8 bytes), while it = really only tracks if at least some (small) number of rtt samples were = collected, to start the use of the rtt vars... >=20 > Realistically, a uint8_t with a limited increment (if (x<255) x++) = would serve the very same function... >=20 > Other example: t_sndzerowin (in tcpcb) appears to be only a counter, = better placed into the tcpstat structure, where non-functional counters = belong IMHO. (perhaps a per-session variant). >=20 >=20 >=20 >=20 > And the other variables could probably be defined in the explicit = types (uint16/32/64), to be more certain of the alignment - plus making = sure that alignment boundaries between different sized types don't = result in unintentional shifting of the alignment (like it seems = currently to be the case). >=20 > Another prime example: struct sackhint is 40 bytes, only 24 of these = are actually used; and ideally, sackblks, snd_fack share the same line, = while sackhint and snd_holes would do the same (currently, both are = distributed across 2) .... >=20 >=20 > Any appetite to get the (higher) cache lines aligned in tcpcb? >=20 > Best regards, > Richard >=20 >=20 > _______________________________________________ > freebsd-transport@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-transport > To unsubscribe, send any mail to = "freebsd-transport-unsubscribe@freebsd.org" ------ Randall Stewart rrs@netflix.com From owner-freebsd-transport@freebsd.org Tue Jul 30 18:45:32 2019 Return-Path: Delivered-To: freebsd-transport@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id EF6FBAA277 for ; Tue, 30 Jul 2019 18:45:32 +0000 (UTC) (envelope-from Richard.Scheffenegger@netapp.com) Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-eopbgr790070.outbound.protection.outlook.com [40.107.79.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "GlobalSign Organization Validation CA - SHA256 - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DACA36CA45 for ; Tue, 30 Jul 2019 18:45:30 +0000 (UTC) (envelope-from Richard.Scheffenegger@netapp.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Sby8JdX/sJ1swb72lQRPKkHv0ZUTW2EgE3IqVWc2VrKz6VhrLyRyy6WnyoDBszEwK7G9b3J7DkrPW32ywHz9/6qxGw03FAr2YxfDQBOiNIuGjML9z3kfg35wWi5+F441SQHtk/hnGk5iWvi1As8s+aWHIn/IH+zdrFbTdNEO4o20gFu7IzslNI8S2UU2hugbhP23iGK2vriFoc9CCWZHqTD2aI5bstgwWVvkwZOFgaPTMNQH+Y7EScmqeEAeixcSliLM17uZepXyjHThx3xdkicl35OXJ8sPCBaGryR3SbFiSYYKmAWmutcQRIcOdISBUxogl1x4yMg90ZcZHrnkmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9toDqN5Eq6oRKPSKPj4nazc2ggtiSU5HL928AZFme+M=; b=MMYlAoqQ6ZITaOKaSpPoYOEmlbyysePlPyrJ2HiBUF/+gkNbLqcFq3Hh2pJywyMyVhg2Yk097UxkEx/urL6neIwswLcNuyXQ+sj+LFsieEWOXEQc4WH0Q57b7c7C8VXoYnvvEmI29+geF5gJeC+UuDU1sOrHtMqFBsrZCRtoohCJLOXyAVfJSmJ7U4netUH9gUbe/MTtAf7Z3P4HrxVewrAvgFgBsOWQZDBDvBeFxDl0MabMzBsUVPC+KXgwZjf4Yge/X+SVieo+qpkoacUV/xYWHE28bN5bJ05T8E5PYCSlvVBRCOaECX6nfL4PdL5CK1otCC262zzTSV+ZKZH3jQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=netapp.com;dmarc=pass action=none header.from=netapp.com;dkim=pass header.d=netapp.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netapp.onmicrosoft.com; s=selector2-netapp-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9toDqN5Eq6oRKPSKPj4nazc2ggtiSU5HL928AZFme+M=; b=tMCme+IzFL7Fsv/3+ihNmSw6X5G+bNtRWIr4QYC0PFkwjchciWUzX9tQOCuZzXhfj0xWN1+1e2gBADdQ8U3gEg53nEA79zm081sQwJiBLlnYucLVIY698fvxjVzKZQ5XyTAscakil76+TT2ffaAQM0Q5bmyGD4L24Wj5DOhPqEs= Received: from SN4PR0601MB3728.namprd06.prod.outlook.com (10.167.151.152) by SN4PR0601MB3741.namprd06.prod.outlook.com (10.167.129.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2115.14; Tue, 30 Jul 2019 18:45:28 +0000 Received: from SN4PR0601MB3728.namprd06.prod.outlook.com ([fe80::4dd2:be1d:4e16:c75e]) by SN4PR0601MB3728.namprd06.prod.outlook.com ([fe80::4dd2:be1d:4e16:c75e%6]) with mapi id 15.20.2115.005; Tue, 30 Jul 2019 18:45:28 +0000 From: "Scheffenegger, Richard" To: Randall Stewart CC: "freebsd-transport@freebsd.org" Subject: RE: tcpcb cleanup? Thread-Topic: tcpcb cleanup? Thread-Index: AdVGgaScnkxGHtT0QAqU2QFN+3Fo5QAUlUsAAAyVKqA= Date: Tue, 30 Jul 2019 18:45:27 +0000 Message-ID: References: In-Reply-To: Accept-Language: de-AT, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-dg-ref: PG1ldGE+PGF0IG5tPSJib2R5LnR4dCIgcD0iYzpcdXNlcnNcc3JpY2hhcmRcYXBwZGF0YVxyb2FtaW5nXDA5ZDg0OWI2LTMyZDMtNGE0MC04NWVlLTZiODRiYTI5ZTM1Ylxtc2dzXG1zZy0zMGNkZjkyMy1iMmZhLTExZTktYjYwMC0wMDE5ZDJlNGVjZDdcYW1lLXRlc3RcMzBjZGY5MjQtYjJmYS0xMWU5LWI2MDAtMDAxOWQyZTRlY2Q3Ym9keS50eHQiIHN6PSIzMjMyIiB0PSIxMzIwODk4NTkyNTI5NjY4MTEiIGg9InR5cytWU0FJNUp4QzZibURCUi9zYys1a3IxMD0iIGlkPSIiIGJsPSIwIiBibz0iMSIvPjwvbWV0YT4= x-dg-rorf: x-originating-ip: [216.240.30.5] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 49faefb6-8ab8-4331-2673-08d7151e1754 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:SN4PR0601MB3741; x-ms-traffictypediagnostic: SN4PR0601MB3741: x-ms-exchange-purlcount: 1 x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0114FF88F6 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(376002)(136003)(346002)(396003)(39860400002)(366004)(199004)(189003)(13464003)(2906002)(6116002)(3846002)(6246003)(7736002)(53936002)(186003)(7116003)(476003)(478600001)(305945005)(68736007)(446003)(486006)(4326008)(6506007)(81166006)(316002)(53546011)(66066001)(81156014)(26005)(102836004)(76176011)(25786009)(966005)(256004)(6916009)(5024004)(11346002)(14454004)(6306002)(55016002)(14444005)(8676002)(74316002)(7696005)(86362001)(229853002)(33656002)(64756008)(66556008)(71190400001)(9686003)(66446008)(66476007)(99286004)(76116006)(5660300002)(6436002)(8936002)(71200400001)(52536014)(66946007)(3480700005); DIR:OUT; SFP:1101; SCL:1; SRVR:SN4PR0601MB3741; H:SN4PR0601MB3728.namprd06.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: netapp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: j3mG6AO3oUXhmVHiqzIa+tVdvb3j2WwKIULxLFCEY+iizx58SN9pAj7/uxG4nWUGMkCaBTKl9yPZyEgQM/BDdyXG1Y8GGG3HSY+RT2WXKVHZBhUyWMGXaV/pHFcm+YbiFH/OshxxnJ3UKW9sMdBPx0DiOzcCBNScdKI+kMY4H87Rx8Xm27qI6Dfis6XXLeBfdibJW2Y10PsuYUiSnbEH1uM/hKxAjiI3LLfYvwzEIOLQAu1aVklDjmoy7rVcDI5Gb9tJrNw6gHtZcSI7i22hdZxoWjG3F4SVoiH/s+Utm4Qp56wjUZIDLgYWIAIj15sJOxuk1SBTrPSqA3Dc7AikaVVYS9rHLvwD1lXfqRqVF03Le9gHa2ejaHbjE2VG5k8aj34+l75L6XfLklhcrR2q/Sh8DOhuMbS17mL+ZmP4ejA= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: netapp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 49faefb6-8ab8-4331-2673-08d7151e1754 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jul 2019 18:45:27.8808 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4b0911a0-929b-4715-944b-c03745165b3a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: srichard@netapp.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR0601MB3741 X-Rspamd-Queue-Id: DACA36CA45 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=netapp.onmicrosoft.com header.s=selector2-netapp-onmicrosoft-com header.b=tMCme+Iz; spf=pass (mx1.freebsd.org: domain of Richard.Scheffenegger@netapp.com designates 40.107.79.70 as permitted sender) smtp.mailfrom=Richard.Scheffenegger@netapp.com X-Spamd-Result: default: False [-4.45 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[netapp.onmicrosoft.com:s=selector2-netapp-onmicrosoft-com]; HAS_XOIP(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:40.107.0.0/16]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[netapp.com]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[netapp.onmicrosoft.com:+]; MX_GOOD(-0.01)[mx1.netapp.iphmx.com,mx2.netapp.iphmx.com,mx1.netapp.iphmx.com,mx2.netapp.iphmx.com,mx1.netapp.iphmx.com,mx2.netapp.iphmx.com,mx1.netapp.iphmx.com,mx2.netapp.iphmx.com,mx1.netapp.iphmx.com,mx2.netapp.iphmx.com,mx1.netapp.iphmx.com,mx2.netapp.iphmx.com,mx1.netapp.iphmx.com,mx2.netapp.iphmx.com]; RCVD_IN_DNSWL_NONE(0.00)[70.79.107.40.list.dnswl.org : 127.0.3.0]; NEURAL_HAM_SHORT(-0.95)[-0.952,0]; RCPT_COUNT_TWO(0.00)[2]; IP_SCORE(-1.08)[ipnet: 40.64.0.0/10(-3.13), asn: 8075(-2.24), country: US(-0.05)]; MIME_BASE64_TEXT(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; SUBJECT_ENDS_QUESTION(1.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:8075, ipnet:40.64.0.0/10, country:US]; ARC_ALLOW(-1.00)[i=1] X-BeenThere: freebsd-transport@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions of transport level network protocols in FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Jul 2019 18:45:33 -0000 SSBiZWxpZXZlIHRoZSBhbGlnbm1lbnQgb2Ygc29tZSBwb2ludGVycyBpcyBhbHNvIG9mZiwgZnVy dGhlciBzaGlmdGluZyB0aGUgZGF0YS4uLg0KDQpJIHN0YXJ0ZWQgc29tZSB3b3JrIGluIEQyMTEx NyBhcm91bmQgdGhpcyAtIHJlZHVjaW5nIHRoZSBzaXplIG9mIHRoaXMgdF9ydHR1cGRhdGVkIGlu IHRjcGNiIGRvd24gZnJvbSB1bG9uZyB0byB1aW50OF90LCBhcyBpdCByZWFsbHkgb25seSBuZWVk cyB0byB0cmFjayB0aGUgaW5pdGlhbCBmZXcgcm91bmRzLCBhbmQgdGhlbiBzdGF5IGZpeGVkIGF0 IHRoZSBVQ0hBUl9NQVguDQoNCkFsc28sIEkgbWFkZSBvdGhlciB0eXBlcywgcGFydGljdWxhcmx5 IHB1cmUgY291bnRlcnMsIHVpbnQzMl90IChmcm9tIGludCksIGdpdmluZyB0aGVtIG1vcmUgcmFu Z2UuDQoNCkl0IHNlZW1zIHRoYXQgc29tZSB2YXJpYWJsZXMsIHRoYXQgYXJlIG9ubHkgKGN1cnJl bnRseSkgdXNlZCBpbiB0aGUgTkYgUkFDSyBzdGFjaywgaGF2ZSAibGVha2VkIiBvdXQgYWxyZWFk eSDwn5iKICh0X21heHVuYWNrdGltZSBpcyByZWZlcmVuY2VkIHRvLCBidXQgYXBwYXJlbnRseSBu ZXZlciBzZXQsIGluIHRoZSB1cHN0cmVhbWVkIFJBQ0sgc3RhY2spLg0KDQpCZXN0IHJlZ2FyZHMs DQoNCg0KUmljaGFyZCBTY2hlZmZlbmVnZ2VyDQoNCi0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0t DQpGcm9tOiBSYW5kYWxsIFN0ZXdhcnQgPHJyc0BuZXRmbGl4LmNvbT4gDQpTZW50OiBEaWVuc3Rh ZywgMzAuIEp1bGkgMjAxOSAwODo0MQ0KVG86IFNjaGVmZmVuZWdnZXIsIFJpY2hhcmQgPFJpY2hh cmQuU2NoZWZmZW5lZ2dlckBuZXRhcHAuY29tPg0KQ2M6IGZyZWVic2QtdHJhbnNwb3J0QGZyZWVi c2Qub3JnDQpTdWJqZWN0OiBSZTogdGNwY2IgY2xlYW51cD8NCg0KTmV0QXBwIFNlY3VyaXR5IFdB Uk5JTkc6IFRoaXMgaXMgYW4gZXh0ZXJuYWwgZW1haWwuIERvIG5vdCBjbGljayBsaW5rcyBvciBv cGVuIGF0dGFjaG1lbnRzIHVubGVzcyB5b3UgcmVjb2duaXplIHRoZSBzZW5kZXIgYW5kIGtub3cg dGhlIGNvbnRlbnQgaXMgc2FmZS4NCg0KDQoNCg0KWWVzDQoNCkFzIEkgc2FpZCBpbiBjb21tZW50 cyB0byB5b3VyIHJlbW92YWwgb2YgdGhlIHNhY2sgZmllbGQsIHRoZXkgaGF2ZSBkcmlmdGVkIHNp bmNlIG15IGZpcnN0IHdvcmsuDQoNCkkgYW0gbm90IHRvbyBjb25jZXJuZWQgc2luY2UgdGhlIGZp cnN0IDMgY2FjaGUgbGluZXMgYXJlIHRoZSBtb3N0IHVzZWQgYW5kIG1vc3QgaW1wb3J0YW50Lg0K DQpJIGRvIGludGVuZCB0byBkbyBhIHJlLWFuYWx5c2lzIG9uY2UgSSBnZXQgQkJSIGFuZCB0aGUg bGF0ZXN0IFJhY2sgaW4gdG8gc2VlIGlmIHdlIGNvdWxkIGltcHJvdmUgdGhpbmdzLi4gdGhvdWdo IGl0IGlzIGRvdWJ0ZnVsIHRoYXQgd2Ugd2lsbCBnYWluIG11Y2ggKGJ1dCB5b3UgbmV2ZXIga25v dykgOykNCg0KUg0KDQo+IE9uIEp1bCAyOSwgMjAxOSwgYXQgMTE6MTMgUE0sIFNjaGVmZmVuZWdn ZXIsIFJpY2hhcmQgPFJpY2hhcmQuU2NoZWZmZW5lZ2dlckBuZXRhcHAuY29tPiB3cm90ZToNCj4N Cj4gSGksDQo+DQo+IEkndmUgYmVlbiBsb29raW5nIGludG8gdGhlIGNhY2hlIGxpbmUgYWxpZ25t ZW50IHRvZGF5IChiZWNhdXNlIEQxODgxMSkuDQo+DQo+IEZvdW5kIHRoYXQgdGhlIGNvbW1lbnRl ZCBjYWNoZSBsaW5lcyBvbmx5IGFsaWduIHRvIGxpbmUgMyAtIHRoZW4gdGhleSBkcmlmdCBmcm9t IHRoZSBjb21tZW50cy4NCj4NCj4gRm9yIGV4YW1wbGUsIHRfcnR0dXBkYXRlZCBpcyBkZWZpbmVk IGFzIHVfbG9uZyAoOCBieXRlcyksIHdoaWxlIGl0IHJlYWxseSBvbmx5IHRyYWNrcyBpZiBhdCBs ZWFzdCBzb21lIChzbWFsbCkgbnVtYmVyIG9mIHJ0dCBzYW1wbGVzIHdlcmUgY29sbGVjdGVkLCB0 byBzdGFydCB0aGUgIHVzZSBvZiB0aGUgcnR0IHZhcnMuLi4NCj4NCj4gUmVhbGlzdGljYWxseSwg YSB1aW50OF90IHdpdGggYSBsaW1pdGVkIGluY3JlbWVudCAoaWYgKHg8MjU1KSB4KyspIHdvdWxk IHNlcnZlIHRoZSB2ZXJ5IHNhbWUgZnVuY3Rpb24uLi4NCj4NCj4gT3RoZXIgZXhhbXBsZTogdF9z bmR6ZXJvd2luIChpbiB0Y3BjYikgYXBwZWFycyB0byBiZSBvbmx5IGEgY291bnRlciwgYmV0dGVy IHBsYWNlZCBpbnRvIHRoZSB0Y3BzdGF0IHN0cnVjdHVyZSwgd2hlcmUgbm9uLWZ1bmN0aW9uYWwg Y291bnRlcnMgYmVsb25nIElNSE8uIChwZXJoYXBzIGEgcGVyLXNlc3Npb24gdmFyaWFudCkuDQo+ DQo+DQo+DQo+DQo+IEFuZCB0aGUgb3RoZXIgdmFyaWFibGVzIGNvdWxkIHByb2JhYmx5IGJlIGRl ZmluZWQgaW4gdGhlIGV4cGxpY2l0IHR5cGVzICh1aW50MTYvMzIvNjQpLCB0byBiZSBtb3JlIGNl cnRhaW4gb2YgdGhlIGFsaWdubWVudCAtIHBsdXMgbWFraW5nIHN1cmUgdGhhdCBhbGlnbm1lbnQg Ym91bmRhcmllcyBiZXR3ZWVuIGRpZmZlcmVudCBzaXplZCB0eXBlcyBkb24ndCByZXN1bHQgaW4g dW5pbnRlbnRpb25hbCBzaGlmdGluZyBvZiB0aGUgYWxpZ25tZW50IChsaWtlIGl0IHNlZW1zIGN1 cnJlbnRseSB0byBiZSB0aGUgY2FzZSkuDQo+DQo+IEFub3RoZXIgcHJpbWUgZXhhbXBsZTogc3Ry dWN0IHNhY2toaW50IGlzIDQwIGJ5dGVzLCBvbmx5IDI0IG9mIHRoZXNlIGFyZSBhY3R1YWxseSB1 c2VkOyBhbmQgaWRlYWxseSwgc2Fja2Jsa3MsIHNuZF9mYWNrIHNoYXJlIHRoZSBzYW1lIGxpbmUs IHdoaWxlIHNhY2toaW50IGFuZCBzbmRfaG9sZXMgd291bGQgZG8gdGhlIHNhbWUgKGN1cnJlbnRs eSwgYm90aCBhcmUgZGlzdHJpYnV0ZWQgYWNyb3NzIDIpICAgICAgICAuLi4uDQo+DQo+DQo+IEFu eSBhcHBldGl0ZSB0byBnZXQgdGhlIChoaWdoZXIpIGNhY2hlIGxpbmVzIGFsaWduZWQgaW4gdGNw Y2I/DQo+DQo+IEJlc3QgcmVnYXJkcywNCj4gICBSaWNoYXJkDQo+DQo+DQo+IF9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fDQo+IGZyZWVic2QtdHJhbnNwb3J0 QGZyZWVic2Qub3JnIG1haWxpbmcgbGlzdCANCj4gaHR0cHM6Ly9saXN0cy5mcmVlYnNkLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2ZyZWVic2QtdHJhbnNwb3J0DQo+IFRvIHVuc3Vic2NyaWJlLCBzZW5k IGFueSBtYWlsIHRvICJmcmVlYnNkLXRyYW5zcG9ydC11bnN1YnNjcmliZUBmcmVlYnNkLm9yZyIN Cg0KLS0tLS0tDQpSYW5kYWxsIFN0ZXdhcnQNCnJyc0BuZXRmbGl4LmNvbQ0KDQoNCg0K From owner-freebsd-transport@freebsd.org Tue Jul 30 18:58:52 2019 Return-Path: Delivered-To: freebsd-transport@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 43F5CAA595 for ; Tue, 30 Jul 2019 18:58:52 +0000 (UTC) (envelope-from rrs@netflix.com) Received: from mail-vs1-xe29.google.com (mail-vs1-xe29.google.com [IPv6:2607:f8b0:4864:20::e29]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B1A406CEF2 for ; Tue, 30 Jul 2019 18:58:50 +0000 (UTC) (envelope-from rrs@netflix.com) Received: by mail-vs1-xe29.google.com with SMTP id k9so44292658vso.5 for ; Tue, 30 Jul 2019 11:58:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=nUAlW+0iOSSKfQFUhcS/62hJhHeTdxyR4ZLBOlCgU/I=; b=dj2m0QwcHKO0+WByKnb+3wKoAt8qbC1MxpnAWsKwT2/iQ9krkjxe+NMPoHPiVuIltz Uk+A5tGJ8vG5h3/07PgKTiByWIVNpmUGNCemtC8zM1CGDtdUD85kFr0+swfPnPvtLI2m GUW75k+gptWtRp6NejW1Xso2W3Xi6+jUvUsxNVkyZbqk2xEVPo+77sgijDHsaYB5bq1k sVVMHU1ggxdriji6HaVFVicRh5RozRY462ZyI8ywlI+LOjD2eJlj6XOih1PuDELjj7+W Kuu6n+j4tq0/nrPvqPldWZnijAeCtcdg5bGW51GGrqZhz3a1oU9OtK0sOW0uNaVbqxOt 9PKg== X-Gm-Message-State: APjAAAWrQyGzVSAzH+WdpGd320rWFOO8oCzVVygHAC5+48+89pFna8dW 1+GwVtgxq2Htm97EHNKW1IqeQNY5Rsg= X-Google-Smtp-Source: APXvYqwxsjm4mUE1FocelMXNdRLKbhfJxbMTa9VOund0b36u7qbnCtwgYlo6gZJHpSy9C5PQ7QDkZg== X-Received: by 2002:a67:8709:: with SMTP id j9mr74795385vsd.35.1564513129700; Tue, 30 Jul 2019 11:58:49 -0700 (PDT) Received: from ?IPv6:2607:fb10:7061:7fd::2bb4? ([2607:fb10:7061:7fd::2bb4]) by smtp.gmail.com with ESMTPSA id i24sm12251612ual.10.2019.07.30.11.58.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 30 Jul 2019 11:58:48 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: tcpcb cleanup? From: Randall Stewart In-Reply-To: Date: Tue, 30 Jul 2019 14:58:47 -0400 Cc: "freebsd-transport@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: To: "Scheffenegger, Richard" X-Mailer: Apple Mail (2.3445.9.1) X-Rspamd-Queue-Id: B1A406CEF2 X-Spamd-Bar: --------------- X-Spamd-Result: default: False [-15.58 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; MV_CASE(0.50)[]; RCVD_COUNT_THREE(0.00)[3]; MX_GOOD(-0.01)[alt1.aspmx.l.google.com,aspmx.l.google.com,aspmx2.googlemail.com,alt2.aspmx.l.google.com,aspmx3.googlemail.com]; DKIM_TRACE(0.00)[netflix.com:+]; RCPT_COUNT_TWO(0.00)[2]; NEURAL_HAM_SHORT(-0.99)[-0.990,0]; DMARC_POLICY_ALLOW(-0.50)[netflix.com,reject]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; SUBJECT_ENDS_QUESTION(1.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[netflix.com:s=google]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-transport@freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; WHITELIST_DMARC(-7.00)[netflix.com:D:+]; RCVD_IN_DNSWL_NONE(0.00)[9.2.e.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; IP_SCORE(-3.08)[ip: (-9.80), ipnet: 2607:f8b0::/32(-3.09), asn: 15169(-2.45), country: US(-0.05)]; WHITELIST_SPF_DKIM(-3.00)[netflix.com:d:+,netflix.com:s:+] X-BeenThere: freebsd-transport@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions of transport level network protocols in FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Jul 2019 18:58:52 -0000 That should change soon :) R > On Jul 30, 2019, at 2:45 PM, Scheffenegger, Richard = wrote: >=20 > I believe the alignment of some pointers is also off, further shifting = the data... >=20 > I started some work in D21117 around this - reducing the size of this = t_rttupdated in tcpcb down from ulong to uint8_t, as it really only = needs to track the initial few rounds, and then stay fixed at the = UCHAR_MAX. >=20 > Also, I made other types, particularly pure counters, uint32_t (from = int), giving them more range. >=20 > It seems that some variables, that are only (currently) used in the NF = RACK stack, have "leaked" out already =F0=9F=98=8A (t_maxunacktime is = referenced to, but apparently never set, in the upstreamed RACK stack). >=20 > Best regards, >=20 >=20 > Richard Scheffenegger >=20 > -----Original Message----- > From: Randall Stewart =20 > Sent: Dienstag, 30. Juli 2019 08:41 > To: Scheffenegger, Richard > Cc: freebsd-transport@freebsd.org > Subject: Re: tcpcb cleanup? >=20 > NetApp Security WARNING: This is an external email. Do not click links = or open attachments unless you recognize the sender and know the content = is safe. >=20 >=20 >=20 >=20 > Yes >=20 > As I said in comments to your removal of the sack field, they have = drifted since my first work. >=20 > I am not too concerned since the first 3 cache lines are the most used = and most important. >=20 > I do intend to do a re-analysis once I get BBR and the latest Rack in = to see if we could improve things.. though it is doubtful that we will = gain much (but you never know) ;) >=20 > R >=20 >> On Jul 29, 2019, at 11:13 PM, Scheffenegger, Richard = wrote: >>=20 >> Hi, >>=20 >> I've been looking into the cache line alignment today (because = D18811). >>=20 >> Found that the commented cache lines only align to line 3 - then they = drift from the comments. >>=20 >> For example, t_rttupdated is defined as u_long (8 bytes), while it = really only tracks if at least some (small) number of rtt samples were = collected, to start the use of the rtt vars... >>=20 >> Realistically, a uint8_t with a limited increment (if (x<255) x++) = would serve the very same function... >>=20 >> Other example: t_sndzerowin (in tcpcb) appears to be only a counter, = better placed into the tcpstat structure, where non-functional counters = belong IMHO. (perhaps a per-session variant). >>=20 >>=20 >>=20 >>=20 >> And the other variables could probably be defined in the explicit = types (uint16/32/64), to be more certain of the alignment - plus making = sure that alignment boundaries between different sized types don't = result in unintentional shifting of the alignment (like it seems = currently to be the case). >>=20 >> Another prime example: struct sackhint is 40 bytes, only 24 of these = are actually used; and ideally, sackblks, snd_fack share the same line, = while sackhint and snd_holes would do the same (currently, both are = distributed across 2) .... >>=20 >>=20 >> Any appetite to get the (higher) cache lines aligned in tcpcb? >>=20 >> Best regards, >> Richard >>=20 >>=20 >> _______________________________________________ >> freebsd-transport@freebsd.org mailing list=20 >> https://lists.freebsd.org/mailman/listinfo/freebsd-transport >> To unsubscribe, send any mail to = "freebsd-transport-unsubscribe@freebsd.org" >=20 > ------ > Randall Stewart > rrs@netflix.com >=20 >=20 >=20 ------ Randall Stewart rrs@netflix.com