From owner-svn-src-all@freebsd.org Sun Oct 20 00:43:20 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0E8E515B11E; Sun, 20 Oct 2019 00:43:20 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 46wgx36BL3z3KkH; Sun, 20 Oct 2019 00:43:19 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1]) by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id x9K0h6B7030773; Sat, 19 Oct 2019 17:43:06 -0700 (PDT) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: (from freebsd@localhost) by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id x9K0h5YZ030772; Sat, 19 Oct 2019 17:43:05 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201910200043.x9K0h5YZ030772@gndrsh.dnsmgr.net> Subject: Re: svn commit: r353365 - head/usr.bin/procstat In-Reply-To: To: Jeremie Le Hen Date: Sat, 19 Oct 2019 17:43:05 -0700 (PDT) CC: rgrimes@freebsd.org, src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 46wgx36BL3z3KkH X-Spamd-Bar: ----- X-Spamd-Result: default: False [-5.93 / 15.00]; NEURAL_HAM_MEDIUM(-0.93)[-0.933,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Oct 2019 00:43:20 -0000 > On Thu, Oct 10, 2019 at 11:27 PM Rodney W. Grimes > wrote: > > > > > Author: jlh > > > Date: Wed Oct 9 20:05:14 2019 > > > New Revision: 353365 > > > URL: https://svnweb.freebsd.org/changeset/base/353365 > > > > > > Log: > > > Add a missing macro for the previous commit (IS_INADDR_ANY()). > > > > Can we write it the same was as it is 100+ other places? > > 1022}# find . -type f | xargs grep "== INADDR_ANY" | wc > > 131 781 9607 > > Done in r353768. Thanks! Thank you. > > > Modified: > > > head/usr.bin/procstat/procstat_files.c > > > > > > Modified: head/usr.bin/procstat/procstat_files.c > > > ============================================================================== > > > --- head/usr.bin/procstat/procstat_files.c Wed Oct 9 20:01:23 2019 (r353364) > > > +++ head/usr.bin/procstat/procstat_files.c Wed Oct 9 20:05:14 2019 (r353365) > > > @@ -94,6 +94,7 @@ addr_to_string(struct sockaddr_storage *ss, char *buff > > > struct sockaddr_in6 *sin6; > > > struct sockaddr_in *sin; > > > struct sockaddr_un *sun; > > > +#define IS_INADDR_ANY(x) ((x).s_addr == INADDR_ANY) > > > > > > switch (ss->ss_family) { > > > case AF_LOCAL: > > > > > > > -- > > Rod Grimes rgrimes@freebsd.org > > > > -- > Jeremie Le Hen > jlh@FreeBSD.org > -- Rod Grimes rgrimes@freebsd.org