From owner-svn-src-head@freebsd.org Sun May 26 12:41:04 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6D1EF15A5AF6; Sun, 26 May 2019 12:41:04 +0000 (UTC) (envelope-from danfe@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0C7D285F3B; Sun, 26 May 2019 12:41:04 +0000 (UTC) (envelope-from danfe@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id D3F241BBB9; Sun, 26 May 2019 12:41:03 +0000 (UTC) (envelope-from danfe@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id x4QCf3c0086607; Sun, 26 May 2019 12:41:03 GMT (envelope-from danfe@FreeBSD.org) Received: (from danfe@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id x4QCf3ng086605; Sun, 26 May 2019 12:41:03 GMT (envelope-from danfe@FreeBSD.org) Message-Id: <201905261241.x4QCf3ng086605@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: danfe set sender to danfe@FreeBSD.org using -f From: Alexey Dokuchaev Date: Sun, 26 May 2019 12:41:03 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r348286 - in head/sys/dev: ctau cxgbe X-SVN-Group: head X-SVN-Commit-Author: danfe X-SVN-Commit-Paths: in head/sys/dev: ctau cxgbe X-SVN-Commit-Revision: 348286 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 0C7D285F3B X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.97 / 15.00]; local_wl_from(0.00)[FreeBSD.org]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.98)[-0.975,0]; ASN(0.00)[asn:11403, ipnet:2610:1c1:1::/48, country:US]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 May 2019 12:41:04 -0000 Author: danfe (ports committer) Date: Sun May 26 12:41:03 2019 New Revision: 348286 URL: https://svnweb.freebsd.org/changeset/base/348286 Log: Fix two errors reported by PVS Studio: V646 Consider inspecting the application's logic. It's possible that 'else' keyword is missing. Reviewed by: gallatin, np, pfg Approved by: pfg Differential Revision: https://reviews.freebsd.org/D20396 Modified: head/sys/dev/ctau/ctddk.c head/sys/dev/cxgbe/t4_main.c Modified: head/sys/dev/ctau/ctddk.c ============================================================================== --- head/sys/dev/ctau/ctddk.c Sun May 26 03:52:35 2019 (r348285) +++ head/sys/dev/ctau/ctddk.c Sun May 26 12:41:03 2019 (r348286) @@ -237,7 +237,7 @@ int ct_set_clk (ct_chan_t *c, int clk) if (c->mode == M_E1) { ct_setup_e1 (c->board); return 0; - } if (c->mode == M_G703) { + } else if (c->mode == M_G703) { ct_setup_g703 (c->board); return 0; } else Modified: head/sys/dev/cxgbe/t4_main.c ============================================================================== --- head/sys/dev/cxgbe/t4_main.c Sun May 26 03:52:35 2019 (r348285) +++ head/sys/dev/cxgbe/t4_main.c Sun May 26 12:41:03 2019 (r348286) @@ -9709,7 +9709,7 @@ set_offload_policy(struct adapter *sc, struct t4_offlo /* Delete installed policies. */ op = NULL; goto set_policy; - } if (uop->nrules > 256) { /* arbitrary */ + } else if (uop->nrules > 256) { /* arbitrary */ return (E2BIG); }