From owner-svn-src-head@freebsd.org Sun Jun 23 00:16:20 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AB6F415BE5DF; Sun, 23 Jun 2019 00:16:20 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-io1-f43.google.com (mail-io1-f43.google.com [209.85.166.43]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8F1CE6C3A2; Sun, 23 Jun 2019 00:16:18 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-io1-f43.google.com with SMTP id e3so592712ioc.12; Sat, 22 Jun 2019 17:16:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc:content-transfer-encoding; bh=HuSoddGLS1i4kPG2LBRYp2pxleDet6LQhX5axlGnyrg=; b=uSvb1KPzIJG74Jixx74mFmmkdkY4uKPbwrnp5TO9QRP8vGslM7O6P/W8I6P1nv98lv zcGGru2Li0F3jQGp05O4YD5OXhwOY0FWB2BP2NIL4d71LupcHjR/EC0Ghy0rZhD14lhZ o8/dWbbid9dyTgnWoyTKR7cWm1qEUNrPP4Ic/lQtZDOEh9fVbPfo9sHDy7fi75jGWZ8p eXMyGHXxl4S+gx8bY1vREAQxtDbGsvhseK/gh5BVAX3EqjUSc9QThEMn3uTvBO+LAckJ 05UKjjEknLRigxeXedev7pd2ACwV2mkhMYJHa8Mk5VZkmYg4vFb3HEEr4ODsnmxVEUSs FYYQ== X-Gm-Message-State: APjAAAWpdpktXQzyuDeqHnnV/URh11CAIN371bhHBeq6kyMY7l0HvUR3 LsZU9Ce0uewMeoNxOhW9d0Vw5YuP X-Google-Smtp-Source: APXvYqz0tOg39O2vRwuhiPNgh/AGLl2rm3LwJaUsqAL1d3wYZ4aODcWAzCU5wPHb74EvYuYgoLb3rA== X-Received: by 2002:a5e:9241:: with SMTP id z1mr8905765iop.39.1561248970222; Sat, 22 Jun 2019 17:16:10 -0700 (PDT) Received: from mail-io1-f52.google.com (mail-io1-f52.google.com. [209.85.166.52]) by smtp.gmail.com with ESMTPSA id y18sm8345348iob.64.2019.06.22.17.16.09 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Sat, 22 Jun 2019 17:16:09 -0700 (PDT) Received: by mail-io1-f52.google.com with SMTP id k8so349963iot.1; Sat, 22 Jun 2019 17:16:09 -0700 (PDT) X-Received: by 2002:a6b:6409:: with SMTP id t9mr32603194iog.270.1561248969777; Sat, 22 Jun 2019 17:16:09 -0700 (PDT) MIME-Version: 1.0 References: <201906171949.x5HJn9Ed091108@repo.freebsd.org> In-Reply-To: <201906171949.x5HJn9Ed091108@repo.freebsd.org> Reply-To: cem@freebsd.org From: Conrad Meyer Date: Sat, 22 Jun 2019 17:15:59 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r349151 - in head: lib/libufs stand/libsa sys/conf sys/dev/iscsi sys/dev/iscsi_initiator sys/dev/liquidio sys/dev/usb/net sys/fs/ext2fs sys/fs/nandfs sys/geom/part sys/geom/raid sys/ker... To: Xin LI Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 8F1CE6C3A2 X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of csecem@gmail.com designates 209.85.166.43 as permitted sender) smtp.mailfrom=csecem@gmail.com X-Spamd-Result: default: False [-5.43 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; HAS_REPLYTO(0.00)[cem@freebsd.org]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; REPLYTO_ADDR_EQ_FROM(0.00)[]; RCVD_COUNT_THREE(0.00)[4]; TO_DN_ALL(0.00)[]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; NEURAL_HAM_SHORT(-0.99)[-0.987,0]; FORGED_SENDER(0.30)[cem@freebsd.org,csecem@gmail.com]; MIME_TRACE(0.00)[0:+]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TAGGED_FROM(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_NEQ_ENVFROM(0.00)[cem@freebsd.org,csecem@gmail.com]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[freebsd.org]; RCVD_TLS_LAST(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[43.166.85.209.list.dnswl.org : 127.0.5.0]; IP_SCORE(-2.43)[ip: (-6.34), ipnet: 209.85.128.0/17(-3.44), asn: 15169(-2.33), country: US(-0.06)] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Jun 2019 00:16:20 -0000 Hi Xin Li, On Mon, Jun 17, 2019 at 12:49 PM Xin LI wrote: > > Author: delphij > Date: Mon Jun 17 19:49:08 2019 > New Revision: 349151 > URL: https://svnweb.freebsd.org/changeset/base/349151 > > Log: > Separate kernel crc32() implementation to its own header (gsb_crc32.h) = and > rename the source to gsb_crc32.c. > > This is a prerequisite of unifying kernel zlib instances. > >... > Modified: head/sys/libkern/x86/crc32_sse42.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/libkern/x86/crc32_sse42.c Mon Jun 17 17:35:55 2019 (= r349150) > +++ head/sys/libkern/x86/crc32_sse42.c Mon Jun 17 19:49:08 2019 (= r349151) > @@ -29,14 +29,14 @@ __FBSDID("$FreeBSD$"); > /* > * This file is compiled in userspace in order to run ATF unit tests. > */ > -#ifdef USERSPACE_TESTING > +#ifndef _KERNEL This change and following identical changes revert a request by kib@ in https://reviews.freebsd.org/D9342 . (When this revision was initially proposed in , it was '#ifndef _KERNEL' =E2=80=94 kib@ requested = the use of a different preprocessor macro.) Cheers, Conrad