From owner-svn-src-projects@freebsd.org Sun Apr 7 17:22:32 2019 Return-Path: Delivered-To: svn-src-projects@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AC8A5156593E for ; Sun, 7 Apr 2019 17:22:32 +0000 (UTC) (envelope-from ngie@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 52B506A594; Sun, 7 Apr 2019 17:22:32 +0000 (UTC) (envelope-from ngie@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 26AE1F507; Sun, 7 Apr 2019 17:22:32 +0000 (UTC) (envelope-from ngie@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id x37HMW9S064849; Sun, 7 Apr 2019 17:22:32 GMT (envelope-from ngie@FreeBSD.org) Received: (from ngie@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id x37HMWY0064848; Sun, 7 Apr 2019 17:22:32 GMT (envelope-from ngie@FreeBSD.org) Message-Id: <201904071722.x37HMWY0064848@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: ngie set sender to ngie@FreeBSD.org using -f From: Enji Cooper Date: Sun, 7 Apr 2019 17:22:32 +0000 (UTC) To: src-committers@freebsd.org, svn-src-projects@freebsd.org Subject: svn commit: r346014 - projects/runtime-coverage-v2/share/mk X-SVN-Group: projects X-SVN-Commit-Author: ngie X-SVN-Commit-Paths: projects/runtime-coverage-v2/share/mk X-SVN-Commit-Revision: 346014 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 52B506A594 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.97 / 15.00]; local_wl_from(0.00)[FreeBSD.org]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.97)[-0.969,0]; ASN(0.00)[asn:11403, ipnet:2610:1c1:1::/48, country:US]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Apr 2019 17:22:32 -0000 Author: ngie Date: Sun Apr 7 17:22:31 2019 New Revision: 346014 URL: https://svnweb.freebsd.org/changeset/base/346014 Log: Disable MK_COVERAGE* when cross-building Unfortunately, make tinderbox is building a copy of libclang_rt.profile*.a for the machine architecture, not the target architecture, while looking for the library under the cross-toolchain directory, with the current set of proposed changes. As such, disable MK_COVERAGE and MK_COVERAGE_SUPPORT until I work out why the library isn't being built and installed as expected. Add a comment to note the issue. Modified: projects/runtime-coverage-v2/share/mk/src.opts.mk Modified: projects/runtime-coverage-v2/share/mk/src.opts.mk ============================================================================== --- projects/runtime-coverage-v2/share/mk/src.opts.mk Sun Apr 7 16:33:22 2019 (r346013) +++ projects/runtime-coverage-v2/share/mk/src.opts.mk Sun Apr 7 17:22:31 2019 (r346014) @@ -405,6 +405,15 @@ __DEFAULT_YES_OPTIONS+=OPENMP __DEFAULT_NO_OPTIONS+=OPENMP .endif +# cross toolchains with "make universe" aren't properly building +# libclang_rt.profile*.a yet for the target platform and installing it to the +# expected location, so disable coverage support for now with clang when +# cross-building. +.if ${COMPILER_TYPE} == "clang" && ${__T} != ${__TT} +BROKEN_OPTIONS+=COVERAGE +BROKEN_OPTIONS+=COVERAGE_SUPPORT +.endif + .include #