From owner-freebsd-emulation@freebsd.org Sun May 24 02:27:37 2020 Return-Path: Delivered-To: freebsd-emulation@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8CF2E2F5B7C for ; Sun, 24 May 2020 02:27:37 +0000 (UTC) (envelope-from damjan.jov@gmail.com) Received: from mail-il1-x135.google.com (mail-il1-x135.google.com [IPv6:2607:f8b0:4864:20::135]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49V3zD3pmzz46mh for ; Sun, 24 May 2020 02:27:36 +0000 (UTC) (envelope-from damjan.jov@gmail.com) Received: by mail-il1-x135.google.com with SMTP id 18so14548540iln.9 for ; Sat, 23 May 2020 19:27:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Vts15ExpUhNQFSyB/jo1HB7sUN8NqOWDuDU2u7gGBF0=; b=hzNBRhsJXpyTkZP8hR/E1AchrnDS1hnElFgUra50UUbL2+J0c3MwE4alnlyw/aolTv T1vYyk4CIW4r3JCBDHG7nFazfcb9HJsZQcG08WlsO7a3n0HNFVDbXFBXO9gVtX7KmtMV Hain7X+AHBawc7lzwJ2RzzIvhLvBOUyx92NOFoa8SQc3rWtrr/RIAcLI9ZAulaaFQv3j gCetFTG/DtuV/lnDyWsslgpKVmvbzr2E/NuLG9d9MXgM8JZm6yP4CuUyV7io7uevThVS U5iyhSB+Ed6+WCQ0xTPUhT2QIYZXDzRgwBSoKwsRw9mic1KpN7LW8oA4+X3+VyqYU8G2 IhaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Vts15ExpUhNQFSyB/jo1HB7sUN8NqOWDuDU2u7gGBF0=; b=kmEu6kWv7ikXay00baAXYg2pYRomithS8SvqHcmeY2OzkJ5pkybrV9CCLLQgWkx4Y7 rGoHEbGQa4Yb4rZIms1MnpEWszA/gQnPR91gj5KtfS4eIRE00kAphaO6S6lFRGB6S/9T GxBvSUREjx23FD83HG0Vc0pH8hlnLZKXIYCEVp6cSIC6rEJuZCMpYnRazXpKOia8Nez3 BN3F1v8HFCHHqcMBUugNQJ/dFSVCIgTM2QcEWYwzveLzGYrQE/AxBi8kzULEEPxIzirf jcvXdVVZXBdq2LDhVBCXqRuUiRT7rKXAzgHMUUwSz8lEUPyh028iymbx9qb7bDmzIVrt uYWA== X-Gm-Message-State: AOAM533AtOpEYljFnfIFPVbJLSJh6bf2N6UApwHPgd1AZxDXgV7LbFXE 5G+KGtTxA5F8mrq2EhaDUuF6fLukwMxKu8wLKvW9B1ph6PidyA== X-Google-Smtp-Source: ABdhPJzw9NZn4ctfZN22afclaHs1E6PKtXlvXsNGLPvgSH5Y2LAc3vxfYZXFdtMyIV9eCeY2EfXBramIZVjU7FXOs/0= X-Received: by 2002:a05:6e02:13ab:: with SMTP id h11mr18426210ilo.191.1590287255257; Sat, 23 May 2020 19:27:35 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Damjan Jovanovic Date: Sun, 24 May 2020 04:26:43 +0200 Message-ID: Subject: Re: Wine 5.9 bugfix To: Gerald Pfeifer Cc: freebsd-emulation@freebsd.org X-Rspamd-Queue-Id: 49V3zD3pmzz46mh X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=hzNBRhsJ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of damjanjov@gmail.com designates 2607:f8b0:4864:20::135 as permitted sender) smtp.mailfrom=damjanjov@gmail.com X-Spamd-Result: default: False [-3.87 / 15.00]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; NEURAL_HAM_MEDIUM(-1.05)[-1.050]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_FROM(0.00)[gmail.com]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-emulation@freebsd.org]; NEURAL_HAM_LONG(-1.01)[-1.008]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; RCPT_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::135:from]; NEURAL_HAM_SHORT(-0.82)[-0.816]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[gmail.com]; RCVD_COUNT_TWO(0.00)[2]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TAGGED_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.33 X-BeenThere: freebsd-emulation@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Development of Emulators of other operating systems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 May 2020 02:27:37 -0000 On Sat, May 23, 2020 at 9:53 PM Gerald Pfeifer wrote: > On Sat, 23 May 2020, Damjan Jovanovic wrote: > > Wine 5.9 is out, and all 3 of the bugs in 5.7 - 5.8 that were affecting > > FreeBSD should be fixed upstream now. > > Thank you for debugging and even fixing those, Damjan - and even doing > so upstream! > > > However I accidentally introduced another bug recently, where we don't > > check the return value from an mmap() call, resulting in assertion > failures > > and possibly memory corruption... I debugged it and a patch to fix it is > > available (https://source.winehq.org/patches/data/185684). Please build > > ports with that patch applied to 5.9. Sorry. > > I just started test builds of emulators/wine-devel with that patch. > > So far I have kept files/patch-tools-winegcc which reverts the upstream > change (1ccd638b1aa85fb3c43b49d69d279cd509ebdc21) that kicked of this > avalanche of events. I was thinking to keep that as part of our port > until the next snapshot (Wine 5.10) - do you have any strong feelings > or recommendations either way? > > While I don't completely understand the many changes there, I would advise against files/patch-tools-winegcc as Linux doesn't use it, and the only issue on FreeBSD was that rtld-elf problem which Wine worked around in 5.9. > Thanks, > Gerald > Damjan