From owner-freebsd-hackers@freebsd.org Sun Mar 8 05:42:37 2020 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6B5F125EEDE for ; Sun, 8 Mar 2020 05:42:37 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic301-20.consmr.mail.gq1.yahoo.com (sonic301-20.consmr.mail.gq1.yahoo.com [98.137.64.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 48Zqxl3sGfz4dfx for ; Sun, 8 Mar 2020 05:42:34 +0000 (UTC) (envelope-from marklmi@yahoo.com) X-YMail-OSG: Ot6Dw5AVM1nq3Jj47v8n1acyS5DKCKklJDP5RW0FYYGFQ7p8LeQ1kW8rjdm.zZR omYVR96ULFkFkhRiQe0iR5ebz.kaEGQb_tNogLOQBK6C4qaNhEyObh1MmMYP54sGrul4cSBoOeVL j_QCe5jqCr5pyd6RClxc_yVY2PoJ.gNj17r5BzSLH.l1S2Fpzqz.fAi0tHkDHmyhLQqF7tQplltc fSdndRdRQ_sElEt9Y6ZiO67I_62Bwt.1JM_LNs_0XM5srvepsakRw9wSNyaeeagfSRM5CpCxzRRf MeSzxbd6vWLWbFZGGJg6_ia3TBrWzfGf8VqYZf5r8uPl5yVn4fG08SjZiIuiI4JNwKzplsPbawRH yoHCzDIGiraKdq_bRI9shuIctcb9.89Kdk.FMj3LRlloO88j3kVEauYofqm9VpWDSrXFTW33B70g sb_4G4xyZ.teknU43aRHl327.yyd7PYNQe.z8BdPD99YH6EF_U5e.4PKPODMkAdDZPgwMBFdV4nK KIrkNeY1cGFjrDnTGyyN7HqLnH0_T_LMkq_I_NJaWE0H5SXWTwbn5JWq0J7fYweX7aJOXOE8NI_G 078e8ji3C8L1HbXZgyw37.BLFQUt6FJA5NLvqkFxABhTykKn3SpNNZTufHIyqgPrm1kjrE76GHP8 kwhybtBMez0ZUaqKw2rdx9pAyZpLMB7C5yHqMGlWddVnhX9RaF_GHOA6NX0eIddZF2CuksaGBuEd RcNhAR9JLMz.k0p7gLEHkNaJ_JgAPZgyMdkcuQmh0.yZZzltBDR4NdKXcqlSW9PX_QUKmwZjDXLv 42cipFiK1eLcB4FTqz14_hv_MYv1NtorDxoCsSZRptO6Cu6FdxUiGL7UCxPK2RyJkD4HYtQFmYBb 7iMN8b4oeauJUpvtR1ZI4nQbuNFNbR1kOaaXdi9O3IKF2qDjlzbSXArV4Xp4xS6x4exwAFderu5l VyzgnZ.uaUaZAUQBw9bIJexg1jqLqX8PtfnHWlSeYjMvkwjtNvjTg.9WjS1I3.djzvliV27tNmcs jD5SZE1yohMVhKXb18dGi1xgojRYWtjL09R29eG02Iz_566JxV1x1bCxqFwjzRyK7y20iaxHTzEo IeFdJ11nbMpFwJIBxjxZjrF3731AfuVj_4uDrfr2INNNfN2HTXxoafjbFy6ArDip.XdpEyrQWGwf jr0WVswNOcgEVkCc3asy.leVt1hiAAKzoryhM1hkR.YHchrlrTpWk5yy3Bvu_QvtozjKor_1LyD5 9DtMkZmh3grMmsPscWhA6_RDo5jxrwwUfNzLmf61UuVywhrKfp7D6Mu0aj0R3vkBrrbGs_LIMeR0 k8Y16KpgYX.ECjhRCzAcWcr4QWFoy70tAKefCC.1LQri4LddzTQBMLel.TXxcoiiF9.pvIXiwaDd .UHI- Received: from sonic.gate.mail.ne1.yahoo.com by sonic301.consmr.mail.gq1.yahoo.com with HTTP; Sun, 8 Mar 2020 05:42:33 +0000 Received: by smtp414.mail.ne1.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 34a81c2ff716654377b2d950a00098de; Sun, 08 Mar 2020 05:42:30 +0000 (UTC) From: Mark Millard Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.60.0.2.5\)) Subject: bugzilla 213937, syscall(int, ...), struct ktr_syscall's short ktr_code, struct syscall_args's u_int code: should the bug be closed? Message-Id: <5AEC7760-EF38-4738-AEBD-9E563CB0E62B@yahoo.com> Date: Sat, 7 Mar 2020 21:42:29 -0800 To: FreeBSD Hackers X-Mailer: Apple Mail (2.3608.60.0.2.5) References: <5AEC7760-EF38-4738-AEBD-9E563CB0E62B.ref@yahoo.com> X-Rspamd-Queue-Id: 48Zqxl3sGfz4dfx X-Spamd-Bar: ++ X-Spamd-Result: default: False [2.15 / 15.00]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; FREEMAIL_FROM(0.00)[yahoo.com]; MV_CASE(0.50)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[yahoo.com:+]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; SUBJECT_ENDS_QUESTION(1.00)[]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/21, country:US]; MID_RHS_MATCH_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[yahoo.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; NEURAL_SPAM_MEDIUM(1.00)[0.999,0]; RCPT_COUNT_ONE(0.00)[1]; IP_SCORE_FREEMAIL(0.00)[]; IP_SCORE(0.00)[ip: (3.58), ipnet: 98.137.64.0/21(0.84), asn: 36647(0.67), country: US(-0.05)]; NEURAL_SPAM_LONG(0.65)[0.653,0]; RCVD_IN_DNSWL_NONE(0.00)[146.64.137.98.list.dnswl.org : 127.0.5.0]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Mar 2020 05:42:37 -0000 Question: Should bugzilla 213937 be left as-is to suggest changing things so that more bad syscall "code/number" values are preserved and reported correctly if/when they happen? Background leading to the question . . . I've been reviewing some of my old bugzilla reports that are still in the new state, closing or adding notes to a bunch of them. The status for what contributes to bugzilla 213937 has not changed over the years since the submittal. Bugzilla 213937 was a report of ktrace misreporting the 24 bit field value in the armv7 svclt instruction. (I had a bad file that had such an instruction with a large 24-bit field value that lead to seeing the problems. It was rather confusing until I figured out the information reported was incorrect relative to the instruction encoding.) Part of the problem was that it looked like the lower 16 bits had been used but sign extended to produce the reported value, a negative number as reported. (It took a while to notice that.) Oleksandr Tymoshenko eventually reported in comment #2 that there is the odd mix of types in use overall (I'm using the "code" terminology below): syscall(int code,...) struct ktr_syscall's short ktr_code struct syscall_args's u_int code Sure enough, using ktr_code could generate a sign-extension of a 16-bit value. But syscall and syscall_args are a little odd as well (signed vs. unsigned at least). It looks like "short ktr_code" has been around for long before I ever ran into it and might well be expected by folks with more historical background than I had. But it can not preserve all int or u_int values for FreeBSD's normal definitions of those types. Is this something that should be fixed? Does it have a reason for being as it is? === Mark Millard marklmi at yahoo.com ( dsl-only.net went away in early 2018-Mar)