From owner-freebsd-hackers@freebsd.org Mon Jul 20 22:56:34 2020 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C2F0336C216; Mon, 20 Jul 2020 22:56:34 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4B9cXy3VGVz4g3M; Mon, 20 Jul 2020 22:56:34 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: mmacy) by smtp.freebsd.org (Postfix) with ESMTPSA id 565E01D9E2; Mon, 20 Jul 2020 22:56:34 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: by mail-lf1-f51.google.com with SMTP id u12so10598371lff.2; Mon, 20 Jul 2020 15:56:34 -0700 (PDT) X-Gm-Message-State: AOAM5326c6IZFEwxjVGV26lAo7xLdUdlT9pL56aoDI7UfoIhJ/u6ya5e ptmhcE/TyEeVVJ3IS5emfBAapc2/dK/3iwoRzJ8= X-Google-Smtp-Source: ABdhPJyybhoOwXo3KGOOm6PHWsvpvL+V4+z3eHcXTkIWSCzyU+SOXXYfEufND/xd+h77Y1nHHWkLhFJoQx684BSM4ok= X-Received: by 2002:ac2:51a1:: with SMTP id f1mr11992204lfk.173.1595285792273; Mon, 20 Jul 2020 15:56:32 -0700 (PDT) MIME-Version: 1.0 From: Matthew Macy Date: Mon, 20 Jul 2020 15:56:20 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: CFT for vendor openzfs - week 3 reminder To: freebsd-current , freebsd-fs , freebsd-hackers@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Jul 2020 22:56:34 -0000 On Wednesday, July 8th I issued the initial call for testing for the update to HEAD to vendored openzfs. We'd like to give users roughly a month to test before merging. I'm pushing the tentative merge date out by a week to August 17th as I wasn't able to spend any time working on this myself last week. Again, I hope it's not terribly controversial to point out that it really rests with users of non amd64 platforms to test to avoid any unpleasant surprises the next time they update their trees following the merge. ========================================================== NB: Do NOT zpool upgrade unless you are willing to live without the ability to ever rollback to the legacy zfs kmod. Checkout updated HEAD: % git clone https://github.com/mattmacy/networking.git -b projects/openzfs_vendor freebsd Checkout updated openzfs in to sys/contrib: % git clone https://github.com/zfsonfreebsd/ZoF.git -b projects/openzfs_vendor freebsd/sys/contrib/openzfs Build world and kernel with whatever your usual configuration is. Where possible the openzfs kmod is backward compatible with the cmd utils in HEAD so common operations work with existing tools and the new kmod. In the projects/openzfs_vendor branch of ZoF ozfs libraries are backward compatible with the zfs kmod in HEAD. Although ideally one would test this in a separate boot environment, the interoperability should allow one to rollback without too much difficulty. Thanks in advance for your time. From owner-freebsd-hackers@freebsd.org Tue Jul 21 05:33:10 2020 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id ABD0E3785CD for ; Tue, 21 Jul 2020 05:33:10 +0000 (UTC) (envelope-from sega01@go-beyond.org) Received: from balrog.mythic-beasts.com (balrog.mythic-beasts.com [IPv6:2a00:1098:0:82:1000:0:2:1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4B9nLY6015z497T for ; Tue, 21 Jul 2020 05:33:09 +0000 (UTC) (envelope-from sega01@go-beyond.org) Received: from [160.3.200.8] (port=55732 helo=localhost) by balrog.mythic-beasts.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92.3) (envelope-from ) id 1jxktj-0003kE-HK for freebsd-hackers@freebsd.org; Tue, 21 Jul 2020 06:33:08 +0100 Date: Tue, 21 Jul 2020 05:32:59 +0000 From: Teran McKinney To: freebsd-hackers@freebsd.org Subject: SA:20-19 Unbound patch is broken for 12.1 Message-ID: <20200721053259.GA21070@daemon> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-BlackCat-Spam-Score: 4 X-Spam-Status: No, score=0.4 X-Rspamd-Queue-Id: 4B9nLY6015z497T X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of sega01@go-beyond.org designates 2a00:1098:0:82:1000:0:2:1 as permitted sender) smtp.mailfrom=sega01@go-beyond.org X-Spamd-Result: default: False [-1.44 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.69)[-0.694]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1098::82:1000:0:2:1]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; DMARC_NA(0.00)[go-beyond.org]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_HAM_LONG(-0.86)[-0.865]; MID_RHS_NOT_FQDN(0.50)[]; NEURAL_SPAM_SHORT(0.02)[0.020]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:44684, ipnet:2a00:1098::/32, country:GB]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; RCVD_IN_DNSWL_LOW(-0.10)[2a00:1098:0:82:1000:0:2:1:from] X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jul 2020 05:33:10 -0000 Hi everyone, It looks like the SA:20-19 Unbound patch for 12.1 is broken. Patch applies cleanly, but it breaks `make buildworld`. Given that it's a security advisory, I figured it wouldn't hurt to get more eyes on it. I'm running into this on my laptop and a fresh install. ---- bash# pwd /usr/src/usr.sbin/unbound bash# make ===> daemon (all) cc -O2 -pipe -I/usr/src/contrib/unbound -I/usr/src/contrib/ldns -I/usr/src/usr.sbin/unbound -I/usr/src/usr.sbin/unbound/daemon -g -MD -MF.depend.acl_list.o -MTacl_list.o -std=gnu99 -fstack-protector-strong -Wsystem-headers -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -Wold-style-definition -Wno-pointer-sign -Wmissing-variable-declarations -Wno-empty-body -Wno-string-plus-int -Wno-unused-const-variable -Qunused-arguments -c /usr/src/contrib/unbound/daemon/acl_list.c -o acl_list.o In file included from /usr/src/contrib/unbound/daemon/acl_list.c:43: In file included from /usr/src/contrib/unbound/daemon/acl_list.h:45: In file included from /usr/src/contrib/unbound/util/storage/dnstree.h:45: /usr/src/contrib/unbound/util/rbtree.h:65:2: error: unknown type name 'uint8_t' uint8_t color; ^ /usr/src/contrib/unbound/util/rbtree.h:81:2: error: unknown type name 'size_t' size_t count; ^ In file included from /usr/src/contrib/unbound/daemon/acl_list.c:43: In file included from /usr/src/contrib/unbound/daemon/acl_list.h:45: /usr/src/contrib/unbound/util/storage/dnstree.h:61:2: error: unknown type name 'uint8_t' uint8_t* name; ^ /usr/src/contrib/unbound/util/storage/dnstree.h:63:2: error: unknown type name 'size_t' size_t len; ^ /usr/src/contrib/unbound/util/storage/dnstree.h:67:2: error: unknown type name 'uint16_t' uint16_t dclass; ^ /usr/src/contrib/unbound/util/storage/dnstree.h:83:26: error: field has incomplete type 'struct sockaddr_storage' struct sockaddr_storage addr; ^ /usr/src/contrib/unbound/util/storage/dnstree.h:83:9: note: forward declaration of 'struct sockaddr_storage' struct sockaddr_storage addr; ^ /usr/src/contrib/unbound/util/storage/dnstree.h:85:2: error: unknown type name 'socklen_t' socklen_t addrlen; ^ /usr/src/contrib/unbound/util/storage/dnstree.h:109:2: error: unknown type name 'uint8_t' uint8_t* name, size_t len, int labs, uint16_t dclass); ^ /usr/src/contrib/unbound/util/storage/dnstree.h:109:17: error: unknown type name 'size_t' uint8_t* name, size_t len, int labs, uint16_t dclass); ^ /usr/src/contrib/unbound/util/storage/dnstree.h:109:39: error: unknown type name 'uint16_t' uint8_t* name, size_t len, int labs, uint16_t dclass); ^ /usr/src/contrib/unbound/util/storage/dnstree.h:127:58: error: unknown type name 'uint8_t' struct name_tree_node* name_tree_find(rbtree_type* tree, uint8_t* name, ^ /usr/src/contrib/unbound/util/storage/dnstree.h:128:2: error: unknown type name 'size_t' size_t len, int labs, uint16_t dclass); ^ /usr/src/contrib/unbound/util/storage/dnstree.h:128:24: error: unknown type name 'uint16_t' size_t len, int labs, uint16_t dclass); ^ /usr/src/contrib/unbound/util/storage/dnstree.h:139:60: error: unknown type name 'uint8_t' struct name_tree_node* name_tree_lookup(rbtree_type* tree, uint8_t* name, ^ /usr/src/contrib/unbound/util/storage/dnstree.h:140:2: error: unknown type name 'size_t' size_t len, int labs, uint16_t dclass); ^ /usr/src/contrib/unbound/util/storage/dnstree.h:140:24: error: unknown type name 'uint16_t' size_t len, int labs, uint16_t dclass); ^ /usr/src/contrib/unbound/util/storage/dnstree.h:148:44: error: unknown type name 'uint16_t' int name_tree_next_root(rbtree_type* tree, uint16_t* dclass); ^ /usr/src/contrib/unbound/util/storage/dnstree.h:167:33: error: unknown type name 'socklen_t' struct sockaddr_storage* addr, socklen_t addrlen, int net); ^ /usr/src/contrib/unbound/util/storage/dnstree.h:191:33: error: unknown type name 'socklen_t' struct sockaddr_storage* addr, socklen_t addrlen); ^ fatal error: too many errors emitted, stopping now [-ferror-limit=] 20 errors generated. *** Error code 1 Stop. make[1]: stopped in /usr/src/usr.sbin/unbound/daemon *** Error code 1 Stop. make: stopped in /usr/src/usr.sbin/unbound ---- Someone already opened a bug for it, but I think it's under the wrong component and may not be getting to the right people. Bug #248010. -Teran From owner-freebsd-hackers@freebsd.org Thu Jul 23 09:55:48 2020 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 98A95379515 for ; Thu, 23 Jul 2020 09:55:48 +0000 (UTC) (envelope-from fernando.apesteguia@gmail.com) Received: from mail-vs1-xe34.google.com (mail-vs1-xe34.google.com [IPv6:2607:f8b0:4864:20::e34]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BC74g1XNNz4M9D for ; Thu, 23 Jul 2020 09:55:46 +0000 (UTC) (envelope-from fernando.apesteguia@gmail.com) Received: by mail-vs1-xe34.google.com with SMTP id d198so2743954vsc.1 for ; Thu, 23 Jul 2020 02:55:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=4YPcMn8ykYlEfR4VW47BH10GCzYdnXo1Jey1PNL+NEQ=; b=k9OsOwy0d+BB7g1LLUN32YaOoQPCBWJhrHVNdsz4DVfYfKvRFZZEz0RGu4Tc6zs2Cy yYKU97ZMcjCtYquPcl+iBol9gdgL+g67Ea6nvX4aVnCaz9ajGOfwA+VPw1k9aNc+0TNl ZXAlUnT/LI2YTYMgBCJGqcFogRikTs/6iTMoHaizQHQE592iFsGmlKGw4HwJo5pQgI2K cpO/65IuMlUFTWcsGMezYsiaVWihoOmMMJdYT3T7dDKo1cEbJDepn1kaceCnPfmnxpRG 1aKQaiXEoVoWos+oDgZjida8zkvuGgPmkHWu3JHx+qcSHKVd1ypQYo2RVKLOJAFv9VGU V19w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=4YPcMn8ykYlEfR4VW47BH10GCzYdnXo1Jey1PNL+NEQ=; b=c7gTNpyh3K18wAtZ5d2+t4dp25X5emAGVXn9lQSpDlscvi8VNNHsz19LCGUx3H7FMD utzZXPUVvJC4JkY0uDYiNpSvogAAUK3OpgVHXP3w6DxyjGvsItaJjwgul6ea+2IYAPlN XJRgioMD9I5r2LCG8hO8QJgM/dPVTq6GvqqGr/BSgGlYFqqhsaduqgM3c1vw99cdsuev 8j4ee2H3Ys+u9OhpxR1fpAbVg7W7rq3YFxYR0po1eVDb01eVamqIAVDLKSFdNxSlWAK1 fbuYwcjPakeI9VUwfZ3MxO0mQl+LDAMaUxYwY/3LKo1p2eYkoFNc+jG9bYEnSC0WYCHq Gh5Q== X-Gm-Message-State: AOAM530b00NVVTyz65NrYUF6Su9lh3XGTseizme+8iKhLKQesAu6RCxh F2WhSCOqoHIuVIFXQEpGIDzmMOMLpLOYs4OzqpodE64W X-Google-Smtp-Source: ABdhPJy57PGRL0XEl20wBxupKBbl1+aeiGfPz+LuQ9Bha4sBZlBMXeqSMYaZrfvOcy1HxoT3NQuSrR9w0H/Tf1HLrOo= X-Received: by 2002:a67:31cc:: with SMTP id x195mr3190753vsx.101.1595498145796; Thu, 23 Jul 2020 02:55:45 -0700 (PDT) MIME-Version: 1.0 From: =?UTF-8?Q?Fernando_Apestegu=C3=ADa?= Date: Thu, 23 Jul 2020 12:54:51 +0200 Message-ID: Subject: tsort(1) -l (longest cycle) clarification To: FreeBSD Hackers Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4BC74g1XNNz4M9D X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=k9OsOwy0; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of fernandoapesteguia@gmail.com designates 2607:f8b0:4864:20::e34 as permitted sender) smtp.mailfrom=fernandoapesteguia@gmail.com X-Spamd-Result: default: False [-2.92 / 15.00]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; NEURAL_HAM_MEDIUM(-0.99)[-0.987]; FROM_HAS_DN(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; FREEMAIL_FROM(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-hackers@freebsd.org]; NEURAL_HAM_LONG(-1.03)[-1.028]; RCPT_COUNT_ONE(0.00)[1]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::e34:from]; NEURAL_HAM_SHORT(-0.53)[-0.528]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TAGGED_FROM(0.00)[]; R_MIXED_CHARSET(0.62)[subject]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jul 2020 09:55:48 -0000 Hi there, I'm having some doubts about the -l flag in tsort(1). According to the man page, it should show the longest cycle in the graph. Assuming we have a file called graph with the following contents: A B A D B C C A D E E F F E This graph has two cycles one involving two nodes and the other involving three nodes: $ tsort graph tsort: cycle in data tsort: E tsort: F F tsort: cycle in data tsort: A tsort: B tsort: C C A D B E When using -q, tsort(1) does not show information about cycles as expected: $ tsort -q graph F C A D B E Using -l shows the exact same output as not using options at all: $ tsort -l graph tsort: cycle in data tsort: E tsort: F F tsort: cycle in data tsort: A tsort: B tsort: C C A D B E So what's -l supposed to do? Shouldn't it at least mark one of the cycles and say "This one is the longest"? Technically, it shows the longest cycle, but it shows other cycles as well so I don't see the use of this. Cheers