From owner-freebsd-hackers@freebsd.org Sat Aug 15 09:34:11 2020 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 943CA3B3F5B for ; Sat, 15 Aug 2020 09:34:11 +0000 (UTC) (envelope-from wojtek@puchar.net) Received: from puchar.net (puchar.net [194.1.144.90]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4BTFW63XRqz3Zcn for ; Sat, 15 Aug 2020 09:34:10 +0000 (UTC) (envelope-from wojtek@puchar.net) Received: Received: from 127.0.0.1 (localhost [127.0.0.1]) by puchar.net (8.15.2/8.15.2) with ESMTPS id 07F9Y737024964 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Sat, 15 Aug 2020 11:34:07 +0200 (CEST) (envelope-from puchar-wojtek@puchar.net) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=puchar.net; s=default; t=1597484047; bh=1MjaM0yN17wGsavgJyqd1BpY+EmHZJk308BYlj+h8t4=; h=Date:From:To:Subject; b=mmnyfNuCBuTZ7JG76tF+CDZX/kIwdxvwRP/ycg0jk179KeSytY5T3dMnNnvIMN6KH MMCY0jaSRX2XGOHOR0JN78XbadL56Mg0D/6s6dsEOv36sTm1TVIrof+OpPCMxMWM3H ZkUUFjiJzBTZxjgJXjQBRi2ohBKCuMJXV1JCkyz4= Received: from localhost (puchar-wojtek@localhost) by puchar.net (8.15.2/8.15.2/Submit) with ESMTP id 07F9Y7Be024961 for ; Sat, 15 Aug 2020 11:34:07 +0200 (CEST) (envelope-from puchar-wojtek@puchar.net) Date: Sat, 15 Aug 2020 11:34:07 +0200 (CEST) From: Wojciech Puchar To: freebsd-hackers@freebsd.org Subject: gmirror balance model "prefer" doesnt work properly Message-ID: User-Agent: Alpine 2.20 (BSF 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Rspamd-Queue-Id: 4BTFW63XRqz3Zcn X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=fail (headers rsa verify failed) header.d=puchar.net header.s=default header.b=mmnyfNuC; dmarc=none; spf=pass (mx1.freebsd.org: domain of wojtek@puchar.net designates 194.1.144.90 as permitted sender) smtp.mailfrom=wojtek@puchar.net X-Spamd-Result: default: False [-1.34 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.92)[-0.916]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; R_SPF_ALLOW(-0.20)[+mx]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[freebsd-hackers@freebsd.org]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_HAM_LONG(-0.89)[-0.887]; DMARC_NA(0.00)[puchar.net]; R_DKIM_REJECT(1.00)[puchar.net:s=default]; DKIM_TRACE(0.00)[puchar.net:-]; NEURAL_HAM_SHORT(-0.23)[-0.233]; RCVD_IN_DNSWL_NONE(0.00)[194.1.144.90:from]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:43476, ipnet:194.1.144.0/24, country:PL]; RCVD_COUNT_TWO(0.00)[2]; MID_RHS_MATCH_FROM(0.00)[] X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 Aug 2020 09:34:11 -0000 ada0p3 is partition on SSD, ada3p3 is partition on magnetic disk. Geom name: root State: COMPLETE Components: 2 Balance: prefer Slice: 2097152 Flags: NONE GenID: 0 SyncID: 1 ID: 3736675121 Type: AUTOMATIC Providers: 1. Name: mirror/root Mediasize: 107374181888 (100G) Sectorsize: 512 Stripesize: 4096 Stripeoffset: 0 Mode: r1w1e1 Consumers: 1. Name: ada0p3 Mediasize: 107374182400 (100G) Sectorsize: 512 Stripesize: 0 Stripeoffset: 525139968 Mode: r1w1e1 State: ACTIVE Priority: 1 Flags: (null) GenID: 0 SyncID: 1 ID: 3655477467 2. Name: ada3p3 Mediasize: 107374182400 (100G) Sectorsize: 512 Stripesize: 4096 Stripeoffset: 0 Mode: r1w1e1 State: ACTIVE Priority: 0 Flags: NONE GenID: 0 SyncID: 1 ID: 3836554217 according to manual reads should be preferred from device of higher priority. i've set priority 1 for ssd, 0 for hdd. but reads are from hdd only. tried reverse - 0 for ssd, 1 for hdd - too reads are from hdd. looking in code seems like it is not implemented at all LIST_FOREACH(disk, &sc->sc_disks, d_next) { if (disk->d_state == G_MIRROR_DISK_STATE_ACTIVE) break; } just take first active disk. why?