From owner-freebsd-ports@freebsd.org Sun Nov 15 01:27:22 2020 Return-Path: Delivered-To: freebsd-ports@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6336646BC1A for ; Sun, 15 Nov 2020 01:27:22 +0000 (UTC) (envelope-from douglaswth@gmail.com) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4CYZLy107zz4fvB for ; Sun, 15 Nov 2020 01:27:22 +0000 (UTC) (envelope-from douglaswth@gmail.com) Received: by mailman.nyi.freebsd.org (Postfix) id 21D3746BCA8; Sun, 15 Nov 2020 01:27:22 +0000 (UTC) Delivered-To: ports@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 218DA46BBCB for ; Sun, 15 Nov 2020 01:27:22 +0000 (UTC) (envelope-from douglaswth@gmail.com) Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CYZLx1kp5z4fv9; Sun, 15 Nov 2020 01:27:21 +0000 (UTC) (envelope-from douglaswth@gmail.com) Received: by mail-pl1-x62b.google.com with SMTP id 35so2213416ple.12; Sat, 14 Nov 2020 17:27:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:references:from:subject:message-id:date:user-agent:mime-version :in-reply-to:content-language; bh=dGpeKOQIB9pInlrmPD0A2+Ek8T/qRus/QIXkNn4SejQ=; b=dqcV4k6HByAJWibNyIrxjYtfoakRJQddIETjyn3PIaOxq91WdgDi47v8pckipDax/O UlhTWFutJjimg2kkomnZGe+iOPw1eVICYgfrWHJivMJ/MaRmIdPv6bggBGjGp23dodIO i7TKKbH44C2nVJkHswSIvxKUBTysj82WGf4USdWpj6+kxwA3I2BEjmAJxCWotPFFU41a INEKJhvWQKGqInL/YyMkz6Eug70hieOYolkmygVTCkUBZoF/mQjAdE+g9iLJFXkCRvSW 7ObTwo0fOq6tfvjjo3hF1Ehr/hmjv7621Qxw5cMfr9XcrPyaX85z0fRWak3FdzktuTVr JJRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:references:from:subject:message-id:date :user-agent:mime-version:in-reply-to:content-language; bh=dGpeKOQIB9pInlrmPD0A2+Ek8T/qRus/QIXkNn4SejQ=; b=mTuVQi6WrFpK1LZWBi4xapu+cIcU42Ctv8CuBqCxePq2ROp6aUz0U68tu85hGG8ONb yuE+VcqXba0uCHOQ/pBHJQdgIt12VQxvImP8j1JKtZ3DwblZ67bTebQf2rV5BqPVHE4O kdQpy1LfTer2z+B2m7URRHv0GvBkF764l83pDLf5FS91LeZbuDPmAHuv0ml+T6989EOS E0YFSSVKk/JrZfTnzjX6EQRQlOaqblWNuX/IIr0znUzO4Y3qLSBvpcWU3B4rt7iSOUSj sCY0wC6i+v0KmPYTtpAtIZwSJpq2wDbVAe8SLpaFd4wZAyUw/FXMicRJVCiYGIJ2CU2i xqDg== X-Gm-Message-State: AOAM5320TA9WFadM/O6lRlcOkBhiTivJfytz1xcS8ip/JCZrYdwv82EH 9iUh+bpCjgsx82EF5qnkh7Sg7U/aR30= X-Google-Smtp-Source: ABdhPJzfEzwzzRXJbI2uZ6MoGPVXt03YUQmXk0T5rrjWTof8jzDQ7rcvzeQy/Sk7/NTRStJOvgO2Kg== X-Received: by 2002:a17:902:a989:b029:d7:e0f8:d888 with SMTP id bh9-20020a170902a989b02900d7e0f8d888mr8078460plb.75.1605403639189; Sat, 14 Nov 2020 17:27:19 -0800 (PST) Received: from ?IPv6:2600:8802:5a00:7a08:4857:1523:b4ac:5e0e? ([2600:8802:5a00:7a08:4857:1523:b4ac:5e0e]) by smtp.gmail.com with ESMTPSA id r15sm14041202pjp.51.2020.11.14.17.27.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 14 Nov 2020 17:27:18 -0800 (PST) To: ports@FreeBSD.org, woodsb02@FreeBSD.org References: <8f21b571-a4d2-ad5d-b4b7-3e36436fa018@gmail.com> <001301d63ca6$d5ddaa00$8198fe00$@gmail.com> <74b8e972-0f06-8fa0-01ba-9a22207197a7@marples.name> From: Douglas Thrift Subject: Re: FreeBSD Port: dhcpcd-9.3.2 Message-ID: <47064bf7-148c-dfa1-5ee2-2eda430ab260@gmail.com> Date: Sat, 14 Nov 2020 17:27:17 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.4.3 MIME-Version: 1.0 In-Reply-To: <74b8e972-0f06-8fa0-01ba-9a22207197a7@marples.name> Content-Type: multipart/mixed; boundary="------------DEA2A33DEB4EC952F7D4A610" Content-Language: en-US X-Rspamd-Queue-Id: 4CYZLx1kp5z4fv9 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=dqcV4k6H; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of douglaswth@gmail.com designates 2607:f8b0:4864:20::62b as permitted sender) smtp.mailfrom=douglaswth@gmail.com X-Spamd-Result: default: False [-2.99 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; HAS_ATTACHMENT(0.00)[]; TO_DN_NONE(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; CTYPE_MIXED_BOGUS(1.00)[]; RCPT_COUNT_TWO(0.00)[2]; NEURAL_HAM_SHORT(-0.99)[-0.988]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; MID_RHS_MATCH_FROM(0.00)[]; RBL_DBL_DONT_QUERY_IPS(0.00)[2607:f8b0:4864:20::62b:from]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[multipart/mixed,text/plain]; SPAMHAUS_ZRD(0.00)[2607:f8b0:4864:20::62b:from:127.0.2.255]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::62b:from]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[ports] X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Nov 2020 01:27:22 -0000 This is a multi-part message in MIME format. --------------DEA2A33DEB4EC952F7D4A610 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit On 6/7/2020 2:39 AM, Roy Marples wrote: > On 07/06/2020 09:37, driesm.michiels@gmail.com wrote: >>> stop the previous dhcpcd manually and then I discovered that the >>> `pidfile` >>> was still incorrect: >>> >>>          pidfile="/var/run/dhcpcd/dhcpcd-$ifn.pid" >>> >>> should actually be: >>> >>>          pidfile="/var/run/dhcpcd/$ifn.pid" > > pidfile=$(dhcpcd -P $args) > > dhcpcd -4 em0 > dhcpcd -6 em0 > > Give different pidfiles. > >> It has already been committed to master and should be fixed in the new >> dhcpcd-9.1.1 release. > > This patch is also relevant for FreeBSD: > https://roy.marples.name/cgit/dhcpcd.git/commit/?id=24019cdbe66a152a1e9936ad5c7ae1657713ef2c > > > Roy It seems like dhcpcd-9.3.2 is working fine for me now in FreeBSD 12.2. I have attached a patch for the rc.d script for when it is run against an interface which matches Roy's suggestion. -- Douglas William Thrift --------------DEA2A33DEB4EC952F7D4A610 Content-Type: text/plain; charset=UTF-8; name="dhcpcd-9.3.2.diff" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="dhcpcd-9.3.2.diff" Index: files/dhcpcd.in =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- files/dhcpcd.in (revision 555156) +++ files/dhcpcd.in (working copy) @@ -16,7 +16,7 @@ if [ -z "$flags" -a -n "$specific" ]; then rc_flags=3D"$specific" fi - pidfile=3D"/var/run/dhcpcd/dhcpcd-$ifn.pid" + pidfile=3D"$($command -P $rc_flags $ifn)" else pidfile=3D"$($command -P $rc_flags)" : ${dhcpcd_enable:=3DNO} --------------DEA2A33DEB4EC952F7D4A610--