From owner-freebsd-ppc@freebsd.org Sun Jun 28 00:03:00 2020 Return-Path: Delivered-To: freebsd-ppc@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9F62835FCEC for ; Sun, 28 Jun 2020 00:03:00 +0000 (UTC) (envelope-from bdragon@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49vW6D3m16z4cvW; Sun, 28 Jun 2020 00:03:00 +0000 (UTC) (envelope-from bdragon@FreeBSD.org) Received: from auth1-smtp.messagingengine.com (auth1-smtp.messagingengine.com [66.111.4.227]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: bdragon/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 5CBE0260F2; Sun, 28 Jun 2020 00:03:00 +0000 (UTC) (envelope-from bdragon@FreeBSD.org) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailauth.nyi.internal (Postfix) with ESMTP id 04A4E27C0054; Sat, 27 Jun 2020 20:03:00 -0400 (EDT) Received: from imap1 ([10.202.2.51]) by compute4.internal (MEProxy); Sat, 27 Jun 2020 20:03:00 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudelgedgfedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdluddtmdenucfjughrpefofgggkfgjfhffhffvufgtsehttdertder reejnecuhfhrohhmpedfuehrrghnughonhcuuegvrhhgrhgvnhdfuceosggurhgrghhonh eshfhrvggvuefuffdrohhrgheqnecuggftrfgrthhtvghrnhepjefhfedtuddtleegkeeg tdegjeekffdvjedttdehgffgveeugffgfeelvdeghffgnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomhepsggurhgrghhonhdomhgvshhmthhprghu thhhphgvrhhsohhnrghlihhthidquddtgedvfeehkeeigedqudekuddtkeehuddqsggurh grghhonheppefhrhgvvgeuufffrdhorhhgsehimhgrphdrtggt X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id B39B7C200A6; Sat, 27 Jun 2020 20:02:59 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.3.0-dev0-543-gda70334-fm-20200618.004-gda703345 Mime-Version: 1.0 Message-Id: In-Reply-To: <45988F4F-56D0-4FDD-90C9-97570B2F0FCF@yahoo.com> References: <18E62746-80DB-4195-977D-4FF32D0129EE@yahoo.com> <9562EEE4-62EF-4164-91C0-948CC0432984@yahoo.com> <9B68839B-AEC8-43EE-B3B6-B696A4A57DAE@yahoo.com> <359C9C7D-4106-42B5-AAB5-08EF995B8100@yahoo.com> <20200513105632.06db9e21@titan.knownspace> <20200611155545.55526f7c@ralga.knownspace> <5542B85D-1C3A-41D8-98CE-3C02E990C3EB@yahoo.com> <20200611164216.47f82775@ralga.knownspace> <20200611212532.59f677be@ralga.knownspace> <1EDCA498-0B67-4374-B7CA-1ECDA8EE32AD@yahoo.com> <3605089E-7B5D-4FBA-B0D1-14B789BDF09B@yahoo.com> <20200616213205.05f365dd@titan.knownspace> <45988F4F-56D0-4FDD-90C9-97570B2F0FCF@yahoo.com> Date: Sat, 27 Jun 2020 19:02:39 -0500 From: "Brandon Bergren" To: "Mark Millard" , "Justin Hibbits" Cc: "FreeBSD PowerPC ML" Subject: =?UTF-8?Q?Re:_svn_commit:_r360233_-_in_head:_contrib/jemalloc_._._._:_Th?= =?UTF-8?Q?is_partially_breaks_a_2-socket_32-bit_powerpc_(old_PowerMac_G?= =?UTF-8?Q?4)_based_on_head_-r360311?= Content-Type: text/plain X-BeenThere: freebsd-ppc@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Porting FreeBSD to the PowerPC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Jun 2020 00:03:00 -0000 On Sat, Jun 27, 2020, at 5:32 PM, Mark Millard wrote: > where moea64_pvo_remove_from_page involves > vm_page_aflag_clear(????,PGA_WRITEABLE | PGA_EXECUTABLE) via: > > static inline void > moea64_pvo_remove_from_page_locked(mmu_t mmu, struct pvo_entry *pvo, > vm_page_t m) > { > > . . . > /* > * Update vm about page writeability/executability if managed > */ > PV_LOCKASSERT(pvo->pvo_pte.pa & LPTE_RPGN); > if (pvo->pvo_vaddr & PVO_MANAGED) { > if (m != NULL) { > LIST_REMOVE(pvo, pvo_vlink); > if (LIST_EMPTY(vm_page_to_pvoh(m))) > vm_page_aflag_clear(m, > PGA_WRITEABLE | PGA_EXECUTABLE); > } > } > . . . > } > > But 32-bit has/uses: > > static void mmu_null_remove_pages(mmu_t mmu, pmap_t pmap) > { > return; > } > > > so it does not involve: > > vm_page_aflag_clear(????,PGA_WRITEABLE | PGA_EXECUTABLE) > > but apparently should involve such in order to pass: > > KASSERT((m->a.flags & (PGA_EXECUTABLE | PGA_WRITEABLE)) == 0, > ("vm_page_free_prep: mapping flags set in page %p", m)); > looking at the history of the 64 bit code: r233017 -- "Implement pmap_remove_pages(). This will be added later to the 32-bit MMU module." Oops! -- Brandon Bergren bdragon@FreeBSD.org