From owner-freebsd-python@freebsd.org Sun Nov 29 09:15:46 2020 Return-Path: Delivered-To: freebsd-python@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8337147BC66 for ; Sun, 29 Nov 2020 09:15:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4CkN4y34Mtz3tn5 for ; Sun, 29 Nov 2020 09:15:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 6954B47B872; Sun, 29 Nov 2020 09:15:46 +0000 (UTC) Delivered-To: python@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 68FF547B871 for ; Sun, 29 Nov 2020 09:15:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CkN4y2PGwz3tsp for ; Sun, 29 Nov 2020 09:15:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 407A46F0A for ; Sun, 29 Nov 2020 09:15:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 0AT9FjJS000755 for ; Sun, 29 Nov 2020 09:15:45 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 0AT9FjnR000754 for python@FreeBSD.org; Sun, 29 Nov 2020 09:15:45 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: python@FreeBSD.org Subject: [Bug 251412] [patch] math/py-pandas Update to 1.1.4 (Python 3.9 compatible) Date: Sun, 29 Nov 2020 09:15:46 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: rhurlin@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: python@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-python@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: FreeBSD-specific Python issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Nov 2020 09:15:46 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D251412 Rainer Hurling changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rhurlin@FreeBSD.org --- Comment #3 from Rainer Hurling --- Hi,=20 Many thanks for the patch. There two issues with your patch (test with 'portlint -AC'): - Don't remove PORTEPOCH, once it exists [1] - Your files/patch-setup.py is not generated by 'make makepatch'. For a pro= per patch format it is recommended to use 'make makepatch' [2] [1] Section 5.2.3.2 from Porters Handbook https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html [2] Section 4.4 from Porters Handbook Another thought: The hint in pkg-message about two additional ports is only visible when the port is installed.=20 Wouldn't it be useful from the user's point of view to include these two po= rts math/py-statsmodels and devel/py-xarray as RUN_DEPENDS in the Makefile? I w= ould expect a much better user experience. --=20 You are receiving this mail because: You are the assignee for the bug.=