From owner-freebsd-stable@freebsd.org Sun Apr 19 13:46:30 2020 Return-Path: Delivered-To: freebsd-stable@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 280052C66AC for ; Sun, 19 Apr 2020 13:46:30 +0000 (UTC) (envelope-from sthaug@nethelp.no) Received: from bizet.nethelp.no (bizet.nethelp.no [195.1.209.33]) by mx1.freebsd.org (Postfix) with ESMTP id 494rhj2fZlz4JFf for ; Sun, 19 Apr 2020 13:46:29 +0000 (UTC) (envelope-from sthaug@nethelp.no) Received: from localhost (bizet.nethelp.no [IPv6:2001:8c0:9e04:500::1]) by bizet.nethelp.no (Postfix) with ESMTP id 4B36DE6079 for ; Sun, 19 Apr 2020 15:46:27 +0200 (CEST) Date: Sun, 19 Apr 2020 15:46:27 +0200 (CEST) Message-Id: <20200419.154627.114207144.sthaug@nethelp.no> To: freebsd-stable@freebsd.org Subject: BIND 9.16.1/9.16.2 memory leak? From: sthaug@nethelp.no X-Mailer: Mew version 6.7 on Emacs 26 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 494rhj2fZlz4JFf X-Spamd-Bar: ++ Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of sthaug@nethelp.no designates 195.1.209.33 as permitted sender) smtp.mailfrom=sthaug@nethelp.no X-Spamd-Result: default: False [2.99 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.17)[-0.169,0]; IP_SCORE(0.24)[asn: 2116(1.22), country: NO(-0.02)]; RWL_MAILSPIKE_GOOD(0.00)[33.209.1.195.rep.mailspike.net : 127.0.0.18]; R_SPF_ALLOW(-0.20)[+mx]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-stable@freebsd.org]; TO_DN_NONE(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; DMARC_NA(0.00)[nethelp.no]; MV_CASE(0.50)[]; RCVD_IN_DNSWL_MED(-0.20)[33.209.1.195.list.dnswl.org : 127.0.6.2]; NEURAL_SPAM_LONG(0.82)[0.821,0]; FROM_NO_DN(0.00)[]; MID_CONTAINS_FROM(1.00)[]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; SUBJECT_ENDS_QUESTION(1.00)[]; ASN(0.00)[asn:2116, ipnet:195.1.0.0/16, country:NO]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Apr 2020 13:46:30 -0000 >From https://lists.isc.org/pipermail/bind-users/2020-April/102998.html > We have what appears to be a significant memory leak in BIND-9.16.1. > > Environment: > FreeBSD 12.1-STABLE. > BIND-9.16.1 installed from packages. > Also uses libuv-1.35.0 installed from packages. > Authoritative only. > Around 800 zones of varying sizes. DNSSEC in use. > > Running a ps command for the named process every minute and logging > the result, I see the named virtual memory size (VSZ) increasing at > around 1.2 Mbyte/minute, and the resident size (RSS) increasing at > around 0.85 Mbyte/minute. No problems due to this so far, but pretty > obviously it's not viable in the long run. > > I tried reading the CHANGES from 9.16.2, and didn't see anything which > suggested a fix for a memory leak problem. I now have a pcap file of queries that I can replay with the "drool" application, and I'm consistently seeing similar memory leak problems (i.e. the problems are reproducible). The memory leak rate seems to be very approximately linear with the query rate - so replaying at 10 times the original speed means we also leak around 10 times as much per minute. Upgrading to 9.16.2 (and also libuv 1.36.0) makes no difference - the same memory leak is observed. Any suggestions? Steinar Haug, Nethelp consulting, sthaug@nethelp.no From owner-freebsd-stable@freebsd.org Sun Apr 19 17:33:57 2020 Return-Path: Delivered-To: freebsd-stable@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7861727C456 for ; Sun, 19 Apr 2020 17:33:57 +0000 (UTC) (envelope-from slw@zxy.spb.ru) Received: from zxy.spb.ru (zxy.spb.ru [195.70.199.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 494xl80DWtz4fLv for ; Sun, 19 Apr 2020 17:33:55 +0000 (UTC) (envelope-from slw@zxy.spb.ru) Received: from slw by zxy.spb.ru with local (Exim 4.86 (FreeBSD)) (envelope-from ) id 1jQDpD-0004sj-8l for freebsd-stable@freebsd.org; Sun, 19 Apr 2020 20:33:47 +0300 Date: Sun, 19 Apr 2020 20:33:47 +0300 From: Slawa Olhovchenkov To: freebsd-stable@freebsd.org Subject: ncurses in 12-stable break emacs tramp mode Message-ID: <20200419173347.GP8028@zxy.spb.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: slw@zxy.spb.ru X-SA-Exim-Scanned: No (on zxy.spb.ru); SAEximRunCond expanded to false X-Rspamd-Queue-Id: 494xl80DWtz4fLv X-Spamd-Bar: ++ Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of slw@zxy.spb.ru has no SPF policy when checking 195.70.199.98) smtp.mailfrom=slw@zxy.spb.ru X-Spamd-Result: default: False [2.11 / 15.00]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; DMARC_NA(0.00)[zxy.spb.ru]; AUTH_NA(1.00)[]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_SPAM_MEDIUM(0.37)[0.372,0]; RCVD_TLS_LAST(0.00)[]; NEURAL_SPAM_LONG(0.76)[0.760,0]; R_SPF_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:5495, ipnet:195.70.192.0/19, country:RU]; MID_RHS_MATCH_FROM(0.00)[]; IP_SCORE(0.08)[asn: 5495(0.37), country: RU(0.01)]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Apr 2020 17:33:57 -0000 Before ncurses update emcas tramp mode got next echo string _echo^H ^H^H ^H^H ^H^H ^H^H ^Hstty after ncurses update echo string is different: _echo^M#$ _ech ^H^M#$ _ec ^H^M#$ _e ^H^M#$ _ ^H^M#$ ^Hstty icanon erase ^H cols 32767_echo i.e. ncurses on `dumb` terminal still do refresh all line, from begin of string, include prompt. This is complety break emacs tramp mode to FreeBSD host. Is this posible to fix this? From owner-freebsd-stable@freebsd.org Mon Apr 20 10:57:39 2020 Return-Path: Delivered-To: freebsd-stable@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 78CF42BECF9; Mon, 20 Apr 2020 10:57:39 +0000 (UTC) (envelope-from lwhsu@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 495NvR2jy5z47gV; Mon, 20 Apr 2020 10:57:39 +0000 (UTC) (envelope-from lwhsu@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1129) id 3CBD31163F; Mon, 20 Apr 2020 10:57:39 +0000 (UTC) Date: Mon, 20 Apr 2020 10:57:39 +0000 From: Li-Wen Hsu To: freebsd-testing@freebsd.org Cc: freebsd-current@freebsd.org, freebsd-stable@freebsd.org Subject: FreeBSD CI Weekly Report 2020-04-19 Message-ID: <20200420105739.GA51787@freefall.freebsd.org> Reply-To: freebsd-testing@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Apr 2020 10:57:39 -0000 (Please send the followup to freebsd-testing@ and note Reply-To is set.) FreeBSD CI Weekly Report 2020-04-19 =================================== Here is a summary of the FreeBSD Continuous Integration results for the period from 2020-04-13 to 2020-04-19. During this period, we have: * 2136 builds (89.3% (-4.7) passed, 10.7% (+4.7) failed) of buildworld and buildkernel (GENERIC and LINT) were executed on aarch64, amd64, armv6, armv7, i386, mips, mips64, powerpc, powerpc64, powerpcspe, riscv64, sparc64 architectures for head, stable/12, stable/11 branches. * 333 test runs (42.0% (+17.0) passed, 55.9% (+26.0) unstable, 2.1% (-43.0) exception) were executed on amd64, i386, riscv64 architectures for head, stable/12, stable/11 branches. * 20 doc and www builds (95.0% (+11.7) passed, 5.0% (-11.7) failed) Test case status (on 2020-04-19 23:59): | Branch/Architecture | Total | Pass | Fail | Skipped | | ------------------- | ---------- | ---------- | ------- | -------- | | head/amd64 | 7756 (+12) | 7657 (+19) | 5 (-9) | 94 (+2) | | head/i386 | 7754 (+12) | 7646 (+18) | 8 (-8) | 100 (+2) | | 12-STABLE/amd64 | 7518 (+10) | 7462 (+13) | 0 (-1) | 56 (-2) | | 12-STABLE/i386 | 7516 (+10) | 7452 (+27) | 0 (-2) | 64 (-15) | | 11-STABLE/amd64 | 6882 (0) | 6830 (+1) | 0 (-1) | 52 (0) | | 11-STABLE/i386 | 6880 (0) | 6826 (+77) | 0 (-80) | 54 (+3) | (The statistics from experimental jobs are omitted) If any of the issues found by CI are in your area of interest or expertise please investigate the PRs listed below. The latest web version of this report is available at https://hackmd.io/@FreeBSD-CI/report-20200419 and archive is available at https://hackmd.io/@FreeBSD-CI/ , any help is welcome. ## Failing jobs * https://ci.freebsd.org/job/FreeBSD-head-amd64-gcc6_build/ ``` /usr/local/bin/x86_64-unknown-freebsd12.1-ld: /tmp/obj/workspace/src/amd64.amd64/lib/clang/liblldb/liblldb.a(IOHandlerCursesGUI.o): in function `curses::Window::Box(unsigned int, unsigned int)': /workspace/src/contrib/llvm-project/lldb/source/Core/IOHandlerCursesGUI.cpp:361: undefined reference to `box' /usr/local/bin/x86_64-unknown-freebsd12.1-ld: /workspace/src/contrib/llvm-project/lldb/source/Core/IOHandlerCursesGUI.cpp:361: undefined reference to `box' collect2: error: ld returned 1 exit status ``` ## Failing tests * https://ci.freebsd.org/job/FreeBSD-head-amd64-test/ * local.kyua.integration.cmd_about_test.topic__authors__installed * sys.netipsec.tunnel.empty.v4 * sys.netipsec.tunnel.empty.v6 * sys.opencrypto.blake2_test.blake2b_vectors_x86 * sys.opencrypto.blake2_test.blake2s_vectors_x86 * https://ci.freebsd.org/job/FreeBSD-head-i386-test/ All amd64 failures and: * sys.kqueue.libkqueue.kqueue_test.main * sys.netinet.divert.ipdivert_ip_input_local_success * sys.netinet.divert.ipdivert_ip_output_remote_success ## Regressions * 3 tests start failing after llvm10 import * lib.libproc.proc_test.symbol_lookup * lib.msun.ctrig_test.test_inf_inputs https://bugs.freebsd.org/244732 * (DTrace) common.pid.t_dtrace_contrib.err_D_PROC_OFF_toobig_d https://bugs.freebsd.org/244823 * fusefs tests fail when mac_bsdextended.ko is loaded https://bugs.freebsd.org/244229 * `dtrace -c` causes program dumps core after somewhere between (r357694, r357701] https://bugs.freebsd.org/244053 * Lock-order reversals triggered by tests under sys.net.if_lagg_test.* on i386 https://bugs.freebsd.org/244163 Discovered by newly endabled sys.net.* tests. ([r357857](https://svnweb.freebsd.org/changeset/base/357857)) * sys.net.if_lagg_test.lacp_linkstate_destroy_stress panics i386 kernel https://bugs.freebsd.org/244168 Discovered by newly endabled sys.net.* tests. ([r357857](https://svnweb.freebsd.org/changeset/base/357857)) * (test case) sys.geom.class.multipath.misc.fail_on_error (on 12-STABLE) https://bugs.freebsd.org/244158 ## Failing and Flaky tests (from experimental jobs) * https://ci.freebsd.org/job/FreeBSD-head-amd64-dtrace_test/ * cddl.usr.sbin.dtrace.common.misc.t_dtrace_contrib.tst_dynopt_d * https://bugs.freebsd.org/237641 * cddl.usr.sbin.dtrace.common.pid.t_dtrace_contrib.err_D_PROC_OFF_toobig_d * https://bugs.freebsd.org/244823 * https://ci.freebsd.org/job/FreeBSD-head-amd64-test_zfs/ * There are ~13 failing and ~109 skipped cases, including flakey ones, see https://ci.freebsd.org/job/FreeBSD-head-amd64-test_zfs/lastCompletedBuild/testReport/ for more details * Work for cleaning these failing cass are in progress * https://ci.freebsd.org/job/FreeBSD-head-amd64-test_ltp/ * Total 3670 tests (0), 2285 success (-5), 579 failures (+5), 806 skipped (0) ## Disabled Tests * sys.fs.tmpfs.mount_test.large https://bugs.freebsd.org/212862 * sys.fs.tmpfs.link_test.kqueue https://bugs.freebsd.org/213662 * sys.kqueue.libkqueue.kqueue_test.main https://bugs.freebsd.org/233586 * sys.kern.ptrace_test.ptrace__PT_KILL_competing_stop https://bugs.freebsd.org/220841 * lib.libc.regex.exhaust_test.regcomp_too_big (i386 only) https://bugs.freebsd.org/237450 * sys.netinet.socket_afinet.socket_afinet_bind_zero https://bugs.freebsd.org/238781 * sys.netpfil.pf.names.names * sys.netpfil.pf.synproxy.synproxy https://bugs.freebsd.org/238870 * sys.kern.ptrace_test.ptrace__follow_fork_child_detached_unrelated_debugger https://bugs.freebsd.org/239292 * sys.kern.ptrace_test.ptrace__follow_fork_both_attached_unrelated_debugger https://bugs.freebsd.org/239397 * sys.kern.ptrace_test.ptrace__parent_sees_exit_after_child_debugger https://bugs.freebsd.org/239399 * sys.kern.ptrace_test.ptrace__follow_fork_parent_detached_unrelated_debugger https://bugs.freebsd.org/239425 * lib.libc.gen.getmntinfo_test.getmntinfo_test https://bugs.freebsd.org/240049 * sys.sys.qmath_test.qdivq_s64q https://bugs.freebsd.org/240219 * sys.kern.ptrace_test.ptrace__getppid https://bugs.freebsd.org/240510 * lib.libc.sys.stat_test.stat_socket https://bugs.freebsd.org/240621 * lib.libarchive.functional_test.test_write_filter_zstd https://bugs.freebsd.org/240683 * lib.libcasper.services.cap_dns.dns_test.main https://bugs.freebsd.org/241435 * local.kyua.* (31 cases) & local.lutok.* (3 cases) on 11-i386 https://ci.freebsd.org/job/FreeBSD-stable-11-i386-test/2278/testReport/ * sys.geom.class.multipath.failloop.failloop https://bugs.freebsd.org/242689 * sys.kern.ptrace_test.ptrace__procdesc_reparent_wait_child https://bugs.freebsd.org/243605 * skip sys.geom.class.multipath.failloop.failloop https://bugs.freebsd.org/244053 * sys.kern.ptrace_test.ptrace__parent_wait_after_attach https://bugs.freebsd.org/244055 * sys.kern.ptrace_test.ptrace__parent_exits_before_child https://bugs.freebsd.org/244056 * sys.geom.class.multipath.misc.fail_on_error (12-STABLE) https://bugs.freebsd.org/244158 * sys.net.if_lagg_test.witness (i386) https://bugs.freebsd.org/244163 * PipePdfork.WildcardWait in sys.capsicum.capsicum-test.main https://bugs.freebsd.org/244165 * sys.net.if_lagg_test.lacp_linkstate_destroy_stress (i386) https://bugs.freebsd.org/244168 * sys.netinet6.frag6.frag6_07.frag6_07 https://bugs.freebsd.org/244170 * sys.netinet.fibs_test.udp_dontroute6 https://bugs.freebsd.org/244172 * sys.netpfil.pf.nat.exhaust https://bugs.freebsd.org/244703 * sys.geom.class.gate.ggate_test.ggated https://bugs.freebsd.org/244737 ## Issues ### Cause build fails * https://bugs.freebsd.org/233735 Possible build race: genoffset.o /usr/src/sys/sys/types.h: error: machine/endian.h: No such file or directory * https://bugs.freebsd.org/233769 Possible build race: ld: error: unable to find library -lgcc_s ### Cause kernel panics * https://bugs.freebsd.org/238870 sys.netpfil.pf.names.names and sys.netpfil.pf.synproxy.synproxy cause panic Patch exists: * https://reviews.freebsd.org/D20868 * https://reviews.freebsd.org/D20869 ### Open * https://bugs.freebsd.org/237403 Tests in sys/opencrypto should be converted to Python3 * https://bugs.freebsd.org/237641 Flakey test case: common.misc.t_dtrace_contrib.tst_dynopt_d * https://bugs.freebsd.org/237656 "Freed UMA keg (rtentry) was not empty (18 items). Lost 1 pages of memory." seen when running sys/netipsec tests * https://bugs.freebsd.org/238781 sys.netinet.socket_afinet.socket_afinet_bind_zero does not work when mac_portacl(4) loaded * https://bugs.freebsd.org/239292 Flakey test case: sys.kern.ptrace_test.ptrace__follow_fork_child_detached_unrelated_debugger * https://bugs.freebsd.org/239397 Flakey test case: sys.kern.ptrace_test.ptrace__follow_fork_both_attached_unrelated_debugger * https://bugs.freebsd.org/239399 Flakey test case: sys.kern.ptrace_test.ptrace__parent_sees_exit_after_child_debugger * https://bugs.freebsd.org/239425 Flakey test case: sys.kern.ptrace_test.ptrace__follow_fork_parent_detached_unrelated_debugger * https://bugs.freebsd.org/241662 Flakey test case: lib.libarchive.functional_test.test_fuzz_iso9660 ### Others * [Tickets related to testing@](https://preview.tinyurl.com/y9maauwg) From owner-freebsd-stable@freebsd.org Mon Apr 20 13:35:05 2020 Return-Path: Delivered-To: freebsd-stable@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5EE2D2C3018 for ; Mon, 20 Apr 2020 13:35:05 +0000 (UTC) (envelope-from mike@sentex.net) Received: from pyroxene2a.sentex.ca (pyroxene19.sentex.ca [IPv6:2607:f3e0:0:3::19]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "pyroxene.sentex.ca", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 495SP41Zvyz4MNj for ; Mon, 20 Apr 2020 13:35:04 +0000 (UTC) (envelope-from mike@sentex.net) Received: from [IPv6:2607:f3e0:0:4::29] ([IPv6:2607:f3e0:0:4:0:0:0:29]) by pyroxene2a.sentex.ca (8.15.2/8.15.2) with ESMTPS id 03KDZ3Ea055551 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NO); Mon, 20 Apr 2020 09:35:03 -0400 (EDT) (envelope-from mike@sentex.net) Subject: Re: BIND 9.16.1/9.16.2 memory leak? To: sthaug@nethelp.no, freebsd-stable@freebsd.org References: <20200419.154627.114207144.sthaug@nethelp.no> From: mike tancsa Autocrypt: addr=mike@sentex.net; keydata= mQENBFywzOMBCACoNFpwi5MeyEREiCeHtbm6pZJI/HnO+wXdCAWtZkS49weOoVyUj5BEXRZP xflV2ib2hflX4nXqhenaNiia4iaZ9ft3I1ebd7GEbGnsWCvAnob5MvDZyStDAuRxPJK1ya/s +6rOvr+eQiXYNVvfBhrCfrtR/esSkitBGxhUkBjOti8QwzD71JVF5YaOjBAs7jZUKyLGj0kW yDg4jUndudWU7G2yc9GwpHJ9aRSUN8e/mWdIogK0v+QBHfv/dsI6zVB7YuxCC9Fx8WPwfhDH VZC4kdYCQWKXrm7yb4TiVdBh5kgvlO9q3js1yYdfR1x8mjK2bH2RSv4bV3zkNmsDCIxjABEB AAG0HW1pa2UgdGFuY3NhIDxtaWtlQHNlbnRleC5uZXQ+iQFUBBMBCAA+FiEEmuvCXT0aY6hs 4SbWeVOEFl5WrMgFAlywzOYCGwMFCQHhM4AFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQ eVOEFl5WrMhnPAf7Bf+ola0V9t4i8rwCMGvzkssGaxY/5zNSZO9BgSgfN0WzgmBEOy/3R4km Yn5KH94NltJYAAE5hqkFmAwK6psOqAR9cxHrRfU+gV2KO8pCDc6K/htkQcd/mclJYpCHp6Eq EVJOiAxcNaYuHZkeMdXDuvvI5Rk82VHk84BGgxIqIrhLlkguoPbXOOa+8c/Mpb1sRAGZEOuX EzKNC49+GS9gKW6ISbanyPsGEcFyP7GKMzcHBPf3cPrewZQZ6gBoNscasL6IJeAQDqzQAxbU GjO0qBSMRgnLXK7+DJlxrYdHGXqNbV6AYsmHJ6c2WWWiuRviFBqXinlgJ2FnYebZPAfWiQ== Message-ID: Date: Mon, 20 Apr 2020 09:35:03 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200419.154627.114207144.sthaug@nethelp.no> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US X-Rspamd-Queue-Id: 495SP41Zvyz4MNj X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of mike@sentex.net designates 2607:f3e0:0:3::19 as permitted sender) smtp.mailfrom=mike@sentex.net X-Spamd-Result: default: False [-1.71 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ptr]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; HFILTER_HELO_IP_A(1.00)[pyroxene2a.sentex.ca]; DMARC_NA(0.00)[sentex.net]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; HFILTER_HELO_NORES_A_OR_MX(0.30)[pyroxene2a.sentex.ca]; IP_SCORE(-1.71)[ipnet: 2607:f3e0::/32(-4.92), asn: 11647(-3.53), country: CA(-0.09)]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; SUBJECT_ENDS_QUESTION(1.00)[]; ASN(0.00)[asn:11647, ipnet:2607:f3e0::/32, country:CA]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Apr 2020 13:35:05 -0000 On 4/19/2020 9:46 AM, sthaug@nethelp.no wrote: > > > I now have a pcap file of queries that I can replay with the "drool" > application, and I'm consistently seeing similar memory leak problems > (i.e. the problems are reproducible). The memory leak rate seems to be > very approximately linear with the query rate - so replaying at 10 > times the original speed means we also leak around 10 times as much per > minute. > > Upgrading to 9.16.2 (and also libuv 1.36.0) makes no difference - the > same memory leak is observed. > > Any suggestions? I have two servers, one mostly master, one mostly slave running 9.16.2 on RELENG_11 and the mostly slave one is showing this behaviour but not the other. every 30 seconds VSZ        RSS 305256  269784 305256  269792 305256  269792 305256  269792 305256  269792 305256  269792 305256  269792 305256  269792 305256  269792 305256  269792 305256  269792 305256  269792 305256  269796 305256  269796 305256  269796 305256  269796 305256  269796 305256  269888 305256  269896 305256  269896 305256  269896 331880  294332 331880  295240 331880  296036 331880  296836 331880  296840 331880  296848 331880  296848 331880  296856 331880  296860 331880  296872 331880  296872 From owner-freebsd-stable@freebsd.org Tue Apr 21 18:02:53 2020 Return-Path: Delivered-To: freebsd-stable@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id DD24A2B2F4F for ; Tue, 21 Apr 2020 18:02:53 +0000 (UTC) (envelope-from andreas@naund.org) Received: from naund.org (172-11-194-172.lightspeed.sntcca.sbcglobal.net [172.11.194.172]) by mx1.freebsd.org (Postfix) with ESMTP id 496BHc0TVPz3Hvv for ; Tue, 21 Apr 2020 18:02:51 +0000 (UTC) (envelope-from andreas@naund.org) Received: (from andreas@localhost) by naund.org (8.11.6/8.11.6-20030329ao) id 03LI2jp23247 for freebsd-stable@freebsd.org; Tue, 21 Apr 2020 11:02:45 -0700 Date: Tue, 21 Apr 2020 11:02:45 -0700 From: Andreas Ott To: freebsd-stable@freebsd.org Subject: FreeBSD 11.3-RELEASE-p7 is approaching its End-of-Life date ? Message-ID: <20200421110245.A23064@naund.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i X-Rspamd-Queue-Id: 496BHc0TVPz3Hvv X-Spamd-Bar: + Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of andreas@naund.org designates 172.11.194.172 as permitted sender) smtp.mailfrom=andreas@naund.org X-Spamd-Result: default: False [1.24 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.70)[-0.703,0]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:172.11.194.172]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; HFILTER_HELO_IP_A(1.00)[naund.org]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_HAM_LONG(-0.48)[-0.482,0]; MIME_TRACE(0.00)[0:+]; MV_CASE(0.50)[]; DMARC_NA(0.00)[naund.org]; IP_SCORE(0.23)[asn: 7018(1.19), country: US(-0.05)]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; SUBJECT_ENDS_QUESTION(1.00)[]; ASN(0.00)[asn:7018, ipnet:172.0.0.0/12, country:US]; MID_RHS_MATCH_FROM(0.00)[] X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Apr 2020 18:02:53 -0000 [I am not sure if this is the correct mailing list but trying to access other "releng" archives is giving me only 502 at the moment] I am trying to run freebsd-upgrade this morning to get fixes for the SAs. The system gives me this message: WARNING: FreeBSD 11.3-RELEASE-p7 is approaching its End-of-Life date. It is strongly recommended that you upgrade to a newer release within the next 2 months. Neither security page nor releng page show any end of support dates within two months, combining "11.4-RELEASE + 3 months" and "11.4-RELEASE June 2020" respectively. Would it be possible to update whatever file this trigger comes from to make the warning message be in line with upcoming release schedules? Thanks, andreas - Andreas Ott K6OTT +1.408.431.8727 andreas@naund.org From owner-freebsd-stable@freebsd.org Wed Apr 22 08:21:10 2020 Return-Path: Delivered-To: freebsd-stable@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6ABB72AAA8A; Wed, 22 Apr 2020 08:21:10 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from anubis.delphij.net (anubis.delphij.net [IPv6:2001:470:1:117::25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "anubis.delphij.net", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 496YKx295Kz3PVc; Wed, 22 Apr 2020 08:21:08 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from odin.corp.delphij.net (unknown [IPv6:2601:646:8600:58ba:8449:9abe:e049:bc98]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by anubis.delphij.net (Postfix) with ESMTPSA id 4F912C309; Wed, 22 Apr 2020 01:21:02 -0700 (PDT) Reply-To: d@delphij.net To: Kristof Provost , freebsd-current@freebsd.org Cc: freebsd-stable@freebsd.org References: <5377E42E-4C01-4BCC-B934-011AC3448B54@FreeBSD.org> From: Xin Li Autocrypt: addr=delphij@delphij.net; prefer-encrypt=mutual; keydata= mQINBFuSR4oBEACvvEgwRIHs6IcSP/yaDtySF78Ji3rP29qdiQsxhMsOtvtffdbS56VApIWO UFb3/iN2gA8HwLvrmjijN0HEoLVX7na1WARmxRYzQMtApsZIUTtx7hnUYlsi2F5odZa6CDW9 a954DLRzYxiUwYDcu5Zjl9bglK1H8e/N9uC0Vuigr4teWfh86brzOyf819QzwFVYfMIK4ihw QGwMvTzbyVuCFy+LENkmcVYni70oQy6rZ5ktSuYbuOFvu7inRRfhSWPHziV7k+bW88sJ7xhv lBlegcnhkSudWX2M8tZ3MO1PJOcyys0CJlsBY5Weiog2lIPi05h/E9pZ9mc1Vud17iqDaL6w RaggOUhuPfDGCdO5ro82W4BZGeQMRnRF5Ntk+t2ShIH4nn3xRLV0E5nziCiKlgiMqOrz/ZTL QTVbHrCuiwD+fSK14y0oHbkOLYTYLlgh1JbwfY2Ty7elOYiWzyeJ7sJh2dF91NSEneWIOys3 mBpuvtU3nSzzTvAB48VV+Nbg1CpIOgNlPjj7uhIum/Z/VjUaJEyaLpTIRh0MVJVcbP7hXSqZ NA35EEZZVnWEOYdycm4CmEdeNPWkrAf2Ya77iR5VLGypwMlsUMQPh+sKVWDD38M8stFGBBNm d01Hi74Bsq5hKan654dOqMt5eYklrVj0ucMzFQtus7oE502UswARAQABtBxYaW4gTEkgPGRl bHBoaWpAZGVscGhpai5uZXQ+iQJUBBMBCgA+FiEEceNg5NEMZIki80nQQHl/fJX0g08FAluS R/YCGwMFCQmuhAAFCwkIBwMFFQoJCAsFFgIDAQACHgECF4AACgkQQHl/fJX0g0+2Og//bWpE F2V5/M5l6YW1T8oLcT9rIOH6oq9M0LMNRgFeiNNnilGIeeIgtOGBRueG4CZiZAvsRPJkrO70 1R2SrdkCIvwGUzUAxx1NfBWb+vgm4fgkW/MotGonceM5v0qfSKKXasWvDctkK28aG+IoQzmi FjXNW4+ju4zeQFYwD4ZDWqw9MqO0hVb24uW3dxtQhbfmOLgJ/PEDMQaFuANbW1c+iR0BQA3D Go/EeMY4kpN8on6Aqt/S/4JVltudfQ9OXdjQsC7netSaB9K3mHGt9aKAAB7RzlRY00DKkYS/ /eQwLzGPmK7yX13M68mMDjBs6mIR8t/E1S5OdBNhHRPNPlEbwugR4KaiCsN5yqzJoSV99fKY z2VyxjWPaG8yhHE+jmKUgIBKTfFUQEfkriQR4EASoeJ+soaMTiFDBij1Zw5n3ndLRFMB1ZCl fZLER36mAgW4m4kP83TWnDiJLxOxSOxifV8HpTFjff902H85cybg9KMwrfPDr6W19GGk5Vo1 fkza5krRMGbKWb7+74Evusi0ZxJLIOFwp5Y8eVqUMZaAD3f1ZX1M3pgXOp20QgAy+2KvMHij rLa4q+tMGRzYYD1BnFVSVdXAX5VOoTmHBcDz67DkuRwk2Byp1sgd407oEOmSwrNJlKS0TPCm xUJ2fdSQF+1/MMSRfee49vtMvz7cOrC5Ag0EW5JHigEQANiBmIFAfRNH3nzYNWC0yC+tfx3z sUwAsH1VaBM/cTib+yKtbBOSIlXWjJZWX3MHwoI/1LeGghB2mxkkX1L0pJ/vj1eXNR+sFZ32 0pYcl61Fxg/5fioG4QDTM4i3i7NR5PxDnc6UVaynSlII93DedRhZ1ROtdn4vyMgzsDiqhbL7 BthDOt5KxjqdRk4qRPSw7BovEqZLOcG5IJtf/zZUzRbM7SBljEbOAfekDGx1Br+RrYSD7/Ef Pwwzou9T8315IpBpIHyQF/dZNk3iFiB9Ed5CA71ZRYV5YoLWE9lL0j9kxOLQ5vHnX3mVq7QZ Bc7nzwZ6UhQgYmrG5+RWvuiPpGwvDRIsugJUGXucYkAQh5kuNblmkwpv6u9rNMjCNbzAylOa qdogra5EW+RUSbRz0b4iIr8nnZeAlh7BihCe7JjOwbDjoBEEEtSfVc4hD/LENqpcYVrChphf aOLB9YIXhnVDTVvMc9OklWT/81HzAaDQqOQCzEfY92199Ct9/CwRoQ2OpO8TO5+8A7b9Nb33 nmxMn09mb48ruRacMrfHxCWbgU4w9SEfbip4GcS5wGG6yTC+hw55Iwnnwus40NrJ0GEr8a4r cdsLbkvlyoNHB8ZGgyJ4aFCQ1V4qE1BnlTk7Z8BYBUkJM1odPSkVvHpCnMUjVpJ3hEOC+73Z YH1dh7lZABEBAAGJAjwEGAEKACYWIQRx42Dk0QxkiSLzSdBAeX98lfSDTwUCW5JHigIbDAUJ Ca6EAAAKCRBAeX98lfSDTz8DEACMh3poeUb+gWNF4RWFZuLteZVo0+E1JLYXQkmtrRBLXviP +Qy0pXyFAVxLM4hNIBoIDYfK9BcwrBYf7AwSKrH0GiNwFpgHCkbZd6qoZy2gB+adTnCpVCTJ KJetsH/8awkrChJWMK0ckGf3EeWMPvawG7kW7FBz70NYEZ0pOMiaEZNVtzD3wwbYWUiDFYth 83XGglOExg+1ShTW5XjQPRrdyJAO+aUW4o3lVjfyUJXMgI4rmhMiLVm06GuNrbpKIF0s+4Vd jQAjhrDQjfoXi9CkfsA/cONseuHNv1JGj3RqHiqHJq1dbrpodXp925zGDAnUGxCOBPoFopAH gVzR89GTut059GpwqsddZmU6y7rqifuam/ekJ+QRwc16vgt7pHqCrTY8WPxRZr2UpFU1wlTo COdeiFep1gq1F9jzFjJnoMaAdmC6k7bgAA+RQusOgIhJL0jIej7DoAHxmxFFCfRy+lDtpXwF gQ8HMvzHI65QWmQnMo7s6SQH/ZH5s1yR6SJq8+3lDz+dCuT42qJVqIPVvxd10LW0FNN+t7HF eLadU6ekSgD13/EYMYXlvNHkw7dAItSDxIzgRyykLz0bCU9xwNWoS4Z43+ifF9anJ+uR0ltW El1j++h6ZrD3LLuCgJIt1so0m49GzdcSpOI7LCwMlacyvafiEyjUn+tSNDsnfw== Subject: Re: CFT: if_bridge performance improvements Message-ID: <8e0e2bf1-27cd-1a99-b266-c7223255942f@delphij.net> Date: Wed, 22 Apr 2020 01:20:57 -0700 User-Agent: Thunderbird MIME-Version: 1.0 In-Reply-To: <5377E42E-4C01-4BCC-B934-011AC3448B54@FreeBSD.org> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Eow1ZhByevXoLHJPQxVHdCGIJnld0vFJV" X-Rspamd-Queue-Id: 496YKx295Kz3PVc X-Spamd-Bar: -------- X-Spamd-Result: default: False [-8.73 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[delphij.net:s=m7e2]; XM_UA_NO_VERSION(0.01)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; R_SPF_ALLOW(-0.20)[+mx]; TO_MATCH_ENVRCPT_ALL(0.00)[]; HAS_ATTACHMENT(0.00)[]; MIME_GOOD(-0.20)[multipart/signed,multipart/mixed,text/plain]; HAS_REPLYTO(0.00)[d@delphij.net]; TO_DN_SOME(0.00)[]; REPLYTO_DOM_EQ_FROM_DOM(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; DKIM_TRACE(0.00)[delphij.net:+]; DMARC_POLICY_ALLOW(-0.50)[delphij.net,reject]; SIGNED_PGP(-2.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:+,3:~]; IP_SCORE(-3.64)[ip: (-9.91), ipnet: 2001:470::/32(-4.65), asn: 6939(-3.60), country: US(-0.05)]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Apr 2020 08:21:10 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Eow1ZhByevXoLHJPQxVHdCGIJnld0vFJV Content-Type: multipart/mixed; boundary="o6v1mRSYFjcNeybUBiH78mO6sKJUeyjOa"; protected-headers="v1" From: Xin Li Reply-To: d@delphij.net To: Kristof Provost , freebsd-current@freebsd.org Cc: freebsd-stable@freebsd.org Message-ID: <8e0e2bf1-27cd-1a99-b266-c7223255942f@delphij.net> Subject: Re: CFT: if_bridge performance improvements References: <5377E42E-4C01-4BCC-B934-011AC3448B54@FreeBSD.org> In-Reply-To: <5377E42E-4C01-4BCC-B934-011AC3448B54@FreeBSD.org> --o6v1mRSYFjcNeybUBiH78mO6sKJUeyjOa Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Hi, On 4/14/20 02:51, Kristof Provost wrote: > Hi, >=20 > Thanks to support from The FreeBSD Foundation I=E2=80=99ve been able to= work on > improving the throughput of if_bridge. > It changes the (data path) locking to use the NET_EPOCH infrastructure.= > Benchmarking shows substantial improvements (x5 in test setups). >=20 > This work is ready for wider testing now. >=20 > It=E2=80=99s under review here: https://reviews.freebsd.org/D24250 >=20 > Patch for CURRENT: https://reviews.freebsd.org/D24250?download=3Dtrue > Patches for stable/12: https://people.freebsd.org/~kp/if_bridge/stable_= 12/ >=20 > I=E2=80=99m not currently aware of any panics or issues resulting from = these > patches. I have observed the following panic with latest stable/12 after applying the stable_12 patchset, it appears like a race condition related NULL pointer deference, but I haven't took a deeper look yet. The box have 7 igb(4) NICs, with several bridge and VLAN configured acting as a router. Please let me know if you need additional information; I can try -CURRENT as well, but it would take some time as the box is relatively slow (it's a ZFS based system so I can create a separate boot environment for -CURRENT if needed, but that would take some time as I might have to upgrade the packages, should there be any ABI breakages). =3D=3D=3D Unread portion of the kernel message buffer: kernel trap 12 with interrupts disabled Fatal trap 12: page fault while in kernel mode cpuid =3D 0; apic id =3D 00 fault virtual address =3D 0x20 fault code =3D supervisor read data, page not present instruction pointer =3D 0x20:0xffffffff80c286d5 stack pointer =3D 0x28:0xffffffff824cb840 frame pointer =3D 0x28:0xffffffff824cb850 code segment =3D base 0x0, limit 0xfffff, type 0x1b =3D DPL 0, pres 1, long 1, def32 0, gran 1 processor eflags =3D resume, IOPL =3D 0 current process =3D 0 (if_io_tqg_0) trap number =3D 12 panic: page fault cpuid =3D 0 time =3D 1587541913 KDB: stack backtrace: #0 0xffffffff80c117a5 at kdb_backtrace+0x65 #1 0xffffffff80bc588e at vpanic+0x17e #2 0xffffffff80bc5703 at panic+0x43 #3 0xffffffff810d2310 at trap_pfault+0 #4 0xffffffff810d235f at trap_pfault+0x4f #5 0xffffffff810d19b8 at trap+0x288 #6 0xffffffff810aae1c at calltrap+0x8 #7 0xffffffff80ba5c96 at __mtx_unlock_sleep+0xb6 #8 0xffffffff8248f4c7 at bridge_input+0x877 #9 0xffffffff80cd5c47 at ether_nh_input+0x207 #10 0xffffffff80cf1e4a at netisr_dispatch_src+0xca #11 0xffffffff80cd4f0b at ether_input+0x4b #12 0xffffffff80cdf1a3 at vlan_input+0x1f3 #13 0xffffffff80cd4ae1 at ether_demux+0x121 #14 0xffffffff80cd5d7b at ether_nh_input+0x33b #15 0xffffffff80cf1e4a at netisr_dispatch_src+0xca #16 0xffffffff80cd4f0b at ether_input+0x4b #17 0xffffffff80cee41c at iflib_rxeof+0xadc Uptime: 6m6s Dumping 848 out of 16313 MB:..2%..12%..21%..31%..42%..51%..61%..72%..82%..91% Backtrace: (kgdb) #0 doadump () at src/sys/amd64/include/pcpu_aux.h:55 #1 0xffffffff80bc54a5 in kern_reboot (howto=3D260) at /usr/src/sys/kern/kern_shutdown.c:451 #2 0xffffffff80bc58e6 in vpanic (fmt=3D, ap=3D) at /usr/src/sys/kern/kern_shutdown.c:880 #3 0xffffffff80bc5703 in panic (fmt=3D) at /usr/src/sys/kern/kern_shutdown.c:807 #4 0xffffffff810d2310 in trap_fatal (frame=3D, eva=3D) at /usr/src/sys/amd64/amd64/trap.c:925 #5 0xffffffff810d235f in trap_pfault (frame=3D0xffffffff824cb780, usermode=3D, signo=3D, ucode=3D) at src/sys/amd64/include/pcpu_aux.h:55= #6 0xffffffff810d19b8 in trap (frame=3D0xffffffff824cb780) at /usr/src/sys/amd64/amd64/trap.c:407 #7 0xffffffff810aae1c in calltrap () at /usr/src/sys/amd64/amd64/exception.S:289 #8 0xffffffff80c286d5 in turnstile_broadcast (ts=3D0x0, queue=3D0) at /usr/src/sys/kern/subr_turnstile.c:880 #9 0xffffffff80ba5c96 in __mtx_unlock_sleep (c=3D0xfffff80013351430, v=3D= 0) at /usr/src/sys/kern/kern_mutex.c:1041 #10 0xffffffff8248f4c7 in bridge_input (ifp=3D, m=3D) at src/sys/amd64/include/atomic.h:221 #11 0xffffffff80cd5c47 in ether_nh_input (m=3D) at /usr/src/sys/net/if_ethersubr.c:631 #12 0xffffffff80cf1e4a in netisr_dispatch_src (proto=3D5, source=3D, m=3D) at /usr/src/sys/net/netisr.c:1124 #13 0xffffffff80cd4f0b in ether_input (ifp=3D0xfffff800060dc000, m=3D0x0)= at /usr/src/sys/net/if_ethersubr.c:787 #14 0xffffffff80cdf1a3 in vlan_input (ifp=3D0xfffff800036d6800, m=3D0xfffff8001d65fc00) at /usr/src/sys/net/if_vlan.c:1291 #15 0xffffffff80cd4ae1 in ether_demux (ifp=3D0xfffff800036d6800, m=3D) at /usr/src/sys/net/if_ethersubr.c:832 #16 0xffffffff80cd5d7b in ether_nh_input (m=3D) at /usr/src/sys/net/if_ethersubr.c:667 #17 0xffffffff80cf1e4a in netisr_dispatch_src (proto=3D5, source=3D, m=3D) at /usr/src/sys/net/netisr.c:1124 #18 0xffffffff80cd4f0b in ether_input (ifp=3D0xfffff800036d6800, m=3D0xfffff80013939c00) at /usr/src/sys/net/if_ethersubr.c:787 #19 0xffffffff80cee41c in iflib_rxeof (rxq=3D, budget=3D) at /usr/src/sys/net/iflib.c:2873 #20 0xffffffff80ce87b3 in _task_fn_rx (context=3D0xfffff800036d6000) at /usr/src/sys/net/iflib.c:3801 #21 0xffffffff80c100b1 in gtaskqueue_run_locked (queue=3D0xfffff8000306b9= 00) at /usr/src/sys/kern/subr_gtaskqueue.c:363 #22 0xffffffff80c0fd53 in gtaskqueue_thread_loop (arg=3D) at /usr/src/sys/kern/subr_gtaskqueue.c:538 #23 0xffffffff80b86b0e in fork_exit ( callout=3D0xffffffff80c0fc80 , arg=3D0xfffffe00003f4008, frame=3D0xffffffff824cbd40) at /usr/src/sys/kern/kern_fork.c:1079 #24 0xffffffff810abe6e in fork_trampoline () at /usr/src/sys/amd64/amd64/exception.S:1079 #25 0x0000000000000000 in ?? () Current language: auto; currently minimal --o6v1mRSYFjcNeybUBiH78mO6sKJUeyjOa-- --Eow1ZhByevXoLHJPQxVHdCGIJnld0vFJV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.2.20 (Darwin) iQIzBAEBCgAdFiEEceNg5NEMZIki80nQQHl/fJX0g08FAl6f/m0ACgkQQHl/fJX0 g09bew//RISJvy1mI5phGpP0ydRB8CbMwdlhb1LL9q12bgB4vBYFXOwtJCqir+ne H2/THBx8kqKZxPb//DpvHv8Wty2Hb0dRVbPqJ2seWX4dXtNGLLvRqpt8+iBxmn2B SyudiF36ifNl9OJR6J4nhYB755xhee3Lu2raBuXx2/voWYbSKQm5tNy5PqvnxbML dhUcxlJnMdO62g8v55lE4a2e7/Fg/XNI7Mg0bLZldggVUJIhwcuhV/kX2NDncI9+ l+TU/8MNOqR4f3sg/dITEE3wMklrl7nXFW4QOJ30jrCJlxrwH8zZ2gRPxOdWji9x 9DoA+M5LbuJT7yxGt0AluITZrdsQ9mzb0GlhsPE7k+CNjCFtmotudy0jcv/dEDrb 2YkYXZhTHooBvsdj0/AqiU0eRKZ6/NI6kHDknOeDLcuTQ98P+JeYYTBgO9sLr8fP hCqOPqmqgF2C01Xr7Wc1AnMlKop99qWrxlS7sZ0zJICI88keoXPNuSOzsTIsTws9 UmaDXvADHEltlqEQXo0pGCbFl4VrXHqBLmNg7PI70RzhpN+QHbKPwCKboplhhkWD DZXCMZ6VTkas5+UGA0tY/7CcNnilHaUcjKiXW2wvVquiSqmDTRK324jpNa+Ytr8h wMg77R7bZr+W9nEtUJfs78h/XkafRc/j/8SPkAELjZ5QpCpp91U= =yySD -----END PGP SIGNATURE----- --Eow1ZhByevXoLHJPQxVHdCGIJnld0vFJV-- From owner-freebsd-stable@freebsd.org Wed Apr 22 08:45:55 2020 Return-Path: Delivered-To: freebsd-stable@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 50A692AC400; Wed, 22 Apr 2020 08:45:55 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 496YtW1C4Mz3RDy; Wed, 22 Apr 2020 08:45:55 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from venus.codepro.be (venus.codepro.be [5.9.86.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx1.codepro.be", Issuer "Let's Encrypt Authority X3" (verified OK)) (Authenticated sender: kp) by smtp.freebsd.org (Postfix) with ESMTPSA id 0B1891F565; Wed, 22 Apr 2020 08:45:55 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: by venus.codepro.be (Postfix, authenticated sender kp) id 774811B31E; Wed, 22 Apr 2020 10:45:53 +0200 (CEST) From: "Kristof Provost" To: d@delphij.net Cc: freebsd-current@freebsd.org, freebsd-stable@freebsd.org Subject: Re: CFT: if_bridge performance improvements Date: Wed, 22 Apr 2020 10:45:49 +0200 X-Mailer: MailMate (1.13.1r5671) Message-ID: In-Reply-To: <8e0e2bf1-27cd-1a99-b266-c7223255942f@delphij.net> References: <5377E42E-4C01-4BCC-B934-011AC3448B54@FreeBSD.org> <8e0e2bf1-27cd-1a99-b266-c7223255942f@delphij.net> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Apr 2020 08:45:55 -0000 On 22 Apr 2020, at 10:20, Xin Li wrote: > Hi, > > On 4/14/20 02:51, Kristof Provost wrote: >> Hi, >> >> Thanks to support from The FreeBSD Foundation I’ve been able to >> work on >> improving the throughput of if_bridge. >> It changes the (data path) locking to use the NET_EPOCH >> infrastructure. >> Benchmarking shows substantial improvements (x5 in test setups). >> >> This work is ready for wider testing now. >> >> It’s under review here: https://reviews.freebsd.org/D24250 >> >> Patch for CURRENT: https://reviews.freebsd.org/D24250?download=true >> Patches for stable/12: >> https://people.freebsd.org/~kp/if_bridge/stable_12/ >> >> I’m not currently aware of any panics or issues resulting from >> these >> patches. > > I have observed the following panic with latest stable/12 after > applying > the stable_12 patchset, it appears like a race condition related NULL > pointer deference, but I haven't took a deeper look yet. > > The box have 7 igb(4) NICs, with several bridge and VLAN configured > acting as a router. Please let me know if you need additional > information; I can try -CURRENT as well, but it would take some time > as > the box is relatively slow (it's a ZFS based system so I can create a > separate boot environment for -CURRENT if needed, but that would take > some time as I might have to upgrade the packages, should there be any > ABI breakages). > Thanks for the report. I don’t immediately see how this could happen. Are you running an L2 firewall on that bridge by any chance? An earlier version of the patch had issues with a stray unlock in that code path. Best regards, Kristof From owner-freebsd-stable@freebsd.org Wed Apr 22 16:15:38 2020 Return-Path: Delivered-To: freebsd-stable@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0632E2B8E47; Wed, 22 Apr 2020 16:15:38 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from anubis.delphij.net (anubis.delphij.net [IPv6:2001:470:1:117::25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "anubis.delphij.net", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 496lsN3Hh8z4RkT; Wed, 22 Apr 2020 16:15:36 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from odin.corp.delphij.net (unknown [IPv6:2601:646:8600:58ba:513e:be73:8631:9dff]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by anubis.delphij.net (Postfix) with ESMTPSA id 0743ECD1A; Wed, 22 Apr 2020 09:15:35 -0700 (PDT) Reply-To: d@delphij.net To: Kristof Provost , d@delphij.net Cc: freebsd-current@freebsd.org, freebsd-stable@freebsd.org References: <5377E42E-4C01-4BCC-B934-011AC3448B54@FreeBSD.org> <8e0e2bf1-27cd-1a99-b266-c7223255942f@delphij.net> From: Xin Li Autocrypt: addr=delphij@delphij.net; prefer-encrypt=mutual; keydata= mQINBFuSR4oBEACvvEgwRIHs6IcSP/yaDtySF78Ji3rP29qdiQsxhMsOtvtffdbS56VApIWO UFb3/iN2gA8HwLvrmjijN0HEoLVX7na1WARmxRYzQMtApsZIUTtx7hnUYlsi2F5odZa6CDW9 a954DLRzYxiUwYDcu5Zjl9bglK1H8e/N9uC0Vuigr4teWfh86brzOyf819QzwFVYfMIK4ihw QGwMvTzbyVuCFy+LENkmcVYni70oQy6rZ5ktSuYbuOFvu7inRRfhSWPHziV7k+bW88sJ7xhv lBlegcnhkSudWX2M8tZ3MO1PJOcyys0CJlsBY5Weiog2lIPi05h/E9pZ9mc1Vud17iqDaL6w RaggOUhuPfDGCdO5ro82W4BZGeQMRnRF5Ntk+t2ShIH4nn3xRLV0E5nziCiKlgiMqOrz/ZTL QTVbHrCuiwD+fSK14y0oHbkOLYTYLlgh1JbwfY2Ty7elOYiWzyeJ7sJh2dF91NSEneWIOys3 mBpuvtU3nSzzTvAB48VV+Nbg1CpIOgNlPjj7uhIum/Z/VjUaJEyaLpTIRh0MVJVcbP7hXSqZ NA35EEZZVnWEOYdycm4CmEdeNPWkrAf2Ya77iR5VLGypwMlsUMQPh+sKVWDD38M8stFGBBNm d01Hi74Bsq5hKan654dOqMt5eYklrVj0ucMzFQtus7oE502UswARAQABtBxYaW4gTEkgPGRl bHBoaWpAZGVscGhpai5uZXQ+iQJUBBMBCgA+FiEEceNg5NEMZIki80nQQHl/fJX0g08FAluS R/YCGwMFCQmuhAAFCwkIBwMFFQoJCAsFFgIDAQACHgECF4AACgkQQHl/fJX0g0+2Og//bWpE F2V5/M5l6YW1T8oLcT9rIOH6oq9M0LMNRgFeiNNnilGIeeIgtOGBRueG4CZiZAvsRPJkrO70 1R2SrdkCIvwGUzUAxx1NfBWb+vgm4fgkW/MotGonceM5v0qfSKKXasWvDctkK28aG+IoQzmi FjXNW4+ju4zeQFYwD4ZDWqw9MqO0hVb24uW3dxtQhbfmOLgJ/PEDMQaFuANbW1c+iR0BQA3D Go/EeMY4kpN8on6Aqt/S/4JVltudfQ9OXdjQsC7netSaB9K3mHGt9aKAAB7RzlRY00DKkYS/ /eQwLzGPmK7yX13M68mMDjBs6mIR8t/E1S5OdBNhHRPNPlEbwugR4KaiCsN5yqzJoSV99fKY z2VyxjWPaG8yhHE+jmKUgIBKTfFUQEfkriQR4EASoeJ+soaMTiFDBij1Zw5n3ndLRFMB1ZCl fZLER36mAgW4m4kP83TWnDiJLxOxSOxifV8HpTFjff902H85cybg9KMwrfPDr6W19GGk5Vo1 fkza5krRMGbKWb7+74Evusi0ZxJLIOFwp5Y8eVqUMZaAD3f1ZX1M3pgXOp20QgAy+2KvMHij rLa4q+tMGRzYYD1BnFVSVdXAX5VOoTmHBcDz67DkuRwk2Byp1sgd407oEOmSwrNJlKS0TPCm xUJ2fdSQF+1/MMSRfee49vtMvz7cOrC5Ag0EW5JHigEQANiBmIFAfRNH3nzYNWC0yC+tfx3z sUwAsH1VaBM/cTib+yKtbBOSIlXWjJZWX3MHwoI/1LeGghB2mxkkX1L0pJ/vj1eXNR+sFZ32 0pYcl61Fxg/5fioG4QDTM4i3i7NR5PxDnc6UVaynSlII93DedRhZ1ROtdn4vyMgzsDiqhbL7 BthDOt5KxjqdRk4qRPSw7BovEqZLOcG5IJtf/zZUzRbM7SBljEbOAfekDGx1Br+RrYSD7/Ef Pwwzou9T8315IpBpIHyQF/dZNk3iFiB9Ed5CA71ZRYV5YoLWE9lL0j9kxOLQ5vHnX3mVq7QZ Bc7nzwZ6UhQgYmrG5+RWvuiPpGwvDRIsugJUGXucYkAQh5kuNblmkwpv6u9rNMjCNbzAylOa qdogra5EW+RUSbRz0b4iIr8nnZeAlh7BihCe7JjOwbDjoBEEEtSfVc4hD/LENqpcYVrChphf aOLB9YIXhnVDTVvMc9OklWT/81HzAaDQqOQCzEfY92199Ct9/CwRoQ2OpO8TO5+8A7b9Nb33 nmxMn09mb48ruRacMrfHxCWbgU4w9SEfbip4GcS5wGG6yTC+hw55Iwnnwus40NrJ0GEr8a4r cdsLbkvlyoNHB8ZGgyJ4aFCQ1V4qE1BnlTk7Z8BYBUkJM1odPSkVvHpCnMUjVpJ3hEOC+73Z YH1dh7lZABEBAAGJAjwEGAEKACYWIQRx42Dk0QxkiSLzSdBAeX98lfSDTwUCW5JHigIbDAUJ Ca6EAAAKCRBAeX98lfSDTz8DEACMh3poeUb+gWNF4RWFZuLteZVo0+E1JLYXQkmtrRBLXviP +Qy0pXyFAVxLM4hNIBoIDYfK9BcwrBYf7AwSKrH0GiNwFpgHCkbZd6qoZy2gB+adTnCpVCTJ KJetsH/8awkrChJWMK0ckGf3EeWMPvawG7kW7FBz70NYEZ0pOMiaEZNVtzD3wwbYWUiDFYth 83XGglOExg+1ShTW5XjQPRrdyJAO+aUW4o3lVjfyUJXMgI4rmhMiLVm06GuNrbpKIF0s+4Vd jQAjhrDQjfoXi9CkfsA/cONseuHNv1JGj3RqHiqHJq1dbrpodXp925zGDAnUGxCOBPoFopAH gVzR89GTut059GpwqsddZmU6y7rqifuam/ekJ+QRwc16vgt7pHqCrTY8WPxRZr2UpFU1wlTo COdeiFep1gq1F9jzFjJnoMaAdmC6k7bgAA+RQusOgIhJL0jIej7DoAHxmxFFCfRy+lDtpXwF gQ8HMvzHI65QWmQnMo7s6SQH/ZH5s1yR6SJq8+3lDz+dCuT42qJVqIPVvxd10LW0FNN+t7HF eLadU6ekSgD13/EYMYXlvNHkw7dAItSDxIzgRyykLz0bCU9xwNWoS4Z43+ifF9anJ+uR0ltW El1j++h6ZrD3LLuCgJIt1so0m49GzdcSpOI7LCwMlacyvafiEyjUn+tSNDsnfw== Subject: Re: CFT: if_bridge performance improvements Message-ID: <8634ec5c-a509-d2dd-8f5c-31efcbd50340@delphij.net> Date: Wed, 22 Apr 2020 09:15:31 -0700 User-Agent: Thunderbird MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="LTzKgwOdjrRKkXH73ISC8Gb63OQfMJK5L" X-Rspamd-Queue-Id: 496lsN3Hh8z4RkT X-Spamd-Bar: -------- X-Spamd-Result: default: False [-8.73 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[delphij.net:s=m7e2]; XM_UA_NO_VERSION(0.01)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+mx]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; HAS_ATTACHMENT(0.00)[]; MIME_GOOD(-0.20)[multipart/signed,multipart/mixed,text/plain]; HAS_REPLYTO(0.00)[d@delphij.net]; TO_DN_SOME(0.00)[]; REPLYTO_DOM_EQ_FROM_DOM(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[delphij.net:+]; DMARC_POLICY_ALLOW(-0.50)[delphij.net,reject]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; SIGNED_PGP(-2.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:+,3:~]; IP_SCORE(-3.64)[ip: (-9.91), ipnet: 2001:470::/32(-4.65), asn: 6939(-3.60), country: US(-0.05)]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Apr 2020 16:15:38 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --LTzKgwOdjrRKkXH73ISC8Gb63OQfMJK5L Content-Type: multipart/mixed; boundary="XOxeXS7BD53fWLQUJLyKPnqYQNh3B0zbP"; protected-headers="v1" From: Xin Li Reply-To: d@delphij.net To: Kristof Provost , d@delphij.net Cc: freebsd-current@freebsd.org, freebsd-stable@freebsd.org Message-ID: <8634ec5c-a509-d2dd-8f5c-31efcbd50340@delphij.net> Subject: Re: CFT: if_bridge performance improvements References: <5377E42E-4C01-4BCC-B934-011AC3448B54@FreeBSD.org> <8e0e2bf1-27cd-1a99-b266-c7223255942f@delphij.net> In-Reply-To: --XOxeXS7BD53fWLQUJLyKPnqYQNh3B0zbP Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 4/22/20 01:45, Kristof Provost wrote: > On 22 Apr 2020, at 10:20, Xin Li wrote: >> Hi, >> >> On 4/14/20 02:51, Kristof Provost wrote: >>> Hi, >>> >>> Thanks to support from The FreeBSD Foundation I=E2=80=99ve been able = to work on >>> improving the throughput of if_bridge. >>> It changes the (data path) locking to use the NET_EPOCH infrastructur= e. >>> Benchmarking shows substantial improvements (x5 in test setups). >>> >>> This work is ready for wider testing now. >>> >>> It=E2=80=99s under review here: https://reviews.freebsd.org/D24250 >>> >>> Patch for CURRENT: https://reviews.freebsd.org/D24250?download=3Dtrue= >>> Patches for stable/12: >>> https://people.freebsd.org/~kp/if_bridge/stable_12/ >>> >>> I=E2=80=99m not currently aware of any panics or issues resulting fro= m these >>> patches. >> >> I have observed the following panic with latest stable/12 after applyi= ng >> the stable_12 patchset, it appears like a race condition related NULL >> pointer deference, but I haven't took a deeper look yet. >> >> The box have 7 igb(4) NICs, with several bridge and VLAN configured >> acting as a router.=C2=A0 Please let me know if you need additional >> information; I can try -CURRENT as well, but it would take some time a= s >> the box is relatively slow (it's a ZFS based system so I can create a >> separate boot environment for -CURRENT if needed, but that would take >> some time as I might have to upgrade the packages, should there be any= >> ABI breakages). >> > Thanks for the report. I don=E2=80=99t immediately see how this could h= appen. >=20 > Are you running an L2 firewall on that bridge by any chance? An earlier= > version of the patch had issues with a stray unlock in that code path. I don't think I have a L2 firewall (I assume means filtering based on MAC address like what can be done with e.g. ipfw? The bridges were created on vlan interfaces though, do they count as L2 firewall?), the system is using pf with a few NAT rules: $ sudo pfctl -s rules anchor "miniupnpd" all pass in quick inet6 proto tcp from to any flags S/SA keep state block drop in quick inet6 proto tcp from ! to flags S/SA block drop in quick proto tcp from any os "Linux" to any port =3D ssh pass out on igb6 inet proto tcp from (igb6) to any port =3D domain flags S/SA keep state queue dns pass out on igb6 inet proto udp from (igb6) to any port =3D domain keep state queue dns pass in on igb6 proto tcp from any to (igb6) port =3D http flags S/SA modulate state queue(web, ack) pass in on igb6 proto tcp from any to (igb6) port =3D https flags S/SA modulate state queue(web, ack) pass out on igb6 inet proto tcp from (igb6) to any flags S/SA modulate state queue bulk block drop in quick on igb6 proto tcp from to any port =3D ssh= label "ssh bruteforce" block drop in on igb6 from to any Cheers, --XOxeXS7BD53fWLQUJLyKPnqYQNh3B0zbP-- --LTzKgwOdjrRKkXH73ISC8Gb63OQfMJK5L Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.2.20 (Darwin) iQIzBAEBCgAdFiEEceNg5NEMZIki80nQQHl/fJX0g08FAl6gbaQACgkQQHl/fJX0 g0/gDg/8DM4yJGY6veYbj3XCp7j0LEnu3YZCmQCzeTQBHlep/4VnXXFpapcusIgy L+M5AjvKcu/83qi64HY3yf9llYTLxJBHblTY5ZlfIYpfkHpHFshJ4v7WZAPqL5OP /bfMucXsomL6tVjhwmj5ByaT7LugL/ESPhMrWM6W+kKABpWfKXbJdC+FVapuchf8 KCvs2HNrlfbgwut+p2szXpA0qnwhvWctwVjpnTF18jYwnUEgrrXKD7n47OszPTN2 n6ZKFD9KPL6WdUfhWlK9mgZVRE7b5TvjsCxnixFT472MK5ziQdJ2Xju/u0CxnQTb TGME3wvvOxU1JyjjQ5SXJRST0UFVS56VdleESrbUoYG2XIDi0AuoF8rV7UAPumS/ Ahxnzy0JxO/yU06q3cHyilmo55ldBwqMaTNg/lDHGp1sALJjMdjg1YgG12kKkCMo gO2YQKdfDOOCt0A7unk5K2FklKMnTzy5H+iBKvnUR+Ch0gkD/FRofuZH1A8qkpiC Zy7X0x+CYoRopGEV7cO5p572htuKHqcGo5yj9rgIS8N7qsiyd7PwiRKhSu/iLjLY DFVMVEJgDKlabXqrPCBXwhNVIqtV0uvCoGGMKyKb6bBNHZxVUse8M9007NvZ8r9w 5EYutBu60v/hduywL3xGmlTMFbeQQsxc5Do37go0luXAmZlFGhI= =JaNn -----END PGP SIGNATURE----- --LTzKgwOdjrRKkXH73ISC8Gb63OQfMJK5L-- From owner-freebsd-stable@freebsd.org Wed Apr 22 17:16:55 2020 Return-Path: Delivered-To: freebsd-stable@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 43F172BAFA4; Wed, 22 Apr 2020 17:16:55 +0000 (UTC) (envelope-from peter.blok@bsd4all.org) Received: from smtpq1.tb.mail.iss.as9143.net (smtpq1.tb.mail.iss.as9143.net [212.54.42.164]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 496nD56qJCz4Wnc; Wed, 22 Apr 2020 17:16:53 +0000 (UTC) (envelope-from peter.blok@bsd4all.org) Received: from [212.54.42.135] (helo=smtp11.tb.mail.iss.as9143.net) by smtpq1.tb.mail.iss.as9143.net with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jRIzS-0005QD-SG; Wed, 22 Apr 2020 19:16:50 +0200 Received: from 94-209-85-88.cable.dynamic.v4.ziggo.nl ([94.209.85.88] helo=wan0.bsd4all.org) by smtp11.tb.mail.iss.as9143.net with esmtp (Exim 4.90_1) (envelope-from ) id 1jRIzS-0002EC-Mb; Wed, 22 Apr 2020 19:16:50 +0200 Received: from newnas.bsd4all.local (localhost [127.0.0.1]) by wan0.bsd4all.org (Postfix) with ESMTP id C9627223; Wed, 22 Apr 2020 19:16:49 +0200 (CEST) X-Virus-Scanned: amavisd-new at bsd4all.org Received: from wan0.bsd4all.org ([127.0.0.1]) by newnas.bsd4all.local (newnas.bsd4all.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sOsf4-Qd-z4U; Wed, 22 Apr 2020 19:16:48 +0200 (CEST) Received: from [192.168.1.65] (unknown [192.168.1.65]) by wan0.bsd4all.org (Postfix) with ESMTPSA id 87AD94A; Wed, 22 Apr 2020 19:16:48 +0200 (CEST) From: peter.blok@bsd4all.org Message-Id: Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.14\)) Subject: Re: CFT: if_bridge performance improvements Date: Wed, 22 Apr 2020 19:16:48 +0200 In-Reply-To: <8634ec5c-a509-d2dd-8f5c-31efcbd50340@delphij.net> Cc: Kristof Provost , FreeBSD Stable To: d@delphij.net, freebsd-current@freebsd.org References: <5377E42E-4C01-4BCC-B934-011AC3448B54@FreeBSD.org> <8e0e2bf1-27cd-1a99-b266-c7223255942f@delphij.net> <8634ec5c-a509-d2dd-8f5c-31efcbd50340@delphij.net> X-Mailer: Apple Mail (2.3445.104.14) X-SourceIP: 94.209.85.88 X-Ziggo-spambar: / X-Ziggo-spamscore: 0.0 X-Ziggo-spamreport: CMAE Analysis: v=2.3 cv=du1A92o4 c=1 sm=1 tr=0 a=LYXyOGYQqFYBMgK+Y6iqTg==:17 a=cl8xLZFz6L8A:10 a=SWg00rOMAAAA:8 a=6I5d2MoRAAAA:8 a=7F27aPtjtkppQGVRRocA:9 a=QEXdDO2ut3YA:10 a=mdr11xoXeMGbgq-aR_MA:9 a=Jz0u6kiykQrJQnsa:21 a=_W_S_7VecoQA:10 a=nWvTgx2JuP7DHgfbJPXu:22 a=IjZwj45LgO3ly-622nXo:22 X-Ziggo-Spam-Status: No X-Spam-Status: No X-Spam-Flag: No X-Rspamd-Queue-Id: 496nD56qJCz4Wnc X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of peter.blok@bsd4all.org designates 212.54.42.164 as permitted sender) smtp.mailfrom=peter.blok@bsd4all.org X-Spamd-Result: default: False [-3.36 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_FIVE(0.00)[6]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+a:smtp.ziggo.nl/16]; MV_CASE(0.50)[]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[bsd4all.org]; URI_COUNT_ODD(1.00)[9]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TO_MATCH_ENVRCPT_SOME(0.00)[]; FROM_NO_DN(0.00)[]; IP_SCORE(-2.46)[ip: (-5.90), ipnet: 212.54.32.0/20(-4.04), asn: 33915(-2.41), country: NL(0.03)]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; R_DKIM_NA(0.00)[]; RCVD_IN_DNSWL_LOW(-0.10)[164.42.54.212.list.dnswl.org : 127.0.5.1]; ASN(0.00)[asn:33915, ipnet:212.54.32.0/20, country:NL]; MID_RHS_MATCH_FROM(0.00)[]; RECEIVED_SPAMHAUS_PBL(0.00)[88.85.209.94.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.11] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Apr 2020 17:16:55 -0000 Just using pf is enough to provoke this panic. I had the same back = trace. This patch from Kristof fixed it for me. diff --git a/sys/net/if_bridge.c b/sys/net/if_bridge.c index 373fa096d70..83c453090bb 100644 --- a/sys/net/if_bridge.c +++ b/sys/net/if_bridge.c @@ -2529,7 +2529,6 @@ bridge_input(struct ifnet *ifp, struct mbuf *m) OR_PFIL_HOOKED_INET6)) { = \ if (bridge_pfil(&m, NULL, ifp, = \ PFIL_IN) !=3D 0 || m =3D=3D NULL) { = \ - BRIDGE_UNLOCK(sc); = \ return (NULL); = \ } = \ eh =3D mtod(m, struct ether_header *); = \ > On 22 Apr 2020, at 18:15, Xin Li wrote: >=20 > On 4/22/20 01:45, Kristof Provost wrote: >> On 22 Apr 2020, at 10:20, Xin Li wrote: >>> Hi, >>>=20 >>> On 4/14/20 02:51, Kristof Provost wrote: >>>> Hi, >>>>=20 >>>> Thanks to support from The FreeBSD Foundation I=E2=80=99ve been = able to work on >>>> improving the throughput of if_bridge. >>>> It changes the (data path) locking to use the NET_EPOCH = infrastructure. >>>> Benchmarking shows substantial improvements (x5 in test setups). >>>>=20 >>>> This work is ready for wider testing now. >>>>=20 >>>> It=E2=80=99s under review here: https://reviews.freebsd.org/D24250 >>>>=20 >>>> Patch for CURRENT: https://reviews.freebsd.org/D24250?download=3Dtrue= >>>> Patches for stable/12: >>>> https://people.freebsd.org/~kp/if_bridge/stable_12/ >>>>=20 >>>> I=E2=80=99m not currently aware of any panics or issues resulting = from these >>>> patches. >>>=20 >>> I have observed the following panic with latest stable/12 after = applying >>> the stable_12 patchset, it appears like a race condition related = NULL >>> pointer deference, but I haven't took a deeper look yet. >>>=20 >>> The box have 7 igb(4) NICs, with several bridge and VLAN configured >>> acting as a router. Please let me know if you need additional >>> information; I can try -CURRENT as well, but it would take some time = as >>> the box is relatively slow (it's a ZFS based system so I can create = a >>> separate boot environment for -CURRENT if needed, but that would = take >>> some time as I might have to upgrade the packages, should there be = any >>> ABI breakages). >>>=20 >> Thanks for the report. I don=E2=80=99t immediately see how this could = happen. >>=20 >> Are you running an L2 firewall on that bridge by any chance? An = earlier >> version of the patch had issues with a stray unlock in that code = path. >=20 > I don't think I have a L2 firewall (I assume means filtering based on > MAC address like what can be done with e.g. ipfw? The bridges were > created on vlan interfaces though, do they count as L2 firewall?), the > system is using pf with a few NAT rules: >=20 > $ sudo pfctl -s rules > anchor "miniupnpd" all > pass in quick inet6 proto tcp from to any flags S/SA keep state > block drop in quick inet6 proto tcp from ! to flags S/SA > block drop in quick proto tcp from any os "Linux" to any port =3D ssh > pass out on igb6 inet proto tcp from (igb6) to any port =3D domain = flags > S/SA keep state queue dns > pass out on igb6 inet proto udp from (igb6) to any port =3D domain = keep > state queue dns > pass in on igb6 proto tcp from any to (igb6) port =3D http flags S/SA > modulate state queue(web, ack) > pass in on igb6 proto tcp from any to (igb6) port =3D https flags S/SA > modulate state queue(web, ack) > pass out on igb6 inet proto tcp from (igb6) to any flags S/SA modulate > state queue bulk > block drop in quick on igb6 proto tcp from to any port =3D = ssh > label "ssh bruteforce" > block drop in on igb6 from to any >=20 > Cheers, From owner-freebsd-stable@freebsd.org Wed Apr 22 20:20:03 2020 Return-Path: Delivered-To: freebsd-stable@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6CBBE2BFEB0 for ; Wed, 22 Apr 2020 20:20:03 +0000 (UTC) (envelope-from wolfgang@lyxys.ka.sub.org) Received: from saturn.lyxys.ka.sub.org (saturn.lyxys.ka.sub.org [217.29.35.151]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 496sHQ2qW4z3GfB for ; Wed, 22 Apr 2020 20:20:01 +0000 (UTC) (envelope-from wolfgang@lyxys.ka.sub.org) Received: from saturn.lyxys.ka.sub.org (localhost [127.0.0.1]) by saturn.lyxys.ka.sub.org (8.15.2/8.15.2) with ESMTPS id 03MKIXSh054781 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO) for ; Wed, 22 Apr 2020 22:18:36 +0200 (CEST) (envelope-from wolfgang@lyxys.ka.sub.org) Received: (from wolfgang@localhost) by saturn.lyxys.ka.sub.org (8.15.2/8.15.2/Submit) id 03MKIWis054780; Wed, 22 Apr 2020 22:18:32 +0200 (CEST) (envelope-from wolfgang) Message-Id: <202004222018.03MKIWis054780@saturn.lyxys.ka.sub.org> From: Wolfgang Zenker To: freebsd-stable@freebsd.org Subject: 12.1-STABLE crash after upgrade to r360192 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Mutt-Fcc: ~/sent Status: RO Date: Wed, 22 Apr 2020 22:15:11 +0200 Lines: 21 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (saturn.lyxys.ka.sub.org [127.0.0.1]); Wed, 22 Apr 2020 22:18:36 +0200 (CEST) X-Rspamd-Queue-Id: 496sHQ2qW4z3GfB X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of wolfgang@lyxys.ka.sub.org designates 217.29.35.151 as permitted sender) smtp.mailfrom=wolfgang@lyxys.ka.sub.org X-Spamd-Result: default: False [-3.74 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+mx]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[freebsd-stable@freebsd.org]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; DMARC_NA(0.00)[sub.org]; IP_SCORE(-1.44)[ip: (-5.80), ipnet: 217.29.32.0/20(-0.78), asn: 16188(-0.60), country: DE(-0.02)]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:16188, ipnet:217.29.32.0/20, country:DE]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Apr 2020 20:20:03 -0000 Hi, I went from 12.1-STABLE r359345 to r360192 on an Acer C720 Notebook. The system now crashes on loading /boot/modules/i915kms.ko I build and install graphics/drm-kmod and graphics/drm-fbsd12.0-kmod together with the kernel. If i915kms.ko is loaded via kld_list in /etc/rc.conf at boot, the screen goes blank upon loading the module and does not react any more, powercycle is required. If I load the the module manually after a successful boot, the screen goes blank and the system reboots after a while; on reboot a dump is found and written to /var/crash. Kernel config is GENERIC with added options WITNESS and WITNESS_SKIPSPIN CPU is a Celeron 2955U (Haswell class) and the graphics controller identifies as 'Haswell-ULT Integrated Graphics Controller' in pciconf. Any suggestions how to proceed from here? Any usefull information that I could extract from the crashdump? Wolfgang From owner-freebsd-stable@freebsd.org Wed Apr 22 20:48:14 2020 Return-Path: Delivered-To: freebsd-stable@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 71E692C111E for ; Wed, 22 Apr 2020 20:48:14 +0000 (UTC) (envelope-from pete@nomadlogic.org) Received: from mail.nomadlogic.org (mail.nomadlogic.org [174.136.98.114]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mail.nomadlogic.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 496svx25vHz3JXG for ; Wed, 22 Apr 2020 20:48:13 +0000 (UTC) (envelope-from pete@nomadlogic.org) Received: from [192.168.1.206] (cpe-23-243-162-239.socal.res.rr.com [23.243.162.239]) by mail.nomadlogic.org (OpenSMTPD) with ESMTPSA id ea312aa9 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Wed, 22 Apr 2020 20:48:06 +0000 (UTC) Subject: Re: 12.1-STABLE crash after upgrade to r360192 To: Wolfgang Zenker , freebsd-stable@freebsd.org References: <202004222018.03MKIWis054780@saturn.lyxys.ka.sub.org> From: Pete Wright Message-ID: <7a237525-ea6a-e138-8c4f-ff8254192e1e@nomadlogic.org> Date: Wed, 22 Apr 2020 13:48:00 -0700 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <202004222018.03MKIWis054780@saturn.lyxys.ka.sub.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Rspamd-Queue-Id: 496svx25vHz3JXG X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of pete@nomadlogic.org designates 174.136.98.114 as permitted sender) smtp.mailfrom=pete@nomadlogic.org X-Spamd-Result: default: False [-5.08 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RECEIVED_SPAMHAUS_PBL(0.00)[239.162.243.23.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.10]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+mx]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[nomadlogic.org]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; IP_SCORE(-2.78)[ip: (-9.25), ipnet: 174.136.96.0/20(-4.18), asn: 25795(-0.42), country: US(-0.05)]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:25795, ipnet:174.136.96.0/20, country:US]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Apr 2020 20:48:14 -0000 On 4/22/20 1:15 PM, Wolfgang Zenker wrote: > Hi, > > I went from 12.1-STABLE r359345 to r360192 on an Acer C720 Notebook. > The system now crashes on loading /boot/modules/i915kms.ko > I build and install graphics/drm-kmod and graphics/drm-fbsd12.0-kmod > together with the kernel. > > If i915kms.ko is loaded via kld_list in /etc/rc.conf at boot, the screen > goes blank upon loading the module and does not react any more, powercycle > is required. If I load the the module manually after a successful boot, > the screen goes blank and the system reboots after a while; on reboot > a dump is found and written to /var/crash. > > Kernel config is GENERIC with added options WITNESS and WITNESS_SKIPSPIN > CPU is a Celeron 2955U (Haswell class) and the graphics controller > identifies as 'Haswell-ULT Integrated Graphics Controller' in pciconf. > > Any suggestions how to proceed from here? Any usefull information that > I could extract from the crashdump? Did you rebuild the drm-fbsd12.0-kmod after updating your world and kernel?  I generally do this by running "make package" inside my ports/graphics/drm-fbsd12.0-kmod directory, then install this updated package. -pete -- Pete Wright pete@nomadlogic.org @nomadlogicLA From owner-freebsd-stable@freebsd.org Fri Apr 24 04:26:20 2020 Return-Path: Delivered-To: freebsd-stable@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 381832CE3E1 for ; Fri, 24 Apr 2020 04:26:20 +0000 (UTC) (envelope-from ip@unixway.org) Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 497h230LQ2z3Hqx for ; Fri, 24 Apr 2020 04:26:18 +0000 (UTC) (envelope-from ip@unixway.org) Received: by mail-lf1-x131.google.com with SMTP id x23so6583066lfq.1 for ; Thu, 23 Apr 2020 21:26:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=unixway-org.20150623.gappssmtp.com; s=20150623; h=from:content-transfer-encoding:subject:message-id:date:to :mime-version; bh=4gQ3R85/2PBRrymV9nwtxqVJLPDhkGvMv1S+3EBN/BE=; b=lMJq/nflL2QckvHVOKkA2Fo+NAPvbZ8cTl9mHPtCX7/mvzWetzD1PnI7a1KZlUOZ0v dPPTepEuqTWRwEwRArqYKc+WNXECJcNfdEVIa9LYXfUf7Ml7x62/j7R5MfbYcGsyuqCB dg3bLEKfyAYJx+pC3cGWqAqZ8QUKpP4w8lOOH/ihEHcDUhcBNS6/KwGr3g8e7FHaMQWy Vd36cj409UN1uP/salPP2qg7pDVFFTHmUY3Fz4jJBrO2V/wgwACX2ZBMmmYdvjOEkLPe lMlClUVu6Wm5NQysOB0oc0osQqTRz3ucs1oq8OwWdFemUw7yHF2iiKhD8kUufC0dXmHq ymwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:content-transfer-encoding:subject :message-id:date:to:mime-version; bh=4gQ3R85/2PBRrymV9nwtxqVJLPDhkGvMv1S+3EBN/BE=; b=RuQGtxySAp1fHaUsAx34mVyQ09FgC7zGqxz1wnsaFrUUCbwNoO+Bb6xSp4LJg8NI0t HXRngR9x1L4U+ybRdV8gn++P6UIXb/n5uZ0zE15+C130A1v3eD+IzVkydPXHku/GdEYp ZUVcJok27icEI4JMz8J3EcSnT8sFaairPkiNdrVHM5tpDHtnb2bBLWejVpliayjl1ZYl JNa/diL2z84qYCQK4pUbe5cMKf+/bkpqVAx1I/r+oocMACxwK7US1o4EDPMO8xUoSwXZ TN6fvWCcI7S9mkSM0xkRk8u4n+bPF3TjVvNX4JRPlE0ObQmvbkGcV6ydOql/QhEkh6c9 OrBw== X-Gm-Message-State: AGi0PubH9sqva8Ox6WDqFpK80GzYlkBNI5jEUoxTE3NcXTl9zwA3R7Yp SIstjI7WaHvO9HObRNQI00pQ10TAM6E= X-Google-Smtp-Source: APiQypLst2pKHo1kiaIOCnXDwcXmqRvT20AT/2cYJ55cYe9RYMTsBAiqtmLj1PQBm40XQLTdFTMrZQ== X-Received: by 2002:a05:6512:1082:: with SMTP id j2mr4827510lfg.53.1587702376715; Thu, 23 Apr 2020 21:26:16 -0700 (PDT) Received: from [192.168.0.100] (5cfcb436.dynamic.mv.ru. [92.252.180.54]) by smtp.gmail.com with ESMTPSA id l12sm3573393lfp.35.2020.04.23.21.26.15 for (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 23 Apr 2020 21:26:16 -0700 (PDT) From: Igor Pokrovsky Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Loader hangs on the latest -STABLE Message-Id: Date: Fri, 24 Apr 2020 08:26:13 +0400 To: freebsd-stable@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\)) X-Mailer: Apple Mail (2.2104) X-Rspamd-Queue-Id: 497h230LQ2z3Hqx X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=unixway-org.20150623.gappssmtp.com header.s=20150623 header.b=lMJq/nfl; dmarc=none; spf=none (mx1.freebsd.org: domain of ip@unixway.org has no SPF policy when checking 2a00:1450:4864:20::131) smtp.mailfrom=ip@unixway.org X-Spamd-Result: default: False [-4.11 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[unixway-org.20150623.gappssmtp.com:s=20150623]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MV_CASE(0.50)[]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-stable@freebsd.org]; TO_DN_NONE(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCVD_COUNT_THREE(0.00)[3]; DMARC_NA(0.00)[unixway.org]; DKIM_TRACE(0.00)[unixway-org.20150623.gappssmtp.com:+]; RCVD_IN_DNSWL_NONE(0.00)[1.3.1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.5.4.1.0.0.a.2.list.dnswl.org : 127.0.5.0]; R_SPF_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; IP_SCORE(-2.31)[ip: (-8.75), ipnet: 2a00:1450::/32(-2.33), asn: 15169(-0.43), country: US(-0.05)]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; RECEIVED_SPAMHAUS_PBL(0.00)[54.180.252.92.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.11] X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Apr 2020 04:26:20 -0000 Hello all, I haven=E2=80=99t been using FreeBSD since 8-STABLE times. Recently I = tried to install latest 12-STABLE on my old computer. But even during initial boot up loader hangs. Eventually I was able to = proceed with installation after replacing loader in=20 the installation disk with one found in my old system 8-STABLE. The same = happened when I tried zfs on root partition. I used MBR partition on PATA hard drive. Motherboard was ASUS A8V = (Athlon64). ip From owner-freebsd-stable@freebsd.org Fri Apr 24 05:23:00 2020 Return-Path: Delivered-To: freebsd-stable@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 722932CFA4A for ; Fri, 24 Apr 2020 05:23:00 +0000 (UTC) (envelope-from bsd-lists@BSDforge.com) Received: from udns.ultimatedns.net (static-24-113-41-81.wavecable.com [24.113.41.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "ultimatedns.net", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 497jHR5pYlz3M7q for ; Fri, 24 Apr 2020 05:22:59 +0000 (UTC) (envelope-from bsd-lists@BSDforge.com) Received: from udns.ultimatedns.net (localhost [IPv6:0:0:0:0:0:0:0:1]) by udns.ultimatedns.net (8.15.2/8.15.2) with ESMTPS id 03O5Ns5V056871 (version=TLSv1.2 cipher=DHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Thu, 23 Apr 2020 22:24:00 -0700 (PDT) (envelope-from bsd-lists@BSDforge.com) X-Mailer: Cypht MIME-Version: 1.0 Cc: In-Reply-To: From: Chris Reply-To: bsd-lists@BSDforge.com To: Igor Pokrovsky Subject: Re: Loader hangs on the latest -STABLE Date: Thu, 23 Apr 2020 22:24:00 -0700 Message-Id: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 497jHR5pYlz3M7q X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-1.93 / 15.00]; NEURAL_HAM_MEDIUM(-0.95)[-0.952,0]; ASN(0.00)[asn:11404, ipnet:24.113.0.0/16, country:US]; local_wl_ip(0.00)[24.113.41.81]; NEURAL_HAM_LONG(-0.98)[-0.982,0] X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Apr 2020 05:23:00 -0000 On Fri, 24 Apr 2020 08:26:13 +0400 Igor Pokrovsky ip@unixway=2Eorg said > Hello all, >=20 > I haven=E2=80=99t been using FreeBSD since 8-STABLE times=2E Recently I tri= ed to > install latest 12-STABLE on my old computer=2E > But even during initial boot up loader hangs=2E Eventually I was able to > proceed with installation after replacing loader in=20 > the installation disk with one found in my old system 8-STABLE=2E The same > happened when I tried zfs on root partition=2E A lot of things are moving around in /boot over the last year=2E Pure speculation; if you're using a usb stick=2E Mount it from your currently running system, and cd /boot rm =2E/loader cp -p =2E/loader=2Eefi =2E/loader umount Then see if it doesn't work for you=2E Like I said, pure speculation=2E But you indicated an old box=2E So I think you might find this works=2E Best wishes! --Chris >=20 > I used MBR partition on PATA hard drive=2E Motherboard was ASUS A8V > (Athlon64)=2E >=20 > ip >=20 > _______________________________________________ > freebsd-stable@freebsd=2Eorg mailing list > https://lists=2Efreebsd=2Eorg/mailman/listinfo/freebsd-stable > To unsubscribe, send any mail to "freebsd-stable-unsubscribe@freebsd=2Eorg" From owner-freebsd-stable@freebsd.org Fri Apr 24 05:27:44 2020 Return-Path: Delivered-To: freebsd-stable@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 08D032CFC2E for ; Fri, 24 Apr 2020 05:27:44 +0000 (UTC) (envelope-from bsd-lists@BSDforge.com) Received: from udns.ultimatedns.net (static-24-113-41-81.wavecable.com [24.113.41.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "ultimatedns.net", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 497jNv5njjz3MHp for ; Fri, 24 Apr 2020 05:27:43 +0000 (UTC) (envelope-from bsd-lists@BSDforge.com) Received: from udns.ultimatedns.net (localhost [IPv6:0:0:0:0:0:0:0:1]) by udns.ultimatedns.net (8.15.2/8.15.2) with ESMTPS id 03O5Sd0Z057052 (version=TLSv1.2 cipher=DHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Thu, 23 Apr 2020 22:28:45 -0700 (PDT) (envelope-from bsd-lists@BSDforge.com) X-Mailer: Cypht MIME-Version: 1.0 Cc: In-Reply-To: From: Chris Reply-To: bsd-lists@BSDforge.com To: Igor Pokrovsky Subject: Re: Loader hangs on the latest -STABLE Date: Thu, 23 Apr 2020 22:28:45 -0700 Message-Id: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 497jNv5njjz3MHp X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-1.93 / 15.00]; NEURAL_HAM_MEDIUM(-0.95)[-0.952,0]; NEURAL_HAM_LONG(-0.98)[-0.982,0]; ASN(0.00)[asn:11404, ipnet:24.113.0.0/16, country:US]; local_wl_ip(0.00)[24.113.41.81] X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Apr 2020 05:27:44 -0000 On Thu, 23 Apr 2020 22:24:00 -0700 bsd-lists@BSDforge=2Ecom said > On Fri, 24 Apr 2020 08:26:13 +0400 Igor Pokrovsky ip@unixway=2Eorg said >=20 > > Hello all, > >=20 > > I haven=E2=80=99t been using FreeBSD since 8-STABLE times=2E Recently I t= ried to > > install latest 12-STABLE on my old computer=2E > > But even during initial boot up loader hangs=2E Eventually I was able to > > proceed with installation after replacing loader in=20 > > the installation disk with one found in my old system 8-STABLE=2E The sam= e > > happened when I tried zfs on root partition=2E > A lot of things are moving around in /boot over the last year=2E > Pure speculation; if you're using a usb stick=2E Mount it from your > currently running system, and >=20 > cd /boot > rm =2E/loader > cp -p =2E/loader=2Eefi =2E/loader STRIKE THAT! I meant cp -p =2E/loader=2E4th =2E/loader sorry! OH, and you will, of course need to do it as root=2E :) --Chris > umount >=20 > Then see if it doesn't work for you=2E Like I said, pure speculation=2E > But you indicated an old box=2E So I think you might find this works=2E >=20 > Best wishes! >=20 > --Chris > >=20 > > I used MBR partition on PATA hard drive=2E Motherboard was ASUS A8V > > (Athlon64)=2E > >=20 > > ip > >=20 > > _______________________________________________ > > freebsd-stable@freebsd=2Eorg mailing list > > https://lists=2Efreebsd=2Eorg/mailman/listinfo/freebsd-stable > > To unsubscribe, send any mail to "freebsd-stable-unsubscribe@freebsd=2Eor= g" >=20 >=20 > _______________________________________________ > freebsd-stable@freebsd=2Eorg mailing list > https://lists=2Efreebsd=2Eorg/mailman/listinfo/freebsd-stable > To unsubscribe, send any mail to "freebsd-stable-unsubscribe@freebsd=2Eorg" From owner-freebsd-stable@freebsd.org Fri Apr 24 06:07:43 2020 Return-Path: Delivered-To: freebsd-stable@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 934772A8826 for ; Fri, 24 Apr 2020 06:07:43 +0000 (UTC) (envelope-from ip@unixway.org) Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 497kH25lkZz3Nr9 for ; Fri, 24 Apr 2020 06:07:42 +0000 (UTC) (envelope-from ip@unixway.org) Received: by mail-lj1-x232.google.com with SMTP id f11so4104512ljp.1 for ; Thu, 23 Apr 2020 23:07:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=unixway-org.20150623.gappssmtp.com; s=20150623; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=Liy97JRy83dUlB4qW/jMwyzi4bn3URvHzp0sc5qkM5o=; b=AfUhqE1eoh3gCLThuKJZ+QhywNT36TPsMK2BXuSYgQRNyAEIZkxjti09T4pB2Jwm2s AFtZBL1kB9J9f6ycb8NpBscToR+6YrR/1AVmAjvwLKAU06eEZoeNB1Xvz3RCsRIVyVUg G/Z0y9/mS61/fPlTXfjyBkjRupx4881Yf8nsbQbxWAIaUMySVeAL301kQYfsmqJe7ngA Kpg4JEZrHNWkYgegBy2tS7SMt4xl7vRB1J+OFsdqY8UnREj+wHHYY7otqOSAfAIoF0bR GPnzPgxfoYoG95+/cIt/sUV7PEEM8omUSIOskI4LDabKae1EP57bB1xy5hGTVSjx3N2/ OsvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=Liy97JRy83dUlB4qW/jMwyzi4bn3URvHzp0sc5qkM5o=; b=JJun5GoxfFLzI+5M44gykaEUPRpRJrBoZ4eNykWXyqARvpjNzkTNoK0eCUfbno/QKC 5tbR4atuQQE3MOvaf6w5RW4H3Jq4Z7RJh3Za7wTp7r75FeEBWdq6WARp/CxjR4yzJpVM wgTERwQ27evR44F7SKodkKGPM7/ohbdrvQNtNH/t0z1qLNOGit7dMJzc7J8fSpRbZl2b RSVnnbuD/LPqKwoTTzUgdvqzMV7TQGzjsPfAcnGxr5nXyiVzL62aayllFKB2L9kluSpF c1rdAG0hv54c8x5heGKTGE1vuwFaZEBJF+1pr6NMiFu3f/tg5RFE9DpcqE+0opdDg7h6 U37w== X-Gm-Message-State: AGi0PuarTcROnmnxzahax8tVTqJLltiVOq18WzhX7IdjF6jcqai7jDHg 52Fg6EW18fTCXtzuFwLmFQsgGKAnL+Q= X-Google-Smtp-Source: APiQypIB5MQLDNnHlkRBsXB7H4EKpth3P/+9FPEGhzUw9NYabTrHh4NVNpvNdwYBuYw9qd0gGgModw== X-Received: by 2002:a05:651c:3ce:: with SMTP id f14mr4866088ljp.98.1587708460614; Thu, 23 Apr 2020 23:07:40 -0700 (PDT) Received: from [192.168.0.100] (5cfcb436.dynamic.mv.ru. [92.252.180.54]) by smtp.gmail.com with ESMTPSA id r20sm3514136ljj.44.2020.04.23.23.07.39 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 23 Apr 2020 23:07:40 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\)) Subject: Re: Loader hangs on the latest -STABLE From: Igor Pokrovsky In-Reply-To: Date: Fri, 24 Apr 2020 10:07:37 +0400 Cc: freebsd-stable@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: To: bsd-lists@BSDforge.com X-Mailer: Apple Mail (2.2104) X-Rspamd-Queue-Id: 497kH25lkZz3Nr9 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=unixway-org.20150623.gappssmtp.com header.s=20150623 header.b=AfUhqE1e; dmarc=none; spf=none (mx1.freebsd.org: domain of ip@unixway.org has no SPF policy when checking 2a00:1450:4864:20::232) smtp.mailfrom=ip@unixway.org X-Spamd-Result: default: False [-4.21 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[unixway-org.20150623.gappssmtp.com:s=20150623]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; MV_CASE(0.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-stable@freebsd.org]; TO_DN_NONE(0.00)[]; DMARC_NA(0.00)[unixway.org]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[unixway-org.20150623.gappssmtp.com:+]; RCPT_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_NONE(0.00)[2.3.2.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.5.4.1.0.0.a.2.list.dnswl.org : 127.0.5.0]; R_SPF_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; IP_SCORE(-2.41)[ip: (-9.22), ipnet: 2a00:1450::/32(-2.33), asn: 15169(-0.43), country: US(-0.05)]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; RECEIVED_SPAMHAUS_PBL(0.00)[54.180.252.92.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.11] X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Apr 2020 06:07:43 -0000 > On 24 =D0=B0=D0=BF=D1=80. 2020 =D0=B3., at 9:28, Chris = wrote: > STRIKE THAT! > I meant > cp -p ./loader.4th ./loader Thanks for the answer, Chris. But unfortunatly this doesn=E2=80=99t = help. From owner-freebsd-stable@freebsd.org Fri Apr 24 09:56:12 2020 Return-Path: Delivered-To: freebsd-stable@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 892D82ADFF9 for ; Fri, 24 Apr 2020 09:56:12 +0000 (UTC) (envelope-from eugen@grosbein.net) Received: from hz.grosbein.net (hz.grosbein.net [IPv6:2a01:4f8:c2c:26d8::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "hz.grosbein.net", Issuer "hz.grosbein.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 497qLf6721z461v for ; Fri, 24 Apr 2020 09:56:10 +0000 (UTC) (envelope-from eugen@grosbein.net) Received: from eg.sd.rdtc.ru (eg.sd.rdtc.ru [IPv6:2a03:3100:c:13:0:0:0:5]) by hz.grosbein.net (8.15.2/8.15.2) with ESMTPS id 03O9tufO073129 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 24 Apr 2020 09:55:58 GMT (envelope-from eugen@grosbein.net) X-Envelope-From: eugen@grosbein.net X-Envelope-To: ip@unixway.org Received: from [10.58.0.10] (dadv@dadvw [10.58.0.10]) by eg.sd.rdtc.ru (8.15.2/8.15.2) with ESMTPS id 03O9to7G004922 (version=TLSv1.2 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Fri, 24 Apr 2020 16:55:50 +0700 (+07) (envelope-from eugen@grosbein.net) Subject: Re: Loader hangs on the latest -STABLE To: Igor Pokrovsky , freebsd-stable@freebsd.org References: From: Eugene Grosbein Message-ID: <8150d268-3390-a5d8-9783-84846c1c83a5@grosbein.net> Date: Fri, 24 Apr 2020 16:55:46 +0700 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=0.3 required=5.0 tests=BAYES_00,LOCAL_FROM, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.2 X-Spam-Report: * -2.3 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record * -0.0 SPF_PASS SPF: sender matches SPF record * 2.6 LOCAL_FROM From my domains X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on hz.grosbein.net X-Rspamd-Queue-Id: 497qLf6721z461v X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=permerror (mx1.freebsd.org: domain of eugen@grosbein.net uses mechanism not recognized by this client) smtp.mailfrom=eugen@grosbein.net X-Spamd-Result: default: False [-3.99 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[grosbein.net]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; R_SPF_PERMFAIL(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; IP_SCORE(-1.89)[ip: (-5.24), ipnet: 2a01:4f8::/29(-2.64), asn: 24940(-1.54), country: DE(-0.02)]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:24940, ipnet:2a01:4f8::/29, country:DE]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Apr 2020 09:56:12 -0000 24.04.2020 11:26, Igor Pokrovsky пишет: > Hello all, > > I haven’t been using FreeBSD since 8-STABLE times. Recently I tried to install latest 12-STABLE on my old computer. > But even during initial boot up loader hangs. Eventually I was able to proceed with installation after replacing loader in > the installation disk with one found in my old system 8-STABLE. The same happened when I tried zfs on root partition. > > I used MBR partition on PATA hard drive. Motherboard was ASUS A8V (Athlon64). Modern FreeBSD versions use newer vt(4) console driver that defaults to pixel mode rendering and depends on correctness of ACPI tables of motherboard's firmware much more than old syscons(4) console driver that is still available. You should try escaping to the loader prompt first and run these commands: set kern.vty=sc boot Try it and see if it helps. If so, don't forget adding "kern.vty=sc" to /boot/loader.conf after installation. From owner-freebsd-stable@freebsd.org Fri Apr 24 13:01:14 2020 Return-Path: Delivered-To: freebsd-stable@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 13F302B3648 for ; Fri, 24 Apr 2020 13:01:14 +0000 (UTC) (envelope-from ip@unixway.org) Received: from mail-lj1-x242.google.com (mail-lj1-x242.google.com [IPv6:2a00:1450:4864:20::242]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 497vS90KWSz4JP6 for ; Fri, 24 Apr 2020 13:01:12 +0000 (UTC) (envelope-from ip@unixway.org) Received: by mail-lj1-x242.google.com with SMTP id f18so9809720lja.13 for ; Fri, 24 Apr 2020 06:01:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=unixway-org.20150623.gappssmtp.com; s=20150623; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=zYaJQbjb4u8HyjpiKhaJ0gCHl0ib1vOZ/G8sSe6gfbA=; b=Rlm0JQr8ajjOGlD+fyCFJNBbRErfjDG92W/muzcUm5YG73JXLKcxNNzcljxL1MemD4 8q4KDJztU3PzdjYsFjxQoY2Z17UCWJLzMGSd/nYuAZPwRKCyfWO5y+VPQOlyIg8gRx9o 40sBqTyfgJ4PQp7P7EJbZtY0tblKhMGpsw9eK9QATUWET2kV8KFjufQXHJ5NAh2tNDTj cuer3WsARNSyLcMb3STBwGAsEujW+Qnh6pkrrtS7fzxJUUvaDxIEGU+5+CMd9jqYGFqb kzKHVRFOAObidTla8S3bXiYg7tgDzT67vZm4VqESC+mGQH5+fpIPHnebWCv6aD6iu5of 0a5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=zYaJQbjb4u8HyjpiKhaJ0gCHl0ib1vOZ/G8sSe6gfbA=; b=rmVVCXlVaDyHIwAxScqxSD0Eau3Gycw50o/1HXl0X7iotbAPvvXrVgNO6OukFIUIbl j9tdgameiMDNzJs+cdOmHVaRQs1zrgAGoha0M+wzzqVeiJzSzDIRXNkeiwJNea4bUR9k NRFA8ZaPfPPTFyHVDcUZxGddp0EvKwsujDt4x5GJr8bKc0v8zBC+ZAaUCo+vaTdMSbLg 39q8x992Ltrb1tehkwmNFRjuvvfqNmZr7zyTy+7naM6McS7QYPfau11Ks7o/FQRW6SnG cvEjgUw1FP81no4qDLwIh/8+MvU3K3EtwEOqBBjCLMJ+P7CRGcIpFzUwTOU1afsGKNNK ny/g== X-Gm-Message-State: AGi0PuawY0Its3mtuxyzbqCZGZ6prbkiT9PTKXKzN1/KL6Ot0yFvqaM0 6s0bOjn4AhepX8qlSyuGJDC6WVNNdWc= X-Google-Smtp-Source: APiQypKWptgL6POEyBDr3OFQffEaU6366fOLpjFxhftja+ifEWanYByea6jtNj2uJ+XSLu8ajlImhA== X-Received: by 2002:a2e:a549:: with SMTP id e9mr6007544ljn.28.1587733271153; Fri, 24 Apr 2020 06:01:11 -0700 (PDT) Received: from [192.168.0.100] (5cfcb436.dynamic.mv.ru. [92.252.180.54]) by smtp.gmail.com with ESMTPSA id x24sm4367050lfc.6.2020.04.24.06.01.10 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 24 Apr 2020 06:01:10 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\)) Subject: Re: Loader hangs on the latest -STABLE From: Igor Pokrovsky In-Reply-To: <8150d268-3390-a5d8-9783-84846c1c83a5@grosbein.net> Date: Fri, 24 Apr 2020 17:01:03 +0400 Cc: freebsd-stable@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <8150d268-3390-a5d8-9783-84846c1c83a5@grosbein.net> To: Eugene Grosbein X-Mailer: Apple Mail (2.2104) X-Rspamd-Queue-Id: 497vS90KWSz4JP6 X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=unixway-org.20150623.gappssmtp.com header.s=20150623 header.b=Rlm0JQr8; dmarc=none; spf=none (mx1.freebsd.org: domain of ip@unixway.org has no SPF policy when checking 2a00:1450:4864:20::242) smtp.mailfrom=ip@unixway.org X-Spamd-Result: default: False [-1.81 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[unixway-org.20150623.gappssmtp.com:s=20150623]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; MV_CASE(0.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-stable@freebsd.org]; DMARC_NA(0.00)[unixway.org]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[unixway-org.20150623.gappssmtp.com:+]; RCPT_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_NONE(0.00)[2.4.2.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.5.4.1.0.0.a.2.list.dnswl.org : 127.0.5.0]; R_SPF_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; IP_SCORE(-0.01)[ip: (2.74), ipnet: 2a00:1450::/32(-2.33), asn: 15169(-0.43), country: US(-0.05)]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; RECEIVED_SPAMHAUS_PBL(0.00)[54.180.252.92.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.11] X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Apr 2020 13:01:14 -0000 > On 24 =D0=B0=D0=BF=D1=80. 2020 =D0=B3., at 13:55, Eugene Grosbein = wrote: >=20 > 24.04.2020 11:26, Igor Pokrovsky =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >=20 >> Hello all, >>=20 >> I haven=E2=80=99t been using FreeBSD since 8-STABLE times. Recently I = tried to install latest 12-STABLE on my old computer. >> But even during initial boot up loader hangs. Eventually I was able = to proceed with installation after replacing loader in=20 >> the installation disk with one found in my old system 8-STABLE. The = same happened when I tried zfs on root partition. >>=20 >> I used MBR partition on PATA hard drive. Motherboard was ASUS A8V = (Athlon64). >=20 > Modern FreeBSD versions use newer vt(4) console driver that defaults = to pixel mode rendering > and depends on correctness of ACPI tables of motherboard's firmware = much more > than old syscons(4) console driver that is still available. > You should try escaping to the loader prompt first and run these = commands: >=20 > set kern.vty=3Dsc > boot >=20 > Try it and see if it helps. If so, don't forget adding "kern.vty=3Dsc" = to /boot/loader.conf > after installation. >=20 Yes, I tried sc, but it doesnt help too. I attached my drive to Promise RAID controller and system boots just = fine now. Probably the cause is in hardware, failed controller was made by VIA. ip From owner-freebsd-stable@freebsd.org Fri Apr 24 13:42:11 2020 Return-Path: Delivered-To: freebsd-stable@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B77852B50BA; Fri, 24 Apr 2020 13:42:11 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 497wMR4M5mz4MpC; Fri, 24 Apr 2020 13:42:11 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from venus.codepro.be (venus.codepro.be [5.9.86.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx1.codepro.be", Issuer "Let's Encrypt Authority X3" (verified OK)) (Authenticated sender: kp) by smtp.freebsd.org (Postfix) with ESMTPSA id 7991B1A126; Fri, 24 Apr 2020 13:42:11 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: by venus.codepro.be (Postfix, authenticated sender kp) id 9296C21E7F; Fri, 24 Apr 2020 15:42:09 +0200 (CEST) From: "Kristof Provost" To: d@delphij.net Cc: freebsd-current@freebsd.org, freebsd-stable@freebsd.org Subject: Re: CFT: if_bridge performance improvements Date: Fri, 24 Apr 2020 15:42:08 +0200 X-Mailer: MailMate (1.13.1r5671) Message-ID: <544E27A6-D799-4AF3-B4B7-1E68D5D50698@FreeBSD.org> In-Reply-To: <8634ec5c-a509-d2dd-8f5c-31efcbd50340@delphij.net> References: <5377E42E-4C01-4BCC-B934-011AC3448B54@FreeBSD.org> <8e0e2bf1-27cd-1a99-b266-c7223255942f@delphij.net> <8634ec5c-a509-d2dd-8f5c-31efcbd50340@delphij.net> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format=flowed; markup=markdown Content-Transfer-Encoding: 8bit X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Apr 2020 13:42:11 -0000 On 22 Apr 2020, at 18:15, Xin Li wrote: > On 4/22/20 01:45, Kristof Provost wrote: >> On 22 Apr 2020, at 10:20, Xin Li wrote: >>> Hi, >>> >>> On 4/14/20 02:51, Kristof Provost wrote: >>>> Hi, >>>> >>>> Thanks to support from The FreeBSD Foundation I’ve been able to >>>> work on >>>> improving the throughput of if_bridge. >>>> It changes the (data path) locking to use the NET_EPOCH >>>> infrastructure. >>>> Benchmarking shows substantial improvements (x5 in test setups). >>>> >>>> This work is ready for wider testing now. >>>> >>>> It’s under review here: https://reviews.freebsd.org/D24250 >>>> >>>> Patch for CURRENT: https://reviews.freebsd.org/D24250?download=true >>>> Patches for stable/12: >>>> https://people.freebsd.org/~kp/if_bridge/stable_12/ >>>> >>>> I’m not currently aware of any panics or issues resulting from >>>> these >>>> patches. >>> >>> I have observed the following panic with latest stable/12 after >>> applying >>> the stable_12 patchset, it appears like a race condition related >>> NULL >>> pointer deference, but I haven't took a deeper look yet. >>> >>> The box have 7 igb(4) NICs, with several bridge and VLAN configured >>> acting as a router.  Please let me know if you need additional >>> information; I can try -CURRENT as well, but it would take some time >>> as >>> the box is relatively slow (it's a ZFS based system so I can create >>> a >>> separate boot environment for -CURRENT if needed, but that would >>> take >>> some time as I might have to upgrade the packages, should there be >>> any >>> ABI breakages). >>> >> Thanks for the report. I don’t immediately see how this could >> happen. >> >> Are you running an L2 firewall on that bridge by any chance? An >> earlier >> version of the patch had issues with a stray unlock in that code >> path. > > I don't think I have a L2 firewall (I assume means filtering based on > MAC address like what can be done with e.g. ipfw? The bridges were > created on vlan interfaces though, do they count as L2 firewall?), the > system is using pf with a few NAT rules: > That backtrace looks identical to the one Peter reported, up to and including the offset in the bridge_input() function. Given that there’s no likely way to end up with a NULL mutex either I have to assume that it’s a case of trying to unlock a locked mutex, and the most likely reason is that you ran into the same problem Peter ran into. The current version of the patch should resolve it. Best regards, Kristof From owner-freebsd-stable@freebsd.org Fri Apr 24 21:12:09 2020 Return-Path: Delivered-To: freebsd-stable@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 649AA2C260A; Fri, 24 Apr 2020 21:12:09 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from anubis.delphij.net (anubis.delphij.net [IPv6:2001:470:1:117::25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "anubis.delphij.net", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4986Lc39TSz484K; Fri, 24 Apr 2020 21:12:08 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from odin.corp.delphij.net (unknown [IPv6:2601:646:8600:58ba:f8e4:80ce:7871:5fe6]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by anubis.delphij.net (Postfix) with ESMTPSA id 94B7322E34; Fri, 24 Apr 2020 14:12:06 -0700 (PDT) Reply-To: d@delphij.net Subject: Re: CFT: if_bridge performance improvements To: Kristof Provost , d@delphij.net Cc: freebsd-current@freebsd.org, freebsd-stable@freebsd.org References: <5377E42E-4C01-4BCC-B934-011AC3448B54@FreeBSD.org> <8e0e2bf1-27cd-1a99-b266-c7223255942f@delphij.net> <8634ec5c-a509-d2dd-8f5c-31efcbd50340@delphij.net> <544E27A6-D799-4AF3-B4B7-1E68D5D50698@FreeBSD.org> From: Xin Li Autocrypt: addr=delphij@delphij.net; prefer-encrypt=mutual; keydata= mQINBFuSR4oBEACvvEgwRIHs6IcSP/yaDtySF78Ji3rP29qdiQsxhMsOtvtffdbS56VApIWO UFb3/iN2gA8HwLvrmjijN0HEoLVX7na1WARmxRYzQMtApsZIUTtx7hnUYlsi2F5odZa6CDW9 a954DLRzYxiUwYDcu5Zjl9bglK1H8e/N9uC0Vuigr4teWfh86brzOyf819QzwFVYfMIK4ihw QGwMvTzbyVuCFy+LENkmcVYni70oQy6rZ5ktSuYbuOFvu7inRRfhSWPHziV7k+bW88sJ7xhv lBlegcnhkSudWX2M8tZ3MO1PJOcyys0CJlsBY5Weiog2lIPi05h/E9pZ9mc1Vud17iqDaL6w RaggOUhuPfDGCdO5ro82W4BZGeQMRnRF5Ntk+t2ShIH4nn3xRLV0E5nziCiKlgiMqOrz/ZTL QTVbHrCuiwD+fSK14y0oHbkOLYTYLlgh1JbwfY2Ty7elOYiWzyeJ7sJh2dF91NSEneWIOys3 mBpuvtU3nSzzTvAB48VV+Nbg1CpIOgNlPjj7uhIum/Z/VjUaJEyaLpTIRh0MVJVcbP7hXSqZ NA35EEZZVnWEOYdycm4CmEdeNPWkrAf2Ya77iR5VLGypwMlsUMQPh+sKVWDD38M8stFGBBNm d01Hi74Bsq5hKan654dOqMt5eYklrVj0ucMzFQtus7oE502UswARAQABtBxYaW4gTEkgPGRl bHBoaWpAZGVscGhpai5uZXQ+iQJUBBMBCgA+FiEEceNg5NEMZIki80nQQHl/fJX0g08FAluS R/YCGwMFCQmuhAAFCwkIBwMFFQoJCAsFFgIDAQACHgECF4AACgkQQHl/fJX0g0+2Og//bWpE F2V5/M5l6YW1T8oLcT9rIOH6oq9M0LMNRgFeiNNnilGIeeIgtOGBRueG4CZiZAvsRPJkrO70 1R2SrdkCIvwGUzUAxx1NfBWb+vgm4fgkW/MotGonceM5v0qfSKKXasWvDctkK28aG+IoQzmi FjXNW4+ju4zeQFYwD4ZDWqw9MqO0hVb24uW3dxtQhbfmOLgJ/PEDMQaFuANbW1c+iR0BQA3D Go/EeMY4kpN8on6Aqt/S/4JVltudfQ9OXdjQsC7netSaB9K3mHGt9aKAAB7RzlRY00DKkYS/ /eQwLzGPmK7yX13M68mMDjBs6mIR8t/E1S5OdBNhHRPNPlEbwugR4KaiCsN5yqzJoSV99fKY z2VyxjWPaG8yhHE+jmKUgIBKTfFUQEfkriQR4EASoeJ+soaMTiFDBij1Zw5n3ndLRFMB1ZCl fZLER36mAgW4m4kP83TWnDiJLxOxSOxifV8HpTFjff902H85cybg9KMwrfPDr6W19GGk5Vo1 fkza5krRMGbKWb7+74Evusi0ZxJLIOFwp5Y8eVqUMZaAD3f1ZX1M3pgXOp20QgAy+2KvMHij rLa4q+tMGRzYYD1BnFVSVdXAX5VOoTmHBcDz67DkuRwk2Byp1sgd407oEOmSwrNJlKS0TPCm xUJ2fdSQF+1/MMSRfee49vtMvz7cOrC5Ag0EW5JHigEQANiBmIFAfRNH3nzYNWC0yC+tfx3z sUwAsH1VaBM/cTib+yKtbBOSIlXWjJZWX3MHwoI/1LeGghB2mxkkX1L0pJ/vj1eXNR+sFZ32 0pYcl61Fxg/5fioG4QDTM4i3i7NR5PxDnc6UVaynSlII93DedRhZ1ROtdn4vyMgzsDiqhbL7 BthDOt5KxjqdRk4qRPSw7BovEqZLOcG5IJtf/zZUzRbM7SBljEbOAfekDGx1Br+RrYSD7/Ef Pwwzou9T8315IpBpIHyQF/dZNk3iFiB9Ed5CA71ZRYV5YoLWE9lL0j9kxOLQ5vHnX3mVq7QZ Bc7nzwZ6UhQgYmrG5+RWvuiPpGwvDRIsugJUGXucYkAQh5kuNblmkwpv6u9rNMjCNbzAylOa qdogra5EW+RUSbRz0b4iIr8nnZeAlh7BihCe7JjOwbDjoBEEEtSfVc4hD/LENqpcYVrChphf aOLB9YIXhnVDTVvMc9OklWT/81HzAaDQqOQCzEfY92199Ct9/CwRoQ2OpO8TO5+8A7b9Nb33 nmxMn09mb48ruRacMrfHxCWbgU4w9SEfbip4GcS5wGG6yTC+hw55Iwnnwus40NrJ0GEr8a4r cdsLbkvlyoNHB8ZGgyJ4aFCQ1V4qE1BnlTk7Z8BYBUkJM1odPSkVvHpCnMUjVpJ3hEOC+73Z YH1dh7lZABEBAAGJAjwEGAEKACYWIQRx42Dk0QxkiSLzSdBAeX98lfSDTwUCW5JHigIbDAUJ Ca6EAAAKCRBAeX98lfSDTz8DEACMh3poeUb+gWNF4RWFZuLteZVo0+E1JLYXQkmtrRBLXviP +Qy0pXyFAVxLM4hNIBoIDYfK9BcwrBYf7AwSKrH0GiNwFpgHCkbZd6qoZy2gB+adTnCpVCTJ KJetsH/8awkrChJWMK0ckGf3EeWMPvawG7kW7FBz70NYEZ0pOMiaEZNVtzD3wwbYWUiDFYth 83XGglOExg+1ShTW5XjQPRrdyJAO+aUW4o3lVjfyUJXMgI4rmhMiLVm06GuNrbpKIF0s+4Vd jQAjhrDQjfoXi9CkfsA/cONseuHNv1JGj3RqHiqHJq1dbrpodXp925zGDAnUGxCOBPoFopAH gVzR89GTut059GpwqsddZmU6y7rqifuam/ekJ+QRwc16vgt7pHqCrTY8WPxRZr2UpFU1wlTo COdeiFep1gq1F9jzFjJnoMaAdmC6k7bgAA+RQusOgIhJL0jIej7DoAHxmxFFCfRy+lDtpXwF gQ8HMvzHI65QWmQnMo7s6SQH/ZH5s1yR6SJq8+3lDz+dCuT42qJVqIPVvxd10LW0FNN+t7HF eLadU6ekSgD13/EYMYXlvNHkw7dAItSDxIzgRyykLz0bCU9xwNWoS4Z43+ifF9anJ+uR0ltW El1j++h6ZrD3LLuCgJIt1so0m49GzdcSpOI7LCwMlacyvafiEyjUn+tSNDsnfw== Message-ID: <5246fd44-b856-5402-092e-9065d4d4f7ae@delphij.net> Date: Fri, 24 Apr 2020 14:12:02 -0700 User-Agent: Thunderbird MIME-Version: 1.0 In-Reply-To: <544E27A6-D799-4AF3-B4B7-1E68D5D50698@FreeBSD.org> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="OL3HcfXl96oGJZBGGYPqcYw9drokEEWjC" X-Rspamd-Queue-Id: 4986Lc39TSz484K X-Spamd-Bar: -------- X-Spamd-Result: default: False [-8.73 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[delphij.net:s=m7e2]; XM_UA_NO_VERSION(0.01)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+mx]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; HAS_ATTACHMENT(0.00)[]; MIME_GOOD(-0.20)[multipart/signed,multipart/mixed,text/plain]; HAS_REPLYTO(0.00)[d@delphij.net]; TO_DN_SOME(0.00)[]; REPLYTO_DOM_EQ_FROM_DOM(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[delphij.net:+]; DMARC_POLICY_ALLOW(-0.50)[delphij.net,reject]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; SIGNED_PGP(-2.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:+,3:~]; IP_SCORE(-3.64)[ip: (-9.91), ipnet: 2001:470::/32(-4.65), asn: 6939(-3.60), country: US(-0.05)]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Apr 2020 21:12:09 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --OL3HcfXl96oGJZBGGYPqcYw9drokEEWjC Content-Type: multipart/mixed; boundary="bBbUDl9mUraOpX4O489N3sYhzSlAUBRFO"; protected-headers="v1" From: Xin Li Reply-To: d@delphij.net To: Kristof Provost , d@delphij.net Cc: freebsd-current@freebsd.org, freebsd-stable@freebsd.org Message-ID: <5246fd44-b856-5402-092e-9065d4d4f7ae@delphij.net> Subject: Re: CFT: if_bridge performance improvements References: <5377E42E-4C01-4BCC-B934-011AC3448B54@FreeBSD.org> <8e0e2bf1-27cd-1a99-b266-c7223255942f@delphij.net> <8634ec5c-a509-d2dd-8f5c-31efcbd50340@delphij.net> <544E27A6-D799-4AF3-B4B7-1E68D5D50698@FreeBSD.org> In-Reply-To: <544E27A6-D799-4AF3-B4B7-1E68D5D50698@FreeBSD.org> --bBbUDl9mUraOpX4O489N3sYhzSlAUBRFO Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 4/24/20 06:42, Kristof Provost wrote: > On 22 Apr 2020, at 18:15, Xin Li wrote: >> On 4/22/20 01:45, Kristof Provost wrote: >>> On 22 Apr 2020, at 10:20, Xin Li wrote: >>>> Hi, >>>> >>>> On 4/14/20 02:51, Kristof Provost wrote: >>>>> Hi, >>>>> >>>>> Thanks to support from The FreeBSD Foundation I=E2=80=99ve been abl= e to >>>>> work on >>>>> improving the throughput of if_bridge. >>>>> It changes the (data path) locking to use the NET_EPOCH >>>>> infrastructure. >>>>> Benchmarking shows substantial improvements (x5 in test setups). >>>>> >>>>> This work is ready for wider testing now. >>>>> >>>>> It=E2=80=99s under review here: https://reviews.freebsd.org/D24250 >>>>> >>>>> Patch for CURRENT: https://reviews.freebsd.org/D24250?download=3Dtr= ue >>>>> Patches for stable/12: >>>>> https://people.freebsd.org/~kp/if_bridge/stable_12/ >>>>> >>>>> I=E2=80=99m not currently aware of any panics or issues resulting f= rom these >>>>> patches. >>>> >>>> I have observed the following panic with latest stable/12 after >>>> applying >>>> the stable_12 patchset, it appears like a race condition related NUL= L >>>> pointer deference, but I haven't took a deeper look yet. >>>> >>>> The box have 7 igb(4) NICs, with several bridge and VLAN configured >>>> acting as a router.=C2=A0 Please let me know if you need additional >>>> information; I can try -CURRENT as well, but it would take some time= as >>>> the box is relatively slow (it's a ZFS based system so I can create = a >>>> separate boot environment for -CURRENT if needed, but that would tak= e >>>> some time as I might have to upgrade the packages, should there be a= ny >>>> ABI breakages). >>>> >>> Thanks for the report. I don=E2=80=99t immediately see how this could= happen. >>> >>> Are you running an L2 firewall on that bridge by any chance? An earli= er >>> version of the patch had issues with a stray unlock in that code path= =2E >> >> I don't think I have a L2 firewall (I assume means filtering based on >> MAC address like what can be done with e.g. ipfw?=C2=A0 The bridges we= re >> created on vlan interfaces though, do they count as L2 firewall?), the= >> system is using pf with a few NAT rules: >> >=20 > That backtrace looks identical to the one Peter reported, up to and > including the offset in the bridge_input() function. > Given that there=E2=80=99s no likely way to end up with a NULL mutex ei= ther I > have to assume that it=E2=80=99s a case of trying to unlock a locked mu= tex, and > the most likely reason is that you ran into the same problem Peter ran > into. >=20 > The current version of the patch should resolve it. Thanks, I'd like to report that after applying the patch from Peter the system seems to survive without problem. Cheers, --bBbUDl9mUraOpX4O489N3sYhzSlAUBRFO-- --OL3HcfXl96oGJZBGGYPqcYw9drokEEWjC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.2.20 (Darwin) iQIzBAEBCgAdFiEEceNg5NEMZIki80nQQHl/fJX0g08FAl6jViUACgkQQHl/fJX0 g08YSQ//ehsN8qEaDAOVOCamsRCb4l5MiW/0i9gulOLsRbEN6Rm4ZRWDa+5yCTyq p0bs1RlOhspYOZhVkwtw7gITCrJ29LdHM7VIxVzaHOskuh6zTGcnUG6PZMHKw62H fA54Yzt20pRpYYS+L/LrKsQUaaJRsZNzMnASchANunuEQcaAuGZJIBG+nZXkM1rQ TRKJv6F9sxAkE+CtWB73AB1isV7IREDrcLgi/C7CIrehqD/nvBdpF35+JflFIe0f s2NHZZNyjoFm6Fxbs7tWfbit+hLDY5pVMHyB/ItsIyFToB0gvWWuNAGasLP4Pimn b5yKyGKb1KXPzIrtkvcLFhRHwqPBqiGeOrm/657MHJ8IxvaXzs6/UGuy2uqZU2iP NfPWVkvU6oP3TZSVkedysyk5/UCWhslCfdAnUP/tT8QqKI5lpbmDsvnCBXN0rNbi uzKnlbMmatqNgLLgw8D9h/MvXj9ZdzUKm2Y1wYF/Jzzag0BBTR3IsOV4BxKmvpX2 e5GwHaa6y/fwHdjIO4K9KWg7y1b6XUFTgp1sxm/0c5GnrmSj29wHUdDntse8yAqm PdWpyU/vwfV2Uc1FIJBpWYnKiWZPx4GgULSKLwliZPCaKeoTqStmE00rfLmtnPPd o2n7dv+oH4ybM2qOkVt55N1TGpGT3HlIne5SWqsNG7aaMWk46p4= =Kjcw -----END PGP SIGNATURE----- --OL3HcfXl96oGJZBGGYPqcYw9drokEEWjC-- From owner-freebsd-stable@freebsd.org Sat Apr 25 05:58:10 2020 Return-Path: Delivered-To: freebsd-stable@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 345952CC377 for ; Sat, 25 Apr 2020 05:58:10 +0000 (UTC) (envelope-from wolfgang@lyxys.ka.sub.org) Received: from saturn.lyxys.ka.sub.org (saturn.lyxys.ka.sub.org [217.29.35.151]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 498L1Y0Zzvz4Z0d for ; Sat, 25 Apr 2020 05:58:08 +0000 (UTC) (envelope-from wolfgang@lyxys.ka.sub.org) Received: from saturn.lyxys.ka.sub.org (localhost [127.0.0.1]) by saturn.lyxys.ka.sub.org (8.15.2/8.15.2) with ESMTPS id 03P5udgh066174 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Sat, 25 Apr 2020 07:56:42 +0200 (CEST) (envelope-from wolfgang@lyxys.ka.sub.org) Received: (from root@localhost) by saturn.lyxys.ka.sub.org (8.15.2/8.15.2/Submit) id 03P5ucHj066173; Sat, 25 Apr 2020 07:56:38 +0200 (CEST) (envelope-from wolfgang) Message-Id: <202004250556.03P5ucHj066173@saturn.lyxys.ka.sub.org> From: Wolfgang Zenker To: Pete Wright Cc: freebsd-stable@freebsd.org Subject: Re: 12.1-STABLE crash after upgrade to r360192 References: <202004222018.03MKIWis054780@saturn.lyxys.ka.sub.org> <7a237525-ea6a-e138-8c4f-ff8254192e1e@nomadlogic.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7a237525-ea6a-e138-8c4f-ff8254192e1e@nomadlogic.org> X-Mutt-References: <7a237525-ea6a-e138-8c4f-ff8254192e1e@nomadlogic.org> X-Mutt-Fcc: ~/sent Status: RO Date: Wed, 22 Apr 2020 23:06:04 +0200 Lines: 32 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (saturn.lyxys.ka.sub.org [127.0.0.1]); Sat, 25 Apr 2020 07:56:43 +0200 (CEST) X-Rspamd-Queue-Id: 498L1Y0Zzvz4Z0d X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of wolfgang@lyxys.ka.sub.org designates 217.29.35.151 as permitted sender) smtp.mailfrom=wolfgang@lyxys.ka.sub.org X-Spamd-Result: default: False [-2.67 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+mx]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[sub.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; IP_SCORE(-1.37)[ip: (-5.47), ipnet: 217.29.32.0/20(-0.77), asn: 16188(-0.59), country: DE(-0.02)]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:16188, ipnet:217.29.32.0/20, country:DE]; RCVD_COUNT_TWO(0.00)[2]; DATE_IN_PAST(1.00)[] X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Apr 2020 05:58:10 -0000 Hi, On Wed, Apr 22, 2020 at 01:48:00PM -0700, Pete Wright wrote: > On 4/22/20 1:15 PM, Wolfgang Zenker wrote: >> I went from 12.1-STABLE r359345 to r360192 on an Acer C720 Notebook. >> The system now crashes on loading /boot/modules/i915kms.ko >> I build and install graphics/drm-kmod and graphics/drm-fbsd12.0-kmod >> together with the kernel. >> If i915kms.ko is loaded via kld_list in /etc/rc.conf at boot, the screen >> goes blank upon loading the module and does not react any more, powercycle >> is required. If I load the the module manually after a successful boot, >> the screen goes blank and the system reboots after a while; on reboot >> a dump is found and written to /var/crash. >> Kernel config is GENERIC with added options WITNESS and WITNESS_SKIPSPIN >> CPU is a Celeron 2955U (Haswell class) and the graphics controller >> identifies as 'Haswell-ULT Integrated Graphics Controller' in pciconf. >> Any suggestions how to proceed from here? Any usefull information that >> I could extract from the crashdump? > Did you rebuild the drm-fbsd12.0-kmod after updating your world and > kernel?  I generally do this by running "make package" inside my > ports/graphics/drm-fbsd12.0-kmod directory, then install this updated > package. I have this line in /etc/make.conf: PORTS_MODULES = graphics/drm-kmod graphics/drm-fbsd12.0-kmod So the modules are always built and installed at every "make kernel". Wolfgang