From owner-svn-src-head@freebsd.org Sun Dec 20 01:19:59 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A69DA4B2BD0; Sun, 20 Dec 2020 01:19:59 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Cz4XH2ltDz3jf3; Sun, 20 Dec 2020 01:19:59 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.16.1/8.16.1) with ESMTPS id 0BK1JpoV029583 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Sun, 20 Dec 2020 03:19:54 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 0BK1JpoV029583 Received: (from kostik@localhost) by tom.home (8.16.1/8.16.1/Submit) id 0BK1JpR9029582; Sun, 20 Dec 2020 03:19:51 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Sun, 20 Dec 2020 03:19:51 +0200 From: Konstantin Belousov To: Gordon Bergling Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r368817 - in head/lib/libc: locale net stdlib sys x86/sys Message-ID: References: <202012191454.0BJEsSaH001310@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202012191454.0BJEsSaH001310@repo.freebsd.org> X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on tom.home X-Rspamd-Queue-Id: 4Cz4XH2ltDz3jf3 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Dec 2020 01:19:59 -0000 On Sat, Dec 19, 2020 at 02:54:28PM +0000, Gordon Bergling wrote: > Modified: head/lib/libc/sys/thr_self.2 > ============================================================================== > --- head/lib/libc/sys/thr_self.2 Sat Dec 19 13:56:19 2020 (r368816) > +++ head/lib/libc/sys/thr_self.2 Sat Dec 19 14:54:28 2020 (r368817) > @@ -71,12 +71,12 @@ The memory pointed to by the > argument is not valid. > .El > .Sh SEE ALSO > +.Xr _umtx_op 2 , > .Xr thr_exit 2 , > .Xr thr_kill 2 , > .Xr thr_kill2 2 , > .Xr thr_new 2 , > .Xr thr_set_name 2 , > -.Xr _umtx_op 2 , > .Xr pthread_getthreadid_np 3 , > .Xr pthread_self 3 > .Sh STANDARDS Why this reordering ? From owner-svn-src-head@freebsd.org Sun Dec 20 02:59:45 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 38C544B5872; Sun, 20 Dec 2020 02:59:45 +0000 (UTC) (envelope-from lwhsu@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Cz6lP15ngz3pMD; Sun, 20 Dec 2020 02:59:45 +0000 (UTC) (envelope-from lwhsu@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 189F2658; Sun, 20 Dec 2020 02:59:45 +0000 (UTC) (envelope-from lwhsu@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id 0BK2xicU074754; Sun, 20 Dec 2020 02:59:44 GMT (envelope-from lwhsu@FreeBSD.org) Received: (from lwhsu@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id 0BK2xiGC074752; Sun, 20 Dec 2020 02:59:44 GMT (envelope-from lwhsu@FreeBSD.org) Message-Id: <202012200259.0BK2xiGC074752@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: lwhsu set sender to lwhsu@FreeBSD.org using -f From: Li-Wen Hsu Date: Sun, 20 Dec 2020 02:59:44 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r368820 - head X-SVN-Group: head X-SVN-Commit-Author: lwhsu X-SVN-Commit-Paths: head X-SVN-Commit-Revision: 368820 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Dec 2020 02:59:45 -0000 Author: lwhsu Date: Sun Dec 20 02:59:44 2020 New Revision: 368820 URL: https://svnweb.freebsd.org/changeset/base/368820 Log: Mark the repository as being converted to Git. This is the last Subversion commit to src. Sponsored by: The FreeBSD Foundation Modified: head/README head/README.md Modified: head/README ============================================================================== --- head/README Sat Dec 19 22:04:46 2020 (r368819) +++ head/README Sun Dec 20 02:59:44 2020 (r368820) @@ -1,3 +1,5 @@ +This repository is being converted from Subversion to Git. + This is the top level of the FreeBSD source directory. This file was last revised on: $FreeBSD$ Modified: head/README.md ============================================================================== --- head/README.md Sat Dec 19 22:04:46 2020 (r368819) +++ head/README.md Sun Dec 20 02:59:44 2020 (r368820) @@ -1,3 +1,5 @@ +This repository is being converted from Subversion to Git. + FreeBSD Source: --------------- This is the top level of the FreeBSD source directory. This file From owner-svn-src-head@freebsd.org Sun Dec 20 03:23:25 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B98244B61B4; Sun, 20 Dec 2020 03:23:25 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Cz7Gj4gq8z3qpQ; Sun, 20 Dec 2020 03:23:25 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro.local (unknown [IPv6:2601:648:8681:1cb0:dd04:d781:734e:7d95]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 1B30CFCE0; Sun, 20 Dec 2020 03:23:25 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Subject: Re: svn commit: r368789 - head/libexec/rtld-elf/rtld-libc To: Ryan Libby , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <202012190838.0BJ8cVJ3064816@repo.freebsd.org> From: John Baldwin Autocrypt: addr=jhb@FreeBSD.org; keydata= mQGiBETQ+XcRBADMFybiq69u+fJRy/0wzqTNS8jFfWaBTs5/OfcV7wWezVmf9sgwn8TW0Dk0 c9MBl0pz+H01dA2ZSGZ5fXlmFIsee1WEzqeJzpiwd/pejPgSzXB9ijbLHZ2/E0jhGBcVy5Yo /Tw5+U/+laeYKu2xb0XPvM0zMNls1ah5OnP9a6Ql6wCgupaoMySb7DXm2LHD1Z9jTsHcAQMD /1jzh2BoHriy/Q2s4KzzjVp/mQO5DSm2z14BvbQRcXU48oAosHA1u3Wrov6LfPY+0U1tG47X 1BGfnQH+rNAaH0livoSBQ0IPI/8WfIW7ub4qV6HYwWKVqkDkqwcpmGNDbz3gfaDht6nsie5Z pcuCcul4M9CW7Md6zzyvktjnbz61BADGDCopfZC4of0Z3Ka0u8Wik6UJOuqShBt1WcFS8ya1 oB4rc4tXfSHyMF63aPUBMxHR5DXeH+EO2edoSwViDMqWk1jTnYza51rbGY+pebLQOVOxAY7k do5Ordl3wklBPMVEPWoZ61SdbcjhHVwaC5zfiskcxj5wwXd2E9qYlBqRg7QeSm9obiBCYWxk d2luIDxqaGJARnJlZUJTRC5vcmc+iGAEExECACAFAkTQ+awCGwMGCwkIBwMCBBUCCAMEFgID AQIeAQIXgAAKCRBy3lIGd+N/BI6RAJ9S97fvbME+3hxzE3JUyUZ6vTewDACdE1stFuSfqMvM jomvZdYxIYyTUpC5Ag0ERND5ghAIAPwsO0B7BL+bz8sLlLoQktGxXwXQfS5cInvL17Dsgnr3 1AKa94j9EnXQyPEj7u0d+LmEe6CGEGDh1OcGFTMVrof2ZzkSy4+FkZwMKJpTiqeaShMh+Goj XlwIMDxyADYvBIg3eN5YdFKaPQpfgSqhT+7El7w+wSZZD8pPQuLAnie5iz9C8iKy4/cMSOrH YUK/tO+Nhw8Jjlw94Ik0T80iEhI2t+XBVjwdfjbq3HrJ0ehqdBwukyeJRYKmbn298KOFQVHO EVbHA4rF/37jzaMadK43FgJ0SAhPPF5l4l89z5oPu0b/+5e2inA3b8J3iGZxywjM+Csq1tqz hltEc7Q+E08AAwUIAL+15XH8bPbjNJdVyg2CMl10JNW2wWg2Q6qdljeaRqeR6zFus7EZTwtX sNzs5bP8y51PSUDJbeiy2RNCNKWFMndM22TZnk3GNG45nQd4OwYK0RZVrikalmJY5Q6m7Z16 4yrZgIXFdKj2t8F+x613/SJW1lIr9/bDp4U9tw0V1g3l2dFtD3p3ZrQ3hpoDtoK70ioIAjjH aIXIAcm3FGZFXy503DOA0KaTWwvOVdYCFLm3zWuSOmrX/GsEc7ovasOWwjPn878qVjbUKWwx Q4QkF4OhUV9zPtf9tDSAZ3x7QSwoKbCoRCZ/xbyTUPyQ1VvNy/mYrBcYlzHodsaqUDjHuW+I SQQYEQIACQUCRND5ggIbDAAKCRBy3lIGd+N/BCO8AJ9j1dWVQWxw/YdTbEyrRKOY8YZNwwCf afMAg8QvmOWnHx3wl8WslCaXaE8= Message-ID: <47e9db0f-14b4-0a0d-45c4-7e466e69711f@FreeBSD.org> Date: Sat, 19 Dec 2020 19:23:22 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: <202012190838.0BJ8cVJ3064816@repo.freebsd.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Dec 2020 03:23:25 -0000 On 12/19/20 12:38 AM, Ryan Libby wrote: > Author: rlibby > Date: Sat Dec 19 08:38:31 2020 > New Revision: 368789 > URL: https://svnweb.freebsd.org/changeset/base/368789 > > Log: > rtld-elf: link udivmoddi4 from compiler_rt > > This fixes the gcc9 build of rtld-elf32 on amd64, which needed an > implementation of udivmoddi4. > > rtld-elf uses certain functions normally found in libc, and so it > includes certain files from libc in its own build. It has two > mechanisms to include files from libc: one that rebuilds source files in > the rtld-elf environment, and one that extracts object files from a > purpose-built no-SSP PIC archive. > > In addition to libc functions, rtld-elf may need to link functions > normally found in libcompiler_rt (formerly libgcc). Now, add an ability > to rebuild libcompiler_rt source files in the rtld-elf environment. We > don't yet have a need for an object file extraction mechanism. > > libcompiler_rt could also supply udivdi3 and umoddi3, but leave them > alone for now. > > Reviewed by: arichardson, kib > Sponsored by: Dell EMC Isilon > Differential Revision: https://reviews.freebsd.org/D27665 Hmm, I had just linked against libcompiler_rt directly as we do on arm: https://reviews.freebsd.org/D26199 It was stuck waiting for review feedback. Given libcompiler_rt is a static archive, we could probably safely link against it directly unlike libc where we have to pick specific object files. -- John Baldwin From owner-svn-src-head@freebsd.org Sun Dec 20 04:27:44 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id ADE2A4B77DB; Sun, 20 Dec 2020 04:27:44 +0000 (UTC) (envelope-from rlibby@gmail.com) Received: from mail-qt1-f174.google.com (mail-qt1-f174.google.com [209.85.160.174]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Cz8hw4MNFz3ssJ; Sun, 20 Dec 2020 04:27:44 +0000 (UTC) (envelope-from rlibby@gmail.com) Received: by mail-qt1-f174.google.com with SMTP id a6so4508640qtw.6; Sat, 19 Dec 2020 20:27:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=p4O4L2rdo5a+qvaOn0QjwXb+ogoQHRTTh0DhniDXUxY=; b=FKpfPKBNPl8Y0h9/YUVxjKVvdmWI4HOO+3Qfx8/Cc4nWikKOwgjTln/2bEuABLMl2N 41NUehPrDoRmCQTPxTwa7XOxruXIcZLVzxVBC/ciH5aP8bZaxJbIeXbdMazx4L2LygDl fJyORXNb3GW5JbfmRdEsQWfP2w6Wh+tEmogARe3pE4AXnVl6QIG2gZRMGJ/gACJegOpy X7UDBaEDIFEr/dvY4gxkofkxTJ4M74PEPLYkMgWVRBIoLrVWnrG2qdxYQ5z/lxH3ZlAJ 1vsIzlgmRKHVBbmNuAYLYDyQevSb5DiHZC5wt/LPaSi6p5VsI6QzSlYwDgY4EgQv5JFd T4Gw== X-Gm-Message-State: AOAM532XUoEjFUdPhen19sL2jDBwwJ391ZglCLa1uyRErlJECQl7tSjG qqPwzbjgJsby5AAvtzRECQfjxts/E8HQsQ== X-Google-Smtp-Source: ABdhPJyTAEQvfmLEVht+PV3zS4n5T2mg7kOFMeMRxj99/S98whrBuPsNsGE+cauF0s3s+Jd/XcD9DA== X-Received: by 2002:a05:622a:346:: with SMTP id r6mr11332747qtw.299.1608438463254; Sat, 19 Dec 2020 20:27:43 -0800 (PST) Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com. [209.85.160.179]) by smtp.gmail.com with ESMTPSA id a10sm8868836qkk.52.2020.12.19.20.27.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 19 Dec 2020 20:27:43 -0800 (PST) Received: by mail-qt1-f179.google.com with SMTP id c14so4535387qtn.0; Sat, 19 Dec 2020 20:27:42 -0800 (PST) X-Received: by 2002:ac8:70c:: with SMTP id g12mr11489375qth.140.1608438462633; Sat, 19 Dec 2020 20:27:42 -0800 (PST) MIME-Version: 1.0 References: <202012190838.0BJ8cVJ3064816@repo.freebsd.org> <47e9db0f-14b4-0a0d-45c4-7e466e69711f@FreeBSD.org> In-Reply-To: <47e9db0f-14b4-0a0d-45c4-7e466e69711f@FreeBSD.org> From: Ryan Libby Date: Sat, 19 Dec 2020 20:27:31 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r368789 - head/libexec/rtld-elf/rtld-libc To: John Baldwin Cc: src-committers , svn-src-all , svn-src-head , Konstantin Belousov , Alex Richardson Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4Cz8hw4MNFz3ssJ X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Dec 2020 04:27:44 -0000 On Sat, Dec 19, 2020 at 7:23 PM John Baldwin wrote: > > On 12/19/20 12:38 AM, Ryan Libby wrote: > > Author: rlibby > > Date: Sat Dec 19 08:38:31 2020 > > New Revision: 368789 > > URL: https://svnweb.freebsd.org/changeset/base/368789 > > > > Log: > > rtld-elf: link udivmoddi4 from compiler_rt > > > > This fixes the gcc9 build of rtld-elf32 on amd64, which needed an > > implementation of udivmoddi4. > > > > rtld-elf uses certain functions normally found in libc, and so it > > includes certain files from libc in its own build. It has two > > mechanisms to include files from libc: one that rebuilds source files in > > the rtld-elf environment, and one that extracts object files from a > > purpose-built no-SSP PIC archive. > > > > In addition to libc functions, rtld-elf may need to link functions > > normally found in libcompiler_rt (formerly libgcc). Now, add an ability > > to rebuild libcompiler_rt source files in the rtld-elf environment. We > > don't yet have a need for an object file extraction mechanism. > > > > libcompiler_rt could also supply udivdi3 and umoddi3, but leave them > > alone for now. > > > > Reviewed by: arichardson, kib > > Sponsored by: Dell EMC Isilon > > Differential Revision: https://reviews.freebsd.org/D27665 > > Hmm, I had just linked against libcompiler_rt directly as we do on arm: > > https://reviews.freebsd.org/D26199 > > It was stuck waiting for review feedback. > > Given libcompiler_rt is a static archive, we could probably safely link > against it directly unlike libc where we have to pick specific object > files. > > -- > John Baldwin Sorry, I wasn't aware of your review. Do you want this backed out? I did see the arm path. I think it is not quite right, because libcompiler_rt is compiled with -fstack-protector-strong, which is not compatible with rtld. However, it will work in practice if stack protection doesn't actually get used on any linked function. We could build a special libcompiler_rt with no stack protection like we do just for rtld with libc, but since we'd only want this no-SSP library for rtld, that's not much different from just rebuilding its source files in rtld. In addition, by rebuilding specific files we avoid overlinking--although that may not be a big deal (?), and there may be other cleaner ways to avoid that (?). On a tangent, it might be neat to split out an rtld_bootstrap (everything through init_rtld()) so that only the bootstrap code needs to be compiled and linked with no-SSP. I looked at this some but I figured there might not be appetite for a bunch of reorganization of rtld just to enable SSP. Anyway the bootstrap code would still need these particular libcompiler_rt functions to be no-SSP, as they get used in the printf procedure, which I am guessing the bootstrap may need. Ryan From owner-svn-src-head@freebsd.org Sun Dec 20 04:34:36 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4958E4B79CB; Sun, 20 Dec 2020 04:34:36 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Cz8rq6qt8z3t7V; Sun, 20 Dec 2020 04:34:35 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.16.1/8.16.1) with ESMTPS id 0BK4YSxk076648 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Sun, 20 Dec 2020 06:34:31 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 0BK4YSxk076648 Received: (from kostik@localhost) by tom.home (8.16.1/8.16.1/Submit) id 0BK4YSEj076647; Sun, 20 Dec 2020 06:34:28 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Sun, 20 Dec 2020 06:34:28 +0200 From: Konstantin Belousov To: Ryan Libby Cc: John Baldwin , src-committers , svn-src-all , svn-src-head , Alex Richardson Subject: Re: svn commit: r368789 - head/libexec/rtld-elf/rtld-libc Message-ID: References: <202012190838.0BJ8cVJ3064816@repo.freebsd.org> <47e9db0f-14b4-0a0d-45c4-7e466e69711f@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on tom.home X-Rspamd-Queue-Id: 4Cz8rq6qt8z3t7V X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Dec 2020 04:34:36 -0000 On Sat, Dec 19, 2020 at 08:27:31PM -0800, Ryan Libby wrote: > On a tangent, it might be neat to split out an rtld_bootstrap > (everything through init_rtld()) so that only the bootstrap code needs > to be compiled and linked with no-SSP. I looked at this some but I > figured there might not be appetite for a bunch of reorganization of > rtld just to enable SSP. Anyway the bootstrap code would still need > these particular libcompiler_rt functions to be no-SSP, as they get used > in the printf procedure, which I am guessing the bootstrap may need. Just my opinion. SSP is not too useful itself, and I believe it is useless in rtld, simply due to what rtld typically executes (matching static strings). Rototiling early rtld stages to get another bullet on the list of doubtful features should not be done. From owner-svn-src-head@freebsd.org Sun Dec 20 08:34:42 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C49174BC13A; Sun, 20 Dec 2020 08:34:42 +0000 (UTC) (envelope-from gbe@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CzG9t50bHz4Z5k; Sun, 20 Dec 2020 08:34:42 +0000 (UTC) (envelope-from gbe@freebsd.org) Received: from localhost (p4fd3a159.dip0.t-ipconnect.de [79.211.161.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: gbe) by smtp.freebsd.org (Postfix) with ESMTPSA id 6145823102; Sun, 20 Dec 2020 08:34:42 +0000 (UTC) (envelope-from gbe@freebsd.org) Date: Sun, 20 Dec 2020 09:34:40 +0100 From: Gordon Bergling To: Konstantin Belousov Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r368817 - in head/lib/libc: locale net stdlib sys x86/sys Message-ID: References: <202012191454.0BJEsSaH001310@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: X-Operating-System: FreeBSD 12.2-STABLE amd64 X-Host-Uptime: 9:31AM up 3 days, 2:26, 4 users, load averages: 0.10, 0.27, 0.26 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Dec 2020 08:34:42 -0000 On Sun, Dec 20, 2020 at 03:19:51AM +0200, Konstantin Belousov wrote: > On Sat, Dec 19, 2020 at 02:54:28PM +0000, Gordon Bergling wrote: > > Modified: head/lib/libc/sys/thr_self.2 > > ============================================================================== > > --- head/lib/libc/sys/thr_self.2 Sat Dec 19 13:56:19 2020 (r368816) > > +++ head/lib/libc/sys/thr_self.2 Sat Dec 19 14:54:28 2020 (r368817) > > @@ -71,12 +71,12 @@ The memory pointed to by the > > argument is not valid. > > .El > > .Sh SEE ALSO > > +.Xr _umtx_op 2 , > > .Xr thr_exit 2 , > > .Xr thr_kill 2 , > > .Xr thr_kill2 2 , > > .Xr thr_new 2 , > > .Xr thr_set_name 2 , > > -.Xr _umtx_op 2 , > > .Xr pthread_getthreadid_np 3 , > > .Xr pthread_self 3 > > .Sh STANDARDS > Why this reordering ? The SEE ALSO section should be ordered by section and within the section alphabetically. Therefore _umtx_op must be on top of section two. --Gordon From owner-svn-src-head@freebsd.org Sun Dec 20 14:46:23 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E9B904C3C6A; Sun, 20 Dec 2020 14:46:23 +0000 (UTC) (envelope-from ohartmann@walstatt.org) Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mout.gmx.net", Issuer "TeleSec ServerPass Class 2 CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CzQQl4dsSz4sVp; Sun, 20 Dec 2020 14:46:23 +0000 (UTC) (envelope-from ohartmann@walstatt.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1608475581; bh=SdIK5NJPaW1j1c/txae+eUyNpPQb62rqSi1nRS0N+OY=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:In-Reply-To:References; b=fkpesDWTXxrl3kF1HKuDTAIijGOABng8DbXLyfuiABGXwGABHZ4A4hTsB4DWZhPNf ifhxYtgIunwNxye+zbchVh0iyYS/dMaKLmEna2u4zgOWcqsMAysXSE8qXQLaIHijWJ zq8pSDLT7gFV80vo9BqswROlRRZH45fMkuCmeAko= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from hermann.fritz.box ([77.183.82.216]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N6bfq-1k0oVv1bd0-018719; Sun, 20 Dec 2020 15:46:21 +0100 Date: Sun, 20 Dec 2020 15:46:12 +0100 From: "Hartmann, O." To: Li-Wen Hsu Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r368820 - head Message-ID: <20201220154612.44a61f72@hermann.fritz.box> In-Reply-To: <202012200259.0BK2xiGC074752@repo.freebsd.org> References: <202012200259.0BK2xiGC074752@repo.freebsd.org> Organization: walstatt.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/7C.yZbrzQe1aOAciZ2V0_5z"; protocol="application/pgp-signature"; micalg=pgp-sha256 X-Provags-ID: V03:K1:fWOkL6KqynVNovkINXwXdcJb33XxSTxY5//37siEqCK0VoUVuzx cvObIfJVUwlBtTlrAQVBawanZQjkI51l3BsXCcjhPqKlxqkbnQb7Xbz3mR22YO3khr1rabH PUPXg4fZy6FQyz6PCHZ2tIHv5ow4OhqErQFSVwt0jdC26wdeqDoqOymcgjqUKN9z5r+AdQA TbMbAwwQigIzCgIM0AL6g== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:2jfyYbZ21Qg=:jZIBgm0aQyDcakAfhFM7Av 794ogWCVZFNWNnsGHBCM2AICqspNJkNYmEfXt84ZZNXwbgpinfhYCn31ZCjmsFQNcj76ecov0 Tg2HfLLjyhrcxxD8pwvD1LoyakK4xa732GQuQy8kzw85O10bLMsnkrUzVrPU9XwnByTjyy1Yq pvKxVuceYkYK3A0jTRiJtsZWinxX6i8zXTX3tdxDBpZU51gFzeVIz2Ek5dch3Erzdo/STeU1w wgsivXcKRgm8mLl4+3/RF1a9j140HDwmwhbgEzG+wS3CdQ5My0f8QeBr9E3CUNonlAiIBVEFq 32LZmtwGjU0UsBWKsJ5orbkrMFx+jN3pU3idmK12/zDcBy68rGN4Tkh5IXNQ4XavTunv/Ujj1 6TpTzyMEQQFyVI5sLwCPa7ZSPH/PHhL+4nVo1rfEqIPWFPUNcTe5rBZWXEFD0S49usPj6g/Cm w8+WDTfSeI3HYSjwH1nPoBTFe4jM6tdxoJ2GzkPKeWCKaPsoNd1pqiNk5Bk15ud0fXIh0bEpz Db4W/gD4VV1x748gYL52lE+3pva4Z/i7VmFy1cOmi2cAErziEDlR+98FZZtRBYVm1bZX7gWpa tT0NW2fqFOWlbrIWCrp06JA2/oGzqEzAJ0PgT8Y2x7VmBmCI/nDbuo9593LmsTQ9FxL8tDSI1 X/k2ap1KofgfYnvSEIEVxLaYnbxstU+qi2l15mHgrM2ers+azAfp39JWjkgDc3JjnbEfCraXj W+6D0LqHnXw4Ihbyo7NA+YeDAdcDdciER6FWwdpeMWQpYax4mIXigIan7ITsggRR0MzeaYu3f OHee+lRVLtkcl2ay3HytTw1kv8Bv0xuE8XT+X7O9xdF1gyQhvQSeL3QsxrS4myUzoq2J5tdR2 JOd1pXrIhrqz6VczsE+A== X-Rspamd-Queue-Id: 4CzQQl4dsSz4sVp X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Dec 2020 14:46:24 -0000 --Sig_/7C.yZbrzQe1aOAciZ2V0_5z Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Sun, 20 Dec 2020 02:59:44 +0000 (UTC) Li-Wen Hsu wrote: > Author: lwhsu > Date: Sun Dec 20 02:59:44 2020 > New Revision: 368820 > URL: https://svnweb.freebsd.org/changeset/base/368820 >=20 > Log: > Mark the repository as being converted to Git. > =20 > This is the last Subversion commit to src. > =20 > Sponsored by: The FreeBSD Foundation >=20 > Modified: > head/README > head/README.md >=20 > Modified: head/README > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/README Sat Dec 19 22:04:46 2020 (r368819) > +++ head/README Sun Dec 20 02:59:44 2020 (r368820) > @@ -1,3 +1,5 @@ > +This repository is being converted from Subversion to Git. > + > This is the top level of the FreeBSD source directory. This file > was last revised on: > $FreeBSD$ >=20 > Modified: head/README.md > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/README.md Sat Dec 19 22:04:46 2020 (r368819) > +++ head/README.md Sun Dec 20 02:59:44 2020 (r368820) > @@ -1,3 +1,5 @@ > +This repository is being converted from Subversion to Git. > + > FreeBSD Source: > --------------- > This is the top level of the FreeBSD source directory. This file > _______________________________________________ > svn-src-head@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-head > To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org" Is this message of yours also the last message concerning the source change= s? Since then you published this message, no further logs ran into list svn-src-head@free= bsd.org. Kind regards, oh --Sig_/7C.yZbrzQe1aOAciZ2V0_5z Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iHUEARYIAB0WIQSy8IBxAPDkqVBaTJ44N1ZZPba5RwUCX99jtAAKCRA4N1ZZPba5 R2xzAQDbjvJ6lU5VOfOH3DqogsEeW/OAF62E+vg+GlkSeMXupwEA8J0lSCheoIiY cdbYU0rx02PSfod1PeyXs/2umy23zwo= =C02D -----END PGP SIGNATURE----- --Sig_/7C.yZbrzQe1aOAciZ2V0_5z-- From owner-svn-src-head@freebsd.org Sun Dec 20 14:55:11 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 189594C41A0; Sun, 20 Dec 2020 14:55:11 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CzQct72YSz4t8S; Sun, 20 Dec 2020 14:55:10 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: by mail-wr1-x433.google.com with SMTP id t16so8134078wra.3; Sun, 20 Dec 2020 06:55:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references:reply-to :mime-version:content-transfer-encoding; bh=5H2UAJLwVq4L+tE0vIXUv9F66gx6RmdcYoum37tVKxE=; b=Z9QCPGWk8L3/LL6PJPLe/xSgiQKv+ty+oEISHCqykoY4Zxqa2emPyfbVHY+JITNTRl GJLe2UDT/5HgIIMu9d+Huuog1sHmSOPh01WAOx7Mhvukx0LKcBcirkxfuglO9J/UJrTE /APbE8WTslI3CmG1RoAxVwRrrxnR7T+ojyY5M3oBkRswyUi2Br5eTq4I+wTE8fIs4QGe rwb9ZE+WmWflfnxLNPYOEf++qVJc4o0onTViVQ2vzAj1aP9rT1OYYmziNvkbs8UFEUYA vs4M0sBELouXRJzx1mkSyKkNfVGiPlWzaQQ60pBrRdk6ZQImfe0V1OLbZSgHJmhTVvnv cx+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:reply-to:mime-version:content-transfer-encoding; bh=5H2UAJLwVq4L+tE0vIXUv9F66gx6RmdcYoum37tVKxE=; b=oPAtPVQEJ7TtXo5VEDcLi2zwhUXZrzbMFGWTYmKkx3LF+Pd8JcxbFKVFuUhxzZPvhr 4BVE/kWupQQAqbvoCmLwGTIPm3nAljqnUgtyfpcPpXkLF9vb8sTAcBYwJor/5dvwspFQ qP8isJusAIegAxR9R5joML/vSrfkHQkNSAYOqlZ64LNy2nrA5+CWHQoYtyTLNppoG78z Pav4I4+1wkVJugtHyi55wURJ1d0BWXaCO9RdKYneG4wRPL27GR2hcJIRrLUhAp1QAYA/ 9hbbzqbHGVKqpkH1cPwF7M4ztM93w8DzNAFwk1csU6GF+IdbxgQRkdWoCqVZI0wFN9TW Y8dw== X-Gm-Message-State: AOAM531yDsP7ZtHru4gs6PCzfKUc+SJlbYlLm+mryBvssRDwGVY9j64L W6UModRxJDB0yNQkZcl+el8UPHDnD2c= X-Google-Smtp-Source: ABdhPJyg6lcgfUVVzTBkHwxjpAnnVIw9wVeVvgqaW1aYXW+Fjc7ZH62UpUtkcKgE0x2Lo68BL5bgHw== X-Received: by 2002:adf:a4cf:: with SMTP id h15mr14190052wrb.13.1608476108390; Sun, 20 Dec 2020 06:55:08 -0800 (PST) Received: from ernst.home (p5b02350e.dip0.t-ipconnect.de. [91.2.53.14]) by smtp.gmail.com with ESMTPSA id n14sm19748707wmi.1.2020.12.20.06.55.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Dec 2020 06:55:07 -0800 (PST) Date: Sun, 20 Dec 2020 15:55:06 +0100 From: Gary Jennejohn To: "Hartmann, O." Cc: Li-Wen Hsu , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r368820 - head Message-ID: <20201220145506.256ba79c@ernst.home> In-Reply-To: <20201220154612.44a61f72@hermann.fritz.box> References: <202012200259.0BK2xiGC074752@repo.freebsd.org> <20201220154612.44a61f72@hermann.fritz.box> Reply-To: gljennjohn@gmail.com X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; amd64-portbld-freebsd13.0) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4CzQct72YSz4t8S X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Dec 2020 14:55:11 -0000 On Sun, 20 Dec 2020 15:46:12 +0100 "Hartmann, O." wrote: > On Sun, 20 Dec 2020 02:59:44 +0000 (UTC) > Li-Wen Hsu wrote: > > > Author: lwhsu > > Date: Sun Dec 20 02:59:44 2020 > > New Revision: 368820 > > URL: https://svnweb.freebsd.org/changeset/base/368820 > > > > Log: > > Mark the repository as being converted to Git. > > > > This is the last Subversion commit to src. > > > > Sponsored by: The FreeBSD Foundation > > > > Modified: > > head/README > > head/README.md > > > > Modified: head/README > > ============================================================================== > > --- head/README Sat Dec 19 22:04:46 2020 (r368819) > > +++ head/README Sun Dec 20 02:59:44 2020 (r368820) > > @@ -1,3 +1,5 @@ > > +This repository is being converted from Subversion to Git. > > + > > This is the top level of the FreeBSD source directory. This file > > was last revised on: > > $FreeBSD$ > > > > Modified: head/README.md > > ============================================================================== > > --- head/README.md Sat Dec 19 22:04:46 2020 (r368819) > > +++ head/README.md Sun Dec 20 02:59:44 2020 (r368820) > > @@ -1,3 +1,5 @@ > > +This repository is being converted from Subversion to Git. > > + > > FreeBSD Source: > > --------------- > > This is the top level of the FreeBSD source directory. This file > > _______________________________________________ > > svn-src-head@freebsd.org mailing list > > https://lists.freebsd.org/mailman/listinfo/svn-src-head > > To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org" > > Is this message of yours also the last message concerning the source changes? Since then > you published this message, no further logs ran into list svn-src-head@freebsd.org. > Take a look at this https://wiki.freebsd.org/git. Write access to Subversion has been disabled. -- Gary Jennejohn From owner-svn-src-head@freebsd.org Mon Dec 21 14:24:27 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4138F4BBF4C; Mon, 21 Dec 2020 14:24:27 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4D01ty6n3Jz3QDt; Mon, 21 Dec 2020 14:24:26 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1]) by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id 0BLEOIBE042174; Mon, 21 Dec 2020 06:24:18 -0800 (PST) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: (from freebsd@localhost) by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id 0BLEOIT9042173; Mon, 21 Dec 2020 06:24:18 -0800 (PST) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <202012211424.0BLEOIT9042173@gndrsh.dnsmgr.net> Subject: Re: svn commit: r368820 - head In-Reply-To: <20201220145506.256ba79c@ernst.home> To: gljennjohn@gmail.com Date: Mon, 21 Dec 2020 06:24:18 -0800 (PST) CC: "Hartmann, O." , Li-Wen Hsu , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 4D01ty6n3Jz3QDt X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Dec 2020 14:24:27 -0000 > On Sun, 20 Dec 2020 15:46:12 +0100 > "Hartmann, O." wrote: > > > On Sun, 20 Dec 2020 02:59:44 +0000 (UTC) > > Li-Wen Hsu wrote: > > > > > Author: lwhsu > > > Date: Sun Dec 20 02:59:44 2020 > > > New Revision: 368820 > > > URL: https://svnweb.freebsd.org/changeset/base/368820 > > > > > > Log: > > > Mark the repository as being converted to Git. > > > > > > This is the last Subversion commit to src. > > > > > > Sponsored by: The FreeBSD Foundation > > > > > > Modified: > > > head/README > > > head/README.md > > > > > > Modified: head/README > > > ============================================================================== > > > --- head/README Sat Dec 19 22:04:46 2020 (r368819) > > > +++ head/README Sun Dec 20 02:59:44 2020 (r368820) > > > @@ -1,3 +1,5 @@ > > > +This repository is being converted from Subversion to Git. > > > + > > > This is the top level of the FreeBSD source directory. This file > > > was last revised on: > > > $FreeBSD$ > > > > > > Modified: head/README.md > > > ============================================================================== > > > --- head/README.md Sat Dec 19 22:04:46 2020 (r368819) > > > +++ head/README.md Sun Dec 20 02:59:44 2020 (r368820) > > > @@ -1,3 +1,5 @@ > > > +This repository is being converted from Subversion to Git. > > > + > > > FreeBSD Source: > > > --------------- > > > This is the top level of the FreeBSD source directory. This file > > > _______________________________________________ > > > svn-src-head@freebsd.org mailing list > > > https://lists.freebsd.org/mailman/listinfo/svn-src-head > > > To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org" > > > > Is this message of yours also the last message concerning the source changes? Since then > > you published this message, no further logs ran into list svn-src-head@freebsd.org. > > > > Take a look at this https://wiki.freebsd.org/git. Write access to > Subversion has been disabled. I think the bigger question is why as a committer have I not seen ANY commits to git since this cut over? Is it a) none have happened in 24 hours, or b) commit mail is no longer going to developers as it use to? > -- > Gary Jennejohn > -- Rod Grimes rgrimes@freebsd.org From owner-svn-src-head@freebsd.org Mon Dec 21 14:26:16 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 56BE74BBB77; Mon, 21 Dec 2020 14:26:16 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4D01x41wxwz3QKf; Mon, 21 Dec 2020 14:26:16 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-qt1-f171.google.com (mail-qt1-f171.google.com [209.85.160.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 307C76AE; Mon, 21 Dec 2020 14:26:16 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-qt1-f171.google.com with SMTP id y15so6655979qtv.5; Mon, 21 Dec 2020 06:26:16 -0800 (PST) X-Gm-Message-State: AOAM5307XzD5fKUZ0gOhvuL8TF9Yyoj7bUsm11RfRzCHbL8EcUFXaS59 LUbyXPWQm5TJgEChCVVdtBHPkl7mq8PVIFuDCW8= X-Google-Smtp-Source: ABdhPJzuQwNUf1rWkEQB/mgMtuevYxGa0PU/6C0cD+/QVYu0d4F1w5uMwa5x1kPq4nZZ8NWoKVD4KKgRYNy+b33a39A= X-Received: by 2002:ac8:44cb:: with SMTP id b11mr16284210qto.60.1608560775577; Mon, 21 Dec 2020 06:26:15 -0800 (PST) MIME-Version: 1.0 References: <20201220145506.256ba79c@ernst.home> <202012211424.0BLEOIT9042173@gndrsh.dnsmgr.net> In-Reply-To: <202012211424.0BLEOIT9042173@gndrsh.dnsmgr.net> From: Kyle Evans Date: Mon, 21 Dec 2020 08:26:02 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r368820 - head To: "Rodney W. Grimes" Cc: Gary Jennejohn , "Hartmann, O." , Li-Wen Hsu , src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Dec 2020 14:26:16 -0000 On Mon, Dec 21, 2020 at 8:24 AM Rodney W. Grimes wrote: > > > On Sun, 20 Dec 2020 15:46:12 +0100 > > "Hartmann, O." wrote: > > > > > On Sun, 20 Dec 2020 02:59:44 +0000 (UTC) > > > Li-Wen Hsu wrote: > > > > > > > Author: lwhsu > > > > Date: Sun Dec 20 02:59:44 2020 > > > > New Revision: 368820 > > > > URL: https://svnweb.freebsd.org/changeset/base/368820 > > > > > > > > Log: > > > > Mark the repository as being converted to Git. > > > > > > > > This is the last Subversion commit to src. > > > > > > > > Sponsored by: The FreeBSD Foundation > > > > > > > > Modified: > > > > head/README > > > > head/README.md > > > > > > > > Modified: head/README > > > > ============================================================================== > > > > --- head/README Sat Dec 19 22:04:46 2020 (r368819) > > > > +++ head/README Sun Dec 20 02:59:44 2020 (r368820) > > > > @@ -1,3 +1,5 @@ > > > > +This repository is being converted from Subversion to Git. > > > > + > > > > This is the top level of the FreeBSD source directory. This file > > > > was last revised on: > > > > $FreeBSD$ > > > > > > > > Modified: head/README.md > > > > ============================================================================== > > > > --- head/README.md Sat Dec 19 22:04:46 2020 (r368819) > > > > +++ head/README.md Sun Dec 20 02:59:44 2020 (r368820) > > > > @@ -1,3 +1,5 @@ > > > > +This repository is being converted from Subversion to Git. > > > > + > > > > FreeBSD Source: > > > > --------------- > > > > This is the top level of the FreeBSD source directory. This file > > > > _______________________________________________ > > > > svn-src-head@freebsd.org mailing list > > > > https://lists.freebsd.org/mailman/listinfo/svn-src-head > > > > To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org" > > > > > > Is this message of yours also the last message concerning the source changes? Since then > > > you published this message, no further logs ran into list svn-src-head@freebsd.org. > > > > > > > Take a look at this https://wiki.freebsd.org/git. Write access to > > Subversion has been disabled. > > I think the bigger question is why as a committer have I not seen ANY > commits to git since this cut over? Is it a) none have happened in 24 hours, > or b) commit mail is no longer going to developers as it use to? > According to the wiki, the repo conversion is not yet done so no commits have been made. =) From owner-svn-src-head@freebsd.org Mon Dec 21 14:28:27 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A9F494BC060 for ; Mon, 21 Dec 2020 14:28:27 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-qv1-xf2c.google.com (mail-qv1-xf2c.google.com [IPv6:2607:f8b0:4864:20::f2c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4D01zb3vXNz3Q9V for ; Mon, 21 Dec 2020 14:28:27 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: by mail-qv1-xf2c.google.com with SMTP id a13so4484089qvv.0 for ; Mon, 21 Dec 2020 06:28:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=rGCqVz6Hy8h5p3x98ydv5D/NEizYq1csnsjghx2rKkY=; b=b1Y9hD5UD2uggPLRLIb1tCLaL+GhXFeWnfhcv8neEj5jfT969NiG4FloKtlkgM/QFu J9D9fbhOTGD3m8CD5s+cUHQDh2V0EF7RlEQi9oZJdS4sv0jZm7Tu8P3vm7jPzW3BTEw1 C4aYF9zWQ2K+R+geXmtVFeNhgZy3m8mcQBIoyQ0gS6tvIXNXO5wx3m9CdaZcloXJBhqx ONvgRGG7I8zKBCa02Cq65UhgkVci3wZKC//GazOPDnn2tQJ8ZuwxXtcTV8SfnQJxdVao 25qi5DRhkxrhAj5rkfUzNCKQnQEZqSEhIB2jgSGntli2Yu2+Zqi+aX8kMZJ2QkjAB9On 1tEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=rGCqVz6Hy8h5p3x98ydv5D/NEizYq1csnsjghx2rKkY=; b=OLrebQVhR469P0NpKG4SzUJtq3a/2jveSflJumSzy8KqZyu+xLnSEgIoLF6qEM7UZL snEj384m5qGMxvZyn7w5AGGX8jWjk5RZU1ggF/dkxSVpFbkwFErzGEGCB1ocMP3UZCoI WR9kZEcL9Cpt7gTRVFz+MwAWu4n+2HG9gYG/rjV5XVoThz2wdA42njYKhTMGx1pgfY/K x5w6LXGaMcVrK1tIjCeKbcGBWPJ6ID00Fsfrv9HsxzuQ4Y7gpv9EuV9Wkscvm5392Yx8 ogznSK6AUIHKP6F5CrNHRCixPOaB8rAJ4xiYsT9KZ/ctddTeRQryrhPkjJOwsBja5LSa a0zw== X-Gm-Message-State: AOAM5331E/RGw2SZ/kVHRhQ1H5Hiwot4s0qNTiX3BKB5FqidFx5xXVTG IkJPLaxmtXv7+GiycOsYMFq3Uw== X-Google-Smtp-Source: ABdhPJxWOtcY40EMq//IdIM4XYS6m2wTk9zuW/g4G9P/MBJFDfaG17fM3yH3slDYqjt7gBp3Mx3vTQ== X-Received: by 2002:ad4:56ab:: with SMTP id bd11mr17211432qvb.53.1608560906698; Mon, 21 Dec 2020 06:28:26 -0800 (PST) Received: from mutt-hbsd (pool-100-16-222-53.bltmmd.fios.verizon.net. [100.16.222.53]) by smtp.gmail.com with ESMTPSA id v196sm5533024qkb.84.2020.12.21.06.28.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Dec 2020 06:28:25 -0800 (PST) Date: Mon, 21 Dec 2020 09:28:25 -0500 From: Shawn Webb To: Kyle Evans Cc: "Rodney W. Grimes" , Gary Jennejohn , "Hartmann, O." , Li-Wen Hsu , src-committers , svn-src-all , svn-src-head Subject: Re: svn commit: r368820 - head Message-ID: <20201221142825.sxgjtkkjeybiaxvf@mutt-hbsd> X-Operating-System: FreeBSD mutt-hbsd 13.0-CURRENT-HBSD FreeBSD 13.0-CURRENT-HBSD X-PGP-Key: http://pgp.mit.edu/pks/lookup?op=vindex&search=0xFF2E67A277F8E1FA References: <20201220145506.256ba79c@ernst.home> <202012211424.0BLEOIT9042173@gndrsh.dnsmgr.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="emnowlfzkotokng4" Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4D01zb3vXNz3Q9V X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Dec 2020 14:28:27 -0000 --emnowlfzkotokng4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 21, 2020 at 08:26:02AM -0600, Kyle Evans wrote: > On Mon, Dec 21, 2020 at 8:24 AM Rodney W. Grimes > wrote: > > > > > On Sun, 20 Dec 2020 15:46:12 +0100 > > > "Hartmann, O." wrote: > > > > > > > On Sun, 20 Dec 2020 02:59:44 +0000 (UTC) > > > > Li-Wen Hsu wrote: > > > > > > > > > Author: lwhsu > > > > > Date: Sun Dec 20 02:59:44 2020 > > > > > New Revision: 368820 > > > > > URL: https://svnweb.freebsd.org/changeset/base/368820 > > > > > > > > > > Log: > > > > > Mark the repository as being converted to Git. > > > > > > > > > > This is the last Subversion commit to src. > > > > > > > > > > Sponsored by: The FreeBSD Foundation > > > > > > > > > > Modified: > > > > > head/README > > > > > head/README.md > > > > > > > > > > Modified: head/README > > > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D > > > > > --- head/README Sat Dec 19 22:04:46 2020 (r368819) > > > > > +++ head/README Sun Dec 20 02:59:44 2020 (r368820) > > > > > @@ -1,3 +1,5 @@ > > > > > +This repository is being converted from Subversion to Git. > > > > > + > > > > > This is the top level of the FreeBSD source directory. This file > > > > > was last revised on: > > > > > $FreeBSD$ > > > > > > > > > > Modified: head/README.md > > > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D > > > > > --- head/README.md Sat Dec 19 22:04:46 2020 (r36881= 9) > > > > > +++ head/README.md Sun Dec 20 02:59:44 2020 (r36882= 0) > > > > > @@ -1,3 +1,5 @@ > > > > > +This repository is being converted from Subversion to Git. > > > > > + > > > > > FreeBSD Source: > > > > > --------------- > > > > > This is the top level of the FreeBSD source directory. This file > > > > > _______________________________________________ > > > > > svn-src-head@freebsd.org mailing list > > > > > https://lists.freebsd.org/mailman/listinfo/svn-src-head > > > > > To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebs= d.org" > > > > > > > > Is this message of yours also the last message concerning the sourc= e changes? Since then > > > > you published this message, no further logs ran into list svn-src-h= ead@freebsd.org. > > > > > > > > > > Take a look at this https://wiki.freebsd.org/git. Write access to > > > Subversion has been disabled. > > > > I think the bigger question is why as a committer have I not seen ANY > > commits to git since this cut over? Is it a) none have happened in 24 = hours, > > or b) commit mail is no longer going to developers as it use to? > > >=20 > According to the wiki, the repo conversion is not yet done so no > commits have been made. =3D) And for those who don't know, the wiki page to pay attention to is: https://wiki.freebsd.org/git Thanks, --=20 Shawn Webb Cofounder / Security Engineer HardenedBSD GPG Key ID: 0xFF2E67A277F8E1FA GPG Key Fingerprint: D206 BB45 15E0 9C49 0CF9 3633 C85B 0AF8 AB23 0FB2 https://git-01.md.hardenedbsd.org/HardenedBSD/pubkeys/src/branch/master/Sha= wn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc --emnowlfzkotokng4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAl/gsP8ACgkQ/y5nonf4 4foHzQ//czVYnRytm8v5IqkSIpy66F3AcooS8kurWMggMRAZG4UUfNbE6gGfvb3e mw42V6sQ8ifZJv4bk8nRCIcL93SzCylTBjTrgqirbHZwaXQLTCJIrlVex5VLNbiR Rrj7zYtNSf1XTY24a8Zg5vtCOAiwnT3V7JqF5w87GyYxy7+NBELnKTJas+VACQUO n3AJ+6eU3v68zlcD1m8O9liP/gR+QOUHzyULD+RjcyoOptul+g/rFz7rm/qJZEeJ FYoUh0R55afbypdw3Iat4Bhluc0DggNY9iStWrK/VPkF9Oa8zrik8G5+L4rvUHrq Q0M1utLVEw5X1c2bY/HxTqO0JULLDyFB/T7r6tOFAG1glFMzWf5CcivWX5g0Dr8D 7EqRykoh3d7OF132hE103ZkiRuApMfcK4hGYuCRvxLSE42ss+WdOboUHZsXo2NLV 03ACGH/zwo6tuLVKfotlAiYuF5QW8BUSiGqqOMdMtRDw0ccrZVFMpndDsz0S5HZc Uwk0+MfYChx7sOjOlC0vIxJ3M5n+iuh1dBnuBa678vWGakcTDDnnxp80x1Dq4CAi UA/vR9oIbQmzPeVGXJIvbjvkIZEoOnmSetk3sCyaNAiQu7Q1rnKUks1qHeENcvSj qdiFsV/uIq/wZn7ONCdS/0T6iuAUSnBrrE5KNDissAHWx47swc0= =lFKH -----END PGP SIGNATURE----- --emnowlfzkotokng4-- From owner-svn-src-head@freebsd.org Mon Dec 21 17:31:09 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 19A944C0426; Mon, 21 Dec 2020 17:31:09 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4D062P03nrz3rq6; Mon, 21 Dec 2020 17:31:09 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro.local (unknown [IPv6:2601:648:8681:1cb0:bcde:28e8:6746:f87e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 43ECF227B; Mon, 21 Dec 2020 17:31:08 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Subject: Re: svn commit: r368789 - head/libexec/rtld-elf/rtld-libc To: Ryan Libby Cc: src-committers , svn-src-all , svn-src-head , Konstantin Belousov , Alex Richardson References: <202012190838.0BJ8cVJ3064816@repo.freebsd.org> <47e9db0f-14b4-0a0d-45c4-7e466e69711f@FreeBSD.org> From: John Baldwin Autocrypt: addr=jhb@FreeBSD.org; keydata= mQGiBETQ+XcRBADMFybiq69u+fJRy/0wzqTNS8jFfWaBTs5/OfcV7wWezVmf9sgwn8TW0Dk0 c9MBl0pz+H01dA2ZSGZ5fXlmFIsee1WEzqeJzpiwd/pejPgSzXB9ijbLHZ2/E0jhGBcVy5Yo /Tw5+U/+laeYKu2xb0XPvM0zMNls1ah5OnP9a6Ql6wCgupaoMySb7DXm2LHD1Z9jTsHcAQMD /1jzh2BoHriy/Q2s4KzzjVp/mQO5DSm2z14BvbQRcXU48oAosHA1u3Wrov6LfPY+0U1tG47X 1BGfnQH+rNAaH0livoSBQ0IPI/8WfIW7ub4qV6HYwWKVqkDkqwcpmGNDbz3gfaDht6nsie5Z pcuCcul4M9CW7Md6zzyvktjnbz61BADGDCopfZC4of0Z3Ka0u8Wik6UJOuqShBt1WcFS8ya1 oB4rc4tXfSHyMF63aPUBMxHR5DXeH+EO2edoSwViDMqWk1jTnYza51rbGY+pebLQOVOxAY7k do5Ordl3wklBPMVEPWoZ61SdbcjhHVwaC5zfiskcxj5wwXd2E9qYlBqRg7QeSm9obiBCYWxk d2luIDxqaGJARnJlZUJTRC5vcmc+iGAEExECACAFAkTQ+awCGwMGCwkIBwMCBBUCCAMEFgID AQIeAQIXgAAKCRBy3lIGd+N/BI6RAJ9S97fvbME+3hxzE3JUyUZ6vTewDACdE1stFuSfqMvM jomvZdYxIYyTUpC5Ag0ERND5ghAIAPwsO0B7BL+bz8sLlLoQktGxXwXQfS5cInvL17Dsgnr3 1AKa94j9EnXQyPEj7u0d+LmEe6CGEGDh1OcGFTMVrof2ZzkSy4+FkZwMKJpTiqeaShMh+Goj XlwIMDxyADYvBIg3eN5YdFKaPQpfgSqhT+7El7w+wSZZD8pPQuLAnie5iz9C8iKy4/cMSOrH YUK/tO+Nhw8Jjlw94Ik0T80iEhI2t+XBVjwdfjbq3HrJ0ehqdBwukyeJRYKmbn298KOFQVHO EVbHA4rF/37jzaMadK43FgJ0SAhPPF5l4l89z5oPu0b/+5e2inA3b8J3iGZxywjM+Csq1tqz hltEc7Q+E08AAwUIAL+15XH8bPbjNJdVyg2CMl10JNW2wWg2Q6qdljeaRqeR6zFus7EZTwtX sNzs5bP8y51PSUDJbeiy2RNCNKWFMndM22TZnk3GNG45nQd4OwYK0RZVrikalmJY5Q6m7Z16 4yrZgIXFdKj2t8F+x613/SJW1lIr9/bDp4U9tw0V1g3l2dFtD3p3ZrQ3hpoDtoK70ioIAjjH aIXIAcm3FGZFXy503DOA0KaTWwvOVdYCFLm3zWuSOmrX/GsEc7ovasOWwjPn878qVjbUKWwx Q4QkF4OhUV9zPtf9tDSAZ3x7QSwoKbCoRCZ/xbyTUPyQ1VvNy/mYrBcYlzHodsaqUDjHuW+I SQQYEQIACQUCRND5ggIbDAAKCRBy3lIGd+N/BCO8AJ9j1dWVQWxw/YdTbEyrRKOY8YZNwwCf afMAg8QvmOWnHx3wl8WslCaXaE8= Message-ID: Date: Mon, 21 Dec 2020 09:31:06 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Dec 2020 17:31:09 -0000 On 12/19/20 8:27 PM, Ryan Libby wrote: > On Sat, Dec 19, 2020 at 7:23 PM John Baldwin wrote: >> >> On 12/19/20 12:38 AM, Ryan Libby wrote: >>> Author: rlibby >>> Date: Sat Dec 19 08:38:31 2020 >>> New Revision: 368789 >>> URL: https://svnweb.freebsd.org/changeset/base/368789 >>> >>> Log: >>> rtld-elf: link udivmoddi4 from compiler_rt >>> >>> This fixes the gcc9 build of rtld-elf32 on amd64, which needed an >>> implementation of udivmoddi4. >>> >>> rtld-elf uses certain functions normally found in libc, and so it >>> includes certain files from libc in its own build. It has two >>> mechanisms to include files from libc: one that rebuilds source files in >>> the rtld-elf environment, and one that extracts object files from a >>> purpose-built no-SSP PIC archive. >>> >>> In addition to libc functions, rtld-elf may need to link functions >>> normally found in libcompiler_rt (formerly libgcc). Now, add an ability >>> to rebuild libcompiler_rt source files in the rtld-elf environment. We >>> don't yet have a need for an object file extraction mechanism. >>> >>> libcompiler_rt could also supply udivdi3 and umoddi3, but leave them >>> alone for now. >>> >>> Reviewed by: arichardson, kib >>> Sponsored by: Dell EMC Isilon >>> Differential Revision: https://reviews.freebsd.org/D27665 >> >> Hmm, I had just linked against libcompiler_rt directly as we do on arm: >> >> https://reviews.freebsd.org/D26199 >> >> It was stuck waiting for review feedback. >> >> Given libcompiler_rt is a static archive, we could probably safely link >> against it directly unlike libc where we have to pick specific object >> files. >> >> -- >> John Baldwin > > Sorry, I wasn't aware of your review. Do you want this backed out? No. I do have other patches you can see in that review stack that might be relevant for GCC 9. Some of them I should push as they've been reviewed, but not all of them are ok'd I think. > I did see the arm path. I think it is not quite right, because > libcompiler_rt is compiled with -fstack-protector-strong, which is not > compatible with rtld. However, it will work in practice if stack > protection doesn't actually get used on any linked function. Hmm, ok. I think it's fine to use the current approach then, and perhaps fix arm to match it and keep SSP out of rtld. -- John Baldwin From owner-svn-src-head@freebsd.org Tue Dec 22 18:31:15 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7CED64C4447; Tue, 22 Dec 2020 18:31:15 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4D0lKG4P0fz4k5D; Tue, 22 Dec 2020 18:31:14 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by mail-wm1-x333.google.com with SMTP id g185so3049735wmf.3; Tue, 22 Dec 2020 10:31:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=g86msX2Ng3AkhFkpAiMvqyvrNr1K59Lhqu4WLVCUmMc=; b=kTnnehHrg8PkpxVt21sz92cBAPY1Oap8dvOAKIVVRu9OlCDmtaMNT/xwYXAwM5yuI/ Yl5JtF0UGXTC14ngblwuCySBin6kTeCiR1KUJwUM2ap7Gvfr+qlLTvz3gcUAVTH0wnQz cIF0p+S2JjJiNOlXEBe2fg9J5JGhQL7/V9BJVo0VF+hNTUOrgodsf17wveTcZb0+8Phh 8FlcIaVcZ5mqBDqoqO467AHrgm0DK3Q7K2FKSph07z1HK/lwHvtXjgabzALMsiVAIZVK eAQ1/b0xT0AeXCSsUVCc0sJ7ySYB+QixYCll0iRmgUXXqMt8LsgWKCM22luwMgR4+0Bq CYWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=g86msX2Ng3AkhFkpAiMvqyvrNr1K59Lhqu4WLVCUmMc=; b=sJDHRYdGwETb7vRM+VIp+W+7baeCcpEb2JTA3J7akI0zI52Lq44NDonyG5W2MgYUV6 5WhEMA7kpIFKgRCUWP+LznF5w7MLz7KbI4eWARHuQT5J+IMMmrxk1rGkcEWO3uqk998K 1Rt5qXLH0KkkOTwUtBC3vEa7B5Ml7ASJLooe58P34mIG8H7m2gJ//nZ/KcGhS5LsGvck ZTyAIBYNkeOg8Wh9zWJQZmExywMM6BSpmexRwhjeGQe5l8FOWl+uNngvjsvJEndq+Q8o 3ALjAU/7/Ds0LlKr2e32okeJARNg1kJOHGgd2YCKLZrmVjmBi8BxuST039Arq9DJC3X7 6X1A== X-Gm-Message-State: AOAM532qqzMVNEyZG9R4GNInTmeEijJWQJ6K/mIdOl/rwsR51YqTYXVT YREvDTJy+obYcqa0+dRan17rJhr8N/xkHSri8HaVLSLEpJI= X-Google-Smtp-Source: ABdhPJyyhYi7ad2iUrcQ6hqmurimAPs0K2yO47m4kXd7XUkwwAdwOm7ttYEXkCCyJdJPA3eplafIQfmEePNnWm+VKI0= X-Received: by 2002:a1c:4156:: with SMTP id o83mr23030449wma.178.1608661871876; Tue, 22 Dec 2020 10:31:11 -0800 (PST) MIME-Version: 1.0 Received: by 2002:adf:f811:0:0:0:0:0 with HTTP; Tue, 22 Dec 2020 10:31:09 -0800 (PST) In-Reply-To: <202012182200.0BIM0vIt062121@repo.freebsd.org> References: <202012182200.0BIM0vIt062121@repo.freebsd.org> From: Mateusz Guzik Date: Tue, 22 Dec 2020 19:31:09 +0100 Message-ID: Subject: Re: svn commit: r368769 - head/sys/net To: "Alexander V. Chernikov" Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4D0lKG4P0fz4k5D X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=kTnnehHr; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of mjguzik@gmail.com designates 2a00:1450:4864:20::333 as permitted sender) smtp.mailfrom=mjguzik@gmail.com X-Spamd-Result: default: False [-2.00 / 15.00]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; FREEMAIL_FROM(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36]; RBL_DBL_DONT_QUERY_IPS(0.00)[2a00:1450:4864:20::333:from]; TO_DN_SOME(0.00)[]; NEURAL_SPAM_SHORT(1.00)[1.000]; SPAMHAUS_ZRD(0.00)[2a00:1450:4864:20::333:from:127.0.2.255]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::333:from]; NEURAL_HAM_LONG(-1.00)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; MAILMAN_DEST(0.00)[svn-src-all,svn-src-head]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Dec 2020 18:31:15 -0000 this makes NOIP kernels fail to compile: /usr/src/sys/net/rtsock.c:802:11: error: unused variable 'scopeid' [-Werror,-Wunused-variable] uint32_t scopeid = 0; On 12/18/20, Alexander V. Chernikov wrote: > Author: melifaro > Date: Fri Dec 18 22:00:57 2020 > New Revision: 368769 > URL: https://svnweb.freebsd.org/changeset/base/368769 > > Log: > Switch direct rt fields access in rtsock.c to newly-create field > acessors. > > rtsock code was build around the assumption that each rtentry record > in the system radix tree is a ready-to-use sockaddr. This assumptions > turned out to be not quite true: > * masks have their length tweaked, so we have rtsock_fix_netmask() hack > * IPv6 addresses have their scope embedded, so we have another explicit > deembedding hack. > > Change the code to decouple rtentry internals from rtsock code using > newly-created rtentry accessors. This will allow to eventually eliminate > both of the hacks and change rtentry dst/mask format. > > Differential Revision: https://reviews.freebsd.org/D27451 > > Modified: > head/sys/net/rtsock.c > > Modified: head/sys/net/rtsock.c > ============================================================================== > --- head/sys/net/rtsock.c Fri Dec 18 20:41:23 2020 (r368768) > +++ head/sys/net/rtsock.c Fri Dec 18 22:00:57 2020 (r368769) > @@ -158,10 +158,13 @@ MTX_SYSINIT(rtsock, &rtsock_mtx, "rtsock route_cb > lock > SYSCTL_NODE(_net, OID_AUTO, route, CTLFLAG_RD | CTLFLAG_MPSAFE, 0, ""); > > struct walkarg { > + int family; > int w_tmemsize; > int w_op, w_arg; > caddr_t w_tmem; > struct sysctl_req *w_req; > + struct sockaddr *dst; > + struct sockaddr *mask; > }; > > static void rts_input(struct mbuf *m); > @@ -170,7 +173,7 @@ static int rtsock_msg_buffer(int type, struct rt_addri > struct walkarg *w, int *plen); > static int rt_xaddrs(caddr_t cp, caddr_t cplim, > struct rt_addrinfo *rtinfo); > -static int sysctl_dumpentry(struct radix_node *rn, void *vw); > +static int sysctl_dumpentry(struct rtentry *rt, void *vw); > static int sysctl_dumpnhop(struct rtentry *rt, struct nhop_object *nh, > uint32_t weight, struct walkarg *w); > static int sysctl_iflist(int af, struct walkarg *w); > @@ -187,7 +190,8 @@ static int update_rtm_from_rc(struct rt_addrinfo *info > static void send_rtm_reply(struct socket *so, struct rt_msghdr *rtm, > struct mbuf *m, sa_family_t saf, u_int fibnum, > int rtm_errno); > -static int can_export_rte(struct ucred *td_ucred, const struct rtentry > *rt); > +static bool can_export_rte(struct ucred *td_ucred, bool rt_is_host, > + const struct sockaddr *rt_dst); > > static struct netisr_handler rtsock_nh = { > .nh_name = "rtsock", > @@ -707,7 +711,7 @@ handle_rtm_get(struct rt_addrinfo *info, u_int fibnum, > return (ESRCH); > } > > - nh = select_nhop(rc->rc_rt->rt_nhop, info->rti_info[RTAX_GATEWAY]); > + nh = select_nhop(rt_get_raw_nhop(rc->rc_rt), > info->rti_info[RTAX_GATEWAY]); > if (nh == NULL) { > RIB_RUNLOCK(rnh); > return (ESRCH); > @@ -721,9 +725,7 @@ handle_rtm_get(struct rt_addrinfo *info, u_int fibnum, > */ > if (rtm->rtm_flags & RTF_ANNOUNCE) { > struct sockaddr laddr; > - struct nhop_object *nh; > > - nh = rc->rc_rt->rt_nhop; > if (nh->nh_ifp != NULL && > nh->nh_ifp->if_type == IFT_PROPVIRTUAL) { > struct ifaddr *ifa; > @@ -747,7 +749,7 @@ handle_rtm_get(struct rt_addrinfo *info, u_int fibnum, > RIB_RUNLOCK(rnh); > return (ESRCH); > } > - nh = select_nhop(rc->rc_rt->rt_nhop, info->rti_info[RTAX_GATEWAY]); > + nh = select_nhop(rt_get_raw_nhop(rc->rc_rt), > info->rti_info[RTAX_GATEWAY]); > if (nh == NULL) { > RIB_RUNLOCK(rnh); > return (ESRCH); > @@ -760,6 +762,66 @@ handle_rtm_get(struct rt_addrinfo *info, u_int fibnum, > return (0); > } > > +static void > +init_sockaddrs_family(int family, struct sockaddr *dst, struct sockaddr > *mask) > +{ > +#ifdef INET > + if (family == AF_INET) { > + struct sockaddr_in *dst4 = (struct sockaddr_in *)dst; > + struct sockaddr_in *mask4 = (struct sockaddr_in *)mask; > + > + bzero(dst4, sizeof(struct sockaddr_in)); > + bzero(mask4, sizeof(struct sockaddr_in)); > + > + dst4->sin_family = AF_INET; > + dst4->sin_len = sizeof(struct sockaddr_in); > + mask4->sin_family = AF_INET; > + mask4->sin_len = sizeof(struct sockaddr_in); > + } > +#endif > +#ifdef INET6 > + if (family == AF_INET6) { > + struct sockaddr_in6 *dst6 = (struct sockaddr_in6 *)dst; > + struct sockaddr_in6 *mask6 = (struct sockaddr_in6 *)mask; > + > + bzero(dst6, sizeof(struct sockaddr_in6)); > + bzero(mask6, sizeof(struct sockaddr_in6)); > + > + dst6->sin6_family = AF_INET6; > + dst6->sin6_len = sizeof(struct sockaddr_in6); > + mask6->sin6_family = AF_INET6; > + mask6->sin6_len = sizeof(struct sockaddr_in6); > + } > +#endif > +} > + > +static void > +export_rtaddrs(const struct rtentry *rt, struct sockaddr *dst, > + struct sockaddr *mask) > +{ > + uint32_t scopeid = 0; > +#ifdef INET > + if (dst->sa_family == AF_INET) { > + struct sockaddr_in *dst4 = (struct sockaddr_in *)dst; > + struct sockaddr_in *mask4 = (struct sockaddr_in *)mask; > + rt_get_inet_prefix_pmask(rt, &dst4->sin_addr, &mask4->sin_addr, > + &scopeid); > + return; > + } > +#endif > +#ifdef INET6 > + if (dst->sa_family == AF_INET6) { > + struct sockaddr_in6 *dst6 = (struct sockaddr_in6 *)dst; > + struct sockaddr_in6 *mask6 = (struct sockaddr_in6 *)mask; > + rt_get_inet6_prefix_pmask(rt, &dst6->sin6_addr, &mask6->sin6_addr, > + &scopeid); > + dst6->sin6_scope_id = scopeid; > + return; > + } > +#endif > +} > + > + > /* > * Update sockaddrs, flags, etc in @prtm based on @rc data. > * rtm can be reallocated. > @@ -772,7 +834,6 @@ static int > update_rtm_from_rc(struct rt_addrinfo *info, struct rt_msghdr **prtm, > int alloc_len, struct rib_cmd_info *rc, struct nhop_object *nh) > { > - struct sockaddr_storage netmask_ss; > struct walkarg w; > union sockaddr_union saun; > struct rt_msghdr *rtm, *orig_rtm = NULL; > @@ -780,11 +841,14 @@ update_rtm_from_rc(struct rt_addrinfo *info, struct > rt > int error, len; > > rtm = *prtm; > + union sockaddr_union sa_dst, sa_mask; > + int family = info->rti_info[RTAX_DST]->sa_family; > + init_sockaddrs_family(family, &sa_dst.sa, &sa_mask.sa); > + export_rtaddrs(rc->rc_rt, &sa_dst.sa, &sa_mask.sa); > > - info->rti_info[RTAX_DST] = rt_key(rc->rc_rt); > + info->rti_info[RTAX_DST] = &sa_dst.sa; > + info->rti_info[RTAX_NETMASK] = rt_is_host(rc->rc_rt) ? NULL : > &sa_mask.sa; > info->rti_info[RTAX_GATEWAY] = &nh->gw_sa; > - info->rti_info[RTAX_NETMASK] = rtsock_fix_netmask(rt_key(rc->rc_rt), > - rt_mask(rc->rc_rt), &netmask_ss); > info->rti_info[RTAX_GENMASK] = 0; > ifp = nh->nh_ifp; > if (rtm->rtm_addrs & (RTA_IFP | RTA_IFA)) { > @@ -994,7 +1058,9 @@ route_output(struct mbuf *m, struct socket *so, ...) > nh = rc.rc_nh_new; > > report: > - if (!can_export_rte(curthread->td_ucred, rc.rc_rt)) { > + if (!can_export_rte(curthread->td_ucred, > + info.rti_info[RTAX_NETMASK] == NULL, > + info.rti_info[RTAX_DST])) { > senderr(ESRCH); > } > > @@ -1730,35 +1796,34 @@ rt_dispatch(struct mbuf *m, sa_family_t saf) > * > * Returns 1 if it can, 0 otherwise. > */ > -static int > -can_export_rte(struct ucred *td_ucred, const struct rtentry *rt) > +static bool > +can_export_rte(struct ucred *td_ucred, bool rt_is_host, > + const struct sockaddr *rt_dst) > { > > - if ((rt->rte_flags & RTF_HOST) == 0 > - ? jailed_without_vnet(td_ucred) > - : prison_if(td_ucred, rt_key_const(rt)) != 0) > - return (0); > - return (1); > + if ((!rt_is_host) ? jailed_without_vnet(td_ucred) > + : prison_if(td_ucred, rt_dst) != 0) > + return (false); > + return (true); > } > > + > /* > * This is used in dumping the kernel table via sysctl(). > */ > static int > -sysctl_dumpentry(struct radix_node *rn, void *vw) > +sysctl_dumpentry(struct rtentry *rt, void *vw) > { > struct walkarg *w = vw; > - struct rtentry *rt = (struct rtentry *)rn; > struct nhop_object *nh; > int error = 0; > > NET_EPOCH_ASSERT(); > > - if (w->w_op == NET_RT_FLAGS && !(rt->rte_flags & w->w_arg)) > - return 0; > - if (!can_export_rte(w->w_req->td->td_ucred, rt)) > + export_rtaddrs(rt, w->dst, w->mask); > + if (!can_export_rte(w->w_req->td->td_ucred, rt_is_host(rt), w->dst)) > return (0); > - nh = rt->rt_nhop; > + nh = rt_get_raw_nhop(rt); > #ifdef ROUTE_MPATH > if (NH_IS_NHGRP(nh)) { > struct weightened_nhop *wn; > @@ -1783,13 +1848,17 @@ sysctl_dumpnhop(struct rtentry *rt, struct > nhop_object > { > struct rt_addrinfo info; > int error = 0, size; > - struct sockaddr_storage ss; > + uint32_t rtflags; > > + rtflags = nhop_get_rtflags(nh); > + > + if (w->w_op == NET_RT_FLAGS && !(rtflags & w->w_arg)) > + return (0); > + > bzero((caddr_t)&info, sizeof(info)); > - info.rti_info[RTAX_DST] = rt_key(rt); > + info.rti_info[RTAX_DST] = w->dst; > info.rti_info[RTAX_GATEWAY] = &nh->gw_sa; > - info.rti_info[RTAX_NETMASK] = rtsock_fix_netmask(rt_key(rt), > - rt_mask(rt), &ss); > + info.rti_info[RTAX_NETMASK] = (rtflags & RTF_HOST) ? NULL : w->mask; > info.rti_info[RTAX_GENMASK] = 0; > if (nh->nh_ifp && !(nh->nh_ifp->if_flags & IFF_DYING)) { > info.rti_info[RTAX_IFP] = nh->nh_ifp->if_addr->ifa_addr; > @@ -1804,12 +1873,16 @@ sysctl_dumpnhop(struct rtentry *rt, struct > nhop_object > > bzero(&rtm->rtm_index, > sizeof(*rtm) - offsetof(struct rt_msghdr, rtm_index)); > - if (rt->rte_flags & RTF_GWFLAG_COMPAT) > + > + /* > + * rte flags may consist of RTF_HOST (duplicated in nhop rtflags) > + * and RTF_UP (if entry is linked, which is always true here). > + * Given that, use nhop rtflags & add RTF_UP. > + */ > + rtm->rtm_flags = rtflags | RTF_UP; > + if (rtm->rtm_flags & RTF_GWFLAG_COMPAT) > rtm->rtm_flags = RTF_GATEWAY | > - (rt->rte_flags & ~RTF_GWFLAG_COMPAT); > - else > - rtm->rtm_flags = rt->rte_flags; > - rtm->rtm_flags |= nhop_get_rtflags(nh); > + (rtm->rtm_flags & ~RTF_GWFLAG_COMPAT); > rt_getmetrics(rt, nh, &rtm->rtm_rmx); > rtm->rtm_rmx.rmx_weight = weight; > rtm->rtm_index = nh->nh_ifp->if_index; > @@ -2075,10 +2148,23 @@ sysctl_ifmalist(int af, struct walkarg *w) > return (error); > } > > +static void > +rtable_sysctl_dump(uint32_t fibnum, int family, struct walkarg *w) > +{ > + union sockaddr_union sa_dst, sa_mask; > + > + w->family = family; > + w->dst = (struct sockaddr *)&sa_dst; > + w->mask = (struct sockaddr *)&sa_mask; > + > + init_sockaddrs_family(family, w->dst, w->mask); > + > + rib_walk(fibnum, family, false, sysctl_dumpentry, w); > +} > + > static int > sysctl_rtsock(SYSCTL_HANDLER_ARGS) > { > - RIB_RLOCK_TRACKER; > struct epoch_tracker et; > int *name = (int *)arg1; > u_int namelen = arg2; > @@ -2151,10 +2237,7 @@ sysctl_rtsock(SYSCTL_HANDLER_ARGS) > for (error = 0; error == 0 && i <= lim; i++) { > rnh = rt_tables_get_rnh(fib, i); > if (rnh != NULL) { > - RIB_RLOCK(rnh); > - error = rnh->rnh_walktree(&rnh->head, > - sysctl_dumpentry, &w); > - RIB_RUNLOCK(rnh); > + rtable_sysctl_dump(fib, i, &w); > } else if (af != 0) > error = EAFNOSUPPORT; > } > _______________________________________________ > svn-src-all@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-all > To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" > -- Mateusz Guzik From owner-svn-src-head@freebsd.org Tue Dec 22 20:45:25 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 60BC24C8987; Tue, 22 Dec 2020 20:45:25 +0000 (UTC) (envelope-from rlibby@gmail.com) Received: from mail-qk1-f174.google.com (mail-qk1-f174.google.com [209.85.222.174]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4D0pJ51frZz4sfk; Tue, 22 Dec 2020 20:45:25 +0000 (UTC) (envelope-from rlibby@gmail.com) Received: by mail-qk1-f174.google.com with SMTP id p14so13148249qke.6; Tue, 22 Dec 2020 12:45:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mofqSGg7Uhbw8nSEuZY5LzxGlh11gpm9r8YzUsbciNs=; b=X23B3D3QyNC1N0pY2+kxV1lBQyRoihWvx7Qy6E0ef7gN53ZVDYGYz7x/3dstZ5ZLnk C/1diOjAvP50ytb39lk8y8VKDE/sZk2ZKwTylTDAQ13/qVFdzl2m6ty1LFGVVzR5iOFK aULaaHKl9WsS2yIHrLulYSeqNIqeCdEPg1ASNaq/rMgtY40SxakHzEveprTPIC2Q+kTo jkqAtl2gtdjTRKMeQxqFLq7+nGmJmuv2MUr4L4EYTVA0JdsG3Y5Upk9MvOvRDOekd1sj jPEXED8pjVLcb2kZeMvoJCjA5R8xh1jfrHA9Lq18gqDsrOCx8P3eaxYELINsXO1BYxlz v8vA== X-Gm-Message-State: AOAM533bzc1aMVMR79ULmawk62Zb0KmtBarVCRxYCCvO2ssLuVa5WP1o ndH/mw6hM0MJWsUdHElALBMYGfg0iqAEnQ== X-Google-Smtp-Source: ABdhPJz9GoeWFVG7IIKtW+iHeC7s4/Ky1F6XfErumjscCcrgSYkFPz+fPPBU4xc2z8KBMTYkCMoD7A== X-Received: by 2002:a37:2796:: with SMTP id n144mr24448247qkn.471.1608669923984; Tue, 22 Dec 2020 12:45:23 -0800 (PST) Received: from mail-qk1-f169.google.com (mail-qk1-f169.google.com. [209.85.222.169]) by smtp.gmail.com with ESMTPSA id e10sm12489291qte.48.2020.12.22.12.45.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Dec 2020 12:45:23 -0800 (PST) Received: by mail-qk1-f169.google.com with SMTP id 143so13128752qke.10; Tue, 22 Dec 2020 12:45:23 -0800 (PST) X-Received: by 2002:a05:620a:12e5:: with SMTP id f5mr14594621qkl.331.1608669923347; Tue, 22 Dec 2020 12:45:23 -0800 (PST) MIME-Version: 1.0 References: <202012182200.0BIM0vIt062121@repo.freebsd.org> In-Reply-To: From: Ryan Libby Date: Tue, 22 Dec 2020 12:45:12 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r368769 - head/sys/net To: Mateusz Guzik Cc: "Alexander V. Chernikov" , src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4D0pJ51frZz4sfk X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Dec 2020 20:45:25 -0000 On Tue, Dec 22, 2020 at 10:31 AM Mateusz Guzik wrote: > > this makes NOIP kernels fail to compile: > > /usr/src/sys/net/rtsock.c:802:11: error: unused variable 'scopeid' > [-Werror,-Wunused-variable] > uint32_t scopeid = 0; > > Fix in progress: https://reviews.freebsd.org/D27730 > On 12/18/20, Alexander V. Chernikov wrote: > > Author: melifaro > > Date: Fri Dec 18 22:00:57 2020 > > New Revision: 368769 > > URL: https://svnweb.freebsd.org/changeset/base/368769 > > > > Log: > > Switch direct rt fields access in rtsock.c to newly-create field > > acessors. > > > > rtsock code was build around the assumption that each rtentry record > > in the system radix tree is a ready-to-use sockaddr. This assumptions > > turned out to be not quite true: > > * masks have their length tweaked, so we have rtsock_fix_netmask() hack > > * IPv6 addresses have their scope embedded, so we have another explicit > > deembedding hack. > > > > Change the code to decouple rtentry internals from rtsock code using > > newly-created rtentry accessors. This will allow to eventually eliminate > > both of the hacks and change rtentry dst/mask format. > > > > Differential Revision: https://reviews.freebsd.org/D27451 > > > > Modified: > > head/sys/net/rtsock.c > > > > Modified: head/sys/net/rtsock.c > > ============================================================================== > > --- head/sys/net/rtsock.c Fri Dec 18 20:41:23 2020 (r368768) > > +++ head/sys/net/rtsock.c Fri Dec 18 22:00:57 2020 (r368769) > > @@ -158,10 +158,13 @@ MTX_SYSINIT(rtsock, &rtsock_mtx, "rtsock route_cb > > lock > > SYSCTL_NODE(_net, OID_AUTO, route, CTLFLAG_RD | CTLFLAG_MPSAFE, 0, ""); > > > > struct walkarg { > > + int family; > > int w_tmemsize; > > int w_op, w_arg; > > caddr_t w_tmem; > > struct sysctl_req *w_req; > > + struct sockaddr *dst; > > + struct sockaddr *mask; > > }; > > > > static void rts_input(struct mbuf *m); > > @@ -170,7 +173,7 @@ static int rtsock_msg_buffer(int type, struct rt_addri > > struct walkarg *w, int *plen); > > static int rt_xaddrs(caddr_t cp, caddr_t cplim, > > struct rt_addrinfo *rtinfo); > > -static int sysctl_dumpentry(struct radix_node *rn, void *vw); > > +static int sysctl_dumpentry(struct rtentry *rt, void *vw); > > static int sysctl_dumpnhop(struct rtentry *rt, struct nhop_object *nh, > > uint32_t weight, struct walkarg *w); > > static int sysctl_iflist(int af, struct walkarg *w); > > @@ -187,7 +190,8 @@ static int update_rtm_from_rc(struct rt_addrinfo *info > > static void send_rtm_reply(struct socket *so, struct rt_msghdr *rtm, > > struct mbuf *m, sa_family_t saf, u_int fibnum, > > int rtm_errno); > > -static int can_export_rte(struct ucred *td_ucred, const struct rtentry > > *rt); > > +static bool can_export_rte(struct ucred *td_ucred, bool rt_is_host, > > + const struct sockaddr *rt_dst); > > > > static struct netisr_handler rtsock_nh = { > > .nh_name = "rtsock", > > @@ -707,7 +711,7 @@ handle_rtm_get(struct rt_addrinfo *info, u_int fibnum, > > return (ESRCH); > > } > > > > - nh = select_nhop(rc->rc_rt->rt_nhop, info->rti_info[RTAX_GATEWAY]); > > + nh = select_nhop(rt_get_raw_nhop(rc->rc_rt), > > info->rti_info[RTAX_GATEWAY]); > > if (nh == NULL) { > > RIB_RUNLOCK(rnh); > > return (ESRCH); > > @@ -721,9 +725,7 @@ handle_rtm_get(struct rt_addrinfo *info, u_int fibnum, > > */ > > if (rtm->rtm_flags & RTF_ANNOUNCE) { > > struct sockaddr laddr; > > - struct nhop_object *nh; > > > > - nh = rc->rc_rt->rt_nhop; > > if (nh->nh_ifp != NULL && > > nh->nh_ifp->if_type == IFT_PROPVIRTUAL) { > > struct ifaddr *ifa; > > @@ -747,7 +749,7 @@ handle_rtm_get(struct rt_addrinfo *info, u_int fibnum, > > RIB_RUNLOCK(rnh); > > return (ESRCH); > > } > > - nh = select_nhop(rc->rc_rt->rt_nhop, info->rti_info[RTAX_GATEWAY]); > > + nh = select_nhop(rt_get_raw_nhop(rc->rc_rt), > > info->rti_info[RTAX_GATEWAY]); > > if (nh == NULL) { > > RIB_RUNLOCK(rnh); > > return (ESRCH); > > @@ -760,6 +762,66 @@ handle_rtm_get(struct rt_addrinfo *info, u_int fibnum, > > return (0); > > } > > > > +static void > > +init_sockaddrs_family(int family, struct sockaddr *dst, struct sockaddr > > *mask) > > +{ > > +#ifdef INET > > + if (family == AF_INET) { > > + struct sockaddr_in *dst4 = (struct sockaddr_in *)dst; > > + struct sockaddr_in *mask4 = (struct sockaddr_in *)mask; > > + > > + bzero(dst4, sizeof(struct sockaddr_in)); > > + bzero(mask4, sizeof(struct sockaddr_in)); > > + > > + dst4->sin_family = AF_INET; > > + dst4->sin_len = sizeof(struct sockaddr_in); > > + mask4->sin_family = AF_INET; > > + mask4->sin_len = sizeof(struct sockaddr_in); > > + } > > +#endif > > +#ifdef INET6 > > + if (family == AF_INET6) { > > + struct sockaddr_in6 *dst6 = (struct sockaddr_in6 *)dst; > > + struct sockaddr_in6 *mask6 = (struct sockaddr_in6 *)mask; > > + > > + bzero(dst6, sizeof(struct sockaddr_in6)); > > + bzero(mask6, sizeof(struct sockaddr_in6)); > > + > > + dst6->sin6_family = AF_INET6; > > + dst6->sin6_len = sizeof(struct sockaddr_in6); > > + mask6->sin6_family = AF_INET6; > > + mask6->sin6_len = sizeof(struct sockaddr_in6); > > + } > > +#endif > > +} > > + > > +static void > > +export_rtaddrs(const struct rtentry *rt, struct sockaddr *dst, > > + struct sockaddr *mask) > > +{ > > + uint32_t scopeid = 0; > > +#ifdef INET > > + if (dst->sa_family == AF_INET) { > > + struct sockaddr_in *dst4 = (struct sockaddr_in *)dst; > > + struct sockaddr_in *mask4 = (struct sockaddr_in *)mask; > > + rt_get_inet_prefix_pmask(rt, &dst4->sin_addr, &mask4->sin_addr, > > + &scopeid); > > + return; > > + } > > +#endif > > +#ifdef INET6 > > + if (dst->sa_family == AF_INET6) { > > + struct sockaddr_in6 *dst6 = (struct sockaddr_in6 *)dst; > > + struct sockaddr_in6 *mask6 = (struct sockaddr_in6 *)mask; > > + rt_get_inet6_prefix_pmask(rt, &dst6->sin6_addr, &mask6->sin6_addr, > > + &scopeid); > > + dst6->sin6_scope_id = scopeid; > > + return; > > + } > > +#endif > > +} > > + > > + > > /* > > * Update sockaddrs, flags, etc in @prtm based on @rc data. > > * rtm can be reallocated. > > @@ -772,7 +834,6 @@ static int > > update_rtm_from_rc(struct rt_addrinfo *info, struct rt_msghdr **prtm, > > int alloc_len, struct rib_cmd_info *rc, struct nhop_object *nh) > > { > > - struct sockaddr_storage netmask_ss; > > struct walkarg w; > > union sockaddr_union saun; > > struct rt_msghdr *rtm, *orig_rtm = NULL; > > @@ -780,11 +841,14 @@ update_rtm_from_rc(struct rt_addrinfo *info, struct > > rt > > int error, len; > > > > rtm = *prtm; > > + union sockaddr_union sa_dst, sa_mask; > > + int family = info->rti_info[RTAX_DST]->sa_family; > > + init_sockaddrs_family(family, &sa_dst.sa, &sa_mask.sa); > > + export_rtaddrs(rc->rc_rt, &sa_dst.sa, &sa_mask.sa); > > > > - info->rti_info[RTAX_DST] = rt_key(rc->rc_rt); > > + info->rti_info[RTAX_DST] = &sa_dst.sa; > > + info->rti_info[RTAX_NETMASK] = rt_is_host(rc->rc_rt) ? NULL : > > &sa_mask.sa; > > info->rti_info[RTAX_GATEWAY] = &nh->gw_sa; > > - info->rti_info[RTAX_NETMASK] = rtsock_fix_netmask(rt_key(rc->rc_rt), > > - rt_mask(rc->rc_rt), &netmask_ss); > > info->rti_info[RTAX_GENMASK] = 0; > > ifp = nh->nh_ifp; > > if (rtm->rtm_addrs & (RTA_IFP | RTA_IFA)) { > > @@ -994,7 +1058,9 @@ route_output(struct mbuf *m, struct socket *so, ...) > > nh = rc.rc_nh_new; > > > > report: > > - if (!can_export_rte(curthread->td_ucred, rc.rc_rt)) { > > + if (!can_export_rte(curthread->td_ucred, > > + info.rti_info[RTAX_NETMASK] == NULL, > > + info.rti_info[RTAX_DST])) { > > senderr(ESRCH); > > } > > > > @@ -1730,35 +1796,34 @@ rt_dispatch(struct mbuf *m, sa_family_t saf) > > * > > * Returns 1 if it can, 0 otherwise. > > */ > > -static int > > -can_export_rte(struct ucred *td_ucred, const struct rtentry *rt) > > +static bool > > +can_export_rte(struct ucred *td_ucred, bool rt_is_host, > > + const struct sockaddr *rt_dst) > > { > > > > - if ((rt->rte_flags & RTF_HOST) == 0 > > - ? jailed_without_vnet(td_ucred) > > - : prison_if(td_ucred, rt_key_const(rt)) != 0) > > - return (0); > > - return (1); > > + if ((!rt_is_host) ? jailed_without_vnet(td_ucred) > > + : prison_if(td_ucred, rt_dst) != 0) > > + return (false); > > + return (true); > > } > > > > + > > /* > > * This is used in dumping the kernel table via sysctl(). > > */ > > static int > > -sysctl_dumpentry(struct radix_node *rn, void *vw) > > +sysctl_dumpentry(struct rtentry *rt, void *vw) > > { > > struct walkarg *w = vw; > > - struct rtentry *rt = (struct rtentry *)rn; > > struct nhop_object *nh; > > int error = 0; > > > > NET_EPOCH_ASSERT(); > > > > - if (w->w_op == NET_RT_FLAGS && !(rt->rte_flags & w->w_arg)) > > - return 0; > > - if (!can_export_rte(w->w_req->td->td_ucred, rt)) > > + export_rtaddrs(rt, w->dst, w->mask); > > + if (!can_export_rte(w->w_req->td->td_ucred, rt_is_host(rt), w->dst)) > > return (0); > > - nh = rt->rt_nhop; > > + nh = rt_get_raw_nhop(rt); > > #ifdef ROUTE_MPATH > > if (NH_IS_NHGRP(nh)) { > > struct weightened_nhop *wn; > > @@ -1783,13 +1848,17 @@ sysctl_dumpnhop(struct rtentry *rt, struct > > nhop_object > > { > > struct rt_addrinfo info; > > int error = 0, size; > > - struct sockaddr_storage ss; > > + uint32_t rtflags; > > > > + rtflags = nhop_get_rtflags(nh); > > + > > + if (w->w_op == NET_RT_FLAGS && !(rtflags & w->w_arg)) > > + return (0); > > + > > bzero((caddr_t)&info, sizeof(info)); > > - info.rti_info[RTAX_DST] = rt_key(rt); > > + info.rti_info[RTAX_DST] = w->dst; > > info.rti_info[RTAX_GATEWAY] = &nh->gw_sa; > > - info.rti_info[RTAX_NETMASK] = rtsock_fix_netmask(rt_key(rt), > > - rt_mask(rt), &ss); > > + info.rti_info[RTAX_NETMASK] = (rtflags & RTF_HOST) ? NULL : w->mask; > > info.rti_info[RTAX_GENMASK] = 0; > > if (nh->nh_ifp && !(nh->nh_ifp->if_flags & IFF_DYING)) { > > info.rti_info[RTAX_IFP] = nh->nh_ifp->if_addr->ifa_addr; > > @@ -1804,12 +1873,16 @@ sysctl_dumpnhop(struct rtentry *rt, struct > > nhop_object > > > > bzero(&rtm->rtm_index, > > sizeof(*rtm) - offsetof(struct rt_msghdr, rtm_index)); > > - if (rt->rte_flags & RTF_GWFLAG_COMPAT) > > + > > + /* > > + * rte flags may consist of RTF_HOST (duplicated in nhop rtflags) > > + * and RTF_UP (if entry is linked, which is always true here). > > + * Given that, use nhop rtflags & add RTF_UP. > > + */ > > + rtm->rtm_flags = rtflags | RTF_UP; > > + if (rtm->rtm_flags & RTF_GWFLAG_COMPAT) > > rtm->rtm_flags = RTF_GATEWAY | > > - (rt->rte_flags & ~RTF_GWFLAG_COMPAT); > > - else > > - rtm->rtm_flags = rt->rte_flags; > > - rtm->rtm_flags |= nhop_get_rtflags(nh); > > + (rtm->rtm_flags & ~RTF_GWFLAG_COMPAT); > > rt_getmetrics(rt, nh, &rtm->rtm_rmx); > > rtm->rtm_rmx.rmx_weight = weight; > > rtm->rtm_index = nh->nh_ifp->if_index; > > @@ -2075,10 +2148,23 @@ sysctl_ifmalist(int af, struct walkarg *w) > > return (error); > > } > > > > +static void > > +rtable_sysctl_dump(uint32_t fibnum, int family, struct walkarg *w) > > +{ > > + union sockaddr_union sa_dst, sa_mask; > > + > > + w->family = family; > > + w->dst = (struct sockaddr *)&sa_dst; > > + w->mask = (struct sockaddr *)&sa_mask; > > + > > + init_sockaddrs_family(family, w->dst, w->mask); > > + > > + rib_walk(fibnum, family, false, sysctl_dumpentry, w); > > +} > > + > > static int > > sysctl_rtsock(SYSCTL_HANDLER_ARGS) > > { > > - RIB_RLOCK_TRACKER; > > struct epoch_tracker et; > > int *name = (int *)arg1; > > u_int namelen = arg2; > > @@ -2151,10 +2237,7 @@ sysctl_rtsock(SYSCTL_HANDLER_ARGS) > > for (error = 0; error == 0 && i <= lim; i++) { > > rnh = rt_tables_get_rnh(fib, i); > > if (rnh != NULL) { > > - RIB_RLOCK(rnh); > > - error = rnh->rnh_walktree(&rnh->head, > > - sysctl_dumpentry, &w); > > - RIB_RUNLOCK(rnh); > > + rtable_sysctl_dump(fib, i, &w); > > } else if (af != 0) > > error = EAFNOSUPPORT; > > } > > _______________________________________________ > > svn-src-all@freebsd.org mailing list > > https://lists.freebsd.org/mailman/listinfo/svn-src-all > > To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" > > > > > -- > Mateusz Guzik > _______________________________________________ > svn-src-all@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-all > To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" From owner-svn-src-head@freebsd.org Thu Dec 24 08:57:32 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B30424BCCF0; Thu, 24 Dec 2020 08:57:32 +0000 (UTC) (envelope-from freebsd@omnilan.de) Received: from mx0.gentlemail.de (mx0.gentlemail.de [IPv6:2a00:e10:2800::a130]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "CN", Issuer "CN" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4D1kVM5JSTz3P53; Thu, 24 Dec 2020 08:57:31 +0000 (UTC) (envelope-from freebsd@omnilan.de) Received: from mh0.gentlemail.de (mh0.gentlemail.de [78.138.80.135]) by mx0.gentlemail.de (8.15.2/8.15.2) with ESMTP id 0BO8vHnN032428; Thu, 24 Dec 2020 09:57:18 +0100 (CET) (envelope-from freebsd@omnilan.de) Received: from titan.inop.mo1.omnilan.net (s1.omnilan.de [217.91.127.234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mh0.gentlemail.de (Postfix) with ESMTPSA id BF026C55; Thu, 24 Dec 2020 09:57:16 +0100 (CET) Subject: Re: svn commit: r368820 - head To: Kyle Evans , "Rodney W. Grimes" Cc: Gary Jennejohn , "Hartmann, O." , Li-Wen Hsu , src-committers , svn-src-all , svn-src-head References: <20201220145506.256ba79c@ernst.home> <202012211424.0BLEOIT9042173@gndrsh.dnsmgr.net> From: Harry Schmalzbauer Organization: OmniLAN Message-ID: <09a685fd-b4ab-dafe-5467-23e8ed4e1ee8@omnilan.de> Date: Thu, 24 Dec 2020 09:57:16 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Greylist: inspected by milter-greylist-4.6.2 (mx0.gentlemail.de [78.138.80.130]); Thu, 24 Dec 2020 09:57:22 +0100 (CET) for IP:'78.138.80.135' DOMAIN:'mh0.gentlemail.de' HELO:'mh0.gentlemail.de' FROM:'freebsd@omnilan.de' RCPT:'' X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx0.gentlemail.de [78.138.80.130]); Thu, 24 Dec 2020 09:57:22 +0100 (CET) X-Rspamd-Queue-Id: 4D1kVM5JSTz3P53 X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of freebsd@omnilan.de designates 2a00:e10:2800::a130 as permitted sender) smtp.mailfrom=freebsd@omnilan.de X-Spamd-Result: default: False [-3.30 / 15.00]; RCVD_TLS_LAST(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; RBL_DBL_DONT_QUERY_IPS(0.00)[2a00:e10:2800::a130:from]; R_SPF_ALLOW(-0.20)[+mx]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[omnilan.de]; ARC_NA(0.00)[]; HAS_ORG_HEADER(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; NEURAL_HAM_SHORT(-1.00)[-1.000]; RCPT_COUNT_SEVEN(0.00)[8]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; SPAMHAUS_ZRD(0.00)[2a00:e10:2800::a130:from:127.0.2.255]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:61157, ipnet:2a00:e10:2800::/38, country:DE]; FREEMAIL_CC(0.00)[gmail.com,walstatt.org,freebsd.org]; MAILMAN_DEST(0.00)[svn-src-head,svn-src-all] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Dec 2020 08:57:32 -0000 Am 21.12.2020 um 15:26 schrieb Kyle Evans: > On Mon, Dec 21, 2020 at 8:24 AM Rodney W. Grimes > wrote: >>> On Sun, 20 Dec 2020 15:46:12 +0100 >>> "Hartmann, O." wrote: >>> >>>> On Sun, 20 Dec 2020 02:59:44 +0000 (UTC) >>>> Li-Wen Hsu wrote: >>>> >>>>> Author: lwhsu >>>>> Date: Sun Dec 20 02:59:44 2020 >>>>> New Revision: 368820 >>>>> URL: https://svnweb.freebsd.org/changeset/base/368820 >>>>> >>>>> Log: >>>>> Mark the repository as being converted to Git. >>>>> >>>>> This is the last Subversion commit to src. >>>>> >>>>> Sponsored by: The FreeBSD Foundation >>>>> >>>>> :... >>>> Is this message of yours also the last message concerning the source changes? Since then >>>> you published this message, no further logs ran into list svn-src-head@freebsd.org. >>>> >>> Take a look at this https://wiki.freebsd.org/git. Write access to >>> Subversion has been disabled. >> I think the bigger question is why as a committer have I not seen ANY >> commits to git since this cut over? Is it a) none have happened in 24 hours, >> or b) commit mail is no longer going to developers as it use to? Still curious about an answer to Oliver"s question regarding the changlog mailing list. I read asorted sources about Git and briefly imp@'s highly appreciated docs, but didn't stumble across an hint about any svn-src-(BRANCH|all)@ replacement. Thanks, -harry From owner-svn-src-head@freebsd.org Thu Dec 24 21:34:56 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id CCAAA4D1A74; Thu, 24 Dec 2020 21:34:56 +0000 (UTC) (envelope-from o.hartmann@walstatt.org) Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mout.gmx.net", Issuer "TeleSec ServerPass Class 2 CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4D23JH4h8sz3M3j; Thu, 24 Dec 2020 21:34:55 +0000 (UTC) (envelope-from o.hartmann@walstatt.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1608845693; bh=lPdjnLVlVKh2I4oTe6TO/6Ufemdf6FqIYDpiYpmvzZ4=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:In-Reply-To:References; b=WCC/jCU4mFERZReeTHpxPc3WI9AlqSSh9H8R9qbyHwlnEFBthjdwPFMptmaJEdDxs kuFlovBO0uWi5v+iHgA48e9KsmaOtQO6F9M4MV4GGISPe07neUJGSBjs+UHGEIdZs8 BMFrsLPYsZZGn1C+tywCvSWVJuNFmvNw+tS19TuA= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from hermann.fritz.box ([78.55.15.118]) by mail.gmx.com (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1Mn2aD-1k9uIc2Pkl-00k7HA; Thu, 24 Dec 2020 22:34:53 +0100 Date: Thu, 24 Dec 2020 22:34:46 +0100 From: "Hartmann, O." To: "Hartmann, O." Cc: Li-Wen Hsu , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r368820 - head Message-ID: <20201224223446.3d6c910d@hermann.fritz.box> In-Reply-To: <20201220154612.44a61f72@hermann.fritz.box> References: <202012200259.0BK2xiGC074752@repo.freebsd.org> <20201220154612.44a61f72@hermann.fritz.box> Organization: walstatt.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/+QmuDpklSzcG3hOQ/cghZ5m"; protocol="application/pgp-signature"; micalg=pgp-sha256 X-Provags-ID: V03:K1:B4wb91/Q/Ag57300tfJa94odaQE65zLLzBGTRN/iiK2pFYoDNjs xTN+3qQBuaFYO0a2LK94E0vtw232S1nnfhpefDF4qXdmsqEsH3o4IxdEswVbV6bElp03KKY V9cyeJIASNrLwzpNuAaFNqCUFvJFHmFgUn4kLyiNZWVcH/c43Z5dZRexwfdkxl9Q9HyGUaQ DTF/cPzPAeh94/1BO6VNA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:gfUWGc1Pev0=:PVmjXuu3GMmeHP2mzBuh55 W6PwTwYQ/7tiydJVkchZ9Wu26sCXCyMW7zvsd5saFnaP7F8M+baHNXdJUwzguSHZs2hmwebm1 CZYb5VhjdJTS0lmWclqjnFV3YM5IY1ML6lGUxEhOzmaQdkB7N4Vicd6TvmpgsSFpWyevtns+Y ydqfOYgqn9vp2pqmgxMZB6/HoFfeeUjFwuB0CBjuqPpgk9SdK4PiOHMcOjp7OaXg0CArW7QgW h3k0qImRE1RG/pym7qMdO413i/+YWL4p+UjLJ2TnrwydhJJ5uDXOcZwygxjr/unbvlXlZbr/I l9rVGQWwObeo83ykbtCiLex1SShOHY+3yjiTUDwmr/cuAfOLfox50QG1Lm4BHKyFRTG//1D4M X3xkajHcS04qxBFYuAqZiGXv+SGUOsVhpK5Fpn2cgopoP214txirffzwKMA1JMpOaPzIHWeiS rqmiT10ijta18cgJqz0n25LWqJi7xv6uD6ct2wF4PKvAe+keszkF1u4GKuC1GLC+/6B+1xK3Y 3rYApSdJsIpgBtPmGIdrp3RQ7NUrPK75T7C34x6bHAkT3A+F93XY6cTgy/71VerWQvY6lw40V 5AJr+jwSMJaJH90khTvaUOH8+BRjtdn3GfhsR4E+jeF0mGcOkUX2kF357TdtddB8NQYaB1ENA II84UrmlbBImXURP9h/gAQ1Gkz0PG8PTQ7wPXSRK9hC/NJhQSPCfAzWBcvdqZ6d7qUJfCVrOs KBczMldbGQvbXBZ4yeVLPyuO/cCUmb97TyxDJdJJ6dvrG/SQtPxEfW9T3Wg5XLu+cH6B+6jiY bWyhCbrnQWN1nnh9it9/jNgWNfM05ifbbwP1idmxUzPPnVXQI7/0czBCDR908T7fvECcNQMVs lt4BXwaJRAYJ6b8+/llg== X-Rspamd-Queue-Id: 4D23JH4h8sz3M3j X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmx.net header.s=badeba3b8450 header.b=WCC/jCU4; dmarc=none; spf=none (mx1.freebsd.org: domain of o.hartmann@walstatt.org has no SPF policy when checking 212.227.15.19) smtp.mailfrom=o.hartmann@walstatt.org X-Spamd-Result: default: False [-3.50 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; RCPT_COUNT_FIVE(0.00)[5]; HAS_ORG_HEADER(0.00)[]; DKIM_TRACE(0.00)[gmx.net:+]; NEURAL_HAM_SHORT(-1.00)[-1.000]; RCVD_IN_DNSWL_LOW(-0.10)[212.227.15.19:from]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RBL_DBL_DONT_QUERY_IPS(0.00)[212.227.15.19:from]; ASN(0.00)[asn:8560, ipnet:212.227.0.0/16, country:DE]; RECEIVED_SPAMHAUS_PBL(0.00)[78.55.15.118:received]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[gmx.net:s=badeba3b8450]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; DMARC_NA(0.00)[walstatt.org]; SPAMHAUS_ZRD(0.00)[212.227.15.19:from:127.0.2.255]; TO_MATCH_ENVRCPT_SOME(0.00)[]; R_SPF_NA(0.00)[no SPF record]; RWL_MAILSPIKE_POSSIBLE(0.00)[212.227.15.19:from]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[svn-src-all,svn-src-head] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Dec 2020 21:34:56 -0000 --Sig_/+QmuDpklSzcG3hOQ/cghZ5m Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Sun, 20 Dec 2020 15:46:12 +0100 "Hartmann, O." wrote: > On Sun, 20 Dec 2020 02:59:44 +0000 (UTC) > Li-Wen Hsu wrote: >=20 > > Author: lwhsu > > Date: Sun Dec 20 02:59:44 2020 > > New Revision: 368820 > > URL: https://svnweb.freebsd.org/changeset/base/368820 > >=20 > > Log: > > Mark the repository as being converted to Git. > > =20 > > This is the last Subversion commit to src. > > =20 > > Sponsored by: The FreeBSD Foundation > >=20 > > Modified: > > head/README > > head/README.md > >=20 > > Modified: head/README > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/README Sat Dec 19 22:04:46 2020 (r368819) > > +++ head/README Sun Dec 20 02:59:44 2020 (r368820) > > @@ -1,3 +1,5 @@ > > +This repository is being converted from Subversion to Git. > > + > > This is the top level of the FreeBSD source directory. This file > > was last revised on: > > $FreeBSD$ > >=20 > > Modified: head/README.md > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/README.md Sat Dec 19 22:04:46 2020 (r368819) > > +++ head/README.md Sun Dec 20 02:59:44 2020 (r368820) > > @@ -1,3 +1,5 @@ > > +This repository is being converted from Subversion to Git. > > + > > FreeBSD Source: > > --------------- > > This is the top level of the FreeBSD source directory. This file > > _______________________________________________ > > svn-src-head@freebsd.org mailing list > > https://lists.freebsd.org/mailman/listinfo/svn-src-head > > To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org"= =20 >=20 > Is this message of yours also the last message concerning the source chan= ges? Since then > you published this message, no further logs ran into list svn-src-head@fr= eebsd.org. >=20 > Kind regards, >=20 > oh According to the status of the wiki refered to by https://wiki.freebsd.org/= git, most of the transition from svn to git has been done. According to the recent logs reported at https://cgit.freebsd.org/src/, the= recent commits for "main" (I assume this is CURRENT?) are done 35 minutes ago, com= mit 322a188d45f17457f0de00a78c77228751dff03c. The last message on this list is still this one I'm replying to. I'm new to git, I usually do not switch between several code revisions syst= ems, I assume a lot of FreeBSD users are familiar with subversion and share my problems o= f keeping pace.=20 =46rom the recent state of the list I assume its death. I can not find (easil= y) any hints for those who were familiar with subversion and checking out /usr/src eithe= r for 12-STABLE, 12.1-RELENG, 12.2-RELENG, CURRENT. For /usr/doc it was easy to "clone" the repository and, who would doubt it,= there were some hints how-to-do. But how do I checkout /usr/src for either CURRENT, 12= .{1,2}-RELENG and 12-STABLE? Where is the primer for those "not-so-development-involved" = people like me? And were to and how to report problems in themanner of this list regard= ing to certain commits? Regards, oh=20 --Sig_/+QmuDpklSzcG3hOQ/cghZ5m Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iHUEARYIAB0WIQSy8IBxAPDkqVBaTJ44N1ZZPba5RwUCX+UJdgAKCRA4N1ZZPba5 R1SvAQCgHZoOnF1JdJSkWwV/KP4Y5Pbp5P8QgzdZJW2WyjEa5QEAv0MFVm/9kKIh 4+SwMl/xjdZ95U8C++cZ51kECCg+tgM= =eVHA -----END PGP SIGNATURE----- --Sig_/+QmuDpklSzcG3hOQ/cghZ5m-- From owner-svn-src-head@freebsd.org Thu Dec 24 22:19:05 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5992E4D3481; Thu, 24 Dec 2020 22:19:05 +0000 (UTC) (envelope-from rpokala@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4D24HF23KNz3PMG; Thu, 24 Dec 2020 22:19:05 +0000 (UTC) (envelope-from rpokala@freebsd.org) Received: from [192.168.1.10] (c-98-207-126-143.hsd1.ca.comcast.net [98.207.126.143]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: rpokala) by smtp.freebsd.org (Postfix) with ESMTPSA id 754BF56DF; Thu, 24 Dec 2020 22:19:04 +0000 (UTC) (envelope-from rpokala@freebsd.org) User-Agent: Microsoft-MacOutlook/16.43.20110804 Date: Thu, 24 Dec 2020 14:19:01 -0800 Subject: Re: svn commit: r368820 - head From: Ravi Pokala To: "Hartmann, O." , "Hartmann, O." CC: Li-Wen Hsu , , , Message-ID: <5BEF93E6-1AF8-4043-A34E-13789EBA7726@panasas.com> Thread-Topic: svn commit: r368820 - head References: <202012200259.0BK2xiGC074752@repo.freebsd.org> <20201220154612.44a61f72@hermann.fritz.box> <20201224223446.3d6c910d@hermann.fritz.box> In-Reply-To: <20201224223446.3d6c910d@hermann.fritz.box> Mime-version: 1.0 Content-type: text/plain; charset="UTF-8" Content-transfer-encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Dec 2020 22:19:05 -0000 -----Original Message----- From: on behalf of "Hartmann, O." Organization: walstatt.org Date: 2020-12-24, Thursday at 13:34 To: "Hartmann, O." Cc: Li-Wen Hsu , , , Subject: Re: svn commit: r368820 - head On Sun, 20 Dec 2020 15:46:12 +0100 "Hartmann, O." wrote: According to the status of the wiki refered to by https://wiki.freebsd.org/git, most of the transition from svn to git has been done. According to the recent logs reported at https://cgit.freebsd.org/src/, the recent commits for "main" (I assume this is CURRENT?) are done 35 minutes ago, commit 322a188d45f17457f0de00a78c77228751dff03c. The last message on this list is still this one I'm replying to. I've been getting mail from git, sent to src-committers@, dev-commits-src-all@, and dev-commits-src-main@ (-HEAD) or dev-commits-src-branches@ (stable). The first such message was: ================================================================ From: on behalf of Li-Wen Hsu Date: 2020-12-22, Tuesday at 20:29 To: , , Subject: git: 5ef5f51d2bef - Mark the repository has been converted to Git The branch main has been updated by lwhsu: URL: https://cgit.FreeBSD.org/src/commit/?id=5ef5f51d2bef80b0ede9b10ad5b0e9440b60518c commit 5ef5f51d2bef80b0ede9b10ad5b0e9440b60518c Author: Li-Wen Hsu AuthorDate: 2020-12-23 04:27:27 +0000 Commit: Li-Wen Hsu CommitDate: 2020-12-23 04:27:27 +0000 Mark the repository has been converted to Git This is the first Git commit to src. Sponsored by: The FreeBSD Foundation --- README | 2 -- README.md | 2 -- 2 files changed, 4 deletions(-) diff --git a/README b/README index eb38522b1357..aad363baf9ea 100644 --- a/README +++ b/README @@ -1,5 +1,3 @@ -This repository is being converted from Subversion to Git. - This is the top level of the FreeBSD source directory. This file was last revised on: $FreeBSD$ diff --git a/README.md b/README.md index 0eba39438e46..72bd634cd813 100644 --- a/README.md +++ b/README.md @@ -1,5 +1,3 @@ -This repository is being converted from Subversion to Git. - FreeBSD Source: --------------- This is the top level of the FreeBSD source directory. This file ================================================================ -Ravi (rpokala@) From owner-svn-src-head@freebsd.org Fri Dec 25 05:17:42 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 456254B7408 for ; Fri, 25 Dec 2020 05:17:42 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic306-19.consmr.mail.gq1.yahoo.com (sonic306-19.consmr.mail.gq1.yahoo.com [98.137.68.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4D2FZD3FYhz4XZ4 for ; Fri, 25 Dec 2020 05:17:39 +0000 (UTC) (envelope-from marklmi@yahoo.com) X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1608873458; bh=ltW9NK6CA/2paPMoABFiYkfIo+UHvvLdFJ0ZNvkW6FW=; h=From:Subject:Date:To:From:Subject; b=QaQnjE9zJF6rp//pN5JNKuvZvAy/PSTjA/BOuDOKnoTawCbG9fIN0gNo31HppVWKOtTRv5JC86/Ax436WlshMoe+MeebFsdT/prh7rw8YC8MDvxOWFAkjDz+L1HEtyzBFsgKPubfTbljXAeHBKsd/RyzU+yEpaN+FeKj3xDnU0GsKh6Jnu2O9HInZol1XX5JOqW77w1/aKjYP/9F/dB1SFry/XyJieypTXpg/hNESzx3Ohih3HC25Zbl4DzdVYW2ck/sOV3NnlnqY9V7Ltmkex+A7R0nOIp2N2tDTg8nO+zZnlTOl1WZxE7lWtiHKej/RzuDjLtG2MSKmgN+aeq6ZQ== X-YMail-OSG: J.6OQcwVM1n5feQgIHX7rZZr3rUZuYpmDZkovUYpv1S6V0G2jZvFtb.iQQ6fdLr YLdofv0i43cH.TEIdTa7XclcXyeThxOYrJK38QF55H909I5P0myxZJ1gw5mxZs60uXwCYNpnA.t6 7h9o9vWZekJyYwMYk6QavUX2PZ6teANENPZIfqBkNwl..Zoh.hMuYsgwFK8itIngY8mHDfCU08bM ZUKW3KzHvwSAykNwDE_LmqZFuDdCQaCw9j4xbPcurLJ4OUVGeTEShxlDrTv.At_q74PYAYA95DZN xspshC1dXNlK5FF0rwYvfMtc_j_5uoIWYBzgagwSaiUdEiWCsBAW7cK8dIT_NHTyb4EvJBcl14n4 37RBcKJQyYfEddqppDwO9GxQI6iGHHshjpGX9hFWHOHN.zKsNVEYlhxxbH1eVJyOQcDAXZLtZIOu B3ioo.Yux0RGOMJVRUl5dGy3Uv1ktrBAykbwrZUowPcLyCkFISAtTdrinTfNJsGC9jAuvj3ejYmj h13FPWzc6IGPw761IxyZB7UWy7ZqzJ3Tp4GT.c9fhjNzmhKw7luomXvBkst5eig4yhrmviqqpMqv 4whAUveBpAk7CfOUenoG2OMbHCEBO12V6ZL0DcfdWvgAuFhEl6.Dgq5n8rVRF.3FgbnQI3lTkxj7 6Acxsl4lSsMyfW53w.X3ZhTl0bmgqoQQovqL8vFHg2Q3AUMNaLQrbRrr2d9dapktM.pzidmB1_HH pxOqX_ipkn5kQ_rQMkRTqJ9qUir9m9uzJiCVgGdXb_jZv216msNVWds7PMTKIJVPF3ki6H_nxGBg 5u8c25F_bzdtrWc4NAm5aowB.XFc6H3bAoEwuvSK0M6SnKq0DUH5xHn6sVo5gIgH5oO7QuwwfSQ2 WBvNnBplKA4o4B1MOJRN7Sifo8JTng55eI5_GwBRx.NLEtqpxvKb9kLa3u_XP2bivZxTUdEzp6lI qAmFCFYqB30dMHSCvRzy.YVJZcomb28Izbwy3.Vi1LotyL75OKRyNylQW4HwfYec6BAKffO707nb rrcPP.rpywsJz0cY3IysuI_mM2qfTOk0Wlq6EUWN65.kcppZzTR3kNw1Bc1nZK_Ahm6bGgBvFiRX q0H2090j0nGPq1MA7a_6THC6Q8m5aImTeYly.z1iMubYn1ZXXvMJ4G5DZurr94264phdi4.KG9zs b49IErIECp0bA6Nee93FLBJsLbqd_Co3pBqGQCmG80ffgMuIwle8R5fQpTQsFoiUp0fzQsEqwmmI PahVVunTXUNUI4HHT67Mb78Ed.6bWhZSyU0wd_uTv6KqzQlZzSl7saKUyrzPH6zOgpz4WlnsQhM3 zDpnqeq.cU3SsajYrQagXxbplUbXlwKeaysAtxZx_iSJnsBq8KobvZNkZTnwPzZSHEpPqBHXR6zN cBscOHKDvWjZXgiiYIGEprMJRqysrWpl.e2ybgzDlLOmE2XZ2zZ94N_y56gaRICTKRqaRGhY4YKs KeZPCvtT6VA9kQRXoTaD.TjuLvjODEhxeDKwNAO8kzdTVG0oRDJSn4Jb23UXzDhKDannM.rEN93x ZjWbubywKT5UhX8T52pQCETC.N6wSsYpaG7zuBUDqAkPH7EwW2DTMh5PJKo9XXEfpwxkHfGhX2Er 16r7nNfvD57kKRTRy7Eb25WqJWQvGAvHmTPO6TKuchU1ZAovCeX8.g.DZrCPNwNEHqyTeHDy8C9. v22I1QCluPXOM5FrbJ_UB_lE5POhNvHIUeydaNv.HyTw7d3Q6WJdB89DaSZNv5O_.HWdzr0Lvc6C XIrMHufjqLrLdL5hNSiSaPYT.8pcWU4NbLogVGhBkDIAiCZxy7gBUMeQ2Wq2xE3izax7vmJX3GLY PIzWbdQ7RcQZ6aCdccsrGe0YF1IFRktwChND0REaftkBPiGzbTtzkfQXtHI2sLatnIPDfYIwk88B ccv4aS1MeHlitxixVqAEeQp37LOXioSfn3FhTF9ls3oMBLhUFyUQI2w73FQMYaZurw..3f8wUhgw Hkz1azZj4xdaXWWijFO4ADUKOZR4AoETE.dLAEIDfUaNfE4fBB6OHvH4xzxuKdUuvB8553QEB0C5 e.H59miZukAZV7TRDyJ2cueG9T5suL0nDtwsKCymDrZjRCA6Rczwc.PmknS1Wjf1GrA9vLhZTmzM wU_lEGyo2OQnnumphHKf0CYoEZj9wux8BK6CjhPbza3W_ivn0Kl7L0kpg17JbZE3WoCknf5Gy_H5 vT9gyHhqejjKTmqcfqhRgiAuSfghsZhCSSf9WgSSYh1Pfa_CcHvNp_I94JGUAjAC0JyWzf_g7z_a jDbaTmJ7f4Iirx8Yo0kMPIX28Hx4_dlk9hI7T2IiCA0X7vFBU2u8pVF370z5XfGAcUrODGeqOR3l lqm2s2aUuChULEbR5oVBhOGQDWigUAis9COoo.EAKyseFL3vCXUEI9Re8DBHNz.eHUbNeffk8zaP APBpnaGEP7tl6.23UlX11IcrIgiBW4RBKkHGj8H8wHZBzFh49kuD65iSL Received: from sonic.gate.mail.ne1.yahoo.com by sonic306.consmr.mail.gq1.yahoo.com with HTTP; Fri, 25 Dec 2020 05:17:38 +0000 Received: by smtp423.mail.bf1.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 98a8550877ab49fe226d7ae7e21d08a4; Fri, 25 Dec 2020 05:17:34 +0000 (UTC) From: Mark Millard Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.20.0.2.21\)) Subject: Re: svn commit: r368820 - head Message-Id: <018DC607-28A9-4937-B5C5-10C5C1B06C43@yahoo.com> Date: Thu, 24 Dec 2020 21:17:32 -0800 Cc: svn-src-head@freebsd.org To: o.hartmann@walstatt.org X-Mailer: Apple Mail (2.3654.20.0.2.21) References: <018DC607-28A9-4937-B5C5-10C5C1B06C43.ref@yahoo.com> X-Rspamd-Queue-Id: 4D2FZD3FYhz4XZ4 X-Spamd-Bar: --- X-Spamd-Result: default: False [-3.36 / 15.00]; FREEMAIL_FROM(0.00)[yahoo.com]; MV_CASE(0.50)[]; TO_DN_NONE(0.00)[]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; DKIM_TRACE(0.00)[yahoo.com:+]; RCPT_COUNT_TWO(0.00)[2]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; NEURAL_HAM_SHORT(-0.86)[-0.863]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/20, country:US]; RBL_DBL_DONT_QUERY_IPS(0.00)[98.137.68.82:from]; DWL_DNSWL_NONE(0.00)[yahoo.com:dkim]; MID_RHS_MATCH_FROM(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; SPAMHAUS_ZRD(0.00)[98.137.68.82:from:127.0.2.255]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[98.137.68.82:from]; RWL_MAILSPIKE_POSSIBLE(0.00)[98.137.68.82:from]; RCVD_COUNT_TWO(0.00)[2]; MAILMAN_DEST(0.00)[svn-src-head] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Dec 2020 05:17:42 -0000 Hartmann, O. o.hartmann at walstatt.org wrote on Thu Dec 24 21:34:56 UTC 2020 : > According to the status of the wiki refered to by = https://wiki.freebsd.org/git, > most of > the transition from svn to git has been done. > According to the recent logs reported at=20 > https://cgit.freebsd.org/src/, > the recent > commits for "main" (I assume this is CURRENT?) are done 35 minutes = ago, commit > 322a188d45f17457f0de00a78c77228751dff03c. "main" in git is is for what was CURRENT. git has its own use of the text "HEAD" and so references to head require identification of the context and possibly are best avoided. (I used to prefer head to current, given head's use in svn.) https://wiki.freebsd.org/git still lists "Finish git->svn exporter for stable/11, stable/12, and supported releng/ branches" as "In Q/A". The updates in svn should start again at some point. 12 and 11 via svn will still identify versions using text like -r368999 and official builds will be based on such, if I understand right. Official 13+ builds will not use such. If one needs to match an official 12 or 11 build, using svn will likely be easier to do that with. If one can wait for the git -> svn delay before picking up src changes in the ongoing future, continuing to use svn for now may be easier. It may (eventually) be better to use what official builds use. But that still could mean svn for 12 and 11 until they are no longer supported and only changing to git for 13+ (at some point). > The last message on this list is still this one I'm replying to. FYI: there are (showing December threads style of access): = https://lists.freebsd.org/pipermail/freebsd-git/2020-December/thread.html = https://lists.freebsd.org/pipermail/dev-commits-src-main/2020-December/thr= ead.html They are probably better targets for your git related questions. > I'm new to git, I usually do not switch between several code revisions = systems, I assume > a lot of FreeBSD users are familiar with subversion and share my = problems of keeping > pace.=20 >=20 > =46rom the recent state of the list I assume its death. svn is not dead for various versions of FreeBSD. It will not be used for official 13+ builds, much like snapshots for 13 have not been using svn (or its -rDDDDDDDD identifications) for some time (despite svn for CURRENT being available for much of that time). > I can not find (easily) any hints > for those who were familiar with subversion and checking out /usr/src = either for > 12-STABLE, 12.1-RELENG, 12.2-RELENG, CURRENT. If one is going to use git for 12 and/or 11, one clones the same repository as for access to 13. Context matters for checkouts. I tend to identify a specific commit that I want to use, not just the most recent on a branch. (historically true for svn -rDDDDDD usage as well). But one does not clone such a specific git repository version. One gets a clone or updates a repository and then causes git to extract the desire version from it into the file system. This is messier than just taking the most recent commit for whatever branch of interest from whatever repository one uses (that is at least recent enough to contain what is of interest). But i've no clue if this is relevant to your usage patterns or not. So you may have to describe you intended usage criteria for picking what to check out. Otherwise the instructions may be misleading. It is also important to know if you need source trees for multiple branches at the same time vs. only one at a time. One at a time leads to only needing one copy of the repository but multiple at a time could be either with just one repository (multiple worktree's) or one repository each. There are disk space tradeoffs involved in such choices. So: more for you to provide some usage criteria for in order for any help to well match your intended context. (git has means of context switching what is seen in the file system, allowing switching branches in place. This is part of how "one at a time" can be relevant: one switches the context in the file system instead.) > For /usr/doc it was easy to "clone" the repository and, who would = doubt it, there were > some hints how-to-do. But how do I checkout /usr/src for either = CURRENT, 12.{1,2}-RELENG > and 12-STABLE? Where is the primer for those = "not-so-development-involved" people like > me? And were to and how to report problems in themanner of this list = regarding to certain > commits? There are various preliminary materials at: https://github.com/bsdimp/freebsd-git-docs/ including: https://github.com/bsdimp/freebsd-git-docs/blob/main/mini-primer.md and: https://github.com/bsdimp/freebsd-git-docs/blob/main/src-cvt.md But I've also been doing other explorations to find what fits my usage patterns or if there are patterns that I likely should change. I've done some "non-production" fiddling separate from my still-existing svn based context to get an idea what various things would end up being like to use. (I've even done some diff -r compares between some pre-existing svn contexts and analogous git ones that I tried to make.) I did catch that I have some "extra" files around that "svnlite diff" output would not reference for how I've been working. (So such a svnlite diff and a git apply of the diff output would not have covered those extra files.) The files happened to be kernel configuration files. Hopefully some of the above notes will prove of some use. =3D=3D=3D Mark Millard marklmi at yahoo.com ( dsl-only.net went away in early 2018-Mar) From owner-svn-src-head@freebsd.org Sat Dec 26 06:21:17 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C081F4D7DFF for ; Sat, 26 Dec 2020 06:21:17 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic312-25.consmr.mail.gq1.yahoo.com (sonic312-25.consmr.mail.gq1.yahoo.com [98.137.69.206]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4D2tx82ppPz4vDN for ; Sat, 26 Dec 2020 06:21:14 +0000 (UTC) (envelope-from marklmi@yahoo.com) X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1608963673; bh=nenpRzIG3ZjuQxNdhNSJfJ+xB/ABNrODZlKBw+6vqjS=; h=Subject:From:Date:To:From:Subject; b=j0MHFOoZyBkq5T/vzI+DjMQHZN5Tsm5QdXBGOAanZA8OFofW2LxMMZtS6usNpVAffiCkvRhgwa5tW0KP+o5pxTdLQ8wvePwhIL5pGeFYg98WSfaNuTnLq4PWmdymyIOFg2T34KH133LT9OTI6oHcQv7Fsrnf989gVPSVUeZ7PjbbQEn8fcgfhXvQk/7I1Tu3zIxrZW+8B9/xig6wroFwRON6udsq/66o+HhJpq1DiUcJonebAj8jX9g3J2kch5r1SJfdhcqDDmrtCnPef1tT+2oym+SC+D5advqGWTY1pWe1Qy3mR2fzqSYQGV/hShgVMSFSQ5DR3IBzD7eoBmDD8Q== X-YMail-OSG: Jph2zSwVM1lJzjkyp0Q9q_I_cmM7muM4iC_RlDJo5Hsle7qYgbamwZGbabF1iy1 KR.JfMdxREZkvu589fKr._9ttHgbEXIrVqgi0vimWgoPrftPADueJtEcotiOWEkUBx1GQpkqob4n lVozFfHwojSbj6FZAhKwe9LMbv5ORpLe__5hKB0Z4zhBJVD8OJyTQFTYmDAEimyqEddI7dRh0Int XJK9ksKq80YsxyjSKgH.oK7KgJnv5QUUu8xA_5JqB7kRyuUB7ExqtaCHUkXljq5Nb4UXo0RXe5R. Gd4ONzdTrfW4IUqXawP8BJhhYkTNCk0Hkby7ZfkwloUlfA0lJcTLGr.zjcg3AqCrJZ0FRxn37ZuG RdSJiCHtAw5KGK6MR21Gfy6YUIvZH2pfxGOBj7ReK1ZOUKaBcz_CnnT1w1DgH1fOF5TP.GOIAZUG CML6vzqU9opVXDX312chARIBUFh.LNgsLuFIzAbVkT.Y8pjuo8rzqIt14bkCG7ZdagPUx7GgIKw8 TC2eOZSTGzGWwfiF4jfX7jCTls0EhIclUDqPGK35Ah59myvgZHykbK5NBIIBaZzcu0RoDvPwreYk yulhufsTriazv9W4ud9TmHpboD1.IqV.GUciQIEYKJYtYTwlxN.ZZx48Dno0cvMjx031L1ChTjPJ 3elVZqC8ABYcFr03agSUISPMEEgFr56o4._BPalMtRB2_Ph_g4fFmuaTT.wB6_Dr9IabKEW3A9da h5zwtB_OhNeOwXy.BOUm2UqS0RhK.YucSxZLVwI7G8FBU02WTmY8DeN.2TDNBCt.Wf.GG8.Cigus UHmKgOXfmUTxn1EuKtswaPKI2rF1d1J_.ZRUwKGdK3rp8oc2z2XkQbKSwFVLDM6qo_ejmlt7lzrC 0UCsSuz.Otb396pbe9IcvSrp5m.JroJh38aywArjxQVNQoFO_ed.Ji6f.j4PQEq7ykRIHbC.Aqv0 V1GISDcw2XxmqU1wufYo6e2mCO8Zfi5MjB1zru3apSYSlK5WaUQCSHJBLLnyzeHfTQkDJpClX7qu X1C3FPYRdosB_VcWoG1oYS1CgzXJeuLSUXEZBjvj4HtplmX91k1B2lg6PlqJ98lhNzuMteIR0Auz ktFCBySO349SISrVQX0i8C18ha68lgqn7bym9nEG9nECtEoizUs9wUJZW1EeOE9QcoOwBtOI1.he 5Vhrpuztcac8l0D4OQBLVJa18oCUsxGCUqeNJFd81GKWn2bUdITreBs4ms22Dx4kwlJHFl6UxMA6 aCa4zTvtMv3HA.xJ9V0rZ4cVuxznYovWm73JXn.juLgtSHqMkM6aDjVHhNKvZynzeR1Mq2ZiYjAm DsR0PxDH5avdRNfS63zNgtjztue7qtYuj28LyUNgTaPr2bPeMODtwlzO.66TMexWpSessncM7v9T VLXanj3jZMaYW7h.hfCKa5Roxc.6HKnoXC58ElO0eHUc3_4M9SN1c750xTIZc_9J47dz01Pvqmix lxawe40erowed5C._BtBiIhj6MbHXxoem6WkvijiEPA3ITb1RzdvObb2eNezvIP7TTxFiAU2U5I1 ZqIXBmn8ksx1hLK6FsocDHXspq64pPSkzi9igUUW2exNYKatI5Qn0JCq3VhS4kueHO_sVQ2cLSp2 N0ubN6uFY7TJQ.7Yzkne2TH3J1GFg4MxP84Hb.XPEcvWrZOih2nl1YD.E35T_0jXZY1MryikNpUc 5DZiJSw2NE5HCYcHzgLpHgei3Krvkfj8MKTxWCvmU.iOlPKoZonJOAf1CTyNKmF8zX0ce8obfwpH g6.XXbGqpzrNRJ9o8BBpNWQovZ_R9RajmIx6wiw6epBgu6fe2ordz3mBgHztGHBCo4_fXFdHG7LU m.auyFfOx2NtIHXLH3xf8688OpdnqJPse.1MG5kJKwUuQNLb80BzpkI8.TJcsTr5Ho1WtN417XnB 6pkrfuB4EmpE2SoZ7qIUMTIjC5cb_uhG12Ww7thjCDc0COMR2cS80MiQMRo_yG4uF6qJR2QOTDYA e73UCCq.o9hfix2vV7GhCGEIVe.M4M3w52TtAvtJd.hbBtLx6zCBy64qJkRaZL0pEk.ThxnMKhVM PUZt5_toURfumxFb15Z3lsPoF1YfHPh3pcqcBLzk.hXA.5ZyTkZZWsK8UHBrGHN46ZAGH0crLGQD VZzFGL6to3DM_Ze6spOsHIjafnG6F21LH0yPFY0o61lrfQrjWoWIG4KZbch5PTkCxFWpx6jn0maq GN259omaf.MDq03BasE9qRRX_0dc_fwbueTznSuZjDzG0gW4gxB1lBy60CZEha5MheJT5e7mPCRH fTJJR_lVmE8taIKtoEgqwKkNLrk7w1BCkEdXXL72X8ZXXt9jBlUPtewbGxTZ4pjCLgbizsUtnpBr Jxf76vNtbcn22b8GeoZrSRE81nhIBqxb57gb_OOcHyyxoCXkpbdiuQHpV3ep6rhS3BL2S1LZ39RX l7O8dZtVzbC0t5dQrHMlsDhVtskh1GYN2_hs5L7lbSMdOI7HwV6.0XPE- Received: from sonic.gate.mail.ne1.yahoo.com by sonic312.consmr.mail.gq1.yahoo.com with HTTP; Sat, 26 Dec 2020 06:21:13 +0000 Received: by smtp415.mail.ne1.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 17010274051281d926f6507f0406dcfb; Sat, 26 Dec 2020 06:21:09 +0000 (UTC) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.20.0.2.21\)) Subject: Re: svn commit: r368820 - head From: Mark Millard In-Reply-To: <018DC607-28A9-4937-B5C5-10C5C1B06C43@yahoo.com> Date: Fri, 25 Dec 2020 22:21:07 -0800 Cc: svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <5354B066-58AF-4F81-A665-F727F4C264F6@yahoo.com> References: <018DC607-28A9-4937-B5C5-10C5C1B06C43@yahoo.com> To: o.hartmann@walstatt.org X-Mailer: Apple Mail (2.3654.20.0.2.21) X-Rspamd-Queue-Id: 4D2tx82ppPz4vDN X-Spamd-Bar: --- X-Spamd-Result: default: False [-3.50 / 15.00]; FREEMAIL_FROM(0.00)[yahoo.com]; MV_CASE(0.50)[]; TO_DN_NONE(0.00)[]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; DKIM_TRACE(0.00)[yahoo.com:+]; RCPT_COUNT_TWO(0.00)[2]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/20, country:US]; RBL_DBL_DONT_QUERY_IPS(0.00)[98.137.69.206:from]; DWL_DNSWL_NONE(0.00)[yahoo.com:dkim]; MID_RHS_MATCH_FROM(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; SPAMHAUS_ZRD(0.00)[98.137.69.206:from:127.0.2.255]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[98.137.69.206:from]; RWL_MAILSPIKE_POSSIBLE(0.00)[98.137.69.206:from]; RCVD_COUNT_TWO(0.00)[2]; MAILMAN_DEST(0.00)[svn-src-head] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Dec 2020 06:21:17 -0000 > On 2020-Dec-24, at 21:17, Mark Millard wrote: >=20 > Hartmann, O. o.hartmann at walstatt.org wrote on > Thu Dec 24 21:34:56 UTC 2020 : . . . I've done more exploring and so am more willing to be explicit about commands now that I've tried some of this. >> I can not find (easily) any hints >> for those who were familiar with subversion and checking out /usr/src = either for >> 12-STABLE, 12.1-RELENG, 12.2-RELENG, CURRENT. >=20 Presuming having each available at the same time in separate directory = trees, but only one repository, and sticking to the HEAD commit for each at the = time the local repository is updated from the remote one. Also presuming no = locally updated sources so there is nothing to clean up or put to the side . . . https://github.com/bsdimp/freebsd-git-docs/blob/main/faq.md has as its = first question: "How do I track -current and -stable with only one copy of the repo?" So = based on that text . . . The notations for the git branches for what you list are (in order): stable/12 releng/12.1 releng/12.2 main The later material will lead to there being 4 FreeBSD source trees (with = my arbitrary example paths that you might not want to use): /usr/fbsd/freebsd-current/ /usr/fbsd/freebsd-stable-12/ /usr/fbsd/freebsd-releng-12.1/ /usr/fbsd/freebsd-releng-12.2/ When following the general structure that uses worktrees that is = documented, you can have at most one worktree for a branch. (Adding branches that you = maintain to be related to those allows for more.) I'll indicate one worktree for = each but main. main gets no worktree: it already has a sufficient context. The initial setup (I picked an example URL): # mkdir -p /usr/fbsd # cd /usr/fbsd # git clone -o freebsd --config = remote.freebsd.fetch=3D'+refs/notes/*:refs/notes/*' \ ssh://anongit@git.freebsd.org/src.git freebsd-current # cd freebsd-current # git checkout main # git worktree add ../freebsd-stable-12 stable/12 # git worktree add ../freebsd-releng-12.1 releng/12.1 # git worktree add ../freebsd-releng-12.2 releng/12.2 Then, as an example of updating freebsd-current (the overall sequence = follows the FAQ but I'll note a variation later): # cd /usr/fbsd/freebsd-current # git checkout main # git pull --ff-only Note: For the below, the above needs to have been done first: the pull involves the fetch of the remote material, including for the use in the below. # cd ../freebsd-stable-12 # git merge --ff_only freebsd/stable/12 # cd ../freebsd-releng-12.1 # git merge --ff_only freebsd/releng/12.1 # cd ../freebsd-releng-12.2 # git merge --ff_only freebsd/stable/12 I'll note that elsewhere it is recommended to do (once for each login using git for FreeBSD source activity): # git config --global pull.ff only because those --ff-only uses are important to keeping history as FreeBSD intends it (linear) and --ff-only can be a default. (This will not cover the below variation.) The variation that I mentioned follows . . . You might not like needing to update freebsd-current in order to update, say, freebsd-stable-12 above. Avoiding the pull and using the analogous two commands in the proper order gives the following that only update the individual part of the fetch that was of interest. I show binding to branches to directories explicitly (checkout) but such would not be needed unless the binding for the directory tree had been changed. Note that the below is not using pull and so the config above does not cause --ff-only defaults to be involved: Be reliably explicit. # cd /usr/fbsd/freebsd-current # git fetch freebsd # git checkout main # git merge --ff-only freebsd/main vs. # cd /usr/fbsd/freebsd-current # git fetch freebsd # cd /usr/fbsd/freebsd-stable-12 # git checkout stable/12 # git merge --ff-only freebsd/stable/12 vs. # cd /usr/fbsd/freebsd-current # git fetch freebsd # cd /usr/fbsd/freebsd-releng-12.1 # git checkout releng/12.1 # git merge --ff-only freebsd/releng/12.1 vs. # cd /usr/fbsd/freebsd-current # git fetch freebsd # cd /usr/fbsd/freebsd-releng-12.2 # git checkout releng/12.2 # git merge --ff-only freebsd/releng/12.2 Note: After a fetch, one or more of the cd-checkout-merge sorts of sequences could be done without re-fetching. Part of what a "merge --ff-only" does is to move what the active branch refers to, in the cases above, to a (potentially) new place in newly fetched material. I hope that the above helps. It does not deal with picking out a specific commit out of the repository for a specific source directory tree. I do not know if you do such and it makes controlling the context more complicated to describe. Not tied to that, you may want to look at: https://github.com/bsdimp/freebsd-git-docs/blob/main/SUMMARY.md that organizes the existing material and may make it easier to pick out things to read. =3D=3D=3D Mark Millard marklmi at yahoo.com ( dsl-only.net went away in early 2018-Mar) From owner-svn-src-head@freebsd.org Sat Dec 26 06:47:03 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id CF0294B0633 for ; Sat, 26 Dec 2020 06:47:03 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic315-8.consmr.mail.gq1.yahoo.com (sonic315-8.consmr.mail.gq1.yahoo.com [98.137.65.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4D2vVt4VPZz4vt7 for ; Sat, 26 Dec 2020 06:47:02 +0000 (UTC) (envelope-from marklmi@yahoo.com) X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1608965220; bh=OOlukaNe8wZzmceqwk/EklGZsA2NuH3nE4+rN4CzD40=; h=Subject:From:Date:To:From:Subject; b=guJ5/Z+8X0rpxEYTe1D7syQmxZor9gmwqgMl3+T+220hCXYbqGiUV3a4R25LawBy++ST/YuAbaRfP1rWnZ58j+gnRQ0FGfUVJRAIATAMxbkCLMZnLwgJgYSahIIFsFvikJDlWIIu2vBaa5MIwRK6t4iEbss1X70PBoPZMw1TC6y0haBsWAyg0mCEfYRzcrK3S7jUkIz/X65dB2Jnn1wpBwNx2G1130X7Oad1QISo4pW/lEfLBr+EYkI1JHDgUIidanZQ5A0yelOKg4uAP5ZTL3nJ/SfRnpcrwpL8flTcsEq7ryXlal7mkkLHsMN2oa4N9g0QoP9MP5c8NcV1ZC/8oA== X-YMail-OSG: 5lbTnCcVM1nesimgpjAn5uAbDAPznsDA6tYoiVyT0wknJJq9FAr.NKN_XdiWY3O UIqMF9i82SeKonsMX1wTa7Htsyranxw27bgDdnewqzLomet32ZhPM3oWsn8SX_115Ry3Dicy8pkW 57dT8mm03IzisktQ.Sjq.PA5qrp.1ycQ1EyTRv8_A72bjxUGSM4pcvyn05UY9g3Lyc2x32vbjX0a NHH0HWkct72CIZoapT3GehZ8Oivlbw97AHNVaCRsmnXrBfcMCzNNj5uRA_D6rMxpRfHGvdAls8aO GvQuF.eqz1z6bKp3FcTQBYnHwsQm_kpOnxax7ToB2sXbDu7hcqAQNmDqEZWfTI_47Oy2TuTrSUPt EPZItS1TPGa12vbZp3103R.H467lRHEgD1PhUOGtzHeEAvguXzR8g9lEBtDXv.qvymXkuwlRL8fO h8k0aZwNQ59AeLdI0Hl1Ef94P8oCslEWV8CcO8wap8.DXoNKoFSby_URdiw_4iWPz.yT5NMJ7eZ2 cYfT8BHAFN8aKESYG2ohrOoO1xRfBL8PxCIWzg.kIbvPfkaCIcjyw73TJhri8PD1ooA2.U0d9s7f 555_GWyxmNhHgOvceXaCVpL5sgF.X86yB34SP1k6ZGrSB1TiNSA81y6P2mm7V0Z4WM3y8p.Eh._8 qggD1QA_btH7eDHhz2ek9w.aq7sdJ1shFFvQAxjCVE08ZfSRA.hk2P.R162lmxMMr9RDJ3A35m0B 0hgb04LVnR.2WyQfWlyCK9jWmgaa22lt_XMWUPLHg1GxqN6y.4sDas5CvBLpTneYZldZQdhbl15z taP6djTWODLJfL1NVhXcyyTLW8ofFQFXdtunNXoC1cgYR8P_NRkIMmdf2w9XuFeUDSzUY8KKkD3P shB9TpIRZJHlYeNcJOmtU2Xc4_o.DCKnVCwk7WMBJLcdP7Bi.Mv3oQHFTI8VgrSsJLGthpsVllUP 0xM3owFYgXq_mA15StJazUEEEAH6XOLRyfponkE3VLd3P48Q5abyTdUc6EIc9NCl0FwrTLKNAdox _._Mbz287BWwEylP1afvCp.MXrLH7nSt1vrK3W23xgGZjmRtuq0_g59GG8spXZXGiehlI8SR6ter jdQ19MrGUIqtWfUHmpFguk1bAEjjhO4hyOH7kwrsKX6Hkyp1OTewXQF.mLflYtOOCyf5YYzI1JJq assVnr15cs9k3iiPHShWYMW7TOO8BtgT8D2nbmLd3Q8lzyvIiZwfX0UfvGQuyxviZc.tAACBNWiA B.A1VTSCI0I_qrYJjCVlJV4ByUlao0sGPo0kbQ8fIH5FckQjDymOHKEY_bhpK_ro01zQk9NEPJ_v sYGW3dScqwcWTqshOIw_GuNz2ygRoBXMzr3mieluKjiBo96GTX48rnGx03Ujrwm07qJWin3BSibY e6NX62IKBa.X9E25TKHQxvrb9MfkPWaH_oislpudjHkR9wGEofnTduzwFfGLpBfqlPUpik.C8yx7 3bBzkHivM1Fa2q6.ik0sYfD93Z2G4rjuvAEeFttS6dXXkDu.G2kwSL6D4E_1EI8voLaSzBGWpeev WHsTIiFT12j5GNNSU7dh8hnPDO.JCrJl02XOgH_W63oZybbt6fXMaIT77jrWb9Q5CZ.RghwQc5_Y fGM4rYjzw2GYMGvjtA.joQ7zK5AwUQdUPVtqNRxv0G5plC.wx.QEQR151zfXOrFZyQJmB7DgPBgO fnr2GUGo5AegWZULZ4hoQ9mhAL6HdN2u5YVEdoRR5l5IfRpt.hauPyhkuUuJ0SjYSyM1nMmYDlK9 y.XI70I9nXKYLJc54n.R0oW.JW7swpFylDEosERe1FcgwxXSIo7VFvUAoOBDxfvKwiWbx9XtiQ_P ghalCMzrko1vqKIu7ZgrwLe4IO31czmjRldPz8I.Mjb_G0rhOcxpLRF69mqXo_UCzWwCTGbTGEvS hq5u6kMofkryeVzbb0eABGVdWpjqYYwnEDm0oSyP2V9jtZZgryTBQu8tVWyAdcgvPq2GW9GuPlIS PBPApBx0C5995kBjiK2UJkuJv8PTM6e1AkTuxZ7Ui6oTlQPlhqLOQLMet3lTymqo94MQcDwuW3tZ DcbfKtLLJbTW20KGchTwJdyORAFja1tnYfoL_72nGAcgqmwNicMic8oqW3GKudRkPJ0nRCRbDkfv VyOptTfWgGfjxzRTw6DWHs8h2BtoWYOgtZLPgmolPvQgMMg39ACoZcwORHP3F3NCv7RZg_xmmGZB KfU8PBCZVJbME71jlCt1.zHejiJjNAKYt78OuBoC4yA6imbyeaAbKFcDnmfSZ01RAD6IhLDoOQvW tL28WqlFJnNtPJya5Nsz8bgFG5DSYgtEyOG_XRG4GPDd4VhrcaOdRYhfqJ0n8Ue_Dh8OAslvD46g MSd.89nvRSHFI7BlcsTd9qElw3Tie3ZEVJbJUQDycOW5iko0HhfOuzmitU8O6NoNUiu4GabVWe9f 3zXboo0DYYQKKi6YmiUVQa3VYVUK92WI0xufgPMtjWdz9EoPFSPyVfYhl Received: from sonic.gate.mail.ne1.yahoo.com by sonic315.consmr.mail.gq1.yahoo.com with HTTP; Sat, 26 Dec 2020 06:47:00 +0000 Received: by smtp414.mail.gq1.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID d56913f8f62d690508504a933276e2d5; Sat, 26 Dec 2020 06:46:59 +0000 (UTC) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.20.0.2.21\)) Subject: Re: svn commit: r368820 - head From: Mark Millard In-Reply-To: <5354B066-58AF-4F81-A665-F727F4C264F6@yahoo.com> Date: Fri, 25 Dec 2020 22:46:57 -0800 Cc: svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <018DC607-28A9-4937-B5C5-10C5C1B06C43@yahoo.com> <5354B066-58AF-4F81-A665-F727F4C264F6@yahoo.com> To: o.hartmann@walstatt.org X-Mailer: Apple Mail (2.3654.20.0.2.21) X-Rspamd-Queue-Id: 4D2vVt4VPZz4vt7 X-Spamd-Bar: --- X-Spamd-Result: default: False [-3.50 / 15.00]; FREEMAIL_FROM(0.00)[yahoo.com]; MV_CASE(0.50)[]; TO_DN_NONE(0.00)[]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; DKIM_TRACE(0.00)[yahoo.com:+]; RCPT_COUNT_TWO(0.00)[2]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/20, country:US]; MID_RHS_MATCH_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[yahoo.com:dkim]; ARC_NA(0.00)[]; RBL_DBL_DONT_QUERY_IPS(0.00)[98.137.65.32:from]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; SPAMHAUS_ZRD(0.00)[98.137.65.32:from:127.0.2.255]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[98.137.65.32:from]; RWL_MAILSPIKE_POSSIBLE(0.00)[98.137.65.32:from]; RCVD_COUNT_TWO(0.00)[2]; MAILMAN_DEST(0.00)[svn-src-head] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Dec 2020 06:47:03 -0000 On 2020-Dec-25, at 22:21, Mark Millard wrote: >> On 2020-Dec-24, at 21:17, Mark Millard wrote: >>=20 >> Hartmann, O. o.hartmann at walstatt.org wrote on >> Thu Dec 24 21:34:56 UTC 2020 : > . . . Looks like I was over specific about where I did "git fetch" from and so made some sequences overcomplicated. So I adjust that this time. > I've done more exploring and so am more willing to be > explicit about commands now that I've tried some of this. >=20 >>> I can not find (easily) any hints >>> for those who were familiar with subversion and checking out = /usr/src either for >>> 12-STABLE, 12.1-RELENG, 12.2-RELENG, CURRENT. >>=20 >=20 > Presuming having each available at the same time in separate directory = trees, > but only one repository, and sticking to the HEAD commit for each at = the time > the local repository is updated from the remote one. Also presuming no = locally > updated sources so there is nothing to clean up or put to the side . . = . >=20 > https://github.com/bsdimp/freebsd-git-docs/blob/main/faq.md has as its = first question: >=20 > "How do I track -current and -stable with only one copy of the repo?" = So based > on that text . . . >=20 > The notations for the git branches for what you list are (in order): >=20 > stable/12 > releng/12.1 > releng/12.2 > main >=20 > The later material will lead to there being 4 FreeBSD source trees = (with my > arbitrary example paths that you might not want to use): >=20 > /usr/fbsd/freebsd-current/ > /usr/fbsd/freebsd-stable-12/ > /usr/fbsd/freebsd-releng-12.1/ > /usr/fbsd/freebsd-releng-12.2/ >=20 > When following the general structure that uses worktrees that is = documented, you > can have at most one worktree for a branch. (Adding branches that you = maintain > to be related to those allows for more.) I'll indicate one worktree = for each but > main. main gets no worktree: it already has a sufficient context. >=20 > The initial setup (I picked an example URL): >=20 > # mkdir -p /usr/fbsd > # cd /usr/fbsd > # git clone -o freebsd --config = remote.freebsd.fetch=3D'+refs/notes/*:refs/notes/*' \ > ssh://anongit@git.freebsd.org/src.git freebsd-current > # cd freebsd-current > # git checkout main > # git worktree add ../freebsd-stable-12 stable/12 > # git worktree add ../freebsd-releng-12.1 releng/12.1 > # git worktree add ../freebsd-releng-12.2 releng/12.2 >=20 > Then, as an example of updating freebsd-current (the overall sequence = follows > the FAQ but I'll note a variation later): >=20 > # cd /usr/fbsd/freebsd-current > # git checkout main > # git pull --ff-only >=20 > Note: For the below, the above needs to have been > done first: the pull involves the fetch of the > remote material, including for the use in the > below. >=20 > # cd ../freebsd-stable-12 > # git merge --ff_only freebsd/stable/12 > # cd ../freebsd-releng-12.1 > # git merge --ff_only freebsd/releng/12.1 > # cd ../freebsd-releng-12.2 > # git merge --ff_only freebsd/stable/12 >=20 > I'll note that elsewhere it is recommended to do (once > for each login using git for FreeBSD source activity): >=20 > # git config --global pull.ff only >=20 > because those --ff-only uses are important to keeping > history as FreeBSD intends it (linear) and --ff-only > can be a default. (This will not cover the below > variation.) >=20 >=20 > The variation that I mentioned follows . . . >=20 > You might not like needing to update freebsd-current in > order to update, say, freebsd-stable-12 above. Avoiding > the pull and using the analogous two commands in the > proper order gives the following that only update the > individual part of the fetch that was of interest. >=20 > I show binding to branches to directories explicitly > (checkout) but such would not be needed unless the > binding for the directory tree had been changed. Note > that the below is not using pull and so the config > above does not cause --ff-only defaults to be involved: > Be reliably explicit. >=20 >=20 > # cd /usr/fbsd/freebsd-current > # git fetch freebsd > # git checkout main > # git merge --ff-only freebsd/main >=20 > vs. >=20 Improved: # cd /usr/fbsd/freebsd-stable-12 # git fetch freebsd # git checkout stable/12 # git merge --ff-only freebsd/stable/12 > vs. >=20 Improved: # cd /usr/fbsd/freebsd-releng-12.1 # git fetch freebsd # git checkout releng/12.1 # git merge --ff-only freebsd/releng/12.1 > vs. >=20 Improved: # cd /usr/fbsd/freebsd-releng-12.2 # git fetch freebsd # git checkout releng/12.2 # git merge --ff-only freebsd/releng/12.2 >=20 > Note: After a fetch, one or more of the > cd-checkout-merge sorts of sequences could > be done without re-fetching. >=20 > Part of what a "merge --ff-only" does is to > move what the active branch refers to, in > the cases above, to a (potentially) new place > in newly fetched material. >=20 > I hope that the above helps. It does not deal with > picking out a specific commit out of the repository > for a specific source directory tree. I do not know > if you do such and it makes controlling the context > more complicated to describe. >=20 > Not tied to that, you may want to look at: >=20 > https://github.com/bsdimp/freebsd-git-docs/blob/main/SUMMARY.md >=20 > that organizes the existing material and may make > it easier to pick out things to read. =3D=3D=3D Mark Millard marklmi at yahoo.com ( dsl-only.net went away in early 2018-Mar)