From owner-freebsd-arch@freebsd.org Tue Mar 16 16:49:10 2021 Return-Path: Delivered-To: freebsd-arch@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2EB2E5B4AE5; Tue, 16 Mar 2021 16:49:10 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4F0K4k0v0Yz4nbQ; Tue, 16 Mar 2021 16:49:10 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-qv1-f52.google.com (mail-qv1-f52.google.com [209.85.219.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 0CD3E76DE; Tue, 16 Mar 2021 16:49:10 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-qv1-f52.google.com with SMTP id l15so9844785qvl.4; Tue, 16 Mar 2021 09:49:10 -0700 (PDT) X-Gm-Message-State: AOAM5336BUCy+ANTqn3eYq34bB2695SlBERXsBJl201bh50jE1MQiFW8 4ezh3gOGtXQIsxeonttLR8Lx1TRKnMv43K4stDA= X-Google-Smtp-Source: ABdhPJzi34QeuuOVEse/PFA41MQ0sLEBCfcjPCZtF6MJIU4MAD2F43d8XcxVIJylISCEjKpVOi7ZU5MBwDx/aFIZSqM= X-Received: by 2002:ad4:51c1:: with SMTP id p1mr582860qvq.39.1615913349559; Tue, 16 Mar 2021 09:49:09 -0700 (PDT) MIME-Version: 1.0 From: Kyle Evans Date: Tue, 16 Mar 2021 11:48:56 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Removing WireGuard Support From FreeBSD Base To: freebsd-arch@freebsd.org, FreeBSD Hackers , WireGuard mailing list Content-Type: text/plain; charset="UTF-8" X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Mar 2021 16:49:10 -0000 Hi, You may have recently noticed some chatter around the internet about FreeBSD's in-kernel WireGuard implementation, and the work we've done on it in the last week. You may have also noticed additional chatter afterwards with regards to the original implementation. I'd like to give some context and information with regards to the current situation, as well as provide some insight into the future as one of the developers involved. With regard to the original implementation, this will be my only commentary on the matter. I'm a developer, and I'm passionate about the work that I do- often to a fault. I've said some things that I regret; the accusations that Scott Long alluded to in an e-mail on FreeBSD mailing lists were indeed made by me, and his phrasing of what I said was much kinder than it could have been. These were mistakes, and I'm going to own that. However, my personal belief is that neither Netgate, pfSense, nor the original developer deserved the level of scorn and criticism that they've received in the past days from both the press and the community at large. In the next day or so, I will be committing a removal of all WireGuard related bits from our 'main' branch, including the work that I recently committed. It will be followed up by a removal of the implementation from stable/13, and we will seek appropriate approval to remove it from releng/13.0 as well. Please, do not be concerned by any of this; this is being done with mutual support from all parties. Did the original implementation have issues? Yes, it did. Are we certain that our new version -doesn't- have issues? I believe it doesn't, but it hasn't been through thorough enough review. We hacked on this for a week, and we all reviewed each others' work in the process. The problem is that this work, in particular, is a driver with fairly severe security implications. Review by "three developers working and beating on it" is not the higher bar that we should be holding this to. While I believed I was doing what's right for the community, it's become clear that what's right for the community is to take a step back and do this the right way. Note that we're not dropping this effort. We will continue iterating on this out-of-tree, and we will go through the proper review channels. Folks will be unhappy in the interim because we're removing it right now, but in the end we will have a better FreeBSD because of it. There will be a kernel module available in ports at some point, but not before it's ready. Moving forward, myself, members of Netgate, and members of the larger community *are* working together on strictly technical details. I urge anyone with an interest in reviewing the driver to also get in touch with me. Please, let's move forward as a community on this. Thank you, Kyle Evans