From owner-freebsd-arch@freebsd.org Thu Apr 8 05:26:49 2021 Return-Path: Delivered-To: freebsd-arch@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3FFF85CFF53 for ; Thu, 8 Apr 2021 05:26:49 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x72e.google.com (mail-qk1-x72e.google.com [IPv6:2607:f8b0:4864:20::72e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FG8rl73QKz3t47 for ; Thu, 8 Apr 2021 05:26:47 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x72e.google.com with SMTP id c4so1074780qkg.3 for ; Wed, 07 Apr 2021 22:26:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=HPIo7/EuC0y7gZEL4SZVeyWLTHrlt+jEByXbLSnYJsE=; b=nnEhS1qgjtXyQjiPzH5U18CPDq+LbIMLboTuJ4q9Pi5yLW5V6rMQh2KI42F5c3ITUg T1SdiQuxombucttFY2HLrEpYEd4vlg9tskCTEKewKQbpgIYN2VLMutbiNhMVaK6ZuDCR 5eD8RStSB0yjqRhjridPT8hYtHDaMZiL3g/r0SCSCVHT4XxUzuW68zAf2gg9KoX8kbja 9SJPMVTS7O+t9kTFxBCmf7xEJv3/Lxz55WVc1E1QbP9YHAkwmL7f8vdUBBE8bLL0vUkD oXZ/t+9pOYSklL63TKi+xbMTKazBoddxJ5mfmVyYCC7J9ePd7Jop1qsNJoDrCdBuIU5W d53g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=HPIo7/EuC0y7gZEL4SZVeyWLTHrlt+jEByXbLSnYJsE=; b=gUbyQk479bGwmYcrJ+FVwGYZIpuckyH2QGvs8RGfB89c/k6dZGyiyeGgEzf6F/2nBN N4q0FUS+QrRvXwd45XcLB3P532EJBUqoqJk/+lyH5AR11+/PXyVE5YQlksbEw1zTgWh4 lkw4DLQ+45t7A9cscaNAVFPkgoGco4Qjr1PJrdI/UlmJkWSLTqtJodSiIXWspQNuzNB/ MAlJdp2jhjNn/pE8tdfsSMRuZXbhmYeUXoy+ObxFfbw8dUlt9PZHzMRmspG5HmspUKlB Y255zNI/H89ek6DHY8F1rLl/Cq8drTHGohmqTcYeqU5TGTRt7UO/WyOBLbOvqH//9kx0 q0Xg== X-Gm-Message-State: AOAM531PmGdt1bQd+chJmjkuYirYqyj+R/TmMxIB7OMnFpZ7NA7N9EsL bGu2WlghTS5kXNxduQFOnrW3ZXs4bpXxVjY5Xtp9AHw5/iG6dAlY X-Google-Smtp-Source: ABdhPJyF11kSn1Bd2klcAnnzR3oAhyrayVLWt8qvL1tcHDcYE5C/gvdN717Hm0+LfpjS80ljmmqJ88vaXelHVEQmbKw= X-Received: by 2002:ae9:e010:: with SMTP id m16mr6708475qkk.44.1617859606467; Wed, 07 Apr 2021 22:26:46 -0700 (PDT) MIME-Version: 1.0 From: Warner Losh Date: Wed, 7 Apr 2021 23:26:35 -0600 Message-ID: Subject: Moving from .uu.o -> .o in the kernel To: "freebsd-arch@freebsd.org" X-Rspamd-Queue-Id: 4FG8rl73QKz3t47 X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=nnEhS1qg; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::72e) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-1.05 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.97)[-0.967]; RCVD_COUNT_TWO(0.00)[2]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-arch@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; RCPT_COUNT_ONE(0.00)[1]; SPAMHAUS_ZRD(0.00)[2607:f8b0:4864:20::72e:from:127.0.2.255]; NEURAL_SPAM_SHORT(0.92)[0.919]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::72e:from]; TO_DN_EQ_ADDR_ALL(0.00)[]; R_SPF_NA(0.00)[no SPF record]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RBL_DBL_DONT_QUERY_IPS(0.00)[2607:f8b0:4864:20::72e:from]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_TLS_ALL(0.00)[]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; MAILMAN_DEST(0.00)[freebsd-arch] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Apr 2021 05:26:49 -0000 Greetings, In preparations for bringing a new vendor driver in, I realized that one of the promises of svn was that one could store .o files in the repo. We never did that, preferring to stick with the old CVS trick of storing the .o files as .o.uu files and converting them as part of the build process. Well, now that we've moved to git, it's time to retool. I've taken the liberty of converting two of the hpt* drivers. These drivers are on the edge of relevance, it is true. However, I'm not here to talk about that today. I'm also not here to talk about whether or not this is evil. I'm not changing any defaults, they still won't be in GENERIC and they still won't be built as modules if you have sourceless turned on. So if you want to talk about those topics, get your own thread :) My proposal is to simplify. I propose that we remove the .uu files and just commit the .o files and adjust the build to simplify it. It turns out that our config(8) knows that when there's a .o in the kernel files* file, just to copy that .o file over when the driver is in the tree. I've done hptnr and hpt27xx rather arbitrarily to get the hang of this and have uploaded the diffs to phabricator for review. I plan on doing the rest of these files this way. https://reviews.freebsd.org/D29632 https://reviews.freebsd.org/D29634 Comments? Warner From owner-freebsd-arch@freebsd.org Thu Apr 8 07:03:04 2021 Return-Path: Delivered-To: freebsd-arch@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 177975D24BD for ; Thu, 8 Apr 2021 07:03:04 +0000 (UTC) (envelope-from markm@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FGBzr05R5z4TsP; Thu, 8 Apr 2021 07:03:04 +0000 (UTC) (envelope-from markm@FreeBSD.org) Received: from [IPv6:2a02:8011:300b:42:a0a2:e1dc:4429:ab77] (unknown [IPv6:2a02:8011:300b:42:a0a2:e1dc:4429:ab77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: markm) by smtp.freebsd.org (Postfix) with ESMTPSA id 816ED1F5; Thu, 8 Apr 2021 07:03:03 +0000 (UTC) (envelope-from markm@FreeBSD.org) Content-Type: multipart/signed; boundary="Apple-Mail=_65A85F42-9322-462A-9E60-8F201B99C2D1"; protocol="application/pgp-signature"; micalg=pgp-sha512 Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) Subject: Re: Moving from .uu.o -> .o in the kernel From: Mark Murray In-Reply-To: Date: Thu, 8 Apr 2021 08:03:00 +0100 Cc: "freebsd-arch@freebsd.org" Message-Id: <91F01713-75D3-40B6-83C0-BBD9B5467AEC@FreeBSD.org> References: To: Warner Losh X-Mailer: Apple Mail (2.3654.60.0.2.21) X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Apr 2021 07:03:04 -0000 --Apple-Mail=_65A85F42-9322-462A-9E60-8F201B99C2D1 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii Greetings, > On 8 Apr 2021, at 06:26, Warner Losh wrote: > My proposal is to simplify. I propose that we remove the .uu files and just > commit the .o files and adjust the build to simplify it. It turns out that > our config(8) knows that when there's a .o in the kernel files* file, just > to copy that .o file over when the driver is in the tree. Go for it. This is an obvious removal of technical debt. M -- Mark R V Murray --Apple-Mail=_65A85F42-9322-462A-9E60-8F201B99C2D1 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.2 Comment: GPGTools - http://gpgtools.org iQEzBAEBCgAdFiEEyzPHvybPbOpU9MCxQlsJDh9CUqAFAmBuqqQACgkQQlsJDh9C UqBjNAf+P15lSBR0GBHufljULnk1j0SzRZhFZr1z2DcekMWqy5DstH8EVuhSEibm y3+nv73w/1y4H7CEO0SEGLx2GJ5V66tIh+ugx2XuBuTou98n+14CS/SkqPla3lS6 qm3wHJk4ESfKv2jD54t6F6ag3We4K0WR7F+qZnWWm/q/DVodIuL1v+k4bTWpdcsC 5ZCkF7s0+AAlhYjwOHyoMwxg8ZAXYYPfZixolf/Ccfi0tJZlk9CW3636u16P1LoJ JojnwZ6CxVIfZAdR/n44PpkuaP3XRligmikK8zqHDAZ0+gcHHxufSRU7yOaLs4yi m0LtWbkwP2D2tS6Iqys4J3yG2DAsmA== =7MJr -----END PGP SIGNATURE----- --Apple-Mail=_65A85F42-9322-462A-9E60-8F201B99C2D1-- From owner-freebsd-arch@freebsd.org Thu Apr 8 13:15:51 2021 Return-Path: Delivered-To: freebsd-arch@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5BBCF5DC3F3 for ; Thu, 8 Apr 2021 13:15:51 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from mx1.sbone.de (cross.sbone.de [195.201.62.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx1.sbone.de", Issuer "SBone.DE" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FGMFy4CCmz3DHF for ; Thu, 8 Apr 2021 13:15:49 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:31::2013:587]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.sbone.de (Postfix) with ESMTPS id 2465B8D4A178; Thu, 8 Apr 2021 13:15:41 +0000 (UTC) Received: from content-filter.sbone.de (content-filter.sbone.de [IPv6:fde9:577b:c1a9:31::2013:2742]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id 20B9BE707C4; Thu, 8 Apr 2021 13:15:41 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:31::2013:587]) by content-filter.sbone.de (content-filter.sbone.de [fde9:577b:c1a9:31::2013:2742]) (amavisd-new, port 10024) with ESMTP id GXynoMP1wLjm; Thu, 8 Apr 2021 13:15:39 +0000 (UTC) Received: from [169.254.73.94] (unknown [IPv6:fde9:577b:c1a9:4902:e98d:57f7:87e4:1796]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id D7099E707BB; Thu, 8 Apr 2021 13:15:39 +0000 (UTC) From: "Bjoern A. Zeeb" To: "Warner Losh" Cc: freebsd-arch@freebsd.org Subject: Re: Moving from .uu.o -> .o in the kernel Date: Thu, 08 Apr 2021 13:15:38 +0000 X-Mailer: MailMate (2.0BETAr6151) Message-ID: In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4FGMFy4CCmz3DHF X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of bzeeb-lists@lists.zabbadoz.net designates 195.201.62.131 as permitted sender) smtp.mailfrom=bzeeb-lists@lists.zabbadoz.net X-Spamd-Result: default: False [-3.30 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; RCVD_COUNT_FIVE(0.00)[5]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:195.201.62.131]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[zabbadoz.net]; RBL_DBL_DONT_QUERY_IPS(0.00)[195.201.62.131:from]; SPAMHAUS_ZRD(0.00)[195.201.62.131:from:127.0.2.255]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_SHORT(-1.00)[-1.000]; RCPT_COUNT_TWO(0.00)[2]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:24940, ipnet:195.201.0.0/16, country:DE]; RCVD_TLS_LAST(0.00)[]; MAILMAN_DEST(0.00)[freebsd-arch] X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Apr 2021 13:15:51 -0000 On 8 Apr 2021, at 5:26, Warner Losh wrote: Hi, > In preparations for bringing a new vendor driver in, I realized that > one of > the promises of svn was that one could store .o files in the repo. We > never > did that, preferring to stick with the old CVS trick of storing the .o > files as .o.uu files and converting them as part of the build process. > .. > > My proposal is to simplify. I propose that we remove the .uu files and > just > commit the .o files and adjust the build to simplify it. It turns out > that > our config(8) knows that when there's a .o in the kernel files* file, > just > to copy that .o file over when the driver is in the tree. and we’ve done similar things for, e.g., firmware files storing the binary rather than the uuencoded versions in the tree. I am all for the simplification! I am a bit concerned with .o files in random places in the source tree though as they may show up and various tooling people have might clean them up. I’d suggested to keep it in mind and go ahead and do a few and see if it becomes a practical issue rather than just a theoretical one before taking any actions .. /bz From owner-freebsd-arch@freebsd.org Thu Apr 8 13:51:14 2021 Return-Path: Delivered-To: freebsd-arch@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id CD1575DD30D for ; Thu, 8 Apr 2021 13:51:14 +0000 (UTC) (envelope-from freebsd@grem.de) Received: from mail.evolve.de (mail.evolve.de [213.239.217.29]) (using TLSv1.3 with cipher TLS_CHACHA20_POLY1305_SHA256 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA512 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mail.evolve.de", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FGN2m6NXwz3H2Q for ; Thu, 8 Apr 2021 13:51:12 +0000 (UTC) (envelope-from freebsd@grem.de) Received: by mail.evolve.de (OpenSMTPD) with ESMTP id 719dad9e; Thu, 8 Apr 2021 13:51:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=grem.de; h=date:from:to:cc :subject:message-id:in-reply-to:references:mime-version :content-type:content-transfer-encoding; s=20180501; bh=XqYeX88v DxiONEz/v3DWVZI1PL0=; b=kTR4AbHIBdboeDvZ8bB/prbo8QBJm4+yUEad6607 HH54tOWdn9arqNEv8LPr1N7QRalPbtDY1wNXPa0aermyQMYNHrVL90yLek84MK2v CquWV3nJiiH7eyKdkT/Kp1rY3yTnFJLq7ybvHGRHx9nTMg8CNhiFlwoLuL9D4hD9 R0CTkm5I6bcR8wjACrtVgUibLyjNkGDHURCza+WMcKT8QtiGETvUboU2q2+9S2zX pAvMsvXjScpXOmLJB6zPju7tCkrZTZtkiKUGnaRjyjX9Yeu9wEyZmW/u0++gDwPu Jo1oCORvbZHXW+XHbDzJIkcpTdnGYSkhchKPNKhBGZlIUA== DomainKey-Signature: a=rsa-sha1; c=nofws; d=grem.de; h=date:from:to:cc :subject:message-id:in-reply-to:references:mime-version :content-type:content-transfer-encoding; q=dns; s=20180501; b=rn BLxcfudB2jSkakDyHwaKZBAruUKDBKviJK896pXQr6J1n5SRWnCdEuQ6nSpltMvI igDk0ZsunP9eOexRmWQMTlxR7TViu4EAWNK4iF9a5qEhYbXSRZhygzevc4b+Q0tN /bNdspF5iEdSPotXSYxsnvmqV45ZzCdZfWKQrGaC+BJfu2OYkrgKcbD6QFiaL0wF i+CCjvUkCE9EB4h/sStk/0K1xqyGPRvY4O4M1dwact9zhoy5HOKFPI/rVTKtZNSz 5qJEkSeEZY0wLJ0TuSE1+1AisnWZWZ8xSttoAmgehbLRB4u0GIzYN8Pwt8OGOMDN tMdCUjeDTCu5Y2lmBMrQ== Received: by mail.evolve.de (OpenSMTPD) with ESMTPSA id 4c367ec2 (TLSv1.3:AEAD-CHACHA20-POLY1305-SHA256:256:NO); Thu, 8 Apr 2021 13:51:08 +0000 (UTC) Date: Thu, 8 Apr 2021 15:50:40 +0200 From: Michael Gmelin To: "Bjoern A. Zeeb" Cc: "Warner Losh" , freebsd-arch@freebsd.org Subject: Re: Moving from .uu.o -> .o in the kernel Message-ID: <20210408155040.7e2e6910@bsd64.grem.de> In-Reply-To: References: X-Face: $wrgCtfdVw_H9WAY?S&9+/F"!41z'L$uo*WzT8miX?kZ~W~Lr5W7v?j0Sde\mwB&/ypo^}> +a'4xMc^^KroE~+v^&^#[B">soBo1y6(TW6#UZiC]o>C6`ej+i Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWJBwe5BQDl LASZU0/LTEWEfHbyj0Txi32+sKrp1Mv944X8/fm1rS+cAAAACXBIWXMAAAsTAAAL EwEAmpwYAAAAB3RJTUUH3wESCxwC7OBhbgAAACFpVFh0Q29tbWVudAAAAAAAQ3Jl YXRlZCB3aXRoIFRoZSBHSU1QbbCXAAAAAghJREFUOMu11DFvEzEUAGCfEhBVFzuq AKkLd0O6VrIQsLXVSZXoWE5N1K3DobBBA9fQpRWc8OkWouaIjedWKiyREOKs+3PY fvalCNjgLVHeF7/3bMtBzV8C/VsQ8tecEgCcDgrzjekwKZ7TwsJZd/ywEKwwP+ZM 8P3drTsAwWn2mpWuDDuYiK1bFs6De0KUUFw0tWxm+D4AIhuuvZqtyWYeO7jQ4Aea 7jUqI+ixhQoHex4WshEvSXdood7stlv4oSuFOC4tqGcr0NjEqXgV4mMJO38nld4+ xKNxRDon7khyKVqY7YR4d+Cg0OMrkWXZOM7YDkEfKiilCn1qYv4mighZiynuHHOA Wq9QJq+BIES7lMFUtcikMnkDGHUoncA+uHgrP0ctIEqfwLHzeSo+eUA66AqzwN6n 2ZHJhw6Qh/PoyC/QENyEyC/AyNjq74Bs+3UH0xYwzDUC4B97HgLocg1QLYgDDO1v f3UX9Y307Ew4AHh67YAFFsxEpkXwpXY3eIgMhAAE3R19L919nNnuD2wlPcDE3UeT L2ytEICQib9BXgS2fU8PrD82ToYO1OEmMSnYTjSqSv9wdC0tPYC+rQRQD9ESnldF CyqfmiYW+tlALt8gH2xrMdC/youbjzPXEun+/ReXsMCDyve3dZc09fn2Oas8oXGc Jj6/fOeK5UmSMPmf/jL+GD8BEj0k/Fn6IO4AAAAASUVORK5CYII= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4FGN2m6NXwz3H2Q X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=grem.de header.s=20180501 header.b=kTR4AbHI; dmarc=none; spf=pass (mx1.freebsd.org: domain of freebsd@grem.de designates 213.239.217.29 as permitted sender) smtp.mailfrom=freebsd@grem.de X-Spamd-Result: default: False [-3.50 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[grem.de:s=20180501]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:213.239.217.29/32]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[grem.de]; NEURAL_HAM_LONG(-1.00)[-1.000]; SPAMHAUS_ZRD(0.00)[213.239.217.29:from:127.0.2.255]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[grem.de:+]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RBL_DBL_DONT_QUERY_IPS(0.00)[213.239.217.29:from]; ASN(0.00)[asn:24940, ipnet:213.239.192.0/18, country:DE]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[freebsd-arch] X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Apr 2021 13:51:14 -0000 On Thu, 08 Apr 2021 13:15:38 +0000 "Bjoern A. Zeeb" wrote: > On 8 Apr 2021, at 5:26, Warner Losh wrote: >=20 > Hi, >=20 > > In preparations for bringing a new vendor driver in, I realized > > that one of > > the promises of svn was that one could store .o files in the repo. > > We never > > did that, preferring to stick with the old CVS trick of storing the > > .o files as .o.uu files and converting them as part of the build > > process.=20 > .. > > > > My proposal is to simplify. I propose that we remove the .uu files > > and just > > commit the .o files and adjust the build to simplify it. It turns > > out that > > our config(8) knows that when there's a .o in the kernel files* > > file, just > > to copy that .o file over when the driver is in the tree. =20 >=20 >=20 > and we=E2=80=99ve done similar things for, e.g., firmware files storing t= he=20 > binary > rather than the uuencoded versions in the tree. I am all for the=20 > simplification! >=20 >=20 > I am a bit concerned with .o files in random places in the source > tree though as > they may show up and various tooling people have might clean them up. > I=E2=80=99d suggested to keep it in mind and go ahead and do a few and se= e if=20 > it becomes > a practical issue rather than just a theoretical one before taking > any actions .. Personally, I would prefer to use a custom extension (like .obj, .srco, .bin, ...) as finger memory will produce things like `find . -name \*.o -delete' (and tooling, like Bjoern said, might bite us as well). If you still decide to use the .o extension, I would make sure to - keep *.o in the top-level .gitignore file to avoid checking in objects by accident. - explicitly make exemptions where needed. So, e.g., .gitignore would contain *.o, while sys/contrib/dev/mwl/.gitignore would contain !mwlboot.fw.o !mw88W8363.fw.o to explicitly just exclude the files in question from being ignored. Best, Michael >=20 >=20 > /bz > _______________________________________________ > freebsd-arch@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-arch > To unsubscribe, send any mail to > "freebsd-arch-unsubscribe@freebsd.org" --=20 Michael Gmelin From owner-freebsd-arch@freebsd.org Fri Apr 9 09:56:33 2021 Return-Path: Delivered-To: freebsd-arch@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 960525D2163 for ; Fri, 9 Apr 2021 09:56:33 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4FGtnY2xFBz4X12 for ; Fri, 9 Apr 2021 09:56:33 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: by mailman.nyi.freebsd.org (Postfix) id 6212B5D22F5; Fri, 9 Apr 2021 09:56:33 +0000 (UTC) Delivered-To: arch@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 608D55D1EFE for ; Fri, 9 Apr 2021 09:56:33 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4FGtnX5WmZz4X10 for ; Fri, 9 Apr 2021 09:56:29 +0000 (UTC) (envelope-from avg@FreeBSD.org) X-Originating-IP: 195.64.148.76 Received: from [192.168.0.88] (unknown [195.64.148.76]) (Authenticated sender: andriy.gapon@uabsd.com) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 55268E000A for ; Fri, 9 Apr 2021 09:56:27 +0000 (UTC) From: Andriy Gapon Subject: adaptive spinning: fall back to sleep / block? To: arch@FreeBSD.org References: <202102251856.11PIuxwF020948@gitrepo.freebsd.org> <19884f0f-115d-a60c-2ef2-72400f96f8a7@uabsd.com> Message-ID: Date: Fri, 9 Apr 2021 12:56:26 +0300 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4FGtnX5WmZz4X10 X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [0.00 / 15.00]; ASN(0.00)[asn:29169, ipnet:217.70.176.0/20, country:FR]; local_wl_from(0.00)[FreeBSD.org] X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Apr 2021 09:56:33 -0000 Until I recently looked at the actual code I was under an impression that the adaptive spinning is bounded and that after some time / number of spins a thread would go to a sleep queue or a turnstile. But it looks that the spinning is actually unbounded as long as its conditions hold (some other thread owns the lock and that thread is running, the owner could be changing too). In my opinion, it does not make sense to spin for "too long". If there was not an opportunity to take a lock quickly, then it's better to block waiting for it rather than keep occupying a processor. For instance, the spinning can prevent another runnable thread from running. I think that if a lock is heavily contended or its hold times are on the longer side (or both), then the adaptive spinning can make the system behavior (performance, responsiveness) worse. Finally, I was under an impression that 'adaptive' meant some heuristic on whether and when to do the spinning. _A lock owner is running_ seems to be too simple to qualify as 'adaptive'. As an example, this looks like a relatively sophisticated implementation of the "adaptiveness": http://hg.openjdk.java.net/jdk8/jdk8/hotspot/file/87ee5ee27509/src/share/vm/runtime/objectMonitor.cpp#l1919 But, JIMHO, simply having a hard limit on the spin count would be better than what we have now. P.S. This is not an area that I know well, so my confusion and ideas may be absurd. On the other hand, I could not find any justification for the current unbounded "adaptive" spinning. -- Andriy Gapon