Date: Mon, 12 Apr 2021 13:55:30 -0600 From: Warner Losh <imp@bsdimp.com> To: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net> Cc: "freebsd-arch@freebsd.org" <freebsd-arch@freebsd.org> Subject: Re: Moving from .uu.o -> .o in the kernel Message-ID: <CANCZdfrCxYJtMHms7eHj23=Cm7mYsxDrZO64LJaHGym3jrksvg@mail.gmail.com> In-Reply-To: <C1ACBE79-0A5C-4D29-9223-630C21C5C9F9@lists.zabbadoz.net> References: <CANCZdfrKziKig4H_dTyDqF-WKMuTpMrpWa3QyCtyOmOwNt_wzA@mail.gmail.com> <C1ACBE79-0A5C-4D29-9223-630C21C5C9F9@lists.zabbadoz.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Apr 8, 2021 at 7:15 AM Bjoern A. Zeeb < bzeeb-lists@lists.zabbadoz.net> wrote: > On 8 Apr 2021, at 5:26, Warner Losh wrote: > > Hi, > > > In preparations for bringing a new vendor driver in, I realized that > > one of > > the promises of svn was that one could store .o files in the repo. We > > never > > did that, preferring to stick with the old CVS trick of storing the .o > > files as .o.uu files and converting them as part of the build process. > > > .. > > > > My proposal is to simplify. I propose that we remove the .uu files and > > just > > commit the .o files and adjust the build to simplify it. It turns out > > that > > our config(8) knows that when there's a .o in the kernel files* file, > > just > > to copy that .o file over when the driver is in the tree. > > > and we=E2=80=99ve done similar things for, e.g., firmware files storing t= he > binary > rather than the uuencoded versions in the tree. I am all for the > simplification! > > > I am a bit concerned with .o files in random places in the source tree > though as > they may show up and various tooling people have might clean them up. > I=E2=80=99d suggested to keep it in mind and go ahead and do a few and se= e if > it becomes > a practical issue rather than just a theoretical one before taking any > actions .. > I'm about to push the changes to the tree based on the discussions in this thread. In the end, I adopted this view: I'm going to create the .o files and if there's a lot of grief that results, I'll name them something else. My reasoning is that there's a benefit from naming them .o since config has a built in rule to copy them (it's only built-in rule) so we'd simplify things where otherwise we'd need to ad= d a cp rule in a number of places for a currently ill defined benefit of not breaking other people's tooling. I suspect that the number of places that break will be low to non-existent in practice. Should that turn out not to be the case, I'll revisit. I'll also monitor all the usual channels for breakage complaints. I'm not doing all the .uu files at this time. Just the .o.uu files. I'll look to the other ones as time requires it. I do not plan on merging this to 12.x, but will to 13.x. Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfrCxYJtMHms7eHj23=Cm7mYsxDrZO64LJaHGym3jrksvg>