From owner-freebsd-security@freebsd.org Sun Jan 31 11:29:24 2021 Return-Path: Delivered-To: freebsd-security@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D4C6D4F104C for ; Sun, 31 Jan 2021 11:29:24 +0000 (UTC) (envelope-from SRS0=Af1q=HC=quip.cz=000.fbsd@elsa.codelab.cz) Received: from elsa.codelab.cz (elsa.codelab.cz [94.124.105.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4DT8436Vswz3D8S; Sun, 31 Jan 2021 11:29:23 +0000 (UTC) (envelope-from SRS0=Af1q=HC=quip.cz=000.fbsd@elsa.codelab.cz) Received: from elsa.codelab.cz (localhost [127.0.0.1]) by elsa.codelab.cz (Postfix) with ESMTP id 2510128417; Sun, 31 Jan 2021 12:29:15 +0100 (CET) Received: from illbsd.quip.test (ip-94-113-69-69.net.upcbroadband.cz [94.113.69.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by elsa.codelab.cz (Postfix) with ESMTPSA id CB91228416; Sun, 31 Jan 2021 12:29:13 +0100 (CET) Subject: Re: [FreeBSD-Announce] FreeBSD Security Advisory FreeBSD-SA-21:01.fsdisclosure To: freebsd-security@freebsd.org, FreeBSD Security Advisories References: <20210129022826.C82C91DB44@freefall.freebsd.org> From: Miroslav Lachman <000.fbsd@quip.cz> Message-ID: Date: Sun, 31 Jan 2021 12:29:12 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210129022826.C82C91DB44@freefall.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4DT8436Vswz3D8S X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of SRS0=Af1q=HC=quip.cz=000.fbsd@elsa.codelab.cz has no SPF policy when checking 94.124.105.4) smtp.mailfrom=SRS0=Af1q=HC=quip.cz=000.fbsd@elsa.codelab.cz X-Spamd-Result: default: False [-1.80 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[quip.cz]; RBL_DBL_DONT_QUERY_IPS(0.00)[94.124.105.4:from]; AUTH_NA(1.00)[]; SPAMHAUS_ZRD(0.00)[94.124.105.4:from:127.0.2.255]; RCVD_COUNT_THREE(0.00)[3]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; RCPT_COUNT_TWO(0.00)[2]; R_SPF_NA(0.00)[no SPF record]; FORGED_SENDER(0.30)[000.fbsd@quip.cz,SRS0=Af1q=HC=quip.cz=000.fbsd@elsa.codelab.cz]; RECEIVED_SPAMHAUS_PBL(0.00)[94.113.69.69:received]; RCVD_TLS_LAST(0.00)[]; R_DKIM_NA(0.00)[]; ASN(0.00)[asn:42000, ipnet:94.124.104.0/21, country:CZ]; MIME_TRACE(0.00)[0:+]; FROM_NEQ_ENVFROM(0.00)[000.fbsd@quip.cz,SRS0=Af1q=HC=quip.cz=000.fbsd@elsa.codelab.cz]; MAILMAN_DEST(0.00)[freebsd-security] X-BeenThere: freebsd-security@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: "Security issues \[members-only posting\]" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Jan 2021 11:29:24 -0000 On 29/01/2021 03:28, FreeBSD Security Advisories wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA512 > > ============================================================================= > FreeBSD-SA-21:01.fsdisclosure Security Advisory > The FreeBSD Project > > Topic: Uninitialized kernel stack leaks in several file systems > > Category: core > Module: fs > Announced: 2021-01-29 > Credits: Syed Faraz Abrar > Affects: All supported versions of FreeBSD. > Corrected: 2021-01-06 14:58:41 UTC (stable/12, 12.2-STABLE) > 2021-01-29 01:20:59 UTC (releng/12.2, 12.2-RELEASE-p3) > 2021-01-29 01:06:09 UTC (releng/12.1, 12.1-RELEASE-p13) > 2021-01-18 19:16:24 UTC (stable/11, 11.4-STABLE) > 2021-01-29 00:20:09 UTC (releng/11.4, 11.4-RELEASE-p7) > CVE Name: CVE-2020-25578, CVE-2020-25579 > > For general information regarding FreeBSD Security Advisories, > including descriptions of the fields above, security branches, and the > following sections, please visit . > > I. Background > > The FreeBSD kernel exports file system directory entries to userspace > using the generic "dirent" structure. Individual file systems implement > VOP_READDIR to convert from the file system's internal directory entry > layout to the generic form. dirent structures can be fetched from > userspace using the getdirentries(2) system call. > > II. Problem Description > > Several file systems were not properly initializing the d_off field of > the dirent structures returned by VOP_READDIR. In particular, tmpfs(5), > smbfs(5), autofs(5) and mqueuefs(5) were failing to do so. As a result, > eight uninitialized kernel stack bytes may be leaked to userspace by > these file systems. This problem is not present in FreeBSD 11. There is a Corrected in: stable/11, 11.4-STABLE and releng/11.4, 11.4-RELEASE-p7, but later is a statement "This problem is not present in FreeBSD 11". What is true? Is it fixed in newer patchlevel of FreeBSD 11.4 or it was not present in 11.x at all? Kind regards Miroslav Lachman