From owner-freebsd-stable@freebsd.org Sun Apr 4 05:45:11 2021 Return-Path: Delivered-To: freebsd-stable@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id CE75E5CBA2E for ; Sun, 4 Apr 2021 05:45:11 +0000 (UTC) (envelope-from danny@cs.huji.ac.il) Received: from kabab.cs.huji.ac.il (kabab.cs.huji.ac.il [132.65.116.210]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4FCjRp2XLlz4SpY for ; Sun, 4 Apr 2021 05:45:10 +0000 (UTC) (envelope-from danny@cs.huji.ac.il) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=cs.huji.ac.il; s=57791128; h=References:To:Cc:In-Reply-To:Date:Subject:Mime-Version:Content-Type:Message-Id:From; bh=hiOtskUHD/W2KTDve3itO6xVu2YyBCxKEswC2HY4Fq4=; b=BKwygcW4A/RRcxVYo6U0VbfJoYSQe42HZKH0XKYOvcb354/hfY3OI+OSX+iK0ZXhfgU2K39He4xNgA6gTI8NXUzsKn2K7vWQAmUPdR5jb4i9Uen57a+LXI4TZes/XfXMoARH24sUZaLS828A+DGttfJ+97rMbEnik9hOy+NrSbap6fXAR/mlV92TK41vtUt6Hw0D8lWaK1yyM0NL86AFxkOolchPCOLkCg544RkpwUMv9b2BhmZAenGVwH8L0w3/YbNXcy9CgTdu0OcE5RS71nEXK2d8antIxQXiTliKRZvtanPdk7nQLVe+skLuJCsM4KO7K1ZHNFi1Iujrn59l9g==; Received: from bach.cs.huji.ac.il ([132.65.80.20]) by kabab.cs.huji.ac.il with esmtp id 1lSvZE-000ERw-TQ; Sun, 04 Apr 2021 08:45:00 +0300 From: Daniel Braniss Message-Id: <2596EB2A-8C43-42E5-947A-80EAAFE56EF7@cs.huji.ac.il> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) Subject: Re: current make world brakes if HESIOD enabled Date: Sun, 4 Apr 2021 08:45:00 +0300 In-Reply-To: Cc: FreeBSD-STABLE Mailing List To: Warner Losh References: X-Mailer: Apple Mail (2.3654.60.0.2.21) X-Rspamd-Queue-Id: 4FCjRp2XLlz4SpY X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=cs.huji.ac.il header.s=57791128 header.b=BKwygcW4; dmarc=pass (policy=none) header.from=huji.ac.il; spf=none (mx1.freebsd.org: domain of danny@cs.huji.ac.il has no SPF policy when checking 132.65.116.210) smtp.mailfrom=danny@cs.huji.ac.il X-Spamd-Result: default: False [-3.30 / 15.00]; MID_RHS_MATCH_FROM(0.00)[]; RBL_DBL_DONT_QUERY_IPS(0.00)[132.65.116.210:from]; R_DKIM_ALLOW(-0.20)[cs.huji.ac.il:s=57791128]; FREEFALL_USER(0.00)[danny]; FROM_HAS_DN(0.00)[]; MV_CASE(0.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; ARC_NA(0.00)[]; SPAMHAUS_ZRD(0.00)[132.65.116.210:from:127.0.2.255]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[cs.huji.ac.il:+]; RCPT_COUNT_TWO(0.00)[2]; DMARC_POLICY_ALLOW(-0.50)[huji.ac.il,none]; NEURAL_HAM_SHORT(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; R_SPF_NA(0.00)[no SPF record]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:378, ipnet:132.64.0.0/13, country:IL]; RCVD_COUNT_TWO(0.00)[2]; MAILMAN_DEST(0.00)[freebsd-stable] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 04 Apr 2021 05:45:11 -0000 > On 3 Apr 2021, at 20:22, Warner Losh wrote: >=20 > What's the error if you don't have these extra uintptr_t casts? --- getgrent.o --- = = = =20 *** [getgrent.o] Error code 1 = = = =20 make[4]: stopped in /h/rnd/git/stable/13/lib/libc = = =20= --- getpwent.o --- = = = =20 /h/rnd/git/stable/13/lib/libc/gen/getpwent.c:1111:8: error: cast to = smaller integer type 'enum nss_lookup_type' from 'void *' = [-Werror,-Wvoid-pointer-to-enum-cast] = =20 how =3D (enum nss_lookup_type)mdata; = = =20 ^~~~~~~~~~~~~~~~~~~~~~~~~~~ = = =20 1 error generated. =20 >=20 > Warner >=20 > On Sat, Apr 3, 2021 at 12:18 AM Daniel Braniss > wrote: > I must be the last person on earth to use Hesiod :-) > this are the diffs: >=20 > diff --git a/lib/libc/gen/getgrent.c b/lib/libc/gen/getgrent.c > index afb89cab3..5832cb8c6 100644 > --- a/lib/libc/gen/getgrent.c > +++ b/lib/libc/gen/getgrent.c > @@ -971,7 +971,7 @@ dns_group(void *retval, void *mdata, va_list ap) > hes =3D NULL; > name =3D NULL; > gid =3D (gid_t)-1; > - how =3D (enum nss_lookup_type)mdata; > + how =3D (enum nss_lookup_type)(uintptr_t)mdata; > switch (how) { > case nss_lt_name: > name =3D va_arg(ap, const char *); > diff --git a/lib/libc/gen/getpwent.c b/lib/libc/gen/getpwent.c > index a07ee109e..bc1d341fd 100644 > --- a/lib/libc/gen/getpwent.c > +++ b/lib/libc/gen/getpwent.c > @@ -1108,7 +1108,7 @@ dns_passwd(void *retval, void *mdata, va_list = ap) > hes =3D NULL; > name =3D NULL; > uid =3D (uid_t)-1; > - how =3D (enum nss_lookup_type)mdata; > + how =3D (enum nss_lookup_type)(uintptr_t)mdata; > switch (how) { > case nss_lt_name: > name =3D va_arg(ap, const char *); >=20 >=20 > _______________________________________________ > freebsd-stable@freebsd.org mailing = list > https://lists.freebsd.org/mailman/listinfo/freebsd-stable = > To unsubscribe, send any mail to = "freebsd-stable-unsubscribe@freebsd.org = "