From owner-freebsd-transport@freebsd.org Sun Apr 18 08:30:27 2021 Return-Path: Delivered-To: freebsd-transport@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 665A75E03FC for ; Sun, 18 Apr 2021 08:30:27 +0000 (UTC) (envelope-from Richard.Scheffenegger@netapp.com) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4FNNS306zNz4tVh for ; Sun, 18 Apr 2021 08:30:27 +0000 (UTC) (envelope-from Richard.Scheffenegger@netapp.com) Received: by mailman.nyi.freebsd.org (Postfix) id 025495E0847; Sun, 18 Apr 2021 08:30:27 +0000 (UTC) Delivered-To: transport@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 01E4A5E08B8; Sun, 18 Apr 2021 08:30:27 +0000 (UTC) (envelope-from Richard.Scheffenegger@netapp.com) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam08on2043.outbound.protection.outlook.com [40.107.101.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "DigiCert Cloud Services CA-1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FNNRz4pQbz4tXg; Sun, 18 Apr 2021 08:30:23 +0000 (UTC) (envelope-from Richard.Scheffenegger@netapp.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W6dYr+Gz46NB36ijbjdCGNG1PgWT7SWZ3pBN2HY6Z8ytS/bDX3oqjAMeInotWT/Kjd4WU/TrnSuCtq/f39zXbMyUKJaNwI2Xnn7ELOmn2ZZjrgZlDWq4anqInCg7EFVf0r6VBay3YFw9EWrXuIMb27ut9XOfuXtAW6oLgUn/BogyHUvlUci6j6S039U1qCYwQIKACEtzJiZL0cLraN2mTiYyK02etjdcxi3zrf153NC78CCL1zOS8AJxFate7Tsw6etkeg6w0rCb7RcAp7Asv5iGetRamrPx/kasTvjwxO/wzyqGKUp/YEHt05pX3Klc+BbkIP23RwLi/j8rmGRWRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=19Y8fiBsM3HdiuoHBurDy8SgjzO8icDgQzjO1PGKFeg=; b=ZvSL6WyDjc6rt5s5JJezhAl0Y8SXXBZm3oyNCnt/vpH/v0KdQNTN29Xb0UJYK7PGmbu7V3SifqKOznDk6zyWvihtZXPBzyV9ZUk+PJj4D+7FeZ53oPv2ldBLN6j+mtFaKk6TpSwKWvTdMJQ/3wybnBNuLtZ0SoO7tp+alN4myPrHQxUa64Xk83Zh0JaKaHldxIQ5iDbg94AdXHrb5gplmruIGOAsmRYo1xKYleAlgEQ7Z7uVCkQShCcT8YJRmKhR3ijNyBY2hYbYjC6kVgzgNbyjFgPYl3EpXo3J/wl8bHT7EbNkecoGFWQUT/BwDwh+oiMUDkIyr1ew9ljLOfGJKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=netapp.com; dmarc=pass action=none header.from=netapp.com; dkim=pass header.d=netapp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netapp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=19Y8fiBsM3HdiuoHBurDy8SgjzO8icDgQzjO1PGKFeg=; b=2d8j5yxsAVX8Gnz6+hff1Lqlm/g78jm+qiGOhcOHnnCY3rNQqB9trAi9xx1sUL0ctunG10r2OfRJAcgCrVA8qFx4SJA/H+uQxnjdL86BMVdcQyEQlgy85iWzg+uYMr6suovM6k0ZJiphKt/CNTaFS4VWV4YHtFuVAUMOyLK0k26vb4AyDX/ksCz+fXzKAkjAzqf9p1jgEnNK7emfsGSkJkWyM/fZi3my0z0FndwYXCcKkwgbZOlru4+2z0wJi3cI3fXFK5KoX6PrapX2dFXxeZQjCmhZZnqlO3AgZ0ZjucJiGVK6lh+anZ669Umt3ErrSORyH4U76pSWqkhK6N/Tng== Received: from PH0PR06MB7639.namprd06.prod.outlook.com (2603:10b6:510:4e::18) by PH0PR06MB7112.namprd06.prod.outlook.com (2603:10b6:510::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.16; Sun, 18 Apr 2021 08:30:21 +0000 Received: from PH0PR06MB7639.namprd06.prod.outlook.com ([fe80::19e2:b5f4:2a64:5eda]) by PH0PR06MB7639.namprd06.prod.outlook.com ([fe80::19e2:b5f4:2a64:5eda%5]) with mapi id 15.20.4042.024; Sun, 18 Apr 2021 08:30:21 +0000 From: "Scheffenegger, Richard" To: Peter Holm , Richard Scheffenegger CC: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" , "transport@freebsd.org" Subject: AW: git: d1de2b05a001 - main - tcp: Rename rfc6675_pipe to sack.revised, and enable by default Thread-Topic: git: d1de2b05a001 - main - tcp: Rename rfc6675_pipe to sack.revised, and enable by default Thread-Index: AQHXM5CiCqQV41lYIEC3c4/iyC2cxKq5yTAAgAAndzA= Date: Sun, 18 Apr 2021 08:30:20 +0000 Message-ID: References: <202104171350.13HDoPQL025776@gitrepo.freebsd.org> <20210418060040.GA48834@x8.osted.lan> In-Reply-To: <20210418060040.GA48834@x8.osted.lan> Accept-Language: de-AT, en-US Content-Language: de-DE X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [185.236.167.136] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1fa443e6-db3e-46eb-ba97-08d902443480 x-ms-traffictypediagnostic: PH0PR06MB7112: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2512; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: YahJPfNH2o1DrM6SGsxyHJPJg5gdW3jaRLjh3NJRKcrLsnSu93bxQ7QAiM9zmWug7a3HQ4aJ8LS0BxUr1uSJ/kG95cGL9Ufp9o3qHgIx8LFiWelYiEsS4ty1pAKqyYy16qvYOrBfVWWI83ri6K+yBlDEUd8vXU96mrVhTXTDCuiSTYxADZltED7K7fOFiSXWHK66TS5DhClscuVty1gC9N40WhB/o5diVMV2Sw/a+9QnAKMnFUfDHarDnqMV1VKon9rgfFWXr5w4zzpgQqVeWfoRUk0oouxeTh2+epee3hnjXPvjZVOxj3xIIgLPIMw5tYXvdkF1XTNKOmEjsrdXIrEN4/DAVxpJ4FPnvpxqKf1Ifp2t52CXqH2WNyT43fm925KuTV70wnArpBusV8+jHDL2F143DQtxn3TphheG5Dfq1/hwgABEaS8y8F+W/psUMcsJQuKdgTSiMH0kBIUjnf3f+9Pog8QWZ45talbiWgdXI2AFaQeB28a0q+G/Y0ziAC2H8BPFz5h7kSfD5DZSH2TlT2opGb+E7hwnGCgRlsue93zlzJGzJbfUlM9G2VKCfFkbxYmfNcfw3cMOLiVJLbuAmNLDVQpYEWob+MPHKvWAwYeBQCtQ03nmxOW3B/QdRDvedMsqbDQV7q3jzfT5kXXxyB4lLAr+eQXPT+cV9jjqs+FKpGj4EPtj+qpez1lP x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR06MB7639.namprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(39860400002)(366004)(136003)(376002)(396003)(83380400001)(66574015)(4326008)(478600001)(450100002)(2906002)(66476007)(66946007)(66446008)(5660300002)(76116006)(6506007)(966005)(55016002)(33656002)(66556008)(9686003)(64756008)(54906003)(7696005)(52536014)(86362001)(38100700002)(186003)(71200400001)(122000001)(8936002)(316002)(8676002)(26005)(110136005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?iso-8859-1?Q?/k/FACsa2+s9wyFXnDJkNw6Cwo/IgbnL0k+rTxAUIV9XXVY/dN+1m18jIk?= =?iso-8859-1?Q?FfsAEMYdG3bc/PeqBE9SAnDLrFDKJgvVkxE2IB1zS8e86ksM9Oo88+UDVJ?= =?iso-8859-1?Q?3pLpbrKqKT9vceZP7j7N0VznggiFFfBG3LxRVLOUbnLwDye6b43d73MFz9?= =?iso-8859-1?Q?QSnBXJKFZcAsCWgJQJqNB4bBq3+yL66A/2p2rY+jKT80VUPZ82OKilr+MV?= =?iso-8859-1?Q?QHwbZ/tbLsiIbOz+9mAv+Ywb5hGzP0OKywALNbmtfaCP1Lr7dAvWekCLe7?= =?iso-8859-1?Q?ucsAjb0vVogqpS2V/5kIvOzGdDDDsVWykMwWd/enZZA5fKcD/vJnOEfBKZ?= =?iso-8859-1?Q?QUHlW5I6dxdoVjffW+QLzFal5Z/I5uFa4wR/vyneatChnVvoZibvBfGT3+?= =?iso-8859-1?Q?+FZoyIGcUzynN7E8e1+nuUBb4SLQujoVU4V1eQMsPjA5lOWJ0jMhr2rnTv?= =?iso-8859-1?Q?casFXAk0gbpRLkumtWzqfBxX+DsxJO1Bn+EDVk9bix++CjAUmmO5Vg3NKk?= =?iso-8859-1?Q?XrdBN5DxOmSXFeLYk+plp9YG7MDcZYck+Rs1v8hOC+rbYqxMkZ/G4vdBDg?= =?iso-8859-1?Q?p+X4MzCUlgrjddt/rodAoXGtz+XRZSkVCOx4z5M31jMO1LJdNxi5PaN2TC?= =?iso-8859-1?Q?Zew/x60+vLQdcejpF9BkvR9f57V+Swu9FViWPxngBLTkXtCYq0IZ0jGUTT?= =?iso-8859-1?Q?uqFY25i2pusgy+zoHC+TSp7aw/8tHRSL4VBP8rpA4R7E/+gJCdxujt/myc?= =?iso-8859-1?Q?NLTsAWN8hVFVZgvCFB2RnzIL6OeqpEMcQsu45cyDYOQ0S5r7peK2PHGyFA?= =?iso-8859-1?Q?ap2vG4MPgOx4czCWgoXOFWjNp21QZBIJXdOEGR4VjHgBqWzm1C+NSmgEnD?= =?iso-8859-1?Q?TSSjqD4zk9LVvYs/5S/7TyqFWo6qIemBZMuX35UiEeKg/0NEju6+BlevDG?= =?iso-8859-1?Q?zXG45Yh0DflT9/ujG39SCVaphg40C+SLNm84nGblI7H+kfeF8R6bZQn0V0?= =?iso-8859-1?Q?gAVFLi2ZDSgWjQaeMX28dp8eBDAMASYHzST0XQ9gCTc0dS6Z++ky78Jy88?= =?iso-8859-1?Q?gubW02jWCo9obSxcbBWhXhhB76oWLN6rswH4sGQMChC4HBdCrBGxGtbY75?= =?iso-8859-1?Q?r2WA90eyyktc43+JL86YMd1Yuj2FCZXzWkdWsInY2BjlxdVja1P21H9A62?= =?iso-8859-1?Q?rjU5FQRkaPs+dNlHLtO4Ut/ppqyAt23lOt0pC4mW0R857Mhl49WhoSLv81?= =?iso-8859-1?Q?8mK46Idg1eKtmXHjyK327ElUsLfhK9ePfGr0qas1w/cPMuKdBb6h+hxZsi?= =?iso-8859-1?Q?DsbUVc9Kbfk5jmle/7UZGFoy9EoGYRBS8QXEkVm0btisYUwTC8MHnLXjfj?= =?iso-8859-1?Q?qiEiviS3Y1?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: netapp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR06MB7639.namprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1fa443e6-db3e-46eb-ba97-08d902443480 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Apr 2021 08:30:20.9687 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4b0911a0-929b-4715-944b-c03745165b3a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GQ45CsIMXtxESiOfjovGgUbWPkEyMp+AfAynmklthFAz6PTPeXpyyceRaX8F679XKHWBv/Smkk6+ztwylgwW0A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR06MB7112 X-Rspamd-Queue-Id: 4FNNRz4pQbz4tXg X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: freebsd-transport@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussions of transport level network protocols in FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Apr 2021 08:30:27 -0000 Hi Peter, Hmm... the panic appears to be due to a stale entry in the sack scoreboard = - a hole not having been closed up to snd_una... Unlikely that this was solely due to this change by itself. Can I get the vmcore and kernel.debug for a close investigation? Richard Scheffenegger -----Urspr=FCngliche Nachricht----- Von: Peter Holm =20 Gesendet: Sonntag, 18. April 2021 08:01 An: Richard Scheffenegger Cc: src-committers@freebsd.org; dev-commits-src-all@freebsd.org; dev-commit= s-src-main@freebsd.org Betreff: Re: git: d1de2b05a001 - main - tcp: Rename rfc6675_pipe to sack.re= vised, and enable by default NetApp Security WARNING: This is an external email. Do not click links or o= pen attachments unless you recognize the sender and know the content is saf= e. On Sat, Apr 17, 2021 at 01:50:25PM +0000, Richard Scheffenegger wrote: > The branch main has been updated by rscheff: > > URL:=20 > https://cgit.FreeBSD.org/src/commit/?id=3Dd1de2b05a001d3d80f633f576f4909 > c2686dda3d > > commit d1de2b05a001d3d80f633f576f4909c2686dda3d > Author: Richard Scheffenegger > AuthorDate: 2021-04-17 12:59:30 +0000 > Commit: Richard Scheffenegger > CommitDate: 2021-04-17 12:59:45 +0000 > > tcp: Rename rfc6675_pipe to sack.revised, and enable by default > > As full support of RFC6675 is in place, deprecating > net.inet.tcp.rfc6675_pipe and enabling by default > net.inet.tcp.sack.revised. > > Reviewed By: #transport, kbowling, rrs > Sponsored by: NetApp, Inc. > Differential Revision: https://reviews.freebsd.org/D28702 > --- > share/man/man4/tcp.4 | 25 ++++++++++++++----------- > sys/netinet/cc/cc_cubic.c | 2 +- > sys/netinet/cc/cc_htcp.c | 2 +- > sys/netinet/cc/cc_newreno.c | 2 +- > sys/netinet/tcp_input.c | 11 +++-------- > sys/netinet/tcp_sack.c | 12 +++++++++--- > sys/netinet/tcp_var.h | 4 ++-- > 7 files changed, 31 insertions(+), 27 deletions(-) > > diff --git a/share/man/man4/tcp.4 b/share/man/man4/tcp.4 index=20 > d01505e58427..cbb8021226fe 100644 > --- a/share/man/man4/tcp.4 Could this panic be related? 20210418 07:19:59 all (204/751): jumbo.sh panic: tcp_output: sack block to the left of una : -293976 cpuid =3D 3 time= =3D 1618723234 KDB: stack backtrace: db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xfffffe00e49b0= 550 vpanic() at vpanic+0x181/frame 0xfffffe00e49b05a0 panic() at panic+0x43/frame 0xfffffe00e49b0600 tcp_output() at tcp_output+0x27dc/frame 0xfffffe00e49b07c0 tcp_do_segment() at tcp_do_segment+0x32a3/frame 0xfffffe00e49b08b0 tcp_input() at tcp_input+0xbd5/frame 0xfffffe00e49b0a10 ip_input() at ip_input+0x194/frame 0xfffffe00e49b0aa0 swi_net() at swi_net+0x1a1/frame 0xfffffe00e49b0b20 ithread_loop() at ithread_loop+0x279/frame 0xfffffe00e49b0bb0 fork_exit() at fork_exit+0x80/frame 0xfffffe00e49b0bf0 fork_trampoline() at fork_trampoline+0xe/frame 0xfffffe00e49b0bf0 --- trap 0, rip =3D 0, rsp =3D 0, rbp =3D 0 --- https://people.freebsd.org/~pho/stress/log/log0094.txt - Peter From owner-freebsd-transport@freebsd.org Sun Apr 18 09:04:23 2021 Return-Path: Delivered-To: freebsd-transport@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 06F665E233A for ; Sun, 18 Apr 2021 09:04:23 +0000 (UTC) (envelope-from pho@holm.cc) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4FNPCB55mxz3CfJ for ; Sun, 18 Apr 2021 09:04:22 +0000 (UTC) (envelope-from pho@holm.cc) Received: by mailman.nyi.freebsd.org (Postfix) id AEF935E2499; Sun, 18 Apr 2021 09:04:22 +0000 (UTC) Delivered-To: transport@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id AE9BD5E21D4; Sun, 18 Apr 2021 09:04:22 +0000 (UTC) (envelope-from pho@holm.cc) Received: from relay05.pair.com (relay05.pair.com [216.92.24.67]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4FNPCB4Pbfz3CcC; Sun, 18 Apr 2021 09:04:22 +0000 (UTC) (envelope-from pho@holm.cc) Received: from x8.osted.lan (unknown [80.208.71.94]) by relay05.pair.com (Postfix) with ESMTP id 3A7391A2803; Sun, 18 Apr 2021 05:04:21 -0400 (EDT) Received: from x8.osted.lan (localhost [127.0.0.1]) by x8.osted.lan (8.15.2/8.15.2) with ESMTPS id 13I94KIM051067 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Sun, 18 Apr 2021 11:04:20 +0200 (CEST) (envelope-from pho@x8.osted.lan) Received: (from pho@localhost) by x8.osted.lan (8.15.2/8.15.2/Submit) id 13I94J5r051066; Sun, 18 Apr 2021 11:04:19 +0200 (CEST) (envelope-from pho) Date: Sun, 18 Apr 2021 11:04:19 +0200 From: Peter Holm To: "Scheffenegger, Richard" Cc: Richard Scheffenegger , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" , "transport@freebsd.org" Subject: Re: git: d1de2b05a001 - main - tcp: Rename rfc6675_pipe to sack.revised, and enable by default Message-ID: <20210418090419.GA51040@x8.osted.lan> References: <202104171350.13HDoPQL025776@gitrepo.freebsd.org> <20210418060040.GA48834@x8.osted.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: 4FNPCB4Pbfz3CcC X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-Mailman-Approved-At: Sun, 18 Apr 2021 09:10:09 +0000 X-BeenThere: freebsd-transport@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussions of transport level network protocols in FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Apr 2021 09:04:23 -0000 On Sun, Apr 18, 2021 at 08:30:20AM +0000, Scheffenegger, Richard wrote: > Hi Peter, > > Hmm... the panic appears to be due to a stale entry in the sack scoreboard - a hole not having been closed up to snd_una... > > Unlikely that this was solely due to this change by itself. > > Can I get the vmcore and kernel.debug for a close investigation? > Sure. Uploaded to: https://people.freebsd.org/~pho/kernel.vmcore.320-mercat1.tar - Peter > > Richard Scheffenegger > > -----Ursprüngliche Nachricht----- > Von: Peter Holm > Gesendet: Sonntag, 18. April 2021 08:01 > An: Richard Scheffenegger > Cc: src-committers@freebsd.org; dev-commits-src-all@freebsd.org; dev-commits-src-main@freebsd.org > Betreff: Re: git: d1de2b05a001 - main - tcp: Rename rfc6675_pipe to sack.revised, and enable by default > > NetApp Security WARNING: This is an external email. Do not click links or open attachments unless you recognize the sender and know the content is safe. > > > > > On Sat, Apr 17, 2021 at 01:50:25PM +0000, Richard Scheffenegger wrote: > > The branch main has been updated by rscheff: > > > > URL: > > https://cgit.FreeBSD.org/src/commit/?id=d1de2b05a001d3d80f633f576f4909 > > c2686dda3d > > > > commit d1de2b05a001d3d80f633f576f4909c2686dda3d > > Author: Richard Scheffenegger > > AuthorDate: 2021-04-17 12:59:30 +0000 > > Commit: Richard Scheffenegger > > CommitDate: 2021-04-17 12:59:45 +0000 > > > > tcp: Rename rfc6675_pipe to sack.revised, and enable by default > > > > As full support of RFC6675 is in place, deprecating > > net.inet.tcp.rfc6675_pipe and enabling by default > > net.inet.tcp.sack.revised. > > > > Reviewed By: #transport, kbowling, rrs > > Sponsored by: NetApp, Inc. > > Differential Revision: https://reviews.freebsd.org/D28702 > > --- > > share/man/man4/tcp.4 | 25 ++++++++++++++----------- > > sys/netinet/cc/cc_cubic.c | 2 +- > > sys/netinet/cc/cc_htcp.c | 2 +- > > sys/netinet/cc/cc_newreno.c | 2 +- > > sys/netinet/tcp_input.c | 11 +++-------- > > sys/netinet/tcp_sack.c | 12 +++++++++--- > > sys/netinet/tcp_var.h | 4 ++-- > > 7 files changed, 31 insertions(+), 27 deletions(-) > > > > diff --git a/share/man/man4/tcp.4 b/share/man/man4/tcp.4 index > > d01505e58427..cbb8021226fe 100644 > > --- a/share/man/man4/tcp.4 > > Could this panic be related? > > 20210418 07:19:59 all (204/751): jumbo.sh > panic: tcp_output: sack block to the left of una : -293976 cpuid = 3 time = 1618723234 > KDB: stack backtrace: > db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xfffffe00e49b0550 > vpanic() at vpanic+0x181/frame 0xfffffe00e49b05a0 > panic() at panic+0x43/frame 0xfffffe00e49b0600 > tcp_output() at tcp_output+0x27dc/frame 0xfffffe00e49b07c0 > tcp_do_segment() at tcp_do_segment+0x32a3/frame 0xfffffe00e49b08b0 > tcp_input() at tcp_input+0xbd5/frame 0xfffffe00e49b0a10 > ip_input() at ip_input+0x194/frame 0xfffffe00e49b0aa0 > swi_net() at swi_net+0x1a1/frame 0xfffffe00e49b0b20 > ithread_loop() at ithread_loop+0x279/frame 0xfffffe00e49b0bb0 > fork_exit() at fork_exit+0x80/frame 0xfffffe00e49b0bf0 > fork_trampoline() at fork_trampoline+0xe/frame 0xfffffe00e49b0bf0 > --- trap 0, rip = 0, rsp = 0, rbp = 0 --- > > https://people.freebsd.org/~pho/stress/log/log0094.txt > > - Peter From owner-freebsd-transport@freebsd.org Sun Apr 18 12:28:52 2021 Return-Path: Delivered-To: freebsd-transport@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 74EE55E8469 for ; Sun, 18 Apr 2021 12:28:52 +0000 (UTC) (envelope-from Richard.Scheffenegger@netapp.com) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4FNTl812QXz3NRb for ; Sun, 18 Apr 2021 12:28:52 +0000 (UTC) (envelope-from Richard.Scheffenegger@netapp.com) Received: by mailman.nyi.freebsd.org (Postfix) id 2373F5E8568; Sun, 18 Apr 2021 12:28:52 +0000 (UTC) Delivered-To: transport@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 232D75E86C6 for ; Sun, 18 Apr 2021 12:28:52 +0000 (UTC) (envelope-from Richard.Scheffenegger@netapp.com) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-eopbgr770080.outbound.protection.outlook.com [40.107.77.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "DigiCert Cloud Services CA-1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FNTl71SYsz3Nbb; Sun, 18 Apr 2021 12:28:50 +0000 (UTC) (envelope-from Richard.Scheffenegger@netapp.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Km9Bdtt4L1Sf1LxoNNzwbQgu/NLRAQc1JakjViWgDxx9W/DJUVC3cjHblvES1zJzO+Dg2WQgyeFaTCuw9u5DgQ+NtVP2ap7D9GCfguDwN9AC0OtajinA4XVxY5qZXAUiy9neqlEpmbfMA6jAoo6IqLppzq6eVBsw/RDbBuJ6dxksCUc8P0F8eWjmSQBqjtjORnseYjcwnsixCoWVMBUrTGHrn1tHk2KsQZQRWxqmoAQlTukvGQ2S9cdAeAh9Qw8RY8eMnETmVpDSAvuWoB+mqHU8dZpATWKGuxGLrIKgFFmf9nqjGUFG1dGZ7TmKAnWeCOxiIadBaD/XzuB57V0Wcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jgm52uaaXxBHTxMd8mF0uqpivwa9GnFstleZGoOjJ5E=; b=cyszwbweRIi2fYBY6VHHr1hzdrRXUEMI4zvBkWAIL04fDGj06TYIDpwgzhcSc1dgwo2f6DBwLwZtqAh28w+3tPCjat02CXu1D+UxVJFrhKypwuKrwhukzBa4UxPmyuQqjReKau2dkHD6mrJliTfAylpp2+EUSI6wHFHH4CiSH1y0mk/+gZKtsSoAHSEk7nJQCg62/hFjoNkswL023mhH3998rK99RsZEuk6cc633LZQscV88QV3sAMIGWsoSk2ZnpDRmvvYUMMkMQCLkqzHO9m7v/BkDXibhrm+yloPJJgBPkQWujlR1N4p0FyyR0Fvn1nImZzXyv/ZKOLIv2C/DUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=netapp.com; dmarc=pass action=none header.from=netapp.com; dkim=pass header.d=netapp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netapp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jgm52uaaXxBHTxMd8mF0uqpivwa9GnFstleZGoOjJ5E=; b=g9mWBzm4P7msX7Lpy+/a02UMHd/K+gY59sPP3UAKYR/3eN6Fp7faTFi8/j0akGEgqLC/WycqMupohb+4oeo9sxlB1hn3hGK54U9aaw5jqGr+KWqnEyrQ1mVh3AkxlGQUrydtwS1qoRFVvhodbLLwxnQ9VtO8KeD7SBkB7s361+tr8USMrxm0euroikW/d20oiDWfHI71wUiLxsq2Pq6ZG+z9jo4HiFhZniyQjFGgdLE0bnsGjh3Qc7+W1Es/NUFlDKziUVhamsCc0YkPF9KoDMCUtMVH3KofhrNB7gbeS8NXV0SFym7pIZ4NGNuMvxXxzPUHXWc6uN8U6HCTNSmXDw== Received: from PH0PR06MB7639.namprd06.prod.outlook.com (2603:10b6:510:4e::18) by PH0PR06MB7158.namprd06.prod.outlook.com (2603:10b6:510::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.16; Sun, 18 Apr 2021 12:28:47 +0000 Received: from PH0PR06MB7639.namprd06.prod.outlook.com ([fe80::19e2:b5f4:2a64:5eda]) by PH0PR06MB7639.namprd06.prod.outlook.com ([fe80::19e2:b5f4:2a64:5eda%5]) with mapi id 15.20.4042.024; Sun, 18 Apr 2021 12:28:47 +0000 From: "Scheffenegger, Richard" To: "rmacklem@freebsd.org" , "transport@freebsd.org" , Michael Tuexen Subject: AW: [Differential] D29690: [tcp] Keep socket buffer locked until upcall Thread-Topic: [Differential] D29690: [tcp] Keep socket buffer locked until upcall Thread-Index: AQHXM+943luUhqmkuEq1GwFSam8mQKq6M0FA Date: Sun, 18 Apr 2021 12:28:46 +0000 Message-ID: References: <14c884a66edd4b503358aa2a2c3f41f2@localhost.localdomain> In-Reply-To: <14c884a66edd4b503358aa2a2c3f41f2@localhost.localdomain> Accept-Language: de-AT, en-US Content-Language: de-DE X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [185.236.167.136] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 35cc3242-b13b-40bb-9ebc-08d902658378 x-ms-traffictypediagnostic: PH0PR06MB7158: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: TqxN7bkFgB3ChQ5gvCepyN9CCXDBeTlHlQjpI6zl5Luj47azdtKKNa1h8uQIwHLtsTphM7uLuJV+9CYaiMSEFxN9gzzg8vPsBg3u7F9vMShfHKDAeAEKVCE8Ko5I14YznXoTD8CxanfZvmxEtZvR0krQe1XO3RZgU3STYlf+Mo4DrY0mas/3aFU2pwsF+H49CWkTE8815QasXM/tMQJdzLkvKDPKpgVZ9MdwD4/1feDljRhI3PVh/yJiTVk4Dscy9xyaSQZnCfgwNw2EMtQ0b+jndjKe7URmbPB1JytLfbs13qGSdIewNohh51T8DCYYsWPm+7TlK+YOdqqc72pPZA/rYu+TjtoSYnjXuDxzGeuLMzKO87XQl8fGy+n1WkG5hBJ4aP+YEkn3Dtpal7dsKfxs5ER5B58GB0U8GoYcT+BrFFlxts/gaU+QIk+/vV+fBNhOsTsRuIsw3mKCXtBIot74txr1P202LRirEKKL5a7TjfyndasavgHohfqaEcztr4QI38wnCSfr7FK4AvnmZTMj0AQ0YIFk0F+SliMYVO+EdR52ghw4oNci39Ysq9fDgzw0ZWG7UGyWNJrl7pWAUctETlzuaSSsqpvZByv9KiqbQo+ZYqORTc7KIX7HzQppeijlyfgM2Sbstg74eWbDoXgjEPYL3wJ22LSnQiqTbzXXXRhXvQpLzWfr+e7jFbLh x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR06MB7639.namprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(396003)(376002)(346002)(39860400002)(136003)(316002)(8676002)(8936002)(71200400001)(52536014)(6506007)(86362001)(110136005)(5660300002)(33656002)(7696005)(83380400001)(66446008)(966005)(66476007)(66556008)(66946007)(186003)(26005)(9686003)(2906002)(450100002)(122000001)(55016002)(76116006)(64756008)(478600001)(38100700002)(66574015); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?utf-8?B?b1RValVURThwRjQ1TllZdWxuWUhhSGtLbTFzeGY4ZUZxMEpxUVI1OExXUFc4?= =?utf-8?B?S040TW9URE92ZmtVMy95Qzhua0xZczk3R1R3bDZxVnU3Zk5YaHlhWlhjVHIz?= =?utf-8?B?UFJodTB2WlRKUUMzbTFITTBTcEtEZDhFeFBmOE8vWVZTUnlPY01FTWs3Q3dn?= =?utf-8?B?Z0praGtnYTE3VTluNEVRTFd1NmQ1Q0JJdytheGlxS0hMTTA5c2NJRkVkNDRV?= =?utf-8?B?UHcyeFR1ZlRPZmZ2c2oyNVl2YlRoeis5SXdUOE5SeFFHL3RNNml5R0hyRmZn?= =?utf-8?B?N1ZqcVlLRG9QUjVOUTF5Z0dFeUJISzMySHpEdlhwM2ZBN2l2Y0w2OEZ3Vzls?= =?utf-8?B?bE1qRURvM1RiRkprbktOdjdjcUtINzUrT2Q2OEs2UFpCRkx1OTZWc1J1dks2?= =?utf-8?B?T1JFaC8rMW93bWpnYmtzTXFWRHU1cWpPeEdpRTZqOGthMXU0WFNOKzFWZENB?= =?utf-8?B?K1FtQU9TK0JldVBZanpVcDdIcEQzelk0ckZCUms4RFk5L0xuQU5hVkw3cmhj?= =?utf-8?B?Y2QrcTdsMGh0bEk1RFlycm0wRlltOWFzYVpnRXdKSDh3bDR5bWNoSThJNEQz?= =?utf-8?B?Y3pPb1orRFl0dENuME9wc2xQV0JPbndZQUYzSHZ0WEpEZzRQLzdCMjdKSXps?= =?utf-8?B?dWRtbG5uT05IbHN5Mkt1RG82M2dsQnVtRmplTEpIWUplQTVWcU1ObTBGNTd6?= =?utf-8?B?WEFMTDQ4Q2JwaXJKLzl4K2swRG5XUUc3VGtyR2lrM1RyZkpDZDh6aEd6Tmtn?= =?utf-8?B?dk5DQWxKRFhhRUFFM2hiTzhlTFhrcERUcXpDaUNLUlM0L09ES3BpL0x5RzV1?= =?utf-8?B?RlgxOUhTaGhtUE00VVNUazdQMG5SckZuOEVHaXVjYzhLTTlqZ0dnTXhaYjBH?= =?utf-8?B?dnl3bkM1N0VBWXAzcnhHakRxUnRNb1ova3RhWUd4dkhFTWJydG5Oa3IrRGMx?= =?utf-8?B?dmlqN3BCMEdMMXAwbng1SUtvNnRBZ3I2Uk5vemdtV0RlSFo3L1BpaFBnVkx5?= =?utf-8?B?N0haV0VxZXVHUUpabDRNb1Z4VlJCL25yM0x4eDQrNSt4dlQwd0tpMnJ2MmM3?= =?utf-8?B?aEROVGVMWFJWYlZURW9Eclo1UTlqQ2VnUzBlRkxZNTdQSTUwWDBidkdPbzNr?= =?utf-8?B?SlFlQytOSGZOaFFSeDZCTXY1MENuOXpld1RSTVhqcWNMWmlFTlhiQjVscnBY?= =?utf-8?B?L1lVai9wWkxzemdGakwxT0d5SDQzMGsxa2hTNTkxcnNTYUh5azFpQTFpblFV?= =?utf-8?B?ckFGeURReUZhdkxDbVgwZncreGNxdG8vTGhUeXhMNkRDODlmR01UQnFJUzhH?= =?utf-8?B?bDdMcS9YVWRtNi9xajVadTRhVkZhYVJSZWVmSkxoNzIxYnVwbFJKRkI5a0Qy?= =?utf-8?B?VFFCMy9VaFhRSEtncUZFVHkwR0JpT2w5cVUwaTlMdGxIdEhBQmRaOExYdzcw?= =?utf-8?B?TmNDT1BvQkE1R2pRVk16SVBFeEtvWU9XbUQ2UmhtZUxSMExlMmxnaFg2MkVz?= =?utf-8?B?aU1tdEVQOW4wUkZGd2U3Y3NOclBNV2tYQkVNbUJoRW9pa0pIU2dFVkk4YTha?= =?utf-8?B?b2l5VjlzNC92NldVSlhvZ3NkNjdWMjk0T2RrdWhETFhlWndSekxYRGhST285?= =?utf-8?B?Q0JLbEgzblB5cm1hVGNiR3p4MzlJUlFZNnUvK3JibWxXMFJCbW1kMkpaU2Vy?= =?utf-8?B?TitrNHFYRWdwUWVLaDBtamN4SXJCU2hSTmNBTHlZaTYxMFFyMFJmSG1hbzlN?= =?utf-8?Q?oYMC/Qy0OPwb7O2bc/ROpMDqRoA7jNwWy6y8do/?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: netapp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR06MB7639.namprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 35cc3242-b13b-40bb-9ebc-08d902658378 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Apr 2021 12:28:46.6853 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4b0911a0-929b-4715-944b-c03745165b3a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9IRB0+LQG7EOh08JuzW4QvQ2Hs5NHyWJmZpBdUOZKx14ZVS56jHrXWTwl1pyZ/kjSlWCb+3hFRxH3FQqlyF7gg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR06MB7158 X-Rspamd-Queue-Id: 4FNTl71SYsz3Nbb X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=netapp.com header.s=selector1 header.b=g9mWBzm4; arc=pass (microsoft.com:s=arcselector9901:i=1); dmarc=pass (policy=none) header.from=netapp.com; spf=pass (mx1.freebsd.org: domain of Richard.Scheffenegger@netapp.com designates 40.107.77.80 as permitted sender) smtp.mailfrom=Richard.Scheffenegger@netapp.com X-Spamd-Result: default: False [-5.90 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; HAS_XOIP(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:40.107.0.0/16]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[netapp.com:+]; MIME_BASE64_TEXT(0.10)[]; DMARC_POLICY_ALLOW(-0.50)[netapp.com,none]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; RBL_DBL_DONT_QUERY_IPS(0.00)[40.107.77.80:from]; ARC_ALLOW(-1.00)[microsoft.com:s=arcselector9901:i=1]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:8075, ipnet:40.104.0.0/14, country:US]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[netapp.com:s=selector1]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; SPAMHAUS_ZRD(0.00)[40.107.77.80:from:127.0.2.255]; DWL_DNSWL_LOW(-1.00)[netapp.com:dkim]; RCVD_IN_DNSWL_NONE(0.00)[40.107.77.80:from]; RWL_MAILSPIKE_POSSIBLE(0.00)[40.107.77.80:from]; MAILMAN_DEST(0.00)[transport] X-BeenThere: freebsd-transport@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussions of transport level network protocols in FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Apr 2021 12:28:52 -0000 SGkgUmljaywNCg0KdGhhdCBjcmFzaCB3YXMgZHVlIHRvIG1lIGZvcmdldHRpbmcgdGhhdCB0aGUg dGNwX3JlYXNzKCkgY29kZSB3YXMgc3RpbGwgZG9pbmcgdW5sb2NrZWQgc29fcmN2IGJ1ZmZlcnMg d2hlbiBzZXR0aW5nIHRoZSBXQUtFU09SIGZsYWcsIHdoaWxlIGFsbCB0aGUgcmVzdCBhc3N1bWVk IGEgbG9ja2VkIHNvX3Jjdi4NCg0KSSBhbHNvIGJlbGlldmUgdG8gaGF2ZSBmaXhlZCB0aGUgbG9j ayBvcmRlciByZXZlcnNhbCBwcm9ibGVtLCBhcyB0aGVyZSB3ZXJlIHR3byBvciB0aHJlZSBpbnN0 YW5jZXMsIHdoZXJlIGEgY2FsbCB0byB0Y3Bfb3V0cHV0IChsb2NraW5nIHNvX3NuZCkgd2FzIGRv bmUganVzdCBiZWZvcmUgdGhlIHdha2V1cCBjYWxsICh1bmxvY2tpbmcgdGhlIHNvX3JjdikuDQoN CkZvciBhZGRpdGlvbmFsIHRyb3VibGVzaG9vdGluZywgSSByZXRhaW5lZCBhIHNwcmlua2xlIG9m IGxvZ2dpbmcgaW4gdGhhdCBwYXRjaC4gSSB0cmllZCB0byBnZXQgYSBoYWxmIGRlY2VudCB1bml0 IHRlc3QgY292ZXJhZ2UsIGJ5IGRvaW5nIHRjcGRyb3BzIG9mIG9uLWdvaW5nIE5GUyBzZXNzaW9u cyAoY2xpZW50IHdvdWxkIHJlLWNvbm5lY3Qgd2l0aGluIDMgc2VjIGFuZCBjb250aW51ZSksIGFz IHdlbGwgYXMgYWRkaW5nIGFydGlmaWNpYWwgcGFja2V0IGxvc3MgKGR1bW15bmV0KSB0aHVzIGV4 ZXJjaXNpbmcgdGhlIHRjcCByZWFzc2VtYmx5IGFuZCBTQUNLIGNvZGVwYXRocyAtIGFuZCBjb3Vs ZCBubyBsb25nZXIgb2JzZXJ2ZSBhbnkgbG9jayBvcmRlciByZXZlcnNhbCBvciBhbnkgb2YgbXkg YWRkZWQgbG9nZ2luZy4NCg0KVGhhbmtzIGZvciB5b3VyIHBhdGllbmNlLg0KDQoNClJpY2hhcmQg U2NoZWZmZW5lZ2dlcg0KQ29uc3VsdGluZyBTb2x1dGlvbiBBcmNoaXRlY3QNCk5BUyAmIE5ldHdv cmtpbmcNCg0KTmV0QXBwDQorNDMgMSAzNjc2IDgxMSAzMTU3IERpcmVjdCBQaG9uZQ0KKzQzwqA2 NjQgODg2NiAxODU3IE1vYmlsZSBQaG9uZQ0KUmljaGFyZC5TY2hlZmZlbmVnZ2VyQG5ldGFwcC5j b20NCg0KaHR0cHM6Ly90cy5sYS9yaWNoYXJkNDk4OTINCg0KDQotLS0tLVVyc3Byw7xuZ2xpY2hl IE5hY2hyaWNodC0tLS0tDQpWb246IHJtYWNrbGVtIChSaWNrIE1hY2tsZW0pIDxwaGFicmljLW5v cmVwbHlARnJlZUJTRC5vcmc+IA0KR2VzZW5kZXQ6IFNvbm50YWcsIDE4LiBBcHJpbCAyMDIxIDAz OjA5DQpBbjogcnNjaGVmZkBmcmVlYnNkLm9yZw0KQmV0cmVmZjogW0RpZmZlcmVudGlhbF0gRDI5 NjkwOiBbdGNwXSBLZWVwIHNvY2tldCBidWZmZXIgbG9ja2VkIHVudGlsIHVwY2FsbA0Kcw0KTmV0 QXBwIFNlY3VyaXR5IFdBUk5JTkc6IFRoaXMgaXMgYW4gZXh0ZXJuYWwgZW1haWwuIERvIG5vdCBj bGljayBsaW5rcyBvciBvcGVuIGF0dGFjaG1lbnRzIHVubGVzcyB5b3UgcmVjb2duaXplIHRoZSBz ZW5kZXIgYW5kIGtub3cgdGhlIGNvbnRlbnQgaXMgc2FmZS4NCg0KDQoNCg0Kcm1hY2tsZW0gYWRk ZWQgYSBjb21tZW50Lg0KDQoNCiAgR290IHRoaXMgY3Jhc2ggd2hpbGUgdHJ5aW5nIHRvICJnaXQi LCBub3Qgd2hlbg0KICBhY3R1YWxseSB0ZXN0aW5nIE5GUywgYWx0aG91Z2ggdGhlIG5mc2Qgd2Fz IHJ1bm5pbmcNCiAgKGJ1dCB3aXRoIG5vIG1vdW50cyBhZ2FpbnN0IGl0KToNCg0KICBwYW5pYzog bXV0ZXggc29fcmN2IG5vdCBvd25lZCBhdCAvdXNyL3NyYy9zeXMvbmV0aW5ldC90Y3BfaW5wdXQu YzoxNDgyDQogIF9fbXR4X2Fzc2VydCgpDQogIHRjcF9oYW5kbGVfd2FrZXVwKCkNCiAgdGNwX2Rv X3NlZ21lbnQoKQ0KICB0Y3BfaW5wdXQoKQ0KICBpcF9pbnB1dCgpDQogIG5ldGlzcl9kaXNwYXRj aF9zcmMoKQ0KICBldGhlcl9kZW11eCgpDQogIGV0aGVyX25oX2lucHV0KCkNCiAgbmV0aXNyX2Rp c3BhdGNoX3NyYygpDQogIGV0aGVyX2lucHV0KCkNCiAgcmVfcnhlb2YoKQ0KICByZV9pbnRyX21z aSgpDQogIGl0aHJlYWRfbG9vcCgpDQogIGZvcmtfZXhpdCgpDQogIGZvcmtfdHJhbXBvbGluZSgp DQoNClJFUE9TSVRPUlkNCiAgclMgRnJlZUJTRCBzcmMgcmVwb3NpdG9yeSAtIHN1YnZlcnNpb24N Cg0KQ0hBTkdFUyBTSU5DRSBMQVNUIEFDVElPTg0KICBodHRwczovL3Jldmlld3MuZnJlZWJzZC5v cmcvRDI5NjkwL25ldy8NCg0KUkVWSVNJT04gREVUQUlMDQogIGh0dHBzOi8vcmV2aWV3cy5mcmVl YnNkLm9yZy9EMjk2OTANCg0KRU1BSUwgUFJFRkVSRU5DRVMNCiAgaHR0cHM6Ly9yZXZpZXdzLmZy ZWVic2Qub3JnL3NldHRpbmdzL3BhbmVsL2VtYWlscHJlZmVyZW5jZXMvDQoNClRvOiByc2NoZWZm LCBybWFja2xlbSwgdHVleGVuLCBycnMsICN0cmFuc3BvcnQNCkNjOiBvdGlzLCBpbXAsIG1lbGlm YXJvLCByc2NoZWZmDQo= From owner-freebsd-transport@freebsd.org Sun Apr 18 12:52:10 2021 Return-Path: Delivered-To: freebsd-transport@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 91F815E9033 for ; Sun, 18 Apr 2021 12:52:10 +0000 (UTC) (envelope-from jgh@wizmail.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4FNVG22bj1z3PlZ for ; Sun, 18 Apr 2021 12:52:10 +0000 (UTC) (envelope-from jgh@wizmail.org) Received: by mailman.nyi.freebsd.org (Postfix) id 592A45E9094; Sun, 18 Apr 2021 12:52:10 +0000 (UTC) Delivered-To: transport@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 58F1D5E9123 for ; Sun, 18 Apr 2021 12:52:10 +0000 (UTC) (envelope-from jgh@wizmail.org) Received: from wizmail.org (wizmail.org [217.146.107.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.wizmail.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FNVG04rT9z3Pbk for ; Sun, 18 Apr 2021 12:52:08 +0000 (UTC) (envelope-from jgh@wizmail.org) DKIM-Signature: v=1; a=ed25519-sha256; q=dns/txt; c=relaxed/relaxed; d=wizmail.org; s=e202001; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Date:Message-ID:Subject:From:To:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive: Autocrypt; bh=r3qGl5f+3Tvk52oB05t0Fv4tGCfLYFxo0/Q8KjTsTQ4=; b=g3spMVcM+/oL14F J+OhJhJGr9y6sj5kQQ97NT/2vcy/2Ws6EhWIHmEAspJ1Z0sZLKgd3yYO09XKCte6QUbXkAw==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=wizmail.org ; s=r202001; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Date: Message-ID:Subject:From:To:From:Sender:Reply-To:Subject:Date:Message-ID:To:Cc :MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive:Autocrypt; bh=r3qGl5f+3Tvk52oB05t0Fv4tGCfLYFxo0/Q8KjTsTQ4=; b=SWvXyEj+Br/gx48Mnit7OJ8Ooa MpMPhz/qxzX4xlQKMaQbSBKLR56RuD8TqSiPkuaOm1dKL1UdO9JFuXxcLiVbKsmoXWgEwgSV+OIFJ gbIt9KN0wXp4AteMqWavuZ87YNo9OKP1dt6zuXeor2aSxMfUwp7MRHMWfNeSFR3PVEQL7pKr/a2Jx LyJ2ZJN3QFc4NaexT42vGQd5W4ln28emVse8cApsef9FPf8S0izu7Z/om/ohFmWuY8fT8Hb8ce2ei rIxqy6bJ6Em+uteGqtv87wUMFRLSVBzxW2M/MzSvmEICWWrBQnwZNksc38J2n9zfZ013MKJ5uomeu zUxE993A==; Received: from vgate18.wizint.net ([2a00:1940:107::1:2f:0] helo=lap.dom.ain) by wizmail.org (Exim 4.94.122) (TLS1.3) tls TLS_AES_128_GCM_SHA256 with esmtpsa id 1lY6s9-002zW3-Uh for transport@freebsd.org (return-path ); Sun, 18 Apr 2021 12:49:58 +0000 To: "transport@freebsd.org" From: Jeremy Harris Subject: TCP Fast Open Message-ID: <7c17539a-b50f-bf52-b55b-5d9b1cc3caad@wizmail.org> Date: Sun, 18 Apr 2021 13:49:56 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Pcms-Received-Sender: vgate18.wizint.net ([2a00:1940:107::1:2f:0] helo=lap.dom.ain) with esmtpsa X-Rspamd-Queue-Id: 4FNVG04rT9z3Pbk X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=wizmail.org header.s=e202001 header.b=g3spMVcM; dkim=pass header.d=wizmail.org header.s=r202001 header.b=SWvXyEj+; dmarc=none; spf=none (mx1.freebsd.org: domain of jgh@wizmail.org has no SPF policy when checking 217.146.107.12) smtp.mailfrom=jgh@wizmail.org X-Spamd-Result: default: False [-3.19 / 15.00]; MID_RHS_MATCH_FROM(0.00)[]; RBL_DBL_DONT_QUERY_IPS(0.00)[217.146.107.12:from]; R_DKIM_ALLOW(-0.20)[wizmail.org:s=e202001,wizmail.org:s=r202001]; FREEFALL_USER(0.00)[jgh]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[wizmail.org]; ARC_NA(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; SPAMHAUS_ZRD(0.00)[217.146.107.12:from:127.0.2.255]; NEURAL_HAM_MEDIUM(-1.00)[-0.995]; DKIM_TRACE(0.00)[wizmail.org:+]; NEURAL_HAM_SHORT(-0.89)[-0.891]; TO_DN_EQ_ADDR_ALL(0.00)[]; R_SPF_NA(0.00)[no SPF record]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:16353, ipnet:217.146.96.0/20, country:GB]; RCVD_COUNT_TWO(0.00)[2]; MAILMAN_DEST(0.00)[transport] X-BeenThere: freebsd-transport@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussions of transport level network protocols in FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Apr 2021 12:52:10 -0000 Could I put in a request for better observability? That is, for an application to be able to tell (for both client and server cases) if TFO was not tried / requested successfully / used with no data / used with data ? There is partial observability currently, via sockopts TCP_FASTOPEN and TCP_INFO... and they are unreliable. [ I'll note here that Linux is no better ] Also, a means for getting data on the SYN,ACK packet. Currently AFAIK we cannot; we can send data from the server (under TFO) before the ACK of the SYN,ACK but only as a separate packet. The use case in mind is SMTP, which is a server-first protocol. Whether or not the facility would have to restrict to preloaded data, or could manage an application interaction, is up for argument. -- Cheers, Jeremy From owner-freebsd-transport@freebsd.org Sun Apr 18 14:50:32 2021 Return-Path: Delivered-To: freebsd-transport@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E30775EB523 for ; Sun, 18 Apr 2021 14:50:32 +0000 (UTC) (envelope-from tuexen@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4FNXtc64w3z3kHV for ; Sun, 18 Apr 2021 14:50:32 +0000 (UTC) (envelope-from tuexen@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id D0D675EB5A4; Sun, 18 Apr 2021 14:50:32 +0000 (UTC) Delivered-To: transport@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D09E95EB804 for ; Sun, 18 Apr 2021 14:50:32 +0000 (UTC) (envelope-from tuexen@freebsd.org) Received: from drew.franken.de (mail-n.franken.de [193.175.24.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.franken.de", Issuer "Sectigo RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FNXtc3bDZz3k71 for ; Sun, 18 Apr 2021 14:50:32 +0000 (UTC) (envelope-from tuexen@freebsd.org) Received: from mb.fritz.box (ip4d15f626.dynamic.kabel-deutschland.de [77.21.246.38]) (Authenticated sender: macmic) by mail-n.franken.de (Postfix) with ESMTPSA id 44A15734384BE; Sun, 18 Apr 2021 16:50:29 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) Subject: Re: TCP Fast Open From: Michael Tuexen In-Reply-To: <7c17539a-b50f-bf52-b55b-5d9b1cc3caad@wizmail.org> Date: Sun, 18 Apr 2021 16:50:28 +0200 Cc: "transport@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: <7c17539a-b50f-bf52-b55b-5d9b1cc3caad@wizmail.org> To: Jeremy Harris X-Mailer: Apple Mail (2.3654.60.0.2.21) X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=disabled version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mail-n.franken.de X-Rspamd-Queue-Id: 4FNXtc3bDZz3k71 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: freebsd-transport@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussions of transport level network protocols in FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Apr 2021 14:50:32 -0000 > On 18. Apr 2021, at 14:49, Jeremy Harris wrote: >=20 > Could I put in a request for better observability? That is, for > an application to be able to tell (for both client and server cases) > if TFO was not tried / requested successfully / used with no data / > used with data ? Sure. It is on my plate and tracked in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D242492 >=20 > There is partial observability currently, via sockopts TCP_FASTOPEN > and TCP_INFO... and they are unreliable. >=20 > [ I'll note here that Linux is no better ] >=20 >=20 > Also, a means for getting data on the SYN,ACK packet. Currently > AFAIK we cannot; we can send data from the server (under TFO) before > the ACK of the SYN,ACK but only as a separate packet. >=20 > The use case in mind is SMTP, which is a server-first protocol. > Whether or not the facility would have to restrict to preloaded data, > or could manage an application interaction, is up for argument. So what you have in mind is a client using TCP fastopen, which does not send user data with the SYN segment, but the server sending its banner with the SYN-ACK. Is that the use case you are referring to? If that is the case, can you add that description to PR 242492? Best regards Michael > --=20 > Cheers, > Jeremy > _______________________________________________ > freebsd-transport@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-transport > To unsubscribe, send any mail to = "freebsd-transport-unsubscribe@freebsd.org" From owner-freebsd-transport@freebsd.org Sun Apr 18 14:54:42 2021 Return-Path: Delivered-To: freebsd-transport@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C25A95EB7BD for ; Sun, 18 Apr 2021 14:54:42 +0000 (UTC) (envelope-from Richard.Scheffenegger@netapp.com) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4FNXzQ2Gvxz3ks5 for ; Sun, 18 Apr 2021 14:54:42 +0000 (UTC) (envelope-from Richard.Scheffenegger@netapp.com) Received: by mailman.nyi.freebsd.org (Postfix) id 4C4415EB7BB; Sun, 18 Apr 2021 14:54:42 +0000 (UTC) Delivered-To: transport@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4A6ED5EB4EA for ; Sun, 18 Apr 2021 14:54:42 +0000 (UTC) (envelope-from Richard.Scheffenegger@netapp.com) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on20603.outbound.protection.outlook.com [IPv6:2a01:111:f400:7eae::603]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "DigiCert Cloud Services CA-1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FNXzQ0ZvZz3kf9 for ; Sun, 18 Apr 2021 14:54:41 +0000 (UTC) (envelope-from Richard.Scheffenegger@netapp.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UsRu2mbk26R+BeXfSbnTCprUcLMxlKeyiNXg+iQ0Hh5+ESZi3oFJPwbiqDkdu3jo481jBMFwRc9jYIIeNveCdJ5DfbKbMf6/mwMyme2FvXIOvrJymTgrSMCKDs8ZBWl4d2h6/63kSzX4PfuTfhb/q+C4ZfivHgRBPpcQgPcOcyW2k60TuMPYVCtyEbKiU/Yk9OHO/jwgFyeaqMtr07YXV3/zCcpOn3xTCwr45Woc42RHF6atoNKOMezyN08HLla0/KEanrGjp51v+OexlUcCRrtdANjM7y1xu2T3vpFBYdo0AVl0Sg/WK36BePzQkQz5eAMJSMNe7g//vdNl9/uFfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vnx1fCL5GgfUU5ca8qmjWmTYMulGwaTIyVp67K/Io5Y=; b=RAB5bS+cXg47LH9oIETDNj4WJ/5xC5E6gIvZ0CP5VBE7POCdEg7MIO/ayRAra/rLhgq5YQQ4FFbm/CYaKjg5nKtonI8Q1LjSWEJ+84/4JrJooz+ICJQmP1R4HgCf8iSdsRLk9+CN68O0m9uXHp27o/bPuNvcLFRHBYt1ugqJq69t7xqYEdootjempAKTtS/yhlacLvVIZOaIhyi9fK9vvYNRYRwuhMuupqIJRi/xg//E9OBEkbYMBklrwDxv8n8Yd6qFUvkRcBVMAFDkTPwj9ikMX7mPEWZaty6E/T+pLZli4r3Gxnk+Z2FbSeySgp5n0mFdQRV/awdgUl4fCBAn4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=netapp.com; dmarc=pass action=none header.from=netapp.com; dkim=pass header.d=netapp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netapp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vnx1fCL5GgfUU5ca8qmjWmTYMulGwaTIyVp67K/Io5Y=; b=jrLj0t91eGDgchW8/tKnXU83BamOuiYoHIxWQq+lJi2PNOqaeJLRf3WdY2mWnu0Zb4CvFBCz2feuvABv2oh+crcmo0LPBjtBeyAa8VBGsk4pf7eDTJ4MrcjGapUGCJt1VMvY5MhbKYkaGtcMbITHjkF8Uf3Ue3oEORTlLW8bitQBfWtq/j1Nir6TqOCsxKjXgD1DEeKa+J1M6dIP/Vkj9yhzLYcbzXlhe8FNkCtTl1az1KTbtg40q4UIhN76qD2yIkTOWqWsfweoOnbmq7P1G//UWjuLNUtoME+CBA8//ncURpXRzp5vs6NCTTibNSHU+JlRJvaCpBkZXo0X9WrE1A== Received: from PH0PR06MB7639.namprd06.prod.outlook.com (2603:10b6:510:4e::18) by PH0PR06MB7477.namprd06.prod.outlook.com (2603:10b6:510:5e::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.18; Sun, 18 Apr 2021 14:54:38 +0000 Received: from PH0PR06MB7639.namprd06.prod.outlook.com ([fe80::19e2:b5f4:2a64:5eda]) by PH0PR06MB7639.namprd06.prod.outlook.com ([fe80::19e2:b5f4:2a64:5eda%5]) with mapi id 15.20.4042.024; Sun, 18 Apr 2021 14:54:38 +0000 From: "Scheffenegger, Richard" To: Peter Holm CC: "transport@freebsd.org" Subject: AW: git: d1de2b05a001 - main - tcp: Rename rfc6675_pipe to sack.revised, and enable by default Thread-Topic: git: d1de2b05a001 - main - tcp: Rename rfc6675_pipe to sack.revised, and enable by default Thread-Index: AQHXM5CiCqQV41lYIEC3c4/iyC2cxKq5yTAAgAAndzCAAAvZgIAAWrhw Date: Sun, 18 Apr 2021 14:54:38 +0000 Message-ID: References: <202104171350.13HDoPQL025776@gitrepo.freebsd.org> <20210418060040.GA48834@x8.osted.lan> <20210418090419.GA51040@x8.osted.lan> In-Reply-To: <20210418090419.GA51040@x8.osted.lan> Accept-Language: de-AT, en-US Content-Language: de-DE X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [185.236.167.136] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9ba205d5-beae-4d52-d3b2-08d90279e399 x-ms-traffictypediagnostic: PH0PR06MB7477: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1169; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +/37LYeFDav9af2aBHrnS2M9e8AY8cAAXkBe5nYlk8Jx+aRn/s6FO4U/+EUE/cUiODMV/wkl0JU52SBUot76Dqkq+fJV7mqmw4erqxjdKG6uhbi4banEcrVhoudyXV9E6NMJyw7DCvtP0I9UVmzmNkyrSYNJWCBHoI9WS1Kkgf+aEcTY9DF/WgON6iR9jgKm/Ytmi6yJerGTM9XdlQn1VkZ3P7eRy9TgrXUke0yMU5PrUE/HFi0tyv0gJ8lQiRTYOU6bn7J9YWUsHFgFNJYIFbnUO97nDLMYHcFDbNEmwS8QCUcPHgooitXl5JgBmk6vhac49NE8JuXqSL61drMaQ9OUrzVj4Bry/sC4izPB9a2FfjxEehweZqP9U4UyTeH1iKoukWdursuHSjZ9OtvappMY9tUGnksoN/Wf24FUBf95DnD0JU/Jo2hqfRLeB1q5mos12PtqXZzUVemZhvpi69dTXwl1VG0AbeVHG71/tSxQcyN75t/IofZuE8B/rJkXTiL7K7tuHDDQyIamoIMebPA/m4g9lU2rKD0UyxyDSvB+ZqWVrgnHw1u4k50W7Zbu16WNonW878YX4Tp3nmZCks9piK2trgGGJ6v3nvBz743qilLlg+7XxPtwImpGa+Jc6gr7LzO8Vwr+5/PkVKfMMVXhrsJXwEco6w9RENwYCyjl53a2qxsaapiz7B39ZW2w x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR06MB7639.namprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(136003)(39860400002)(346002)(376002)(396003)(8676002)(38100700002)(71200400001)(8936002)(33656002)(6916009)(186003)(478600001)(4326008)(122000001)(9686003)(6506007)(86362001)(966005)(2906002)(5660300002)(26005)(66476007)(66446008)(64756008)(76116006)(66556008)(316002)(7696005)(66574015)(83380400001)(55016002)(52536014)(66946007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?iso-8859-1?Q?oPbrCWx0kG8SUjEhs3Uz9E4RogNkDaSQrpVIqIbNvUeu8v43r/CJxIJUuQ?= =?iso-8859-1?Q?plCvLMg4CtpCVzdbEPlzuvRlwDijT+Vyu96wyTNh5mQ3mmOpp3fMhmSTkq?= =?iso-8859-1?Q?qsDV1gISeaj5NRo0nOCbR5imfcP/XYSOLnYSILngPZc+DyjJQGdXbSN3Xo?= =?iso-8859-1?Q?nMQOXITLZ3vWB80AqDp440r5gJcx3neWRl35Ls7bdCBBTiw8kxZgiHSX9u?= =?iso-8859-1?Q?t0JN+B9WHws6f2kufIolUNz9J5qPCVKs5bC8bIH4KfbAS/Ox2jYITBhuCn?= =?iso-8859-1?Q?3ga9kTvWfz6tQQcrFQCR/nDsUXmYTrNzYs402zjG9eaqXdaKHNQipNxt32?= =?iso-8859-1?Q?KIb9tZIvHr+F7n2e9D96FaiUfNvVy8eyRAWEBnLO9TfG2Po8zoqaMGbMH+?= =?iso-8859-1?Q?H4nRrscEOorgKNECOAJPz51yQZbKIbaHUhVAjeYy87LKQASze1E+1/fn64?= =?iso-8859-1?Q?c4VhGQfA+KXf9RHwmX47R2BCecHnxj4j/5K++/u5A8iSg3hX49QwDpBqUH?= =?iso-8859-1?Q?eOOJp/GfThyem3ggRFt/GrNu/5P8Ob3fwG0ckAZB3r841iFYlQy/FEdmjL?= =?iso-8859-1?Q?8a/xC8JltrVIO/Hs2iz4ocU1Pr4A23K8kBsQp+JRqyji5UgFeG6wTk6vQ2?= =?iso-8859-1?Q?mRLR5cw0yY5kCopvQxbk7T1H6d7+SzRyWrfdjqPCRWA2pHDUjwGClZYBlA?= =?iso-8859-1?Q?TBvGaSB4R6sLKzv0HvaiDlDWLOulRgKGakmoYj5nsTfxhbpbN0CpDrZsgy?= =?iso-8859-1?Q?JKmi/oQPtDsiuhCLjiZgAshmTOawhzuXmF2eQX8UeNE+XmGgPK+tSsnHJw?= =?iso-8859-1?Q?R7oFscMMz7cgsC5y08ufCK8ymFclE4Wjh8ardS4k50U3gMs0ghVk1BVduL?= =?iso-8859-1?Q?YvRWZ2N/1hUoWcy6SHJPGYKLYSIubmD6N7vzw1pAFEdmQooXHiCeTou2FI?= =?iso-8859-1?Q?5OLLp20SVKwsTYLEobr2I4DiVSbeW2/dwWC0UXXA4BVpjBnvUwI9JOjafV?= =?iso-8859-1?Q?1yJiloPG7/Yr1HIqiHg6KV+4RUoBnGZYsGYOE2J+VpWKVSiX2FkEHnSaSZ?= =?iso-8859-1?Q?fXnYciLqfLepk6PiCUGPk+WKtqMnGxmmJuSCQli3RPtqcyYap9kmFnyRTB?= =?iso-8859-1?Q?Y9jFEjg5JROlqfXv/QxY7AuTwVQSsdJrmjY1/qTrDCUfY74Qf6B369E8Ei?= =?iso-8859-1?Q?S6LczhonW9FobDBQvmHAGR4FCjF4v/SBCdaeZ2rQ7FJUWVmwSjIaP1/BUT?= =?iso-8859-1?Q?I8pWcTe2WyepjQ/xCaCvQ1Ij5FhMAbuk8JSXW/q9qmFsAoNP3bXUdyKePX?= =?iso-8859-1?Q?qREfhWVEK6F2Fxj+F2yyYgQtfZr62dLHJTIyT9gqBvy85psBoWB/Ak4fWQ?= =?iso-8859-1?Q?hcmc/9z+rn?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: netapp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR06MB7639.namprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9ba205d5-beae-4d52-d3b2-08d90279e399 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Apr 2021 14:54:38.0969 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4b0911a0-929b-4715-944b-c03745165b3a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HIGAJBRyjlHK6nlGvA2CFxhE3MpBZ8khy4I7EKSsTTDQOL/XVSagADntkbHqnpwwObDq+Qm0ZsFhl01WoTEKSQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR06MB7477 X-Rspamd-Queue-Id: 4FNXzQ0ZvZz3kf9 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: freebsd-transport@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussions of transport level network protocols in FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Apr 2021 14:54:42 -0000 It appears that the SACK scoreboard ended up unordered (the assumption/inva= riant is for it to remain sorted for efficient processing): tp->snd_holes 0xfffff80726393c00 3958849524 3958865856 0xfffff80726393bc0 3958816860 3958849524 0xfffff80726393ae0 3959110836 3959192496 The 2nd entry has lower sequence numbers than the first. The KASSERT happen= ed, when this hole was scheduled for retransmission, but snd_una already ac= knowledged it by that time... It seems the reproduction is stable, I will look into where this happens... Richard Scheffenegger -----Urspr=FCngliche Nachricht----- Von: owner-src-committers@freebsd.org Im= Auftrag von Peter Holm Gesendet: Sonntag, 18. April 2021 11:04 An: Scheffenegger, Richard Cc: Richard Scheffenegger ; src-committers@freebsd.org= ; dev-commits-src-all@freebsd.org; dev-commits-src-main@freebsd.org; transp= ort@freebsd.org Betreff: Re: git: d1de2b05a001 - main - tcp: Rename rfc6675_pipe to sack.re= vised, and enable by default NetApp Security WARNING: This is an external email. Do not click links or o= pen attachments unless you recognize the sender and know the content is saf= e. On Sun, Apr 18, 2021 at 08:30:20AM +0000, Scheffenegger, Richard wrote: > Hi Peter, > > Hmm... the panic appears to be due to a stale entry in the sack scoreboar= d - a hole not having been closed up to snd_una... > > Unlikely that this was solely due to this change by itself. > > Can I get the vmcore and kernel.debug for a close investigation? > Sure. Uploaded to: https://people.freebsd.org/~pho/kernel.vmcore.320-mercat= 1.tar - Peter > > Richard Scheffenegger > > -----Urspr=FCngliche Nachricht----- > Von: Peter Holm > Gesendet: Sonntag, 18. April 2021 08:01 > An: Richard Scheffenegger > Cc: src-committers@freebsd.org; dev-commits-src-all@freebsd.org;=20 > dev-commits-src-main@freebsd.org > Betreff: Re: git: d1de2b05a001 - main - tcp: Rename rfc6675_pipe to=20 > sack.revised, and enable by default > > NetApp Security WARNING: This is an external email. Do not click links or= open attachments unless you recognize the sender and know the content is s= afe. > > > > > On Sat, Apr 17, 2021 at 01:50:25PM +0000, Richard Scheffenegger wrote: > > The branch main has been updated by rscheff: > > > > URL: > > https://cgit.FreeBSD.org/src/commit/?id=3Dd1de2b05a001d3d80f633f576f49 > > 09 > > c2686dda3d > > > > commit d1de2b05a001d3d80f633f576f4909c2686dda3d > > Author: Richard Scheffenegger > > AuthorDate: 2021-04-17 12:59:30 +0000 > > Commit: Richard Scheffenegger > > CommitDate: 2021-04-17 12:59:45 +0000 > > > > tcp: Rename rfc6675_pipe to sack.revised, and enable by default > > > > As full support of RFC6675 is in place, deprecating > > net.inet.tcp.rfc6675_pipe and enabling by default > > net.inet.tcp.sack.revised. > > > > Reviewed By: #transport, kbowling, rrs > > Sponsored by: NetApp, Inc. > > Differential Revision: https://reviews.freebsd.org/D28702 > > --- > > share/man/man4/tcp.4 | 25 ++++++++++++++----------- > > sys/netinet/cc/cc_cubic.c | 2 +- > > sys/netinet/cc/cc_htcp.c | 2 +- > > sys/netinet/cc/cc_newreno.c | 2 +- > > sys/netinet/tcp_input.c | 11 +++-------- > > sys/netinet/tcp_sack.c | 12 +++++++++--- > > sys/netinet/tcp_var.h | 4 ++-- > > 7 files changed, 31 insertions(+), 27 deletions(-) > > > > diff --git a/share/man/man4/tcp.4 b/share/man/man4/tcp.4 index=20 > > d01505e58427..cbb8021226fe 100644 > > --- a/share/man/man4/tcp.4 > > Could this panic be related? > > 20210418 07:19:59 all (204/751): jumbo.sh > panic: tcp_output: sack block to the left of una : -293976 cpuid =3D 3=20 > time =3D 1618723234 > KDB: stack backtrace: > db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame=20 > 0xfffffe00e49b0550 > vpanic() at vpanic+0x181/frame 0xfffffe00e49b05a0 > panic() at panic+0x43/frame 0xfffffe00e49b0600 > tcp_output() at tcp_output+0x27dc/frame 0xfffffe00e49b07c0 > tcp_do_segment() at tcp_do_segment+0x32a3/frame 0xfffffe00e49b08b0 > tcp_input() at tcp_input+0xbd5/frame 0xfffffe00e49b0a10 > ip_input() at ip_input+0x194/frame 0xfffffe00e49b0aa0 > swi_net() at swi_net+0x1a1/frame 0xfffffe00e49b0b20 > ithread_loop() at ithread_loop+0x279/frame 0xfffffe00e49b0bb0 > fork_exit() at fork_exit+0x80/frame 0xfffffe00e49b0bf0 > fork_trampoline() at fork_trampoline+0xe/frame 0xfffffe00e49b0bf0 > --- trap 0, rip =3D 0, rsp =3D 0, rbp =3D 0 --- > > https://people.freebsd.org/~pho/stress/log/log0094.txt > > - Peter From owner-freebsd-transport@freebsd.org Sun Apr 18 15:16:15 2021 Return-Path: Delivered-To: freebsd-transport@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D17EB5EC74D for ; Sun, 18 Apr 2021 15:16:15 +0000 (UTC) (envelope-from jgh@wizmail.org) Received: from wizmail.org (wizmail.org [217.146.107.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.wizmail.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FNYSG6qX1z3lwH for ; Sun, 18 Apr 2021 15:16:14 +0000 (UTC) (envelope-from jgh@wizmail.org) DKIM-Signature: v=1; a=ed25519-sha256; q=dns/txt; c=relaxed/relaxed; d=wizmail.org; s=e202001; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:To:Subject:From: Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive:Autocrypt; bh=E4WTFZje9RPdiq7E4eCrbLxOK01bMYHNmIVoVN2X37M=; b=jrUumG2+VZpgi3/D4TVxhTsQ9Q IgQzhH+4DIFp8iPxbvHX9oOHu65hDmc+oNJ3TlfMYgDeNcNXCCo3Cixm7fBw==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=wizmail.org ; s=r202001; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:To:Subject:From:Sender:Reply-To: Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post: List-Owner:List-Archive:Autocrypt; bh=E4WTFZje9RPdiq7E4eCrbLxOK01bMYHNmIVoVN2X37M=; b=pehWVO6LLq3ljVd+c7NnO3qVvN 5kzTWD4kS7PGxOWvj2iYdqR+ovQPYt6wP7nzkvNns/jQUlH0Yhncz6ZET9hiwLdjOWUakOVngv0W+ J//5CWA9ijEuCIzskZeO/7I8v0fq55kRoHxs/14LrGT/Zx0E5OPa42fKOfhE7TaX7LfmJko1of+Pq ct4kFKt9BYuKk0THICsmFNl697EZsmHVeO4OsdgnsBOqYODAqEgc72wyR/q9zIbppApUZMG8M1iRz MQpBXh0WJnkf/qkIx93Y1M91k/6SscbgmYygi+DjHedInLV15janz2Ek0cFlgaGHsSLph5D+314AN XuFsHF3Q==; Received: from vgate18.wizint.net ([2a00:1940:107::1:2f:0] helo=lap.dom.ain) by wizmail.org (Exim 4.94.122) (TLS1.3) tls TLS_AES_128_GCM_SHA256 with esmtpsa id 1lY97a-003275-Co for freebsd-transport@freebsd.org (return-path ); Sun, 18 Apr 2021 15:14:02 +0000 Subject: Re: TCP Fast Open To: freebsd-transport@freebsd.org References: <7c17539a-b50f-bf52-b55b-5d9b1cc3caad@wizmail.org> From: Jeremy Harris Message-ID: Date: Sun, 18 Apr 2021 16:14:01 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Pcms-Received-Sender: vgate18.wizint.net ([2a00:1940:107::1:2f:0] helo=lap.dom.ain) with esmtpsa X-Rspamd-Queue-Id: 4FNYSG6qX1z3lwH X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=wizmail.org header.s=e202001 header.b=jrUumG2+; dkim=pass header.d=wizmail.org header.s=r202001 header.b=pehWVO6L; dmarc=none; spf=none (mx1.freebsd.org: domain of jgh@wizmail.org has no SPF policy when checking 217.146.107.12) smtp.mailfrom=jgh@wizmail.org X-Spamd-Result: default: False [-3.29 / 15.00]; MID_RHS_MATCH_FROM(0.00)[]; RBL_DBL_DONT_QUERY_IPS(0.00)[217.146.107.12:from]; R_DKIM_ALLOW(-0.20)[wizmail.org:s=e202001,wizmail.org:s=r202001]; FREEFALL_USER(0.00)[jgh]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; ARC_NA(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; SPAMHAUS_ZRD(0.00)[217.146.107.12:from:127.0.2.255]; DMARC_NA(0.00)[wizmail.org]; DKIM_TRACE(0.00)[wizmail.org:+]; NEURAL_HAM_SHORT(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-0.99)[-0.987]; R_SPF_NA(0.00)[no SPF record]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:16353, ipnet:217.146.96.0/20, country:GB]; RCVD_COUNT_TWO(0.00)[2]; MAILMAN_DEST(0.00)[freebsd-transport] X-BeenThere: freebsd-transport@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussions of transport level network protocols in FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Apr 2021 15:16:15 -0000 On 18/04/2021 15:50, Michael Tuexen wrote: > So what you have in mind is a client using TCP fastopen, which does > not send user data with the SYN segment, but the server sending its > banner with the SYN-ACK. Is that the use case you are referring to? Precisely > If that is the case, can you add that description to PR 242492? Done. -- Cheers, Jeremy From owner-freebsd-transport@freebsd.org Sun Apr 18 17:27:48 2021 Return-Path: Delivered-To: freebsd-transport@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7722B5EF962 for ; Sun, 18 Apr 2021 17:27:48 +0000 (UTC) (envelope-from pho@holm.cc) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4FNcN4117Pz3s5l for ; Sun, 18 Apr 2021 17:27:48 +0000 (UTC) (envelope-from pho@holm.cc) Received: by mailman.nyi.freebsd.org (Postfix) id 228325EFD8F; Sun, 18 Apr 2021 17:27:48 +0000 (UTC) Delivered-To: transport@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 224815EFBC0 for ; Sun, 18 Apr 2021 17:27:48 +0000 (UTC) (envelope-from pho@holm.cc) Received: from relay05.pair.com (relay05.pair.com [216.92.24.67]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4FNcN409b3z3sHN for ; Sun, 18 Apr 2021 17:27:47 +0000 (UTC) (envelope-from pho@holm.cc) Received: from x8.osted.lan (unknown [80.208.71.94]) by relay05.pair.com (Postfix) with ESMTP id 60A641A291D; Sun, 18 Apr 2021 13:27:46 -0400 (EDT) Received: from x8.osted.lan (localhost [127.0.0.1]) by x8.osted.lan (8.15.2/8.15.2) with ESMTPS id 13IHRj35056777 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Sun, 18 Apr 2021 19:27:46 +0200 (CEST) (envelope-from pho@x8.osted.lan) Received: (from pho@localhost) by x8.osted.lan (8.15.2/8.15.2/Submit) id 13IHRjkQ056776; Sun, 18 Apr 2021 19:27:45 +0200 (CEST) (envelope-from pho) Date: Sun, 18 Apr 2021 19:27:45 +0200 From: Peter Holm To: "Scheffenegger, Richard" Cc: "transport@freebsd.org" Subject: Re: git: d1de2b05a001 - main - tcp: Rename rfc6675_pipe to sack.revised, and enable by default Message-ID: <20210418172745.GA56730@x8.osted.lan> References: <202104171350.13HDoPQL025776@gitrepo.freebsd.org> <20210418060040.GA48834@x8.osted.lan> <20210418090419.GA51040@x8.osted.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: 4FNcN409b3z3sHN X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: freebsd-transport@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussions of transport level network protocols in FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Apr 2021 17:27:48 -0000 On Sun, Apr 18, 2021 at 02:54:38PM +0000, Scheffenegger, Richard wrote: > It appears that the SACK scoreboard ended up unordered (the assumption/invariant is for it to remain sorted for efficient processing): > > tp->snd_holes > 0xfffff80726393c00 3958849524 3958865856 > 0xfffff80726393bc0 3958816860 3958849524 > 0xfffff80726393ae0 3959110836 3959192496 > > The 2nd entry has lower sequence numbers than the first. The KASSERT happened, when this hole was scheduled for retransmission, but snd_una already acknowledged it by that time... > > It seems the reproduction is stable, I will look into where this happens... > OK. Let me know if there is anything I can help with. - Peter > Richard Scheffenegger > > > -----Ursprüngliche Nachricht----- > Von: owner-src-committers@freebsd.org Im Auftrag von Peter Holm > Gesendet: Sonntag, 18. April 2021 11:04 > An: Scheffenegger, Richard > Cc: Richard Scheffenegger ; src-committers@freebsd.org; dev-commits-src-all@freebsd.org; dev-commits-src-main@freebsd.org; transport@freebsd.org > Betreff: Re: git: d1de2b05a001 - main - tcp: Rename rfc6675_pipe to sack.revised, and enable by default > > NetApp Security WARNING: This is an external email. Do not click links or open attachments unless you recognize the sender and know the content is safe. > > > > > On Sun, Apr 18, 2021 at 08:30:20AM +0000, Scheffenegger, Richard wrote: > > Hi Peter, > > > > Hmm... the panic appears to be due to a stale entry in the sack scoreboard - a hole not having been closed up to snd_una... > > > > Unlikely that this was solely due to this change by itself. > > > > Can I get the vmcore and kernel.debug for a close investigation? > > > > Sure. Uploaded to: https://people.freebsd.org/~pho/kernel.vmcore.320-mercat1.tar > > - Peter > > > > > Richard Scheffenegger > > > > -----Ursprüngliche Nachricht----- > > Von: Peter Holm > > Gesendet: Sonntag, 18. April 2021 08:01 > > An: Richard Scheffenegger > > Cc: src-committers@freebsd.org; dev-commits-src-all@freebsd.org; > > dev-commits-src-main@freebsd.org > > Betreff: Re: git: d1de2b05a001 - main - tcp: Rename rfc6675_pipe to > > sack.revised, and enable by default > > > > NetApp Security WARNING: This is an external email. Do not click links or open attachments unless you recognize the sender and know the content is safe. > > > > > > > > > > On Sat, Apr 17, 2021 at 01:50:25PM +0000, Richard Scheffenegger wrote: > > > The branch main has been updated by rscheff: > > > > > > URL: > > > https://cgit.FreeBSD.org/src/commit/?id=d1de2b05a001d3d80f633f576f49 > > > 09 > > > c2686dda3d > > > > > > commit d1de2b05a001d3d80f633f576f4909c2686dda3d > > > Author: Richard Scheffenegger > > > AuthorDate: 2021-04-17 12:59:30 +0000 > > > Commit: Richard Scheffenegger > > > CommitDate: 2021-04-17 12:59:45 +0000 > > > > > > tcp: Rename rfc6675_pipe to sack.revised, and enable by default > > > > > > As full support of RFC6675 is in place, deprecating > > > net.inet.tcp.rfc6675_pipe and enabling by default > > > net.inet.tcp.sack.revised. > > > > > > Reviewed By: #transport, kbowling, rrs > > > Sponsored by: NetApp, Inc. > > > Differential Revision: https://reviews.freebsd.org/D28702 > > > --- > > > share/man/man4/tcp.4 | 25 ++++++++++++++----------- > > > sys/netinet/cc/cc_cubic.c | 2 +- > > > sys/netinet/cc/cc_htcp.c | 2 +- > > > sys/netinet/cc/cc_newreno.c | 2 +- > > > sys/netinet/tcp_input.c | 11 +++-------- > > > sys/netinet/tcp_sack.c | 12 +++++++++--- > > > sys/netinet/tcp_var.h | 4 ++-- > > > 7 files changed, 31 insertions(+), 27 deletions(-) > > > > > > diff --git a/share/man/man4/tcp.4 b/share/man/man4/tcp.4 index > > > d01505e58427..cbb8021226fe 100644 > > > --- a/share/man/man4/tcp.4 > > > > Could this panic be related? > > > > 20210418 07:19:59 all (204/751): jumbo.sh > > panic: tcp_output: sack block to the left of una : -293976 cpuid = 3 > > time = 1618723234 > > KDB: stack backtrace: > > db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame > > 0xfffffe00e49b0550 > > vpanic() at vpanic+0x181/frame 0xfffffe00e49b05a0 > > panic() at panic+0x43/frame 0xfffffe00e49b0600 > > tcp_output() at tcp_output+0x27dc/frame 0xfffffe00e49b07c0 > > tcp_do_segment() at tcp_do_segment+0x32a3/frame 0xfffffe00e49b08b0 > > tcp_input() at tcp_input+0xbd5/frame 0xfffffe00e49b0a10 > > ip_input() at ip_input+0x194/frame 0xfffffe00e49b0aa0 > > swi_net() at swi_net+0x1a1/frame 0xfffffe00e49b0b20 > > ithread_loop() at ithread_loop+0x279/frame 0xfffffe00e49b0bb0 > > fork_exit() at fork_exit+0x80/frame 0xfffffe00e49b0bf0 > > fork_trampoline() at fork_trampoline+0xe/frame 0xfffffe00e49b0bf0 > > --- trap 0, rip = 0, rsp = 0, rbp = 0 --- > > > > https://people.freebsd.org/~pho/stress/log/log0094.txt > > > > - Peter