From nobody Wed Oct 13 02:44:22 2021 X-Original-To: virtualization@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 721601806BEA for ; Wed, 13 Oct 2021 02:44:26 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HTcLf2lfqz4pLT for ; Wed, 13 Oct 2021 02:44:26 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 3EF5A1FDB4 for ; Wed, 13 Oct 2021 02:44:26 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 19D2iQko029894 for ; Wed, 13 Oct 2021 02:44:26 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 19D2iQN4029893 for virtualization@FreeBSD.org; Wed, 13 Oct 2021 02:44:26 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: virtualization@FreeBSD.org Subject: [Bug 254513] virtio_random: random_harvestq spinning on a CPU with Q35 virtio random device Date: Wed, 13 Oct 2021 02:44:22 +0000 X-Bugzilla-Reason: CC AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: misc X-Bugzilla-Version: 13.0-STABLE X-Bugzilla-Keywords: performance, regression X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: lwhsu@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: virtualization@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc see_also Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Discussion List-Archive: https://lists.freebsd.org/archives/freebsd-virtualization List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-virtualization@freebsd.org X-BeenThere: freebsd-virtualization@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D254513 Li-Wen Hsu changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lwhsu@FreeBSD.org See Also| |https://bugs.freebsd.org/bu | |gzilla/show_bug.cgi?id=3D2= 531 | |75 --=20 You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.= From nobody Thu Oct 14 07:10:56 2021 X-Original-To: freebsd-virtualization@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 99B7E1807744 for ; Thu, 14 Oct 2021 07:11:19 +0000 (UTC) (envelope-from C.Koehne@beckhoff.com) Received: from Internet2.beckhoff.com (internet2.beckhoff.com [194.25.186.210]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "*.beckhoff.com", Issuer "Thawte TLS RSA CA G1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HVLD63QBHz4Yvc for ; Thu, 14 Oct 2021 07:11:18 +0000 (UTC) (envelope-from C.Koehne@beckhoff.com) Received: from 172.17.5.170 by Internet2.beckhoff.com (Tls12, Aes256, Sha384, DiffieHellmanEllipticKey256); Thu, 14 Oct 2021 07:11:17 GMT Received: from CorvinK-NB03.beckhoff.com (172.17.62.127) by ex04.beckhoff.com (172.17.5.170) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.12; Thu, 14 Oct 2021 09:11:15 +0200 From: =?UTF-8?q?Corvin=20K=C3=B6hne?= To: CC: FreeBSD Virtualization Subject: [PATCH] OvmfPkg/Bhyve: install bhyve's ACPI tables Date: Thu, 14 Oct 2021 09:10:56 +0200 Message-ID: <20211014071056.452-1-c.koehne@beckhoff.com> X-Mailer: git-send-email 2.33.0.windows.2 List-Id: Discussion List-Archive: https://lists.freebsd.org/archives/freebsd-virtualization List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-virtualization@freebsd.org X-BeenThere: freebsd-virtualization@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [172.17.62.127] X-ClientProxiedBy: ex06.beckhoff.com (172.17.5.171) To ex04.beckhoff.com (172.17.5.170) X-OLX-Disclaimer: EX04.BECKHOFF.COM X-Rspamd-Queue-Id: 4HVLD63QBHz4Yvc X-Spamd-Bar: ++ Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of C.Koehne@beckhoff.com designates 194.25.186.210 as permitted sender) smtp.mailfrom=C.Koehne@beckhoff.com X-Spamd-Result: default: False [2.26 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; HAS_XOIP(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; R_SPF_ALLOW(-0.20)[+mx]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[beckhoff.com]; RCPT_COUNT_ONE(0.00)[1]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_ALL(0.00)[]; NEURAL_SPAM_LONG(1.00)[1.000]; MID_CONTAINS_FROM(1.00)[]; RCVD_IN_DNSWL_NONE(0.00)[194.25.186.210:from]; NEURAL_SPAM_SHORT(1.00)[1.000]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:3320, ipnet:194.25.0.0/16, country:DE]; RCVD_TLS_LAST(0.00)[]; R_MIXED_CHARSET(0.56)[subject]; RWL_MAILSPIKE_POSSIBLE(0.00)[194.25.186.210:from] X-ThisMailContainsUnwantedMimeParts: N =EF=BB=BFIt's much easier to create configuration dependend ACPI tables for bhyve than for OVMF. For this reason, don't use the statically created ACPI tables provided by OVMF. Instead use the dynamically created ACPI tables of bhyve. If bhyve provides no ACPI tables or we are unable to detect those, fall back to OVMF tables. Implementation is similar to . Signed-off-by: Corvin K=C3=B6hne CC: FreeBSD Virtualization --- MdePkg/Include/Uefi/UefiBaseType.h | 2 + OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c | 10 + OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.h | 6 + OvmfPkg/Bhyve/AcpiPlatformDxe/Bhyve.c | 241 +++++++++++++++++++ 4 files changed, 259 insertions(+) diff --git a/MdePkg/Include/Uefi/UefiBaseType.h b/MdePkg/Include/Uefi/UefiB= aseType.h index 45e2aa63bb..084c52cd0f 100644 --- a/MdePkg/Include/Uefi/UefiBaseType.h +++ b/MdePkg/Include/Uefi/UefiBaseType.h @@ -53,6 +53,8 @@ typedef UINT64 EFI_PHYSICAL_ADDRESS; /// typedef UINT64 EFI_VIRTUAL_ADDRESS; =20 +#define NUMERIC_VALUE_AS_POINTER(Type, Value) ((Type *) ((UINTN)(Value))= ) + /// /// EFI Time Abstraction: /// Year: 1900 - 9999 diff --git a/OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c b/OvmfPkg/Bhyve/A= cpiPlatformDxe/AcpiPlatform.c index 9ccdb4d91c..e7de6937da 100644 --- a/OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c +++ b/OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c @@ -245,6 +245,16 @@ InstallAcpiTables ( { EFI_STATUS Status; =20 + Status =3D InstallBhyveTables (AcpiTable); + if (!EFI_ERROR (Status)) { + return EFI_SUCCESS; + } + if (Status !=3D EFI_NOT_FOUND) { + DEBUG ((DEBUG_INFO, "%a: unable to install bhyve's ACPI tables (%r)\n"= , + __FUNCTION__, Status)); + return Status; + } + Status =3D InstallOvmfFvTables (AcpiTable); =20 return Status; diff --git a/OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.h b/OvmfPkg/Bhyve/A= cpiPlatformDxe/AcpiPlatform.h index 994ee2c7cd..1a99838e8e 100644 --- a/OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.h +++ b/OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.h @@ -46,6 +46,12 @@ BhyveInstallAcpiTable( OUT UINTN *TableKey ); =20 +EFI_STATUS +EFIAPI +InstallBhyveTables ( + IN EFI_ACPI_TABLE_PROTOCOL *AcpiProtocol + ); + EFI_STATUS EFIAPI InstallXenTables ( diff --git a/OvmfPkg/Bhyve/AcpiPlatformDxe/Bhyve.c b/OvmfPkg/Bhyve/AcpiPlat= formDxe/Bhyve.c index 01ee894746..2f5dd87995 100644 --- a/OvmfPkg/Bhyve/AcpiPlatformDxe/Bhyve.c +++ b/OvmfPkg/Bhyve/AcpiPlatformDxe/Bhyve.c @@ -12,6 +12,19 @@ #include #include =20 +#define BHYVE_ACPI_PHYSICAL_ADDRESS ((UINTN)0x000F2400) +#define BHYVE_BIOS_PHYSICAL_END ((UINTN)0x00100000) + +#pragma pack (1) + +typedef struct +{ + EFI_ACPI_DESCRIPTION_HEADER Header; + UINT64 Tables[0]; +} EFI_ACPI_2_0_EXTENDED_SYSTEM_DESCRIPTION_TABLE; + +#pragma pack () + STATIC EFI_STATUS EFIAPI @@ -130,3 +143,231 @@ BhyveInstallAcpiTable ( TableKey ); } + +/** + Get the address of bhyve's ACPI Root System Description Pointer (RSDP). + + @param RsdpPtr Return pointer to RSDP. + + @return EFI_SUCCESS Bhyve's RSDP successfully found. + @return EFI_NOT_FOUND Couldn't find bhyve's RSDP. + @return EFI_UNSUPPORTED Revision is lower than 2. + @return EFI_PROTOCOL_ERROR Invalid RSDP found. + +**/ +EFI_STATUS +EFIAPI +BhyveGetAcpiRsdp ( + OUT EFI_ACPI_2_0_ROOT_SYSTEM_DESCRIPTION_POINTER **RsdpPtr + ) +{ + UINTN RsdpAddress; + EFI_ACPI_2_0_ROOT_SYSTEM_DESCRIPTION_POINTER *Rsdp; + + if (RsdpPtr =3D=3D NULL) { + return EFI_INVALID_PARAMETER; + } + + // + // Detect the RSDP + // + for (RsdpAddress =3D BHYVE_ACPI_PHYSICAL_ADDRESS; + RsdpAddress < BHYVE_BIOS_PHYSICAL_END; + RsdpAddress +=3D 0x10) { + Rsdp =3D NUMERIC_VALUE_AS_POINTER ( + EFI_ACPI_2_0_ROOT_SYSTEM_DESCRIPTION_POINTER, + RsdpAddress + ); + if (Rsdp->Signature !=3D EFI_ACPI_2_0_ROOT_SYSTEM_DESCRIPTION_POINTER_= SIGNATURE) { + continue; + } + if (Rsdp->Revision < 2) { + DEBUG ((DEBUG_INFO, "%a: unsupported RSDP found\n", __FUNCTION__)); + return EFI_UNSUPPORTED; + } + + // + // For ACPI 1.0/2.0/3.0 the checksum of first 20 bytes should be 0. + // For ACPI 2.0/3.0 the checksum of the entire table should be 0. + // + UINT8 Sum =3D CalculateCheckSum8 ( + (CONST UINT8 *)Rsdp, + sizeof (EFI_ACPI_1_0_ROOT_SYSTEM_DESCRIPTION_POINTER) + ); + if (Sum !=3D 0) { + DEBUG ((DEBUG_INFO, "%a: RSDP header checksum not valid: 0x%02x\n", + __FUNCTION__, Sum)); + return EFI_PROTOCOL_ERROR; + } + Sum =3D CalculateCheckSum8 ( + (CONST UINT8 *)Rsdp, + sizeof (EFI_ACPI_2_0_ROOT_SYSTEM_DESCRIPTION_POINTER) + ); + if (Sum !=3D 0) { + DEBUG ((DEBUG_INFO, "%a: RSDP table checksum not valid: 0x%02x\n", + __FUNCTION__, Sum)); + return EFI_PROTOCOL_ERROR; + } + + // + // RSDP was found and is valid + // + *RsdpPtr =3D Rsdp; + + return EFI_SUCCESS; + } + + DEBUG ((DEBUG_INFO, "%a: RSDP not found\n", __FUNCTION__)); + return EFI_NOT_FOUND; +} + +/** + Get bhyve's ACPI tables from the RSDP. And install bhyve's ACPI tables + into the RSDT/XSDT using InstallAcpiTable. + + @param AcpiProtocol Protocol instance pointer. + + @return EFI_SUCCESS All tables were successfully inserted. + @return EFI_UNSUPPORTED Bhyve's ACPI tables doesn't include a XSDT. + @return EFI_PROTOCOL_ERROR Invalid XSDT found. + + @return Error codes propagated from underlying funct= ions. +**/ +EFI_STATUS +EFIAPI +InstallBhyveTables ( + IN EFI_ACPI_TABLE_PROTOCOL *AcpiProtocol + ) +{ + EFI_STATUS Status; + UINTN TableHandle; + EFI_ACPI_2_0_ROOT_SYSTEM_DESCRIPTION_POINTER *Rsdp; + EFI_ACPI_2_0_FIRMWARE_ACPI_CONTROL_STRUCTURE *Facs; + EFI_ACPI_DESCRIPTION_HEADER *Dsdt; + + Rsdp =3D NULL; + Facs =3D NULL; + Dsdt =3D NULL; + + // + // Try to find bhyve ACPI tables + // + Status =3D BhyveGetAcpiRsdp (&Rsdp); + if (EFI_ERROR (Status)) { + DEBUG ((DEBUG_INFO, "%a: can't get RSDP (%r)\n", __FUNCTION__, Status)= ); + return Status; + } + + // + // Bhyve should always provide a XSDT + // + EFI_ACPI_2_0_EXTENDED_SYSTEM_DESCRIPTION_TABLE * CONST Xsdt =3D + NUMERIC_VALUE_AS_POINTER ( + EFI_ACPI_2_0_EXTENDED_SYSTEM_DESCRIPTION_TABLE, + Rsdp->XsdtAddress + ); + if (Xsdt =3D=3D NULL) { + DEBUG ((DEBUG_INFO, "%a: XSDT not found\n", __FUNCTION__)); + return EFI_UNSUPPORTED; + } + if (Xsdt->Header.Length < sizeof (EFI_ACPI_DESCRIPTION_HEADER)) { + DEBUG ((DEBUG_INFO, "%a: invalid XSDT length\n", __FUNCTION__)); + return EFI_PROTOCOL_ERROR; + } + + // + // Install ACPI tables + // + CONST UINTN NumberOfTableEntries =3D + (Xsdt->Header.Length - sizeof (Xsdt->Header)) / sizeof (UINT64); + for (UINTN Index =3D 0; Index < NumberOfTableEntries; Index++) { + EFI_ACPI_DESCRIPTION_HEADER * CONST CurrentTable =3D + NUMERIC_VALUE_AS_POINTER ( + EFI_ACPI_DESCRIPTION_HEADER, + Xsdt->Tables[Index] + ); + Status =3D AcpiProtocol->InstallAcpiTable ( + AcpiProtocol, + CurrentTable, + CurrentTable->Length, + &TableHandle + ); + if (EFI_ERROR (Status)) { + DEBUG ((DEBUG_INFO, "%a: failed to install ACPI table %c%c%c%c (%r)\= n", + __FUNCTION__, + NUMERIC_VALUE_AS_POINTER (UINT8, CurrentTable->Signature)[0], + NUMERIC_VALUE_AS_POINTER (UINT8, CurrentTable->Signature)[1], + NUMERIC_VALUE_AS_POINTER (UINT8, CurrentTable->Signature)[2], + NUMERIC_VALUE_AS_POINTER (UINT8, CurrentTable->Signature)[3], + Status)); + return Status; + } + + if (CurrentTable->Signature =3D=3D EFI_ACPI_2_0_FIXED_ACPI_DESCRIPTION= _TABLE_SIGNATURE) { + EFI_ACPI_2_0_FIXED_ACPI_DESCRIPTION_TABLE * CONST Fadt =3D + (EFI_ACPI_2_0_FIXED_ACPI_DESCRIPTION_TABLE * CONST)CurrentTable; + if (Fadt->XFirmwareCtrl) { + Facs =3D NUMERIC_VALUE_AS_POINTER ( + EFI_ACPI_2_0_FIRMWARE_ACPI_CONTROL_STRUCTURE, + Fadt->XFirmwareCtrl + ); + } else { + Facs =3D NUMERIC_VALUE_AS_POINTER ( + EFI_ACPI_2_0_FIRMWARE_ACPI_CONTROL_STRUCTURE, + Fadt->FirmwareCtrl + ); + } + if (Fadt->XDsdt) { + Dsdt =3D NUMERIC_VALUE_AS_POINTER ( + EFI_ACPI_DESCRIPTION_HEADER, + Fadt->XDsdt + ); + } else { + Dsdt =3D NUMERIC_VALUE_AS_POINTER ( + EFI_ACPI_DESCRIPTION_HEADER, + Fadt->Dsdt + ); + } + } + } + + // + // Install FACS + // + if (Facs !=3D NULL) { + Status =3D AcpiProtocol->InstallAcpiTable ( + AcpiProtocol, + Facs, + Facs->Length, + &TableHandle + ); + if (EFI_ERROR (Status)) { + DEBUG ((DEBUG_INFO, "%a: failed to install FACS (%r)\n", __FUNCTION_= _, + Status)); + return Status; + } + } + + // + // Install DSDT + // If it's not found, something bad happened. Don't continue execution. + // + if (Dsdt =3D=3D NULL) { + DEBUG ((DEBUG_ERROR, "%a: failed to find DSDT\n", __FUNCTION__)); + CpuDeadLoop (); + } + + Status =3D AcpiProtocol->InstallAcpiTable ( + AcpiProtocol, + Dsdt, + Dsdt->Length, + &TableHandle + ); + if (EFI_ERROR (Status)) { + DEBUG ((DEBUG_INFO, "%a: failed to install DSDT (%r)\n", __FUNCTION__, + Status)); + return Status; + } + + return EFI_SUCCESS; +} --=20 2.33.0.windows.2 Beckhoff Automation GmbH & Co. KG | Managing Director: Dipl. Phys. Hans Bec= khoff Registered office: Verl, Germany | Register court: Guetersloh HRA 7075 From nobody Thu Oct 14 07:11:34 2021 X-Original-To: freebsd-virtualization@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id AEB391807B89 for ; Thu, 14 Oct 2021 07:11:49 +0000 (UTC) (envelope-from C.Koehne@beckhoff.com) Received: from netsrv01.beckhoff.com (netsrv01.beckhoff.com [62.159.14.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "*.beckhoff.com", Issuer "Thawte TLS RSA CA G1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HVLDh18jFz4ZF8 for ; Thu, 14 Oct 2021 07:11:48 +0000 (UTC) (envelope-from C.Koehne@beckhoff.com) Received: from 172.17.5.170 by netsrv01.beckhoff.com (Tls12, Aes256, Sha384, DiffieHellmanEllipticKey256); Thu, 14 Oct 2021 07:11:48 GMT Received: from CorvinK-NB03.beckhoff.com (172.17.62.127) by ex04.beckhoff.com (172.17.5.170) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.12; Thu, 14 Oct 2021 09:11:45 +0200 From: =?UTF-8?q?Corvin=20K=C3=B6hne?= To: CC: =?UTF-8?q?Corvin=20K=C3=B6hne?= , FreeBSD Virtualization Subject: [PATCH] OvmfPkg/Bhyve: Use QemuFwCfg over BhyveFwCtl Date: Thu, 14 Oct 2021 09:11:34 +0200 Message-ID: <20211014071134.502-1-c.koehne@beckhoff.com> X-Mailer: git-send-email 2.33.0.windows.2 List-Id: Discussion List-Archive: https://lists.freebsd.org/archives/freebsd-virtualization List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-virtualization@freebsd.org X-BeenThere: freebsd-virtualization@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [172.17.62.127] X-ClientProxiedBy: ex08.beckhoff.com (172.17.5.173) To ex04.beckhoff.com (172.17.5.170) X-OLX-Disclaimer: EX04.BECKHOFF.COM X-Rspamd-Queue-Id: 4HVLDh18jFz4ZF8 X-Spamd-Bar: ++ Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of C.Koehne@beckhoff.com designates 62.159.14.10 as permitted sender) smtp.mailfrom=C.Koehne@beckhoff.com X-Spamd-Result: default: False [2.26 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999]; HAS_XOIP(0.00)[]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+mx:c]; NEURAL_SPAM_SHORT(1.00)[1.000]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[beckhoff.com]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; MID_CONTAINS_FROM(1.00)[]; NEURAL_SPAM_LONG(1.00)[1.000]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:3320, ipnet:62.156.0.0/14, country:DE]; RCVD_TLS_LAST(0.00)[]; R_MIXED_CHARSET(0.56)[subject] X-ThisMailContainsUnwantedMimeParts: N =EF=BB=BFFrom: Corvin K=C3=B6hne QemuFwCfg is more powerful and has more use cases than BhyveFwCtl. Try to use QemuFwCfg in first place. If that fails, fall back to BhyveFwCtl. Signed-off-by: Corvin K=C3=B6hne CC: FreeBSD Virtualization --- .../Bhyve/AcpiPlatformDxe/AcpiPlatformDxe.inf | 1 + OvmfPkg/Bhyve/AcpiPlatformDxe/Bhyve.c | 41 +++++++++++++++++-- OvmfPkg/Bhyve/BhyveX64.dsc | 4 +- 3 files changed, 40 insertions(+), 6 deletions(-) diff --git a/OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatformDxe.inf b/OvmfPkg/Bh= yve/AcpiPlatformDxe/AcpiPlatformDxe.inf index 595fd055f9..94c65f32dc 100644 --- a/OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatformDxe.inf +++ b/OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatformDxe.inf @@ -43,6 +43,7 @@ MemoryAllocationLib OrderedCollectionLib PcdLib + QemuFwCfgLib UefiBootServicesTableLib UefiDriverEntryPoint UefiLib diff --git a/OvmfPkg/Bhyve/AcpiPlatformDxe/Bhyve.c b/OvmfPkg/Bhyve/AcpiPlat= formDxe/Bhyve.c index 01ee894746..e31579311b 100644 --- a/OvmfPkg/Bhyve/AcpiPlatformDxe/Bhyve.c +++ b/OvmfPkg/Bhyve/AcpiPlatformDxe/Bhyve.c @@ -11,6 +11,41 @@ #include #include #include +#include // QemuFwCfgFindFile() + +STATIC +EFI_STATUS +EFIAPI +BhyveGetCpuCount ( + OUT UINT32 *CpuCount + ) +{ + FIRMWARE_CONFIG_ITEM Item; + UINTN Size; + + if (QemuFwCfgIsAvailable ()) { + if (EFI_ERROR (QemuFwCfgFindFile ("opt/bhyve/hw.ncpu", &Item, &Size)))= { + return EFI_NOT_FOUND; + } else if (Size !=3D sizeof (*CpuCount)) { + return EFI_BAD_BUFFER_SIZE; + } + + QemuFwCfgSelectItem (Item); + QemuFwCfgReadBytes (Size, CpuCount); + + return EFI_SUCCESS; + } + + // + // QemuFwCfg not available, try BhyveFwCtl. + // + Size =3D sizeof (*CpuCount); + if (BhyveFwCtlGet ("hw.ncpu", CpuCount, &Size) =3D=3D RETURN_SUCCESS) { + return EFI_SUCCESS; + } + + return EFI_UNSUPPORTED; +} =20 STATIC EFI_STATUS @@ -23,7 +58,6 @@ BhyveInstallAcpiMadtTable ( ) { UINT32 CpuCount; - UINTN cSize; UINTN NewBufferSize; EFI_ACPI_1_0_MULTIPLE_APIC_DESCRIPTION_TABLE_HEADER *Madt; EFI_ACPI_1_0_PROCESSOR_LOCAL_APIC_STRUCTURE *LocalApic; @@ -36,9 +70,8 @@ BhyveInstallAcpiMadtTable ( ASSERT (AcpiTableBufferSize >=3D sizeof (EFI_ACPI_DESCRIPTION_HEADER)); =20 // Query the host for the number of vCPUs - CpuCount =3D 0; - cSize =3D sizeof(CpuCount); - if (BhyveFwCtlGet ("hw.ncpu", &CpuCount, &cSize) =3D=3D RETURN_SUCCESS) = { + Status =3D BhyveGetCpuCount (&CpuCount); + if (!EFI_ERROR (Status)) { DEBUG ((DEBUG_INFO, "Retrieved CpuCount %d\n", CpuCount)); ASSERT (CpuCount >=3D 1); } else { diff --git a/OvmfPkg/Bhyve/BhyveX64.dsc b/OvmfPkg/Bhyve/BhyveX64.dsc index d8fe607d1c..4abb31d993 100644 --- a/OvmfPkg/Bhyve/BhyveX64.dsc +++ b/OvmfPkg/Bhyve/BhyveX64.dsc @@ -163,8 +163,7 @@ SecurityManagementLib|MdeModulePkg/Library/DxeSecurityManagementLib/DxeS= ecurityManagementLib.inf UefiUsbLib|MdePkg/Library/UefiUsbLib/UefiUsbLib.inf SerializeVariablesLib|OvmfPkg/Library/SerializeVariablesLib/SerializeVar= iablesLib.inf - QemuFwCfgLib|OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLibNull.inf - QemuFwCfgS3Lib|OvmfPkg/Library/QemuFwCfgS3Lib/BaseQemuFwCfgS3LibNull.inf + QemuFwCfgLib|OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgDxeLib.inf BhyveFwCtlLib|OvmfPkg/Library/BhyveFwCtlLib/BhyveFwCtlLib.inf VirtioLib|OvmfPkg/Library/VirtioLib/VirtioLib.inf MemEncryptSevLib|OvmfPkg/Library/BaseMemEncryptSevLib/DxeMemEncryptSevLi= b.inf @@ -354,6 +353,7 @@ !endif PciLib|OvmfPkg/Library/DxePciLibI440FxQ35/DxePciLibI440FxQ35.inf MpInitLib|UefiCpuPkg/Library/MpInitLibUp/MpInitLibUp.inf + QemuFwCfgS3Lib|OvmfPkg/Library/QemuFwCfgS3Lib/DxeQemuFwCfgS3LibFwCfg.inf =20 [LibraryClasses.common.UEFI_APPLICATION] PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf --=20 2.33.0.windows.2 Beckhoff Automation GmbH & Co. KG | Managing Director: Dipl. Phys. Hans Bec= khoff Registered office: Verl, Germany | Register court: Guetersloh HRA 7075 From nobody Fri Oct 15 20:02:45 2021 X-Original-To: freebsd-virtualization@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 6AA2C17FA7C5 for ; Fri, 15 Oct 2021 20:02:57 +0000 (UTC) (envelope-from rebecca@bsdio.com) Received: from out03.mta.xmission.com (out03.mta.xmission.com [166.70.13.233]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4HWHJ01RPwz4R54 for ; Fri, 15 Oct 2021 20:02:56 +0000 (UTC) (envelope-from rebecca@bsdio.com) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=simple/simple; d=bsdio.com; s=xmission; h=Subject:From:To:MIME-Version:Date:Message-ID:Content-Type: Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=+tSOaxjU02i1H2p+XF4duu1XJh9tsBbmRm7cvZ+f2PM=; b=S5wkh+qOkUzytuV/91vDf9Jnpt aixMRizSuwLADM602xHk4yvITfPmdXILvszyWBGOje9+NBlIKijG3JUSSoN15ESUZra85XqpK79+5 y77NXaajtJtnMCeOtu/Ft1op0CsSE+oLqkuz+nGJjSsBqQWyOlkkGOMbheu11DDODG9Y=; Received: from in01.mta.xmission.com ([166.70.13.51]:53196) by out03.mta.xmission.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1mbTPk-008BVn-VH for freebsd-virtualization@freebsd.org; Fri, 15 Oct 2021 14:02:49 -0600 Received: from mta5.zcs.xmission.com ([166.70.13.69]:34132) by in01.mta.xmission.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1mbTPj-00GU8h-Nb for freebsd-virtualization@freebsd.org; Fri, 15 Oct 2021 14:02:48 -0600 Received: from localhost (localhost [127.0.0.1]) by mta5.zcs.xmission.com (Postfix) with ESMTP id 5FE211281614 for ; Fri, 15 Oct 2021 14:02:47 -0600 (MDT) X-Amavis-Modified: Mail body modified (using disclaimer) - mta5.zcs.xmission.com Received: from mta5.zcs.xmission.com ([127.0.0.1]) by localhost (mta5.zcs.xmission.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id IKv90Pc6eWpu for ; Fri, 15 Oct 2021 14:02:47 -0600 (MDT) Received: from [10.0.10.162] (c-174-52-16-57.hsd1.ut.comcast.net [174.52.16.57]) by mta5.zcs.xmission.com (Postfix) with ESMTPSA id 6FBE71281602 for ; Fri, 15 Oct 2021 14:02:46 -0600 (MDT) Content-Type: multipart/alternative; boundary="------------S6RXp9BTa1PfBBOY0jF01evB" Message-ID: <3e971d79-a81e-d0d7-fa91-b7265f8d8b66@bsdio.com> Date: Fri, 15 Oct 2021 14:02:45 -0600 List-Id: Discussion List-Archive: https://lists.freebsd.org/archives/freebsd-virtualization List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-virtualization@freebsd.org X-BeenThere: freebsd-virtualization@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 To: FreeBSD Virtualization Content-Language: en-US From: Rebecca Cran X-XM-SPF: eid=1mbTPj-00GU8h-Nb;;;mid=<3e971d79-a81e-d0d7-fa91-b7265f8d8b66@bsdio.com>;;;hst=in01.mta.xmission.com;;;ip=166.70.13.69;;;frm=rebecca@bsdio.com;;;spf=none X-SA-Exim-Connect-IP: 166.70.13.69 X-SA-Exim-Mail-From: rebecca@bsdio.com X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on sa05.xmission.com X-Spam-Level: X-Spam-Status: No, score=-0.2 required=8.0 tests=ALL_TRUSTED,BAYES_50, DCC_CHECK_NEGATIVE,HTML_MESSAGE,XM_B_Unicode autolearn=disabled version=3.4.2 X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.4919] * 0.0 XM_B_Unicode BODY: Testing for specific types of unicode * 0.0 HTML_MESSAGE BODY: HTML included in message * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa05 1397; IP=ok Body=1 Fuz1=1] [Fuz2=1] X-Spam-DCC: XMission; sa05 1397; IP=ok Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: ;FreeBSD Virtualization X-Spam-Relay-Country: X-Spam-Timing: total 403 ms - load_scoreonly_sql: 0.23 (0.1%), signal_user_changed: 11 (2.8%), b_tie_ro: 9 (2.4%), parse: 1.14 (0.3%), extract_message_metadata: 10 (2.5%), get_uri_detail_list: 1.75 (0.4%), tests_pri_-1000: 2.6 (0.6%), tests_pri_-950: 1.31 (0.3%), tests_pri_-900: 0.99 (0.2%), tests_pri_-90: 96 (23.8%), check_bayes: 94 (23.4%), b_tokenize: 10 (2.4%), b_tok_get_all: 6 (1.5%), b_comp_prob: 2.1 (0.5%), b_tok_touch_all: 73 (18.2%), b_finish: 0.86 (0.2%), tests_pri_0: 268 (66.6%), check_dkim_signature: 0.62 (0.2%), check_dkim_adsp: 46 (11.3%), poll_dns_idle: 39 (9.7%), tests_pri_10: 1.72 (0.4%), tests_pri_500: 7 (1.7%), rewrite_mail: 0.00 (0.0%) Subject: vmm is very chatty on 14-CURRENT on AMD EYPC system X-SA-Exim-Version: 4.2.1 (built Sat, 08 Feb 2020 21:53:50 +0000) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) X-Rspamd-Queue-Id: 4HWHJ01RPwz4R54 X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdio.com header.s=xmission header.b=S5wkh+qO; dmarc=none; spf=none (mx1.freebsd.org: domain of rebecca@bsdio.com has no SPF policy when checking 166.70.13.233) smtp.mailfrom=rebecca@bsdio.com X-Spamd-Result: default: False [-3.50 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; RCVD_COUNT_FIVE(0.00)[6]; R_DKIM_ALLOW(-0.20)[bsdio.com:s=xmission]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-virtualization@freebsd.org]; DMARC_NA(0.00)[bsdio.com]; RCPT_COUNT_ONE(0.00)[1]; RECEIVED_SPAMHAUS_PBL(0.00)[174.52.16.57:received]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[bsdio.com:+]; NEURAL_HAM_SHORT(-1.00)[-1.000]; R_SPF_NA(0.00)[no SPF record]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:6315, ipnet:166.70.0.0/16, country:US]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_IN_DNSWL_LOW(-0.20)[166.70.13.51:received,166.70.13.233:from] X-ThisMailContainsUnwantedMimeParts: N This is a multi-part message in MIME format. --------------S6RXp9BTa1PfBBOY0jF01evB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit vmm is spamming my dmesg with _lots_ of repeated messages. I'm running: FreeBSD timp 14.0-CURRENT FreeBSD 14.0-CURRENT #0 main-n250063-a72ee355646: Thu Oct 14 18:09:55 MDT 2021 bcran@timp:/usr/obj/usr/src/amd64.amd6 4/sys/GENERIC  amd64 I'm running it on a Dell PowerEdge R7525: Aug 15 00:13:00 timp kernel: CPU: AMD EPYC 7713 64-Core Processor                 (1996.29-MHz K8-class CPU) ... Aug 15 00:13:00 timp kernel: FreeBSD/SMP: Multiprocessor System Detected: 256 CPUs Aug 15 00:13:00 timp kernel: FreeBSD/SMP: 2 package(s) x 8 cache groups x 8 core(s) x 2 hardware threads The repeated messages are: Oct 14 18:59:08 timp kernel: ivhd2: EVT INTR 2948 Status:0x0 EVT Head:0x0 Tail:0x0] Oct 14 18:59:08 timp kernel:   [CMD Total 0x0] Tail:0x0, Head:0x0. Oct 14 18:59:08 timp kernel: ivhd1: EVT INTR 2943 Status:0x0 EVT Head:0x0 Tail:0x0] Oct 14 18:59:08 timp kernel:   [CMD Total 0x0] Tail:0x0, Head:0x0. Oct 14 18:59:08 timp kernel: ivhd5: EVT INTR 2938 Status:0x0 EVT Head:0x0 Tail:0x0] Oct 14 18:59:08 timp kernel: ivhd6: EVT INTR 2936 Status:0x0 EVT Head:0x0 Tail:0x0] Oct 14 18:59:08 timp kernel: ivhd4: EVT INTR 2945 Status:0x0 EVT Head:0x0 Tail:0x0] Oct 14 18:59:08 timp kernel: ivhd7: EVT INTR 2947 Status:0x0 EVT Head:0x0 Tail:0x0] Oct 14 18:59:08 timp kernel:   [CMD Total 0x0] Tail:0x0, Head:0x0. Oct 14 18:59:08 timp syslogd: last message repeated 3 times -- Rebecca Cran --------------S6RXp9BTa1PfBBOY0jF01evB-- From nobody Sat Oct 16 08:37:54 2021 X-Original-To: freebsd-virtualization@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 14362180719D for ; Sat, 16 Oct 2021 08:38:08 +0000 (UTC) (envelope-from SRS0=yYI6=PE=freebsd.org=grehan@iredmail.onthenet.com.au) Received: from alto.onthenet.com.au (alto.OntheNet.com.au [203.13.68.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4HWc3L3bSRz4kft for ; Sat, 16 Oct 2021 08:38:05 +0000 (UTC) (envelope-from SRS0=yYI6=PE=freebsd.org=grehan@iredmail.onthenet.com.au) Received: from iredmail.onthenet.com.au (iredmail.onthenet.com.au [203.13.68.150]) by alto.onthenet.com.au (Postfix) with ESMTPS id 90BFF20B49E6 for ; Sat, 16 Oct 2021 18:37:55 +1000 (AEST) Received: from iredmail.onthenet.com.au (iredmail.onthenet.com.au [127.0.0.1]) by iredmail.onthenet.com.au (Postfix) with ESMTP id 87E7A20B49B6 for ; Sat, 16 Oct 2021 18:37:55 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nt.com.au; h= content-transfer-encoding:content-language:content-type :content-type:in-reply-to:mime-version:user-agent:date:date :message-id:from:from:references:to:subject:subject; s=dkim; t= 1634373475; x=1636965476; bh=ogOcUyghvdlB9dlxXDkJ3iP41pKgCUURCYI WZ5pHAfw=; b=ds2LtGragDdSPBS5q0ouwoq+xKNw1nyUiOkzNzuVRM87O66mE4F v5gWV2Me6qwzCXhJy9hsz8R3RFb5/4Z2nuGzQ9DnmeDA0579xKcLlsiQcaU9vbq3 Am5dKKfVx7LqbijchZAB9j8mknKVyqExehS7iYCpqj6F+kVjfgKsWq9Y= Received: from iredmail.onthenet.com.au ([127.0.0.1]) by iredmail.onthenet.com.au (iredmail.onthenet.com.au [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id M8-xOB0RZtJU for ; Sat, 16 Oct 2021 18:37:55 +1000 (AEST) Received: from MacBook-Air-4.local (CPE-120-29-50-221.dsl.OntheNet.net [120.29.50.221]) by iredmail.onthenet.com.au (Postfix) with ESMTPSA id 533C120B49B3; Sat, 16 Oct 2021 18:37:55 +1000 (AEST) Subject: Re: [PATCH] OvmfPkg/Bhyve: install bhyve's ACPI tables To: =?UTF-8?Q?Corvin_K=c3=b6hne?= Cc: FreeBSD Virtualization References: <20211014071056.452-1-c.koehne@beckhoff.com> From: Peter Grehan Message-ID: <39f6e329-2d8a-2fa7-cd39-5031d6646b9f@freebsd.org> Date: Sat, 16 Oct 2021 18:37:54 +1000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 List-Id: Discussion List-Archive: https://lists.freebsd.org/archives/freebsd-virtualization List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-virtualization@freebsd.org X-BeenThere: freebsd-virtualization@freebsd.org MIME-Version: 1.0 In-Reply-To: <20211014071056.452-1-c.koehne@beckhoff.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=ONO8IRSB c=1 sm=1 tr=0 a=A6CF0fG5TOl4vs6YHvqXgw==:117 a=lvEwUD+J6oDjjCrxL21sGw==:17 a=IkcTkHD0fZMA:10 a=8gfv0ekSlNoA:10 a=NEAV23lmAAAA:8 a=qO2m75UGKiCQLCtN3y0A:9 a=QEXdDO2ut3YA:10 X-Rspamd-Queue-Id: 4HWc3L3bSRz4kft X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=nt.com.au header.s=dkim header.b=ds2LtGra; dmarc=none; spf=none (mx1.freebsd.org: domain of "SRS0=yYI6=PE=freebsd.org=grehan@iredmail.onthenet.com.au" has no SPF policy when checking 203.13.68.12) smtp.mailfrom="SRS0=yYI6=PE=freebsd.org=grehan@iredmail.onthenet.com.au" X-Spamd-Result: default: False [-3.09 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; RCVD_COUNT_FIVE(0.00)[5]; R_DKIM_ALLOW(-0.20)[nt.com.au:s=dkim]; FROM_HAS_DN(0.00)[]; RWL_MAILSPIKE_GOOD(0.00)[203.13.68.12:from]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-virtualization@freebsd.org]; DMARC_NA(0.00)[freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[nt.com.au:+]; RCPT_COUNT_TWO(0.00)[2]; NEURAL_HAM_SHORT(-0.99)[-0.987]; R_SPF_NA(0.00)[no SPF record]; FORGED_SENDER(0.30)[grehan@freebsd.org,SRS0=yYI6=PE=freebsd.org=grehan@iredmail.onthenet.com.au]; RCVD_IN_DNSWL_LOW(-0.10)[203.13.68.12:from]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:9313, ipnet:203.13.68.0/23, country:AU]; FROM_NEQ_ENVFROM(0.00)[grehan@freebsd.org,SRS0=yYI6=PE=freebsd.org=grehan@iredmail.onthenet.com.au]; MID_RHS_MATCH_FROM(0.00)[] X-ThisMailContainsUnwantedMimeParts: N Hi Corvin K=C3=B6hne wrote:, > =EF=BB=BFIt's much easier to create configuration dependend ACPI tables= for > bhyve than for OVMF. For this reason, don't use the statically > created ACPI tables provided by OVMF. Instead use the dynamically > created ACPI tables of bhyve. If bhyve provides no ACPI tables or > we are unable to detect those, fall back to OVMF tables. Thanks for forwarding this to the list. I think it's an interesting change - fortunately it is opt-in for EFI=20 users since they generally run without the -A option, which will=20 continue to allow ACPI tables to be created from within EFI. There will be some issues with the use of this that may have to be=20 addressed at some point - the PCI mmio/io windows are created assuming that bhyve has done PCI=20 enumeration. If EFI is doing enumeration, these will be incorrect - the SPCR isn't generated by bhyve, but is by EFI. There are Windows=20 users who rely on having a serial console, so this should be added to=20 bhyve. Fortunately the table is trivial. - the space used by bhyve ACPI tables (the area just below 1MB=20 physical) is quite small and has little room for expansion. Qemu gets=20 around this by providing ACPI tables (or just the DSDT) by a fw_cfg=20 interface, and doesn't place the tables into RAM. There are other more general issues with bhyve ACPI. Fork/exec of iasl=20 is convenient, and guarantees tables are syntactically correct, but is=20 expensive in startup time. It would be preferable for tables to be=20 generated without iasl. This is simple for static tables, but for=20 DSDT/SSDT, something like EDK2's dynamic table generation could be used=20 (https://github.com/tianocore/edk2/tree/master/DynamicTablesPkg) I also feel that table generation in EFI is still a viable approach,=20 though it requires additional information to be pass from the=20 hypervisor, and dynamic table generation, to get to feature parity with=20 bhyve's generated tables. later, Peter. From nobody Sat Oct 16 22:30:43 2021 X-Original-To: virtualization@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id E2E7817FD642 for ; Sat, 16 Oct 2021 22:30:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HWyX45dkSz3qlV for ; Sat, 16 Oct 2021 22:30:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 9E0F821E0C for ; Sat, 16 Oct 2021 22:30:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 19GMUiUH031908 for ; Sat, 16 Oct 2021 22:30:44 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 19GMUiIJ031907 for virtualization@FreeBSD.org; Sat, 16 Oct 2021 22:30:44 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: virtualization@FreeBSD.org Subject: [Bug 252445] panics on ESXi triggered by update making devd(8) to load vmci(4) module Date: Sat, 16 Oct 2021 22:30:43 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.2-STABLE X-Bugzilla-Keywords: panic, regression X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: virtualization@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback+ mfc-stable13? mfc-stable12? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Discussion List-Archive: https://lists.freebsd.org/archives/freebsd-virtualization List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-virtualization@freebsd.org X-BeenThere: freebsd-virtualization@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D252445 --- Comment #21 from commit-hook@FreeBSD.org --- A commit in branch stable/13 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D4e5c1be4202a141b7a15c505848abcbea= 535912f commit 4e5c1be4202a141b7a15c505848abcbea535912f Author: Mark Peek AuthorDate: 2021-10-09 21:21:16 +0000 Commit: Mark Peek CommitDate: 2021-10-16 18:22:43 +0000 vmci: fix panic due to freeing unallocated resources Summary: An error mapping PCI resources results in a panic due to unallocated resources being freed up. This change puts the appropriate checks in place to prevent the panic. PR: 252445 Reported by: Marek Zarychta Tested by: marcus MFC after: 1 week Sponsored by: VMware Test Plan: Along with user testing, also simulated error by inserting a ENXIO return in vmci_map_bars(). Reviewed by: marcus Subscribers: imp Differential Revision: https://reviews.freebsd.org/D32016 (cherry picked from commit 0f14bcbe384091c729464cb770372aeb79061070) sys/dev/vmware/vmci/vmci.c | 9 ++++--- sys/dev/vmware/vmci/vmci_event.c | 3 +++ sys/dev/vmware/vmci/vmci_kernel_if.c | 48 +++++++++++++++++++++++++++++++= +++- sys/dev/vmware/vmci/vmci_kernel_if.h | 2 ++ sys/dev/vmware/vmci/vmci_queue_pair.c | 3 +++ 5 files changed, 61 insertions(+), 4 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Sun Oct 17 09:23:36 2021 X-Original-To: virtualization@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 5610F1801F67 for ; Sun, 17 Oct 2021 09:23:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HXF1N1vKcz3hYD for ; Sun, 17 Oct 2021 09:23:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 22B7D23C0 for ; Sun, 17 Oct 2021 09:23:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 19H9NaGo080483 for ; Sun, 17 Oct 2021 09:23:36 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 19H9NabZ080482 for virtualization@FreeBSD.org; Sun, 17 Oct 2021 09:23:36 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: virtualization@FreeBSD.org Subject: [Bug 252445] panics on ESXi triggered by update making devd(8) to load vmci(4) module Date: Sun, 17 Oct 2021 09:23:36 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.2-STABLE X-Bugzilla-Keywords: panic, regression X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: arrowd@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: virtualization@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback+ mfc-stable13? mfc-stable12? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Discussion List-Archive: https://lists.freebsd.org/archives/freebsd-virtualization List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-virtualization@freebsd.org X-BeenThere: freebsd-virtualization@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D252445 --- Comment #22 from Gleb Popov --- Will this change end up into a security update, so that `freebsd-update upg= rade -r 13.0-RELEASE` would work? --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Sun Oct 17 12:34:07 2021 X-Original-To: virtualization@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 58949180965F for ; Sun, 17 Oct 2021 12:34:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HXKFC1rl1z3JxQ for ; Sun, 17 Oct 2021 12:34:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 1FD5F54B9 for ; Sun, 17 Oct 2021 12:34:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 19HCY765084865 for ; Sun, 17 Oct 2021 12:34:07 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 19HCY7D1084864 for virtualization@FreeBSD.org; Sun, 17 Oct 2021 12:34:07 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: virtualization@FreeBSD.org Subject: [Bug 258534] panic on boot under ARM64 Parallels, episode two Date: Sun, 17 Oct 2021 12:34:07 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: arm X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: panic X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: trasz@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-arm@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Discussion List-Archive: https://lists.freebsd.org/archives/freebsd-virtualization List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-virtualization@freebsd.org X-BeenThere: freebsd-virtualization@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D258534 Edward Tomasz Napierala changed: What |Removed |Added ---------------------------------------------------------------------------- Status|New |In Progress --- Comment #1 from Edward Tomasz Napierala --- Fixed by Andrew in 18c21394954. --=20 You are receiving this mail because: You are on the CC list for the bug.= From nobody Sun Oct 17 15:32:46 2021 X-Original-To: virtualization@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 57A13180D490 for ; Sun, 17 Oct 2021 15:32:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HXPCM1f9mz4thD for ; Sun, 17 Oct 2021 15:32:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 1ABD079BF for ; Sun, 17 Oct 2021 15:32:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 19HFWlHl084611 for ; Sun, 17 Oct 2021 15:32:47 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 19HFWlMJ084610 for virtualization@FreeBSD.org; Sun, 17 Oct 2021 15:32:47 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: virtualization@FreeBSD.org Subject: [Bug 252445] panics on ESXi triggered by update making devd(8) to load vmci(4) module Date: Sun, 17 Oct 2021 15:32:46 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.2-STABLE X-Bugzilla-Keywords: panic, regression X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: virtualization@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback+ mfc-stable13? mfc-stable12? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Discussion List-Archive: https://lists.freebsd.org/archives/freebsd-virtualization List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-virtualization@freebsd.org X-BeenThere: freebsd-virtualization@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D252445 --- Comment #23 from commit-hook@FreeBSD.org --- A commit in branch stable/12 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3Db5d236785dc352a65bc29d97c8a89b403= 87eb7a0 commit b5d236785dc352a65bc29d97c8a89b40387eb7a0 Author: Mark Peek AuthorDate: 2021-10-09 21:21:16 +0000 Commit: Mark Peek CommitDate: 2021-10-17 15:31:53 +0000 vmci: fix panic due to freeing unallocated resources Summary: An error mapping PCI resources results in a panic due to unallocated resources being freed up. This change puts the appropriate checks in place to prevent the panic. PR: 252445 Reported by: Marek Zarychta Tested by: marcus MFC after: 1 week Sponsored by: VMware Test Plan: Along with user testing, also simulated error by inserting a ENXIO return in vmci_map_bars(). Reviewed by: marcus Subscribers: imp Differential Revision: https://reviews.freebsd.org/D32016 (cherry picked from commit 0f14bcbe384091c729464cb770372aeb79061070) sys/dev/vmware/vmci/vmci.c | 9 ++++--- sys/dev/vmware/vmci/vmci_event.c | 3 +++ sys/dev/vmware/vmci/vmci_kernel_if.c | 48 +++++++++++++++++++++++++++++++= +++- sys/dev/vmware/vmci/vmci_kernel_if.h | 2 ++ sys/dev/vmware/vmci/vmci_queue_pair.c | 3 +++ 5 files changed, 61 insertions(+), 4 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Sun Oct 17 21:00:49 2021 X-Original-To: virtualization@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 969E81808567 for ; Sun, 17 Oct 2021 21:00:49 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HXXTs33QGz4T5J for ; Sun, 17 Oct 2021 21:00:49 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 308CC142B7 for ; Sun, 17 Oct 2021 21:00:49 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 19HL0n82071021 for ; Sun, 17 Oct 2021 21:00:49 GMT (envelope-from bugzilla-noreply@FreeBSD.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 19HL0njF071020 for virtualization@FreeBSD.org; Sun, 17 Oct 2021 21:00:49 GMT (envelope-from bugzilla-noreply@FreeBSD.org) Message-Id: <202110172100.19HL0njF071020@kenobi.freebsd.org> X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@FreeBSD.org using -f From: bugzilla-noreply@FreeBSD.org To: virtualization@FreeBSD.org Subject: Problem reports for virtualization@FreeBSD.org that need special attention Date: Sun, 17 Oct 2021 21:00:49 +0000 List-Id: Discussion List-Archive: https://lists.freebsd.org/archives/freebsd-virtualization List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-virtualization@freebsd.org X-BeenThere: freebsd-virtualization@freebsd.org MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="16345044492.1BC2187.69093" Content-Transfer-Encoding: 7bit X-ThisMailContainsUnwantedMimeParts: N --16345044492.1BC2187.69093 Date: Sun, 17 Oct 2021 21:00:49 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" To view an individual PR, use: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=(Bug Id). The following is a listing of current problems submitted by FreeBSD users, which need special attention. These represent problem reports covering all versions including experimental development code and obsolete releases. Status | Bug Id | Description ------------+-----------+--------------------------------------------------- In Progress | 247208 | mpt(4): VMWare virtualized LSI controller panics New | 240945 | [hyper-v] [netvsc] hn network driver incorrectly Open | 244838 | "bectl activate -t" does not honor the -t flag in 3 problems total for which you should take action. --16345044492.1BC2187.69093--