From owner-svn-src-all@freebsd.org Mon Dec 28 19:34:28 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 963874BEED0; Mon, 28 Dec 2020 19:34:28 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-oo1-f49.google.com (mail-oo1-f49.google.com [209.85.161.49]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4D4SRR54mYz4chb; Mon, 28 Dec 2020 19:34:27 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-oo1-f49.google.com with SMTP id p72so2419895oop.4; Mon, 28 Dec 2020 11:34:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZWKJQf6MJ8IoHd1KGT7Gsl6mkpfsCKl765gp35RmqgQ=; b=H6a60TwJD2j7cFnvRoIwvhGQpuRJA71qbPxDnYVrvhZlfoSCQZqMlZ87HnjX6rNRUi nkHGydFXL/985qChKfEEwFjHqNDrbJi5WJIXZyx7q7VZpCllmCBuAgUR9Zg17N8h9b/E DouN2tP84rCyfs5+pq1Hna+svokszfv5VDFNp/XFedbGKFVs/7Is5nHvUaLS8nICwrX3 WoswpKaZiT6rL1h/3iGzwbCVpYojUdd/GguZ3G0sXfgaiQie08ZLqrHJniU8VopfFKN8 eI6ivLtgrzUp5aaXEZ59nJfIB1R76+LRr1HxCUwfcfzkgsDgPZra1sS8KgXhh5oerZUT JUIA== X-Gm-Message-State: AOAM533IhWndFYKk5HkV4XrH4AUZKRFXCuZxsWa+OONOQEo8Ic0A6RDY 2bv8+F+Z6romG9LtGFQinZt/hfy88Bzh5QC3zJp+poGcq1g= X-Google-Smtp-Source: ABdhPJxqJCbVj1u6i5lql+mKfI2oiiIOsm/TR56NOhODWfFF0E9CqkM20AzvLN12QJ/xqNKspZcfj6S1SDetPXwQzNo= X-Received: by 2002:a05:6820:54c:: with SMTP id n12mr32029145ooj.79.1609184066441; Mon, 28 Dec 2020 11:34:26 -0800 (PST) MIME-Version: 1.0 References: <202012171958.0BHJwT9X079850@repo.freebsd.org> In-Reply-To: <202012171958.0BHJwT9X079850@repo.freebsd.org> From: Alan Somers Date: Mon, 28 Dec 2020 12:34:15 -0700 Message-ID: Subject: Re: svn commit: r368736 - head/tools/tools/git/hooks To: Ed Maste Cc: src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: 4D4SRR54mYz4chb X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of asomers@gmail.com designates 209.85.161.49 as permitted sender) smtp.mailfrom=asomers@gmail.com X-Spamd-Result: default: False [-2.99 / 15.00]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FREEFALL_USER(0.00)[asomers]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; DMARC_NA(0.00)[freebsd.org]; RBL_DBL_DONT_QUERY_IPS(0.00)[209.85.161.49:from]; RWL_MAILSPIKE_GOOD(0.00)[209.85.161.49:from]; SPAMHAUS_ZRD(0.00)[209.85.161.49:from:127.0.2.255]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; TO_DN_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.99)[-0.992]; RCVD_IN_DNSWL_NONE(0.00)[209.85.161.49:from]; FORGED_SENDER(0.30)[asomers@freebsd.org,asomers@gmail.com]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FROM_NEQ_ENVFROM(0.00)[asomers@freebsd.org,asomers@gmail.com]; MAILMAN_DEST(0.00)[svn-src-all,svn-src-head] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Dec 2020 19:34:28 -0000 On Thu, Dec 17, 2020 at 12:58 PM Ed Maste wrote: > Author: emaste > Date: Thu Dec 17 19:58:29 2020 > New Revision: 368736 > URL: https://svnweb.freebsd.org/changeset/base/368736 > > Log: > Add initial version of git commit message preparation hook > > Start with a slightly modified version of the SVN commit template, to > allow developers to experiment. This will be updated in the future as > our process and techniques evolve. > > This can be installed by copying or symlinking into the .git/hooks/ > directory. > > Feedback from: cem, jhb > Reviewed by: imp > Sponsored by: The FreeBSD Foundation > Differential Revision: https://reviews.freebsd.org/D27633 > > Added: > head/tools/tools/git/hooks/ > head/tools/tools/git/hooks/prepare-commit-msg (contents, props changed) > Thanks! But how can we use it? Is there a "git config" incantation that will use this file? Also, this seems too complicated. Git already has a "config.template" configuration variable. Could we just use that instead, or does it not work for some reason? -Alan