From owner-svn-src-head@freebsd.org Mon Dec 28 19:34:28 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 963874BEED0; Mon, 28 Dec 2020 19:34:28 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-oo1-f49.google.com (mail-oo1-f49.google.com [209.85.161.49]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4D4SRR54mYz4chb; Mon, 28 Dec 2020 19:34:27 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-oo1-f49.google.com with SMTP id p72so2419895oop.4; Mon, 28 Dec 2020 11:34:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZWKJQf6MJ8IoHd1KGT7Gsl6mkpfsCKl765gp35RmqgQ=; b=H6a60TwJD2j7cFnvRoIwvhGQpuRJA71qbPxDnYVrvhZlfoSCQZqMlZ87HnjX6rNRUi nkHGydFXL/985qChKfEEwFjHqNDrbJi5WJIXZyx7q7VZpCllmCBuAgUR9Zg17N8h9b/E DouN2tP84rCyfs5+pq1Hna+svokszfv5VDFNp/XFedbGKFVs/7Is5nHvUaLS8nICwrX3 WoswpKaZiT6rL1h/3iGzwbCVpYojUdd/GguZ3G0sXfgaiQie08ZLqrHJniU8VopfFKN8 eI6ivLtgrzUp5aaXEZ59nJfIB1R76+LRr1HxCUwfcfzkgsDgPZra1sS8KgXhh5oerZUT JUIA== X-Gm-Message-State: AOAM533IhWndFYKk5HkV4XrH4AUZKRFXCuZxsWa+OONOQEo8Ic0A6RDY 2bv8+F+Z6romG9LtGFQinZt/hfy88Bzh5QC3zJp+poGcq1g= X-Google-Smtp-Source: ABdhPJxqJCbVj1u6i5lql+mKfI2oiiIOsm/TR56NOhODWfFF0E9CqkM20AzvLN12QJ/xqNKspZcfj6S1SDetPXwQzNo= X-Received: by 2002:a05:6820:54c:: with SMTP id n12mr32029145ooj.79.1609184066441; Mon, 28 Dec 2020 11:34:26 -0800 (PST) MIME-Version: 1.0 References: <202012171958.0BHJwT9X079850@repo.freebsd.org> In-Reply-To: <202012171958.0BHJwT9X079850@repo.freebsd.org> From: Alan Somers Date: Mon, 28 Dec 2020 12:34:15 -0700 Message-ID: Subject: Re: svn commit: r368736 - head/tools/tools/git/hooks To: Ed Maste Cc: src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: 4D4SRR54mYz4chb X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of asomers@gmail.com designates 209.85.161.49 as permitted sender) smtp.mailfrom=asomers@gmail.com X-Spamd-Result: default: False [-2.99 / 15.00]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FREEFALL_USER(0.00)[asomers]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; DMARC_NA(0.00)[freebsd.org]; RBL_DBL_DONT_QUERY_IPS(0.00)[209.85.161.49:from]; RWL_MAILSPIKE_GOOD(0.00)[209.85.161.49:from]; SPAMHAUS_ZRD(0.00)[209.85.161.49:from:127.0.2.255]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; TO_DN_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.99)[-0.992]; RCVD_IN_DNSWL_NONE(0.00)[209.85.161.49:from]; FORGED_SENDER(0.30)[asomers@freebsd.org,asomers@gmail.com]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FROM_NEQ_ENVFROM(0.00)[asomers@freebsd.org,asomers@gmail.com]; MAILMAN_DEST(0.00)[svn-src-all,svn-src-head] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Dec 2020 19:34:28 -0000 On Thu, Dec 17, 2020 at 12:58 PM Ed Maste wrote: > Author: emaste > Date: Thu Dec 17 19:58:29 2020 > New Revision: 368736 > URL: https://svnweb.freebsd.org/changeset/base/368736 > > Log: > Add initial version of git commit message preparation hook > > Start with a slightly modified version of the SVN commit template, to > allow developers to experiment. This will be updated in the future as > our process and techniques evolve. > > This can be installed by copying or symlinking into the .git/hooks/ > directory. > > Feedback from: cem, jhb > Reviewed by: imp > Sponsored by: The FreeBSD Foundation > Differential Revision: https://reviews.freebsd.org/D27633 > > Added: > head/tools/tools/git/hooks/ > head/tools/tools/git/hooks/prepare-commit-msg (contents, props changed) > Thanks! But how can we use it? Is there a "git config" incantation that will use this file? Also, this seems too complicated. Git already has a "config.template" configuration variable. Could we just use that instead, or does it not work for some reason? -Alan From owner-svn-src-head@freebsd.org Mon Dec 28 22:29:28 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id EAE424C333F; Mon, 28 Dec 2020 22:29:28 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-io1-f48.google.com (mail-io1-f48.google.com [209.85.166.48]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4D4XKN6JWkz4pVJ; Mon, 28 Dec 2020 22:29:28 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: by mail-io1-f48.google.com with SMTP id n4so10627219iow.12; Mon, 28 Dec 2020 14:29:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Qjl7QvscoyDLVTG3rcrV9X3Fk7x0n0bh5vIQV1ZTMos=; b=bgKyjDHvVOl45D8K1o9uK8evdh7EzJGp/5kDwcT6bxF0LVjA4ppV5N252TzUb1Jz9I NZKhjCjjtRw80FZIBr9vyudYKt89/q8QI46NW3/jbSGR+pgyTVXiIrCVt6Nm8/9Psu+Y dCLclsfSRcMjZI3Uw155PmRubOZa4sz13DGWZ5xwaOOok2JwJnawCii481y05CSaCHA9 0bD5bBPhEsvq49iWyYmdxUoPX6TrHmvnHs6rhaBN/33rHaDWHNxwwaHgUsSf/gNZt/Xm 7sB6cqPw9hBQopImLpxXWoCQ/dw0ASaluieHUoBZlDcxBEhexsujmVGHPrVx2Nnxyz3p 5MlQ== X-Gm-Message-State: AOAM530fbMhLbe284bifmXEoz0G/Edg7LoosOspHfuF2FgKO7xixkgfh IOqm994LupgntRh/ET6tcIc9a3Lg8rysHDowvXLCad2yI4dlEA== X-Google-Smtp-Source: ABdhPJwmQODYvvIdmy3zcFb0X7RXqWgpyq8iBpQp5nuOKT7HpHmxtMSJcS4HEvtPzbtW5uLHxpokp/qE9tklQJPwLG8= X-Received: by 2002:a02:cc54:: with SMTP id i20mr40751894jaq.136.1609194567335; Mon, 28 Dec 2020 14:29:27 -0800 (PST) MIME-Version: 1.0 References: <202012171958.0BHJwT9X079850@repo.freebsd.org> In-Reply-To: From: Ed Maste Date: Mon, 28 Dec 2020 17:29:15 -0500 Message-ID: Subject: Re: svn commit: r368736 - head/tools/tools/git/hooks To: Alan Somers Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4D4XKN6JWkz4pVJ X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Dec 2020 22:29:29 -0000 On Mon, 28 Dec 2020 at 14:34, Alan Somers wrote: > > On Thu, Dec 17, 2020 at 12:58 PM Ed Maste wrote: >> >> Author: emaste >> Date: Thu Dec 17 19:58:29 2020 >> New Revision: 368736 >> URL: https://svnweb.freebsd.org/changeset/base/368736 >> >> Log: >> Add initial version of git commit message preparation hook >> > Thanks! But how can we use it? Is there a "git config" incantation that will use this file? Just copy it into .git/hooks/. Can also fetch the latest version directly from cgit; lwhsu added this to https://github.com/bsdimp/freebsd-git-docs/blob/main/URLs.md: fetch https://cgit.freebsd.org/src/plain/tools/tools/git/hooks/prepare-commit-msg -o .git/hooks chmod 755 .git/hooks/prepare-commit-msg I'd like us to end up with a setup-repo.sh or such that will offer to take care of all of these things. >Also, this seems too complicated. Git already has a "config.template" configuration variable. Could we just use that instead, or does it not work for some reason? It does work, although it's a bit awkward. For one thing, the provided template is placed at the top of the message, followed by the default message, but our addition is really commented-out information and fits best in the middle of the existing text - after the "Please enter the..." and before the list of changes and such. With config.template we'd end up with something like: ==== # PR: # ... # Differential Revision: # # Please enter the commit message for your changes. Lines starting # with '#' will be ignored, and an empty message aborts the commit. # # ... ==== Additionally we might want to make some more programmatic changes in the default message (depending on the resolution of some open questions). For example we could strip the "MFC after" line that's copied from the original commit, when preparing the commit message for a MFC/cherry-pick. From owner-svn-src-head@freebsd.org Mon Dec 28 23:45:53 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6B6594C541A; Mon, 28 Dec 2020 23:45:53 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-ot1-f41.google.com (mail-ot1-f41.google.com [209.85.210.41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4D4Z1X44B7z4t63; Mon, 28 Dec 2020 23:45:52 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-ot1-f41.google.com with SMTP id 11so10525340oty.9; Mon, 28 Dec 2020 15:45:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=W0cu45umfF83V7ZXsa+kilA59qXZdNUHo4MjmnjoYt0=; b=aBjG0p9lAX8/1hU+mp7ZGkuNGyAtCvH09hqLCoc1cxxASzEY08hSd7R6SOy07bCzGD nw6vYvo6UO+V5m+QAUx6tcZG4aOYzHZ+do+QVAuIswUWAD9KmVdaW1OF+/fVQcdlHlMm YLbYJp23hyfpO7niENMDjEJVq9+h0+H9yb62u8vJAja/2VrEqAII/xKiYTYPdS63L7Np AqQ+EzdDvHPZiXfLt5c9xGAMj24yT6zq/vBxWM8ebiSIsqIYlDSHA9Ghf+UNzYh0ius3 ibh/DSTzkK8hcloQqAhcCN21hs9d1e2zk8q3bwb+FKzORKo0Fzf+Ax/sOjwDFJuq2uSi TyxA== X-Gm-Message-State: AOAM533hrPHevG+w+cKDUIEgXPd466XK8dbI7OVO3xkGbeTi0khMolPH AitELZmeEIaW6wwh8maHvQehdiox4LAr0gQ0pMeZ+711pME= X-Google-Smtp-Source: ABdhPJywiiBlfrHyrLz4x3BZp7OUfKPmvsYD53PT8hd5SZECvciqH58OPOZHb9sXc88JopuNvpCmRbFKMFNAqnhccoE= X-Received: by 2002:a05:6830:2413:: with SMTP id j19mr35872341ots.251.1609199151168; Mon, 28 Dec 2020 15:45:51 -0800 (PST) MIME-Version: 1.0 References: <202010141228.09ECSg0D023438@repo.freebsd.org> In-Reply-To: From: Alan Somers Date: Mon, 28 Dec 2020 16:45:39 -0700 Message-ID: Subject: Re: svn commit: r366697 - head/usr.bin/xinstall To: Alexander Richardson Cc: Mateusz Guzik , src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: 4D4Z1X44B7z4t63 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of asomers@gmail.com designates 209.85.210.41 as permitted sender) smtp.mailfrom=asomers@gmail.com X-Spamd-Result: default: False [-3.00 / 15.00]; RWL_MAILSPIKE_GOOD(0.00)[209.85.210.41:from]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; RCPT_COUNT_FIVE(0.00)[5]; TO_DN_ALL(0.00)[]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FORGED_SENDER(0.30)[asomers@freebsd.org,asomers@gmail.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[gmail.com]; RBL_DBL_DONT_QUERY_IPS(0.00)[209.85.210.41:from]; R_DKIM_NA(0.00)[]; FROM_NEQ_ENVFROM(0.00)[asomers@freebsd.org,asomers@gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FREEFALL_USER(0.00)[asomers]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; DMARC_NA(0.00)[freebsd.org]; SPAMHAUS_ZRD(0.00)[209.85.210.41:from:127.0.2.255]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[209.85.210.41:from]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[svn-src-all,svn-src-head]; FREEMAIL_CC(0.00)[gmail.com,freebsd.org] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Dec 2020 23:45:53 -0000 BTW, I have a WIP patch to xinstall to make it use copy_file_range. The patch works, but I never wrote a fallback path in case copy_file_range fails for some reason. Alex, would you be interested to finish the patch? -Alan On Wed, Oct 14, 2020 at 7:35 AM Alexander Richardson < arichardson@freebsd.org> wrote: > On Wed, 14 Oct 2020 at 14:29, Mateusz Guzik wrote: > > > > This should use copy_file_range (also available on Linux). > > > > I agree. I even mentioned this in > https://reviews.freebsd.org/D26041#589287. > This change avoids the two unnecessary syscalls, but I agree that > longer-term install should share the copy_file_range code with cp. > The only thing that copy_file_range won't speed up is the check > whether source and target are already identical. > > Alex > > > On 10/14/20, Alex Richardson wrote: > > > Author: arichardson > > > Date: Wed Oct 14 12:28:41 2020 > > > New Revision: 366697 > > > URL: https://svnweb.freebsd.org/changeset/base/366697 > > > > > > Log: > > > install(1): Avoid unncessary fstatfs() calls and use mmap() based on > size > > > > > > According to git blame the trymmap() function was added in 1996 to > skip > > > mmap() calls for NFS file systems. However, nowadays mmap() should be > > > perfectly safe even on NFS. Importantly, onl ufs and cd9660 file > systems > > > were whitelisted so we don't use mmap() on ZFS. It also prevents the > use > > > of mmap() when bootstrapping from macOS/Linux since on those systems > the > > > trymmap() function was always returning zero due to the missing > > > MFSNAMELEN > > > define. > > > > > > This change keeps the trymmap() function but changes it to check > whether > > > using mmap() can reduce the number of system calls that are required. > > > Using mmap() only reduces the number of system calls if we need > multiple > > > read() > > > syscalls, i.e. if the file size is > MAXBSIZE. However, mmap() is > more > > > expensive > > > than read() so this sets the threshold at 4 fewer syscalls. > Additionally, > > > for > > > larger file size mmap() can significantly increase the number of page > > > faults, > > > so avoid it in that case. > > > > > > It's unclear whether using mmap() is ever faster than a read with an > > > appropriate > > > buffer size, but this change at least removes two unnecessary system > > > calls > > > for every file that is installed. > > > > > > Reviewed By: markj > > > Differential Revision: https://reviews.freebsd.org/D26041 > > > > > > Modified: > > > head/usr.bin/xinstall/xinstall.c > > > > > > Modified: head/usr.bin/xinstall/xinstall.c > > > > ============================================================================== > > > --- head/usr.bin/xinstall/xinstall.c Wed Oct 14 10:12:39 2020 > (r366696) > > > +++ head/usr.bin/xinstall/xinstall.c Wed Oct 14 12:28:41 2020 > (r366697) > > > @@ -148,7 +148,7 @@ static void metadata_log(const char *, const > char *, s > > > const char *, const char *, off_t); > > > static int parseid(const char *, id_t *); > > > static int strip(const char *, int, const char *, char **); > > > -static int trymmap(int); > > > +static int trymmap(size_t); > > > static void usage(void); > > > > > > int > > > @@ -1087,7 +1087,7 @@ compare(int from_fd, const char *from_name > __unused, > > > s > > > if (do_digest) > > > digest_init(&ctx); > > > done_compare = 0; > > > - if (trymmap(from_fd) && trymmap(to_fd)) { > > > + if (trymmap(from_len) && trymmap(to_len)) { > > > p = mmap(NULL, from_len, PROT_READ, MAP_SHARED, > > > from_fd, (off_t)0); > > > if (p == MAP_FAILED) > > > @@ -1248,13 +1248,8 @@ copy(int from_fd, const char *from_name, int > to_fd, > > > co > > > > > > digest_init(&ctx); > > > > > > - /* > > > - * Mmap and write if less than 8M (the limit is so we don't > totally > > > - * trash memory on big files. This is really a minor hack, but > it > > > - * wins some CPU back. > > > - */ > > > done_copy = 0; > > > - if (size <= 8 * 1048576 && trymmap(from_fd) && > > > + if (trymmap((size_t)size) && > > > (p = mmap(NULL, (size_t)size, PROT_READ, MAP_SHARED, > > > from_fd, (off_t)0)) != MAP_FAILED) { > > > nw = write(to_fd, p, size); > > > @@ -1523,20 +1518,23 @@ usage(void) > > > * return true (1) if mmap should be tried, false (0) if not. > > > */ > > > static int > > > -trymmap(int fd) > > > +trymmap(size_t filesize) > > > { > > > -/* > > > - * The ifdef is for bootstrapping - f_fstypename doesn't exist in > > > - * pre-Lite2-merge systems. > > > - */ > > > -#ifdef MFSNAMELEN > > > - struct statfs stfs; > > > - > > > - if (fstatfs(fd, &stfs) != 0) > > > - return (0); > > > - if (strcmp(stfs.f_fstypename, "ufs") == 0 || > > > - strcmp(stfs.f_fstypename, "cd9660") == 0) > > > - return (1); > > > -#endif > > > - return (0); > > > + /* > > > + * This function existed to skip mmap() for NFS file systems > whereas > > > + * nowadays mmap() should be perfectly safe. Nevertheless, using > mmap() > > > + * only reduces the number of system calls if we need multiple > read() > > > + * syscalls, i.e. if the file size is > MAXBSIZE. However, > mmap() is > > > + * more expensive than read() so set the threshold at 4 fewer > syscalls. > > > + * Additionally, for larger file size mmap() can significantly > increase > > > + * the number of page faults, so avoid it in that case. > > > + * > > > + * Note: the 8MB limit is not based on any meaningful > benchmarking > > > + * results, it is simply reusing the same value that was used > before > > > + * and also matches bin/cp. > > > + * > > > + * XXX: Maybe we shouldn't bother with mmap() at all, since we > use > > > + * MAXBSIZE the syscall overhead of read() shouldn't be too high? > > > + */ > > > + return (filesize > 4 * MAXBSIZE && filesize < 8 * 1024 * 1024); > > > } > > > _______________________________________________ > > > svn-src-all@freebsd.org mailing list > > > https://lists.freebsd.org/mailman/listinfo/svn-src-all > > > To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" > > > > > > > > > -- > > Mateusz Guzik > From owner-svn-src-head@freebsd.org Tue Dec 29 01:26:54 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id EA30D4C9F42; Tue, 29 Dec 2020 01:26:54 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-ot1-f53.google.com (mail-ot1-f53.google.com [209.85.210.53]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4D4cG66CYrz51qn; Tue, 29 Dec 2020 01:26:54 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-ot1-f53.google.com with SMTP id d20so10727915otl.3; Mon, 28 Dec 2020 17:26:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KRhoFPv418Dq2ZypxRy453JggVlwl/1Y0xbto0x2Jb0=; b=bEZacgbyI4jPrA/nEqNkdWlVgs45wvkgWGlteVCn3oQZLyGCZ9ltB8e12oDM7tDUch 5kWlz2oVqwIYJ7UdcF6BKCkBsqxAtnKnJZ2krQVxb9rueERutiOx9VF6KV4tAJFSQF/j UxG44s8xPORgY1TXn24rdUsFgzkNRsIhrDfXM5nmDAp9CcECn+6Qsp2rqUFRGZ3ZSBkx wOWJ5hd6oXqwG4s0cEeuyOiS/trgQ5fjTLapD95FdblsM1oyQwFoTf5RsLiTieAFC7w6 MCw/tqqmYxzeHazUE7qzN3pPqPYuuuFrq+GdKCWf1iD6BzOdaaGhxCJ5Brej+8c2IUL6 7AjQ== X-Gm-Message-State: AOAM531LdtZIDz4xLzUlQTTwYZKclkQu19YtkIlZgMU9OrNPL7NydROj GOPFD1d875NMoGjCKeiuQAkDtWUTocjWtXzylHWZh0005+U= X-Google-Smtp-Source: ABdhPJzSsO+npwt1rP0rTv9oCa2NJ1Z04fDELzlL2IWuIcafw8HbY461aqnj/dUDQhcL1NnaVrn8/PAWKiNEY0da+1Y= X-Received: by 2002:a9d:a61:: with SMTP id 88mr32911493otg.18.1609205213717; Mon, 28 Dec 2020 17:26:53 -0800 (PST) MIME-Version: 1.0 References: <202012171958.0BHJwT9X079850@repo.freebsd.org> In-Reply-To: From: Alan Somers Date: Mon, 28 Dec 2020 18:26:42 -0700 Message-ID: Subject: Re: svn commit: r368736 - head/tools/tools/git/hooks To: Ed Maste Cc: Alan Somers , src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: 4D4cG66CYrz51qn X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Dec 2020 01:26:55 -0000 On Mon, Dec 28, 2020 at 3:29 PM Ed Maste wrote: > On Mon, 28 Dec 2020 at 14:34, Alan Somers wrote: > > > > On Thu, Dec 17, 2020 at 12:58 PM Ed Maste wrote: > >> > >> Author: emaste > >> Date: Thu Dec 17 19:58:29 2020 > >> New Revision: 368736 > >> URL: https://svnweb.freebsd.org/changeset/base/368736 > >> > >> Log: > >> Add initial version of git commit message preparation hook > >> > > Thanks! But how can we use it? Is there a "git config" incantation > that will use this file? > > Just copy it into .git/hooks/. Can also fetch the latest version > directly from cgit; lwhsu added this to > https://github.com/bsdimp/freebsd-git-docs/blob/main/URLs.md: > > fetch > https://cgit.freebsd.org/src/plain/tools/tools/git/hooks/prepare-commit-msg > -o > > .git/hooks > chmod 755 .git/hooks/prepare-commit-msg > > I'd like us to end up with a setup-repo.sh or such that will offer to > take care of all of these things. > > >Also, this seems too complicated. Git already has a "config.template" > configuration variable. Could we just use that instead, or does it not > work for some reason? > > It does work, although it's a bit awkward. For one thing, the provided > template is placed at the top of the message, followed by the default > message, but our addition is really commented-out information and fits > best in the middle of the existing text - after the "Please enter > the..." and before the list of changes and such. With config.template > we'd end up with something like: > > ==== > > # PR: > # ... > # Differential Revision: > # > # Please enter the commit message for your changes. Lines starting > # with '#' will be ignored, and an empty message aborts the commit. > # > # ... > ==== > > Additionally we might want to make some more programmatic changes in > the default message (depending on the resolution of some open > questions). For example we could strip the "MFC after" line that's > copied from the original commit, when preparing the commit message for > a MFC/cherry-pick. > Thanks for the explanation. It all makes sense, and the commit template works. From owner-svn-src-head@freebsd.org Thu Dec 31 09:07:24 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2B4454B9773 for ; Thu, 31 Dec 2020 09:07:24 +0000 (UTC) (envelope-from 3yZTtXxIJDK4hcbmOldSfYWbgXrxupUaOWZ.Qcagjb-gfQ-VSORTfSSPgR.cfU@trix.bounces.google.com) Received: from mail-il1-x147.google.com (mail-il1-x147.google.com [IPv6:2607:f8b0:4864:20::147]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4D62NW2Pm1z4TZm for ; Thu, 31 Dec 2020 09:07:23 +0000 (UTC) (envelope-from 3yZTtXxIJDK4hcbmOldSfYWbgXrxupUaOWZ.Qcagjb-gfQ-VSORTfSSPgR.cfU@trix.bounces.google.com) Received: by mail-il1-x147.google.com with SMTP id x13so10638242ilv.16 for ; Thu, 31 Dec 2020 01:07:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:reply-to:message-id:date:subject:from:to; bh=FssYHn2pq8mUU9avfyClGKj1HbNQcXHoYRsKmAUvmzo=; b=bVRTXG+fLcgREn1hgPZhMeAQk9tHyA0MdytO9uqJpqyFjTlXNZsNzTiH734lLk3jrY a7gR3dy+4Dfadpr0dqMcZGtGzZhMKplsLWIvAMGHkH55X0aBfb/Yq8afuOaKz3OLBMcG +8pDtiYvw40nFNs7999yniMmFQMGnD/KzQMnVjx5K2lLX7ka/Bq0M8fsFW1oWI2A5GE7 4Z8SStYJxxzB4tuEzMRCyyrgb3db6g5+iNJdI/nq1+2xV9ug/gbboE3BqaSgPXwqs/YT yYvBMowcsjeLerIJ6ftz2DZJJ1mXC4X/9thiPBumvvkE6xfnCWdfMs+wgiWQp5kZdlGq emkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:reply-to:message-id:date:subject :from:to; bh=FssYHn2pq8mUU9avfyClGKj1HbNQcXHoYRsKmAUvmzo=; b=FomW6A20RpQj9AWfuOSqGtLjna02IPL37kvUreqxUq9swCnBiWlbA09DXF3iYF/462 xJwoY3USxkBKwTB+TztOzNIgSNkVcBXSWy5HpvZiGTyDHGXGQzupqa5RCLqHsHwDFqAh ZMdT46FPVxg7FGlaf/bJWKAxdj7zYXlrx+ZyB5Hmr0PjpYEUhA5f3wXUsQbKLf2VbQSi Gvkk1oF5qHktgvIwHWZN+ht9hZ/EUd0CPRjzJFZNrS4ocvM6QC6AHmgXGjYBOEgU6FuF L2hDcMXBSnH3exDyG+O0JZzIm2iy1PIXpU7M4UU5DlPVi/GIAQkzwIv4toZjhY7L7YcJ tS0w== X-Gm-Message-State: AOAM531yrZohZcQOnvXOfeykkvHyoOTNPOGFqC6NGbv/c8ymDx355/XZ 45T1bMkmHw/Zvvv9y8yjrQluZrWMYcBU11UPgxRI MIME-Version: 1.0 X-Received: by 2002:a6b:b2c3:: with SMTP id b186mt47272319iof.126.1609405641213; Thu, 31 Dec 2020 01:07:21 -0800 (PST) Reply-To: tonyaxperkinsj3961@gmail.com X-No-Auto-Attachment: 1 Message-ID: <0000000000008b66f305b7bef384@google.com> Date: Thu, 31 Dec 2020 09:07:22 +0000 Subject: =?UTF-8?B?5qC55o2u5oKo55qE5Lqn5ZOB77yM5om+5Yiw5YWo55CD6ZyA5rGC5oKo5Lqn5ZOB55qE?= =?UTF-8?B?6YeH6LSt5ZWG?= From: tonyaxperkinsj3961@gmail.com To: svn-src-head@freebsd.org X-Rspamd-Queue-Id: 4D62NW2Pm1z4TZm X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=bVRTXG+f; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of 3yZTtXxIJDK4hcbmOldSfYWbgXrxupUaOWZ.Qcagjb-gfQ-VSORTfSSPgR.cfU@trix.bounces.google.com designates 2607:f8b0:4864:20::147 as permitted sender) smtp.mailfrom=3yZTtXxIJDK4hcbmOldSfYWbgXrxupUaOWZ.Qcagjb-gfQ-VSORTfSSPgR.cfU@trix.bounces.google.com X-Spamd-Result: default: False [0.40 / 15.00]; HAS_REPLYTO(0.00)[tonyaxperkinsj3961@gmail.com]; FREEMAIL_FROM(0.00)[gmail.com]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; TO_DN_NONE(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; MIME_BASE64_TEXT(0.10)[]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; FORGED_SENDER(0.30)[tonyaxperkinsj3961@gmail.com,3yZTtXxIJDK4hcbmOldSfYWbgXrxupUaOWZ.Qcagjb-gfQ-VSORTfSSPgR.cfU@trix.bounces.google.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RBL_DBL_DONT_QUERY_IPS(0.00)[2607:f8b0:4864:20::147:from]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[tonyaxperkinsj3961@gmail.com,3yZTtXxIJDK4hcbmOldSfYWbgXrxupUaOWZ.Qcagjb-gfQ-VSORTfSSPgR.cfU@trix.bounces.google.com]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; REPLYTO_EQ_FROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; FREEMAIL_REPLYTO(0.00)[gmail.com]; PREVIOUSLY_DELIVERED(0.00)[svn-src-head@freebsd.org]; NEURAL_SPAM_MEDIUM(1.00)[1.000]; RCPT_COUNT_ONE(0.00)[1]; SPAMHAUS_ZRD(0.00)[2607:f8b0:4864:20::147:from:127.0.2.255]; NEURAL_SPAM_SHORT(1.00)[1.000]; FROM_NO_DN(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::147:from]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[svn-src-head] Content-Type: text/plain; charset="UTF-8"; format=flowed; delsp=yes Content-Transfer-Encoding: base64 X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Dec 2020 09:07:24 -0000 SSd2ZSBpbnZpdGVkIHlvdSB0byBmaWxsIGluIHRoZSBmb2xsb3dpbmcgZm9ybToNCuagueaNruaC qOeahOS6p+WTge+8jOaJvuWIsOWFqOeQg+mcgOaxguaCqOS6p+WTgeeahOmHh+i0reWVhg0KDQpU byBmaWxsIGl0IGluLCB2aXNpdDoNCmh0dHBzOi8vZG9jcy5nb29nbGUuY29tL2Zvcm1zL2QvZS8x RkFJcFFMU2R1OElXVFVmdk9XaGdTZ2RPaVZDcHA2MW1BcEtSMklHUERGd25GOXVHUmVPWkhRdy92 aWV3Zm9ybT92Yz0wJmFtcDtjPTAmYW1wO3c9MSZhbXA7ZmxyPTAmYW1wO3VzcD1tYWlsX2Zvcm1f bGluaw0KDQpJJiMzOTt2ZSBpbnZpdGVkIHlvdSB0byBmaWxsIGluIGEgZm9ybToNCg0KR29vZ2xl IEZvcm1zOiBDcmVhdGUgYW5kIGFuYWx5c2Ugc3VydmV5cy4NCg== From owner-svn-src-head@freebsd.org Fri Jan 1 18:44:00 2021 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 30A8A4D05DF; Fri, 1 Jan 2021 18:44:00 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4D6v7N0vbtz3h5K; Fri, 1 Jan 2021 18:44:00 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1609526640; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OnQsJ3S9OXmNL+UHheJOZU58BAXraCzW3fPlQwQtbgU=; b=ezO81IfDix5NawLJ1h7sEXBojoEB1VWZ9BR/rmb2qZK4cO8uZGNAzSQUf1pDg06IKDz4nc 6opTSrt/D7rQmPP7/gPj1dV9/+9o1MlEktL+b00TVpwqKY66DaxyIKe6qVIv6l52f2OWdN f7P7q67tzRv31T6WQ1PjhvivoIKncGAcS982xuLb5wrEUDjRT36ga/hvI4EuDnp91XBJiy Os0J3G4LrbTCqL/z+OAHpL4YGCaTM1xY/p6KayGlzMElIf2/+gcLBMRJzR6AO+SuQmMGHs TL1mXh2gK20L0cFjER40HgyHRyFfww/5GIXWtjRc9lT+P+7SHT4AvirI+htnZw== Received: by freefall.freebsd.org (Postfix, from userid 1033) id 165A94F4F; Fri, 1 Jan 2021 18:44:00 +0000 (UTC) Date: Fri, 1 Jan 2021 18:44:00 +0000 From: Alexey Dokuchaev To: Konstantin Belousov Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r365787 - head/sys/fs/tmpfs Message-ID: <20210101184400.GA77653@FreeBSD.org> References: <202009152219.08FMJGMw065722@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202009152219.08FMJGMw065722@repo.freebsd.org> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1609526640; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OnQsJ3S9OXmNL+UHheJOZU58BAXraCzW3fPlQwQtbgU=; b=kxFDMFtUZZfq56jwuukZ6P0J8iB5Xyq1Q4VEHjEWhGsPOF9fLM169U2PgEpiueuv88KBIG cRMiurmYvxyOUzfjVXlqqK/zCMMb28JFY/Z7lTgzSx674VRPCNFhAQ55V/93WAo/vbC+MZ swlzpL9Gqz+1SBB0TFe4Vo5QgGYD+WFABoGWlzGf/XUnZJsc+9KRxX17v0VD/HwjDdfSgK ytLuHGA1sYKCILZYFvVBXbSg3CSi2Ip8q+ZH7yY4R66+7TlilgxgPPLoAiPrRvHxbXRWXa 1a8EU+4TmwxuYU04KVNOVW9ZJwMbL9NkzSZ5xf+xEeFtByKVhEwjUnynIXlrjA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1609526640; a=rsa-sha256; cv=none; b=bfMuDOZb8MhgAlaPWu8p+Givm5WqrF+Y5HFxjvB4isjx7tLgAy5x0T0fLmEFljpIbd2GZc lu8IQW6aH/LXA/P/MgS7iYQg2NGbMEFLa5HNRfA7Rxy/rlEjxvyYOcHRHKAZOI8ippLbw3 TKe2jN0Yh7edJnAOOdBDe4sSdGwgXCcmSiDxO8A/yKPrph/Dbh426gvtiiNHQSwXrB6GBr IjY/egzwRwtrPabpZIheefHI00Rcii+/A5TCmgtObb9IDkQCT/6kA3ViD9cd92Kcg4h6uM 7vb44p8gOJNjaN5v7NTrfRgg2f48VUIN6DM3NmYCCo6yr0Q79GmU7LnDr4p+Nw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Jan 2021 18:44:00 -0000 On Tue, Sep 15, 2020 at 10:19:16PM +0000, Konstantin Belousov wrote: > New Revision: 365787 > URL: https://svnweb.freebsd.org/changeset/base/365787 > > Log: > Add tmpfs page cache read support. > > Or it could be explained as lockless (for vnode lock) reads. Reads > are performed from the node tn_obj object. Tmpfs regular vnode object > lifecycle is significantly different from the normal OBJT_VNODE: it is > alive as far as ref_count > 0. This causes panics for me when building ports in the tmpfs-backed tinderbox. Easily reproducible: 1) ./tc tinderbuild ... -b "$@" 2) tail -f .../tmp/make.log4 # on the adjacent console 3) wait until the build job finishes 4) ^C in the "tail" window -> crash ... __mtx_lock_sleep() tmpfs_free_node() tmpfs_fo_close() _fdrop() closef() fdescfree_fds() fdescfree() exit1() sigexit() postsig() ast() doreit_ast() ./danfe From owner-svn-src-head@freebsd.org Fri Jan 1 22:02:32 2021 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 571CC4D56E0; Fri, 1 Jan 2021 22:02:32 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4D6zXR4kVjz3vXC; Fri, 1 Jan 2021 22:02:31 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.16.1/8.16.1) with ESMTPS id 101M2NJw049856 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Sat, 2 Jan 2021 00:02:26 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 101M2NJw049856 Received: (from kostik@localhost) by tom.home (8.16.1/8.16.1/Submit) id 101M2NAZ049855; Sat, 2 Jan 2021 00:02:23 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Sat, 2 Jan 2021 00:02:23 +0200 From: Konstantin Belousov To: Alexey Dokuchaev Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r365787 - head/sys/fs/tmpfs Message-ID: References: <202009152219.08FMJGMw065722@repo.freebsd.org> <20210101184400.GA77653@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210101184400.GA77653@FreeBSD.org> X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on tom.home X-Rspamd-Queue-Id: 4D6zXR4kVjz3vXC X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=gmail.com (policy=none); spf=softfail (mx1.freebsd.org: 2001:470:d5e7:1::1 is neither permitted nor denied by domain of kostikbel@gmail.com) smtp.mailfrom=kostikbel@gmail.com X-Spamd-Result: default: False [-3.00 / 15.00]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; DMARC_POLICY_SOFTFAIL(0.10)[gmail.com : No valid SPF, No valid DKIM,none]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; FREEMAIL_FROM(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; HAS_XAW(0.00)[]; RBL_DBL_DONT_QUERY_IPS(0.00)[2001:470:d5e7:1::1:from]; TO_DN_SOME(0.00)[]; R_SPF_SOFTFAIL(0.00)[~all]; SPAMHAUS_ZRD(0.00)[2001:470:d5e7:1::1:from:127.0.2.255]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US]; MIME_TRACE(0.00)[0:+]; MAILMAN_DEST(0.00)[svn-src-all,svn-src-head]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Jan 2021 22:02:32 -0000 On Fri, Jan 01, 2021 at 06:44:00PM +0000, Alexey Dokuchaev wrote: > On Tue, Sep 15, 2020 at 10:19:16PM +0000, Konstantin Belousov wrote: > > New Revision: 365787 > > URL: https://svnweb.freebsd.org/changeset/base/365787 > > > > Log: > > Add tmpfs page cache read support. > > > > Or it could be explained as lockless (for vnode lock) reads. Reads > > are performed from the node tn_obj object. Tmpfs regular vnode object > > lifecycle is significantly different from the normal OBJT_VNODE: it is > > alive as far as ref_count > 0. > > This causes panics for me when building ports in the tmpfs-backed tinderbox. > Easily reproducible: > > 1) ./tc tinderbuild ... -b "$@" > 2) tail -f .../tmp/make.log4 # on the adjacent console > 3) wait until the build job finishes > 4) ^C in the "tail" window -> crash What exactly 'crash' is ? Provide literal transcription of the kernel messages and not your interpretation of them. > ... > __mtx_lock_sleep() > tmpfs_free_node() What is the source line for tmpfs_free_node() frame ? > tmpfs_fo_close() > _fdrop() > closef() > fdescfree_fds() > fdescfree() > exit1() > sigexit() > postsig() > ast() > doreit_ast() From owner-svn-src-head@freebsd.org Fri Jan 1 22:34:36 2021 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id EBA2D4D6327; Fri, 1 Jan 2021 22:34:36 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4D70FR6mzSz4RPh; Fri, 1 Jan 2021 22:34:35 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.16.1/8.16.1) with ESMTPS id 101MYSB8057128 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Sat, 2 Jan 2021 00:34:31 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 101MYSB8057128 Received: (from kostik@localhost) by tom.home (8.16.1/8.16.1/Submit) id 101MYSbo057127; Sat, 2 Jan 2021 00:34:28 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Sat, 2 Jan 2021 00:34:28 +0200 From: Konstantin Belousov To: Alexey Dokuchaev Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r365787 - head/sys/fs/tmpfs Message-ID: References: <202009152219.08FMJGMw065722@repo.freebsd.org> <20210101184400.GA77653@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on tom.home X-Rspamd-Queue-Id: 4D70FR6mzSz4RPh X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=gmail.com (policy=none); spf=softfail (mx1.freebsd.org: 2001:470:d5e7:1::1 is neither permitted nor denied by domain of kostikbel@gmail.com) smtp.mailfrom=kostikbel@gmail.com X-Spamd-Result: default: False [-3.00 / 15.00]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; DMARC_POLICY_SOFTFAIL(0.10)[gmail.com : No valid SPF, No valid DKIM,none]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; FREEMAIL_FROM(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; HAS_XAW(0.00)[]; RBL_DBL_DONT_QUERY_IPS(0.00)[2001:470:d5e7:1::1:from]; TO_DN_SOME(0.00)[]; R_SPF_SOFTFAIL(0.00)[~all]; SPAMHAUS_ZRD(0.00)[2001:470:d5e7:1::1:from:127.0.2.255]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US]; MIME_TRACE(0.00)[0:+]; MAILMAN_DEST(0.00)[svn-src-all,svn-src-head]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Jan 2021 22:34:37 -0000 On Sat, Jan 02, 2021 at 12:02:29AM +0200, Konstantin Belousov wrote: > On Fri, Jan 01, 2021 at 06:44:00PM +0000, Alexey Dokuchaev wrote: > > On Tue, Sep 15, 2020 at 10:19:16PM +0000, Konstantin Belousov wrote: > > > New Revision: 365787 > > > URL: https://svnweb.freebsd.org/changeset/base/365787 > > > > > > Log: > > > Add tmpfs page cache read support. > > > > > > Or it could be explained as lockless (for vnode lock) reads. Reads > > > are performed from the node tn_obj object. Tmpfs regular vnode object > > > lifecycle is significantly different from the normal OBJT_VNODE: it is > > > alive as far as ref_count > 0. > > > > This causes panics for me when building ports in the tmpfs-backed tinderbox. > > Easily reproducible: > > > > 1) ./tc tinderbuild ... -b "$@" > > 2) tail -f .../tmp/make.log4 # on the adjacent console > > 3) wait until the build job finishes > > 4) ^C in the "tail" window -> crash > What exactly 'crash' is ? Provide literal transcription of the kernel > messages and not your interpretation of them. > > > ... > > __mtx_lock_sleep() > > tmpfs_free_node() > What is the source line for tmpfs_free_node() frame ? > > > tmpfs_fo_close() > > _fdrop() > > closef() > > fdescfree_fds() > > fdescfree() > > exit1() > > sigexit() > > postsig() > > ast() > > doreit_ast() Forgot to mention this. I tried a somewhat naive method to reproduce it: # mount -t tmpfs none /mnt # echo 123 >/mnt/1 # tail -f /mnt/1 while in other session, # umount -f /mnt but this only resulted in report of EIO from tail, and SIGINT killed tail without producing the panic/page fault/whatever you see. From owner-svn-src-head@freebsd.org Sat Jan 2 06:29:07 2021 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 103D94C506F; Sat, 2 Jan 2021 06:29:07 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4D7Bmy74r4z3GHn; Sat, 2 Jan 2021 06:29:06 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1609568947; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5st1pqN3yAH9RZI0HeO5q4iNYGKTXKdYxCPXggbVFv4=; b=sCV9x7wCLHWA+gKuSRLYhKJUbYj91VlE3/fulf3ieUBrfiSlucqdZ3w9n883sospdDLJYF NuVd9yYndbMkOnhG7FqtxViOs8tSailMs2CUXqdxstPzKWRPL5XdP7gCwcVJ+5r2euGUE5 PUXMoN759yvnERAzwHyDOp9DIYXLTJntaUM3QJIh009ojwPIAED40WUBHJkEUHe+noKTcG 4oVK9tlSWDdKfHnFWH0g+OesCz9fcc+prK6oXchakTwjRRrU/yIZQPNgPjklfkOd61fwuO 6EMtRsQDFZ4JELNUAz3XECAHCQpHtp+dO5+f/WGQn/6eYyncB+LlKudEY5Z3Cw== Received: by freefall.freebsd.org (Postfix, from userid 1033) id EB8B2F549; Sat, 2 Jan 2021 06:29:06 +0000 (UTC) Date: Sat, 2 Jan 2021 06:29:06 +0000 From: Alexey Dokuchaev To: Konstantin Belousov Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r365787 - head/sys/fs/tmpfs Message-ID: <20210102062906.GA98322@FreeBSD.org> References: <202009152219.08FMJGMw065722@repo.freebsd.org> <20210101184400.GA77653@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1609568947; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5st1pqN3yAH9RZI0HeO5q4iNYGKTXKdYxCPXggbVFv4=; b=DQw+hsJ2mpDaKxmYLAAXmyxhMWZqQ+uUUW9oQmPetY4FtXP065u/xACYtOTToGXEo+AaDp M6n4z25k3kCPV5gxa0MUV+xv7RtD4fb4hk/r4RcBIuz9woans0hesnRJpYJy2uQdwvHzyH fR3wc7xXKkQTHtlw7DJgMGQnMqXt0TZnULS7c8N1Dqwz3Pq2j16TLVKhk6GA9tbBK1o+Af +O5awPP9B6p7FP9zUa6BhZ7JfJ3eS7367Nw485Cp/SVAElYO7LPLCxjgAqyIc3NCMLIyv7 DpoxVOa/HFZeoR/mk8tQfGhNbY9JJNI9ON+7TUaezFie5XHXJP7aIzH609B3tA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1609568947; a=rsa-sha256; cv=none; b=oEUNgBoCZAWYzEGBs3cEF9011Bi97ohYSLZcLOj819DJdNkM6uN2agYHVHLk9AAEs98/Nw LE9kbH/whQEfy7+RuTGgig/dZEcIG4T8CdD01pSdZyuUNNsKR+gm0IfiAKmtkj7epQFp6x OEm8edoYlDLMHm10zh1MIo8COmq1K4gvGD9/pH8bOqfZKiJQG6RWgTUmuWHWifXsGsFdhJ yzjEXosLVHEhPLQBScFnrUdGDC9GME/0dBpsgzTu+opo1jiFwQcvUz48Um0ry9o4VoW5R1 taKRjF0afbYgZAmuC41fuO64BJ6ptIh59j016uYQEVXK5Yk9rnOYIzgngUoOpQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Jan 2021 06:29:07 -0000 On Sat, Jan 02, 2021 at 12:02:23AM +0200, Konstantin Belousov wrote: > On Fri, Jan 01, 2021 at 06:44:00PM +0000, Alexey Dokuchaev wrote: > > On Tue, Sep 15, 2020 at 10:19:16PM +0000, Konstantin Belousov wrote: > > > New Revision: 365787 > > > URL: https://svnweb.freebsd.org/changeset/base/365787 > > > > > > Log: > > > Add tmpfs page cache read support. > > > > > > Or it could be explained as lockless (for vnode lock) reads. Reads > > > are performed from the node tn_obj object. Tmpfs regular vnode object > > > lifecycle is significantly different from the normal OBJT_VNODE: it is > > > alive as far as ref_count > 0. > > > > This causes panics for me when building ports in the tmpfs-backed tinderbox. > > Easily reproducible: > > > > 1) ./tc tinderbuild ... -b "$@" > > 2) tail -f .../tmp/make.log4 # on the adjacent console > > 3) wait until the build job finishes > > 4) ^C in the "tail" window -> crash > > What exactly 'crash' is? The usual "Fatal trap 12: page fault while in kernel mode" panic. > Provide literal transcription of the kernel messages and not your > interpretation of them. Sorry, I've just quickly copied function names off the screen since my debug symbols did not match the running kernel at that moment and I've thought maybe it's a known bug that was fixed after r368820. I've now made things in sync so can provide full context (see below). > > ... > > __mtx_lock_sleep() at __mtx_lock_sleep+0xd2/frame 0xfffffe0060636490 > > tmpfs_free_node() at tmpfs_free_node+0xc7/frame 0xfffffe00606364c0 > > What is the source line for tmpfs_free_node() frame? /usr/src/crash-dec/sys/fs/tmpfs/tmpfs_subr.c:373 (kgdb) list *(tmpfs_free_node+0xc7) 0xffffffff815246d7 is in tmpfs_free_node (/usr/src/crash-dec/sys/fs/tmpfs/tmpfs_subr.c:374). 369 { 370 if (refcount_release_if_not_last(&node->tn_refcount)) 371 return; 372 373 TMPFS_LOCK(tmp); 374 TMPFS_NODE_LOCK(node); 375 if (!tmpfs_free_node_locked(tmp, node, false)) { 376 TMPFS_NODE_UNLOCK(node); 377 TMPFS_UNLOCK(tmp); 378 } (kgdb) ./danfe From owner-svn-src-head@freebsd.org Sat Jan 2 14:52:44 2021 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 803414D2489; Sat, 2 Jan 2021 14:52:44 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4D7Py34Wwpz4TTj; Sat, 2 Jan 2021 14:52:43 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.16.1/8.16.1) with ESMTPS id 102EqX30000413 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Sat, 2 Jan 2021 16:52:36 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 102EqX30000413 Received: (from kostik@localhost) by tom.home (8.16.1/8.16.1/Submit) id 102EqXQf000412; Sat, 2 Jan 2021 16:52:33 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Sat, 2 Jan 2021 16:52:33 +0200 From: Konstantin Belousov To: Alexey Dokuchaev Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r365787 - head/sys/fs/tmpfs Message-ID: References: <202009152219.08FMJGMw065722@repo.freebsd.org> <20210101184400.GA77653@FreeBSD.org> <20210102062906.GA98322@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210102062906.GA98322@FreeBSD.org> X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on tom.home X-Rspamd-Queue-Id: 4D7Py34Wwpz4TTj X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=gmail.com (policy=none); spf=softfail (mx1.freebsd.org: 2001:470:d5e7:1::1 is neither permitted nor denied by domain of kostikbel@gmail.com) smtp.mailfrom=kostikbel@gmail.com X-Spamd-Result: default: False [-3.00 / 15.00]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; DMARC_POLICY_SOFTFAIL(0.10)[gmail.com : No valid SPF, No valid DKIM,none]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; FREEMAIL_FROM(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; HAS_XAW(0.00)[]; RBL_DBL_DONT_QUERY_IPS(0.00)[2001:470:d5e7:1::1:from]; TO_DN_SOME(0.00)[]; R_SPF_SOFTFAIL(0.00)[~all]; SPAMHAUS_ZRD(0.00)[2001:470:d5e7:1::1:from:127.0.2.255]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US]; MIME_TRACE(0.00)[0:+]; MAILMAN_DEST(0.00)[svn-src-all,svn-src-head]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Jan 2021 14:52:44 -0000 On Sat, Jan 02, 2021 at 06:29:06AM +0000, Alexey Dokuchaev wrote: > On Sat, Jan 02, 2021 at 12:02:23AM +0200, Konstantin Belousov wrote: > > On Fri, Jan 01, 2021 at 06:44:00PM +0000, Alexey Dokuchaev wrote: > > > On Tue, Sep 15, 2020 at 10:19:16PM +0000, Konstantin Belousov wrote: > > > > New Revision: 365787 > > > > URL: https://svnweb.freebsd.org/changeset/base/365787 > > > > > > > > Log: > > > > Add tmpfs page cache read support. > > > > > > > > Or it could be explained as lockless (for vnode lock) reads. Reads > > > > are performed from the node tn_obj object. Tmpfs regular vnode object > > > > lifecycle is significantly different from the normal OBJT_VNODE: it is > > > > alive as far as ref_count > 0. > > > > > > This causes panics for me when building ports in the tmpfs-backed tinderbox. > > > Easily reproducible: > > > > > > 1) ./tc tinderbuild ... -b "$@" > > > 2) tail -f .../tmp/make.log4 # on the adjacent console > > > 3) wait until the build job finishes > > > 4) ^C in the "tail" window -> crash > > > > What exactly 'crash' is? > > The usual "Fatal trap 12: page fault while in kernel mode" panic. And everything else ? There is a lot of useful data there (for me at least). > > > Provide literal transcription of the kernel messages and not your > > interpretation of them. > > Sorry, I've just quickly copied function names off the screen since my > debug symbols did not match the running kernel at that moment and I've > thought maybe it's a known bug that was fixed after r368820. I've now > made things in sync so can provide full context (see below). > > > > ... > > > __mtx_lock_sleep() at __mtx_lock_sleep+0xd2/frame 0xfffffe0060636490 > > > tmpfs_free_node() at tmpfs_free_node+0xc7/frame 0xfffffe00606364c0 > > > > What is the source line for tmpfs_free_node() frame? > > /usr/src/crash-dec/sys/fs/tmpfs/tmpfs_subr.c:373 > > (kgdb) list *(tmpfs_free_node+0xc7) > 0xffffffff815246d7 is in tmpfs_free_node (/usr/src/crash-dec/sys/fs/tmpfs/tmpfs_subr.c:374). > 369 { > 370 if (refcount_release_if_not_last(&node->tn_refcount)) > 371 return; > 372 > 373 TMPFS_LOCK(tmp); > 374 TMPFS_NODE_LOCK(node); > 375 if (!tmpfs_free_node_locked(tmp, node, false)) { > 376 TMPFS_NODE_UNLOCK(node); > 377 TMPFS_UNLOCK(tmp); > 378 } > (kgdb) Ok. So two questions: 1. Do you have core dump? If not, can you configure it and obtain the dump? 2. Can you look more closely what you do from the user PoV there, and provide a recipe to reproduce without involving 'tc tinderbiuild', whatever it is ? In particular, I want to see the *node content. From owner-svn-src-head@freebsd.org Sat Jan 2 16:35:22 2021 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4B5BE4D634B; Sat, 2 Jan 2021 16:35:22 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4D7SDV1gQnz4cP5; Sat, 2 Jan 2021 16:35:22 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1609605322; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fGEpsNtVe9h3cCc8tMKTWr2IaNaSOs0U37Vvv//hTgQ=; b=DVfQp76a/PuEHaKJMFvT5j7Jqcm/wsuASv8vcRjzxe0ptZHVKrCmvMoZaLbJMUGZ+Wnwl3 fIx46l5hDM6bmfDWX3QDG/22zoFmhIlWwjTr+6KwsIm6YrzCH+HoW66uO8kR9P3PUWkV55 s9s852ePqGsnf90UYVoCIjH2mhtC9yUNvFQQfw8HB+uaVvzKN8EmJalKqP0+aTeY/6n7KH xteGbgGz1nrLbo+BAXa0G5lY/4ARXnlJRWwOZRCfKd/xJBjy3cg/5EP4ZQW9ROquyQfWyg Qif+1l2+OhSWxtCCivW/QEMikr+Zg1pRDhWzR7Pbg+qvgljCzuAk/VAnb7uXKg== Received: by freefall.freebsd.org (Postfix, from userid 1033) id 274E615332; Sat, 2 Jan 2021 16:35:22 +0000 (UTC) Date: Sat, 2 Jan 2021 16:35:22 +0000 From: Alexey Dokuchaev To: Konstantin Belousov Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r365787 - head/sys/fs/tmpfs Message-ID: <20210102163522.GA3248@FreeBSD.org> References: <202009152219.08FMJGMw065722@repo.freebsd.org> <20210101184400.GA77653@FreeBSD.org> <20210102062906.GA98322@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1609605322; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fGEpsNtVe9h3cCc8tMKTWr2IaNaSOs0U37Vvv//hTgQ=; b=wuiBM+xfSz4pcRU5qITC5A9C/XxTuCSIZDXZy2+4+QkRsTDz6Vd+b6FwFCPiv1f6idnZxm 6TjnqaIdRs0kOFcacuxgO3ammI2F1S4cIBc1AOPN16k0YhUngWGZM/buW2/8S6BrmTtnQ0 o0ANzMksNxrR2rR7c7+Vd8qmSYv6cbOODSQYgeJ6WHz80mZoA+ZBD4/U2rsg7HBDPgFclu nU6qqmtzApdxPvAA40MD7eEL92O4Vhc+ZQLB5NAwoUsnnxSpHe7V5W2P4g0T7wbf7bUzqt jnLv07RHSitf544THetDGXM19uh8E3Gu43pLAUvatiAZEdnhm8YSIFdaWzb6fQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1609605322; a=rsa-sha256; cv=none; b=eykx5bw6+37Rve6w/5b9emQDLrg+oS9/Gtpk6VzYedxMYxBb9s/C6gPyGe63YAPuZy0YA5 G/MxS9Mx8FbAqloz2plrVptboB1W937ntDr2FZY+l8R13rposUbQUMSS30xghPMbR2Ov60 +SxOlshjrpEIwewruJoabyft16O2Wrm10Xfp+VjRnyOBU/djRMsp88lVBQi8HydH6wVbMT qdd8OAmlqQ8gjvfMQL+LlgOfQ+oqRXoXjCWN+iFXNzsIRxldEKLtDr8fk+EiJEn53pxXMO ie1ClTdVsELwo4edi7oCefh5bnHPE2bADVa3c6LXTkxwu0kEgDXoXzu3jp/7Ug== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Jan 2021 16:35:22 -0000 On Sat, Jan 02, 2021 at 04:52:33PM +0200, Konstantin Belousov wrote: > ... > Ok. So two questions: > 1. Do you have core dump? I have vmcore.0 and matching kernel.debug, I'll gladly obtain and provide anything else you might wanna need. > 2. Can you look more closely what you do from the user PoV there, and > provide a recipe to reproduce without involving 'tc tinderbiuild', > whatever it is? Yeah, I know that would be nice; the naive way (from the previous email of yours) indeed doesn't trigger it, I haven't found one which does yet. > In particular, I want to see the *node content. I can upload the kernel core+debug files to freefall so you could have a closer look yourself. ./danfe From owner-svn-src-head@freebsd.org Sat Jan 2 16:47:23 2021 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 66A484D66E7; Sat, 2 Jan 2021 16:47:23 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4D7SVL3VSjz4cvp; Sat, 2 Jan 2021 16:47:22 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.16.1/8.16.1) with ESMTPS id 102GlEHu027910 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Sat, 2 Jan 2021 18:47:17 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 102GlEHu027910 Received: (from kostik@localhost) by tom.home (8.16.1/8.16.1/Submit) id 102GlEuD027909; Sat, 2 Jan 2021 18:47:14 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Sat, 2 Jan 2021 18:47:14 +0200 From: Konstantin Belousov To: Alexey Dokuchaev Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r365787 - head/sys/fs/tmpfs Message-ID: References: <202009152219.08FMJGMw065722@repo.freebsd.org> <20210101184400.GA77653@FreeBSD.org> <20210102062906.GA98322@FreeBSD.org> <20210102163522.GA3248@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210102163522.GA3248@FreeBSD.org> X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on tom.home X-Rspamd-Queue-Id: 4D7SVL3VSjz4cvp X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=gmail.com (policy=none); spf=softfail (mx1.freebsd.org: 2001:470:d5e7:1::1 is neither permitted nor denied by domain of kostikbel@gmail.com) smtp.mailfrom=kostikbel@gmail.com X-Spamd-Result: default: False [-1.00 / 15.00]; RCVD_TLS_ALL(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; FREEMAIL_FROM(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; HAS_XAW(0.00)[]; RBL_DBL_DONT_QUERY_IPS(0.00)[2001:470:d5e7:1::1:from]; TO_DN_SOME(0.00)[]; R_SPF_SOFTFAIL(0.00)[~all]; SPAMHAUS_ZRD(0.00)[2001:470:d5e7:1::1:from:127.0.2.255]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_SPAM_SHORT(1.00)[1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; MAILMAN_DEST(0.00)[svn-src-all,svn-src-head]; DMARC_POLICY_SOFTFAIL(0.10)[gmail.com : No valid SPF, No valid DKIM,none] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Jan 2021 16:47:23 -0000 On Sat, Jan 02, 2021 at 04:35:22PM +0000, Alexey Dokuchaev wrote: > On Sat, Jan 02, 2021 at 04:52:33PM +0200, Konstantin Belousov wrote: > > ... > > Ok. So two questions: > > 1. Do you have core dump? > > I have vmcore.0 and matching kernel.debug, I'll gladly obtain and provide > anything else you might wanna need. ... > I can upload the kernel core+debug files to freefall so you could have > a closer look yourself. Lets try this. From owner-svn-src-head@freebsd.org Sat Jan 2 18:09:13 2021 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 76F0C4D95B5; Sat, 2 Jan 2021 18:09:13 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4D7VJn2wXhz4jr2; Sat, 2 Jan 2021 18:09:13 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1609610953; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=n4mgmFEQpaALjumm5Hh2goTVUKXmlg0Ou/5MEkA0RTI=; b=mGu0dF72HNM7WAomvsd8UR6MJp3MNFDOkbWwf74dzdF2UpgIKNhmwdrP5ZyhQ5CpRDo8W/ S07F4QRkD8KX6x9IGoTvw3n9E8H5IGgwRoQAApMxjaOQiuKfifbnB1FQo6x2hKnkJHwy2S fCcnkq7JJbuZNOsOrHPL8ez77xNU3eAmYZ+mgPF2skXPTQ00wFpbI7oOARcAamCNbpvMrC acEVBXOTVtqlmDLbrrGe1VmV2HTIWo83dIsj0AeRVeLGk+wRC/q30wF1Vo0n0J3fcHKjZ/ 9wm0EcmHsTjWcsDfInDhN74zjW6Kl25lf0taBh/DoIoAzRRX1shIXmSMJ79evQ== Received: by freefall.freebsd.org (Postfix, from userid 1033) id 5D5171680C; Sat, 2 Jan 2021 18:09:13 +0000 (UTC) Date: Sat, 2 Jan 2021 18:09:13 +0000 From: Alexey Dokuchaev To: Konstantin Belousov Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r365787 - head/sys/fs/tmpfs Message-ID: <20210102180913.GA13620@FreeBSD.org> References: <202009152219.08FMJGMw065722@repo.freebsd.org> <20210101184400.GA77653@FreeBSD.org> <20210102062906.GA98322@FreeBSD.org> <20210102163522.GA3248@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1609610953; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=n4mgmFEQpaALjumm5Hh2goTVUKXmlg0Ou/5MEkA0RTI=; b=Qxp5qDo988QN+KHVFaHUEIhArspH/JRF8n7Ni3SMlrlFpf6B27ILhOymMCwNTp07PhSIxH PEIAGzfMi29wmqM+SQgz25b2Kz0DQC9hXkBScf4YrhplL7UBGQpZzPBXvB6iRcLOfTcin6 EvavmLcj0a/0ckwNCTVogd2XRyK0KIZAwJ2TQd0CkqNM7x1eG5thrJEFjmx9cj8Um7MP6e e0wWMKAILXBsWudQqyXYBglT+nxJz9DHfjJvGZNM7EKhkMQ8Ln7blvOm1RlXXx0V+amHui toQrgH6XPLHmsXCKdfrBgVigUgxlI2BxbXgbZeiTv3O05U1YPT/Nb4uYJCIooA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1609610953; a=rsa-sha256; cv=none; b=wyi84d6Is790BAxNhjRBYO2IMCXDErGa3OzOsATDWYfxJGAymaFVAz7Mt1mIRf9eUsy4Da 50bSYNvRfQMrZAvghk6htqQqsauMUoWq7z/m67TMSyCgPqyUqLbBCBrexhGViZATQUYevt qFF6F4ahDa4giwaNbZhH0KJ1rXbP8rG3HePUZA/1G1hZ5uM5vF3OLVqbczIGPrEdnvQ1k+ X6kZX1hLZH0UVzyeNkWC9i7vc8cdy6Rev98AKSV1QGPwcYpxJv/qFwWAMPYLRnGppqSecV wVGlabUE71BAKmKvXZj2fCX84PlscST7gb3Rtcg9At3bcJRAG2GWBcDFoFUYBQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Jan 2021 18:09:13 -0000 On Sat, Jan 02, 2021 at 06:47:14PM +0200, Konstantin Belousov wrote: > On Sat, Jan 02, 2021 at 04:35:22PM +0000, Alexey Dokuchaev wrote: > > On Sat, Jan 02, 2021 at 04:52:33PM +0200, Konstantin Belousov wrote: > > > ... > > > Ok. So two questions: > > > 1. Do you have core dump? > > > > I have vmcore.0 and matching kernel.debug, I'll gladly obtain and provide > > anything else you might wanna need. > ... > > I can upload the kernel core+debug files to freefall so you could have > > a closer look yourself. > > Lets try this. ff:/home/danfe/x.rar ./danfe