From owner-svn-src-head@freebsd.org Fri Feb 12 20:00:50 2021 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 08C4452F2E7; Fri, 12 Feb 2021 20:00:50 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qt1-x82c.google.com (mail-qt1-x82c.google.com [IPv6:2607:f8b0:4864:20::82c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Dckrd1lyzz3rHt; Fri, 12 Feb 2021 20:00:48 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-qt1-x82c.google.com with SMTP id v3so541945qtw.4; Fri, 12 Feb 2021 12:00:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=W8V9yTXtBu0Tz1YRaZotCMbjPeszkCTKusFAvjF5JWw=; b=RTPrjAO0QM9bWf52v8YI2TF88hnSN+xsq33BlVgzpSOcH1HMCAjuCKyHmX+wTqfecA F61X3qfOz5+SuWG2vJ0I2uvfxGfPmbjCTni5GTysHGiTGOCGMedyhGj/guW+4F4MOrIM WfIzRmmLfn0ZMOLydYv0+eDeDtpi732Ssc2xbyarTqkoRxwqdLEcfB3oDpjZUAlEhfdv 8yWSibFZIyb2+74AYrt2GIUw/c/WceU3A97aI7nWBvUcu9LN1uUW4XjcrbU/mBv7z5Rb CRKT9F4U1Llottm36iJbNI1Osrz22a6m8si9f94ubE/1B2fpgLpkHunKW6dDZlFlElqY m43Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=W8V9yTXtBu0Tz1YRaZotCMbjPeszkCTKusFAvjF5JWw=; b=edewP5SI3tKlYhvXWb9gAFP5u0T20g/yNn7rHh0RS9H5uZ8CcHWCVaSr62tZIDO9ij LmImtjS6e5E9zkTsECf592FeArO0tVGmq5bFgskvHPDmvxUXhSCBgZDtP64EnkkanUCJ 3BoP/41qY9yXHxPUCmShyhsf3XJmIPxdzl53V54dlfVyOPq6AocQR8CApp1POcwSduX8 qCbVhO0F9APZwu5frEd8wKM2pyTcJyHyOpdsJeaEOnGdE6tsPqmzuO3gpBisfrGxz+1O u55BiSxLyUfDdHQpWZx1Bu/QDVD19jE9NxyeokADNj9xwLxiw/YX3J2p/jZVFtRA/xxE 1ctQ== X-Gm-Message-State: AOAM532UribgK/4m53lU2jalgwcDWXM9WyUjJ/gQC6ebZ48hhnTUwsNS aUXFnemTLxrbtwhJ7WTZ5MxVz8l7fiw= X-Google-Smtp-Source: ABdhPJz9byxGd4jSLRvz97IKtOAxeRJWR9152p68hde7TKn3vt3QfrX0iMjbnKseP+x/4MYS0QeuTg== X-Received: by 2002:ac8:7a69:: with SMTP id w9mr4207311qtt.314.1613160044518; Fri, 12 Feb 2021 12:00:44 -0800 (PST) Received: from raichu ([142.126.164.150]) by smtp.gmail.com with ESMTPSA id t3sm6079945qkm.4.2021.02.12.12.00.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Feb 2021 12:00:43 -0800 (PST) Sender: Mark Johnston Date: Fri, 12 Feb 2021 15:00:41 -0500 From: Mark Johnston To: Jung-uk Kim Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r362333 - in head: contrib/flex contrib/flex/src usr.bin/lex usr.bin/lex/lib Message-ID: References: <202006181809.05II9G8p054025@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202006181809.05II9G8p054025@repo.freebsd.org> X-Rspamd-Queue-Id: 4Dckrd1lyzz3rHt X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=RTPrjAO0; dmarc=none; spf=pass (mx1.freebsd.org: domain of markjdb@gmail.com designates 2607:f8b0:4864:20::82c as permitted sender) smtp.mailfrom=markjdb@gmail.com X-Spamd-Result: default: False [-2.70 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FORGED_SENDER(0.30)[markj@freebsd.org,markjdb@gmail.com]; MIME_TRACE(0.00)[0:+]; RBL_DBL_DONT_QUERY_IPS(0.00)[2607:f8b0:4864:20::82c:from]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[markj@freebsd.org,markjdb@gmail.com]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.998]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[freebsd.org]; SPAMHAUS_ZRD(0.00)[2607:f8b0:4864:20::82c:from:127.0.2.255]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::82c:from]; MID_RHS_NOT_FQDN(0.50)[]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[svn-src-all,svn-src-head] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Feb 2021 20:00:50 -0000 On Thu, Jun 18, 2020 at 06:09:16PM +0000, Jung-uk Kim wrote: > Author: jkim > Date: Thu Jun 18 18:09:16 2020 > New Revision: 362333 > URL: https://svnweb.freebsd.org/changeset/base/362333 > > Log: > MFV: r362286 > > Merge flex 2.6.4. This seems to have introduced a regression: input() now returns 0 instead of EOF to indicate that the end of input was reached. This has been reported in a few places: https://github.com/westes/flex/issues/448 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=911415 It breaks the scanner used by libdtrace, and as a result dtrace is unable to resolve some probe argument types: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=253440 I have a small patch to libdtrace which works around this. The upstream commit that introduced the change is fairly old at this point, and upstream seems somewhat unresponsive, so I'm not sure it'll get reverted. Some other scanners in the tree look like they'd be affected, like crypto/heimdal/lib/asn1/lex.l or sys/contrib/dev/acpica/compiler/aslsupport.l, so I'm wondering if we should revert this particular change for 13.0. Certainly we should fix the DTrace bug one way or another for 13.0. From owner-svn-src-head@freebsd.org Sat Feb 13 06:42:24 2021 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id EEDEB542782; Sat, 13 Feb 2021 06:42:24 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Dd14w6JJ5z3M65; Sat, 13 Feb 2021 06:42:24 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Received: from freefall.freebsd.org (pool-100-8-53-238.nwrknj.fios.verizon.net [100.8.53.238]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jkim/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id BBF24A895; Sat, 13 Feb 2021 06:42:24 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Subject: Re: svn commit: r362333 - in head: contrib/flex contrib/flex/src usr.bin/lex usr.bin/lex/lib To: Mark Johnston Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <202006181809.05II9G8p054025@repo.freebsd.org> From: Jung-uk Kim Organization: FreeBSD.org Message-ID: <0a0ac901-c1d2-54d7-d585-2856ae4fe6ea@FreeBSD.org> Date: Sat, 13 Feb 2021 01:42:23 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="rO8sMfinX2yxVlpQHj6O53yYEJYoqiXxU" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Feb 2021 06:42:25 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --rO8sMfinX2yxVlpQHj6O53yYEJYoqiXxU Content-Type: multipart/mixed; boundary="gcR0VLLRQ6Xng2BPSLXSVdA4bAoIlUWwz"; protected-headers="v1" From: Jung-uk Kim To: Mark Johnston Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <0a0ac901-c1d2-54d7-d585-2856ae4fe6ea@FreeBSD.org> Subject: Re: svn commit: r362333 - in head: contrib/flex contrib/flex/src usr.bin/lex usr.bin/lex/lib References: <202006181809.05II9G8p054025@repo.freebsd.org> In-Reply-To: --gcR0VLLRQ6Xng2BPSLXSVdA4bAoIlUWwz Content-Type: multipart/mixed; boundary="------------E339EDF0812F96CD3F2582EB" Content-Language: en-US This is a multi-part message in MIME format. --------------E339EDF0812F96CD3F2582EB Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 21. 2. 12., Mark Johnston wrote: > On Thu, Jun 18, 2020 at 06:09:16PM +0000, Jung-uk Kim wrote: >> Author: jkim >> Date: Thu Jun 18 18:09:16 2020 >> New Revision: 362333 >> URL: https://svnweb.freebsd.org/changeset/base/362333 >> >> Log: >> MFV: r362286 >> =20 >> Merge flex 2.6.4. >=20 > This seems to have introduced a regression: input() now returns 0 > instead of EOF to indicate that the end of input was reached. This has= > been reported in a few places: >=20 > https://github.com/westes/flex/issues/448 > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=3D911415 >=20 > It breaks the scanner used by libdtrace, and as a result dtrace is > unable to resolve some probe argument types: > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D253440 >=20 > I have a small patch to libdtrace which works around this. The upstrea= m > commit that introduced the change is fairly old at this point, and > upstream seems somewhat unresponsive, so I'm not sure it'll get > reverted. Some other scanners in the tree look like they'd be affected= , > like crypto/heimdal/lib/asn1/lex.l or > sys/contrib/dev/acpica/compiler/aslsupport.l, so I'm wondering if we > should revert this particular change for 13.0. Certainly we should fix= > the DTrace bug one way or another for 13.0. I think it does not make much sense and we should revert the upstream change. Does the attached patch work for you? Jung-uk Kim --------------E339EDF0812F96CD3F2582EB Content-Type: text/x-patch; charset=UTF-8; name="flex.diff" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="flex.diff" diff --git a/contrib/flex/src/flex.skl b/contrib/flex/src/flex.skl index 242645f53245..b0f1b2ad297c 100644 --- a/contrib/flex/src/flex.skl +++ b/contrib/flex/src/flex.skl @@ -1863,7 +1863,7 @@ m4_ifdef( [[M4_YY_USE_LINENO]], case EOB_ACT_END_OF_FILE: { if ( yywrap( M4_YY_CALL_ONLY_ARG ) ) - return 0; + return EOF; =20 if ( ! YY_G(yy_did_buffer_switch_on_eof) ) YY_NEW_FILE; --------------E339EDF0812F96CD3F2582EB-- --gcR0VLLRQ6Xng2BPSLXSVdA4bAoIlUWwz-- --rO8sMfinX2yxVlpQHj6O53yYEJYoqiXxU Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEl1bqgKaRyqfWXu/CfJ+WJvzb8UYFAmAndM8FAwAAAAAACgkQfJ+WJvzb8Uab Lgf/Q0Dgl1iZ1RTUkoK4wPXmpkzZg54f1QgWg5wgNkRJGCUK3iY//y7ZWeaE1JvSB7aUVNn/i+t2 Ys3yUS50dD6cnC5/c/wfuJNLX81Nl3NF3V/ErU0OsGzc4/v83hlMo3GjlHP56gL1FY4iou+DKhCh fz+mhg9lYsEQEtb25mfoXkWTXXoXJIqziLnQDk336e99o5W5CDDDyQ97bcO3Qz45bkgOUW7qzox8 Yoaz76xztgwZRdABpkGS4V2u9R0ytPqWyccYyYTV2K5gRYXyG82Kb7sEGwD1bcztRFPx7oMj+3ru qLtK+tj6jekKEoCoF4byodzpJGcSbcZ0ANb0ZSWMqA== =dnZq -----END PGP SIGNATURE----- --rO8sMfinX2yxVlpQHj6O53yYEJYoqiXxU-- From owner-svn-src-head@freebsd.org Sat Feb 13 07:39:56 2021 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id BCFFC543726; Sat, 13 Feb 2021 07:39:56 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Dd2MJ4pf5z3PhT; Sat, 13 Feb 2021 07:39:56 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Received: from freefall.freebsd.org (pool-100-8-53-238.nwrknj.fios.verizon.net [100.8.53.238]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jkim/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 85766B405; Sat, 13 Feb 2021 07:39:56 +0000 (UTC) (envelope-from jkim@FreeBSD.org) From: Jung-uk Kim To: Mark Johnston Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <202006181809.05II9G8p054025@repo.freebsd.org> <0a0ac901-c1d2-54d7-d585-2856ae4fe6ea@FreeBSD.org> Organization: FreeBSD.org Subject: Re: svn commit: r362333 - in head: contrib/flex contrib/flex/src usr.bin/lex usr.bin/lex/lib Message-ID: <68440f27-7b70-cc1f-d646-9669c4093838@FreeBSD.org> Date: Sat, 13 Feb 2021 02:39:56 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <0a0ac901-c1d2-54d7-d585-2856ae4fe6ea@FreeBSD.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="21Mw8Q896MjFg79SqwtcPuvVMLKe3MxM0" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Feb 2021 07:39:56 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --21Mw8Q896MjFg79SqwtcPuvVMLKe3MxM0 Content-Type: multipart/mixed; boundary="0XaxRnIbm9Q0ToP7C1wL5T9SComHIRqut"; protected-headers="v1" From: Jung-uk Kim To: Mark Johnston Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <68440f27-7b70-cc1f-d646-9669c4093838@FreeBSD.org> Subject: Re: svn commit: r362333 - in head: contrib/flex contrib/flex/src usr.bin/lex usr.bin/lex/lib References: <202006181809.05II9G8p054025@repo.freebsd.org> <0a0ac901-c1d2-54d7-d585-2856ae4fe6ea@FreeBSD.org> In-Reply-To: <0a0ac901-c1d2-54d7-d585-2856ae4fe6ea@FreeBSD.org> --0XaxRnIbm9Q0ToP7C1wL5T9SComHIRqut Content-Type: multipart/mixed; boundary="------------A6E82E690D1DA14BA587D34B" Content-Language: en-US This is a multi-part message in MIME format. --------------A6E82E690D1DA14BA587D34B Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 21. 2. 13., Jung-uk Kim wrote: > On 21. 2. 12., Mark Johnston wrote: >> On Thu, Jun 18, 2020 at 06:09:16PM +0000, Jung-uk Kim wrote: >>> Author: jkim >>> Date: Thu Jun 18 18:09:16 2020 >>> New Revision: 362333 >>> URL: https://svnweb.freebsd.org/changeset/base/362333 >>> >>> Log: >>> MFV: r362286 >>> =20 >>> Merge flex 2.6.4. >> >> This seems to have introduced a regression: input() now returns 0 >> instead of EOF to indicate that the end of input was reached. This ha= s >> been reported in a few places: >> >> https://github.com/westes/flex/issues/448 >> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=3D911415 >> >> It breaks the scanner used by libdtrace, and as a result dtrace is >> unable to resolve some probe argument types: >> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D253440 >> >> I have a small patch to libdtrace which works around this. The upstre= am >> commit that introduced the change is fairly old at this point, and >> upstream seems somewhat unresponsive, so I'm not sure it'll get >> reverted. Some other scanners in the tree look like they'd be affecte= d, >> like crypto/heimdal/lib/asn1/lex.l or >> sys/contrib/dev/acpica/compiler/aslsupport.l, so I'm wondering if we >> should revert this particular change for 13.0. Certainly we should fi= x >> the DTrace bug one way or another for 13.0. >=20 > I think it does not make much sense and we should revert the upstream > change. Does the attached patch work for you? Now I believe the author wanted Lex compatibility. Maybe we should do the attached patch instead? Jung-uk Kim --------------A6E82E690D1DA14BA587D34B Content-Type: text/x-patch; charset=UTF-8; name="flex.diff" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="flex.diff" diff --git a/contrib/flex/src/flex.skl b/contrib/flex/src/flex.skl index 242645f53245..c23b944ea473 100644 --- a/contrib/flex/src/flex.skl +++ b/contrib/flex/src/flex.skl @@ -1863,7 +1863,11 @@ m4_ifdef( [[M4_YY_USE_LINENO]], case EOB_ACT_END_OF_FILE: { if ( yywrap( M4_YY_CALL_ONLY_ARG ) ) +#ifdef YY_FLEX_LEX_COMPAT return 0; +#else + return EOF; +#endif =20 if ( ! YY_G(yy_did_buffer_switch_on_eof) ) YY_NEW_FILE; --------------A6E82E690D1DA14BA587D34B-- --0XaxRnIbm9Q0ToP7C1wL5T9SComHIRqut-- --21Mw8Q896MjFg79SqwtcPuvVMLKe3MxM0 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEl1bqgKaRyqfWXu/CfJ+WJvzb8UYFAmAngkwFAwAAAAAACgkQfJ+WJvzb8UYn tgf/XMpmOKNO2YwRToNKgd/lE8I5iQOlFCnP2FE43TRvkjOchjhKeCez4cVPrXoJXywq7oz4JxXR EY5D9YZFy9njlOko1/krH2a829LWsdUZF4jKgU2w2GMvB7C7L3nKGSAl88AUHiCEtRjUUq5t4vwD wlaKvn5tSLBUyB9cjUNrbYgniLr4aVvZ39ZbHJqxRe+TuZvdV7BASHOtry98VeZGpRmXygN6aT3H n8d7wRvuYKXZnMCiOJN3T58/UZJYds41LAVY/DkktiXeN5YmY3m/w0Sa5LkCiKQSYmdiHY0ZH0lv 06MbjcUhQfbhIzWxSFLlyJZyTKBv/fhFHmP4U1Mlkg== =go0i -----END PGP SIGNATURE----- --21Mw8Q896MjFg79SqwtcPuvVMLKe3MxM0-- From owner-svn-src-head@freebsd.org Sat Feb 13 16:10:54 2021 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 39581530DF5; Sat, 13 Feb 2021 16:10:54 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-il1-x134.google.com (mail-il1-x134.google.com [IPv6:2607:f8b0:4864:20::134]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DdFht0xcLz4gpr; Sat, 13 Feb 2021 16:10:54 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-il1-x134.google.com with SMTP id z18so1988182ile.9; Sat, 13 Feb 2021 08:10:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=JqLgxL1EQrNpJTrgu04Qo7hpngFDjihduUHrDWtuQwM=; b=uRs3JNnMeY3RPHewb8EEE4wzmQ3P5G91Ta6oBagDgG7JFy462KKunvQvgwcn3PjWMT 9n7yi5BwtyfnyVHxmresQMi8VKqG86VB1rvNSLSoli9rnYEZiMFbEIjmmPiGmqCSdsiK +bXN/GHB78ngoQG6yD0q+XAORj5krMJVRyBlXwdtB20O8tdJOdmPHmCVj0vuysSDcnnm pVCgQzNMALqiQdzwVM6Ncn7md3KoyzRzfsUBl874+gdG8kAWpaRqKj6QG0hssTshf0m+ ALXeZnTONdmAFIQmxB8Rq+7E2dTZF07zsCu2/XAGYfTIhW6E6LUY+yQiH6lbiOm2pEgZ FxYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=JqLgxL1EQrNpJTrgu04Qo7hpngFDjihduUHrDWtuQwM=; b=rhSBPNp090EapOwVn6Ifj0iazMb7oGUIHgGiLyVzIkED3zvt/8X6CJtsBBPzXT7ZW8 RjeyW1UpGXNEWCsx0yQwYSh6YpjtGcU8iDlCL33kokc9jAr+c2VTTBJi15ogTUDnakj6 9XKTBq2TA/N6uO6ZOEWgw01egVWxm8HhRbh7Uir4hr6GivH8HGaQKwCB1J+R8E8lIjPJ 8xKEFNNsI1E6KLJslcMUGngGF3KefJsmdpqJN2Y750xj60yJKyaVDSQ9eopydlCQ15FH pIZ3pbC9thy8utyw+w+4es4VZpnE72eRr9m2TQXqd9jhzEdbBKcsJf8qbxnN+ioKnm55 oYUQ== X-Gm-Message-State: AOAM530vUmxKu9Zi+BG+itnrCCecfZY0i5j38LLzX4cghbtUgSUaaTrq KVWRGMr0o/mHWD3mPQPPsloVXeIa+Ko= X-Google-Smtp-Source: ABdhPJzhiYXIipfhbpYcMMz9nIhHuwafyVnik/z29382DiQpkfDkVaa3I906g0SGVI4l3MffotEExA== X-Received: by 2002:a92:c60d:: with SMTP id p13mr6760523ilm.118.1613232652626; Sat, 13 Feb 2021 08:10:52 -0800 (PST) Received: from raichu ([142.126.164.150]) by smtp.gmail.com with ESMTPSA id d135sm5920451iog.35.2021.02.13.08.10.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 13 Feb 2021 08:10:51 -0800 (PST) Sender: Mark Johnston Date: Sat, 13 Feb 2021 11:10:49 -0500 From: Mark Johnston To: Jung-uk Kim Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r362333 - in head: contrib/flex contrib/flex/src usr.bin/lex usr.bin/lex/lib Message-ID: References: <202006181809.05II9G8p054025@repo.freebsd.org> <0a0ac901-c1d2-54d7-d585-2856ae4fe6ea@FreeBSD.org> <68440f27-7b70-cc1f-d646-9669c4093838@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <68440f27-7b70-cc1f-d646-9669c4093838@FreeBSD.org> X-Rspamd-Queue-Id: 4DdFht0xcLz4gpr X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Feb 2021 16:10:54 -0000 On Sat, Feb 13, 2021 at 02:39:56AM -0500, Jung-uk Kim wrote: > On 21. 2. 13., Jung-uk Kim wrote: > > On 21. 2. 12., Mark Johnston wrote: > >> On Thu, Jun 18, 2020 at 06:09:16PM +0000, Jung-uk Kim wrote: > >>> Author: jkim > >>> Date: Thu Jun 18 18:09:16 2020 > >>> New Revision: 362333 > >>> URL: https://svnweb.freebsd.org/changeset/base/362333 > >>> > >>> Log: > >>> MFV: r362286 > >>> > >>> Merge flex 2.6.4. > >> > >> This seems to have introduced a regression: input() now returns 0 > >> instead of EOF to indicate that the end of input was reached. This has > >> been reported in a few places: > >> > >> https://github.com/westes/flex/issues/448 > >> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=911415 > >> > >> It breaks the scanner used by libdtrace, and as a result dtrace is > >> unable to resolve some probe argument types: > >> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=253440 > >> > >> I have a small patch to libdtrace which works around this. The upstream > >> commit that introduced the change is fairly old at this point, and > >> upstream seems somewhat unresponsive, so I'm not sure it'll get > >> reverted. Some other scanners in the tree look like they'd be affected, > >> like crypto/heimdal/lib/asn1/lex.l or > >> sys/contrib/dev/acpica/compiler/aslsupport.l, so I'm wondering if we > >> should revert this particular change for 13.0. Certainly we should fix > >> the DTrace bug one way or another for 13.0. > > > > I think it does not make much sense and we should revert the upstream > > change. Does the attached patch work for you? The original patch fixes it, the updated one does not since libdtrace sets -l in LFLAGS. :) Removing it causes a build failure but it is trivial to resolve. I am running some tests now to see if anything regressed. > Now I believe the author wanted Lex compatibility. Maybe we should do > the attached patch instead? Is it common to use the base system's flex for ports and out-of-tree code generally? I have no real idea. I'd be worried about configure scripts that use the flex version to determine whether or not to apply a workaround for this change. I also note that Debian does not seem to have patched this. Looking through consumers in the tree (all *.l files), the following scanners could be affected: - libdtrace - contrib/com_err/lex.l - contrib/ipfilter/iplang/iplang_l.l - does not appear to be built - crypto/heimdal/lib/asn1/lex.l - crypto/heimdal/lib/com_err/lex.l - crypto/heimdal/lib/hx509/sel-lex.l - crypto/heimdal/lib/sl/slc-lex.l - sys/contrib/dev/acpica/compiler/aslsupport.l - sys/contrib/dev/acpica/compiler/prparser.l It would not be too difficult to patch them, and I think in most cases the problem is not very severe and is only triggered by invalid input. For instance, asn1_compile enters an infinite loop if the input file contains an unterminated comment. So for 13.0 I am kind of inclined to just patch consumers. If you think we should revert the change in flex, I'm ok with that too and will remove the use of -l in libdtrace. > diff --git a/contrib/flex/src/flex.skl b/contrib/flex/src/flex.skl > index 242645f53245..c23b944ea473 100644 > --- a/contrib/flex/src/flex.skl > +++ b/contrib/flex/src/flex.skl > @@ -1863,7 +1863,11 @@ m4_ifdef( [[M4_YY_USE_LINENO]], > case EOB_ACT_END_OF_FILE: > { > if ( yywrap( M4_YY_CALL_ONLY_ARG ) ) > +#ifdef YY_FLEX_LEX_COMPAT > return 0; > +#else > + return EOF; > +#endif > > if ( ! YY_G(yy_did_buffer_switch_on_eof) ) > YY_NEW_FILE;