From owner-svn-src-head@freebsd.org Fri Feb 12 20:00:50 2021 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 08C4452F2E7; Fri, 12 Feb 2021 20:00:50 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qt1-x82c.google.com (mail-qt1-x82c.google.com [IPv6:2607:f8b0:4864:20::82c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Dckrd1lyzz3rHt; Fri, 12 Feb 2021 20:00:48 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-qt1-x82c.google.com with SMTP id v3so541945qtw.4; Fri, 12 Feb 2021 12:00:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=W8V9yTXtBu0Tz1YRaZotCMbjPeszkCTKusFAvjF5JWw=; b=RTPrjAO0QM9bWf52v8YI2TF88hnSN+xsq33BlVgzpSOcH1HMCAjuCKyHmX+wTqfecA F61X3qfOz5+SuWG2vJ0I2uvfxGfPmbjCTni5GTysHGiTGOCGMedyhGj/guW+4F4MOrIM WfIzRmmLfn0ZMOLydYv0+eDeDtpi732Ssc2xbyarTqkoRxwqdLEcfB3oDpjZUAlEhfdv 8yWSibFZIyb2+74AYrt2GIUw/c/WceU3A97aI7nWBvUcu9LN1uUW4XjcrbU/mBv7z5Rb CRKT9F4U1Llottm36iJbNI1Osrz22a6m8si9f94ubE/1B2fpgLpkHunKW6dDZlFlElqY m43Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=W8V9yTXtBu0Tz1YRaZotCMbjPeszkCTKusFAvjF5JWw=; b=edewP5SI3tKlYhvXWb9gAFP5u0T20g/yNn7rHh0RS9H5uZ8CcHWCVaSr62tZIDO9ij LmImtjS6e5E9zkTsECf592FeArO0tVGmq5bFgskvHPDmvxUXhSCBgZDtP64EnkkanUCJ 3BoP/41qY9yXHxPUCmShyhsf3XJmIPxdzl53V54dlfVyOPq6AocQR8CApp1POcwSduX8 qCbVhO0F9APZwu5frEd8wKM2pyTcJyHyOpdsJeaEOnGdE6tsPqmzuO3gpBisfrGxz+1O u55BiSxLyUfDdHQpWZx1Bu/QDVD19jE9NxyeokADNj9xwLxiw/YX3J2p/jZVFtRA/xxE 1ctQ== X-Gm-Message-State: AOAM532UribgK/4m53lU2jalgwcDWXM9WyUjJ/gQC6ebZ48hhnTUwsNS aUXFnemTLxrbtwhJ7WTZ5MxVz8l7fiw= X-Google-Smtp-Source: ABdhPJz9byxGd4jSLRvz97IKtOAxeRJWR9152p68hde7TKn3vt3QfrX0iMjbnKseP+x/4MYS0QeuTg== X-Received: by 2002:ac8:7a69:: with SMTP id w9mr4207311qtt.314.1613160044518; Fri, 12 Feb 2021 12:00:44 -0800 (PST) Received: from raichu ([142.126.164.150]) by smtp.gmail.com with ESMTPSA id t3sm6079945qkm.4.2021.02.12.12.00.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Feb 2021 12:00:43 -0800 (PST) Sender: Mark Johnston Date: Fri, 12 Feb 2021 15:00:41 -0500 From: Mark Johnston To: Jung-uk Kim Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r362333 - in head: contrib/flex contrib/flex/src usr.bin/lex usr.bin/lex/lib Message-ID: References: <202006181809.05II9G8p054025@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202006181809.05II9G8p054025@repo.freebsd.org> X-Rspamd-Queue-Id: 4Dckrd1lyzz3rHt X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=RTPrjAO0; dmarc=none; spf=pass (mx1.freebsd.org: domain of markjdb@gmail.com designates 2607:f8b0:4864:20::82c as permitted sender) smtp.mailfrom=markjdb@gmail.com X-Spamd-Result: default: False [-2.70 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FORGED_SENDER(0.30)[markj@freebsd.org,markjdb@gmail.com]; MIME_TRACE(0.00)[0:+]; RBL_DBL_DONT_QUERY_IPS(0.00)[2607:f8b0:4864:20::82c:from]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[markj@freebsd.org,markjdb@gmail.com]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.998]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[freebsd.org]; SPAMHAUS_ZRD(0.00)[2607:f8b0:4864:20::82c:from:127.0.2.255]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::82c:from]; MID_RHS_NOT_FQDN(0.50)[]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[svn-src-all,svn-src-head] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Feb 2021 20:00:50 -0000 On Thu, Jun 18, 2020 at 06:09:16PM +0000, Jung-uk Kim wrote: > Author: jkim > Date: Thu Jun 18 18:09:16 2020 > New Revision: 362333 > URL: https://svnweb.freebsd.org/changeset/base/362333 > > Log: > MFV: r362286 > > Merge flex 2.6.4. This seems to have introduced a regression: input() now returns 0 instead of EOF to indicate that the end of input was reached. This has been reported in a few places: https://github.com/westes/flex/issues/448 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=911415 It breaks the scanner used by libdtrace, and as a result dtrace is unable to resolve some probe argument types: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=253440 I have a small patch to libdtrace which works around this. The upstream commit that introduced the change is fairly old at this point, and upstream seems somewhat unresponsive, so I'm not sure it'll get reverted. Some other scanners in the tree look like they'd be affected, like crypto/heimdal/lib/asn1/lex.l or sys/contrib/dev/acpica/compiler/aslsupport.l, so I'm wondering if we should revert this particular change for 13.0. Certainly we should fix the DTrace bug one way or another for 13.0.