From nobody Sat Apr 1 23:34:37 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PptmJ4ZKhz43Y6M; Sat, 1 Apr 2023 23:34:40 +0000 (UTC) (envelope-from agh@riseup.net) Received: from mx1.riseup.net (mx1.riseup.net [198.252.153.129]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx1.riseup.net", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PptmH4BFhz4d1S; Sat, 1 Apr 2023 23:34:39 +0000 (UTC) (envelope-from agh@riseup.net) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=riseup.net header.s=squak header.b=JhtcMn29; spf=pass (mx1.freebsd.org: domain of agh@riseup.net designates 198.252.153.129 as permitted sender) smtp.mailfrom=agh@riseup.net; dmarc=pass (policy=none) header.from=riseup.net Received: from fews2.riseup.net (fews2-pn.riseup.net [10.0.1.84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mail.riseup.net", Issuer "R3" (not verified)) by mx1.riseup.net (Postfix) with ESMTPS id 4PptmF5X7RzDqQT; Sat, 1 Apr 2023 23:34:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1680392077; bh=ZAv3pvchxmwD8gyph+SJqra2wcRJi73B9HruEoAlbK4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=JhtcMn29WYQQbJ9avvUOMPT960bDFtMQB3a5k+wEfYqSy3gCnKB7brKPrHt6zNI3k moZu4NaDYiE35WpIHVOVMnpmt1KkQyuGK4klMr++7VtDpuEb0mgRzo3C569JBdCvjT nKq/BuJNmdzPDwi4yc4yQ1MRj9lZxzKFclgxgHCs= X-Riseup-User-ID: 40E4E77800B1673E05C0220DC6FA2AFF98944E417F69EA5D348AAD35CDC54212 Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews2.riseup.net (Postfix) with ESMTPSA id 4PptmF3935z1y8c; Sat, 1 Apr 2023 23:34:37 +0000 (UTC) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Date: Sat, 01 Apr 2023 23:34:37 +0000 From: Alastair Hogge To: Emmanuel Vadot Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: f1d7ae31d4aa - main - linuxkpi: Add hdmi helpers In-Reply-To: <202303280725.32S7P5eF036507@gitrepo.freebsd.org> References: <202303280725.32S7P5eF036507@gitrepo.freebsd.org> Message-ID: <818d6db4dfaf420427d38f0491ec29b7@riseup.net> Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.20 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.996]; DMARC_POLICY_ALLOW(-0.50)[riseup.net,none]; R_SPF_ALLOW(-0.20)[+mx]; R_DKIM_ALLOW(-0.20)[riseup.net:s=squak]; RCVD_IN_DNSWL_LOW(-0.10)[198.252.153.129:from]; MIME_GOOD(-0.10)[text/plain]; RWL_MAILSPIKE_GOOD(-0.10)[198.252.153.129:from]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; ASN(0.00)[asn:16652, ipnet:198.252.153.0/24, country:US]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org,dev-commits-src-main@freebsd.org]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; DWL_DNSWL_NONE(0.00)[riseup.net:dkim]; MID_RHS_MATCH_FROM(0.00)[]; DKIM_TRACE(0.00)[riseup.net:+]; RCVD_COUNT_THREE(0.00)[3]; RCVD_VIA_SMTP_AUTH(0.00)[] X-Rspamd-Queue-Id: 4PptmH4BFhz4d1S X-Spamd-Bar: ---- X-ThisMailContainsUnwantedMimeParts: N On 2023-03-28 07:25, Emmanuel Vadot wrote: Hello manu, > The branch main has been updated by manu: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=f1d7ae31d4aa7b352611c43a9fb3b04986cff622 > > commit f1d7ae31d4aa7b352611c43a9fb3b04986cff622 > Author: Emmanuel Vadot > AuthorDate: 2023-03-16 15:12:12 +0000 > Commit: Emmanuel Vadot > CommitDate: 2023-03-28 07:11:06 +0000 > > linuxkpi: Add hdmi helpers > > This is a direct port of the Linux code as the licence allows it, so > style(9) isn't respected to allow applying directly the upstream commits. > Do not add it to linuxkpi directly but add a new linuxkpi_hdmi module > that drm modules will require later, no need to bloat linuxkpi more. > > Sponsored by: Beckhoff Automation GmbH & Co. KG > Differential Revision: https://reviews.freebsd.org/D39122 > --- > sys/compat/linuxkpi/common/include/linux/hdmi.h | 440 ++++++ > sys/compat/linuxkpi/common/src/linux_hdmi.c | 1922 +++++++++++++++++++++++ > sys/modules/Makefile | 1 + > sys/modules/linuxkpi_hdmi/Makefile | 13 + > 4 files changed, 2376 insertions(+) [leading diff removed] diff --git a/sys/compat/linuxkpi/common/src/linux_hdmi.c b/sys/compat/linuxkpi/common/src/linux_hdmi.c new file mode 100644 index 000000000000..5a9b5c552e49 --- /dev/null +++ b/sys/compat/linuxkpi/common/src/linux_hdmi.c @@ -0,0 +1,1922 @@ [most of module removed] +} +EXPORT_SYMBOL(hdmi_infoframe_unpack); + + +MODULE_VERSION(linuxkpi_hdmi, 1); +MODULE_DEPEND(linuxkpi_hdmi, linuxkpi, 1, 1, 1); +MODULE_DEPEND(linuxkpi_hdmi, wlan, 1, 1, 1); Is this module meant to depend on wlan? I was unable to boot a working X after updating past this commit; upon booting the kernel, it did not load linuxkpi_hdmi because wlan was missing. I did not want to rebuild world and kernel WITH_WIRELESS and with the wlan device, so I removed the MODULE_DEPEND declaration on wlan. Not sure what is going on, and if linuxkpi will depend on the networking stack in future? Thanks for the amazing work on continuing FreeBSD work on the desktop for the 14 or so of us users ;-) Alastair