From nobody Sun Sep 24 00:28:22 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RtRgq1n5mz4vTYG for ; Sun, 24 Sep 2023 00:28:39 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic317-21.consmr.mail.gq1.yahoo.com (sonic317-21.consmr.mail.gq1.yahoo.com [98.137.66.147]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4RtRgp2pf7z4L2Z for ; Sun, 24 Sep 2023 00:28:38 +0000 (UTC) (envelope-from marklmi@yahoo.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=yahoo.com header.s=s2048 header.b=CIrDBiXt; spf=pass (mx1.freebsd.org: domain of marklmi@yahoo.com designates 98.137.66.147 as permitted sender) smtp.mailfrom=marklmi@yahoo.com; dmarc=pass (policy=reject) header.from=yahoo.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1695515316; bh=JkHpUvd1TLBFL3QVPUjokWLk0nQZWHrMoqj7I5pBcGQ=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From:Subject:Reply-To; b=CIrDBiXt+Bssgt/Nn/jpcpTR1KiCQ+NONss7bNYR9NrQaCV9bCUa3UILYC+uzcw/aIcjrn24l0VHI8u1t0ReXL7YuNHhqwFHMQh8e6lUZ6x9dItAtv6eEJjZjbOxx2bPhtdB4W1vjFNaYcNky6p2uZldtuo4xabkmRObdS5nZcdRt24Vhy3O6K5ZYr7iMgpZ7992yshg+pKqC4GMjqyFdO3DHqtg2H2SXW9TtsmAtU7kyMptoyB8PxIJAI88jmgABAtaqvAcSezzfeellNU/GoNG35WovdbyBDl7nNu8bpWQC2MU/+BHn0n+0A5fVbI6tTprq0CnLJJ22O3s0b1+xQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1695515316; bh=4vlVsVcLAABXAfugmZ29gF1zFYjqTMLi5oS6HM3/Pb0=; h=X-Sonic-MF:Subject:From:Date:To:From:Subject; b=lZZf5eFD6MkYn+VNJ84GIsidde8k0lOcizEod1OejfbwpCIYWEkooovWNgbrUj3X7cV82HP5Ta3VhsijdfNpYqMqT5u0F8LxVDwlW79BE0/T+CM5Wotd6xihKGM7/FCqsxjosrShHH/Ji9dO8sNRypgGjLQaH1bMtrdqdo4S2fcbHdko0eJisij0BUjZuDJRVIU9gO9xUOsUJmXmgFJT6cAen0JUW83yNE6/JpGfPnRNJtSkdWbyfoe1h8qDahbEFTr2gMAqSL7NJCj0pYytOi7MnqglViPka93v7JgX6xG4ew9530Hdd5aoTzssLNx3/55PtQnPuSwu3h8gdugVtA== X-YMail-OSG: 9DOxSUMVM1kBMe4Ktxd_Kz9zYjdR2w.nI6VWNEwJHwVpuX0TDkZjMt.WLTDXRYQ MS8CEetgj0zLfXLMmHrhZ40iG_sH_Mz31TNuxRhQhlPRJ99dIl5Ov1teqUBxe1GcXmH1ix2EtlUa O7UsuSY6RcgC1xvj4ksG8gH0F_fTq2c9SvgoiwjnuNxti2AguaOJ1K8ACKJaPp.aNtaptRuK4DUM smdrECDzEyfD74WWWuFMt2rZNCz0tD3JEAa3VtqE63TUQiIM6w0NMMGJQEr.rHZpUN0Rn8QoBJn0 kOC9GSg16BiMwKtoeKGpF4jpUXAUVAXgNzQKo17lnqX4hqLSsJ_RRa7hWKnO4SnnVz12sPuoKeIc 1HLPwaClgCpl.HzYxgUT_yuWq0d3uxRNOMRGrszJEFdBmq_sFiO7406gHryuLohR6XQmhlQkmq.q soaw9_zTfWxow88aBi0p28mLhWMYFGzssoSNbHCCoELKimIEOwf8Z8HgyNSbsEkZW5q6VTG6p3vO mBD6yM4a98.6trvIes0WTEfGJl5gudXeWCUTuFExRvrPDtZS530sB6pe_ZLCMV4h539q8EVJKIGq NgPxSogLUeCdlnv_oUMD5bQsCZytTk1_rVYPBc9SVrFhRivS42o56sx1gv0wIW.hKV.ON7mBs8s_ EtBpY8r7RnNi7.fjBmQxI2RVr6wVVDLhE3IG0o6ztPMY9ypuesy7Xaw57XwHyfiNBWmpuaIMNdNL i5rT3_v26.PsEc4sRDI4xjCFtcE2l6vj6eeuBONCnET0rAcB2UU4EN9HOQgZJfC6qseby3MHtSMR UabPu8eBxWadItemuqDn4rzE6UfsmJYgBZjtuDuTYBkDbAnINDrOO9dFGQip624bHnuMmyxmLVSH Fuaw1LAgRNoTATwL78XweGmkwaUI8USRoPjjIB__kEu2TDD2v9M8Mbd_rZ2rgeiDfZrM2iXHygC7 BXUALPFt3A.1kWi1HhwQNidX3ETBbLiMt902YCpQ5JumNDZvAOOJTt8nUDIRu59bppinlaq1tgur C44iOF5AgFXlKj8pwxwfClNN1Fmg32ALguqz0TJ0DSrNmuhHzZzrOlwOpqNnI_46gR9MLiHBj_3h pwp76JsWnKbtZhUP4Iya5rqBU9rhImKlABTncLb6b8MXSHKclGz70zXkz3c6KEyDGQ8TGIqUeVT4 bXlMG7CObIppFl4htr0Rnxjtp9cw1eqQkU4qHJsiIDzEK.TWKEJmLqhxu7PXUqR6hPx_JUncnLhS WQ20A0WDVGge7EOvrb6YDL2Mc3dSMexACfWL8E3mKUc15etgpzDj0umW6ovXSCQJcHKpVixJyEOD fn9lLMCakFh_gvEGBulOHJMWjPw9CRu2AIQojjNrW3oTK666.bCWODMu9kqnQpdlscZoUn9WKbpo EoTNcqjzcipsiB_aSov431W56uUb.UftrBsYl6Dlzc4QK.yac1Ss7IJz8uczofmwiWfR_cFwuT9_ 2n6kGYJO2RJS7lBQQ6JxxrwHN85JoPAe02gvJR9DX5CxmsHAMD64kLT62MSNLgMiYQSwhnn9Zudn X4mzJ9c5b12bQC0piUHqIyJGoPBjNt_sIoATPlNcCz6grwTjSWvfY7kcVTWIJbP6LMTmoHStje4E z6QeezE5OS1sBFA04zbTyUSh4rUxBHTa8gvj5BVlPPtHNH4zd7_XM_UlP9Vsh0I_1UtgqTZScqVq tuNAIk3KNrlddano_sNAXnu6pcbMf9uJeJT3IHML4LRWAL4xZd_7LcE0hTYvJ0RL5f5wwiZBHu37 oQSgdXlMA_79o1r30YmPS.ziIApwbzX3pRBnki0sHnsQwTQBO5Q1WrCZ49cgJbqib6MikCPN0bUo 3B9MfjQ7b4r80t1yZ8V75UiumY9YRYbkuizgkNuRgxu0GFLdYpQJZ7MHrKXB860wNQ5C9w6DhrzS _uQjL.N9M5BtcDyo2uFOhk4hYd2JXkyL07zFzaLxyHmzeYmcW7lxX3S4NsKBbT.22MV.u8awsDeu _VjlDjaNujqGvsV1NpbFws7cG_zWX4pDCtI7y_QYP2T9GTgRrdAW4B.wrbU369oCAgKndUIamzTh uiykfXvxutEiDv6BgFoRkF58si.3cEME36qOiaOLt7BWOiZHeCYD6Yp7oYcq0jY0uq13y36mkXoz ilsBJxJcbKrqzP9Di8XKabWscsocPvDLbEU7Gecen_IRlRt3LwbpEn3BwXbS5.58o9rZ6sDKwQAF Ptj5uvZ94s2.CcKMt_LOjYQ5IGt1zD7l5xcF4VTn3UyYLKT6_OMEyT90jkNOcu.SZuCrQm5rpeCn JV96jOog- X-Sonic-MF: X-Sonic-ID: 5ed3b9b5-07e4-454e-810d-7a7787c3a75e Received: from sonic.gate.mail.ne1.yahoo.com by sonic317.consmr.mail.gq1.yahoo.com with HTTP; Sun, 24 Sep 2023 00:28:36 +0000 Received: by hermes--production-gq1-77657878bb-9nwx5 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 277da1c44dc511c791316911bcff872c; Sun, 24 Sep 2023 00:28:33 +0000 (UTC) Content-Type: text/plain; charset=us-ascii List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) Subject: Re: git: f9df60975087 - main - Add support for host32 for DIRDEPS_BUILD From: Mark Millard In-Reply-To: <8033.1695509469@kaos.jnpr.net> Date: Sat, 23 Sep 2023 17:28:22 -0700 Cc: Mike Karels , stevek@juniper.net, dev-commits-src-main@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <79F167D9-DF7A-4714-92EE-3B9FBB7BF912.ref@yahoo.com> <79F167D9-DF7A-4714-92EE-3B9FBB7BF912@yahoo.com> <2401.1695508551@kaos.jnpr.net> <8033.1695509469@kaos.jnpr.net> To: "Simon J. Gerraty" X-Mailer: Apple Mail (2.3731.700.6) X-Spamd-Bar: --- X-Spamd-Result: default: False [-3.50 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; MV_CASE(0.50)[]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; MIME_GOOD(-0.10)[text/plain]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[98.137.66.147:from]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org]; ARC_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RWL_MAILSPIKE_POSSIBLE(0.00)[98.137.66.147:from]; DKIM_TRACE(0.00)[yahoo.com:+]; FREEMAIL_FROM(0.00)[yahoo.com]; TO_DN_SOME(0.00)[]; DWL_DNSWL_NONE(0.00)[yahoo.com:dkim]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/20, country:US]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; RCVD_COUNT_TWO(0.00)[2] X-Rspamd-Queue-Id: 4RtRgp2pf7z4L2Z On Sep 23, 2023, at 15:51, Simon J. Gerraty wrote: > Simon J. Gerraty wrote: >>> Looks like this broke lib32 builds via it ending up using >>> the default: >>>=20 >>> -target armv7-unknown-freebsd >>>=20 >>> instead of the correct: >>>=20 >>> -target armv7-unknown-freebsd15.0-gnueabihf >>=20 >> Sorry. >>=20 >> That would be easier to fix/control if a separate variable >> is used to hold just the -target flag=20 >>=20 >> That way bsd.compat.mk could reset that varaible if needed with no = harm >> done. >>=20 >=20 > Does the following look like it would DTRT for you? > Not sure about COMPILER_TYPE vs COMPAT_COMPILER_TYPE I reported strictly based on noticing the official FreeBSD Jenkins activity having build failures. My environment is currently based on a commit that is a day or two before your change, so I'd need to progress in order to be able to test anything that fixed the operation. I expect that Mike Karels would be a better one to comment on any alternate structuring for having the build environment always be explicit for its aarch64 -m32 use, at least based on preexisting familiarity with where and how things are used. Last I tried, gcc12 based builds did not work/finish for aarch64, even though amd64 was working at the time. It seemed that the status was not a surprise to folks. Correctly covering gcc12 use for this issue may well still end up with a broken/incomplete aarch64+LIB32 build via gcc12 --for other reasons. (E-mail has a tendency to not preserve leading whitespace.) > diff --git a/share/mk/bsd.compat.mk b/share/mk/bsd.compat.mk > index = 0c387bcb020c67ea6eda8fc1f4956eebf098e2a2..1e82df42391c4cec341ad368cb477fe4= a14c84b8 100644 > --- a/share/mk/bsd.compat.mk > +++ b/share/mk/bsd.compat.mk > @@ -26,16 +26,18 @@ COMPAT_COMPILER_TYPE=3D${COMPILER_TYPE} >=20 > # ------------------------------------------------------------------- > # 32 bit world > +LIB32CPUFLAGS=3D ${LIB32CPUFLAGS.${COMPAT_COMPILER_TYPE}:U} > +LIB32CPUFLAGS.clang=3D -target ${CROSS_TARGET.clang} > .if ${COMPAT_ARCH} =3D=3D "amd64" > HAS_COMPAT+=3D 32 > .if empty(LIB32CPUTYPE) > -LIB32CPUFLAGS=3D -march=3Di686 -mmmx -msse -msse2 > +LIB32CPUFLAGS+=3D -march=3Di686 -mmmx -msse -msse2 > .else > -LIB32CPUFLAGS=3D -march=3D${LIB32CPUTYPE} > +LIB32CPUFLAGS+=3D -march=3D${LIB32CPUTYPE} > .endif > .if ${COMPAT_COMPILER_TYPE} =3D=3D gcc > .else > -LIB32CPUFLAGS+=3D -target x86_64-unknown-freebsd${OS_REVISION} > +CROSS_TARGET.clang=3D x86_64-unknown-freebsd${OS_REVISION} > .endif > LIB32CPUFLAGS+=3D -m32 > LIB32_MACHINE=3D i386 > @@ -47,15 +49,15 @@ LIB32WMAKEFLAGS=3D \ > .elif ${COMPAT_ARCH} =3D=3D "powerpc64" > HAS_COMPAT+=3D 32 > .if empty(LIB32CPUTYPE) > -LIB32CPUFLAGS=3D -mcpu=3Dpowerpc > +LIB32CPUFLAGS+=3D -mcpu=3Dpowerpc > .else > -LIB32CPUFLAGS=3D -mcpu=3D${LIB32CPUTYPE} > +LIB32CPUFLAGS+=3D -mcpu=3D${LIB32CPUTYPE} > .endif >=20 > .if ${COMPAT_COMPILER_TYPE} =3D=3D "gcc" > LIB32CPUFLAGS+=3D -m32 > .else > -LIB32CPUFLAGS+=3D -target powerpc-unknown-freebsd${OS_REVISION} > +CROSS_TARGET.clang=3D powerpc-unknown-freebsd${OS_REVISION} > .endif >=20 > LIB32_MACHINE=3D powerpc > @@ -66,15 +68,15 @@ LIB32WMAKEFLAGS=3D \ > .elif ${COMPAT_ARCH} =3D=3D "aarch64" > HAS_COMPAT+=3D 32 > .if empty(LIB32CPUTYPE) > -LIB32CPUFLAGS=3D -march=3Darmv7 > +LIB32CPUFLAGS+=3D -march=3Darmv7 > .else > -LIB32CPUFLAGS=3D -mcpu=3D${LIB32CPUTYPE} > +LIB32CPUFLAGS+=3D -mcpu=3D${LIB32CPUTYPE} > .endif >=20 > LIB32CPUFLAGS+=3D -m32 > .if ${COMPAT_COMPILER_TYPE} =3D=3D "gcc" > .else > -LIB32CPUFLAGS+=3D -target = armv7-unknown-freebsd${OS_REVISION}-gnueabihf > +CROSS_TARGET.clang=3D armv7-unknown-freebsd${OS_REVISION}-gnueabihf > .endif >=20 > LIB32_MACHINE=3D arm > diff --git a/share/mk/local.sys.mk b/share/mk/local.sys.mk > index = eb21380f051c4ec8434301ed16c881d07a83dddf..dae540261f7961937db9101da32acc8d= fca20e8f 100644 > --- a/share/mk/local.sys.mk > +++ b/share/mk/local.sys.mk > @@ -97,7 +97,9 @@ META_DEPS+=3D ${META_NOPHONY} >=20 > .if ${MACHINE:Nhost*:Ncommon} !=3D "" && ${MACHINE} !=3D = ${HOST_MACHINE} > # cross-building > -CROSS_TARGET_FLAGS?=3D -target = ${MACHINE_ARCH}-unknown-freebsd${FREEBSD_REVISION} > +CROSS_TARGET.clang?=3D = ${MACHINE_ARCH}-unknown-freebsd${FREEBSD_REVISION} > +CROSS_TARGET_FLAGS.clang?=3D -target ${CROSS_TARGET.clang} > +CROSS_TARGET_FLAGS?=3D ${CROSS_TARGET_FLAGS.${COMPILER_TYPE}} > CFLAGS+=3D ${CROSS_TARGET_FLAGS} > ACFLAGS+=3D ${CROSS_TARGET_FLAGS} > .endif I see that you have since disabled the new share/mk/local.sys.mk code unless ${MK_DIRDEPS_BUILD} =3D=3D "yes" --thus giving time for considering alternatives. =3D=3D=3D Mark Millard marklmi at yahoo.com