From nobody Wed Dec 21 15:05:00 2022 X-Original-To: freebsd-arch@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NccDs3hdGz1H8jf for ; Wed, 21 Dec 2022 15:05:01 +0000 (UTC) (envelope-from jhibbits@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NccDs37vLz4PVQ; Wed, 21 Dec 2022 15:05:01 +0000 (UTC) (envelope-from jhibbits@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1671635101; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fpuhQWEsAfo8rpWCgtkOSf6uSUNepg9ouiUTaEa4G+A=; b=uAewa59QRtGWPGrGYp0MupKxloZfMtbrTy/aNiTLyK7p/7bprUM9CsTt4CSEUWEB0eak1q 1ceRc2Gu2hGsSze5bDzKUcmX14dDX9npJfihlMYlA17qA3W9o6NKeRJjasAnDfYeP4sArd xCbMcDCa+qfqsEsqETrT7p36IfmetFMMQ+ZlwXLlb7z7Z3cUh3NMX3Q8eCovo9UkpEwbCp 8H5Cj2bsP0meFyEYGAXUWLGozED3+yz9OtnLETETJAmoobNL/f5rM844VaA3+ohB5Gaf0h /IS8QC43hwpyMX5iaT++F6q0OyTzg64ZWOwOHdX0CpqAw8HJH+gCwwWkVZiMhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1671635101; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fpuhQWEsAfo8rpWCgtkOSf6uSUNepg9ouiUTaEa4G+A=; b=vZceM9+7veZL4zboPvUFS9/EHmL9M2iETW5PAz3AY52IqDHW/CY8E6L2j/lW995HQzm0Yw WMvUTdil2+T0N5kSqBNc3H/pjGFeMG7qCnKjpTueOv2BAT11oCo3pO9rnTsrDJGqQASFIB kdJYZSq/m65xffUrsnIAZcVwj5kX3uQQN7H+CXeLX6XrYdINVF6pI/NXwcSDRAxi5GvEhg BvL4WXX13SRrahck+mTx8PK/G84g+F1lP3T+c8/HsMafG08/iCx6AnuJoVASbQsoeUykJ7 zRykBWTqQBoW3qzR5zvj1t8kTz6FEPr+UnGM6pVUxUVddyjXVWa0Uue6+MKg9A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1671635101; a=rsa-sha256; cv=none; b=qRPZcyhItTVySknm2xcYEUyQkIJLpEEKYNt8XH3LktpM2cnCXustrO65q0cJmRiOGP+4Qr jG4lllj7e15UxiX+mPW45ex7saUJLagyk65IyyxRyjqkI4l+69uym+2AOeUnBxngditd5Y 2VqL1VwLuBhrW7n8JRSL+3iqz5LWRQLB+gFRQOe0KX4hNJezoTj3oik83DXMf6gilaoLwq x/5/1bRbcrFpr25fcVU8Qmb1H5CduPIcn1s7MaHU0A/2zxXMygkKBWrO96L1IU5mXkF/vL 6UJnmZYNv5twTfdJaT8zj3PGttIGsfgIYt5pyBhQzp9+pdhUQwqQrQ3L+dBtCg== Received: from ralga-linux (dsl-74-83-251-217.fuse.net [74.83.251.217]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhibbits) by smtp.freebsd.org (Postfix) with ESMTPSA id 4NccDs152LzZSb; Wed, 21 Dec 2022 15:05:01 +0000 (UTC) (envelope-from jhibbits@FreeBSD.org) Date: Wed, 21 Dec 2022 10:05:00 -0500 From: Justin Hibbits To: Ed Maste Cc: freebsd-arch@freebsd.org Subject: Re: Modularizing the network stack with a driver API Message-ID: <20221221100500.53da379a@ralga-linux> In-Reply-To: References: <20221123143359.2370ed89@ralga-linux> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; powerpc64le-unknown-linux-gnu) List-Id: Discussion related to FreeBSD architecture List-Archive: https://lists.freebsd.org/archives/freebsd-arch List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-arch@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-ThisMailContainsUnwantedMimeParts: N On Wed, 21 Dec 2022 09:58:05 -0500 Ed Maste wrote: > On Wed, 23 Nov 2022 at 14:34, Justin Hibbits > wrote: > > > > Most of the work I've done in the recent port has been purely > > mechanical and scripted, fixing build failures along the way. The > > current work in progress can be found in my personal repository at > > https://github.com/chmeeedalf/freebsd/tree/drvapi . The goal of > > this first step is to get things started, address design feedback, > > and move forward in main. > > Thanks for picking up this long-neglected effort. > > One comment, let's make sure that documentation gets updated as we go > - right now ifnet(9) documents struct ifnet's internals and makes no > reference to any of the accessor functions. The man page likely needs > significant work at some point as it's already quite long, but we > should at least mention that direct access to ifnet internals is > undesired, and list the accessors. I'll be doing that once I finish the first round of driver updates, so expect updates to that in early to mid January. It'll be a significant update, so will need time and probably lots of review. - Justin From nobody Tue Jan 17 09:41:48 2023 X-Original-To: freebsd-arch@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Nx3p03P3qz2snpX for ; Tue, 17 Jan 2023 09:42:16 +0000 (UTC) (envelope-from 6yearold@gmail.com) Received: from mail-vk1-f179.google.com (mail-vk1-f179.google.com [209.85.221.179]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Nx3nz579Pz3kXb for ; Tue, 17 Jan 2023 09:42:15 +0000 (UTC) (envelope-from 6yearold@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=none; spf=pass (mx1.freebsd.org: domain of 6yearold@gmail.com designates 209.85.221.179 as permitted sender) smtp.mailfrom=6yearold@gmail.com; dmarc=none Received: by mail-vk1-f179.google.com with SMTP id l129so13655144vkh.6 for ; Tue, 17 Jan 2023 01:42:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=8TC+HnAeeINSSYGA3P3fYsBjBFkXTjq4znOxt7VqPqM=; b=RkZ+xOecIKKv6TjCScrzyz91QHawKFMUZ0w3SAVcz5PilYcLdUzrUg3my6oxwaEGyd B2Doee0kJH8jiKIXKy5hjyjCSBUllQzbXuvjbS73m7pmRIdaOSraIK5rTZDb7+uyxXd4 nhQYQJjvIBlHt3u/faG8v3IVOcbxrCQkgKqarKNNGWIlce1q1va+0Noe/WkTfoO2WNcA YzDQqJxcgVGSWE3eV2Ot4K7Zfqt45ZemoKk1cPciFXTlYg08YgSKpn6OSrPiFjlGkfcJ Sdpd6gmMP3e0edPLdSNmFgZv7grPbRFDA+3VxElAfAYtqfESlH3bPH4r6u2Wm1O6HRgS BYOw== X-Gm-Message-State: AFqh2koH9pKaPTH0/jY2fNTqpKoMujRC/9ThvsvWPkybont6ib/ExZvz bDfxxUSwgyD7PlRe4/HIcheXMxUBEr9WBg== X-Google-Smtp-Source: AMrXdXvn0UKZJA6N8ixhUjiaH+oHCYjlwa6AjGaMfdShUlvow1XIj1Gf3Z1/fmDVxV+EAQNgi7vA7w== X-Received: by 2002:a05:6122:1285:b0:3da:1c67:7011 with SMTP id i5-20020a056122128500b003da1c677011mr943619vkp.3.1673948534772; Tue, 17 Jan 2023 01:42:14 -0800 (PST) Received: from mail-vs1-f42.google.com (mail-vs1-f42.google.com. [209.85.217.42]) by smtp.gmail.com with ESMTPSA id bj11-20020a0561220e4b00b003dde41b70f9sm1554290vkb.39.2023.01.17.01.42.14 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Jan 2023 01:42:14 -0800 (PST) Received: by mail-vs1-f42.google.com with SMTP id 187so904278vsv.10 for ; Tue, 17 Jan 2023 01:42:14 -0800 (PST) X-Received: by 2002:a67:fb14:0:b0:3d3:c741:fe1d with SMTP id d20-20020a67fb14000000b003d3c741fe1dmr301971vsr.85.1673948534229; Tue, 17 Jan 2023 01:42:14 -0800 (PST) List-Id: Discussion related to FreeBSD architecture List-Archive: https://lists.freebsd.org/archives/freebsd-arch List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-arch@freebsd.org MIME-Version: 1.0 From: Gleb Popov Date: Tue, 17 Jan 2023 12:41:48 +0300 X-Gmail-Original-Message-ID: Message-ID: Subject: libcamcontrol ? To: freebsd-arch@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Spamd-Result: default: False [-0.80 / 15.00]; SUBJECT_ENDS_QUESTION(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FORGED_SENDER(0.30)[arrowd@freebsd.org,6yearold@gmail.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; NEURAL_SPAM_SHORT(0.20)[0.198]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; DMARC_NA(0.00)[freebsd.org]; RCPT_COUNT_ONE(0.00)[1]; PREVIOUSLY_DELIVERED(0.00)[freebsd-arch@freebsd.org]; RCVD_IN_DNSWL_NONE(0.00)[209.85.221.179:from,209.85.217.42:received]; RCVD_TLS_LAST(0.00)[]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; TO_DOM_EQ_FROM_DOM(0.00)[]; R_DKIM_NA(0.00)[]; RCVD_COUNT_THREE(0.00)[4]; TO_DN_NONE(0.00)[]; MLMMJ_DEST(0.00)[freebsd-arch@freebsd.org]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FREEMAIL_ENVFROM(0.00)[gmail.com]; FROM_NEQ_ENVFROM(0.00)[arrowd@freebsd.org,6yearold@gmail.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.221.179:from] X-Rspamd-Queue-Id: 4Nx3nz579Pz3kXb X-Spamd-Bar: / X-ThisMailContainsUnwantedMimeParts: N I wonder if it makes sense to move some code from sbin/camcontrol/camcontrol.c to a shared library. Specifically, all the entry points of the main executable like "devlist", "identify", etc. and all the code supporting them. I'm asking because I require camcontrol functionality in sysutils/bsdisks and calling the executable doesn't satisfy my needs. At the same time, the amount of code I pulled out from camcontrol.c keeps growing [1] and I feel uncomfortable about it. Another approach might be implementing libxo in the camcontrol utility and enriching it to return all the information I need. I'm volunteering to do the work, but I need a plan.