From nobody Mon Feb 27 15:20:11 2023 X-Original-To: freebsd-git@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PQPM75Vbxz3vFBR for ; Mon, 27 Feb 2023 15:20:19 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from glebi.us (glebi.us [162.251.186.162]) by mx1.freebsd.org (Postfix) with ESMTP id 4PQPM53VzCz3NJk for ; Mon, 27 Feb 2023 15:20:17 +0000 (UTC) (envelope-from glebius@freebsd.org) Authentication-Results: mx1.freebsd.org; dkim=none; spf=softfail (mx1.freebsd.org: 162.251.186.162 is neither permitted nor denied by domain of glebius@freebsd.org) smtp.mailfrom=glebius@freebsd.org; dmarc=none Received: by glebi.us (Postfix, from userid 1000) id 87D132D0BF; Mon, 27 Feb 2023 07:20:11 -0800 (PST) Date: Mon, 27 Feb 2023 07:20:11 -0800 From: Gleb Smirnoff To: Warner Losh Cc: freebsd-git Subject: Re: Report on the pull request experiment so far Message-ID: References: List-Id: Discussion of git use in the FreeBSD project List-Archive: https://lists.freebsd.org/archives/freebsd-git List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-git@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spamd-Result: default: False [0.50 / 15.00]; VIOLATED_DIRECT_SPF(3.50)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.999]; MIME_GOOD(-0.10)[text/plain]; RCVD_NO_TLS_LAST(0.10)[]; MLMMJ_DEST(0.00)[freebsd-git@freebsd.org]; ARC_NA(0.00)[]; R_DKIM_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_TWO(0.00)[2]; TO_DN_ALL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; FREEFALL_USER(0.00)[glebius]; ASN(0.00)[asn:27348, ipnet:162.251.186.0/24, country:US]; FROM_HAS_DN(0.00)[]; R_SPF_SOFTFAIL(0.00)[~all]; DMARC_NA(0.00)[freebsd.org]; RCVD_COUNT_TWO(0.00)[2] X-Rspamd-Queue-Id: 4PQPM53VzCz3NJk X-Spamd-Bar: / X-ThisMailContainsUnwantedMimeParts: N On Sat, Feb 25, 2023 at 04:54:26PM -0700, Warner Losh wrote: W> I also landed one commit that was from 2021. Yikes. The commit date is W> right, but the author date is in the past. I suggest that we add a git W> commit --amend --date="`date`" to the process. This likely is a good thing. W> There's no simple --reset-date, alas: only a reset that also resets the W> author. Isn't --ignore-date what we need? -- Gleb Smirnoff From nobody Mon Feb 27 15:30:44 2023 X-Original-To: freebsd-git@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PQPbH2dNvz3vFpL for ; Mon, 27 Feb 2023 15:30:51 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PQPbH0LMKz3NgK for ; Mon, 27 Feb 2023 15:30:51 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ed1-x534.google.com with SMTP id o12so27365586edb.9 for ; Mon, 27 Feb 2023 07:30:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=SzME8bYlucpKmdbnHP4uZ8eFWAgoPpn4l8JjCHr+/7g=; b=pnOX4gtP38TLpizUuLCAM4+te6LOP+EdSEwL7eAm9tRiIL8nBV7v2G2EEyydD1+pJ9 n8IEyAdDLpcGKEIqxabkbn0xdIAQDVQwl158scB2mDFrMsgsSQA/OGFKQ2ae/GZ9lnac e/7vQQbxOqVuZ39e3xqhvLOEnKAOvA4YXwkPvYaI/7yzydVF3L7VxEbF1V/1ok4DT8TB Bf75o87Vn90+bvTAGZ4Weipf0wRcBO2Ioi7S4mhnCKEUKqWCQbPD7pdhFYVZAMzOrq3y Iy++Bo++PWYgSdXhVpDmF4uNaSRoVMBxoMmxYvXe9maA9/Rd+VuigSBVwMkJJXWZvR2p a7Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SzME8bYlucpKmdbnHP4uZ8eFWAgoPpn4l8JjCHr+/7g=; b=FVKIReyINwV3x343CKK+uO6CB3l+igj0nvasZQx9566rGu3Yivujg+XCLfUAdtiXWP oggYW5P5p42oeTiYoKKq1PpV/Z6DSy0FOYxe+w1Ru4x54Tv+vUZotlrfcEFqHyiCnA4U DSK/IY6mZ3DPRhj/PhN/hGgP5lW9rXoPLnFLrbYHdQ7PmlyYDmwBAf6wfs5pDnn1NBIj Z9vH0YshkKWdVGovV7cbtPGi7jvO0JueRnrhXoNY5xiLipQBBbXeN+3kYVVuSBna71mV 3vCRYmlSXvt0dE/qC6aZ4FzQ0F4qnJc5Lor3R8mLyNCi5ZaEvE5YpijQih57ZuOq11Gy IAfg== X-Gm-Message-State: AO0yUKW3OOFXyBeh6igTYm/toZt8jNCW7seFegIlo1A278K0pI+29bZA nB2nDf3Uz2EdV96sFSAOP7OOIwKF9gnIsh0KhFAdOgy+XES3yQ== X-Google-Smtp-Source: AK7set9xaiW1LOQxg5jdc9xtrzMJoA4OBSwtkTr4P1zwViMkGhisFYXBtOMNdWshr205iZWH1vhyE2nMljDCSQTrEkQ= X-Received: by 2002:a50:f619:0:b0:4ac:b74b:a6a3 with SMTP id c25-20020a50f619000000b004acb74ba6a3mr11813734edn.0.1677511849723; Mon, 27 Feb 2023 07:30:49 -0800 (PST) List-Id: Discussion of git use in the FreeBSD project List-Archive: https://lists.freebsd.org/archives/freebsd-git List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-git@freebsd.org MIME-Version: 1.0 References: In-Reply-To: From: Warner Losh Date: Mon, 27 Feb 2023 08:30:44 -0700 Message-ID: Subject: Re: Report on the pull request experiment so far To: Gleb Smirnoff Cc: freebsd-git Content-Type: multipart/alternative; boundary="000000000000e8dc8305f5b02997" X-Rspamd-Queue-Id: 4PQPbH0LMKz3NgK X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N --000000000000e8dc8305f5b02997 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Feb 27, 2023 at 8:20=E2=80=AFAM Gleb Smirnoff = wrote: > On Sat, Feb 25, 2023 at 04:54:26PM -0700, Warner Losh wrote: > W> I also landed one commit that was from 2021. Yikes. The commit date is > W> right, but the author date is in the past. I suggest that we add a git > W> commit --amend --date=3D"`date`" to the process. This likely is a good > thing. > W> There's no simple --reset-date, alas: only a reset that also resets th= e > W> author. > > Isn't --ignore-date what we need? > I don't see that in the manual page, and it doesn't work... Git 2.39.1 Warner --000000000000e8dc8305f5b02997 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Mon, Feb 27, 2023 at 8:20=E2=80=AF= AM Gleb Smirnoff <glebius@freebsd= .org> wrote:
On Sat, Feb 25, 2023 at 04:54:26PM -0700, Warner Losh wrote:
W> I also landed one commit that was from 2021. Yikes. The commit date i= s
W> right, but the author date is in the past. I suggest that we add a gi= t
W> commit --amend --date=3D"`date`" to the process. This likel= y is a good thing.
W> There's no simple --reset-date, alas: only a reset that also rese= ts the
W> author.

Isn't --ignore-date what we need?

I= don't see that in the manual page, and it doesn't work... Git 2.39= .1

Warner
--000000000000e8dc8305f5b02997-- From nobody Mon Feb 27 15:39:41 2023 X-Original-To: freebsd-git@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PQPng3FLrz3vGD3 for ; Mon, 27 Feb 2023 15:39:51 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PQPnf5D3Dz3P2V for ; Mon, 27 Feb 2023 15:39:50 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20210112.gappssmtp.com header.s=20210112 header.b=oiVUCtUT; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2a00:1450:4864:20::52a) smtp.mailfrom=wlosh@bsdimp.com; dmarc=none Received: by mail-ed1-x52a.google.com with SMTP id h16so27478259edz.10 for ; Mon, 27 Feb 2023 07:39:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Vb2JdMDRKC9hg0hXzzNPAQhwhRsR10ltBCDCuC4RzPs=; b=oiVUCtUTNkciK+ZGzixHLe+LE5mdYLXqKi9ijTL/+FZbEAlvz95Rd8DnuBCHEB9vM/ UP6NQ0NEvf3M4mSV+9Z2O67EsVr6w3fZpF14wmVr+BpJeN5VC2aEpQjz0QP1UJ+3pKsx C9Jf0GiCEWgztP2STXD55V6a/+yHXjy2m5LyfScu/Zz+rHavzillBZfhobH9iw45Y50s q5B+aip8kDpEPHSM1TSWM6ZH1vKLytvI32W/SzR4Y90PSPqQ8Lvt8XHn5xK3CNdGS3Q9 jy7TcxBV5+lqmCo2cv0ohSpHqd8ZqCszdR0eQqOVJI8e6BYlXb2npj2z8/zdK7xNvH6k bEnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Vb2JdMDRKC9hg0hXzzNPAQhwhRsR10ltBCDCuC4RzPs=; b=VsIcNY8f4ImpHu+u+L0OPnhjCvzm3kTdBiwDP55CoX21rLYbP2EzHVlFiQW4i4WIpE NheKkiSfeCeiprLF/yD68MV4g72QUchKdFnYzvjQgoLO6t1HHDwIZETfezWzZg26rZse eUKyFqvsMyoYrIluELGJqAifjSCSYt76IC7JDkJzItFUj23AzAc9Bzle6gP7jb30N+YD 1SI6npq9Lnk7A5qib0FsUwfQ4GPZO8ZxXtNyMmqdjLOUcCgzosl1qfweVKX8VCZlPv/C Yf7sIaAO5my/vL1dfB9ulXOYFdBx7zP5tOvlR8ATlyLtbIpP0NMFF4uiwqvRl3gk21PZ m7JQ== X-Gm-Message-State: AO0yUKXdbXrnvJi7mXIT/VdtflgzxTpWKbYqRAuw3u8AJwCozbIiudx6 u9K9CM2y9Cft9uJzRRBd2IqGuXZJbeSTNVebQnTD8dqaye6ZwA== X-Google-Smtp-Source: AK7set8JKjRA/LmkOX/HHPoSluo2ezvJDPqkcPc1gl+RnzWwdsvuP5oyPvXyuXQQD1oV9kNPi1EyRa1tuQiSnoqwMek= X-Received: by 2002:a50:bae3:0:b0:4a8:2436:4ed2 with SMTP id x90-20020a50bae3000000b004a824364ed2mr11917927ede.0.1677512387599; Mon, 27 Feb 2023 07:39:47 -0800 (PST) List-Id: Discussion of git use in the FreeBSD project List-Archive: https://lists.freebsd.org/archives/freebsd-git List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-git@freebsd.org MIME-Version: 1.0 References: In-Reply-To: From: Warner Losh Date: Mon, 27 Feb 2023 08:39:41 -0700 Message-ID: Subject: Re: Report on the pull request experiment so far To: Gleb Smirnoff Cc: freebsd-git Content-Type: multipart/alternative; boundary="000000000000f8340b05f5b0493b" X-Spamd-Result: default: False [-3.00 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.999]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20210112.gappssmtp.com:s=20210112]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; ARC_NA(0.00)[]; MLMMJ_DEST(0.00)[freebsd-git@freebsd.org]; R_SPF_NA(0.00)[no SPF record]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::52a:from]; DKIM_TRACE(0.00)[bsdimp-com.20210112.gappssmtp.com:+]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; PREVIOUSLY_DELIVERED(0.00)[freebsd-git@freebsd.org]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; DMARC_NA(0.00)[bsdimp.com]; TO_DN_ALL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-Rspamd-Queue-Id: 4PQPnf5D3Dz3P2V X-Spamd-Bar: -- X-ThisMailContainsUnwantedMimeParts: N --000000000000f8340b05f5b0493b Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Feb 27, 2023 at 8:30=E2=80=AFAM Warner Losh wrote: > > > On Mon, Feb 27, 2023 at 8:20=E2=80=AFAM Gleb Smirnoff wrote: > >> On Sat, Feb 25, 2023 at 04:54:26PM -0700, Warner Losh wrote: >> W> I also landed one commit that was from 2021. Yikes. The commit date i= s >> W> right, but the author date is in the past. I suggest that we add a gi= t >> W> commit --amend --date=3D"`date`" to the process. This likely is a goo= d >> thing. >> W> There's no simple --reset-date, alas: only a reset that also resets t= he >> W> author. >> >> Isn't --ignore-date what we need? >> > > I don't see that in the manual page, and it doesn't work... Git 2.39.1 > Ah, the git rebase has --ignore-date. That makes more sense now. And is easier. Warner --000000000000f8340b05f5b0493b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Mon, Feb 27, 2023 at 8:30=E2=80=AF= AM Warner Losh <imp@bsdimp.com>= wrote:


On Mon, Feb 27, 2023 at 8:20=E2=80=AFAM Gleb = Smirnoff <glebi= us@freebsd.org> wrote:
On Sat, Feb 25, 2023 at 04:54:26PM -0700, Warner Losh wrote:<= br> W> I also landed one commit that was from 2021. Yikes. The commit date i= s
W> right, but the author date is in the past. I suggest that we add a gi= t
W> commit --amend --date=3D"`date`" to the process. This likel= y is a good thing.
W> There's no simple --reset-date, alas: only a reset that also rese= ts the
W> author.

Isn't --ignore-date what we need?

I= don't see that in the manual page, and it doesn't work... Git 2.39= .1

Ah, the git rebase= has --ignore-date. That makes more sense now. And is easier.

Warner
--000000000000f8340b05f5b0493b-- From nobody Mon Feb 27 15:40:55 2023 X-Original-To: freebsd-git@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PQPq93swTz3vGDB for ; Mon, 27 Feb 2023 15:41:09 +0000 (UTC) (envelope-from christer.edwards@gmail.com) Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PQPq86SMTz3PQm for ; Mon, 27 Feb 2023 15:41:08 +0000 (UTC) (envelope-from christer.edwards@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20210112 header.b=qlzyv98+; spf=pass (mx1.freebsd.org: domain of christer.edwards@gmail.com designates 2607:f8b0:4864:20::431 as permitted sender) smtp.mailfrom=christer.edwards@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pf1-x431.google.com with SMTP id z11so3784598pfh.4 for ; Mon, 27 Feb 2023 07:41:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=ZYBa8Q8KXXwrbgwIq+3BvN/wiceF19fsZipYxYP4XkQ=; b=qlzyv98+Pznzk2tmmmiIXZCuEJ1+CabTSDYITZm4iq7rYhqouYeJ6xBbChLmXG6W4F exHo6ew1wrLuLEl29vB5TYoOnBvUw1PIRrgfq1JJHRFWIxKAM7WwTECTObZIJpZfpEs0 J4eKj3haFXFRq4gE6mT2tQ63JQuAOsSzO3fl8kj+SJCQe5MoQcy0xJv1LpNlxSwFej50 v3rm//cqrLFUR2e9j8cBPoFBv1LainBQKf5LHpgcDCPsCiKltGZCZsyAQB+tzp6WoBTr UJAoWq/KplCRg+lidFVCfnV0gJKD3cwnTlFNrN1ihGYLLdQstvSO70UWa61OfU0LbJHX S7rA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ZYBa8Q8KXXwrbgwIq+3BvN/wiceF19fsZipYxYP4XkQ=; b=5nHI6wGOfMPB6/ZajWbtljyI91QTtRoQcCd4zLHJwB2GLkVGjbmUb6XX975KmJ+bks XVL3fkVHpBe5QGdaDf+LKB1y3uJWnXHlWJjVsJjqUUuwKdglU2AewI0y3anVXp13cR+g Z0jMdDa2MCRtCn35F+y+xpyRfliJdqI1pCqhw4rU8DJUmiky8FB6rH7VcyhJDk/FdZnf S764KXdhwv79/7STJT59pc8Ct8Qi/2H1r97dJc0KVtLq//4ss7DUQPX2saETnR4P9pe4 G30uyiv2N+9D7t1/bLcKGmQzM1VP2lxW/lQL8camo/M6a8WAWG7AYLjzzU5jg9LA91Mc FRPg== X-Gm-Message-State: AO0yUKXJWq3A6yJ/F615IEYT0vPRkkeRy+QLDjvNwjUUl5DNgjyAflrM Nw5rMPnGjbgRuQgFWahsA8lLbgvTTnGbb3Ocn5MyUJxX X-Google-Smtp-Source: AK7set9vLULa/5jI3Tm04k1IpIIgMPuc2JuSXfE41SSeEcSFRZqC6t9M9lq2VhJ9RG0rJyDhPvkrBc8HlwEYSDj/szI= X-Received: by 2002:a63:7a4c:0:b0:503:2612:5554 with SMTP id j12-20020a637a4c000000b0050326125554mr2546101pgn.10.1677512467105; Mon, 27 Feb 2023 07:41:07 -0800 (PST) List-Id: Discussion of git use in the FreeBSD project List-Archive: https://lists.freebsd.org/archives/freebsd-git List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-git@freebsd.org MIME-Version: 1.0 From: Christer Edwards Date: Mon, 27 Feb 2023 08:40:55 -0700 Message-ID: Subject: unsubscribe To: freebsd-git@freebsd.org Content-Type: multipart/alternative; boundary="000000000000b54d8505f5b04e15" X-Spamd-Result: default: False [-3.93 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.93)[-0.932]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20210112]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FREEMAIL_FROM(0.00)[gmail.com]; RCPT_COUNT_ONE(0.00)[1]; PREVIOUSLY_DELIVERED(0.00)[freebsd-git@freebsd.org]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::431:from]; ARC_NA(0.00)[]; TAGGED_FROM(0.00)[]; MLMMJ_DEST(0.00)[freebsd-git@freebsd.org]; DKIM_TRACE(0.00)[gmail.com:+]; MID_RHS_MATCH_FROMTLD(0.00)[]; TO_DN_NONE(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FREEMAIL_ENVFROM(0.00)[gmail.com]; RCVD_COUNT_TWO(0.00)[2] X-Rspamd-Queue-Id: 4PQPq86SMTz3PQm X-Spamd-Bar: --- X-ThisMailContainsUnwantedMimeParts: N --000000000000b54d8505f5b04e15 Content-Type: text/plain; charset="UTF-8" --000000000000b54d8505f5b04e15 Content-Type: text/html; charset="UTF-8"
--000000000000b54d8505f5b04e15-- From nobody Tue Feb 28 22:12:37 2023 X-Original-To: freebsd-git@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PRBSf3m8Bz3v1bW for ; Tue, 28 Feb 2023 22:12:50 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PRBSd3Qw5z47cS for ; Tue, 28 Feb 2023 22:12:49 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=none; spf=pass (mx1.freebsd.org: domain of carpeddiem@gmail.com designates 209.85.167.44 as permitted sender) smtp.mailfrom=carpeddiem@gmail.com; dmarc=none Received: by mail-lf1-f44.google.com with SMTP id i28so2442249lfv.0 for ; Tue, 28 Feb 2023 14:12:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677622367; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kt32FNtfspUOfCpAnY7slNbA3j6HjvmP4s342qqgsqY=; b=W1ohn0r3O4W/R/Yh1Q/YjnWcBSIZfggi9WcP98cFm+XYcr/98ojYjxwPf1Fj82RIJC LDpzqxRvRD5KdOQ0425So+MY6t0wM3iJ/FwuPDF0sSivUKLscC47tME7nwjbJffvmIQK aiRVvZ2KH7Ep8kU+DkP+oxBQSe8Zs9G5stksEjC6O3VrfYamM/1gdDk4WeqobkORwigm PGL0XZvByzFLg+D85WJ/KGyPkNRNmY7kvFLegcHs9AtqHTktFGKhfyzzHZ5215kpmYW8 VJom6BOJ90kzZgqAS7+TEyzdEMfJ8Hl4Hg/Hmrwpqt5d3I0tZnHf6wTZ2Xs21ISQPGUG nrJQ== X-Gm-Message-State: AO0yUKV7B5PfbUeAzjlw6SxSmlNGInE9iLV1+Iazy2yUO2BBdaPIOcyp jpFerEqc8VuyK8Syn7HblpxM5hUdS1FROAhitBwB60Wq X-Google-Smtp-Source: AK7set9ws8M2iz6DanmfhvE0ZpRfzB0iOiv2a7JXfzRKxzU/dIo25JGgcqfsVyccDrH4L8FN9ttlDsXmxOCx+nqW72U= X-Received: by 2002:ac2:539a:0:b0:4d5:ca32:7bbb with SMTP id g26-20020ac2539a000000b004d5ca327bbbmr1165576lfh.2.1677622367341; Tue, 28 Feb 2023 14:12:47 -0800 (PST) List-Id: Discussion of git use in the FreeBSD project List-Archive: https://lists.freebsd.org/archives/freebsd-git List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-git@freebsd.org MIME-Version: 1.0 References: In-Reply-To: From: Ed Maste Date: Tue, 28 Feb 2023 17:12:37 -0500 Message-ID: Subject: Re: Report on the pull request experiment so far To: Warner Losh Cc: freebsd-git Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spamd-Result: default: False [-2.94 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.94)[-0.940]; FORGED_SENDER(0.30)[emaste@freebsd.org,carpeddiem@gmail.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; MIME_GOOD(-0.10)[text/plain]; FREEMAIL_ENVFROM(0.00)[gmail.com]; MLMMJ_DEST(0.00)[freebsd-git@freebsd.org]; R_DKIM_NA(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; MIME_TRACE(0.00)[0:+]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.167.44:from]; RCVD_IN_DNSWL_NONE(0.00)[209.85.167.44:from]; RCVD_TLS_LAST(0.00)[]; FROM_NEQ_ENVFROM(0.00)[emaste@freebsd.org,carpeddiem@gmail.com]; FROM_HAS_DN(0.00)[]; FREEFALL_USER(0.00)[carpeddiem]; ARC_NA(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; PREVIOUSLY_DELIVERED(0.00)[freebsd-git@freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DMARC_NA(0.00)[freebsd.org]; TO_DN_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-Rspamd-Queue-Id: 4PRBSd3Qw5z47cS X-Spamd-Bar: -- X-ThisMailContainsUnwantedMimeParts: N On Sat, 25 Feb 2023 at 18:54, Warner Losh wrote: > > I also landed one commit that was from 2021. Yikes. The commit date is ri= ght, but the author date is in the past. I suggest that we add a git commit= --amend --date=3D"`date`" to the process. This likely is a good thing. The= re's no simple --reset-date, alas: only a reset that also resets the author= . IMO we should just accept git's notion of separate author and commit dates, and not worry about author dates being in the past. From nobody Tue Feb 28 23:04:48 2023 X-Original-To: freebsd-git@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PRCck68thz3v48p for ; Tue, 28 Feb 2023 23:04:54 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: from spindle.one-eyed-alien.net (spindle.one-eyed-alien.net [199.48.129.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4PRCck4GGvz4FFy; Tue, 28 Feb 2023 23:04:54 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Authentication-Results: mx1.freebsd.org; none Received: by spindle.one-eyed-alien.net (Postfix, from userid 3001) id AD9DC3C0199; Tue, 28 Feb 2023 23:04:48 +0000 (UTC) Date: Tue, 28 Feb 2023 23:04:48 +0000 From: Brooks Davis To: Ed Maste Cc: Warner Losh , freebsd-git Subject: Re: Report on the pull request experiment so far Message-ID: References: List-Id: Discussion of git use in the FreeBSD project List-Archive: https://lists.freebsd.org/archives/freebsd-git List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-git@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: X-Rspamd-Queue-Id: 4PRCck4GGvz4FFy X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:36236, ipnet:199.48.128.0/22, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On Tue, Feb 28, 2023 at 05:12:37PM -0500, Ed Maste wrote: > On Sat, 25 Feb 2023 at 18:54, Warner Losh wrote: > > > > I also landed one commit that was from 2021. Yikes. The commit date is = right, but the author date is in the past. I suggest that we add a git comm= it --amend --date=3D"`date`" to the process. This likely is a good thing. T= here's no simple --reset-date, alas: only a reset that also resets the auth= or. >=20 > IMO we should just accept git's notion of separate author and commit > dates, and not worry about author dates being in the past. I remain on the fence, but think we should either accept git's notion or enforce that the date is newer than prior commits and not in the future. IMO we should enforce this on commit dates regardless[0]. There is no conceivable value in allowing people to commit from systems with wildly wrong clocks given they must be on the internet to commit. -- Brooks [0] Obviously this only applies to first-parent commits not the commits being merged in a merge commit. From nobody Wed Mar 1 01:48:37 2023 X-Original-To: freebsd-git@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PRHFs6X0Fz3vD3x for ; Wed, 1 Mar 2023 01:48:49 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PRHFs4mRzz3DDS for ; Wed, 1 Mar 2023 01:48:49 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ed1-x52f.google.com with SMTP id ee7so47987117edb.2 for ; Tue, 28 Feb 2023 17:48:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20210112.gappssmtp.com; s=20210112; t=1677635328; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=qvE4R8X2h8fvK9K+l7FrYNSQjX8rRfeoxQoMwLFUhUg=; b=AfHJAxNF73IDaiuP3QGfNBzCGoZW/Tik1TBw5Sq53Nfxe534gGwWfetJYfij/i134m H292lAewFWD6nR4jgXm2nBOH5Hc/mBU2rvmEILxXY9wHS69yJwukCZVDFc9/kHHA3OKN tz7aEChXaYVv8QIC/oOTLx15t0kS84ZF5YI1/a8jXoWc3R0tcIT5BRmvtBf1ZOzeVjr9 TaEpxby32/UepRZmgHz30XYbqcufTsfX8NjsSxmMdm8e2pBCmlAiOTNGazJRlWIu75iv rfyNXdow4EbtOEi+2ZGHo7jdQwJjSGGcZ7PmI3RUd0aEsvkaxxLk0BeztmIMiZCqmkNz BMUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677635328; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qvE4R8X2h8fvK9K+l7FrYNSQjX8rRfeoxQoMwLFUhUg=; b=5Y1b/ljiE9JGX1jp2p+kuQsh5ub9aPPkJB4OgX3JI4aI88FXTGF5OhGW4jvscMLs9l icpVkc+5+BZSI0fYn/zAEthN/rTweOXhEq2wdUq/syF1IJunTr45gDNz0jXrQdQqJX4M Abb2M4lIG62wYLcqOq2SPfl1ER2rXfxRxNrLg3cl3+MV24pkovevh5LrT9/lOziXq4Jq X7IMaukdDd+98g8EJcCgvJdcZGIXT6B864H9n8fBWgYteDfuC2NpCz02Ya+sEvs7zIcf OmvnLCtDG5TgQV0p8npBkU1UsWEmy/9TkO37xNFCkJ/mF07RpFtauskUm3cNiWyAvYtK jIPw== X-Gm-Message-State: AO0yUKVlmrtbpfw6UmannXHA93P6HfjAXvKdThRZklqdxMJx5Uwl+Fj9 M0Wjxu3k8wecKWc0z5Bsu5e8YQkTUORQROcDxAkjAyDIrewkvQ== X-Google-Smtp-Source: AK7set//rikDOcSfSSaAPdxFxmN6b/twx9qxjbnhgIofnDsPK6VQ8x7vk88dgepdhClcrJqP6xm/+smcbJYSlk2lOIg= X-Received: by 2002:a17:906:5597:b0:8b1:7aec:c8e6 with SMTP id y23-20020a170906559700b008b17aecc8e6mr2290023ejp.2.1677635328235; Tue, 28 Feb 2023 17:48:48 -0800 (PST) List-Id: Discussion of git use in the FreeBSD project List-Archive: https://lists.freebsd.org/archives/freebsd-git List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-git@freebsd.org MIME-Version: 1.0 References: In-Reply-To: From: Warner Losh Date: Tue, 28 Feb 2023 18:48:37 -0700 Message-ID: Subject: Re: Report on the pull request experiment so far To: Brooks Davis Cc: Ed Maste , freebsd-git Content-Type: multipart/alternative; boundary="000000000000cd6b2f05f5cce992" X-Rspamd-Queue-Id: 4PRHFs4mRzz3DDS X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N --000000000000cd6b2f05f5cce992 Content-Type: text/plain; charset="UTF-8" On Tue, Feb 28, 2023, 4:04 PM Brooks Davis wrote: > On Tue, Feb 28, 2023 at 05:12:37PM -0500, Ed Maste wrote: > > On Sat, 25 Feb 2023 at 18:54, Warner Losh wrote: > > > > > > I also landed one commit that was from 2021. Yikes. The commit date is > right, but the author date is in the past. I suggest that we add a git > commit --amend --date="`date`" to the process. This likely is a good thing. > There's no simple --reset-date, alas: only a reset that also resets the > author. > > > > IMO we should just accept git's notion of separate author and commit > > dates, and not worry about author dates being in the past. > > I remain on the fence, but think we should either accept git's notion or > enforce that the date is newer than prior commits and not in the future. > IMO we should enforce this on commit dates regardless[0]. There is no > conceivable value in allowing people to commit from systems with wildly > wrong clocks given they must be on the internet to commit. > I too am on the fence. It isn't a huge deal... I've also found git am --ignore-date copes well. It's a lot faster to fetch the .patch file and feed it to git am than to fetch the deltas and rebase... but the latter is more robust... A bigger issue in my mind is the project's use of trailer metadata that doesn't match what git expects. The whole spaces vs - thing is making tooling harder than it needs to be... Warner -- Brooks > > [0] Obviously this only applies to first-parent commits not the commits > being merged in a merge commit. > --000000000000cd6b2f05f5cce992 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Tue, Feb 28, 2023, 4:04 PM Brooks Davis <brooks@freebsd.org> wrote:
<= blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px= #ccc solid;padding-left:1ex">On Tue, Feb 28, 2023 at 05:12:37PM -0500, Ed = Maste wrote:
> On Sat, 25 Feb 2023 at 18:54, Warner Losh <imp@bsdimp.com> wrote= :
> >
> > I also landed one commit that was from 2021. Yikes. The commit da= te is right, but the author date is in the past. I suggest that we add a gi= t commit --amend --date=3D"`date`" to the process. This likely is= a good thing. There's no simple --reset-date, alas: only a reset that = also resets the author.
>
> IMO we should just accept git's notion of separate author and comm= it
> dates, and not worry about author dates being in the past.

I remain on the fence, but think we should either accept git's notion o= r
enforce that the date is newer than prior commits and not in the future. IMO we should enforce this on commit dates regardless[0].=C2=A0 There is no=
conceivable value in allowing people to commit from systems with wildly
wrong clocks given they must be on the internet to commit.
=

I too am on the f= ence. It isn't a huge deal...=C2=A0

I've also found git am --ignore-date copes well. It'= ;s a lot faster to fetch the .patch file and feed it to git am than to fetc= h the deltas and rebase... but the latter is more robust...

A bigger issue in my mind is the proj= ect's use of trailer metadata that doesn't match what git expects. = The whole spaces vs - thing is making tooling harder than it needs to be...=

Warner=C2=A0

-- Brooks

[0] Obviously this only applies to first-parent commits not the commits
being merged in a merge commit.
--000000000000cd6b2f05f5cce992-- From nobody Wed Mar 1 15:01:30 2023 X-Original-To: freebsd-git@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PRcrl4kFkz3txXZ for ; Wed, 1 Mar 2023 15:01:43 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PRcrl0D4pz3Mtt; Wed, 1 Mar 2023 15:01:43 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-lf1-f43.google.com with SMTP id s20so17964805lfb.11; Wed, 01 Mar 2023 07:01:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677682900; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jhY1oVTMxkEGaGHmTVpiAOuNP6I0aREZm3zC08O9vwE=; b=ol/4EkfMw4AuTphnpfuZoWz5xJ4SAOXvdtroZALhPqMR70LbZaCQUtXzGtQl+HRpoG JlTnzBHiKzUnUtejUGjnVuocn3PNy6MS19+SSubVF+e9wikCSy2zQscYWRBGECyqz11p 8d3xnTcFXFO+vc03PuoPqEpd4n8u8vbHDkSG76XXHjgz26FA6VFyhBO2TyP2Pi2kYbaR qZ1rt4XtUCRSvWQ9BgGFtA5l1sAOxHKXKOfJjwdeK39bBCI1odoaR4iIPiCCX9OY1MND yJdocwv3XDmq9v+hk3RU6nZk3RzW+xB22rdIE6sL/iyN6GpZZu2KQ8jd45tXsaqEGl6M ll5Q== X-Gm-Message-State: AO0yUKXWog88nV8GQvjRbQx1xeUI+tv5coXIYXv9M7dYEhs0wnDSU2cz UK5MqV+RnYwzAbPgwpO4ObUltSTL3WhMI/MnTxBlCgpVVHk= X-Google-Smtp-Source: AK7set9MhQ8wT0AVXs4mG3hMRY6fB4ggh5n+ReIbgt2XIPPVSDnELoU78iHm+33/TGhJQuoMWDgA8JynWeCRuJCheOI= X-Received: by 2002:ac2:5388:0:b0:4db:257b:f605 with SMTP id g8-20020ac25388000000b004db257bf605mr1943848lfh.2.1677682900167; Wed, 01 Mar 2023 07:01:40 -0800 (PST) List-Id: Discussion of git use in the FreeBSD project List-Archive: https://lists.freebsd.org/archives/freebsd-git List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-git@freebsd.org MIME-Version: 1.0 References: In-Reply-To: From: Ed Maste Date: Wed, 1 Mar 2023 10:01:30 -0500 Message-ID: Subject: Re: Report on the pull request experiment so far To: Brooks Davis Cc: Warner Losh , freebsd-git Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4PRcrl0D4pz3Mtt X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On Tue, 28 Feb 2023 at 18:04, Brooks Davis wrote: > > IMO we should enforce this on commit dates regardless[0]. There is no > conceivable value in allowing people to commit from systems with wildly > wrong clocks given they must be on the internet to commit. Yes, I think it a reasonable commit hook could enforce having the commit date be: - later than the first parent - earlier than the server's current time On Tue, 28 Feb 2023 at 20:48, Warner Losh wrote: > > A bigger issue in my mind is the project's use of trailer metadata that doesn't match what git expects. The whole spaces vs - thing is making tooling harder than it needs to be... The open source world has standardized on dashes, so we might as well follow suit and change the committer's guide and template to have "Sponsored-by" etc. "Differential Revision" might be an issue, but if "Differential-revision:" is not currently accepted by Phabricator we ought to just patch it.