Date: Fri, 10 Nov 2023 19:00:41 +0100 From: Jochen Neumeister <joneum@FreeBSD.org> To: freebsd-git@freebsd.org Subject: commit error: Non-standard/badly formatted template - found Message-ID: <4949e29a-dc01-4289-971d-0c61313fd463@FreeBSD.org>
next in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format.
--------------9Nlpw4WAPw3GOBzDcCmC8tX0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Hi all,
There is an error when I want to publish a commit:
remote:
remote: ================================================================
remote: Non-standard/badly formatted template - found 'Reviewers:'
instead of 'Reviewed by:'.
remote:
================================================================
remote:
To ssh://repo.freebsd.org/ports.git
I cannot find any errors in my commit message:
databases/mysql57-{client, server}: Update to 5.7.43
Bugs Fixed:
Group Replication: After one machine halted and restarted in a
three-node MySQL InnoDB Cluster, one node failed to start; after
restarting all nodes, the cluster shut down unexpectedly.
Our thanks to Zetang Zeng for the contribution. (Bug #34976442)
Fortified parsing of the network packet data sent by the server to
the client. (Bug #35374491)
Some floating-point literals were not always handled correctly. (Bug
Executing a query with an implicit aggregation should return exactly
one row, unless the query has a HAVING clause that filters out the row,
but a query with a HAVING clause which evaluated to FALSE sometimes
ignored this, and returned a row regardless. (Bug #14272020)
During optimization, range-select tree creation uses logic which
differs based on the left-hand side of the IN() predicate. For a field
item, each value on the right-hand side is added to an OR tree to create
the necessary expression. In the case of a row item comparison (example:
WHERE (a,b) IN ((n1,m1), (n2, m2), ...)), an expression in disjunctive
normal form (DNF) is needed. A DNF expression is created by adding an
AND tree with column values to an OR tree for each set of RHS values,
but instead the OR tree was added to the AND tree causing the tree merge
to require exponential time due to O(n2) runtime complexity. (Bug
See full Changlog here:
https://dev.mysql.com/doc/relnotes/mysql/5.7/en/news-5-7-43.html
Sponsored by: Netzkommune GmbH
# Please enter the commit message for your changes. Lines starting
# with '#' will be ignored, and an empty message aborts the commit.
#
# category/port: Subject goes here, max 50 cols -|
# <then a blank line>
# 72 columns --|
#
# Do not add a Submitted by line. If someone besides the committer
sent in the
# change, the commit author should be set using `git commit --author`.
#
# Uncomment and complete these metadata fields, as appropriate:
#
# PR: <If and which Problem Report is related.>
# Reported by: <If someone else reported the issue.>
# Reviewed by: <If someone else reviewed your modification.>
# Tested by: <If someone else tested the change.>
# Approved by: <If you needed approval for this commit.>
# Obtained from: <If the change is from a third party.>
# Fixes: <Short hash and title line of commit fixed by this
change>
# MFH: <Ports tree branch name you plan to merge to.>
# Relnotes: <Set to 'yes' for mention in release notes.>
# Security: <Vulnerability reference (one per line) or description.>
# Sponsored by: <If the change was sponsored by an organization.>
# Pull Request: <https://github.com/freebsd/freebsd-ports/pull/###>;
# Differential Revision: <https://reviews.freebsd.org/D###>;
#
# "Pull Request" and "Differential Revision" require the *full*
GitHub or
# Phabricator URL.
#
# Date: Fri Nov 10 18:25:02 2023 +0100
#
# On branch main
# Your branch is ahead of 'origin/main' by 2 commits.
# (use "git push" to publish your local commits)
#
# Changes to be committed:
# modified: databases/mysql57-client/files/patch-cmake_ssl.cmake
# modified: databases/mysql57-server/Makefile
# modified: databases/mysql57-server/distinfo
# modified: databases/mysql57-server/files/patch-cmake_ssl.cmake
I have set up my git according to this guideline:
https://docs.freebsd.org/en/articles/committers-guide/#git-mini-daily-use
Does anyone here have any tips?
Cheers
jochen
--------------9Nlpw4WAPw3GOBzDcCmC8tX0
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit
<!DOCTYPE html>
<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
</head>
<body>
<p>Hi all,</p>
<p>There is an error when I want to publish a commit:</p>
<blockquote>
<p>remote:<br>
remote:
================================================================<br>
remote: Non-standard/badly formatted template - found
'Reviewers:' instead of 'Reviewed by:'. <br>
remote:
================================================================
<br>
remote:<br>
To <a class="moz-txt-link-freetext" href="ssh://repo.freebsd.org/ports.git">ssh://repo.freebsd.org/ports.git</a></p>
</blockquote>
<p>I cannot find any errors in my commit message: <br>
</p>
<blockquote>
<p>databases/mysql57-{client, server}: Update to 5.7.43<br>
<br>
Bugs Fixed:<br>
Group Replication: After one machine halted and restarted in a<br>
three-node MySQL InnoDB Cluster, one node failed to start; after<br>
restarting all nodes, the cluster shut down unexpectedly.<br>
<br>
Our thanks to Zetang Zeng for the contribution. (Bug #34976442)<br>
<br>
Fortified parsing of the network packet data sent by the server
to<br>
the client. (Bug #35374491)<br>
<br>
Some floating-point literals were not always handled correctly.
(Bug<br>
<br>
Executing a query with an implicit aggregation should return
exactly<br>
one row, unless the query has a HAVING clause that filters out
the row,<br>
but a query with a HAVING clause which evaluated to FALSE
sometimes<br>
ignored this, and returned a row regardless. (Bug #14272020)<br>
<br>
During optimization, range-select tree creation uses logic which<br>
differs based on the left-hand side of the IN() predicate. For a
field<br>
item, each value on the right-hand side is added to an OR tree
to create<br>
the necessary expression. In the case of a row item comparison
(example:<br>
WHERE (a,b) IN ((n1,m1), (n2, m2), ...)), an expression in
disjunctive<br>
normal form (DNF) is needed. A DNF expression is created by
adding an<br>
AND tree with column values to an OR tree for each set of RHS
values,<br>
but instead the OR tree was added to the AND tree causing the
tree merge<br>
to require exponential time due to O(n2) runtime complexity.
(Bug<br>
<br>
See full Changlog here:
<a class="moz-txt-link-freetext" href="https://dev.mysql.com/doc/relnotes/mysql/5.7/en/news-5-7-43.html">https://dev.mysql.com/doc/relnotes/mysql/5.7/en/news-5-7-43.html</a><br>;
<br>
Sponsored by: Netzkommune GmbH<br>
<br>
# Please enter the commit message for your changes. Lines
starting<br>
# with '#' will be ignored, and an empty message aborts the
commit.<br>
#<br>
# category/port: Subject goes here, max 50 cols -|<br>
# <then a blank line><br>
# 72
columns --|<br>
#<br>
# Do not add a Submitted by line. If someone besides the
committer sent in the<br>
# change, the commit author should be set using `git commit
--author`.<br>
#<br>
# Uncomment and complete these metadata fields, as appropriate:<br>
#<br>
# PR: <If and which Problem Report is related.><br>
# Reported by: <If someone else reported the issue.><br>
# Reviewed by: <If someone else reviewed your
modification.><br>
# Tested by: <If someone else tested the change.><br>
# Approved by: <If you needed approval for this commit.><br>
# Obtained from: <If the change is from a third
party.><br>
# Fixes: <Short hash and title line of commit fixed by
this change><br>
# MFH: <Ports tree branch name you plan to merge
to.><br>
# Relnotes: <Set to 'yes' for mention in release
notes.><br>
# Security: <Vulnerability reference (one per line) or
description.><br>
# Sponsored by: <If the change was sponsored by an
organization.><br>
# Pull Request:
<a class="moz-txt-link-rfc2396E" href="https://github.com/freebsd/freebsd-ports/pull/###"><https://github.com/freebsd/freebsd-ports/pull/###></a><br>;
# Differential Revision:
<a class="moz-txt-link-rfc2396E" href="https://reviews.freebsd.org/D###"><https://reviews.freebsd.org/D###></a><br>;
#<br>
# "Pull Request" and "Differential Revision" require the *full*
GitHub or<br>
# Phabricator URL.<br>
#<br>
# Date: Fri Nov 10 18:25:02 2023 +0100<br>
#<br>
# On branch main<br>
# Your branch is ahead of 'origin/main' by 2 commits.<br>
# (use "git push" to publish your local commits)<br>
#<br>
# Changes to be committed:<br>
# modified:
databases/mysql57-client/files/patch-cmake_ssl.cmake<br>
# modified: databases/mysql57-server/Makefile<br>
# modified: databases/mysql57-server/distinfo<br>
# modified:
databases/mysql57-server/files/patch-cmake_ssl.cmake</p>
</blockquote>
<p>I have set up my git according to this guideline:
<a class="moz-txt-link-freetext" href="https://docs.freebsd.org/en/articles/committers-guide/#git-mini-daily-use">https://docs.freebsd.org/en/articles/committers-guide/#git-mini-daily-use</a></p>;
<p>Does anyone here have any tips?<br>
<br>
</p>
<p><br>
</p>
<p>Cheers<br>
jochen<br>
</p>
<p><br>
</p>
</body>
</html>
--------------9Nlpw4WAPw3GOBzDcCmC8tX0--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4949e29a-dc01-4289-971d-0c61313fd463>