From nobody Sat Feb 11 18:32:48 2023 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PDfNx46Qvz3pqRV for ; Sat, 11 Feb 2023 18:33:05 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic307-55.consmr.mail.gq1.yahoo.com (sonic307-55.consmr.mail.gq1.yahoo.com [98.137.64.31]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4PDfNx2sv0z4ZKh for ; Sat, 11 Feb 2023 18:33:04 +0000 (UTC) (envelope-from marklmi@yahoo.com) Authentication-Results: mx1.freebsd.org; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1676140383; bh=2QTWf/6iLdeZD/6vAe2dYE7e/wl5mWSARq5+1Gb8e6Q=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From:Subject:Reply-To; b=M7FYzNFGWyz9Gd9DI0aVd0bSfoFxr4FXi3rFlIV0QV9W49pe53cvWkKbNhN6AGzOKfhCnal6fJb6hlSIcYrRZSv6jSbwo9K4lqUtz5X48MCue13/6Z2tRkphTlDZc02cWLlM9iuGiQS7J5hahI9h3rz4jztaV21gFpZr8npUSQrjv3Iq1uPilmRGRGT/wudY0R6ji8JCGe2QGX1PEU2O4dRWcaACmEzLovxDX0N2nhS/Gcx5xUweVBAhG1hhhijljiUNptBzyJPFVES3fccQigiX53EachF9C7JxskXiBBN6A7DEde3uCqLFGAqbwrHwFuhia9wK9zaglfspiwTIIQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1676140383; bh=Mm2j0UCfuzkNwbhI24hDqLugSQ3vr6pxW9y7T/WTqCO=; h=X-Sonic-MF:Subject:From:Date:To:From:Subject; b=NmXH+PqnQaPFguweBivTAU2qKplnRbE/aB85IwvaO+0OZsJDqL3NDMD/fy2JdvKrQG79Gdg5tyfs1dDkhumQRTwUisC54RL/9MVk8NhQamgtBklT1mC0YzCEJ/RDNk7Ngmt/9cGMGkSYBtdHKMdnXtKMAFc68X7Oi0oHOTRV0e19cp7bnJoCSXskKzARaOfhDLaZGDzu1ZFdxqog25TQMRaLb1GjSoPcKWpRJdGSXUtM98auRoC8kU6lzN5Nf6XdMR96w29ad6fv7qzPLIN6N/7kS1h5siVWQk5uR1/YmTsMoLHguuJJA9y0uPP9tSc/jjXs6wUQCYsfYziblCIAXQ== X-YMail-OSG: gWN4FZAVM1laXLLNNoRhcj1Soh4xUHNkv8MUv3BhaulfZDg_8GvctoxHR5rmWEK gXXsHhE.i.SJZqrGhEt92ef1iofm.Juwd5o2XgcXKgNZfdIYQlyUZLjN7Opm411MzNkDfed3TyYT 0aZBBgKUsu6ZeBNetGIrHfoi7HOyVo7QSjAbnz.rP.laGE4Y2hddjnBqdCzHJ2CSczM_EvIyXHFP 9K8cJVc0JkWagQ0kSNO5Q_u8cBnGRn03lTImnigdvZXo5ATnWpKmAAsbbpsb61iRQ73zYw99EZNR HGzyzqVwKeGuVnzHcdXYf_cjDewwl0GUSnHhH5nho7VtNEgXFU_o8x.HFuUXEupsykev0783OiDP mPTIMjyMFMAOULIjuLjKZdmL.l5gkLBL.HOsPAcYJNucFUTr255JHvtMD6a8zBA7SYG_wiPqLKZq gufAULm7koTooPH5rMtmkIoeZcUJFedskNrBSDCFf3kPXGT8wf2eQCXHUE2OVJ6ildBro1n.u7D2 Q5mR5khhd.UfsJidYkPu4dXNiMUlOVNnyyEWunMkAG_DgoYKaY_8USx.vYQHn65SK9E9msm4bfiU p6tRpA1sfp1qIl7xTR61YFjq4_xt_ZLVjMjje6xqTupMiyERGKGi1KTHp5G_GdBJrG5.fAxOzs.r dEUZUDGJd.1V27yn3Q0PdgNfEWSn5MNCjWrTHHSjOsCULhVgXX2XuGWTWVkJjvp0.wSQbX0kMHv5 dj_.pG0DQzluK9Xpu6832ETt49ZpLQsOGBSfL523FVc4Xq1ZZJ9Fp81m3nLSZRbHcsfyqOwTzxx7 sTlNfOMRfOUZqDzADc12K9g7o4Sx6BVAr7Vmxwtjl.LH2D9CCWH3jKLQJISzI7X6izQT9zKzV8XJ mtdww3aHCNeYed5dyd50g7op3as2K54ygPO1fOhenC0cr9z9v.TUJTigT9yn.xu_edWd3hZC.iZ9 tkZZGqFx3j5_G66olqM6ff3_o_fTx0DT1PK5MvOgcdwbyH_FYXXWWc..CDp4Btss352TFZ05FvBT 0petRHornohoTajOuDedjc2iBOqHW4_xFzXFcuLn7bmw1pBIzj7E9KT47HUN8_86LcsG7HJ8agOY txq0y5IDLO3oEquPijPcJG4DvSxlblT1DVchxSRCCDhpsZ0rRfzTAungIWawjp.Ha3uLm3JzCBuA M.hNUYZWSjOGLU5BGglHh7yXtjRzaBD5BGlEmJ01eFlSIuyVewBc4ciSM5OWCVs4nGGS0yHsiDp7 WQmdxXyWqv7oOt4tkravOwWDrskTLnVOTPgPw1ivugXvRqjJeH6W2TzwRLACLlPuFJcIM5.IINvg YRki8zSxUwVVVYjMQfATeOtLfdf0NkYNIaEbuKxwZJWwt4l2FamzW6QB88Syq0xX5vMvX.GA9ukY V9QO.hWLNt4Tw42OEqANGjL8OzDPuFgVS8k7X7WOtfqzFjpI63XjyBbVPi9403zW_vfY_fkjX48f 1mvbRk.NS_zNNNWIRB_yMigmKgU9WeWUmcdZb1v4GV5AinWCHxKehFvTKDIyu4P7eVD6RwJLKkEp OQfHzdpXgYhwTTRs48rQmNIoB3hhjcjfrYVswfmsLqKTRoK223BeoPG8me68Dpta6Rz6kTu8GCXs VeOhRhgdMOXfKECrhuZRhjAkl5il1nawqIF3oOXtKFY14gWY6jGD9u893tpb7BKe06udzHxxBuIG 0uIpLT6dGgOpW4T20oY8tLjse_6muB3AWO.D22GQYQe7mGL69X.ADaOLgLtO4AGkSzeVjcSt8bXZ Ajn0fQxKkKE66T.NxDPNQwZAsxy5lAO1pl2SU5guh2GMWLX6ZL69pjunJmzUY6s36IRTtzB38ANZ pGKjEa8upNEpab75gPHD8IIK_yRMd_Wy0J74jc5ck3Q3t2DhX7M6HRl6iNJ27G913FkCJ9t5igcd qS8v9SeUHyQmo8Dp_0L43SAFfwDXrsVoSyhqK.poWjPcgxg19oBLCo3KOGcgu22xNHLsVGxCIdrP ..c_Re3wOBs4KXx1JGaGsgI8tGtibgdgDq.CPd3BVakBFm3XHSCrnDJBxv9mTLoSINmKtFO2aiY9 PISf3BTs9wKNfDOG4mmViOapJM6V94mroBUEcVg2WLfrjQBl2CEBwoT2ceU5sluSIVzF2i6YxmBp Osv4s9pqxh9DlgSyFrypCdWFlrkPFtOE3wQoDWMYiQn3i7paD8HNYb.xSaMPVPb.2NetoUt5xpKS tLvDlLtfFAOrli7LEabCB8eyoPE6gcGrEH3MzaDnw9jd4xu4TVyH7N.11MIX_1VoCVLzDcgxkOK0 fa9jxDXw- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.gq1.yahoo.com with HTTP; Sat, 11 Feb 2023 18:33:03 +0000 Received: by hermes--production-ne1-746bc6c6c4-wq9r9 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID e28447bafc0a206efa602c99537c799b; Sat, 11 Feb 2023 18:32:59 +0000 (UTC) Content-Type: text/plain; charset=utf-8 List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.300.101.1.3\)) Subject: Re: CFT: snmalloc as libc malloc (the source_location issue) From: Mark Millard In-Reply-To: Date: Sat, 11 Feb 2023 10:32:48 -0800 Cc: FreeBSD Hackers , Dimitry Andric Content-Transfer-Encoding: quoted-printable Message-Id: <64CA5178-100B-4244-8F36-ADF417EE2F5C@yahoo.com> References: <22F8AD1A-C1F9-48FA-BCED-E165E2DA5260@yahoo.com> <1982263E-57E0-4709-AAB3-DBB4F75C7546@yahoo.com> <96652C51-EAB7-46C7-9039-557A5DCDAB75@yahoo.com> To: David Chisnall , shawn.webb@hardenedbsd.org X-Mailer: Apple Mail (2.3731.300.101.1.3) X-Rspamd-Queue-Id: 4PDfNx2sv0z4ZKh X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/20, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On Feb 11, 2023, at 09:13, David Chisnall wrote: > On 10 Feb 2023, at 21:34, Mark Millard wrote: >>=20 >> # find / -name source_location -print | more >> = /usr/obj/DESTDIRs/main-amd64-chroot/usr/local/lib/gcc12/include/c++/experi= mental/source_location >> = /usr/obj/DESTDIRs/main-amd64-chroot/usr/local/lib/gcc12/include/c++/source= _location >> /usr/local/lib/gcc12/include/c++/experimental/source_location >> /usr/local/lib/gcc12/include/c++/source_location >>=20 >> So, none for FreeBSD and its llvm15. >>=20 >> This makes sense, https://libcxx.llvm.org/Status/Cxx20.html shows: >>=20 >> P1208R6 LWG Adopt source_location for C++20 Cologne Complete 16.0 >>=20 >> So, likely FreeBSD will not have this until it progresses to >> LLVM16 . It just changed to LLVM15 in main [so: FreeBSD 14]. >=20 > The include of source_location is guarded under an #if __has_include, = it should be used only if it exists. If it doesn=E2=80=99t, there=E2=80=99= s a stub implementation. If you have GCC includes in your include path, = is it possible that it=E2=80=99s finding a source_location that is then = guarded behind a check for a compiler builtin that clang doesn=E2=80=99t = have? I was just looking at Shawn's hardenedbsd log and FreeBSD source (source from after the llvm15 update). Shawn's log shows an example of: = /data/src/hardenedbsd/contrib/snmalloc/src/snmalloc/override/../global/../= backend/../backend_helpers/../mem/../ds/../pal/../aal/../ds_core/defines.h= :114:12: fatal error: 'source_location' file not found # include (I do not have hardenedbsd source around, nor an install. Just FreeBSD.) The gcc12 present in my search is from/for port building, not for buildworld or buildkernel for FreeBSD. I have not tried to do anything with snmalloc myself. I was just looking at part of the context Shawn presented based on the request: QUOTE Any non-XKCD[138]-conforming pointers would be appreciated. ;-) END QUOTE As to how helpful --or not-- Shawn found my notes and responses to my notes, I do not know. I did not expect my notes to be a complete classification of everything involved, just a possible start. =3D=3D=3D Mark Millard marklmi at yahoo.com From nobody Sun Feb 12 16:13:22 2023 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PFCFQ3FVrz3q1f2 for ; Sun, 12 Feb 2023 16:13:30 +0000 (UTC) (envelope-from yonas.yanfa@gmail.com) Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PFCFP5QnBz3HrV for ; Sun, 12 Feb 2023 16:13:29 +0000 (UTC) (envelope-from yonas.yanfa@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20210112 header.b=PzDCHD6+; spf=pass (mx1.freebsd.org: domain of yonas.yanfa@gmail.com designates 2a00:1450:4864:20::62c as permitted sender) smtp.mailfrom=yonas.yanfa@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ej1-x62c.google.com with SMTP id rp23so26465858ejb.7 for ; Sun, 12 Feb 2023 08:13:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:subject:from:to:content-language :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=wYtGxRlNXJWrcSVCzw8d+L1UeKf/Ki89XK8oBTARx8U=; b=PzDCHD6+ZLVCce/dTwuaKQvTNP+PkSuNDFF28JQhjUMxV6Vzhv5uPtnAaIdlx+9guL 0O1OPXgK+ajerBv9m1TkWQyZCzQQe/iyVbNN2leUrWT8xXgCXCIbGRVfxsrXRDi3/XDM 07gjw56dH9bedv2pbITi0Dvb05xgOrwumHgPjTmqA/PJg/j8oCIhKIPpAMUx3r9q8paW aEjnw7nraCxgCzY9lx0FKfdgF6vYF9g/OJLTPHAet/1Sq8yvm2jKAJlopHgsE39Vetux TnhE95jBadGQ32B/iQl0GEcNQ2jSrjh3QQ6XAPC973ig79jNLyrPHUPbPCdzsWUrCOFp TcgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:subject:from:to:content-language :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=wYtGxRlNXJWrcSVCzw8d+L1UeKf/Ki89XK8oBTARx8U=; b=qg5S9Ru8O3cCGNry4fFthfl/WB4F5nvfXd/CjnTniyOY9GS/Zyyz9lXBLkn9mtSBjP xVpTeCWljwi3w+Ix4Mp/417C4sknjqOGHcAalSRPRlh/Gp4iXk+d9jWPuJqqJM0gVQN8 dvkt2UpN1gNioPYzfTotA0nMkBpfInTYjKi3stCa8y6cGZbUvqHbXOXHkpeVxKzjK52V X1T5l69Y0ehnQnYu0J+QbUZTMl10hgBbd/IgbIWoLbaDlp08D+xLXKxToMHhqpPhahdg UkRAy8pB+5nLIU9R/vENZmGl1a95FKN1zxbSydvkT9O3wQBLSx8tS0qcfh1U7EVm0UUT N/Xg== X-Gm-Message-State: AO0yUKXBBs4djbYvNJFrrshDTHjH00WAsvWwqwxJtCWcwAkPMxpcrC6D uuxbrAtXk5kpqTHTR7WysSOwSO2dzjr2FA== X-Google-Smtp-Source: AK7set9icur6djcGJIMbYB2jkf71LpWn3pVfaAitfcI9XYAAxswvX1736aXOinbOm+jjIqtl3A0QUw== X-Received: by 2002:a17:906:1c90:b0:878:7291:d558 with SMTP id g16-20020a1709061c9000b008787291d558mr22058375ejh.34.1676218406883; Sun, 12 Feb 2023 08:13:26 -0800 (PST) Received: from [10.16.0.2] (93-190-138-195.hosted-by-worldstream.net. [93.190.138.195]) by smtp.gmail.com with ESMTPSA id r14-20020a170906364e00b0088351ea808bsm5484735ejb.46.2023.02.12.08.13.25 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Feb 2023 08:13:26 -0800 (PST) Message-ID: <2701c344-ca24-6793-bda2-6f76a2b42922@gmail.com> Date: Sun, 12 Feb 2023 11:13:22 -0500 List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Content-Language: en-US To: freebsd-hackers@FreeBSD.org From: Yonas Yanfa Subject: Add FreeBSD-SA-23:01.geli.asc to 13.1R Errata Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-3.99 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.99)[-0.990]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20210112]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36]; MIME_GOOD(-0.10)[text/plain]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; PREVIOUSLY_DELIVERED(0.00)[freebsd-hackers@freebsd.org]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; TAGGED_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_NONE(0.00)[]; FREEMAIL_FROM(0.00)[gmail.com]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::62c:from]; DKIM_TRACE(0.00)[gmail.com:+]; RCVD_TLS_LAST(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; MIME_TRACE(0.00)[0:+]; MLMMJ_DEST(0.00)[freebsd-hackers@freebsd.org] X-Rspamd-Queue-Id: 4PFCFP5QnBz3HrV X-Spamd-Bar: --- X-ThisMailContainsUnwantedMimeParts: N Hi, I can't find FreeBSD-SA-23:01.geli.asc on https://www.freebsd.org/releases/13.1R/errata. Cheers, Yonas From nobody Sun Feb 12 19:44:24 2023 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PFHwr03lYz3r9XP for ; Sun, 12 Feb 2023 19:44:28 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-qt1-x832.google.com (mail-qt1-x832.google.com [IPv6:2607:f8b0:4864:20::832]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PFHwq1Mcxz3yvC for ; Sun, 12 Feb 2023 19:44:27 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=hardenedbsd.org header.s=google header.b=AL0GfG4t; spf=pass (mx1.freebsd.org: domain of shawn.webb@hardenedbsd.org designates 2607:f8b0:4864:20::832 as permitted sender) smtp.mailfrom=shawn.webb@hardenedbsd.org; dmarc=none Received: by mail-qt1-x832.google.com with SMTP id 5so11799166qtp.9 for ; Sun, 12 Feb 2023 11:44:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=xLnT5ApllZ2ekvp8EoSe+7e07JM1n9NyH/7qQGXok+o=; b=AL0GfG4tTbGh6dCVF/jHOGJDZUva8gCsqZmVrNpCcR+dfmjH70dky0+MMdV/1eP6M5 6kqQGifHb2SS0hZgsRc2n1Zbwe0G4oUUvZ37T7HVTCwYKm4zlCySVfxy2WNzhJm4pV7T lJQF2dvvCv2o7w1mqrjpBw8EfS+wMH6JkZO/EB8Gk5XkR8foC7Q98UfapcalzU+/FxrM Ew8Q6+2rES02/QsnTlV243A6Qvc0Qvf1MZmk4pcWtfySibtEe5BAqf8GLf2cLtJ7RPkF Tc0CyTFXZfUorLz/uEYuLim7vB7+PMQZZau0L6k0fPFKyq+Jsc6LvThPRioQL+w4jn1j DLgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xLnT5ApllZ2ekvp8EoSe+7e07JM1n9NyH/7qQGXok+o=; b=GYFhDUI9YBYgnFfop8MFYAtbQsVgCdg12FkW8Gb6YEVTbecyup6b+OOn6rnsMzpBYs 3vbnW2ufAWsySPz0Uligeo28Nmu3u8nkW/B+ybSi1yRFUBLrTLQkKi1q3WI+SyNYD0I+ cs4qfLAvAgx+W34cFIPrflxUefiXYyy0HZ7KdG5jfnu1BPnUkcR0qhh4QKRfLYmHYSv5 73pByydjw2rLd0slBfEldM+j/fYGgx19W/yj11pW4OsXTGoFBdj/d5E0yEezBw2sRv2w RztgFxOgX2h3DOhPlKHTJwGwJBUkVGia2asfBbbxKw/x9gwiU3ddAe/otV7zAsbCasLK 7Vkw== X-Gm-Message-State: AO0yUKU5y41erLC8Tpy+wsnSkPu3tZx/ey2TqaW+Tm7szIkBzIovFElY r2p4SQ/ksMMWqEbtGLBsj/gJ6+8DX4MXMfKJ X-Google-Smtp-Source: AK7set9Zk1S8a/H04aSRkhX1jdv+IQpFVxWBWYKdx3oCoyv5mL7CuaYFepCk/T+sbR5g9r5kW03yKw== X-Received: by 2002:ac8:5554:0:b0:3b9:bc8c:c216 with SMTP id o20-20020ac85554000000b003b9bc8cc216mr19627567qtr.33.1676231066305; Sun, 12 Feb 2023 11:44:26 -0800 (PST) Received: from mutt-hbsd (pool-100-16-219-215.bltmmd.fios.verizon.net. [100.16.219.215]) by smtp.gmail.com with ESMTPSA id r21-20020ac85e95000000b003b835e7e283sm7886398qtx.44.2023.02.12.11.44.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Feb 2023 11:44:25 -0800 (PST) Date: Sun, 12 Feb 2023 14:44:24 -0500 From: Shawn Webb To: David Chisnall Cc: freebsd-hackers Subject: Re: CFT: snmalloc as libc malloc Message-ID: <20230212194424.ka7omg6ya3ain3ml@mutt-hbsd> X-Operating-System: FreeBSD mutt-hbsd 14.0-CURRENT-HBSD FreeBSD 14.0-CURRENT-HBSD X-PGP-Key: https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/blob/master/Shawn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc References: <2f3dcda0-5135-290a-2dff-683b2e9fe271@FreeBSD.org> <20230210162350.gg5g7dihp3zef3ov@mutt-hbsd> <193D1E1C-73EB-42BB-8A6A-87B0E4AD9D7C@FreeBSD.org> List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7emnhufbnpa7q373" Content-Disposition: inline In-Reply-To: <193D1E1C-73EB-42BB-8A6A-87B0E4AD9D7C@FreeBSD.org> X-Spamd-Result: default: False [-5.10 / 15.00]; SIGNED_PGP(-2.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.998]; MID_RHS_NOT_FQDN(0.50)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; R_DKIM_ALLOW(-0.20)[hardenedbsd.org:s=google]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; MLMMJ_DEST(0.00)[freebsd-hackers@freebsd.org]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::832:from]; FROM_EQ_ENVFROM(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; DKIM_TRACE(0.00)[hardenedbsd.org:+]; PREVIOUSLY_DELIVERED(0.00)[freebsd-hackers@freebsd.org]; RCVD_COUNT_THREE(0.00)[3]; DMARC_NA(0.00)[hardenedbsd.org]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_VIA_SMTP_AUTH(0.00)[] X-Rspamd-Queue-Id: 4PFHwq1Mcxz3yvC X-Spamd-Bar: ----- X-ThisMailContainsUnwantedMimeParts: N --7emnhufbnpa7q373 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Feb 11, 2023 at 05:10:02PM +0000, David Chisnall wrote: > On 10 Feb 2023, at 16:23, Shawn Webb wrote: > >=20 > > So I took a little bit of a different approach, which should provide > > the same end result as your submodule approach. Note that I'm doing > > this in HardenedBSD 14-CURRENT (the hardened/current/master branch). > >=20 > > 1. git cherry-pick -xs a5c83c69817d03943b8be982dd815c7e263d1a83 > > 2. git rm -f .gitmodules contrib/snmalloc > > 3. git commit > > 4. git subtree add -P contrib/snmalloc \ > > git@github.com:microsoft/snmalloc.git main > >=20 > > I believe this should leave me with a tree that populates > > contrib/snmalloc and pulls in your non-contrib/ changes, leading me to > > end up in the same end state as your submodule approach. > >=20 > > I am seeing some build errors. I've uploaded a WITHOUT_CLEAN=3Dyes log > > to: > >=20 > > https://hardenedbsd.org/~shawn/2023-02-10_snmalloc-01.log.txt > >=20 > > Note that this is with llvm 15.0.7 that just landed in FreeBSD main. >=20 > The error is a bit confusing, because nullptr_t has been in libc++ since = C++11. Does HardenedBSD change anything in include orders? Can you add -v= to the end of the compile command: >=20 >=20 > c++ -target x86_64-unknown-freebsd14.0 --sysroot=3D/usr/obj/data/src/har= denedbsd/amd64.amd64/tmp -B/usr/obj/data/src/hardenedbsd/amd64.amd64/tmp/us= r/bin -fomit-frame-pointer -O2 -pipe -fno-common -DHARDENEDBSD -DNO__SCCSID= -DNO__RCSID -I/data/src/hardenedbsd/lib/libc/include -I/data/src/hardenedb= sd/include -I/data/src/hardenedbsd/lib/libc/amd64 -DNLS -ftls-model=3Diniti= al-exec -D__DBINTERFACE_PRIVATE -I/data/src/hardenedbsd/contrib/gdtoa -I/da= ta/src/hardenedbsd/contrib/libc-vis -DINET6 -I/usr/obj/data/src/hardenedbsd= /amd64.amd64/lib/libc -I/data/src/hardenedbsd/lib/libc/resolv -D_ACL_PRIVAT= E -DPOSIX_MISTAKE -I/data/src/hardenedbsd/lib/libmd -I/data/src/hardenedbsd= /lib/libc/locale -DBROKEN_DES -DPORTMAP -DDES_BUILTIN -I/data/src/hardenedb= sd/lib/libc/rpc -DWANT_HYPERV -DYP -DNS_CACHING -DSYMBOL_VERSIONING -g -gz= =3Dzlib -mretpoline -fPIC -flto -MD -MF.depend.malloc.o -MTmalloc.o -Wno-fo= rmat-zero-length -fstack-protector-strong -Wsystem-headers -Werror -Wall -W= no-format-y2k -Wno-uninitialized -Wdate-time -Wno-empty-body -Wno-string-pl= us-int -Wno-unused-const-variable -Wno-error=3Dunused-but-set-variable -Wno= -error=3Darray-parameter -Wno-error=3Ddeprecated-non-prototype -Wno-error= =3Dunused-but-set-parameter -Wno-tautological-compare -Wno-unused-value -Wn= o-parentheses-equality -Wno-unused-function -Wno-enum-conversion -Wno-unuse= d-local-typedef -Wno-address-of-packed-member -Wno-switch -Wno-switch-enum = -Wno-knr-promoted-parameter -Qunused-arguments -I/data/src/hardenedbsd/lib/= libutil -I/data/src/hardenedbsd/lib/msun/amd64 -I/data/src/hardenedbsd/lib/= msun/x86 --include-directory-after /data/src/hardenedbsd/lib/msun/src -DHAR= DENEDBSD -I/data/src/hardenedbsd/contrib/snmalloc/src/snmalloc -std=3Dc++2= 0 -mcx16 -fno-exceptions -fno-rtti -DSNMALLOC_USE_THREAD_CLEANUP -DSNMALLOC= _BOOTSTRAP_ALLOCATOR -DSNMALLOC_JEMALLOC3_EXPERIMENTAL -DSNMALLOC_JEMALLOC_= NONSTANDARD -DSNMALLOC_PLATFORM_HAS_GETENTROPY -DSNMALLOC_STATIC_LIBRARY_PR= EFIX=3D__ -ftls-model=3Dinitial-exec -DSNMALLOC_CHECK_CLIENT -DSNMALLOC_FAI= L_FAST=3Dfalse -DNDEBUG -g -gz=3Dzlib -mretpoline -flto -Wno-c++11-exten= sions -c /data/src/hardenedbsd/lib/libc/stdlib/snmalloc/malloc.cc -o mall= oc.o >=20 >=20 >=20 > That should dump the include paths. It=E2=80=99s possible that the libc+= + headers are being included in the wrong order with respect to the C paths? Hey David, HardenedBSD doesn't have any changes to userland that would cause changes in include header paths (and the priorities of them.) I made sure to `pkg delete -g gcc\* binutils\*` before running another buildworld, ending up with the same error. I tried running your command above. Here's the result: http://ix.io/4nS9 I think Mark might be on the right track with regards to llvm 15. I'll try importing the snmalloc patch (via the same subtree method) to a pre-llvm15 import branch and report back. It might be a few days before I get you a result. BTW, I appreciate the work. One long-term goal I've had for HardenedBSD is to be able to switch between multiple heap implementations at buildworld-time. I think it would be nifty for users to have a choice of jemalloc, snmalloc, and GrapheneOS' hardened_malloc. Thanks, --=20 Shawn Webb Cofounder / Security Engineer HardenedBSD https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/raw/master/Shawn_Webb/03A= 4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc --7emnhufbnpa7q373 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAmPpQZEACgkQ/y5nonf4 4frmqQ//eWViZtBrwkq3zrzEBbBEyxpWpQvzyG68scSvtdJ6/+bVzGbk/xR3mzso DDiWwaL2ehEBdWwj1WDS4bPKF33Tm8jdOje8gf0qG+ajgcnhSpZFTqNbTmOxWdNO YIKJkCuhxP4AOMD8mhEgdzZseOlYcO7txlFefI8e6+B9nc4siM7OmO76CgGrzN1Q MP9YPDAhvEI5txsRHh/BXPxDU5hk/stHsdnwdIrZn5hq65qXU49+omMxx/T62JQ9 fpapv2rZOc0PmkyrMuAQlKo6EnSzANG2Cudd5Bx4MI8oZbpCwZKXGIuOmYwgN1U5 PjOYJ0J4IPyU7u3nwerKAB9RpG+HNFgt4KJlXvc/YRi7732GcCKamcpXUkYmZWXC 3l/1tQH8NtX/quXwH5tOUI2PWjxRHJoHfRv1Dtw3hzzB5FEVNxa8A4D4TtH7EsJU oW81yfuFW59wLmLlnXV2u77/uyaoafEW/gxUjWzc8+9c4o1ZQ7Fogj0nf7cT8g0P Q13N92pEEtwF863uJ4X1VQtXlvDBYAa1rMfYGMNMrqrhkO0QwhY5J2krmM7+tSzP 4mpT1fPwHYg64gRJpoOKDQrSs9PvybmfxXht1wXHg5j9exJS4CgeCBuBj5D5+9rp 39oIeJvAKwk/f0zdi6EvhNBTjwV3hYAqGalYvgix4csASIDiAyA= =blgy -----END PGP SIGNATURE----- --7emnhufbnpa7q373-- From nobody Sun Feb 12 20:01:22 2023 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PFJJf0gN6z3rBwj for ; Sun, 12 Feb 2023 20:01:38 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic301-22.consmr.mail.gq1.yahoo.com (sonic301-22.consmr.mail.gq1.yahoo.com [98.137.64.148]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4PFJJc05dJz43Qf for ; Sun, 12 Feb 2023 20:01:35 +0000 (UTC) (envelope-from marklmi@yahoo.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=yahoo.com header.s=s2048 header.b=JIfhV2oV; spf=pass (mx1.freebsd.org: domain of marklmi@yahoo.com designates 98.137.64.148 as permitted sender) smtp.mailfrom=marklmi@yahoo.com; dmarc=pass (policy=reject) header.from=yahoo.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1676232094; bh=suS1YhdBrEFsreozH+4w7JZ9WJIFXkceKwnreqtF9jY=; h=From:Subject:Date:Cc:To:References:From:Subject:Reply-To; b=JIfhV2oVDKex7mKIgx38Ps+qi3EpD2uplqNzf6Ly7EaoQ93vfRd26c/SLI0NwCI0NltjNedcE/zaN73DsGIyrwvnHpwYM32VPHxAJ4KJgEzb5d2O+syLp90cMviFCNwHpmXbsX90UN8m2PgPw6bUJ7Oo9QEr23FiS4KOvR7Q6JhQzPLxxVhojVjrz+2WJ45QS+GewcVL9ESwX7LLSnQHqlGCU6QpSf8C+kIRNV7hK7yoKr/78RWwxlKGxMrE56UqXWXKxv1vuOB4OYyroxlcTu+AMAU8hAXzqcuicSyK+B/YQs+uA6mn0hnTusorbhioCOQiIuX5ndvI7rIfGagO3Q== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1676232094; bh=Cb27un9AZnvHjtHBmvJfQZ0c7u7Deud71hQ/5Eq6tXw=; h=X-Sonic-MF:From:Subject:Date:To:From:Subject; b=X8QcqZsiNF7bGTo3jEDKNye5GRP3a9vyXPYEwX2/z+UUvJcg0ZBXwJfHAR5h2QkQtk6bsjvJHX5EEXGfeaMlt72OUQRS+zmkarxFEIM3nWpPbSh7Py4W9FYWxPZUsttdsJzKSCCt0mKsRYYZjQUbGXBQqgQ78f4m9++Ow+Tjt8X8E8UcevGrxtzrj1pG00VQFt7kjnggZ7hB6qQ8SWwOdX1pLbicvaq1EINLaMKBeprMo0AU/67ZXRvVxkAYGzKuyT+2qoQGYM4g6R0Iq/RnoH4cigkFfa/JviAA1E5i/KvdQKp9jr2Et47BYxPlm+1os8rXHd3aMxS+eN39SofVLg== X-YMail-OSG: XomcE7UVM1nvIG.qAXlwuEdVlsIMaPqnIirELvxWAdHrrZv_dI0CChNCwTQiSPl .kuoBOC_VlK8EVkqyapuuAj3tkW1l5hecQfF.TIF4ZS6ZEujNAq0.EldUmhSVz6BTYPdzBLFdIAM i7UAdgXlrS0HpSs7WtcAfbWIEmMUydzZZOvpVwCIwm0haZG.zjHMB_YfRE6sTp9678KORZAUh53O Pl5Vf.86xz9uXbnSuYa4avJI6ZTCyF1WhlWvcAw34qFwTalYF0eajORvluIszreEfU8iSaxbBirD Sg7oMPk_0xPJP9uRPZr1gNR2q1Y1BR9ugRhVnwWgCVBeE01j7XNNsJNjnizuOdw8VfFWHf9mNdQ9 3WtwK.x2v1cgcf5sWgkZTXdISlrZ_pd.6fjD7oBzoTAYN4hOMSNVnIJ8gohzep_jpJi_4HfRfVTZ ThhRWTUVpMLfAwq5OYCLOB..8l5W2tNCWAqEwHIGzAmzS2YO49CYKtBU6ea4atgDpWqUeaSZ2Gt9 _YEb8XOrlkGu.1D.UT7ZNv5ZrsePaJ3Nfj62w6G9AkpS_ykgHzuCNxx.Y06szhlVM9VvRBgLjaXv GEZS7IN0RTfbDjo.xxN3sm9_3150x7zRc1gxkQWmhcESa_HW7A33.bUEADim7XNKmmyOHVOCE75I x8316YdUVUht7GKRy_ph7sPZJ0uaJMhD1Y5OGF6HWr.h4J4qVdU8DV68PVOttVdjGBsTJnL5d4vr 0yDStncq6X_gX_NmIUjbcA7ayscYmgwUsuAlaTR7bsbHD64Vw2XyjS548Fg6wU6s0V4Gl.Z6Bq2l VwpsXvtoSpV9XIQfk0_IcwCLt0omg_.dQz_DuqelTvJO.mjMY6mmR_7Tbk951Xi99iLpOQlmEWOY fAloQLKg37N_wStyojfNBjx315YfJ2MLmv_1IfT9qahdma6rLywLiAuhFzO1RpJ_GmuTbAL5BrCc .4a17wD4zFgBt5r4l2rqVmqX1v7BIBWSmtvnCSZslyeZKxHLeeczOXbC8PEvt4eFEIIBfKnlYg_u soy_XUlyM4LjYWCoSv2bzC0QwpthRmWXLONqQmoVGJU9OAvN0uRhuaIwm7Uq2vIcZbUmBehvCbTM DdMOw0dFBg7YdMAxsAsdRAaWnMVHsSF9p3lG0P46dVSnlO5ykMOir2Yo0mq2Cc2eSlJCddPpx8qq BwMAQ1arrAAyHqKtTkSMl9NR8XN0GUCiUdRolLs1OkgZsQt17FNPBHzXELbzJJ_1Fghg93yCgRaJ 8JM0VWuWuS9PKMojnZMg5rmPAWxAAw3pKghtZ3OMtPMPZqWK3kmnmu4BrUq7wcuz2QVeYTT8dSJ8 RhWKYpalpXf3xmATk673N.5uZ_b_KIoYCXnnxAVpgtIfolFyQs3lEVImNQ7T6tjGZa03qXlVRHuP .uCu1NMrMpcuqQRlcwljZd_LKnH8Mc.YXHzsrUz4LPBSxhiuRIluZAJa_2Dx_4aflcx0F6WBiLfp LHAAsuN7R2fYtZh6Y_Rq_iuJAC3amZ4eausxjzm1NpI_RzcssUk6vC5gq.m5lAsGa.IM1L3Y2Iu1 iM7D3cDbspBmbr6I4UQGV2ue6CMkHVhNLtHIvuXf4bblcH.2UHJi0r6x06_jyLd755IebStG7wkO yJ4kYXG0BMbiwyXUHHvlULeVBDqtQ36ZWL1X5CvARCegeD1Ak4Pmlrq7I9FiIV2XivIVK9ALzjOU UFUF2eDFxrqH6PPlpJ5g2eW15qt0HRtHGitzEJouZpSlsRWTAiWTMo_W.pTpl0vmW2ZDcjaQ7ZEm w4NdU8ZeJznk.PcqebqRE5EQeDXPwK2i89bYDkmzzaNUgt0_nSq9CNwvPZiA4KhlmzDR1KseyXhe uD4du64Q8xhA1_XF4Ur4E_7zUwMmTSJaBaihhiz7I_Y.9ZogmEK5JmCPdCcNtO0.YYlU_2kjuB4T i2kKHDTI1qw0asJ8bsqDKPiQKkwWWDS0IUsGy_CbopFYIDR_fVugnEZWe1UUGoRGJSbkZ3jYQiYY 9SoejhBGF3UhYzK5KmyAeJkQzcQrx.b7gPZnaVV7A2D_mELdheNCTnevZ.CgkUQ36TwNuK1r3ysZ B7soCVRnR9K.OsYPBWoEXI9pZNYUpoB7Xz5cae.Dh6X7hHKTPXXKLXwJ.gu.P_pLZZaDQLTYVnLR NWxZtYrn2xNg4Af0A1p8Dbm0BtG0kkA3lQNlWsssvJGJ862YdR1NeHC.zcVn.cDP9YobZ1K8sGEA ksZljSoLPjFjQnDXS_LjPQY8dOu2AoACe6uKxX4ZLyCMgg_uTdQpy3v7gIkqDcFcIGuK7rp2UjM9 Sq3qIwKD5 X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic301.consmr.mail.gq1.yahoo.com with HTTP; Sun, 12 Feb 2023 20:01:34 +0000 Received: by hermes--production-gq1-655ddccc9-j6kw5 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID b82b2dfb47e95f30041923d27d234d9e; Sun, 12 Feb 2023 20:01:33 +0000 (UTC) From: Mark Millard Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.300.101.1.3\)) Subject: Re: CFT: snmalloc as libc malloc Message-Id: Date: Sun, 12 Feb 2023 12:01:22 -0800 Cc: David Chisnall To: shawn.webb@hardenedbsd.org, FreeBSD Hackers X-Mailer: Apple Mail (2.3731.300.101.1.3) References: X-Spamd-Result: default: False [-3.50 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; MV_CASE(0.50)[]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; MIME_GOOD(-0.10)[text/plain]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; DWL_DNSWL_NONE(0.00)[yahoo.com:dkim]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/20, country:US]; RCVD_IN_DNSWL_NONE(0.00)[98.137.64.148:from]; RCVD_COUNT_THREE(0.00)[3]; FREEMAIL_FROM(0.00)[yahoo.com]; TO_DN_SOME(0.00)[]; RCVD_TLS_LAST(0.00)[]; DKIM_TRACE(0.00)[yahoo.com:+]; MIME_TRACE(0.00)[0:+]; FROM_EQ_ENVFROM(0.00)[]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; MLMMJ_DEST(0.00)[freebsd-hackers@freebsd.org] X-Rspamd-Queue-Id: 4PFJJc05dJz43Qf X-Spamd-Bar: --- X-ThisMailContainsUnwantedMimeParts: N Shawn Webb wrote on Date: Sun, 12 Feb 2023 19:44:24 UTC : > On Sat, Feb 11, 2023 at 05:10:02PM +0000, David Chisnall wrote: > > On 10 Feb 2023, at 16:23, Shawn Webb = wrote: > > >=20 > > > So I took a little bit of a different approach, which should = provide > > > the same end result as your submodule approach. Note that I'm = doing > > > this in HardenedBSD 14-CURRENT (the hardened/current/master = branch). > > >=20 > > > 1. git cherry-pick -xs a5c83c69817d03943b8be982dd815c7e263d1a83 > > > 2. git rm -f .gitmodules contrib/snmalloc > > > 3. git commit > > > 4. git subtree add -P contrib/snmalloc \ > > > git@github.com:microsoft/snmalloc.git main > > >=20 > > > I believe this should leave me with a tree that populates > > > contrib/snmalloc and pulls in your non-contrib/ changes, leading = me to > > > end up in the same end state as your submodule approach. > > >=20 > > > I am seeing some build errors. I've uploaded a WITHOUT_CLEAN=3Dyes = log > > > to: > > >=20 > > > https://hardenedbsd.org/~shawn/2023-02-10_snmalloc-01.log.txt > > >=20 > > > Note that this is with llvm 15.0.7 that just landed in FreeBSD = main. > >=20 > > The error is a bit confusing, because nullptr_t has been in libc++ = since C++11. Does HardenedBSD change anything in include orders? Can you = add -v to the end of the compile command: > >=20 > >=20 > > c++ -target x86_64-unknown-freebsd14.0 = --sysroot=3D/usr/obj/data/src/hardenedbsd/amd64.amd64/tmp = -B/usr/obj/data/src/hardenedbsd/amd64.amd64/tmp/usr/bin = -fomit-frame-pointer -O2 -pipe -fno-common -DHARDENEDBSD -DNO__SCCSID = -DNO__RCSID -I/data/src/hardenedbsd/lib/libc/include = -I/data/src/hardenedbsd/include -I/data/src/hardenedbsd/lib/libc/amd64 = -DNLS -ftls-model=3Dinitial-exec -D__DBINTERFACE_PRIVATE = -I/data/src/hardenedbsd/contrib/gdtoa = -I/data/src/hardenedbsd/contrib/libc-vis -DINET6 = -I/usr/obj/data/src/hardenedbsd/amd64.amd64/lib/libc = -I/data/src/hardenedbsd/lib/libc/resolv -D_ACL_PRIVATE -DPOSIX_MISTAKE = -I/data/src/hardenedbsd/lib/libmd = -I/data/src/hardenedbsd/lib/libc/locale -DBROKEN_DES -DPORTMAP = -DDES_BUILTIN -I/data/src/hardenedbsd/lib/libc/rpc -DWANT_HYPERV -DYP = -DNS_CACHING -DSYMBOL_VERSIONING -g -gz=3Dzlib -mretpoline -fPIC -flto = -MD -MF.depend.malloc.o -MTmalloc.o -Wno-format-zero-length = -fstack-protector-strong -Wsystem-headers -Werror -Wall -Wno-format-y2k = -Wno-uninitialized -Wdate-time -Wno-empty-body -Wno-string-plus-int = -Wno-unused-const-variable -Wno-error=3Dunused-but-set-variable = -Wno-error=3Darray-parameter -Wno-error=3Ddeprecated-non-prototype = -Wno-error=3Dunused-but-set-parameter -Wno-tautological-compare = -Wno-unused-value -Wno-parentheses-equality -Wno-unused-function = -Wno-enum-conversion -Wno-unused-local-typedef = -Wno-address-of-packed-member -Wno-switch -Wno-switch-enum = -Wno-knr-promoted-parameter -Qunused-arguments = -I/data/src/hardenedbsd/lib/libutil = -I/data/src/hardenedbsd/lib/msun/amd64 = -I/data/src/hardenedbsd/lib/msun/x86 --include-directory-after = /data/src/hardenedbsd/lib/msun/src -DHARDENEDBSD = -I/data/src/hardenedbsd/contrib/snmalloc/src/snmalloc -std=3Dc++20 = -mcx16 -fno-exceptions -fno-rtti -DSNMALLOC_USE_THREAD_CLEANUP = -DSNMALLOC_BOOTSTRAP_ALLOCATOR -DSNMALLOC_JEMALLOC3_EXPERIMENTAL = -DSNMALLOC_JEMALLOC_NONSTANDARD -DSNMALLOC_PLATFORM_HAS_GETENTROPY = -DSNMALLOC_STATIC_LIBRARY_PREFIX=3D__ -ftls-model=3Dinitial-exec = -DSNMALLOC_CHECK_CLIENT -DSNMALLOC_FAIL_FAST=3Dfalse -DNDEBUG -g = -gz=3Dzlib -mretpoline -flto -Wno-c++11-extensions -c = /data/src/hardenedbsd/lib/libc/stdlib/snmalloc/malloc.cc -o malloc.o > >=20 > >=20 > >=20 > > That should dump the include paths. It=E2=80=99s possible that the = libc++ headers are being included in the wrong order with respect to the = C paths? >=20 > Hey David, >=20 > HardenedBSD doesn't have any changes to userland that would cause > changes in include header paths (and the priorities of them.) >=20 > I made sure to `pkg delete -g gcc\* binutils\*` before running another > buildworld, ending up with the same error. >=20 > I tried running your command above. He asked that you add a -v to it. Implicitly also: capture and report the extra text that the -v causes in the output. That extra text covers what the sequence of include paths searched are in the order searched. It shows even the paths for which nothing is/will-be found for the specific compile: where all did the compiler look? Any unexpected places? Any missing places? Any examples of not being in the required order? > Here's the result: > http://ix.io/4nS9 That does not include the extra text that would be generated by having added the -v requested to that shown command line. That tet would likely have been before the text that you did include. Did you add the -v option? Was there extra text? > I think Mark might be on the right track with regards to llvm 15. I'll > try importing the snmalloc patch (via the same subtree method) to a > pre-llvm15 import branch and report back. It might be a few days > before I get you a result. >=20 > BTW, I appreciate the work. One long-term goal I've had for > HardenedBSD is to be able to switch between multiple heap > implementations at buildworld-time. I think it would be nifty for > users to have a choice of jemalloc, snmalloc, and GrapheneOS' > hardened_malloc. =3D=3D=3D Mark Millard marklmi at yahoo.com From nobody Sun Feb 12 21:09:04 2023 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PFKpV5YBvz3rLFF for ; Sun, 12 Feb 2023 21:09:06 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-qt1-x82f.google.com (mail-qt1-x82f.google.com [IPv6:2607:f8b0:4864:20::82f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PFKpV3YqZz4GBJ for ; Sun, 12 Feb 2023 21:09:06 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Authentication-Results: mx1.freebsd.org; none Received: by mail-qt1-x82f.google.com with SMTP id f10so11977303qtv.1 for ; Sun, 12 Feb 2023 13:09:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=H/VqqQqqtAbnEpGdzeUXSLEqpNj1jwY7elsY7gSSCiA=; b=gBO+JDd+c13AvVfR3dxYxA+r+vyPGQEl3d80vx8Fc8qEKnOZojHXZIxKMog/SI1f5w aIkYcVGTcW84tzy4PWG9zdl3w4u+tJScd5uHWFMiV21Kg26+dHc6iPyPAQ3uG4ulslql IuPgTE8aupkZyeGiX/jI6cHN1PnxV64w7z6HOb5xvERFO1H6ZMcKKZ9qGpXBOUyohC2F gZJqD7LEMN50KLxxHEq3Ffw5jmY3Yb6g2Dpig+0GsE5Ij8KNUWPKCya38zVqZiRvNGrz xxeqC5y9WMeU5xDms5j14LP4jE0OWKsh9WTtR8e9cFMUSD8fg3n1btiL5R+oJ00j0K/a sPkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=H/VqqQqqtAbnEpGdzeUXSLEqpNj1jwY7elsY7gSSCiA=; b=OFLBsIgIleJn6/t9fhCVTrBuYvc/YwkYls/tyTGa6QYYRZdQI3dUZAkfDm545mWI35 jZ+BHX9KGpbzx7f8JV1c3ARSAWk0LrdrNcfxbnhC0QgWISLkitKFhMu++VxexbhQeAEK jsND5ukaDFOl1Ro1bfwvbYon6jXHQBpBvDOHbRpvnW5FsVBR9c4jRNelOoo3aWGtd1BU 90xjOge//25fTsUFfv41239Egao7PQMzEHQjq36pkPTxTj4Ga5GTg7AH3nOh+DjcNCQ6 71cLYe5yAWgsDeyo677b3kO4pXhk4DAKnDpwP7KDDSH0kRdfQDFeuMjjs9kof7WJYacg DVAQ== X-Gm-Message-State: AO0yUKU+h9YfK4HthS23fpAmIHLLIGBwJc0S2/x8nk6dyoLs34tfZPiN SpzSriXSuSl2MadPD+miMgOhlg== X-Google-Smtp-Source: AK7set+HNKPdsSX4NfZwDiOqwv8JskxQuUh5pGCsLo7i2omCGvQIZfj7xktt1ctBwfV7gA5SBUrfoA== X-Received: by 2002:ac8:5fd3:0:b0:3b8:6930:ee6 with SMTP id k19-20020ac85fd3000000b003b869300ee6mr40052755qta.21.1676236145748; Sun, 12 Feb 2023 13:09:05 -0800 (PST) Received: from mutt-hbsd (pool-100-16-219-215.bltmmd.fios.verizon.net. [100.16.219.215]) by smtp.gmail.com with ESMTPSA id m190-20020a3758c7000000b0071d2cd07560sm8335906qkb.124.2023.02.12.13.09.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Feb 2023 13:09:05 -0800 (PST) Date: Sun, 12 Feb 2023 16:09:04 -0500 From: Shawn Webb To: Mark Millard Cc: FreeBSD Hackers , David Chisnall Subject: Re: CFT: snmalloc as libc malloc Message-ID: <20230212210904.nzxfwtzsjf2tu6ky@mutt-hbsd> X-Operating-System: FreeBSD mutt-hbsd 14.0-CURRENT-HBSD FreeBSD 14.0-CURRENT-HBSD X-PGP-Key: https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/blob/master/Shawn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc References: List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="utl62kziietstoa5" Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4PFKpV3YqZz4GBJ X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N --utl62kziietstoa5 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Feb 12, 2023 at 12:01:22PM -0800, Mark Millard wrote: > Shawn Webb wrote on > Date: Sun, 12 Feb 2023 19:44:24 UTC : >=20 > > On Sat, Feb 11, 2023 at 05:10:02PM +0000, David Chisnall wrote: > > > On 10 Feb 2023, at 16:23, Shawn Webb wro= te: > > > >=20 > > > > So I took a little bit of a different approach, which should provide > > > > the same end result as your submodule approach. Note that I'm doing > > > > this in HardenedBSD 14-CURRENT (the hardened/current/master branch). > > > >=20 > > > > 1. git cherry-pick -xs a5c83c69817d03943b8be982dd815c7e263d1a83 > > > > 2. git rm -f .gitmodules contrib/snmalloc > > > > 3. git commit > > > > 4. git subtree add -P contrib/snmalloc \ > > > > git@github.com:microsoft/snmalloc.git main > > > >=20 > > > > I believe this should leave me with a tree that populates > > > > contrib/snmalloc and pulls in your non-contrib/ changes, leading me= to > > > > end up in the same end state as your submodule approach. > > > >=20 > > > > I am seeing some build errors. I've uploaded a WITHOUT_CLEAN=3Dyes = log > > > > to: > > > >=20 > > > > https://hardenedbsd.org/~shawn/2023-02-10_snmalloc-01.log.txt > > > >=20 > > > > Note that this is with llvm 15.0.7 that just landed in FreeBSD main. > > >=20 > > > The error is a bit confusing, because nullptr_t has been in libc++ si= nce C++11. Does HardenedBSD change anything in include orders? Can you add = -v to the end of the compile command: > > >=20 > > >=20 > > > c++ -target x86_64-unknown-freebsd14.0 --sysroot=3D/usr/obj/data/src/= hardenedbsd/amd64.amd64/tmp -B/usr/obj/data/src/hardenedbsd/amd64.amd64/tmp= /usr/bin -fomit-frame-pointer -O2 -pipe -fno-common -DHARDENEDBSD -DNO__SCC= SID -DNO__RCSID -I/data/src/hardenedbsd/lib/libc/include -I/data/src/harden= edbsd/include -I/data/src/hardenedbsd/lib/libc/amd64 -DNLS -ftls-model=3Din= itial-exec -D__DBINTERFACE_PRIVATE -I/data/src/hardenedbsd/contrib/gdtoa -I= /data/src/hardenedbsd/contrib/libc-vis -DINET6 -I/usr/obj/data/src/hardened= bsd/amd64.amd64/lib/libc -I/data/src/hardenedbsd/lib/libc/resolv -D_ACL_PRI= VATE -DPOSIX_MISTAKE -I/data/src/hardenedbsd/lib/libmd -I/data/src/hardened= bsd/lib/libc/locale -DBROKEN_DES -DPORTMAP -DDES_BUILTIN -I/data/src/harden= edbsd/lib/libc/rpc -DWANT_HYPERV -DYP -DNS_CACHING -DSYMBOL_VERSIONING -g -= gz=3Dzlib -mretpoline -fPIC -flto -MD -MF.depend.malloc.o -MTmalloc.o -Wno-= format-zero-length -fstack-protector-strong -Wsystem-headers -Werror -Wall = -Wno-format-y2k -Wno-uninitialized -Wdate-time -Wno-empty-body -Wno-string-= plus-int -Wno-unused-const-variable -Wno-error=3Dunused-but-set-variable -W= no-error=3Darray-parameter -Wno-error=3Ddeprecated-non-prototype -Wno-error= =3Dunused-but-set-parameter -Wno-tautological-compare -Wno-unused-value -Wn= o-parentheses-equality -Wno-unused-function -Wno-enum-conversion -Wno-unuse= d-local-typedef -Wno-address-of-packed-member -Wno-switch -Wno-switch-enum = -Wno-knr-promoted-parameter -Qunused-arguments -I/data/src/hardenedbsd/lib/= libutil -I/data/src/hardenedbsd/lib/msun/amd64 -I/data/src/hardenedbsd/lib/= msun/x86 --include-directory-after /data/src/hardenedbsd/lib/msun/src -DHAR= DENEDBSD -I/data/src/hardenedbsd/contrib/snmalloc/src/snmalloc -std=3Dc++20= -mcx16 -fno-exceptions -fno-rtti -DSNMALLOC_USE_THREAD_CLEANUP -DSNMALLOC_= BOOTSTRAP_ALLOCATOR -DSNMALLOC_JEMALLOC3_EXPERIMENTAL -DSNMALLOC_JEMALLOC_N= ONSTANDARD -DSNMALLOC_PLATFORM_HAS_GETENTROPY -DSNMALLOC_STATIC_LIBRARY_PRE= FIX=3D__ -ftls-model=3Dinitial-exec -DSNMALLOC_CHECK_CLIENT -DSNMALLOC_FAIL= _FAST=3Dfalse -DNDEBUG -g -gz=3Dzlib -mretpoline -flto -Wno-c++11-extension= s -c /data/src/hardenedbsd/lib/libc/stdlib/snmalloc/malloc.cc -o malloc.o > > >=20 > > >=20 > > >=20 > > > That should dump the include paths. It=E2=80=99s possible that the li= bc++ headers are being included in the wrong order with respect to the C pa= ths? > >=20 > > Hey David, > >=20 > > HardenedBSD doesn't have any changes to userland that would cause > > changes in include header paths (and the priorities of them.) > >=20 > > I made sure to `pkg delete -g gcc\* binutils\*` before running another > > buildworld, ending up with the same error. > >=20 > > I tried running your command above. >=20 > He asked that you add a -v to it. Implicitly also: capture > and report the extra text that the -v causes in the output. >=20 > That extra text covers what the sequence of include paths > searched are in the order searched. It shows even the paths > for which nothing is/will-be found for the specific > compile: where all did the compiler look? Any unexpected > places? Any missing places? Any examples of not being in > the required order? >=20 > > Here's the result: > > http://ix.io/4nS9 >=20 > That does not include the extra text that would be generated > by having added the -v requested to that shown command line. > That tet would likely have been before the text that you did > include. >=20 > Did you add the -v option? Was there extra text? Good catch. I missed reading that. Here's the new output: http://ix.io/4nSy Thanks, --=20 Shawn Webb Cofounder / Security Engineer HardenedBSD https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/raw/master/Shawn_Webb/03A= 4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc --utl62kziietstoa5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAmPpVWoACgkQ/y5nonf4 4foQ2A//SHF+npe/6nRSwzTOPVAQjZXH6Xkfvdka6+qH3yVscNPRephxhmpyUEVb WfvaX27T6My4S7gSP4kJX4hltsqeLHszhX7a+MZFN1jORuKfndOPDIcNnkIWq22T 53Pwh49fEMQAUJVTw4NTZKKiHRYWXWCD39u6TLJPMI6c2sY0qfbvPjpy+YprWdso K8SXKCFTREVKg87SK+olgvlD+SgHiyQxTJcmVP2i5BUhnKZipeDkteI5zvMyqRTJ DCMLbjUCH+El6VA2qhBNbdT/0aAvjkcNoRHAioxw1MWO2CEHQ+MjoMT9Wit6ME8N 6MlYHsrtg46RSk7ipV2m8Ks4feiiGsF5qhzh/Ud4PlRV6Feif8N0cQ6xFpFBG4// RpqiKkx8tTXODSzwc0bFekhmL+cX9tC0KXo/QuIiNWX1soznNLK+Ne92mYIzvob2 kSNHJ/rA4ScHy2R+ZvJtnCrqZnF6GhoLbBew9aqLfVqGhOMaNdhOhombncaWcC0B 8zlO2TCY0UiZ6hQMiEywwncOCxSxfe+n2sGWbMHpW/zfDgZ5TDp0YT62Ev/BnrT1 zb0DOjHfQBgEVFikgkVtesldFZy2bJRrl2KECKLeEKxdJaVCMQ2vPj32wDMyV3nF Xpl3C1yJwGYYc8OFqcdwqeq4cx5UUglqQkb2YWPcbPlJ+bFnins= =GCtU -----END PGP SIGNATURE----- --utl62kziietstoa5-- From nobody Sun Feb 12 21:48:59 2023 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PFLhq0bydz3pBx6 for ; Sun, 12 Feb 2023 21:49:15 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic308-55.consmr.mail.gq1.yahoo.com (sonic308-55.consmr.mail.gq1.yahoo.com [98.137.68.31]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4PFLhp50FTz4PyK for ; Sun, 12 Feb 2023 21:49:14 +0000 (UTC) (envelope-from marklmi@yahoo.com) Authentication-Results: mx1.freebsd.org; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1676238552; bh=c7lG87VUSj/jQne6tC3wvyg/WV+hU/u77Zy5X2A76Jo=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From:Subject:Reply-To; b=O+aNWC2eXXbgmx4/+Sc4zIamKLWnBx6VA6kpKZLW7vS9e52o1qhVBMLGXGS9SdHkYzS2TauAzdDa5Y4zlmpHTI3+vKCSgI2tVPFGecX6vF4EzBch07bhPoEXSjTExdLzvJesHTKIFoisD3r3886kuNLp3wZ/GlxEGpmVqihpMvj+RdqZF26WZrHbcSlF4hUjEWPl3VyyChyibXBQ4TKgdiD2SJsxUdOPmnV03hq3ggQ1KVn1az1VNVgS2OEL8m+iBWWIWNn6E5J6ORRBUD/5Q3K4Gd9NpcGMBUbiNSpYGcuH5pP6HFabAcXAy0oAGkq+zucjYI6Z0S0vEHEcy1fFLQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1676238552; bh=4nc8w9VMM8uNt/r4YgG3Ki2BNJEj5ydAvHAxbGk08Rr=; h=X-Sonic-MF:Subject:From:Date:To:From:Subject; b=nYpL4PvnYP/IdFRCJc0UvmiODukm7kABhmkLz9BsCoJ2P88Ou+ed7G5TmmiY2S6Z6B+AFvpH/L8FTzYDje810Sajs6HbWl6XxqSWtMkJJE4lJh1UmC7lllPEQ6ic1iZMxdmd1CJfU43ZPfDeSTOcbYfu0fuCWca3EnI+zwC4Gq5Kdc55lEl8g1Hb1agwvr4x8ITv8utuInNbDbIveBlch9FtwH808I1gpDmbgguPTkIL0+f8awZK1CbYAfUfhn/1Wccba4xWjsmDpbzlebi98nrEPagZhaJq3LWEkbbPWBBJnMiKv2RZS5kvMa6XXBnQXUFf1lOTn1LeXUcRzn7RmA== X-YMail-OSG: CW6zhmAVM1k4hdGv2.Lmt8KC7vvbOTaYQ13FQATW2UW55o2vYjSM6ru5F0Zc175 ci2OX26KOByXMfJtxBRVQwHNN6P.U3v28Q9JB1Kbt6NZZ9wjRtTdlDhbrpKHTR_x2raoKomYibd. QA.cUPj7pkbNATUwzRwyFFh69LtDAe9mO8N2dh1j3G_8RFZpJuZXH.r0fPVo0sUYn0ETT8fnqsyY nxeu4zvQimGGzTgF0VdGfWR.yXttMCe7uP0DHwGx0gZntB3RJ906Dzbe3eCU5on0syiJTJDQUdV0 EtWQlW1faznuqEW3NeItdnCCBfZxQ8Sit9ar6Q9SkrgoOZDt0wTW0r7dIZNFz.VxwgYWSK45olDc FnwFrAXXttjm_HxLRfozTxx9S..pJUmsBIK4_NmHUqvdox7GZyyh3.7w7cV0J_.dcuuyYddEreyU Xn6svVzakvx0b.uLOpryH5bDSzHWl1J.c2mrHvl01KGLPBWjtxpOhyb1rXH0CmP4qIz9jw1UBNj3 9UURXm2ug68IGc9dOS_ncRVggVZRsghAo0Ixis9w5prUy_ewBMNMRK7r_vkNx4Jx7By7AN8.RmmX x226Jo3nnZjBB6CsyyAwXIPq9vdYLbe3bSzPXVqS0XwLFMzAxNBlIHzsGC7KpsI8dkmtkKWhZgOG vu2.kS06YUcBKgTjhCogvXw3uVAGfkzTcrtRTujBly__IECy6qPy_HHvqYC1aYPd05pdAxu2kVTB mGiBhx1E2CZG8fsLR3DYo8pkIhR609YGGUldqSgJfmbkg4ckK1EcUnNLo4wtNlA6nAMAT_gKepyH l_jK3jQC8f.ZjokrwFe6AhnpNoEfGK0UHs9Wmc9FkDQHBb8KT34mov16CVblXPVvBTR3uU_zLuCK fsSSuBl0ZT1UAGxraptgiqCxrPhXiwM6CBH0S.S92itJn2dTEf6XriCa_JTMsfQusnREoGANgbmi 3kFCemaaxlbhSdAcsTwPSb.tpSj._l.ZE7VVHCzyeEl1H4AWIPhHyUfCuPA9Tf8uDMtw4GAGn0Re .YKRcIrDeipzpR4Y3OxaIbZazy0s3HDrC1QLsxbwH9WNCfUrxFc_oWSmbGdSW8clmtpoz07Wowzh BnHkjFySM3PqBxQo.aPBN0mnp_bljnvUOAMrxru3.EDzXWwwKrYQLXAQuXJSlJfDggl4TkjxJ2lu 8CeFOYLLo6pFJ4NT7JUfvNXwNPmDk.UXt16xEDSAJQoRR4yEwGrSOgFF3Uax0LL8cmQpfriAvIqL 9bC70Dbe.PlkBVtjr1SsOUGyhQN0QB2qeB6dAszwjVCkMPIbnElsQH62aCcUIJP3tsAVc6dCnPT7 _vLvjryBEffRJZQ7AIDDXIo.ZisN80tO_OgDPpO4Az6FC7Y1gzy3PNPX9gu6BFHxqGfJcuHNbpOD mq_2Fd9mohFSZa41X.BG7cgLxRbTrXgBgVdgw7SnaNRN8zyvvn5Rt.6xvtOQPET91dRAOoZsc4Iv kWWZOi5D0bhH4R6jiVbEy0GKoeYAaBMT1uPt.7xnwt6Y0.aW0VJGoxP30cBHDDN12TUcTHtNIjVr FsuGv.U1YMHTvVaMamquXzRq1ZFtR.prHozh0eFzGJlir6yv5mdkOgpcHPaon9EjzYgEJyHEs.s4 xpzeBcNCssLkKFpublavdHJzGdVkCJlgwJ.buRQFXDiOS4RCrUOJ0QkWH4nygtJzOJBHvALqefGy lY3DYy99_pogv8.BfPKvzSuIr56ZgKatrxTZYYf.mDj0Hmo6QJzVmzUVSEykbpWS7bF5JTwx4NYA FYbAai92.UhpCb_3JSfj0rgLdq1X.fQ9e9ziqc.XVd.eAAiDqpXdEh5bEFkz4pRYRxg7Ndr7UaFM 3Fps..PeE0IYVLtiD_vkH06PafKI5p5b3K8Br_8KIgXYeHySo4gTKk1sxPDuyifii1gPwvLqkcvz rrvMkfgOZtVL0.QI5ECjFbuIgwf9xmf2qVN7YNeu.zoaXTFkURvKfYK6Z1TyqJRWO_HGjgUpaIhy DlM0lIQXbItI9jdozEVuod7JJ0P0vM1IVN8GryTW_LXyAyBSnv0AYY0cyYzCcRnA4uOgyNeXlXMo PSKIID361VEoxmvRoXHXGYtSpNiHWNZPSZ2lnwg_SSJSn1iyNpsgsq_hDMexR63gNAdyFhAJGwlu fxsgpEyuCCEa8PQsbs86EMPxH3qr46p_2fJop2.owqipNAaEBDm7Yqha4T85_WdQvpSgTR2qJgLI bZLzfx40eoGoDO.e2DpcB_yWeOWGEgQKEdMGKcg6e947N0UMyvnByp38yUMXkAG_arIlbotmcDhj A2f4- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic308.consmr.mail.gq1.yahoo.com with HTTP; Sun, 12 Feb 2023 21:49:12 +0000 Received: by hermes--production-gq1-655ddccc9-9lt6n (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID c945023b7be092fd8d7fea417411153b; Sun, 12 Feb 2023 21:49:10 +0000 (UTC) Content-Type: text/plain; charset=us-ascii List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.300.101.1.3\)) Subject: Re: CFT: snmalloc as libc malloc From: Mark Millard In-Reply-To: <20230212210904.nzxfwtzsjf2tu6ky@mutt-hbsd> Date: Sun, 12 Feb 2023 13:48:59 -0800 Cc: FreeBSD Hackers , David Chisnall Content-Transfer-Encoding: 7bit Message-Id: References: <20230212210904.nzxfwtzsjf2tu6ky@mutt-hbsd> To: Shawn Webb X-Mailer: Apple Mail (2.3731.300.101.1.3) X-Rspamd-Queue-Id: 4PFLhp50FTz4PyK X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/20, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On Feb 12, 2023, at 13:09, Shawn Webb wrote: > . . . > That does not include the extra text that would be generated > by having added the -v requested to that shown command line. > That tet would likely have been before the text that you did > include. > > Did you add the -v option? Was there extra text? Good catch. I missed reading that. Here's the new output: http://ix.io/4nSy Hmm. Scanning that list . . . #include "..." search starts here: #include <...> search starts here: /data/src/hardenedbsd/lib/libc/include /data/src/hardenedbsd/include The above likely includes a non-C++: stddef.h That likely overrides any: . . ./include/c++/v1/stddef.h that is required for things to work for the nullptr_t issue. (See prior E-mail from when I noticed that I'd missed the include/c++/v1/stddef.h involved.) /data/src/hardenedbsd/lib/libc/amd64 /data/src/hardenedbsd/contrib/gdtoa /data/src/hardenedbsd/contrib/libc-vis /usr/obj/data/src/hardenedbsd/amd64.amd64/lib/libc /data/src/hardenedbsd/lib/libc/resolv /data/src/hardenedbsd/lib/libmd /data/src/hardenedbsd/lib/libc/locale /data/src/hardenedbsd/lib/libc/rpc /data/src/hardenedbsd/lib/libutil /data/src/hardenedbsd/lib/msun/amd64 /data/src/hardenedbsd/lib/msun/x86 /data/src/hardenedbsd/contrib/snmalloc/src/snmalloc /usr/obj/data/src/hardenedbsd/amd64.amd64/tmp/usr/include/c++/v1 The above looks to be the first/only chance to pick up a C++ based file header (that may in turn look for a C based one as well). /usr/lib/clang/15.0.7/include /usr/obj/data/src/hardenedbsd/amd64.amd64/tmp/usr/include /data/src/hardenedbsd/lib/msun/src End of search list. The ordering does not look anything like correct to me relative to C++ headers, some of which in turn may include the C variants from the environment. It is not so clear to me what the relationship is to the source_location file issue. === Mark Millard marklmi at yahoo.com From nobody Sun Feb 12 21:57:18 2023 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PFLtN1vp9z3pD24 for ; Sun, 12 Feb 2023 21:57:32 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PFLtM20Hpz4S0Y for ; Sun, 12 Feb 2023 21:57:31 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20210112.gappssmtp.com header.s=20210112 header.b="JmW62/zl"; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2a00:1450:4864:20::62f) smtp.mailfrom=wlosh@bsdimp.com; dmarc=none Received: by mail-ej1-x62f.google.com with SMTP id jg8so27618556ejc.6 for ; Sun, 12 Feb 2023 13:57:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=wM+iVltsyptxrxlwDVVr5Gki4XlZaBJm3EZkqsj9CUI=; b=JmW62/zlVB7KfGkzoxQezB354wuL/ah8EdSgaSajti/2BkfHvEaJ9xj6Dct39sGMbL bXmVYS8ZsJnPE8HD6dplxSpGelL5d2qPwkYM1DsQ+XthKZpt5PGVh63+yRA3lz1P3tuE lEN3jfvvsennfQVo61QAdUZrZjBp5K27wsvTDz1YN/e8ajwh7XIC0WhZ1PAhPzNyKh8g +FXiSEcPkYTpNl7xiqX1LMXAYC5XZGCQvHrJW3S361QC2+3IbEshPqFyegaOQNk3FB7u e6AH57Nc5Gl/mooBmPEMff9GVqB5zrGcN1w8CcXQYVhv+QB4QXrwJes9wLsoiIY1voPe UFig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wM+iVltsyptxrxlwDVVr5Gki4XlZaBJm3EZkqsj9CUI=; b=jktK5Ppog0AcsEGOdDqeRZQ2yFOAkzMdHe86kCndg99pT/3zzykSCgYy3eLmTuza0p CcpPKmga05UCLD4S0WLjwc6lUGKDvCY1duCp+/XiDWWGbG0B/XutorOHilzeL1EhArwO 2WecsI2YvLjMPO2UqnNcOqiws8GlW12t+440irIzc+KQi5QLHMpoCtB+8sUzcACl2teu jm/jJ/Q9WKKedV2MBF1bGh6QkLOqDQdynSocKIwcSFdt1nyynpssaXec0jKhlI5m3Ud5 rJ5wfAkTp99czpGwgeS+GKYF69Thw0XDWgQkc2tQ4nK18dMSBfgKeSxh1Ab2OVcwkSu/ Tf3g== X-Gm-Message-State: AO0yUKXF6jAZU/1RSYDozpx/rH3fM3kdTxZmPpYqwn8sVEt0Is9bXdSJ Hv9K6T5tCqbMhy5lBLi4ot/vUCBQfCZC7wIccOEk2g== X-Google-Smtp-Source: AK7set/19y5yJBmKa/4tF/jUcmElHbckfI0aW1N3o37JpEohoPWEwEum8/mTC80Q33TaQ5cPd0G5vaoBWMfbWlOaD7M= X-Received: by 2002:a17:906:fc26:b0:8b0:7c88:e86b with SMTP id ov38-20020a170906fc2600b008b07c88e86bmr1823254ejb.2.1676239049324; Sun, 12 Feb 2023 13:57:29 -0800 (PST) List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org MIME-Version: 1.0 References: <2f3dcda0-5135-290a-2dff-683b2e9fe271@FreeBSD.org> In-Reply-To: From: Warner Losh Date: Sun, 12 Feb 2023 14:57:18 -0700 Message-ID: Subject: Re: CFT: snmalloc as libc malloc To: David Chisnall Cc: Mateusz Guzik , freebsd-hackers Content-Type: multipart/alternative; boundary="000000000000180d5005f487d157" X-Spamd-Result: default: False [-2.75 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.75)[-0.750]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20210112.gappssmtp.com:s=20210112]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; MLMMJ_DEST(0.00)[freebsd-hackers@freebsd.org]; R_SPF_NA(0.00)[no SPF record]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ARC_NA(0.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; RCVD_TLS_LAST(0.00)[]; FREEMAIL_CC(0.00)[gmail.com,freebsd.org]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::62f:from]; DKIM_TRACE(0.00)[bsdimp-com.20210112.gappssmtp.com:+]; TO_DN_ALL(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; FROM_HAS_DN(0.00)[]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; PREVIOUSLY_DELIVERED(0.00)[freebsd-hackers@freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DMARC_NA(0.00)[bsdimp.com]; RCVD_COUNT_TWO(0.00)[2] X-Rspamd-Queue-Id: 4PFLtM20Hpz4S0Y X-Spamd-Bar: -- X-ThisMailContainsUnwantedMimeParts: N --000000000000180d5005f487d157 Content-Type: text/plain; charset="UTF-8" David, Thanks for replying. I do appreciate the offer to help work out a proposal for submodules. That would be quite useful. Technology has improved in the almost 5 years now since we looked at submodules for the first time. Many of your criticisms have some merit. There's not currently a formal working group. I walked away from it because there weren't enough people at the time that wanted to do work and some rather unfortunate comments from some other people (so bad I contemplated leaving the project)... Now that I've mostly recovered from that experience, I've started a more modest pull-request experiment... Moving to submodules is a big project, bigger than I can take on leading at the moment. And about my snarkiness... This is still a very sore spot with me, and so I responded to you with more snarkiness than you deserved. I'd like to apologise for that. I'm sorry. I'd love to have your input on this, but first we'd need to find someone to project manage things... Warner --000000000000180d5005f487d157 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
David,

Thanks=C2=A0for reply= ing. I do appreciate the offer to help work out a proposal for submodules. = That would be quite useful. Technology has improved in the almost 5 years n= ow since we looked at submodules for the first time.=C2=A0 Many of your cri= ticisms have some merit.

There's not currently= a formal working group. I walked away from it because=C2=A0there weren'= ;t enough people at the time that wanted to do work and some rather unfortu= nate comments from some other people (so bad I contemplated leaving the pro= ject)... Now that I've mostly recovered from that experience, I've = started a more modest pull-request experiment... Moving=C2=A0to submodules = is a big project, bigger than I can take on leading at the moment.

And about my snarkiness... This is still a very sore spot = with me, and so I responded to you with more snarkiness than you deserved. = I'd like to apologise for that. I'm sorry.

I'd love to have your input on this, but first we'd need to find s= omeone to project manage things...

Warner
--000000000000180d5005f487d157-- From nobody Sun Feb 12 22:24:56 2023 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PFMV319ZMz3pGvh for ; Sun, 12 Feb 2023 22:24:59 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-qv1-xf2c.google.com (mail-qv1-xf2c.google.com [IPv6:2607:f8b0:4864:20::f2c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PFMV26ddDz4Y9v for ; Sun, 12 Feb 2023 22:24:58 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Authentication-Results: mx1.freebsd.org; none Received: by mail-qv1-xf2c.google.com with SMTP id di14so3099322qvb.12 for ; Sun, 12 Feb 2023 14:24:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=evYaWfe2/4QDxWqf3EGi4TuI8yTDDsQtNpKeNVQbSxE=; b=hA4A9tB0oMpNX3LpWl/+HTGLV9Iev1MAclPC2iZy5oN7YbH8+k2gWrVGNCr/mbY72+ 0KlJDonSfxLQQdYfNd9mrI5FWEx3eq9eDCi2qzzOoAh95mLOA1pL6abX/OpdOuGevqMD 5V45fM5sQsIaXjlJ5XUFedhelHTqMHyc/rdVXgLXB/RK2FowO1rlv7YcHWrdqzf9fc/U jlmNQ+VAXf0xycujS9Rny/18nbMkPBhwHj+oOHsGe8Wow7/Ocknx9c/oblq3gg7x/DDS kfhl2HwHiUOzXfBWSjUrdmt65EW6pUcu/QkiymBrlrqhT5YEtmkOKJviF7VebPGjRq8Y dEdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=evYaWfe2/4QDxWqf3EGi4TuI8yTDDsQtNpKeNVQbSxE=; b=wrkJLZ2H3LxiLWIxbq+5bgFyVPDBJNajbvKe+TRFO2BZHszqM2SfxGolofu/79y6V4 ERwISjPkaDqEnE3dZw4ugywy7b/6LPERZcGHHBhph68pzM2Hst2oOVeJLJFm7ZLlr4y/ XAZEYHQhp1Q42VycALUMZyBIDfi7Q9uDoaiVNi2BD7GmmItRO3+TFFd+FXlHSIpmmP5C 0uboBT80BZh97sQKCP8qBAr2dLt5VZqoVFvF4w+7h1Q8QAlBRklTmOHZc/FOaE52nss1 ANM3osROWWsOlASbhPazKu90LUwZ2kCjohwYqhBkF5I0i0ki03j/MUwTuaK5uZetEpKy YLxg== X-Gm-Message-State: AO0yUKXttUE+92d0IjJgjUFI/BFV5GNH3TkQxGKIodZFN4/v2V/do8Zo XxghANDm8H8EC5DTY6xV32BN6A== X-Google-Smtp-Source: AK7set/NlRRT2thu22oo1zA85LODxArfXyOLPCIJv44Nxf+iu712blTDY5trjsAXAlyn/3unBCtQ/A== X-Received: by 2002:a05:6214:230e:b0:53c:f76f:2e3c with SMTP id gc14-20020a056214230e00b0053cf76f2e3cmr44042190qvb.46.1676240697892; Sun, 12 Feb 2023 14:24:57 -0800 (PST) Received: from mutt-hbsd (pool-100-16-219-215.bltmmd.fios.verizon.net. [100.16.219.215]) by smtp.gmail.com with ESMTPSA id fu48-20020a05622a5db000b003b63a734434sm8028038qtb.52.2023.02.12.14.24.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Feb 2023 14:24:57 -0800 (PST) Date: Sun, 12 Feb 2023 17:24:56 -0500 From: Shawn Webb To: Mark Millard Cc: FreeBSD Hackers , David Chisnall Subject: Re: CFT: snmalloc as libc malloc Message-ID: <20230212222456.2vcvgf6v45na7jb2@mutt-hbsd> X-Operating-System: FreeBSD mutt-hbsd 14.0-CURRENT-HBSD FreeBSD 14.0-CURRENT-HBSD X-PGP-Key: https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/blob/master/Shawn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc References: <20230212210904.nzxfwtzsjf2tu6ky@mutt-hbsd> List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="zj3c7escvk6siqap" Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4PFMV26ddDz4Y9v X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N --zj3c7escvk6siqap Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Feb 12, 2023 at 01:48:59PM -0800, Mark Millard wrote: > On Feb 12, 2023, at 13:09, Shawn Webb wrote: >=20 > > . . . > > That does not include the extra text that would be generated > > by having added the -v requested to that shown command line. > > That tet would likely have been before the text that you did > > include. > >=20 > > Did you add the -v option? Was there extra text? >=20 > Good catch. I missed reading that. Here's the new output: > http://ix.io/4nSy >=20 > Hmm. Scanning that list . . . >=20 > #include "..." search starts here: > #include <...> search starts here: > /data/src/hardenedbsd/lib/libc/include > /data/src/hardenedbsd/include >=20 > The above likely includes a non-C++: stddef.h > That likely overrides any: . . ./include/c++/v1/stddef.h > that is required for things to work for the > nullptr_t issue. (See prior E-mail from when > I noticed that I'd missed the include/c++/v1/stddef.h > involved.) >=20 > /data/src/hardenedbsd/lib/libc/amd64 > /data/src/hardenedbsd/contrib/gdtoa > /data/src/hardenedbsd/contrib/libc-vis > /usr/obj/data/src/hardenedbsd/amd64.amd64/lib/libc > /data/src/hardenedbsd/lib/libc/resolv > /data/src/hardenedbsd/lib/libmd > /data/src/hardenedbsd/lib/libc/locale > /data/src/hardenedbsd/lib/libc/rpc > /data/src/hardenedbsd/lib/libutil > /data/src/hardenedbsd/lib/msun/amd64 > /data/src/hardenedbsd/lib/msun/x86 > /data/src/hardenedbsd/contrib/snmalloc/src/snmalloc > /usr/obj/data/src/hardenedbsd/amd64.amd64/tmp/usr/include/c++/v1 >=20 > The above looks to be the first/only chance to pick > up a C++ based file header (that may in turn look > for a C based one as well). >=20 > /usr/lib/clang/15.0.7/include > /usr/obj/data/src/hardenedbsd/amd64.amd64/tmp/usr/include > /data/src/hardenedbsd/lib/msun/src > End of search list. >=20 > The ordering does not look anything like correct > to me relative to C++ headers, some of which in > turn may include the C variants from the environment. >=20 > It is not so clear to me what the relationship is > to the source_location file issue. Also: find /data/src/hardenedbsd -iname '*source_location*' ^ that returns zero results. Are we ("we" being both FreeBSD and HardenedBSD) completely missing a header file somewhere? Thanks, --=20 Shawn Webb Cofounder / Security Engineer HardenedBSD https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/raw/master/Shawn_Webb/03A= 4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc --zj3c7escvk6siqap Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAmPpZzIACgkQ/y5nonf4 4fpmgA//UHRDMqZEhyc5EKTdOdsHpr8MFMHHURLGbjCDwa0V8Lukx3UdUxSThCIl 0efR1dq/CWtDv1JL3eZWEYEO1FWOdczKXjFl/IEHihb4XnoLlwN28S1nCgTE2ofH 1Ky1AGwTQjpOWxQDDp1wCmueGu9hyvzmw+OsLmygFGpqpkAdTKL+l1xJvOe4UPZY 7hHXSRWVzsVFXWWN5lZPGmKnlSq/EDTKfgqxRIFJSuLkrpyNgcWM/JuY1LGMuFCr x/ZfOGeSpJ94DINTDJl90ex2lfK9AxDGMdEGmwcRz5PLC5qgo418bac1lc0o/Ebh yRwaUFsaF5olE+Z0x0NnMfQRwtx5KCzRWoinmzi1lHqZhU4pOzjkw5Oj2b+/HOT1 B0IVh+Hdwd/LbsDOUPGWeV/2OFXe/Kwl//nFQKrZ0feykxIGLqSUfvSbPMkb54kl NDdwBG5Rg3/i/yyGH/hwNFfYxVExa0My5K1tvGzCLCqO9VVzOJ9CRUWytCtKXiRx mFvNhILqTvkpe7qYRdCw2NqMv8242c9n7rUktYEkptbyj4fNwHVl6g9VQjg5FvZi k7VaQ4QPuBzjwvaIH+5g14t93APkKJF9ogC7HM1UwZFTgtIMKDOkTFcYcQK/ersD qK3bkc9rF5u8K/oxkPhIwa1MlG9T7ni4Bd7HPBfyb00L6dBD74w= =ksva -----END PGP SIGNATURE----- --zj3c7escvk6siqap-- From nobody Sun Feb 12 22:32:56 2023 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PFMgd3kyBz3pHn1 for ; Sun, 12 Feb 2023 22:33:17 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic307-8.consmr.mail.gq1.yahoo.com (sonic307-8.consmr.mail.gq1.yahoo.com [98.137.64.32]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4PFMgc2sFFz4bGm for ; Sun, 12 Feb 2023 22:33:16 +0000 (UTC) (envelope-from marklmi@yahoo.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=yahoo.com header.s=s2048 header.b=qgb37POZ; spf=pass (mx1.freebsd.org: domain of marklmi@yahoo.com designates 98.137.64.32 as permitted sender) smtp.mailfrom=marklmi@yahoo.com; dmarc=pass (policy=reject) header.from=yahoo.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1676241194; bh=HA0HMe4cu7foEnXH9e39Bzyadm96SAcnCMIcMHXs5PA=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From:Subject:Reply-To; b=qgb37POZYSbGEhsNWBhtf7k239h8N2IpVjZOXjm1Bkfwxy6PaWfhQL/8WzKC7L9JRbLJvf+4X1v1FfSpRaOsSPIZjamQlywi6sGUg3zrf/MOkFsYT3n0qwt8fIkSq2poDm7MK2InZ2PTYOlIxKwMRaWa0m3/RL154slPvGP3IST4sn3u+CF3MbbtNYT7k2HHyynoA8enJy5kHsC1t+XLKkGldmNNUyycORK7H/v7Q+d44yaC32wxuEK4+IjoQ/cTMeC6NU11qPLobWf7M0mb0i85AYZogEhG7KfshIW1+Y7+o4xClAwgRYAiTspvrwQniBZtNTQxrpvx45VrTEbS0A== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1676241194; bh=tKJpnnHkEUwv1RpsLQ3LZIZZgUg68VHPCVroH939amc=; h=X-Sonic-MF:Subject:From:Date:To:From:Subject; b=k+OhPKI1by0I5s8w1/jpwZXI2MPatChr2iflFK9adIhp6DDxyT/GSEjwkQTBWttm61day4nFbR/hjAtWYTjTy32W+FyKZUujhI7yz9VHb9ayKPz8i7rAA5SEnD3CnqhWJMm6crC/ZyYeaWXLahqIo+KY2JaYv2QWVqssgyTs4BzxX2548r+DzYEiq9OW0GjUAe7L7PErQNg4OHXubXmwwjsGrsQ+Ec4rUgyPJMTOF6XZohIip8TDbSE7hMSazUvHpbtakGP7qTw4wlw+JBnBMS3IYMNPjWFHWyzEVLpmDDUUtw+yZzfqbpTAUc+9UAXK7EQer8FDQ7jOGwXyTyMepw== X-YMail-OSG: gDawvxEVM1mprG4O1GU1ZmfdICsVLImsXI.eDL7Cgnwvnhmp86d.NpwQsQbjoX6 E34XOAAXmUpTjzTlNcw63TnxpCbCMRKg.1Gyhku7KxEfygV7tpnen6NByKoeChkiY3dyGzJ4cV2B ZGJpDyJqBooiKdqi0Zsu73FAe33DZ_NdjZCpJfZ.DZzB.dNta5ek6ZC5sxAaiSHdS_VMciwK2G7m xxOGdekwySEln1ANGGAKBXLz9gvDUyhRz6bl4O5RhSUWrOFv.BFhjamPzXWXEukUutEtINABRIST aN1XhHBy_i1EV6zyAitH6r9j7P4ZJD1EJf4FMR5MC3d6MlWAXQpGOs2WCW3hB8O5HIG.9492Ja2h kHwERvjiqAwvqib7EkgkdtiqsoAwjl.VmlWhH7xHDgwBAgmMVSW1Q.VMdFtkbiE_rGKaKaJq2QwM mQwi5Qexb2XWay6iEhm8C8LmRHAkWBRVPuxEUFrAT1vPl_qmhz3gQZwxt0mdpq0gjg2Ez9iAtFx2 TdKIGw38lnaluAZjoJ0qkI9ehfLxKJjF.lGXj_OUa7fzqePu3g9P7yvQTRCXt5D01WqqLqheE9NV fbWuP4fs0AnkK5QhnlN1KssnWlxtmv6HnEt52dJ44JqiBqlzokqXNzTF0FE_knHAR8Cr7YvYBG9V hofj45VzFSAWkb5TmomNgpI8QlLIKGTX.udBQbJ_tl6VZeQ8bdsfxYcHgJioJ.kxt42Gati8YA2C Fv5lCieasXUQsVYntm0cL_rglKu4fo9AfrcepEcFYX.bUkV8W8b5otq9NOcdgoxGNoqYmwSL.unR tvF5bq8_YZVCUdyrH3kJdUTTH_KKdKhqMlziCC0HHPnflfwwe4CuwGuaHzPHZdFIS7_HdnRUUS09 8hQHpUMwBdqhug1Y6xlkQmRd9MhNM.id7g0bTt7SlQtq1mnf6GHfiTSd56vWw..fy.HxnVOx2cKA fQ_x6.v3ma7qsX_GsS_C2xzjW3OBjWTArP0sZRGORg2UwzK45Mxyar4muZvVzPQSF5YWV7d2fzve 60LYn2GzoOPeYDL8O0P.FXep8eg25R19jLWy_IBDlKAD5uuNVvJn3xwuuTStozizFzjcvZKkDEGl sGIRrt4A5TGnHQfwcTv4cs1a4Jx.c6nTYs1OslG2j5ERAwP3Wu0xKFDnRUKlAJrBUf9IIRBw6uUe wnWudhw3BLzhU.yGn2XABmtibAOt.o6JpM.pE.OBDeDFz0ruvT9yR.DU3JEdedK1XOtpZlC4TUG5 OIC836oJ8dyKxqMHKXvHTy92Y0npFlZDsxXZIHx2lqhtkzMKnjsvaszBhSEmN3xIDGnEUKbVpYwq KfeCnfnaqdo4vDFLSv6FQ46lORnyokU6H2ruU9TzLE7epQmGf1YcawrZaQn.xSLfqxZxv50ZPpvI ExZjG_KMLX0eHyjuoPu5ORdjSdkk.l_wHxQC.DvKxHH8s48j.rJvu1JRjVuzPPYZYHSn8GDJelt_ VZ4PrdosPJURb6uGOnE4YkxxY_1QU00k4Mam.7jHuSBsnX1xDEUr61H1Xa1X88HCFLQJ8kqGNnep EEQcCa_ea3W9gLcYvoYcRNN2TR2ZxjzKZhNpY2lJSDS9y2txlIqcbzX2JFISvl3QkP1Tk9B_gVtR _a0caPdM_4jUk9lBR5Js0i3KQeZr7zqngK7yqeB4zKi2YCCRqHNLc1_DvPsGybkE5F7M.FGUwlm0 kzBBfu_YC_Zoa1Iif9mCqXeteevkBODkbhkPSDq5aOPYeVVIA4i4W9ZKK03Qi6RWL7sjSiB_5JSB .RVVWgY6TYOmtgyyZruSOqqffJ3xnQDntZHTpURw43bg8tcS_NHZ4QXJnzFub7Cf4ronxh5glinS CDGlYqrf3ezEPtlnTOFI50WJiJjUu6L.YaKjRnzuyUCaGM_lI.hDQQtgdtHjyuLLCWM0_v3._84h uAa1.gObiiN9X2FmSPdOxD3PF3VmYyKaSuGazp0ggZWNsSYkhrx77fhsB.znbJWKkaN7fR0xfTB6 IrYbKUNn05htmAsKDV6TyRf_AXw4rSQCAFTTUTmA0yHXLakeioOCQ0HjS5kTGQYVFSnjVcwxCdHY M134mBCGTQyllGG0fHjLNfjB0J66rdA8DENOFv9uAv6wu1EF1gLDy7HsgwwxGf4cgLZLtb7swH2G yTONJbrdqhAgEkGitA0VjrZtWf0N9pV74RIS2RevfzurjfkC7BMD_qcmRbCixmIgj8Xb9FmRluyK .NAJG2zl10QSh1J.UAphQlkeC1vLn.i4MaaJLyVT63ppudy_XcpU3iOiiT9m_KJoctAOCujg5S_P Zwdw- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.gq1.yahoo.com with HTTP; Sun, 12 Feb 2023 22:33:14 +0000 Received: by hermes--production-bf1-57c96c66f6-76kbw (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID fd2c24f4073e1e2418c3de148e2ac47a; Sun, 12 Feb 2023 22:33:08 +0000 (UTC) Content-Type: text/plain; charset=us-ascii List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.300.101.1.3\)) Subject: Re: CFT: snmalloc as libc malloc From: Mark Millard In-Reply-To: Date: Sun, 12 Feb 2023 14:32:56 -0800 Cc: FreeBSD Hackers , David Chisnall Content-Transfer-Encoding: 7bit Message-Id: <0F63E50F-C0DF-48C4-81A0-6EEF46C9C397@yahoo.com> References: <20230212210904.nzxfwtzsjf2tu6ky@mutt-hbsd> To: Shawn Webb X-Mailer: Apple Mail (2.3731.300.101.1.3) X-Spamd-Result: default: False [-3.38 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.88)[-0.878]; MV_CASE(0.50)[]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; MIME_GOOD(-0.10)[text/plain]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; ARC_NA(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[98.137.64.32:from]; DWL_DNSWL_NONE(0.00)[yahoo.com:dkim]; RCVD_TLS_LAST(0.00)[]; MLMMJ_DEST(0.00)[freebsd-hackers@freebsd.org]; TO_DN_ALL(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; FREEMAIL_FROM(0.00)[yahoo.com]; MID_RHS_MATCH_FROM(0.00)[]; DKIM_TRACE(0.00)[yahoo.com:+]; MIME_TRACE(0.00)[0:+]; FROM_EQ_ENVFROM(0.00)[]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/20, country:US]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[98.137.64.32:from] X-Rspamd-Queue-Id: 4PFMgc2sFFz4bGm X-Spamd-Bar: --- X-ThisMailContainsUnwantedMimeParts: N [Just making my notes more complete, mentioning the C++ use of #include_next and the ordering implication for include/c++/v1 vs. where the normal C headers are in the search list (for C headers that C++ tries to use).] On Feb 12, 2023, at 13:48, Mark Millard wrote: > On Feb 12, 2023, at 13:09, Shawn Webb wrote: > >> . . . >> That does not include the extra text that would be generated >> by having added the -v requested to that shown command line. >> That tet would likely have been before the text that you did >> include. >> >> Did you add the -v option? Was there extra text? > > Good catch. I missed reading that. Here's the new output: > http://ix.io/4nSy > > Hmm. Scanning that list . . . > > #include "..." search starts here: > #include <...> search starts here: > /data/src/hardenedbsd/lib/libc/include > /data/src/hardenedbsd/include > > The above likely includes a non-C++: stddef.h > That likely overrides any: . . ./include/c++/v1/stddef.h > that is required for things to work for the > nullptr_t issue. (See prior E-mail from when > I noticed that I'd missed the include/c++/v1/stddef.h > involved.) > > /data/src/hardenedbsd/lib/libc/amd64 > /data/src/hardenedbsd/contrib/gdtoa > /data/src/hardenedbsd/contrib/libc-vis > /usr/obj/data/src/hardenedbsd/amd64.amd64/lib/libc > /data/src/hardenedbsd/lib/libc/resolv > /data/src/hardenedbsd/lib/libmd > /data/src/hardenedbsd/lib/libc/locale > /data/src/hardenedbsd/lib/libc/rpc > /data/src/hardenedbsd/lib/libutil > /data/src/hardenedbsd/lib/msun/amd64 > /data/src/hardenedbsd/lib/msun/x86 > /data/src/hardenedbsd/contrib/snmalloc/src/snmalloc > /usr/obj/data/src/hardenedbsd/amd64.amd64/tmp/usr/include/c++/v1 > > The above looks to be the first/only chance to pick > up a C++ based file header (that may in turn look > for a C based one as well). > > /usr/lib/clang/15.0.7/include > /usr/obj/data/src/hardenedbsd/amd64.amd64/tmp/usr/include > /data/src/hardenedbsd/lib/msun/src > End of search list. > > The ordering does not look anything like correct > to me relative to C++ headers, some of which in > turn may include the C variants from the environment. I'll note that include/c++/v1/stddef.h uses: #include_next That in turn causes a stddef.h to be found that is from later in the search list (not earlier or the same file again). As for the include ordering, this leads to . . ./include/c++/v1 needing to be before the directory for the matching normal C header(s) that C++ is(are) trying to include. There are implications for recursive include handling during #include_next processing (just the tail of the search list is used as I understand). > It is not so clear to me what the relationship is > to the source_location file issue. === Mark Millard marklmi at yahoo.com From nobody Sun Feb 12 22:36:41 2023 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PFMls5MzNz3pJHY for ; Sun, 12 Feb 2023 22:36:57 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic305-21.consmr.mail.gq1.yahoo.com (sonic305-21.consmr.mail.gq1.yahoo.com [98.137.64.84]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4PFMls30Wsz4c7s for ; Sun, 12 Feb 2023 22:36:57 +0000 (UTC) (envelope-from marklmi@yahoo.com) Authentication-Results: mx1.freebsd.org; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1676241415; bh=Dx+vuj9RUA8Aul1MvqxJzbrFibFzwl9ePqqJfPeLKDI=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From:Subject:Reply-To; b=Mwj6suDkJJVECLMY7h2PUDqtOil1e0wHs1Lmghds42f3DzPyscQAjIPI3jY0mDT0Tv6lN4T9MugW0h1aa5T7km1o/lZTWlPJ0qOPWqhxdnrTGyu+ujsAcJQ3XX9E4BGIuCCnSiw6DWzrdgopCUnYIUrniLPbrUKQ/n7/A73jeUZNGaD3ff3yrBsSmv0P2mZTWqg3qHmCNxAskJ7yV4FK39RcFUA2/MIDwDF+9B5pNg+BWoFMUuX2hkHnrlA0jILvQaAMnLP9dJ2HA7jsyqFlD+pEaXf1ZnQ91E+L49FVT0kwO+VjQ7Dkxzisa63siNBQmDvyf7zdzgKbX+cEvUNwsA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1676241415; bh=hZzcx+5nHMDUQ1QfaksIg7uNfsYZJJM4yAm5+D+4tky=; h=X-Sonic-MF:Subject:From:Date:To:From:Subject; b=V79oQpyWRoR+9XL7+c1fFO0sVx+em3nuY8dNza4mb0XbJxcXU49lhs9KcvU1qg9ahBf462g8xCxzz0CsXPgjMdYwpfoag1/Sxp7Nnw50KIWk2ObsOZtusPBAc05YZaP14ex5iF9z4IRaieuwWAmdPpQZRv2JYq1B6LtchYfI9OOyOQgLEITqNOnAzTdGHVa6yR7dkxf267U4V2tRmw/vaUXOc2aCzQ9pmYmJO+/hKuMil9BnsiQbWZ4MGbi425n5fCrxrauyjMeYgDxl8VvQFrQUdDM9rlDBlG+Xvi2GcG/EmznJZgZkJ/+SdwY1vnJlbjRNQ5ytYq1tt5l0SbI3pg== X-YMail-OSG: Oy1WpKMVM1lLPZ9D.7aTdmKGAT5hHZaC4.KBRSdMNUgUc7GuPfix5vU2987eGHF ZgzdIxM64YHrzPydvou.ykfGsylVvQqeMWIPCehywybqv437RpS.WyBbqqmgdd8qqvooyAma25rb DMhqzg8H.AxFB5aCGayfJkZgSTmMCnL2HF4Mqkkvhaj0z5_0BpTI5bYyqvn1l3uG4lc5azJ2wVnw R2p1qak2js9RoNzqwwo8VAGxbl7dMvZDtASeqHh8IiUxxzpZtf4m5_9edTtyZzluMM9Dp2A7qXzh SqjYTrnFY.go0J560jSMjqUU.K9zKtfKNuEmr6EFA3x9QVOLo8S00fENO6eI5rERTjqW4rQBGKlR ycfCqfVfV7OqJlFi5medNYNUVj5JP5JQ0V706Vm7.EjoaS5mLNLoS9hEpvk4A6o1VdpvCTtFgzqC SCxB2xZeeg0QcM5Lz7LRPmkQfoVObhJE2iqXbh8NvTBtCOWoerjzPfrAnKzxAs6Aho3OL5sA50fv siZn3t4eifBGInHa7w6Hq6tTCh4xRes5QvU3mvsgzGprFfF4FAyNsuu1KzhNJ.Bt8LigcRtBuEmd v9_rY2cHl72iBx1dQioSMVW5tyQilj.k_QEf.3UPCh70Iex5mYdFEYDT8Fih8b3nXCf9gv800OdV I10vpuLd0rej2Z244cMMLnvS9u5ygBobKBzkzBLwx46cQw2laA_YENRiPs1fFxjSOCSNQFOboo_u Zht81QcWJv9550l4mDawZtj6NohDiKZNKnJD60NSPOdP3sNnkfoL.iyVveuWbWj_12DGkK.IlAO9 rzYgDcBZ38RQWXhdIIaPcqW7PEeY17Yt4g9PAy8wnHQimcrwZ1Iic45kb2_Q896ebSpBINKjmljK 0.OQ7eYSc5aniH1XF.e7pJAo5edLThWutp191W0d9Vg78fYbzI_Oyd8u1j6oNEGZilAGGZgWZmF2 13i4d6rMn_LJhjSTBp_xoT9PL_MFpsq.sg2XfeGTZYAf6PyhzW4cHyEcDTijZBFgNQltvyLcktXN ddWGg.yLgrseFxw0tiWZPcqffPWXqtF_tj.MSOoPozZO3k3cNgAyHeKK6PQBXmMt2CncBZQNGiZB T6Di0Sw6fePSSnOOBJAk9lYrX6Z3okiaJYAQd83Gc4_m0.ymsC0Lky6tAQWxHW4Ty1AdYQaSGO4V 8IiTVLOTq0mv6kVKg0jRrEN7s_ol9rLat3mdwI1XsjVk3M18k9UKfb.qddqPTgbNdpl85votlTlI WGhgK4GmmfaGvj1jA0rAQei2w379XldpaTJQXLWAC83ActFhtHka6QZsxgt4Pn144COd_6xTywtj K7eShFLQpGkVJVfCIN.N5reT_RZI_nWN0CS0A1XSyX_htG_a8IeNkC.zS5paKV53dv9Kqi69mom_ Y4rPMS_KVWV3gX0VMSRZMgtUu8S1XwdjoObw8neXb.sVkL6ntvZ0FS_lpjYFGBTdKNoayHjOYdWN mfDXNALIJc.xsLbSVWiEvzQeoS8i6jLIKSam04OxfG9AATlqqTXJ39VTacZMu375fAlWSnREOk6J Tvfzn1U6Ibi7TBzinp2p9k8jT27HVX_andFglndxrc8uKeal6qa3jvW55pzurxTWHQ5T.BLTVJXc jVwuCBMTLVtgpZmwwjsTxCBDB.ba8BNR7qloNNzRRn9w1l1r4TdK7KqB6IlsRZ9mckr8K6QW_Owg PyGs1XZ6Mutuh1jzG7Ql64cri0ybjFK9sHy1h3YHqFuERh7iv6qjlhDQU2bkSmQRmYrTc5gUISZr zic10CVbUbNhkSJ8FotS6.oXIT6JIxBcoJRuskc6AjxRxlvVtK5raXpcFcZcicuOnvrGbsJ7i2jL E6LlAFyQTuJhzLFp6mJt7sh2cDJ4BGKgJN5g7H4adbCG9dNJcSYDJUBBNi0Q7j9c_zLZx3rpyUPO bhCA7U5koTFAMVRwtXWHDb7yKTjTZqnXXmOe5_0A_2PQG9TcJOSHOfXCebt0xjRMA1bu0yqRTvsQ hLIm2LLFTt_vxza72Vrnwvu8yU4FXeqVWGo_iUUYC0fg2ITdiHxmHgj7hrhxgfM1G8NE0zT690EA wJA.wZ4G0TK2O3lpwzR.hUswKXwjif.QUr6RKs4W1a3t0U6iF.y39lIfyDdfTU0Q_2iHYXo9Djyi VuQEoE7FEVQhXzfJmy0c4qyf4gQhfYHU1NXoPyXTY0Tpdga6_wG8b.X_wNneYW5WkzlYN0XRg3G7 wg7Li0n3gChjx09lX1uPlSynM0Orej0B36unp8CyStTuCxNkG4.WzHuOEXfXtm15JGDbTZCJg.rx Es4A- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic305.consmr.mail.gq1.yahoo.com with HTTP; Sun, 12 Feb 2023 22:36:55 +0000 Received: by hermes--production-bf1-57c96c66f6-p9vmd (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 2caee892436a3019fd452c5f057cbd33; Sun, 12 Feb 2023 22:36:53 +0000 (UTC) Content-Type: text/plain; charset=us-ascii List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.300.101.1.3\)) Subject: Re: CFT: snmalloc as libc malloc From: Mark Millard In-Reply-To: <20230212222456.2vcvgf6v45na7jb2@mutt-hbsd> Date: Sun, 12 Feb 2023 14:36:41 -0800 Cc: FreeBSD Hackers , David Chisnall Content-Transfer-Encoding: 7bit Message-Id: <16E1DFAE-B679-4E10-9139-51336F5306AF@yahoo.com> References: <20230212210904.nzxfwtzsjf2tu6ky@mutt-hbsd> <20230212222456.2vcvgf6v45na7jb2@mutt-hbsd> To: Shawn Webb X-Mailer: Apple Mail (2.3731.300.101.1.3) X-Rspamd-Queue-Id: 4PFMls30Wsz4c7s X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/20, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On Feb 12, 2023, at 14:24, Shawn Webb wrote: > On Sun, Feb 12, 2023 at 01:48:59PM -0800, Mark Millard wrote: >> On Feb 12, 2023, at 13:09, Shawn Webb wrote: >> >>> . . . >>> That does not include the extra text that would be generated >>> by having added the -v requested to that shown command line. >>> That tet would likely have been before the text that you did >>> include. >>> >>> Did you add the -v option? Was there extra text? >> >> Good catch. I missed reading that. Here's the new output: >> http://ix.io/4nSy >> >> Hmm. Scanning that list . . . >> >> #include "..." search starts here: >> #include <...> search starts here: >> /data/src/hardenedbsd/lib/libc/include >> /data/src/hardenedbsd/include >> >> The above likely includes a non-C++: stddef.h >> That likely overrides any: . . ./include/c++/v1/stddef.h >> that is required for things to work for the >> nullptr_t issue. (See prior E-mail from when >> I noticed that I'd missed the include/c++/v1/stddef.h >> involved.) >> >> /data/src/hardenedbsd/lib/libc/amd64 >> /data/src/hardenedbsd/contrib/gdtoa >> /data/src/hardenedbsd/contrib/libc-vis >> /usr/obj/data/src/hardenedbsd/amd64.amd64/lib/libc >> /data/src/hardenedbsd/lib/libc/resolv >> /data/src/hardenedbsd/lib/libmd >> /data/src/hardenedbsd/lib/libc/locale >> /data/src/hardenedbsd/lib/libc/rpc >> /data/src/hardenedbsd/lib/libutil >> /data/src/hardenedbsd/lib/msun/amd64 >> /data/src/hardenedbsd/lib/msun/x86 >> /data/src/hardenedbsd/contrib/snmalloc/src/snmalloc >> /usr/obj/data/src/hardenedbsd/amd64.amd64/tmp/usr/include/c++/v1 >> >> The above looks to be the first/only chance to pick >> up a C++ based file header (that may in turn look >> for a C based one as well). >> >> /usr/lib/clang/15.0.7/include >> /usr/obj/data/src/hardenedbsd/amd64.amd64/tmp/usr/include >> /data/src/hardenedbsd/lib/msun/src >> End of search list. >> >> The ordering does not look anything like correct >> to me relative to C++ headers, some of which in >> turn may include the C variants from the environment. >> >> It is not so clear to me what the relationship is >> to the source_location file issue. > > Also: find /data/src/hardenedbsd -iname '*source_location*' > > ^ that returns zero results. Are we ("we" being both FreeBSD and > HardenedBSD) completely missing a header file somewhere? > Quoting prior content, after showing a find that indicated no examples in system header areas, including for llvm15: QUOTE So, none for FreeBSD and its llvm15. This makes sense, https://libcxx.llvm.org/Status/Cxx20.html shows: P1208R6 LWG Adopt source_location for C++20 Cologne Complete 16.0 So, likely FreeBSD will not have this until it progresses to LLVM16 . It just changed to LLVM15 in main [so: FreeBSD 14]. END QUOTE === Mark Millard marklmi at yahoo.com From nobody Sun Feb 12 22:53:43 2023 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PFN7V1jsfz3pLPZ for ; Sun, 12 Feb 2023 22:53:58 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic305-21.consmr.mail.gq1.yahoo.com (sonic305-21.consmr.mail.gq1.yahoo.com [98.137.64.84]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4PFN7T1fNbz3CVr for ; Sun, 12 Feb 2023 22:53:57 +0000 (UTC) (envelope-from marklmi@yahoo.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=yahoo.com header.s=s2048 header.b="kK32w29/"; spf=pass (mx1.freebsd.org: domain of marklmi@yahoo.com designates 98.137.64.84 as permitted sender) smtp.mailfrom=marklmi@yahoo.com; dmarc=pass (policy=reject) header.from=yahoo.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1676242435; bh=/sSqHeGmLclJOQitZdjTRu4cwaxDFMz6qgRd/pPwnac=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From:Subject:Reply-To; b=kK32w29/gauc1epqG1v8TEehERcNa6f+QeX1mP7CTpT4E5OTCBctO/fOO5ZFL92Ta0eSSd5qO17yySA41jxtV0Oy+K5MqAs7/lFM9aOHfTptT3gejkCAoU4yIRQ+DWQ9N7R7uc9ed3sEKYfpYFsKYAPzTecJMZj1fkf8gZbtBmvfQ63BrUUwowFFMBTTXJ0dDanKpxYbWr6BJ6QMRPpE0SgwKzKPaNDpFuG+oJ7TAsR+2GF4FMgdAS4kdk/jzSnO/tW1ZfDVagLr3rwJNlWGWEO3r56U/T2fRGcAtytt4hPb7Q14bW5ljZ4N6MZ6CRyK0ZR58i3YsfoSOFlg9Q43oA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1676242435; bh=Ks1LJ4roIplUuI8saCN/zOuFe7A0bClEj4hGkVtGJFU=; h=X-Sonic-MF:Subject:From:Date:To:From:Subject; b=AMaquGXWowDGlsNhHESO5k7ABktrLQNMiI/O5Ejv/kbFhSqC9WGjo0YWpZPeiBbII1tP154vTenxoHp2UiliCKmgm9tqbyjPXGMcZcLnIe2V99dwWytzGn6xH9S0/aVQqKZ8r+XMKLwjPIDlilQDaUmpRJAAYLWUNIl7Avc5zYnnBJiVO30bfxY2eRCcJuGtRmM0HIh68RAy5Mb+UgNDvedqLXWIU38QqA7VRRqpnS/YtPzW/EI1MOSbgv7fyuozZzxAG9+MAbmJvjaEqqEhK7edMnh3+R5wOvd9PXyARyovG0aRvaH7w+CcKQtXtbuok5iPPvwVXySZjQHGyOSXIg== X-YMail-OSG: cYVa_4IVM1mHqV7v2aZKTve2MNj9xQIeK3E0hk2.fk5XiyRvFpUQMBJ8nf5_qvS MP2jWJNNP51Rv_PKGinDz_CJrZ_gEVk5HC3zzou_63KHq51JdfLsPsg28UFDoQ.NX7h3RqiAUUzB wpRdYl4JmBrAwrBgxyUXy.pemI5avvMDTP4zORn_G0Fvmf1setLPKOhVsAnSguls7J1OS2eILyx1 PFKXnG1goNAx5phLTC80eWo0b5lvUuKO9ftOWbeRpXUTWZHq4xg0DfYhzSUygAj.f5nyAUx775AO B7G1_oZl5H7wyY9nwEyc0_ThW3lL5fYITIAmk0QjES0Id0jpUzu6mojooaucT.wjfLrz9sCQvBL0 7gscINxsyOQowGx0U39LWkjH3.ohTPcfG8_zTRLJiYupJ4EvP9fCmZWhpEInjJx53jatU3rnG8WB Ck0dD8tGwxXcl6R0yaYhgehJFOanWqNCRyRdAFVMR1AFLMGaHXRtrTxVPIzCHHUIzO2pGxfpAc9o zEFj4vOMLLhmp1tyihbaPMyscV5rsnu4K9p9wIVuQMc704d0KqSpj1P1T5DFLVbh0SN3t2ylAG3t n2IxuEYEMgJqDExTe5_2uTsNgRTMOJ8.uddkkCa5kY6Fk8J5WUhS.F9TiPCoVUun1IC.2prU2Bcm acP1sXG7Jky6TWn8JRxc.fZoi9SjBxbfIe3Dv.2oC79CEM7YwHDda0nVQo597pv1nqX.6vHrq.9X Ql1.95Th723YMoHq4zybJVKva4xrIVEhf.nqti7braiQ7LHlRFJgOJ.sRUsaFi7MGl57mhcOTdBR 3le5_nTZJkzt.kFnzuNpBaZjWTsij6GmTYeImvPGNZAGiGLYz9UWQW2gvk4Yzun0V_bXfl1UgAKu D_0S155MmXxDiUzMOYMOd0_Jdctz18qvlIRLb3oYJ9lThPnYS4stCa_yLBm1D7oQTGi_A2D8TKKi ewPDETZwKXuPY7kl4ADl38NtmKrdLgrEX8XoGKSFieD58llP9P_yLcBGB_Nm3nmLpDzu6ZYQj3OZ jjQvDTHAp8waiKpPGyxqfszJtlatR6O2H09eNg1uzZJ6cj1.2lySnByxSHqomxo2N3PwwfpBXMGJ j40vtjA7so7lp1Nv5UaLf6xPdQwgku33YG3922V5CpSySj7IhZdYZXcw0HnOkx1I4.MM9uf4pVK1 gaaFpK3Po9kXxFYGQNhVuF.CmopurYpGmjrYQxsZIM2bY098YAbDEqPlqjs6wh1t9s5Cqxh_Z3k4 zs_83KrJkR_Ru3210MAPtVqki0gzh.Av_KFMbk8nmwTR59jckCOFB0xawrPvPW6Pk5Ou1Y_p1_i4 VROuUM3w2Hy676GgV7G7bMEOR4IafBIJONWRFdo4KbhvuW7QR4b.h8cjuVuQBxJ6_bSZpOhnFJWW gyB.fHg.il71CcfvgrcMsvPqYVnrVD8PFrdbiYFKiYPIW507bXiHH5ezu3hqQNhotMnbXVIObTMJ _Ls5DQl0BYjXTcfjCSkuqtkZ8qdg.4pnWZ_oDXbavuJFFos_SmlFhSmsFE5QFOIDA9IwQMymSn.y THTpehjv5gzb.1LhrNmA8WNx1OsGVJziqwAGRbO7o5Rx69xb2D10ofbigW2BcQpwSZ13.aK6k1Me HzIZomZPmeq3IWkU1ijAhMtVQ1afOdHckdoraz2nZjKedAzfj6MvoFmC4fI8kYb.pfnJcRjDgnEm xIGgjgs1UMEEoQ43KjZw6Nt_.5MhN22SY5xVN8ssARJ_dUbcOM_iBtmCXLoY6TUX_wRG9wOtdXH_ YPyGt0RQbrID4P1FwiRdSM1Qgx4WGq2zqUnmQxP21FGndCHCnWQ8F_shsnrH.SYxgv77db5VL4f_ hwuMbeCxNH_Y.ks2YnHgaGAfVDez2E01PfNYVsCSdn2C81hz3SVRuHLtbOgF1x00awTJMxtVjcNU ep.dMv1udHwl16OnXMdLnIJpyWQbhcy8_VTXx8k0O4u4J9MLj1XG1mNDan3A48t_D45eg8tBmd4K q5GlxiUlHKAPWMhthCHFI3r5jNA96cg_40Onkk.7Rshc0JH8cLkXIKMGF47d_RrXlfiYQLnZxiOY 4BLGT7pXbjI081SZ0CwMxdaVoqkIWQvham_Zybq9qYf2bxwvnSJSvVnWdxzzf2bJFNF_PuNbkoWd Xn89C15uXo_QUnL5LkxBB9UMiNqOT7XD5xKcV62fb2J5tDv2CSAgzof8O9LzUlcvMGK0TfJ5LWTw H23QY8QCNhSn7Qp.tbeXcy7DNHvkmbFl44_XrFPcjlN1g6N4HWxGWxNCtHcxfbhKmggCvqrh8nGJ mFxTt7NhyJodx X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic305.consmr.mail.gq1.yahoo.com with HTTP; Sun, 12 Feb 2023 22:53:55 +0000 Received: by hermes--production-ne1-746bc6c6c4-z5pmw (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID e201060eca132aea55f3b6ca33228c6e; Sun, 12 Feb 2023 22:53:55 +0000 (UTC) Content-Type: text/plain; charset=us-ascii List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.300.101.1.3\)) Subject: Re: CFT: snmalloc as libc malloc [snmalloc misidentifies what llvm versions have source_location: need >= 16, not 15] From: Mark Millard In-Reply-To: <16E1DFAE-B679-4E10-9139-51336F5306AF@yahoo.com> Date: Sun, 12 Feb 2023 14:53:43 -0800 Cc: FreeBSD Hackers Content-Transfer-Encoding: quoted-printable Message-Id: <9AA79B35-51E6-4FA1-BC41-E51CDB819D2D@yahoo.com> References: <20230212210904.nzxfwtzsjf2tu6ky@mutt-hbsd> <20230212222456.2vcvgf6v45na7jb2@mutt-hbsd> <16E1DFAE-B679-4E10-9139-51336F5306AF@yahoo.com> To: David Chisnall , Shawn Webb X-Mailer: Apple Mail (2.3731.300.101.1.3) X-Spamd-Result: default: False [-3.38 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.88)[-0.876]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; MV_CASE(0.50)[]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; MIME_GOOD(-0.10)[text/plain]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; DWL_DNSWL_NONE(0.00)[yahoo.com:dkim]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/20, country:US]; RCVD_IN_DNSWL_NONE(0.00)[98.137.64.84:from]; TO_DN_ALL(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; FREEMAIL_FROM(0.00)[yahoo.com]; RCVD_TLS_LAST(0.00)[]; DKIM_TRACE(0.00)[yahoo.com:+]; MIME_TRACE(0.00)[0:+]; FROM_EQ_ENVFROM(0.00)[]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; MLMMJ_DEST(0.00)[freebsd-hackers@freebsd.org] X-Rspamd-Queue-Id: 4PFN7T1fNbz3CVr X-Spamd-Bar: --- X-ThisMailContainsUnwantedMimeParts: N [snmalloc misidentifies what llvm versions have source_location .] On Feb 12, 2023, at 14:36, Mark Millard wrote: >=20 > On Feb 12, 2023, at 14:24, Shawn Webb = wrote: >=20 >> On Sun, Feb 12, 2023 at 01:48:59PM -0800, Mark Millard wrote: >>> On Feb 12, 2023, at 13:09, Shawn Webb = wrote: >>>=20 >>>> . . . >>>> That does not include the extra text that would be generated >>>> by having added the -v requested to that shown command line. >>>> That tet would likely have been before the text that you did >>>> include. >>>>=20 >>>> Did you add the -v option? Was there extra text? >>>=20 >>> Good catch. I missed reading that. Here's the new output: >>> http://ix.io/4nSy >>>=20 >>> Hmm. Scanning that list . . . >>>=20 >>> #include "..." search starts here: >>> #include <...> search starts here: >>> /data/src/hardenedbsd/lib/libc/include >>> /data/src/hardenedbsd/include >>>=20 >>> The above likely includes a non-C++: stddef.h >>> That likely overrides any: . . ./include/c++/v1/stddef.h >>> that is required for things to work for the >>> nullptr_t issue. (See prior E-mail from when >>> I noticed that I'd missed the include/c++/v1/stddef.h >>> involved.) >>>=20 >>> /data/src/hardenedbsd/lib/libc/amd64 >>> /data/src/hardenedbsd/contrib/gdtoa >>> /data/src/hardenedbsd/contrib/libc-vis >>> /usr/obj/data/src/hardenedbsd/amd64.amd64/lib/libc >>> /data/src/hardenedbsd/lib/libc/resolv >>> /data/src/hardenedbsd/lib/libmd >>> /data/src/hardenedbsd/lib/libc/locale >>> /data/src/hardenedbsd/lib/libc/rpc >>> /data/src/hardenedbsd/lib/libutil >>> /data/src/hardenedbsd/lib/msun/amd64 >>> /data/src/hardenedbsd/lib/msun/x86 >>> /data/src/hardenedbsd/contrib/snmalloc/src/snmalloc >>> /usr/obj/data/src/hardenedbsd/amd64.amd64/tmp/usr/include/c++/v1 >>>=20 >>> The above looks to be the first/only chance to pick >>> up a C++ based file header (that may in turn look >>> for a C based one as well). >>>=20 >>> /usr/lib/clang/15.0.7/include >>> /usr/obj/data/src/hardenedbsd/amd64.amd64/tmp/usr/include >>> /data/src/hardenedbsd/lib/msun/src >>> End of search list. >>>=20 >>> The ordering does not look anything like correct >>> to me relative to C++ headers, some of which in >>> turn may include the C variants from the environment. >>>=20 >>> It is not so clear to me what the relationship is >>> to the source_location file issue. >>=20 >> Also: find /data/src/hardenedbsd -iname '*source_location*' >>=20 >> ^ that returns zero results. Are we ("we" being both FreeBSD and >> HardenedBSD) completely missing a header file somewhere? >>=20 >=20 > Quoting prior content, after showing a find > that indicated no examples in system header > areas, including for llvm15: >=20 > QUOTE > So, none for FreeBSD and its llvm15. >=20 > This makes sense, https://libcxx.llvm.org/Status/Cxx20.html shows: >=20 > P1208R6 LWG Adopt source_location for C++20 Cologne Complete 16.0 >=20 > So, likely FreeBSD will not have this until it progresses to > LLVM16 . It just changed to LLVM15 in main [so: FreeBSD 14]. > END QUOTE >=20 = https://github.com/microsoft/snmalloc/blob/main/src/snmalloc/ds_core/defin= es.h shows that it misidentifes what llvm versions have source__location, indicating that llvm15 (__clang_major__ >=3D 15) has it when it does not = : #if (defined(__GNUC__) && !defined(__clang__) && __GNUC__ >=3D 11) || \ (defined(__clang__) && __clang_major__ >=3D 15) # include __clang_major__ >=3D 16 would be appropriate, based on: https://libcxx.llvm.org/Status/Cxx20.html =3D=3D=3D Mark Millard marklmi at yahoo.com From nobody Sun Feb 12 23:09:24 2023 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PFNTh5B2Sz3pMvV for ; Sun, 12 Feb 2023 23:09:44 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic310-22.consmr.mail.gq1.yahoo.com (sonic310-22.consmr.mail.gq1.yahoo.com [98.137.69.148]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4PFNTg5D1rz3FKs for ; Sun, 12 Feb 2023 23:09:43 +0000 (UTC) (envelope-from marklmi@yahoo.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=yahoo.com header.s=s2048 header.b=MqA6fUPI; spf=pass (mx1.freebsd.org: domain of marklmi@yahoo.com designates 98.137.69.148 as permitted sender) smtp.mailfrom=marklmi@yahoo.com; dmarc=pass (policy=reject) header.from=yahoo.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1676243381; bh=CidQYlmBmJbRsAuVJlF3nCLeIdxjS1rY4bjUCaRuFRs=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From:Subject:Reply-To; b=MqA6fUPIgI/kCVTkNGpjX2TVDHbSS0YyMigRQRdVVJoP6lWX5b5mxxSW+d8GGy3DGX/VxVq43nT6/zU/0hZMeKjQXf7+QP02K5EzbcSxtrwRzdeTbTznqrgGrSZoPSE4gAukZQG3e/WxK2RMjR5bBSF5lRlEMACl+Is8YKcHUO7PYsxrTxxxHYRR+YK+YO5tJCrOSLNYKh1cxlTWSyIJHpXhztn4rkM267pAgRGPAf8F5gimBIG7UaSlFDLpomWfaPcuCg72USKVj70jpTm+pnJa/dI0upZUGzL6tHfUyaR7sbX4VbIWEUcPhQSqPBcNuxBpNUmDbFa+nbio8euLpA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1676243381; bh=FdAAgPOpCVSYuVOVJvWuNqSeqYYbtza3cx3qU/zUQf8=; h=X-Sonic-MF:Subject:From:Date:To:From:Subject; b=gA3T5mAKefhHxIs8dNanZNooPK6FbQgWjRzctxO54hfawJ8QbJi7eg+MRasyXTx4SV442W/q2uHvIOfh9EO6BaaNz3FQclSTDmOhryShBg4CDuHVOmz/sTSsmFESA1NCvDNO1RIK/v7oHeRq9BAo6jH1vB8Ce1+xrM/2fuEQS2dusj1AT9g1/i9J7SGxu0hBEgrWcEdU+RguuKrdHUeTq0qCNjec+nE/o9goNetRCjaMlszZ9JmTWG6fGkL8YiWFFR7fNDoctJgYCyW1G/ykLkqgQH6u+earme8bd8XODAlipB0+WY5PgLbECtJj8LHSw/xIIXPLKqSJuM5uo3w+qw== X-YMail-OSG: ZjIYSHoVM1kDLebvijvRDCRvX4ZjjkMIgxyHzqoT_xpRMJi_zmM9VidrQOVeyLK jY8b9sR5xIchdFvmNmDZ0EXD5YiHSbseHqGReJx2NMAh.BgYp9c5ouwFDEI99cr1gXNg.SgfxbKm rKddUHIP0k8MOAXgGTfYzGzewQkBJA1G4nWIvG_aCxFTUWblrjORVXXB0zVuky5M1R60VFAj_iww PBvuQwsoBtSKhcjGfNwPTQeIAwNGX36ekie4o4WImKkI_4_lRo4HcTDc5hE1BIRb8vsDb.1Np116 fiDvsFIx1_qFQV2veiJrZNCPwsGeWziy9.j4jBDcN1IvKkOZk0_GmEd2cnk9b11nFE_V4YttS0qZ I_cThN9uMi8GIHoy6Ps2gWjsrO0uMaDnsKOkHCNLu8nUbazkrkP5gTHqeqHsqJqIvdTEdEOu.zck ecoBQqJ.2bkQrnxIa6mCZdHPJERvK3oraWXxnaOS0QKtOE96LFT.FP5ssETvU3aLwwB4yLPx1d7g L4pjtlN5OCXuHeAvZCv3lXO3FJrossoTpCQAgl5xp97co3bQGqKyuTun0gtR58w8KbZrp.jLheN1 PFgUbMF0RXrjPvy3Ek49xlsiSJZoWW60zEuV.PIOgk9.ckGQtBMQOOg5O9S0IUqS0rnw6svPO58x C0Mzka_HaOUMtz9Q2fx1.SLc9T2zzZ7ZM4Gt35JT9kDZ9CzhYfsM18J0kp7eARp0Gp3OIGzrRV1d YCluREdvZu8l8oBjFI5Fo0oNh5aKWO7FM2lW_K5VoDt8OLWtFWZjMM56Hzhu2op4zb5iYz5qvmTZ TOLmAImx1W.YYIwNOADjQED7PrRkCpPIUO609rJUBAb_A8S8acJgfRYZjk6dDB7.t6CYYrJwHyEE GzWFR8g4qQOhjozY02Mnmbz92S_aPNdHp7aktbww1UPT_wtvrZJqQYq6BS.r_wSSv9PqmtnUTmd5 K8LXOCbvry6GJ542xn3bv4.BkQqiuLrTDZKeYCUi_ZrmLtr34xMdmouX9ar4yIqaBUaIAUIijR8k Eyx8.32zoE5Fk.yJbb7IqYB2fbMkGKAaldXvJACdobQPJO4zQaZr9oYA.TDgvtFhogXccaVhjF3R sF9uZqjuQDQ.ta6VSLBpw3UM6kh2vUUmIKjyhT.OjaaUsMZsTPJwLObjDQvP9CqDoF5FVl8Rk9R5 KJcK2MC5nRnTDw1FjXWp8qa8YiSf5hV.RFKrBwXci8sj0cDWnGKu0A94zJDSCRut4zgUE823nfWB GNfB9.ZxyuyM1EDx6pemEbfUFGeYVvPqejMKrJswA5DFwtjy4QQ18w8E4wim72KVwmcCUrk2QWNf DfEXdxLO_SFbtoyYsbM.vkfczZVwO4rUWBvm7FlQCaWfNQS.Gea5uhon18e0Z53sl1aepgCSq6Yx syrJlJFwszBcS2zbm1scSpvdJYhArmfj32YhPdpjbkjcX2tDUpK9uoBZaj_0Nkgw5yPQ9V5hkJCB VyvXCVBX0uz2Xun9bXfp5U5.bDJLC0LhvNJZPtJkh6QTCKhU3Oew4s1fvvEf7OpcCPyQ1jxwRrGu Rx0BErd4JYgEYGF6UWo5SVMUQzHAs00QFvc._zTRN8RpJCWBQx8Xxykp19Lln.nMVGA3XVdTbKGs NQbbomjzBwR_ME8tts.qfhKA1Sx1g26ZnIyBeH8M61mFBoseSIupoxOhN.3t3Uy2VhhFOStD65kR zRufB84_UM7tPkgnsWuK0MYb_YFHWZ7oH1KMaFeGZkMDeYneHWa2bLOhv2GABkQ8nPAAvl5mk9cl p9Ug7ApJILf0tzQ63mhT98Yp5Z8zvKBTY3il3q0IBMHbTUBQmfUvGcFMUULR5OGqShgSg62d5a.a aq7FZF_ZTDcar37WRFWx3GO6u9QblNJgHK19M2a0c6gPoTsseNHZfrN5dCHRbIWeqbU8x75KQSCo _mXXIW5kS1xZfqiGtInLqBIhxON.Gyx1XswhRL98fCiRtiASmJt6pJIaOlX5KZcMPzEoB69zl4gR _EC9cOtKbTJjRk9yWj4yeVod3ohXMl1m6wkpaQclhQiQqn0pZ7D.cKbLcHKK9b9oIg8h.Dm2AlM2 klw1iBm_SYnKK5mOzyXaLKuWStomTv2JlAWLHdAa0sGUd26TUA6pMa2aGVgQIoSGd6JsgoiJr5HF VteN0GasxgTgrADBLLiG4hjQU6Wy3kefMqVgK3Pl5xx_pQOkz5Hrp0f_eEVsy_1gbBWGKhIYoPRD 2e6PMB0pFWlpcgdQkcP2ai4w2MXFvhEpEVrfU6aQp1zbdC8.UAdtYJQ_AdhxpRYXLpm0.bNQeqk9 4SsM- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.gq1.yahoo.com with HTTP; Sun, 12 Feb 2023 23:09:41 +0000 Received: by hermes--production-bf1-57c96c66f6-7l94f (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 2b36145ab0194d295d0629b842c34bfc; Sun, 12 Feb 2023 23:09:37 +0000 (UTC) Content-Type: text/plain; charset=utf-8 List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.300.101.1.3\)) Subject: Re: CFT: snmalloc as libc malloc (the source_location issue) From: Mark Millard In-Reply-To: Date: Sun, 12 Feb 2023 15:09:24 -0800 Cc: FreeBSD Hackers , shawn.webb@hardenedbsd.org, Dimitry Andric Content-Transfer-Encoding: quoted-printable Message-Id: References: <22F8AD1A-C1F9-48FA-BCED-E165E2DA5260@yahoo.com> <1982263E-57E0-4709-AAB3-DBB4F75C7546@yahoo.com> <96652C51-EAB7-46C7-9039-557A5DCDAB75@yahoo.com> To: David Chisnall X-Mailer: Apple Mail (2.3731.300.101.1.3) X-Spamd-Result: default: False [-3.38 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.88)[-0.883]; MV_CASE(0.50)[]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; MIME_GOOD(-0.10)[text/plain]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; ARC_NA(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[98.137.69.148:from]; DWL_DNSWL_NONE(0.00)[yahoo.com:dkim]; RCVD_TLS_LAST(0.00)[]; MLMMJ_DEST(0.00)[freebsd-hackers@freebsd.org]; RCVD_COUNT_THREE(0.00)[3]; FREEMAIL_FROM(0.00)[yahoo.com]; TO_DN_SOME(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; DKIM_TRACE(0.00)[yahoo.com:+]; MIME_TRACE(0.00)[0:+]; FROM_EQ_ENVFROM(0.00)[]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/20, country:US]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[98.137.69.148:from] X-Rspamd-Queue-Id: 4PFNTg5D1rz3FKs X-Spamd-Bar: --- X-ThisMailContainsUnwantedMimeParts: N [Previously noted in another exchange, I note the snmalloc source issue in reply to this message as well, to hopefully avoid confusions when someone reads this particular exchange.] On Feb 11, 2023, at 09:13, David Chisnall wrote: > On 10 Feb 2023, at 21:34, Mark Millard wrote: >>=20 >> # find / -name source_location -print | more >> = /usr/obj/DESTDIRs/main-amd64-chroot/usr/local/lib/gcc12/include/c++/experi= mental/source_location >> = /usr/obj/DESTDIRs/main-amd64-chroot/usr/local/lib/gcc12/include/c++/source= _location >> /usr/local/lib/gcc12/include/c++/experimental/source_location >> /usr/local/lib/gcc12/include/c++/source_location >>=20 >> So, none for FreeBSD and its llvm15. >>=20 >> This makes sense, https://libcxx.llvm.org/Status/Cxx20.html shows: >>=20 >> P1208R6 LWG Adopt source_location for C++20 Cologne Complete 16.0 >>=20 >> So, likely FreeBSD will not have this until it progresses to >> LLVM16 . It just changed to LLVM15 in main [so: FreeBSD 14]. >=20 > The include of source_location is guarded under an #if __has_include, I do not see such when I look at: = https://github.com/microsoft/snmalloc/blob/main/src/snmalloc/ds_core/defin= es.h What I see is version checking that is based on llvm15 and above having source_location : #if (defined(__GNUC__) && !defined(__clang__) && __GNUC__ >=3D 11) || \ (defined(__clang__) && __clang_major__ >=3D 15) # include . . . __clang_major__ >=3D 16 would be appropriate, based on: https://libcxx.llvm.org/Status/Cxx20.html Other tests, less dependent on version checking, might work instead. > it should be used only if it exists. If it doesn=E2=80=99t, there=E2=80= =99s a stub implementation. If you have GCC includes in your include = path, is it possible that it=E2=80=99s finding a source_location that is = then guarded behind a check for a compiler builtin that clang doesn=E2=80=99= t have? =3D=3D=3D Mark Millard marklmi at yahoo.com From nobody Mon Feb 13 10:43:57 2023 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PFgtm0Gxzz3q0ps for ; Mon, 13 Feb 2023 10:44:00 +0000 (UTC) (envelope-from theraven@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PFgtl6w6vz3jhg; Mon, 13 Feb 2023 10:43:59 +0000 (UTC) (envelope-from theraven@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1676285040; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=19CK6g0jmyjI5vRxvvBhVGfiLWneKv4TTpjFbRqyWVk=; b=fHeuZKxEuMHPbO/qPzpqDkAYxyNNSP03/pQ9INqLBCOUX1RvmWI/B1nJQGz/N8WyEUBFr1 uu4C+i3zmpBzNjBlxEWvV3Ju6xfPI/JfC1s+cnFY3KmZG1faQneZWtmBePGF/yAzO4TyOu VCiXG6E1aeaLooMJRAVQROGkgpkhpjKztvhaai0gyKzo3g+98bKLwcTTHV6MOyXUoYcYKB 9odb/ev/cafeDpSsksvsQFYAUbTEkR4NgAPZWb7nisDnOS1Eb/0LKPxe/E134e/8FwF2TI MY1yXbXGaXBfQN1PX+au2w+xoz6ykC/0hW3MgRPF+TJ8RSGPlPZzvE8LN5yQvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1676285040; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=19CK6g0jmyjI5vRxvvBhVGfiLWneKv4TTpjFbRqyWVk=; b=BKqBoeRmcyF0mWhxz1lkDeLjqcVqCEcyhuqlSOB4uQ6xe1pflCgsYHvg7C7GQzhX9rZEt9 s7q7BUEsnxKG9MlY2fuC0GD0IxNyNZx0UcJNzidgnGqVlCif7zGA14CwDHwGYgI2KLpuVk CAQSCMVumhJsGVXP4GDGR3S/I9CnDEwWJYypdYUfYjNVz5HX0DBWo0twSfLaG+t9fXdbe7 CX2KzOJAjHutxRH3MAEfMjoQdf87Ob31SX5GzmWXAeyH5NMgN53SArww8vuM+djTg2vy1m Jm3okruZLau2StXqpOIG4UVspJPCyAk7Pej94MHUTylgAGJgIOHnc9vxI6XRDA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1676285040; a=rsa-sha256; cv=none; b=qJ2JGf/qoI5HIIc3JNOh/hvam1WtZ4wI4/s+in9i/LZN72M7ukh3rPSYex+TyHMFrfnsiE +BFWysDqQYueMLqB7ieaQbGYftzDwEw5kQ4zKtWq9MVz9AWwhCn0TotkP8/Om7CgbsM7OY AWdEf6wPksfJSvxX6WGgfzFAcp66mXCukv1i3v51xNxHJXDM7bQEzhwUUrNYWECJxPX3Od PFUbOfguc9q+0vQ7ebR/xz+6JKSV7PEz1gJdIE56UovtBChcEsI2DlNr3vZbiOKlTViW8g zmeHpPZoOfrZuzUtC+ovldWM+PzvCrLypSo8d0uB758xE6DRvno+4AtFyW77WQ== Received: from smtp.theravensnest.org (smtp.theravensnest.org [45.77.103.195]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: theraven) by smtp.freebsd.org (Postfix) with ESMTPSA id 4PFgtl5pYjz18cP; Mon, 13 Feb 2023 10:43:59 +0000 (UTC) (envelope-from theraven@FreeBSD.org) Received: from [10.164.186.150] (unknown [167.220.197.150]) by smtp.theravensnest.org (Postfix) with ESMTPSA id 8E2441060B; Mon, 13 Feb 2023 10:43:58 +0000 (GMT) Message-ID: Date: Mon, 13 Feb 2023 10:43:57 +0000 List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: CFT: snmalloc as libc malloc [snmalloc misidentifies what llvm versions have source_location: need >= 16, not 15] Content-Language: en-GB To: Mark Millard , Shawn Webb Cc: FreeBSD Hackers References: <20230212210904.nzxfwtzsjf2tu6ky@mutt-hbsd> <20230212222456.2vcvgf6v45na7jb2@mutt-hbsd> <16E1DFAE-B679-4E10-9139-51336F5306AF@yahoo.com> <9AA79B35-51E6-4FA1-BC41-E51CDB819D2D@yahoo.com> From: David Chisnall In-Reply-To: <9AA79B35-51E6-4FA1-BC41-E51CDB819D2D@yahoo.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ThisMailContainsUnwantedMimeParts: N On 12/02/2023 22:53, Mark Millard wrote: > [snmalloc misidentifies what llvm versions have source_location .] Thanks, I thought snmalloc included the code I wrote in a related project to do this, but apparently not. I've opened a PR to fix it and will merge once it passes CI, then bump the submodule: https://github.com/microsoft/snmalloc/pull/591 David From nobody Mon Feb 13 10:45:56 2023 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PFgx219tmz3q1Gp for ; Mon, 13 Feb 2023 10:45:58 +0000 (UTC) (envelope-from theraven@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PFgx20gX8z3kbG; Mon, 13 Feb 2023 10:45:58 +0000 (UTC) (envelope-from theraven@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1676285158; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qvClFFhjpjeTucXd3S9G/h5Uz1IU0YDutUnk1EWcSpo=; b=Dw/CHaCTPO3kUNlP08IoP72mi1M2wJh6hEn5yCLg720TWSrc1Ce4OGykI75N7OSEIMYLTy mmId7NT52kiS06OcbZPogp1GJapqxAtUIOwU04BpZmPhVXBOHog3+vjoVT+yeMSswhmHIO gj6AQPhlL/PY/+XkTokjemzxYZqS5gmDzQWloMZMN1yTGnbAh3R+votXuowxt7kc7nY2EU srjHd/ZhXHEzqY45JaZYo2BbvdDExZJE0KMi2MBBpDGAoYM1Bc2fLd036G62fa9786G6q+ nNSvzkYibE+uvu5O3enCr1igzjCe2cWvfQR8vVHoSuviuNMfHVB+UpxJywU6kA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1676285158; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qvClFFhjpjeTucXd3S9G/h5Uz1IU0YDutUnk1EWcSpo=; b=LQvWwNNafKnBrDBc9J2W20tgmH2TtToJMHireJ/n3a9PbIrfWxbRNnmAX/R5ycm6pJZKF/ IgUHm8hCscmujP6paNlAt2RxEm+8N6E3b0tzo84Eo2gzSOXpLp2+R7pB+3a/Pe4zYWqAF+ tU+NkEL1+RoDO0LwTMaGQgSmeR6+fwY/jXGmRQYYhIg/hw06HGkug4a/4Ti0gahIPzfPXc GkAGCOnfxYobgF1afMsplORWerhG7LWIGyzbC1qwMw545bNLQxaib+L4Cmgw9O8qymMWHO 4ppb3Ff6P9RsBGOlI514zNVfUvsEHRkxE8O2UsK+RKWsMP8SovkJSwwbEiSzGg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1676285158; a=rsa-sha256; cv=none; b=NqCtn3IrWY/5LcClw0z3caGuxMqQZ29YqzX0E/HPZhHQ4t94JhwdmQ81TZxFuXePOfy95f q3z1p3SJC9LIGlPCUtt1CHAfmrMufasS64DnzjYXAAfvc6qj/qyMeuKE8CpzIJ46b4Cn0d zRWBUIKFlsWKfrm0t3V/L6CHba19mps6a/x3h9W58BiqmsEYaWT+P2CFi1JzaYI1JSukHr JEChI5GmPDBp94rTfE07E5CWMQblOVKqoD/pOcsVi3tbOh9Uezcq4n9nW2ZqkEI8HKnyRp 6AfW/ahlwfC2w2D3IKUz+vK9ySWxDb6NNzjbAwGknU7zJU66ibvX5ILr7E5PrQ== Received: from smtp.theravensnest.org (smtp.theravensnest.org [45.77.103.195]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: theraven) by smtp.freebsd.org (Postfix) with ESMTPSA id 4PFgx16hJhz17sB; Mon, 13 Feb 2023 10:45:57 +0000 (UTC) (envelope-from theraven@FreeBSD.org) Received: from [10.164.186.150] (unknown [167.220.197.150]) by smtp.theravensnest.org (Postfix) with ESMTPSA id 3CA3C1060C; Mon, 13 Feb 2023 10:45:57 +0000 (GMT) Message-ID: <69917cbd-816b-da64-988d-910ddb88438e@FreeBSD.org> Date: Mon, 13 Feb 2023 10:45:56 +0000 List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: CFT: snmalloc as libc malloc Content-Language: en-GB To: Mark Millard , Shawn Webb Cc: FreeBSD Hackers References: <20230212210904.nzxfwtzsjf2tu6ky@mutt-hbsd> <0F63E50F-C0DF-48C4-81A0-6EEF46C9C397@yahoo.com> From: David Chisnall In-Reply-To: <0F63E50F-C0DF-48C4-81A0-6EEF46C9C397@yahoo.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ThisMailContainsUnwantedMimeParts: N On 12/02/2023 22:32, Mark Millard wrote: > I'll note that include/c++/v1/stddef.h uses: > > #include_next > > That in turn causes a stddef.h to be found that is > from later in the search list (not earlier or the > same file again). > > As for the include ordering, this leads to > . . ./include/c++/v1 needing to be before the > directory for the matching normal C header(s) that > C++ is(are) trying to include. > > There are implications for recursive include > handling during #include_next processing (just the > tail of the search list is used as I understand). I hit a problem with this related to the msun headers, which was fixed in the diff by changing the include from libc to: CFLAGS+= --include-directory-after ${SRCTOP}/lib/msun/src This may also be necessary for other headers if the way that the libc / libc++ headers are included has changed. David From nobody Mon Feb 13 10:53:40 2023 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PFh5y2NZNz3q1Mb for ; Mon, 13 Feb 2023 10:53:42 +0000 (UTC) (envelope-from theraven@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PFh5y1sfFz3lXq; Mon, 13 Feb 2023 10:53:42 +0000 (UTC) (envelope-from theraven@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1676285622; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xNch1CG9bE92y/+Xdx325exyPLOMdPTnG4EsVrIV0hI=; b=fGM8NXP8gbF26n+ebzWPNUHlBBQZYXsAWx4FqxHv6Fe9NXP9CyksmpNjO6ZRTyw3C+mULV E+hQiznpizWxmhma+lUEChMAWTDpHGDQ2LeJuRhpwrmPFVWZBK4dc471r6P99yVCtAYl2q x3towQ/LE7nMGBUZOX117K1grsNAcgl0u7Vtp2zgqn6DpzXaoK3lX9VVFf1Ic2cbgtyVZR zKf+r2S+7Enh6tdjBuXSvgsfoBESNeNPfb7DSEBzD9aP6oMLVfFEe5vT4GU1FheLNmMI8H WlnwA0hsY0qmG/S+7QlxauRn8SA6eZF+E1GYDWOG1SsxFwlv3ZvvdazPVtmr1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1676285622; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xNch1CG9bE92y/+Xdx325exyPLOMdPTnG4EsVrIV0hI=; b=aSwSwtWAY1riWihsN9M3kBUZD5wAsnZdga+ZEKJyRYKD11KuC5QMsmPzRh+DJOTziVuZwt lQ2qHyLT/xFKuQVZ4GiiGtsFnFdAZh1SXCtO0knQR4zQlOwiwbHmBRnQs/c85iLvrqnAq7 fkheVPF1N+W1cx/XkoHa+B4076G3Y+vILXku427hbCrw3kJTJuya0XNwcncRZ/XbUUB4Tw ENdS7KvZh9doDN9ZkPSFcAqUVBk+Rn7yRNKd62YB2dp0BYdAse1T6B4xgDGGhfKJ68BCeR T7DacCDhiM+tac62CHF+GynCIk4rb0mLxdjHhOLn0Kgy9NT2DuWvKcdZabgYpw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1676285622; a=rsa-sha256; cv=none; b=FJ5/AfnIcM60w+SrELwG5VvzaSyYLaHp8uR1rTk0Yd+S1gZ+yTnfI523X7bPpJUeicJEJC HUKMovlMVeQwROAu7JWwyiZimQet1KOJHCwHy+n03St1/eS9gC86pE/OAuYWz0V3Yr84Zo ZRWL7Bbnc1R6LkMPFt/j/0U4uFV86C+ZzVdcqyUOLluHqUzdsTGXYmGoS5SYz6Op8LuIWn +h1xG847eMJz9+m/FnNcst55Ge1p6cxlEi4scRAX0b9+G+pSSCqQEQbKelLCt7lqm6Qm9q HgJsmys8TS7N83/UxWjyL77EWxKnFJ9r83KVE9GvtGqgkQ5czYM7PYQZdJHkwA== Received: from smtp.theravensnest.org (smtp.theravensnest.org [45.77.103.195]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: theraven) by smtp.freebsd.org (Postfix) with ESMTPSA id 4PFh5y0p55z1814; Mon, 13 Feb 2023 10:53:42 +0000 (UTC) (envelope-from theraven@FreeBSD.org) Received: from [10.164.186.150] (unknown [167.220.197.150]) by smtp.theravensnest.org (Postfix) with ESMTPSA id 9C5511060D; Mon, 13 Feb 2023 10:53:41 +0000 (GMT) Message-ID: <9f3273aa-b140-10e7-017a-983b8d2ff51a@FreeBSD.org> Date: Mon, 13 Feb 2023 10:53:40 +0000 List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: CFT: snmalloc as libc malloc Content-Language: en-GB To: Warner Losh Cc: Mateusz Guzik , freebsd-hackers References: <2f3dcda0-5135-290a-2dff-683b2e9fe271@FreeBSD.org> From: David Chisnall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ThisMailContainsUnwantedMimeParts: N Hi Waner, I'm sorry about your experience - I've had similar experiences that have caused me to take year-long breaks from the project and I'm sorry if I contributed to that for you. And I definitely deserved at least some of the snarkiness - my comments were unhelpful. Please let me know if there's something I can do to help with the PR work. We have some infrastructure for using GitHub Actions to drive our Morello (CHERI + FreeBSD) cluster and we'd happily accept (or, time permitting, make) changes that would make it more generally useful. David On 12/02/2023 21:57, Warner Losh wrote: > David, > > Thanks for replying. I do appreciate the offer to help work out a > proposal for submodules. That would be quite useful. Technology has > improved in the almost 5 years now since we looked at submodules for the > first time.  Many of your criticisms have some merit. > > There's not currently a formal working group. I walked away from it > because there weren't enough people at the time that wanted to do work > and some rather unfortunate comments from some other people (so bad I > contemplated leaving the project)... Now that I've mostly recovered from > that experience, I've started a more modest pull-request experiment... > Moving to submodules is a big project, bigger than I can take on leading > at the moment. > > And about my snarkiness... This is still a very sore spot with me, and > so I responded to you with more snarkiness than you deserved. I'd like > to apologise for that. I'm sorry. > > I'd love to have your input on this, but first we'd need to find someone > to project manage things... > > Warner From nobody Mon Feb 13 12:04:31 2023 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PFjgj4yTsz3qPXj for ; Mon, 13 Feb 2023 12:04:33 +0000 (UTC) (envelope-from theraven@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PFjgj49rVz3vNn for ; Mon, 13 Feb 2023 12:04:33 +0000 (UTC) (envelope-from theraven@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1676289873; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3bJoqV5S4huXHzZPAiVz3rLlvBfvRiggOHhDTBNtGFU=; b=e0UX2lEhcGa9psS04ODNAhTlgXFw8BNDA00mPTQ+SlFvwLTE+AqDZtvYjUOLd5+7vDL9KG D+4/jjr/uXl0iwbcSd3tBerGs5TxTz1cPs1LrBpu7qlABHOTSs4+iYELHmAmG+NwsJZmnL bJhWANapn2QXRq2wJgDBnlpLfU3T09jtikEKJKARlw/as6UQk4GfMRH5cIZv5m9UQkuGyh Oqy4tsDxHDMbyCjS/3HDd0Am8OTPQVHZaXEq8+GXuCBVtTFXw5qL1W16YU/kzMJ4ymCE6U 4qHAFu1buFiVzEh4KXtXIN/cSBHxvW0hf4mmiB0PcAow+MBKT5TUtolTr/x8vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1676289873; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3bJoqV5S4huXHzZPAiVz3rLlvBfvRiggOHhDTBNtGFU=; b=bJfiRSXfkhFOWOIPvkeL0cM96RdgriDm9HqsMei/ezQgCpP+o5x0aiWzBsxesmtfIYM4XP e3cuA9qxLzY39tQxQjIfIsl1UtYEWAoolDWN9Qe9479xwSggc5c5J2K6jlaTM1Tru4iezW h1VhJqKeZEPaG4XEUGMTFg69xi4iP6kmiAEAqK9UPBSW7SC1A2Dw8Q9q7sRlEvdtCICwRN HqaVotqvOWYvasYPb2LrqGLDug4Zm6dW3YV+HgrheqYpIzueKQCjrFZf6466b+CcKaTVe4 joXcaVhBLQTKh17VpZfJd1GZb/FJP5L7POJAcQNY+fgnLIUFqEV/leNQluopKQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1676289873; a=rsa-sha256; cv=none; b=Arp4+/4YQtYD/fde3tavORgFB8pWVorPydBE3wskOX6XJn/HyJbOItVh7j9GlmWjF1+9HD wuEkeCBmZ9mbrE4heOI6ODWserFUo+M/O78bouo61ZUrdbZoqghSlhKUoUSL5ismYvhnCj zjv3RYH0Kcym4rkYKnaYLVF0SGwAp63wV0KFlr6GfNHRsDetxcar7TjlDSaPam1xDLpWEV HB2/ACFaPxRkrV90VF5ehbDw7AugV3XoFO3HTCwmM5vByPOL0VZ2uDYDCRIiFxXSxenbDU y/5sSEB+zUemRACPipti4VlhYM6dyCkoKoOamNrOd4KHVZZpULFwC7wo5qc62A== Received: from smtp.theravensnest.org (smtp.theravensnest.org [45.77.103.195]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: theraven) by smtp.freebsd.org (Postfix) with ESMTPSA id 4PFjgj2xypz19hW for ; Mon, 13 Feb 2023 12:04:33 +0000 (UTC) (envelope-from theraven@FreeBSD.org) Received: from [10.164.186.150] (unknown [167.220.197.150]) by smtp.theravensnest.org (Postfix) with ESMTPSA id B33BA1060F for ; Mon, 13 Feb 2023 12:04:32 +0000 (GMT) Message-ID: Date: Mon, 13 Feb 2023 12:04:31 +0000 List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: CFT: snmalloc as libc malloc [snmalloc misidentifies what llvm versions have source_location: need >= 16, not 15] Content-Language: en-GB To: freebsd-hackers@freebsd.org References: <20230212210904.nzxfwtzsjf2tu6ky@mutt-hbsd> <20230212222456.2vcvgf6v45na7jb2@mutt-hbsd> <16E1DFAE-B679-4E10-9139-51336F5306AF@yahoo.com> <9AA79B35-51E6-4FA1-BC41-E51CDB819D2D@yahoo.com> From: David Chisnall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ThisMailContainsUnwantedMimeParts: N On 13/02/2023 10:43, David Chisnall wrote: > On 12/02/2023 22:53, Mark Millard wrote: >> [snmalloc misidentifies what llvm versions have source_location .] > > Thanks, I thought snmalloc included the code I wrote in a related > project to do this, but apparently not.  I've opened a PR to fix it and > will merge once it passes CI, then bump the submodule: > > https://github.com/microsoft/snmalloc/pull/591 > > David I've also bumped the submodule version to point to the merged version of this. David From nobody Mon Feb 13 12:48:03 2023 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PFkdx0pkVz3qTnT for ; Mon, 13 Feb 2023 12:48:05 +0000 (UTC) (envelope-from theraven@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PFkdx0J0Zz40Y8 for ; Mon, 13 Feb 2023 12:48:05 +0000 (UTC) (envelope-from theraven@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1676292485; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GV7FdpbAhcp06dBq3fmhbjB84tWg2juRZA2GoxRwCtw=; b=rwJhG+MgFbq9bJuyyOVYpdSBh1wtBsem51kLSg5Z92Zsmj8rgHUagK66LhM+fsfwKyMk7Q C1ymKU5IU0DXpxqbLGrITRwdGRQ01MA0cX877pB5Ag75mdqj7k4Q+ghWJY6/5BeaCiI5EK +jacZC0t9NrWZRL+SqAPh+uVk+0REB2SLOgbKQrttxDSi+u4nzBnCrozwVcOkR5v6bZ6dp WZCDJc6YTA1qHD6H5pj32WfD4+9h+JR3OEtmQWItM2neuo042ftWuVGbh+/6++wBqm/x5O 9e/C+3SCP5uyHsRRPX8CXk+VETf3xAAPp0hFULA3b/MrsrBdcKZIln/JB00hMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1676292485; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GV7FdpbAhcp06dBq3fmhbjB84tWg2juRZA2GoxRwCtw=; b=OnK6KqHDoDQRVOVXsX7SARFEHeNIWrXX11uhsbWvJdTkfN3JtLPLEKxrkQdARxF+a2sYZQ QTQkho39BjHYKMCABUfzQuV5yunhLV2fEnrEliNNfDDkTbYncRdpPaO2zqYhvRmigvQvCG ajjKw7IKps/y9yfKQzw9rCfQlC7l11XWOfyC8I0IsJSHSlqpe2Uh7BwQqI8GCZWtpJdTkz +X8r7qoauBvo+FB9o/inH9iqN/gTMrRMOJj22dFlR9BM2FadGf3pfvKnII11Ed6ZQAaITW 8KWYMcepBL8d5xq8+dHTkjt+Zdwat8e6I2SNngpgEShmi/ENoBGjSfIq4H+lOg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1676292485; a=rsa-sha256; cv=none; b=OhEycdioKDIdd5xD6h1Qi7er62LTx9N+qzDCkCmXSfTaN1H5fih5r0YgmT6Av6cbG8suWd GiF2CSXEJRvb0CnAwG4QKetFhbmJyAmdbcTgAvhxwg6esKvSnDyow9nxbkv4Pqg/2priDv vezxMmsDoijddRnUNFHDw18wc6+O4++0DMcjWt5Ia3opYI1Xcugf+912/FxttL+HfwkHVt sfoYE2cTArgQzZS+RjxUNvLPKhqrroawzIoiDfgMPUe9yql7L0pjN1PvZz2FJVRVmTpbeH aTgLEHOJtSY2Tr7wPEuKwC5Yw2sr3Riz479C7A/eSpBW7Nc/rKINm4VRAGwCpQ== Received: from smtp.theravensnest.org (smtp.theravensnest.org [45.77.103.195]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: theraven) by smtp.freebsd.org (Postfix) with ESMTPSA id 4PFkdw6K6nz1BG6 for ; Mon, 13 Feb 2023 12:48:04 +0000 (UTC) (envelope-from theraven@FreeBSD.org) Received: from [10.164.186.150] (unknown [167.220.197.150]) by smtp.theravensnest.org (Postfix) with ESMTPSA id 4447A10610 for ; Mon, 13 Feb 2023 12:48:04 +0000 (GMT) Message-ID: <0a00f93d-adf7-1b70-3898-1377c1b582a2@FreeBSD.org> Date: Mon, 13 Feb 2023 12:48:03 +0000 List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: CFT: snmalloc as libc malloc Content-Language: en-GB To: freebsd-hackers@freebsd.org References: <2f3dcda0-5135-290a-2dff-683b2e9fe271@FreeBSD.org> <2836EF0C-8B4B-441C-927B-3796457A3865@FreeBSD.org> From: David Chisnall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ThisMailContainsUnwantedMimeParts: N Thanks, that's good feedback. I didn't separate these originally because I didn't want a huge testing matrix, but I've now done so. I have split snmalloc into two options in the latest commit in that branch: - WITH_SNMALLOC (defaults on) enables snmalloc - WITH_SNMALLOC_MEMCPY (defaults on if snmalloc is enabled) - WITH_MALLOC_PRODUCTION (I believe this is off by default for -CURRENT, on for other branches) sets both snmalloc and jemalloc into the recommended mode for release builds It's good to compare snmalloc vs jemalloc in WITH_MALLOC_PRODUCTION modes. I'd be interested in seeing snmalloc *without* the production knobs against jemalloc *with*, because if we have a bit of performance headroom we could use it for better security features. I'd also like to see comparisons of WITH_SNMALLOC_MEMCPY with different settings of the LIBC_BOUNDS_CHECKS environment variable for any workloads that people care about. David On 09/02/2023 22:07, Mateusz Guzik wrote: > I'm going to write a proper reply some time this week. > > For now what matters is that this CFT mixes up different things: > - snmalloc > - memcpy as shipped with snmalloc > - bound checks for said memcpy > > Seeing as stock memcpy is deficient and the one provided by snmalloc > is not a factor when deciding whether to switch to snmalloc, imo this > should be reposted. I also note that at least on head stock jemalloc > ships with debug, which again people run with by default unless they > explicitly disabled it. > > So a better CFT would include instructions: > - how to make sure jemalloc does not have debug > - how to build snmalloc without affecting memcpy (in fact, it would be > best if the branch for now shipped *without* custom memcpy so that one > does not have to check what hapepned) > > frankly i don't know how to check the jemalloc thing, but I can spend > some time to find out if that helps > > On 2/9/23, David Chisnall wrote: >> On 9 Feb 2023, at 20:53, Mateusz Guzik wrote: >>> >>> First and foremost, perhaps I should clear up that I have no opinion >>> on snmalloc or it replacing jemalloc. I'm here only about the memcpy >>> thing. >>> >>> Inspecting assembly is what I intended to do, but got the compilation >>> problem. >> >> If you just want to look at the memcpy, you might do better using the >> upstream (CMake) build system, which builds a shim library that you can >> disassemble and look at. >> >>> So, as someone who worked on memcpy previously, I note the variant >>> currently implemented in libc is pessimal for sizes > 16 bytes because >>> it does not use SIMD. I do have plans to rectify that, but ENOTIME. >> >> That’s one of the benefits of the C++ implementation. We were able to try a >> few dozen variations in a morning. Writing a single one of those in >> assembly would take a similar amount of time. >> >> We were inspired by the automemcpy paper, which demonstrated that you can >> write memcpy implementations tuned to specific workloads in higher-level >> languages and get better performance. >> >>> I also note CPUs are incredibly picky when it comes to starting point >>> of the routine. The officialy recommended alignment of 16 bytes is >>> basically a tradeoff between total binary size and performance. Should >>> you move the routine at different 16 bytes intervals you will easily >>> find big variation in performance, depending on how big of an >>> alignment you ended up with. >> >> Yes, that’s what our test does. It does a large number of different copies >> with different sizes and alignments. >> >>> I tried to compile the benchmark but got bested by c++. I don't know >>> the lang and I don't want to fight it. >>> >>> $ pwd >>> /usr/src/contrib/snmalloc/src >>> $ c++ -I. test/perf/memcpy/memcpy.cc >>> [snip] >>> ./snmalloc/global/../backend/../backend_helpers/../mem/../ds_core/bits.h:57:26: >>> error: no template named 'is_integral_v' in namespace 'std'; did you >>> mean 'is_integral'? >>> static_assert(std::is_integral_v, "Type must be integral"); >>> ~~~~~^~~~~~~~~~~~~ >>> is_integral >> >> I think the only thing missing is -std=c++17. >> >>> I'm trying to say that if you end up with different funcs depending on >>> bounds checking and you only align them to 16 bytes, the benchmark is >>> most likely inaccurate if only for this reason. >> >> I’m not sure I follow this, sorry. >> >>>> The fastest on x86 is roughly: >>>> >>>> - A jump table of power for small sizes that do power-of-two-sized small >>>> copies (double-word, word, half-word, and byte) to perform the copy. >>> >>> Last I checked this was not true. The last slow thing to do was to >>> branch on few sizes and handle them with overlapping stores. Roughly >>> what memcpy in libc is doing now. >>> >>> Jump table aside, you got all sizes "spelled out", that is just >>> avoidable impact on icache. While overlapping stores do come with some >>> penalty, it is cheaper than the above combined. >> >> They’re not all spelled out, because a lot of them are subsets of the >> others. The compiler does a *very* good job of optimising this. The >> generated assembly was a lot more complex than anything I could write by >> hand. >> >>> I don't have numbers nor bench code handy, but if you insist on >>> contesting the above I'll be glad to provide them. >>> >>>> - A vectorised copy for medium-sized copies using a loop of SSE copies. >>> >>> Depends on what you mean by medium and which simd instructions, but >>> yes, they should be used here. >> >> This could probably do with more tuning, but all of this is configurable >> with a couple of template parameters. If it’s useful to have more variants >> for different microarchitectures then it’s a trivial tweak to generate >> them. >> >>>> - rep movsb for large copies. >>> >>> There are still old cpus here and there which don't support ERMS. They >>> are very negatively impacted the above and should roll with rep stosq >>> instead. >> >> We tested on some microarchitectures without FRMS but didn’t compare with >> rep stosq as an alternative. The rep movsb is inline assembly >> (https://github.com/microsoft/snmalloc/blob/4370a23f3e5f1d1d06967b1e0d6162bf1ee81196/src/snmalloc/global/memcpy.h#L351) >> so it would be quite easy to compare. Very happy to take patches that make >> things faster! >> >> PowerPC doesn’t have an equivalent of rep movsb, so the PowerPC version >> doesn’t have an equivalent codepath. >> >> Each tuned version is a dozen lines of code (plus a lot of comments to >> explain *why* it does things a particular way), so it’s very easy to add >> different versions with different tuning. >> >>> I see the code takes some care to align the target buffer. That's >>> good, but not necessary on CPUs with FSRM. >> >> It doesn’t hurt though, on the sizes where it’s actually beneficial to use >> the rep sequence the cost of alignment is negligible. >> >>> All that said, I have hard time believing the impact of bounds >>> checking on short copies is around 20% or so. The code to do it looks >>> super slow (not that I know to do better). >> >> The last time I looked at the disassembly, the code for the bounds check >> touched three cache lines and has two branches. It fits well in a >> superscalar pipeline so adds a handful of cycles. This is basically in the >> noise for large copies but is double-digit percentage overhead for small >> ones. >> >>> People like to claim short sizes are inlined by the compiler, but >>> that's only true if the size is known at compilation time, which it >>> often is not. Then they claim they are rare. >> >> I agree. >> >>> To illustrate why that's bogus, here is clang 15 compiling vfs_cache.c: >>> value ------------- Distribution ------------- count >>> -1 | 0 >>> 0 |@ 19758 >>> 1 |@@@@@@@@ 218420 >>> 2 |@@ 67670 >>> 4 |@@@@ 103914 >>> 8 |@@@@@@@@@@@ 301157 >>> 16 |@@@@@@@@@@ 293812 >>> 32 |@@ 57954 >>> 64 |@ 23818 >>> 128 | 13344 >>> 256 |@ 18507 >>> 512 | 6342 >>> 1024 | 1710 >>> 2048 | 627 >>> 4096 | 398 >>> 8192 | 34 >>> 16384 | 10 >>> 32768 | 6 >>> 65536 | 7 >>> 131072 | 4 >>> 262144 | 1 >>> 524288 | 1 >>> 1048576 | 0 >>> >>> obtained with this bad boy: >>> dtrace -n 'pid$target::memcpy:entry { @ = quantize(arg2); }' -c "cc >>> -target x86_64-unknown-freebsd14.0 >>> --sysroot=/usr/obj/usr/src/amd64.amd64/tmp >>> -B/usr/obj/usr/src/amd64.amd64/tmp/usr/bin -c -O2 -pipe >>> -fno-strict-aliasing -g -nostdinc -I. -I/usr/src/sys >>> -I/usr/src/sys/contrib/ck/include -I/usr/src/sys/contrib/libfdt >>> -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h >>> -fno-common -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer >>> -MD -MF.depend.vfs_cache.o -MTvfs_cache.o >>> -fdebug-prefix-map=./machine=/usr/src/sys/amd64/include >>> -fdebug-prefix-map=./x86=/usr/src/sys/x86/include >>> -fdebug-prefix-map=./i386=/usr/src/sys/i386/include -mcmodel=kernel >>> -mno-red-zone -mno-mmx -mno-sse -msoft-float >>> -fno-asynchronous-unwind-tables -ffreestanding -fwrapv >>> -fstack-protector -Wall -Wnested-externs -Wstrict-prototypes >>> -Wmissing-prototypes -Wpointer-arith -Wcast-qual -Wundef >>> -Wno-pointer-sign -D__printf__=__freebsd_kprintf__ >>> -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas >>> -Wno-error=tautological-compare -Wno-error=empty-body >>> -Wno-error=parentheses-equality -Wno-error=unused-function >>> -Wno-error=pointer-sign -Wno-error=shift-negative-value >>> -Wno-address-of-packed-member -Wno-error=array-parameter >>> -Wno-error=deprecated-non-prototype -Wno-error=strict-prototypes >>> -Wno-error=unused-but-set-variable -Wno-format-zero-length -mno-aes >>> -mno-avx -std=iso9899:1999 -Werror /usr/src/sys/kern/vfs_cache.c” >> >> That’s a really helpful datapoint, thanks! That distribution matches roughly >> what we’ve seen - the number of zero-byte memcpy calls surprised me the >> first time I saw it, but the automemcpy paper reported something similar. >> >> If you can also extract the alignments from these then it would be fairly >> easy to modify the benchmark program to use those distributions. >> >> My original version extended the FreeBSD assembly memcpy with a call to a >> function that did the bounds checks, but that had *much* worse performance. >> We could insert assembly to do the bounds checks, but that’s hard to update >> if we change the metadata layout in malloc. >> >> We could modify the ifunc resolvers to use the current memcpy if you don’t >> care about bounds checks. I did a tiny amount of testing (mostly clang and >> lld) in this configuration and it was slower than using the snmalloc memcpy, >> but I didn’t do enough benchmarking to be confident of that. Hence the >> CFT. >> >> David >> >> > > From nobody Mon Feb 13 12:51:30 2023 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PFkjw0LS3z3qV5Y for ; Mon, 13 Feb 2023 12:51:32 +0000 (UTC) (envelope-from theraven@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PFkjv72Kpz41YS for ; Mon, 13 Feb 2023 12:51:31 +0000 (UTC) (envelope-from theraven@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1676292692; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c50IxGRx3YGk2RH931HDATYl34oWuXdyQ45TLmwJE0w=; b=aJz4umMzG3zTqpZs8iZibVSDSQyvtukh1I1FqIzb8vfecu7LpX7Q2GpAxOi8sRVcmUoXeY bxcvX8owhlIC6bqJ3BIfBs2xKHnG/Dsi8vbpkleEqJmzQRM6jgy9Ifv+r+7L5t1N9Xalci ZdvXcLrHPLkZhXA++4DmDi3M+dqhsBOXiJD0VNVilfq8cS+ID9BCuNCJdXQs/Afvz09h7d XNtKpuYRvos8/c+cm16sxtpS/D8QXUITDykDuUtRNmaPHcDfKgiyssPXPEdMclqtKNYs9K LgHvfJNzUCNUZzqOMUdxnGZBI63APtpkjpbrYxbAyyJmmW5Te8Z0qeRtmc4w5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1676292692; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c50IxGRx3YGk2RH931HDATYl34oWuXdyQ45TLmwJE0w=; b=XWTwUeRFzwfRTUHONHpsWmi4ZuW2r8hfetwbywwT+/uUKnflBfTpxw6p6aSMD8gEMdGpcF Pxtm8cFDZkZS1wqqulUS4Cqbv48Mu0VioUfGWBhp031BsK8weYgTiTLUS9bW852ghH9drL yRtFGiJwaPdFn0GmyvumJlfUZlRBsorYRlwDixdu2Lyr1/aIK/PczS/BE8Cci4KXs4snYT JQd87v7vjtYOj+3wLJnw/m092RDbmqQq+3PXOwDrdJ02cbBFgXy3GC376cLmyv+hZDpY/a Te3D43OyLRZBjqrELhoJhrTYfuE9PhFPtmm4PbG6dOLBTIsXoYLgV6UvOJOk2A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1676292692; a=rsa-sha256; cv=none; b=vVVgPyGfatGT0hJU6lcVCEwsXoKivWoDc1m8fRiaOP9jEdtSPDCl1PRKhBH3pS79XCYrnz k7HPBawsSPAusd+ALsyneSc6TReetddB6U2SAD2W5jgXPSOzB19aa4lLO9qWGxK7qoyja4 Ub9KOR7+HHLGhmSZVAHt7vF6pBen08/NjtXs/Hp/TYuULN99VzvRvbBvZfWE3wlyULAlUg bEcNWhyfBpBnL59+P2vvj6C7+Tfj9/KBWst9QlmVnbhjYY11E8q5mfhnqaf6qekdBB0gZQ H75VackpyBOJUuvRReMRZj6U5O3I2qv+kJRVRYqvpATACdUqudSrR8fzthbPjw== Received: from smtp.theravensnest.org (smtp.theravensnest.org [45.77.103.195]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: theraven) by smtp.freebsd.org (Postfix) with ESMTPSA id 4PFkjv64mBz1BfZ for ; Mon, 13 Feb 2023 12:51:31 +0000 (UTC) (envelope-from theraven@FreeBSD.org) Received: from [10.164.186.150] (unknown [167.220.197.150]) by smtp.theravensnest.org (Postfix) with ESMTPSA id 7DC1710612 for ; Mon, 13 Feb 2023 12:51:31 +0000 (GMT) Message-ID: Date: Mon, 13 Feb 2023 12:51:30 +0000 List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: CFT: snmalloc as libc malloc Content-Language: en-GB To: freebsd-hackers@freebsd.org References: <2f3dcda0-5135-290a-2dff-683b2e9fe271@FreeBSD.org> From: David Chisnall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ThisMailContainsUnwantedMimeParts: N On 09/02/2023 23:09, Konstantin Belousov wrote: > On Thu, Feb 09, 2023 at 09:53:34PM +0100, Mateusz Guzik wrote: >> So, as someone who worked on memcpy previously, I note the variant >> currently implemented in libc is pessimal for sizes > 16 bytes because >> it does not use SIMD. I do have plans to rectify that, but ENOTIME. > > Note that you need two kinds of micro-benchmarks for this: > - normal microbenchmark which does the SIMD-enabled memcpy() in a loop > - a microbenchmark which ensures that the SIMD register file ownership > is re-taken on each iteration (or close to it). > > I am sure that the results from #2 would be astonishing and give quite > different prospective on the use of SIMD for basic libc services. Does FreeBSD still do lazy context switching of SIMD state? I was under the impression that this was disabled by all operating systems now because it exposes speculative side channels across a process boundary. Given that the x86-64 and AArch64 ABIs both pass floating point arguments in SIMD registers by default, I'd be surprised if it gave a performance win - unless a workload manages to avoid passing any floating-point arguments in a quantum, it will hit the trap every time. In addition, unless you explicitly disable it, recent versions of clang will use SIMD registers for inlined memcpy (irrespective of what libc does) and will also now spill GPRs to SIMD registers in preference to the stack in some situations. David From nobody Mon Feb 13 15:24:39 2023 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PFp6k71pcz3rHHW for ; Mon, 13 Feb 2023 15:24:46 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4PFp6k4f72z3C3r; Mon, 13 Feb 2023 15:24:46 +0000 (UTC) (envelope-from kostikbel@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.17.1/8.17.1) with ESMTPS id 31DFOdUm084868 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Mon, 13 Feb 2023 17:24:42 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 31DFOdUm084868 Received: (from kostik@localhost) by tom.home (8.17.1/8.17.1/Submit) id 31DFOdav084867; Mon, 13 Feb 2023 17:24:39 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Mon, 13 Feb 2023 17:24:39 +0200 From: Konstantin Belousov To: David Chisnall Cc: freebsd-hackers@freebsd.org Subject: Re: CFT: snmalloc as libc malloc Message-ID: References: <2f3dcda0-5135-290a-2dff-683b2e9fe271@FreeBSD.org> List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=4.0.0 X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-14) on tom.home X-Rspamd-Queue-Id: 4PFp6k4f72z3C3r X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On Mon, Feb 13, 2023 at 12:51:30PM +0000, David Chisnall wrote: > On 09/02/2023 23:09, Konstantin Belousov wrote: > > On Thu, Feb 09, 2023 at 09:53:34PM +0100, Mateusz Guzik wrote: > > > So, as someone who worked on memcpy previously, I note the variant > > > currently implemented in libc is pessimal for sizes > 16 bytes because > > > it does not use SIMD. I do have plans to rectify that, but ENOTIME. > > > > Note that you need two kinds of micro-benchmarks for this: > > - normal microbenchmark which does the SIMD-enabled memcpy() in a loop > > - a microbenchmark which ensures that the SIMD register file ownership > > is re-taken on each iteration (or close to it). > > > > I am sure that the results from #2 would be astonishing and give quite > > different prospective on the use of SIMD for basic libc services. > > Does FreeBSD still do lazy context switching of SIMD state? I was under the > impression that this was disabled by all operating systems now because it > exposes speculative side channels across a process boundary. FreeBSD uses lazy context instantiations. Even with it, there were several reports of problems caused by the use of XMM registers in libthr due to significantly increased latency of the context switches. > > Given that the x86-64 and AArch64 ABIs both pass floating point arguments in > SIMD registers by default, I'd be surprised if it gave a performance win - > unless a workload manages to avoid passing any floating-point arguments in a > quantum, it will hit the trap every time. In addition, unless you explicitly > disable it, recent versions of clang will use SIMD registers for inlined > memcpy (irrespective of what libc does) and will also now spill GPRs to SIMD > registers in preference to the stack in some situations. It is common/not unusual to have programs that do not need floating point arithmetic. From nobody Mon Feb 13 16:34:58 2023 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PFqh30KBkz3rQ6N for ; Mon, 13 Feb 2023 16:35:15 +0000 (UTC) (envelope-from Walter.von.Entferndt@posteo.net) Received: from mout01.posteo.de (mout01.posteo.de [185.67.36.65]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4PFqh23wvlz3PL7 for ; Mon, 13 Feb 2023 16:35:14 +0000 (UTC) (envelope-from Walter.von.Entferndt@posteo.net) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=posteo.net header.s=2017 header.b=IUUAqPxe; spf=pass (mx1.freebsd.org: domain of Walter.von.Entferndt@posteo.net designates 185.67.36.65 as permitted sender) smtp.mailfrom=Walter.von.Entferndt@posteo.net; dmarc=pass (policy=none) header.from=posteo.net Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id A05D1240158 for ; Mon, 13 Feb 2023 17:35:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1676306113; bh=frcCV1k9oG9oKj3dpUqdJg1PxRT2RSN/XKdLCPjaYaY=; h=From:To:Subject:Date:From; b=IUUAqPxeppYhNUvz7Ms1gt42G/NNOIWgxnuaSkcOP9U/GBA8q5ctvwTZeKTtnAMMw eOLiAcbnv8SsKYRFjpR5RXoolgPNUsond0FyrYuLbsKbrCNj7WlS73IIps34L5rkpS r/jJxFbNLUqICwnmlIpuks2tdJt90u9Qp/uM1uglLxOuUFOuHdU0BTeqfoP8IKvZkA zZzX/9+24NY9940ixfE2dfiwmI2oSTEFjIOIGm3rQ2YV9rsVE102iK3KPfd0dtrOiz UFQfPlmazTnLBgiPmSnlRjnxmfs5dVItfRX6BQp3BuAByDN6I5WMdPxqrPWb2JIxt2 k2P6zjXD544YA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4PFqh125NSz6ts3 for ; Mon, 13 Feb 2023 17:35:13 +0100 (CET) From: Walter von Entferndt To: freebsd-hackers@freebsd.org Subject: unsubscribe Date: Mon, 13 Feb 2023 16:34:58 +0000 Message-ID: <1912081.M6z43oxySm@t450s.local.lan> X-Face: #$[hC+4[4W*mS3hB&izisyT_#E]^Aq+7Isv`2Tu5q*1~jR@&['74B>Ibyrk]GTJ!j$ NjX=#L2#k2X7OnaaRM_Pd5`>`8OJ3;+I2 References: <4PCRp05JvBz3nT4T@mlmmj.nyi.freebsd.org> List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Spamd-Result: default: False [-4.20 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-0.999]; DMARC_POLICY_ALLOW(-0.50)[posteo.net,none]; RCVD_DKIM_ARC_DNSWL_MED(-0.50)[]; CTE_CASE(0.50)[]; R_DKIM_ALLOW(-0.20)[posteo.net:s=2017]; RCVD_IN_DNSWL_MED(-0.20)[185.67.36.65:from]; R_SPF_ALLOW(-0.20)[+ip4:185.67.36.0/23:c]; MIME_GOOD(-0.10)[text/plain]; ARC_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; MLMMJ_DEST(0.00)[freebsd-hackers@freebsd.org]; MIME_TRACE(0.00)[0:+]; DKIM_TRACE(0.00)[posteo.net:+]; RCPT_COUNT_ONE(0.00)[1]; ASN(0.00)[asn:8495, ipnet:185.67.36.0/23, country:DE]; FROM_HAS_DN(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[freebsd-hackers@freebsd.org]; RCVD_TLS_ALL(0.00)[] X-Rspamd-Queue-Id: 4PFqh23wvlz3PL7 X-Spamd-Bar: ---- X-ThisMailContainsUnwantedMimeParts: N From nobody Mon Feb 13 22:01:29 2023 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PFywv4047z3qS9k for ; Mon, 13 Feb 2023 22:01:51 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic306-21.consmr.mail.gq1.yahoo.com (sonic306-21.consmr.mail.gq1.yahoo.com [98.137.68.84]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4PFywv0mXcz4lGK for ; Mon, 13 Feb 2023 22:01:51 +0000 (UTC) (envelope-from marklmi@yahoo.com) Authentication-Results: mx1.freebsd.org; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1676325707; bh=OpieL/EShaJUbh3Q5/pfK6mZOQWGJkO7KRfWzikhR40=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From:Subject:Reply-To; b=mnegLAshSvYOAGUSlY3kwz0iiGyvZ/ufTnZo59F3CP6v18MpBbrg1025JhHFDnBp/vNhEq0uJM6rMLMBrcrLUb2QlFozYZ1tR17bHW533rixVezf4LlCVz256MBXeWOreZ2MnFYPXwTwP4VisZIH1D+/jUuk1HLXMuTRzbZYRaCmYG6tBBhYikP2QcCz4aRmn/n1MjoIXJA3bNFSOcI7h8ljPXbMg0gczwHzCSfWVySfO3zLjU1QWbbTHm3CZl1fRgqb8etf583ZprvymeyB+DD2CCMvR9nIz95pNweHHKDccfTxk1kRIHZJFaUiMYgGMfg0Eas7qvaG8IoWkPNw7g== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1676325707; bh=nC7XZuQxcRYq3DWx11zXgryzBReOT7DOBpdq10e9iFY=; h=X-Sonic-MF:Subject:From:Date:To:From:Subject; b=h7nCBtIS+hXCef/QGvBiWfDNAmg13GJcuGQLVEUgZk2O/2pTlA7eJwUrVq+bQ1pLon//O4DNz6ceoucDHUgIO2qDVBaULk94QwSrwdXvDBwWnjiyJT8W6aPdJCd51zFaF0mZ/JmU6epzTCwxbz2CqUchHwniMd83ktx2/LcoRAqd21t//qJtCD+SAgBCCd8kRpbfVs2tzYuYpg+bZgIaybBoRN6m1u+DzXskFsNbqYxceDQID69w5JEuGnvFYnimrsly/w5u/MG9KLWnZGv2Bp7RMKnIOxDLUFCHzQ6vQmyCIw3YOrvM7MaueQhFqv3DXknS5lgiplTPphaSdOXEuw== X-YMail-OSG: 6tCS7rgVM1nTc2erlsYKeP454Pl2Hxfm8qIgmfTUbD8Y.U6wOKYH37hTAHIIcyC kDGbTaeBWTv93x7tpTFiQY2Tj.McPvxujVo2ZhKPbA.JwgA3hxYhjMFo0KyH_5w.V_.DCnASh2aT i.JfCV2S76GzcHM0y039PCzTLFnX9R6dhdvHWujDrQEPeFFW0fC_M9wI1S83Ft.CVbPD0B8GAq9j URsOycXQSShq3lHC8wP0ho9c7JDs5XSAVxHj7KYn9ANz3oH0ZUpz94HEMirvCq0a7KeKLndEl4mX TCUCi.d0BjpPemrw5zRde6GFnZ4aNZy4wR.U4lg076oRu6NVF3MJhD2xqUrVpWBzGH9OoUmsO5UZ aCVTp_dNDXYBWbC7ynBpWNOShpIsIMo2H0LAK_wV_epGb30ZqL6_6wgJzNMFbBLA4OAKel1njpzP FCCmfrHtWpcqx_a445v2d_r9ZG0MLlAfS2Gsu6vx2sdPxy7BYDFYWe4Qk_Eoy1la44mCG.wM8MQ1 VZ7Ld_hbW.MTYm2FU8ohM0qThfi0c5aZ8PVLu3PcjT1Cf1gxNJeg4WJ7A_VIygziZXjxEYtJ15pO 5709wlf_Yf1tPKP4d24eOCS69Q1nWIQk352oRfMPEkBm51j2PnmaHU69K55pSTb6zr7vjalKn9ln sxQVxqYns3UH50z1isQ6O0b8LIWXa31gP7SQdkfxMXwMF65I.hh_TNdDYnulmKJlu3zj9AdOSr6p TiqgAs51tKthc18TUo72XGVy4kw31gjKBJ0h2g0sE8rKy0sqE1HVa4j.avEmP9nJaOFXcnar1wol 5SJLwEpsu6lJQzitvcY1AIno1i6RJj6pW8Vb2U4GedZ.jOnkq2foZxMmJYxTtPAUSN_Eej2O3PQK lQA0xuAeOdR8i7cpDacstc8RD.1faKi_uo7ST9b2XqLwzHnKFmo01.aHu0KVkJRo7mX.Uvhmlg5v YZg6zjEnYdgJ5PW8KnaeRaVp.QtYEIcT2vkunrHMJV2rEUBJjjh.pNvkZ2leYOu5yhwonN9sQQE2 oMIMYhSOYGnNOuMzypYWh1kboSYQVmqYWJYySVTynWUtRkvk3WZjMpKX.rlRHLXZbqXzwnDoEz.I YlPtRGgzqgJpDdNbU6awIIt7FkakxsFuh1h2bIomDqZXKyMAMOst6HSPDpgfu3ardddSbuHsrgZE jZr17lGVTV7R2517R4Qwf6EJd4yqzM6BAa.FNHjfd1mGyDfoWyyfs1MaUQeGmV.z4EClUBrvOS9Y y08VB9c.03Tv.cuDKYWVkbLZkG20ptC0g1jz0fxBrtk3fdWdoivvBOXh1SBZhS98npk9OWifhtFj OMk1C21FJBYjmzFPWt.qMKrBeSPPUAWLuH41AVhGYl4uPXCvJJ0AW8kCHhs5RCIwYE8odvnnYbeP JhZli0oST5h.gEui.lJq0asl5U6tNpHb5Ovdz.lPdX.eNwytJMKdLPM.CI0QJMnINF3rcAzCgDNK eGFhfzjAiljsZk1PsQhKfMOX38zyXiZUTYUgWWAhzyUhIa8MhkmRi1vwnoXJH9D98dikEta8Z83g WRDi1qq4on1k3m3jMfVedGvvz3.8MaRgTJh.kpULKdQAASQmu58AVyQgoF03wy3fy.gMUirESqXT Lcn_SjXniXH0b5omo6NBAJ2zq1haRznBlm.ko0JB.f3LGXekhFWD6BnEHBtjXsB9Km67wDRI31_0 QHi3HwwJ12Lwlj.uF_CIutxtWKTTOBYyNPAnmTpeRdZgR7eD6cCal6koDa9_2TzmCa5.xUdKFn7a xoew_.v2wJy6aZUMdA0aGS8L4Hl.nTfEGVXgkKKRnbinn0yinJZb3RKyc0Wt9tA6p0gbU8C6Kt3_ yoPKSeuRKrIqcuZTusHmviCdLnq7_njXpWYwmu6U9I6yDO4w8oRLht_M0vflgix9OcaeaY1Lijyi 59uOYTwkKJ3iKgVOFZJgCKEKkDyWX0U6wDRtd9xjq65NqB7eLciOHZZ84Ga0cgvPKry9fRmQGLGp isVi2IgAlnSvqFqg6ztbT6yOJW5uJ_LZ6O6D4DtN3Xsiu9rcbSTzXVw3HFR8SO6w6gO.9lZ3AtIl PfBK5ujOB9BQyW0.5U3dQ1wDgnyp4a9LLe8SUwkLfM7oHcW0S7hyEVh_PA1jFZ.mcNT7QtGu._Eh W0zowHKIKAUASL0yEmb_XxG2iz5EY1JHlOrlRcRXjRuHayhTSau8aWfcreH_E1CcojnJbN1nNari YyCmvdGCSu9VoHwq1jV7HCJSCngqJFwxhUJ61tpJsX7ntI4Pb6eS8qRlgzsy4vyDth..8ytZ6qfX aMfXP X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic306.consmr.mail.gq1.yahoo.com with HTTP; Mon, 13 Feb 2023 22:01:47 +0000 Received: by hermes--production-bf1-57c96c66f6-p9vmd (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID dfb1070ddad82091d5acb5947a2b91de; Mon, 13 Feb 2023 22:01:42 +0000 (UTC) Content-Type: text/plain; charset=us-ascii List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.300.101.1.3\)) Subject: Re: CFT: snmalloc as libc malloc [snmalloc misidentifies what llvm versions have source_location: need >= 16, not 15] From: Mark Millard In-Reply-To: Date: Mon, 13 Feb 2023 14:01:29 -0800 Cc: Shawn Webb , FreeBSD Hackers Content-Transfer-Encoding: quoted-printable Message-Id: <6660BD19-13BA-4F73-9447-A3B54D8E0B29@yahoo.com> References: <20230212210904.nzxfwtzsjf2tu6ky@mutt-hbsd> <20230212222456.2vcvgf6v45na7jb2@mutt-hbsd> <16E1DFAE-B679-4E10-9139-51336F5306AF@yahoo.com> <9AA79B35-51E6-4FA1-BC41-E51CDB819D2D@yahoo.com> To: David Chisnall X-Mailer: Apple Mail (2.3731.300.101.1.3) X-Rspamd-Queue-Id: 4PFywv0mXcz4lGK X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/20, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On Feb 13, 2023, at 02:43, David Chisnall wrote: > On 12/02/2023 22:53, Mark Millard wrote: >> [snmalloc misidentifies what llvm versions have source_location .] >=20 > Thanks, I thought snmalloc included the code I wrote in a related = project to do this, but apparently not. I've opened a PR to fix it and = will merge once it passes CI, then bump the submodule: >=20 > https://github.com/microsoft/snmalloc/pull/591 >=20 For the: -#if (defined(__GNUC__) && !defined(__clang__) && __GNUC__ >=3D 11) || \ - (defined(__clang__) && __clang_major__ >=3D 15) +#ifdef __cpp_lib_source_location My understanding is that __cpp_lib_source_location is guaranteed to potentially become defined basically only 2 ways: A) inclusion of B) inclusion of Clearly (A) is not the case here and would require a __has_include() test to allow this style of attempting to get a definition for __cpp_lib_source_location . I looked a round some and did not notice an example of (B), but I may have missed it. So, it might be that this changed turned off use of in unintended places. =3D=3D=3D Mark Millard marklmi at yahoo.com From nobody Fri Feb 17 15:43:39 2023 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PJGLJ3TCFz3qYkw for ; Fri, 17 Feb 2023 15:43:20 +0000 (UTC) (envelope-from ihor@antonovs.family) Received: from mail.antonovs.family (mail.antonovs.family [100.25.240.195]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mail.antonovs.family", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PJGLH5Pz9z3LQm; Fri, 17 Feb 2023 15:43:19 +0000 (UTC) (envelope-from ihor@antonovs.family) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=antonovs.family header.s=20200215 header.b=gTdHYvDK; spf=pass (mx1.freebsd.org: domain of ihor@antonovs.family designates 100.25.240.195 as permitted sender) smtp.mailfrom=ihor@antonovs.family; dmarc=pass (policy=none) header.from=antonovs.family DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=antonovs.family; s=20200215; t=1676648589; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uKc8SdEdKKAGuZiyG3F+ZHAGGSXkvOZEjEo2eX6vWTw=; b=gTdHYvDKH3H+H3jfwm9k/bNU5VpCscUAXUbVq47Y8QnYxkS5kdGhmEjIFn88Kn+5oSLIH5 Kvofx1jBpK90e8Z/a6H54U9hh7/JhiW5VbYtKLnmDUMcrRTb4M+BnskSrHHjp4nsvbKNYP 6Ch4OqPSe5D0IYO2bb5BU5f0kvGfEOo= Received: by mail.antonovs.family (OpenSMTPD) with ESMTPSA id c5b5edf8 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Fri, 17 Feb 2023 15:43:09 +0000 (UTC) Message-ID: Date: Fri, 17 Feb 2023 07:43:39 -0800 List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: working groups reanimation Content-Language: en-US To: freebsd-hackers Cc: David Chisnall , Warner Losh References: <2f3dcda0-5135-290a-2dff-683b2e9fe271@FreeBSD.org> From: User Ngor In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-4.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; DMARC_POLICY_ALLOW(-0.50)[antonovs.family,none]; R_SPF_ALLOW(-0.20)[+mx]; R_DKIM_ALLOW(-0.20)[antonovs.family:s=20200215]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; MLMMJ_DEST(0.00)[freebsd-hackers@freebsd.org]; ASN(0.00)[asn:14618, ipnet:100.24.0.0/13, country:US]; MIME_TRACE(0.00)[0:+]; DKIM_TRACE(0.00)[antonovs.family:+]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; ARC_NA(0.00)[]; TO_DN_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; FROM_HAS_DN(0.00)[]; RCVD_TLS_ALL(0.00)[] X-Rspamd-Queue-Id: 4PJGLH5Pz9z3LQm X-Spamd-Bar: --- X-ThisMailContainsUnwantedMimeParts: N forking the thread for working groups convo On 2/12/23 13:57, Warner Losh wrote: > David, > > Thanks for replying. I do appreciate the offer to help work out a > proposal for submodules. That would be quite useful. Technology has > improved in the almost 5 years now since we looked at submodules for > the first time.  Many of your criticisms have some merit. > > There's not currently a formal working group. I walked away from it > because there weren't enough people at the time that wanted to do work > and some rather unfortunate comments from some other people (so bad I > contemplated leaving the project)... Now that I've mostly recovered > from that experience, I've started a more modest pull-request > experiment... Moving to submodules is a big project, bigger than I can > take on leading at the moment. > I will be more than happy to help restart working groups and play a role of a meeting organizer / stenographer and contribute my expertise where I can. First thing we need is a place where a list of working groups can be discovered (how and when to join) and where announcements can be shared. A dedicated mailing list would be great, but I am also open to other ideas (use -hackers maybe fine too?). Currently the only place I know of is [1] meetings repo on github with notes (and it is not complete, bhyve group for example is missing) [1] https://github.com/freebsd/meetings -- Ihor Antonov From nobody Fri Feb 17 17:03:49 2023 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PJJ7S2LJhz3r9Yx for ; Fri, 17 Feb 2023 17:04:04 +0000 (UTC) (envelope-from f0andrey@gmail.com) Received: from mail-oa1-x29.google.com (mail-oa1-x29.google.com [IPv6:2001:4860:4864:20::29]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PJJ7R575dz3kZf; Fri, 17 Feb 2023 17:04:03 +0000 (UTC) (envelope-from f0andrey@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20210112 header.b=MFReEnDO; spf=pass (mx1.freebsd.org: domain of f0andrey@gmail.com designates 2001:4860:4864:20::29 as permitted sender) smtp.mailfrom=f0andrey@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-oa1-x29.google.com with SMTP id 586e51a60fabf-171894cdf02so1621372fac.11; Fri, 17 Feb 2023 09:04:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=N3KqzEFCIIfQZduF6kVhk+Bm2gwP4vVz1PE6PWxqluE=; b=MFReEnDOKPfyZP+HplU8r55UEdkwTDz06nKQJOb9DQ9D50KeulMtf5A2/GStJrfgAd /AepcuSFkIo8UPwqYyeDAstp/a6By7bctwGSFslZG0PXbWPpmLeJSUYv2bkJ8h62ociF rKW+D7+lIosEJh1fix3BfLHZO5gxyuqtq2GwyQdUcmDa5oC0fOB0H5QgjbRdsk+0plhd 5qsd9nnMWzYffitH72PIpinvmaSIN4cWCM0s6zGdwW7JOAHrLAA9m7j6YpjRD5PfULQW HnRPGxADe9HvEJ4NOmkTMYCUEppGdsYy+AuKPMEQ5LCj/Lb0POlSjHdDXS93ZXFNFZYP Wcaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=N3KqzEFCIIfQZduF6kVhk+Bm2gwP4vVz1PE6PWxqluE=; b=UUDPoLV0TJH6A3G9QR8M6eyfLOBCZSb18v1yYKpdpJVrtO8vuGipbn4N9XQ9c+DWPY PB3jiy5sktx8Ud+S53TLA1Zwn+oMAlCUhfMu1F4CFF2QEBMyJ82IuYo+Puek3diFgfLr 7mHEM4TwN/z631kuDjzgrpm5WqJOx2IuAoiP5Nhb7pCHvYRx3VPa6V0Pmi0N7M7RBglF CSs0aSLUSPJu/MPcdmEPL6FN6SHYiqQDbtD4c2EHn7da0kfjPHVjzqX6x1M28uIfY017 33Fux9RxjH8rrLQ6g6lXoB5WqD+gd1XEU2eTT0vQ3OnafIV5pQF6xjxA7U0xzseDGqX8 oWLw== X-Gm-Message-State: AO0yUKVZdNo2TUh8yrz1d80s1QSOC68/SM9SudirPyQKbz5nB1oRJ7br cCzYarbrm/3EDHSh7IDNOPuzSZRFJh/tNlN47GSSWh/aHk8= X-Google-Smtp-Source: AK7set+rFdLY32waVaIqrR2i0M7Kn6ahGBPrnKgH6sgRLHEcIYORf6Yac8Y0fN8SGdXccdMh+7et4mWrmxU4NsH6yjk= X-Received: by 2002:a05:6870:b909:b0:16a:6ef8:bbef with SMTP id gx9-20020a056870b90900b0016a6ef8bbefmr648213oab.264.1676653441767; Fri, 17 Feb 2023 09:04:01 -0800 (PST) List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org MIME-Version: 1.0 References: In-Reply-To: From: Andrey Fesenko Date: Fri, 17 Feb 2023 20:03:49 +0300 Message-ID: Subject: Re: RFC: GEOM and hard disk LEDs To: Alan Somers Cc: FreeBSD Hackers Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spamd-Result: default: False [-3.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.98)[-0.975]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20210112]; R_SPF_ALLOW(-0.20)[+ip6:2001:4860:4000::/36]; MIME_GOOD(-0.10)[text/plain]; MLMMJ_DEST(0.00)[freebsd-hackers@freebsd.org]; RCVD_TLS_LAST(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:15169, ipnet:2001:4860:4864::/48, country:US]; RCVD_IN_DNSWL_NONE(0.00)[2001:4860:4864:20::29:from]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; FREEMAIL_FROM(0.00)[gmail.com]; MID_RHS_MATCH_FROMTLD(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim] X-Rspamd-Queue-Id: 4PJJ7R575dz3kZf X-Spamd-Bar: --- X-ThisMailContainsUnwantedMimeParts: N On Wed, Feb 8, 2023 at 2:31 AM Alan Somers wrote: > > Most modern SES backplanes have two LEDs per hard disk. There's a > "fault" LED and a "locate" LED. You can control either one with > sesutil(8) or, with a little more work, sg_ses from > sysutils/sg3_utils. They're very handy for tasks like replacing a > failed disk, especially in large enclosures. However, there isn't any > way to automatically control them. It would be very convenient if, > for example, zfsd(8) could do it. Basically, it would just set the > fault LED for any disk that has been kicked out of a ZFS pool, and > clear it for any disk that is healthy or is being resilvered. But > zfsd does not do that. Instead, users' only options are to write a > custom daemon or to use sesutil by hand. Instead of forcing all of us > to write our own custom daemons, why not train zfsd to do it? > > My proposal is to add boolean GEOM attributes for "fault" and > "locate". A userspace program would be able to look up their values > for any geom with DIOCGATTR. Setting them would require a new ioctl > (DIOCSATTR?). The disk class would issue a ENCIOC_SETELMSTAT to > actually change the LEDs whenever this attribute changes. GEOM > transforms such as geli would simply pass the attribute through to > lower layers. Many-to-one transforms like gmultipath would pass the > attribute through to all lower layers. zfsd could then set all vdevs' > fault attributes when it starts up, and adjust individual disk's as > appropriate on an event-driven basis. > > Questions: > > * Are there any obvious flaws in this plan, any reasons why GEOM > attributes can't be used this way? > > * For one-to-many transforms like gpart the correct behavior is less > clear: what if a disk has two partitions in two different pools, and > one of them is healthy but the other isn't? > > * Besides ZFS, are there any other systems that could take advantage? > > * SATA enclosures uses SGPIO instead of SES. SGPIO is too limited, > IMHO, to be of almost any use at all. I suggest not even trying to > make it work with this scheme. > > > old dreams https://people.freebsd.org/~mav/Enclosure_Management_en.pdf TODO: =E2=80=93 add support for SGPIO/I2C interfaces in more drivers, =E2=80=93 associate devices with enclosure slots for non-SAS enclosures; =E2=80=93 implement in-kernel interface for the =C2=ABenc=C2=BB CAM driver; =E2=80=93 refactor GEOM::setstate API to handle full set of SES Array Device Slot flags; =E2=80=93 explore possibility to make ZFS report disks statuses to GEOM using that API. From nobody Fri Feb 17 20:15:52 2023 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PJNNp4ptLz3rQpQ for ; Fri, 17 Feb 2023 20:15:54 +0000 (UTC) (envelope-from leres@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PJNNp4Fxfz48WF for ; Fri, 17 Feb 2023 20:15:54 +0000 (UTC) (envelope-from leres@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1676664954; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=1vDq1wNFwu4VTLpQIuA1uYMoL3nvMYRHVg542wYGdhM=; b=WnaNG8tOM9y3j4POtqfh4xhHYAUCsHOn0Y5+jXFn0qFxUKgrx7X2VgMRd3fbXRu8/1OqYm i23GKnU2yyOmanKETXFmWl/CYrrbclL5PBYA+RLNzPlHng5G4faGgEaiI6yYxLeoLl3UwR 1R2A1ifcXb9UTuLnSiE93g2O9FEb9LIk6xILIpqcngh7H/arCOb5+mG59KuYFUg23MyVhx sZor2lROzecPcsdiJ9JCCYkKAczv6CgXtYTuERJyjkJUvljos93xzEAoLTiaqdFtEwcudx hKP9lNSsVoyrxhmxcdZEpPSd86fHbx+5zdrKLAhzhM28kPsFHQbtN/mPRqoQkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1676664954; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=1vDq1wNFwu4VTLpQIuA1uYMoL3nvMYRHVg542wYGdhM=; b=FtbKZ8+JIqvb9pVxyR06WtjrVlPq5rXxWNfKcl1YOcoiu80AbdvE4AFM6BCOlD0EDYzU4S qUrQrVnxY1b7xVTjof/uoEBMfsvSBeVqr+KK3Ltc106pa7lBTgv9b0ub2DNNDXap4NFPJz PuZtp7l75t3f0Jv+STcb4MeYZFM5Ei0fVRQEQS+HxW2EKn85fPIppnQZGBnAhKb39JLeiy o/yhYieQSP69pkisH/SUpiXyrDG2miwg5LqtWoSfTMGLhjXvSohnCoHwNaZFVWRI/bjQq4 OrTmtfz7XwrneE8if87T1ozzFnOBkcMwkoMJYhvnSiBDoMceQEylN45y5h0oZQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1676664954; a=rsa-sha256; cv=none; b=eTObdt+a07dNI4xaWxPETuciUEzUeVuL92uWv5nYg4zmq32VeyRA3Sjzo7MT2Z0CtefPYB bGbE5qSwX9TVvjA6CXytZy5KOQuydaKYRiGR5e7EkMHNNRFSGFD3Av3qd+u7CIGac15oMY eH1us7Ku6uA+g7+uvZf5mlX/cKQaxSzh2LkQBU/e/lA14YwJDuoCPRktUSscJGIYn6grRR 9gHY9UOSQsQrZuOsJvtyocABwaTsGS2xxVzX/4H+syO/ioZSAjYfd50SYFXWTDrvzVrwCQ yWo3kSImaF+xPOvvDEsxXaXff45qguqza4WtVFGJdp3457eReJlvosGNKneWpQ== Received: from [IPV6:fd:1965::2] (unknown [IPv6:2600:1700:ab1b:6800:f2ad:4eff:fe09:150e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: leres) by smtp.freebsd.org (Postfix) with ESMTPSA id 4PJNNp259HzsvS for ; Fri, 17 Feb 2023 20:15:54 +0000 (UTC) (envelope-from leres@freebsd.org) Message-ID: Date: Fri, 17 Feb 2023 12:15:52 -0800 List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Content-Language: en-US From: Craig Leres To: freebsd-hackers@freebsd.org Subject: Building a poudriere for pfsense 23.01 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ThisMailContainsUnwantedMimeParts: N Please pardon my inexperience with git. When I built a poudriere jail to build packages for 22.05 I used: poudriere jail -x -u -j 12pfsense -a arm64.aarch64 -m git+https \ -v 12.3-STABLE@5f81a4619dcf I got the git hash from here: https://docs.netgate.com/pfsense/en/latest/releases/versions.html Now I want to build a jail for 23.01 and this page says the version is 14.0-CURRENT@aec9453fec7 but poudriere tells me that branch is not found... I was able to clone https://git.freebsd.org/src.git to a scratch directory and can see hash 5f81a4619dcf in the log in branch "main" but main@aec9453fec7 and head@aec9453fec7 do not work when trying to build a poudriere jail. This is the last thing I tried, what am I doing wrong? poudriere jail -x -c -j 14pfsense -a arm64.aarch64 -m git+https \ -U https://git.freebsd.org/src.git -v 14.0-CURRENT@aec9453fec7 (The last time I tried running CURRENT on a test box I got stuck at building packages for it, I think my problem was the same as this...) Craig From nobody Sat Feb 18 17:03:53 2023 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PJw4t1vkhz3slZw for ; Sat, 18 Feb 2023 17:03:58 +0000 (UTC) (envelope-from void@f-m.fm) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4PJw4s21FTz46BR for ; Sat, 18 Feb 2023 17:03:57 +0000 (UTC) (envelope-from void@f-m.fm) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=f-m.fm header.s=fm1 header.b=MH+12HUK; dkim=pass header.d=messagingengine.com header.s=fm1 header.b="i bGDM4S"; spf=pass (mx1.freebsd.org: domain of void@f-m.fm designates 66.111.4.26 as permitted sender) smtp.mailfrom=void@f-m.fm; dmarc=pass (policy=none) header.from=f-m.fm Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id A77B05C00AD for ; Sat, 18 Feb 2023 12:03:56 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sat, 18 Feb 2023 12:03:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=f-m.fm; h=cc :content-type:date:date:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to; s=fm1; t= 1676739836; x=1676826236; bh=5SdKz8ziVxhwMj3xQ0SEJ+ZgCWRfU6WpGkx 4eNls/MI=; b=MH+12HUKpNpPPXY6Pi3DNEsoqKlKTU5bcFzV50CJe4m4d7JHBZg 8skRv1xYy7B9fzRBmGLEL/jllBEepWsEbaW8T5G46UfsPSdUUFykpikm5WgpCnak +YvJVEHp16tHE8LZO9Cl9sHuqimqSpfdwE9z3Qncz15CJhZsEBriita+d01PRvPN CEa/2L2MNo+JJLZK5Lvrcnnd/PZvU8M3/KS/EAFLMJjrfqMxvXRtjHngja3iDx1T FxitMpFcBUhkUuQwOu0quznBSEqRPcQXjpPHc+JCpWAJm5qKgjbs7WxydUcrK9ZK YrImqr/vDBHWFkjwTszVsoi1ZHHnmEdDkVw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:message-id:mime-version :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1676739836; x= 1676826236; bh=5SdKz8ziVxhwMj3xQ0SEJ+ZgCWRfU6WpGkx4eNls/MI=; b=i bGDM4S4k1Nv97vpdTunS7vnZ8fproKvHc1L63oEOIoubYcfcLjy8ZJWAbbWMIPzM ejOHu/eunO11WLhFMo3VE7Mn+oRfwvGwKA22JCh1UkLZ7+wlESYQDkqKsw+RfSRI uDkxSvKWPAgmxIzIA143kwDrKyRa5w5hCW7tDbBS/lLbEZSG3JZKPKZx1MLWDu5n SGd+256pvngua1gs2U9VP+UodULDrUtVNlkAGZhPSNs4cjOC+8iXMmJtqahULoWF ePs9S0JwukbaoVPagsyxeKF4C5CUkAzMpS/YHWvGny4r1UL67e1ZRZCkYLGZo9q+ a78xahJPMvdG5WiiemlqA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudejuddgleegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkgggtugesthdtredttd dtvdenucfhrhhomhepvhhoihguuceovhhoihgusehfqdhmrdhfmheqnecuggftrfgrthht vghrnhepveduffeivdfffffghfegfeejfefftdeiteehteekfefhvdefgfettdeuheegff eunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepvhho ihgusehfqdhmrdhfmh X-ME-Proxy: Feedback-ID: i2541463c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Sat, 18 Feb 2023 12:03:56 -0500 (EST) Date: Sat, 18 Feb 2023 17:03:53 +0000 From: void To: freebsd-hackers@freebsd.org Subject: avoiding periodic(8) during long poudriere runs Message-ID: Mail-Followup-To: freebsd-hackers@freebsd.org List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline X-Spamd-Result: default: False [-4.56 / 15.00]; DWL_DNSWL_LOW(-1.00)[messagingengine.com:dkim]; NEURAL_HAM_SHORT(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-0.997]; NEURAL_HAM_MEDIUM(-0.86)[-0.860]; MID_RHS_NOT_FQDN(0.50)[]; DMARC_POLICY_ALLOW(-0.50)[f-m.fm,none]; R_DKIM_ALLOW(-0.20)[f-m.fm:s=fm1,messagingengine.com:s=fm1]; R_SPF_ALLOW(-0.20)[+ip4:66.111.4.26]; MIME_GOOD(-0.10)[text/plain]; RWL_MAILSPIKE_GOOD(-0.10)[66.111.4.26:from]; RCVD_IN_DNSWL_LOW(-0.10)[66.111.4.26:from]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; PREVIOUSLY_DELIVERED(0.00)[freebsd-hackers@freebsd.org]; ARC_NA(0.00)[]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:19151, ipnet:66.111.4.0/24, country:US]; RCVD_COUNT_THREE(0.00)[4]; TO_DN_NONE(0.00)[]; FREEMAIL_FROM(0.00)[f-m.fm]; MLMMJ_DEST(0.00)[freebsd-hackers@freebsd.org]; DKIM_TRACE(0.00)[f-m.fm:+,messagingengine.com:+]; MIME_TRACE(0.00)[0:+]; FROM_EQ_ENVFROM(0.00)[]; FREEMAIL_ENVFROM(0.00)[f-m.fm]; RCVD_VIA_SMTP_AUTH(0.00)[] X-Rspamd-Queue-Id: 4PJw4s21FTz46BR X-Spamd-Bar: ---- X-ThisMailContainsUnwantedMimeParts: N Hello hackers@ Is there an established way of telling periodic to not run when load is over a certain value? Or to delay running it until load goes (for example) under 1.00 for 15 mins. tia, -- From nobody Sat Feb 18 20:46:43 2023 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PK12455YSz3rZrH for ; Sat, 18 Feb 2023 20:46:52 +0000 (UTC) (envelope-from SRS0=zpMN=6O=quip.cz=000.fbsd@elsa.codelab.cz) Received: from elsa.codelab.cz (elsa.codelab.cz [94.124.105.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4PK1242NF8z3LBq for ; Sat, 18 Feb 2023 20:46:52 +0000 (UTC) (envelope-from SRS0=zpMN=6O=quip.cz=000.fbsd@elsa.codelab.cz) Authentication-Results: mx1.freebsd.org; none Received: from elsa.codelab.cz (localhost [127.0.0.1]) by elsa.codelab.cz (Postfix) with ESMTP id D6EEED7893; Sat, 18 Feb 2023 21:46:44 +0100 (CET) Received: from [192.168.145.50] (ip-89-177-27-225.bb.vodafone.cz [89.177.27.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by elsa.codelab.cz (Postfix) with ESMTPSA id ECD4FD788C; Sat, 18 Feb 2023 21:46:43 +0100 (CET) Message-ID: Date: Sat, 18 Feb 2023 21:46:43 +0100 List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: avoiding periodic(8) during long poudriere runs Content-Language: cs-Cestina To: freebsd-hackers@freebsd.org References: From: Miroslav Lachman <000.fbsd@quip.cz> Cc: void@f-m.fm In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4PK1242NF8z3LBq X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:42000, ipnet:94.124.104.0/21, country:CZ] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On 18/02/2023 18:03, void wrote: > Hello hackers@ > > Is there an established way of telling periodic to not run when load is > over a certain value? Or to delay running it until load goes (for > example) under 1.00 for 15 mins. I don't know about any generic way, but you can put some shell code into /etc/periodic.conf to exit if load is too high Just a quick and dirty example, exit if 5 minutes avg is higher than 1.1: avg5load=$(top | awk '/load averages:/ { load=$7+0; if (load > 1.1) { print "HIGH" } }') echo $avg5load if [ "$avg5load" = "HIGH" ]; then echo "CPU load is too high" exit 5 fi Kind regards Miroslav Lachman From nobody Sat Feb 18 21:56:42 2023 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PK2Zk6BRvz3rw3X for ; Sat, 18 Feb 2023 21:56:46 +0000 (UTC) (envelope-from void@f-m.fm) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4PK2Zk1Sqrz3hqP for ; Sat, 18 Feb 2023 21:56:46 +0000 (UTC) (envelope-from void@f-m.fm) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=f-m.fm header.s=fm1 header.b=jo+CZ3lF; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=NxEpMSVp; spf=pass (mx1.freebsd.org: domain of void@f-m.fm designates 64.147.123.21 as permitted sender) smtp.mailfrom=void@f-m.fm; dmarc=pass (policy=none) header.from=f-m.fm Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 327303200312 for ; Sat, 18 Feb 2023 16:56:45 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Sat, 18 Feb 2023 16:56:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=f-m.fm; h=cc :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1676757404; x=1676843804; bh=p7/XKxEkmZ u2J7JMTxzeq1Y+WTX1+r86TXsm3ORpMPE=; b=jo+CZ3lF5ULbm1xUh+YTGFJiok qgtFkEaen9JCLvPoE3bEIAuYxNSMjlwTbxQcijLRMOyAe6JnIqVuWSq3UWam46oB dzr/KBGe9NZ2lv8UERVXUUpZfD9XQXe+2/Di4o87rxqsKWD4lAAv0G7Mm7zBpLe3 5nd+QXIX60DTS7k9vBeo8XNXl3k8zIHtJzKtDHuM7i91KA/oyTvshWsR0zceuGZa LOt+SeZxz0Ba9fWqJ5cC8+gGLMG+Ea1GfHXyrpGTjQ227612ne+azmvmMV+Qrkcf igmsZXnQjEtGl5Xwh5sJ4TULG9uy+e3ICuvFPEZGRqCSwNvERiuqf1Irsj7A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1676757404; x=1676843804; bh=p7/XKxEkmZu2J7JMTxzeq1Y+WTX1 +r86TXsm3ORpMPE=; b=NxEpMSVpfbf9IVqY78mXnG5s6bZDKap4aHwGlPA6EiIV jie8AotJerIQBgRn8G6aNYwu26f9PO0+73k4/uclJn4KfFTmXElcWuDsPeQWKcQw yQcu4JQHA2wcPGKnSccKdRYplGh/DwRgO+fQgk9kMOAr/C2x8rh8R7Jl5V6qgjjC 1yNsb+6ATivjomDkYoYHQgkb6WCMf+01VKHaUATFqiBYDgsC0Dn05yYnV8H2l05E 2c+WY1szEyW1SJGzdPiZK+3Ogq8Wgjdz9ptPez81x2Kk2LJrBBIodVxz3KitQ2XB b/kk78C54BL3qq8F4+fvmbbBQROJ1WIMzHcBDIXx9g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudejuddgudehvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepfffhvffukfhfgggtuggjsehttd ertddttddvnecuhfhrohhmpehvohhiugcuoehvohhiugesfhdqmhdrfhhmqeenucggtffr rghtthgvrhhnpeekleduvdelhfeileefgffghfffkedtheellefgudfgvdegkeejjedutd ehhefgueenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhm pehvohhiugesfhdqmhdrfhhm X-ME-Proxy: Feedback-ID: i2541463c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Sat, 18 Feb 2023 16:56:44 -0500 (EST) Date: Sat, 18 Feb 2023 21:56:42 +0000 From: void To: freebsd-hackers@freebsd.org Subject: Re: avoiding periodic(8) during long poudriere runs Message-ID: Mail-Followup-To: freebsd-hackers@freebsd.org References: List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: X-Spamd-Result: default: False [-4.59 / 15.00]; DWL_DNSWL_LOW(-1.00)[messagingengine.com:dkim]; NEURAL_HAM_SHORT(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-0.999]; NEURAL_HAM_MEDIUM(-0.99)[-0.994]; DMARC_POLICY_ALLOW(-0.50)[f-m.fm,none]; MID_RHS_NOT_FQDN(0.50)[]; R_SPF_ALLOW(-0.20)[+ip4:64.147.123.21:c]; R_DKIM_ALLOW(-0.20)[f-m.fm:s=fm1,messagingengine.com:s=fm1]; MIME_GOOD(-0.10)[text/plain]; RCVD_IN_DNSWL_LOW(-0.10)[64.147.123.21:from]; PREVIOUSLY_DELIVERED(0.00)[freebsd-hackers@freebsd.org]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; TO_MATCH_ENVRCPT_ALL(0.00)[]; ARC_NA(0.00)[]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:29838, ipnet:64.147.123.0/24, country:US]; RCVD_COUNT_THREE(0.00)[4]; TO_DN_NONE(0.00)[]; FREEMAIL_FROM(0.00)[f-m.fm]; MLMMJ_DEST(0.00)[freebsd-hackers@freebsd.org]; DKIM_TRACE(0.00)[f-m.fm:+,messagingengine.com:+]; MIME_TRACE(0.00)[0:+]; FROM_EQ_ENVFROM(0.00)[]; FREEMAIL_ENVFROM(0.00)[f-m.fm]; RCVD_VIA_SMTP_AUTH(0.00)[] X-Rspamd-Queue-Id: 4PK2Zk1Sqrz3hqP X-Spamd-Bar: ---- X-ThisMailContainsUnwantedMimeParts: N On Sat, Feb 18, 2023 at 09:46:43PM +0100, Miroslav Lachman wrote: >I don't know about any generic way, but you can put some shell code into >/etc/periodic.conf to exit if load is too high > >Just a quick and dirty example, exit if 5 minutes avg is higher than 1.1: > >avg5load=$(top | awk '/load averages:/ { load=$7+0; if (load > 1.1) { >print "HIGH" } }') >echo $avg5load >if [ "$avg5load" = "HIGH" ]; then > echo "CPU load is too high" > exit 5 >fi Many thanks for this. I didn't know one could put scripting into periodic.conf! --