From nobody Tue Dec 14 19:06:53 2021 X-Original-To: freebsd-numerics@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id D59CD18E23A5 for ; Tue, 14 Dec 2021 19:07:09 +0000 (UTC) (envelope-from enh@google.com) Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JD7Cx12Mbz4ppl for ; Tue, 14 Dec 2021 19:07:06 +0000 (UTC) (envelope-from enh@google.com) Received: by mail-lf1-x12c.google.com with SMTP id d10so38724444lfg.6 for ; Tue, 14 Dec 2021 11:07:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:from:date:message-id:subject:to:cc; bh=A3okBxzTVyUqv4lgTmS0eOm9gK8rzhR/c3WN/S5dCw8=; b=Yjm3LLxJpGDT/pUqmhUvGLP1GHSMkPKVOw/Uvv2H8GFyEOdIXu7/Ax9uMRR/3WA62I +6pda4fPcRNPX84apU8QGbd3X4+qC0tbPIjsrsZnGVm19TagwHPLERB8rLacchWRSRfW DjxT84VlZWQ28ngTB8z4eLWLzLGhp9KIE8ZkNRS0dTHXXbIu9uRdJ74mVSVrTdZ7LJuH uBzE+Q3Hm+5Kk5UKx7G529QnigHbZKYKicUX6pxPG40SZpYEgW2hLWzPSounT6/X9zKC +5IYAIZWX78p2pyDEdiDcHkrNNmjFIyka2EAo6RuMvNl9r/CJ7jfIbxDpNBYo9ggP113 EAFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=A3okBxzTVyUqv4lgTmS0eOm9gK8rzhR/c3WN/S5dCw8=; b=SLz5CusywjimDMKofTbnV6x88jL4/DwwgAfPsh9nc889ZHt72aD8AIMLDyY+QqPHkr NvK67SFW804eCZ0gjsME6EKwjpLGk3NOEC5oQvq42Y0nOodIK8y0GOuwFfTQCrt+9uW6 o2Esqzp+yspFBhGNEg3pD/yyZ3MZGqpnVk0Cv8qCmwaLpDbh+iAD/zrnE09oJWGCuVuF Lw6IxsWlrtGLfMotmh8cdkiJb2RupaIHUcpyYINxBaLLCIv3iYsEXL7oz6nXO2HRopEd wEPEHtThs++nA4VEvaUrwimUC1XxoZNJ0dGTFHUPMHJr1FoxJ2jR0hf2rYdz0bxIQ+8s erDg== X-Gm-Message-State: AOAM530kxRtHEseMFjWkOo2jLMLLJnFj9KJf6sY+xzTgkn5qIU8QESjc C2vHSp0OjoJtZ6wtx4msJb5+ms7udoR731fhU6B4x1zvNi8UMg== X-Google-Smtp-Source: ABdhPJyac7fUbEG6uh7TsfiEMUy5eHI5KWMHO/dHZP73ANSEhO9gumWZYAIE52Npkfa9vP4JYCM4cImHjuISa1327Yo= X-Received: by 2002:a05:6512:230e:: with SMTP id o14mr6700342lfu.490.1639508824617; Tue, 14 Dec 2021 11:07:04 -0800 (PST) List-Id: Discussions of high quality implementation of libm functions List-Archive: https://lists.freebsd.org/archives/freebsd-numerics List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-numerics@freebsd.org MIME-Version: 1.0 Date: Tue, 14 Dec 2021 11:06:53 -0800 Message-ID: Subject: s_sincosl.c: remove unused variable To: freebsd-numerics@freebsd.org Cc: mmel@freebsd.org Content-Type: multipart/mixed; boundary="00000000000019b5ee05d31fe538" X-Rspamd-Queue-Id: 4JD7Cx12Mbz4ppl X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=pass header.d=google.com header.s=20210112 header.b=Yjm3LLxJ; dmarc=pass (policy=reject) header.from=google.com; spf=pass (mx1.freebsd.org: domain of enh@google.com designates 2a00:1450:4864:20::12c as permitted sender) smtp.mailfrom=enh@google.com X-Spamd-Result: default: False [-0.77 / 15.00]; ARC_NA(0.00)[]; NEURAL_SPAM_LONG(0.10)[0.105]; R_DKIM_ALLOW(-0.20)[google.com:s=20210112]; NEURAL_HAM_MEDIUM(-0.98)[-0.978]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36:c]; MIME_GOOD(-0.10)[multipart/mixed,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-numerics@freebsd.org]; TO_DN_NONE(0.00)[]; HAS_ATTACHMENT(0.00)[]; MIME_BASE64_TEXT_BOGUS(1.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[google.com:+]; MIME_BASE64_TEXT(0.10)[]; CTYPE_MIXED_BOGUS(1.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::12c:from]; RCPT_COUNT_TWO(0.00)[2]; NEURAL_HAM_SHORT(-1.00)[-1.000]; DMARC_POLICY_ALLOW(-0.50)[google.com,reject]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:+]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DWL_DNSWL_NONE(0.00)[google.com:dkim] Reply-To: enh@google.com From: enh via freebsd-numerics X-Original-From: enh X-ThisMailContainsUnwantedMimeParts: N --00000000000019b5ee05d31fe538 Content-Type: text/plain; charset="UTF-8" Newer versions of clang complain about this, and it seems genuinely unneeded. It was in the original commit, and judging from that I think it's just a copy & paste leftover from inlinine sinl() and cosl() --- the < M_PI_4 case in sinl() needs the original sign. (I've cc:ed the original author.) diff --git a/lib/msun/src/s_sincosl.c b/lib/msun/src/s_sincosl.c index aef36c2320b..3dd34575f89 100644 --- a/lib/msun/src/s_sincosl.c +++ b/lib/msun/src/s_sincosl.c @@ -50,11 +50,10 @@ void sincosl(long double x, long double *sn, long double *cs) { union IEEEl2bits z; - int e0, sgn; + int e0; long double y[2]; z.e = x; - sgn = z.bits.sign; z.bits.sign = 0; ENTERV(); --00000000000019b5ee05d31fe538 Content-Type: text/plain; charset="US-ASCII"; name="patch.txt" Content-Disposition: attachment; filename="patch.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kx6h0hi00 ZGlmZiAtLWdpdCBhL2xpYi9tc3VuL3NyYy9zX3NpbmNvc2wuYyBiL2xpYi9tc3VuL3NyYy9zX3Np bmNvc2wuYwppbmRleCBhZWYzNmMyMzIwYi4uM2RkMzQ1NzVmODkgMTAwNjQ0Ci0tLSBhL2xpYi9t c3VuL3NyYy9zX3NpbmNvc2wuYworKysgYi9saWIvbXN1bi9zcmMvc19zaW5jb3NsLmMKQEAgLTUw LDExICs1MCwxMCBAQCB2b2lkCiBzaW5jb3NsKGxvbmcgZG91YmxlIHgsIGxvbmcgZG91YmxlICpz biwgbG9uZyBkb3VibGUgKmNzKQogewogCXVuaW9uIElFRUVsMmJpdHMgejsKLQlpbnQgZTAsIHNn bjsKKwlpbnQgZTA7CiAJbG9uZyBkb3VibGUgeVsyXTsKIAogCXouZSA9IHg7Ci0Jc2duID0gei5i aXRzLnNpZ247CiAJei5iaXRzLnNpZ24gPSAwOwogCiAJRU5URVJWKCk7Cg== --00000000000019b5ee05d31fe538--