From nobody Sun May 7 18:29:08 2023 X-Original-To: stable@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QDtHH3KzYz49Knd for ; Sun, 7 May 2023 18:29:15 +0000 (UTC) (envelope-from SRS0=o+HB=A4=quip.cz=000.fbsd@elsa.codelab.cz) Received: from elsa.codelab.cz (elsa.codelab.cz [94.124.105.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4QDtHG0S7Rz4GVn for ; Sun, 7 May 2023 18:29:13 +0000 (UTC) (envelope-from SRS0=o+HB=A4=quip.cz=000.fbsd@elsa.codelab.cz) Authentication-Results: mx1.freebsd.org; dkim=none; spf=none (mx1.freebsd.org: domain of "SRS0=o+HB=A4=quip.cz=000.fbsd@elsa.codelab.cz" has no SPF policy when checking 94.124.105.4) smtp.mailfrom="SRS0=o+HB=A4=quip.cz=000.fbsd@elsa.codelab.cz"; dmarc=none Received: from elsa.codelab.cz (localhost [127.0.0.1]) by elsa.codelab.cz (Postfix) with ESMTP id F328BD789A for ; Sun, 7 May 2023 20:29:09 +0200 (CEST) Received: from [192.168.145.50] (ip-89-177-27-225.bb.vodafone.cz [89.177.27.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by elsa.codelab.cz (Postfix) with ESMTPSA id EDECED788A for ; Sun, 7 May 2023 20:29:08 +0200 (CEST) Message-ID: <0ff15452-ea25-d72e-58ae-6ed526b2615c@quip.cz> Date: Sun, 7 May 2023 20:29:08 +0200 List-Id: Production branch of FreeBSD source code List-Archive: https://lists.freebsd.org/archives/freebsd-stable List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-stable@freebsd.org X-BeenThere: freebsd-stable@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: etcupdate created empty files = system unbootable To: stable@freebsd.org References: <312ae63f-4fab-e194-c603-a85fd11f6edd@quip.cz> <0db3bbf1-9e98-d721-c734-fdfe2483cbf0@quip.cz> <95169DC0-5DB6-41D1-8B04-5A450094529F@FreeBSD.org> <19399711-4a71-7025-7ceb-8dd481ec0038@quip.cz> <7afb4128-3eef-f2d9-07c0-035a237cba45@quip.cz> <004e8a85-7bc1-6b33-8a42-70d7b43f9497@quip.cz> Content-Language: cs-Cestina From: Miroslav Lachman <000.fbsd@quip.cz> In-Reply-To: <004e8a85-7bc1-6b33-8a42-70d7b43f9497@quip.cz> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-1.58 / 15.00]; AUTH_NA(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.997]; NEURAL_HAM_MEDIUM(-0.78)[-0.781]; FORGED_SENDER(0.30)[000.fbsd@quip.cz,SRS0=o@elsa.codelab.cz]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[quip.cz]; ASN(0.00)[asn:42000, ipnet:94.124.104.0/21, country:CZ]; R_SPF_NA(0.00)[no SPF record]; MIME_TRACE(0.00)[0:+]; R_DKIM_NA(0.00)[]; MLMMJ_DEST(0.00)[stable@freebsd.org]; RCVD_TLS_LAST(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; TAGGED_FROM(0.00)[HB=A4=quip.cz=000.fbsd]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[stable@freebsd.org]; TO_DN_NONE(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; FROM_NEQ_ENVFROM(0.00)[000.fbsd@quip.cz,SRS0=o@elsa.codelab.cz] X-Rspamd-Queue-Id: 4QDtHG0S7Rz4GVn X-Spamd-Bar: - X-ThisMailContainsUnwantedMimeParts: N On 06/05/2023 09:33, Miroslav Lachman wrote: [..] > As you can see, cp failed, but etcupdate continued without any sign of > error. > cp failed because I did installkernel & installworld without rebooting. > I have never run into a problem like this in the past, but I understand > the reason - running the new 13.2 binary "cp" on an older 12.3 kernel is > not supported. > > > However, there is a bug in etcupdate which causes it to continue > silently instead of stopping when the first copy fails. > > This function needs to check the return status of cp and not blindly > return 0 even if the copy failed. In other words, the function > install_new() does not do what the comment says. This needs to be fixed. PR 271287 with attached patch https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=271287 Kind regards Miroslav Lachman