From nobody Thu Jun 1 16:42:42 2023 X-Original-To: sysinstall@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QXBkp3Ftgz4Yl7c for ; Thu, 1 Jun 2023 16:42:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QXBkp2DyZz3NTn for ; Thu, 1 Jun 2023 16:42:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1685637762; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CuShqBTRjTxL2+U2qz/orRIE6SZ5kkv4sK4C1f4ZOlw=; b=Jmz3k8gzmi9uLsQptDtF4w839R6ouQnAAxCXiYRrJezyTeFdgu/tQVpXMBCCTWmZauan6X u/YLxrqa7BqBSdKMXLqerh1DpUZi+EojboO0l2pzwGzhd7bTzPpf7kPwWcKNUWXdNiTEve gofPUtgj8M4oxN6epOj62h9d+2ugX/Q/qH9euwh4eJT/niQpAVm/TF8JPool3IYCKFpGu1 g/T/RpnDI58lMumfpZ9Z6cbXwwURUYWa8XJorrgj/w02r/s3Tz9rca1YJUCBRAGNecooRh 8x5cp6XM3omvYTh+TVHnQO9UwoTyN7WDZls+V3gYquY6mXytMqEWKkU+GAtOjg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1685637762; a=rsa-sha256; cv=none; b=SMqJMCByRm+GfoY5YEa1GgnHCkBdFeLKSaNFpYJv6f9DAapENgzbeQcG18Y2eSZSVBB0LE FHp6MCYrcFAM2XQxNTEuJq8rThyo5WRR7OL71YXfNNvpTk40FGghsl24n0pjRS44uklIKd 6wS/Dw1dQpPdELboEpkB//v4n/uxPnU9pP3m1iYAQcuPLrxPEiKy9iTymMcP8pCCNgOitn sIMCqauW0HYzRO47poMdijrSOCOJctWrXlzfjU6cxWnIIAH9u0ynGbG757XSxofcPRv1Il DaeljYV+Dc2Xrr50uT+kvsO7UMOzGaUTkki58LMBI/L2AJQsdhiSM+ud16sYpg== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4QXBkp1JWQzPfC for ; Thu, 1 Jun 2023 16:42:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 351GgggU064989 for ; Thu, 1 Jun 2023 16:42:42 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 351Ggg2e064988 for sysinstall@FreeBSD.org; Thu, 1 Jun 2023 16:42:42 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: sysinstall@FreeBSD.org Subject: [Bug 204506] bsdinstall(8) umount target should be able to unmount zfs filesystems Date: Thu, 01 Jun 2023 16:42:42 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 10.2-RELEASE X-Bugzilla-Keywords: install X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: jreynolds1729@gmail.com X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: sysinstall@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Sysinstall Work List-Archive: https://lists.freebsd.org/archives/freebsd-sysinstall List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-sysinstall@freebsd.org X-BeenThere: freebsd-sysinstall@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D204506 Jonathan Reynolds changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jreynolds1729@gmail.com --- Comment #7 from Jonathan Reynolds --- This still happens on 14-CURRENT. The issue: /usr/libexec/bsdinstall/umount fails if fstab is emtpty, which happens with= ZFS + BIOS boot. Two dialog box displaying /tmp/bsdinstall_log will be shown in succession (= user input required). The installation itself does succeed. Simple fix (main 9a49a3792940497ddf4657f6e5be56d8ef881edc): --- usr.sbin/bsdinstall/scripts/umount.orig 2023-06-01 18:17:39.4829440= 00 +0200 +++ usr.sbin/bsdinstall/scripts/umount 2023-06-01 18:18:20.275423000 +0200 @@ -46,6 +46,6 @@ }' > $TMP_FSTAB umount $BSDINSTALL_CHROOT/dev 2>/dev/null -if [ -n "$TMP_FSTAB" ]; then +if [ -n "$TMP_FSTAB" -a -s "$TMP_FSTAB" ]; then umount -F $TMP_FSTAB -a 2>/dev/null fi Note: The described issue does not happen if $debugFile is prepended with a plus = `+' sign. if $debugFile is prepended with a `+' in /etc/rc.local and the `+' sign is removed in /etc/installerconfig, the script will show one dialog box displa= ying /tmp/bsdinstall_log and an other showing success/reboot. --=20 You are receiving this mail because: You are the assignee for the bug.=