From nobody Sat Jul 1 01:00:11 2023 X-Original-To: sysinstall@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QtDPS1WgVz4l0R4 for ; Sat, 1 Jul 2023 01:00:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QtDPS0VQqz3xvm for ; Sat, 1 Jul 2023 01:00:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1688173212; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iUJIhSDEWQWkfoUi3ucS4UR1SJN4KnN18aM0nx2T0RU=; b=IcTtvu8LyCJX7wSN6nTvyRI9kMIAUtLBRZEJdMqWG3PZqcVosMrqelLnRjk9DcL7Ywf9Pm Hxh84kRHdbby/b8WwWfIesT5edaETZ6xbD+ZYYP4GnX4ax+zRP2VhI8qDAvf/EjP0NpZ2J 7N3DiA5sfLFiBmGs2b09sKphH9e1GmWx7EcCD3F4ml6xxJuYNKH8RZzjFt9zduwTPGBOv/ 6H/T93kmg+YD3IJDBYX3J9HqmO65vB8EZDlDs6mWt+S5c8VxImxQW+aatHwqGZBaWASUuR wKu8JjSZDFJR9wqAOiXtuD2E/+I+telots1ESYpM4MW6wyi4T7FmnpqzgypVlA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1688173212; a=rsa-sha256; cv=none; b=fPKR+dmkbQDhlHfTqn6VXgOu9n690xdUq9gWUF1mY6U77NtNZ54Ox3MaHvNC41+XLT5dJZ HrjkVFrv62ep7uJLmCGLSLez6rZyqlTqbpeHEn0HJNGl5y31e+Ba6eRc29qkZO8KePJUKJ CF2Nj3QQovbtjg33INN5Ymzf+AwAs7s3qtXbNEoguBQVDU2G80gfodExCkTUY7fRrMsYYu 7LmAdyHJQk77imzTDhpek8LzYgL/XpqK9+ZgoxmtJftXAJaN5JuJbDYlMAqwwK5s3VFrIN WgPxT/Zad8KCDRXVCJCsFEz13a36V+3c1qfxZW+MB4dVnfO1ZWCwcO7wNHobKg== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4QtDPR6Ywdz1KNS for ; Sat, 1 Jul 2023 01:00:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 36110BDE008130 for ; Sat, 1 Jul 2023 01:00:11 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 36110BQg008129 for sysinstall@FreeBSD.org; Sat, 1 Jul 2023 01:00:11 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: sysinstall@FreeBSD.org Subject: [Bug 271262] bsdinstaller in AutoZFS + MBR mode always wipes disklabel - rendering system non-bootable Date: Sat, 01 Jul 2023 01:00:11 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 13.2-RELEASE X-Bugzilla-Keywords: install X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: rcm@rcm.sh X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: sysinstall@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Sysinstall Work List-Archive: https://lists.freebsd.org/archives/freebsd-sysinstall List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-sysinstall@freebsd.org X-BeenThere: freebsd-sysinstall@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D271262 --- Comment #11 from R. Christian McDonald --- https://reviews.freebsd.org/D40816 diff --git a/usr.sbin/bsdinstall/scripts/zfsboot b/usr.sbin/bsdinstall/scripts/zfsboot --- a/usr.sbin/bsdinstall/scripts/zfsboot +++ b/usr.sbin/bsdinstall/scripts/zfsboot @@ -106,6 +106,11 @@ # : ${ZFSBOOT_BOOT_POOL_SIZE:=3D2g} +# +# Default offset for the boot pool when enabled (e.g., geli(8) or MBR) +# +: ${ZFSBOOT_BOOT_POOL_OFFSET:=3D2048} + # # Default disks to use (always empty unless being scripted) # @@ -1008,12 +1013,14 @@ # # Always prepare a boot pool on MBR - # Do not align this partition, there must not be a gap + # + # Offset the boot pool in order to protect the disk label + # and zfsboot from being clobbered by ZFS # ZFSBOOT_BOOT_POOL=3D1 f_eval_catch $funcname gpart \ "$GPART_ADD_ALIGN_INDEX_WITH_SIZE" \ - "" 1 freebsd-zfs ${bootsize}b ${disk}s1 || + "-b $ZFSBOOT_BOOT_POOL_OFFSET" 1 freebsd-zfs ${bootsize}b ${disk}s1 || return $FAILURE # Pedantically nuke any old labels f_eval_catch -d $funcname zpool "$ZPOOL_LABELCLEAR_F" \ @@ -1424,11 +1431,11 @@ fi f_dprintf "$funcname: Updating MBR boot loader on disks..." - # Stick the ZFS boot loader in the "convenient hole" after - # the ZFS internal metadata + # The boot pool is offset from the beginning of the slice in order + # to protect the disk label and zfsboot from being clobbere= d by ZFS for disk in $disks; do f_eval_catch $funcname dd "$DD_WITH_OPTIONS" \ - /boot/zfsboot /dev/$disk$bootpart \ + /boot/zfsboot /dev/${disk}s1 \ "skip=3D1 seek=3D1024" || return $FAIL= URE done --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Sun Jul 2 21:00:12 2023 X-Original-To: sysinstall@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QvLzd2Nkxz4lKQL for ; Sun, 2 Jul 2023 21:00:13 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QvLzd0nYvz3xwK for ; Sun, 2 Jul 2023 21:00:13 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1688331613; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ilV/P/gnQOe6AMbGPdRCDseM000l1oZSA0WTw95Zi18=; b=jim77x7Wcaj/ioYGNlMFE3e9JCuZ0CnQ98dg1lGohHyUj27heJIMt4r4Ji9/n7DHZoVmum SseDzwDwE8xx/8iBr+rZFl6UwltVZRgnBDXWKf5SDnu0AcJ8TnB90TS9fTgXYhJrfvnaXK nMx4uTVpU/C83rADR71nqztkEfIVJ2zlydx4+VVY2BCpgZyRF/0D1T4hGmL9aAg6La3Wtz IGF1+NGaEhB3ZO4xOjhW8hKp5rENaIEeth/gpdXp2GX2mKeJglXSJe30pLPAYvTlMDr9SU /TwuIGEKbft6zUqc2ngBoboY9K900mzlPKdUhfmVTtIMmQqb1lkMSN36peTnVQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1688331613; a=rsa-sha256; cv=none; b=BJDH+RA67lsOUb33DZVVOmRchzt5B/CAos3HrXKKpN0AKHgt7TKq6jmIaRhhI3YlOj+KnL cFszGbHSQkzqs3DYWNQR/P1JjV/tQlf6j7y8Wzn2B/5o+QV14ymkY0FmuxvA1C18uj27Ls U300WRiM2a31I2RGigGH+meFQSxzrwanLSCx0XKjSSa3WevceZtXwcUwxwxbI6Gk0+73oH AhilTzCNjMwOFzCi43fSbzc4L+6howVzkjVI80ExfP8HCoWGyAZ0nzfsv16oeH7hdcPOC4 smTrdd6fmMCrJSYg+jQq8+aidw7SlNtY62g8We6Gap2dOzTCoxDM5pFYrISLwQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4QvLzc70cCzNQX for ; Sun, 2 Jul 2023 21:00:12 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 362L0Crr046265 for ; Sun, 2 Jul 2023 21:00:12 GMT (envelope-from bugzilla-noreply@FreeBSD.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 362L0CPa046264 for sysinstall@FreeBSD.org; Sun, 2 Jul 2023 21:00:12 GMT (envelope-from bugzilla-noreply@FreeBSD.org) Message-Id: <202307022100.362L0CPa046264@kenobi.freebsd.org> X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@FreeBSD.org using -f From: bugzilla-noreply@FreeBSD.org To: sysinstall@FreeBSD.org Subject: Problem reports for sysinstall@FreeBSD.org that need special attention Date: Sun, 2 Jul 2023 21:00:12 +0000 List-Id: Sysinstall Work List-Archive: https://lists.freebsd.org/archives/freebsd-sysinstall List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-sysinstall@freebsd.org X-BeenThere: freebsd-sysinstall@freebsd.org MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="16883316128.cADFCa.44750" Content-Transfer-Encoding: 7bit X-ThisMailContainsUnwantedMimeParts: N --16883316128.cADFCa.44750 Date: Sun, 2 Jul 2023 21:00:12 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" To view an individual PR, use: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=(Bug Id). The following is a listing of current problems submitted by FreeBSD users, which need special attention. These represent problem reports covering all versions including experimental development code and obsolete releases. Status | Bug Id | Description ------------+-----------+--------------------------------------------------- Open | 198797 | bsdinstall: option to install BSD-Stats Open | 258696 | installer fails when using separate /root partiti 2 problems total for which you should take action. --16883316128.cADFCa.44750 Date: Sun, 2 Jul 2023 21:00:12 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" 
The following is a listing of current problems submitted by FreeBSD users,
which need special attention. These represent problem reports covering
all versions including experimental development code and obsolete releases.

Status      |    Bug Id | Description
------------+-----------+---------------------------------------------------
Open        |    198797 | bsdinstall: option to install BSD-Stats
Open        |    258696 | installer fails when using separate /root partiti

2 problems total for which you should take action.
--16883316128.cADFCa.44750--