From nobody Mon Nov 27 17:43:59 2023 X-Original-To: transport@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SfCcv4kynz536xt for ; Mon, 27 Nov 2023 17:43:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SfCcv2s4hz4F3J for ; Mon, 27 Nov 2023 17:43:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1701107039; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=NI5MGXNnrl8SK1dKkXOFrkPBW1haGJbs9z7IQXJt280=; b=nQeiKNQ2y2f1A9d97rtePlxpXkG2HeVCyyh66wLvXyAkrcLxi0oDENLsMqgzyPHjIXQXZh GUGy9lE3IIoJw6W2OiO6+aBcONc75CCxrnE+ByIH9sUdbqwlkyJkTvz3y/0kaiLViFufrS QNFuCu2f6E5hyBQlv4TwBxpR112S0sF/ZhE9dwYSlhv+4c+l/SG79fetcexk++OKYFlHm8 xKBD9N0LAsG4m34eWlmpneIy7GzkbFWeYXCxGLMATWL7Ee+lP9u0onuOmank33FJz2kGTR o4V48gNEFeHKdQ/UhMM4iYKosMBtwon1h/hsqORfyFAxLi4oUZBqT+A33qC0nA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1701107039; a=rsa-sha256; cv=none; b=KIXUk8rSZw4bpxLQ6cwxIsv4AkQemdXyvT6SzHdafzPj6Cosh2g/jcUVi3ICitEMb+RYX2 StFr86KiJrherO5uPXR52VUTNp6ECa62aK+K30QTFa+Of52cDGjhhDHXWk2rfrNpVE5P+E xbn47CN0labP9Ti7iGSApVWonSVGlHS2j+0Js8hwp0QB88/yA8aS8+dKxWhbQk4OiNDVe3 uh8ylqGBo8aITBCLkIK4/DYLE6o/ujaCeOM83CBKQAa8pMyIqPegsC936ZvJqy5v8jXT0S zrrmG3k7XpdejdhFrdlg3uMKuXOLGI6in6YJILe8fhA+yrpDg9iuFzB+s3KHGw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4SfCcv1wYSznd7 for ; Mon, 27 Nov 2023 17:43:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 3ARHhx2H095348 for ; Mon, 27 Nov 2023 17:43:59 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 3ARHhx2F095347 for transport@FreeBSD.org; Mon, 27 Nov 2023 17:43:59 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: transport@FreeBSD.org Subject: [Bug 275382] uninitialized memory use in __tcp_run_hpts() Date: Mon, 27 Nov 2023 17:43:59 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 14.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: markj@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: transport@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter cc Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Discussions List-Archive: https://lists.freebsd.org/archives/freebsd-transport List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-transport@freebsd.org X-BeenThere: freebsd-transport@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D275382 Bug ID: 275382 Summary: uninitialized memory use in __tcp_run_hpts() Product: Base System Version: 14.0-RELEASE Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: kern Assignee: transport@FreeBSD.org Reporter: markj@FreeBSD.org CC: glebius@FreeBSD.org, rrs@FreeBSD.org, tuexen@freebsd.org Coverity reports that tv.tv_sec is uninitialized when passed to tvtosbt(), which returns the timeout used for the HPTS callout. Presumably the intent= is to initialize it to 0? I also see that in tcp_run_hpts(), "hpts" is declared as static, but that is not thread safe and doesn't make sense to me. --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Mon Nov 27 19:18:48 2023 X-Original-To: transport@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SfFkJ53jNz5318V for ; Mon, 27 Nov 2023 19:18:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SfFkJ3zSFz3N1j for ; Mon, 27 Nov 2023 19:18:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1701112728; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WjSyZywdBqTKIxQx1fmNb6kklFD67ihT/YPGZ6yXb9E=; b=oPtaYhtr9+MM+A0OVfofaLiJfL/w7rSu7EqrRo4BCmDIi1+Mz7FJvjo2Ii5mXqvqm8aGUF k6X+7MFErHHAhFxfcApS4sbH966bkctd+bf25zMIFHKcxi3aMaUJVD+YfN+5wxKivh0iVJ siuuIGFQfiz9xcU7ki6vBMNb3ZDSU/GESZWyVrnUtwAi/XoK5PZM8JO7Ph+NtW1mpZpzh3 mJykHX/vWebGmDLZVsn6sBxglYXXWqYLa+J19dFIlpiexGLcHwogA6OQnsXoJIhk8aUJ19 /jbn9dm8iE9xAeVv2/8oAFU/4tCcw60EjDVK6Q4BfVp9ANnvzxebn+bCz8XfgQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1701112728; a=rsa-sha256; cv=none; b=t90oVjsQPm5aCsgtB596j4TY4qcgPgZKmetAMICaRuxCt7EEDQ0oPjFkPuHfofb0odb/rZ nm7sJKq21+XzUdvNryB7MqYJEcI7OpJVYMgqt1eUXgSdiDqb6xxU/KBCY4BEFurSx3dvUY AmjukaPJeLVkbvwGeuF3fznceWHSO8qKGq+qPnfWo33KQCROU3qrTB/CCtfqDgm/t62G/4 Y6dbCuD76PCmgQjrv48KWptJwVVO7UvGjKJ2p2oVrRt8YAs1OmC54EL1cyqNpZ3eO1CqyZ RVF+ZM3sl9jrnoD7fXf9zInzPCa+6xEkD13PsyY2MJcJLVucE7c27QkFEIFcFw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4SfFkJ2jkKzrBf for ; Mon, 27 Nov 2023 19:18:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 3ARJImE4047416 for ; Mon, 27 Nov 2023 19:18:48 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 3ARJImPE047415 for transport@FreeBSD.org; Mon, 27 Nov 2023 19:18:48 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: transport@FreeBSD.org Subject: [Bug 275382] uninitialized memory use in __tcp_run_hpts() Date: Mon, 27 Nov 2023 19:18:48 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 14.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: glebius@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: glebius@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_status assigned_to Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Discussions List-Archive: https://lists.freebsd.org/archives/freebsd-transport List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-transport@freebsd.org X-BeenThere: freebsd-transport@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D275382 Gleb Smirnoff changed: What |Removed |Added ---------------------------------------------------------------------------- Status|New |In Progress Assignee|transport@FreeBSD.org |glebius@FreeBSD.org --- Comment #1 from Gleb Smirnoff --- The second find is super weird! Thanks for reporting. I also noticed the re= cent Coverity report. --=20 You are receiving this mail because: You are the assignee for the bug.=