From nobody Tue Aug 15 17:51:28 2023 X-Original-To: xen@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RQJjX3ZZtz4qCJD for ; Tue, 15 Aug 2023 17:51:28 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RQJjX2Y5kz3F5L for ; Tue, 15 Aug 2023 17:51:28 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1692121888; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A0H5YYMsg/PbtV34jag8UnX02Hf3puwpjJidi2psmKE=; b=XtwXmG8NwFs/bw1RpKHQ5kq5Eagfo1HbdLdl/J6HVsDLRThr/TU/pvAYPp2VSEbJUivRxQ vdIU13dg8FJR0QMzDQ5GtfAqOZyEVDO9lDs2okk2LGE3fcOEeZWQ1Tcv5JdPo+xxTcCRGb /AldtVczNvaGYm6vT8lE5gsbhIle1OoD9P+gMgOUHt2k+kSSsmMS7BOJ/lRFjwTYfoPVAJ 6Q8WPSQneRlnUJyHI7NLhwH1HRCnLc9+uT//zJrGFb/8W1f2rGe4RYk8fo3DjjYakSHIxD eqW7I2q+Q49aqUeF/tSw75+Fl/jB8vBC9F5vvC1vbTCcwiWQ7yvYI0bw9Bt7Fg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1692121888; a=rsa-sha256; cv=none; b=xsLo3CDE6zlKhd3TVeVuJe7rcr76HAHAnx3HE/KnE6VGY3jPiHZcksX0y4XOB0Ka8LZKYN Lh0Cm+wshP+S6OpC08QnNuxF7AXuwRR7GpVLnEbwY7EkW71XZpCaFDQDNqLIqLzeyIKbL9 8gkze4/ZurUDgxRhcIBaFxq5rzY+YoIFvd9GK6/qO35TGlGUNRpLlPjgC23cjBvj5g+eme 0a/F31llOJ9hJy/+sfFJHl7Qs9D0gAamV4lhrFtzkkYQUJn0bbi1NE4RjIWjRHvvw9gJ9Y 9YaCmssGLu7IUxLd8oLy7/ZD0EFmkr9eC9zTHTtSnSNpejzyVEnIaEN8MjVDHw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4RQJjX1XMKz48y for ; Tue, 15 Aug 2023 17:51:28 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 37FHpSux085187 for ; Tue, 15 Aug 2023 17:51:28 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 37FHpSEB085186 for xen@FreeBSD.org; Tue, 15 Aug 2023 17:51:28 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: xen@FreeBSD.org Subject: [Bug 273046] xn: xen netfront does LRO even if packet forwarding is enabled Date: Tue, 15 Aug 2023 17:51:28 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.2-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: royger@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: xen@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Discussion List-Archive: https://lists.freebsd.org/archives/freebsd-xen List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-xen@freebsd.org X-BeenThere: freebsd-xen@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D273046 --- Comment #5 from Roger Pau Monn=C3=A9 --- I once tried to fix this, but my knowledge of networking internals is not t= hat good. I came up with: https://reviews.freebsd.org/D6656 https://reviews.freebsd.org/D6612 https://reviews.freebsd.org/D6611 I was hoping that someone from the net side would pick those up. --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Fri Oct 20 10:52:24 2023 X-Original-To: xen@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SBhHY1RJVz4xdLL for ; Fri, 20 Oct 2023 10:52:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SBhHY0MM9z4W67 for ; Fri, 20 Oct 2023 10:52:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1697799145; a=rsa-sha256; cv=none; b=rKLetK53E7bLDPBD+dR55j14irHaLJgsG5FUXmPke7JW0ZT/rvj2iiS8QjqFOsA9MeJcG5 juWssq8t6yA2RBaqo34fRb02oE+b6k7uUUlGbE3zDe+KsPVCIBVVVygvx3sFk4Qg2aoL+m Jc9m4OLlXApK7YpV9IaWwv23cLhCzHQX8af3yeBPzw95T8eavN6P+wc0SgrFuCiRwTqDda 5p8aF5n5mEO6Vx2dPN6tanVKIFICVPVRgJqghPZp0Gn4xPOxUoOKPzZTb1g7YDg/Q7Vnvx n8zc31/ng+3wNbjfOHUWjWQAtFIrYZYLf0SWbQjE7IY1BCBVwvxHTAATclHBOg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1697799145; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y1FbezuSGqlDH6v3HQi69PstyltpmOIfOoRgDXtv4rI=; b=CakNgrz6cfcEk+WanwE9aNJ3KsMTxDGz1iIDg+v0AfrX2/Iqg0UF77uPE0os7w8odv9O2k M0mW/Si2fUTz016o2b7pEmoOn0N0YvBTYKKrNrmgKD4redMjIgA7DZZvFG0ejMXS0HhqWr mxWMDBDEMYpGtHZ5SPsypG4izTCG7lZG+V6ZgsBcl8oDmogTYEhQYlV5gO8sBuxJmYlfUh VqtaawjpBgJaap82UVA2fnznUKXzZiBNf+WkQkxiY4vgpVvXY7+tEBlZ0DdxFoG5FhX0FM FTkt7kA34p241TrAD2qibKW7+CxuyVDCdZLGYwuWhDGL7pL18SUe5VPDu8nTwA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4SBhHX6XXTzW9v for ; Fri, 20 Oct 2023 10:52:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 39KAqO4o076919 for ; Fri, 20 Oct 2023 10:52:24 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 39KAqORV076917 for xen@FreeBSD.org; Fri, 20 Oct 2023 10:52:24 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: xen@FreeBSD.org Subject: [Bug 273046] xn: xen netfront does LRO even if packet forwarding is enabled Date: Fri, 20 Oct 2023 10:52:24 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.2-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: xen@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Discussion List-Archive: https://lists.freebsd.org/archives/freebsd-xen List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-xen@freebsd.org X-BeenThere: freebsd-xen@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D273046 --- Comment #6 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3Dda4b0d6eb06d730487d48e15d2d5e10c5= 6266fd9 commit da4b0d6eb06d730487d48e15d2d5e10c56266fd9 Author: Doug Rabson AuthorDate: 2023-08-12 13:19:47 +0000 Commit: Doug Rabson CommitDate: 2023-10-20 10:50:20 +0000 netfront: fix the support for disabling LRO at boot time The driver has a tunable hw.xn.enable_lro which is intended to control whether LRO is enabled. This is currently non-functional - even if its set to zero, the driver still requests LRO support from the backend. This change fixes the feature so that if enable_lro is set to zero, LRO no longer appears in the interface capabilities and LRO is not requested from the backend. PR: 273046 MFC after: 1 week Reviewed by: royger Differential Revision: https://reviews.freebsd.org/D41439 sys/dev/xen/netfront/netfront.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=