From nobody Mon Aug 26 04:53:19 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Wsdbg5Qg3z5VCDN; Mon, 26 Aug 2024 04:53:19 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Wsdbg4npBz54XQ; Mon, 26 Aug 2024 04:53:19 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724647999; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lFpepENUAm5HS9itt8K+jfRp2XklO5PIZ4n7c6XXVGA=; b=q1CMb+dzU1dzqOUHPh2+F7zpI7c/XMb6pMLw2LGqe/zSYcbJ/pZviFYgHATU2ZUupTQq9G Luxse5H9sRBM/oHrdT2r3x5dmwNgXV5rNqJoNgMLE2iCiyelzoXpOmZmm5x3RHgOGMZjvS eilt3FcGGR//1BxJBF2ON468nkXv6EZqEXFeXb1CILJhYBHaeietZSh95Q8R6I2j9AP7N3 YsdNZn77yL/tAPhX2tUGgHcIHqmeRJqNvk35YQX4lSvVbZhV+52l4SVnKQg4N96Y7kJvBN pLSH4SbYCnt2WKIu2uGZe9emGjpu+sbiZWWMU/EWZnqcDHsPSqs7AwpdYXRSmQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724647999; a=rsa-sha256; cv=none; b=dwb7yME9wSJxPeWVDYofev8Nad5NanLkFSJxOS6zNEMeGegVZpo/ZlPOWjo/HBZd94vXvr IA58hHyrwhQ9V4N+E47QMAToJVbCkbrtRPzU0OM3FO67G32R/fxOkyJOFEJiIV7gJcQVTu WSDM6ftJGDpf6RkCr/1VVFMc495cstVgcgYyW3m4NrAK9ef3+5qd7VHhaj3Rl1WMKji6n9 U8TnefY3CzT7qSlCTQjrLhT5u87ZHOIy531UNPuJHDQPKGxSo9Z0ItgzwMCCflDltDvv0r RRBcIQm7xki/THaNFlJ00M7nsWKGhR+QjwT87oUbJX1nZeXGbx7edtVzp2pfjA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724647999; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lFpepENUAm5HS9itt8K+jfRp2XklO5PIZ4n7c6XXVGA=; b=moGHUvb1N6ycbSqeHnqECelz4tvDWWoZKpT6YNyzJeOdY3xUu2xY3G3UFSUzv30hqwvKqU AuBVU5wB4ODNmCXfWEWfUtfuZkwk3FJglSvvqNVyM1ANlvNm/Y/ocMd3WBA1YTHMsXjm3I 3oqb50mf8TFdTwjgLmO3uADCSf09k3SGhNuxbNVJDHD0stYekDB3QjBtDkodArvYdnuovk BDGkAvafw8HMQl/B2nY3NOq2hy5q8eGZLglq6KmWPewTaWYv2b16uxzZaX3M8D47+cEO5t SzxLKbFqLfW+d6FNU7BMUoBviAWEelL0eGCBewJsSQKmqErwlFJdTlVw+WNCkQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Wsdbg4NqDzt1B; Mon, 26 Aug 2024 04:53:19 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47Q4rJjU099725; Mon, 26 Aug 2024 04:53:19 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47Q4rJ6J099722; Mon, 26 Aug 2024 04:53:19 GMT (envelope-from git) Date: Mon, 26 Aug 2024 04:53:19 GMT Message-Id: <202408260453.47Q4rJ6J099722@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Alex Richardson Subject: git: 04262ed78d23 - main - rtld-elf: Add CFI annotation for .rtld_start on RISC-V List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: arichardson X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 04262ed78d2368a9e1f64755fb92a22872a20cac Auto-Submitted: auto-generated The branch main has been updated by arichardson: URL: https://cgit.FreeBSD.org/src/commit/?id=04262ed78d2368a9e1f64755fb92a22872a20cac commit 04262ed78d2368a9e1f64755fb92a22872a20cac Author: Alex Richardson AuthorDate: 2024-08-26 04:51:55 +0000 Commit: Alex Richardson CommitDate: 2024-08-26 04:51:55 +0000 rtld-elf: Add CFI annotation for .rtld_start on RISC-V Without this change, unwinders such as LLVM libunwind will attempt to unwind beyond the start of RTLD and get stuck in an infinite loop or crash (depending on the current values on the stack). This fixes an infinite loop in the LLVM libunwind test suite on RISC-V. See also https://reviews.freebsd.org/D40844 for AArch64 Reviewed By: #riscv, jhb MFC After: 2 weeks Differential Revision: https://reviews.freebsd.org/D46406 --- libexec/rtld-elf/riscv/rtld_start.S | 1 + 1 file changed, 1 insertion(+) diff --git a/libexec/rtld-elf/riscv/rtld_start.S b/libexec/rtld-elf/riscv/rtld_start.S index 5459089fa1e6..e0b8157c964f 100644 --- a/libexec/rtld-elf/riscv/rtld_start.S +++ b/libexec/rtld-elf/riscv/rtld_start.S @@ -39,6 +39,7 @@ */ ENTRY(.rtld_start) + .cfi_undefined ra /* Do not attempt to unwind any further. */ mv s0, a0 /* Put ps_strings in a callee-saved register */ mv s1, sp /* And the stack pointer */ From nobody Mon Aug 26 14:29:29 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WstNT383xz5T1fJ; Mon, 26 Aug 2024 14:29:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WstNT2X7Yz4kPg; Mon, 26 Aug 2024 14:29:29 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724682569; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+/v6V61DCdThUGbF1mjkKntRR6vdkub3JMTNyeCex7s=; b=TW8kF89athcIWGG4kaQ3+fr+q00uqfxt/pQN1/KbHZYJfYj3hk27EPZSiF7V8yzw1uCUeW YOwVNMNC2ONs/effCeyk/guXfziDXBtFAwy5/WGmlSTaoaxpfV4ZpRe+2vlrpXFDMP99Dx +E/lUWUFKkw1B9UigDnR5pDygs0LEVKbIS7Z3HLpy5uyCPMgzEL2aok/NcF3BcqjB1KBzs pjKcYVilFWJHfYfIXUX0bYjuIZmnt/HIW3zkjDeIeYsNtWK+FPQvxK4bDM4rN1hRYZReBs 4jIotYMh3g+YMvlTvUZxFSy31mQzf24ZAALl9Nni2dm9TGKl2W7nTPz5rZG/mQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724682569; a=rsa-sha256; cv=none; b=h0llTvtjtUJnV17H196/RUtJx4bkWkFhZ3aiKwFAsIRIDsbhuEhkSODZ1tvjaAJdSZIIG/ xmGBdzbJDPv//SlEbKctvfNAo2ceoULuNzJrnklRpI3FeODo0w50f1j+ztzpr2Dx2rrQIL mMEvHl96Xqc3SDUF162XlTG7DpjZG9LkcSg03uu5S8UaWBQ6uqYyeQXQNvNCq64al6ISTm dacoS9TQVb2Rz/WEDPrmjiW9MCOc35GfUkRK2jwpSjna/Elijs6ghXBfBpytE8Uj0HElZg K6BFuX6d62gXq2X5dGD5sKemnSNVLqw1iyXDv4EOhDL3eoZSSdjIy9z5Ks6lww== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724682569; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+/v6V61DCdThUGbF1mjkKntRR6vdkub3JMTNyeCex7s=; b=YDrVzxJc1lECQFXXLAOIGeoNY0bSSBR6fryN5Byf7raKp6qEJNNW3pvYt2pXuZOhlLsj1Y FTaVT0flyDD1WCRyECAvo4T8yHjNc7Qa9qsNqH29YZaniOuCXWH7emQdlhLDNJG9I8rb/z tEX2aVoTXUYt/awMArqEuvsHQGh0VYqgyw9XjJaC1ftUInA//fsQ25G6pgRy9SXL+pf9DF 954c3RKlKmCn99v6HMR0S7QnGnCfVuzYeQBwa9yrcd2PNRS/JIH5RUqDAV708/AKRneM+5 +AvsQDUW42XGp4rpeLoeO4HKOhxogRzhhQcEhuVwM69hTSOnjd0qwRaIPDz1Bg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WstNT1nlFz18Z1; Mon, 26 Aug 2024 14:29:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47QETTDA070150; Mon, 26 Aug 2024 14:29:29 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47QETTWx070147; Mon, 26 Aug 2024 14:29:29 GMT (envelope-from git) Date: Mon, 26 Aug 2024 14:29:29 GMT Message-Id: <202408261429.47QETTWx070147@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: 49a5fe1a017f - main - asmc: Add support for MacbookPro11,4 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 49a5fe1a017fc179c79b74f409440e070511a0ab Auto-Submitted: auto-generated The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=49a5fe1a017fc179c79b74f409440e070511a0ab commit 49a5fe1a017fc179c79b74f409440e070511a0ab Author: Joshua Rogers AuthorDate: 2024-06-11 19:51:51 +0000 Commit: Mark Johnston CommitDate: 2024-08-26 14:27:58 +0000 asmc: Add support for MacbookPro11,4 Signed-off-by: Joshua Rogers MFC after: 2 weeks Pull Request: https://github.com/freebsd/freebsd-src/pull/1366 --- sys/dev/asmc/asmc.c | 6 ++++++ sys/dev/asmc/asmcvar.h | 34 ++++++++++++++++++++++++++++++++++ 2 files changed, 40 insertions(+) diff --git a/sys/dev/asmc/asmc.c b/sys/dev/asmc/asmc.c index ab0a614aa50f..f321a3cdc5f7 100644 --- a/sys/dev/asmc/asmc.c +++ b/sys/dev/asmc/asmc.c @@ -278,6 +278,12 @@ static const struct asmc_model asmc_models[] = { ASMC_MBP113_TEMPS, ASMC_MBP113_TEMPNAMES, ASMC_MBP113_TEMPDESCS }, + { + "MacBookPro11,4", "Apple SMC MacBook Pro Retina Core i7 (mid 2015, 15-inch)", + ASMC_SMS_FUNCS_DISABLED, ASMC_FAN_FUNCS, ASMC_LIGHT_FUNCS, + ASMC_MBP114_TEMPS, ASMC_MBP114_TEMPNAMES, ASMC_MBP114_TEMPDESCS + }, + /* The Mac Mini has no SMS */ { "Macmini1,1", "Apple SMC Mac Mini", diff --git a/sys/dev/asmc/asmcvar.h b/sys/dev/asmc/asmcvar.h index 42e3120ff4ff..73a8fc449c2c 100644 --- a/sys/dev/asmc/asmcvar.h +++ b/sys/dev/asmc/asmcvar.h @@ -432,6 +432,40 @@ struct asmc_softc { "TM0S", "TP0P", "TPCD", "TW0P", "Ta0P", \ "TaSP", "Th1H", "Th2H", "Ts0P", "Ts0S", \ "Ts1S" } + +#define ASMC_MBP114_TEMPS { "IC0C", "ID0R", "IHDC", "IPBR", "IC0R", \ + "IO3R", "IO5R", "IM0C", "IC1C", "IC2C", \ + "IC3C", "ILDC", "IBLC", "IAPC", "IHSC", \ + "ICMC", "TC0P", "TP0P", "TM0P", \ + "Ta0P", "Th2H", "Th1H", "TW0P", "Ts0P", \ + "Ts1P", "TB0T", "TB1T", "TB2T", "TH0A", "TH0B", \ + "TC1C", "TC2C", "TC3C", "TC4C", "TCXC", \ + "TCGC", "TPCD", "TCSA", "VC0C", "VD0R", \ + "VP0R", "ALSL", "F0Ac", "F1Ac", "PCPC", \ + "PCPG", "PCPT", "PSTR", "PDTR", NULL } + +#define ASMC_MBP114_TEMPNAMES { "IC0C", "ID0R", "IHDC", "IPBR", "IC0R", \ + "IO3R", "IO5R", "IM0C", "IC1C", "IC2C", \ + "IC3C", "ILDC", "IBLC", "IAPC", "IHSC", \ + "ICMC", "TC0P", "TP0P", "TM0P", \ + "Ta0P", "Th2H", "Th1H", "TW0P", "Ts0P", \ + "Ts1P", "TB0T", "TB1T", "TB2T", "TH0A", "TH0B", \ + "TC1C", "TC2C", "TC3C", "TC4C", "TCXC", \ + "TCGC", "TPCD", "TCSA", "VC0C", "VD0R", \ + "VP0R", "ALSL", "F0Ac", "F1Ac", "PCPC", \ + "PCPG", "PCPT", "PSTR", "PDTR" } + +#define ASMC_MBP114_TEMPDESCS { "CPU High (CPU, I/O)", "DC In", "SSD", "Charger (BMON)", "CPU", \ + "Other 3.3V", "Other 5V", "Memory", "Platform Controller Hub Core", "CPU Load Current Monitor", \ + "CPU DDR", "LCD Panel", "LCD Backlight", "Airport", "Thunderbolt", \ + "S2", "CPU Proximity", "Platform Controller Hub", "Memory Proximity", "Air Flow Proximity", \ + "Left Fin Stack", "Right Fin Stack", "Airport Proximity", "Palm Rest", "Palm Rest Actuator", \ + "Battery Max", "Battery Sensor 1", "Battery Sensor 2", "SSD A", "SSD B", \ + "CPU Core 1", "CPU Core 2", "CPU Core 3", "CPU Core 4", "CPU PECI Die", \ + "Intel GPU", "Platform Controller Hub PECI", "CPU System Agent Core", "CPU VCore", "DC In", \ + "Pbus", "Ambient Light", "Leftside", "Rightside", "CPU Package Core", \ + "CPU Package GPU", "CPU Package Total", "System Total", "DC In" } + #define ASMC_MM_TEMPS { "TN0P", "TN1P", NULL } #define ASMC_MM_TEMPNAMES { "northbridge1", "northbridge2" } #define ASMC_MM_TEMPDESCS { "Northbridge Point 1", \ From nobody Mon Aug 26 16:28:13 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Wsx1T5kD9z5TCbX; Mon, 26 Aug 2024 16:28:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Wsx1T5Nspz4vpY; Mon, 26 Aug 2024 16:28:13 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724689693; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=1PtLT7ejOlTSPiAF62ZwtqFee9ZXWL0W0lEhY3/0G8o=; b=JY3GFB+5i1Sf/W+LhYpfllJ6VA2QFpdD6LHPlzPmEx8bT+l6TDbtW+oI4h7F6KONnNZYwI aFfyL80HIvix05QK0gEqDmsBxVjj3zIHW+4VfP0l90qdGPCTfQbY5V0AUofkTur7QdWB4c XPKOZL50PInFa15NDfFPBy4abwqqsTZWAQIjnDEIHbJzrhX0nXPjd2TkhW6toR9x9NUsAy 2yYdwCefJNIl35QWPwO7RlyhJUahPlKz1gYas5bjbTEr4G1h6FuTOFxhyFyRrlud4QcuU4 uAUwrt15j/Gr3e17ndJIL852cHetmQAYXeu+nqsndAJUzU4qPbL/zf+d/43Jpg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724689693; a=rsa-sha256; cv=none; b=ZARx9ZOkP76V/f/c8zY4MRTGeBEtaWqaMoVlCUOyAgDnKfpFcuEhvOUrzjcrrd4k3T4oiu uK1RI4ugbxNHJfi4Ro/gNUPxw+5GPJpM+rY5Gj9UYC1tifsHI3j447FS4GQrVwCxNMTIpA tC/EC3dUHual9B1osXJ/99xO0wSjUDAvKDuReDMp066TpC+FZRi0VWSThXCKLeCGuObORT qdJDCPMYx/duzME6M0A0ZqdTBoe4LD8k6c0iuAxSnP4ZW9QMYhhCtwfH6lzbZsVbceZHbN izioR751G5J+Kvq6v1X1zv8dUYWNAUEJSqGGJ2rs66DXc9JxEdTZzsJuJToaXw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724689693; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=1PtLT7ejOlTSPiAF62ZwtqFee9ZXWL0W0lEhY3/0G8o=; b=JHNl32gJd11rxYUwbE7AeUnuyYUJydADANkk0V32PvDICkTCWlWgl7zIbnsrlyLMEsnf2K u3QDJGJ6bMmRwMJxfDmLjDJXKrwVghe7vhigdYWRU5Ip+6vuviDFBjeY9xmTPwsffnDVbd KpOtxxLCNtuosKkbxplnG4y9EY+QaYL3IS8/sMvqPXGRqbOdt4Wt7RAf5IVadVc60sT/GD XejkyJXWLs63FWxwvdyncx92ntDASOxEyLRNAaQYIGIiOHXXOXWrLthgRtHYCTroFuSXZj GEH7ahAdEtaVWYhOIZ8lLyv3KRJZAR7YACtGWtkX++cu0KFdXBwBpKseT8Kjhg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Wsx1T4hV0zDrd; Mon, 26 Aug 2024 16:28:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47QGSDfc072641; Mon, 26 Aug 2024 16:28:13 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47QGSD1E072637; Mon, 26 Aug 2024 16:28:13 GMT (envelope-from git) Date: Mon, 26 Aug 2024 16:28:13 GMT Message-Id: <202408261628.47QGSD1E072637@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Stefan =?utf-8?Q?E=C3=9Fer?= Subject: git: 12e0d316644a - main - vendor/bc: upgrade to version 7.0.0 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: se X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 12e0d316644a4f80f5f1f78cf07bd93def43b1ca Auto-Submitted: auto-generated The branch main has been updated by se: URL: https://cgit.FreeBSD.org/src/commit/?id=12e0d316644a4f80f5f1f78cf07bd93def43b1ca commit 12e0d316644a4f80f5f1f78cf07bd93def43b1ca Author: Stefan Eßer AuthorDate: 2024-08-23 16:45:58 +0000 Commit: Stefan Eßer CommitDate: 2024-08-26 16:27:29 +0000 vendor/bc: upgrade to version 7.0.0 This is a production release to fix three bugs, none of which affects well formed scripts on FreeBSD: The first bug is that bc/dc will exit on macOS when the terminal is resized. The second bug is that an array, which should only be a function parameter, was accepted as part of larger expressions. The third bug is that the value stack for dc was cleared on any error. However, this is not how other dc behave. To bring dc more in line with other implementations, this behavior was changed. This change is why this version is a new major version. (cherry picked from commit 54d20d67e2af28d948ce2df13feb039fa10900fc) MFC after: 3 days --- contrib/bc/Makefile.in | 10 +++- contrib/bc/NEWS.md | 14 +++++ contrib/bc/compile_flags.txt | 1 + contrib/bc/configure.sh | 120 ++++++++++++++++++++++++++++++-------- contrib/bc/include/args.h | 2 +- contrib/bc/include/bc.h | 2 +- contrib/bc/include/dc.h | 2 +- contrib/bc/include/opt.h | 6 +- contrib/bc/include/ossfuzz.h | 79 +++++++++++++++++++++++++ contrib/bc/include/status.h | 25 ++------ contrib/bc/include/version.h | 2 +- contrib/bc/include/vm.h | 2 +- contrib/bc/manuals/dc/A.1 | 7 ++- contrib/bc/manuals/dc/A.1.md | 9 ++- contrib/bc/manuals/dc/E.1 | 7 ++- contrib/bc/manuals/dc/E.1.md | 9 ++- contrib/bc/manuals/dc/EH.1 | 7 ++- contrib/bc/manuals/dc/EH.1.md | 9 ++- contrib/bc/manuals/dc/EHN.1 | 7 ++- contrib/bc/manuals/dc/EHN.1.md | 9 ++- contrib/bc/manuals/dc/EN.1 | 7 ++- contrib/bc/manuals/dc/EN.1.md | 9 ++- contrib/bc/manuals/dc/H.1 | 7 ++- contrib/bc/manuals/dc/H.1.md | 9 ++- contrib/bc/manuals/dc/HN.1 | 7 ++- contrib/bc/manuals/dc/HN.1.md | 9 ++- contrib/bc/manuals/dc/N.1 | 7 ++- contrib/bc/manuals/dc/N.1.md | 9 ++- contrib/bc/scripts/os.c | 59 +++++++++++++++++++ contrib/bc/src/args.c | 4 +- contrib/bc/src/bc.c | 3 +- contrib/bc/src/bc_fuzzer.c | 112 +++++++++++++++++++++++++++++++++++ contrib/bc/src/bc_lex.c | 2 + contrib/bc/src/bc_parse.c | 23 +++++++- contrib/bc/src/data.c | 59 +++++++++++++++++++ contrib/bc/src/dc.c | 3 +- contrib/bc/src/dc_fuzzer.c | 112 +++++++++++++++++++++++++++++++++++ contrib/bc/src/dc_lex.c | 2 + contrib/bc/src/history.c | 2 +- contrib/bc/src/lang.c | 4 +- contrib/bc/src/lex.c | 8 +++ contrib/bc/src/main.c | 21 +++++-- contrib/bc/src/num.c | 4 ++ contrib/bc/src/opt.c | 14 ++--- contrib/bc/src/program.c | 13 +++-- contrib/bc/src/vm.c | 38 ++++++++++-- contrib/bc/tests/bc/errors/37.txt | 37 ++++++++++++ contrib/bc/tests/bc/errors/38.txt | 37 ++++++++++++ contrib/bc/vs/bc.vcxproj | 18 +++--- include/ossfuzz.h | 79 +++++++++++++++++++++++++ 50 files changed, 914 insertions(+), 133 deletions(-) diff --git a/contrib/bc/Makefile.in b/contrib/bc/Makefile.in index 4adb76ddaa17..c63dc242e79a 100644 --- a/contrib/bc/Makefile.in +++ b/contrib/bc/Makefile.in @@ -94,6 +94,10 @@ BC = bc DC = dc BC_EXEC = $(BIN)/$(EXEC_PREFIX)$(BC) DC_EXEC = $(BIN)/$(EXEC_PREFIX)$(DC) +BC_FUZZER = $(BIN)/$(BC)_fuzzer_c +BC_FUZZER_C = $(BIN)/$(BC)_fuzzer_C +DC_FUZZER = $(BIN)/$(DC)_fuzzer_c +DC_FUZZER_C = $(BIN)/$(DC)_fuzzer_C BC_TEST_OUTPUTS = tests/bc_outputs BC_FUZZ_OUTPUTS = tests/fuzzing/bc_outputs1 tests/fuzzing/bc_outputs2 tests/fuzzing/bc_outputs3 @@ -149,8 +153,11 @@ BC_ENABLE_NLS = %%NLS%% BC_EXCLUDE_EXTRA_MATH = %%EXCLUDE_EXTRA_MATH%% BC_ENABLE_AFL = %%FUZZ%% +BC_ENABLE_OSSFUZZ = %%OSSFUZZ%% BC_ENABLE_MEMCHECK = %%MEMCHECK%% +LIB_FUZZING_ENGINE = %%LIB_FUZZING_ENGINE%% + BC_DEFAULT_BANNER = %%BC_DEFAULT_BANNER%% BC_DEFAULT_SIGINT_RESET = %%BC_DEFAULT_SIGINT_RESET%% DC_DEFAULT_SIGINT_RESET = %%DC_DEFAULT_SIGINT_RESET%% @@ -210,7 +217,8 @@ CPPFLAGS5 = $(CPPFLAGS4) -DBC_NUM_KARATSUBA_LEN=$(BC_NUM_KARATSUBA_LEN) CPPFLAGS6 = $(CPPFLAGS5) -DBC_ENABLE_NLS=$(BC_ENABLE_NLS) CPPFLAGS7 = $(CPPFLAGS6) -D$(BC_ENABLE_EXTRA_MATH_NAME)=$(BC_ENABLE_EXTRA_MATH) CPPFLAGS8 = $(CPPFLAGS7) -DBC_ENABLE_HISTORY=$(BC_ENABLE_HISTORY) -DBC_ENABLE_LIBRARY=$(BC_ENABLE_LIBRARY) -CPPFLAGS = $(CPPFLAGS8) -DBC_ENABLE_MEMCHECK=$(BC_ENABLE_MEMCHECK) -DBC_ENABLE_AFL=$(BC_ENABLE_AFL) +CPPFLAGS9 = $(CPPFLAGS8) -DBC_ENABLE_MEMCHECK=$(BC_ENABLE_MEMCHECK) -DBC_ENABLE_AFL=$(BC_ENABLE_AFL) +CPPFLAGS = $(CPPFLAGS9) -DBC_ENABLE_OSSFUZZ=$(BC_ENABLE_OSSFUZZ) CFLAGS = $(CPPFLAGS) $(BC_DEFS) $(DC_DEFS) %%CPPFLAGS%% %%CFLAGS%% LDFLAGS = %%LDFLAGS%% diff --git a/contrib/bc/NEWS.md b/contrib/bc/NEWS.md index 95de7e5182c4..1775fa0b6533 100644 --- a/contrib/bc/NEWS.md +++ b/contrib/bc/NEWS.md @@ -1,5 +1,19 @@ # News +## 7.0.0 + +This is a production release to fix three bugs. + +The first bug is that `bc`/`dc` will exit on macOS when the terminal is resized. + +The second bug is that an array, which should only be a function parameter, was +accepted as part of larger expressions. + +The third bug is that value stack for `dc` was cleared on any error. However, +this is not how other `dc` behave. To bring `dc` more in line with other +implementations, this behavior was changed. This change is why this version is a +new major version. + ## 6.7.6 This is a production release to fix one bug. diff --git a/contrib/bc/compile_flags.txt b/contrib/bc/compile_flags.txt index 7a08c87f3876..3324798013c6 100644 --- a/contrib/bc/compile_flags.txt +++ b/contrib/bc/compile_flags.txt @@ -13,3 +13,4 @@ -DBC_ENABLE_EXTRA_MATH=1 -DBC_ENABLE_HISTORY=1 -DBC_ENABLE_NLS=1 +-DBC_ENABLE_OSSFUZZ=0 diff --git a/contrib/bc/configure.sh b/contrib/bc/configure.sh index 43bb502ea817..442165d15693 100755 --- a/contrib/bc/configure.sh +++ b/contrib/bc/configure.sh @@ -68,7 +68,7 @@ usage() { printf ' [--man3dir=MAN3DIR]\n' if [ "$_usage_val" -ne 0 ]; then - exit + exit "$_usage_val" fi printf '\n' @@ -181,6 +181,8 @@ usage() { printf ' Enable a build appropriate for valgrind. For development only.\n' printf ' -z, --enable-fuzz-mode\n' printf ' Enable fuzzing mode. THIS IS FOR DEVELOPMENT ONLY.\n' + printf ' -Z, --enable-ossfuzz-mode\n' + printf ' Enable fuzzing mode for OSS-Fuzz. THIS IS FOR DEVELOPMENT ONLY.\n' printf ' --prefix PREFIX\n' printf ' The prefix to install to. Overrides "$PREFIX" if it exists.\n' printf ' If PREFIX is "/usr", install path will be "/usr/bin".\n' @@ -722,6 +724,7 @@ predefined_build() { all_locales=0 library=0 fuzz=0 + ossfuzz=0 time_tests=0 vg=0 memcheck=0 @@ -755,6 +758,7 @@ predefined_build() { all_locales=0 library=0 fuzz=0 + ossfuzz=0 time_tests=0 vg=0 memcheck=0 @@ -772,7 +776,8 @@ predefined_build() { dc_default_digit_clamp=0;; GDH) - CFLAGS="-flto -Weverything -Wno-padded -Wno-unsafe-buffer-usage -Wno-poison-system-directories -Werror -pedantic -std=c11" + CFLAGS="-Weverything -Wno-padded -Wno-unsafe-buffer-usage -Wno-poison-system-directories" + CFLAGS="$CFLAGS -Wno-switch-default -Werror -pedantic -std=c11" bc_only=0 dc_only=0 coverage=0 @@ -789,6 +794,7 @@ predefined_build() { all_locales=0 library=0 fuzz=0 + ossfuzz=0 time_tests=0 vg=0 memcheck=0 @@ -806,7 +812,8 @@ predefined_build() { dc_default_digit_clamp=1;; DBG) - CFLAGS="-Weverything -Wno-padded -Wno-unsafe-buffer-usage -Wno-poison-system-directories -Werror -pedantic -std=c11" + CFLAGS="-Weverything -Wno-padded -Wno-unsafe-buffer-usage -Wno-poison-system-directories" + CFLAGS="$CFLAGS -Wno-switch-default -Werror -pedantic -std=c11" bc_only=0 dc_only=0 coverage=0 @@ -823,6 +830,7 @@ predefined_build() { all_locales=0 library=0 fuzz=0 + ossfuzz=0 time_tests=0 vg=0 memcheck=1 @@ -888,6 +896,7 @@ strip_bin=1 all_locales=0 library=0 fuzz=0 +ossfuzz=0 time_tests=0 vg=0 memcheck=0 @@ -911,7 +920,7 @@ dc_default_digit_clamp=0 # getopts is a POSIX utility, but it cannot handle long options. Thus, the # handling of long options is done by hand, and that's the reason that short and # long options cannot be mixed. -while getopts "abBcdDeEfgGhHik:lMmNO:p:PrS:s:tTvz-" opt; do +while getopts "abBcdDeEfgGhHik:lMmNO:p:PrS:s:tTvzZ-" opt; do case "$opt" in a) library=1 ;; @@ -944,6 +953,7 @@ while getopts "abBcdDeEfgGhHik:lMmNO:p:PrS:s:tTvz-" opt; do T) strip_bin=0 ;; v) vg=1 ;; z) fuzz=1 ;; + Z) ossfuzz=1 ;; -) arg="$1" arg="${arg#--}" @@ -1070,6 +1080,7 @@ while getopts "abBcdDeEfgGhHik:lMmNO:p:PrS:s:tTvz-" opt; do enable-test-timing) time_tests=1 ;; enable-valgrind) vg=1 ;; enable-fuzz-mode) fuzz=1 ;; + enable-ossfuzz-mode) ossfuzz=1 ;; enable-memcheck) memcheck=1 ;; install-all-locales) all_locales=1 ;; help* | bc-only* | dc-only* | coverage* | debug*) @@ -1320,6 +1331,45 @@ elif [ "$dc_only" -eq 1 ]; then tests="test_dc" +elif [ "$ossfuzz" -eq 1 ]; then + + if [ "$bc_only" -ne 0 ] || [ "$dc_only" -ne 0 ]; then + usage "An OSS-Fuzz build must build both fuzzers." + fi + + bc=1 + dc=1 + + # Expressions *cannot* exit in an OSS-Fuzz build. + bc_default_expr_exit=0 + dc_default_expr_exit=0 + + executables="bc_fuzzer and dc_fuzzer" + + karatsuba="@\$(KARATSUBA) 30 0 \$(BC_EXEC)" + karatsuba_test="@\$(KARATSUBA) 1 100 \$(BC_EXEC)" + + if [ "$library" -eq 0 ]; then + install_prereqs=" install_execs" + install_man_prereqs=" install_bc_manpage install_dc_manpage" + uninstall_prereqs=" uninstall_bc uninstall_dc" + uninstall_man_prereqs=" uninstall_bc_manpage uninstall_dc_manpage" + else + install_prereqs=" install_library install_bcl_header" + install_man_prereqs=" install_bcl_manpage" + uninstall_prereqs=" uninstall_library uninstall_bcl_header" + uninstall_man_prereqs=" uninstall_bcl_manpage" + tests="test_library" + fi + + second_target_prereqs="src/bc_fuzzer.o $default_target_prereqs" + default_target_prereqs="\$(BC_FUZZER) src/dc_fuzzer.o $default_target_prereqs" + default_target_cmd="\$(CXX) \$(CFLAGS) src/dc_fuzzer.o \$(LIB_FUZZING_ENGINE) \$(OBJS) \$(LDFLAGS) -o \$(DC_FUZZER) \&\& ln -sf ./dc_fuzzer_c \$(DC_FUZZER_C)" + second_target_cmd="\$(CXX) \$(CFLAGS) src/bc_fuzzer.o \$(LIB_FUZZING_ENGINE) \$(OBJS) \$(LDFLAGS) -o \$(BC_FUZZER) \&\& ln -sf ./bc_fuzzer_c \$(BC_FUZZER_C)" + + default_target="\$(DC_FUZZER) \$(DC_FUZZER_C)" + second_target="\$(BC_FUZZER) \$(BC_FUZZER_C)" + else bc=1 @@ -1349,8 +1399,12 @@ else fi +if [ "$fuzz" -ne 0 ] && [ "$ossfuzz" -ne 0 ]; then + usage "Fuzzing mode and OSS-Fuzz mode are mutually exclusive" +fi + # We need specific stuff for fuzzing. -if [ "$fuzz" -ne 0 ]; then +if [ "$fuzz" -ne 0 ] || [ "$ossfuzz" -ne 0 ]; then debug=1 hist=0 nls=0 @@ -1395,7 +1449,6 @@ else COVERAGE_PREREQS="" fi - # Set some defaults. if [ -z "${DESTDIR+set}" ]; then destdir="" @@ -1485,8 +1538,8 @@ if [ "$nls" -ne 0 ]; then flags="-DBC_ENABLE_NLS=1 -DBC_ENABLED=$bc -DDC_ENABLED=$dc" flags="$flags -DBC_ENABLE_HISTORY=$hist -DBC_ENABLE_LIBRARY=0 -DBC_ENABLE_AFL=0" - flags="$flags -DBC_ENABLE_EXTRA_MATH=$extra_math -I$scriptdir/include/" - flags="$flags -D_POSIX_C_SOURCE=200809L -D_XOPEN_SOURCE=700" + flags="$flags -DBC_ENABLE_EXTRA_MATH=$extra_math -DBC_ENABLE_OSSFUZZ=0" + flags="$flags -I$scriptdir/include/ -D_POSIX_C_SOURCE=200809L -D_XOPEN_SOURCE=700" ccbase=$(basename "$CC") @@ -1494,14 +1547,14 @@ if [ "$nls" -ne 0 ]; then flags="$flags -Wno-unreachable-code" fi - "$CC" $CPPFLAGS $CFLAGS $flags -c "$scriptdir/src/vm.c" -o "./vm.o" > /dev/null 2>&1 + "$CC" $CPPFLAGS $CFLAGS $flags -c "$scriptdir/src/vm.c" -E > /dev/null err="$?" rm -rf "./vm.o" - # If this errors, it is probably because of building on Windows, - # and NLS is not supported on Windows, so disable it. + # If this errors, it is probably because of building on Windows or musl, + # and NLS is not supported on Windows or musl, so disable it. if [ "$err" -ne 0 ]; then printf 'NLS does not work.\n' if [ $force -eq 0 ]; then @@ -1514,7 +1567,7 @@ if [ "$nls" -ne 0 ]; then printf 'NLS works.\n\n' printf 'Testing gencat...\n' - gencat "./en_US.cat" "$scriptdir/locales/en_US.msg" > /dev/null 2>&1 + gencat "./en_US.cat" "$scriptdir/locales/en_US.msg" > /dev/null err="$?" @@ -1587,10 +1640,10 @@ if [ "$hist" -eq 1 ]; then flags="-DBC_ENABLE_HISTORY=1 -DBC_ENABLED=$bc -DDC_ENABLED=$dc" flags="$flags -DBC_ENABLE_NLS=$nls -DBC_ENABLE_LIBRARY=0 -DBC_ENABLE_AFL=0" flags="$flags -DBC_ENABLE_EDITLINE=$editline -DBC_ENABLE_READLINE=$readline" - flags="$flags -DBC_ENABLE_EXTRA_MATH=$extra_math -I$scriptdir/include/" - flags="$flags -D_POSIX_C_SOURCE=200809L -D_XOPEN_SOURCE=700" + flags="$flags -DBC_ENABLE_EXTRA_MATH=$extra_math -DBC_ENABLE_OSSFUZZ=0" + flags="$flags -I$scriptdir/include/ -D_POSIX_C_SOURCE=200809L -D_XOPEN_SOURCE=700" - "$CC" $CPPFLAGS $CFLAGS $flags -c "$scriptdir/src/history.c" -o "./history.o" > /dev/null 2>&1 + "$CC" $CPPFLAGS $CFLAGS $flags -c "$scriptdir/src/history.c" -E > /dev/null err="$?" @@ -1660,7 +1713,7 @@ set +e printf 'Testing for FreeBSD...\n' flags="-DBC_TEST_FREEBSD -DBC_ENABLE_AFL=0" -"$CC" $CPPFLAGS $CFLAGS $flags "-I$scriptdir/include" -E "$scriptdir/src/vm.c" > /dev/null 2>&1 +"$CC" $CPPFLAGS $CFLAGS $flags "-I$scriptdir/include" -E "$scriptdir/scripts/os.c" > /dev/null err="$?" @@ -1677,7 +1730,7 @@ fi printf 'Testing for macOS...\n' flags="-DBC_TEST_APPLE -DBC_ENABLE_AFL=0" -"$CC" $CPPFLAGS $CFLAGS $flags "-I$scriptdir/include" -E "$scriptdir/src/vm.c" > /dev/null 2>&1 +"$CC" $CPPFLAGS $CFLAGS $flags "-I$scriptdir/include" -E "$scriptdir/scripts/os.c" > /dev/null err="$?" @@ -1705,7 +1758,7 @@ fi printf 'Testing for OpenBSD...\n' flags="-DBC_TEST_OPENBSD -DBC_ENABLE_AFL=0" -"$CC" $CPPFLAGS $CFLAGS $flags "-I$scriptdir/include" -E "$scriptdir/src/vm.c" > /dev/null 2>&1 +"$CC" $CPPFLAGS $CFLAGS $flags "-I$scriptdir/include" -E "$scriptdir/scripts/os.c" > /dev/null err="$?" @@ -1741,7 +1794,7 @@ GEN_DIR="$scriptdir/gen" # These lines set the appropriate targets based on whether `gen/strgen.c` or # `gen/strgen.sh` is used. GEN="strgen" -GEN_EXEC_TARGET="\$(HOSTCC) -DBC_ENABLE_AFL=0 -I$scriptdir/include/ \$(HOSTCFLAGS) -o \$(GEN_EXEC) \$(GEN_C)" +GEN_EXEC_TARGET="\$(HOSTCC) -DBC_ENABLE_AFL=0 -DBC_ENABLE_OSSFUZZ=0 -I$scriptdir/include/ \$(HOSTCFLAGS) -o \$(GEN_EXEC) \$(GEN_C)" CLEAN_PREREQS=" clean_gen clean_coverage" if [ -z "${GEN_HOST+set}" ]; then @@ -1754,8 +1807,9 @@ else fi fi +# The fuzzer files are always unneeded because they'll be built separately. manpage_args="" -unneeded="" +unneeded="bc_fuzzer.c dc_fuzzer.c" headers="\$(HEADERS)" # This series of if statements figure out what source files are *not* needed. @@ -1826,6 +1880,14 @@ if [ "$library" -ne 0 ]; then fi +elif [ "$ossfuzz" -ne 0 ]; then + + unneeded="$unneeded library.c main.c" + + PC_PATH="" + pkg_config_install="" + pkg_config_uninstall="" + else unneeded="$unneeded library.c" @@ -1836,9 +1898,10 @@ else fi -# library.c is not needed under normal circumstances. +# library.c, bc_fuzzer.c, and dc_fuzzer.c are not needed under normal +# circumstances. if [ "$unneeded" = "" ]; then - unneeded="library.c" + unneeded="library.c bc_fuzzer.c dc_fuzzer.c" fi # This sets the appropriate manpage for a full build. @@ -1846,7 +1909,7 @@ if [ "$manpage_args" = "" ]; then manpage_args="A" fi -if [ "$vg" -ne 0 ]; then +if [ "$vg" -ne 0 ] || [ "$ossfuzz" -ne 0 ]; then memcheck=1 fi @@ -2011,7 +2074,9 @@ contents=$(replace "$contents" "HISTORY" "$hist") contents=$(replace "$contents" "EXTRA_MATH" "$extra_math") contents=$(replace "$contents" "NLS" "$nls") contents=$(replace "$contents" "FUZZ" "$fuzz") +contents=$(replace "$contents" "OSSFUZZ" "$ossfuzz") contents=$(replace "$contents" "MEMCHECK" "$memcheck") +contents=$(replace "$contents" "LIB_FUZZING_ENGINE" "$LIB_FUZZING_ENGINE") contents=$(replace "$contents" "BC_LIB_O" "$bc_lib") contents=$(replace "$contents" "BC_HELP_O" "$bc_help") @@ -2117,6 +2182,15 @@ if [ "$dc" -ne 0 ]; then gen_err_tests dc $dc_test_exec fi +if [ "$ossfuzz" -ne 0 ]; then + + printf 'bc_fuzzer_c: $(BC_FUZZER)\n\tln -sf $(BC_FUZZER) bc_fuzzer_c\n' >> Makefile + printf 'bc_fuzzer_C: $(BC_FUZZER)\n\tln -sf $(BC_FUZZER) bc_fuzzer_C\n' >> Makefile + printf 'dc_fuzzer_c: $(DC_FUZZER)\n\tln -sf $(DC_FUZZER) dc_fuzzer_c\n' >> Makefile + printf 'dc_fuzzer_C: $(DC_FUZZER)\n\tln -sf $(DC_FUZZER) dc_fuzzer_C\n' >> Makefile + +fi + # Copy the correct manuals to the expected places. mkdir -p manuals cp -f "$scriptdir/manuals/bc/$manpage_args.1.md" manuals/bc.1.md diff --git a/contrib/bc/include/args.h b/contrib/bc/include/args.h index f1e9f007bddf..8f8f00be4630 100644 --- a/contrib/bc/include/args.h +++ b/contrib/bc/include/args.h @@ -54,7 +54,7 @@ * any. */ void -bc_args(int argc, char* argv[], bool exit_exprs, BcBigDig* scale, +bc_args(int argc, const char* argv[], bool exit_exprs, BcBigDig* scale, BcBigDig* ibase, BcBigDig* obase); #if BC_ENABLED diff --git a/contrib/bc/include/bc.h b/contrib/bc/include/bc.h index b25df09a174e..2213278be1da 100644 --- a/contrib/bc/include/bc.h +++ b/contrib/bc/include/bc.h @@ -51,7 +51,7 @@ * @return A status. */ BcStatus -bc_main(int argc, char* argv[]); +bc_main(int argc, const char* argv[]); // These are references to the help text, the library text, and the "filename" // for the library. diff --git a/contrib/bc/include/dc.h b/contrib/bc/include/dc.h index 1328f1c63b38..63f5ccbd10e3 100644 --- a/contrib/bc/include/dc.h +++ b/contrib/bc/include/dc.h @@ -48,7 +48,7 @@ * @return A status. */ BcStatus -dc_main(int argc, char* argv[]); +dc_main(int argc, const char* argv[]); // A reference to the dc help text. extern const char dc_help[]; diff --git a/contrib/bc/include/opt.h b/contrib/bc/include/opt.h index e60328994d8c..41058cb4e29c 100644 --- a/contrib/bc/include/opt.h +++ b/contrib/bc/include/opt.h @@ -47,7 +47,7 @@ typedef struct BcOpt { /// The array of arguments. - char** argv; + const char** argv; /// The index of the current argument. size_t optind; @@ -59,7 +59,7 @@ typedef struct BcOpt int subopt; /// The option argument. - char* optarg; + const char* optarg; } BcOpt; @@ -103,7 +103,7 @@ typedef struct BcOptLong * @param argv The array of arguments. */ void -bc_opt_init(BcOpt* o, char** argv); +bc_opt_init(BcOpt* o, const char** argv); /** * Parse an option. This returns a value the same way getopt() and getopt_long() diff --git a/contrib/bc/include/ossfuzz.h b/contrib/bc/include/ossfuzz.h new file mode 100644 index 000000000000..5c12a3c9c9fb --- /dev/null +++ b/contrib/bc/include/ossfuzz.h @@ -0,0 +1,79 @@ +/* + * ***************************************************************************** + * + * SPDX-License-Identifier: BSD-2-Clause + * + * Copyright (c) 2018-2024 Gavin D. Howard and contributors. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions are met: + * + * * Redistributions of source code must retain the above copyright notice, this + * list of conditions and the following disclaimer. + * + * * Redistributions in binary form must reproduce the above copyright notice, + * this list of conditions and the following disclaimer in the documentation + * and/or other materials provided with the distribution. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE + * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE + * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE + * POSSIBILITY OF SUCH DAMAGE. + * + * ***************************************************************************** + * + * Declarations for the OSS-Fuzz build of bc and dc. + * + */ + +#include +#include + +#ifndef BC_OSSFUZZ_H +#define BC_OSSFUZZ_H + +/// The number of args in fuzzer arguments, including the NULL terminator. +extern const size_t bc_fuzzer_args_len; + +/// The standard arguments for the bc fuzzer with the -c argument. +extern const char* bc_fuzzer_args_c[]; + +/// The standard arguments for the bc fuzzer with the -C argument. +extern const char* bc_fuzzer_args_C[]; + +/// The standard arguments for the dc fuzzer with the -c argument. +extern const char* dc_fuzzer_args_c[]; + +/// The standard arguments for the dc fuzzer with the -C argument. +extern const char* dc_fuzzer_args_C[]; + +/// The data pointer. +extern uint8_t* bc_fuzzer_data; + +/** + * The function that the fuzzer runs. + * @param Data The data. + * @param Size The number of bytes in @a Data. + * @return 0 on success, -1 on error. + * @pre @a Data must not be equal to NULL if @a Size > 0. + */ +int +LLVMFuzzerTestOneInput(const uint8_t* Data, size_t Size); + +/** + * The initialization function for the fuzzer. + * @param argc A pointer to the argument count. + * @param argv A pointer to the argument list. + * @return 0 on success, -1 on error. + */ +int +LLVMFuzzerInitialize(int* argc, char*** argv); + +#endif // BC_OSSFUZZ_H diff --git a/contrib/bc/include/status.h b/contrib/bc/include/status.h index f579df8c649b..203f09af628b 100644 --- a/contrib/bc/include/status.h +++ b/contrib/bc/include/status.h @@ -46,27 +46,6 @@ #include #include -// This is used by configure.sh to test for OpenBSD. -#ifdef BC_TEST_OPENBSD -#ifdef __OpenBSD__ -#error On OpenBSD without _BSD_SOURCE -#endif // __OpenBSD__ -#endif // BC_TEST_OPENBSD - -// This is used by configure.sh to test for FreeBSD. -#ifdef BC_TEST_FREEBSD -#ifdef __FreeBSD__ -#error On FreeBSD with _POSIX_C_SOURCE -#endif // __FreeBSD__ -#endif // BC_TEST_FREEBSD - -// This is used by configure.sh to test for macOS. -#ifdef BC_TEST_APPLE -#ifdef __APPLE__ -#error On macOS without _DARWIN_C_SOURCE -#endif // __APPLE__ -#endif // BC_TEST_APPLE - // Windows has deprecated isatty() and the rest of these. Or doesn't have them. // So these are just fixes for Windows. #ifdef _WIN32 @@ -676,9 +655,13 @@ typedef enum BcMode /// File mode. BC_MODE_FILE, +#if !BC_ENABLE_OSSFUZZ + /// stdin mode. BC_MODE_STDIN, +#endif // !BC_ENABLE_OSSFUZZ + } BcMode; /// Do a longjmp(). This is what to use when activating an "exception", i.e., a diff --git a/contrib/bc/include/version.h b/contrib/bc/include/version.h index 586691a6e7ef..897a19530e3f 100644 --- a/contrib/bc/include/version.h +++ b/contrib/bc/include/version.h @@ -37,6 +37,6 @@ #define BC_VERSION_H /// The current version. -#define VERSION 6.7.6 +#define VERSION 7.0.0 #endif // BC_VERSION_H diff --git a/contrib/bc/include/vm.h b/contrib/bc/include/vm.h index 052c1d14c237..e81206b63871 100644 --- a/contrib/bc/include/vm.h +++ b/contrib/bc/include/vm.h @@ -794,7 +794,7 @@ bc_vm_info(const char* const help); * @return A status. */ BcStatus -bc_vm_boot(int argc, char* argv[]); +bc_vm_boot(int argc, const char* argv[]); /** * Initializes some of the BcVm global. This is separate to make things easier diff --git a/contrib/bc/manuals/dc/A.1 b/contrib/bc/manuals/dc/A.1 index 33ecb8e2031e..d59e0fa68a58 100644 --- a/contrib/bc/manuals/dc/A.1 +++ b/contrib/bc/manuals/dc/A.1 @@ -25,7 +25,7 @@ .\" ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE .\" POSSIBILITY OF SUCH DAMAGE. .\" -.TH "DC" "1" "January 2024" "Gavin D. Howard" "General Commands Manual" +.TH "DC" "1" "August 2024" "Gavin D. Howard" "General Commands Manual" .nh .ad l .SH Name @@ -1275,11 +1275,14 @@ handler for, it resets. This means that several things happen. .PP First, any macros that are executing are stopped and popped off the -stack. +execution stack. The behavior is not unlike that of exceptions in programming languages. Then the execution point is set so that any code waiting to execute (after all macros returned) is skipped. .PP +However, the stack of values is \f[I]not\f[R] cleared; in interactive +mode, users can inspect the stack and manipulate it. +.PP Thus, when dc(1) resets, it skips any remaining code waiting to be executed. Then, if it is interactive mode, and the error was not a fatal error diff --git a/contrib/bc/manuals/dc/A.1.md b/contrib/bc/manuals/dc/A.1.md index 613f98f76814..ad0c59934fd1 100644 --- a/contrib/bc/manuals/dc/A.1.md +++ b/contrib/bc/manuals/dc/A.1.md @@ -1130,11 +1130,14 @@ the next non-space characters do not match that regex. When dc(1) encounters an error or a signal that it has a non-default handler for, it resets. This means that several things happen. -First, any macros that are executing are stopped and popped off the stack. -The behavior is not unlike that of exceptions in programming languages. Then -the execution point is set so that any code waiting to execute (after all +First, any macros that are executing are stopped and popped off the execution +stack. The behavior is not unlike that of exceptions in programming languages. +Then the execution point is set so that any code waiting to execute (after all macros returned) is skipped. +However, the stack of values is *not* cleared; in interactive mode, users can +inspect the stack and manipulate it. + Thus, when dc(1) resets, it skips any remaining code waiting to be executed. Then, if it is interactive mode, and the error was not a fatal error (see the **EXIT STATUS** section), it asks for more input; otherwise, it exits with the diff --git a/contrib/bc/manuals/dc/E.1 b/contrib/bc/manuals/dc/E.1 index 91f68dfd7467..a5febe44705f 100644 --- a/contrib/bc/manuals/dc/E.1 +++ b/contrib/bc/manuals/dc/E.1 @@ -25,7 +25,7 @@ .\" ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE .\" POSSIBILITY OF SUCH DAMAGE. .\" -.TH "DC" "1" "January 2024" "Gavin D. Howard" "General Commands Manual" +.TH "DC" "1" "August 2024" "Gavin D. Howard" "General Commands Manual" .nh .ad l .SH Name @@ -1061,11 +1061,14 @@ handler for, it resets. This means that several things happen. .PP First, any macros that are executing are stopped and popped off the -stack. +execution stack. The behavior is not unlike that of exceptions in programming languages. Then the execution point is set so that any code waiting to execute (after all macros returned) is skipped. .PP +However, the stack of values is \f[I]not\f[R] cleared; in interactive +mode, users can inspect the stack and manipulate it. +.PP Thus, when dc(1) resets, it skips any remaining code waiting to be executed. Then, if it is interactive mode, and the error was not a fatal error diff --git a/contrib/bc/manuals/dc/E.1.md b/contrib/bc/manuals/dc/E.1.md index 3a47f789bd3e..54b877999d0d 100644 --- a/contrib/bc/manuals/dc/E.1.md +++ b/contrib/bc/manuals/dc/E.1.md @@ -961,11 +961,14 @@ the next non-space characters do not match that regex. When dc(1) encounters an error or a signal that it has a non-default handler for, it resets. This means that several things happen. -First, any macros that are executing are stopped and popped off the stack. -The behavior is not unlike that of exceptions in programming languages. Then -the execution point is set so that any code waiting to execute (after all +First, any macros that are executing are stopped and popped off the execution +stack. The behavior is not unlike that of exceptions in programming languages. +Then the execution point is set so that any code waiting to execute (after all macros returned) is skipped. +However, the stack of values is *not* cleared; in interactive mode, users can +inspect the stack and manipulate it. + Thus, when dc(1) resets, it skips any remaining code waiting to be executed. Then, if it is interactive mode, and the error was not a fatal error (see the **EXIT STATUS** section), it asks for more input; otherwise, it exits with the diff --git a/contrib/bc/manuals/dc/EH.1 b/contrib/bc/manuals/dc/EH.1 index e60e6e0d8497..61fbaa4efe92 100644 --- a/contrib/bc/manuals/dc/EH.1 +++ b/contrib/bc/manuals/dc/EH.1 @@ -25,7 +25,7 @@ .\" ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE .\" POSSIBILITY OF SUCH DAMAGE. .\" -.TH "DC" "1" "January 2024" "Gavin D. Howard" "General Commands Manual" +.TH "DC" "1" "August 2024" "Gavin D. Howard" "General Commands Manual" .nh .ad l .SH Name @@ -1061,11 +1061,14 @@ handler for, it resets. This means that several things happen. .PP First, any macros that are executing are stopped and popped off the -stack. +execution stack. The behavior is not unlike that of exceptions in programming languages. Then the execution point is set so that any code waiting to execute (after all macros returned) is skipped. .PP +However, the stack of values is \f[I]not\f[R] cleared; in interactive +mode, users can inspect the stack and manipulate it. +.PP Thus, when dc(1) resets, it skips any remaining code waiting to be executed. Then, if it is interactive mode, and the error was not a fatal error diff --git a/contrib/bc/manuals/dc/EH.1.md b/contrib/bc/manuals/dc/EH.1.md index 761b9a89947b..6398477a84dd 100644 --- a/contrib/bc/manuals/dc/EH.1.md +++ b/contrib/bc/manuals/dc/EH.1.md @@ -961,11 +961,14 @@ the next non-space characters do not match that regex. When dc(1) encounters an error or a signal that it has a non-default handler for, it resets. This means that several things happen. -First, any macros that are executing are stopped and popped off the stack. -The behavior is not unlike that of exceptions in programming languages. Then -the execution point is set so that any code waiting to execute (after all +First, any macros that are executing are stopped and popped off the execution +stack. The behavior is not unlike that of exceptions in programming languages. +Then the execution point is set so that any code waiting to execute (after all macros returned) is skipped. +However, the stack of values is *not* cleared; in interactive mode, users can +inspect the stack and manipulate it. + Thus, when dc(1) resets, it skips any remaining code waiting to be executed. Then, if it is interactive mode, and the error was not a fatal error (see the **EXIT STATUS** section), it asks for more input; otherwise, it exits with the diff --git a/contrib/bc/manuals/dc/EHN.1 b/contrib/bc/manuals/dc/EHN.1 index d26d49c5ce3d..974cb3c86791 100644 --- a/contrib/bc/manuals/dc/EHN.1 +++ b/contrib/bc/manuals/dc/EHN.1 @@ -25,7 +25,7 @@ .\" ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE .\" POSSIBILITY OF SUCH DAMAGE. .\" -.TH "DC" "1" "January 2024" "Gavin D. Howard" "General Commands Manual" +.TH "DC" "1" "August 2024" "Gavin D. Howard" "General Commands Manual" .nh .ad l .SH Name @@ -1061,11 +1061,14 @@ handler for, it resets. This means that several things happen. .PP First, any macros that are executing are stopped and popped off the -stack. +execution stack. The behavior is not unlike that of exceptions in programming languages. Then the execution point is set so that any code waiting to execute (after all macros returned) is skipped. .PP +However, the stack of values is \f[I]not\f[R] cleared; in interactive +mode, users can inspect the stack and manipulate it. +.PP Thus, when dc(1) resets, it skips any remaining code waiting to be executed. Then, if it is interactive mode, and the error was not a fatal error diff --git a/contrib/bc/manuals/dc/EHN.1.md b/contrib/bc/manuals/dc/EHN.1.md index 58ae149bb686..51e30849996e 100644 --- a/contrib/bc/manuals/dc/EHN.1.md +++ b/contrib/bc/manuals/dc/EHN.1.md @@ -961,11 +961,14 @@ the next non-space characters do not match that regex. When dc(1) encounters an error or a signal that it has a non-default handler for, it resets. This means that several things happen. -First, any macros that are executing are stopped and popped off the stack. -The behavior is not unlike that of exceptions in programming languages. Then -the execution point is set so that any code waiting to execute (after all +First, any macros that are executing are stopped and popped off the execution +stack. The behavior is not unlike that of exceptions in programming languages. +Then the execution point is set so that any code waiting to execute (after all macros returned) is skipped. +However, the stack of values is *not* cleared; in interactive mode, users can +inspect the stack and manipulate it. + Thus, when dc(1) resets, it skips any remaining code waiting to be executed. Then, if it is interactive mode, and the error was not a fatal error (see the **EXIT STATUS** section), it asks for more input; otherwise, it exits with the diff --git a/contrib/bc/manuals/dc/EN.1 b/contrib/bc/manuals/dc/EN.1 index 03cb5743602c..5ce8defc91c7 100644 --- a/contrib/bc/manuals/dc/EN.1 +++ b/contrib/bc/manuals/dc/EN.1 @@ -25,7 +25,7 @@ .\" ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE .\" POSSIBILITY OF SUCH DAMAGE. .\" -.TH "DC" "1" "January 2024" "Gavin D. Howard" "General Commands Manual" +.TH "DC" "1" "August 2024" "Gavin D. Howard" "General Commands Manual" .nh .ad l .SH Name @@ -1061,11 +1061,14 @@ handler for, it resets. This means that several things happen. .PP First, any macros that are executing are stopped and popped off the -stack. +execution stack. The behavior is not unlike that of exceptions in programming languages. Then the execution point is set so that any code waiting to execute (after all macros returned) is skipped. .PP +However, the stack of values is \f[I]not\f[R] cleared; in interactive +mode, users can inspect the stack and manipulate it. +.PP Thus, when dc(1) resets, it skips any remaining code waiting to be executed. Then, if it is interactive mode, and the error was not a fatal error diff --git a/contrib/bc/manuals/dc/EN.1.md b/contrib/bc/manuals/dc/EN.1.md index 64c945be8857..ab9647a196be 100644 --- a/contrib/bc/manuals/dc/EN.1.md +++ b/contrib/bc/manuals/dc/EN.1.md @@ -961,11 +961,14 @@ the next non-space characters do not match that regex. When dc(1) encounters an error or a signal that it has a non-default handler for, it resets. This means that several things happen. -First, any macros that are executing are stopped and popped off the stack. -The behavior is not unlike that of exceptions in programming languages. Then -the execution point is set so that any code waiting to execute (after all +First, any macros that are executing are stopped and popped off the execution +stack. The behavior is not unlike that of exceptions in programming languages. +Then the execution point is set so that any code waiting to execute (after all macros returned) is skipped. +However, the stack of values is *not* cleared; in interactive mode, users can +inspect the stack and manipulate it. + Thus, when dc(1) resets, it skips any remaining code waiting to be executed. Then, if it is interactive mode, and the error was not a fatal error (see the **EXIT STATUS** section), it asks for more input; otherwise, it exits with the diff --git a/contrib/bc/manuals/dc/H.1 b/contrib/bc/manuals/dc/H.1 index 36f7458a3316..82c1bbd5c2b9 100644 --- a/contrib/bc/manuals/dc/H.1 +++ b/contrib/bc/manuals/dc/H.1 @@ -25,7 +25,7 @@ .\" ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE .\" POSSIBILITY OF SUCH DAMAGE. .\" -.TH "DC" "1" "January 2024" "Gavin D. Howard" "General Commands Manual" +.TH "DC" "1" "August 2024" "Gavin D. Howard" "General Commands Manual" .nh .ad l .SH Name @@ -1275,11 +1275,14 @@ handler for, it resets. This means that several things happen. .PP *** 1272 LINES SKIPPED *** From nobody Mon Aug 26 16:53:52 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Wsxb43PXjz5TFLC; Mon, 26 Aug 2024 16:53:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Wsxb42pjJz3ymt; Mon, 26 Aug 2024 16:53:52 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724691232; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jApDlPVEic+UkCyt/S8qv+E64vlB+tE6NjLN8HdBZCE=; b=IRRFkEnY5gGMJUpKzWuJNN5hcda8Od99pnA/kQ3t8wMc/3j9aQQk1MM035OFLAauEni3gk xEXVNT5wTuRPoLQYmzLgzITOgx1F2rD4oL7uQFRRuXLY1NIZtxZ/8lbXiMRwqK7gLi8xPk TneBRVsDuQ6fsnjGuPk8GmQ+BTh1bNjpCbwSipqmLsguhImzci7emIkoc2K1eGRYQf++Di J5xHZOj59sVTmzjLx05oE6Wvk5VYWkGIXKnjTwQp5x9vGhXcKBpy3Eauq7Dq3CZfZV0n+1 nHYtr+Hz82EdyohGuIj9cvTiW8Ia7bfwDJ5CJUoCv3ZqdAG7a5gnfgngUSpXPA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724691232; a=rsa-sha256; cv=none; b=Jg9LdpaBumLk57GVt77IEscmPR0n9p3qH2IwpoFgHqRfec3CGj8Nip9VcotAFB9OpVAjvs CTOChIRxqlknwk0CCI5PgHKt+aPUAQooH9dZNIYZzP2wiMj56+vH3MCx40Uq80unG5rYhi uOZTGE6grUWj1VFuXgtXJYHfwY2ZfVQde6aliX3/XUX6RF/mdKHouP7ar+0Wm5vJ1KG0xx XPbmu0A0jewvr9+nog/6cr6Qgr+aXUDFaO5cYmGGrFVpQu5QuWK60iHRFCGmOYvv0Z99eP gO1IUwy2+j/SNX1/Udj3YyARbsH9SPhhjUUsddpcbm37HrtLybAjwQW1KFvwHA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724691232; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jApDlPVEic+UkCyt/S8qv+E64vlB+tE6NjLN8HdBZCE=; b=lysIlk3KRwN5Bb/TNS4YsV+/PSaGSdpH9GKcjBC1ghZ2Hbg9VBdIX52TPyyVBwN5NXZUdf 9MsZ9d4J4hc5+Ux85VGDdNwdAZ9Bu3ie5vxeLviM7j/7+sn1DEIATBAJxgrgAHR3bBtLe9 LWn5GvDfMdjdyNG0dx6+t7j4Z/R4uPiU9UOVq8Y99wa/4ott6Eqf3TliDrabEuTmBlx22N M9Ihl4Aj02jCRPuQ2lcZDsIjIQAfhunFmGwkVtjelONqMz4LLK0yHuuK9cr+iLfPPCYmIK kJ8ZysR7+v63k01T3HVNV847UwRWQQpgaFt/kjc7vpPSQ/Iowwqul1wmq8aUng== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Wsxb42QHBzFSx; Mon, 26 Aug 2024 16:53:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47QGrqOR022320; Mon, 26 Aug 2024 16:53:52 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47QGrqIR022317; Mon, 26 Aug 2024 16:53:52 GMT (envelope-from git) Date: Mon, 26 Aug 2024 16:53:52 GMT Message-Id: <202408261653.47QGrqIR022317@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kristof Provost Subject: git: fff621251320 - main - pf tests: ensure that 'quick' on anchor rules works as expected List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: fff6212513205a4989b38e9debe455343a8d309f Auto-Submitted: auto-generated The branch main has been updated by kp: URL: https://cgit.FreeBSD.org/src/commit/?id=fff6212513205a4989b38e9debe455343a8d309f commit fff6212513205a4989b38e9debe455343a8d309f Author: Kristof Provost AuthorDate: 2024-08-26 15:24:32 +0000 Commit: Kristof Provost CommitDate: 2024-08-26 16:50:02 +0000 pf tests: ensure that 'quick' on anchor rules works as expected Sponsored by: Rubicon Communications, LLC ("Netgate") --- tests/sys/netpfil/pf/anchor.sh | 39 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 39 insertions(+) diff --git a/tests/sys/netpfil/pf/anchor.sh b/tests/sys/netpfil/pf/anchor.sh index 311d6485e794..25d9d5b6df03 100644 --- a/tests/sys/netpfil/pf/anchor.sh +++ b/tests/sys/netpfil/pf/anchor.sh @@ -195,6 +195,44 @@ nested_label_cleanup() pft_cleanup } +atf_test_case "quick" "cleanup" +quick_head() +{ + atf_set descr "Test handling of quick on anchors" + atf_set require.user root +} + +quick_body() +{ + pft_init + + epair=$(vnet_mkepair) + vnet_mkjail alcatraz ${epair}a + + ifconfig ${epair}b 192.0.2.2/24 up + jexec alcatraz ifconfig ${epair}a 192.0.2.1/24 up + + # Sanity check + atf_check -s exit:0 -o ignore ping -c 1 192.0.2.1 + + jexec alcatraz pfctl -e + pft_set_rules alcatraz \ + "anchor quick {\n\ + pass\n\ + }" \ + "block" + + # We can still ping because the anchor is 'quick' + atf_check -s exit:0 -o ignore ping -c 1 192.0.2.1 + jexec alcatraz pfctl -sr -v + jexec alcatraz pfctl -ss -v +} + +quick_cleanup() +{ + pft_cleanup +} + atf_init_test_cases() { atf_add_test_case "pr183198" @@ -202,4 +240,5 @@ atf_init_test_cases() atf_add_test_case "nested_anchor" atf_add_test_case "wildcard" atf_add_test_case "nested_label" + atf_add_test_case "quick" } From nobody Mon Aug 26 18:30:02 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Wszk23LqMz5TNwt; Mon, 26 Aug 2024 18:30:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Wszk22CS5z4Bb8; Mon, 26 Aug 2024 18:30:02 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724697002; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jdTDgI8HRBu2X4FMBpmORd4nb14S3PFOub1C7kBN1Qc=; b=k9c15mImb/Aixt9J6mtCRag3UUN3yKrAAjhq0HhllQhRB+IZ0QitbnXlYlrbwsCD3qpuSL GxSin60QRP9scOzRUovkNLuy3Hby4hK+QP4yrFal/uaLXw7rb9NVd4yW1LupAlB5DyQIXm QH0Vns2XD6En7pJ4zJuuVaDeZKiAUHzOclSmWTYCfXMcTQ3rJpK+BNJUi2odYn+QeoIkis bXf0jRtTHI85pcLAvfDxNWJ84BfQ2JAP/117b6smmm0+GQ8DkMxUky2u+5f1A6ptzKPAIH ecQVRz4g6Ui8q5rA5IRH270HSl82bnitXvr6K4bksIZgswaphejyYMqNBaRe4w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724697002; a=rsa-sha256; cv=none; b=lfgn5D0ohKyqZzKdt5dh4lmEi7jAbIif9GI1oHV4L6quevToJAnIU69zbAMu+Pfi9jr4M9 NJgbOgh+W80h8US050TAzGYeZfWLMMH2TEI4nVimUUgjA86/qk+T691GYRcM+OQu35uVdA YHrKzfDgFxwFSqJp6vPXIDFVV8ex7t9UI7nDXmcD/6ksLiwhrdEF6FAuadJwVcQwHYkauQ d8xtvIPK4XDLh1UaWVunH97FFhupKkIVJztV68y2xPjkPXuRgbS4nKgWaLBr9nn8vb7mNy Tqo9VJ10ILeHK9/cTQTZzBqftDqbLZFU722pn2O/pF9SjedHAYIzPagaUAbTZQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724697002; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jdTDgI8HRBu2X4FMBpmORd4nb14S3PFOub1C7kBN1Qc=; b=sLlFmiFeUtwIMWgC8GOhYNu+220RmP/MM/SI5yCosLloyjkQC+zRiuJwU25dYAJ7b/uJ+n yvLEUHErQ1R+uiUbiC76AQpbI7kMvB7rduCXU0rDg1YC5FfCqXJUS2yvh8JIk3Bl6knFuH wVv671kPQQRw3tPRvR8ytMyXgoMjJ2gatexMJtzn155NwAYJ0znRqlkm6/CTSe4nSyDAxz fAzPcpijgn0i4vpPRat0MQBchrblZ86gp86r/nVSObOWHcQMpgh6kFBALKB6wj41718otB Q2mLahsF4WU770WdiuyAX/3HAegbAz3v9wvA60d7qlpCwxnhc1W/Rvn7QuS0UQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Wszk21psGzH7L; Mon, 26 Aug 2024 18:30:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47QIU2RC079090; Mon, 26 Aug 2024 18:30:02 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47QIU2kV079085; Mon, 26 Aug 2024 18:30:02 GMT (envelope-from git) Date: Mon, 26 Aug 2024 18:30:02 GMT Message-Id: <202408261830.47QIU2kV079085@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: 62bb18abed25 - main - p9fs: Properly handle paths containing "." List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 62bb18abed25a831a29e1e5b6e6f7fdddbba6403 Auto-Submitted: auto-generated The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=62bb18abed25a831a29e1e5b6e6f7fdddbba6403 commit 62bb18abed25a831a29e1e5b6e6f7fdddbba6403 Author: Bakul Shah AuthorDate: 2024-08-04 18:19:52 +0000 Commit: Mark Johnston CommitDate: 2024-08-26 18:24:59 +0000 p9fs: Properly handle paths containing "." Fixes: 56e4622588ed ("p9fs: fix lookup of "." for lib9p-based 9P servers") Pull Request: https://github.com/freebsd/freebsd-src/pull/1361 --- sys/fs/p9fs/p9fs_vnops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/fs/p9fs/p9fs_vnops.c b/sys/fs/p9fs/p9fs_vnops.c index 6ac0a7c008cc..14951e96b59d 100644 --- a/sys/fs/p9fs/p9fs_vnops.c +++ b/sys/fs/p9fs/p9fs_vnops.c @@ -238,7 +238,7 @@ p9fs_lookup(struct vop_lookup_args *ap) if (dnp == NULL) return (ENOENT); - if (cnp->cn_nameptr[0] == '.' && strlen(cnp->cn_nameptr) == 1) { + if (cnp->cn_nameptr[0] == '.' && cnp->cn_namelen == 1) { vref(dvp); *vpp = dvp; return (0); From nobody Mon Aug 26 18:58:29 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Wt0Ls3Gysz5TQpM; Mon, 26 Aug 2024 18:58:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Wt0Ls1Z7Xz4FDf; Mon, 26 Aug 2024 18:58:29 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724698709; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=UMRJGDwf8LZB/dKivjGj5eeH3bViRTyM+GDUy0wYAII=; b=TIN27VnVgateUcSKI55L7zAg1NnUU+MYg6OveSZdijw/i//LF45Qk5qYtfenXNPeRMZUtF nNhRNK1oiLWhf1Bk17lFeXOXc/4zRsV6cag0JqrpVwj0COYTs8eAYDuNnhtWGfP5VG4UKy e8i53u0zOfWL9Eb9dpe/gRReJ/d2JZX60/XmBblD4AKoolg6OvN3OMO9Dg1vCffmYM9fTn V5go9tyb2o0xLcHczYQj19saGXG18ZRpDxm+uCH67nphz0/+R6QFm/w7beS+hI0aTflsYO 0TWlbToX6G4L57GjTg4EEVFyiLmHKFO3FZavfGumjta3NZC19AdNoteld4OPwA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724698709; a=rsa-sha256; cv=none; b=P/l0G7NLr0xKQaLi1m5O7+WijYu4y2siH0k2LNLLAz1QhJSjVd5H6QDjDvfiLJh/TWX6FQ W6DOKKBPa+kkbbwm1M4AdtBNhJEZnT4Mo6Mg485sXvLe5i1+90JGm9xmg+arkmE8ssXfFA 596fYJ+7/iH6BnBnbCNWgl8PoKron0x1Mt1DPRV3/fFSBqUKeLKe5w+rBNkR5MjjuaAolR Zb3R5Ea7nBcGFx3JIVfRbGhihQl3zz+u1J0Asmc7w/n2PCMc8wT+9AlmNAdPsvyTIMSD8e Qdim4wp28tiQAfsGv5rWRVOa8FQxxUOQ+67VpTcfNQqVF1lBdiFStNONA0x93w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724698709; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=UMRJGDwf8LZB/dKivjGj5eeH3bViRTyM+GDUy0wYAII=; b=gpLVZ41AtlXU8jIEx5F+2UlfD1Nf/36pOU6KIBpda2xAub05dG115oEhpAY2oBkhrXxdcK uNrtqaqZ+DtD5Sq/IVzj0kA8lyQ8arEjiHcVe7wgGY5RTjuZPbhGLb/jtlWk4I3nzTjOOE gAWQwAWTpcnmimozwRUKxeTbLiDne8sRTyGAnSmj4vu6VFLZNplSbJAW0GfVbGpxooirsL +flNvu7Po9HlOq+PVtL18sh8bgMev8AgxHOy+fW2+zJsMYhBxRQXNmHGOoTtn68ck5yCAI niPNAMm6LvZktad+wKiP32PDZylfT5l0agoFUlvzNvKUa5OSuuuwyHeVeHBm8g== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Wt0Ls19RJzHND; Mon, 26 Aug 2024 18:58:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47QIwTIG027502; Mon, 26 Aug 2024 18:58:29 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47QIwTrx027499; Mon, 26 Aug 2024 18:58:29 GMT (envelope-from git) Date: Mon, 26 Aug 2024 18:58:29 GMT Message-Id: <202408261858.47QIwTrx027499@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: 3ccb02334bf5 - main - vmm: Move vmm_ktr.h to a common directory List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 3ccb02334bf5aee49a66dcff4b9229220bd0184b Auto-Submitted: auto-generated The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=3ccb02334bf5aee49a66dcff4b9229220bd0184b commit 3ccb02334bf5aee49a66dcff4b9229220bd0184b Author: Mark Johnston AuthorDate: 2024-08-26 18:41:05 +0000 Commit: Mark Johnston CommitDate: 2024-08-26 18:41:05 +0000 vmm: Move vmm_ktr.h to a common directory No functional change intended. Reviewed by: corvink, jhb, emaste Differential Revision: https://reviews.freebsd.org/D46429 --- sys/amd64/vmm/amd/svm.c | 3 +- sys/amd64/vmm/amd/vmcb.c | 2 +- sys/amd64/vmm/intel/vmx.c | 3 +- sys/amd64/vmm/io/ppt.c | 4 +-- sys/amd64/vmm/io/vatpic.c | 6 ++-- sys/amd64/vmm/io/vatpit.c | 3 +- sys/amd64/vmm/io/vhpet.c | 7 ++-- sys/amd64/vmm/io/vioapic.c | 3 +- sys/amd64/vmm/io/vlapic.c | 4 +-- sys/amd64/vmm/io/vrtc.c | 3 +- sys/amd64/vmm/vmm.c | 3 +- sys/amd64/vmm/vmm_ioport.c | 3 +- sys/amd64/vmm/vmm_lapic.c | 3 +- sys/amd64/vmm/x86.c | 4 +-- sys/arm64/vmm/vmm.c | 2 +- sys/arm64/vmm/vmm_ktr.h | 69 ---------------------------------------- sys/{amd64 => dev}/vmm/vmm_ktr.h | 0 17 files changed, 30 insertions(+), 92 deletions(-) diff --git a/sys/amd64/vmm/amd/svm.c b/sys/amd64/vmm/amd/svm.c index b35cf53be080..1015b04ee161 100644 --- a/sys/amd64/vmm/amd/svm.c +++ b/sys/amd64/vmm/amd/svm.c @@ -54,9 +54,10 @@ #include #include +#include + #include "vmm_lapic.h" #include "vmm_stat.h" -#include "vmm_ktr.h" #include "vmm_ioport.h" #include "vatpic.h" #include "vlapic.h" diff --git a/sys/amd64/vmm/amd/vmcb.c b/sys/amd64/vmm/amd/vmcb.c index 4bd2fae9f821..9a1008fa495c 100644 --- a/sys/amd64/vmm/amd/vmcb.c +++ b/sys/amd64/vmm/amd/vmcb.c @@ -37,7 +37,7 @@ #include #include -#include "vmm_ktr.h" +#include #include "vlapic.h" #include "vmcb.h" diff --git a/sys/amd64/vmm/intel/vmx.c b/sys/amd64/vmm/intel/vmx.c index 31ca9256b527..63b0cf3d2ff9 100644 --- a/sys/amd64/vmm/intel/vmx.c +++ b/sys/amd64/vmm/intel/vmx.c @@ -58,10 +58,11 @@ #include #include +#include + #include "vmm_lapic.h" #include "vmm_host.h" #include "vmm_ioport.h" -#include "vmm_ktr.h" #include "vmm_stat.h" #include "vatpic.h" #include "vlapic.h" diff --git a/sys/amd64/vmm/io/ppt.c b/sys/amd64/vmm/io/ppt.c index 9fcfdc7cb441..109707dbcbd5 100644 --- a/sys/amd64/vmm/io/ppt.c +++ b/sys/amd64/vmm/io/ppt.c @@ -41,12 +41,12 @@ #include #include - #include #include +#include + #include "vmm_lapic.h" -#include "vmm_ktr.h" #include "iommu.h" #include "ppt.h" diff --git a/sys/amd64/vmm/io/vatpic.c b/sys/amd64/vmm/io/vatpic.c index 788fcec9ceb3..a003cd7e8c07 100644 --- a/sys/amd64/vmm/io/vatpic.c +++ b/sys/amd64/vmm/io/vatpic.c @@ -39,12 +39,12 @@ #include #include -#include - #include #include -#include "vmm_ktr.h" +#include +#include + #include "vmm_lapic.h" #include "vioapic.h" #include "vatpic.h" diff --git a/sys/amd64/vmm/io/vatpit.c b/sys/amd64/vmm/io/vatpit.c index e7bf74dd7e94..31b6c2ad0f89 100644 --- a/sys/amd64/vmm/io/vatpit.c +++ b/sys/amd64/vmm/io/vatpit.c @@ -41,7 +41,8 @@ #include #include -#include "vmm_ktr.h" +#include + #include "vatpic.h" #include "vioapic.h" #include "vatpit.h" diff --git a/sys/amd64/vmm/io/vhpet.c b/sys/amd64/vmm/io/vhpet.c index daa85bccf14f..a1dfc7ba731f 100644 --- a/sys/amd64/vmm/io/vhpet.c +++ b/sys/amd64/vmm/io/vhpet.c @@ -37,19 +37,18 @@ #include #include -#include - #include #include #include +#include +#include + #include "vmm_lapic.h" #include "vatpic.h" #include "vioapic.h" #include "vhpet.h" -#include "vmm_ktr.h" - static MALLOC_DEFINE(M_VHPET, "vhpet", "bhyve virtual hpet"); #define HPET_FREQ 16777216 /* 16.7 (2^24) Mhz */ diff --git a/sys/amd64/vmm/io/vioapic.c b/sys/amd64/vmm/io/vioapic.c index e1503b6a699b..8869dc1383e6 100644 --- a/sys/amd64/vmm/io/vioapic.c +++ b/sys/amd64/vmm/io/vioapic.c @@ -42,7 +42,8 @@ #include #include -#include "vmm_ktr.h" +#include + #include "vmm_lapic.h" #include "vlapic.h" #include "vioapic.h" diff --git a/sys/amd64/vmm/io/vlapic.c b/sys/amd64/vmm/io/vlapic.c index 7c29cca4d907..dce7528ac773 100644 --- a/sys/amd64/vmm/io/vlapic.c +++ b/sys/amd64/vmm/io/vlapic.c @@ -43,12 +43,12 @@ #include #include - #include #include +#include + #include "vmm_lapic.h" -#include "vmm_ktr.h" #include "vmm_stat.h" #include "vlapic.h" diff --git a/sys/amd64/vmm/io/vrtc.c b/sys/amd64/vmm/io/vrtc.c index 0840f8e88d5c..7dc651a7b883 100644 --- a/sys/amd64/vmm/io/vrtc.c +++ b/sys/amd64/vmm/io/vrtc.c @@ -44,7 +44,8 @@ #include -#include "vmm_ktr.h" +#include + #include "vatpic.h" #include "vioapic.h" #include "vrtc.h" diff --git a/sys/amd64/vmm/vmm.c b/sys/amd64/vmm/vmm.c index f399f876717d..b0465ea84fcb 100644 --- a/sys/amd64/vmm/vmm.c +++ b/sys/amd64/vmm/vmm.c @@ -71,8 +71,9 @@ #include #include +#include + #include "vmm_ioport.h" -#include "vmm_ktr.h" #include "vmm_host.h" #include "vmm_mem.h" #include "vmm_util.h" diff --git a/sys/amd64/vmm/vmm_ioport.c b/sys/amd64/vmm/vmm_ioport.c index ac14e54dc4a5..f036841f4e10 100644 --- a/sys/amd64/vmm/vmm_ioport.c +++ b/sys/amd64/vmm/vmm_ioport.c @@ -32,12 +32,13 @@ #include #include +#include + #include "vatpic.h" #include "vatpit.h" #include "vpmtmr.h" #include "vrtc.h" #include "vmm_ioport.h" -#include "vmm_ktr.h" #define MAX_IOPORTS 1280 diff --git a/sys/amd64/vmm/vmm_lapic.c b/sys/amd64/vmm/vmm_lapic.c index bafd839afe64..fd511733492e 100644 --- a/sys/amd64/vmm/vmm_lapic.c +++ b/sys/amd64/vmm/vmm_lapic.c @@ -33,8 +33,9 @@ #include #include +#include + #include -#include "vmm_ktr.h" #include "vmm_lapic.h" #include "vlapic.h" diff --git a/sys/amd64/vmm/x86.c b/sys/amd64/vmm/x86.c index 1167652d88ea..a833b61786e7 100644 --- a/sys/amd64/vmm/x86.c +++ b/sys/amd64/vmm/x86.c @@ -36,11 +36,11 @@ #include #include #include - #include +#include + #include "vmm_host.h" -#include "vmm_ktr.h" #include "vmm_util.h" #include "x86.h" diff --git a/sys/arm64/vmm/vmm.c b/sys/arm64/vmm/vmm.c index c6a49ebc4b03..f5173c4152bd 100644 --- a/sys/arm64/vmm/vmm.c +++ b/sys/arm64/vmm/vmm.c @@ -64,8 +64,8 @@ #include #include +#include -#include "vmm_ktr.h" #include "vmm_stat.h" #include "arm64.h" #include "mmu.h" diff --git a/sys/arm64/vmm/vmm_ktr.h b/sys/arm64/vmm/vmm_ktr.h deleted file mode 100644 index 965f440ae874..000000000000 --- a/sys/arm64/vmm/vmm_ktr.h +++ /dev/null @@ -1,69 +0,0 @@ -/*- - * SPDX-License-Identifier: BSD-2-Clause-FreeBSD - * - * Copyright (c) 2011 NetApp, Inc. - * All rights reserved. - * - * Redistribution and use in source and binary forms, with or without - * modification, are permitted provided that the following conditions - * are met: - * 1. Redistributions of source code must retain the above copyright - * notice, this list of conditions and the following disclaimer. - * 2. Redistributions in binary form must reproduce the above copyright - * notice, this list of conditions and the following disclaimer in the - * documentation and/or other materials provided with the distribution. - * - * THIS SOFTWARE IS PROVIDED BY NETAPP, INC ``AS IS'' AND - * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE - * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE - * ARE DISCLAIMED. IN NO EVENT SHALL NETAPP, INC OR CONTRIBUTORS BE LIABLE - * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL - * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS - * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) - * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT - * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY - * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF - * SUCH DAMAGE. - */ - -#ifndef _VMM_KTR_H_ -#define _VMM_KTR_H_ - -#include -#include - -#ifndef KTR_VMM -#define KTR_VMM KTR_GEN -#endif - -#define VCPU_CTR0(vm, vcpuid, format) \ -CTR2(KTR_VMM, "vm %s[%d]: " format, vm_name((vm)), (vcpuid)) - -#define VCPU_CTR1(vm, vcpuid, format, p1) \ -CTR3(KTR_VMM, "vm %s[%d]: " format, vm_name((vm)), (vcpuid), (p1)) - -#define VCPU_CTR2(vm, vcpuid, format, p1, p2) \ -CTR4(KTR_VMM, "vm %s[%d]: " format, vm_name((vm)), (vcpuid), (p1), (p2)) - -#define VCPU_CTR3(vm, vcpuid, format, p1, p2, p3) \ -CTR5(KTR_VMM, "vm %s[%d]: " format, vm_name((vm)), (vcpuid), (p1), (p2), (p3)) - -#define VCPU_CTR4(vm, vcpuid, format, p1, p2, p3, p4) \ -CTR6(KTR_VMM, "vm %s[%d]: " format, vm_name((vm)), (vcpuid), \ - (p1), (p2), (p3), (p4)) - -#define VM_CTR0(vm, format) \ -CTR1(KTR_VMM, "vm %s: " format, vm_name((vm))) - -#define VM_CTR1(vm, format, p1) \ -CTR2(KTR_VMM, "vm %s: " format, vm_name((vm)), (p1)) - -#define VM_CTR2(vm, format, p1, p2) \ -CTR3(KTR_VMM, "vm %s: " format, vm_name((vm)), (p1), (p2)) - -#define VM_CTR3(vm, format, p1, p2, p3) \ -CTR4(KTR_VMM, "vm %s: " format, vm_name((vm)), (p1), (p2), (p3)) - -#define VM_CTR4(vm, format, p1, p2, p3, p4) \ -CTR5(KTR_VMM, "vm %s: " format, vm_name((vm)), (p1), (p2), (p3), (p4)) -#endif diff --git a/sys/amd64/vmm/vmm_ktr.h b/sys/dev/vmm/vmm_ktr.h similarity index 100% rename from sys/amd64/vmm/vmm_ktr.h rename to sys/dev/vmm/vmm_ktr.h From nobody Mon Aug 26 18:58:30 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Wt0Lt2w8Rz5TRD4; Mon, 26 Aug 2024 18:58:30 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Wt0Lt2F63z4F8R; Mon, 26 Aug 2024 18:58:30 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724698710; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Yv90j1+6tgzRAayosuY8kwKVacRqmnHXKow5NAm+XEM=; b=AwAfypxEnDLM8ypdRs4dxR5ozmu0arBkA5esVJdNSkCBE3zfuRAN/FtauZVG4SNg6YiZLN KtQbc12OsbFbwjTM0z72VRazDf5Gs55TWLAuTEG5qrz93Jo+eBf/GCjJIpDlw8sBYmJB1E 3a4OS3rGbJfeNsp2p2vnMCRGtIwbIU60YxcbUVraAmYAOrvM0QDdmOQ82fX9vp5hW51hVt XLZGJ052NpvvTN868UIPkxl5Ov2ouHBjVw7VD7PAn+gJRsQ2WXXLBsL//xXjYq4+PaIkT0 oJ+AEpthXN/e+LTa5kdyEpsU6bCVBlunTLlDwcnbRzbSJIV6m1dRLXRBwxhYSA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724698710; a=rsa-sha256; cv=none; b=HJSkU3pRhZKybiPoAzViy4DAvFcdR+XhIb0Hfa79XvRL+LiLbxbvbL8ClKyB06E1Rm1h6A HfGaonBgNUWrHjo4NJp+k4Udmtjnn5pfTY2Sjv8SIerMeDS159NbTipx73dBNOwxj/TMVo eAdtBTOu+tXYTr/PpYU3sh5qgmKgMHSPPneGYTfrHGHh9stPH8lYat8/j3Q9h9IdzeqL7q yMefS6uNAROqM0MOgmai7IM5pZZbjfM0AB7BcYDF/mW0kMtZuzyFXELun3aqDl/5Xdy/K1 XpQJldmelEjtyB1B5g56RhDp1W1pMQsmIDrJb/fSagXhUS6+O0satKhlC3K7oA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724698710; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Yv90j1+6tgzRAayosuY8kwKVacRqmnHXKow5NAm+XEM=; b=WLcyOJqTCcLf+j7pnBH47qp9XdulbAmWhrKgurZ/8NL32rdhuYlVv53YHnBvBymKuIpiEp P+ZuNVrtIyyiPZ5i7RoBw6R+pGcG627Hb+5vOtoLjW8ChxWwV2XU3k9nysQKXptw8IyiW/ /9IfY4wqAhX2YKnQoMia6xwcJupiLfHYkGAfxbeEtndT1xRVVUSKyK3e/zc2Zpso+b3Zmz bufHGsiniFWKjYBpdHWEdS9FOvU/0fNMTYS6YdljE1lNt1rHEoGQ3JRFo9ALXcUbMTkut4 qXCQPNkYMuqRqXq4afxMR9DEuRb2zBOEFvC+HYSJmgN8IrYzRkHKfYC43LnLeQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Wt0Lt1rBFzJZ5; Mon, 26 Aug 2024 18:58:30 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47QIwULg027556; Mon, 26 Aug 2024 18:58:30 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47QIwUYJ027553; Mon, 26 Aug 2024 18:58:30 GMT (envelope-from git) Date: Mon, 26 Aug 2024 18:58:30 GMT Message-Id: <202408261858.47QIwUYJ027553@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: 93e81baa1c1b - main - vmm: Move duplicated stats code into a generic file List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 93e81baa1c1baccf4eca9e3dbfe5ac9378e9623a Auto-Submitted: auto-generated The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=93e81baa1c1baccf4eca9e3dbfe5ac9378e9623a commit 93e81baa1c1baccf4eca9e3dbfe5ac9378e9623a Author: Mark Johnston AuthorDate: 2024-08-26 18:41:14 +0000 Commit: Mark Johnston CommitDate: 2024-08-26 18:41:14 +0000 vmm: Move duplicated stats code into a generic file There is a small difference between the arm64 and amd64 implementations: the latter makes use of a "scope" to exclude AMD-specific stats on Intel systems and vice-versa. Replace this with a more generic predicate callback which can be used for the same purpose. No functional change intended. Reviewed by: corvink, jhb Differential Revision: https://reviews.freebsd.org/D46430 --- sys/amd64/vmm/vmm.c | 23 +++++ sys/amd64/vmm/vmm_stat.c | 177 -------------------------------------- sys/amd64/vmm/vmm_stat.h | 109 ++--------------------- sys/arm64/vmm/vmm.c | 19 +++- sys/arm64/vmm/vmm_stat.h | 98 +-------------------- sys/conf/files.arm64 | 2 +- sys/{arm64 => dev}/vmm/vmm_stat.c | 26 ++---- sys/dev/vmm/vmm_stat.h | 135 +++++++++++++++++++++++++++++ sys/modules/vmm/Makefile | 7 +- 9 files changed, 196 insertions(+), 400 deletions(-) diff --git a/sys/amd64/vmm/vmm.c b/sys/amd64/vmm/vmm.c index b0465ea84fcb..d0259b3b125f 100644 --- a/sys/amd64/vmm/vmm.c +++ b/sys/amd64/vmm/vmm.c @@ -297,6 +297,29 @@ static void vm_free_memmap(struct vm *vm, int ident); static bool sysmem_mapping(struct vm *vm, struct mem_map *mm); static void vcpu_notify_event_locked(struct vcpu *vcpu, bool lapic_intr); +/* global statistics */ +VMM_STAT(VCPU_MIGRATIONS, "vcpu migration across host cpus"); +VMM_STAT(VMEXIT_COUNT, "total number of vm exits"); +VMM_STAT(VMEXIT_EXTINT, "vm exits due to external interrupt"); +VMM_STAT(VMEXIT_HLT, "number of times hlt was intercepted"); +VMM_STAT(VMEXIT_CR_ACCESS, "number of times %cr access was intercepted"); +VMM_STAT(VMEXIT_RDMSR, "number of times rdmsr was intercepted"); +VMM_STAT(VMEXIT_WRMSR, "number of times wrmsr was intercepted"); +VMM_STAT(VMEXIT_MTRAP, "number of monitor trap exits"); +VMM_STAT(VMEXIT_PAUSE, "number of times pause was intercepted"); +VMM_STAT(VMEXIT_INTR_WINDOW, "vm exits due to interrupt window opening"); +VMM_STAT(VMEXIT_NMI_WINDOW, "vm exits due to nmi window opening"); +VMM_STAT(VMEXIT_INOUT, "number of times in/out was intercepted"); +VMM_STAT(VMEXIT_CPUID, "number of times cpuid was intercepted"); +VMM_STAT(VMEXIT_NESTED_FAULT, "vm exits due to nested page fault"); +VMM_STAT(VMEXIT_INST_EMUL, "vm exits for instruction emulation"); +VMM_STAT(VMEXIT_UNKNOWN, "number of vm exits for unknown reason"); +VMM_STAT(VMEXIT_ASTPENDING, "number of times astpending at exit"); +VMM_STAT(VMEXIT_REQIDLE, "number of times idle requested at exit"); +VMM_STAT(VMEXIT_USERSPACE, "number of vm exits handled in userspace"); +VMM_STAT(VMEXIT_RENDEZVOUS, "number of times rendezvous pending at exit"); +VMM_STAT(VMEXIT_EXCEPTION, "number of vm exits due to exceptions"); + /* * Upper limit on vm_maxcpu. Limited by use of uint16_t types for CPU * counts as well as range of vpid values for VT-x and by the capacity diff --git a/sys/amd64/vmm/vmm_stat.c b/sys/amd64/vmm/vmm_stat.c deleted file mode 100644 index eb394418b4a9..000000000000 --- a/sys/amd64/vmm/vmm_stat.c +++ /dev/null @@ -1,177 +0,0 @@ -/*- - * SPDX-License-Identifier: BSD-2-Clause - * - * Copyright (c) 2011 NetApp, Inc. - * All rights reserved. - * - * Redistribution and use in source and binary forms, with or without - * modification, are permitted provided that the following conditions - * are met: - * 1. Redistributions of source code must retain the above copyright - * notice, this list of conditions and the following disclaimer. - * 2. Redistributions in binary form must reproduce the above copyright - * notice, this list of conditions and the following disclaimer in the - * documentation and/or other materials provided with the distribution. - * - * THIS SOFTWARE IS PROVIDED BY NETAPP, INC ``AS IS'' AND - * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE - * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE - * ARE DISCLAIMED. IN NO EVENT SHALL NETAPP, INC OR CONTRIBUTORS BE LIABLE - * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL - * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS - * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) - * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT - * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY - * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF - * SUCH DAMAGE. - */ - -#include -#include -#include -#include - -#include -#include "vmm_util.h" -#include "vmm_stat.h" - -/* - * 'vst_num_elems' is the total number of addressable statistic elements - * 'vst_num_types' is the number of unique statistic types - * - * It is always true that 'vst_num_elems' is greater than or equal to - * 'vst_num_types'. This is because a stat type may represent more than - * one element (for e.g. VMM_STAT_ARRAY). - */ -static int vst_num_elems, vst_num_types; -static struct vmm_stat_type *vsttab[MAX_VMM_STAT_ELEMS]; - -static MALLOC_DEFINE(M_VMM_STAT, "vmm stat", "vmm stat"); - -#define vst_size ((size_t)vst_num_elems * sizeof(uint64_t)) - -void -vmm_stat_register(void *arg) -{ - struct vmm_stat_type *vst = arg; - - /* We require all stats to identify themselves with a description */ - if (vst->desc == NULL) - return; - - if (vst->scope == VMM_STAT_SCOPE_INTEL && !vmm_is_intel()) - return; - - if (vst->scope == VMM_STAT_SCOPE_AMD && !vmm_is_svm()) - return; - - if (vst_num_elems + vst->nelems >= MAX_VMM_STAT_ELEMS) { - printf("Cannot accommodate vmm stat type \"%s\"!\n", vst->desc); - return; - } - - vst->index = vst_num_elems; - vst_num_elems += vst->nelems; - - vsttab[vst_num_types++] = vst; -} - -int -vmm_stat_copy(struct vcpu *vcpu, int index, int count, int *num_stats, - uint64_t *buf) -{ - struct vmm_stat_type *vst; - uint64_t *stats; - int i, tocopy; - - if (index < 0 || count < 0) - return (EINVAL); - - if (index > vst_num_elems) - return (ENOENT); - - if (index == vst_num_elems) { - *num_stats = 0; - return (0); - } - - tocopy = min(vst_num_elems - index, count); - - /* Let stats functions update their counters */ - for (i = 0; i < vst_num_types; i++) { - vst = vsttab[i]; - if (vst->func != NULL) - (*vst->func)(vcpu, vst); - } - - /* Copy over the stats */ - stats = vcpu_stats(vcpu); - memcpy(buf, stats + index, tocopy * sizeof(stats[0])); - *num_stats = tocopy; - return (0); -} - -void * -vmm_stat_alloc(void) -{ - - return (malloc(vst_size, M_VMM_STAT, M_WAITOK)); -} - -void -vmm_stat_init(void *vp) -{ - - bzero(vp, vst_size); -} - -void -vmm_stat_free(void *vp) -{ - free(vp, M_VMM_STAT); -} - -int -vmm_stat_desc_copy(int index, char *buf, int bufsize) -{ - int i; - struct vmm_stat_type *vst; - - for (i = 0; i < vst_num_types; i++) { - vst = vsttab[i]; - if (index >= vst->index && index < vst->index + vst->nelems) { - if (vst->nelems > 1) { - snprintf(buf, bufsize, "%s[%d]", - vst->desc, index - vst->index); - } else { - strlcpy(buf, vst->desc, bufsize); - } - return (0); /* found it */ - } - } - - return (EINVAL); -} - -/* global statistics */ -VMM_STAT(VCPU_MIGRATIONS, "vcpu migration across host cpus"); -VMM_STAT(VMEXIT_COUNT, "total number of vm exits"); -VMM_STAT(VMEXIT_EXTINT, "vm exits due to external interrupt"); -VMM_STAT(VMEXIT_HLT, "number of times hlt was intercepted"); -VMM_STAT(VMEXIT_CR_ACCESS, "number of times %cr access was intercepted"); -VMM_STAT(VMEXIT_RDMSR, "number of times rdmsr was intercepted"); -VMM_STAT(VMEXIT_WRMSR, "number of times wrmsr was intercepted"); -VMM_STAT(VMEXIT_MTRAP, "number of monitor trap exits"); -VMM_STAT(VMEXIT_PAUSE, "number of times pause was intercepted"); -VMM_STAT(VMEXIT_INTR_WINDOW, "vm exits due to interrupt window opening"); -VMM_STAT(VMEXIT_NMI_WINDOW, "vm exits due to nmi window opening"); -VMM_STAT(VMEXIT_INOUT, "number of times in/out was intercepted"); -VMM_STAT(VMEXIT_CPUID, "number of times cpuid was intercepted"); -VMM_STAT(VMEXIT_NESTED_FAULT, "vm exits due to nested page fault"); -VMM_STAT(VMEXIT_INST_EMUL, "vm exits for instruction emulation"); -VMM_STAT(VMEXIT_UNKNOWN, "number of vm exits for unknown reason"); -VMM_STAT(VMEXIT_ASTPENDING, "number of times astpending at exit"); -VMM_STAT(VMEXIT_REQIDLE, "number of times idle requested at exit"); -VMM_STAT(VMEXIT_USERSPACE, "number of vm exits handled in userspace"); -VMM_STAT(VMEXIT_RENDEZVOUS, "number of times rendezvous pending at exit"); -VMM_STAT(VMEXIT_EXCEPTION, "number of vm exits due to exceptions"); diff --git a/sys/amd64/vmm/vmm_stat.h b/sys/amd64/vmm/vmm_stat.h index 7d3a4044dcce..cf3895001528 100644 --- a/sys/amd64/vmm/vmm_stat.h +++ b/sys/amd64/vmm/vmm_stat.h @@ -32,108 +32,9 @@ #ifndef _VMM_STAT_H_ #define _VMM_STAT_H_ -struct vm; +#include -#define MAX_VMM_STAT_ELEMS 64 /* arbitrary */ - -enum vmm_stat_scope { - VMM_STAT_SCOPE_ANY, - VMM_STAT_SCOPE_INTEL, /* Intel VMX specific statistic */ - VMM_STAT_SCOPE_AMD, /* AMD SVM specific statistic */ -}; - -struct vmm_stat_type; -typedef void (*vmm_stat_func_t)(struct vcpu *vcpu, - struct vmm_stat_type *stat); - -struct vmm_stat_type { - int index; /* position in the stats buffer */ - int nelems; /* standalone or array */ - const char *desc; /* description of statistic */ - vmm_stat_func_t func; - enum vmm_stat_scope scope; -}; - -void vmm_stat_register(void *arg); - -#define VMM_STAT_FDEFINE(type, nelems, desc, func, scope) \ - struct vmm_stat_type type[1] = { \ - { -1, nelems, desc, func, scope } \ - }; \ - SYSINIT(type##_stat, SI_SUB_KLD, SI_ORDER_ANY, vmm_stat_register, type) - -#define VMM_STAT_DEFINE(type, nelems, desc, scope) \ - VMM_STAT_FDEFINE(type, nelems, desc, NULL, scope) - -#define VMM_STAT_DECLARE(type) \ - extern struct vmm_stat_type type[1] - -#define VMM_STAT(type, desc) \ - VMM_STAT_DEFINE(type, 1, desc, VMM_STAT_SCOPE_ANY) -#define VMM_STAT_INTEL(type, desc) \ - VMM_STAT_DEFINE(type, 1, desc, VMM_STAT_SCOPE_INTEL) -#define VMM_STAT_AMD(type, desc) \ - VMM_STAT_DEFINE(type, 1, desc, VMM_STAT_SCOPE_AMD) - -#define VMM_STAT_FUNC(type, desc, func) \ - VMM_STAT_FDEFINE(type, 1, desc, func, VMM_STAT_SCOPE_ANY) - -#define VMM_STAT_ARRAY(type, nelems, desc) \ - VMM_STAT_DEFINE(type, nelems, desc, VMM_STAT_SCOPE_ANY) - -void *vmm_stat_alloc(void); -void vmm_stat_init(void *vp); -void vmm_stat_free(void *vp); - -int vmm_stat_copy(struct vcpu *vcpu, int index, int count, - int *num_stats, uint64_t *buf); -int vmm_stat_desc_copy(int index, char *buf, int buflen); - -static void __inline -vmm_stat_array_incr(struct vcpu *vcpu, struct vmm_stat_type *vst, int statidx, - uint64_t x) -{ -#ifdef VMM_KEEP_STATS - uint64_t *stats; - - stats = vcpu_stats(vcpu); - - if (vst->index >= 0 && statidx < vst->nelems) - stats[vst->index + statidx] += x; -#endif -} - -static void __inline -vmm_stat_array_set(struct vcpu *vcpu, struct vmm_stat_type *vst, int statidx, - uint64_t val) -{ -#ifdef VMM_KEEP_STATS - uint64_t *stats; - - stats = vcpu_stats(vcpu); - - if (vst->index >= 0 && statidx < vst->nelems) - stats[vst->index + statidx] = val; -#endif -} - -static void __inline -vmm_stat_incr(struct vcpu *vcpu, struct vmm_stat_type *vst, uint64_t x) -{ - -#ifdef VMM_KEEP_STATS - vmm_stat_array_incr(vcpu, vst, 0, x); -#endif -} - -static void __inline -vmm_stat_set(struct vcpu *vcpu, struct vmm_stat_type *vst, uint64_t val) -{ - -#ifdef VMM_KEEP_STATS - vmm_stat_array_set(vcpu, vst, 0, val); -#endif -} +#include "vmm_util.h" VMM_STAT_DECLARE(VCPU_MIGRATIONS); VMM_STAT_DECLARE(VMEXIT_COUNT); @@ -156,4 +57,10 @@ VMM_STAT_DECLARE(VMEXIT_USERSPACE); VMM_STAT_DECLARE(VMEXIT_RENDEZVOUS); VMM_STAT_DECLARE(VMEXIT_EXCEPTION); VMM_STAT_DECLARE(VMEXIT_REQIDLE); + +#define VMM_STAT_INTEL(type, desc) \ + VMM_STAT_DEFINE(type, 1, desc, vmm_is_intel) +#define VMM_STAT_AMD(type, desc) \ + VMM_STAT_DEFINE(type, 1, desc, vmm_is_svm) + #endif diff --git a/sys/arm64/vmm/vmm.c b/sys/arm64/vmm/vmm.c index f5173c4152bd..425e44f81500 100644 --- a/sys/arm64/vmm/vmm.c +++ b/sys/arm64/vmm/vmm.c @@ -65,8 +65,8 @@ #include #include +#include -#include "vmm_stat.h" #include "arm64.h" #include "mmu.h" @@ -239,6 +239,23 @@ static void vm_free_memmap(struct vm *vm, int ident); static bool sysmem_mapping(struct vm *vm, struct mem_map *mm); static void vcpu_notify_event_locked(struct vcpu *vcpu); +/* global statistics */ +VMM_STAT(VMEXIT_COUNT, "total number of vm exits"); +VMM_STAT(VMEXIT_UNKNOWN, "number of vmexits for the unknown exception"); +VMM_STAT(VMEXIT_WFI, "number of times wfi was intercepted"); +VMM_STAT(VMEXIT_WFE, "number of times wfe was intercepted"); +VMM_STAT(VMEXIT_HVC, "number of times hvc was intercepted"); +VMM_STAT(VMEXIT_MSR, "number of times msr/mrs was intercepted"); +VMM_STAT(VMEXIT_DATA_ABORT, "number of vmexits for a data abort"); +VMM_STAT(VMEXIT_INSN_ABORT, "number of vmexits for an instruction abort"); +VMM_STAT(VMEXIT_UNHANDLED_SYNC, "number of vmexits for an unhandled synchronous exception"); +VMM_STAT(VMEXIT_IRQ, "number of vmexits for an irq"); +VMM_STAT(VMEXIT_FIQ, "number of vmexits for an interrupt"); +VMM_STAT(VMEXIT_BRK, "number of vmexits for a breakpoint exception"); +VMM_STAT(VMEXIT_SS, "number of vmexits for a single-step exception"); +VMM_STAT(VMEXIT_UNHANDLED_EL2, "number of vmexits for an unhandled EL2 exception"); +VMM_STAT(VMEXIT_UNHANDLED, "number of vmexits for an unhandled exception"); + /* * Upper limit on vm_maxcpu. We could increase this to 28 bits, but this * is a safe value for now. diff --git a/sys/arm64/vmm/vmm_stat.h b/sys/arm64/vmm/vmm_stat.h index 402fa2f1b1e4..0dc3eeced603 100644 --- a/sys/arm64/vmm/vmm_stat.h +++ b/sys/arm64/vmm/vmm_stat.h @@ -32,102 +32,7 @@ #ifndef _VMM_STAT_H_ #define _VMM_STAT_H_ -struct vm; - -#define MAX_VMM_STAT_ELEMS 64 /* arbitrary */ - -enum vmm_stat_scope { - VMM_STAT_SCOPE_ANY, -}; - -struct vmm_stat_type; -typedef void (*vmm_stat_func_t)(struct vcpu *vcpu, - struct vmm_stat_type *stat); - -struct vmm_stat_type { - int index; /* position in the stats buffer */ - int nelems; /* standalone or array */ - const char *desc; /* description of statistic */ - vmm_stat_func_t func; - enum vmm_stat_scope scope; -}; - -void vmm_stat_register(void *arg); - -#define VMM_STAT_FDEFINE(type, nelems, desc, func, scope) \ - struct vmm_stat_type type[1] = { \ - { -1, nelems, desc, func, scope } \ - }; \ - SYSINIT(type##_stat, SI_SUB_KLD, SI_ORDER_ANY, vmm_stat_register, type) - -#define VMM_STAT_DEFINE(type, nelems, desc, scope) \ - VMM_STAT_FDEFINE(type, nelems, desc, NULL, scope) - -#define VMM_STAT_DECLARE(type) \ - extern struct vmm_stat_type type[1] - -#define VMM_STAT(type, desc) \ - VMM_STAT_DEFINE(type, 1, desc, VMM_STAT_SCOPE_ANY) - -#define VMM_STAT_FUNC(type, desc, func) \ - VMM_STAT_FDEFINE(type, 1, desc, func, VMM_STAT_SCOPE_ANY) - -#define VMM_STAT_ARRAY(type, nelems, desc) \ - VMM_STAT_DEFINE(type, nelems, desc, VMM_STAT_SCOPE_ANY) - -void *vmm_stat_alloc(void); -void vmm_stat_init(void *vp); -void vmm_stat_free(void *vp); - -int vmm_stat_copy(struct vcpu *vcpu, int index, int count, - int *num_stats, uint64_t *buf); -int vmm_stat_desc_copy(int index, char *buf, int buflen); - -static void __inline -vmm_stat_array_incr(struct vcpu *vcpu, struct vmm_stat_type *vst, int statidx, - uint64_t x) -{ -#ifdef VMM_KEEP_STATS - uint64_t *stats; - - stats = vcpu_stats(vcpu); - - if (vst->index >= 0 && statidx < vst->nelems) - stats[vst->index + statidx] += x; -#endif -} - -static void __inline -vmm_stat_array_set(struct vcpu *vcpu, struct vmm_stat_type *vst, int statidx, - uint64_t val) -{ -#ifdef VMM_KEEP_STATS - uint64_t *stats; - - stats = vcpu_stats(vcpu); - - if (vst->index >= 0 && statidx < vst->nelems) - stats[vst->index + statidx] = val; -#endif -} - -static void __inline -vmm_stat_incr(struct vcpu *vcpu, struct vmm_stat_type *vst, uint64_t x) -{ - -#ifdef VMM_KEEP_STATS - vmm_stat_array_incr(vcpu, vst, 0, x); -#endif -} - -static void __inline -vmm_stat_set(struct vcpu *vcpu, struct vmm_stat_type *vst, uint64_t val) -{ - -#ifdef VMM_KEEP_STATS - vmm_stat_array_set(vcpu, vst, 0, val); -#endif -} +#include VMM_STAT_DECLARE(VMEXIT_COUNT); VMM_STAT_DECLARE(VMEXIT_UNKNOWN); @@ -144,4 +49,5 @@ VMM_STAT_DECLARE(VMEXIT_BRK); VMM_STAT_DECLARE(VMEXIT_SS); VMM_STAT_DECLARE(VMEXIT_UNHANDLED_EL2); VMM_STAT_DECLARE(VMEXIT_UNHANDLED); + #endif diff --git a/sys/conf/files.arm64 b/sys/conf/files.arm64 index 1c863ff98998..3a8818340f75 100644 --- a/sys/conf/files.arm64 +++ b/sys/conf/files.arm64 @@ -119,7 +119,6 @@ dev/iommu/iommu_gas.c optional iommu arm64/vmm/vmm.c optional vmm arm64/vmm/vmm_dev.c optional vmm arm64/vmm/vmm_instruction_emul.c optional vmm -arm64/vmm/vmm_stat.c optional vmm arm64/vmm/vmm_arm64.c optional vmm arm64/vmm/vmm_reset.c optional vmm arm64/vmm/vmm_handlers.c optional vmm @@ -151,6 +150,7 @@ arm64/vmm/io/vgic.c optional vmm arm64/vmm/io/vgic_v3.c optional vmm arm64/vmm/io/vgic_if.m optional vmm arm64/vmm/io/vtimer.c optional vmm +dev/vmm/vmm_stat.c optional vmm crypto/armv8/armv8_crypto.c optional armv8crypto armv8_crypto_wrap.o optional armv8crypto \ diff --git a/sys/arm64/vmm/vmm_stat.c b/sys/dev/vmm/vmm_stat.c similarity index 77% rename from sys/arm64/vmm/vmm_stat.c rename to sys/dev/vmm/vmm_stat.c index 05ece6f30579..44edd6af85dd 100644 --- a/sys/arm64/vmm/vmm_stat.c +++ b/sys/dev/vmm/vmm_stat.c @@ -26,16 +26,14 @@ * SUCH DAMAGE. */ -#include - #include #include #include #include -#include #include -#include "vmm_stat.h" + +#include /* * 'vst_num_elems' is the total number of addressable statistic elements @@ -61,6 +59,9 @@ vmm_stat_register(void *arg) if (vst->desc == NULL) return; + if (vst->pred != NULL && !vst->pred()) + return; + if (vst_num_elems + vst->nelems >= MAX_VMM_STAT_ELEMS) { printf("Cannot accommodate vmm stat type \"%s\"!\n", vst->desc); return; @@ -148,20 +149,3 @@ vmm_stat_desc_copy(int index, char *buf, int bufsize) return (EINVAL); } - -/* global statistics */ -VMM_STAT(VMEXIT_COUNT, "total number of vm exits"); -VMM_STAT(VMEXIT_UNKNOWN, "number of vmexits for the unknown exception"); -VMM_STAT(VMEXIT_WFI, "number of times wfi was intercepted"); -VMM_STAT(VMEXIT_WFE, "number of times wfe was intercepted"); -VMM_STAT(VMEXIT_HVC, "number of times hvc was intercepted"); -VMM_STAT(VMEXIT_MSR, "number of times msr/mrs was intercepted"); -VMM_STAT(VMEXIT_DATA_ABORT, "number of vmexits for a data abort"); -VMM_STAT(VMEXIT_INSN_ABORT, "number of vmexits for an instruction abort"); -VMM_STAT(VMEXIT_UNHANDLED_SYNC, "number of vmexits for an unhandled synchronous exception"); -VMM_STAT(VMEXIT_IRQ, "number of vmexits for an irq"); -VMM_STAT(VMEXIT_FIQ, "number of vmexits for an interrupt"); -VMM_STAT(VMEXIT_BRK, "number of vmexits for a breakpoint exception"); -VMM_STAT(VMEXIT_SS, "number of vmexits for a single-step exception"); -VMM_STAT(VMEXIT_UNHANDLED_EL2, "number of vmexits for an unhandled EL2 exception"); -VMM_STAT(VMEXIT_UNHANDLED, "number of vmexits for an unhandled exception"); diff --git a/sys/dev/vmm/vmm_stat.h b/sys/dev/vmm/vmm_stat.h new file mode 100644 index 000000000000..471afd0dd827 --- /dev/null +++ b/sys/dev/vmm/vmm_stat.h @@ -0,0 +1,135 @@ +/*- + * SPDX-License-Identifier: BSD-3-Clause + * + * Copyright (c) 2011 NetApp, Inc. + * All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * 1. Redistributions of source code must retain the above copyright + * notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + * notice, this list of conditions and the following disclaimer in the + * documentation and/or other materials provided with the distribution. + * 3. Neither the name of the University nor the names of its contributors + * may be used to endorse or promote products derived from this software + * without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND + * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE + * ARE DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE + * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL + * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS + * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) + * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY + * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF + * SUCH DAMAGE. + */ + +#ifndef _DEV_VMM_STAT_H_ +#define _DEV_VMM_STAT_H_ + +struct vm; + +#define MAX_VMM_STAT_ELEMS 64 /* arbitrary */ + +struct vmm_stat_type; +typedef void (*vmm_stat_func_t)(struct vcpu *vcpu, + struct vmm_stat_type *stat); +typedef bool (*vmm_stat_func_pred_t)(void); + +struct vmm_stat_type { + int index; /* position in the stats buffer */ + int nelems; /* standalone or array */ + const char *desc; /* description of statistic */ + vmm_stat_func_t func; + vmm_stat_func_pred_t pred; /* predicate to check during registration */ +}; + +void vmm_stat_register(void *arg); + +#define VMM_STAT_FDEFINE(type, _nelems, _desc, _func, _pred) \ + struct vmm_stat_type type[1] = { \ + { \ + .index = -1, \ + .nelems = _nelems, \ + .desc = _desc, \ + .func = _func, \ + .pred = _pred, \ + } \ + }; \ + SYSINIT(type##_stat, SI_SUB_KLD, SI_ORDER_ANY, vmm_stat_register, type) + +#define VMM_STAT_DEFINE(type, nelems, desc, pred) \ + VMM_STAT_FDEFINE(type, nelems, desc, NULL, pred) + +#define VMM_STAT_DECLARE(type) \ + extern struct vmm_stat_type type[1] + +#define VMM_STAT(type, desc) \ + VMM_STAT_DEFINE(type, 1, desc, NULL) + +#define VMM_STAT_FUNC(type, desc, func) \ + VMM_STAT_FDEFINE(type, 1, desc, func, NULL) + +#define VMM_STAT_ARRAY(type, nelems, desc) \ + VMM_STAT_DEFINE(type, nelems, desc, NULL) + +void *vmm_stat_alloc(void); +void vmm_stat_init(void *vp); +void vmm_stat_free(void *vp); + +int vmm_stat_copy(struct vcpu *vcpu, int index, int count, + int *num_stats, uint64_t *buf); +int vmm_stat_desc_copy(int index, char *buf, int buflen); + +static void __inline +vmm_stat_array_incr(struct vcpu *vcpu, struct vmm_stat_type *vst, int statidx, + uint64_t x) +{ +#ifdef VMM_KEEP_STATS + uint64_t *stats; + + stats = vcpu_stats(vcpu); + + if (vst->index >= 0 && statidx < vst->nelems) + stats[vst->index + statidx] += x; +#endif +} + +static void __inline +vmm_stat_array_set(struct vcpu *vcpu, struct vmm_stat_type *vst, int statidx, + uint64_t val) +{ +#ifdef VMM_KEEP_STATS + uint64_t *stats; + + stats = vcpu_stats(vcpu); + + if (vst->index >= 0 && statidx < vst->nelems) + stats[vst->index + statidx] = val; +#endif +} + +static void __inline +vmm_stat_incr(struct vcpu *vcpu, struct vmm_stat_type *vst, uint64_t x) +{ + +#ifdef VMM_KEEP_STATS + vmm_stat_array_incr(vcpu, vst, 0, x); +#endif +} + +static void __inline +vmm_stat_set(struct vcpu *vcpu, struct vmm_stat_type *vst, uint64_t val) +{ + +#ifdef VMM_KEEP_STATS + vmm_stat_array_set(vcpu, vst, 0, val); +#endif +} + +#endif /* !_DEV_VMM_STAT_H_ */ diff --git a/sys/modules/vmm/Makefile b/sys/modules/vmm/Makefile index 0604a34690e5..92986a364883 100644 --- a/sys/modules/vmm/Makefile +++ b/sys/modules/vmm/Makefile @@ -15,9 +15,10 @@ CFLAGS+= -I${SRCTOP}/sys/${MACHINE}/vmm CFLAGS+= -I${SRCTOP}/sys/${MACHINE}/vmm/io # generic vmm support -.PATH: ${SRCTOP}/sys/${MACHINE}/vmm -SRCS+= vmm.c \ - vmm_dev.c \ +.PATH: ${SRCTOP}/sys/dev/vmm ${SRCTOP}/sys/${MACHINE}/vmm + +SRCS+= vmm.c \ + vmm_dev.c \ vmm_instruction_emul.c \ vmm_stat.c From nobody Mon Aug 26 18:58:31 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Wt0Lv4zzrz5TRJW; Mon, 26 Aug 2024 18:58:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Wt0Lv3Kprz4F8f; Mon, 26 Aug 2024 18:58:31 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724698711; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=9WkwvBdUKWMclIGmUu2VEUK6adWQI13e9tczNsXMxRY=; b=DsT29+my1tnYVD0itLzggiWggQczLHEiJFQGGvs1zeYsXhN/s9snPy9BJPgQ3eWPcih0q7 wq3ybnpnYya0zrfsrg8E82nv2y6mc/VVyxSV/uNY/OyRCLF/hbhMkhtu+35t7/5c8ls8Tn HgW6524LShMD8fN2IqclJVVAlpbJa3gN5Lg7sZRLFTzFW+RvqAfUUxjxbdkuWD2Eaa+ecR OiNydbzNF2VyaYUpz62rnxI1aqxu1eh89RpGZ01MjKoldWqBCVBNrhq97aULw/77ldsC4f WVUgkRDEp9Y4XOf7BKHhpgPiB0hYzbA7t2cg+kfWpZ0rTNa40Rziojn1mubZQw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724698711; a=rsa-sha256; cv=none; b=Lrf04VPCtVkaE0BiAIdilnimORa9omyHvqjqA4bHzUOm92JVYxY/N2umxUC/zUzvGlrJI2 HFMXvyNzNj8PwwytHEC6ZEAFwjaT04PeB2nssVo1RxQHVGu7pGNeTf2ciSLHvSh4sc54nT b1KLUCxi5IRTE/6prbfbfFmFUa2IgTmJWeQ+YlJX6nnrTDPdPkYj1+HBwRTqkZp+enOshu JOiYFj9E8kJ9Hoq+CDOhsXPadzqZPF0NH6rI6TT67QHN9o3lqFcnPtsmAsP2jSv42+HaC+ uA8UYGSMH138oq0HW8r5ja4+nk/zgSDjTnujmUWoznSCV3WTjzqZWAZ7ur5tdA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724698711; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=9WkwvBdUKWMclIGmUu2VEUK6adWQI13e9tczNsXMxRY=; b=aWBe9VWLjhDL3LnKXNyJugqdccKefqloJQC9i8iExWSn9eXRz28uidQajQPkqyql84XbMC p0oEqwbTD0LyRGHn+VQArnNkY/sanyu/vmLzonQ227RrMAP7OnExztDUhDD886AUjkzanS BuldUh9r9XySQbqVuQrSPEdV4XcqeipHngf48dD5909nvLbN7MadrLosxweIedXYbbxvu1 o5RPbrJVtDrD/RK9+1xbEpZ/kSL+WWK/CWYNHR5fSV3d1QUrXyfdTHCTn3Ge8ckdZFok35 RDJttvJOuYUHHLRtlJlDwEZVoF0EjAGHnJOWqnnt7wLaPJka3mThAdz9IM8Zdw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Wt0Lv2qbCzHNF; Mon, 26 Aug 2024 18:58:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47QIwVPa027599; Mon, 26 Aug 2024 18:58:31 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47QIwVWk027596; Mon, 26 Aug 2024 18:58:31 GMT (envelope-from git) Date: Mon, 26 Aug 2024 18:58:31 GMT Message-Id: <202408261858.47QIwVWk027596@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: 3df92c972898 - main - vmm: Enable assertions in vmmdev_lookup() List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 3df92c972898be7b4b8dafacfd6708f3a39b2af5 Auto-Submitted: auto-generated The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=3df92c972898be7b4b8dafacfd6708f3a39b2af5 commit 3df92c972898be7b4b8dafacfd6708f3a39b2af5 Author: Mark Johnston AuthorDate: 2024-08-26 18:41:23 +0000 Commit: Mark Johnston CommitDate: 2024-08-26 18:41:23 +0000 vmm: Enable assertions in vmmdev_lookup() The comment has been there since the initial import of the vmm code and presumably reflected some kind of problem with standalone builds of vmm.ko. However, I don't see any problems with it, and mtx_assert() is used elsewhere within the vmm code. Reviewed by: jhb Differential Revision: https://reviews.freebsd.org/D46438 --- sys/amd64/vmm/vmm_dev.c | 2 -- sys/arm64/vmm/vmm_dev.c | 2 -- 2 files changed, 4 deletions(-) diff --git a/sys/amd64/vmm/vmm_dev.c b/sys/amd64/vmm/vmm_dev.c index 46cddce4e4b8..9acbfbb454e0 100644 --- a/sys/amd64/vmm/vmm_dev.c +++ b/sys/amd64/vmm/vmm_dev.c @@ -228,9 +228,7 @@ vmmdev_lookup(const char *name) { struct vmmdev_softc *sc; -#ifdef notyet /* XXX kernel is not compiled with invariants */ mtx_assert(&vmmdev_mtx, MA_OWNED); -#endif SLIST_FOREACH(sc, &head, link) { if (strcmp(name, vm_name(sc->vm)) == 0) diff --git a/sys/arm64/vmm/vmm_dev.c b/sys/arm64/vmm/vmm_dev.c index 946c6760f7c1..c3c6dcc87d88 100644 --- a/sys/arm64/vmm/vmm_dev.c +++ b/sys/arm64/vmm/vmm_dev.c @@ -172,9 +172,7 @@ vmmdev_lookup(const char *name) { struct vmmdev_softc *sc; -#ifdef notyet /* XXX kernel is not compiled with invariants */ mtx_assert(&vmmdev_mtx, MA_OWNED); -#endif SLIST_FOREACH(sc, &head, link) { if (strcmp(name, vm_name(sc->vm)) == 0) From nobody Mon Aug 26 18:58:32 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Wt0Lw60j9z5TR3m; Mon, 26 Aug 2024 18:58:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Wt0Lw4B3Nz4FSt; Mon, 26 Aug 2024 18:58:32 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724698712; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=mP/wJ6eKGl+ksztt1bR1B3juQdQ7mna9u0Vf6jd4174=; b=pxVSmExox86yRbeAj+QK7LKf147I3VQqW8/sdX3Pm0alP/wqz/vKPzoVm2TuxrqNOC72Wv mtky8VKo8ynYe99C6nUjjFTw4DfuNFlam+GR1VLurdUBCMq2pr3KrSLZFYtoPVFn1GIby5 may+bKLFkTU6IofKxtLgsc9OO6aj/aD4hVwv1ErA8pC+D6ewZpoYhqt+pIVt0Pw3fJ7g0u snxie1tXRaPl5RHHTr3O58wv3Yok/AaMxAA/pSbikfqVJ+K3ZJ3hsgW6TuioXkvRUlaNd4 WtelfMhEX7UuKRBOv0yG2TZv2ueMgbebJ0oLPfw+C4eHVPPvcOkl0hdYj1/sYA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724698712; a=rsa-sha256; cv=none; b=ojuh3hKK/bxzM0eGhDle7yQxrtnLyo6qUUrNDNiaElXFfkVnnIHh53GcIZrMfSwTcxcRMa XiIo+DZlW10LHVKSqHd7nbtPGGmQEQgs4t9EtF7GT9xWKaB/opHl1oXDRTlFBBJq0eidlo oAKfaJGLaNmGUHoyaorm3t+plESc6ZizhiWvMT2i4mwy6SSGsXiqhUFlx0WGXHESPrAu8p eogMbR0/IOsqRtvkJhMGA3D7XxuiEWkkwjrZglTpxlaU9tN2c8upL1cKciWmZXpeyudyxY llMvCYXW9SZhY9ct9pDnqCe8HqahRNgUaiHMb2BmWYIGGCniBMSfQ0qP37pkjQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724698712; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=mP/wJ6eKGl+ksztt1bR1B3juQdQ7mna9u0Vf6jd4174=; b=q+DB4oSNalSTGxSdl0gA24hiCe1C94Fwc3pDj+v9nWU4/ONG+yplKyIQQyhfcTHwXneXuc +Ca8ziDivuHtiUItLe7o2IV/Uk+CWa9GEzdiAMLq4d2ucAzQlSDtMsRS3o1zLNLl/SpUrj br6/NvT094NQsCH/S9Zrz2lZyhNent4bj0TmACxLD8n97olVx9eOQfG42jayWdHvhY3PKD eMevCR5W2/d7Kgxig/nykJFiUQehFrSE9f9SC8BRLfuMEQXu9ch8PzcnoEo8ZTQhBYHIof a9mlmWKmbA+ld1f0ChxofdmVC9aM5BKL5SWRnK+Z1qOI3nh3cE1Lgws26TQM+w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Wt0Lw3l4gzJ4T; Mon, 26 Aug 2024 18:58:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47QIwWd7027650; Mon, 26 Aug 2024 18:58:32 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47QIwWqA027647; Mon, 26 Aug 2024 18:58:32 GMT (envelope-from git) Date: Mon, 26 Aug 2024 18:58:32 GMT Message-Id: <202408261858.47QIwWqA027647@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: 908a9dc02007 - main - arm64: Add a missing vm_disable_vcpu_creation() call in vmmdev_destroy() List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 908a9dc020071947fe727ef11a35e78bf76a6b81 Auto-Submitted: auto-generated The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=908a9dc020071947fe727ef11a35e78bf76a6b81 commit 908a9dc020071947fe727ef11a35e78bf76a6b81 Author: Mark Johnston AuthorDate: 2024-08-26 18:41:34 +0000 Commit: Mark Johnston CommitDate: 2024-08-26 18:41:34 +0000 arm64: Add a missing vm_disable_vcpu_creation() call in vmmdev_destroy() This brings arm64 in sync with amd64, which had diverged a bit after the arm64 code was forked. Reviewed by: jhb Differential Revision: https://reviews.freebsd.org/D46439 --- sys/arm64/vmm/vmm_dev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/arm64/vmm/vmm_dev.c b/sys/arm64/vmm/vmm_dev.c index c3c6dcc87d88..28877739e2ce 100644 --- a/sys/arm64/vmm/vmm_dev.c +++ b/sys/arm64/vmm/vmm_dev.c @@ -767,6 +767,7 @@ vmmdev_destroy(void *arg) struct devmem_softc *dsc; int error __diagused; + vm_disable_vcpu_creation(sc->vm); error = vcpu_lock_all(sc); KASSERT(error == 0, ("%s: error %d freezing vcpus", __func__, error)); vm_unlock_vcpus(sc->vm); From nobody Mon Aug 26 18:58:33 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Wt0Lx6hz2z5TR7m; Mon, 26 Aug 2024 18:58:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Wt0Lx4nN2z4FWH; Mon, 26 Aug 2024 18:58:33 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724698713; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=uXseGtT7NZvzH2k8cOvs4exsNDs316GpQq4+PdCAcTA=; b=MbH2d5D8xyVtjq1uqKIrmy0TgfxeGzy+mjRx4lgzCOfH0NuHJHfhlIG4IAHzwE2V41vsVR J0QLL6I+mz8rwwTWj7NVmLDiYp6/2PAQKbWj52VoxZOuI5ahl0ip15YxXYH7zqjvHOh8Eq DpOZ6VZ87ZhTfT5ofgc4WftVAsMo1zNRJ646GVJMgz1F6ueB3at74z3gwEfYAAUHmNlWB2 /VpjHCJ/twdP2nq1daC3KGEAGL2D0sUarevsgiA6mPgzgn9sJBYhmjEC3vM89um0zdZWBo 5CYiloE7eblsPNQHZUXMfFEE1aCZnWYIxXWLp8yFfd6hBJpWkE5ArTf+4akFug== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724698713; a=rsa-sha256; cv=none; b=dgoWnpLqLvWUdhWCz97xrlpmU48VbsuOfwFBbKcRYldzNbQCA+sVbOykIFIGRwzHVpHvW4 8HHctbT/utAIK8ugUG8hxm+0L1o9V88MFa2YmU2dzSz+sBEDor4hindI6BG3sLKqqX9wCL ETnBZMeVhqZr9GLX0ITVfbnZ4uMhicaQEsC1MBJSwYGhH+eb7ZElcR6NmCBfh4jkMWZGPZ y+AWZFKyE0a9b+GrORK1oyDV4P3oKCXFNEvTt+Ini/f2mXM6XutCzGtnFyWSOIBvCbUQYM LlGXdxMQgThPm8g+Uwd+db0hslLlL/d7coqSEFKZRiIci8mFghcSHVLmQn4EFA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724698713; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=uXseGtT7NZvzH2k8cOvs4exsNDs316GpQq4+PdCAcTA=; b=Pjp1F9KO8A3Qowgo/yunJlWACxCrwM9DP1EEatDpIxkQjFXyROXGsZpP7I65HC4+xki2FI XmsC3WNmFWLgwrLyxWXGNakUe4wbaKki03s1TIwNqyZIpGjusAMz9Emw/ImHeGTtCYJqB7 i3VEKKBrWAc+EwPS/gDmUvev+fZPeoVymzVZ9oGEVQSh7F+mRv89g4lwNqEZwWh7QjEtcU YvxGv+64fV1CkW2LYL6B3AcTNz8P2oEepfNgxYQhdVDeWYtXiYCpcjp0ukpba/5+Cvh7hW NALvTG1nic4FLxeAkvnL8qgXAnlIHms7wbiBEAU5LZN3oOPnE0bN0tDHWJniSw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Wt0Lx4Lf3zJZ6; Mon, 26 Aug 2024 18:58:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47QIwXeq027693; Mon, 26 Aug 2024 18:58:33 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47QIwX6l027690; Mon, 26 Aug 2024 18:58:33 GMT (envelope-from git) Date: Mon, 26 Aug 2024 18:58:33 GMT Message-Id: <202408261858.47QIwX6l027690@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: b9ef152bec6c - main - vmm: Merge vmm_dev.c List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: b9ef152bec6cff4cd82b68921f631bd6efb24ae6 Auto-Submitted: auto-generated The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=b9ef152bec6cff4cd82b68921f631bd6efb24ae6 commit b9ef152bec6cff4cd82b68921f631bd6efb24ae6 Author: Mark Johnston AuthorDate: 2024-08-26 18:41:39 +0000 Commit: Mark Johnston CommitDate: 2024-08-26 18:41:39 +0000 vmm: Merge vmm_dev.c This file contains the vmm device file implementation. Most of this code is not machine-dependent and so shouldn't be duplicated this way. Move most of it into a generic dev/vmm/vmm_dev.c. This will make it easier to introduce a cdev-based interface for VM creation, which in turn makes it possible to implement support for running bhyve as an unprivileged user. Machine-dependent ioctls continue to be handled in machine-dependent code. To make the split a bit easier to handle, introduce a pair of tables which define MI and MD ioctls. Each table entry can set flags which determine which locks need to be held in order to execute the handler. vmmdev_ioctl() now looks up the ioctl in one of the tables, acquires locks and either handles the ioctl directly or calls vmmdev_machdep_ioctl() to handle it. No functional change intended. There is a lot of churn in this change but the underlying logic in the ioctl handlers is the same. For now, vmm_dev.h is still mostly separate, even though some parts could be merged in principle. This would involve changing include paths for userspace, though. Reviewed by: corvink, jhb Differential Revision: https://reviews.freebsd.org/D46431 --- sys/amd64/include/vmm_dev.h | 5 - sys/amd64/vmm/vmm.c | 2 +- sys/amd64/vmm/vmm_dev.c | 1452 -------------------------------------- sys/amd64/vmm/vmm_dev_machdep.c | 526 ++++++++++++++ sys/arm64/include/vmm_dev.h | 5 - sys/arm64/vmm/vmm.c | 2 +- sys/arm64/vmm/vmm_dev_machdep.c | 137 ++++ sys/conf/files.arm64 | 1 + sys/{arm64 => dev}/vmm/vmm_dev.c | 443 ++++++------ sys/dev/vmm/vmm_dev.h | 57 ++ sys/modules/vmm/Makefile | 1 + 11 files changed, 924 insertions(+), 1707 deletions(-) diff --git a/sys/amd64/include/vmm_dev.h b/sys/amd64/include/vmm_dev.h index aa265315f15e..a007ce5515a5 100644 --- a/sys/amd64/include/vmm_dev.h +++ b/sys/amd64/include/vmm_dev.h @@ -31,11 +31,6 @@ struct vm_snapshot_meta; -#ifdef _KERNEL -void vmmdev_init(void); -int vmmdev_cleanup(void); -#endif - struct vm_memmap { vm_paddr_t gpa; int segid; /* memory segment */ diff --git a/sys/amd64/vmm/vmm.c b/sys/amd64/vmm/vmm.c index d0259b3b125f..20006e63cfeb 100644 --- a/sys/amd64/vmm/vmm.c +++ b/sys/amd64/vmm/vmm.c @@ -67,10 +67,10 @@ #include #include -#include #include #include +#include #include #include "vmm_ioport.h" diff --git a/sys/amd64/vmm/vmm_dev.c b/sys/amd64/vmm/vmm_dev.c deleted file mode 100644 index 9acbfbb454e0..000000000000 --- a/sys/amd64/vmm/vmm_dev.c +++ /dev/null @@ -1,1452 +0,0 @@ -/*- - * SPDX-License-Identifier: BSD-2-Clause - * - * Copyright (c) 2011 NetApp, Inc. - * All rights reserved. - * - * Redistribution and use in source and binary forms, with or without - * modification, are permitted provided that the following conditions - * are met: - * 1. Redistributions of source code must retain the above copyright - * notice, this list of conditions and the following disclaimer. - * 2. Redistributions in binary form must reproduce the above copyright - * notice, this list of conditions and the following disclaimer in the - * documentation and/or other materials provided with the distribution. - * - * THIS SOFTWARE IS PROVIDED BY NETAPP, INC ``AS IS'' AND - * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE - * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE - * ARE DISCLAIMED. IN NO EVENT SHALL NETAPP, INC OR CONTRIBUTORS BE LIABLE - * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL - * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS - * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) - * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT - * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY - * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF - * SUCH DAMAGE. - */ - -#include "opt_bhyve_snapshot.h" - -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include -#include - -#include -#include -#include -#include - -#include -#include -#include -#include -#include -#include - -#include "vmm_lapic.h" -#include "vmm_stat.h" -#include "vmm_mem.h" -#include "io/ppt.h" -#include "io/vatpic.h" -#include "io/vioapic.h" -#include "io/vhpet.h" -#include "io/vrtc.h" - -#ifdef COMPAT_FREEBSD13 -struct vm_stats_old { - int cpuid; /* in */ - int num_entries; /* out */ - struct timeval tv; - uint64_t statbuf[MAX_VM_STATS]; -}; - -#define VM_STATS_OLD \ - _IOWR('v', IOCNUM_VM_STATS, struct vm_stats_old) - -struct vm_snapshot_meta_old { - void *ctx; /* unused */ - void *dev_data; - const char *dev_name; /* identify userspace devices */ - enum snapshot_req dev_req; /* identify kernel structs */ - - struct vm_snapshot_buffer buffer; - - enum vm_snapshot_op op; -}; - -#define VM_SNAPSHOT_REQ_OLD \ - _IOWR('v', IOCNUM_SNAPSHOT_REQ, struct vm_snapshot_meta_old) - -struct vm_exit_ipi_13 { - uint32_t mode; - uint8_t vector; - __BITSET_DEFINE(, 256) dmask; -}; - -struct vm_exit_13 { - uint32_t exitcode; - int32_t inst_length; - uint64_t rip; - uint64_t u[120 / sizeof(uint64_t)]; -}; - -struct vm_run_13 { - int cpuid; - struct vm_exit_13 vm_exit; -}; - -#define VM_RUN_13 \ - _IOWR('v', IOCNUM_RUN, struct vm_run_13) - -#endif /* COMPAT_FREEBSD13 */ - -struct devmem_softc { - int segid; - char *name; - struct cdev *cdev; - struct vmmdev_softc *sc; - SLIST_ENTRY(devmem_softc) link; -}; - -struct vmmdev_softc { - struct vm *vm; /* vm instance cookie */ - struct cdev *cdev; - struct ucred *ucred; - SLIST_ENTRY(vmmdev_softc) link; - SLIST_HEAD(, devmem_softc) devmem; - int flags; -}; -#define VSC_LINKED 0x01 - -static SLIST_HEAD(, vmmdev_softc) head; - -static unsigned pr_allow_flag; -static struct mtx vmmdev_mtx; -MTX_SYSINIT(vmmdev_mtx, &vmmdev_mtx, "vmm device mutex", MTX_DEF); - -static MALLOC_DEFINE(M_VMMDEV, "vmmdev", "vmmdev"); - -SYSCTL_DECL(_hw_vmm); - -static int vmm_priv_check(struct ucred *ucred); -static int devmem_create_cdev(const char *vmname, int id, char *devmem); -static void devmem_destroy(void *arg); - -static int -vmm_priv_check(struct ucred *ucred) -{ - - if (jailed(ucred) && - !(ucred->cr_prison->pr_allow & pr_allow_flag)) - return (EPERM); - - return (0); -} - -static int -vcpu_lock_one(struct vcpu *vcpu) -{ - return (vcpu_set_state(vcpu, VCPU_FROZEN, true)); -} - -static void -vcpu_unlock_one(struct vcpu *vcpu) -{ - enum vcpu_state state; - - state = vcpu_get_state(vcpu, NULL); - if (state != VCPU_FROZEN) { - panic("vcpu %s(%d) has invalid state %d", - vm_name(vcpu_vm(vcpu)), vcpu_vcpuid(vcpu), state); - } - - vcpu_set_state(vcpu, VCPU_IDLE, false); -} - -static int -vcpu_lock_all(struct vmmdev_softc *sc) -{ - struct vcpu *vcpu; - int error; - uint16_t i, j, maxcpus; - - error = 0; - vm_slock_vcpus(sc->vm); - maxcpus = vm_get_maxcpus(sc->vm); - for (i = 0; i < maxcpus; i++) { - vcpu = vm_vcpu(sc->vm, i); - if (vcpu == NULL) - continue; - error = vcpu_lock_one(vcpu); - if (error) - break; - } - - if (error) { - for (j = 0; j < i; j++) { - vcpu = vm_vcpu(sc->vm, j); - if (vcpu == NULL) - continue; - vcpu_unlock_one(vcpu); - } - vm_unlock_vcpus(sc->vm); - } - - return (error); -} - -static void -vcpu_unlock_all(struct vmmdev_softc *sc) -{ - struct vcpu *vcpu; - uint16_t i, maxcpus; - - maxcpus = vm_get_maxcpus(sc->vm); - for (i = 0; i < maxcpus; i++) { - vcpu = vm_vcpu(sc->vm, i); - if (vcpu == NULL) - continue; - vcpu_unlock_one(vcpu); - } - vm_unlock_vcpus(sc->vm); -} - -static struct vmmdev_softc * -vmmdev_lookup(const char *name) -{ - struct vmmdev_softc *sc; - - mtx_assert(&vmmdev_mtx, MA_OWNED); - - SLIST_FOREACH(sc, &head, link) { - if (strcmp(name, vm_name(sc->vm)) == 0) - break; - } - - if (sc == NULL) - return (NULL); - - if (cr_cansee(curthread->td_ucred, sc->ucred)) - return (NULL); - - return (sc); -} - -static struct vmmdev_softc * -vmmdev_lookup2(struct cdev *cdev) -{ - - return (cdev->si_drv1); -} - -static int -vmmdev_rw(struct cdev *cdev, struct uio *uio, int flags) -{ - int error, off, c, prot; - vm_paddr_t gpa, maxaddr; - void *hpa, *cookie; - struct vmmdev_softc *sc; - - error = vmm_priv_check(curthread->td_ucred); - if (error) - return (error); - - sc = vmmdev_lookup2(cdev); - if (sc == NULL) - return (ENXIO); - - /* - * Get a read lock on the guest memory map. - */ - vm_slock_memsegs(sc->vm); - - prot = (uio->uio_rw == UIO_WRITE ? VM_PROT_WRITE : VM_PROT_READ); - maxaddr = vmm_sysmem_maxaddr(sc->vm); - while (uio->uio_resid > 0 && error == 0) { - gpa = uio->uio_offset; - off = gpa & PAGE_MASK; - c = min(uio->uio_resid, PAGE_SIZE - off); - - /* - * The VM has a hole in its physical memory map. If we want to - * use 'dd' to inspect memory beyond the hole we need to - * provide bogus data for memory that lies in the hole. - * - * Since this device does not support lseek(2), dd(1) will - * read(2) blocks of data to simulate the lseek(2). - */ - hpa = vm_gpa_hold_global(sc->vm, gpa, c, prot, &cookie); - if (hpa == NULL) { - if (uio->uio_rw == UIO_READ && gpa < maxaddr) - error = uiomove(__DECONST(void *, zero_region), - c, uio); - else - error = EFAULT; - } else { - error = uiomove(hpa, c, uio); - vm_gpa_release(cookie); - } - } - vm_unlock_memsegs(sc->vm); - return (error); -} - -CTASSERT(sizeof(((struct vm_memseg *)0)->name) >= VM_MAX_SUFFIXLEN + 1); - -static int -get_memseg(struct vmmdev_softc *sc, struct vm_memseg *mseg, size_t len) -{ - struct devmem_softc *dsc; - int error; - bool sysmem; - - error = vm_get_memseg(sc->vm, mseg->segid, &mseg->len, &sysmem, NULL); - if (error || mseg->len == 0) - return (error); - - if (!sysmem) { - SLIST_FOREACH(dsc, &sc->devmem, link) { - if (dsc->segid == mseg->segid) - break; - } - KASSERT(dsc != NULL, ("%s: devmem segment %d not found", - __func__, mseg->segid)); - error = copystr(dsc->name, mseg->name, len, NULL); - } else { - bzero(mseg->name, len); - } - - return (error); -} - -static int -alloc_memseg(struct vmmdev_softc *sc, struct vm_memseg *mseg, size_t len) -{ - char *name; - int error; - bool sysmem; - - error = 0; - name = NULL; - sysmem = true; - - /* - * The allocation is lengthened by 1 to hold a terminating NUL. It'll - * by stripped off when devfs processes the full string. - */ - if (VM_MEMSEG_NAME(mseg)) { - sysmem = false; - name = malloc(len, M_VMMDEV, M_WAITOK); - error = copystr(mseg->name, name, len, NULL); - if (error) - goto done; - } - - error = vm_alloc_memseg(sc->vm, mseg->segid, mseg->len, sysmem); - if (error) - goto done; - - if (VM_MEMSEG_NAME(mseg)) { - error = devmem_create_cdev(vm_name(sc->vm), mseg->segid, name); - if (error) - vm_free_memseg(sc->vm, mseg->segid); - else - name = NULL; /* freed when 'cdev' is destroyed */ - } -done: - free(name, M_VMMDEV); - return (error); -} - -static int -vm_get_register_set(struct vcpu *vcpu, unsigned int count, int *regnum, - uint64_t *regval) -{ - int error, i; - - error = 0; - for (i = 0; i < count; i++) { - error = vm_get_register(vcpu, regnum[i], ®val[i]); - if (error) - break; - } - return (error); -} - -static int -vm_set_register_set(struct vcpu *vcpu, unsigned int count, int *regnum, - uint64_t *regval) -{ - int error, i; - - error = 0; - for (i = 0; i < count; i++) { - error = vm_set_register(vcpu, regnum[i], regval[i]); - if (error) - break; - } - return (error); -} - -static int -vmmdev_ioctl(struct cdev *cdev, u_long cmd, caddr_t data, int fflag, - struct thread *td) -{ - int error, vcpuid, size; - cpuset_t *cpuset; - struct vmmdev_softc *sc; - struct vcpu *vcpu; - struct vm_register *vmreg; - struct vm_seg_desc *vmsegdesc; - struct vm_register_set *vmregset; - struct vm_run *vmrun; -#ifdef COMPAT_FREEBSD13 - struct vm_run_13 *vmrun_13; -#endif - struct vm_exception *vmexc; - struct vm_lapic_irq *vmirq; - struct vm_lapic_msi *vmmsi; - struct vm_ioapic_irq *ioapic_irq; - struct vm_isa_irq *isa_irq; - struct vm_isa_irq_trigger *isa_irq_trigger; - struct vm_capability *vmcap; - struct vm_pptdev *pptdev; - struct vm_pptdev_mmio *pptmmio; - struct vm_pptdev_msi *pptmsi; - struct vm_pptdev_msix *pptmsix; -#ifdef COMPAT_FREEBSD13 - struct vm_stats_old *vmstats_old; -#endif - struct vm_stats *vmstats; - struct vm_stat_desc *statdesc; - struct vm_x2apic *x2apic; - struct vm_gpa_pte *gpapte; - struct vm_suspend *vmsuspend; - struct vm_gla2gpa *gg; - struct vm_cpuset *vm_cpuset; - struct vm_intinfo *vmii; - struct vm_rtc_time *rtctime; - struct vm_rtc_data *rtcdata; - struct vm_memmap *mm; - struct vm_munmap *mu; - struct vm_cpu_topology *topology; - struct vm_readwrite_kernemu_device *kernemu; - uint64_t *regvals; - int *regnums; - enum { NONE, SINGLE, ALL } vcpus_locked; - bool memsegs_locked; -#ifdef BHYVE_SNAPSHOT - struct vm_snapshot_meta *snapshot_meta; -#ifdef COMPAT_FREEBSD13 - struct vm_snapshot_meta_old *snapshot_old; -#endif -#endif - - error = vmm_priv_check(curthread->td_ucred); - if (error) - return (error); - - sc = vmmdev_lookup2(cdev); - if (sc == NULL) - return (ENXIO); - - vcpuid = -1; - vcpu = NULL; - vcpus_locked = NONE; - memsegs_locked = false; - - /* - * For VMM ioctls that operate on a single vCPU, lookup the - * vcpu. For VMM ioctls which require one or more vCPUs to - * not be running, lock necessary vCPUs. - * - * XXX fragile, handle with care - * Most of these assume that the first field of the ioctl data - * is the vcpuid. - */ - switch (cmd) { - case VM_RUN: -#ifdef COMPAT_FREEBSD13 - case VM_RUN_13: -#endif - case VM_GET_REGISTER: - case VM_SET_REGISTER: - case VM_GET_SEGMENT_DESCRIPTOR: - case VM_SET_SEGMENT_DESCRIPTOR: - case VM_GET_REGISTER_SET: - case VM_SET_REGISTER_SET: - case VM_INJECT_EXCEPTION: - case VM_GET_CAPABILITY: - case VM_SET_CAPABILITY: - case VM_SET_X2APIC_STATE: - case VM_GLA2GPA: - case VM_GLA2GPA_NOFAULT: - case VM_ACTIVATE_CPU: - case VM_SET_INTINFO: - case VM_GET_INTINFO: - case VM_RESTART_INSTRUCTION: - case VM_GET_KERNEMU_DEV: - case VM_SET_KERNEMU_DEV: - /* - * ioctls that can operate only on vcpus that are not running. - */ - vcpuid = *(int *)data; - vcpu = vm_alloc_vcpu(sc->vm, vcpuid); - if (vcpu == NULL) { - error = EINVAL; - goto done; - } - error = vcpu_lock_one(vcpu); - if (error) - goto done; - vcpus_locked = SINGLE; - break; - -#ifdef COMPAT_FREEBSD12 - case VM_ALLOC_MEMSEG_FBSD12: -#endif - case VM_ALLOC_MEMSEG: - case VM_BIND_PPTDEV: - case VM_UNBIND_PPTDEV: - case VM_MMAP_MEMSEG: - case VM_MUNMAP_MEMSEG: - case VM_REINIT: - /* - * ioctls that modify the memory map must lock memory - * segments exclusively. - */ - vm_xlock_memsegs(sc->vm); - memsegs_locked = true; - /* FALLTHROUGH */ - case VM_MAP_PPTDEV_MMIO: - case VM_UNMAP_PPTDEV_MMIO: -#ifdef BHYVE_SNAPSHOT - case VM_SNAPSHOT_REQ: -#ifdef COMPAT_FREEBSD13 - case VM_SNAPSHOT_REQ_OLD: -#endif - case VM_RESTORE_TIME: -#endif - /* - * ioctls that operate on the entire virtual machine must - * prevent all vcpus from running. - */ - error = vcpu_lock_all(sc); - if (error) - goto done; - vcpus_locked = ALL; - break; - -#ifdef COMPAT_FREEBSD12 - case VM_GET_MEMSEG_FBSD12: -#endif - case VM_GET_MEMSEG: - case VM_MMAP_GETNEXT: - /* - * Lock the memory map while it is being inspected. - */ - vm_slock_memsegs(sc->vm); - memsegs_locked = true; - break; - -#ifdef COMPAT_FREEBSD13 - case VM_STATS_OLD: -#endif - case VM_STATS: - case VM_INJECT_NMI: - case VM_LAPIC_IRQ: - case VM_GET_X2APIC_STATE: - /* - * These do not need the vCPU locked but do operate on - * a specific vCPU. - */ - vcpuid = *(int *)data; - vcpu = vm_alloc_vcpu(sc->vm, vcpuid); - if (vcpu == NULL) { - error = EINVAL; - goto done; - } - break; - - case VM_LAPIC_LOCAL_IRQ: - case VM_SUSPEND_CPU: - case VM_RESUME_CPU: - /* - * These can either operate on all CPUs via a vcpuid of - * -1 or on a specific vCPU. - */ - vcpuid = *(int *)data; - if (vcpuid == -1) - break; - vcpu = vm_alloc_vcpu(sc->vm, vcpuid); - if (vcpu == NULL) { - error = EINVAL; - goto done; - } - break; - - default: - break; - } - - switch (cmd) { - case VM_RUN: { - struct vm_exit *vme; - - vmrun = (struct vm_run *)data; - vme = vm_exitinfo(vcpu); - - error = vm_run(vcpu); - if (error != 0) - break; - - error = copyout(vme, vmrun->vm_exit, sizeof(*vme)); - if (error != 0) - break; - if (vme->exitcode == VM_EXITCODE_IPI) { - error = copyout(vm_exitinfo_cpuset(vcpu), - vmrun->cpuset, - min(vmrun->cpusetsize, sizeof(cpuset_t))); - if (error != 0) - break; - if (sizeof(cpuset_t) < vmrun->cpusetsize) { - uint8_t *p; - - p = (uint8_t *)vmrun->cpuset + - sizeof(cpuset_t); - while (p < (uint8_t *)vmrun->cpuset + - vmrun->cpusetsize) { - if (subyte(p++, 0) != 0) { - error = EFAULT; - break; - } - } - } - } - break; - } -#ifdef COMPAT_FREEBSD13 - case VM_RUN_13: { - struct vm_exit *vme; - struct vm_exit_13 *vme_13; - - vmrun_13 = (struct vm_run_13 *)data; - vme_13 = &vmrun_13->vm_exit; - vme = vm_exitinfo(vcpu); - - error = vm_run(vcpu); - if (error == 0) { - vme_13->exitcode = vme->exitcode; - vme_13->inst_length = vme->inst_length; - vme_13->rip = vme->rip; - memcpy(vme_13->u, &vme->u, sizeof(vme_13->u)); - if (vme->exitcode == VM_EXITCODE_IPI) { - struct vm_exit_ipi_13 *ipi; - cpuset_t *dmask; - int cpu; - - dmask = vm_exitinfo_cpuset(vcpu); - ipi = (struct vm_exit_ipi_13 *)&vme_13->u[0]; - BIT_ZERO(256, &ipi->dmask); - CPU_FOREACH_ISSET(cpu, dmask) { - if (cpu >= 256) - break; - BIT_SET(256, cpu, &ipi->dmask); - } - } - } - break; - } -#endif - case VM_SUSPEND: - vmsuspend = (struct vm_suspend *)data; - error = vm_suspend(sc->vm, vmsuspend->how); - break; - case VM_REINIT: - error = vm_reinit(sc->vm); - break; - case VM_STAT_DESC: { - statdesc = (struct vm_stat_desc *)data; - error = vmm_stat_desc_copy(statdesc->index, - statdesc->desc, sizeof(statdesc->desc)); - break; - } -#ifdef COMPAT_FREEBSD13 - case VM_STATS_OLD: - vmstats_old = (struct vm_stats_old *)data; - getmicrotime(&vmstats_old->tv); - error = vmm_stat_copy(vcpu, 0, - nitems(vmstats_old->statbuf), - &vmstats_old->num_entries, - vmstats_old->statbuf); - break; -#endif - case VM_STATS: { - vmstats = (struct vm_stats *)data; - getmicrotime(&vmstats->tv); - error = vmm_stat_copy(vcpu, vmstats->index, - nitems(vmstats->statbuf), - &vmstats->num_entries, vmstats->statbuf); - break; - } - case VM_PPTDEV_MSI: - pptmsi = (struct vm_pptdev_msi *)data; - error = ppt_setup_msi(sc->vm, - pptmsi->bus, pptmsi->slot, pptmsi->func, - pptmsi->addr, pptmsi->msg, - pptmsi->numvec); - break; - case VM_PPTDEV_MSIX: - pptmsix = (struct vm_pptdev_msix *)data; - error = ppt_setup_msix(sc->vm, - pptmsix->bus, pptmsix->slot, - pptmsix->func, pptmsix->idx, - pptmsix->addr, pptmsix->msg, - pptmsix->vector_control); - break; - case VM_PPTDEV_DISABLE_MSIX: - pptdev = (struct vm_pptdev *)data; - error = ppt_disable_msix(sc->vm, pptdev->bus, pptdev->slot, - pptdev->func); - break; - case VM_MAP_PPTDEV_MMIO: - pptmmio = (struct vm_pptdev_mmio *)data; - error = ppt_map_mmio(sc->vm, pptmmio->bus, pptmmio->slot, - pptmmio->func, pptmmio->gpa, pptmmio->len, - pptmmio->hpa); - break; - case VM_UNMAP_PPTDEV_MMIO: - pptmmio = (struct vm_pptdev_mmio *)data; - error = ppt_unmap_mmio(sc->vm, pptmmio->bus, pptmmio->slot, - pptmmio->func, pptmmio->gpa, pptmmio->len); - break; - case VM_BIND_PPTDEV: - pptdev = (struct vm_pptdev *)data; - error = vm_assign_pptdev(sc->vm, pptdev->bus, pptdev->slot, - pptdev->func); - break; - case VM_UNBIND_PPTDEV: - pptdev = (struct vm_pptdev *)data; - error = vm_unassign_pptdev(sc->vm, pptdev->bus, pptdev->slot, - pptdev->func); - break; - case VM_INJECT_EXCEPTION: - vmexc = (struct vm_exception *)data; - error = vm_inject_exception(vcpu, - vmexc->vector, vmexc->error_code_valid, vmexc->error_code, - vmexc->restart_instruction); - break; - case VM_INJECT_NMI: - error = vm_inject_nmi(vcpu); - break; - case VM_LAPIC_IRQ: - vmirq = (struct vm_lapic_irq *)data; - error = lapic_intr_edge(vcpu, vmirq->vector); - break; - case VM_LAPIC_LOCAL_IRQ: - vmirq = (struct vm_lapic_irq *)data; - error = lapic_set_local_intr(sc->vm, vcpu, vmirq->vector); - break; - case VM_LAPIC_MSI: - vmmsi = (struct vm_lapic_msi *)data; - error = lapic_intr_msi(sc->vm, vmmsi->addr, vmmsi->msg); - break; - case VM_IOAPIC_ASSERT_IRQ: - ioapic_irq = (struct vm_ioapic_irq *)data; - error = vioapic_assert_irq(sc->vm, ioapic_irq->irq); - break; - case VM_IOAPIC_DEASSERT_IRQ: - ioapic_irq = (struct vm_ioapic_irq *)data; - error = vioapic_deassert_irq(sc->vm, ioapic_irq->irq); - break; - case VM_IOAPIC_PULSE_IRQ: - ioapic_irq = (struct vm_ioapic_irq *)data; - error = vioapic_pulse_irq(sc->vm, ioapic_irq->irq); - break; - case VM_IOAPIC_PINCOUNT: - *(int *)data = vioapic_pincount(sc->vm); - break; - case VM_SET_KERNEMU_DEV: - case VM_GET_KERNEMU_DEV: { - mem_region_write_t mwrite; - mem_region_read_t mread; - bool arg; - - kernemu = (void *)data; - - if (kernemu->access_width > 0) - size = (1u << kernemu->access_width); - else - size = 1; - - if (kernemu->gpa >= DEFAULT_APIC_BASE && kernemu->gpa < DEFAULT_APIC_BASE + PAGE_SIZE) { - mread = lapic_mmio_read; - mwrite = lapic_mmio_write; - } else if (kernemu->gpa >= VIOAPIC_BASE && kernemu->gpa < VIOAPIC_BASE + VIOAPIC_SIZE) { - mread = vioapic_mmio_read; - mwrite = vioapic_mmio_write; - } else if (kernemu->gpa >= VHPET_BASE && kernemu->gpa < VHPET_BASE + VHPET_SIZE) { - mread = vhpet_mmio_read; - mwrite = vhpet_mmio_write; - } else { - error = EINVAL; - break; - } - - if (cmd == VM_SET_KERNEMU_DEV) - error = mwrite(vcpu, kernemu->gpa, - kernemu->value, size, &arg); - else - error = mread(vcpu, kernemu->gpa, - &kernemu->value, size, &arg); - break; - } - case VM_ISA_ASSERT_IRQ: - isa_irq = (struct vm_isa_irq *)data; - error = vatpic_assert_irq(sc->vm, isa_irq->atpic_irq); - if (error == 0 && isa_irq->ioapic_irq != -1) - error = vioapic_assert_irq(sc->vm, - isa_irq->ioapic_irq); - break; - case VM_ISA_DEASSERT_IRQ: - isa_irq = (struct vm_isa_irq *)data; - error = vatpic_deassert_irq(sc->vm, isa_irq->atpic_irq); - if (error == 0 && isa_irq->ioapic_irq != -1) - error = vioapic_deassert_irq(sc->vm, - isa_irq->ioapic_irq); - break; - case VM_ISA_PULSE_IRQ: - isa_irq = (struct vm_isa_irq *)data; - error = vatpic_pulse_irq(sc->vm, isa_irq->atpic_irq); - if (error == 0 && isa_irq->ioapic_irq != -1) - error = vioapic_pulse_irq(sc->vm, isa_irq->ioapic_irq); - break; - case VM_ISA_SET_IRQ_TRIGGER: - isa_irq_trigger = (struct vm_isa_irq_trigger *)data; - error = vatpic_set_irq_trigger(sc->vm, - isa_irq_trigger->atpic_irq, isa_irq_trigger->trigger); - break; - case VM_MMAP_GETNEXT: - mm = (struct vm_memmap *)data; - error = vm_mmap_getnext(sc->vm, &mm->gpa, &mm->segid, - &mm->segoff, &mm->len, &mm->prot, &mm->flags); - break; - case VM_MMAP_MEMSEG: - mm = (struct vm_memmap *)data; - error = vm_mmap_memseg(sc->vm, mm->gpa, mm->segid, mm->segoff, - mm->len, mm->prot, mm->flags); - break; - case VM_MUNMAP_MEMSEG: - mu = (struct vm_munmap *)data; - error = vm_munmap_memseg(sc->vm, mu->gpa, mu->len); - break; -#ifdef COMPAT_FREEBSD12 - case VM_ALLOC_MEMSEG_FBSD12: - error = alloc_memseg(sc, (struct vm_memseg *)data, - sizeof(((struct vm_memseg_fbsd12 *)0)->name)); - break; -#endif - case VM_ALLOC_MEMSEG: - error = alloc_memseg(sc, (struct vm_memseg *)data, - sizeof(((struct vm_memseg *)0)->name)); - break; -#ifdef COMPAT_FREEBSD12 - case VM_GET_MEMSEG_FBSD12: - error = get_memseg(sc, (struct vm_memseg *)data, - sizeof(((struct vm_memseg_fbsd12 *)0)->name)); - break; -#endif - case VM_GET_MEMSEG: - error = get_memseg(sc, (struct vm_memseg *)data, - sizeof(((struct vm_memseg *)0)->name)); - break; - case VM_GET_REGISTER: - vmreg = (struct vm_register *)data; - error = vm_get_register(vcpu, vmreg->regnum, &vmreg->regval); - break; - case VM_SET_REGISTER: - vmreg = (struct vm_register *)data; - error = vm_set_register(vcpu, vmreg->regnum, vmreg->regval); - break; - case VM_SET_SEGMENT_DESCRIPTOR: - vmsegdesc = (struct vm_seg_desc *)data; - error = vm_set_seg_desc(vcpu, - vmsegdesc->regnum, - &vmsegdesc->desc); - break; - case VM_GET_SEGMENT_DESCRIPTOR: - vmsegdesc = (struct vm_seg_desc *)data; - error = vm_get_seg_desc(vcpu, - vmsegdesc->regnum, - &vmsegdesc->desc); - break; - case VM_GET_REGISTER_SET: - vmregset = (struct vm_register_set *)data; - if (vmregset->count > VM_REG_LAST) { - error = EINVAL; - break; - } *** 1979 LINES SKIPPED *** From nobody Mon Aug 26 18:58:34 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Wt0Lz0kZ9z5TR9X; Mon, 26 Aug 2024 18:58:35 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Wt0Ly5jTwz4FfY; Mon, 26 Aug 2024 18:58:34 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724698714; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=dsnhcOjM6SHp14UvjKdEBQc/MYgq+J7Ihnbcsa6L7jw=; b=AnfAvrGAnR67C3Bmm5Wvkaf5xYs7hkhSHavXb8B6jB2BxzdvkLKOy9TakkSQkGedmQ6OBX v9b0w0kruTFJzSycbPofnw0RBJ0qzcmwKvrV8oMPFiHGHJ36QBPIF3kYGAmA8UtskrxUk0 w82tAxN08J82X1yOgAtfA38ccup50qko10ygQsw8jNtEqfKLQT1DIzPxB7lJoVVv1EucvZ CDLinCswR5BXNW5wdM68mzhHtB7iydftzuCz9sCMxIUOiig/8uYWya9swHB68rUztJgwgu X2mNgmD9ZywLbC0rpIAqxvzbTV+gytAks1Kn2kGGeFwZ26yfv18+ZjNbgq0jNA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724698714; a=rsa-sha256; cv=none; b=Te62IJb3eI3xJaFHiTufhsj3BFuEqIByVx/xiHvUbLUipS8n4R9aKtsS89nWxw0/zqCpic hYF7Y9sCImLY8zztI5EdphAEGxfgMqAX3YZ2zyKyN7yJtm169M4keE+pamUuMQRcAOSakG TK19po+7vqEOUR7JJ1Jrr49BOg8KwSETkKi2qXUfkuztovkBJbFIk04qpaN1/RQa99KuIw 1yyKm471CT81K1amk/lC04hN73eIVpkObpNXIwL++vOOVn7PZkFbM61GqA1NJ0lBVmDpqR fKEJnqaRJUufp/fD4EW8gu4odJnvOwI8jiNyMKIyoelsFmdXL58EQZz8XCQ1CA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724698714; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=dsnhcOjM6SHp14UvjKdEBQc/MYgq+J7Ihnbcsa6L7jw=; b=TDfOqi+tWOxI9kGi/2a2kP7u1KYf6M8LD7icLFsxnszz4XIFMLiYQpKOviGMAw5PmAOlbR 0ZXcE25xcZVyzeLMIBsZspDwOM1bHVibtJk7QblaxBvkEtrszpKxkSLzzaN0bBx2S+AFQt JkACCe3prLqAVONi76TuXCPdpnLHFLV4FCIADQnSjWN/dZwb9neoECo6cwPRpLeMF08nca m1BZ2PbIOPxlOidPYKAwN4sCIrRrpoRO7KQn/MP1PpXBO0j8Tg4gz6EwjA9RoahlHmK1We meKNcx/MfzGbJ2Yg8AZ3N25yUlPwPLA6krzoXZN9i4obKvpzDzGwOsWzLPUU6g== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Wt0Ly5KlLzJZ7; Mon, 26 Aug 2024 18:58:34 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47QIwYWd027741; Mon, 26 Aug 2024 18:58:34 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47QIwYsq027738; Mon, 26 Aug 2024 18:58:34 GMT (envelope-from git) Date: Mon, 26 Aug 2024 18:58:34 GMT Message-Id: <202408261858.47QIwYsq027738@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: e12b6aaf0d51 - main - vmm: Move compat ioctl definitions to vmm_dev.c List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: e12b6aaf0d515dede86001c544024e791a968707 Auto-Submitted: auto-generated The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=e12b6aaf0d515dede86001c544024e791a968707 commit e12b6aaf0d515dede86001c544024e791a968707 Author: Mark Johnston AuthorDate: 2024-08-26 18:42:13 +0000 Commit: Mark Johnston CommitDate: 2024-08-26 18:42:13 +0000 vmm: Move compat ioctl definitions to vmm_dev.c There is no reason to keep them in vmm_dev.h. No functional change intended. Reviewed by: corvink, jhb Differential Revision: https://reviews.freebsd.org/D46432 --- sys/amd64/include/vmm_dev.h | 11 ----------- sys/dev/vmm/vmm_dev.c | 14 ++++++++++++++ 2 files changed, 14 insertions(+), 11 deletions(-) diff --git a/sys/amd64/include/vmm_dev.h b/sys/amd64/include/vmm_dev.h index a007ce5515a5..5f347e46b9c4 100644 --- a/sys/amd64/include/vmm_dev.h +++ b/sys/amd64/include/vmm_dev.h @@ -54,13 +54,6 @@ struct vm_memseg { char name[VM_MAX_SUFFIXLEN + 1]; }; -struct vm_memseg_fbsd12 { - int segid; - size_t len; - char name[64]; -}; -_Static_assert(sizeof(struct vm_memseg_fbsd12) == 80, "COMPAT_FREEBSD12 ABI"); - struct vm_register { int cpuid; int regnum; /* enum vm_reg_name */ @@ -349,12 +342,8 @@ enum { _IOW('v', IOCNUM_SUSPEND, struct vm_suspend) #define VM_REINIT \ _IO('v', IOCNUM_REINIT) -#define VM_ALLOC_MEMSEG_FBSD12 \ - _IOW('v', IOCNUM_ALLOC_MEMSEG, struct vm_memseg_fbsd12) #define VM_ALLOC_MEMSEG \ _IOW('v', IOCNUM_ALLOC_MEMSEG, struct vm_memseg) -#define VM_GET_MEMSEG_FBSD12 \ - _IOWR('v', IOCNUM_GET_MEMSEG, struct vm_memseg_fbsd12) #define VM_GET_MEMSEG \ _IOWR('v', IOCNUM_GET_MEMSEG, struct vm_memseg) #define VM_MMAP_MEMSEG \ diff --git a/sys/dev/vmm/vmm_dev.c b/sys/dev/vmm/vmm_dev.c index 554583358168..db3e2c992f3b 100644 --- a/sys/dev/vmm/vmm_dev.c +++ b/sys/dev/vmm/vmm_dev.c @@ -28,6 +28,20 @@ #include #include +#if defined(__amd64__) && defined(COMPAT_FREEBSD12) +struct vm_memseg_fbsd12 { + int segid; + size_t len; + char name[64]; +}; +_Static_assert(sizeof(struct vm_memseg_fbsd12) == 80, "COMPAT_FREEBSD12 ABI"); + +#define VM_ALLOC_MEMSEG_FBSD12 \ + _IOW('v', IOCNUM_ALLOC_MEMSEG, struct vm_memseg_fbsd12) +#define VM_GET_MEMSEG_FBSD12 \ + _IOWR('v', IOCNUM_GET_MEMSEG, struct vm_memseg_fbsd12) +#endif + static int devmem_create_cdev(const char *vmname, int id, char *devmem); struct devmem_softc { From nobody Mon Aug 26 20:11:47 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Wt1zS5Jx9z5TXVj; Mon, 26 Aug 2024 20:11:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Wt1zS4tPZz4NNk; Mon, 26 Aug 2024 20:11:48 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724703108; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0y4486CdgZbZrSzAuvA1Sp5w071DPkuBXzu1eTFjMiU=; b=GTNjXL7YhMtZoDmLz3140XklSzaL/V2wpfianpIu50pvCMKzF7R/eMXssYVEusNxxnIyZy dImgKTlPo2DiXktm8BM50/i0KNn4ok/YgrDF0+k8OA+GHKF7aTBi3rjJMeeHbPH6svzV1p RlFIftkdnrpoPlUmwag+2RFrpEEwIiT9shpPaAHvA3kjiaGPqmg2kq+gB/dcxIuJluxctH 3JkfsdoKVCkym00MZdg32smbzkFXD+kACTkUPjL/Zs8fsDmr1Zi74YGkBfKzm5I2rmHRaW zrPZx4QluudzTXewVEyvYS9GVKV//1sLk0Nq3asMpOmF0YfOfyEKH5lqH8smLw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724703108; a=rsa-sha256; cv=none; b=c1qCK4CipQo6wJWZa0gvEAx6OSdcGy+Ttopky7RamKWR7ZSwWwiJ9J/7qUh/o9Jvg1tzoR u/J+3PrrKlY9PIQiKMsV+q5Otzrqwvvqxv2MncYzwjkAAhCuqQbBF0QMbXIc9Pdok33fFx ewwEMKIoCpnFkPp9Bv7DtClakC7rm0bE/AaXhEyCHLy5Ia6+9c0TjfTngRVv8NoftPCs38 ltfDyPfQZRZIztxvLuzrv8CyttZ2YEhSckaBeQOb/rM2VGZlmvoaoCmlw0p3vH3pibOgwj DN5UCH2/cLfKmeBlzxKQO3VIr3Nd1a89yDynqVaXxstaXLTzoieBvjZKqxP8/w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724703108; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0y4486CdgZbZrSzAuvA1Sp5w071DPkuBXzu1eTFjMiU=; b=gpPMordsPavu7sgrnNazMGWafybT2Ra8anCAR5hiuMmg9/pRf+WU1A+HFX9sw784R56cEW 8yl5K3VL5hPu+TJzq79eoeXQdP36ln7C8mr+BK5biBXcBa8rROUnI9/Oz4fhc7U4+GcdWg rxTSN3m+3tTGpCTJej7DmbfZNTT6O8ONM2VuwGeP5z7qPCA50Mx36XCcfBFhXnxplr0HBk OKWweN7340T/XkFlZhUJs6qwb/HnHtK21ql3BXCImAtkvmGgnQT2x1wPAvTBSxWy2qL4DK uXsY/rT0kggh0/p27hbzw9Jf4bPJep8CnN6HuyeL8xBZ6W5mn71F3ah/YAMo3w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Wt1zS4V6NzLJY; Mon, 26 Aug 2024 20:11:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47QKBmJV060717; Mon, 26 Aug 2024 20:11:48 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47QKBlif060706; Mon, 26 Aug 2024 20:11:47 GMT (envelope-from git) Date: Mon, 26 Aug 2024 20:11:47 GMT Message-Id: <202408262011.47QKBlif060706@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Cy Schubert Subject: git: de9468837c92 - main - sqlite3: Vendor import of sqlite3 3.46.1 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cy X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: de9468837c92cab304c658480bd32dbe4e022d01 Auto-Submitted: auto-generated The branch main has been updated by cy: URL: https://cgit.FreeBSD.org/src/commit/?id=de9468837c92cab304c658480bd32dbe4e022d01 commit de9468837c92cab304c658480bd32dbe4e022d01 Merge: e12b6aaf0d51 657ea345f331 Author: Cy Schubert AuthorDate: 2024-08-26 20:00:23 +0000 Commit: Cy Schubert CommitDate: 2024-08-26 20:07:14 +0000 sqlite3: Vendor import of sqlite3 3.46.1 Release notes at https://www.sqlite.org/releaselog/3_46_1.html. Obtained from: https://www.sqlite.org/2024/sqlite-autoconf-3460100.tar.gz MFC after: 1 week Merge commit '657ea345f331704c612a35e5a74968bef9ffcfd8' into sqlite3 contrib/sqlite3/configure | 20 ++--- contrib/sqlite3/configure.ac | 2 +- contrib/sqlite3/shell.c | 40 +++++----- contrib/sqlite3/sqlite3.c | 154 ++++++++++++++++++++------------------- contrib/sqlite3/sqlite3.h | 6 +- contrib/sqlite3/sqlite3rc.h | 2 +- contrib/sqlite3/tea/configure | 18 ++--- contrib/sqlite3/tea/configure.ac | 2 +- 8 files changed, 127 insertions(+), 117 deletions(-) From nobody Mon Aug 26 20:25:07 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Wt2Gq4wP0z5TYqd; Mon, 26 Aug 2024 20:25:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Wt2Gq4R6zz4PNm; Mon, 26 Aug 2024 20:25:07 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724703907; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+U5n/IvawVB/0wb2hUhn91zxZuS/tq30prxJokcJOeA=; b=szt1f/RsAYcaMqW81S7XXZU/W8sudpGbHFhxw2qhv6UL+Gaj1HnEIiLB2/GFoOwenXYqHT d6yb/8WG8LnbqU7QbZcQEpiv0NeixxqSKCtgC63cN0QasT8zXoqUn6Hl6LhRCKL45QJW8U cFOs2k7c4ojkVeEzAReaRiy8le7PfQId1pCJhkajtkB5XyEeClwRKob5Ry3J8d++Q2WA3z L85wXlTrK3n7gNw2yrlP/2uyEAS+ETZxMRAZZrqX02QhMMPeFReYmO0i/8eHc33wrxNuHx t6E7DyjY7JLH7WKlQdX3+HRBPpIo+pd5nPrcKdNJ8ldqhTUa/1cjshyvEMsgxw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724703907; a=rsa-sha256; cv=none; b=H1wJPJuqhPWDzZU3+JAc41GLfDUKGc37Bbc5QXqRiLkO/TUW14eupUVP/k6qN/pdpygeb9 Hy2lOiWBhdUKEhqLBeZNTY8SVTp6p42zLhgDeODGFk9y0bFcnzJ398kifG8NJU5MpI8mBk yAVw309Wlca8zlnEn1BlJSVLtCKT0YOlTK2nf3ybUlIgzLkYCqIa2K745LyyPSmjkIUSBk MebtCl3jlqmcYxQOe5Y1qvjQwaQJ7/WUcO/pilanF1uXYiHvTfik8xSmiE7zuxJcIsnUeH +lAfJModajXo2igr2VCa+YSo9Cp95f12KXbJ8gNJ3WiTHLet6OghEfhYW2ZgKA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724703907; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+U5n/IvawVB/0wb2hUhn91zxZuS/tq30prxJokcJOeA=; b=SBnGKZPZGAPHPbHoXZwWwb+UKUB0S+vZq+5WWLTGuqVuKGDbxqIvDiBamJhW54iYyo41Yi /7TTGMSwWXmm2aUbo2FZt7t1+WtdRfXjGWN1M3bcSAPRbpMu/2lPC+VZ+gtAFn+5Pw2wsr jvs3f/QzBZco5TlZ5H4Xccuqrev0hDulig6uwdspVi7ASyIV0KId+Llual0LPIvkr65XXg CZP8i3ChA+IpSC+EfJxVjJlasTwTdI2pRMXQU8v21SPhHxhaHV9mqAVh/dBmPN+4B08rtC 3EqKgYRdm2ws9vdlNH8bpNsTdOkhBGlgrkMMtC6CtNM4O3AYMU4y5Qb0ukqyZA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Wt2Gq42fmzL5B; Mon, 26 Aug 2024 20:25:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47QKP75t080700; Mon, 26 Aug 2024 20:25:07 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47QKP7VT080697; Mon, 26 Aug 2024 20:25:07 GMT (envelope-from git) Date: Mon, 26 Aug 2024 20:25:07 GMT Message-Id: <202408262025.47QKP7VT080697@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Ed Maste Subject: git: 85707cfdaddc - main - bhyve: avoid updating fbaddr when vm_mmap_memseg fails List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: emaste X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 85707cfdaddc179af8bd2623091eb1b8c58fed4a Auto-Submitted: auto-generated The branch main has been updated by emaste: URL: https://cgit.FreeBSD.org/src/commit/?id=85707cfdaddc179af8bd2623091eb1b8c58fed4a commit 85707cfdaddc179af8bd2623091eb1b8c58fed4a Author: Pierre Pronchery AuthorDate: 2024-07-24 20:51:20 +0000 Commit: Ed Maste CommitDate: 2024-08-26 20:23:52 +0000 bhyve: avoid updating fbaddr when vm_mmap_memseg fails In the function pci_fbuf_baraddr the field sc->fbaddr was set with a user-controlled value, even though the call to vm_mmap_memseg failed. No security risk as currently sc->fbaddr is not really used in the source code. Reported by: Synacktiv Reviewed by: emaste Sponsored by: Alpha-Omega Project Sponsored by: The FreeBSD Foundation Differential revision: https://reviews.freebsd.org/D46109 --- usr.sbin/bhyve/pci_fbuf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/usr.sbin/bhyve/pci_fbuf.c b/usr.sbin/bhyve/pci_fbuf.c index 798e9b41f0b0..125428e0b772 100644 --- a/usr.sbin/bhyve/pci_fbuf.c +++ b/usr.sbin/bhyve/pci_fbuf.c @@ -231,7 +231,8 @@ pci_fbuf_baraddr(struct pci_devinst *pi, int baridx, int enabled, if (vm_mmap_memseg(pi->pi_vmctx, address, VM_FRAMEBUFFER, 0, FB_SIZE, prot) != 0) EPRINTLN("pci_fbuf: mmap_memseg failed"); - sc->fbaddr = address; + else + sc->fbaddr = address; } } From nobody Mon Aug 26 21:02:08 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Wt35X5WHTz5TcP0; Mon, 26 Aug 2024 21:02:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Wt35X2zCLz4Rt3; Mon, 26 Aug 2024 21:02:08 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724706128; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AX0vnQQCeBv3NtQqni7pjOdrN0U2J+OqfuyJR/bjvJU=; b=AMwwQyc48Bb0U81eWLf9SmtGq7wSoTiEHx0gPrlQFs/E5MhhJKYRtqZHTU4YYmz5rNYNik Gah5Qy3jmVV0eADdGVq0Y6GsaJAWrcSuWr3BElStAiUAb0mp4J/A7YJvQX6mwb12QtaxXS 0+jaKYrmc2/R+zegv3whzYDGlMhyTQiajT1tCj2H8jKOVOrseQbeDoQpCHdTgI146rBZHk /+KJxwpW4yCO54gyNXHzIwEy63Gifu7tUfISv2e7B/P2nDBgc0RCPwSpQ3SxZXBM0jAc6l mBygulOObm5z4s/HEfFqyVzbCzwFb5yuipBBrW/g+UJo4jFrV8lf+V1UiZ8pCw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724706128; a=rsa-sha256; cv=none; b=wzTO9v/NEsdrCVjpBekVzxCw6eqAWYd2McDyACtriSauA8kOJZsk8vkezk355EF4VjRcm3 MtpcBv0Yr1B3FMX52BfyKTeLJrVEAGK/vFHannivy0xRwYF+/ocoXp/kPWWngba4tmBvii UJ7+23f+hUqttu+rRhuGxFXKoX5IaOkIEfnCOG7X3RUiRvT8Fx6qbbwacQAB253h/iCa/Y O/b9TfdzqYb4sRuW1hBOeJSwJEQe7PxkF+2Si8fVA+HNjPaBAoSlZOGkykyGRw25vrASor 7Qt5uTQaNJGJ3t4ETqevQq9dE+p6yihcPwjcu1KC6U8N3swAg38X1dX92kruMA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724706128; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AX0vnQQCeBv3NtQqni7pjOdrN0U2J+OqfuyJR/bjvJU=; b=EflH+WI8Q0hN7oImz+V334TVofN9YD6QJasSgLnOR7QoSe4t4iCgpLm7ZSGBDM7SfwsiUD goPUIBCn23ie7HUwNYevAE4PLm+Ao8RlnUaNMyoB3apHX2QoBUbQc7VVxcAZubaoz0fLTT zNk2fHpyUgT0XsLfsL1H7REGDgeqwMrmNxbNSApjB/3/QABZOQQXAks2coEpMHNAu1DBXw 39cMxzgFx+te9kx4iQ9NHGYCCB8kcsKqTaV9rmxex1sBcrZoOpFFRrIKRzLyjWEidDUJIx v58M2YaBI7AqFHF/lrK7rwhK00Za900yH3dxDhzA5ScbPBdkYcjuQu/A3FqyXw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Wt35X2ZXrzMvh; Mon, 26 Aug 2024 21:02:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47QL28gY045051; Mon, 26 Aug 2024 21:02:08 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47QL28YV045048; Mon, 26 Aug 2024 21:02:08 GMT (envelope-from git) Date: Mon, 26 Aug 2024 21:02:08 GMT Message-Id: <202408262102.47QL28YV045048@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: b4dd5ff5f4f1 - main - pkgbase: Avoid hard-coding the package prefix in generate-ucl.sh List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: b4dd5ff5f4f159a566c64e3348e67c33b80f2bbf Auto-Submitted: auto-generated The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=b4dd5ff5f4f159a566c64e3348e67c33b80f2bbf commit b4dd5ff5f4f159a566c64e3348e67c33b80f2bbf Author: Mark Johnston AuthorDate: 2024-08-26 20:46:53 +0000 Commit: Mark Johnston CommitDate: 2024-08-26 20:49:50 +0000 pkgbase: Avoid hard-coding the package prefix in generate-ucl.sh MFC after: 1 week Sponsored by: Innovate UK --- release/packages/generate-ucl.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/release/packages/generate-ucl.sh b/release/packages/generate-ucl.sh index 27adddad96c0..72db4a3180b8 100755 --- a/release/packages/generate-ucl.sh +++ b/release/packages/generate-ucl.sh @@ -136,7 +136,7 @@ main() { echo 'deps: {' >> ${uclfile} for dep in ${pkgdeps}; do cat <> ${uclfile} - FreeBSD-${dep}: { + ${PKG_NAME_PREFIX}-${dep}: { origin: "base", version: "${PKG_VERSION}" } From nobody Mon Aug 26 23:19:45 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Wt68K4LlBz5Tntv; Mon, 26 Aug 2024 23:19:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Wt68K3jYzz4b8l; Mon, 26 Aug 2024 23:19:45 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724714385; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=pjh3r2P+/aSVGOXarENhJQLV71tpy7s2sH6jfpw9pEg=; b=DeXDMbpJ5yaKmYy/3ywRvixNp3xzNUkmULOJvFmua8Ve6+CUOX0cxBAQU/tZ/G0NCYQhpH ekzjugJiIiaSnz1HKGYyY7WYvR+0P5MnDaGEw3omMTvulDPYrKFvQZF5HfmQq52Mob9CTi mymNsIDBMeSI0C6n8F5tj91yidWIrqdpKY2DgHzV0CUvae7ivh7cdPipFTTHteKwbaXKT+ L8Rk4CEbC/PsQffOGFK91ojcOOD+j1PDRaTU7XJUMRWoAcS+B27MlAv6G3TBUxuIBh7/Uj xB4ZCMENtcTDZGhZ9dkwudiTdbbbqQ1VfMQIbddetgBMysbmRM6s28dePnjnwA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724714385; a=rsa-sha256; cv=none; b=X0mKWLGG0qA69Gm34ILs5ea7Cyh62F/QYCC+ai8Gu/+/GTEQ5On3wSWekJMFD9x/yf3n54 snpXPXmsk0pA9lwmMEJnYq9vGg23dsc1RYxlKHSsgjcOE7su8ZIS5ymT1CHti8qp6kpilV SuSs6uy78+WkM+iABAMOpiFZiBRFBuf30ShnGgjsvtF6oOd8xrmOe5qF43bpuLGBywUg3G V3uIn/Q3e1QDo4fsuQRDr1hiU7qDNO5z4bY6bxP3ZyDlySyL3tQhieIMiNMdkHRcVr/wkc PpXKQVC32ug6xOI9tdsEcQzdW+m6Pdnprluo894JopfskQhMvrvbgcX8q6ZakA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724714385; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=pjh3r2P+/aSVGOXarENhJQLV71tpy7s2sH6jfpw9pEg=; b=lrNotHZDFWwaxrGq8lsUc9QSHcvUj/kSkPT0uYcMpJjmVUmvyIjdCK7tyGL2OCn449CVhM kGB89Mo3+0MJMBlP/q/9RKHJXAAflO+feUI2+in23vhQPfv8T5CBUg3Legp8c6sBjiaeTS 9Bjd0EVT/9DZXt3XTRGomK5S6M6VX/g9TarnwEjz0VgzVCC7a2lLG6C1czY2IrB5e9teU2 3E5wQ8o92ZpcgaxOsC0RZJWtU7sDcvTp20EnLGZeaXEwOYd6pKNjwB7zPuhSC/em+NWqM9 lUDg+sdl8dBe2T/NsZSb+xfiX3ARuZLNmBT1CY2vb+6y7yzDnVT/TB63WNE2Yg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Wt68K3BKdzQy9; Mon, 26 Aug 2024 23:19:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47QNJjXl068296; Mon, 26 Aug 2024 23:19:45 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47QNJjhq068293; Mon, 26 Aug 2024 23:19:45 GMT (envelope-from git) Date: Mon, 26 Aug 2024 23:19:45 GMT Message-Id: <202408262319.47QNJjhq068293@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: 871911a4ab73 - main - loader.efi(8): beef up the updating the ESP List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 871911a4ab738a54a88f3533f553f5eb68c28012 Auto-Submitted: auto-generated The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=871911a4ab738a54a88f3533f553f5eb68c28012 commit 871911a4ab738a54a88f3533f553f5eb68c28012 Author: Warner Losh AuthorDate: 2024-08-20 15:44:38 +0000 Commit: Warner Losh CommitDate: 2024-08-26 23:19:59 +0000 loader.efi(8): beef up the updating the ESP There's a huge variety of situations when booting with UEFI. Document more of them, hopefully better. Feedback from: jrtc27 MFC After: 3 days Sponsored by: Netflix --- stand/man/loader.efi.8 | 142 +++++++++++++++++++++++++++++++++++++++++-------- 1 file changed, 120 insertions(+), 22 deletions(-) diff --git a/stand/man/loader.efi.8 b/stand/man/loader.efi.8 index cc24b25594f9..a0c0df9a9c35 100644 --- a/stand/man/loader.efi.8 +++ b/stand/man/loader.efi.8 @@ -30,7 +30,7 @@ .\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF .\" SUCH DAMAGE. .\" -.Dd November 22, 2023 +.Dd August 20, 2024 .Dt LOADER.EFI 8 .Os .Sh NAME @@ -355,43 +355,141 @@ The default location for the ESP mount point is documented in The following example shows how to install a new .Nm on the ESP. +The exact placement is complicated due to the diversity of +installations, setups and situations. +In this section, paths that are all lower case are Unix paths. +Paths that are all upper case are relative to the ESP mount point, +though they may appear as lower case on your system because the +FAT filesystem of the ESP is case insensitive. .Pp -First, find the partition of type +Locate the ESP, which has its own partition type of .Dq efi : .Bd -literal -offset indent -# gpart list | grep -Ew '(Name|efi)' -1. Name: nvd0p1 - type: efi -2. Name: nvd0p2 -3. Name: nvd0p3 -4. Name: nvd0p4 -1. Name: nvd0 +# gpart show nda0 +=> 40 7501476448 nda0 GPT (3.5T) + 40 614400 1 efi (300M) + 614440 7500862048 2 freebsd-zfs (3.5T) .Ed .Pp The name of the ESP on this system is -.Pa nvd0p1 . +.Pa nda0p1 . +By default, this will be mounted on +.Pa /boot/efi . +To check: +.Bd -literal -offset indent +# mount | grep nda0p1 +/dev/nda0p1 on /boot/efi (msdosfs, local) +.Ed +If it's not mounted, you will need to mount it: +.Bd -literal -offset indent +# mount -t msdosfs /dev/nda0p1 /boot/efi +.Ed .Pp -Second, let's mount the ESP, copy -.Nm -to the special location reserved for -.Fx -EFI loaders, and unmount once finished: +.Xr efibootmgr 8 +reports what we booted from. +.Bd -literal -offset indent +# efibootmgr -v +Boot to FW : false +BootCurrent: 0001 +Timeout : 2 seconds +BootOrder : 0000, 0001, 0003, 0004, 0005, 0006, 0001, 0008, 000A, 000B, 000C, 000E, 0007 +... ++Boot0001* FreeBSD ZPOOL HD(1,GPT,b5d0f86b-265d-1e1b-18aa-0ed55e1e73bd,0x28,0x96000)/File(\EFI\FREEBSD\LOADER.EFI) + nda0p1:/EFI/FREEBSD/LOADER.EFI /boot/efi//EFI/FREEBSD/LOADER.EFI +... +.Ed +Often there are several options, depending on the BIOS. +The entry that we booted with is marked with a +.Sq + +at the start of the line, as shown above. +So in this case, this firmware is using +.Pa /EFI/FREEBSD/LOADER.EFI +from the ESP. +Often times it will be the UEFI +.Dq default +loader, which varies by architecture. +.Bl -column -offset indent "Architecture" "Default Path" +.It Sy Architecture Ta Sy Default Path +.It amd64 Ta Pa /EFI/BOOT/BOOTX64.EFI +.It arm Ta Pa /EFI/BOOT/BOOTARM.EFI +.It arm64 Ta Pa /EFI/BOOT/BOOTAA64.EFI +.It i386 Ta Pa /EFI/BOOT/BOOTIA32.EFI +.It riscv Ta Pa /EFI/BOOT/BOOTRISCV64.EFI +.El +However, care must be taken: some multiple-boot environments rely on a special +.Pa bootXXX.efi +to function. +Before updating a +.Pa bootXXX.efi +file, make sure it is the FreeBSD boot loader before updating it: +.Bd -literal -offset indent +# strings /boot/efi/EFI/BOOT/BOOTX64.EFI | grep FreeBSD | grep EFI +FreeBSD/amd64 EFI loader, Revision 3.0 +.Ed +.Pp +.Xr bsdinstall 8 +copies +.Pa loader.efi +to the default name if there wasn't one there before. +Check to see if they are copies before updating (with X64 substituted using the +above table): +.Bd -literal -offset indent +# cmp /boot/efi/EFI/FREEBSD/LOADER.EFI /boot/efi/EFI/BOOT/BOOOTX64.EFI +.Ed +Copy the loader: +.Bd -literal -offset indent +# cp /boot/loader.efi /boot/efi/EFI/FREEBSD/LOADER.EFI +.Ed +replacing the all caps part of the example with the proper path. +.Pp +If ESP path was +.Pa /FREEBSD/LOADER.EFI +and LOADER.EFI and BOOTX64.EFI were identical in the cmp step, +copy the loader to the default location: +.Bd -literal -offset indent +# cp /boot/loader.efi /boot/efi/EFI/BOOT/BOOTX64.EFI +.Ed +.Pp +.Bd -literal -offset indent +# umount /boot/efi +.Ed +Finally, if you mounted the ESP, you may wish to unmount it. .Bd -literal -offset indent -# mount_msdosfs /dev/nvd0p1 /boot/efi -# cp /boot/loader.efi /boot/efi/efi/freebsd/loader.efi # umount /boot/efi .Ed .Sh SEE ALSO .Xr loader 8 , .Xr uefi 8 .Sh BUGS -Systems that do not have a -.Dv ConOut -variable set are not conformant with the standard, and likely have unexpected -results. -.Pp Non-x86 serial console handling is even more confusing and less well documented. .Pp Sometimes when the serial port speed isn't set, 9600 is used. Other times the result is typically 115200 since the speed remains unchanged from the default. +.Pp +U-Boot implements a subset of the UEFI standard. +Some versions do not support fetching loader variables, so +.Pa efibootmgr +may not work. +In addition, +.Pa efibootmgr +is not supported on armv7 or riscv. +In these instances, the user has to understand what was booted to update +it properly (and in most cases, it will be the FreeBSD path and the UEFI default +so just copy loader.efi there if there are loaders there). +Typically in these embedded situations, there is only one .efi file (loader.efi +or a copy of loader.efi). +The path to this file is typically the default removable path above. +.Pp +Managing booting multiple OSes on UEFI varies greatly, so extra caution when +updating the UEFI default loader. +.Pp +The old, now obsolete, boot1.efi was installed as bootx64.efi in +.Fx 10 +and earlier. +Since it was quite limited in functionality, we created very small +ESPs by default. +A modern loader.efi will not fit. +However, if the old boot1.efi still works, there's no need to update +it since it will chain boot /boot/loader.efi from a copy that +make installworld updates. From nobody Tue Aug 27 07:25:45 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WtJx61Jb2z5VFw5; Tue, 27 Aug 2024 07:25:46 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WtJx56fbBz4T8X; Tue, 27 Aug 2024 07:25:45 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724743545; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=IeanAedIsS41P/kBQarn5fRw4t3K1pK7+RNW3qwAcNs=; b=qt3WlAyN3QEfOHjmJ2YCLS63coSwAwCPRS0nzKN44yKBdBvw/rjbzLk9VHss57Vfsn/GL6 /fumDZ+pisXRjBqbyObWQ7JfzcsVP9M22EKQSyyv/j7yzHnqenUaNlbIEcOzCpnjlIqzER 6gqOIuwK499ac2tAgB7ihGCdy+jwIUqpZCmX6RtXBIMOXo8ts/qjkOeKDt/4RjkdmVSQn+ V1lgXlEev4ZnW5+9y3mGftEIINVmBCIL5g0m8WP4E0LcYHXb8+fNqq3+QOqXhrvdfnvlAX V2JUeA4WfKr4dkIpV86geE0qYWluXnG+4yOoJGHmq+rRtsgNjtE3SE0abODf3A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724743545; a=rsa-sha256; cv=none; b=pv6t6UpkA8caevDgzFsggeV72brFuZttupsIkTIAWOFT4+8ORCqgdBSop19tnLg3o5kooD yYqce2NjMpttGXqOBGJ4HmYP6oH7Qy86W5aRUTqcIvPAQiJ94swlRsETsttxSjV7A2ke9W SVGbQfG4VeUv9fmRkHjbzczHEWLGQEs3SLms3XkT75+Xu79v+iPASnKRgtgY2x+D0RJI9S 06IoFue0omeGJeh6kbGh8y+fFAd9JmTE3DsiHHWUiCZhAh3eBRuvv1joMRedhS2U4f0H7U W4KdKZHGbfiN+eKm0BJtzVOyiS3cZXomhDp+vySeL/jwFfOyNtcOZ9yeJ9AZWg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724743545; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=IeanAedIsS41P/kBQarn5fRw4t3K1pK7+RNW3qwAcNs=; b=uPYSyCtz5ki3EtqglwyadWH3IKueTCzgXIEHxsPfOBTyIOa1dUhd2pAJo39xneH64E0H7G Yuli3+DjP60kbFMfDVsa/5eDahzbBjKlOkDXnNmqBcJDkFUrraVQgsgfm1y2af/jAYG7wO JZGwKhE2lD2UjRV9BJNPfEFfpmgNKFh87LoPYw9l21rxJflZmxG+phWSMh82/4eJjNDAH/ pgMa2q9Z9Rs2MsHChgVLRcbkWDGm0LP4MCYuGtk+YPt/VLufZnv58EwVZJiAxTwZ+Wqla3 8I0vAkqWoyM0MxXA1BOcI0xAeXgw4UBwbwMXBIlV+HCSXudYNXJPg6AWhvcoNQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WtJx56FyCzh7N; Tue, 27 Aug 2024 07:25:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47R7PjqP006433; Tue, 27 Aug 2024 07:25:45 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47R7PjWH006429; Tue, 27 Aug 2024 07:25:45 GMT (envelope-from git) Date: Tue, 27 Aug 2024 07:25:45 GMT Message-Id: <202408270725.47R7PjWH006429@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Stefan =?utf-8?Q?E=C3=9Fer?= Subject: git: ef5752762ba9 - main - contrib/bc: fix build with GCC List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: se X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: ef5752762ba9ec54d5c02023167d24bcdbb45fd7 Auto-Submitted: auto-generated The branch main has been updated by se: URL: https://cgit.FreeBSD.org/src/commit/?id=ef5752762ba9ec54d5c02023167d24bcdbb45fd7 commit ef5752762ba9ec54d5c02023167d24bcdbb45fd7 Author: Stefan Eßer AuthorDate: 2024-08-27 07:11:58 +0000 Commit: Stefan Eßer CommitDate: 2024-08-27 07:25:16 +0000 contrib/bc: fix build with GCC Building with GCC failed with the following error message: error: to be safe all intermediate pointers in cast from 'char **' to 'const char **' must be 'const' qualified [-Werror=cast-qual] This was caused by main() being declared with "char *argv[]" as the 3rd parameter, but argv later being passed cast to "const char**": 113 | if (BC_IS_BC) s = bc_main(argc, (const char**) argv); | ^ This is fixed by declaring the 3rd parameter of main() as "const char *argv[]". Reported by: CI MFC after: 3 days --- contrib/bc/src/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/bc/src/main.c b/contrib/bc/src/main.c index e4a1f7399bb4..da4c27156029 100644 --- a/contrib/bc/src/main.c +++ b/contrib/bc/src/main.c @@ -54,7 +54,7 @@ #include int -main(int argc, char* argv[]) +main(int argc, const char* argv[]) { BcStatus s; char* name; From nobody Tue Aug 27 13:33:16 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WtT5840msz5VkKP; Tue, 27 Aug 2024 13:33:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WtT581h0jz41Nb; Tue, 27 Aug 2024 13:33:16 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724765596; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=wrAD4yWLiZVDpynpjOTYoNY9wxh/zb7LmCJC1pcgPyA=; b=msKIIN7EzBc6jxGhb3+NkKb8jRcTOsSN2Ln+XVgEJpwjcyPH3TKsJNlK6XOvkArWeUSzec xJptC0IQfCrBMdahFYUPvfFWv0lzXrI9NfykSfH3qhMOGYoW7cX9jfrBrBnaOqMwLZbW1Y e5GO0sdWESpoiQ3yf6f3wuK+kKVAJD5nB5GnJ1JM2QzethJlJtVJ4618yojDuhqgoiMVIs LKy2Lm5o066mLzBuNNhvCmGRfhg4zNzGrdwf0TOnW0LJQjaJQZ2yyhyf4IlwhrH+tWCy47 J3uZHCzVnjN2d6B1yluNKCDM6OQvj+ZfpqaEXhpN8ZUFOvyKei0Gosg/3HvzZA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724765596; a=rsa-sha256; cv=none; b=LaQxwNQvjqLMD8EoP+AKus/F/9Nu+lu7qPY+n25PKDZJznsaHtr0k5PYTzvyFBtd7PrRmq 3HNe1gcRaMkUFiD2UKdra4jMGPRFunLQtAzbWDmSmiwPvifDSRJUOQqaJA2cNa9Vm/FusY OfEj3FJ+Vx+m7zb2wxTYq/mb0HlpiC5tHuR7L+pz/aSDLtPi+cRZtJdf6L2pL3+gLSatcI RN2ZdJTRMbUhfgfpyPzkaksbT3j0PqQv8DBe2tvbSDp/Ey6XtNSEja9lPaYYQOVQt0dRN9 0ZvAtz8Eh5Xc0/toC/3KdKFHM26Te5dkhhX2a3uR4esIrr3MCUpwFC6JWzgiqA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724765596; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=wrAD4yWLiZVDpynpjOTYoNY9wxh/zb7LmCJC1pcgPyA=; b=Cf/8z8QRzTBPNgtT6fmW0F/VvH5PIJ6RZdHxeF7rmdx8W6qivN8zgLNVt2xxls4pCx/mhq oW+hoQRQYuD5zKYPeHY5/1QI4vKFpaHqPRYPTZEXBr5hGJuG/HbKF62Zcevo1bcLJBTI+n hT6y+LL9ZLSLc3kdsnP8pX5q9z27sLCBePUrUihmHyYFJGC8V7sXMgKhXXTrvKlVH+HsJn uguhi3dKnSo+JsQITUYtOXEvLik8+G9ptXJxxN97unFtUmgn4CNLiftn7ZUe3Njbj7BhEh u9WgNgHgOb3HaHWNA8SBCcz/Q+le+MQm4f8/UhBK1ONUFVw+ZoFCz3ELX5Y1XQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WtT581HBdzsGc; Tue, 27 Aug 2024 13:33:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47RDXGtv034174; Tue, 27 Aug 2024 13:33:16 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47RDXG4f034171; Tue, 27 Aug 2024 13:33:16 GMT (envelope-from git) Date: Tue, 27 Aug 2024 13:33:16 GMT Message-Id: <202408271333.47RDXG4f034171@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Igor Ostapenko Subject: git: 033f223666ad - main - committers-src: Add igoro@ with markj@ and kp@ mentors List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: igoro X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 033f223666ad8b98d6da6bd4551307fc7ba02763 Auto-Submitted: auto-generated The branch main has been updated by igoro: URL: https://cgit.FreeBSD.org/src/commit/?id=033f223666ad8b98d6da6bd4551307fc7ba02763 commit 033f223666ad8b98d6da6bd4551307fc7ba02763 Author: Igor Ostapenko AuthorDate: 2024-08-27 00:52:28 +0000 Commit: Igor Ostapenko CommitDate: 2024-08-27 00:52:28 +0000 committers-src: Add igoro@ with markj@ and kp@ mentors Approved by: markj (mentor), kp (mentor) --- share/misc/committers-src.dot | 3 +++ 1 file changed, 3 insertions(+) diff --git a/share/misc/committers-src.dot b/share/misc/committers-src.dot index da7092c8bb24..52da2f3bcc25 100644 --- a/share/misc/committers-src.dot +++ b/share/misc/committers-src.dot @@ -204,6 +204,7 @@ hmp [label="Hiten Pandya\nhmp@FreeBSD.org\n2004/03/23"] hselasky [label="Hans Petter Selasky\nhselasky@FreeBSD.org\n"] ian [label="Ian Lepore\nian@FreeBSD.org\n2013/01/07"] iedowse [label="Ian Dowse\niedowse@FreeBSD.org\n2000/12/01"] +igoro [label="Igor Ostapenko\nigoro@FreeBSD.org\n2024/08/22"] imp [label="Warner Losh\nimp@FreeBSD.org\n1996/09/20"] ivoras [label="Ivan Voras\nivoras@FreeBSD.org\n2008/06/10"] jah [label="Jason A. Harmening\njah@FreeBSD.org\n2015/03/08"] @@ -740,6 +741,7 @@ kib -> zont kmacy -> lstewart kp -> donner +kp -> igoro kp -> nick kp -> rcm kp -> zlei @@ -760,6 +762,7 @@ markj -> bnovkov markj -> cem markj -> christos markj -> dougm +markj -> igoro markj -> jfree markj -> lwhsu markj -> mhorne From nobody Tue Aug 27 13:33:17 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WtT593KJ0z5Vk0l; Tue, 27 Aug 2024 13:33:17 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WtT592grnz41St; Tue, 27 Aug 2024 13:33:17 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724765597; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=9q6B1URgdI6U5Ow2P8oY8mIc3N3yA3bfndamwR7eiHw=; b=kkDeYyBMV2jVE2pR5FaPcJXiVYquJbotjWNVBy3DXVlBCKfqznwEuuWZtazCunSSZWfENs 9tAorZFXUklxAoxFX9vC8Vpck3C9ctDBoIStkuT7AKWEXva8KyAeBkRxQgUoD9CUsdEfUc 1qirw6HplWo0vnCYXf/ZQrjPZCKhtloauhWui6eee7tNuMOCiZAQ1OB1B7ufXrLZMxXqYu /23hfjnCdCqMGErr2IJ89HSy+5vOGKCjy3qX/VLqQslR76Jze7AKGMvADNwpesgJz3lLxa ib42MSu6SZ8rPCj68Hktls6V3r0YnXgkTK+i4cQ19g6vH0oj5/CZDBICQdsT4g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724765597; a=rsa-sha256; cv=none; b=y3IUCpG5EibiW8bKRyFi8mcV2ebCODTyXHpEyIgS3weNuPMFdCR2kWC7Rlpj+dCAyTjiSs oUAPT0srKg69CeUjStOVCQBS2jMIhk23lTafqZ3tr4s7QPxETinwOM9vBDP0hjsLyF7AwO MDr/p5fykXEjrje7jl4fGo7LUrCLPEOradWeh3r59lr7Ai+VyUpcysCfe0Rt8KluW1iZDk QoFmL98XyeS1wmB5CsUNKe6Jjuvvk8jy4SnsVJFMqO3t3eVBvdnTmb18xpEcOMPFjPsIe3 6GdAPu/vJ1Vz7Gk5mBtuupyaIIV7tt9J5GewH8CnBoy2PtSo6F3haiCToAiu0g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724765597; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=9q6B1URgdI6U5Ow2P8oY8mIc3N3yA3bfndamwR7eiHw=; b=cKkjMf7KWdoXDLuJ8IiY23Bd+K5bsRKIXgshZ0tSmvZthpFs3DRwUNR+4cmSADVOfefP6y F2/Z6xduco7Id4cRsh7NC27JDAfxTJi39JGxrIWuTCbdEBi21Oy2bdNQ3I34mUX119kmYX RQfhc0DEjKOgwrXVZmXSFgXrnzUiHCXiC2w11fM4sklmw8jo+UkbUcVvfCr3FHV6xiZaWX Mw5Z+z1X3bAvKjyW9mP/Nlve0B8uRGjvyHraJ2vLaoBELMP1sZwiNipmyh7J14g74yjqhl rXZIOf1mwH0w4iM/wLIus/OYNBKVmuIl+SEdYuJNxjzp+Tgcs7VFJWssKtKy4A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WtT592HL9zs84; Tue, 27 Aug 2024 13:33:17 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47RDXHYt034216; Tue, 27 Aug 2024 13:33:17 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47RDXHEJ034213; Tue, 27 Aug 2024 13:33:17 GMT (envelope-from git) Date: Tue, 27 Aug 2024 13:33:17 GMT Message-Id: <202408271333.47RDXHEJ034213@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Igor Ostapenko Subject: git: 199544c9900a - main - calendar: Add myself to calendar.freebsd List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: igoro X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 199544c9900a640b3a2a35bb6ab858a8f177152e Auto-Submitted: auto-generated The branch main has been updated by igoro: URL: https://cgit.FreeBSD.org/src/commit/?id=199544c9900a640b3a2a35bb6ab858a8f177152e commit 199544c9900a640b3a2a35bb6ab858a8f177152e Author: Igor Ostapenko AuthorDate: 2024-08-27 02:25:22 +0000 Commit: Igor Ostapenko CommitDate: 2024-08-27 02:25:22 +0000 calendar: Add myself to calendar.freebsd Approved by: markj (mentor), kp (mentor) --- usr.bin/calendar/calendars/calendar.freebsd | 1 + 1 file changed, 1 insertion(+) diff --git a/usr.bin/calendar/calendars/calendar.freebsd b/usr.bin/calendar/calendars/calendar.freebsd index f799c27e59fd..bc5f0a5d90ba 100644 --- a/usr.bin/calendar/calendars/calendar.freebsd +++ b/usr.bin/calendar/calendars/calendar.freebsd @@ -180,6 +180,7 @@ 04/29 Adam Weinberger born in Berkeley, California, United States, 1980 04/29 Eric Anholt born in Portland, Oregon, United States, 1983 05/01 Randall Stewart born in Spokane, Washington, United States, 1959 +05/01 Igor Ostapenko born in Astana, Kazakhstan, 1985 05/02 Kai Knoblich born in Hannover, Niedersachsen, Germany, 1982 05/02 Danilo G. Baio born in Maringa, Parana, Brazil, 1986 05/02 Wojciech A. Koszek born in Czestochowa, Poland, 1987 From nobody Tue Aug 27 13:53:38 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WtTXm0xD0z52BsL; Tue, 27 Aug 2024 13:53:44 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-io1-xd35.google.com (mail-io1-xd35.google.com [IPv6:2607:f8b0:4864:20::d35]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WtTXl1rK9z44b0; Tue, 27 Aug 2024 13:53:43 +0000 (UTC) (envelope-from markjdb@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20230601 header.b=OCxT7UTH; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=freebsd.org (policy=none); spf=pass (mx1.freebsd.org: domain of markjdb@gmail.com designates 2607:f8b0:4864:20::d35 as permitted sender) smtp.mailfrom=markjdb@gmail.com Received: by mail-io1-xd35.google.com with SMTP id ca18e2360f4ac-829e856a173so77361939f.1; Tue, 27 Aug 2024 06:53:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724766822; x=1725371622; darn=freebsd.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=i1KKLkz+HYQF4K6P7MuSBiQTgJvlFxAxJpWJ68S1lQw=; b=OCxT7UTHn9/4kS0mO2LKnSM35GLbVqH1T8dfASP01vp2A4WdWKKmSZx8Exr9dTLVJR ivLbWjfGhIwVkvTZatEJOsBAkyTwMOq54BKRjiu6WF11Lji36GEzDTVirhb6R3IT1hfv 7IJwhHzoh+PSI6AS73AZDKgusyUnNnaeq5RLrcWDSOazoHYIA+HRU6pAhdu1NQl6a8Dz ukrLTtyhHiSZFi5c08VSPIQmFWDjt+ZUGjHILmEVI3+eycu3T+bSxX/TiR6oTzvXo6ih ftfyf0UjptQ+znx0mrnCEVG1LdS90VdXVTRZxp/BF5GA2yv5vKjVerXKuxUX9nF6CsDx gxWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724766822; x=1725371622; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=i1KKLkz+HYQF4K6P7MuSBiQTgJvlFxAxJpWJ68S1lQw=; b=S4WvDkSZVmEb4rlqrE72SkOsDSlZT4p3/4GdyH3iluGR3cMpMkbPTg4rrSzzoWwTxZ FIL/6WRcBatM8Wg1XXcS8mQjr9UsRnrPo7GiCWLRPc5g8PFB7jY/G2I+1yWQ6hVYGV6W V7ps3wmoMC6mIpRqII3mEIJh2EKcnj7qS4bWCaQCt6kH8zNWFtlXWUCBzzqHEF3Sh8QP viPBCvJhpr7j9posp31li1kan1LrroGfZBQwcfV/0vrTxE/jhs6qtYSibRsvxzYa1B6R q9TIUTnYK7BP0K0ew4ets+98Gj+ZDoS+VeiREABx6IenID1KKTHYrYoYcu9nDOLtQ389 LzfA== X-Forwarded-Encrypted: i=1; AJvYcCUH+Aq7VYV0rmUqAYQrThoDVnZrf1vHHmA1G/eOmW0wuIArK802S6QGrem8z78KsKT8/ZuWNFD44WS7Gk9sMlYW96iyxfg=@freebsd.org, AJvYcCWBV2tE7c+O/4Y4p1CkqSgKg3rp7zSbWERlr1YY/KvQZkW7imy6w/rEguQEX9AJzIosqFFCP1HAV2/KdKvo4GV18TDc@freebsd.org X-Gm-Message-State: AOJu0Yz2FpWMdsQvuVSRZrGsVS/b7JLHKE07RIJePbXByexxsN+K//82 IxZ16oPbz1dAWw1PAmOw4W5ZFSeLRFG+9spKKB8AiCQRZvC+RaewxylHVg== X-Google-Smtp-Source: AGHT+IER4mPIXbpb2kMEYR2fiDd8FpOET6+mORXK85FDwyQtpMuvk9fZNBfduvArCVOFPA6QC6YvJA== X-Received: by 2002:a05:6602:1691:b0:824:d641:9448 with SMTP id ca18e2360f4ac-82788141a1bmr1829953439f.7.1724766822126; Tue, 27 Aug 2024 06:53:42 -0700 (PDT) Received: from nuc (192-0-220-237.cpe.teksavvy.com. [192.0.220.237]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4ce7106a1a5sm2662775173.102.2024.08.27.06.53.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Aug 2024 06:53:41 -0700 (PDT) Date: Tue, 27 Aug 2024 09:53:38 -0400 From: Mark Johnston To: Shawn Webb Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 417b35a97b76 - main - netinet: Add a sysctl to allow disabling connections to INADDR_ANY Message-ID: References: <202408202134.47KLYdPH055386@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spamd-Bar: -- X-Spamd-Result: default: False [-2.45 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.85)[-0.850]; MID_RHS_NOT_FQDN(0.50)[]; FORGED_SENDER(0.30)[markj@freebsd.org,markjdb@gmail.com]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20230601]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), DKIM not aligned (relaxed),none]; MIME_GOOD(-0.10)[text/plain]; TO_DN_SOME(0.00)[]; RCVD_TLS_LAST(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; FROM_HAS_DN(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::d35:from]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_NEQ_ENVFROM(0.00)[markj@freebsd.org,markjdb@gmail.com]; RCPT_COUNT_THREE(0.00)[4]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org,dev-commits-src-main@freebsd.org]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_VIA_SMTP_AUTH(0.00)[]; MISSING_XM_UA(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim] X-Rspamd-Queue-Id: 4WtTXl1rK9z44b0 On Wed, Aug 21, 2024 at 12:59:18AM +0000, Shawn Webb wrote: > Hey Mark, > > When I set the net.inet.ip.connect_inaddr_wild sysctl node to 0 and > try running `nc -vv 0.0.0.0 22` (this VM has sshd enabled), the > below-linked KASSERT fires: > > https://cgit.freebsd.org/src/tree/sys/netinet/in_pcb.c#n2304 > > No KASSERT is tripped on the IPv6 code path--that works fine. Only > IPv4 is impacted. I had tested this when I wrote the patch, and just tried again now. I haven't been able to trigger the panic: root@freebsd:~ # nc -4 -vv 0.0.0.0 22 nc: connect to 0.0.0.0 port 22 (tcp) failed: Network is unreachable I believe the error is coming from in_pcbladdr(). But, I can bypass that by rerunning the test in a classic jail with ip4.saddrsel=0. So, it seems it's best to explicitly catch that case and return an error: https://reviews.freebsd.org/D46454 > -- > Shawn Webb > Cofounder / Security Engineer > HardenedBSD > > Tor-ified Signal: +1 303-901-1600 / shawn_webb_opsec.50 > https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/raw/master/Shawn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc > > On Tue, Aug 20, 2024 at 09:34:39PM UTC, Mark Johnston wrote: > > The branch main has been updated by markj: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=417b35a97b7669eb0bf417b43e97cccbedbce6f9 > > > > commit 417b35a97b7669eb0bf417b43e97cccbedbce6f9 > > Author: Mark Johnston > > AuthorDate: 2024-08-20 21:31:57 +0000 > > Commit: Mark Johnston > > CommitDate: 2024-08-20 21:31:57 +0000 > > > > netinet: Add a sysctl to allow disabling connections to INADDR_ANY > > > > See the discussion in Bugzilla PR 280705 for context. > > > > PR: 280705 > > MFC after: 1 week > > Differential Revision: https://reviews.freebsd.org/D46259 > > --- > > sys/netinet/in_pcb.c | 8 +++++++- > > sys/netinet6/in6_pcb.c | 12 +++++++++++- > > 2 files changed, 18 insertions(+), 2 deletions(-) > > > > diff --git a/sys/netinet/in_pcb.c b/sys/netinet/in_pcb.c > > index 1a341d421f31..3fc90f1e12c2 100644 > > --- a/sys/netinet/in_pcb.c > > +++ b/sys/netinet/in_pcb.c > > @@ -234,6 +234,12 @@ in_pcbhashseed_init(void) > > VNET_SYSINIT(in_pcbhashseed_init, SI_SUB_PROTO_DOMAIN, SI_ORDER_FIRST, > > in_pcbhashseed_init, 0); > > > > +VNET_DEFINE_STATIC(int, connect_inaddr_wild) = 1; > > +#define V_connect_inaddr_wild VNET(connect_inaddr_wild) > > +SYSCTL_INT(_net_inet_ip, OID_AUTO, connect_inaddr_wild, > > + CTLFLAG_VNET | CTLFLAG_RW, &VNET_NAME(connect_inaddr_wild), 0, > > + "Allow connecting to INADDR_ANY or INADDR_BROADCAST for connect(2)"); > > + > > static void in_pcbremhash(struct inpcb *); > > > > /* > > @@ -1309,7 +1315,7 @@ in_pcbconnect_setup(struct inpcb *inp, struct sockaddr_in *sin, > > inp->inp_flowtype = hash_type; > > } > > #endif > > - if (!CK_STAILQ_EMPTY(&V_in_ifaddrhead)) { > > + if (V_connect_inaddr_wild && !CK_STAILQ_EMPTY(&V_in_ifaddrhead)) { > > /* > > * If the destination address is INADDR_ANY, > > * use the primary local address. > > diff --git a/sys/netinet6/in6_pcb.c b/sys/netinet6/in6_pcb.c > > index e6ec0f24c898..098b4e50483c 100644 > > --- a/sys/netinet6/in6_pcb.c > > +++ b/sys/netinet6/in6_pcb.c > > @@ -83,6 +83,7 @@ > > #include > > #include > > #include > > +#include > > #include > > #include > > #include > > @@ -97,6 +98,7 @@ > > #include > > #include > > #include > > +#include > > > > #include > > #include > > @@ -112,6 +114,14 @@ > > #include > > #include > > > > +SYSCTL_DECL(_net_inet6); > > +SYSCTL_DECL(_net_inet6_ip6); > > +VNET_DEFINE_STATIC(int, connect_in6addr_wild) = 1; > > +#define V_connect_in6addr_wild VNET(connect_in6addr_wild) > > +SYSCTL_INT(_net_inet6_ip6, OID_AUTO, connect_in6addr_wild, > > + CTLFLAG_VNET | CTLFLAG_RW, &VNET_NAME(connect_in6addr_wild), 0, > > + "Allow connecting to the unspecified address for connect(2)"); > > + > > int > > in6_pcbsetport(struct in6_addr *laddr, struct inpcb *inp, struct ucred *cred) > > { > > @@ -351,7 +361,7 @@ in6_pcbladdr(struct inpcb *inp, struct sockaddr_in6 *sin6, > > if ((error = sa6_embedscope(sin6, V_ip6_use_defzone)) != 0) > > return(error); > > > > - if (!CK_STAILQ_EMPTY(&V_in6_ifaddrhead)) { > > + if (V_connect_in6addr_wild && !CK_STAILQ_EMPTY(&V_in6_ifaddrhead)) { > > /* > > * If the destination address is UNSPECIFIED addr, > > * use the loopback addr, e.g ::1. > > From nobody Tue Aug 27 14:46:11 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WtVjH3bwWz52H5J; Tue, 27 Aug 2024 14:46:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WtVjH2xFMz49vQ; Tue, 27 Aug 2024 14:46:11 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724769971; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=u4XucBQdI/edCK0upoywZI5rriC4MWFijHj3+TLcHtc=; b=e+kCKWCIib8Wxe0q/0EQISwDI4Rxf2/caXd/9pUjV/BzG2nEqePMojyj+RH+5xB+TTWO0x hj9o0O1fn5MzUZ6FxDoDw8YtWMcoHT+LUugIM9MiqF2538qNrwXtpWbnrMHGFJi65Bf68P o21fj/GWkoGihK4cy8ldO8d+Zpf8sozApeYEb/EMzxBuK8urkQkqxNGjzPanGJ9aL7kL1W JSepwOlGO2H2BkrHR+GUsG8ONI2FVPZHsyPY6uzxoiNI9Pf9EK0E2k36la1ZnxNKV2jcqR QZjUNKHi3q9YVur43OB/D7jGqQ5sdlB5/c1M/Foi8DVEx9EaLWTdcuqlFqYm3A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724769971; a=rsa-sha256; cv=none; b=W9EIlrNi3B9e/A9SZ3VNNYWr5OJYLwl/KB63HuY4+sS0Pe6U8QujhC66hU09M0Ujt+GyXa jd0y0lSbTd5Pt4mLst5ClvXKHdekVpJknjR/FqSW5odbzhXcHR0hVoidSVjUnQEP8dUiEy xL52xGy/ONQJlqOJOfd/iu5hgbuNTZSJUMKJboNwpDMmBGBdoUPRQMhUdckXKmaZ3ZdoG8 NpFJU44uWUXB+MfpvQUhG626U9zAVlkafxkIPdoOhCRsnSflwt6NOg76je+0D9pVIiZXYi Z+xtlrNrWBfNyL6d9EFKLIPQFLNIwnqyCdcYaoTq1Aub7BDgwyaNC7yjIZ0pCQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724769971; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=u4XucBQdI/edCK0upoywZI5rriC4MWFijHj3+TLcHtc=; b=EYpALI3qU2rfk0kpgxeUDw9XY8XYbMkJnc+/yN08Jfaa2zV2SnccIsETNMjs/p6a5dfnFm 2tgNeZ3XswhB6YF1q0T06YX1s0Ppco/zWt64MpAM9T8vQER2SoYTbEh493y8NCEwzbNQWS lCLhPRdRNcxzud7iV7saME+HqN2fgI3mbf7P7vI/80E/b1KsCw3ge4OLjPzVfULMaKOKDb 4Nlu6E94Ec5c2wwvptJhqcZztH+6kPr1mDT4wnFfe7iH0Eyb3Vox72VTvvismAFQ2vVASV TVVszTd8KGWH0fvoDK7njYbavyPubrodzNrPTZ5meKhKOgByjqYms6eOzxlmpA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WtVjH2XbrztxN; Tue, 27 Aug 2024 14:46:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47REkBY6053384; Tue, 27 Aug 2024 14:46:11 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47REkBfW053381; Tue, 27 Aug 2024 14:46:11 GMT (envelope-from git) Date: Tue, 27 Aug 2024 14:46:11 GMT Message-Id: <202408271446.47REkBfW053381@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kristof Provost Subject: git: 2096ad13524e - main - pf: sprinkle const in pf_pull_hdr() List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 2096ad13524e5bc6ace98877dd62583ba1ec3f82 Auto-Submitted: auto-generated The branch main has been updated by kp: URL: https://cgit.FreeBSD.org/src/commit/?id=2096ad13524e5bc6ace98877dd62583ba1ec3f82 commit 2096ad13524e5bc6ace98877dd62583ba1ec3f82 Author: Kristof Provost AuthorDate: 2024-08-26 17:08:04 +0000 Commit: Kristof Provost CommitDate: 2024-08-27 14:45:46 +0000 pf: sprinkle const in pf_pull_hdr() Sponsored by: Rubicon Communications, LLC ("Netgate") --- sys/net/pfvar.h | 2 +- sys/netpfil/pf/pf.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/sys/net/pfvar.h b/sys/net/pfvar.h index d66e6f799761..10bf527c025d 100644 --- a/sys/net/pfvar.h +++ b/sys/net/pfvar.h @@ -2329,7 +2329,7 @@ int pf_multihome_scan_asconf(struct mbuf *, int, int, struct pf_pdesc *, struct pfi_kkif *); u_int32_t pf_new_isn(struct pf_kstate *); -void *pf_pull_hdr(struct mbuf *, int, void *, int, u_short *, u_short *, +void *pf_pull_hdr(const struct mbuf *, int, void *, int, u_short *, u_short *, sa_family_t); void pf_change_a(void *, u_int16_t *, u_int32_t, u_int8_t); void pf_change_proto_a(struct mbuf *, void *, u_int16_t *, u_int32_t, diff --git a/sys/netpfil/pf/pf.c b/sys/netpfil/pf/pf.c index cb69d06b1fe6..acbaf304995f 100644 --- a/sys/netpfil/pf/pf.c +++ b/sys/netpfil/pf/pf.c @@ -7422,13 +7422,13 @@ pf_test_state_other(struct pf_kstate **state, struct pfi_kkif *kif, * h must be at "ipoff" on the mbuf chain. */ void * -pf_pull_hdr(struct mbuf *m, int off, void *p, int len, +pf_pull_hdr(const struct mbuf *m, int off, void *p, int len, u_short *actionp, u_short *reasonp, sa_family_t af) { switch (af) { #ifdef INET case AF_INET: { - struct ip *h = mtod(m, struct ip *); + const struct ip *h = mtod(m, struct ip *); u_int16_t fragoff = (ntohs(h->ip_off) & IP_OFFMASK) << 3; if (fragoff) { @@ -7451,7 +7451,7 @@ pf_pull_hdr(struct mbuf *m, int off, void *p, int len, #endif /* INET */ #ifdef INET6 case AF_INET6: { - struct ip6_hdr *h = mtod(m, struct ip6_hdr *); + const struct ip6_hdr *h = mtod(m, struct ip6_hdr *); if (m->m_pkthdr.len < off + len || (ntohs(h->ip6_plen) + sizeof(struct ip6_hdr)) < From nobody Tue Aug 27 14:46:12 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WtVjJ4mnTz52Gww; Tue, 27 Aug 2024 14:46:12 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WtVjJ3QRYz49vR; Tue, 27 Aug 2024 14:46:12 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724769972; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=rz5olVQ7vsIwByHjviEbm1JvC2R0Kpv39+RP19l5HoQ=; b=dMBPJYxqCrDci0C5CddP1TZsLzhN8cv5IcwLeNp0qbqpCEsFrGRtge8Wm+ciFquohxl+Tq cWG34Ap5VyFx+GfwDAHC+SK/DZ8cZzs3jw6vIYBvB1aHog5Li/6gluncgZn6x0U3WC0FyF YVSe9fVNDxW6+j/+90rJMc05euLwa7tnDfYC77dnueJ6T0Z6NafkbifaWb+SZXfuU4Gdcy p8e7PsxFQo0IEkafSxyTDEfudUzWR1jdIuNcSiTvciVZ42RZIWYqyZf/ghTzhaw3bENULs htSW8peAwvWmXx/xRlX9IKqf3dNGY/Z+6nhqJvXWO3NtFMgtvhiLcmGe2d6WAQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724769972; a=rsa-sha256; cv=none; b=u1fcjC2hMW8Nr5YsAYW2Z6Jbk1IdJobJJI590lbpmTISKyjFtwzJ49WGrwyALmsivREmLm GyXLBvxOFkZcuXib6u/4S4noTCsoAt5ZAM8AZs+4vrNpkeK2gbsaX3RpZmuZLxW6fODC+X W1bZcIjxy1mGoKKIuaKiZs061jax6+4CdzY9RoqJIt4tqaunMDbqmpoWg2gEu4ZKOHfooG 4djxJoInEr1wCF+K/Hsrx3CDdw7ONYzzdlj+9mmcsXZa0YjIfiT+9Xss2z52jSyd+BH4zd p4EH5SfLa+HZkzTbsC9PGh2p/e3wdzlOEkDS66K80y+yVKI2j46yHY8wUhuZJg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724769972; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=rz5olVQ7vsIwByHjviEbm1JvC2R0Kpv39+RP19l5HoQ=; b=VLCsfpagH/dDSI7VwbpuXCPrV3IHgFOfhf79CBdkMsbnGm+oxbetuxutCGJ4/cBODG3FkG EZ6k/TowOZ38n0IjHdjGYYVqTcT1dHWs27QZL4HPHyKZ5GHj13j/evvbMzYMye1Fz5cNoo i7KvdVdNglvpEch12d44M243aWuhe5+GaxQezyrjh5W3lnlgjEtVb6MA7il1iky01iwv/x BghYuIR15m5/lBG3sWF4bQtsb/TF1n6mE6lj8RUajthVnt7UXHdaOIZbI33I9McahXLcKW ibVviaVBpIdGqd8HnEP/l0mjp8sDbASFxQsTFtL0fCS53O11KogsJs8Z0vNMgA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WtVjJ32DnzvBJ; Tue, 27 Aug 2024 14:46:12 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47REkChC053426; Tue, 27 Aug 2024 14:46:12 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47REkChb053423; Tue, 27 Aug 2024 14:46:12 GMT (envelope-from git) Date: Tue, 27 Aug 2024 14:46:12 GMT Message-Id: <202408271446.47REkChb053423@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kristof Provost Subject: git: 3b62f3350017 - main - netinet: fix LINT-NOINET build failure List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 3b62f3350017ab6722ebe8e4fccd9ba76acbb214 Auto-Submitted: auto-generated The branch main has been updated by kp: URL: https://cgit.FreeBSD.org/src/commit/?id=3b62f3350017ab6722ebe8e4fccd9ba76acbb214 commit 3b62f3350017ab6722ebe8e4fccd9ba76acbb214 Author: Kristof Provost AuthorDate: 2024-08-26 20:02:25 +0000 Commit: Kristof Provost CommitDate: 2024-08-27 14:45:46 +0000 netinet: fix LINT-NOINET build failure Sponsored by: Rubicon Communications, LLC ("Netgate") --- sys/netinet/in_pcb.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/netinet/in_pcb.c b/sys/netinet/in_pcb.c index 3fc90f1e12c2..70ddd581895f 100644 --- a/sys/netinet/in_pcb.c +++ b/sys/netinet/in_pcb.c @@ -234,11 +234,13 @@ in_pcbhashseed_init(void) VNET_SYSINIT(in_pcbhashseed_init, SI_SUB_PROTO_DOMAIN, SI_ORDER_FIRST, in_pcbhashseed_init, 0); +#ifdef INET VNET_DEFINE_STATIC(int, connect_inaddr_wild) = 1; #define V_connect_inaddr_wild VNET(connect_inaddr_wild) SYSCTL_INT(_net_inet_ip, OID_AUTO, connect_inaddr_wild, CTLFLAG_VNET | CTLFLAG_RW, &VNET_NAME(connect_inaddr_wild), 0, "Allow connecting to INADDR_ANY or INADDR_BROADCAST for connect(2)"); +#endif static void in_pcbremhash(struct inpcb *); From nobody Tue Aug 27 15:25:06 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WtWZB5PdMz52L9m; Tue, 27 Aug 2024 15:25:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WtWZB4rnMz4FL6; Tue, 27 Aug 2024 15:25:06 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724772306; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=zjluDdZld2UPFb/go8qS83Phup36TK7kI2nraZeIpZQ=; b=nOOPyiYTCZb3pFb4J4UpS4pbSSaT9FudLhk5goLNgLqlR1RJx2ydB4/uhenxWTgXY2V3Qz jOu/t/uLcVcFZeuy3TiS4WChpQmeokXovLKS3Lwp8yjJajui6y4RCBV5trza323z9tVOTp bYu+cdpN4DDfzQTr9SZ9xmfvxVnmy+pMWRt5LFoYnvdeyBV44Bx2moEEbYmLkvh6G32rB8 ywr1/PlsH4kE1kZof0/AY1HqSjxV7egEBYpf0+l+oMN9ephMBfKcXJ4XNX0CP4Svs6yLjD 730jL+p+aTf9nJEri9lOoLZJDSY9x5/ZcVPhD16cetS51bDbDPHnw9dyHs8YeQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724772306; a=rsa-sha256; cv=none; b=syXhrEndY5XTRrLSUWcPnkCxxh+mRyqWf1ksu3Si+IEASSb2MXDFZH7vZQsjWPlByvnqss 1ebUb8GXeqH9RU/aSFykSzI7s9+TlA9fyiN/N0E5Vk3YJ0PqXhZTevpD6i8X+yWPSTLzzY GeZZCEtZcjBeQs8h3d75/puEiX5/B7oEMG5p4Ux+kAd/HfgQztWD9lXAOi71WuzPowwg6t XhUCKU77d0/Yp1aLWtaWGLykXKxMVs+qYpmWgr2xvMCDfQtdE2VJcD1u1wUQPU/pU5/2r2 2Q2fqvLu2VoiRn7vlZBMYp7rWDYTYQtFibpt/eRL2IxxZfqUvt1fRU55mAbqVw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724772306; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=zjluDdZld2UPFb/go8qS83Phup36TK7kI2nraZeIpZQ=; b=qZfqz5B0AXxkIhhfC/fiWYLRgK5pmYYdM1/N4qpYsN8vXbg0jQZYJjXqZhdRpe9QXcS90j ZiNd6725yNSlpHQP9SsYEHg5UbKhI3CvdUSIm/QmaA0sFE5ChCqO86NzS/pTwOMvsYVj3s IsvcHg0LCuDY4PM2vKaMWu3LZ8TFsYgIL6bV7+fV9yItKcCcGswbURr04wFfRBw9SlHMlU IxQfJpu3i4ZIW6BiU8cxgrFtFCmAWdRlFHB2Tirp/ajDW/1OMnlkXY80LB+f1kyUZ0dI4a 03SJutfwV34zNkrTUH3mjGJIw8qgcqEjC+yuUNzVt1W1H4Pwex+iD6bKt0DCQA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WtWZB4RyKzvGD; Tue, 27 Aug 2024 15:25:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47RFP6MS021272; Tue, 27 Aug 2024 15:25:06 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47RFP6D8021269; Tue, 27 Aug 2024 15:25:06 GMT (envelope-from git) Date: Tue, 27 Aug 2024 15:25:06 GMT Message-Id: <202408271525.47RFP6D8021269@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mariusz Zaborski Subject: git: d0675399d09f - main - capsicum: allow subset of wait4(2) functionality List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: oshogbo X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: d0675399d09f02d347912e23d004329710338450 Auto-Submitted: auto-generated The branch main has been updated by oshogbo: URL: https://cgit.FreeBSD.org/src/commit/?id=d0675399d09f02d347912e23d004329710338450 commit d0675399d09f02d347912e23d004329710338450 Author: Edward Tomasz Napierala AuthorDate: 2024-08-27 15:19:24 +0000 Commit: Mariusz Zaborski CommitDate: 2024-08-27 15:22:12 +0000 capsicum: allow subset of wait4(2) functionality The usual way of handling process exit exit in capsicum(4) mode is by using process descriptors (pdfork(2)) instead of the traditional fork(2)/wait4(2) API. But most apps hadn't been converted this way, and many cannot because the wait is hidden behind a library APIs that revolve around PID numbers and not descriptors; GLib's g_spawn_check_wait_status(3) is one example. Thus, provide backwards compatibility by allowing the wait(2) family of functions in Capsicum mode, except for child processes created by pdfork(2). Reviewed by: brooks, oshogbo Sponsored by: Innovate UK Differential Revision: https://reviews.freebsd.org/D44372 --- contrib/capsicum-test/capmode.cc | 1 - lib/libsys/wait.2 | 10 +++++++--- sys/kern/kern_exit.c | 12 ++++++++++++ sys/kern/syscalls.master | 2 +- 4 files changed, 20 insertions(+), 5 deletions(-) diff --git a/contrib/capsicum-test/capmode.cc b/contrib/capsicum-test/capmode.cc index f32d9e038744..5ff025290211 100644 --- a/contrib/capsicum-test/capmode.cc +++ b/contrib/capsicum-test/capmode.cc @@ -594,7 +594,6 @@ FORK_TEST_F(WithFiles, AllowedMiscSyscalls) { AWAIT_INT_MESSAGE(pipefds[0], MSG_CHILD_STARTED); errno = 0; EXPECT_CAPMODE(ptrace_(PTRACE_PEEKDATA_, pid, &pid, NULL)); - EXPECT_CAPMODE(waitpid(pid, NULL, WNOHANG)); SEND_INT_MESSAGE(pipefds[0], MSG_PARENT_REQUEST_CHILD_EXIT); if (verbose) fprintf(stderr, " child finished\n"); } diff --git a/lib/libsys/wait.2 b/lib/libsys/wait.2 index 8b504e070b7a..3c649f3dfa77 100644 --- a/lib/libsys/wait.2 +++ b/lib/libsys/wait.2 @@ -25,7 +25,7 @@ .\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF .\" SUCH DAMAGE. .\" -.Dd June 24, 2022 +.Dd August 27, 2024 .Dt WAIT 2 .Os .Sh NAME @@ -605,9 +605,13 @@ must be checked against zero to determine if a process reported status. .Pp The .Fn wait -family of functions will not return a child process created with +family of functions will only return a child process created with .Xr pdfork 2 -unless specifically directed to do so by specifying its process ID. +if the calling process is not in +.Xr capsicum 4 +capability mode, and +.Nm +has been explicitly given the child's process ID. .Sh ERRORS The .Fn wait diff --git a/sys/kern/kern_exit.c b/sys/kern/kern_exit.c index f83f0433f9cd..f6263cd46d06 100644 --- a/sys/kern/kern_exit.c +++ b/sys/kern/kern_exit.c @@ -1330,6 +1330,18 @@ loop_locked: return (0); } + /* + * When running in capsicum(4) mode, make wait(2) ignore + * processes created with pdfork(2). This is because one can + * disown them - by passing their process descriptor to another + * process - which means it needs to be prevented from touching + * them afterwards. + */ + if (IN_CAPABILITY_MODE(td) && p->p_procdesc != NULL) { + PROC_UNLOCK(p); + continue; + } + nfound++; PROC_LOCK_ASSERT(p, MA_OWNED); diff --git a/sys/kern/syscalls.master b/sys/kern/syscalls.master index 9fdd443955c7..fac1c2e1e96f 100644 --- a/sys/kern/syscalls.master +++ b/sys/kern/syscalls.master @@ -157,7 +157,7 @@ int fd ); } -7 AUE_WAIT4 STD { +7 AUE_WAIT4 STD|CAPENABLED { int wait4( int pid, _Out_opt_ int *status, From nobody Tue Aug 27 15:25:07 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WtWZC6N44z52Kd2; Tue, 27 Aug 2024 15:25:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WtWZC5qGBz4FQJ; Tue, 27 Aug 2024 15:25:07 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724772307; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BMjjQM5s3U+sNg6heM2fN+2GgO7H3krFDyJWHl0BOb4=; b=xu3+WSxF/gmcqG+C7gqQLtL7k+IUm7W4Ud97LtK0Np2ttVWFdIsPYioW6hYIGHQOfSQzPL GoiyjVlUhKbHXyKD6m8pE39XVmSw3cFmcBzJ/+kQhhdrbvOBOGY0iJnQq5eY3GNWAOQxdE fe8n8cOlPRiApg3SpfQ4fQL5eWsIotGkzoJdieoSIsexv8V/ftZpP2wbi5xcfT++U0WDpv JwSLOWFuJ7yPWbH/mYoIoLFZ2Xgr2SEUMwjDedVECtIqEfr3bIKdedYLqeWGmy00+5UQ5M oSi53kjwkyglIQG2/Eweq3u41oFHO/W/oyyiBsF3l80vNVEm5gGFtuDFKH3UCg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724772307; a=rsa-sha256; cv=none; b=EGdJecJyAWNMS893Mu6gq3eUblv+KYLNSNnHJCw7d4vv1l9Ix1wOOiKOCt0mmt9Nxm4saC 9Z4NbADORLJ8hRdZAbQ5Tvu9SLi6QYGy8LUgq1OVnoQAZjqiXwlp52CaYaEiUkPAK0YCGc f5Quca65gk9NnwZkR6ywFHUgugwgCWpuoHWhA+8UJtTKboKf6B345zmBXGMEbDQDSY0l8f pYZdfCifuVUyH5vRLms3Yv078PjpxgFqPEqFRfeyAxUxMxyXNpih+6uuY0OBqWiJ1LxLxd /VdqIK19wF1KBgc5D2uwKOBmZIvW171lZrAUt8aNx09r/GGGv7ksaniWFPbV1g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724772307; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BMjjQM5s3U+sNg6heM2fN+2GgO7H3krFDyJWHl0BOb4=; b=XgEM1I2RZW57tX1rKpRidzTjaxxNmbTFGgf3HBMuS07coUXpBI5e6r9MAhz3JFGgMuTJqy cpsCT8ncrvW3NNRNwCgPG0MU4FjaQBPM0OyXLc+zTnl3rHIHohNpw+sfDZfjjlUCEKDCAL d6g5cy37AhrACVVPMpC216H/0w9oDf1GgcGOtuqaOUJMS8J9jcqJwXvgfjt9x2jqhWhvG8 hxNUk/hv6jpC+oAGPyCoCpzBb1aEW3yjwmNqKfIsukw51lO6mT2Nxg5qdIUdLzWCAXJoVC /myQZ4U0e3ANB4hzFDdTt26KoH7ORFq3JARFOtgw/tHW5lMl3D9AK9q0q0Y60w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WtWZC5P6Rzvhd; Tue, 27 Aug 2024 15:25:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47RFP7j4021312; Tue, 27 Aug 2024 15:25:07 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47RFP7OG021309; Tue, 27 Aug 2024 15:25:07 GMT (envelope-from git) Date: Tue, 27 Aug 2024 15:25:07 GMT Message-Id: <202408271525.47RFP7OG021309@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mariusz Zaborski Subject: git: 24b1cf7a8a1d - main - sysent: regen after d0675399 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: oshogbo X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 24b1cf7a8a1d2ad9eda9d155c264da092c1351ac Auto-Submitted: auto-generated The branch main has been updated by oshogbo: URL: https://cgit.FreeBSD.org/src/commit/?id=24b1cf7a8a1d2ad9eda9d155c264da092c1351ac commit 24b1cf7a8a1d2ad9eda9d155c264da092c1351ac Author: Mariusz Zaborski AuthorDate: 2024-08-27 15:24:54 +0000 Commit: Mariusz Zaborski CommitDate: 2024-08-27 15:24:54 +0000 sysent: regen after d0675399 --- sys/compat/freebsd32/freebsd32_sysent.c | 2 +- sys/kern/init_sysent.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/compat/freebsd32/freebsd32_sysent.c b/sys/compat/freebsd32/freebsd32_sysent.c index 54b07374bbce..b8df64206611 100644 --- a/sys/compat/freebsd32/freebsd32_sysent.c +++ b/sys/compat/freebsd32/freebsd32_sysent.c @@ -68,7 +68,7 @@ struct sysent freebsd32_sysent[] = { { .sy_narg = AS(write_args), .sy_call = (sy_call_t *)sys_write, .sy_auevent = AUE_WRITE, .sy_flags = SYF_CAPENABLED, .sy_thrcnt = SY_THR_STATIC }, /* 4 = write */ { .sy_narg = AS(open_args), .sy_call = (sy_call_t *)sys_open, .sy_auevent = AUE_OPEN_RWTC, .sy_flags = 0, .sy_thrcnt = SY_THR_STATIC }, /* 5 = open */ { .sy_narg = AS(close_args), .sy_call = (sy_call_t *)sys_close, .sy_auevent = AUE_CLOSE, .sy_flags = SYF_CAPENABLED, .sy_thrcnt = SY_THR_STATIC }, /* 6 = close */ - { .sy_narg = AS(freebsd32_wait4_args), .sy_call = (sy_call_t *)freebsd32_wait4, .sy_auevent = AUE_WAIT4, .sy_flags = 0, .sy_thrcnt = SY_THR_STATIC }, /* 7 = freebsd32_wait4 */ + { .sy_narg = AS(freebsd32_wait4_args), .sy_call = (sy_call_t *)freebsd32_wait4, .sy_auevent = AUE_WAIT4, .sy_flags = SYF_CAPENABLED, .sy_thrcnt = SY_THR_STATIC }, /* 7 = freebsd32_wait4 */ { compat(AS(ocreat_args),creat), .sy_auevent = AUE_CREAT, .sy_flags = 0, .sy_thrcnt = SY_THR_STATIC }, /* 8 = old creat */ { .sy_narg = AS(link_args), .sy_call = (sy_call_t *)sys_link, .sy_auevent = AUE_LINK, .sy_flags = 0, .sy_thrcnt = SY_THR_STATIC }, /* 9 = link */ { .sy_narg = AS(unlink_args), .sy_call = (sy_call_t *)sys_unlink, .sy_auevent = AUE_UNLINK, .sy_flags = 0, .sy_thrcnt = SY_THR_STATIC }, /* 10 = unlink */ diff --git a/sys/kern/init_sysent.c b/sys/kern/init_sysent.c index 291d38865bd3..e066b04b4f6e 100644 --- a/sys/kern/init_sysent.c +++ b/sys/kern/init_sysent.c @@ -67,7 +67,7 @@ struct sysent sysent[] = { { .sy_narg = AS(write_args), .sy_call = (sy_call_t *)sys_write, .sy_auevent = AUE_WRITE, .sy_flags = SYF_CAPENABLED, .sy_thrcnt = SY_THR_STATIC }, /* 4 = write */ { .sy_narg = AS(open_args), .sy_call = (sy_call_t *)sys_open, .sy_auevent = AUE_OPEN_RWTC, .sy_flags = 0, .sy_thrcnt = SY_THR_STATIC }, /* 5 = open */ { .sy_narg = AS(close_args), .sy_call = (sy_call_t *)sys_close, .sy_auevent = AUE_CLOSE, .sy_flags = SYF_CAPENABLED, .sy_thrcnt = SY_THR_STATIC }, /* 6 = close */ - { .sy_narg = AS(wait4_args), .sy_call = (sy_call_t *)sys_wait4, .sy_auevent = AUE_WAIT4, .sy_flags = 0, .sy_thrcnt = SY_THR_STATIC }, /* 7 = wait4 */ + { .sy_narg = AS(wait4_args), .sy_call = (sy_call_t *)sys_wait4, .sy_auevent = AUE_WAIT4, .sy_flags = SYF_CAPENABLED, .sy_thrcnt = SY_THR_STATIC }, /* 7 = wait4 */ { compat(AS(ocreat_args),creat), .sy_auevent = AUE_CREAT, .sy_flags = 0, .sy_thrcnt = SY_THR_STATIC }, /* 8 = old creat */ { .sy_narg = AS(link_args), .sy_call = (sy_call_t *)sys_link, .sy_auevent = AUE_LINK, .sy_flags = 0, .sy_thrcnt = SY_THR_STATIC }, /* 9 = link */ { .sy_narg = AS(unlink_args), .sy_call = (sy_call_t *)sys_unlink, .sy_auevent = AUE_UNLINK, .sy_flags = 0, .sy_thrcnt = SY_THR_STATIC }, /* 10 = unlink */ From nobody Tue Aug 27 17:50:44 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WtZpD72SJz52Y9B; Tue, 27 Aug 2024 17:50:44 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WtZpD6WMXz4XVH; Tue, 27 Aug 2024 17:50:44 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724781044; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=NDenC6Iz+pnugF5a5xT0xRLVVIJ5kIWATj6IdM9Qg4I=; b=o4ZjJz2Fp4ek1uuD42Z1wXABGgARxiC0eyeTHSTki8TSyb3Oqj1NLoleBcFeN5UGyuRLMN pFIVwMxpP3OH6mAvCi7j9CtR1Vt78Vib19WtCfc+Js1rsqMbIuifsavr12y4nDBdKt3BP6 qDktPLevFAgMHY1UggQbonhiNeZpbCmPY4GrrKISv5ji7qjY+woEIjvbQugcetTMXvBSbA 4rNJ4sYqKULIQ+YJp0TbKigcwfihdeG65Zsj1dsoEury0tciZkgCylX7o2mlyVJERM2ghM c7td0T0K3iXz9SdLhYB7sL8QzBrmaOlvGZcHvKddzgw7iLmw2wKY3Xcjd7FUNA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724781044; a=rsa-sha256; cv=none; b=Q9OqOl3xq6uJW8+Eh73XiEPDkzgyNiwU62hL7uKUVDHMZX0RybIOvCWgXm2+Ee/qtfU0lY PLfeCFsR+ER9cNDeMX3+w4SDMZoZW6gjViscJustEVXzYIjx29QSkCESqeo56kAx4oHazi PQiDBvRPaEXWgEs8odeY575erTQ61qDwvqY7XL6HE9vAkSVSOfErv2xxr4fNKkWKxu+sP3 P7LAbUREweYWQShV7c8olec46sUGPycACbnBOmx3ezbH7iiknNZc14b0HTpenxS21KVBkt Iw/sMDmYvInyIhR2JC/D32kwgR7yk+nIM355yz/HWmwkgoltB8A3VWMGd5E0cw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724781044; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=NDenC6Iz+pnugF5a5xT0xRLVVIJ5kIWATj6IdM9Qg4I=; b=CUaLsJeAM/ne91yZ1Vv+eIvCGFKdFPstTtOb4TMLa3Guhqns46WaDSZz2Awk4IouWjGLAz UClhJyBNfSSVseq1xIcGa7rA8utAIxdnqt1kVJzoumbaAPlae8WWaedhu3PZ/cR3S5RYd9 tKzu+PlNbI20W7JbOz6tsLaXxxkC9jOGaoWgCNB2Adq2HKwR4V5eHF26o6fntADAWTcUiY hQqZujYoOrjM3pPM94AZcgXX/mD07n91ZBEqaf32fkZMVOx1pfSJBEH5bhqs2PnnMMCe93 /F58iKFUAaxTIGnu5R6jgttlWF5fer4/PAcTDp/5PeTbZJ6M59LI9D5+bgR1oQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WtZpD66dGz103f; Tue, 27 Aug 2024 17:50:44 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47RHoigs067700; Tue, 27 Aug 2024 17:50:44 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47RHoiaK067697; Tue, 27 Aug 2024 17:50:44 GMT (envelope-from git) Date: Tue, 27 Aug 2024 17:50:44 GMT Message-Id: <202408271750.47RHoiaK067697@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: "Bjoern A. Zeeb" Subject: git: 9c0cce328363 - main - usb: correct the rtw8821cu quirk and add another wireless rtw88 device List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: bz X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 9c0cce328363bd62f3c9add67bea7422208d9903 Auto-Submitted: auto-generated The branch main has been updated by bz: URL: https://cgit.FreeBSD.org/src/commit/?id=9c0cce328363bd62f3c9add67bea7422208d9903 commit 9c0cce328363bd62f3c9add67bea7422208d9903 Author: Bjoern A. Zeeb AuthorDate: 2024-07-31 08:10:24 +0000 Commit: Bjoern A. Zeeb CommitDate: 2024-08-27 17:48:43 +0000 usb: correct the rtw8821cu quirk and add another wireless rtw88 device The RTW8821CU_CD entry in quirks has an invalid lo_rev/hi_rev match entry. Use the different USB_QUIRK macro to match on all of these; the value we currently see is 0x0200 on two different wifi sticks. [1] Also add an entry for the DLINK DWA-181 rev A1, rtw88 USB. Submitted by: phk Tested by: phk Fixes: b3b6a959c85af3aabbde3ef2b80dbd4bf5b6f5a7 [1] Sponsored by: The FreeBSD Foundation MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D46189 --- sys/dev/usb/quirk/usb_quirk.c | 2 +- sys/dev/usb/usbdevs | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/dev/usb/quirk/usb_quirk.c b/sys/dev/usb/quirk/usb_quirk.c index d6ddeafd7195..8c49f048ecb3 100644 --- a/sys/dev/usb/quirk/usb_quirk.c +++ b/sys/dev/usb/quirk/usb_quirk.c @@ -534,7 +534,7 @@ static struct usb_quirk_entry usb_quirks[USB_DEV_QUIRKS_MAX] = { UQ_MSC_NO_INQUIRY, UQ_CFG_INDEX_0), USB_QUIRK(SMART2, G2MEMKEY, UQ_MSC_NO_INQUIRY), USB_QUIRK_REV(RALINK, RT_STOR, 0x0001, 0x0001, UQ_MSC_IGNORE), - USB_QUIRK_REV(REALTEK, RTW8821CU_CD, 0x0001, 0x0001, UQ_MSC_IGNORE), + USB_QUIRK(REALTEK, RTW8821CU_CD, UQ_MSC_IGNORE), /* Non-standard USB MIDI devices */ USB_QUIRK(ROLAND, UM1, UQ_AU_VENDOR_CLASS), USB_QUIRK(ROLAND, SC8850, UQ_AU_VENDOR_CLASS), diff --git a/sys/dev/usb/usbdevs b/sys/dev/usb/usbdevs index ea011f54b075..e02289521095 100644 --- a/sys/dev/usb/usbdevs +++ b/sys/dev/usb/usbdevs @@ -1729,6 +1729,7 @@ product DLINK DWA180A1 0x3316 DWA-180 rev A1 product DLINK DWA172A1 0x3318 DWA-172 rev A1 product DLINK DWA131E1 0x3319 DWA-131 rev E1 product DLINK DWA182D1 0x331c DWA-182 rev D1 +product DLINK DWA181A1 0x331e DWA-181 rev A1 product DLINK DWL122 0x3700 DWL-122 product DLINK DWLG120 0x3701 DWL-G120 product DLINK DWL120F 0x3702 DWL-120 rev F From nobody Tue Aug 27 18:39:02 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Wtbsz17YYz52cWc; Tue, 27 Aug 2024 18:39:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Wtbsz0V60z4gsS; Tue, 27 Aug 2024 18:39:03 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724783943; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FpbAtf2uh7vyXNObJA1skAKFNUuRfZC8BtmqbFv3ZCk=; b=eJu22u579A/VEbToQ9msgKX4egJWCZIkfULIBtRSgqdcAs1GkwHxT7v0a8e6jnFZpunHUi knpsrsZBSXhl12GnjEf12LGMhfJHfyhQk8kioUDxH5UpZIyq6OgqupX5ck6qvqZwE1LURH df1jyYUipxhuduYSZmFebCW0Yo7TtQpgR2NSwxumf8oPg8sMKmMJNbopwI10G48TfDuXK8 C7FvNQtQtEJToh5EjiWOq0Mo8NkFZEMD8I7vbyPsvX9ualkiiCMSIS9hD1Uf8LqKCD4f6p iL8nubWmoMJX+WOcr6GxWBc2BskPqEsyL4o3hN6zUWQPS5keoXK7hTRF9tP7lA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724783943; a=rsa-sha256; cv=none; b=P7vrM+Uir/jfcncH711DADRGo83wU4wf5DZfeIsB9r5Gazy3eHQKc8NR3ZH1OqI9BWdHfn QHsvYnnuQFpFFs57hTmbNaEnlXg0p9/L9yjc+bgdENezB8g107lYLb08oSaZWkW0Q4zIyt 0dMXSGHHrcN+9df9D7emvk7yq7jBmGfUiQhGwxMsT52saluFmwSpu81o3JSBjxNp8zAVTc q859OjYa6jl6le5hv9SQlyut4tkbNrp6vXOXMJadD52Sz6ZbldAibOrWUFnyodwzWFeE0c 1JOEp2OtgIV75Yn3AtqgnNqP+AfGwXaDWzv9TK2Zc4/dlKdsxbBLZegV1dqVNw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724783943; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FpbAtf2uh7vyXNObJA1skAKFNUuRfZC8BtmqbFv3ZCk=; b=YIenJUN6ad6UC8A2dbReh9wx2+FEBwBkbCdUUIVZS0Q0xF0XcEgz/fe917b4mPqTzHdkeH 26E3gnYM3b8+wr21lA3Rtl17M1leXbVy5Yz1CcqXdFh6JxHMECfQNTViV/URQN8aDEYe46 TkfTCbxLwf4JBt0J1T8NDzqaMlksJPYS3RtYFvpUBKMIH9dPX6FIuSviAQ6XHA1vt5QC6R ZQNZJhtsfQGPvqWHwyXQWoAvUc3ve3N2SGxqqXvsVPDJKelRV2/+Td5y2rZl0x5rPLXc32 2aKxl4koZhOkZLzI31U2oPCBUFf/whDHpnsqh1m/uL7pF+7+rY+wzcVKMDiDXg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Wtbsy71pPz11BK; Tue, 27 Aug 2024 18:39:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47RId2GH044812; Tue, 27 Aug 2024 18:39:02 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47RId2HG044809; Tue, 27 Aug 2024 18:39:02 GMT (envelope-from git) Date: Tue, 27 Aug 2024 18:39:02 GMT Message-Id: <202408271839.47RId2HG044809@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: "Bjoern A. Zeeb" Subject: git: 499c337781bf - main - tools/sdiodevs2h.awk: fix after removal of $FreeBSD$ List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: bz X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 499c337781bf8df7f97f612b93427b3f53dfd8bb Auto-Submitted: auto-generated The branch main has been updated by bz: URL: https://cgit.FreeBSD.org/src/commit/?id=499c337781bf8df7f97f612b93427b3f53dfd8bb commit 499c337781bf8df7f97f612b93427b3f53dfd8bb Author: Bjoern A. Zeeb AuthorDate: 2024-08-27 18:33:14 +0000 Commit: Bjoern A. Zeeb CommitDate: 2024-08-27 18:33:14 +0000 tools/sdiodevs2h.awk: fix after removal of $FreeBSD$ The input file used to have a $FreeBSD$ tag on the first line and we recorded that in the generated files to know which versions they were based on. With the removal of $FreeBSD$ the logic was not quite correct anymore; fix that to generate proper header files again. Sponsored by: The FreeBSD Foundation MFC after: 3 days Reviewed by: imp Differential Revision: https://reviews.freebsd.org/D46300 --- sys/tools/sdiodevs2h.awk | 6 ------ 1 file changed, 6 deletions(-) diff --git a/sys/tools/sdiodevs2h.awk b/sys/tools/sdiodevs2h.awk index 1cddd6c1f5d0..818bdef58762 100644 --- a/sys/tools/sdiodevs2h.awk +++ b/sys/tools/sdiodevs2h.awk @@ -44,9 +44,6 @@ function header(file) printf("/*\n") > file printf(" * THIS FILE IS AUTOMATICALLY GENERATED. DO NOT EDIT.\n") \ > file - printf(" *\n") > file - printf(" * generated from:\n") > file - printf(" *\t%s\n", VERSION) > file printf(" */\n") > file } @@ -233,13 +230,10 @@ line=0; while ((getline < srcfile) > 0) { line++; if (line == 1) { - VERSION = $0 - gsub("\\$", "", VERSION) if (dfile) header(dfile) if (hfile) header(hfile) - continue; } if ($1 == "vendor") { vendor(hfile) From nobody Tue Aug 27 18:39:03 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Wtbt02Fn8z52cSv; Tue, 27 Aug 2024 18:39:04 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Wtbt00v44z4gsT; Tue, 27 Aug 2024 18:39:04 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724783944; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Tv4vFF/mU4aaY/rixZlbRk8vy4MF8WXoFcOVa+gKJX8=; b=aqOINMS30fID801HrDn9UqvS5vUm1Y/W2sLSqoVlRY8rvGo7kotSJsmPHONFwyn2pdUTDJ +JJJzh13N/pkibuCk7jzVdShcagJ92/FbHDZsKytzzOBLE77rLNg7hWNL9/WLttfSJ+57I 3L+6NzO1nea2LSyuM7vTFmvKxJ85kylir174PVvLb3n0Fph5WBpz2GRCV1AQ+7tDu+rzxE y8e6tAW56ILjw8R7eszrQ9Tap2CsI6c4G0S3qJC8uooISSek6+59zv9cxLq1ycNG6Ifzo7 n46xbLxGU7K8d3shurrDBH9oI5VOGeWP2IeCD4lJfOc5UBciPTJoxw4vDquu5w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724783944; a=rsa-sha256; cv=none; b=KcqJ1LOTUAMywvPJ89/BMISXI9ryARITj8k8vyN4WMgLQbhzCa89MTlevlS2krQTwoHLhE ISfaKnuqjcU0eqMI+u4msh8d9vsinlNQ8XBV+5ebd0H3XoQ1Tltzg855n0yNOofgyuTIGt Fh2WUShzPt/giVhlqtcZ2q5QVtdMLux+E1DPBLLRtpf51LsiXSgaUwlz/Kl09sYhc/kib8 OaaGfd8RSw5NKXX6cYeC5S7HrVdYBWFSc7PFzyIytDwoRcwGK4zwC0xeNLxer/HYVnsrk7 YMOopmsVysrxhsnSItMOrohRuCq+RBxNPpP1rptVig2sDHA8lSy4hJKadGilIQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724783944; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Tv4vFF/mU4aaY/rixZlbRk8vy4MF8WXoFcOVa+gKJX8=; b=fxsd9yh8YuB/+ePKrhYyoWoUnBELJNppDIvt9QjLinGDoC5f8Nm/BXbupCjFQwsU3vJgKD 3HqvX3DGGrqkErgvlgEjpwsdqZezK2/bkUCE32HACEjXM+8wHcEp7q/R4ZnJ7dv59Fhlx5 m2icPfs6kYzE4x9T3vfvHpObc+BtadsHEBdI5SaroQBYANB23YBtgzJwGqJP06Roq/jzww QxNmM9hk+49DUAT3pLd9i69pqiSgYK16C1IzUyXz4qtMTRDt+B1O+qBVHDQOq8pWwwP9RU c6hRNK5NJyAway9zkZ4U2mEMFIx85gaxjLPdBLY19/Th6bPmsZyq6KylP5Tx3g== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Wtbt00WdGz11bg; Tue, 27 Aug 2024 18:39:04 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47RId3j6044869; Tue, 27 Aug 2024 18:39:03 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47RId3NV044866; Tue, 27 Aug 2024 18:39:03 GMT (envelope-from git) Date: Tue, 27 Aug 2024 18:39:03 GMT Message-Id: <202408271839.47RId3NV044866@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: "Bjoern A. Zeeb" Subject: git: 51cb6f524457 - main - tools/sdiodevs2h.awk: adjust defined named for vendor and device IDs List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: bz X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 51cb6f5244575e1abc008598e90eb35452ffbcac Auto-Submitted: auto-generated The branch main has been updated by bz: URL: https://cgit.FreeBSD.org/src/commit/?id=51cb6f5244575e1abc008598e90eb35452ffbcac commit 51cb6f5244575e1abc008598e90eb35452ffbcac Author: Bjoern A. Zeeb AuthorDate: 2024-08-27 18:35:49 +0000 Commit: Bjoern A. Zeeb CommitDate: 2024-08-27 18:37:55 +0000 tools/sdiodevs2h.awk: adjust defined named for vendor and device IDs Generate defined names which match the ones in the Linux drivers (a lot more); given we are likely to have drivers only based on those one way or another there is absolutely no reason to fight over differently generated names for device and vendor IDs. Sponsored by: The FreeBSD Foundation MFC after: 3 days Reviewed by: imp Differential Revision: https://reviews.freebsd.org/D46300 --- sys/tools/sdiodevs2h.awk | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sys/tools/sdiodevs2h.awk b/sys/tools/sdiodevs2h.awk index 818bdef58762..596d09531ab1 100644 --- a/sys/tools/sdiodevs2h.awk +++ b/sys/tools/sdiodevs2h.awk @@ -55,7 +55,7 @@ function vendor(hfile) vendors[nvendors, 1] = $2; # name vendors[nvendors, 2] = $3; # id if (hfile) - printf("#define\tSDIO_VENDOR_%s\t%s\t", vendors[nvendors, 1], + printf("#define\tSDIO_VENDOR_ID_%s\t%s\t", vendors[nvendors, 1], vendors[nvendors, 2]) > hfile i = 3; f = 4; @@ -105,7 +105,7 @@ function product(hfile) products[nproducts, 2] = $3; # product id products[nproducts, 3] = $4; # id if (hfile) - printf("#define\tSDIO_PRODUCT_%s_%s\t%s\t", \ + printf("#define\tSDIO_DEVICE_ID_%s_%s\t%s\t", \ products[nproducts, 1], products[nproducts, 2], \ products[nproducts, 3]) > hfile @@ -155,7 +155,7 @@ function dump_dfile(dfile) printf("const struct sdio_knowndev sdio_knowndevs[] = {\n") > dfile for (i = 1; i <= nproducts; i++) { printf("\t{\n") > dfile - printf("\t SDIO_VENDOR_%s, SDIO_PRODUCT_%s_%s,\n", + printf("\t SDIO_VENDOR_ID_%s, SDIO_DEVICE_ID_%s_%s,\n", products[i, 1], products[i, 1], products[i, 2]) > dfile printf("\t ") > dfile printf("0") > dfile @@ -189,7 +189,7 @@ function dump_dfile(dfile) } for (i = 1; i <= nvendors; i++) { printf("\t{\n") > dfile - printf("\t SDIO_VENDOR_%s, 0,\n", vendors[i, 1]) > dfile + printf("\t SDIO_VENDOR_ID_%s, 0,\n", vendors[i, 1]) > dfile printf("\t SDIO_KNOWNDEV_NOPROD,\n") > dfile printf("\t \"") > dfile j = 3; From nobody Tue Aug 27 20:38:04 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WtfWJ68mcz5JtRg; Tue, 27 Aug 2024 20:38:04 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WtfWJ5KQ9z4sZc; Tue, 27 Aug 2024 20:38:04 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724791084; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=TnyS+N+ccfyCdM0v99H3M9NZXAs4L7hsHS0wvQ7iE1o=; b=X4ezXOZm9lIsgfGR023zt9lt9tpHZiMUELsj6sCPLbU7p4YYTweZD4g4J1jCElohOA5JyM Dktyd/Zao+G6gBY7231fWTDSG5BaU4Gn/h3uWhFBRJdV28IpP5SH5oMmg9j8F0L6iKAHgt d4BFtG0KGzz9plsBt12prqgp5nV1WSoqXmst/zFvYfBR/k10xMaoGXacJFBxCNe5Id1O4T z+TNxfTNWe5bIKJqtKCh8I9vZWGIxQdoRFXi79m++A69V/9rovgdV+LPnztk4BdG5JCEtU IbHdaDdfmwBWT6Qwh/NcqkKnhb+vSD/DBa88kVKjY48/lBbX4lOrE0XyNd3tHw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724791084; a=rsa-sha256; cv=none; b=XQyWqY7KG/DfmopQV6fGyulaRU9nHdrAhYqy4fH8HhIsJN0ofyU58r+ktHo1umcdbcSIs2 /tUM+MPlwa5WV6uAQ8aGEKllF8+UGob3DKVwtrPHPw25SlPn8DVKsNabv0CtoYjUVgw/Sg ZbIGWGqrWlyYAMCC0OPYu9pkdliPXZSW2skirec1kUk+Cl3Cx76/UmaubzX7Vpep5RDwsM UG4+FXqN5QNBhZ0BqCxREIky++vq7SrzWaGIF/vxH3RNmbl+v+n2TEfNt7rsopuMNgvi7A T/JNxfQhFlv3UHJEvwd/a9ew0ye5k8oX3KviuH2JFvpveoeymesZhCwVy57bVQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724791084; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=TnyS+N+ccfyCdM0v99H3M9NZXAs4L7hsHS0wvQ7iE1o=; b=eIWJ1C/DCfgHBRmSaKzr0dh0taSJeVXgTMV+Lc0rS3ZYrxKkh9R3ojthHTg6o2qB3YTRC/ V2jAChXqqY8yylD3Ra/fMuEjNsEK3aA2pYDAjplpj2EFNmy35J2WkZ1Rl+gE1xln29zjxF KLW01kXe4jghPAfym4Ebz+xv/2Mosg2y7e8GMmPv/R9T2f8QMpnbqCoWNS4njUt7E2jamO dXEiyGVsQl+rJ5AYp3B1QVv0I7nAT0SnJ0Pok+Td3ZF7fwzRfwWnQPxYIe6G1huJ+afZlF UVNsE+iJeoBF70gRyNjWH8IEkP1cq7qJk3sVBTyC2pLfyw/hOTSbLw/0XpfEcw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WtfWJ4wk9z14h1; Tue, 27 Aug 2024 20:38:04 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47RKc4AL048986; Tue, 27 Aug 2024 20:38:04 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47RKc4cb048983; Tue, 27 Aug 2024 20:38:04 GMT (envelope-from git) Date: Tue, 27 Aug 2024 20:38:04 GMT Message-Id: <202408272038.47RKc4cb048983@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: 705008fbfdbe - main - fusefs: Fix warning formatting List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 705008fbfdbeff147fe624ae506f3781b5ba10bf Auto-Submitted: auto-generated The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=705008fbfdbeff147fe624ae506f3781b5ba10bf commit 705008fbfdbeff147fe624ae506f3781b5ba10bf Author: Mark Johnston AuthorDate: 2024-08-27 20:29:05 +0000 Commit: Mark Johnston CommitDate: 2024-08-27 20:29:05 +0000 fusefs: Fix warning formatting Reviewed by: asomers MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D46456 --- sys/fs/fuse/fuse_internal.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/fs/fuse/fuse_internal.c b/sys/fs/fuse/fuse_internal.c index 29d88fc942f4..11d7b2d3e9bb 100644 --- a/sys/fs/fuse/fuse_internal.c +++ b/sys/fs/fuse/fuse_internal.c @@ -282,12 +282,12 @@ fuse_internal_cache_attrs(struct vnode *vp, struct fuse_attr *attr, * dirty writes! That's a server bug. */ if (fuse_libabi_geq(data, 7, 23)) { - msg = "writeback cache incoherent!." + msg = "writeback cache incoherent! " "To prevent data corruption, disable " "the writeback cache according to your " "FUSE server's documentation."; } else { - msg = "writeback cache incoherent!." + msg = "writeback cache incoherent! " "To prevent data corruption, disable " "the writeback cache by setting " "vfs.fusefs.data_cache_mode to 0 or 1."; From nobody Tue Aug 27 20:38:05 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WtfWK6mQRz5Jt9w; Tue, 27 Aug 2024 20:38:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WtfWK64v6z4scM; Tue, 27 Aug 2024 20:38:05 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724791085; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ilro21MpfaUjEazGO5v9y7bQ8QA4pAS8j6Gv3jZ9A58=; b=e1lMxTXdCel3zOWyfNFPemXWrQpE8mLNNbQ2mAxqAgb7tz3sk8WktpT24bsJNkEYFdw/tS 7YerrXXzT2kzIRvGNEQQ39oHE0f4ELGiYUnktN4OtyjN87YiCe13FkFsDmq0BCxjNfoOpZ G7aCuE1U+Iw/LL6O//9iDFdscBx91i69fum6WCrlAEU/Q4ehMcKS24/8IRenB1ozG56vFF JxGsLlO+R4fL/IbEWg06oIRl0k9rum/MWLFauKDd6HBchqtbfcSv+efXL65q/Y1RHDu+op FmO3VC97kd59fRu1MwxMJ37OQV1o+ds5nX0ipxT48HlilO8A6vgmpZnu9o+QSw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724791085; a=rsa-sha256; cv=none; b=NJiOXWXSeNPabhSVRoS/N/tlE65V4Yg32/8eFuIzW5U+tEpDlDeJk/9toVfLrGrXs7YCc4 xvVPnzEAyfNeT3RpLUQpFHwgF6VBg8da3KjfqESlmqy+aErndszRG1QhMC8FT9ItE0s5jf Yoh4GloXKpmubkVhB95OnwNrOz0nY+waP+MDciuF++MqFFSsWD2YM3q2pda2s8FERqmKOO l/Wut0U9MF2+FdcOD0y+KbX9hUQcO8czPS2i4Zl4L1bthWxs41DPGe6cbfZmQQF9rkdfEG HhIsh/Zg0mdGaLQpYQJWArnPWBFAk7rHQ1k/qenP+gBFKAOytE00ft/PSNZ3Cg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724791085; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ilro21MpfaUjEazGO5v9y7bQ8QA4pAS8j6Gv3jZ9A58=; b=YRxLWDAWzoRJE+znXYAGOKJ1iNbPhaWiqSXX48GTenhBoXT5NNn6KPXgMLJ2/JAQiSxs5j uwbeciptBNHlcN9u6P5oQ/+0M+eCgToubNURLk5M8LSn8QBLuTO2fp78p0r/+7acEKSdPl F1mq79uiuR8fF6UTz2iWaWSizL6HjEnT7p1f1nopvwhUe6ncd6whZFY6K8iHm0SCaYR5AD o3xFagXh1jL/NwXJXEungQgsOhgxJhdu1Qa1q+bglgVEuVv6TE6i4HZ9e0bSB/7HF5zc99 gjr35NYgDlguLrk6EXTunUHqEAnieTiCEs6pL0wAo8/fwZDsy+bSAWScsaJzxg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WtfWK5gygz14Dk; Tue, 27 Aug 2024 20:38:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47RKc5H4049029; Tue, 27 Aug 2024 20:38:05 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47RKc5cn049026; Tue, 27 Aug 2024 20:38:05 GMT (envelope-from git) Date: Tue, 27 Aug 2024 20:38:05 GMT Message-Id: <202408272038.47RKc5cn049026@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: e6651546c2dd - main - rangelock: Fix an off-by-one error List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: e6651546c2dd72e028b9422f1695c432dbf47d75 Auto-Submitted: auto-generated The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=e6651546c2dd72e028b9422f1695c432dbf47d75 commit e6651546c2dd72e028b9422f1695c432dbf47d75 Author: Mark Johnston AuthorDate: 2024-08-27 20:29:18 +0000 Commit: Mark Johnston CommitDate: 2024-08-27 20:35:08 +0000 rangelock: Fix an off-by-one error A rangelock entry covers the range [start, end), so entries e1 and e2 with e1->end == e2->start do not overlap. PR: 281073 Fixes: 5badbeeaf061 ("Re-implement rangelocks part 2") Reviewed by: kib Differential Revision: https://reviews.freebsd.org/D46458 --- sys/kern/kern_rangelock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/kern/kern_rangelock.c b/sys/kern/kern_rangelock.c index e3bb413ab1bb..14163dd1c782 100644 --- a/sys/kern/kern_rangelock.c +++ b/sys/kern/kern_rangelock.c @@ -544,7 +544,7 @@ again: cur = rl_q_load(prev); MPASS(!rl_e_is_marked(cur)); /* nobody can unlock e yet */ for (;;) { - if (cur == NULL || cur->rl_q_start > e->rl_q_end) + if (cur == NULL || cur->rl_q_start >= e->rl_q_end) return (RL_LOCK_SUCCESS); next = rl_q_load(&cur->rl_q_next); if (rl_e_is_marked(next)) { From nobody Tue Aug 27 20:38:06 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WtfWM1sT5z5JtM4; Tue, 27 Aug 2024 20:38:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WtfWL6Mq9z4sgK; Tue, 27 Aug 2024 20:38:06 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724791087; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8uo5YsJ/qQZlLNQyU4W6W1I7oNlIYSuW0FfPKz7zbQk=; b=CkgTndCNcP8XFfb6Tx/eUkzSmzns5czz14/zq/oyK9dXrhU2n8BQxaeYhPBsXuJzXQqkv3 Xovb/QcBDhLSJMK8Zrhz6a3yjSfpfgm8DKOgObLIm8qsGIwDb/4GQxTBNBuJpQ57tlcbgJ rkInHRZztQol5wRER0I27rMn7xh1NpC56/R4Qp6lO/RkPdFxTfTaLS+kU+BVB7FqK5U8rd sN0USMYg+8nIixV+JSHu6ETmL+1WsV+9DU4kT6TU/GsvIkfO+Ps4HvdQ+QpOuQxr99GlJa MFRst++2E6o+MzeuddlIQOvuGKmtbu8oxmZ3sw9rMb5M87v8uy8AZ3HXw9uMPQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724791087; a=rsa-sha256; cv=none; b=MR54lxHOCp6pvFvw5ZLZwaVjUMZgpcbUSAqDHwap+k2iUfZ3JH58uuEcrhF4HVYvNcH5WK UQHCr7sZGvFeZuQBKr1FTj1u1AqVo2nt/O2sTkS2Bpv7crg9otJ0CIdZdwzivSaRiR6o1d YwDXnLtvO2FkOZ9kncv4WHrsZQoBvE9E/lv9o/m+yQlDTlSl5ILdDYtdGrJYvtcz+r4XpI uKrpgcyvMGHGaUHANcu96igF/00rbIjtYFtGShjGa+YDocDfZNkIA8sDnjrVCFsNTrpVky A8zpgHEY8Bb1M92Z8YLPGbDvfoVubaYR5+1Wbj6POKrBMMDyXEPnqj/UHIajgA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724791087; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8uo5YsJ/qQZlLNQyU4W6W1I7oNlIYSuW0FfPKz7zbQk=; b=otXmjc23DXBRNdpkfAgad02E00FLkfxptbmuYAmBKl9iL3in+Du5HqDKKJIQzFN+QqGMLI IVXS7vDYVCIT4lUD9EOQxgTDSOWVnzG8IQ3+l8UVPzuvKpkJk1Q0TUpfNMSs4dRkVwYXYW P9CckaM0mAK0BP4117qU4j4riprKqDXsOgcsgihvJ5fXboalf9U4y6k4mNzFj86/fSSiNC +C0Im8wFq920aHYVd+POBzuhWGL6CMvqqbSTcYvX9UMlJu8BKFO/sR91uNKHCuALBShfeq H5wpEA0UtaZ7+ENMf+bVcU+C+jIAnv0ZVufoHm7LJzO1w+jxwEvaXTu04F0rOg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WtfWL60NBz14ql; Tue, 27 Aug 2024 20:38:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47RKc6TD049074; Tue, 27 Aug 2024 20:38:06 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47RKc6Ga049071; Tue, 27 Aug 2024 20:38:06 GMT (envelope-from git) Date: Tue, 27 Aug 2024 20:38:06 GMT Message-Id: <202408272038.47RKc6Ga049071@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: fe66e4caf456 - main - rangelock: Disable cheat mode by default List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: fe66e4caf4561ee3349ad7a29cc9976108c3b04f Auto-Submitted: auto-generated The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=fe66e4caf4561ee3349ad7a29cc9976108c3b04f commit fe66e4caf4561ee3349ad7a29cc9976108c3b04f Author: Mark Johnston AuthorDate: 2024-08-27 20:31:25 +0000 Commit: Mark Johnston CommitDate: 2024-08-27 20:36:31 +0000 rangelock: Disable cheat mode by default Cheat mode is incompatible with code which locks multiple ranges in the same vnode, with at least one range being write-locked. This can arise in kern_copy_file_range(). Until that's handled somehow, avoid the problem to make the fusefs tests stable. PR: 281073 Fixes: 9ef425e560a9 ("rangelocks: add fast cheating mode") Reviewed by: kib Differential Revision: https://reviews.freebsd.org/D46457 --- sys/kern/kern_rangelock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/kern/kern_rangelock.c b/sys/kern/kern_rangelock.c index 14163dd1c782..38449f71a8b7 100644 --- a/sys/kern/kern_rangelock.c +++ b/sys/kern/kern_rangelock.c @@ -66,7 +66,7 @@ * trylocks are same as normal locks but do not drain. */ -static int rangelock_cheat = 1; +static int rangelock_cheat = 0; SYSCTL_INT(_debug, OID_AUTO, rangelock_cheat, CTLFLAG_RWTUN, &rangelock_cheat, 0, ""); From nobody Tue Aug 27 21:09:31 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WtgCr6JkFz5Jws4 for ; Tue, 27 Aug 2024 21:09:44 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WtgCr4Vnjz4wVS for ; Tue, 27 Aug 2024 21:09:44 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-42819654737so50880245e9.1 for ; Tue, 27 Aug 2024 14:09:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724792983; x=1725397783; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NX4IbqHfa5327H4urDGdUF5Df6RypuG+A49oO2gSCpA=; b=u0R/GFnFTEqEKBPA9xgRdg0Zmko7KG3m+EZL/BQiaScyp8Qm9BEQEHoFPOYhUEa8On 76NZrMHZhaMuhFOLIxxqp6/pVukNT0XtS4K8W/8aSqf62LmyJ3v9NgRd2IJGzlRANjmz q7qQAy+SqBxRhr+cdArY2EAXF/9VQ4RQAJxjF1zI8r5Q9HxtlEHd68eTjD71JmNM/D/V nEjEgVUm20AO+uqyqFAFf4IZqXiQ1+dA7pO3/aasLxWbEQFTjXBN7w/V5UZcKT6JMG5V 6sjxwLc3F6Kp/6A1vTY2IZr5uDEm7E+XFnipvCKB8cpac3k+s/ZdzgKa7zxo2WGbQesj iY5Q== X-Forwarded-Encrypted: i=1; AJvYcCWCMNRuR4i/JkrmWFOM6IpDfRAsk9XlX5JfTvZjS+TGCEVV2NEgLO5e91o6nhkHg+36+zKID6KpKlQU6oJ+ITzDhhSzww==@freebsd.org X-Gm-Message-State: AOJu0YwdSYjALpzwNla27vgMjg+45xZcxlRLiFdVPcvyeWjFc1hR9AEb urPk0yPq3uBuq6wapTUa41iMy85h5PBbC68iwaGCUdK3PQJhsduTgTtmUzAecjw= X-Google-Smtp-Source: AGHT+IFOFGcAcKayBRN3Rmt/3D4+0jlq7VbvU3Y47mQM9pQGHeX775vuhvB9DToR/FUSwGuWQwRqKg== X-Received: by 2002:a05:600c:3514:b0:426:51dc:f6cd with SMTP id 5b1f17b1804b1-42acd57a01dmr108122495e9.18.1724792982617; Tue, 27 Aug 2024 14:09:42 -0700 (PDT) Received: from smtpclient.apple ([131.111.5.201]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42abed8b86bsm234115435e9.4.2024.08.27.14.09.41 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Aug 2024 14:09:41 -0700 (PDT) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51\)) Subject: Re: git: fe66e4caf456 - main - rangelock: Disable cheat mode by default From: Jessica Clarke In-Reply-To: <202408272038.47RKc6Ga049071@gitrepo.freebsd.org> Date: Tue, 27 Aug 2024 22:09:31 +0100 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <9CF133C9-42AD-41EE-961E-FBD76DD5F592@freebsd.org> References: <202408272038.47RKc6Ga049071@gitrepo.freebsd.org> To: Mark Johnston X-Mailer: Apple Mail (2.3776.700.51) X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Queue-Id: 4WtgCr4Vnjz4wVS On 27 Aug 2024, at 21:38, Mark Johnston wrote: >=20 > The branch main has been updated by markj: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3Dfe66e4caf4561ee3349ad7a29cc99761= 08c3b04f >=20 > commit fe66e4caf4561ee3349ad7a29cc9976108c3b04f > Author: Mark Johnston > AuthorDate: 2024-08-27 20:31:25 +0000 > Commit: Mark Johnston > CommitDate: 2024-08-27 20:36:31 +0000 >=20 > rangelock: Disable cheat mode by default >=20 > Cheat mode is incompatible with code which locks multiple ranges in = the > same vnode, with at least one range being write-locked. This can = arise > in kern_copy_file_range(). Until that's handled somehow, avoid the > problem to make the fusefs tests stable. >=20 > PR: 281073 > Fixes: 9ef425e560a9 ("rangelocks: add fast cheating mode") > Reviewed by: kib > Differential Revision: https://reviews.freebsd.org/D46457 > --- > sys/kern/kern_rangelock.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/sys/kern/kern_rangelock.c b/sys/kern/kern_rangelock.c > index 14163dd1c782..38449f71a8b7 100644 > --- a/sys/kern/kern_rangelock.c > +++ b/sys/kern/kern_rangelock.c > @@ -66,7 +66,7 @@ > * trylocks are same as normal locks but do not drain. > */ >=20 > -static int rangelock_cheat =3D 1; > +static int rangelock_cheat =3D 0; This probably deserves a comment for why it=E2=80=99s disabled/the risks = of enabling it, and/or some text in the sysctl description? Jess > SYSCTL_INT(_debug, OID_AUTO, rangelock_cheat, CTLFLAG_RWTUN, > &rangelock_cheat, 0, > ""); From nobody Tue Aug 27 21:20:43 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WtgSW1spRz5MQcr; Tue, 27 Aug 2024 21:20:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WtgSW1Mnqz4xb2; Tue, 27 Aug 2024 21:20:43 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724793643; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/g11u6OMdWW/u2Q8fs3VO15PwFSys9Rupj+T6n+lOxQ=; b=ZN+rom4WGQ9pFIUgGQvZG//ltddD7S/d3mIppxzB2NrVLW6GY3J7eZFE/N3FOaG+4tmmlb Zdm5Vr23lv4WorlUx/VvgC2R3VW9RsNd7tTX/9VEYnySGHzJaTS+1yXKVwZFPogYk739KH hfC/0KObX7piEvAWS+xWfEp57H9JgorReNjEtKw/Oq3bEo6/KXRYSDwLPg1jziyvI2h+Xq u4IV/Tqxd9sr3oACgLT9bM1acx2j0Mx/gvdaPhq2h7cboFUyk15omhQN6DYkmEiUXBojTg 16qhBaEEQT+HfYdyOUFBD1SSXyVE3IiD0Foid28lB/Y9iiUfbrnMcBYDw9eLMA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724793643; a=rsa-sha256; cv=none; b=D7N5jAjHIpuT7N247aAatLrcQizhqPs+gkerGR9vwkft/dzewpQMSjzfiNJBPA7W0E725c bXvwoZQY3v45lxZMXLF+BC10jFWZMuoha/0jhndgEMrtF6sz7ER4RcxqfUqI030LuMu9OE wpsFZE6LmzOlg7IaKuCcoD2QdG1w++++oYkJS8+aScIvjFo8t3600MnK8Je7FL6jfRm2QH tZx7sjP5+fratab/BeObGSx8/HcN8IUmgykQxYJxftI+N4GA2DBSUFbFxnYAtY45xY+/PU lqDHRklvzY67LBdEnxdC4Wt4ef0rKBlJt6133833gzIzQShyx4o8GMw+34Ymug== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724793643; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/g11u6OMdWW/u2Q8fs3VO15PwFSys9Rupj+T6n+lOxQ=; b=ZKxAZYI5qL3Jn7uQ39UiEFDmXFIbvF/prRJv1TSfV3cAJ5DztxXZTAa5Z/LgoJjcOQMGi/ RPpabtFOaeA4Jly1nx1l27pmKKrTKB8j6JCxrCVDLPnm+do2Ic6vTxPURY7cmnRTrCVVE9 rTgSIjoLOU1Iva7jMKMJKOBdYtkRjQ/W4pFz0KgZYBHCkrXvnjTCwP+EshOvPMgPMMSTZk y4J+ON/OjOKB/01dtlCUmswOfwVLQ4q0xLh3d1XItjL8QX9G5bR8EPN9N1n3lgIHud+0af XKnt8hs+pQ6jvV9X8TcnX/cXyNtrCzIsIxG3cK6CPAxAw2J4YtSQOVtlGeMj+w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WtgSW0zG6z15m4; Tue, 27 Aug 2024 21:20:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47RLKh0t027363; Tue, 27 Aug 2024 21:20:43 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47RLKhBV027330; Tue, 27 Aug 2024 21:20:43 GMT (envelope-from git) Date: Tue, 27 Aug 2024 21:20:43 GMT Message-Id: <202408272120.47RLKhBV027330@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Rick Macklem Subject: git: 5037c6398b23 - main - nfsd: Fix handling of NFSv4 setable attributes List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: rmacklem X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 5037c6398b2327366494a0434a894dc17ba8d023 Auto-Submitted: auto-generated The branch main has been updated by rmacklem: URL: https://cgit.FreeBSD.org/src/commit/?id=5037c6398b2327366494a0434a894dc17ba8d023 commit 5037c6398b2327366494a0434a894dc17ba8d023 Author: Rick Macklem AuthorDate: 2024-08-27 21:19:33 +0000 Commit: Rick Macklem CommitDate: 2024-08-27 21:19:33 +0000 nfsd: Fix handling of NFSv4 setable attributes Commit d8a5961 made a change to nfsv4_sattr() that broke parsing of the setable attributes for a NFSv4 SETATTR. (It broke out of the code by setting "error" and returning right away, instead of noting the error in nd_repstat and allowing parsing of the attributes to continue.) By returning prematurely, it was possible for SETATTR to return the error, but with a bogus set of attribute bits set, since "retbits" had not yet been set to all zeros. (I am not sure if any client could be affected by this bug. The patch was done for a failure case detected by a pynfs test suite and not an actual client.) While here, the patch also fixes a few cases where the value of attributes gets set for attributes after an error has been set in nd_repstat. This would not really break the protocol, since a SETATTR is allowed to set some attributes and still return an failure, but should not really be done. MFC after: 2 weeks --- sys/fs/nfsserver/nfs_nfsdport.c | 74 ++++++++++++++++++++++++----------------- sys/fs/nfsserver/nfs_nfsdserv.c | 2 +- 2 files changed, 44 insertions(+), 32 deletions(-) diff --git a/sys/fs/nfsserver/nfs_nfsdport.c b/sys/fs/nfsserver/nfs_nfsdport.c index 12592d4c5c59..8a2a39052506 100644 --- a/sys/fs/nfsserver/nfs_nfsdport.c +++ b/sys/fs/nfsserver/nfs_nfsdport.c @@ -3026,6 +3026,8 @@ nfsv4_sattr(struct nfsrv_descript *nd, vnode_t vp, struct nfsvattr *nvap, /* * Loop around getting the setable attributes. If an unsupported * one is found, set nd_repstat == NFSERR_ATTRNOTSUPP and return. + * Once nd_repstat != 0, do not set the attribute value, but keep + * parsing the attribute(s). */ if (retnotsup) { nd->nd_repstat = NFSERR_ATTRNOTSUPP; @@ -3043,12 +3045,13 @@ nfsv4_sattr(struct nfsrv_descript *nd, vnode_t vp, struct nfsvattr *nvap, switch (bitpos) { case NFSATTRBIT_SIZE: NFSM_DISSECT(tl, u_int32_t *, NFSX_HYPER); - if (vp != NULL && vp->v_type != VREG) { - error = (vp->v_type == VDIR) ? NFSERR_ISDIR : - NFSERR_INVAL; - goto nfsmout; + if (!nd->nd_repstat) { + if (vp != NULL && vp->v_type != VREG) + nd->nd_repstat = (vp->v_type == VDIR) ? + NFSERR_ISDIR : NFSERR_INVAL; + else + nvap->na_size = fxdr_hyper(tl); } - nvap->na_size = fxdr_hyper(tl); attrsum += NFSX_HYPER; break; case NFSATTRBIT_ACL: @@ -3085,7 +3088,8 @@ nfsv4_sattr(struct nfsrv_descript *nd, vnode_t vp, struct nfsvattr *nvap, case NFSATTRBIT_MODE: moderet = NFSERR_INVAL; /* Can't do MODESETMASKED. */ NFSM_DISSECT(tl, u_int32_t *, NFSX_UNSIGNED); - nvap->na_mode = nfstov_mode(*tl); + if (!nd->nd_repstat) + nvap->na_mode = nfstov_mode(*tl); attrsum += NFSX_UNSIGNED; break; case NFSATTRBIT_OWNER: @@ -3153,10 +3157,11 @@ nfsv4_sattr(struct nfsrv_descript *nd, vnode_t vp, struct nfsvattr *nvap, attrsum += NFSX_UNSIGNED; if (fxdr_unsigned(int, *tl)==NFSV4SATTRTIME_TOCLIENT) { NFSM_DISSECT(tl, u_int32_t *, NFSX_V4TIME); - fxdr_nfsv4time(tl, &nvap->na_atime); + if (!nd->nd_repstat) + fxdr_nfsv4time(tl, &nvap->na_atime); toclient = 1; attrsum += NFSX_V4TIME; - } else { + } else if (!nd->nd_repstat) { vfs_timestamp(&nvap->na_atime); nvap->na_vaflags |= VA_UTIMES_NULL; } @@ -3169,7 +3174,8 @@ nfsv4_sattr(struct nfsrv_descript *nd, vnode_t vp, struct nfsvattr *nvap, break; case NFSATTRBIT_TIMECREATE: NFSM_DISSECT(tl, u_int32_t *, NFSX_V4TIME); - fxdr_nfsv4time(tl, &nvap->na_btime); + if (!nd->nd_repstat) + fxdr_nfsv4time(tl, &nvap->na_btime); attrsum += NFSX_V4TIME; break; case NFSATTRBIT_TIMEMODIFYSET: @@ -3177,10 +3183,11 @@ nfsv4_sattr(struct nfsrv_descript *nd, vnode_t vp, struct nfsvattr *nvap, attrsum += NFSX_UNSIGNED; if (fxdr_unsigned(int, *tl)==NFSV4SATTRTIME_TOCLIENT) { NFSM_DISSECT(tl, u_int32_t *, NFSX_V4TIME); - fxdr_nfsv4time(tl, &nvap->na_mtime); + if (!nd->nd_repstat) + fxdr_nfsv4time(tl, &nvap->na_mtime); nvap->na_vaflags &= ~VA_UTIMES_NULL; attrsum += NFSX_V4TIME; - } else { + } else if (!nd->nd_repstat) { vfs_timestamp(&nvap->na_mtime); if (!toclient) nvap->na_vaflags |= VA_UTIMES_NULL; @@ -3198,18 +3205,21 @@ nfsv4_sattr(struct nfsrv_descript *nd, vnode_t vp, struct nfsvattr *nvap, * specified and this attribute cannot be done in the * same Setattr operation. */ - if ((nd->nd_flag & ND_NFSV41) == 0) - nd->nd_repstat = NFSERR_ATTRNOTSUPP; - else if ((mode & ~07777) != 0 || (mask & ~07777) != 0 || - vp == NULL) - nd->nd_repstat = NFSERR_INVAL; - else if (moderet == 0) - moderet = VOP_GETATTR(vp, &va, nd->nd_cred); - if (moderet == 0) - nvap->na_mode = (mode & mask) | - (va.va_mode & ~mask); - else - nd->nd_repstat = moderet; + if (!nd->nd_repstat) { + if ((nd->nd_flag & ND_NFSV41) == 0) + nd->nd_repstat = NFSERR_ATTRNOTSUPP; + else if ((mode & ~07777) != 0 || + (mask & ~07777) != 0 || vp == NULL) + nd->nd_repstat = NFSERR_INVAL; + else if (moderet == 0) + moderet = VOP_GETATTR(vp, &va, + nd->nd_cred); + if (moderet == 0) + nvap->na_mode = (mode & mask) | + (va.va_mode & ~mask); + else + nd->nd_repstat = moderet; + } attrsum += 2 * NFSX_UNSIGNED; break; case NFSATTRBIT_MODEUMASK: @@ -3220,13 +3230,15 @@ nfsv4_sattr(struct nfsrv_descript *nd, vnode_t vp, struct nfsvattr *nvap, * If moderet != 0, mode has already been done. * If vp != NULL, this is not a file object creation. */ - if ((nd->nd_flag & ND_NFSV42) == 0) - nd->nd_repstat = NFSERR_ATTRNOTSUPP; - else if ((mask & ~0777) != 0 || vp != NULL || - moderet != 0) - nd->nd_repstat = NFSERR_INVAL; - else - nvap->na_mode = (mode & ~mask); + if (!nd->nd_repstat) { + if ((nd->nd_flag & ND_NFSV42) == 0) + nd->nd_repstat = NFSERR_ATTRNOTSUPP; + else if ((mask & ~0777) != 0 || vp != NULL || + moderet != 0) + nd->nd_repstat = NFSERR_INVAL; + else + nvap->na_mode = (mode & ~mask); + } attrsum += 2 * NFSX_UNSIGNED; break; default: @@ -3241,7 +3253,7 @@ nfsv4_sattr(struct nfsrv_descript *nd, vnode_t vp, struct nfsvattr *nvap, /* * some clients pad the attrlist, so we need to skip over the - * padding. + * padding. This also skips over unparsed non-supported attributes. */ if (attrsum > attrsize) { error = NFSERR_BADXDR; diff --git a/sys/fs/nfsserver/nfs_nfsdserv.c b/sys/fs/nfsserver/nfs_nfsdserv.c index 47e3a20390f4..a38ef3d47946 100644 --- a/sys/fs/nfsserver/nfs_nfsdserv.c +++ b/sys/fs/nfsserver/nfs_nfsdserv.c @@ -375,6 +375,7 @@ nfsrvd_setattr(struct nfsrv_descript *nd, __unused int isdgram, NFSACL_T *aclp = NULL; struct thread *p = curthread; + NFSZERO_ATTRBIT(&retbits); if (nd->nd_repstat) { nfsrv_wcc(nd, preat_ret, &nva2, postat_ret, &nva); goto out; @@ -402,7 +403,6 @@ nfsrvd_setattr(struct nfsrv_descript *nd, __unused int isdgram, goto nfsmout; /* For NFSv4, only va_uid is used from nva2. */ - NFSZERO_ATTRBIT(&retbits); NFSSETBIT_ATTRBIT(&retbits, NFSATTRBIT_OWNER); preat_ret = nfsvno_getattr(vp, &nva2, nd, p, 1, &retbits); if (!nd->nd_repstat) From nobody Tue Aug 27 22:09:53 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WthYF5t6Kz5MV6p; Tue, 27 Aug 2024 22:09:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WthYF5Lhrz55b2; Tue, 27 Aug 2024 22:09:53 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724796593; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vUBDg5VrMmL2kgLogBJfqmSqVRItUs/fs6iNMbwjsnw=; b=Q5GFt23NRMq4NryWSWCUWR4SqbDF7CCPWr6+FK372FGwhai4XIX91Dp5Vri4j/xdeECM+a BZPfENsp66GZlyv2H/vnsUIgNRXMEJrelrzxjmxwkZBSv0b5gIkdJWT4Y1UeuOUvIYJtTx Tgrhm3MZhwb4C0RZxEFrAVrYmbDopP7vhUVoswxBfEJPeEJ8ev6BAyiKC9xM4j1YK5JZ6x ERISbf1sdAMC6hpNwO/KClf4qQS6I4cXYpUjYd2W8TcRw4nNQHquFTmjocqPmFM2AoDoUa J5Vi6VE0ZFL/3fXTYLTUojwYydV+0aiercH5gjIhNOIuDMSUBkxuhGozJUSfbQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724796593; a=rsa-sha256; cv=none; b=Pyty96PqgQXGFCvsW4aoRFWFgsC94j0stsHRRcAQ7isqvCV23rPTeHWgOWXbhKhwmGi4Ds ooLrGEDpR25A1G5yM/wQ7RBPP5Sh51IFm0w8XAyjF3DGY3hOlgfv/QsGWeeagrfP23Ftzo vkB1MwynGpFUdBsjOomz5MEcE4S1dGTN3zAewYrOA0pUy+rGWW7Sl85fUS3egeIp+/7cQk iqc667IklFu1+AU6iMQ2uGoYXR7h24GaSHRO58jyJv1KY3Q9cdUEgdsrO/lMj6ezEy34dE zfFD6YcoVttEq7KlTgNPZGolBLjF7+qJHksJo6Z2/N47g92wnKreMaUYe5hGfQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724796593; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vUBDg5VrMmL2kgLogBJfqmSqVRItUs/fs6iNMbwjsnw=; b=ZLpA+Q9EeMJBhvwN6hDO2pNb1sAqGsuYI8eZdHjH97M9ePqG8tnQf6mM2bHgbf85uYdItV BeeLOiohhckh1nnrx0eAiUwJ2S2gmOaK8pBy1YLpR+J12MqRDJRyfH9zedPvE17DjCSUVJ bT4l3O2kc/szMDSiA+7Lj6wvc78jOwxcl0IkllEJt1JgA/SBFe3aJcn51koph7epwrL5PC 1ClMqD75XqNFvntgH9zarLSaC6NWiMbY4Uzk0q3b+UkGLqQFFDD/xAvYARsY3hxTeqJhR+ hNgGvJ4zs9VYC8Sq4IP6kVQy3UW94wETmqxEJhgtjWR8pc4nQeSYRVkAk+PYrQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WthYF4y3Qz172P; Tue, 27 Aug 2024 22:09:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47RM9r1l002770; Tue, 27 Aug 2024 22:09:53 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47RM9rVX002767; Tue, 27 Aug 2024 22:09:53 GMT (envelope-from git) Date: Tue, 27 Aug 2024 22:09:53 GMT Message-Id: <202408272209.47RM9rVX002767@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: f5a37f8dd319 - main - open(2): mandoc -T lint List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: f5a37f8dd319e3007b126b77376e61ad96f44d8b Auto-Submitted: auto-generated The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=f5a37f8dd319e3007b126b77376e61ad96f44d8b commit f5a37f8dd319e3007b126b77376e61ad96f44d8b Author: Jose Luis Duran AuthorDate: 2024-08-27 03:48:09 +0000 Commit: Konstantin Belousov CommitDate: 2024-08-27 22:09:33 +0000 open(2): mandoc -T lint Lint the manual, addressing almost all requests. Differential revision: https://reviews.freebsd.org/D46450 MFC after: 1 week --- lib/libsys/open.2 | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/lib/libsys/open.2 b/lib/libsys/open.2 index be164aae1834..220561cc5683 100644 --- a/lib/libsys/open.2 +++ b/lib/libsys/open.2 @@ -252,7 +252,7 @@ controlling terminal when it opens a tty device. This is the default on .Fx , but is present for -.Tn POSIX +POSIX compatibility. The .Fn open @@ -265,7 +265,7 @@ initially opening a TTY. This is the default on .Fx , but is present for -.Tn POSIX +POSIX compatibility. The initial call to .Fn open @@ -384,7 +384,7 @@ The file pointer used to mark the current position within the file is set to the beginning of the file. .Pp If a sleeping open of a device node from -.Xr devfs 4 +.Xr devfs 5 is interrupted by a signal, the call always fails with .Er EINTR , even if the @@ -487,7 +487,7 @@ The system file table is full. .It Bq Er EMLINK .Dv O_NOFOLLOW was specified and the target is a symbolic link. -.Tn POSIX +POSIX specifies a different error for this case; see the note in .Sx STANDARDS below. @@ -661,7 +661,7 @@ to .Er EMLINK instead of .Er ELOOP as specified by -.Tn POSIX +POSIX when .Dv O_NOFOLLOW is set in flags and the final component of pathname is a symbolic link @@ -679,7 +679,10 @@ permits searches. The present implementation of the .Fa openat system call is believed to be compatible with -.St -p1003.1-2017 , +.\" .St -p1003.1-2017 , +.\" XXX: This should be replaced in the future when an appropriate argument to +.\" the St macro is available: -p1003.1-2017 +.No IEEE Std 1003.1-2008, 2017 Edition (\\(LqPOSIX.1\\(Rq) , which specifies that behavior for .Dv O_SEARCH , in the absence of the flag the implementation checks the current From nobody Tue Aug 27 22:09:54 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WthYH0zs8z5MTtr; Tue, 27 Aug 2024 22:09:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WthYG6JD1z55Xt; Tue, 27 Aug 2024 22:09:54 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724796594; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=cP7cvvzOjFmWGVn/AHMoGj+GkeHBPVdISuSS69FlU60=; b=fpFBR4tb5CuBacARdqxUF07qCFlIpuY4buykZcZmoCdv888dE5hVvJBy5YM3XmHm2D1uPj J3ITeOrBinD6sGNMWGNEqegFOtqGWaZXBwNa6Ir3jSQsK4BFGd3Eqf5MwxR5xMuR9DxR9T nQ/e+G25L7d8F5VC/enSOkuhp2mX/t3Xb2dGa5HhBdBrVBrh/faX6KZGiPUczJCVD+7gJp WKkFdzbf/sDyE2BWKSreC4UiPLAHMz+2YCfmGS3jrn5CGbrJPI2J2aDBBnKUbdCEevYvvV vKhSSCGOE2JRJlhxdhazojaDWc3zBstNVypJliIGwTcV3egCUD5hcsbikCEoXA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724796594; a=rsa-sha256; cv=none; b=MezbnKUDTvdb70KrBw2sKTisNlZxnH6MX0WM8FWu+lCAo0KmgCg/341ozf6pFDhRsxB1fK jgHxqHViUmbxziNTgLi40Era0fcihdL3dlqr1UizqlYuDjBQjC5ODGyKz5QjQKxKY6EuJI TRIYDLIIXkqSbM8vNgYTZ6EB1Hh5egKhpd85ADPerSIytxTQS/F9F/cJ5U5phqDPRRPJ2G U359hqWJiVAigQXehLsdf5k6q/7Q2bfLzvBB2gdYBjiKX2Akv/CckpqLvrN3LmQ54ph+Bw EG71DCKEc0qfmELrh1Tq0JOUeeojEWV2NR7uavL13wbQkdh6qlJUOkCn6JHDDw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724796594; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=cP7cvvzOjFmWGVn/AHMoGj+GkeHBPVdISuSS69FlU60=; b=QrUB/K7qQuwuMLlFZH7FzqBKz8qOwUWbL23Y7t9uLYEamkNqUw/ZJBQH/yPOc7wdED8S8X 4BnMeXOimA/vWlnHIblvUdUYT8FiBnvMWum1MCiIvkjRdIQDXNBjGIRt81MgsnDaw+N+iQ VO5ozQF2sCsKpU0N32DGwgQkaPwRc8MJdU+cvF0UTaR/QXREyguKFOAf+u7sRQVOBOHOOe br3domDRymqPyu9TS+1j+8YrQmBgDVFHzVb8qo4mM5LP3x27IXy++5Ma6PbwVOSJRM/+Hj wJFP6PK5yTVWuHkUMnAM1rukh3XvKVgDJ6LtqhmtiDqlTsIs9Ncm0HKKLYvUZA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WthYG5vysz172Q; Tue, 27 Aug 2024 22:09:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47RM9stK002809; Tue, 27 Aug 2024 22:09:54 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47RM9sAu002806; Tue, 27 Aug 2024 22:09:54 GMT (envelope-from git) Date: Tue, 27 Aug 2024 22:09:54 GMT Message-Id: <202408272209.47RM9sAu002806@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: 33f58ac0795b - main - rename(2): Extend EINVAL's description List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 33f58ac0795b2b02593ad0a8bf8a1ea24c1dc5e1 Auto-Submitted: auto-generated The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=33f58ac0795b2b02593ad0a8bf8a1ea24c1dc5e1 commit 33f58ac0795b2b02593ad0a8bf8a1ea24c1dc5e1 Author: Jose Luis Duran AuthorDate: 2024-08-26 01:32:14 +0000 Commit: Konstantin Belousov CommitDate: 2024-08-27 22:09:33 +0000 rename(2): Extend EINVAL's description On some file systems, the last component of the destination path can contain invalid characters and return EINVAL. PR: 281033 Differential revision: https://reviews.freebsd.org/D46450 MFC after: 1 week --- lib/libsys/rename.2 | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/libsys/rename.2 b/lib/libsys/rename.2 index f792c8a3dc7b..4faba81ff509 100644 --- a/lib/libsys/rename.2 +++ b/lib/libsys/rename.2 @@ -25,7 +25,7 @@ .\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF .\" SUCH DAMAGE. .\" -.Dd March 30, 2020 +.Dd August 25, 2024 .Dt RENAME 2 .Os .Sh NAME @@ -255,6 +255,10 @@ or an attempt is made to rename .Ql .\& or .Ql \&.. . +.It Bq Er EINVAL +The last component of the +.Fa to +path is invalid on the target file system. .It Bq Er ENOTEMPTY The .Fa to From nobody Tue Aug 27 22:09:55 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WthYJ64y1z5MTpB; Tue, 27 Aug 2024 22:09:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WthYJ0Lq9z55VT; Tue, 27 Aug 2024 22:09:56 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724796596; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=U4IY0aUQzx6RhDxXJwKgRJvTyKjLgHMSu9egT/us5SU=; b=Ks+rKNqzlfASaXc89f5pzgZyvWct8KvbanPlrN3ZQTpGCUNPgAxOQF+/SVZkTljN2Pw3ip 73PB9nOAPwHHaD0VgMfdLicBIBu8uJK9Knieb8oTv3AMiX3YlbaRlvt78P6ReYtvlrEFHe 5/C59LX1PJWQ8b7mwKrevK5XEChPRGSK5e/sJSzXoFC6a/E8hJTzeH9L/L9PB+P0ir4g8y DmbysLUdlltpMLsz54nKOznOEqfKjOr480XZ6WRwdAuLW2FOK5tbdgr4Eyx2qlqjrz1RhS pSEholqL57QerZ6hA0YBL0s3YA/pLjdIEDxpG1XTWTn0r0BQs8h0tNZBEh3Gxg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724796596; a=rsa-sha256; cv=none; b=J3pADerUAH7k7WB6Z57yyu19mh5yZkCBr0Tmrv3NsFskhX/nQ5g6j2VmGMpUZQficDhM+P od+dWkEK5V4aPwoY0zgBu5CPF+2MxJyWQc/+3uH501a/AnjuS2M0cCzuLZkjGZYa0Elf5n B62Fkjlw3cNMjxYxC22gdf3+we03ApV5EF7PMjg60Jj8zwmOTZijDoGwYfzehvqrwTNhCs p8PVXSmpsYRoRF4MCO4zS1D/WsCq2POqOisfcpZWALvc7kqACxrsgUrprT4nYg3Mk+7AJJ tjOgzz4x7hsC8n+MhrEfpaIwmB3s8iArvuQ25lRpyB+IGjz9rLpzrDHNSJdLoA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724796596; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=U4IY0aUQzx6RhDxXJwKgRJvTyKjLgHMSu9egT/us5SU=; b=JK5jK3XwOdb9C0VUI5JFxMbefox8I4Y78+m9FlrmPVbxpFEvUufMRCXJkErYP0ir1UYqgb ifBDNSzlrnAkpdHQiTrJiI7RCEqGr9JOOAYlIFEo5cNEegHYayzLdQ5LinwoOvOt7O0tht sxunppIWeIaGof3rdUKU8BBPRnsRd0ltzU6f214vtw2FUW/R1o7b+Ixm4Q4n3nu0TwB+2T tFvUInRrd2dS9lLNILits6lcg9mWAH2onNDqAVF7hdmLr1QN1M9YnWwRsGs7H5bc+dcCet mPxDvihH/xaOMRHOKjZLgwUjx5UNw6DX9L7IVBWP57s4OLpnhT7pwlU4K9hCEQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WthYH6tyVz16qM; Tue, 27 Aug 2024 22:09:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47RM9tTj002848; Tue, 27 Aug 2024 22:09:55 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47RM9tJp002845; Tue, 27 Aug 2024 22:09:55 GMT (envelope-from git) Date: Tue, 27 Aug 2024 22:09:55 GMT Message-Id: <202408272209.47RM9tJp002845@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: 02c23c3b5ac9 - main - open(2): Extend EINVAL's description List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 02c23c3b5ac9c9c1115c8b892034bb5d67b05c06 Auto-Submitted: auto-generated The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=02c23c3b5ac9c9c1115c8b892034bb5d67b05c06 commit 02c23c3b5ac9c9c1115c8b892034bb5d67b05c06 Author: Jose Luis Duran AuthorDate: 2024-08-27 02:23:14 +0000 Commit: Konstantin Belousov CommitDate: 2024-08-27 22:09:33 +0000 open(2): Extend EINVAL's description If O_CREAT is specified, the last component of the path argument can contain invalid characters, and return EINVAL on some file systems. PR: 281033 Differential revision: https://reviews.freebsd.org/D46450 MFC after: 1 week --- lib/libsys/open.2 | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/lib/libsys/open.2 b/lib/libsys/open.2 index 220561cc5683..4cdceb336532 100644 --- a/lib/libsys/open.2 +++ b/lib/libsys/open.2 @@ -25,7 +25,7 @@ .\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF .\" SUCH DAMAGE. .\" -.Dd January 29, 2024 +.Dd August 25, 2024 .Dt OPEN 2 .Os .Sh NAME @@ -580,6 +580,12 @@ and .Dv O_EXEC or .Dv O_SEARCH . +.It Bq Er EINVAL +.Dv O_CREAT +is specified, +and the last component of the +.Fa path +argument is invalid on the file system on which the file is being created. .It Bq Er EBADF The .Fa path From nobody Tue Aug 27 22:12:48 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Wthct0m15z5MVBk; Tue, 27 Aug 2024 22:13:02 +0000 (UTC) (envelope-from yuri@aetern.org) Received: from fhigh6-smtp.messagingengine.com (fhigh6-smtp.messagingengine.com [103.168.172.157]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Wthcs64pgz56mF; Tue, 27 Aug 2024 22:13:01 +0000 (UTC) (envelope-from yuri@aetern.org) Authentication-Results: mx1.freebsd.org; none Received: from phl-compute-05.internal (phl-compute-05.nyi.internal [10.202.2.45]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 4A6521151AD5; Tue, 27 Aug 2024 18:12:56 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-05.internal (MEProxy); Tue, 27 Aug 2024 18:12:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aetern.org; h=cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1724796776; x=1724883176; bh=AduXSrGEkOPWxvHQ6zaxiMvzMd4dYF8k/wQGJ/ztaTQ=; b= LsPQ1teRyjrLbNPBTFzrWjBfxXBY0M+Woi0v6RH0Z0y4Wc9xfcphPEqjO02m4IBL ofPg79jslRyiRjzIWiTbDmoOxN4mM93PslpDzoM4GbWAGPs8p8Z5cu9+cYAnsOV6 J0dw84OrzacFl8+CHwz9RXkrDUlMQX7BRLNcSujIEk8bN5i0wvXTroeigNkxa5ud kDVvXS2o0mNW2Tnq/XLp2tpH8EPWKk7/5cXDpWSKwowzAjj/Ml6J0D1FMeCWBrAN ENUtiAeFAhWtSi82rKJ/KOOPhD0eUrOBnu+dC5PJQWq9GsAnvrTLQuQHSuLou9cf x607rpnWOHzGsRc3KWBg7Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1724796776; x= 1724883176; bh=AduXSrGEkOPWxvHQ6zaxiMvzMd4dYF8k/wQGJ/ztaTQ=; b=D UKZpwrwCdfGT3Ht92nLiBYlqHqbSP0Y1Ss6WbBAO1IonPYBwDKfs4qSJ/g5iM+Gz isdbYy9u2KvJSOsHAyBJBj1WUgt4mAAj/9isNYuQNcAVqPlwPWa4NBEtdowHKl01 o4Bh/Si04eL+nkc3REdQf2DepqXLpq0am7+kX0XqDJ46k63J3D3laQzmojeKrvUJ LMJxESBOgiSzQCuZ+/aJB/rLynwJcgAwSWIseOeN9YsAuDjlAGq1FSY9WuNxsteR 5pxPLIVlW5yWFV1PGd79/wwv5nPvX8Em35GzzfjaAGqzEaEr6lOy9tXvp05rq5A+ QhT5EAAwlglGbytZhV9IA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudefuddgtdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucenucfjughrpefkffggfg fuvfhfhfgjtgfgsehtjeertddtvdejnecuhfhrohhmpegjuhhrihcurfgrnhhkohhvuceo hihurhhisegrvghtvghrnhdrohhrgheqnecuggftrfgrthhtvghrnhepuddvvefhkeegte fggfekleelheeuvedvkeeljeekgfevjeevtdeuhefhveffteeknecuffhomhgrihhnpehf rhgvvggsshgurdhorhhgpdduqddvtddujedrgiiggidpuddqvddtudejrdhnohenucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpeihuhhrihesrggv thgvrhhnrdhorhhgpdhnsggprhgtphhtthhopeegpdhmohguvgepshhmthhpohhuthdprh gtphhtthhopehkihgssehfrhgvvggsshgurdhorhhgpdhrtghpthhtohepshhrtgdqtgho mhhmihhtthgvrhhssehfrhgvvggsshgurdhorhhgpdhrtghpthhtohepuggvvhdqtghomh hmihhtshdqshhrtgdqrghllhesfhhrvggvsghsugdrohhrghdprhgtphhtthhopeguvghv qdgtohhmmhhithhsqdhsrhgtqdhmrghinhesfhhrvggvsghsugdrohhrgh X-ME-Proxy: Feedback-ID: i0d79475b:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 27 Aug 2024 18:12:54 -0400 (EDT) Message-ID: <8bb9edf4-e0f4-4cfb-8b76-4c132a9abd5a@aetern.org> Date: Wed, 28 Aug 2024 05:12:48 +0700 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: f5a37f8dd319 - main - open(2): mandoc -T lint To: Konstantin Belousov , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202408272209.47RM9rVX002767@gitrepo.freebsd.org> Content-Language: en-US From: Yuri Pankov In-Reply-To: <202408272209.47RM9rVX002767@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:209242, ipnet:103.168.172.0/24, country:US] X-Rspamd-Queue-Id: 4Wthcs64pgz56mF Konstantin Belousov wrote: > The branch main has been updated by kib: > > URL: https://cgit.FreeBSD.org/src/commit/?id=f5a37f8dd319e3007b126b77376e61ad96f44d8b > > commit f5a37f8dd319e3007b126b77376e61ad96f44d8b > Author: Jose Luis Duran > AuthorDate: 2024-08-27 03:48:09 +0000 > Commit: Konstantin Belousov > CommitDate: 2024-08-27 22:09:33 +0000 > > open(2): mandoc -T lint > > Lint the manual, addressing almost all requests. > > Differential revision: https://reviews.freebsd.org/D46450 > MFC after: 1 week > --- > lib/libsys/open.2 | 15 +++++++++------ > 1 file changed, 9 insertions(+), 6 deletions(-) > > diff --git a/lib/libsys/open.2 b/lib/libsys/open.2 > index be164aae1834..220561cc5683 100644 > --- a/lib/libsys/open.2 > +++ b/lib/libsys/open.2 > @@ -252,7 +252,7 @@ controlling terminal when it opens a tty device. > This is the default on > .Fx , > but is present for > -.Tn POSIX > +POSIX > compatibility. > The > .Fn open > @@ -265,7 +265,7 @@ initially opening a TTY. > This is the default on > .Fx , > but is present for > -.Tn POSIX > +POSIX > compatibility. > The initial call to > .Fn open > @@ -384,7 +384,7 @@ The file pointer used to mark the current position within the > file is set to the beginning of the file. > .Pp > If a sleeping open of a device node from > -.Xr devfs 4 > +.Xr devfs 5 This looks wrong, we now have fs man pages in section 4. > is interrupted by a signal, the call always fails with > .Er EINTR , > even if the > @@ -487,7 +487,7 @@ The system file table is full. > .It Bq Er EMLINK > .Dv O_NOFOLLOW > was specified and the target is a symbolic link. > -.Tn POSIX > +POSIX > specifies a different error for this case; see the note in > .Sx STANDARDS > below. > @@ -661,7 +661,7 @@ to > .Er EMLINK instead of > .Er ELOOP > as specified by > -.Tn POSIX > +POSIX > when > .Dv O_NOFOLLOW > is set in flags and the final component of pathname is a symbolic link > @@ -679,7 +679,10 @@ permits searches. > The present implementation of the > .Fa openat > system call is believed to be compatible with > -.St -p1003.1-2017 , > +.\" .St -p1003.1-2017 , > +.\" XXX: This should be replaced in the future when an appropriate argument to > +.\" the St macro is available: -p1003.1-2017 > +.No IEEE Std 1003.1-2008, 2017 Edition (\\(LqPOSIX.1\\(Rq) , > which specifies that behavior for > .Dv O_SEARCH , > in the absence of the flag the implementation checks the current > From nobody Tue Aug 27 22:21:23 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Wthpk4kh2z5MVgt; Tue, 27 Aug 2024 22:21:34 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Wthpk2R30z58Lf; Tue, 27 Aug 2024 22:21:34 +0000 (UTC) (envelope-from kostikbel@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: from tom.home (kib@localhost [127.0.0.1] (may be forged)) by kib.kiev.ua (8.18.1/8.18.1) with ESMTP id 47RMLOJn009297; Wed, 28 Aug 2024 01:21:27 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 47RMLOJn009297 Received: (from kostik@localhost) by tom.home (8.18.1/8.18.1/Submit) id 47RMLOkK009296; Wed, 28 Aug 2024 01:21:24 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Wed, 28 Aug 2024 01:21:23 +0300 From: Konstantin Belousov To: Yuri Pankov Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: f5a37f8dd319 - main - open(2): mandoc -T lint Message-ID: References: <202408272209.47RM9rVX002767@gitrepo.freebsd.org> <8bb9edf4-e0f4-4cfb-8b76-4c132a9abd5a@aetern.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8bb9edf4-e0f4-4cfb-8b76-4c132a9abd5a@aetern.org> X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on tom.home X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US] X-Rspamd-Queue-Id: 4Wthpk2R30z58Lf On Wed, Aug 28, 2024 at 05:12:48AM +0700, Yuri Pankov wrote: > Konstantin Belousov wrote: > > The branch main has been updated by kib: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=f5a37f8dd319e3007b126b77376e61ad96f44d8b > > > > commit f5a37f8dd319e3007b126b77376e61ad96f44d8b > > Author: Jose Luis Duran > > AuthorDate: 2024-08-27 03:48:09 +0000 > > Commit: Konstantin Belousov > > CommitDate: 2024-08-27 22:09:33 +0000 > > > > open(2): mandoc -T lint > > > > Lint the manual, addressing almost all requests. > > > > Differential revision: https://reviews.freebsd.org/D46450 > > MFC after: 1 week > > --- > > lib/libsys/open.2 | 15 +++++++++------ > > 1 file changed, 9 insertions(+), 6 deletions(-) > > > > diff --git a/lib/libsys/open.2 b/lib/libsys/open.2 > > index be164aae1834..220561cc5683 100644 > > --- a/lib/libsys/open.2 > > +++ b/lib/libsys/open.2 > > @@ -252,7 +252,7 @@ controlling terminal when it opens a tty device. > > This is the default on > > .Fx , > > but is present for > > -.Tn POSIX > > +POSIX > > compatibility. > > The > > .Fn open > > @@ -265,7 +265,7 @@ initially opening a TTY. > > This is the default on > > .Fx , > > but is present for > > -.Tn POSIX > > +POSIX > > compatibility. > > The initial call to > > .Fn open > > @@ -384,7 +384,7 @@ The file pointer used to mark the current position within the > > file is set to the beginning of the file. > > .Pp > > If a sleeping open of a device node from > > -.Xr devfs 4 > > +.Xr devfs 5 > > This looks wrong, we now have fs man pages in section 4. Thanks. I checked it on my stable/14 w/s. From nobody Tue Aug 27 22:24:13 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Wthsn6gzgz5MW9S; Tue, 27 Aug 2024 22:24:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Wthsn66Lkz58lM; Tue, 27 Aug 2024 22:24:13 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724797453; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=VXV93188LzC8bXmkeMw4OgV1W7uIEbTtWqmlRn6OSFU=; b=hrU5ahMBt3QnJEti9c6PzxE7XYrdApfIwUX2mXl+hB/nPqUjauUGvKZsuBP+i3tXQixLoO c7tr9AVC5MEpvnuaixjef+u+2uT5vZfzPSrHW6WGN4qDGpwzTv4fc1M+qi8cLZsxF6Uvw6 lV67zivku+mjOLCBd9C6YDOXuMJT9bI8ceT2ORoF2PZyAAEonMT80ovCNJ5bGBnAfV4vww sa6dOUTGdmOpeqi47zkE8qGVSPX9f6h0ql71cZngpX2XhFhBWMI3AnVSIaD6DKT6cBjrIX MGRpLcorHys/13+DAtMsdlAc4LLbBegDoplfnYkd22tz4IOKZv1SngCUzRB7Dw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724797453; a=rsa-sha256; cv=none; b=kbbVIhwOFRwmBssv78B2NZEthOz8EznUL1hgRUPzfM/+EYIWsYDT3bRoR8tZ1ovm8FzXI3 3kMrt/n35Put5uD2E8Mt5VUTlRbjd+T1Yc953J+mN0bbnRJUcn8p9r99EFQ4ITA5j394fX QjZ/D9wQY5Ya513QoPG89nCrOHf0GnMfXUcWcbONZv8LyTzLptEk0pLQwfIoKrM/7KTR/j v64CjGBF+axNm001iajOnYjyfFwaAmghaKaRVN6HsBLb8DfEnGFfUpJTugqkya9FK+eUFq npP/hY2DFvgFMUb/crCcDv1hfBuI0eBv0dqRdd97UxCht4zBpbb/mU99bReUGQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724797453; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=VXV93188LzC8bXmkeMw4OgV1W7uIEbTtWqmlRn6OSFU=; b=AInyM2voPXrez7hRIlGH/WtDDcyk6ZVxgmOPAXgXLh8eB48bDrupI2XxoeCMadaHQY1cBN Ht5BL1XE6x7FpQMz9AbYIQ1BM4VAOt5T69OPTrgfFSE7eT3anHw8IFHNMah/IHEtC1xVTp nG/somBtYf9xz/bWLC4EpGXY4Od73Bc416VMvMMpA3Hvx5kXTv8R1p6e+BDjV5IWcsb92y c1uMtO/HyTVn1npG/3xgBbFbFngkbuKmfwz0bAb0HhvShvgQA99mAfNq0bohuF7M4Nz9hN 0oHbnw/wy7GBOxbbt0C0z4q57Zq70Dlg+2nPdipZKygAB840zSwHRnPSYCVZwA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Wthsn5fkRz17Pw; Tue, 27 Aug 2024 22:24:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47RMODaX035906; Tue, 27 Aug 2024 22:24:13 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47RMOD9s035903; Tue, 27 Aug 2024 22:24:13 GMT (envelope-from git) Date: Tue, 27 Aug 2024 22:24:13 GMT Message-Id: <202408272224.47RMOD9s035903@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: 37bb98841099 - main - open(2): devfs is in section 4 on HEAD List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 37bb98841099a4c23c0b8990a988a3324b902c39 Auto-Submitted: auto-generated The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=37bb98841099a4c23c0b8990a988a3324b902c39 commit 37bb98841099a4c23c0b8990a988a3324b902c39 Author: Konstantin Belousov AuthorDate: 2024-08-27 22:23:20 +0000 Commit: Konstantin Belousov CommitDate: 2024-08-27 22:23:20 +0000 open(2): devfs is in section 4 on HEAD Noted by: yuripv Fixes: f5a37f8dd319e3007b126b77376e61ad96f44d8b --- lib/libsys/open.2 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/libsys/open.2 b/lib/libsys/open.2 index 4cdceb336532..8331362640d6 100644 --- a/lib/libsys/open.2 +++ b/lib/libsys/open.2 @@ -384,7 +384,7 @@ The file pointer used to mark the current position within the file is set to the beginning of the file. .Pp If a sleeping open of a device node from -.Xr devfs 5 +.Xr devfs 4 is interrupted by a signal, the call always fails with .Er EINTR , even if the From nobody Tue Aug 27 23:07:36 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Wtjqr2PHXz5MYdG; Tue, 27 Aug 2024 23:07:36 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Wtjqr1gr0z40Wg; Tue, 27 Aug 2024 23:07:36 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724800056; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=bYoyHkQhxU8AChNp3iqI2QjxumVWRO/crag03yJS4RA=; b=UD8UpKBMynkkIrFpNcxwGBEkzkmwu35ss7MgSucZHgFUyFtaHG4K0B4Ni0BrvIJziSCh0u J3jHX3nts99UyibFJtzn/0JJFOv/KzQykM008VaS3VTg16MYpJTYd50IrH1A4V6/OztOIE 5FE/kVXOIvo3L2vMsGVb3Myjvd3dESh0PnIZh85XocJsZhHGgHukgZvp8SaC1FI8DvVGqJ 8VGtlLZc7kSlCTgFXjoZ2M/kQ1rIvzVrbLp3FsDJaj/9tnELO4EaSEEDKVvt3QlnRZWpCp 1qS3PiXu8wl+acAgYCzgMcCa6om6XWBG1b1bcLK0CUXS2Cy9fytzqAXTkT/aoA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724800056; a=rsa-sha256; cv=none; b=qjZHz2qOTlufnnHiHjtLdRUciwTYLKOytO5RsFUzthIBKWDUmALmztA+fxYXjy2MBDjE4Z w1gNamskOyCe2mojY3+7MwTzR3I7k7CjzBqn/9wVPG6Y5oR3SZoqluUM6UIQqIFMM/kA6s dYCb+oqT/jZjSv9JnugmkAzHM7xSH+KsDGOJqAfWLbf/qsXMe+/Bx2EtlqnnP2YIccjJIN WIEqcvTUs+GCJCbLdIN4zxYSZBpijfxPRM8do1zyZc4kt99mdbnosjN5FoGxviGQruKfFX u/OAinEFqLzeiH0YUlMQHoUDi0RjdzPoLjeC/z7SOWm5NyAZKMdv68iAPzXubA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724800056; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=bYoyHkQhxU8AChNp3iqI2QjxumVWRO/crag03yJS4RA=; b=qVm3/716yVfy/mhmS9jWgWZ9AA02oKyqmtaZjChFwtHeNc0JtKd2paMHXmxPBm3IE2ChdI aSHCJN0S9veOV6kHYnpNJH8S9Wy5VoRnesOYZyta2b0zT9gSOawQ/zy3AXnUI44IJp7ph8 L0mr8o/+MQSNoJWWixOo2C1jRZUwi7cR20uPyz5azE+3GRpH9qLG10Pre+O/oL0aBAH2Sa s/DLdxICtR3LlG8sYUetQNjiJiY5+DQ/AqufKHiiBYoOfo06gSytGTY3YLRu5NneOl3HZ2 vAn145p6ex6RdDzQzavXMs1gOxESUcf+hVmmZhhmKH/+hyKBajZ7eRqWxzv2Hw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Wtjqr1H3Qz17q3; Tue, 27 Aug 2024 23:07:36 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47RN7a6L004450; Tue, 27 Aug 2024 23:07:36 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47RN7aU4004448; Tue, 27 Aug 2024 23:07:36 GMT (envelope-from git) Date: Tue, 27 Aug 2024 23:07:36 GMT Message-Id: <202408272307.47RN7aU4004448@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Eric Joyner Subject: git: fef4249f0728 - main - ixl(4): Use GL_RXERR1 register for correct oversize packet count List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: erj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: fef4249f07287374b10087f597a62b8e00dedabc Auto-Submitted: auto-generated The branch main has been updated by erj: URL: https://cgit.FreeBSD.org/src/commit/?id=fef4249f07287374b10087f597a62b8e00dedabc commit fef4249f07287374b10087f597a62b8e00dedabc Author: Eric Joyner AuthorDate: 2024-08-27 22:59:49 +0000 Commit: Eric Joyner CommitDate: 2024-08-27 22:59:49 +0000 ixl(4): Use GL_RXERR1 register for correct oversize packet count The driver sets the Maximum Transmission Unit (MTU) at the Virtual Station Interface (VSI) level, which leads to a discrepancy in the GLPRT_ROC counter's ability to accurately tally oversized packets, as this counter operates at the physical port level. To rectify this issue, it is necessary to take an additional register (GL_RXERR1) into account to obtain the correct count of oversized packets. Signed-off-by: Yogesh Bhosale Signed-off-by: Eric Joyner Reviewed by: erj@ Sponsored by: Intel Corporation Differential Revision: https://reviews.freebsd.org/D45870 --- sys/dev/ixl/i40e_register.h | 12 ++-- sys/dev/ixl/i40e_type.h | 1 + sys/dev/ixl/ixl_pf.h | 4 +- sys/dev/ixl/ixl_pf_main.c | 158 ++++++++++++++++++++++++-------------------- 4 files changed, 100 insertions(+), 75 deletions(-) diff --git a/sys/dev/ixl/i40e_register.h b/sys/dev/ixl/i40e_register.h index 22a0f779db09..c267fef41af3 100644 --- a/sys/dev/ixl/i40e_register.h +++ b/sys/dev/ixl/i40e_register.h @@ -2431,10 +2431,14 @@ #define I40E_GL_FCOERPDC_MAX_INDEX 143 #define I40E_GL_FCOERPDC_FCOERPDC_SHIFT 0 #define I40E_GL_FCOERPDC_FCOERPDC_MASK I40E_MASK(0xFFFFFFFF, I40E_GL_FCOERPDC_FCOERPDC_SHIFT) -#define I40E_GL_RXERR1_L(_i) (0x00318000 + ((_i) * 8)) /* _i=0...143 */ /* Reset: CORER */ -#define I40E_GL_RXERR1_L_MAX_INDEX 143 -#define I40E_GL_RXERR1_L_FCOEDIFRC_SHIFT 0 -#define I40E_GL_RXERR1_L_FCOEDIFRC_MASK I40E_MASK(0xFFFFFFFF, I40E_GL_RXERR1_L_FCOEDIFRC_SHIFT) +#define I40E_GL_RXERR1H(_i) (0x00318004 + ((_i) * 8)) /* _i=0...143 */ /* Reset: CORER */ +#define I40E_GL_RXERR1H_MAX_INDEX 143 +#define I40E_GL_RXERR1H_RXERR1H_SHIFT 0 +#define I40E_GL_RXERR1H_RXERR1H_MASK I40E_MASK(0xFFFFFFFF, I40E_GL_RXERR1H_RXERR1H_SHIFT) +#define I40E_GL_RXERR1L(_i) (0x00318000 + ((_i) * 8)) /* _i=0...143 */ /* Reset: CORER */ +#define I40E_GL_RXERR1L_MAX_INDEX 143 +#define I40E_GL_RXERR1L_RXERR1L_SHIFT 0 +#define I40E_GL_RXERR1L_RXERR1L_MASK I40E_MASK(0xFFFFFFFF, I40E_GL_RXERR1L_RXERR1L_SHIFT) #define I40E_GL_RXERR2_L(_i) (0x0031c000 + ((_i) * 8)) /* _i=0...143 */ /* Reset: CORER */ #define I40E_GL_RXERR2_L_MAX_INDEX 143 #define I40E_GL_RXERR2_L_FCOEDIXAC_SHIFT 0 diff --git a/sys/dev/ixl/i40e_type.h b/sys/dev/ixl/i40e_type.h index 9c2809a3e41a..20e8f09b0813 100644 --- a/sys/dev/ixl/i40e_type.h +++ b/sys/dev/ixl/i40e_type.h @@ -1472,6 +1472,7 @@ struct i40e_hw_port_stats { u64 rx_undersize; /* ruc */ u64 rx_fragments; /* rfc */ u64 rx_oversize; /* roc */ + u64 rx_err1; /* rxerr1 */ u64 rx_jabber; /* rjc */ u64 tx_size_64; /* ptc64 */ u64 tx_size_127; /* ptc127 */ diff --git a/sys/dev/ixl/ixl_pf.h b/sys/dev/ixl/ixl_pf.h index 96303c43d4e8..f0d42f18cef0 100644 --- a/sys/dev/ixl/ixl_pf.h +++ b/sys/dev/ixl/ixl_pf.h @@ -318,7 +318,9 @@ void ixl_disable_queue(struct i40e_hw *, int); void ixl_enable_intr0(struct i40e_hw *); void ixl_disable_intr0(struct i40e_hw *); void ixl_nvm_version_str(struct i40e_hw *hw, struct sbuf *buf); -void ixl_stat_update48(struct i40e_hw *, u32, u32, bool, +void ixl_stat_update64(struct i40e_hw *, u32, bool, + u64 *, u64 *); +void ixl_stat_update48(struct i40e_hw *, u32, bool, u64 *, u64 *); void ixl_stat_update32(struct i40e_hw *, u32, bool, u64 *, u64 *); diff --git a/sys/dev/ixl/ixl_pf_main.c b/sys/dev/ixl/ixl_pf_main.c index af253faeac7a..4e1b1001efdc 100644 --- a/sys/dev/ixl/ixl_pf_main.c +++ b/sys/dev/ixl/ixl_pf_main.c @@ -2109,45 +2109,37 @@ ixl_update_stats_counters(struct ixl_pf *pf) ixl_stat_update32(hw, I40E_GLPRT_ILLERRC(hw->port), pf->stat_offsets_loaded, &osd->illegal_bytes, &nsd->illegal_bytes); - ixl_stat_update48(hw, I40E_GLPRT_GORCH(hw->port), - I40E_GLPRT_GORCL(hw->port), + ixl_stat_update48(hw, I40E_GLPRT_GORCL(hw->port), pf->stat_offsets_loaded, &osd->eth.rx_bytes, &nsd->eth.rx_bytes); - ixl_stat_update48(hw, I40E_GLPRT_GOTCH(hw->port), - I40E_GLPRT_GOTCL(hw->port), + ixl_stat_update48(hw, I40E_GLPRT_GOTCL(hw->port), pf->stat_offsets_loaded, &osd->eth.tx_bytes, &nsd->eth.tx_bytes); ixl_stat_update32(hw, I40E_GLPRT_RDPC(hw->port), pf->stat_offsets_loaded, &osd->eth.rx_discards, &nsd->eth.rx_discards); - ixl_stat_update48(hw, I40E_GLPRT_UPRCH(hw->port), - I40E_GLPRT_UPRCL(hw->port), + ixl_stat_update48(hw, I40E_GLPRT_UPRCL(hw->port), pf->stat_offsets_loaded, &osd->eth.rx_unicast, &nsd->eth.rx_unicast); - ixl_stat_update48(hw, I40E_GLPRT_UPTCH(hw->port), - I40E_GLPRT_UPTCL(hw->port), + ixl_stat_update48(hw, I40E_GLPRT_UPTCL(hw->port), pf->stat_offsets_loaded, &osd->eth.tx_unicast, &nsd->eth.tx_unicast); - ixl_stat_update48(hw, I40E_GLPRT_MPRCH(hw->port), - I40E_GLPRT_MPRCL(hw->port), + ixl_stat_update48(hw, I40E_GLPRT_MPRCL(hw->port), pf->stat_offsets_loaded, &osd->eth.rx_multicast, &nsd->eth.rx_multicast); - ixl_stat_update48(hw, I40E_GLPRT_MPTCH(hw->port), - I40E_GLPRT_MPTCL(hw->port), + ixl_stat_update48(hw, I40E_GLPRT_MPTCL(hw->port), pf->stat_offsets_loaded, &osd->eth.tx_multicast, &nsd->eth.tx_multicast); - ixl_stat_update48(hw, I40E_GLPRT_BPRCH(hw->port), - I40E_GLPRT_BPRCL(hw->port), + ixl_stat_update48(hw, I40E_GLPRT_BPRCL(hw->port), pf->stat_offsets_loaded, &osd->eth.rx_broadcast, &nsd->eth.rx_broadcast); - ixl_stat_update48(hw, I40E_GLPRT_BPTCH(hw->port), - I40E_GLPRT_BPTCL(hw->port), + ixl_stat_update48(hw, I40E_GLPRT_BPTCL(hw->port), pf->stat_offsets_loaded, &osd->eth.tx_broadcast, &nsd->eth.tx_broadcast); @@ -2191,62 +2183,48 @@ ixl_update_stats_counters(struct ixl_pf *pf) vsi->shared->isc_pause_frames = 1; /* Packet size stats rx */ - ixl_stat_update48(hw, I40E_GLPRT_PRC64H(hw->port), - I40E_GLPRT_PRC64L(hw->port), + ixl_stat_update48(hw, I40E_GLPRT_PRC64L(hw->port), pf->stat_offsets_loaded, &osd->rx_size_64, &nsd->rx_size_64); - ixl_stat_update48(hw, I40E_GLPRT_PRC127H(hw->port), - I40E_GLPRT_PRC127L(hw->port), + ixl_stat_update48(hw, I40E_GLPRT_PRC127L(hw->port), pf->stat_offsets_loaded, &osd->rx_size_127, &nsd->rx_size_127); - ixl_stat_update48(hw, I40E_GLPRT_PRC255H(hw->port), - I40E_GLPRT_PRC255L(hw->port), + ixl_stat_update48(hw, I40E_GLPRT_PRC255L(hw->port), pf->stat_offsets_loaded, &osd->rx_size_255, &nsd->rx_size_255); - ixl_stat_update48(hw, I40E_GLPRT_PRC511H(hw->port), - I40E_GLPRT_PRC511L(hw->port), + ixl_stat_update48(hw, I40E_GLPRT_PRC511L(hw->port), pf->stat_offsets_loaded, &osd->rx_size_511, &nsd->rx_size_511); - ixl_stat_update48(hw, I40E_GLPRT_PRC1023H(hw->port), - I40E_GLPRT_PRC1023L(hw->port), + ixl_stat_update48(hw, I40E_GLPRT_PRC1023L(hw->port), pf->stat_offsets_loaded, &osd->rx_size_1023, &nsd->rx_size_1023); - ixl_stat_update48(hw, I40E_GLPRT_PRC1522H(hw->port), - I40E_GLPRT_PRC1522L(hw->port), + ixl_stat_update48(hw, I40E_GLPRT_PRC1522L(hw->port), pf->stat_offsets_loaded, &osd->rx_size_1522, &nsd->rx_size_1522); - ixl_stat_update48(hw, I40E_GLPRT_PRC9522H(hw->port), - I40E_GLPRT_PRC9522L(hw->port), + ixl_stat_update48(hw, I40E_GLPRT_PRC9522L(hw->port), pf->stat_offsets_loaded, &osd->rx_size_big, &nsd->rx_size_big); /* Packet size stats tx */ - ixl_stat_update48(hw, I40E_GLPRT_PTC64H(hw->port), - I40E_GLPRT_PTC64L(hw->port), + ixl_stat_update48(hw, I40E_GLPRT_PTC64L(hw->port), pf->stat_offsets_loaded, &osd->tx_size_64, &nsd->tx_size_64); - ixl_stat_update48(hw, I40E_GLPRT_PTC127H(hw->port), - I40E_GLPRT_PTC127L(hw->port), + ixl_stat_update48(hw, I40E_GLPRT_PTC127L(hw->port), pf->stat_offsets_loaded, &osd->tx_size_127, &nsd->tx_size_127); - ixl_stat_update48(hw, I40E_GLPRT_PTC255H(hw->port), - I40E_GLPRT_PTC255L(hw->port), + ixl_stat_update48(hw, I40E_GLPRT_PTC255L(hw->port), pf->stat_offsets_loaded, &osd->tx_size_255, &nsd->tx_size_255); - ixl_stat_update48(hw, I40E_GLPRT_PTC511H(hw->port), - I40E_GLPRT_PTC511L(hw->port), + ixl_stat_update48(hw, I40E_GLPRT_PTC511L(hw->port), pf->stat_offsets_loaded, &osd->tx_size_511, &nsd->tx_size_511); - ixl_stat_update48(hw, I40E_GLPRT_PTC1023H(hw->port), - I40E_GLPRT_PTC1023L(hw->port), + ixl_stat_update48(hw, I40E_GLPRT_PTC1023L(hw->port), pf->stat_offsets_loaded, &osd->tx_size_1023, &nsd->tx_size_1023); - ixl_stat_update48(hw, I40E_GLPRT_PTC1522H(hw->port), - I40E_GLPRT_PTC1522L(hw->port), + ixl_stat_update48(hw, I40E_GLPRT_PTC1522L(hw->port), pf->stat_offsets_loaded, &osd->tx_size_1522, &nsd->tx_size_1522); - ixl_stat_update48(hw, I40E_GLPRT_PTC9522H(hw->port), - I40E_GLPRT_PTC9522L(hw->port), + ixl_stat_update48(hw, I40E_GLPRT_PTC9522L(hw->port), pf->stat_offsets_loaded, &osd->tx_size_big, &nsd->tx_size_big); @@ -2256,9 +2234,29 @@ ixl_update_stats_counters(struct ixl_pf *pf) ixl_stat_update32(hw, I40E_GLPRT_RFC(hw->port), pf->stat_offsets_loaded, &osd->rx_fragments, &nsd->rx_fragments); + + u64 rx_roc; ixl_stat_update32(hw, I40E_GLPRT_ROC(hw->port), pf->stat_offsets_loaded, - &osd->rx_oversize, &nsd->rx_oversize); + &osd->rx_oversize, &rx_roc); + + /* + * Read from RXERR1 register to get the count for the packets + * larger than RX MAX and include that in total rx_oversize count. + * + * Also need to add BIT(7) to hw->port value while indexing + * I40E_GL_RXERR1 register as indexes 0..127 are for VFs when + * SR-IOV is enabled. Indexes 128..143 are for PFs. + */ + u64 rx_err1; + ixl_stat_update64(hw, + I40E_GL_RXERR1L(hw->pf_id + BIT(7)), + pf->stat_offsets_loaded, + &osd->rx_err1, + &rx_err1); + + nsd->rx_oversize = rx_roc + rx_err1; + ixl_stat_update32(hw, I40E_GLPRT_RJC(hw->port), pf->stat_offsets_loaded, &osd->rx_jabber, &nsd->rx_jabber); @@ -2305,37 +2303,29 @@ ixl_update_eth_stats(struct ixl_vsi *vsi) vsi->stat_offsets_loaded, &oes->rx_discards, &es->rx_discards); - ixl_stat_update48(hw, I40E_GLV_GORCH(stat_idx), - I40E_GLV_GORCL(stat_idx), + ixl_stat_update48(hw, I40E_GLV_GORCL(stat_idx), vsi->stat_offsets_loaded, &oes->rx_bytes, &es->rx_bytes); - ixl_stat_update48(hw, I40E_GLV_UPRCH(stat_idx), - I40E_GLV_UPRCL(stat_idx), + ixl_stat_update48(hw, I40E_GLV_UPRCL(stat_idx), vsi->stat_offsets_loaded, &oes->rx_unicast, &es->rx_unicast); - ixl_stat_update48(hw, I40E_GLV_MPRCH(stat_idx), - I40E_GLV_MPRCL(stat_idx), + ixl_stat_update48(hw, I40E_GLV_MPRCL(stat_idx), vsi->stat_offsets_loaded, &oes->rx_multicast, &es->rx_multicast); - ixl_stat_update48(hw, I40E_GLV_BPRCH(stat_idx), - I40E_GLV_BPRCL(stat_idx), + ixl_stat_update48(hw, I40E_GLV_BPRCL(stat_idx), vsi->stat_offsets_loaded, &oes->rx_broadcast, &es->rx_broadcast); - ixl_stat_update48(hw, I40E_GLV_GOTCH(stat_idx), - I40E_GLV_GOTCL(stat_idx), + ixl_stat_update48(hw, I40E_GLV_GOTCL(stat_idx), vsi->stat_offsets_loaded, &oes->tx_bytes, &es->tx_bytes); - ixl_stat_update48(hw, I40E_GLV_UPTCH(stat_idx), - I40E_GLV_UPTCL(stat_idx), + ixl_stat_update48(hw, I40E_GLV_UPTCL(stat_idx), vsi->stat_offsets_loaded, &oes->tx_unicast, &es->tx_unicast); - ixl_stat_update48(hw, I40E_GLV_MPTCH(stat_idx), - I40E_GLV_MPTCL(stat_idx), + ixl_stat_update48(hw, I40E_GLV_MPTCL(stat_idx), vsi->stat_offsets_loaded, &oes->tx_multicast, &es->tx_multicast); - ixl_stat_update48(hw, I40E_GLV_BPTCH(stat_idx), - I40E_GLV_BPTCL(stat_idx), + ixl_stat_update48(hw, I40E_GLV_BPTCL(stat_idx), vsi->stat_offsets_loaded, &oes->tx_broadcast, &es->tx_broadcast); vsi->stat_offsets_loaded = true; @@ -2409,28 +2399,56 @@ ixl_vsi_reset_stats(struct ixl_vsi *vsi) } /** - * Read and update a 48 bit stat from the hw + * Helper function for reading and updating 48/64 bit stats from the hw * * Since the device stats are not reset at PFReset, they likely will not * be zeroed when the driver starts. We'll save the first values read * and use them as offsets to be subtracted from the raw values in order * to report stats that count from zero. **/ -void -ixl_stat_update48(struct i40e_hw *hw, u32 hireg, u32 loreg, - bool offset_loaded, u64 *offset, u64 *stat) +static void +_ixl_stat_update_helper(struct i40e_hw *hw, u32 reg, + bool offset_loaded, u64 mask, u64 *offset, u64 *stat) { - u64 new_data; - - new_data = rd64(hw, loreg); + u64 new_data = rd64(hw, reg); if (!offset_loaded) *offset = new_data; if (new_data >= *offset) *stat = new_data - *offset; else - *stat = (new_data + ((u64)1 << 48)) - *offset; - *stat &= 0xFFFFFFFFFFFFULL; + *stat = (new_data + mask) - *offset + 1; + *stat &= mask; +} + +/** + * Read and update a 48 bit stat from the hw + **/ +void +ixl_stat_update48(struct i40e_hw *hw, u32 reg, + bool offset_loaded, u64 *offset, u64 *stat) +{ + _ixl_stat_update_helper(hw, + reg, + offset_loaded, + 0xFFFFFFFFFFFFULL, + offset, + stat); +} + +/** + * ixl_stat_update64 - read and update a 64 bit stat from the chip. + **/ +void +ixl_stat_update64(struct i40e_hw *hw, u32 reg, + bool offset_loaded, u64 *offset, u64 *stat) +{ + _ixl_stat_update_helper(hw, + reg, + offset_loaded, + 0xFFFFFFFFFFFFFFFFULL, + offset, + stat); } /** From nobody Tue Aug 27 23:16:03 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Wtk1f2TDQz5MZKb; Tue, 27 Aug 2024 23:16:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Wtk1b6XT5z41NY; Tue, 27 Aug 2024 23:16:03 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724800563; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=MMxEOCf0Lq2YnNNXOhYD5vAwI7wwD50iolcrxXwf5eE=; b=lsSfhwkngMKA8WQiBkZT19tJJJrD+dpODFqgrrtWc4Y4r3orT16Yn8bDLBqk0hF8RvQTMd AbVmepHz1inr1g9xR99t3fx2/tRC8RBB0bFeHv2SFH3EZeKhznxk5ycTssZzICfKXCm4Hz 21gAbuJS8e6hNYJ8LRqPCV61g4K6gL6RLr/tBLd9OqB9/iwCoIJ7GyCcSDZGJHFAcNl6Ro D65rdTireGv+2t5kR/N05S/eQhWWzH5Ivg2fUHXofVNCy+50YGIxXbZYW+upQK1VvFwQK2 LsLTeyPcymVPMZF1iDi+o3dGbCtr7s2gfKrbrChHmlb5eyVBWCGmPaZVI5Cv9A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724800563; a=rsa-sha256; cv=none; b=Z6EJjJX2wS4iwzU19GS6Tq3ukkwfuc82bXoxFgvFux2BdJaeGflpz4/cwUKGmXR1osHhr4 afONqjoAOvoz2LgxPBSUDEKZBz7FkT1oYtrEo6dVczVZrKghGidvBhZDkZgxvy1+mZ4Rza 5ytxHCtytxG9cDScSNg2FhRHtIUeX5D5OBZKbvFXdcyXZPqaIiyN06zNRlDG+ZzhP+QFMZ wgKY/Wm/bHJncYXIbF5gsA2CIsKzuDXmuoC/n6CVLpjLNqFZAuSfg9ZS+3mH3Kv8xwSTwR B+mobn/uANZodzwJCL7pVDElrPHxQ6c4UGX8t37pLCpzFANHNMEuft8VMt5qHQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724800563; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=MMxEOCf0Lq2YnNNXOhYD5vAwI7wwD50iolcrxXwf5eE=; b=Ga/W4amh785qJiRiWWt9m/yN8Q5IeeBq44Fl8sUOaLAsBWj6BD2EY73CxW7amWV1Pf82oB 1dL/tkNAqyveQxUPayaTELkdZ7kYG2mwghT5yG7ooRMMCHiL+p1fxaj5x3DhwI56kMj0hA 5VCiu2qWdE4R3bMxzDxy/Jt6ITlP2nRhIcfhfyUliYLU5MXGk9Fpi7IpV3yoiyyHoG7YCF kszKoOH6yCXamFts5JsH3rWngRV+Z5PolCB4ZZXofMSkr4TDoagS9BOKRGIIwmCbxktuJc nk+0MpCj48/unq8Le2J32OLZC1o3JKO8oWCfcpL0Us/SC+jNGAoudSQx40X0MQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Wtk1b3qskz17qM; Tue, 27 Aug 2024 23:16:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47RNG3Tr020966; Tue, 27 Aug 2024 23:16:03 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47RNG37E020963; Tue, 27 Aug 2024 23:16:03 GMT (envelope-from git) Date: Tue, 27 Aug 2024 23:16:03 GMT Message-Id: <202408272316.47RNG37E020963@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Eric Joyner Subject: git: 4fecb7015432 - main - ixl(4): Add more debug information for queues' config List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: erj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 4fecb70154322fb8160da10d87c633cefaff7db3 Auto-Submitted: auto-generated The branch main has been updated by erj: URL: https://cgit.FreeBSD.org/src/commit/?id=4fecb70154322fb8160da10d87c633cefaff7db3 commit 4fecb70154322fb8160da10d87c633cefaff7db3 Author: Krzysztof Galazka AuthorDate: 2024-08-27 23:11:18 +0000 Commit: Eric Joyner CommitDate: 2024-08-27 23:13:19 +0000 ixl(4): Add more debug information for queues' config Include information about interrupt linked lists in queue_interrupt_table sysctl and add new debug sysctl queue_int_ctln allowing to check current interrupt state. Signed-off-by: Krzysztof Galazka Signed-off-by: Eric Joyner Reviewed by: erj@ Sponsored by: Intel Corporation Differential Revision: https://reviews.freebsd.org/D45403 --- sys/dev/ixl/ixl_pf_main.c | 53 +++++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 51 insertions(+), 2 deletions(-) diff --git a/sys/dev/ixl/ixl_pf_main.c b/sys/dev/ixl/ixl_pf_main.c index 4e1b1001efdc..9755136df848 100644 --- a/sys/dev/ixl/ixl_pf_main.c +++ b/sys/dev/ixl/ixl_pf_main.c @@ -91,6 +91,7 @@ static int ixl_sysctl_do_pf_reset(SYSCTL_HANDLER_ARGS); static int ixl_sysctl_do_core_reset(SYSCTL_HANDLER_ARGS); static int ixl_sysctl_do_global_reset(SYSCTL_HANDLER_ARGS); static int ixl_sysctl_queue_interrupt_table(SYSCTL_HANDLER_ARGS); +static int ixl_sysctl_debug_queue_int_ctln(SYSCTL_HANDLER_ARGS); #ifdef IXL_DEBUG static int ixl_sysctl_qtx_tail_handler(SYSCTL_HANDLER_ARGS); static int ixl_sysctl_qrx_tail_handler(SYSCTL_HANDLER_ARGS); @@ -2528,6 +2529,12 @@ ixl_add_sysctls_recovery_mode(struct ixl_pf *pf) OID_AUTO, "queue_interrupt_table", CTLTYPE_STRING | CTLFLAG_RD | CTLFLAG_NEEDGIANT, pf, 0, ixl_sysctl_queue_interrupt_table, "A", "View MSI-X indices for TX/RX queues"); + + SYSCTL_ADD_PROC(ctx, debug_list, + OID_AUTO, "queue_int_ctln", + CTLTYPE_STRING | CTLFLAG_RD | CTLFLAG_NEEDGIANT, + pf, 0, ixl_sysctl_debug_queue_int_ctln, "A", + "View MSI-X control registers for RX queues"); } void @@ -4899,6 +4906,7 @@ ixl_sysctl_queue_interrupt_table(SYSCTL_HANDLER_ARGS) { struct ixl_pf *pf = (struct ixl_pf *)arg1; struct ixl_vsi *vsi = &pf->vsi; + struct i40e_hw *hw = vsi->hw; device_t dev = pf->dev; struct sbuf *buf; int error = 0; @@ -4915,11 +4923,52 @@ ixl_sysctl_queue_interrupt_table(SYSCTL_HANDLER_ARGS) sbuf_cat(buf, "\n"); for (int i = 0; i < vsi->num_rx_queues; i++) { rx_que = &vsi->rx_queues[i]; - sbuf_printf(buf, "(rxq %3d): %d\n", i, rx_que->msix); + sbuf_printf(buf, + "(rxq %3d): %d LNKLSTN: %08x QINT_RQCTL: %08x\n", + i, rx_que->msix, + rd32(hw, I40E_PFINT_LNKLSTN(rx_que->msix - 1)), + rd32(hw, I40E_QINT_RQCTL(rx_que->msix - 1))); } for (int i = 0; i < vsi->num_tx_queues; i++) { tx_que = &vsi->tx_queues[i]; - sbuf_printf(buf, "(txq %3d): %d\n", i, tx_que->msix); + sbuf_printf(buf, "(txq %3d): %d QINT_TQCTL: %08x\n", + i, tx_que->msix, + rd32(hw, I40E_QINT_TQCTL(tx_que->msix - 1))); + } + + error = sbuf_finish(buf); + if (error) + device_printf(dev, "Error finishing sbuf: %d\n", error); + sbuf_delete(buf); + + return (error); +} + +static int +ixl_sysctl_debug_queue_int_ctln(SYSCTL_HANDLER_ARGS) +{ + struct ixl_pf *pf = (struct ixl_pf *)arg1; + struct ixl_vsi *vsi = &pf->vsi; + struct i40e_hw *hw = vsi->hw; + device_t dev = pf->dev; + struct sbuf *buf; + int error = 0; + + struct ixl_rx_queue *rx_que = vsi->rx_queues; + + buf = sbuf_new_for_sysctl(NULL, NULL, 128, req); + if (!buf) { + device_printf(dev, "Could not allocate sbuf for output.\n"); + return (ENOMEM); + } + + sbuf_cat(buf, "\n"); + for (int i = 0; i < vsi->num_rx_queues; i++) { + rx_que = &vsi->rx_queues[i]; + sbuf_printf(buf, + "(rxq %3d): %d PFINT_DYN_CTLN: %08x\n", + i, rx_que->msix, + rd32(hw, I40E_PFINT_DYN_CTLN(rx_que->msix - 1))); } error = sbuf_finish(buf); From nobody Wed Aug 28 07:31:10 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Wtx0t5k0Wz5PWbV; Wed, 28 Aug 2024 07:31:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Wtx0t5D7Kz4gfV; Wed, 28 Aug 2024 07:31:10 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724830270; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=C1Wwz95sQlBROezyh9+sMRdPvCrSHTgdnFLsvcdfV3c=; b=f/h3s4Hcni8PUzO4p4H1ontsqN4gyxqHPNNIPZA0qgkstVzLV1NTLRCY6KT2fLT1i18o1S mO2tck5xsbjeJuESRijgusBHG0U1LG2XJNicOjj+NIWw+4BNly9PboGtEJynqz7pTdT8ro 4rn1g+HGP1ky9J4zkt0QDo+4rEgJnS822XAxFN7KKLBMOOpKHsp2H8AZ1j5T/pLBdjLN0D 6Oo0wwBpx0ZXYJdHSyfdbE7iCIl5gHNMiP6ANr17B3vnpHy7RA+7jG1gTMrPMbQv6cA8p8 vDLZIl7I5jrkMypYBreo9TnQPkuyyiijT0kWjFEwwkf+Xt3Io/6CPWjZdE7LrA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724830270; a=rsa-sha256; cv=none; b=DGoLpkmLcOD9qxOCioeXwkRUpBnWx6c16ehl+74Qfd/0HM7ovNmoDHqZf1s3D5PGsDDBI9 So+vFn9ZL6+zOAcotywoBpa3B7hPzuRuRaBtVu0OB0wPtMyJknVwLm2bQX4+3+LdxDf8qw dy8OLI47aOc3JFO3mX0yssx8oplNXDKGeGlmprkD2XZxQv9TeBO/pKO33SYjna3xmd1qNy N9/XOfF/ECaazRSLk1pAW/3b/kHNrQImzqG3m/FCCRupg+WjlHTCxXuRWMHpvnA0SqrppM /ar9RJpcbFmzCCzn9BYjsrQf5Au/vkCDTqTLvPw2IsiQqTYwlPcgPwBMRHUP4g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724830270; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=C1Wwz95sQlBROezyh9+sMRdPvCrSHTgdnFLsvcdfV3c=; b=kX2+ipPqC0oSBLWs0ujmjg5kmRRrXgMNcyOR45wUjcLOHvuiDMCrOSfPeSYLew2uOKTCiE aLiUAHTjm9jxc4pFzWa4Nbb/AAv/OkaPbSxG/tTWB52xThyXTH8Xkt4CdfydNKJm1h5lNH 8Q8wgZiI2KHkUvYy1yYRaBfxtD1YTFijU3QtPmvTG+0FPNxDqny7IzTJjSkBd37qVwsotc fqvut217mUxwGdd2ic1l1PQca7bnHP8lbjr9kSb2isa9wXF/TNxUAuGy5ouoNo+yFCbiB2 GqhB3YFa3Qn/QlneKBq9BgxPLRxXWRM5kWbgh7AD4Pv8I8HsUpJUeOIFEyZ8Mg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Wtx0t4pk1zPRC; Wed, 28 Aug 2024 07:31:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47S7VA0v062807; Wed, 28 Aug 2024 07:31:10 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47S7VAcD062804; Wed, 28 Aug 2024 07:31:10 GMT (envelope-from git) Date: Wed, 28 Aug 2024 07:31:10 GMT Message-Id: <202408280731.47S7VAcD062804@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Emmanuel Vadot Subject: git: 84f46335ab5d - main - linuxkpi: chase spinlock_t in DECLARE_WAIT_QUEUE_HEAD List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: manu X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 84f46335ab5da086c74032579799c0a74aa27447 Auto-Submitted: auto-generated The branch main has been updated by manu: URL: https://cgit.FreeBSD.org/src/commit/?id=84f46335ab5da086c74032579799c0a74aa27447 commit 84f46335ab5da086c74032579799c0a74aa27447 Author: Evgenii Khramtsov <2khramtsov@gmail.com> AuthorDate: 2024-08-27 11:21:39 +0000 Commit: Emmanuel Vadot CommitDate: 2024-08-28 07:29:40 +0000 linuxkpi: chase spinlock_t in DECLARE_WAIT_QUEUE_HEAD Remove member m to unbreak consumers, e.g. drm-kmod 5.10-lts branch. [...] /tmp/drm-kmod/drivers/gpu/drm/ttm/ttm_module.c:38:8: error: no member named 'm' in 'struct mtx' 38 | static DECLARE_WAIT_QUEUE_HEAD(exit_q); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /tmp/src/sys/compat/linuxkpi/common/include/linux/wait.h:113:33: note: expanded from macro 'DECLARE_WAIT_QUEUE_HEAD' 113 | MTX_SYSINIT(name, &(name).lock.m, spin_lock_name("wqhead"), MTX_DEF) | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /tmp/src/sys/sys/mutex.h:528:4: note: expanded from macro 'MTX_SYSINIT' 528 | (mtx), \ | ^~~ /tmp/drm-kmod/drivers/gpu/drm/ttm/ttm_module.c:38:8: error: no member named 'm' in 'struct mtx' 38 | static DECLARE_WAIT_QUEUE_HEAD(exit_q); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /tmp/src/sys/compat/linuxkpi/common/include/linux/wait.h:113:33: note: expanded from macro 'DECLARE_WAIT_QUEUE_HEAD' 113 | MTX_SYSINIT(name, &(name).lock.m, spin_lock_name("wqhead"), MTX_DEF) | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ [...] Fixes: ae38a1a1bfdf ("linuxkpi: spinlock: Simplify code") MFC after: ? --- sys/compat/linuxkpi/common/include/linux/wait.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/compat/linuxkpi/common/include/linux/wait.h b/sys/compat/linuxkpi/common/include/linux/wait.h index b815050b6faa..309c7816aa7b 100644 --- a/sys/compat/linuxkpi/common/include/linux/wait.h +++ b/sys/compat/linuxkpi/common/include/linux/wait.h @@ -110,7 +110,7 @@ extern wait_queue_func_t default_wake_function; wait_queue_head_t name = { \ .task_list = LINUX_LIST_HEAD_INIT(name.task_list), \ }; \ - MTX_SYSINIT(name, &(name).lock.m, spin_lock_name("wqhead"), MTX_DEF) + MTX_SYSINIT(name, &(name).lock, spin_lock_name("wqhead"), MTX_DEF) #define init_waitqueue_head(wqh) do { \ mtx_init(&(wqh)->lock, spin_lock_name("wqhead"), \ From nobody Wed Aug 28 12:34:43 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Wv3l73kWSz5T9nW; Wed, 28 Aug 2024 12:34:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Wv3l73LlVz46mf; Wed, 28 Aug 2024 12:34:43 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724848483; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yN9jyQOyMN/e/XaIMu1eY9wQZFbuAoEeMsRJMjJBXFw=; b=vuQkODWoCwTbfXtaIlUaZRMCMbKoQzTuyfOXbQXloUbQ5mH6i/kyqP0hoxo7ON5XmBB2TI pafDgyn5MYO+mbleRlsePPqWqjMP3tSq3hSBPWvoIq32Of/KHtQSzzqxqkO1cma0732w1E w6/uu1gqylC9hJtcxNjSM9os2sv7yYLUGd7kmkustLhmBKHURav4Yl6jbGnAUmiT3niLj5 CpjCDeSwx+9QoRc2U5NvNZ7kVi7NTlXtocEnHs2qNrCRdcVJ1ktJZgdQju1phagSn2yX3E kB72yATv/8deHpDCa0f329x6e+eagttLCSqJI8zUhSHGZ0j30B6cbJmXBAIYGg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724848483; a=rsa-sha256; cv=none; b=hhAoRxlJIzTD7ib4Kq1HS/3kw6OKy64Ihu1JRkB232oyTbLDrcnbvrAKPWVSlDXeSR8sWV xui5vq0kV6JQn2y7+bz7ZtN+yAPwn/2GXQrs2cqskcBMNBl9eOpKX15OGU6yrOnc+dKmI9 arIhNwXnYexr1saoUDX9d75Hsz0lJNk5Q0z1NRyqt81d6SX71+ETi3V2RbnDG9qHSfJh1X LobopWfPpf/FXS0Kq/ljVj//Cch+94ScrrSPl+QD6tvntxKAMnGRLEITvQmaGBqBfZR4+u 8qoJWZ6dQMlp9jqcOIYx9da+mn8NnsTIRTvYPwiYq5F/Cw7xY1+CQXit0XuMxA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724848483; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yN9jyQOyMN/e/XaIMu1eY9wQZFbuAoEeMsRJMjJBXFw=; b=E9xi/j9FaRfnUV7OH9K3GAQxIDnCw9Mw26KAiehd39UI3HfdctWEt+HIspMc+tLCTiK/8r lD7fAJ+d/qMZgS8Y5rUiVGNS53bFruAlZ6aCTpaoe0Fle872SbLGl4kjQkjmmuONBT0XVX ywMfYUhGEz7cEtj8Tix4pd5f8ZGpYxltgmR0zq+YddpRrA7qdc6VaCsGENQ1LtkjGCRDp9 +9iys3S9SHQXHk9SsLF6SRMENSHfGBjuyIPUiNUiJyR8st5pJdV+wHPg0emfri2adCC7wk Pzh/LIWyED6oeAtTup1uW3GisaL9sB7cM4jknNCwwXDjLLvNZoC5KxUOPUGuPQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Wv3l72rRszYfJ; Wed, 28 Aug 2024 12:34:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47SCYhA0078262; Wed, 28 Aug 2024 12:34:43 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47SCYhXn078259; Wed, 28 Aug 2024 12:34:43 GMT (envelope-from git) Date: Wed, 28 Aug 2024 12:34:43 GMT Message-Id: <202408281234.47SCYhXn078259@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kristof Provost Subject: git: b1c3a4d75f4f - main - netipsec: add probe points for the ipsec/esp/ah/ipcomp counters List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: b1c3a4d75f4ff74218434a11cdd4e56632e13711 Auto-Submitted: auto-generated The branch main has been updated by kp: URL: https://cgit.FreeBSD.org/src/commit/?id=b1c3a4d75f4ff74218434a11cdd4e56632e13711 commit b1c3a4d75f4ff74218434a11cdd4e56632e13711 Author: Kristof Provost AuthorDate: 2024-08-22 14:41:32 +0000 Commit: Kristof Provost CommitDate: 2024-08-28 10:02:45 +0000 netipsec: add probe points for the ipsec/esp/ah/ipcomp counters Extend what we did for netinet counters in 60d8dbbef075 (netinet: add a probe point for IP, IP6, ICMP, ICMP6, UDP and TCP stats counters, 2024-01-18) to the IPsec code. Sponsored by: Rubicon Communications, LLC ("Netgate") Differential Revision: https://reviews.freebsd.org/D46416 --- sys/netinet/in_kdtrace.c | 93 +++++++++++++++++++++++++++++++++++++++++++++ sys/netinet/in_kdtrace.h | 82 +++++++++++++++++++++++++++++++++++++++ sys/netipsec/ah_var.h | 13 ++++++- sys/netipsec/esp_var.h | 14 ++++++- sys/netipsec/ipcomp_var.h | 14 ++++++- sys/netipsec/ipsec.h | 10 ++++- sys/netipsec/xform_ah.c | 4 +- sys/netipsec/xform_esp.c | 8 ++-- sys/netipsec/xform_ipcomp.c | 4 +- 9 files changed, 226 insertions(+), 16 deletions(-) diff --git a/sys/netinet/in_kdtrace.c b/sys/netinet/in_kdtrace.c index 219bc6482910..bfa57bd8bf1e 100644 --- a/sys/netinet/in_kdtrace.c +++ b/sys/netinet/in_kdtrace.c @@ -341,6 +341,99 @@ MIB_PROBE_TCP(tcps_tlpresend_bytes); MIB_PROBE_TCP(tcps_rcvghostack); MIB_PROBE_TCP(tcps_rcvacktooold); + +#define MIB_PROBE_IPSEC(name) SDT_PROBE_DEFINE1(mib, ipsec, count, name, "int") + +MIB_PROBE_IPSEC(ips_in_polvio); +MIB_PROBE_IPSEC(ips_in_nomem); +MIB_PROBE_IPSEC(ips_in_inval); +MIB_PROBE_IPSEC(ips_out_polvio); +MIB_PROBE_IPSEC(ips_out_nosa); +MIB_PROBE_IPSEC(ips_out_nomem); +MIB_PROBE_IPSEC(ips_out_noroute); +MIB_PROBE_IPSEC(ips_out_inval); +MIB_PROBE_IPSEC(ips_out_bundlesa); + +MIB_PROBE_IPSEC(ips_spdcache_hits); +MIB_PROBE_IPSEC(ips_spdcache_misses); + +MIB_PROBE_IPSEC(ips_clcopied); +MIB_PROBE_IPSEC(ips_mbinserted); +MIB_PROBE_IPSEC(ips_input_front); +MIB_PROBE_IPSEC(ips_input_middle); +MIB_PROBE_IPSEC(ips_input_end); + +#define MIB_PROBE_ESP(name) SDT_PROBE_DEFINE1(mib, esp, count, name, "int") +#define MIB_PROBE2_ESP(name) SDT_PROBE_DEFINE2(mib, esp, count, name, "int", "int") + +MIB_PROBE_ESP(esps_hdrops); +MIB_PROBE_ESP(esps_nopf); +MIB_PROBE_ESP(esps_notdb); +MIB_PROBE_ESP(esps_badkcr); +MIB_PROBE_ESP(esps_qfull); +MIB_PROBE_ESP(esps_noxform); +MIB_PROBE_ESP(esps_badilen); +MIB_PROBE_ESP(esps_wrap); +MIB_PROBE_ESP(esps_badenc); +MIB_PROBE_ESP(esps_badauth); +MIB_PROBE_ESP(esps_replay); +MIB_PROBE_ESP(esps_input); +MIB_PROBE_ESP(esps_output); +MIB_PROBE_ESP(esps_invalid); +MIB_PROBE_ESP(esps_ibytes); +MIB_PROBE_ESP(esps_obytes); +MIB_PROBE_ESP(esps_toobig); +MIB_PROBE_ESP(esps_pdrops); +MIB_PROBE_ESP(esps_crypto); +MIB_PROBE_ESP(esps_tunnel); +MIB_PROBE2_ESP(esps_hist); + +#define MIB_PROBE_AH(name) SDT_PROBE_DEFINE1(mib, ah, count, name, "int") +#define MIB_PROBE_AH2(name) SDT_PROBE_DEFINE2(mib, ah, count, name, "int", "int") + +MIB_PROBE_AH(ahs_hdrops); +MIB_PROBE_AH(ahs_nopf); +MIB_PROBE_AH(ahs_notdb); +MIB_PROBE_AH(ahs_badkcr); +MIB_PROBE_AH(ahs_badauth); +MIB_PROBE_AH(ahs_noxform); +MIB_PROBE_AH(ahs_qfull); +MIB_PROBE_AH(ahs_wrap); +MIB_PROBE_AH(ahs_replay); +MIB_PROBE_AH(ahs_badauthl); +MIB_PROBE_AH(ahs_input); +MIB_PROBE_AH(ahs_output); +MIB_PROBE_AH(ahs_invalid); +MIB_PROBE_AH(ahs_ibytes); +MIB_PROBE_AH(ahs_obytes); +MIB_PROBE_AH(ahs_toobig); +MIB_PROBE_AH(ahs_pdrops); +MIB_PROBE_AH(ahs_crypto); +MIB_PROBE_AH(ahs_tunnel); +MIB_PROBE_AH2(ahs_hist); + +#define MIB_PROBE_IPCOMP(name) SDT_PROBE_DEFINE1(mib, ipcomp, count, name, "int") +#define MIB_PROBE_IPCOMP2(name) SDT_PROBE_DEFINE2(mib, ipcomp, count, name, "int", "int") + +MIB_PROBE_IPCOMP(ipcomps_hdrops); +MIB_PROBE_IPCOMP(ipcomps_nopf); +MIB_PROBE_IPCOMP(ipcomps_notdb); +MIB_PROBE_IPCOMP(ipcomps_badkcr); +MIB_PROBE_IPCOMP(ipcomps_qfull); +MIB_PROBE_IPCOMP(ipcomps_noxform); +MIB_PROBE_IPCOMP(ipcomps_wrap); +MIB_PROBE_IPCOMP(ipcomps_input); +MIB_PROBE_IPCOMP(ipcomps_output); +MIB_PROBE_IPCOMP(ipcomps_invalid); +MIB_PROBE_IPCOMP(ipcomps_ibytes); +MIB_PROBE_IPCOMP(ipcomps_obytes); +MIB_PROBE_IPCOMP(ipcomps_toobig); +MIB_PROBE_IPCOMP(ipcomps_pdrops); +MIB_PROBE_IPCOMP(ipcomps_crypto); +MIB_PROBE_IPCOMP2(ipcomps_hist); +MIB_PROBE_IPCOMP(ipcomps_threshold); +MIB_PROBE_IPCOMP(ipcomps_uncompr); + #endif SDT_PROBE_DEFINE6_XLATE(ip, , , receive, diff --git a/sys/netinet/in_kdtrace.h b/sys/netinet/in_kdtrace.h index 22f181974f93..3fb82ad961dd 100644 --- a/sys/netinet/in_kdtrace.h +++ b/sys/netinet/in_kdtrace.h @@ -333,6 +333,88 @@ SDT_PROBE_DECLARE(mib, tcp, count, tcps_tlpresend_bytes); SDT_PROBE_DECLARE(mib, tcp, count, tcps_rcvghostack); SDT_PROBE_DECLARE(mib, tcp, count, tcps_rcvacktooold); + +SDT_PROBE_DECLARE(mib, ipsec, count, ips_in_polvio); +SDT_PROBE_DECLARE(mib, ipsec, count, ips_in_nomem); +SDT_PROBE_DECLARE(mib, ipsec, count, ips_in_inval); +SDT_PROBE_DECLARE(mib, ipsec, count, ips_out_polvio); +SDT_PROBE_DECLARE(mib, ipsec, count, ips_out_nosa); +SDT_PROBE_DECLARE(mib, ipsec, count, ips_out_nomem); +SDT_PROBE_DECLARE(mib, ipsec, count, ips_out_noroute); +SDT_PROBE_DECLARE(mib, ipsec, count, ips_out_inval); +SDT_PROBE_DECLARE(mib, ipsec, count, ips_out_bundlesa); + +SDT_PROBE_DECLARE(mib, ipsec, count, ips_spdcache_hits); +SDT_PROBE_DECLARE(mib, ipsec, count, ips_spdcache_misses); + +SDT_PROBE_DECLARE(mib, ipsec, count, ips_clcopied); +SDT_PROBE_DECLARE(mib, ipsec, count, ips_mbinserted); +SDT_PROBE_DECLARE(mib, ipsec, count, ips_input_front); +SDT_PROBE_DECLARE(mib, ipsec, count, ips_input_middle); +SDT_PROBE_DECLARE(mib, ipsec, count, ips_input_end); + +SDT_PROBE_DECLARE(mib, esp, count, esps_hdrops); +SDT_PROBE_DECLARE(mib, esp, count, esps_nopf); +SDT_PROBE_DECLARE(mib, esp, count, esps_notdb); +SDT_PROBE_DECLARE(mib, esp, count, esps_badkcr); +SDT_PROBE_DECLARE(mib, esp, count, esps_qfull); +SDT_PROBE_DECLARE(mib, esp, count, esps_noxform); +SDT_PROBE_DECLARE(mib, esp, count, esps_badilen); +SDT_PROBE_DECLARE(mib, esp, count, esps_wrap); +SDT_PROBE_DECLARE(mib, esp, count, esps_badenc); +SDT_PROBE_DECLARE(mib, esp, count, esps_badauth); +SDT_PROBE_DECLARE(mib, esp, count, esps_replay); +SDT_PROBE_DECLARE(mib, esp, count, esps_input); +SDT_PROBE_DECLARE(mib, esp, count, esps_output); +SDT_PROBE_DECLARE(mib, esp, count, esps_invalid); +SDT_PROBE_DECLARE(mib, esp, count, esps_ibytes); +SDT_PROBE_DECLARE(mib, esp, count, esps_obytes); +SDT_PROBE_DECLARE(mib, esp, count, esps_toobig); +SDT_PROBE_DECLARE(mib, esp, count, esps_pdrops); +SDT_PROBE_DECLARE(mib, esp, count, esps_crypto); +SDT_PROBE_DECLARE(mib, esp, count, esps_tunnel); +SDT_PROBE_DECLARE(mib, esp, count, esps_hist); + +SDT_PROBE_DECLARE(mib, ah, count, ahs_hdrops); +SDT_PROBE_DECLARE(mib, ah, count, ahs_nopf); +SDT_PROBE_DECLARE(mib, ah, count, ahs_notdb); +SDT_PROBE_DECLARE(mib, ah, count, ahs_badkcr); +SDT_PROBE_DECLARE(mib, ah, count, ahs_badauth); +SDT_PROBE_DECLARE(mib, ah, count, ahs_noxform); +SDT_PROBE_DECLARE(mib, ah, count, ahs_qfull); +SDT_PROBE_DECLARE(mib, ah, count, ahs_wrap); +SDT_PROBE_DECLARE(mib, ah, count, ahs_replay); +SDT_PROBE_DECLARE(mib, ah, count, ahs_badauthl); +SDT_PROBE_DECLARE(mib, ah, count, ahs_input); +SDT_PROBE_DECLARE(mib, ah, count, ahs_output); +SDT_PROBE_DECLARE(mib, ah, count, ahs_invalid); +SDT_PROBE_DECLARE(mib, ah, count, ahs_ibytes); +SDT_PROBE_DECLARE(mib, ah, count, ahs_obytes); +SDT_PROBE_DECLARE(mib, ah, count, ahs_toobig); +SDT_PROBE_DECLARE(mib, ah, count, ahs_pdrops); +SDT_PROBE_DECLARE(mib, ah, count, ahs_crypto); +SDT_PROBE_DECLARE(mib, ah, count, ahs_tunnel); +SDT_PROBE_DECLARE(mib, ah, count, ahs_hist); + +SDT_PROBE_DECLARE(mib, ipcomp, count, ipcomps_hdrops); +SDT_PROBE_DECLARE(mib, ipcomp, count, ipcomps_nopf); +SDT_PROBE_DECLARE(mib, ipcomp, count, ipcomps_notdb); +SDT_PROBE_DECLARE(mib, ipcomp, count, ipcomps_badkcr); +SDT_PROBE_DECLARE(mib, ipcomp, count, ipcomps_qfull); +SDT_PROBE_DECLARE(mib, ipcomp, count, ipcomps_noxform); +SDT_PROBE_DECLARE(mib, ipcomp, count, ipcomps_wrap); +SDT_PROBE_DECLARE(mib, ipcomp, count, ipcomps_input); +SDT_PROBE_DECLARE(mib, ipcomp, count, ipcomps_output); +SDT_PROBE_DECLARE(mib, ipcomp, count, ipcomps_invalid); +SDT_PROBE_DECLARE(mib, ipcomp, count, ipcomps_ibytes); +SDT_PROBE_DECLARE(mib, ipcomp, count, ipcomps_obytes); +SDT_PROBE_DECLARE(mib, ipcomp, count, ipcomps_toobig); +SDT_PROBE_DECLARE(mib, ipcomp, count, ipcomps_pdrops); +SDT_PROBE_DECLARE(mib, ipcomp, count, ipcomps_crypto); +SDT_PROBE_DECLARE(mib, ipcomp, count, ipcomps_hist); +SDT_PROBE_DECLARE(mib, ipcomp, count, ipcomps_threshold); +SDT_PROBE_DECLARE(mib, ipcomp, count, ipcomps_uncompr); + #endif SDT_PROBE_DECLARE(ip, , , receive); diff --git a/sys/netipsec/ah_var.h b/sys/netipsec/ah_var.h index 7f784a7ddeb3..c77113cf8258 100644 --- a/sys/netipsec/ah_var.h +++ b/sys/netipsec/ah_var.h @@ -71,13 +71,22 @@ struct ahstat { #ifdef _KERNEL #include +#include VNET_DECLARE(int, ah_enable); VNET_DECLARE(int, ah_cleartos); VNET_PCPUSTAT_DECLARE(struct ahstat, ahstat); -#define AHSTAT_ADD(name, val) \ - VNET_PCPUSTAT_ADD(struct ahstat, ahstat, name , (val)) +#define AHSTAT_ADD(name, val) \ + do { \ + MIB_SDT_PROBE1(ah, count, name, (val)); \ + VNET_PCPUSTAT_ADD(struct ahstat, ahstat, name, (val)); \ + } while (0) +#define AHSTAT_INC2(name, type) \ + do { \ + MIB_SDT_PROBE2(ah, count, name, 1, (type)); \ + VNET_PCPUSTAT_ADD(struct ahstat, ahstat, name[type], 1); \ + } while (0) #define AHSTAT_INC(name) AHSTAT_ADD(name, 1) #define V_ah_enable VNET(ah_enable) #define V_ah_cleartos VNET(ah_cleartos) diff --git a/sys/netipsec/esp_var.h b/sys/netipsec/esp_var.h index c1f492913107..3490bf2e3c40 100644 --- a/sys/netipsec/esp_var.h +++ b/sys/netipsec/esp_var.h @@ -72,15 +72,25 @@ struct espstat { #ifdef _KERNEL #include +#include VNET_DECLARE(int, esp_enable); VNET_DECLARE(int, esp_ctr_compatibility); #define V_esp_ctr_compatibility VNET(esp_ctr_compatibility) VNET_PCPUSTAT_DECLARE(struct espstat, espstat); -#define ESPSTAT_ADD(name, val) \ - VNET_PCPUSTAT_ADD(struct espstat, espstat, name, (val)) +#define ESPSTAT_ADD(name, val) \ + do { \ + MIB_SDT_PROBE1(esp, count, name, (val)); \ + VNET_PCPUSTAT_ADD(struct espstat, espstat, name, (val)); \ + } while (0) #define ESPSTAT_INC(name) ESPSTAT_ADD(name, 1) +#define ESPSTAT_INC2(name, type) \ + do { \ + MIB_SDT_PROBE2(esp, count, name, 1, (type)); \ + VNET_PCPUSTAT_ADD(struct espstat, espstat, name[type], 1); \ + } while (0) + #define V_esp_enable VNET(esp_enable) #endif /* _KERNEL */ #endif /*_NETIPSEC_ESP_VAR_H_*/ diff --git a/sys/netipsec/ipcomp_var.h b/sys/netipsec/ipcomp_var.h index 396af64b57a2..3af4a3c199e4 100644 --- a/sys/netipsec/ipcomp_var.h +++ b/sys/netipsec/ipcomp_var.h @@ -66,12 +66,22 @@ struct ipcompstat { #ifdef _KERNEL #include +#include VNET_DECLARE(int, ipcomp_enable); VNET_PCPUSTAT_DECLARE(struct ipcompstat, ipcompstat); -#define IPCOMPSTAT_ADD(name, val) \ - VNET_PCPUSTAT_ADD(struct ipcompstat, ipcompstat, name, (val)) +#define IPCOMPSTAT_ADD(name, val) \ + do { \ + MIB_SDT_PROBE1(ipcomp, count, name, (val)); \ + VNET_PCPUSTAT_ADD(struct ipcompstat, ipcompstat, name, (val)); \ + } while (0) +#define IPCOMPSTAT_INC2(name, type) \ + do { \ + MIB_SDT_PROBE2(ipcomp, count, name, 1, (type)); \ + VNET_PCPUSTAT_ADD(struct ipcompstat, ipcompstat, name[type], \ + 1); \ + } while (0) #define IPCOMPSTAT_INC(name) IPCOMPSTAT_ADD(name, 1) #define V_ipcomp_enable VNET(ipcomp_enable) #endif /* _KERNEL */ diff --git a/sys/netipsec/ipsec.h b/sys/netipsec/ipsec.h index 749813518092..8f3e8f02d88b 100644 --- a/sys/netipsec/ipsec.h +++ b/sys/netipsec/ipsec.h @@ -48,6 +48,8 @@ #include #include +#include + #define IPSEC_ASSERT(_c,_m) KASSERT(_c, _m) /* @@ -295,8 +297,12 @@ VNET_DECLARE(int, crypto_support); VNET_DECLARE(int, async_crypto); VNET_DECLARE(int, natt_cksum_policy); -#define IPSECSTAT_INC(name) \ - VNET_PCPUSTAT_ADD(struct ipsecstat, ipsec4stat, name, 1) +#define IPSECSTAT_INC(name) \ + do { \ + MIB_SDT_PROBE1(ipsec, count, name, 1); \ + VNET_PCPUSTAT_ADD(struct ipsecstat, ipsec4stat, name, 1); \ + } while (0) + #define V_ip4_esp_trans_deflev VNET(ip4_esp_trans_deflev) #define V_ip4_esp_net_deflev VNET(ip4_esp_net_deflev) #define V_ip4_ah_trans_deflev VNET(ip4_ah_trans_deflev) diff --git a/sys/netipsec/xform_ah.c b/sys/netipsec/xform_ah.c index 4619ecaf8197..8f08872eb38a 100644 --- a/sys/netipsec/xform_ah.c +++ b/sys/netipsec/xform_ah.c @@ -731,7 +731,7 @@ ah_input_cb(struct cryptop *crp) error = crp->crp_etype; goto bad; } else { - AHSTAT_INC(ahs_hist[sav->alg_auth]); + AHSTAT_INC2(ahs_hist, sav->alg_auth); crypto_freereq(crp); /* No longer needed. */ crp = NULL; } @@ -1137,7 +1137,7 @@ ah_output_cb(struct cryptop *crp) free(xd, M_AH); crypto_freereq(crp); - AHSTAT_INC(ahs_hist[sav->alg_auth]); + AHSTAT_INC2(ahs_hist, sav->alg_auth); #ifdef REGRESSION /* Emulate man-in-the-middle attack when ipsec_integrity is TRUE. */ if (V_ipsec_integrity) { diff --git a/sys/netipsec/xform_esp.c b/sys/netipsec/xform_esp.c index 599134f056ca..7aec10549e6c 100644 --- a/sys/netipsec/xform_esp.c +++ b/sys/netipsec/xform_esp.c @@ -548,12 +548,12 @@ esp_input_cb(struct cryptop *crp) error = EINVAL; goto bad; } - ESPSTAT_INC(esps_hist[sav->alg_enc]); + ESPSTAT_INC2(esps_hist, sav->alg_enc); /* If authentication was performed, check now. */ if (esph != NULL) { alen = xform_ah_authsize(esph); - AHSTAT_INC(ahs_hist[sav->alg_auth]); + AHSTAT_INC2(ahs_hist, sav->alg_auth); if (crp->crp_etype == EBADMSG) { DPRINTF(("%s: authentication hash mismatch for " "packet in SA %s/%08lx\n", __func__, @@ -1033,9 +1033,9 @@ esp_output_cb(struct cryptop *crp) free(xd, M_ESP); free(crp->crp_aad, M_ESP); crypto_freereq(crp); - ESPSTAT_INC(esps_hist[sav->alg_enc]); + ESPSTAT_INC2(esps_hist, sav->alg_enc); if (sav->tdb_authalgxform != NULL) - AHSTAT_INC(ahs_hist[sav->alg_auth]); + AHSTAT_INC2(ahs_hist, sav->alg_auth); #ifdef REGRESSION /* Emulate man-in-the-middle attack when ipsec_integrity is TRUE. */ diff --git a/sys/netipsec/xform_ipcomp.c b/sys/netipsec/xform_ipcomp.c index 9a8d132d564d..737d4a50098a 100644 --- a/sys/netipsec/xform_ipcomp.c +++ b/sys/netipsec/xform_ipcomp.c @@ -327,7 +327,7 @@ ipcomp_input_cb(struct cryptop *crp) error = EINVAL; goto bad; } - IPCOMPSTAT_INC(ipcomps_hist[sav->alg_comp]); + IPCOMPSTAT_INC2(ipcomps_hist, sav->alg_comp); clen = crp->crp_olen; /* Length of data after processing */ @@ -571,7 +571,7 @@ ipcomp_output_cb(struct cryptop *crp) error = EINVAL; goto bad; } - IPCOMPSTAT_INC(ipcomps_hist[sav->alg_comp]); + IPCOMPSTAT_INC2(ipcomps_hist, sav->alg_comp); if (crp->crp_payload_length > crp->crp_olen) { struct mbuf *mo; From nobody Wed Aug 28 12:55:19 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Wv4C057knz5TCPm; Wed, 28 Aug 2024 12:55:24 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-io1-xd33.google.com (mail-io1-xd33.google.com [IPv6:2607:f8b0:4864:20::d33]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Wv4C02PWDz49V9; Wed, 28 Aug 2024 12:55:24 +0000 (UTC) (envelope-from markjdb@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-io1-xd33.google.com with SMTP id ca18e2360f4ac-81f96ea9ff7so331953239f.3; Wed, 28 Aug 2024 05:55:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724849722; x=1725454522; darn=freebsd.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:sender :from:to:cc:subject:date:message-id:reply-to; bh=QotXNe++o8wiKrtjpoafXTKzxz3hjFp2pe1p5Pbjaiw=; b=aaGwJpeIhVVLhEeyQsKgrEUnWL2MqDB+lqyYt1M20GcMzqIZvTZN5BkCPRJ2+3CF8R xi6qbvselrYONuPULlGbXpmlZ+8ymxK5H8DjRNbHB33GOhHGE7VFhYVkPC0ULApHKXaw r6V2VIt5tHcBAe7RQgn70dp8LuUuYxw3qbRiOtIKY+SOTngjI0SL76EPwH6X2AywdyIh pFCidrQ2akHBjkMXyfwLUd15LFV6r3mS0Vhe87Fttq8sH8arIa7zQaY+KdqnkKFxDq2b pJ5kw3JmpiG17j+mk9lBWrX1fGfxMYafh74e5K0nFJNDJq0HhnZ9PZ1mLPq2zKp0QJSa TJvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724849722; x=1725454522; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QotXNe++o8wiKrtjpoafXTKzxz3hjFp2pe1p5Pbjaiw=; b=P5m3Y8QuMurh+N+CcrpzLt24Fv7bVK+wQSld8Tstt3kuScbpZuoNBXlmRnSNAMIBau pltZUUrbXyjAyUxNy1joKKiH4aC4zu7ZUseosqZ6M76QhqmfXQiR+IUF0uB7tmlUvF/I +eJp/+6LPtent+cEfzJJIJR7+8lXs6lhDxwsFfXl/wvV5Qq+3S/nqQIy56XDUnNj0SbI LKBO/0Ya4D7IfMZho3dH8Zwzypq6IcUTH4I+pdfqbLF3vOdC6tVcJmzQZW5MHigPji5j JdV9HeC/ud5e6J5YK3104xqSPCDrfeCtFYXAyDQytHry73VywWvwdePJxDb/gGkba4Up T3fw== X-Forwarded-Encrypted: i=1; AJvYcCU/+qsE48ax1Kr2UeI74UvYj2ddBLjmLw5iJZb6/uWFFClPVqDbuvDtkPF3qstgBhtjW+MGNf1OpxBZ+iSFiEebKlGu@freebsd.org, AJvYcCVk010LHF/bpGCjwaDnggrpYCX4WPyuZxugS+GXAoIGwW+eFjIYCMJ2mlLjP+YnwiEgqaRZ+IH7+frDAyw7E65QhGfDva8=@freebsd.org X-Gm-Message-State: AOJu0YzXTOlMQnYbHoSi4Bh/wtcD5KHOjYMFntYFilizt+5dm6btmLGh XYXQVOFyYb6vd40gzphKx0TLR8H0b11s3ZXpKqk6VW+TnqTzbUsDnZGwqg== X-Google-Smtp-Source: AGHT+IF4vbEaW5KLV7U3NdL30OufcTN4KOpxweFClcgLPUmqDXeRfgNeb4pH75UPJppMzPdSESktNQ== X-Received: by 2002:a05:6602:4c8b:b0:81f:b38c:3537 with SMTP id ca18e2360f4ac-8278732f8a4mr1653199839f.10.1724849722042; Wed, 28 Aug 2024 05:55:22 -0700 (PDT) Received: from nuc (192-0-220-237.cpe.teksavvy.com. [192.0.220.237]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4ce710698c6sm3018957173.99.2024.08.28.05.55.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Aug 2024 05:55:21 -0700 (PDT) Date: Wed, 28 Aug 2024 08:55:19 -0400 From: Mark Johnston To: Jessica Clarke Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Subject: Re: git: fe66e4caf456 - main - rangelock: Disable cheat mode by default Message-ID: References: <202408272038.47RKc6Ga049071@gitrepo.freebsd.org> <9CF133C9-42AD-41EE-961E-FBD76DD5F592@freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9CF133C9-42AD-41EE-961E-FBD76DD5F592@freebsd.org> X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4Wv4C02PWDz49V9 On Tue, Aug 27, 2024 at 10:09:31PM +0100, Jessica Clarke wrote: > On 27 Aug 2024, at 21:38, Mark Johnston wrote: > > > > The branch main has been updated by markj: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=fe66e4caf4561ee3349ad7a29cc9976108c3b04f > > > > commit fe66e4caf4561ee3349ad7a29cc9976108c3b04f > > Author: Mark Johnston > > AuthorDate: 2024-08-27 20:31:25 +0000 > > Commit: Mark Johnston > > CommitDate: 2024-08-27 20:36:31 +0000 > > > > rangelock: Disable cheat mode by default > > > > Cheat mode is incompatible with code which locks multiple ranges in the > > same vnode, with at least one range being write-locked. This can arise > > in kern_copy_file_range(). Until that's handled somehow, avoid the > > problem to make the fusefs tests stable. > > > > PR: 281073 > > Fixes: 9ef425e560a9 ("rangelocks: add fast cheating mode") > > Reviewed by: kib > > Differential Revision: https://reviews.freebsd.org/D46457 > > --- > > sys/kern/kern_rangelock.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/sys/kern/kern_rangelock.c b/sys/kern/kern_rangelock.c > > index 14163dd1c782..38449f71a8b7 100644 > > --- a/sys/kern/kern_rangelock.c > > +++ b/sys/kern/kern_rangelock.c > > @@ -66,7 +66,7 @@ > > * trylocks are same as normal locks but do not drain. > > */ > > > > -static int rangelock_cheat = 1; > > +static int rangelock_cheat = 0; > > This probably deserves a comment for why it’s disabled/the risks of > enabling it, and/or some text in the sysctl description? There's already a patch which aims to fix the underlying problem, https://reviews.freebsd.org/D46465, so I will hold off on making further changes here. > Jess > > > SYSCTL_INT(_debug, OID_AUTO, rangelock_cheat, CTLFLAG_RWTUN, > > &rangelock_cheat, 0, > > ""); > From nobody Wed Aug 28 14:49:56 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Wv6l93H00z52PgW; Wed, 28 Aug 2024 14:49:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Wv6l90Mtvz4N9m; Wed, 28 Aug 2024 14:49:57 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724856597; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gCEjEgrVuoaUiZEMykZ3+T9Vb0ujTEzIpBll+YnTZGE=; b=YthkF+eubMXD8Uhn+7ne5KXWQkMiaJzLwDs7Q7lLpxi6/rj4V1CctpnR7utgHnrcAw390Y PNUDQFuxFfwjTjWjbhkcxZi1q04Hl506CzKrSjndyCa/wq09+zs09uTd9mjv1NTyUd54et j+rKC0muL027RO6JWPo2QP3yG8sd0PGILmscVC+7xrhoEWWuGBVC4AZkXzo5fvbj51Hkce Ovif1NXoQnUKC0xqdL/ivnV4rkwt3e3SOPVlwzjZJuadbK7qhwiMrMjHLpwV4pDy21zVHA TI1pqkOSeaDJi8Ah40WUE0HQjAeJNLZNHP+lswfMtgdLi53O0758zLMJkOWZnA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724856597; a=rsa-sha256; cv=none; b=YC+nYZvTwbLdDHviZCezkzIUHqlLhksNaRjua6Gy0/J3u+ykbhZzi7m6wtlaIhX+PEG7qH qNhq98K+os6KG5FiChSZT/bZTmIWqMRG3PA+1HNRDGJZBhz3m8zTlFUPL0HaOM0uERgTG1 R5pRj7sTnn6OeKMFy2V7CmIwJ7fKYDsBXCkZOIA5fhtP012I40NF/AIoWY74xrmjSuJUs/ gTgViKkVfPvhRFW1Xg0QXdXHBcnWtKsUnCqkQgGi7OOGr6y6Wv66vFECdP/5LqlF/MzCB5 XzuR0i7VaegZS0dp3twMgy4FdMHBWM9GbCQaXCjAx/ywlk5fPCLCW51eKYE0vA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724856597; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gCEjEgrVuoaUiZEMykZ3+T9Vb0ujTEzIpBll+YnTZGE=; b=vkIONiDmTbzjJis5Y3U+6Qd0tEv1TwpnwLYHlfmIOPursEOT+JuZJZI9ftxKZZPkqbiSZ5 xx9CaPfy5WsOIf5BSUY9348rzxIzEM1IPNcJTNVTAkVabo0v/389Lm6dKgzHlHcpxn0o9E a4KMLrc1QFvS0Sdlo2Gbpz0VFn/7aqyYBTy/Fqe45wF30ZZxBAwHc93EzShXynUri5qYz6 Za5ao6CmZerCGTOyq29X/5bFK97ZcCrEGClqjVOjyn0dVgxhkm8aMx2OiMuD5h5Jt2r6eS HeShqFxvo8LXPgjm3+nlKk5KhU7ClOb8GXSyguC44UJwVQIZ7kn7H4BKC/vGsw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Wv6l86j7tzdc8; Wed, 28 Aug 2024 14:49:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47SEnud7000038; Wed, 28 Aug 2024 14:49:56 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47SEnu78000035; Wed, 28 Aug 2024 14:49:56 GMT (envelope-from git) Date: Wed, 28 Aug 2024 14:49:56 GMT Message-Id: <202408281449.47SEnu78000035@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: 75447afca868 - main - rangelocks: extract the cheat mode drain code List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 75447afca868f82f1c53c5be32dccd777813ec1a Auto-Submitted: auto-generated The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=75447afca868f82f1c53c5be32dccd777813ec1a commit 75447afca868f82f1c53c5be32dccd777813ec1a Author: Konstantin Belousov AuthorDate: 2024-08-27 21:32:51 +0000 Commit: Konstantin Belousov CommitDate: 2024-08-28 14:33:46 +0000 rangelocks: extract the cheat mode drain code Reviewed by: markj Tested by: lwhsu Sponsored by: The FreeBSD Foundation Differential revision: https://reviews.freebsd.org/D46465 --- sys/kern/kern_rangelock.c | 30 +++++++++++++++++++----------- 1 file changed, 19 insertions(+), 11 deletions(-) diff --git a/sys/kern/kern_rangelock.c b/sys/kern/kern_rangelock.c index 38449f71a8b7..0e62b91b4ee7 100644 --- a/sys/kern/kern_rangelock.c +++ b/sys/kern/kern_rangelock.c @@ -82,6 +82,24 @@ SYSCTL_INT(_debug, OID_AUTO, rangelock_cheat, CTLFLAG_RWTUN, #define RL_RET_CHEAT_RLOCKED 0x1100 #define RL_RET_CHEAT_WLOCKED 0x2200 +static void +rangelock_cheat_drain(struct rangelock *lock) +{ + uintptr_t v; + + DROP_GIANT(); + for (;;) { + v = (uintptr_t)atomic_load_ptr(&lock->head); + if ((v & RL_CHEAT_DRAINING) == 0) + break; + sleepq_add(&lock->head, NULL, "ranged1", 0, 0); + sleepq_wait(&lock->head, PRI_USER); + sleepq_lock(&lock->head); + } + sleepq_release(&lock->head); + PICKUP_GIANT(); +} + static bool rangelock_cheat_lock(struct rangelock *lock, int locktype, bool trylock, void **cookie) @@ -99,17 +117,7 @@ drain: } sleepq_lock(&lock->head); drain1: - DROP_GIANT(); - for (;;) { - v = (uintptr_t)atomic_load_ptr(&lock->head); - if ((v & RL_CHEAT_DRAINING) == 0) - break; - sleepq_add(&lock->head, NULL, "ranged1", 0, 0); - sleepq_wait(&lock->head, PRI_USER); - sleepq_lock(&lock->head); - } - sleepq_release(&lock->head); - PICKUP_GIANT(); + rangelock_cheat_drain(lock); return (false); } From nobody Wed Aug 28 14:49:57 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Wv6lB2SQ2z52Ppb; Wed, 28 Aug 2024 14:49:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Wv6lB0r43z4NHL; Wed, 28 Aug 2024 14:49:58 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724856598; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=UQ05eBOA197Ve+Wb/r+6omAuu0zH9oXizzN/mxeDcx0=; b=F8OSSE99E9h77OHIsat9c44KneAwqXMHqzZ0/8+vtnPKFLIBJel/0/Uua8CqCrAALIpjQR e7F3my6fP9PmbDUu+cu3YWgQ8zAsomERcaO0kt0OXi6z+a7j133hesOsX58Gf/iF32JqdR Z9Y7/dKTFLgq2aDCi+Twqbeuc1AJN7uKjPh7Z6kpGINgk2Bx4SebJkUaiYJXGu79ffAQ1L r3wti51JfWUNBubrNH10jdwzn5WgeUyEQEf8zXc8xBXJaR3eQQpS/LYca7Er7Xp+rqmr2m cdpoTFn12giKB7kOE3h7U465IFCmdLOgRw+RcS8pYk/wmJpku2UHbfAC385VFg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724856598; a=rsa-sha256; cv=none; b=c5t0VovcCp6zXqP3e7w7rmYEADIszMwBfSwOocckNFZQn/0y7PvmzdQcsu8h10jT2mD8IB iehc9TGQYiy7JjtPKK9IUDCusIvqho6Q1BR3kRPw+m0X8mPE7pLTSKwaM7/8gNjef99Epj Kb/XeQessXOLGQuDa8u3aXIJtWhzdKWyfTIMj657kvLyJvav8Bvg1VVK6n0c+dyoPFKjoD t/YjaWAACyNl0gYr1jB4dAQ7bheGAb+n/FgtpfRfgyCA+m8qNzUBt4/y91EUr/ki4Dieek i09qtZKkWPHjSk4KXqIROoT+R39SD14GMqowvNZ/YHw+Y/FfX/XDgIDq1WLAWQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724856598; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=UQ05eBOA197Ve+Wb/r+6omAuu0zH9oXizzN/mxeDcx0=; b=SoIZhgbXSP1r5syjEHnOfHxT3MFrAK5UbG4Sf1ILvD06o0l4yJE9MH7+DkpgFZgsAuRq41 7RpqVPqICusrtL9RZxAqQVIMpzHZuy9uDcyFUzHrSA3o03zBQ98hh+eh2ag3z0CIXyG5Xy hZiJIw6LRTUOAGG36O/ToM7XrSjWTwKclQ4EhpCh49u70uBGb5E+kan+aGIZNrbaLIFIYf bWwvzhVx95lITavAoCMgUCX5gSqB8vxcFGM3QKA8/sigoMidUtNWjsj9gqTtYB9/hzztvt DdL7QZv/iSZtUxxwbPrwPaFVQPcGAyZc59FU1stZKIcunATlSVb+EO3VWWtkwQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Wv6lB06ftzdtY; Wed, 28 Aug 2024 14:49:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47SEnvJD000120; Wed, 28 Aug 2024 14:49:57 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47SEnvLx000116; Wed, 28 Aug 2024 14:49:57 GMT (envelope-from git) Date: Wed, 28 Aug 2024 14:49:57 GMT Message-Id: <202408281449.47SEnvLx000116@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: 0b6b1c285920 - main - Add rangelock_may_recurse(9) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 0b6b1c285920563ba0c119d3190ac25af4731d02 Auto-Submitted: auto-generated The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=0b6b1c285920563ba0c119d3190ac25af4731d02 commit 0b6b1c285920563ba0c119d3190ac25af4731d02 Author: Konstantin Belousov AuthorDate: 2024-08-27 21:33:38 +0000 Commit: Konstantin Belousov CommitDate: 2024-08-28 14:33:58 +0000 Add rangelock_may_recurse(9) Reviewed by: markj Tested by: lwhsu Sponsored by: The FreeBSD Foundation Differential revision: https://reviews.freebsd.org/D46465 --- sys/kern/kern_rangelock.c | 41 +++++++++++++++++++++++++++++++++++++++++ sys/sys/rangelock.h | 1 + 2 files changed, 42 insertions(+) diff --git a/sys/kern/kern_rangelock.c b/sys/kern/kern_rangelock.c index 0e62b91b4ee7..4d74c02302e7 100644 --- a/sys/kern/kern_rangelock.c +++ b/sys/kern/kern_rangelock.c @@ -752,6 +752,47 @@ rangelock_trywlock(struct rangelock *lock, vm_ooffset_t start, vm_ooffset_t end) return (rangelock_lock_int(lock, true, start, end, RL_LOCK_WRITE)); } +/* + * If the caller asserts that it can obtain the range locks on the + * same lock simultaneously, switch to the non-cheat mode. Cheat mode + * cannot handle it, hanging in drain or trylock retries. + */ +void +rangelock_may_recurse(struct rangelock *lock) +{ + uintptr_t v, x; + + v = atomic_load_ptr(&lock->head); + if ((v & RL_CHEAT_CHEATING) == 0) + return; + + sleepq_lock(&lock->head); + for (;;) { + if ((v & RL_CHEAT_CHEATING) == 0) { + sleepq_release(&lock->head); + return; + } + + /* Cheating and locked, drain. */ + if ((v & RL_CHEAT_WLOCKED) != 0 || + (v & ~RL_CHEAT_MASK) >= RL_CHEAT_READER) { + x = v | RL_CHEAT_DRAINING; + if (atomic_fcmpset_ptr(&lock->head, &v, x) != 0) { + rangelock_cheat_drain(lock); + return; + } + continue; + } + + /* Cheating and unlocked, clear RL_CHEAT_CHEATING. */ + x = 0; + if (atomic_fcmpset_ptr(&lock->head, &v, x) != 0) { + sleepq_release(&lock->head); + return; + } + } +} + #ifdef INVARIANT_SUPPORT void _rangelock_cookie_assert(void *cookie, int what, const char *file, int line) diff --git a/sys/sys/rangelock.h b/sys/sys/rangelock.h index 127f101ddc2e..accf33d7296b 100644 --- a/sys/sys/rangelock.h +++ b/sys/sys/rangelock.h @@ -66,6 +66,7 @@ void *rangelock_wlock(struct rangelock *lock, vm_ooffset_t start, void *rangelock_trywlock(struct rangelock *lock, vm_ooffset_t start, vm_ooffset_t end); void rangelock_entry_free(struct rl_q_entry *e); +void rangelock_may_recurse(struct rangelock *lock); #if defined(INVARIANTS) || defined(INVARIANT_SUPPORT) void _rangelock_cookie_assert(void *cookie, int what, const char *file, int line); From nobody Wed Aug 28 14:50:00 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Wv6lD3V4kz52PkK; Wed, 28 Aug 2024 14:50:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Wv6lD1xd2z4NXG; Wed, 28 Aug 2024 14:50:00 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724856600; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=dnWKhuP8AJCOb4uPXUj6zgHLnK+MIoHa6raSNluAOZM=; b=C/uXgfBFzzvBJEQRJOFgTcBBbDYbtfyg+w0u+Y+diYvX52APtwC69+7RAZRBjsermAbKhF n6QBHtP59SVat3jojNI8HxoFOHVOeyaox2lG50c/+QRYjdJvYLBq6UnUOS1nbuwWp/z/9c fnWW2+YgD8m9Pxu59SBXrlTSH/H1ZyFctYR8XLqREZ7WMiDaIUsuNNf2QqdmTWjpsGw1yj Q64Gcwnsjznim03EtgfpXWGRKrCdHZizGkEaO9tgJqkHk4j6V00ldjtnGxtlsd6PSyiOIP BZSljZB8vvAD03Tpahfy787igbQCo1SLWc2y6Q/3nxH6Bkem3kkHNI/nfxz+Gg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724856600; a=rsa-sha256; cv=none; b=Fxp0YLyJtWxAA28By+VimA9nMp24r8gUqn0t/M94Aq2DMtZkocGT3pCmktvbkPoSqWlq29 o6eprRhJApJ9Lbow2qaPGdFn6RTxWa/UiybtUbMo9Q0Z66sVL4MAzgZvKgxTwuYLpAfrr4 ni7B5YeYeyhE+fW2pmEixs0CQ1+Npjnzo/RWlZ5jJIVgFt3WaanaZ4mf32aQ+0X4HOSUNL 26QZRpPR9KcEZeB0ixL546DwCD8IKWRcaeM3XngHkbaXExeUZVuC8E0yU/d7rv2/pZzad8 fqQM+Ek49Ej3OGhpRsJnTvvwOn4FtndemJtQFWXoaU/c971PFC2V7rJUPnCe4w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724856600; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=dnWKhuP8AJCOb4uPXUj6zgHLnK+MIoHa6raSNluAOZM=; b=opj2og4ZYHc8Au9/rsdhTGCsyZWGajFoCgsxZqRghViApGLaH7XGkgpWStpVm5JNc2MAo1 biZcY8t8yQYD+BomTgn5XpZeGv+lmcowtH+NvyB3hluT+o4rkZrtHAE/yb+OQSN7Z+n9h0 8tVS4VxghZFo1FeRs9spmZjwnMBSLWw8mN06xRsB68H2Zo5gzny/0GpQmMsqIdHStWOjVm DH0pZTfvL5oOwNgipMxamMdkQRiIIRmzJDHeIaOYfhp7Rh4TvKwRCBqPkauIa+Mcs/fMEa ZDRAbuUmxtTI3YFWk75nIscJOaQgThDdlsmKQ36Q69ubmui7T95dCmdWtKR0mA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Wv6lD1XZyzdfZ; Wed, 28 Aug 2024 14:50:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47SEo0OL000248; Wed, 28 Aug 2024 14:50:00 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47SEo0CM000245; Wed, 28 Aug 2024 14:50:00 GMT (envelope-from git) Date: Wed, 28 Aug 2024 14:50:00 GMT Message-Id: <202408281450.47SEo0CM000245@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: 5378962154e0 - main - rangelocks: re-enable cheat mode List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 5378962154e08e9af43a9e8e832d0dc81a4f4517 Auto-Submitted: auto-generated The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=5378962154e08e9af43a9e8e832d0dc81a4f4517 commit 5378962154e08e9af43a9e8e832d0dc81a4f4517 Author: Konstantin Belousov AuthorDate: 2024-08-27 21:38:21 +0000 Commit: Konstantin Belousov CommitDate: 2024-08-28 14:34:54 +0000 rangelocks: re-enable cheat mode Tested by: lwhsu Reviewed by: markj Sponsored by: The FreeBSD Foundation Differential revision: https://reviews.freebsd.org/D46465 --- sys/kern/kern_rangelock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/kern/kern_rangelock.c b/sys/kern/kern_rangelock.c index 4d74c02302e7..580910597c08 100644 --- a/sys/kern/kern_rangelock.c +++ b/sys/kern/kern_rangelock.c @@ -66,7 +66,7 @@ * trylocks are same as normal locks but do not drain. */ -static int rangelock_cheat = 0; +static int rangelock_cheat = 1; SYSCTL_INT(_debug, OID_AUTO, rangelock_cheat, CTLFLAG_RWTUN, &rangelock_cheat, 0, ""); From nobody Wed Aug 28 14:49:59 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Wv6lC3Wnlz52PgY; Wed, 28 Aug 2024 14:49:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Wv6lC1KQpz4N0F; Wed, 28 Aug 2024 14:49:59 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724856599; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=G+qVAncLdqvTsT6tYyi8FExSCz1sAw/o1IxxdGHwOpw=; b=yxRXEmeVPj3ZlqzJDEn2Pd46as58ElWI6ud12Pp+IGM4ilniEs6i3im1hf6+nhLL6s00U4 9mB33GFewsdCyjaOOnZAUBmiI03jXw1sYQCFSzruIRJUbTENUGhXqeQFz7KzrAaIf+/Rjn 3kgeRn5qvbpw7PjySZYjPPsUWWgNOdvJH0/Ks06AMPxvWL2r/i1tpxxRgvQoAWkeJo0K54 OWeyJYUQJa5Kn4P9F7NURZoTNP5DkbnT6BPz+1JTTY9af8+4k0Y3mrTye8pu34unESB78W fjB8vJAt01bugL8qtmuNh50GBOY0G54a4m0YUspDcuRlyv2OgjCsiywHFSt/vg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724856599; a=rsa-sha256; cv=none; b=O/WsqCsvOP6ZmBgZUu3l4BBD2z4Vwt47oE2/kniK1uz7PPaMRgWceRxWZ9kC3B7sZQdUmo Mda0NmwjPA0rwZFH+p6E+GpMxG6qZPl3YXnf7kskULM1cA34DATXxnGaVgsaudq2oqr2ws htfuLqV97nHsTy2sC91UK7v/b1PukrntCNWHzbm83qwB1PYeS8hFGF6ffMzNiLwjEMd5Pj i27vK1ypxtVIkwIoMZDZc+tf7hB36N48UThFP+Reu47rfRdlJRQvmfztT5iMJmtIQK7fyt olosCj9TSx9zNQP5/JCHmSjQmBCMrmQbA7L4HsVsqdqlN4/SaWjr5RUp69haeA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724856599; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=G+qVAncLdqvTsT6tYyi8FExSCz1sAw/o1IxxdGHwOpw=; b=jX1w3+aJRE5+3FH4X+kNzVcHVDP5COn2UNbs+9CEyzI+l8wVsQHhQbhkiOoC8tK30nUXHg a1kSKE4bStIUSwn7eBoJcZkVOxKhaSGRbBLV3+CfkaUueVPcU649s2qMFIIdJATwhhxtHI lmMpJJulbh7pFEOwavq9+5lNdYU128fikc7ml626h3abvAHN2XJFmB2/9w3ztz5YjjpuRx /HgupUBqZYsCViRNMYapuoz/sH00fRdmVLqzEtI37eao12Vm+AtqRx7/ZZvq1MKY43R8fw K+1UqKZgvty5s9VSDMLh3uVf7Su8y90UqKFhX5s62cunMjQc5fphNtL2OcuwNg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Wv6lC0x0yzdB6; Wed, 28 Aug 2024 14:49:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47SEnxdT000170; Wed, 28 Aug 2024 14:49:59 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47SEnxbG000165; Wed, 28 Aug 2024 14:49:59 GMT (envelope-from git) Date: Wed, 28 Aug 2024 14:49:59 GMT Message-Id: <202408281449.47SEnxbG000165@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: 4e1f29b92dc5 - main - kern_copy_file_range(): handle rangelock recursion List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 4e1f29b92dc5fdc84d646eb3c16a4155b6ec688d Auto-Submitted: auto-generated The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=4e1f29b92dc5fdc84d646eb3c16a4155b6ec688d commit 4e1f29b92dc5fdc84d646eb3c16a4155b6ec688d Author: Konstantin Belousov AuthorDate: 2024-08-27 21:34:16 +0000 Commit: Konstantin Belousov CommitDate: 2024-08-28 14:34:40 +0000 kern_copy_file_range(): handle rangelock recursion PR: 281073 Reviewed by: markj Tested by: lwhsu Sponsored by: The FreeBSD Foundation Differential revision: https://reviews.freebsd.org/D46465 --- sys/kern/vfs_syscalls.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/sys/kern/vfs_syscalls.c b/sys/kern/vfs_syscalls.c index 28ab3080c075..ab0e562e73aa 100644 --- a/sys/kern/vfs_syscalls.c +++ b/sys/kern/vfs_syscalls.c @@ -4978,11 +4978,13 @@ kern_copy_file_range(struct thread *td, int infd, off_t *inoffp, int outfd, * If infp and outfp refer to the same file, the byte ranges cannot * overlap. */ - if (invp == outvp && ((savinoff <= savoutoff && savinoff + len > - savoutoff) || (savinoff > savoutoff && savoutoff + len > - savinoff))) { - error = EINVAL; - goto out; + if (invp == outvp) { + if ((savinoff <= savoutoff && savinoff + len > savoutoff) || + (savinoff > savoutoff && savoutoff + len > savinoff)) { + error = EINVAL; + goto out; + } + rangelock_may_recurse(&invp->v_rl); } /* Range lock the byte ranges for both invp and outvp. */ From nobody Wed Aug 28 14:50:01 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Wv6lF5lssz52PmV; Wed, 28 Aug 2024 14:50:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Wv6lF2WlJz4NXc; Wed, 28 Aug 2024 14:50:01 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724856601; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=XWRyixoKzttHFSzJoE8eHwpXjarjRce7ydfs4sYVm+U=; b=MtsIiFTj6J0ZbMi4R5GTbzro9JvdSaiEBF51cVNYr8PEoVkWPGLlzeU25H56xG/E5DrS9a xIpY29HNtmmbXwOiV+KcNNpdTQDJbmMKuMaDPrQVlvXrBupZKzR1jakWJrC6n0tJ1SMWMo qNRRz3VQ+RTBhN5O4rYaXb/J9bOTgIngcXQYKdbN7MHX1K4BAeOiXg9Rj8oa4sLWNZWMuD BdOBDYtm6yiIHvTIVnebvk62j20uOx3+GLmxeqT8rmI4IpHXryROuQ0tmpP2jy/KqsOuzk Np369oMPikDW6+9drkKxGSQmeDERhszQpSLfYmJMPuy1xfMtl6tkkrzwTw/KqA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724856601; a=rsa-sha256; cv=none; b=Z2wf222RpR2AuxXJAjoCVZSNeDqDRiYywmMFYEzVTd5FNcRz7auwbxC5D2K7r+54puryZu EPvglVkLnR9tozMQeVP72QLmvku2L4Z9H43c9XtEs2CS0AMmPtlGhk+uoFsI3IXRqexqjI cvecLmnvCDwWallD3ahJT9sAPJ6Y4hHJwDdOTuAn8xfl07uD3NsZvEhclNSVQnFB6s28v/ uQse+eI0ED+ySLfzHLb08jUZaREc/HcbNqwf3bcI1I2ZGI/WNUAq5RAzDvEVR7PJAeU7Iw CMy4oCp/a5wIJrznORNOWPb8wFPXghMRxnLIr+Vg80+9Cxi9KzmHLdTL17aeJQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724856601; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=XWRyixoKzttHFSzJoE8eHwpXjarjRce7ydfs4sYVm+U=; b=gvKe/wUziBtps7qZx53Vu2lwenryaEzYsum9+keCGY63XITfJhikZs5E/O6AVCfZg3yhU8 6DfhLJfrp7dtRNk6mKTb7SNxuxllBJjy7bPNMoURSWYfk47mBv0YiT5MP1af3PXZ696fdQ IADqPtQNjbtBRoq3saQB5JPxIt6/ypiYJLPaJWj+6UzcY6aHbhrY72fk6tC/eGiJzXfoqG xzzR0ITFxooLQSBJ8jqjM/Y6HvIQ7ZblU7g4rGEPqvOrnhaHzp9aGst0/69tF2PRdYYWzL v+wHaVVWM8ni+m3BlHAQn2UGxT6nIvHDxI1ZHkDt4LoBndTQzfdebsw5phd7Cw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Wv6lF24GbzdhQ; Wed, 28 Aug 2024 14:50:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47SEo1Vg002009; Wed, 28 Aug 2024 14:50:01 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47SEo1SK001989; Wed, 28 Aug 2024 14:50:01 GMT (envelope-from git) Date: Wed, 28 Aug 2024 14:50:01 GMT Message-Id: <202408281450.47SEo1SK001989@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: e1f4d623779d - main - rangelocks: remove unneeded cast of the atomic_load_ptr() result List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: e1f4d623779df3b05b58ca06aaa8ae0b0a1c9ef7 Auto-Submitted: auto-generated The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=e1f4d623779df3b05b58ca06aaa8ae0b0a1c9ef7 commit e1f4d623779df3b05b58ca06aaa8ae0b0a1c9ef7 Author: Konstantin Belousov AuthorDate: 2024-08-28 13:30:04 +0000 Commit: Konstantin Belousov CommitDate: 2024-08-28 14:35:06 +0000 rangelocks: remove unneeded cast of the atomic_load_ptr() result Noted and reviewed by: markj Sponsored by: The FreeBSD Foundation Differential revision: https://reviews.freebsd.org/D46465 --- sys/kern/kern_rangelock.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sys/kern/kern_rangelock.c b/sys/kern/kern_rangelock.c index 580910597c08..3a11059a7f64 100644 --- a/sys/kern/kern_rangelock.c +++ b/sys/kern/kern_rangelock.c @@ -89,7 +89,7 @@ rangelock_cheat_drain(struct rangelock *lock) DROP_GIANT(); for (;;) { - v = (uintptr_t)atomic_load_ptr(&lock->head); + v = atomic_load_ptr(&lock->head); if ((v & RL_CHEAT_DRAINING) == 0) break; sleepq_add(&lock->head, NULL, "ranged1", 0, 0); @@ -106,7 +106,7 @@ rangelock_cheat_lock(struct rangelock *lock, int locktype, bool trylock, { uintptr_t v, x; - v = (uintptr_t)atomic_load_ptr(&lock->head); + v = atomic_load_ptr(&lock->head); if ((v & RL_CHEAT_CHEATING) == 0) return (false); if ((v & RL_CHEAT_DRAINING) != 0) { @@ -190,7 +190,7 @@ rangelock_cheat_unlock(struct rangelock *lock, void *cookie) { uintptr_t v, x; - v = (uintptr_t)atomic_load_ptr(&lock->head); + v = atomic_load_ptr(&lock->head); if ((v & RL_CHEAT_CHEATING) == 0) return (false); @@ -259,7 +259,7 @@ rangelock_cheat_destroy(struct rangelock *lock) { uintptr_t v; - v = (uintptr_t)atomic_load_ptr(&lock->head); + v = atomic_load_ptr(&lock->head); if ((v & RL_CHEAT_CHEATING) == 0) return (false); MPASS(v == RL_CHEAT_CHEATING); From nobody Wed Aug 28 16:58:37 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Wv9bd6dxbz52bPv; Wed, 28 Aug 2024 16:58:37 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Wv9bd69Rcz4cj4; Wed, 28 Aug 2024 16:58:37 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724864317; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=92Q2ETsWBQ1uAfOHlg9mjSARrcE+9lUPn4MSpzoUGcQ=; b=KFphumuO4x5iqwjm8g1xoYYvnPkXuY+Te2R95cAgFVJXwv3GIDA1lzMJHe17bTJw/5MH1W YC6BLVnJAEd77syrsm2EeCsIJHBacmkYFdPRgKwX69QE43QGndJSqPaCiIBgOQEUvzzTWZ BnT4e7rwqg5cN0oSI1jCzS/wttIzRVk1MrGOIqIfRJQnmvVw/dG2FCF0ZvbdWyGVhUDZ8P kMU/GfqbF5eWk4kSaAYseBBlK2u5ftCSeqh4jMhHEXo2ZbjCRmEICJkToMbsgqnXpwijJ+ iAqTQ2xxs7FIpBuVER+3t4XmCIMp5SUmZ8HkWsrSm9I9b1d8pbL4bLCFo3Lz0w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724864317; a=rsa-sha256; cv=none; b=UekKgfpJMMTgDanSOwJXND+RTp925qWe8AOTjndngqpGHDTN93HD7uZXoCvI7hthkRY3vv tP8XAqIwbgILI8wn7RzY1k+H+G616GlRZs5khO3su5GWB6EKUq1FbqQ7J0rF7D1YDLU0f7 ewvSA6nD8d/Xln4ciVCH5OY000KLeNsZkx4g/MV8VRy4sR1AP90LcvdHl98H/BMPSVHKdn RPcojee9OrwxweNGtrI0qRk4oZpVOiVo2gqiVT+5d8JYVDEbxpLQ8k9kWmFHCnmeus4FVY oSEeLesQdZos8Z4xGJeDM6/cPZimGkRQ9lcrzzPNW/3w93kM5XFQA5pAT5nZBw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724864317; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=92Q2ETsWBQ1uAfOHlg9mjSARrcE+9lUPn4MSpzoUGcQ=; b=pl08Qnul1AcWm9dw0/4M6T3ZDFZRLqM1GzwiyKQm1V6D2dbR0aH9qdaQR+QrhnKWyyLg8o rxzrD7CzyZuIZX+HlIb1YrVPFrggjLMomEQ5docihzZGxldbIKMwiQGfuqVZB8ttDtj/di xy4S9KgbOIWTxgrFscHvesMazd+ctFsOyJvR5VchdXE6Op4+e9TXmWpCq3rYwXNLBjxQy8 7Z1g1MsnLWrRyOlrbeJhD8Uyjoou++eB6Phm9WrPL4j0d6ktAyGVVfhB4Mp3DBo/FPMy2b cf5+DrEG1tBxqN4kJOy457TjW28ke7UjuQb2RQnAn7RrMLKcjPGdBUIENt3ytw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Wv9bd5fVVzhjP; Wed, 28 Aug 2024 16:58:37 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47SGwbnK020600; Wed, 28 Aug 2024 16:58:37 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47SGwbb4020596; Wed, 28 Aug 2024 16:58:37 GMT (envelope-from git) Date: Wed, 28 Aug 2024 16:58:37 GMT Message-Id: <202408281658.47SGwbb4020596@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Stefan =?utf-8?Q?E=C3=9Fer?= Subject: git: 5b0dc991093c - main - vendor/bc: upgrade to version 7.0.1 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: se X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 5b0dc991093c82824f6fe566af947f64f5072264 Auto-Submitted: auto-generated The branch main has been updated by se: URL: https://cgit.FreeBSD.org/src/commit/?id=5b0dc991093c82824f6fe566af947f64f5072264 commit 5b0dc991093c82824f6fe566af947f64f5072264 Author: Stefan Eßer AuthorDate: 2024-08-28 16:46:05 +0000 Commit: Stefan Eßer CommitDate: 2024-08-28 16:52:54 +0000 vendor/bc: upgrade to version 7.0.1 This update fixes building bc on FreeBSD with non-default compilers (GCC-12, GCC-13). GCC warned about casting argv from non-const to const and since warnings are treated as errors, the build failed. (cherry picked from commit 1e19146fc7692f59e8dfc5da7957e938cd0b81b8) --- contrib/bc/NEWS.md | 6 ++++++ contrib/bc/include/version.h | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/contrib/bc/NEWS.md b/contrib/bc/NEWS.md index 1775fa0b6533..8156b673ce04 100644 --- a/contrib/bc/NEWS.md +++ b/contrib/bc/NEWS.md @@ -1,5 +1,11 @@ # News +## 7.0.1 + +This is a production release that fixes a warning using GCC on FreeBSD. + +Other users do ***NOT*** need to upgrade. + ## 7.0.0 This is a production release to fix three bugs. diff --git a/contrib/bc/include/version.h b/contrib/bc/include/version.h index 897a19530e3f..4d2f6acfb433 100644 --- a/contrib/bc/include/version.h +++ b/contrib/bc/include/version.h @@ -37,6 +37,6 @@ #define BC_VERSION_H /// The current version. -#define VERSION 7.0.0 +#define VERSION 7.0.1 #endif // BC_VERSION_H From nobody Wed Aug 28 18:35:23 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WvClH56hLz5MWqY; Wed, 28 Aug 2024 18:35:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WvClH4bvgz4kyv; Wed, 28 Aug 2024 18:35:23 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724870123; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+MCHFtwQWgw1KTM/sk+nGNy1ev6c2VMVRWg6/drIh34=; b=qY0KpgUrVg+rQAwFqcQOLUb1eGmjPTJBCv9VQpdAcX9aO1ifITdsjIcE+B3fjgnHdze45c WU6spVTQ2gIUB3Lu+5tLxqt9FCM0zf05kiMECidjZTEe3GeU+0QctR77ErXaxAd1+UaBdZ WOOl5gkUVLGMXyUGQIeTVmLdhWwtsfNscHLXQIrRBIEPQBgF/QSYEtWu4qUr55Z/jDfzn3 POFQ4peluLRaRkQ0G/HkkQ+KydlB3RvfGZlHBRnLwGjv2WjjOGeiI2UTMgmWFSg05xP1lb qp1ol0qJ7JPlvpfIHWZmFbg+w/hJkL524dvnhoWGbD1TG9Xb6EfqthXKW3Ip+A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724870123; a=rsa-sha256; cv=none; b=kmYi2B5ZlahPU+RxEkhDxAchVsOn8g6LTwvqCGl8qnT4tNGEqjWf/BMZtR7/8IzlcH+GdR +bEglzH+SrCT485lrriVFoOuxSMxgObV2fBRDz23724RXbl0rUyPKHnCiLk7h5b/LdsYF5 aSipohQAXU+Ey9pACnjQYIewNCpdyUyXBi2SFG4uasnFGGxeHq0GKNv+wV8zjRLdHmnDx3 9oGrIPED8OtHiANOMVLPFKj5ZKgPoUT+IsqXmWZFVB737TFAn0J2QD5LTJQg24h+DZ6o/p Eq/MHiQdz90gJvB7RKqKIa5UL1b2zlgtpEG6Ys9MJC3cecVd3r46AqxfChnZWw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724870123; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+MCHFtwQWgw1KTM/sk+nGNy1ev6c2VMVRWg6/drIh34=; b=ykNN+0xd47VIcuyyXfdfOPcvQVyyqZ5pFJaLI18tDhyTVn/4yDkmLMGrIr11ttfyu1kg3X aZcquPgpsZcH17YibJR1BKMBRxQ9ISwJWTXcpa4Gj5uwTJhweNRc6ERIN6bqGWk8T+k4gr mlV6G1Yr1E4nIyJdxstgF52J1Y6AhYp4NlfQT3jW3FEc+IhFSRStkDZt6v44Iyd30/df+R /7cYT87iWkEVtQImRjR4slpU4xnpi1EOHb20i/17Hh1lIN46voN9oeRrhTuKGwAxpV0KIG zHmH/r2WO5KXS/bcEKrsYefFj2q7EburyWfD/rsuKWn77VrRaG7CQ9HyyPOeyQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WvClH4C9Lzkt2; Wed, 28 Aug 2024 18:35:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47SIZNen090764; Wed, 28 Aug 2024 18:35:23 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47SIZNiN090761; Wed, 28 Aug 2024 18:35:23 GMT (envelope-from git) Date: Wed, 28 Aug 2024 18:35:23 GMT Message-Id: <202408281835.47SIZNiN090761@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Navdeep Parhar Subject: git: 1e584ca30e3a - main - cxgbe(4): Export the core suspend/resume functionality to other modules. List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: np X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 1e584ca30e3a97eedf37368e7ad75c31f08be039 Auto-Submitted: auto-generated The branch main has been updated by np: URL: https://cgit.FreeBSD.org/src/commit/?id=1e584ca30e3a97eedf37368e7ad75c31f08be039 commit 1e584ca30e3a97eedf37368e7ad75c31f08be039 Author: Navdeep Parhar AuthorDate: 2024-08-28 17:18:03 +0000 Commit: Navdeep Parhar CommitDate: 2024-08-28 18:20:26 +0000 cxgbe(4): Export the core suspend/resume functionality to other modules. MFC after: 1 week Sponsored by: Chelsio Communications --- sys/dev/cxgbe/adapter.h | 2 ++ sys/dev/cxgbe/t4_main.c | 54 ++++++++++++++++++++++++++++--------------------- 2 files changed, 33 insertions(+), 23 deletions(-) diff --git a/sys/dev/cxgbe/adapter.h b/sys/dev/cxgbe/adapter.h index 3922bd3909fe..2769277e8411 100644 --- a/sys/dev/cxgbe/adapter.h +++ b/sys/dev/cxgbe/adapter.h @@ -1392,6 +1392,8 @@ void release_tid(struct adapter *, int, struct sge_wrq *); int cxgbe_media_change(if_t); void cxgbe_media_status(if_t, struct ifmediareq *); void t4_os_cim_err(struct adapter *); +int suspend_adapter(struct adapter *); +int resume_adapter(struct adapter *); #ifdef KERN_TLS /* t6_kern_tls.c */ diff --git a/sys/dev/cxgbe/t4_main.c b/sys/dev/cxgbe/t4_main.c index 5fedf10869d2..0606f383b879 100644 --- a/sys/dev/cxgbe/t4_main.c +++ b/sys/dev/cxgbe/t4_main.c @@ -2110,23 +2110,32 @@ stop_lld(struct adapter *sc) return (rc); } -static int -t4_suspend(device_t dev) +int +suspend_adapter(struct adapter *sc) { - struct adapter *sc = device_get_softc(dev); - - CH_ALERT(sc, "%s from thread %p.\n", __func__, curthread); stop_adapter(sc); stop_lld(sc); #ifdef TCP_OFFLOAD stop_all_uld(sc); #endif set_adapter_hwstatus(sc, false); - CH_ALERT(sc, "%s end (thread %p).\n", __func__, curthread); return (0); } +static int +t4_suspend(device_t dev) +{ + struct adapter *sc = device_get_softc(dev); + int rc; + + CH_ALERT(sc, "%s from thread %p.\n", __func__, curthread); + rc = suspend_adapter(sc); + CH_ALERT(sc, "%s end (thread %p).\n", __func__, curthread); + + return (rc); +} + struct adapter_pre_reset_state { u_int flags; uint16_t nbmcaps; @@ -2464,20 +2473,28 @@ done: return (rc); } -static int -t4_resume(device_t dev) +int +resume_adapter(struct adapter *sc) { - struct adapter *sc = device_get_softc(dev); - - CH_ALERT(sc, "%s from thread %p.\n", __func__, curthread); restart_adapter(sc); restart_lld(sc); #ifdef TCP_OFFLOAD restart_all_uld(sc); #endif + return (0); +} + +static int +t4_resume(device_t dev) +{ + struct adapter *sc = device_get_softc(dev); + int rc; + + CH_ALERT(sc, "%s from thread %p.\n", __func__, curthread); + rc = resume_adapter(sc); CH_ALERT(sc, "%s end (thread %p).\n", __func__, curthread); - return (0); + return (rc); } static int @@ -2512,12 +2529,7 @@ reset_adapter_with_pci_bus_reset(struct adapter *sc) static int reset_adapter_with_pl_rst(struct adapter *sc) { - stop_adapter(sc); - stop_lld(sc); -#ifdef TCP_OFFLOAD - stop_all_uld(sc); -#endif - set_adapter_hwstatus(sc, false); + suspend_adapter(sc); /* This is a t4_write_reg without the hw_off_limits check. */ MPASS(sc->error_flags & HW_OFF_LIMITS); @@ -2525,11 +2537,7 @@ reset_adapter_with_pl_rst(struct adapter *sc) F_PIORSTMODE | F_PIORST | F_AUTOPCIEPAUSE); pause("pl_rst", 1 * hz); /* Wait 1s for reset */ - restart_adapter(sc); - restart_lld(sc); -#ifdef TCP_OFFLOAD - restart_all_uld(sc); -#endif + resume_adapter(sc); return (0); } From nobody Wed Aug 28 18:55:48 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WvDBr3qQFz5MXyT; Wed, 28 Aug 2024 18:55:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WvDBr2kb4z4mVD; Wed, 28 Aug 2024 18:55:48 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724871348; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=fSbNWF35y1yjHhhqxwH8i7B9v6lUJhOPcewJDPCg2RI=; b=in80SNGh6IuRle2mPNROxDJbRBOP/ottlx8wQiDHUSFjk6IYkjewA+pQrsa4fVZQ3ELChp pnrYnSxVlDeeUb769wEnfTmBSry1fYuTz5CFhsGglrYVH7ACoVQqaouCgCfN9h41KPKQIx wWYHS6y8b99nmbatrtyoilFlJxhsu5ptOJfIyNQtJk8QhD8U9ILc4XtssCm7N2/LqhkwIO 0qY75nKXFyOpzz/oFkpKmzpZxnkvMI+tWfe1g2buPyvA7pp/y2bJvrIDrqe+/vIO0Oi5GR lctMs/9L3DaKua3TZ8zPrqhLs1USKRWBWJ9bmuVHm7awIAAbs+OzG5mwF98Vqw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724871348; a=rsa-sha256; cv=none; b=a+pbEHtzh+Z41+OX2Lt0wPxe08tuBo3Ji2iiA00rvhoF2dp24a3whV0TM/I7eXGqKcM1yr 045sR+NxsjqRcalxmGfm8l0QR8wqCs5bWxKKvsMtRY0ttLQUWintPpJPsDYNQ9tUMwFcJ1 Tax554V5JCTnMxjB2oE5xzbfL6zJhcTZdMWVZaW01xZB6CRhp1m/osZOAZ2ezu5KFrHe+X Q5cJs8imPCSID8BCA8UsbzhIDpuTJKA3586uyW9AB6N3kCLouphA/zc40xy/UzN3f5PRaC /I8dCqR0Ywm5GPJ4VPWylSpwKYSkwuZGbHeGQSm77qcaGMgsMuDMCUWYjjlCbQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724871348; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=fSbNWF35y1yjHhhqxwH8i7B9v6lUJhOPcewJDPCg2RI=; b=rzpY/C/QtbMcDd8V9woIp929k8oCoXYoNsjZqAyP7QMFEph2EtRnLHVWzIp7H3VcBqkZq8 Ob15m+z3pYeNoLfai0S9rQqdhmYKQGcgqzlyypnW/HYG7/ylMynUBqeYV0K5GfZ1hq6qvs 2gzavn+RN7jW5V+2rvN36j4KtZ2E+MtLyrOa0mnEkj8yhxOyPa6uLtbksf8TL2wczZAM6T oc+nnJW2w5EirFevk61dpT0d7/QUhsYaXkqsaDX0ofvHNm80gO9lKHL7+7mlgGGnRvjCv9 PUyAc1ejr0dadWR5DgVOJBKFV+q9YnyTR6ZDYwcsP5Y3oVWtLtIfVXlE1GA8dA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WvDBr2Kk2zm0b; Wed, 28 Aug 2024 18:55:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47SItmxU024357; Wed, 28 Aug 2024 18:55:48 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47SItml1024354; Wed, 28 Aug 2024 18:55:48 GMT (envelope-from git) Date: Wed, 28 Aug 2024 18:55:48 GMT Message-Id: <202408281855.47SItml1024354@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: c7a7e997d25d - main - atomic: Avoid casting the return value of atomic_load_ptr to void HEAD branches config description git-daemon-export-ok gl-conf hooks info objects packed-refs refs List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: c7a7e997d25d0b33769252d002b16839c864c83d Auto-Submitted: auto-generated The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=c7a7e997d25d0b33769252d002b16839c864c83d commit c7a7e997d25d0b33769252d002b16839c864c83d Author: Mark Johnston AuthorDate: 2024-08-28 18:51:06 +0000 Commit: Mark Johnston CommitDate: 2024-08-28 18:55:39 +0000 atomic: Avoid casting the return value of atomic_load_ptr to void * Otherwise a cast is needed to load a uintptr_t value. Fixes: e1f4d623779d ("rangelocks: remove unneeded cast of the atomic_load_ptr() result") MFC after: 1 week --- sys/sys/atomic_san.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/sys/atomic_san.h b/sys/sys/atomic_san.h index eb6913296a45..ef81b4b7c51e 100644 --- a/sys/sys/atomic_san.h +++ b/sys/sys/atomic_san.h @@ -266,7 +266,8 @@ ATOMIC_SAN_THREAD_FENCE(SAN_INTERCEPTOR_PREFIX); #define atomic_fcmpset_rel_ptr ATOMIC_SAN(fcmpset_rel_ptr) #define atomic_fetchadd_ptr ATOMIC_SAN(fetchadd_ptr) #define atomic_load_ptr(x) \ - ((void *)ATOMIC_SAN(load_ptr)(__DECONST(volatile uintptr_t *, (x)))) + ((__typeof(*x))ATOMIC_SAN(load_ptr)( \ + __DECONST(volatile uintptr_t *, (x)))) #define atomic_load_acq_ptr ATOMIC_SAN(load_acq_ptr) #define atomic_load_consume_ptr(x) \ ((void *)atomic_load_acq_ptr((volatile uintptr_t *)(x))) From nobody Wed Aug 28 19:12:42 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WvDZL444Tz5MZRJ; Wed, 28 Aug 2024 19:12:42 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WvDZL36YZz4ppv; Wed, 28 Aug 2024 19:12:42 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724872362; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=rXzwUJ3B073p+5XdpZL7rBXbR3gV3vMdQ2n+lfhRooY=; b=Vi2rCi9BUbmC7pa2NMNVpGgohnkDY3wnIaA1wXwONoluBUzfZPCjezBS1lhcjztYJq+v+e 16oHX3MhBeqk5NyA6OeQHEAdcucU5ozQEd6aXipFCo0Gy9hR0pdvNbuxm28QsI91r60lBL VXmlaIm7x7+WxySt8wlv4UygXCq+6oCOdEWCA9Vsfg1dg/oKLXZaGS7x5YdprFmtzVZulr NJk6HZrM798MMoacJem2n2teiFqfeYMjYrHKNCf3Or1zvXwbcBMUVQ3GtguvGVqCtmtpp8 9WPC4xdXNwNgTb0EyElHNU5ajksNM//m9GwzYscTPv9JQr9ey0UlsAx/OHmleA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724872362; a=rsa-sha256; cv=none; b=vsYeijW5pBf1XcrRvldJsSJVho0y3Hw0clg3w0+8Ts39hhxuyDtaNUJuPz07joQii79xBq L0mCdEVtpde/u9/dfw7rYO0nhDv2yBdwndzbaDY3lTGVgBXgbRW91OkdFnviiQ2IsYBbsp JUDr7ABJDcyOaEV6dWjiuN0NL14q1LNJ3D+p5jsAk3/k4ReXboqyBZMvKdCdQogFJ3xNae MHBtEEahd7IHG944ni3WU7BLsT3YPwIQoHj9+oOIjdl9I0qCSm0toGboG/tlwJ7tM5IL35 6k6Y0nKAouMmsjpXBdZdjiBnAOxIi0MtVTkNdq0Y12oIL81/i7A9QtljVeyWXQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724872362; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=rXzwUJ3B073p+5XdpZL7rBXbR3gV3vMdQ2n+lfhRooY=; b=SRuj7bIZ18mmojE/q9yBliCHvCmJ2cJYsTxV8HeAXuhIsDUDOFnzf2LFbXwfREjwBuL8f5 WHt3sU3LrNx0dd0/Azz8YYtGpD8rd4tDfobpq1Vj6RKeaR67JjuI1QmKQCjFdnBqsfz0I+ Kd4ZH9FiPzLRS/GMzHVnD/Se/9bHFYTwLtXm2h3ILP7WJGTbY6QF8qfazkAr3gsYaPOrxV ht7bFgP950IJ4rqOtoCznLWmM7HkRyBUwXMc7vHNN6/Ua15kGj/Zd/g5ynbr48OWHLMOUP BDVuGqGq9sA/XVJsL/3o/H2OJP5b1JrTCwj/AGO8Q4YdS0R62yJYwTx5gz71jg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WvDZL2jM6zldM; Wed, 28 Aug 2024 19:12:42 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47SJCgDw058950; Wed, 28 Aug 2024 19:12:42 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47SJCgfx058947; Wed, 28 Aug 2024 19:12:42 GMT (envelope-from git) Date: Wed, 28 Aug 2024 19:12:42 GMT Message-Id: <202408281912.47SJCgfx058947@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: d58197097610 - main - vmm: Factor most of sysctl_vmm_create() out into a separate function List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: d581970976101e1bcbfc23823b97696b172f118c Auto-Submitted: auto-generated The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=d581970976101e1bcbfc23823b97696b172f118c commit d581970976101e1bcbfc23823b97696b172f118c Author: Mark Johnston AuthorDate: 2024-08-28 18:57:03 +0000 Commit: Mark Johnston CommitDate: 2024-08-28 18:57:03 +0000 vmm: Factor most of sysctl_vmm_create() out into a separate function This will make it easy to share code with an ioctl handler which creates VMs. No functional change intended. Reviewed by: corvink, jhb Differential Revision: https://reviews.freebsd.org/D46444 --- sys/dev/vmm/vmm_dev.c | 86 ++++++++++++++++++++++++++++----------------------- 1 file changed, 48 insertions(+), 38 deletions(-) diff --git a/sys/dev/vmm/vmm_dev.c b/sys/dev/vmm/vmm_dev.c index db3e2c992f3b..94546efd03c9 100644 --- a/sys/dev/vmm/vmm_dev.c +++ b/sys/dev/vmm/vmm_dev.c @@ -838,66 +838,58 @@ static struct cdevsw vmmdevsw = { .d_write = vmmdev_rw, }; +static struct vmmdev_softc * +vmmdev_alloc(struct vm *vm, struct ucred *cred) +{ + struct vmmdev_softc *sc; + + sc = malloc(sizeof(*sc), M_VMMDEV, M_WAITOK | M_ZERO); + SLIST_INIT(&sc->devmem); + sc->vm = vm; + sc->ucred = crhold(cred); + return (sc); +} + static int -sysctl_vmm_create(SYSCTL_HANDLER_ARGS) +vmmdev_create(const char *name, struct ucred *cred) { - struct vm *vm; struct cdev *cdev; struct vmmdev_softc *sc, *sc2; - char *buf; - int error, buflen; - - error = vmm_priv_check(req->td->td_ucred); - if (error) - return (error); - - buflen = VM_MAX_NAMELEN + 1; - buf = malloc(buflen, M_VMMDEV, M_WAITOK | M_ZERO); - strlcpy(buf, "beavis", buflen); - error = sysctl_handle_string(oidp, buf, buflen, req); - if (error != 0 || req->newptr == NULL) - goto out; + struct vm *vm; + int error; mtx_lock(&vmmdev_mtx); - sc = vmmdev_lookup(buf); + sc = vmmdev_lookup(name); mtx_unlock(&vmmdev_mtx); - if (sc != NULL) { - error = EEXIST; - goto out; - } + if (sc != NULL) + return (EEXIST); - error = vm_create(buf, &vm); + error = vm_create(name, &vm); if (error != 0) - goto out; + return (error); - sc = malloc(sizeof(struct vmmdev_softc), M_VMMDEV, M_WAITOK | M_ZERO); - sc->ucred = crhold(curthread->td_ucred); - sc->vm = vm; - SLIST_INIT(&sc->devmem); + sc = vmmdev_alloc(vm, cred); /* * Lookup the name again just in case somebody sneaked in when we * dropped the lock. */ mtx_lock(&vmmdev_mtx); - sc2 = vmmdev_lookup(buf); - if (sc2 == NULL) { - SLIST_INSERT_HEAD(&head, sc, link); - sc->flags |= VSC_LINKED; - } - mtx_unlock(&vmmdev_mtx); - + sc2 = vmmdev_lookup(name); if (sc2 != NULL) { + mtx_unlock(&vmmdev_mtx); vmmdev_destroy(sc); - error = EEXIST; - goto out; + return (EEXIST); } + sc->flags |= VSC_LINKED; + SLIST_INSERT_HEAD(&head, sc, link); + mtx_unlock(&vmmdev_mtx); error = make_dev_p(MAKEDEV_CHECKNAME, &cdev, &vmmdevsw, sc->ucred, - UID_ROOT, GID_WHEEL, 0600, "vmm/%s", buf); + UID_ROOT, GID_WHEEL, 0600, "vmm/%s", name); if (error != 0) { vmmdev_destroy(sc); - goto out; + return (error); } mtx_lock(&vmmdev_mtx); @@ -905,7 +897,25 @@ sysctl_vmm_create(SYSCTL_HANDLER_ARGS) sc->cdev->si_drv1 = sc; mtx_unlock(&vmmdev_mtx); -out: + return (0); +} + +static int +sysctl_vmm_create(SYSCTL_HANDLER_ARGS) +{ + char *buf; + int error, buflen; + + error = vmm_priv_check(req->td->td_ucred); + if (error != 0) + return (error); + + buflen = VM_MAX_NAMELEN + 1; + buf = malloc(buflen, M_VMMDEV, M_WAITOK | M_ZERO); + strlcpy(buf, "beavis", buflen); + error = sysctl_handle_string(oidp, buf, buflen, req); + if (error == 0 && req->newptr != NULL) + error = vmmdev_create(buf, req->td->td_ucred); free(buf, M_VMMDEV); return (error); } From nobody Wed Aug 28 19:12:43 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WvDZM5S7tz5MZVv; Wed, 28 Aug 2024 19:12:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WvDZM3lbbz4pbY; Wed, 28 Aug 2024 19:12:43 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724872363; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=sgj/UhkRUu4ZWnLOoi11yvogSw5YyLHeDqM9knZjjAc=; b=HM6PSHRQU0mJtMqTVsat10V2hyKTsS0juhr59AZtyKYfBIc3LOb5IUNZYOgm7MSg7Ipp97 TyvlxnwzDDYcKCQ35PMebDxVoz2Bvk1RsVSLnGOrTDQ5xLEXSSJPmqE2f8mvuXdagKhFn/ LvUMGZdFuEdrXSvB5UgMDS0zYwil4dxL/0L1bIqDNuOBBT2w3CHzVNeBUAeFAZ4sORpfI8 bdYJCMMmdpitOE3rXomeTZi1OsPbbPWHUq1TYwlB3kNbLqQJthx9lFwzkXPjRIUM05XBja VhRuyj2XpM8B+kvOOq6Gnhuh6rAawnHSS1L6G8u8e2mbG8ljY43Y5qIpwEartA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724872363; a=rsa-sha256; cv=none; b=HhNyAMvrbXFbrdjHGEtlYYGu7zPyrNm/v7eBsNZAhfGC4jz9Yj2ZGHPEoM6rzy8dpOYgFM AnuN+OR+RY1qA2V3NCwnt9j11W627Vp6UoTK3Wdw0npW4DJoVV6IMqjUN1CvesKQaEv7S1 HRxATWXfw7HAUTvMpxzMuFR3PiTAWFaFvkBvFiA/ylSauQnVlE2OEsoPzHpwPpPtXIotN5 DKtHsO1Oz8oV2P+dXNuKfErAQp6LdUx1DJgMBI5Cp44A3woTu+SE7aTmtUbtHg4C5rGtmn DVaKoAe8LO07z9sE8kiUr8+Glz3lKBoY3U+GfjO8Ovkvguva/npJQ2PUyaaYoA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724872363; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=sgj/UhkRUu4ZWnLOoi11yvogSw5YyLHeDqM9knZjjAc=; b=i8ITYCFzptePj3dAb23xN+o9vaBb9e+8ny6MEB9eKq+3yUZw2Hak1ZycEAI+XAQ/OiMf0t zSZur6kIYbSWowit6VfqHbMYSHucdyh8CdRoBIKtLKfKqvbGKbu6rbHS2fGk3RnSrP1kns TYUgXP1HK9MrFbaVOO5az7iUHZLluQogmFLo/4+CGSdnt17PDrNH9TQQa6ceTvZGYUvoIC bZu3obkHhuLRBD5PM0q8jvy+/8uaJowP0Cccdr69J9lTpFelH7CW11B81HmmXusurtOAFk ajcBgHIFLEMLFD0DUSsB4pcD/xPdRxWHLX9D8Q7jC2AmK7+M2pxhZ0uX/oYTCA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WvDZM3MGZzmLn; Wed, 28 Aug 2024 19:12:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47SJChVw059011; Wed, 28 Aug 2024 19:12:43 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47SJChCA059008; Wed, 28 Aug 2024 19:12:43 GMT (envelope-from git) Date: Wed, 28 Aug 2024 19:12:43 GMT Message-Id: <202408281912.47SJChCA059008@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: 063a8bd908dd - main - vmm: Factor most of sysctl_vmm_destroy() into a separate function List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 063a8bd908ddaae9f0ba8c7711dfe837a14f21e7 Auto-Submitted: auto-generated The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=063a8bd908ddaae9f0ba8c7711dfe837a14f21e7 commit 063a8bd908ddaae9f0ba8c7711dfe837a14f21e7 Author: Mark Johnston AuthorDate: 2024-08-28 18:57:12 +0000 Commit: Mark Johnston CommitDate: 2024-08-28 18:57:12 +0000 vmm: Factor most of sysctl_vmm_destroy() into a separate function This will make it easy to share code with an ioctl handler which creates VMs. No functional change intended. Reviewed by: corvink, jhb Differential Revision: https://reviews.freebsd.org/D46445 --- sys/dev/vmm/vmm_dev.c | 72 ++++++++++++++++++++++++++------------------------- 1 file changed, 37 insertions(+), 35 deletions(-) diff --git a/sys/dev/vmm/vmm_dev.c b/sys/dev/vmm/vmm_dev.c index 94546efd03c9..6bdcb51777d4 100644 --- a/sys/dev/vmm/vmm_dev.c +++ b/sys/dev/vmm/vmm_dev.c @@ -732,12 +732,24 @@ vmmdev_mmap_single(struct cdev *cdev, vm_ooffset_t *offset, vm_size_t mapsize, } static void -vmmdev_destroy(void *arg) +vmmdev_destroy(struct vmmdev_softc *sc) { - struct vmmdev_softc *sc = arg; struct devmem_softc *dsc; int error __diagused; + /* + * Destroy all cdevs: + * + * - any new operations on the 'cdev' will return an error (ENXIO). + * + * - the 'devmem' cdevs are destroyed before the virtual machine 'cdev' + */ + SLIST_FOREACH(dsc, &sc->devmem, link) { + KASSERT(dsc->cdev != NULL, ("devmem cdev already destroyed")); + destroy_dev(dsc->cdev); + devmem_destroy(dsc); + } + vm_disable_vcpu_creation(sc->vm); error = vcpu_lock_all(sc); KASSERT(error == 0, ("%s: error %d freezing vcpus", __func__, error)); @@ -769,31 +781,16 @@ vmmdev_destroy(void *arg) } static int -sysctl_vmm_destroy(SYSCTL_HANDLER_ARGS) +vmmdev_lookup_and_destroy(const char *name, struct ucred *cred) { - struct devmem_softc *dsc; - struct vmmdev_softc *sc; struct cdev *cdev; - char *buf; - int error, buflen; - - error = vmm_priv_check(req->td->td_ucred); - if (error) - return (error); - - buflen = VM_MAX_NAMELEN + 1; - buf = malloc(buflen, M_VMMDEV, M_WAITOK | M_ZERO); - strlcpy(buf, "beavis", buflen); - error = sysctl_handle_string(oidp, buf, buflen, req); - if (error != 0 || req->newptr == NULL) - goto out; + struct vmmdev_softc *sc; mtx_lock(&vmmdev_mtx); - sc = vmmdev_lookup(buf); + sc = vmmdev_lookup(name); if (sc == NULL || sc->cdev == NULL) { mtx_unlock(&vmmdev_mtx); - error = EINVAL; - goto out; + return (EINVAL); } /* @@ -804,23 +801,28 @@ sysctl_vmm_destroy(SYSCTL_HANDLER_ARGS) sc->cdev = NULL; mtx_unlock(&vmmdev_mtx); - /* - * Destroy all cdevs: - * - * - any new operations on the 'cdev' will return an error (ENXIO). - * - * - the 'devmem' cdevs are destroyed before the virtual machine 'cdev' - */ - SLIST_FOREACH(dsc, &sc->devmem, link) { - KASSERT(dsc->cdev != NULL, ("devmem cdev already destroyed")); - destroy_dev(dsc->cdev); - devmem_destroy(dsc); - } destroy_dev(cdev); vmmdev_destroy(sc); - error = 0; -out: + return (0); +} + +static int +sysctl_vmm_destroy(SYSCTL_HANDLER_ARGS) +{ + char *buf; + int error, buflen; + + error = vmm_priv_check(req->td->td_ucred); + if (error) + return (error); + + buflen = VM_MAX_NAMELEN + 1; + buf = malloc(buflen, M_VMMDEV, M_WAITOK | M_ZERO); + strlcpy(buf, "beavis", buflen); + error = sysctl_handle_string(oidp, buf, buflen, req); + if (error == 0 && req->newptr != NULL) + error = vmmdev_lookup_and_destroy(buf, req->td->td_ucred); free(buf, M_VMMDEV); return (error); } From nobody Wed Aug 28 19:12:44 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WvDZP12gYz5MZRL; Wed, 28 Aug 2024 19:12:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WvDZN4VJfz4pbc; Wed, 28 Aug 2024 19:12:44 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724872364; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=A9E43Cr2nfgxnDATDCHpNXgXdqidOW0FMyEinjmOB/s=; b=cqx8sW+M5NZBNVar0JXEmJ65oB8qP6K5pVU0loiJpV0YuRadFVNsmIqzzwQpDH8YYwxCA+ IFtLx0MJnVhbHxsTbvEK2E41QNAemUdgWt+4nVrctC+jHHcaTV3M0ESUY0aST5orBFyUIo sHFWighbB8LXRZA2HrC4DhFKXXymtsWHElSV53seyzO+R5PAraHphpqQtdJMEFYjiwv2wE PTPJVPp/0hj86aZo9UEwj/VH1yGRqSRwT4Hz1yn5zkJbDQOuIh5HjN/E7sCoDTHIowxGSE vem41DyagnNWD2zr3a6O5DIRpVno/ad9OC3PprTnWuh1WPilTrTxEHSRPvRvUg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724872364; a=rsa-sha256; cv=none; b=WqSbQXMIjErl5OQtqcNDT5ylrmtSzgl2QVWMmDTCG5U+IiuAWRS06tRhTpZSQYhpy3S/bp lDjArEL4KU3+AVnIbKhSs4AJ/w4gbs40yt/HdHFP+gYRdSnYgWW8MhBkZWjy458E4uBfVc HaYnLd8G7v1ZHI++0pfDm9ZJTnDpJk0r7r+lot+tFB4TzbjU/EekCSpTS/Tw3QYjsQJkMe OYQ481qWZvFlgmZQWquTwVyc4W+j2IHh7uHTiS4XG6W5eUZ5g3kDEojK98zQ3qPvuH2nLd e8OPe6z20bwmeNDfZIDpoMQJIfWh8C9UNoLbC++oudD1u7NuedwdBlzFPvRtOQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724872364; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=A9E43Cr2nfgxnDATDCHpNXgXdqidOW0FMyEinjmOB/s=; b=MS/FxdTtfoujVxHcomn1JsrHCmFtWC99YYKnktchLzJbiN8n8b5Lvqx+yO6GjdW4sOuGHP Yzdfw8p5dbBuBI47nZACzDBiZdGLkaXzGv6rkyVmzwqwFIxwkX5n9J8bbrTYyWjNdHUeqz Cv3q4cwdsMKqNboo7kCxOSy4QR5OtB2t+7SAQPmU9n8FLUYJNI/aY8U1w8MGD4BH1acLAh Llubu9CHbeiVL3EIT6neRxGx+goaNMIJjU23XkLCqxSy3kDdU2rjQ8vJcBj4Wd+nYv8FLi dY4v4hWNJfjL1qF4/7d+hxQoQexm2VhF/2xx5cMPBIe3s051nihCKi6LH06Ilw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WvDZN3r1vzm1d; Wed, 28 Aug 2024 19:12:44 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47SJCi2E059071; Wed, 28 Aug 2024 19:12:44 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47SJCiAj059068; Wed, 28 Aug 2024 19:12:44 GMT (envelope-from git) Date: Wed, 28 Aug 2024 19:12:44 GMT Message-Id: <202408281912.47SJCiAj059068@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: f4002135a2be - main - vmm: Remove an unneeded lookup in devmem_create_cdev() List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: f4002135a2be59272f39f886fb270f5a4736ac08 Auto-Submitted: auto-generated The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=f4002135a2be59272f39f886fb270f5a4736ac08 commit f4002135a2be59272f39f886fb270f5a4736ac08 Author: Mark Johnston AuthorDate: 2024-08-28 18:57:21 +0000 Commit: Mark Johnston CommitDate: 2024-08-28 18:57:21 +0000 vmm: Remove an unneeded lookup in devmem_create_cdev() The sole caller of this function already holds a pointer to the VM's softc, so rather than passing the VM name and looking it up again, just pass the softc pointer directly. This function is only called from an ioctl context, so the softc structure will remain live. Reviewed by: corvink, jhb Differential Revision: https://reviews.freebsd.org/D46446 --- sys/dev/vmm/vmm_dev.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/sys/dev/vmm/vmm_dev.c b/sys/dev/vmm/vmm_dev.c index 6bdcb51777d4..c42b2aaee5ed 100644 --- a/sys/dev/vmm/vmm_dev.c +++ b/sys/dev/vmm/vmm_dev.c @@ -42,8 +42,6 @@ _Static_assert(sizeof(struct vm_memseg_fbsd12) == 80, "COMPAT_FREEBSD12 ABI"); _IOWR('v', IOCNUM_GET_MEMSEG, struct vm_memseg_fbsd12) #endif -static int devmem_create_cdev(const char *vmname, int id, char *devmem); - struct devmem_softc { int segid; char *name; @@ -73,6 +71,7 @@ static MALLOC_DEFINE(M_VMMDEV, "vmmdev", "vmmdev"); SYSCTL_DECL(_hw_vmm); static void devmem_destroy(void *arg); +static int devmem_create_cdev(struct vmmdev_softc *sc, int id, char *devmem); static int vmm_priv_check(struct ucred *ucred) @@ -287,7 +286,7 @@ alloc_memseg(struct vmmdev_softc *sc, struct vm_memseg *mseg, size_t len) goto done; if (VM_MEMSEG_NAME(mseg)) { - error = devmem_create_cdev(vm_name(sc->vm), mseg->segid, name); + error = devmem_create_cdev(sc, mseg->segid, name); if (error) vm_free_memseg(sc->vm, mseg->segid); else @@ -989,13 +988,15 @@ static struct cdevsw devmemsw = { }; static int -devmem_create_cdev(const char *vmname, int segid, char *devname) +devmem_create_cdev(struct vmmdev_softc *sc, int segid, char *devname) { struct devmem_softc *dsc; - struct vmmdev_softc *sc; struct cdev *cdev; + const char *vmname; int error; + vmname = vm_name(sc->vm); + error = make_dev_p(MAKEDEV_CHECKNAME, &cdev, &devmemsw, NULL, UID_ROOT, GID_WHEEL, 0600, "vmm.io/%s.%s", vmname, devname); if (error) @@ -1004,8 +1005,6 @@ devmem_create_cdev(const char *vmname, int segid, char *devname) dsc = malloc(sizeof(struct devmem_softc), M_VMMDEV, M_WAITOK | M_ZERO); mtx_lock(&vmmdev_mtx); - sc = vmmdev_lookup(vmname); - KASSERT(sc != NULL, ("%s: vm %s softc not found", __func__, vmname)); if (sc->cdev == NULL) { /* virtual machine is being created or destroyed */ mtx_unlock(&vmmdev_mtx); From nobody Wed Aug 28 19:12:45 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WvDZQ1j3zz5MZW7; Wed, 28 Aug 2024 19:12:46 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WvDZP5ZMGz4pql; Wed, 28 Aug 2024 19:12:45 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724872365; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=afjc736OpC4MDxUXdy9mhKBlDHgIv3SuwoHHtdiZgfA=; b=i9jIUi4cfB1pVbqn0iFwvZCmCRUBCVv1HyouS/iJsgtS9V6FmXs02tFc+TxbG9KGyttoQK FMPxfZWWrewfD1ZMWk0C1ho2A8BPzllU94A30J4dDPYu5bUnUeLf7hJYZnAToyf/aiBgNB 6fW7VvDAo/d9ovjgkzzXHrJjwwGms/jn3GAVF0MQ2v4SjSyW8VVDqxg8T2PZsI3aqyw3Xe chdoEWbjawlE6QS8+xgB6ezHFiVdyCxCTBr3iyEwSjFmlH+IXrpbLRrEs6/fU3uJ9O8iOY ZSfpDX9kAZ79vvGrXLriOjMcjaom28+vO4DLxB0VbrLmIC1X2QS9tNpDU/WRIg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724872365; a=rsa-sha256; cv=none; b=Nkz7JBZsBTVx7ll+zDu4OFiG7b/8hr3bXOuA6kzd5S4O7DgXrSDwC7uLh8Hf1ZK8whL3GK b/tgq77782H56EHvf9+ao/MqmygR6MzKXqUOPYBHTjzeDbQQ3qJzSS6LNCVcUgIyHeUseO CCRNyT4id2qpQGcuxMkM/qtkIDnuF7eaHrWdBeqc0KUbuseUYyghNTWn5+L1WUgMSZUF6E fwCFInyVtq0NRAGK0sCxh307Rn4rNEbfOCYr7r4vex6IUJkto1XRfsNEFSvXBDxLI5nny4 JtOqlqauAyzO88xei1k6EnutijM5uO6XTGcTz/M/9ZjFlFZ8RI/HSYlXhAsWEQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724872365; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=afjc736OpC4MDxUXdy9mhKBlDHgIv3SuwoHHtdiZgfA=; b=isw+MpBRow9exqa2cGnmokSsvQRCTpBUPTR/dvsO+KypZEUURycDHRmGt1VTbe1Zebo9Ne HDzBZhj+WbS+3zZseYsYDDmNBc9OCQmAHaifohbhkSPCxjk/Hy3NM0MXH8WBP/4U4s1eJF rCkZf3uD3bhdH/uD6syxIJAJ5yYi6IHLidXnQ4ZjYD2lSqVEAFDe9FewdA9Tds7B8eEfDj HSpbO/yHvXJTVaTo29LVvBozHhCWB2ZiZxRpAlopelXB73zKmIdizc0EBQT9ChsJjwinMm GubtDNZ0U67oJERbBjWrXTSv1JwXAG5U+HYNdWZsJmMhwhF4g/v+WUem3EqUwA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WvDZP5BMCzmGb; Wed, 28 Aug 2024 19:12:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47SJCji6059131; Wed, 28 Aug 2024 19:12:45 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47SJCjrx059128; Wed, 28 Aug 2024 19:12:45 GMT (envelope-from git) Date: Wed, 28 Aug 2024 19:12:45 GMT Message-Id: <202408281912.47SJCjrx059128@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: c23da668fa8e - main - vmm: Be more consistent with the credential used for VM lookup List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: c23da668fa8e341c6f51d70ec632de617b693215 Auto-Submitted: auto-generated The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=c23da668fa8e341c6f51d70ec632de617b693215 commit c23da668fa8e341c6f51d70ec632de617b693215 Author: Mark Johnston AuthorDate: 2024-08-28 18:57:33 +0000 Commit: Mark Johnston CommitDate: 2024-08-28 18:57:33 +0000 vmm: Be more consistent with the credential used for VM lookup vmmdev_lookup() is used from sysctl context to find a VM by name. There, a reference credential is already passed, so use that instead of assuming that it's the same as curthread->td_ucred, even though that's true today. No functional change intended. Reviewed by: corvink, jhb Differential Revision: https://reviews.freebsd.org/D46447 --- sys/dev/vmm/vmm_dev.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/sys/dev/vmm/vmm_dev.c b/sys/dev/vmm/vmm_dev.c index c42b2aaee5ed..53b4dc8cda91 100644 --- a/sys/dev/vmm/vmm_dev.c +++ b/sys/dev/vmm/vmm_dev.c @@ -152,7 +152,7 @@ vcpu_unlock_all(struct vmmdev_softc *sc) } static struct vmmdev_softc * -vmmdev_lookup(const char *name) +vmmdev_lookup(const char *name, struct ucred *cred) { struct vmmdev_softc *sc; @@ -166,7 +166,7 @@ vmmdev_lookup(const char *name) if (sc == NULL) return (NULL); - if (cr_cansee(curthread->td_ucred, sc->ucred)) + if (cr_cansee(cred, sc->ucred)) return (NULL); return (sc); @@ -786,7 +786,7 @@ vmmdev_lookup_and_destroy(const char *name, struct ucred *cred) struct vmmdev_softc *sc; mtx_lock(&vmmdev_mtx); - sc = vmmdev_lookup(name); + sc = vmmdev_lookup(name, cred); if (sc == NULL || sc->cdev == NULL) { mtx_unlock(&vmmdev_mtx); return (EINVAL); @@ -860,7 +860,7 @@ vmmdev_create(const char *name, struct ucred *cred) int error; mtx_lock(&vmmdev_mtx); - sc = vmmdev_lookup(name); + sc = vmmdev_lookup(name, cred); mtx_unlock(&vmmdev_mtx); if (sc != NULL) return (EEXIST); @@ -876,7 +876,7 @@ vmmdev_create(const char *name, struct ucred *cred) * dropped the lock. */ mtx_lock(&vmmdev_mtx); - sc2 = vmmdev_lookup(name); + sc2 = vmmdev_lookup(name, cred); if (sc2 != NULL) { mtx_unlock(&vmmdev_mtx); vmmdev_destroy(sc); From nobody Wed Aug 28 19:12:46 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WvDZR1fpmz5MZdh; Wed, 28 Aug 2024 19:12:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WvDZQ6dN9z4pwd; Wed, 28 Aug 2024 19:12:46 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724872367; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=5PG3mkA45TK8AF9Teu6YsZv/7yFMRu/CqN8RJ2ZDRBM=; b=Wl7290APk5yWwdgKTVPuJTi8sAyQzbxZlk1+FAFji8uiJy6ernp4b3WYsO76dvj7Fkld2Y KTWuHbpe14xKp4X+KcyEUM2vF3mnRXdHdvDd+RARUuf1Dv8oREMx1vIxuFQe7ZEmbIsY7U U6cLwsUha2NzBqibfkhGPgncX9o1Lj/eJk0VhUER56DK7zvf1Vw/kvBjIGutqrlq05reuj LvuOMGKWVhC4PzUumgPGognjSCIh1y9Lotd1d5/80jRGVCBYe4Ok0cvDxISi5QiM00WrEr SQmWlmxJbkIGGCMXRvCpQg1RTHxGw9WpoVx+F/2w+bipZ7flb1ka92E1UfNXeA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724872367; a=rsa-sha256; cv=none; b=J1feLC+1kAoiZveElgaxQzyd44pTU/imxZM0mirXz4tp7PQwAr3XWllGhtv7vHtHVCPBth ddXBgrtbmYcoIyy9dzoOtO5gmN6OLHodiq5e6dRBATGmBPgf9ZPxj8zk1ndK5eU55MM2q3 HmKrvbKajJlUoBsNBYNVjpkblqiUvhDBAb7HCHFm2dHoFBxDRN17sF/r4eVSs8dh6Mmjga WAvfNtd27v6iFrNeseaM57a3SsOforF/8TWkDXPtdElSptuNC0ON1nDSgm+C2I4T+Glcdz XzIxuw0uwwnnHYD8vZNOwMrsKHPLcFEXPYyvyOp7T1zGRC0+5P5ukXXhtGZ6tw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724872367; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=5PG3mkA45TK8AF9Teu6YsZv/7yFMRu/CqN8RJ2ZDRBM=; b=A5yHBdVjqoCTYqvdaIrAlo0XlLL/oSU763B+mQAeGXkj0nnZalVu6IoXfGz9rD7emMZTcX +3y0/uN+drTrr4QS+lGNH24c8xyuwbUf2BNeEfgVEtZjOUoP0f7btr1a5zRHMb270ZKpcp RexBVPayplz5bNQWSWpf6rCXhh/XpUQ/MRPvI0Kl4FGCFGzbkyuKHW4IjJ+9wYH/dbJLLg vnpXmdmMfJw++dl/30CWSlB8deJ8IxcGVGl58QIYSfLkwv+Hj3gdczAL0j9DQJp13ej/0r zbR8p8vCyWNEKWsXw6UZrRXt+w5tMOKNXrj71Uz3ZaEf6eg4IKoTMQQm3ltt9Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WvDZQ6CgRzm1f; Wed, 28 Aug 2024 19:12:46 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47SJCku0059186; Wed, 28 Aug 2024 19:12:46 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47SJCkSK059183; Wed, 28 Aug 2024 19:12:46 GMT (envelope-from git) Date: Wed, 28 Aug 2024 19:12:46 GMT Message-Id: <202408281912.47SJCkSK059183@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: 72ea8f41e19d - main - vmm: Let devmem devices reference the VM credential List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 72ea8f41e19d3e028dd4ab3f9102240e215dbc6d Auto-Submitted: auto-generated The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=72ea8f41e19d3e028dd4ab3f9102240e215dbc6d commit 72ea8f41e19d3e028dd4ab3f9102240e215dbc6d Author: Mark Johnston AuthorDate: 2024-08-28 18:57:38 +0000 Commit: Mark Johnston CommitDate: 2024-08-28 19:12:16 +0000 vmm: Let devmem devices reference the VM credential Otherwise they are globally visible (in jails with allow.vmm set), instead of being restricted to the jail to which the VM belongs. Reviewed by: corvink, jhb Differential Revision: https://reviews.freebsd.org/D46448 --- sys/dev/vmm/vmm_dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/vmm/vmm_dev.c b/sys/dev/vmm/vmm_dev.c index 53b4dc8cda91..fa9357b3b566 100644 --- a/sys/dev/vmm/vmm_dev.c +++ b/sys/dev/vmm/vmm_dev.c @@ -997,7 +997,7 @@ devmem_create_cdev(struct vmmdev_softc *sc, int segid, char *devname) vmname = vm_name(sc->vm); - error = make_dev_p(MAKEDEV_CHECKNAME, &cdev, &devmemsw, NULL, + error = make_dev_p(MAKEDEV_CHECKNAME, &cdev, &devmemsw, sc->ucred, UID_ROOT, GID_WHEEL, 0600, "vmm.io/%s.%s", vmname, devname); if (error) return (error); From nobody Wed Aug 28 19:12:47 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WvDZS2208z5MZW8; Wed, 28 Aug 2024 19:12:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WvDZS0g4nz4pc9; Wed, 28 Aug 2024 19:12:48 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724872368; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=xCaCC1lyWx/mGAwnSwLqinjhhvQy/0Qj00VfVklbALA=; b=BQNhinNjVpr/2v6FizPa2gNtorvU07VP5ibb8jBMaYNsPe1xy3UQL2rH8lpdX8pOYkanxX Ki0V6MNgJWl/omvplh/34IphX7yE5kB0F5eSvkPhxQ08Bc9SOsGI0IIlPHbQ611a5Tj446 zF/vLptnYNjVV5waubLX6rDyv9I7BM8YjA8Uk/PyQfwLEk2YWUW9jqEJ+/RQofu61AmBS1 FnlLiISd2iPwJoCS3GTpVGISrmxDbyvtt2VT1uf5M/gtrLOZZVET5Jk+Zk2KZw37w70jDN bQykUT023enQlgFMLlG74ogRxf9aInYFOHC3KBW6i4qiuQDKT/b5+p8hnMP23w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724872368; a=rsa-sha256; cv=none; b=sEhTFGq9nbPqeZKrHarsKi4qsXwYUSB0xOVU67LSjjBJcna4YUhueHWsTuQOo6/VW//OLH tWLoeoz6QUVQNwW9GDQ1vft7NeIpRcx2KjR1zxw1JI1qCI3Qw2rw+TjROxqGLXdlPy//cy tOUOOwNOMqCJ8UJw6dAhuGTSo67otRsCKKh52atbPAAdvt0tbjvAdG2R4Ue8WVkdgwElmR qKklxre51tvVdbzkmHEbRSIjSJscH99HJZ9pNmnklwoyDrwlJ6UI1bp1bSXSpwaRdJaFsn Oe/4KcEjRdCELIHli2xAyWmJnMW4u1BjD1A5TWSGsknIX/OS7y1/fVbLQmXmfQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724872368; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=xCaCC1lyWx/mGAwnSwLqinjhhvQy/0Qj00VfVklbALA=; b=DPyEwbG+jXf5KSFH9d2t/ThtbCUzZFw/hCG/qkPq8S5/N4vQFoX0NzNyRaSfsyaz5YqLfn 6H32UzNvRsdhPVZNYWp91DtaIsi63mujbcubFBNkSmhbC4iNxFS9uNANuMuziHriQTup+v IEl7uzSi7LTwW9Hauwp1pW9g7RJtVDaikVZxcaVagve9IWjTD3uBCmiLg2KWmqAEMAPi/M iCraJYcC90l7SahNAEEfG8ahfw+OFv+4krj536LrIi5F3nn7syo5ELAxQrKVLehyq/EzsT gA403iTby5yjXkClU027MpkgM8dypRpd4mM0xgA8SP+4mqafogpVmLKsnIJKiA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WvDZS06LVzmXB; Wed, 28 Aug 2024 19:12:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47SJClwX059235; Wed, 28 Aug 2024 19:12:47 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47SJCl4M059232; Wed, 28 Aug 2024 19:12:47 GMT (envelope-from git) Date: Wed, 28 Aug 2024 19:12:47 GMT Message-Id: <202408281912.47SJCl4M059232@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: a852dc580c1c - main - vmm: Harmonize compat ioctl definitions List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: a852dc580c1c261bc50fd9788b52abca0004661b Auto-Submitted: auto-generated The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=a852dc580c1c261bc50fd9788b52abca0004661b commit a852dc580c1c261bc50fd9788b52abca0004661b Author: Mark Johnston AuthorDate: 2024-08-28 18:57:43 +0000 Commit: Mark Johnston CommitDate: 2024-08-28 19:12:32 +0000 vmm: Harmonize compat ioctl definitions For compat ioctls and structures, we use a mix of suffixes: _old, _fbsd, _. Standardize on _ to make things more consistent. No functional change intended. Reported by: jhb Reviewed by: corvink, jhb Differential Revision: https://reviews.freebsd.org/D46449 --- sys/amd64/vmm/vmm_dev_machdep.c | 34 +++++++++++++++++----------------- sys/dev/vmm/vmm_dev.c | 24 ++++++++++++------------ 2 files changed, 29 insertions(+), 29 deletions(-) diff --git a/sys/amd64/vmm/vmm_dev_machdep.c b/sys/amd64/vmm/vmm_dev_machdep.c index 792807568212..2d0ceadaedfe 100644 --- a/sys/amd64/vmm/vmm_dev_machdep.c +++ b/sys/amd64/vmm/vmm_dev_machdep.c @@ -59,16 +59,16 @@ #include "io/vrtc.h" #ifdef COMPAT_FREEBSD13 -struct vm_stats_old { +struct vm_stats_13 { int cpuid; /* in */ int num_entries; /* out */ struct timeval tv; uint64_t statbuf[MAX_VM_STATS]; }; -#define VM_STATS_OLD _IOWR('v', IOCNUM_VM_STATS, struct vm_stats_old) +#define VM_STATS_13 _IOWR('v', IOCNUM_VM_STATS, struct vm_stats_13) -struct vm_snapshot_meta_old { +struct vm_snapshot_meta_13 { void *ctx; /* unused */ void *dev_data; const char *dev_name; /* identify userspace devices */ @@ -79,8 +79,8 @@ struct vm_snapshot_meta_old { enum vm_snapshot_op op; }; -#define VM_SNAPSHOT_REQ_OLD \ - _IOWR('v', IOCNUM_SNAPSHOT_REQ, struct vm_snapshot_meta_old) +#define VM_SNAPSHOT_REQ_13 \ + _IOWR('v', IOCNUM_SNAPSHOT_REQ, struct vm_snapshot_meta_13) struct vm_exit_ipi_13 { uint32_t mode; @@ -131,14 +131,14 @@ const struct vmmdev_ioctl vmmdev_machdep_ioctls[] = { VMMDEV_IOCTL(VM_UNMAP_PPTDEV_MMIO, VMMDEV_IOCTL_LOCK_ALL_VCPUS), #ifdef BHYVE_SNAPSHOT #ifdef COMPAT_FREEBSD13 - VMMDEV_IOCTL(VM_SNAPSHOT_REQ_OLD, VMMDEV_IOCTL_LOCK_ALL_VCPUS), + VMMDEV_IOCTL(VM_SNAPSHOT_REQ_13, VMMDEV_IOCTL_LOCK_ALL_VCPUS), #endif VMMDEV_IOCTL(VM_SNAPSHOT_REQ, VMMDEV_IOCTL_LOCK_ALL_VCPUS), VMMDEV_IOCTL(VM_RESTORE_TIME, VMMDEV_IOCTL_LOCK_ALL_VCPUS), #endif #ifdef COMPAT_FREEBSD13 - VMMDEV_IOCTL(VM_STATS_OLD, VMMDEV_IOCTL_LOCK_ONE_VCPU), + VMMDEV_IOCTL(VM_STATS_13, VMMDEV_IOCTL_LOCK_ONE_VCPU), #endif VMMDEV_IOCTL(VM_INJECT_NMI, VMMDEV_IOCTL_LOCK_ONE_VCPU), VMMDEV_IOCTL(VM_LAPIC_IRQ, VMMDEV_IOCTL_LOCK_ONE_VCPU), @@ -196,7 +196,7 @@ vmmdev_machdep_ioctl(struct vm *vm, struct vcpu *vcpu, u_long cmd, caddr_t data, #ifdef BHYVE_SNAPSHOT struct vm_snapshot_meta *snapshot_meta; #ifdef COMPAT_FREEBSD13 - struct vm_snapshot_meta_old *snapshot_old; + struct vm_snapshot_meta_13 *snapshot_13; #endif #endif int error; @@ -270,13 +270,13 @@ vmmdev_machdep_ioctl(struct vm *vm, struct vcpu *vcpu, u_long cmd, caddr_t data, } break; } - case VM_STATS_OLD: { - struct vm_stats_old *vmstats_old; + case VM_STATS_13: { + struct vm_stats_13 *vmstats_13; - vmstats_old = (struct vm_stats_old *)data; - getmicrotime(&vmstats_old->tv); - error = vmm_stat_copy(vcpu, 0, nitems(vmstats_old->statbuf), - &vmstats_old->num_entries, vmstats_old->statbuf); + vmstats_13 = (struct vm_stats_13 *)data; + getmicrotime(&vmstats_13->tv); + error = vmm_stat_copy(vcpu, 0, nitems(vmstats_13->statbuf), + &vmstats_13->num_entries, vmstats_13->statbuf); break; } #endif @@ -502,14 +502,14 @@ vmmdev_machdep_ioctl(struct vm *vm, struct vcpu *vcpu, u_long cmd, caddr_t data, error = vm_snapshot_req(vm, snapshot_meta); break; #ifdef COMPAT_FREEBSD13 - case VM_SNAPSHOT_REQ_OLD: + case VM_SNAPSHOT_REQ_13: /* * The old structure just has an additional pointer at * the start that is ignored. */ - snapshot_old = (struct vm_snapshot_meta_old *)data; + snapshot_13 = (struct vm_snapshot_meta_13 *)data; snapshot_meta = - (struct vm_snapshot_meta *)&snapshot_old->dev_data; + (struct vm_snapshot_meta *)&snapshot_13->dev_data; error = vm_snapshot_req(vm, snapshot_meta); break; #endif diff --git a/sys/dev/vmm/vmm_dev.c b/sys/dev/vmm/vmm_dev.c index fa9357b3b566..f43429de4d4c 100644 --- a/sys/dev/vmm/vmm_dev.c +++ b/sys/dev/vmm/vmm_dev.c @@ -29,17 +29,17 @@ #include #if defined(__amd64__) && defined(COMPAT_FREEBSD12) -struct vm_memseg_fbsd12 { +struct vm_memseg_12 { int segid; size_t len; char name[64]; }; -_Static_assert(sizeof(struct vm_memseg_fbsd12) == 80, "COMPAT_FREEBSD12 ABI"); +_Static_assert(sizeof(struct vm_memseg_12) == 80, "COMPAT_FREEBSD12 ABI"); -#define VM_ALLOC_MEMSEG_FBSD12 \ - _IOW('v', IOCNUM_ALLOC_MEMSEG, struct vm_memseg_fbsd12) -#define VM_GET_MEMSEG_FBSD12 \ - _IOWR('v', IOCNUM_GET_MEMSEG, struct vm_memseg_fbsd12) +#define VM_ALLOC_MEMSEG_12 \ + _IOW('v', IOCNUM_ALLOC_MEMSEG, struct vm_memseg_12) +#define VM_GET_MEMSEG_12 \ + _IOWR('v', IOCNUM_GET_MEMSEG, struct vm_memseg_12) #endif struct devmem_softc { @@ -339,7 +339,7 @@ static const struct vmmdev_ioctl vmmdev_ioctls[] = { VMMDEV_IOCTL(VM_STATS, VMMDEV_IOCTL_LOCK_ONE_VCPU), #if defined(__amd64__) && defined(COMPAT_FREEBSD12) - VMMDEV_IOCTL(VM_ALLOC_MEMSEG_FBSD12, + VMMDEV_IOCTL(VM_ALLOC_MEMSEG_12, VMMDEV_IOCTL_XLOCK_MEMSEGS | VMMDEV_IOCTL_LOCK_ALL_VCPUS), #endif VMMDEV_IOCTL(VM_ALLOC_MEMSEG, @@ -352,7 +352,7 @@ static const struct vmmdev_ioctl vmmdev_ioctls[] = { VMMDEV_IOCTL_XLOCK_MEMSEGS | VMMDEV_IOCTL_LOCK_ALL_VCPUS), #if defined(__amd64__) && defined(COMPAT_FREEBSD12) - VMMDEV_IOCTL(VM_GET_MEMSEG_FBSD12, VMMDEV_IOCTL_SLOCK_MEMSEGS), + VMMDEV_IOCTL(VM_GET_MEMSEG_12, VMMDEV_IOCTL_SLOCK_MEMSEGS), #endif VMMDEV_IOCTL(VM_GET_MEMSEG, VMMDEV_IOCTL_SLOCK_MEMSEGS), VMMDEV_IOCTL(VM_MMAP_GETNEXT, VMMDEV_IOCTL_SLOCK_MEMSEGS), @@ -489,13 +489,13 @@ vmmdev_ioctl(struct cdev *cdev, u_long cmd, caddr_t data, int fflag, break; } #if defined(__amd64__) && defined(COMPAT_FREEBSD12) - case VM_ALLOC_MEMSEG_FBSD12: + case VM_ALLOC_MEMSEG_12: error = alloc_memseg(sc, (struct vm_memseg *)data, - sizeof(((struct vm_memseg_fbsd12 *)0)->name)); + sizeof(((struct vm_memseg_12 *)0)->name)); break; - case VM_GET_MEMSEG_FBSD12: + case VM_GET_MEMSEG_12: error = get_memseg(sc, (struct vm_memseg *)data, - sizeof(((struct vm_memseg_fbsd12 *)0)->name)); + sizeof(((struct vm_memseg_12 *)0)->name)); break; #endif case VM_ALLOC_MEMSEG: From nobody Wed Aug 28 19:15:38 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WvDdz6RQjz5MZTJ for ; Wed, 28 Aug 2024 19:15:51 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WvDdz51Ccz4rmJ for ; Wed, 28 Aug 2024 19:15:51 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-42816ca797fso64348855e9.2 for ; Wed, 28 Aug 2024 12:15:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724872550; x=1725477350; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bhL8HMcqBBOP5lcukNoi8NinRQMDW3+MOUL1ZxkhuWg=; b=DOABGI9kpL7EFam2ATMkx+IO45LvbTeI3+hi7urYPX1YkIrGYRPWLMQZYAZyUTJTOh yyPaRTTg35NBaPbqN8XjH+/5bDywW2vNBL6jhNF26ZyqCBCuuFSBTBd788cIOvcqEDCG t5jD0IEfZah3OvkgWy6f8W+ceWioTeFu9NJ9iHOcukWDFqPTXUAUVesSaKSNr7kKJJWp 8rI0MLCcCDIxii0XrL/TIHsXcMHVoayRTHyA0dvYmI8Pd28ZvVvPTqHhx69XMBmh46ms Hn0+DJmMQaZAlS16h09C1PBspa2WIeir5OOF9Zph42OFj6ckjQbHdWPTOWlgl1UDNCHv k2kw== X-Forwarded-Encrypted: i=1; AJvYcCUDsf2fOjZE155a+ClCReHQzmPxNo+uBQO2zlCevwMa+cXqNzwetI5wYRLSmEeDWG5YW+5h5B95VrVxdXcO7lfG0t8GCg==@freebsd.org X-Gm-Message-State: AOJu0Ywrc+JJqQarn0MRgvlqm3c8TMkSw/QDLEE2A9Q431Yqn/9leJOr r4G80yLJr81CgtditI0w+0AaqQamUuMFU78LyI4CG7ItEsklGcE83Vgt8Bu2i2K0KXSRY580PEE A X-Google-Smtp-Source: AGHT+IERJKsPce3xQ4HYGwyIZof7o+TPOG4sTmsctinGFHt13h75/7vhDb0LowvB8NGZ2MDflYBt4w== X-Received: by 2002:a05:600c:3ca4:b0:426:5fbc:f319 with SMTP id 5b1f17b1804b1-42bb01f45b7mr4584995e9.33.1724872549693; Wed, 28 Aug 2024 12:15:49 -0700 (PDT) Received: from smtpclient.apple ([131.111.5.201]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3749b2429absm455618f8f.65.2024.08.28.12.15.49 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Aug 2024 12:15:49 -0700 (PDT) Content-Type: text/plain; charset=us-ascii List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51\)) Subject: Re: git: c7a7e997d25d - main - atomic: Avoid casting the return value of atomic_load_ptr to void HEAD branches config description git-daemon-export-ok gl-conf hooks info objects packed-refs refs From: Jessica Clarke In-Reply-To: <202408281855.47SItml1024354@gitrepo.freebsd.org> Date: Wed, 28 Aug 2024 20:15:38 +0100 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <9559E6F1-0FB5-48E9-9827-50D6BD8E5446@freebsd.org> References: <202408281855.47SItml1024354@gitrepo.freebsd.org> To: Mark Johnston X-Mailer: Apple Mail (2.3776.700.51) X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Queue-Id: 4WvDdz51Ccz4rmJ On 28 Aug 2024, at 19:55, Mark Johnston wrote: >=20 > The branch main has been updated by markj: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3Dc7a7e997d25d0b33769252d002b16839= c864c83d >=20 > commit c7a7e997d25d0b33769252d002b16839c864c83d > Author: Mark Johnston > AuthorDate: 2024-08-28 18:51:06 +0000 > Commit: Mark Johnston > CommitDate: 2024-08-28 18:55:39 +0000 >=20 > atomic: Avoid casting the return value of atomic_load_ptr to void * >=20 > Otherwise a cast is needed to load a uintptr_t value. >=20 > Fixes: e1f4d623779d ("rangelocks: remove unneeded cast of the = atomic_load_ptr() result") > MFC after: 1 week > --- > sys/sys/atomic_san.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/sys/sys/atomic_san.h b/sys/sys/atomic_san.h > index eb6913296a45..ef81b4b7c51e 100644 > --- a/sys/sys/atomic_san.h > +++ b/sys/sys/atomic_san.h > @@ -266,7 +266,8 @@ ATOMIC_SAN_THREAD_FENCE(SAN_INTERCEPTOR_PREFIX); > #define atomic_fcmpset_rel_ptr ATOMIC_SAN(fcmpset_rel_ptr) > #define atomic_fetchadd_ptr ATOMIC_SAN(fetchadd_ptr) > #define atomic_load_ptr(x) \ > - ((void *)ATOMIC_SAN(load_ptr)(__DECONST(volatile uintptr_t *, (x)))) > + ((__typeof(*x))ATOMIC_SAN(load_ptr)( \ > + __DECONST(volatile uintptr_t *, (x)))) > #define atomic_load_acq_ptr ATOMIC_SAN(load_acq_ptr) > #define atomic_load_consume_ptr(x) \ > ((void *)atomic_load_acq_ptr((volatile uintptr_t *)(x))) This variant is similarly wrong. Jess From nobody Wed Aug 28 19:30:46 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WvDzC0VxCz5MbmR; Wed, 28 Aug 2024 19:30:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WvDzB6vZjz4ssm; Wed, 28 Aug 2024 19:30:46 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724873447; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=7Tgd7dlx9vKtxjxjHHiEKl+pzZHy9KrklmKGa9VjSDY=; b=A/8I2nmezuJkg94jMTMvk4VhxzDifqkrGnH+SdLvrVis6MTN84CaiKmHFz+/vrffuHWdYT m5Fbq9bOKWI1afZHVWHpbPLe8FIYIXp0GOGdFjZDSxQn/KZP1NjCXfnI45zbEBT35gYMXT sXZVHkRIGYpiK/u8pnA55gvQU7z0TIFTvpC4CcDlt3wuNhogjcmJaQxsewrmNf83nKktGA 1qe401TX8sCPjeDqhtOReMi03Kf3NXtP5KC2FC/IRJFvf39B215lwezMuj5Q9T0DpVb0tz fG5lbsa2PxWR71ua8JTb7wUyLhTPpYg7noMo0FWUkE6hKEpNgdjEyKH7C+U0bw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724873447; a=rsa-sha256; cv=none; b=okFIbrriAXbdlDl/OVMj4viAzTz3oXYeVDwZvawtGzr6vLUmEY+TJ8yJ4uUDncm1I/CZ1G qbqh5tnxldk2w7Uq/zqURDFDiWd7xaDC9wjfdydkuL16vHqkD+LNqnsLifq6KfWiMpUoir hZrnh856T6Oj3Z6NITyzqaFBO0uHn/vjDCVozyc7D6ijc6UlQVGL3FHkOq4oa0FPPp4qNo s48VHi5cr8gadoNmOWCrrc9e61lfgGjfycQk8h3PeqDW3pBLqssiy7Rl2ZRMmsM961OgoC CHOv6oSATbq1exNbZf/Knh2sDDluzbBUAOApQu9onpTXb+ZNHfJTBmbdEJ8ONg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724873447; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=7Tgd7dlx9vKtxjxjHHiEKl+pzZHy9KrklmKGa9VjSDY=; b=vpc3wKVOLZHKkNsvBrQT+TpDzMUYpgJrW/2heYePQ8rLQVSPcBFOXPkZSKInB77FlYBSK7 HDsQDQ8plyf6FS3URPsVDaYiyESq+T482Xtn9pIlV3DZflmuuvaZ+qCLGuICt7Lyj5QLwI LqZ9aUIiQi9evFUWiRM4TTlFqyXRIo1rcpm9ToCYtgtp4bZOAavYd/crX8tloOEw35QvUf oVQCipLZKj8R6Gzwnr8p0oqfN3OvCs2T4vxwzI2b2xRCeSe1JQkY+4l0241E+3WTn3MAjw jVlkdzwZj0POpiuIiq0Koj2kGQnV3fHQ3MHH4oAfM9M2GkfX3avDcOKG4N7bYw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WvDzB6VhmzmMR; Wed, 28 Aug 2024 19:30:46 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47SJUkC5085657; Wed, 28 Aug 2024 19:30:46 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47SJUkGH085654; Wed, 28 Aug 2024 19:30:46 GMT (envelope-from git) Date: Wed, 28 Aug 2024 19:30:46 GMT Message-Id: <202408281930.47SJUkGH085654@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Navdeep Parhar Subject: git: 8254a276ad89 - main - cxgbe/iw_cxgbe: Replace the fatal error flag with a stopped flag. List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: np X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 8254a276ad893ae2a1b35fcbbad255f06e29b8c6 Auto-Submitted: auto-generated The branch main has been updated by np: URL: https://cgit.FreeBSD.org/src/commit/?id=8254a276ad893ae2a1b35fcbbad255f06e29b8c6 commit 8254a276ad893ae2a1b35fcbbad255f06e29b8c6 Author: Navdeep Parhar AuthorDate: 2024-08-28 18:41:10 +0000 Commit: Navdeep Parhar CommitDate: 2024-08-28 19:19:23 +0000 cxgbe/iw_cxgbe: Replace the fatal error flag with a stopped flag. Now that suspend/resume is supported by the base driver, a fatal error isn't the only reason that the RNIC can stop abruptly. Also, this state is no longer permanent as it's possible to resume operations after a stop. Rename the flag and associated routines to match the new state of affairs. MFC after: 1 week Sponsored by: Chelsio Communications --- sys/dev/cxgbe/iw_cxgbe/cm.c | 10 +++++----- sys/dev/cxgbe/iw_cxgbe/device.c | 11 ++++++++--- sys/dev/cxgbe/iw_cxgbe/iw_cxgbe.h | 10 +++++----- sys/dev/cxgbe/iw_cxgbe/mem.c | 2 +- 4 files changed, 19 insertions(+), 14 deletions(-) diff --git a/sys/dev/cxgbe/iw_cxgbe/cm.c b/sys/dev/cxgbe/iw_cxgbe/cm.c index e0e48fdff9ba..257dec81f384 100644 --- a/sys/dev/cxgbe/iw_cxgbe/cm.c +++ b/sys/dev/cxgbe/iw_cxgbe/cm.c @@ -1080,7 +1080,7 @@ c4iw_so_upcall(struct socket *so, void *arg, int waitflag) * Wake up any threads waiting in rdma_init()/rdma_fini(), * with locks held. */ - if (so->so_error || (ep->com.dev->rdev.flags & T4_FATAL_ERROR)) + if (so->so_error || c4iw_stopped(&ep->com.dev->rdev)) c4iw_wake_up(&ep->com.wr_wait, -ECONNRESET); add_ep_to_req_list(ep, C4IW_EVENT_SOCKET); @@ -2708,8 +2708,8 @@ c4iw_create_listen(struct iw_cm_id *cm_id, int backlog) CTR3(KTR_IW_CXGBE, "%s: cm_id %p, backlog %s", __func__, cm_id, backlog); - if (c4iw_fatal_error(&dev->rdev)) { - CTR2(KTR_IW_CXGBE, "%s: cm_id %p, fatal error", __func__, + if (c4iw_stopped(&dev->rdev)) { + CTR2(KTR_IW_CXGBE, "%s: cm_id %p, stopped", __func__, cm_id); return -EIO; } @@ -2821,8 +2821,8 @@ int c4iw_ep_disconnect(struct c4iw_ep *ep, int abrupt, gfp_t gfp) rdev = &ep->com.dev->rdev; - if (c4iw_fatal_error(rdev)) { - CTR3(KTR_IW_CXGBE, "%s:ced1 fatal error %p %s", __func__, ep, + if (c4iw_stopped(rdev)) { + CTR3(KTR_IW_CXGBE, "%s:ced1 stopped %p %s", __func__, ep, states[ep->com.state]); if (ep->com.state != DEAD) { send_abort(ep); diff --git a/sys/dev/cxgbe/iw_cxgbe/device.c b/sys/dev/cxgbe/iw_cxgbe/device.c index 209d12767a1c..3c4d269f6c69 100644 --- a/sys/dev/cxgbe/iw_cxgbe/device.c +++ b/sys/dev/cxgbe/iw_cxgbe/device.c @@ -335,9 +335,8 @@ c4iw_stop(struct adapter *sc) if (iwsc) { struct ib_event event = {0}; - device_printf(sc->dev, - "iWARP driver received FATAL ERROR event.\n"); - iwsc->rdev.flags |= T4_FATAL_ERROR; + device_printf(sc->dev, "iWARP driver stopped.\n"); + iwsc->rdev.flags |= T4_IW_STOPPED; event.event = IB_EVENT_DEVICE_FATAL; event.device = &iwsc->ibdev; ib_dispatch_event(&event); @@ -349,6 +348,12 @@ c4iw_stop(struct adapter *sc) static int c4iw_restart(struct adapter *sc) { + struct c4iw_dev *iwsc = sc->iwarp_softc; + + if (iwsc) { + device_printf(sc->dev, "iWARP driver restarted.\n"); + iwsc->rdev.flags &= ~T4_IW_STOPPED; + } return (0); } diff --git a/sys/dev/cxgbe/iw_cxgbe/iw_cxgbe.h b/sys/dev/cxgbe/iw_cxgbe/iw_cxgbe.h index 5715b7e53863..ca2595b65b02 100644 --- a/sys/dev/cxgbe/iw_cxgbe/iw_cxgbe.h +++ b/sys/dev/cxgbe/iw_cxgbe/iw_cxgbe.h @@ -116,7 +116,7 @@ struct c4iw_dev_ucontext { }; enum c4iw_rdev_flags { - T4_FATAL_ERROR = (1<<0), + T4_IW_STOPPED = (1<<0), T4_STATUS_PAGE_DISABLED = (1<<1), }; @@ -167,9 +167,9 @@ struct c4iw_rdev { struct workqueue_struct *free_workq; }; -static inline int c4iw_fatal_error(struct c4iw_rdev *rdev) +static inline int c4iw_stopped(struct c4iw_rdev *rdev) { - return rdev->flags & T4_FATAL_ERROR; + return rdev->flags & T4_IW_STOPPED; } static inline int c4iw_num_stags(struct c4iw_rdev *rdev) @@ -214,7 +214,7 @@ c4iw_wait_for_reply(struct c4iw_rdev *rdev, struct c4iw_wr_wait *wr_waitp, int timedout = 0; struct timeval t1, t2; - if (c4iw_fatal_error(rdev)) { + if (c4iw_stopped(rdev)) { wr_waitp->ret = -EIO; goto out; } @@ -240,7 +240,7 @@ c4iw_wait_for_reply(struct c4iw_rdev *rdev, struct c4iw_wr_wait *wr_waitp, "seconds - tid %u qpid %u\n", func, device_get_nameunit(sc->dev), t2.tv_sec, t2.tv_usec, hwtid, qpid); - if (c4iw_fatal_error(rdev)) { + if (c4iw_stopped(rdev)) { wr_waitp->ret = -EIO; break; } diff --git a/sys/dev/cxgbe/iw_cxgbe/mem.c b/sys/dev/cxgbe/iw_cxgbe/mem.c index 5b8c7391514f..348cd3985e87 100644 --- a/sys/dev/cxgbe/iw_cxgbe/mem.c +++ b/sys/dev/cxgbe/iw_cxgbe/mem.c @@ -256,7 +256,7 @@ static int write_tpt_entry(struct c4iw_rdev *rdev, u32 reset_tpt_entry, u32 stag_idx; static atomic_t key; - if (c4iw_fatal_error(rdev)) + if (c4iw_stopped(rdev)) return -EIO; stag_state = stag_state > 0; From nobody Wed Aug 28 19:31:15 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WvDzl5vmqz5Mbm3; Wed, 28 Aug 2024 19:31:15 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WvDzl3w1hz4tKj; Wed, 28 Aug 2024 19:31:15 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724873475; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=P1/YwTAx+dy7zuySDqcRaNF/xVawkV8uGUp71FSQCm4=; b=jskaX4kqY3B7TUR+Gio20ddxIZDTaskicjr9ZuK9lUUkAgpYkXb11yWc31jbaZV9UNEoeJ 09HhnuAW8tEbzBFvwpE6SzCbtic1KdUBnkwaAcUemG43Wil8/lphLO7ICgyj3C2c18TpEr ThwkFiDokgGyQR1d2IMh5d5qi5DmQkWfxcNX6yaAWqnZbdky0qrjv+BM3RAFhhGT/mlAGd /b88hhd6ujEYjUJoe+lao5aU56OeBt04GoP4jzHGaLiNl/65MnJXh6wXCLOsamO5Slh8rl vvR6/8jDza5h6WTHvcbpvsXkEDnGkIIWvSK2eWbbx3oRkWmvYtnowidJBuF1rg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724873475; a=rsa-sha256; cv=none; b=RuI7gvytMraQsPcE/K0gvj4yJzVnoH4qkd32gYS54Y5gQGiNVT8t3iG5/SGY//sg3hkZg3 AMT52bAB2u520uaWjIQeVxHL6hVvMMpHuc9iLXEpWe6Y3bSSwYQNy0ZrCXmKeIxjKygMEQ foMwNNi02T5M4Llqsfbckr4cXKaA4jdRyqKJ4tvILmayO0MSC3LbnDRPiP8O1FTtLAb0+u 4Fn3CWANvUegIe4SvfsbaMkqUVz22OY3bwDY5P6W8PSvyQxhgpW3WbAcCBCGXKHZN9GMs/ FmiTS9prdc6uXR803Q6mDpxJV0SswRM5V7GDWp2GyEVGpQM+KXP1LoG+U2W2JA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724873475; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=P1/YwTAx+dy7zuySDqcRaNF/xVawkV8uGUp71FSQCm4=; b=J6SgKTuvEMjJzYmo1tiFW6l/v/f8qiGNSjnFIYtkvZHeXsU7MTsMxdFLLypzPb04euG0J/ c6ixdSXhXKSIqsOdBSt955zS+x8xJjTov4BFfoFL6ybUyXaftmXhmWAOiSaeL1HaxAiaCL F1Tb0SnwMQfMcZaL6F1YSdQd6Td7+TN3YMWk/7VC9IAo8gELprEJAW7e9rlFbxROf2Xq2B KtEwDQNogIaoXJ6H+4SUkn/jB92VcWV8iA2EGyd0rruoRp+LZLa2AgP1+LyHnzV7O/M89a QMOUvlTXLEovtPJg6yhcDm3/eboSU9/3J0+5qoYVQXUqi6+BkpKmBjiWoyGXpw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WvDzl3WHYzmK0; Wed, 28 Aug 2024 19:31:15 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47SJVFbf089368; Wed, 28 Aug 2024 19:31:15 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47SJVF6p089365; Wed, 28 Aug 2024 19:31:15 GMT (envelope-from git) Date: Wed, 28 Aug 2024 19:31:15 GMT Message-Id: <202408281931.47SJVF6p089365@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: cb91dc50950f - main - atomic: Fix the cast in the atomic_load_consume() interceptor List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: cb91dc50950ffdfd49337e844e231b69b8b5c634 Auto-Submitted: auto-generated The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=cb91dc50950ffdfd49337e844e231b69b8b5c634 commit cb91dc50950ffdfd49337e844e231b69b8b5c634 Author: Mark Johnston AuthorDate: 2024-08-28 19:25:11 +0000 Commit: Mark Johnston CommitDate: 2024-08-28 19:31:03 +0000 atomic: Fix the cast in the atomic_load_consume() interceptor As in commit c7a7e997d25d0, we should permit loading from a pointer to uintptr_t. Note that the other atomic_*_ptr() interfaces currently require casting regardless, only those defined in atomic_common.h try to be generic. Reported by: jrtc27 MFC after: 1 week --- sys/sys/atomic_san.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/sys/atomic_san.h b/sys/sys/atomic_san.h index ef81b4b7c51e..e22324b87623 100644 --- a/sys/sys/atomic_san.h +++ b/sys/sys/atomic_san.h @@ -270,7 +270,7 @@ ATOMIC_SAN_THREAD_FENCE(SAN_INTERCEPTOR_PREFIX); __DECONST(volatile uintptr_t *, (x)))) #define atomic_load_acq_ptr ATOMIC_SAN(load_acq_ptr) #define atomic_load_consume_ptr(x) \ - ((void *)atomic_load_acq_ptr((volatile uintptr_t *)(x))) + ((__typeof(*x))atomic_load_acq_ptr((volatile uintptr_t *)(x))) #define atomic_readandclear_ptr ATOMIC_SAN(readandclear_ptr) #define atomic_set_ptr ATOMIC_SAN(set_ptr) #define atomic_set_acq_ptr ATOMIC_SAN(set_acq_ptr) From nobody Wed Aug 28 19:31:47 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WvF0S4vZdz5Mc6x; Wed, 28 Aug 2024 19:31:52 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-il1-x131.google.com (mail-il1-x131.google.com [IPv6:2607:f8b0:4864:20::131]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WvF0S38F9z4tSr; Wed, 28 Aug 2024 19:31:52 +0000 (UTC) (envelope-from markjdb@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-il1-x131.google.com with SMTP id e9e14a558f8ab-39d22965434so2955605ab.0; Wed, 28 Aug 2024 12:31:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724873510; x=1725478310; darn=freebsd.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=DRVfuPAtJTI3+7iyGAS+cdBRCnzRb50IpG5TWlfhVCg=; b=ApLXvx0Fa5ZypPlXEmgjl1j6wdNh99WUb7TTojHedLqM0NueIykyBv4xkcTvFZQVEb kpl+2huLVUKeYpcqbg5KZk59kYS+XWeRtRIhHdLzOs+ANX9qA8thLTblXzVj8jk5fmh1 y7vIeAmH1BDU5gooKo2jM3ZDRX5YZCV+TvP1i5HOI2aSEXcQLwsUaDMRV0sB/F7NZJkn DVyaiA5MgOtslpChl7fPEQ+1fEcKXqd24w4QZBtWJFbstG8a8i2SzfgQV7b3n910pjGT H0Ko0HjtAKcIs4/XR3W1bk8Z/tL2piocIwUzQEOdAmzWVWAahg+LSVS/ldGmfqVUNSXM q7fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724873510; x=1725478310; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DRVfuPAtJTI3+7iyGAS+cdBRCnzRb50IpG5TWlfhVCg=; b=X6q/SE/25xvAL79GoZW2f6iKoM31be8qcws4up4a+3bI7jzC5UTKFaZs7qKXFjh3EP DonaFlVD53EMFQAGmzcfW/NhBNMPftXyKnlldx9uT9CBsJ133o+LP6CdkTqig0HydE72 oKEleJ0K+9WE6HABvRF5xOvWK4K38fdzizFPVnLdqZXZpr05QdLLMCbgkIlWFfZfPn3y VNEu1VlsWVBTt9Aqxh3DNeQEF85BUtuaSA223jDF0OPu4W/rvkf9GiP1BadAO/CGYyOb q5OX8LDxeg/mxbfaZp84uYM7hRkdeiYwS2NRrHXs+3fAHrxEilidSCkTf3FnduvXGcrS v8ag== X-Forwarded-Encrypted: i=1; AJvYcCUN2lmaPIwlxvRPj4pHB7jyJxxI4O1OOFk/A3gAibxKIFmmoHWcJgjv1Bx4Yacnx5JQ9CP5RqjM4JbiGNiQv96bmNvn@freebsd.org, AJvYcCVddpBFtAfwBekzpV/NYvSF0ee89s1zdRGMPdRpay+Sa3CJzf2OjqIao8cNOz8L7Ew13qdAd7R+4rtL1jRkl3O7BFNpc4E=@freebsd.org X-Gm-Message-State: AOJu0YwzrUh9Sb1lADhi1Na2dM32diZzNfUjh0KxxP0ljsEajH6wT+mB F7A1EOn9R4V81uifWZ6fQ5friNCA+RPBHrJGbv7puXu1/iDfXAO3kq6UuQ== X-Google-Smtp-Source: AGHT+IG0HIe5/wbBbpyH5ygT/mno+Sze7E7rJ3NY7W1Wlgsc8ILQJcUNuTFjFJWrj4S4MSbOXAlOlQ== X-Received: by 2002:a05:6e02:1e0e:b0:39d:4dab:a533 with SMTP id e9e14a558f8ab-39f389db2b8mr2073455ab.0.1724873510371; Wed, 28 Aug 2024 12:31:50 -0700 (PDT) Received: from nuc (192-0-220-237.cpe.teksavvy.com. [192.0.220.237]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4ced0da0e38sm12068173.105.2024.08.28.12.31.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Aug 2024 12:31:49 -0700 (PDT) Date: Wed, 28 Aug 2024 15:31:47 -0400 From: Mark Johnston To: Jessica Clarke Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Subject: Re: git: c7a7e997d25d - main - atomic: Avoid casting the return value of atomic_load_ptr to void HEAD branches config description git-daemon-export-ok gl-conf hooks info objects packed-refs refs Message-ID: References: <202408281855.47SItml1024354@gitrepo.freebsd.org> <9559E6F1-0FB5-48E9-9827-50D6BD8E5446@freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9559E6F1-0FB5-48E9-9827-50D6BD8E5446@freebsd.org> X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4WvF0S38F9z4tSr On Wed, Aug 28, 2024 at 08:15:38PM +0100, Jessica Clarke wrote: > On 28 Aug 2024, at 19:55, Mark Johnston wrote: > > > > The branch main has been updated by markj: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=c7a7e997d25d0b33769252d002b16839c864c83d > > > > commit c7a7e997d25d0b33769252d002b16839c864c83d > > Author: Mark Johnston > > AuthorDate: 2024-08-28 18:51:06 +0000 > > Commit: Mark Johnston > > CommitDate: 2024-08-28 18:55:39 +0000 > > > > atomic: Avoid casting the return value of atomic_load_ptr to void * > > > > Otherwise a cast is needed to load a uintptr_t value. > > > > Fixes: e1f4d623779d ("rangelocks: remove unneeded cast of the atomic_load_ptr() result") > > MFC after: 1 week > > --- > > sys/sys/atomic_san.h | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/sys/sys/atomic_san.h b/sys/sys/atomic_san.h > > index eb6913296a45..ef81b4b7c51e 100644 > > --- a/sys/sys/atomic_san.h > > +++ b/sys/sys/atomic_san.h > > @@ -266,7 +266,8 @@ ATOMIC_SAN_THREAD_FENCE(SAN_INTERCEPTOR_PREFIX); > > #define atomic_fcmpset_rel_ptr ATOMIC_SAN(fcmpset_rel_ptr) > > #define atomic_fetchadd_ptr ATOMIC_SAN(fetchadd_ptr) > > #define atomic_load_ptr(x) \ > > - ((void *)ATOMIC_SAN(load_ptr)(__DECONST(volatile uintptr_t *, (x)))) > > + ((__typeof(*x))ATOMIC_SAN(load_ptr)( \ > > + __DECONST(volatile uintptr_t *, (x)))) > > #define atomic_load_acq_ptr ATOMIC_SAN(load_acq_ptr) > > #define atomic_load_consume_ptr(x) \ > > ((void *)atomic_load_acq_ptr((volatile uintptr_t *)(x))) > > This variant is similarly wrong. Thank you, fixed in cb91dc50950f. From nobody Wed Aug 28 20:39:38 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WvGVf3TKDz5Mj1W; Wed, 28 Aug 2024 20:39:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WvGVf30Qkz41Qq; Wed, 28 Aug 2024 20:39:38 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724877578; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=CmVvy4SCeRxKdldD0uO8fQmVPmjHfLNfbNiUq4Y1aVw=; b=fFC3PrPPxRgYu7N7bWzXyFi6pGN747ePJVNeAw16C3fqu+RfoU26jkSLjUeP680XYe/7md jty+V2VHCDv8sBkUZ5cedpOgFgnnZVfQX6pzLkB1DVvmPYJa37xUL0FF/rgA1qUbO6shWj qCFTmodZi/0crmUzVnjRR6O2a+1B/hoobi/AU8r5axKzlAzuja98jiyraSPuBNE5Ztfdxh 5QXN9I3b4NeS0m71i8zMkVTIJDJBaAyXsgpeu+Ctem7FWdaaQRH3+eFvCUaU8/1oAnofTL J2GWa/Q/C1X0Ncdb15GxpLgb5JAgEPE+u/JHOZ8ME9eKMyVBFjzmjchA14gv6A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724877578; a=rsa-sha256; cv=none; b=SJff5UjHDGcv3TWni07XXEoy4k2TfKhcf1kTouNzwhPv+fDe1N8LlabzrI9xTHnqitIYUT 8lnyrFjribJWKJZIsvpfm2P+b2m54Hd5cMEVzJMlB+ogaGIBOziKP7Ww07FqjApfIc+OfH /gfhx51hjIdUEqk013/EUpocLIWW7nqXqQ/a1lWPuExdWQnrmvEI2D3sTtbZhMVkIP2lN5 2uRKsMtvaKHh3NfK2rONCUBtBx9gP0GrhPOcbyMiBU1Ijlor62ds8TG+WCtaU91uEnxRGr a9Q8zmghW/T5oTy20FwVOa/RFv6zJ4HanpVN/Fy510ESxOCsOaiolPSITDlArQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724877578; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=CmVvy4SCeRxKdldD0uO8fQmVPmjHfLNfbNiUq4Y1aVw=; b=h1kjrqxNiqoUizjxyTom8an87NvQjjcu2tkdUq8RFXnSL9KmMQ29yM3upPhcAUAvmBkPtS Zk3nUFPk28VZMuNyiVlEJ5DHNNSg0Z+MfEKqtTm/LqqKEeuyHP+YnNnqJAxTzQN6wzuwGc AEH7nqc+WcqHuam37sTyLWUWVjS1PbMUisj+16fGv7UUI/qBAJ7l6BvSWe/6RPy/gAoxTp JGSQZDGs9/ZyD5g+2gL0c+qRLVcMDFfIcIf0ozjR7BdzIrlVYDKr0Efw0Li9nntM9s4dOb CTieAO4DUuKc2dMEvhWa5YsRycnC0RMy385z4I3aiUon3F2LfRSqWKMncBM8pA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WvGVf2c8WzpY4; Wed, 28 Aug 2024 20:39:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47SKdcmx095719; Wed, 28 Aug 2024 20:39:38 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47SKdcjS095716; Wed, 28 Aug 2024 20:39:38 GMT (envelope-from git) Date: Wed, 28 Aug 2024 20:39:38 GMT Message-Id: <202408282039.47SKdcjS095716@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kevin Bowling Subject: git: f622dc5daecc - main - x86: Detect NVMM hypervisor List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: f622dc5daecc5c05504cfc605b6f2d66a3bd90e8 Auto-Submitted: auto-generated The branch main has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=f622dc5daecc5c05504cfc605b6f2d66a3bd90e8 commit f622dc5daecc5c05504cfc605b6f2d66a3bd90e8 Author: Kevin Bowling AuthorDate: 2024-08-28 09:31:35 +0000 Commit: Kevin Bowling CommitDate: 2024-08-28 20:39:07 +0000 x86: Detect NVMM hypervisor MFC after: 1 week --- sys/kern/subr_param.c | 1 + sys/sys/systm.h | 2 +- sys/x86/x86/identcpu.c | 1 + 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/sys/kern/subr_param.c b/sys/kern/subr_param.c index ea5e8d02be2b..7d58208a461f 100644 --- a/sys/kern/subr_param.c +++ b/sys/kern/subr_param.c @@ -157,6 +157,7 @@ static const char *const vm_guest_sysctl_names[] = { [VM_GUEST_BHYVE] = "bhyve", [VM_GUEST_VBOX] = "vbox", [VM_GUEST_PARALLELS] = "parallels", + [VM_GUEST_NVMM] = "nvmm", }; _Static_assert(nitems(vm_guest_sysctl_names) == VM_GUEST_LAST, "new vm guest type not added to vm_guest_sysctl_names"); diff --git a/sys/sys/systm.h b/sys/sys/systm.h index 6c2b466c4cfe..61874a05e0b9 100644 --- a/sys/sys/systm.h +++ b/sys/sys/systm.h @@ -79,7 +79,7 @@ extern u_long maxphys; /* max raw I/O transfer size */ */ enum VM_GUEST { VM_GUEST_NO = 0, VM_GUEST_VM, VM_GUEST_XEN, VM_GUEST_HV, VM_GUEST_VMWARE, VM_GUEST_KVM, VM_GUEST_BHYVE, VM_GUEST_VBOX, - VM_GUEST_PARALLELS, VM_GUEST_LAST }; + VM_GUEST_PARALLELS, VM_GUEST_NVMM, VM_GUEST_LAST }; #endif /* KERNEL */ diff --git a/sys/x86/x86/identcpu.c b/sys/x86/x86/identcpu.c index 4da250c535a0..f24fdc1647e6 100644 --- a/sys/x86/x86/identcpu.c +++ b/sys/x86/x86/identcpu.c @@ -1370,6 +1370,7 @@ static struct { { "KVMKVMKVM", VM_GUEST_KVM }, /* KVM */ { "bhyve bhyve ", VM_GUEST_BHYVE }, /* bhyve */ { "VBoxVBoxVBox", VM_GUEST_VBOX }, /* VirtualBox */ + { "___ NVMM ___", VM_GUEST_NVMM }, /* NVMM */ }; static void From nobody Wed Aug 28 22:43:32 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WvKFd0vjtz5Mt8D; Wed, 28 Aug 2024 22:43:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WvKFd0Pv1z49WS; Wed, 28 Aug 2024 22:43:33 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724885013; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ezRUbp/hDCWkmMyWqpepEARf/gW3PZmAHjG2PXMko7c=; b=bV6GQVkBDQAC6xsS49Ens//tW3aQ7SwmjAxJjlOjNNoLdSBah7LnpJ4Owp59mgKpm3kdCR ksGCBWxxBEDP9iZC9axD07G+96wXK25x67ZodF70MBZCfNbKXiLbcrvUWDTmW10UeOyGiN ysUwRVHfdVDZBLpNiiZmE/G8owWpUZdQow/7erdJWb3fkt7B1B0hQ9mX/a14ZabUJ8DKkh 9ZS1TuXrMEowMfeAX+uV1uRSIWpPPeZDXEcdgekDnvjWEfXomS8OQYxQ8MxaZgDBZNqOO4 UuFgFkOMJjpB5G1zYYQVorN7rvRtj75/ZZgb66za0fkVFA5bvFqnKLym2uutww== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724885013; a=rsa-sha256; cv=none; b=kdv3RZpmjiSJ1XIdadIdq4f1I91WZQK4OzO1YaAVGoSPja12PhmdrlQQYnFodnYOoYm7Bg 01hfoeKhUG5Du2iCFmFm7XpHHvqyu8IZnsBOMtGr5nlR/58Kf7Imr5c/GbeeQdy77sfDEw 2+9BpJT9PqL4hBQLPPTDwkjkbSrFebrdC3k7jpl42iF021YeUJf9sZCPhXOsf4WulxuxXX /eQPn1Pxfs9BJwGY6b1kqLWY5snjuVu3QTi6PLTU6o+JmHAPjZtFgJk0+DgvJYQYjYhNSu XG3VxobleFd88b/XVIZan6xVTGbQq+ZBGqqmgaXjP2BInLA7g77jTtL+X7oaZQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724885013; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ezRUbp/hDCWkmMyWqpepEARf/gW3PZmAHjG2PXMko7c=; b=d71meSWpNbwuCWNZuEwC157TjF4TzPJEfszioy9UbT9DVl/FoBfAjn+/e7Up5+ggPnhwMS qxdzvMhEM4JCUhXfMkTPuM346UoHfFQSNrll1rPQAhw2DLh3CCfHYKYoHERaEzJVoPIBkL yBd7hfKUjUGS0Q27EGMewHibqL8j4YdzMx4qaD/ig2wjD173BuSDu/GYt1YR4DrN70uqCf peRVmWDzVzTQKFsVD6kfv3wtbvOAPTRsU2/PEeA+IvkCs3fbtIUBMmlxQU1gxgQenSUup4 HvJ1hWFGc1vytMA/nPXsv5PqdMtzPREYUQg4fdn5ZnyFOmblU150nfWE+bocgg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WvKFd00cmzsTv; Wed, 28 Aug 2024 22:43:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47SMhWnQ014484; Wed, 28 Aug 2024 22:43:32 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47SMhWfP014481; Wed, 28 Aug 2024 22:43:32 GMT (envelope-from git) Date: Wed, 28 Aug 2024 22:43:32 GMT Message-Id: <202408282243.47SMhWfP014481@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Jessica Clarke Subject: git: 18aef07cfac4 - main - beinstall: Pass -B to etcupdate List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jrtc27 X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 18aef07cfac41fde763e1328366cc6e334bb9254 Auto-Submitted: auto-generated The branch main has been updated by jrtc27: URL: https://cgit.FreeBSD.org/src/commit/?id=18aef07cfac41fde763e1328366cc6e334bb9254 commit 18aef07cfac41fde763e1328366cc6e334bb9254 Author: Jessica Clarke AuthorDate: 2024-08-28 22:36:56 +0000 Commit: Jessica Clarke CommitDate: 2024-08-28 22:36:56 +0000 beinstall: Pass -B to etcupdate Since commit 246364454fc1 ("etcupdate: Use new buildetc and installetc targets when available"), beinstall has been much slower for the etcupdate step, as it's been doing a kernel-toolchain (admittedly without LLVM itself being built). Given beinstall requires an object tree to already have been built and just installs it, we can pass -B to beinstall to reuse that tree rather than build kernel-toolchain in another one. Reported by: olivier Tested by: olivier MFC after: 1 week --- tools/build/beinstall.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/build/beinstall.sh b/tools/build/beinstall.sh index 7f7481b671f5..dcafd1030c91 100755 --- a/tools/build/beinstall.sh +++ b/tools/build/beinstall.sh @@ -48,7 +48,7 @@ NO_PKG_UPGRADE="${NO_PKG_UPGRADE:-""}" # Config updater - 'etcupdate' is supported. Set to an empty string to skip. CONFIG_UPDATER="${CONFIG_UPDATER:-"etcupdate"}" # Flags for etcupdate if used. -ETCUPDATE_FLAGS="${ETCUPDATE_FLAGS:-"-F"}" +ETCUPDATE_FLAGS="${ETCUPDATE_FLAGS:-"-BF"}" ######################################################################## From nobody Thu Aug 29 01:37:27 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WvP6J3NbPz5PcbF; Thu, 29 Aug 2024 01:37:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WvP6J0VBPz4SbB; Thu, 29 Aug 2024 01:37:28 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724895448; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=x+LJ2N9Q/SvZBXDKhxCWo+JEORGYoBMdLu5O8my5LKI=; b=oJPPEXTNCz4qeeGr3v4UmSokrUNT+LwcqxuUqSAZkxSiPY3oHjwqJhLD+2m74ekXHpchgW BP8VqWuxw02pElN8y3J5ofubwVUd8drsM50tWRvCK+xm4uLdZUCjRonvElDOhTTwx25SD/ BAFeXGw5FwBsPTeVx06kiz+7kDsUEWaBF3EqejFHfV57/baWb+GD1Pli/nE3/1vqDUHBRQ QTwmXz6SgKJ3jKzL9dX9r1Bau+hc1OmcuR+FYCsQ2/fl7h3FAH0ZndgYvrPkNuJl2gD4IS H6MzjsKha23vH4Md00T0sChW/zowHkVPsoMQneMVjY6Pmgk6DUwRF+lmQAyhCQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724895448; a=rsa-sha256; cv=none; b=eyx/B8tC4uprei9yGZbOlDA1Wp054eRnigbye0/bDIveiZOcELRgVEUmgHgVrJVIyvPOpy UGtF4nykvcEOChqMGGl+p4uZSaCfAgLjxkcuUFaOuLtrTfuM0L6ElnD6Qq/iHnlWkv61HO E3NO9NB7ZZo/J0cszEaaqr+zbi8rQfpfTGvdemZRd/lfpBt3wljYX1/YAp8uh2C9q9uA/g pmHR+gITg/SvFcla+SQr2QqYh/OaNpvR9b3mO/HT6rSMFUB5eJv+AeuJON9zzUuILuNr8y McvUx+I5054hNcRB/WKkEeF2thasatXhpvmIcu2IMfpdL/b0MohKkEIzTM/HNw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724895448; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=x+LJ2N9Q/SvZBXDKhxCWo+JEORGYoBMdLu5O8my5LKI=; b=V+vTO1+InUksQWncuxy4y7xVLO9UKeP7+pwRD45UxpAEmxyUJJ78f0n9gst4/a897J2HMk DEmXPEUNSl8t75UyaClLimhp0wEQw4p7b5xmxPqcL//LVRIWrIY3CddsxV7SZ6i7C9imV0 SU5nq7gsgaBWogR0qx4BIbkCTZrkiDUH76l1yWZhBPKxQZBRMo8yctKm8ydhC0nieqKirh gVXvaKl/M8DashMBVIXXJJDCCExxH78LnQD1fNJUDd3YgdDorI61ro3QQPApnRlJm6WnL4 5A9pjbY3uO3jBhGRpQzZgNKuXAW6lSpFZBLfthOi/KANjRGJ68i/But0qJpHVQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WvP6J05R7zxhv; Thu, 29 Aug 2024 01:37:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47T1bRfK003294; Thu, 29 Aug 2024 01:37:27 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47T1bRnw003291; Thu, 29 Aug 2024 01:37:27 GMT (envelope-from git) Date: Thu, 29 Aug 2024 01:37:27 GMT Message-Id: <202408290137.47T1bRnw003291@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Jessica Clarke Subject: git: 62775aebf725 - main - rc.d/devmatch: Silence sysctl hw.bus.devctl_nomatch_enabled=1 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jrtc27 X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 62775aebf725a79703592f3276118245a74afdac Auto-Submitted: auto-generated The branch main has been updated by jrtc27: URL: https://cgit.FreeBSD.org/src/commit/?id=62775aebf725a79703592f3276118245a74afdac commit 62775aebf725a79703592f3276118245a74afdac Author: Jessica Clarke AuthorDate: 2024-08-28 23:26:26 +0000 Commit: Jessica Clarke CommitDate: 2024-08-28 23:26:26 +0000 rc.d/devmatch: Silence sysctl hw.bus.devctl_nomatch_enabled=1 As with various other rc scripts, we don't want the output from this being visible in the boot log. Fixes: 6437872c1d66 ("New sysctl to disable NOMATCH until devmatch runs") MFC after: 1 week --- libexec/rc/rc.d/devmatch | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libexec/rc/rc.d/devmatch b/libexec/rc/rc.d/devmatch index 21846355fcfe..0999159bb332 100755 --- a/libexec/rc/rc.d/devmatch +++ b/libexec/rc/rc.d/devmatch @@ -46,7 +46,7 @@ devmatch_start() if [ -n "$one_nomatch" ]; then list=$(devmatch -p "${one_nomatch}" | sort -u) else - sysctl hw.bus.devctl_nomatch_enabled=1 + sysctl hw.bus.devctl_nomatch_enabled=1 > /dev/null list=$(devmatch | sort -u) fi From nobody Thu Aug 29 03:39:44 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WvRqP1SbMz5T2Dj; Thu, 29 Aug 2024 03:39:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WvRqP0hdRz4g4m; Thu, 29 Aug 2024 03:39:45 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724902785; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=t4xB94cajMt/FZMSQlqLwLbaI+12/HIjK3P6qStC15w=; b=DNsVPSYefxCUbSVIwU/EOipnRjg3oBXN1WAOrNzXH+kdukuQMP5skEebAg2j7BiBfKAilg LMeCUXPX2ss78xz6dmo6w2TU7N6Uu3CbSs+SZ63kOhmEl/H3HYckopRZ5XvGabijyuY+3q TJP1oHNH9fsEb6QejbqvYsJB6zio3t1SDSvj1/Xe4svUlhMZ78gyL+8HRwobDyIS8YqQo1 Wh6IijBn2tnBLWohjP4Lw17okFkHL9C9AyiRDqLDPqbZBTmUQUnzqDMK/MvJJN8VVfbkGZ In5bL0O0nJWffDIji6IzE7M5zpQD/QpKrUUF9x20GeyGFR61Kiu8uCWfiCIKPw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724902785; a=rsa-sha256; cv=none; b=FORRYhLcG8AdTFpxhKJHxBi9DJsyOlrd3UNXNSZU4KqHnqY3jEddrCPB99or0naRW5aE9r MmqkiOm1aXUHi957Rhx6SAHAK/icyPNN7f06+kFFfuxB5MMvs5im9OcPDFubVEapj8oefO Hot24h/DYXG/tEHCS2DvWnYvSTFuvRxhe+2hkhRjlWqN/+0dCfRYk2NKbh0/brtg/SbK0r cKVj129UmhQV6zphYDMjT4jd5++qGMeROXnIZtU0FK/njn3Dk6j3UD3Lcxd/MBfkKU7KOb 6aOPrAUw12/pWWXAjJZ5wVZCy6T5gZL4pXu+V6flUWaFCVdnDQlf16KsHrwGoA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724902785; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=t4xB94cajMt/FZMSQlqLwLbaI+12/HIjK3P6qStC15w=; b=D5OyVBfLPPrI7cLZbidYQqibF6r0tChiGJnURkeMgi+dX8T+rxHOvcSBv7oi0UPHvLWOmp o3x39ynQNgs0hKC7uLLxPDaRlsLXdO1bYN5JD0VkAUq3rKOTQeeDXf0x6x67/lEgtuNrqw XG3XFV78k2TP/8d1EYcJ1Nm1Fjabs5sYMvcFv8zhCUs6rsgYnH0k+SdfA9NLuz2C/fjw3i Pd8e7H2gw0GJ46au3cWeHhH2iX2Zl6CRGYLTYzUj09GwUZljDg9QnCy2P30zYs+fY0E6XH JBsqSih3f4QlFDzaF0iOd3MTrR9U/Ecxm9fMQP2Qjd2Y9CT/PAuaeUc/ehVthw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WvRqP0GQWz1207; Thu, 29 Aug 2024 03:39:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47T3diGH008555; Thu, 29 Aug 2024 03:39:44 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47T3diHQ008552; Thu, 29 Aug 2024 03:39:44 GMT (envelope-from git) Date: Thu, 29 Aug 2024 03:39:44 GMT Message-Id: <202408290339.47T3diHQ008552@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Navdeep Parhar Subject: git: 3f250bb6f05b - main - cxgbe/iw_cxgbe: Tidy up a couple of CTRs in c4iw_create_listen. List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: np X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 3f250bb6f05b57890215398767bbb8aa00c888f3 Auto-Submitted: auto-generated The branch main has been updated by np: URL: https://cgit.FreeBSD.org/src/commit/?id=3f250bb6f05b57890215398767bbb8aa00c888f3 commit 3f250bb6f05b57890215398767bbb8aa00c888f3 Author: Navdeep Parhar AuthorDate: 2024-08-29 02:33:09 +0000 Commit: Navdeep Parhar CommitDate: 2024-08-29 02:40:04 +0000 cxgbe/iw_cxgbe: Tidy up a couple of CTRs in c4iw_create_listen. backlog is an int and not a string. While here, fix an adjacent CTR that was spread over two lines even though it fits in one. MFC after: 1 week Sponsored by: Chelsio Communications --- sys/dev/cxgbe/iw_cxgbe/cm.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/sys/dev/cxgbe/iw_cxgbe/cm.c b/sys/dev/cxgbe/iw_cxgbe/cm.c index 257dec81f384..c3d334aa0f62 100644 --- a/sys/dev/cxgbe/iw_cxgbe/cm.c +++ b/sys/dev/cxgbe/iw_cxgbe/cm.c @@ -2706,11 +2706,10 @@ c4iw_create_listen(struct iw_cm_id *cm_id, int backlog) struct listen_port_info *port_info = NULL; int rc = 0; - CTR3(KTR_IW_CXGBE, "%s: cm_id %p, backlog %s", __func__, cm_id, + CTR3(KTR_IW_CXGBE, "%s: cm_id %p, backlog %d", __func__, cm_id, backlog); if (c4iw_stopped(&dev->rdev)) { - CTR2(KTR_IW_CXGBE, "%s: cm_id %p, stopped", __func__, - cm_id); + CTR2(KTR_IW_CXGBE, "%s: cm_id %p, stopped", __func__, cm_id); return -EIO; } lep = alloc_ep(sizeof(*lep), GFP_KERNEL); From nobody Thu Aug 29 08:01:18 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WvYdC0BSmz5MVc3; Thu, 29 Aug 2024 08:01:19 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WvYdB6s6gz45XM; Thu, 29 Aug 2024 08:01:18 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724918479; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Dt+r1nqgjs4/1PBbTWN2z8g+jM6fNG18ZQx4ujCBpqo=; b=KP5MmwIQpWze10hLYMNp2mgmTwUtCw0P8iUQmQB538iR2wjbCIGFDiD08GOtLdd/x1nz/j 8bjgsSAu7LqVDGZY9Hw0tUH5pQPF9spuwL8DcMywCtQNc23F07O2nWP12ouZ/3J7r0VnTo Lkn33UP0R0U6SIXZ2oCNLHpT0ZMRTT/kQqx2Cm3+SsC1lYIAq5ul+JmIK8d0CAV1DGjiWq cEZXYD6BqsCvJqIT0FWqqgeeo4wE0REoYxrD8mt6n7tXzAyCwtYWdU1AnmZUejBk07+5Ad 14WVgWWGpG6prBExoHNIiTGK8YCkx8OtVrIdxWzmPkE6fUaTdWeiz1v2vOekYQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724918479; a=rsa-sha256; cv=none; b=pfXsqw2dudTl4MLyOlrC9vbHosItjLzULjhEZWELg5QlYW+P4TyHLtJ1nOmZ1yqbtSLwWn N4TlyqKNgA0KT5tqjP/tvZ2AYY1vxHb9bIeXB8AFCQBpaUp1rDAZHZMRjBYy/Q57PUn+P/ aB6sphizNzt7UsyRVmradAuE3gvdLswn2CadA/khtsz7LSd4hPNx5SI9jYiv9dSOjrAEHt X92Pq1PhihLwiqdWMtfEbbG44z54q+nbEdjJlgyoIgP1L1hv5Y3VgF5oGrjThBcamV7Y5C N/KU5EC5w3LQE6ikvluz027Bh/p8YKKLC4vogO/aC14aInRbB7Qk//5hvDfgwQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724918479; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Dt+r1nqgjs4/1PBbTWN2z8g+jM6fNG18ZQx4ujCBpqo=; b=bC8CCzxxTV8tkkniZclrVimKOVdcTzQeczFwtsxmoKZ5dzNdcZqx+y2I0HMr7ZNzPivL1i aWS4XF2Ysy8z8pPVaXd0h7MFtS3wN7dDk0eKijPrt9Jzv3gurZuEElTnvhtsSBlG9nXMSf grpPdSIauk3xH/55Z6qMhxPDgNL+7T/cfOkaMY/dZZSwyx4meNVEOqz+lhMy5icY8kU0Bo NTPT7Su812qtKGeVs2irfCpc5cvxkEbj5RbrHTt/NkcAyL+saLxtgG+HBt+yaA3QF4h9EE K51XA+4UxXx63hI047z90DJQXtNvOEpd/V4X5LS0ElcOXLU3gkHJ2lrL/rTJTg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WvYdB6PV0z18X5; Thu, 29 Aug 2024 08:01:18 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47T81I7U064427; Thu, 29 Aug 2024 08:01:18 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47T81IP4064423; Thu, 29 Aug 2024 08:01:18 GMT (envelope-from git) Date: Thu, 29 Aug 2024 08:01:18 GMT Message-Id: <202408290801.47T81IP4064423@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Peter Holm Subject: git: c7c3f6351e96 - main - stress2: Update comments and remove one test List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: pho X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: c7c3f6351e969d9659376ed24286d2638fc4d794 Auto-Submitted: auto-generated The branch main has been updated by pho: URL: https://cgit.FreeBSD.org/src/commit/?id=c7c3f6351e969d9659376ed24286d2638fc4d794 commit c7c3f6351e969d9659376ed24286d2638fc4d794 Author: Peter Holm AuthorDate: 2024-08-29 07:59:16 +0000 Commit: Peter Holm CommitDate: 2024-08-29 07:59:16 +0000 stress2: Update comments and remove one test --- tools/test/stress2/misc/all.exclude | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/tools/test/stress2/misc/all.exclude b/tools/test/stress2/misc/all.exclude index 91fb68afabfc..f8a5ea4a91f1 100644 --- a/tools/test/stress2/misc/all.exclude +++ b/tools/test/stress2/misc/all.exclude @@ -14,9 +14,8 @@ fsck10.sh Waiting for fix 20230319 fsck11.sh Waiting for fix 20230319 fsck12.sh Waiting for fix 20230319 fsync.sh panic: Journal overflow 20190208 -fuse.sh Memory corruption seen in log file kostik734.txt 20141114 -fuse2.sh Deadlock seen 20121129 -fuse3.sh Deadlock seen 20141120 +fuse.sh https://people.freebsd.org/~pho/stress/log/log0546.txt 20240828 +fuse2.sh https://people.freebsd.org/~pho/stress/log/log0547.txt 20240828 getrandom.sh Known DoS issue 20201107 getrandom2.sh Known DoS issue 20200302 gjournal.sh panic: Journal overflow 20190626 @@ -39,7 +38,7 @@ mlockall2.sh Unrecoverable OOM killing seen 20190203 mlockall6.sh https://people.freebsd.org/~pho/stress/log/log0430.txt 20230403 mlockall7.sh Needs further investigation 20210123 msetdomain.sh May change policy for random threads to domainset_fixed 20210104 -newfs4.sh watchdog fired. newbuf 20190225 +newfs4.sh watchdog fired. newbuf (still seen 20240729) 20190225 nfs10.sh Double fault 20151013 nfs13.sh mount_nfs hangs in mntref 20191007 nfs15lockd.sh panic: Assertion td->td_realucred == td->td_ucred failed ... 20210211 From nobody Thu Aug 29 10:43:09 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WvdCx4ywSz5MkPW; Thu, 29 Aug 2024 10:43:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WvdCx499Bz4P42; Thu, 29 Aug 2024 10:43:09 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724928189; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=kPvWH55tekctlZi5w4S+uPwik24tWywspdC45q71czQ=; b=ZSsTEGum6FhXMHqC3r5Q7F5ZDAkL3/KavFCAWavyidi89AK6pLW/3sByuw6Q5gHz3PqZ5o Zaz5uCkl3kfxlc2EJ1+Eo1Y6DLyfeKlSQGIaWJE++MuQAIIf8b1THzvUm4d3xDkiXFsvSx sRr1poYNTB6Px+GLkEH6xYiCoXdKWuNiHo0Yf8zFB8tIVn4///FZ5vmw41GubWT6JuaD31 iDLJPMFsIb9cZHnj24cUo7wYTyH++vsIySNgsieHfAj0LfF6K4XSZ+rXElWIPcuelgxtZJ +h+KMyqiJcT8QJ5gQ1RJOhzWuUfy+XtVITU4vy+dk7AVI9bHFWvgWiYCjfXbCw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724928189; a=rsa-sha256; cv=none; b=oT9jc+121jqDzR4spsLgAN71O4XYvbIxCBenyxFLLBrwzZ1QsLzv4IbY9SAdvdyqn2ap2g RLRyNPYmNHtKxDyiKK4Vbjy4K9o5r60jg6B50lMEXzrmBFeZB1O2kT1sNvlkXfxZU8OH4z bFDlCF6N+zia5N/uMpZhaf834ehVdQNYCwjXdtgNcgIhUfhUhGKVvtE0ltDoH2uEk9mfwq y0oPABOUi9bLHEr/pX/JGaKidlFgsq184QOfpPd609yzWf7tTMi8KgchXyVwGFFo9WDL2l wYI0Xkt7v2uXCYMuzyrxWS54r8vQbmFNLTX9vDCNVdPCRDyB3wi3Q3aqab33cA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724928189; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=kPvWH55tekctlZi5w4S+uPwik24tWywspdC45q71czQ=; b=mSuewP99/ZjUHuYuuxJZaHKt2/YroM24ecCbWFJXHiC86aD5GUTE3G8KOyFPNNGN96Lapw 88M1+Eaz2gahMLGBoh4z9ZtZEDh54mkTG2JTEb4zJx2jjoSFxPcbGfIoC7c/WQTl/MY90z RiQ7mo2O09/m0frPuwQpdO/5R0s+sKTU7QG/J3XBrvckHEOqZDwEVO2mqew4D0ajxj/b71 SRHyIWS1caqO87wZ98ZHVhb54WvrYfMHdejaM7lKIyXrl8qKfKqYJfwaRy6D8Vbw44wnyH 6vIr9j4BTOYr7stL2DvVzWqtu8KeRJGFbnpB2VETM6/UakDSzqXO5JWWsxd/Rw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WvdCx3gnqzFMk; Thu, 29 Aug 2024 10:43:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47TAh9ED037176; Thu, 29 Aug 2024 10:43:09 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47TAh98F037173; Thu, 29 Aug 2024 10:43:09 GMT (envelope-from git) Date: Thu, 29 Aug 2024 10:43:09 GMT Message-Id: <202408291043.47TAh98F037173@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Andrew Turner Subject: git: 8b017284319c - main - arm64: Fix the ESR_EL1_op2 value List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: andrew X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 8b017284319c46d349abee5573d4656bb377b0fd Auto-Submitted: auto-generated The branch main has been updated by andrew: URL: https://cgit.FreeBSD.org/src/commit/?id=8b017284319c46d349abee5573d4656bb377b0fd commit 8b017284319c46d349abee5573d4656bb377b0fd Author: Andrew Turner AuthorDate: 2024-08-29 08:51:30 +0000 Commit: Andrew Turner CommitDate: 2024-08-29 10:42:34 +0000 arm64: Fix the ESR_EL1_op2 value This leads to an unallocated register. Fix the value to point to ESR_EL1. Sponsored by: Arm Ltd --- sys/arm64/include/armreg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/arm64/include/armreg.h b/sys/arm64/include/armreg.h index ce21bf4de0a9..a04afd57585c 100644 --- a/sys/arm64/include/armreg.h +++ b/sys/arm64/include/armreg.h @@ -676,7 +676,7 @@ #define ESR_EL1_op1 0 #define ESR_EL1_CRn 5 #define ESR_EL1_CRm 2 -#define ESR_EL1_op2 1 +#define ESR_EL1_op2 0 /* ESR_EL12 */ #define ESR_EL12_REG MRS_REG_ALT_NAME(ESR_EL12) From nobody Thu Aug 29 13:51:09 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WvjNs6ff9z5PTf8; Thu, 29 Aug 2024 13:51:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WvjNs647Yz4ftS; Thu, 29 Aug 2024 13:51:09 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724939469; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=smfGShyH+mGQnhM/S0HzA9p4rOENWIvfXJWjZkTGUN0=; b=ak9ADn+czsIu0uNSEVCoCJq7oxQJXdmLyAr21475Dw5bT7GV+DIlz0tyrBUYzGWMa4Yfls lG7Sl9BUJ55ltIaZY1T80JUkPoQOxvNfI3rThBrQ9+a0hQZxEfiSFsmKyzNgTWQBWGaaf/ AJBXXofP8+h86rkZtZoVJm7UheB4YuKrSjjUF/oFV9bRn6tZdY7nTPXLoXqr4ERWWHHxdB uPDN1mb64OxkCFvRCGC8MP6gMimD73XuXJPntq1wWC+6QRSa96v2izKuRIdr2QOkfPV8m+ 2f561qJacOWVFDG4P/6M6UZsq1+YVSnnTArHgIRnyx6mP3CBd6idK0Q3fao2Xg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724939469; a=rsa-sha256; cv=none; b=FOufqgi/5WjChXV9JWCs8/SRXxslW3invDB5DmXu7g1tCRrls0D02wgbWNLuMUfamNTXR2 7wFwWj64n/H865GbmMoyINebWrguVbx75P5vgo8RkGvcZTeAlL/SpPsRbCKObiUiHu4uqn uM6Zej+dizxMGq7fC0D5rP3qjJwtlTQENZJ+/bd0R7Bc8EqXzjqIpQSw8Wqj+ek/JhlufI afHMyIBEIbEc7lOnlPwq/FOlmDQkRblfuEep9QRaHkg6kfzSqVo0vSZlaSLWacOlk/OPqt pv9550SNVkgfZtOknqCBkqbzO2jMdyQGCRzw5OxACa+m4ATrRsKVeqTvmLjS0w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724939469; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=smfGShyH+mGQnhM/S0HzA9p4rOENWIvfXJWjZkTGUN0=; b=KVC5QpQD9XsN3Y3Q7wk5y4bzxt8ZxIdX1V9hiDi4ztdJ+e4SFjnafDp+HkpvMSUhd7wz2M c6w1Xrm7WieGspEyQcifAhpyH4+e9WA5RyQZkgo/Kntuj2tXJa7ahqyf0IG2gM5tqP4IRT oz7QfVqCUzYe1WTuJfz7P3WwK9aLYtoAKCs9TiCoKV+MYhK6rNF8GVbQTUJNK93MNouC8k WCKMEDAn22ij/hh8eb2KDkf7Z0dEYd9PsWkxmF7PpAZ9aeo+P35ePm+nljzuBzdR+Hj26X /XCpN3lpSt9N2Ioj1zJTDK5Y6wiKX/qr4sB8XDcojobJxJbr/Of416q3t6wJDg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WvjNs5hGKzKL4; Thu, 29 Aug 2024 13:51:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47TDp9EH052303; Thu, 29 Aug 2024 13:51:09 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47TDp9fZ052300; Thu, 29 Aug 2024 13:51:09 GMT (envelope-from git) Date: Thu, 29 Aug 2024 13:51:09 GMT Message-Id: <202408291351.47TDp9fZ052300@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: 0c605af3f9d9 - main - netinet: Explicitly disallow connections to the unspecified address List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 0c605af3f9d9e66be6af0a3bbc36dbedc5dfe516 Auto-Submitted: auto-generated The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=0c605af3f9d9e66be6af0a3bbc36dbedc5dfe516 commit 0c605af3f9d9e66be6af0a3bbc36dbedc5dfe516 Author: Mark Johnston AuthorDate: 2024-08-29 13:11:15 +0000 Commit: Mark Johnston CommitDate: 2024-08-29 13:11:15 +0000 netinet: Explicitly disallow connections to the unspecified address If the V_connect_ifaddr_wild sysctl says that we shouldn't infer a destination address, return an error. Otherwise it's possible for use of an unspecified foreign address to trigger a subsequent assertion failure, for example in in_pcblookup_hash_locked(). Similarly, if no interface addresses are assigned, fail quickly upon an attempt to connect to the unspecified address. Reported by: Shawn Webb MFC after: 2 weeks Reviewed by: zlei, allanjude, emaste Differential Revision: https://reviews.freebsd.org/D46454 --- sys/netinet/in_pcb.c | 2 ++ sys/netinet6/in6_pcb.c | 3 +++ 2 files changed, 5 insertions(+) diff --git a/sys/netinet/in_pcb.c b/sys/netinet/in_pcb.c index 70ddd581895f..6ea197cf68d8 100644 --- a/sys/netinet/in_pcb.c +++ b/sys/netinet/in_pcb.c @@ -1336,6 +1336,8 @@ in_pcbconnect_setup(struct inpcb *inp, struct sockaddr_in *sin, faddr = satosin(&CK_STAILQ_FIRST( &V_in_ifaddrhead)->ia_broadaddr)->sin_addr; } + } else if (faddr.s_addr == INADDR_ANY) { + return (ENETUNREACH); } if (laddr.s_addr == INADDR_ANY) { error = in_pcbladdr(inp, &faddr, &laddr, cred); diff --git a/sys/netinet6/in6_pcb.c b/sys/netinet6/in6_pcb.c index 098b4e50483c..501434f2fac6 100644 --- a/sys/netinet6/in6_pcb.c +++ b/sys/netinet6/in6_pcb.c @@ -368,7 +368,10 @@ in6_pcbladdr(struct inpcb *inp, struct sockaddr_in6 *sin6, */ if (IN6_IS_ADDR_UNSPECIFIED(&sin6->sin6_addr)) sin6->sin6_addr = in6addr_loopback; + } else if (IN6_IS_ADDR_UNSPECIFIED(&sin6->sin6_addr)) { + return (ENETUNREACH); } + if ((error = prison_remote_ip6(inp->inp_cred, &sin6->sin6_addr)) != 0) return (error); From nobody Thu Aug 29 13:51:10 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WvjNv0C2qz5PThj; Thu, 29 Aug 2024 13:51:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WvjNt6jplz4ffV; Thu, 29 Aug 2024 13:51:10 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724939470; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Xh66Z2S306AMs42ymgNji/UHzZlWL48lJ9Xp23CF3PM=; b=h/q31D4uALRzbgIMLisqvh6m9OVylLeWulJz5cgbBbrei+KGBqMV42fIz3ZZeCLlNKGW2b 4SpnRAL41oMACM4phD3KZGKveTs75FMSS2sCmJHs1thYBAs8kwq0FQee3rI1bzWkmmZy4b pu8yQubmprthBkmsI+e+JWJg5Zc5731ucaQOyuJv2uWWB0yq8jIoDtjVHQteQhxn/0+Cz7 r9vfmQ3PHUE5zeA1sVDKcLBvKGU4oTxjjFcw9sZqsEfJBLgOhh94EPpVDVrZ3VYGKgdiPF vRhzN2m3oEnd2/n+IFVwRhxR+Tg5p36AW7UaGh5njpX100CfczKJJRxysSo0Jw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724939470; a=rsa-sha256; cv=none; b=ZLPjKTL9dycDIxZLOp4wKNtRMum6QlYYZry0w1Od39cNbkH8iLf2iizAzof5FVonUM/DOi 8sgRCc9UmgePMsD7i7O9WDuHV5LCga+jcK14sWrT0EoJNJRzk8C8HLgRP6/KalCMWVVljU Ed3XbHKpWkBryFgDL+IrNvBFMgFAfoUC4bHgFALB9ed4ChwfJpRNYvrMcv8rkfmufa2Za+ Gd3jUD8GOHWI8sCyI4TPvi/f1Ckm9yc35t346blFhhlf05S8zBNzhsYmi5tOFcY+DaBn5x 0vvRUYAEkPvjyx2FOQE6ylh6lLDmIFralGZQAbjUwqxX6R+FeYciysQNzA6GSA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724939470; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Xh66Z2S306AMs42ymgNji/UHzZlWL48lJ9Xp23CF3PM=; b=GdmMXMlb8VQfB9Q5fG9swMF6BNxgjv3l1bmzvwxmeiaXx+/TorrzkQ/KnAT+tjBc5WWPk0 TwpjgDHf7qkWN7Edj5rPVF/OrhRc0hEMiuENEKq1ypCdZUy3FuXc7nYP42z4gCkREuZrkE GiCeOAUjqwWFi4sv3WVuWQQ53TWicLxlaK3my+XuoM/vQbyFYP6l8ihefsJ9XsnzbMXRMb 5q+Vbgs8YkQ0Fwi5R075x6KnytiC5xd0JxrDl8Grs68LYpDS793cwWaWzqBk5NFalDJ8HG 5ONhxyVG7CtJA9QHf6YLtKAdAC98GS1qpGs0JyJUutwRB8jk9BmpjAB7FclOQQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WvjNt6KS2zKWl; Thu, 29 Aug 2024 13:51:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47TDpAi3052350; Thu, 29 Aug 2024 13:51:10 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47TDpAQp052347; Thu, 29 Aug 2024 13:51:10 GMT (envelope-from git) Date: Thu, 29 Aug 2024 13:51:10 GMT Message-Id: <202408291351.47TDpAQp052347@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: 12500c14281d - main - agp: Set the driver-specific field correctly List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 12500c14281dc62ddeac4c5e1e6eabd1e380f11c Auto-Submitted: auto-generated The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=12500c14281dc62ddeac4c5e1e6eabd1e380f11c commit 12500c14281dc62ddeac4c5e1e6eabd1e380f11c Author: Mark Johnston AuthorDate: 2024-08-29 13:12:19 +0000 Commit: Mark Johnston CommitDate: 2024-08-29 13:12:19 +0000 agp: Set the driver-specific field correctly PR: 281035 Reviewed by: mhorne MFC after: 1 week Fixes: 437ea82ce7fc ("agp: Handle multiple devices more gracefully") --- sys/dev/agp/agp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/agp/agp.c b/sys/dev/agp/agp.c index f7eb906fc57c..8db1e13f08de 100644 --- a/sys/dev/agp/agp.c +++ b/sys/dev/agp/agp.c @@ -254,7 +254,7 @@ agp_generic_attach(device_t dev) mdargs.mda_uid = UID_ROOT; mdargs.mda_gid = GID_WHEEL; mdargs.mda_mode = 0600; - mdargs.mda_si_drv1 = sc; + mdargs.mda_si_drv1 = dev; mdargs.mda_si_drv2 = NULL; unit = device_get_unit(dev); From nobody Thu Aug 29 15:06:24 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Wvl3h4zLTz5PbHV; Thu, 29 Aug 2024 15:06:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Wvl3h4VVNz4nyB; Thu, 29 Aug 2024 15:06:24 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724943984; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/b0oZ7rOspwOwoU7ywgFTzueHh7zYJIxVyefSDFz5hk=; b=dCDE+K/MGzAMnZYNh3oW/E7zRcZUbhQIepCMzE4olBYJt0//UV7+bKXC2uE5SUysQnJ5db cCc9EAnhjHsNjBMPBAoT4dKUL9lr8Cp31vsJomkMNq1vTgv4RhkDdPpExW+HyKdfHi1R2z NOsLou031zlevNC2FK1K2XRMHJjEfkfnPErr+t9HCYpeGcqD4cwXg7uoPmM28K0LJB5F9e m6bdQh7KzKFLj9J5rDojGWNXJTi845cfaXxttRnvZBILcjJx89gqJJRIA4EdRtAuCrDv76 EGaqdMxa3Db4vMVGhmKmrhBBhteM2T5NbhdRu86lzJB6CvXTMPY8zgbUY1EpSA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724943984; a=rsa-sha256; cv=none; b=X6sU55+4N5PVnqPPU87Ssl5pJWfxhNp5RPviswOABQ/ZARF1Igdu3JxIkXvx+qkXSF9FpH njXq/5owJk9Nikta/Njwj/hTccORlQXbjAPveb8XAH8tQi9CeYm74M/pCOLuvdz+BBwysN UP6qUdVzQSocVna8hd4cMpGc5dIN0x/+LfgYwIQdAQ0+2MPVmZX7c2xea2zXPoARYgPix2 FU2iBkXmTWPwP/SVXq+qYlaxCynXAca6lCEnbPJ0XYjyuj7iwF5B0iSRQKu9LlEbGihxvR WUtXFPmZfccaCEVd5sEfwN8hkpdolKsMDRuDQwcUrS117zKHldsME3Q9f1wDSw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724943984; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/b0oZ7rOspwOwoU7ywgFTzueHh7zYJIxVyefSDFz5hk=; b=BhHrILkaobRsgqX/F4959nv4SBkqPL5E9tSCRIPpiz7pRHEMRb3ez1dQ7PAl3gmsN7Enns 8YCiWCoyJNLMwluAx/ouKwPxdXcNi1u18ZZcRa+ZAudJuUBWLTw4kPjlYbbQBMe66x5m+c V5bPuXbbeQXuEsmxqm/ss9y3Z8b8mFBBDPBAIzGp3RuZdHH0ETlPQsZx4jIDeJcCAr9zSJ GDCg8OY2RPy30ZQs4hfEh+DEgrumZ74HPDWbGUnDmoiRXvI5gxC8gkLUSItUKrHWflIl+X dSCh5TZM9W0WtzZn+1XBQcLhki68hOlZOpXuUveijVZZWTWTeoaMQYCTxsRqiw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Wvl3h45r0zM9g; Thu, 29 Aug 2024 15:06:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47TF6ONQ079043; Thu, 29 Aug 2024 15:06:24 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47TF6ODx079040; Thu, 29 Aug 2024 15:06:24 GMT (envelope-from git) Date: Thu, 29 Aug 2024 15:06:24 GMT Message-Id: <202408291506.47TF6ODx079040@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Dag-Erling =?utf-8?Q?Sm=C3=B8rgrav?= Subject: git: f62c1f3f8e91 - main - locate.updatedb: Explicitly exit from trap code. List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: des X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: f62c1f3f8e91c78d402e1db4e518e4899a4ba2b9 Auto-Submitted: auto-generated The branch main has been updated by des: URL: https://cgit.FreeBSD.org/src/commit/?id=f62c1f3f8e91c78d402e1db4e518e4899a4ba2b9 commit f62c1f3f8e91c78d402e1db4e518e4899a4ba2b9 Author: Dag-Erling Smørgrav AuthorDate: 2024-08-29 15:05:47 +0000 Commit: Dag-Erling Smørgrav CommitDate: 2024-08-29 15:05:47 +0000 locate.updatedb: Explicitly exit from trap code. When a signal is trapped, the script continues after the trap code has run, unless the trap code explicitly exits. In the particular case of locate.updatedb, this is mostly harmless, except that the trap code is executed twice (once for the signal and once when we reach the end of the script), but it's still worth fixing. Furthermore, install the trap as soon as we've created the temporary directory, to minimize the window during which we can fail to clean up after ourselves if interrupted. While here, simplify the empty check at the end and make some minor style tweaks. MFC after: 1 week Sponsored by: Klara, Inc. Reviewed by: kevans Differential Revision: https://reviews.freebsd.org/D46475 --- usr.bin/locate/locate/updatedb.sh | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/usr.bin/locate/locate/updatedb.sh b/usr.bin/locate/locate/updatedb.sh index ff7ec7f6c18e..ca1a79116a91 100644 --- a/usr.bin/locate/locate/updatedb.sh +++ b/usr.bin/locate/locate/updatedb.sh @@ -42,13 +42,14 @@ fi # The directory containing locate subprograms : ${LIBEXECDIR:=/usr/libexec}; export LIBEXECDIR : ${TMPDIR:=/tmp}; export TMPDIR -if ! TMPDIR=`mktemp -d $TMPDIR/locateXXXXXXXXXX`; then +if ! TMPDIR=$(mktemp -d $TMPDIR/locateXXXXXXXXXX); then exit 1 fi +tmp=$TMPDIR/_updatedb$$ +trap 'rc=$?; rm -f $tmp; rmdir $TMPDIR; trap - 0; exit $rc' 0 1 2 3 5 10 15 PATH=$LIBEXECDIR:/bin:/usr/bin:$PATH; export PATH - : ${mklocatedb:=locate.mklocatedb} # make locate database program : ${FCODES:=/var/db/locate.database} # the database : ${SEARCHPATHS="/"} # directories to be put in the database @@ -87,17 +88,13 @@ if [ -n "$PRUNEDIRS" ]; then done fi -tmp=$TMPDIR/_updatedb$$ -trap 'rm -f $tmp; rmdir $TMPDIR' 0 1 2 3 5 10 15 - # search locally if $find -s $SEARCHPATHS $excludes -or -print 2>/dev/null | $mklocatedb -presort > $tmp then - if [ -n "$($find $tmp -size -257c -print)" ]; then + if ! grep -aq / $tmp; then echo "updatedb: locate database $tmp is empty" >&2 exit 1 - else - cat $tmp > $FCODES # should be cp? fi + install $tmp $FCODES fi From nobody Thu Aug 29 15:21:51 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WvlPW5n3Zz5PcGs; Thu, 29 Aug 2024 15:21:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WvlPW51dyz4qXN; Thu, 29 Aug 2024 15:21:51 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724944911; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=f88pjODd1rzyfoK9x+pNaTeoP6Ki6ALh5XargyMK18U=; b=qQMcxqWn6kMwbbQ8lz5j6saxQub1hfi5YRDo9obPPN5z31NOfF9YLq+c0Ub1dAbrnMP+6F ikKlX6gtcl0ZoF9AHbbX0t4SzX2XlaWLeb2bVchakYLlCwiqgBcHO9I5npCY4WydLzHDi+ 8QlQFzyBBAgF7z8ijSy7exyG48QdKMERcT8lRCVxdk9kH0Hlj0inJZJNMVY+whoSz6T3zN mawZw2HZPHICA5ic27+tWc/IBnw9K5hl8pmJhbdAdFThr+WZY0oJVvSVlvLQkGsth+zuCY Eay+3GUo/JbP8ErCOgJEULFdB3BmWpDZB0QSub9dcC77nL6ZwE5eUHVGmVLGRg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724944911; a=rsa-sha256; cv=none; b=S1XrJC8t21ksgYVbQBPIcxMkNP2t1scvh7fMxon18ltzr08y5EDxY4vGRNpXMt94k5rkm2 HqnuWjw7a/CGErluXvJhiuyOxo68AAdFdMGgeeddIa1C1bLAkMNHBiob//3ciYuSxArRMF 3M29jMwj6oBJpljDai1LnXrDAGafOXMLrloKmhnYNF4fQsdistcrRZAxdP9Kn8LoylBAN2 xDShHhiqREcd0JoWYYQ0Yp8L0UzIeo5WzbKhRgrcWJhHyxWws+5bU6bqZVipNuoxMqdL5/ V8klKpzpvluq+7eez0l/C8o+suQ78muV9llzbu2+DYyUlCwRK9Ixi/mgbL0DJg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724944911; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=f88pjODd1rzyfoK9x+pNaTeoP6Ki6ALh5XargyMK18U=; b=fizu2N2NXxh70TalRZz7WIV1VdLpe54+U1GXvg37/ZWnA7Ekt0JD2uup1NTL0IuRRHy5Gm KXgwyjNO3WrqaGqCQlMdpcrXaOQ4/vS7ObwNZHmnS92H9SiQfLXPUMkvcUU4tNtcuWKDEe ubnDLxi2ZC3lGKiGWJmlJwwTxibkpS6v/pKvQAoLy/6Th1Xzu+C6TudViZJg3VGvr0s0hG Ct5936d34ZQoTxEqJ199xz9IR0tn8AIp2nJltqTiUr2akHfUEorPZyYQpEF+amyR30OLR2 1pxeye0n8gjqZFjGgIVxakGPQiuDln9ez8YLQZlyxvWQc+Us390rH+88eiOkqQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WvlPW4cfjzN9G; Thu, 29 Aug 2024 15:21:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47TFLpXu008906; Thu, 29 Aug 2024 15:21:51 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47TFLpul008903; Thu, 29 Aug 2024 15:21:51 GMT (envelope-from git) Date: Thu, 29 Aug 2024 15:21:51 GMT Message-Id: <202408291521.47TFLpul008903@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mitchell Horne Subject: git: 05cf677bb8d8 - main - riscv: remove a redundant MPASS test in _pmap_unwire_ptp() List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mhorne X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 05cf677bb8d8b2528fd5bf472c908eabe4e76125 Auto-Submitted: auto-generated The branch main has been updated by mhorne: URL: https://cgit.FreeBSD.org/src/commit/?id=05cf677bb8d8b2528fd5bf472c908eabe4e76125 commit 05cf677bb8d8b2528fd5bf472c908eabe4e76125 Author: Wuyang Chung AuthorDate: 2024-08-02 06:28:46 +0000 Commit: Mitchell Horne CommitDate: 2024-08-29 15:20:28 +0000 riscv: remove a redundant MPASS test in _pmap_unwire_ptp() It is guaranteed by the else if condition. Reviewed by: mhorne Pull Request: https://github.com/freebsd/freebsd-src/pull/1355 --- sys/riscv/riscv/pmap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sys/riscv/riscv/pmap.c b/sys/riscv/riscv/pmap.c index 7058eb03cf44..c372e6f7362b 100644 --- a/sys/riscv/riscv/pmap.c +++ b/sys/riscv/riscv/pmap.c @@ -1464,7 +1464,6 @@ _pmap_unwire_ptp(pmap_t pmap, vm_offset_t va, vm_page_t m, struct spglist *free) pd_entry_t *l0; vm_page_t pdpg; - MPASS(pmap_mode != PMAP_MODE_SV39); l0 = pmap_l0(pmap, va); pdpg = PTE_TO_VM_PAGE(pmap_load(l0)); pmap_unwire_ptp(pmap, va, pdpg, free); From nobody Thu Aug 29 15:21:52 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WvlPY1Qptz5PcGw; Thu, 29 Aug 2024 15:21:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WvlPX65Mzz4q76; Thu, 29 Aug 2024 15:21:52 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724944912; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=1B0VgsHNi007aVdoAhRbBoGFrXvF0MW9IFn1P5ybniU=; b=cg37kyVTq3qHjO7NMBffxNkcDS1OvILeXTCd4JAAcdRFacKxUZ9RE/p72yO+JJioDSGfWI TZemvrbp38Zm/cKyAYuXiqIciIGYewgBJ7zMPgxh2Ob2Uo24zlN8mrt6cgzVQonPxD3GCI 8gHaj3Mn6Wlu/1r74pUvRgJ0Jd1RVWSPY7MFzQQqQfV4kdhOuFjIAcBsK8ot+zaRDULUah lMbRDm+j7WwLavD2CL1raS+SZ8hW5lO4Z/uUw4fNtH88SoeumYxQmo8tNeEhr6d8jXJ7fg pIrOGk5lKrGu9dSzzj97pjJMOppKr//soJELB59cuopQ/lZehh87AHJaXdxoTA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724944912; a=rsa-sha256; cv=none; b=GheNDvu2ZWcPSNTLJP8c5quitSbFM/Asbs2HeYLHiO+sP9Njjyc5zrs6Ejnhm+MzndYDdb kw7MXlOph/1euHHIU42cNDv8YAc/Mg655QDFS6UQ8tDb2ipFuSK95a/6Lw+K6iqYeI1HJc fvBW6ZLxN8BHHnN7l/27pXJusNcnhE6F6Y7WfRwo8b/6jN/qEFtVsWZtZtlY3MRy/Lcyug posfEYv9Pdfn3xDi+DydpIY+Qutv8lxBhiRSfDi8nkyJGlwL1ZQ3TcwaXlV3d5jDhGL5Op oSc3vfoRAcZvYrMu90gsVpSuqMF0gkeyv8uS0jG1Ujfods4e3eqEwLmvc+iSTQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724944912; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=1B0VgsHNi007aVdoAhRbBoGFrXvF0MW9IFn1P5ybniU=; b=dzuZgPyOsFpJdHqLCC0VuKT8ZNGg2ZP8HxZtKFiHBQLstXgbkjxy9GKkPlisW+s2wF81S/ b7lPtwqTMErkk0QkB/78hitWTAAtfJXl18MjQis/3k/w1rtH64BnjLoXuS+VtafjFMOyMB zdlJfo+mfQWZG9bf3kQvzQe/BtHFWBiOhBXAj9MRsyTd9zc+Hfepp74n2aa15U9mGjNpvD nhadZ/ef/9+7CzVws63Ujcgk3YOX0a0cDKS0FIR4EM1B2XfDlxSHdj4/MI+izdbD2iyYZR LdzopAiYvE8Dbscw9X6552Y7mEmR/VAXd9G7iurmDvuClIB83TVfGC7hdxK5kg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WvlPX5jFXzMt4; Thu, 29 Aug 2024 15:21:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47TFLqx8008966; Thu, 29 Aug 2024 15:21:52 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47TFLqr6008963; Thu, 29 Aug 2024 15:21:52 GMT (envelope-from git) Date: Thu, 29 Aug 2024 15:21:52 GMT Message-Id: <202408291521.47TFLqr6008963@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mitchell Horne Subject: git: 2e33abc35460 - main - riscv: fix a bug in calculating the pindex for L1 page List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mhorne X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 2e33abc35460b9e2c2eeb1e43a0614db7bebbdb3 Auto-Submitted: auto-generated The branch main has been updated by mhorne: URL: https://cgit.FreeBSD.org/src/commit/?id=2e33abc35460b9e2c2eeb1e43a0614db7bebbdb3 commit 2e33abc35460b9e2c2eeb1e43a0614db7bebbdb3 Author: Wuyang Chung AuthorDate: 2024-08-04 14:04:12 +0000 Commit: Mitchell Horne CommitDate: 2024-08-29 15:20:28 +0000 riscv: fix a bug in calculating the pindex for L1 page pmap_l1_pindex(va) expands to: ((va >> L1_SHIFT) + NUL2E) Reviewed by: mhorne MFC after: 1 week Fixes: a4667e09e652 ("Convert vm_page_alloc() callers to...") Pull Request: https://github.com/freebsd/freebsd-src/pull/1360 --- sys/riscv/riscv/pmap.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sys/riscv/riscv/pmap.c b/sys/riscv/riscv/pmap.c index c372e6f7362b..4baa4948e442 100644 --- a/sys/riscv/riscv/pmap.c +++ b/sys/riscv/riscv/pmap.c @@ -1887,8 +1887,8 @@ pmap_growkernel(vm_offset_t addr) nkpg = vm_page_alloc_noobj(VM_ALLOC_INTERRUPT | VM_ALLOC_NOFREE | VM_ALLOC_WIRED | VM_ALLOC_ZERO); if (nkpg == NULL) - panic("pmap_growkernel: no memory to grow kernel"); - nkpg->pindex = kernel_vm_end >> L1_SHIFT; + panic("%s: no memory to grow kernel", __func__); + nkpg->pindex = pmap_l1_pindex(kernel_vm_end); paddr = VM_PAGE_TO_PHYS(nkpg); pn = (paddr / PAGE_SIZE); @@ -1913,8 +1913,8 @@ pmap_growkernel(vm_offset_t addr) nkpg = vm_page_alloc_noobj(VM_ALLOC_INTERRUPT | VM_ALLOC_NOFREE | VM_ALLOC_WIRED | VM_ALLOC_ZERO); if (nkpg == NULL) - panic("pmap_growkernel: no memory to grow kernel"); - nkpg->pindex = kernel_vm_end >> L2_SHIFT; + panic("%s: no memory to grow kernel", __func__); + nkpg->pindex = pmap_l2_pindex(kernel_vm_end); paddr = VM_PAGE_TO_PHYS(nkpg); pn = (paddr / PAGE_SIZE); From nobody Thu Aug 29 15:21:53 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WvlPZ2Qmwz5PcK1; Thu, 29 Aug 2024 15:21:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WvlPZ06Xfz4qdW; Thu, 29 Aug 2024 15:21:54 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724944914; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=OEcxx4hKnUbzMfV7mjYu+qS8KKS9/JTOiJi0jxwM9x8=; b=XH1bj9nH8nq77qMoTcGFli9sd9L4I7waGdYqD/SPmS4arnEIXip2+RwonBDwW3a6kWR329 WZSuieYqRhfkO7D1j5Ozk/2VARuI95mpNKiF58s9Zcho4d3d+cBRT9P9iD+tco09ttc8iu 7zcKkXmJjsh9MEavHiiq4iWGXrwid44wnKJ6dizOFHCkb1GMdMZZZGmsqULBkXrDxybB5M jAlO5ZHfCViZHtO9s0ZJuKMQx5WCh/J8k7jwKDM5ZUPdxnylaCKgsHzNbdZyMBtBREJwSj I2Is+nOZdDKYHmeRSWz3Bv1kLeEiw6keJwUIKdiExkFWWYgyH1ij9fk3hr3m9A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724944914; a=rsa-sha256; cv=none; b=iFO0O08ma+svpPnejNoFRY1DiMtqYvC+P/38r1UE1jSGqvG0pEOb2B+secSXgZ47WLQELe TeHFocQcQs2TOlFf2pMmD5rn9ID8uGZGa93uUUuOFxx1x8EO/k5+qkCf3gw2ClaB/7Smuy +QF9Yi6bsB0EQZKiZ0UCgCsJlcSFtEYCQzjLOIylIkswIuf0fBQFIDUdqjYJXlPu2eFtLY KQghg51vIKDJMfMJ2XOwJ2nR0y3Gxihp/V7zoY7nkWEy3QVatvubQla+sGqmvNTaqPKcdM fRN002OJvcpdmtAZMucfsnBvBslCe0+aJdXp87NcMh8Mq0zcT1INkQL3JDOD/A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724944914; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=OEcxx4hKnUbzMfV7mjYu+qS8KKS9/JTOiJi0jxwM9x8=; b=MicGRcuSuOo5bR/5nA8MPPNLhid0cIZ/1GB1AWnyT18AYbNX0CZ56HSBiELrQ96Mdfzghc WJrDj4bVLrkuUd7PCxkqgsmtCZgJprhqwNT3j9c6YrckSW+fr5ozZMcmgD2aLFpobYRpf9 9McWuyAx7LMz66mSC40J48JEvmdhY4vLA+98Gd7U1toWxHdn5JQs5ULHvRTIpWTZ5NCANH 2HhcMwi+c87yuK0sdtmeOEFE8UoDRjLYfK06lN3Xn/3JQWZWLvloaOgJC9iJOZ0Uq3mCsP zdlQ44kEiRceeFmaNYtcWuF4p0fIqKakReQGRVl4qo+x/oE/LETUsR6MKbbf1Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WvlPY6n3gzN9J; Thu, 29 Aug 2024 15:21:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47TFLr5P009033; Thu, 29 Aug 2024 15:21:53 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47TFLrBV009030; Thu, 29 Aug 2024 15:21:53 GMT (envelope-from git) Date: Thu, 29 Aug 2024 15:21:53 GMT Message-Id: <202408291521.47TFLrBV009030@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mitchell Horne Subject: git: 835cd17f87e1 - main - riscv: use pmap_l1_pindex to calculate the pindex of the l2 page table page List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mhorne X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 835cd17f87e1b38c05e4a9a392181bebb9b8dc6d Auto-Submitted: auto-generated The branch main has been updated by mhorne: URL: https://cgit.FreeBSD.org/src/commit/?id=835cd17f87e1b38c05e4a9a392181bebb9b8dc6d commit 835cd17f87e1b38c05e4a9a392181bebb9b8dc6d Author: Wuyang Chung AuthorDate: 2024-08-05 05:22:56 +0000 Commit: Mitchell Horne CommitDate: 2024-08-29 15:20:29 +0000 riscv: use pmap_l1_pindex to calculate the pindex of the l2 page table page Reviewed by: mhorne MFC after: 1 week Pull Request: https://github.com/freebsd/freebsd-src/pull/1360 --- sys/riscv/riscv/pmap.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sys/riscv/riscv/pmap.c b/sys/riscv/riscv/pmap.c index 4baa4948e442..69eb36c2cd4c 100644 --- a/sys/riscv/riscv/pmap.c +++ b/sys/riscv/riscv/pmap.c @@ -1743,7 +1743,7 @@ pmap_alloc_l2(pmap_t pmap, vm_offset_t va, struct rwlock **lockp) { pd_entry_t *l1; vm_page_t l2pg; - vm_pindex_t l2pindex; + vm_pindex_t pindex; retry: l1 = pmap_l1(pmap, va); @@ -1756,8 +1756,8 @@ retry: l2pg->ref_count++; } else { /* Allocate a L2 page. */ - l2pindex = pmap_l2_pindex(va) >> Ln_ENTRIES_SHIFT; - l2pg = _pmap_alloc_l3(pmap, NUL2E + l2pindex, lockp); + pindex = pmap_l1_pindex(va); + l2pg = _pmap_alloc_l3(pmap, pindex, lockp); if (l2pg == NULL && lockp != NULL) goto retry; } From nobody Thu Aug 29 16:02:09 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WvmJL1Ykbz5T84K for ; Thu, 29 Aug 2024 16:02:26 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WvmJK0Tr1z51ZN for ; Thu, 29 Aug 2024 16:02:25 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=freebsd.org (policy=none); spf=pass (mx1.freebsd.org: domain of jrtc27@jrtc27.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=jrtc27@jrtc27.com Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-42bb81e795bso5646845e9.1 for ; Thu, 29 Aug 2024 09:02:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724947343; x=1725552143; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fzBIPBzUtwVCCLTFfP14lfaNf86Vp1wysB1CZ58lgxA=; b=Lba+qY80mrj4ZxdJK/WmA/XZmxlJVeCuE2AWnhrbBwXPg0kWXf6bhT+3ZRLD5eFk/4 kUTLSXjFhG4LwTilnWw5dXWlKdCKdrMi2sCAZUDfuIY49DDrL4eWTnKG4XSlruH32RGX cgnMYK+IcHSJp4xlkYQU08R5pl5mPCYDF7oc4RioWsKcwKETP57OOHIhxRwAcSiiWlwx EJ+I9e6YOgaisXvt55KFdlrthDiRa9Zqm4BZHAoXw0o+d6c29X7VOjs1ev1/1spbjFVi cT8BiOTOsTMNzSbWz4+AuwTPHC4YIzzXJyX2okjPiddF+sCZ0laICuib3jFKn5sHNsGS hbkw== X-Forwarded-Encrypted: i=1; AJvYcCX5Qzlk8SrOPtfqXdLGK+mfTPq58+AhCf/AxV9Rk+73YQ/l0v1GnDo6rAYdCgk+vCjkR/T5EKwEOum+BQ9zuqUG/BZ7Pw==@freebsd.org X-Gm-Message-State: AOJu0YyF93GhFsfPrDlN9jo3Gl5kMgwQgdYIHE9I4qvtN/fdleElMrZb jwn0zID/nqHTfasUYwKugmiJHRaFECzfZIlOptTzMune+eGaI1ltTDBuLEVl1KY= X-Google-Smtp-Source: AGHT+IEA0Mkf+93ft1gZ5i+nkCa0A8VnJ2tKI19AUt9BeWsIhaSPy6onK9Nqi++wtk2dVt18cyXa5g== X-Received: by 2002:a05:600c:4693:b0:429:d43e:dbb9 with SMTP id 5b1f17b1804b1-42bb01e58b8mr28805275e9.23.1724947340955; Thu, 29 Aug 2024 09:02:20 -0700 (PDT) Received: from smtpclient.apple ([131.111.5.201]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3749ee49fccsm1773412f8f.4.2024.08.29.09.02.20 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Aug 2024 09:02:20 -0700 (PDT) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51\)) Subject: Re: git: 43e8849bc294 - main - conf: Enable BTI checking in the arm64 kernel From: Jessica Clarke In-Reply-To: <77cbcd47-1778-4e71-b824-4e75e0e4b2d6@FreeBSD.org> Date: Thu, 29 Aug 2024 17:02:09 +0100 Cc: Andrew Turner , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <19DBDC11-EB0F-48C0-9AAE-9EED087F0AB6@freebsd.org> References: <202408200902.47K92BsJ078096@gitrepo.freebsd.org> <77cbcd47-1778-4e71-b824-4e75e0e4b2d6@FreeBSD.org> To: John Baldwin X-Mailer: Apple Mail (2.3776.700.51) X-Spamd-Bar: -- X-Spamd-Result: default: False [-2.90 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FORGED_SENDER(0.30)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; MIME_GOOD(-0.10)[text/plain]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), No valid DKIM,none]; RCVD_TLS_LAST(0.00)[]; FREEFALL_USER(0.00)[jrtc27]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.128.46:from]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_NEQ_ENVFROM(0.00)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; RCVD_IN_DNSWL_NONE(0.00)[209.85.128.46:from]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-main@freebsd.org]; R_DKIM_NA(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org]; APPLE_MAILER_COMMON(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_FIVE(0.00)[5] X-Rspamd-Queue-Id: 4WvmJK0Tr1z51ZN On 21 Aug 2024, at 15:28, John Baldwin wrote: >=20 > On 8/20/24 05:02, Andrew Turner wrote: >> The branch main has been updated by andrew: >> URL: = https://cgit.FreeBSD.org/src/commit/?id=3D43e8849bc29414036ccaef7788de95a0= 7ad32ab5 >> commit 43e8849bc29414036ccaef7788de95a07ad32ab5 >> Author: Andrew Turner >> AuthorDate: 2024-08-19 12:59:49 +0000 >> Commit: Andrew Turner >> CommitDate: 2024-08-20 08:49:15 +0000 >> conf: Enable BTI checking in the arm64 kernel >> To ensure new code has BTI support make it an error to not = have the >> BTI ELF note when linking the kernel and kernel modules. >> Reviewed by: kib, emaste >> Sponsored by: Arm Ltd >> Differential Revision: https://reviews.freebsd.org/D45469 >=20 > This has broken two of the GitHub CI actions using clang 12 and clang = 13. > Please fix this to be conditional on a supported linker version (or = perhaps > add a new linker feature to bsd.linker.mk). This is still broken. If it=E2=80=99s not fixed promptly I will just = revert this change; we can=E2=80=99t leave CI broken, especially when it gets = used to test GitHub PRs. Please stop breaking building with older toolchains, this isn=E2=80=99t the first time it=E2=80=99s happened. Jess From nobody Thu Aug 29 16:48:26 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WvnKQ2q7Yz5TCVd; Thu, 29 Aug 2024 16:48:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WvnKQ2LCrz55lT; Thu, 29 Aug 2024 16:48:26 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724950106; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=RRnZfCazhs3Rw/iCof2qD1rtYONWsoWb0PA5+2k5ssA=; b=us1ifkdKtVWjag0jCZpmKwCuYt1fwaUKtairbC8EsjCN46ob0a70jmHJ1Zj/wDCPqfMX4i jxc833QNDdYn/Mb2g2CN1qCaGnecHmqS0xE9in6N9BX08qCw642e6Q5/szsHx+Nldo9aEi MatjXcYc0JiEGK3tvIYfzTeQBthrmS0qs1egbKUPWiMM0Yeg8OWGNKHz7aMi4jUFmqaqFc mcy25LuJnsYmQELn/1QDW9Qi9G/bOD8wWszDq6v9Q7XhegUXkEZ4ICj+fKje26eMSyc/py QJwusgFYCsPGb6xubc3/dyHva2/i1M5eoYDF/a+Tb+Kt6Sz33OfkxHMrl8Uy0w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724950106; a=rsa-sha256; cv=none; b=Prx2spSoIvaJlYxPXWo+AtkGIhdotvW6Txv9aa+RyeZBojbxsW+dioRgF6k50wcc5aoLW5 SzenORD9rvBrXovRllak9QL/rZ5UETMqgqWEypqdxkVr2Cq/6xdPOMG7vw1W5GgFARB0FY XPQ+8fFGR2mv8ABEgQ+oX3cGRJywFeajy1gQ+VEdgkmL6tgV8mJQ9qh1G3oqU/BfqZK5CA 3duz2FFO3a84bg2ne12lrBdF4HM7Y4kn0IjYhJMG2BYV9KvWVVcEKO55tkrf0Rw/S6KAqP KD6iBXwlpA7wpnGWkk3nTolfmDAozBciCOTFJXv20jOAMkK0aafZuDxp5Bxd5A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724950106; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=RRnZfCazhs3Rw/iCof2qD1rtYONWsoWb0PA5+2k5ssA=; b=L4jv5Cy3oeQY8XvomBJZF/AFkj2L5MfTHQwE/S0TKvML39Mzp+MbnGqEm48hVd7sn+E1mn aZw/HuYUA6LqTa+rkTiQ073noqLOA+vqS/5Aks4llWK2yld6pkXNIOaePGVR4EDw/xTzAx jCueqzaRZ7sfTdlj75zwEqzYDWLdNud94+JIXPpEWV2aAeowtq4jVC+zbuxZmi/xcI6qSM dlUfJWrn2Tyx/Bf6weeNW3iPCEhrIRQ/EQxZ5bm3K/Q/neX7hoNEgLCRB84NhJPP6DgJpo Z33BJ4TMrPIH7kkm46G6ctX9FcZ3jw1siQ/+uDc3a+BFLptWmHWDbu3Z7ZDq2g== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WvnKQ1wZ6zPvT; Thu, 29 Aug 2024 16:48:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47TGmQQl048149; Thu, 29 Aug 2024 16:48:26 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47TGmQpd048146; Thu, 29 Aug 2024 16:48:26 GMT (envelope-from git) Date: Thu, 29 Aug 2024 16:48:26 GMT Message-Id: <202408291648.47TGmQpd048146@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: 460464b2e031 - main - netbsd-tests: Remove an xfail annotation List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 460464b2e031881d03ffb24ec4ca5b7cbeadb5b7 Auto-Submitted: auto-generated The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=460464b2e031881d03ffb24ec4ca5b7cbeadb5b7 commit 460464b2e031881d03ffb24ec4ca5b7cbeadb5b7 Author: Mark Johnston AuthorDate: 2024-08-29 16:45:09 +0000 Commit: Mark Johnston CommitDate: 2024-08-29 16:48:18 +0000 netbsd-tests: Remove an xfail annotation The test passes after commit 5ab6ed93cd36 ("faccessat(2): Honor AT_SYMLINK_NOFOLLOW"). Reported by: Jenkins --- contrib/netbsd-tests/lib/libc/c063/t_faccessat.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/contrib/netbsd-tests/lib/libc/c063/t_faccessat.c b/contrib/netbsd-tests/lib/libc/c063/t_faccessat.c index 7de4f61637a4..5e6829f7ea45 100644 --- a/contrib/netbsd-tests/lib/libc/c063/t_faccessat.c +++ b/contrib/netbsd-tests/lib/libc/c063/t_faccessat.c @@ -166,9 +166,6 @@ ATF_TC_BODY(faccessat_fdlink, tc) ATF_REQUIRE(faccessat(dfd, BASELINK, F_OK, 0) == -1); ATF_REQUIRE(errno == ENOENT); -#ifdef __FreeBSD__ - atf_tc_expect_fail("Depends on non-standard behavior not mentioned in POSIX.1-2008"); -#endif ATF_REQUIRE(faccessat(dfd, BASELINK, F_OK, AT_SYMLINK_NOFOLLOW) == 0); ATF_REQUIRE(close(dfd) == 0); From nobody Thu Aug 29 17:45:28 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WvpbD1z1Pz5THqV; Thu, 29 Aug 2024 17:45:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WvpbD1Wr3z3wlY; Thu, 29 Aug 2024 17:45:28 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724953528; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=5HJTup70t+8kYkt9vKSoq3PegChYHTOTdU2opgf+dok=; b=o/Va8MV0qv3PGrBnqjgfJrcyiI6ZekFJ4mYUlVckNHx0RrC3LMARDMmRH9OgNXakDhHQq2 gRNjdSDeJ39YAepza/pqfAGvnj97dNszurkJ8zXcuvQ9LVDf6CDXvvwmEUeU3N8s5Bj+o5 l0KcOaK6B8TbboK039c4bZuOSOHhNpTt7QG/FcDASn5qa3QAke0LUSF7721la6RzzQfWR2 9B3l+nT5+LfJcvHjQH7VLwLCLEOL6fs8Bda0uGe+TXwDoIJXjW+PpbqzrFMLE36jIMgWCe 2oPn1+WGfbn0OsXv7wzxJnuglia6WjWQAuYaAw9qI9Y6YWzRvK+c9a27jMeJWg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724953528; a=rsa-sha256; cv=none; b=Vu1TzThUpWbikHEld58YVmbNqlneabPPs0Gyx4ILzLrUOR2CaW8vzqxm/4kkoj4fBWCS1O dufxvxbxrMELrmI8B9DfcULVOCyRjX/eCXSs+L7KLQSiCgMVhv9oGp8KpYgWPVQJ8ptyMl CKacGVJehPzV2RvLHCVjYMFdkOYXcPrsLjtA/ZsdnAvLgTdHvK6GvGf4+CLxn3jnpVVaTJ F9+DIVoJdX9yfOVQf607PHzOznaSQ/h8B0avhSEVatObgATw4GdBR5z3j6Ls29lXi1w9SP 6jnsTaB1bFtnb0P/3p1I7UsMvX0R4nxN0RSG5sS4GZL2rbgyx88LvqPyrUsyDA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724953528; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=5HJTup70t+8kYkt9vKSoq3PegChYHTOTdU2opgf+dok=; b=P6m4JolVIgaVrDmrJZFQeaHNA/7DJ7oEZbGMzf8DUIporKV95r8mDvGTxnmB6yrlaYyQVN 4Q27zZkcZE0Bl5gNqJSrGRWj4CeRSGY7zW1NHeA4JSKiE4Ep97X8WcYzrwQUqVYfc2vCjU /QNLUWhZoijYlIdmQY1bDB7b+D7V5oBXpA3/TuFA9ciCuj+cMFR2z7FCkphNCNQdHiqm/T TgCn8ESt3yqsIlJKs0PEYCYxCTpASmRKV8F41W1n3EvqpYssZiRLpmSBSCZsJu1YWMbGEb gwINbPJaqtgSG5LzbIC7rDYR+YlbcW0OfukyKkyu9d0+hXETI1jWrSxEuc30mA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WvpbD11q2zRr8; Thu, 29 Aug 2024 17:45:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47THjSSS049072; Thu, 29 Aug 2024 17:45:28 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47THjSOe049069; Thu, 29 Aug 2024 17:45:28 GMT (envelope-from git) Date: Thu, 29 Aug 2024 17:45:28 GMT Message-Id: <202408291745.47THjSOe049069@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: a58ece87303f - main - zfsd tests: Update the mock zpool_handle List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: a58ece87303f882367105c92a27268ed6befa655 Auto-Submitted: auto-generated The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=a58ece87303f882367105c92a27268ed6befa655 commit a58ece87303f882367105c92a27268ed6befa655 Author: Mark Johnston AuthorDate: 2024-08-29 17:37:57 +0000 Commit: Mark Johnston CommitDate: 2024-08-29 17:40:44 +0000 zfsd tests: Update the mock zpool_handle The zfsd tests rely on this having the same layout as the real zpool_handle, which changed in the last OpenZFS import. Fixes: 62e7d3c89ebd ("ddt: add support for prefetching tables into the ARC") Reported by: Jenkins --- cddl/usr.sbin/zfsd/tests/zfsd_unittest.cc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/cddl/usr.sbin/zfsd/tests/zfsd_unittest.cc b/cddl/usr.sbin/zfsd/tests/zfsd_unittest.cc index f1e925b0b4ef..6c9a49a8ebbf 100644 --- a/cddl/usr.sbin/zfsd/tests/zfsd_unittest.cc +++ b/cddl/usr.sbin/zfsd/tests/zfsd_unittest.cc @@ -82,6 +82,9 @@ struct zpool_handle zpool_handle_t *zpool_next; char zpool_name[ZFS_MAX_DATASET_NAME_LEN]; int zpool_state; + unsigned int zpool_n_propnames; +#define ZHP_MAX_PROPNAMES 4 + const char *zpool_propnames[ZHP_MAX_PROPNAMES]; size_t zpool_config_size; nvlist_t *zpool_config; nvlist_t *zpool_old_config; From nobody Thu Aug 29 17:53:14 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WvpmR6WdFz5TJmf; Thu, 29 Aug 2024 17:53:27 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-vk1-f169.google.com (mail-vk1-f169.google.com [209.85.221.169]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WvpmR4XSTz3xWh; Thu, 29 Aug 2024 17:53:27 +0000 (UTC) (envelope-from asomers@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-vk1-f169.google.com with SMTP id 71dfb90a1353d-4fcefbd6bc4so351060e0c.1; Thu, 29 Aug 2024 10:53:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724954006; x=1725558806; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NRZMoFFgXD0BQcaOJOaLGsmBsPlwU2Q6n5oThrE2W48=; b=fM6pJRIynKpXqIWqTt9VNMEK1mXjISGVnNgA+2qbar1luM/4OpG6tJyGlubAKq7OrP 6t7aqBGdwwNwRiqmvR9pbe0ud17uO4SFvnQB1rfC+Y+n+1/x+EGx6/uAffo2SEHk5fux tSbqvp+LFlpQcz8N1SxoEa3GERqP00XICIf4rsfNzhdNM3lanl89+pSPkIlpntkpR8YZ 5jzFrRen1pV0VytWJOqN4tznec0Gwgarv1CkAK3rgMsgdHvGs5CZjX0m9pkvcj+JBZ8C 6sE77NcrAOQWE8OzbKkUIUL6SPBLiR8pXXFmgCJhl2lg7QMRB50S28DA+e5betZsFnbK MvwQ== X-Forwarded-Encrypted: i=1; AJvYcCX8OFRFOyFgWYZwEyXo9W6YPEcB4simLudmG6DUnsSD9hZ13LCiiO3lrMXQJDyzM8MW3lTvkJbpKE3jS4u4lYoW08toO7w=@freebsd.org, AJvYcCXXF2bNNV/nA2bB4JO2SZoOkAUaqs38GK6VltnXQdYAriUF1EBkU6BqMK7zwtAQZxi14HynM8Xuw4c+1/2+d9zhN7vh@freebsd.org X-Gm-Message-State: AOJu0Ywo1xHunC5dNPbhoF7oy2iLeHiW+Dqbth45EtQo2wqGq7MPmnd6 m1t0dLNwdWoYjY0st83ynOBnjDcrwxexvzlY5ck73HsYKZgDayYOcgl/a/n0ATttzrsXjxJDGdJ jZJOo99NRPazKHbPoLS44gdG6m6XoCNZ2 X-Google-Smtp-Source: AGHT+IE0SMtZCZa3hGFxRfy5zlN1Og8xmYve0h1XYIw+p8y2ypLM+nFMH6waaMfEl4i9omuB6dEIVajc6jcTVEDAvgE= X-Received: by 2002:a05:6122:250e:b0:4f5:2276:136d with SMTP id 71dfb90a1353d-4ffe4a5c710mr3699985e0c.1.1724954006169; Thu, 29 Aug 2024 10:53:26 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 References: <202408291745.47THjSOe049069@gitrepo.freebsd.org> In-Reply-To: <202408291745.47THjSOe049069@gitrepo.freebsd.org> From: Alan Somers Date: Thu, 29 Aug 2024 11:53:14 -0600 Message-ID: Subject: Re: git: a58ece87303f - main - zfsd tests: Update the mock zpool_handle To: Mark Johnston Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Queue-Id: 4WvpmR4XSTz3xWh On Thu, Aug 29, 2024 at 11:45=E2=80=AFAM Mark Johnston = wrote: > > The branch main has been updated by markj: > > URL: https://cgit.FreeBSD.org/src/commit/?id=3Da58ece87303f882367105c92a2= 7268ed6befa655 > > commit a58ece87303f882367105c92a27268ed6befa655 > Author: Mark Johnston > AuthorDate: 2024-08-29 17:37:57 +0000 > Commit: Mark Johnston > CommitDate: 2024-08-29 17:40:44 +0000 > > zfsd tests: Update the mock zpool_handle > > The zfsd tests rely on this having the same layout as the real > zpool_handle, which changed in the last OpenZFS import. > > Fixes: 62e7d3c89ebd ("ddt: add support for prefetching tables into t= he ARC") > Reported by: Jenkins Oh, I already had https://reviews.freebsd.org/D46479 open for this, but you beat me to it ;) From nobody Thu Aug 29 19:46:24 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WvsGm5Yr3z52W36; Thu, 29 Aug 2024 19:46:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WvsGm3mDbz4BHR; Thu, 29 Aug 2024 19:46:24 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724960784; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WRfjbLgdt0QKPPSST6T9r4j5hDziCwQWCMTTt7J+JFI=; b=d1vD83MdmQAxwrIBx32NQNabh1Z9U03o/VUfgMECUFDm7SB/GlHGaAjXk/C+pNPLyT3GRX 0XgvQzc6lTTTYhdC0ZOANHUT2RRzjTGgonD3YqWPIHFtcqTUDSNjKhFZz46WPr5wY6Ak7W JAuBnORmyYYBnc2K+lpQBW4djLnnK0xbLZYMpI3lL6hTBCSX1QbLZXUbKPCcp/sx8vTQ36 oyJdWdU3pMuR1oesjUBpMGYSSuV1I8PoDDeK1KwopjFjQtB/ls+0RjzCH1+2fouWBOJ7tG Sv0YC8JlMqyH6Clftg3Bk6bif02EsK2mmJgwtH/RZG70Gq6wSev2u6HvyCQLaw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724960784; a=rsa-sha256; cv=none; b=MCFedGu77g5v3fTz7TJ/P8wAtHTqWPSaa9txuwefePQbHn6BmZ0pzHBGpnjoDWFCOjNopO PAz2SXLL+YhD+8zKJlvA2Pwkepb7ahp84VKBHXDp7+Hx36jxE3gL0grl5lDLzmSFVCe2SO DZ3iMolksupx3o1Gn7XEXvuEmnW3PAhrQAhzw4eu4xsK24BXkr2Wc62fm1OVv1aisoF9q1 v7wmj6oyJBODq04tHkW6qBpK8xGFe+YwfykgQgI9H7s71tLxx1C4t4/sWqugnUgZaKk781 jpnwYkO1tmA/U9UXeIPIiddlHxkMg2ZpsKGMZm5PFDu8sAxTUbLLMaLJQRAdIw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724960784; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WRfjbLgdt0QKPPSST6T9r4j5hDziCwQWCMTTt7J+JFI=; b=Lob0UthOtYZNF1JuvFKbCGA693W6Kz1Bkg7tpVb30sOQqooFD9u+RQok4mBh2kCDsTfuKs x6teHmWx3O58Vg9+mzBUrPjp2vblZzaPQlMOA2ICn63quIdfwcG+WpZzvvbdbksxzkuFDZ 5zsTE0WPJ5BuAQjb2o45RbnU18yxv2ap/cAaR2/dbe1qEulHwpRHqbgrvER5NF3TZC+dzx 2W8QpD5VmGdqGNbHGZfSgA5c8mpof1Vwz5xgWFWk/89nk7+DP2aVzSHg+vbMRcljF28ONe wOiuLiwt8xnUJzM+jRYOtL8b7OwOkKE8XiPSSnXBcEHjibtAjyuwDYG4GHD7VQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WvsGm3DvLzX0D; Thu, 29 Aug 2024 19:46:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47TJkOea053590; Thu, 29 Aug 2024 19:46:24 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47TJkO0d053587; Thu, 29 Aug 2024 19:46:24 GMT (envelope-from git) Date: Thu, 29 Aug 2024 19:46:24 GMT Message-Id: <202408291946.47TJkO0d053587@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Dimitry Andric Subject: git: 41e016289f77 - main - Improve accuracy of asinf(3) and acosf(3) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 41e016289f77deb88b0ef1ec3f7b2ab3515ac7c8 Auto-Submitted: auto-generated The branch main has been updated by dim: URL: https://cgit.FreeBSD.org/src/commit/?id=41e016289f77deb88b0ef1ec3f7b2ab3515ac7c8 commit 41e016289f77deb88b0ef1ec3f7b2ab3515ac7c8 Author: Steve Kargl AuthorDate: 2024-08-29 19:44:48 +0000 Commit: Dimitry Andric CommitDate: 2024-08-29 19:44:48 +0000 Improve accuracy of asinf(3) and acosf(3) This uses a better rational approximation to improve the accuracy of both functions. For exhaustive testing of asinf(3) in the interval, the current libm gives: % ./tlibm asin -fPED -x 0x1p-12f -X 1 Interval tested for asinf: [0.000244141,1] ulp <= 0.5: 97.916% 98564994 | 97.916% 98564994 0.5 < ulp < 0.6: 2.038% 2051023 | 99.953% 100616017 0.6 < ulp < 0.7: 0.047% 47254 | 100.000% 100663271 0.7 < ulp < 0.8: 0.000% 25 | 100.000% 100663296 Max ulp: 0.729891 at 5.00732839e-01 which isn't too bad given that much of the computation is actually done in double floating point. With the new rational approximation, exhaustive testing yields: % ./tlibm asin -fPED -x 0x1p-12f -X 1 Interval tested for asinf: [0.000244141,1] ulp <= 0.5: 99.711% 100372643 | 99.711% 100372643 0.5 < ulp < 0.6: 0.288% 290357 | 100.000% 100663000 0.6 < ulp < 0.7: 0.000% 296 | 100.000% 100663296 Max ulp: 0.636344 at 5.09706438e-01 Similarly, for exhaustive testing of asinf(3) in the interval, the current libm gives: % ./tlibm acos -fPED -x -1 -X -0x1p-12f Interval tested for acosf: [-1,-0.000244141] ulp <= 0.5: 97.008% 97651921 | 97.008% 97651921 0.5 < ulp < 0.6: 2.441% 2457242 | 99.450% 100109163 0.6 < ulp < 0.7: 0.472% 475503 | 99.922% 100584666 0.7 < ulp < 0.8: 0.071% 71309 | 99.993% 100655975 0.8 < ulp < 0.9: 0.007% 7319 | 100.000% 100663294 0.9 < ulp < 1.0: 0.000% 2 | 100.000% 100663296 Max ulp: 0.914007 at -5.01484931e-01 % ./tlibm acos -fPED -x 0x1p-12f -X 1 Interval tested for acosf: [0.000244141,1] ulp <= 0.5: 97.317% 97962530 | 97.317% 97962530 0.5 < ulp < 0.6: 2.340% 2355182 | 99.657% 100317712 0.6 < ulp < 0.7: 0.314% 316134 | 99.971% 100633846 0.7 < ulp < 0.8: 0.029% 29450 | 100.000% 100663296 Max ulp: 0.796035 at 4.99814630e-01 With the new rational approximation, exhaustive testing yields: % ./tlibm acos -fPED -x -1 -X -0x1p-12f Interval tested for acosf: [-1,-0.000244141] ulp <= 0.5: 97.010% 97653245 | 97.010% 97653245 0.5 < ulp < 0.6: 2.442% 2458373 | 99.452% 100111618 0.6 < ulp < 0.7: 0.473% 476012 | 99.925% 100587630 0.7 < ulp < 0.8: 0.068% 68603 | 99.993% 100656233 0.8 < ulp < 0.9: 0.007% 7063 | 100.000% 100663296 Max ulp: 0.896189 at -5.04511118e-01 % ./tlibm acos -fPED -x 0x1p-12f -X 1 Interval tested for acosf: [0.000244141,1] ulp <= 0.5: 97.650% 98298175 | 97.650% 98298175 0.5 < ulp < 0.6: 2.028% 2041709 | 99.679% 100339884 0.6 < ulp < 0.7: 0.292% 293555 | 99.970% 100633439 0.7 < ulp < 0.8: 0.030% 29857 | 100.000% 100663296 Max ulp: 0.775875 at 4.91849005e-01 PR: 281001 MFC after: 1 week --- lib/msun/src/e_acosf.c | 20 +++++++++++++------- lib/msun/src/e_asinf.c | 22 ++++++++++++++-------- 2 files changed, 27 insertions(+), 15 deletions(-) diff --git a/lib/msun/src/e_acosf.c b/lib/msun/src/e_acosf.c index 42ba126d1baa..ede552e7055a 100644 --- a/lib/msun/src/e_acosf.c +++ b/lib/msun/src/e_acosf.c @@ -22,11 +22,17 @@ pi = 3.1415925026e+00, /* 0x40490fda */ pio2_hi = 1.5707962513e+00; /* 0x3fc90fda */ static volatile float pio2_lo = 7.5497894159e-08; /* 0x33a22168 */ + +/* + * The coefficients for the rational approximation were generated over + * 0x1p-12f <= x <= 0.5f. The maximum error satisfies log2(e) < -30.084. + */ static const float -pS0 = 1.6666586697e-01, -pS1 = -4.2743422091e-02, -pS2 = -8.6563630030e-03, -qS1 = -7.0662963390e-01; +pS0 = 1.66666672e-01f, /* 0x3e2aaaab */ +pS1 = -1.19510300e-01f, /* 0xbdf4c1d1 */ +pS2 = 5.47002675e-03f, /* 0x3bb33de9 */ +qS1 = -1.16706085e+00f, /* 0xbf956240 */ +qS2 = 2.90115148e-01f; /* 0x3e9489f9 */ float acosf(float x) @@ -46,13 +52,13 @@ acosf(float x) if(ix<=0x32800000) return pio2_hi+pio2_lo;/*if|x|<2**-26*/ z = x*x; p = z*(pS0+z*(pS1+z*pS2)); - q = one+z*qS1; + q = one+z*(qS1+z*qS2); r = p/q; return pio2_hi - (x - (pio2_lo-x*r)); } else if (hx<0) { /* x < -0.5 */ z = (one+x)*(float)0.5; p = z*(pS0+z*(pS1+z*pS2)); - q = one+z*qS1; + q = one+z*(qS1+z*qS2); s = sqrtf(z); r = p/q; w = r*s-pio2_lo; @@ -66,7 +72,7 @@ acosf(float x) SET_FLOAT_WORD(df,idf&0xfffff000); c = (z-df*df)/(s+df); p = z*(pS0+z*(pS1+z*pS2)); - q = one+z*qS1; + q = one+z*(qS1+z*qS2); r = p/q; w = r*s+c; return (float)2.0*(df+w); diff --git a/lib/msun/src/e_asinf.c b/lib/msun/src/e_asinf.c index a2ee1a166f03..8d1aca27df83 100644 --- a/lib/msun/src/e_asinf.c +++ b/lib/msun/src/e_asinf.c @@ -18,12 +18,18 @@ static const float one = 1.0000000000e+00, /* 0x3F800000 */ -huge = 1.000e+30, - /* coefficient for R(x^2) */ -pS0 = 1.6666586697e-01, -pS1 = -4.2743422091e-02, -pS2 = -8.6563630030e-03, -qS1 = -7.0662963390e-01; +huge = 1.000e+30; + +/* + * The coefficients for the rational approximation were generated over + * 0x1p-12f <= x <= 0.5f. The maximum error satisfies log2(e) < -30.084. + */ +static const float +pS0 = 1.66666672e-01f, /* 0x3e2aaaab */ +pS1 = -1.19510300e-01f, /* 0xbdf4c1d1 */ +pS2 = 5.47002675e-03f, /* 0x3bb33de9 */ +qS1 = -1.16706085e+00f, /* 0xbf956240 */ +qS2 = 2.90115148e-01f; /* 0x3e9489f9 */ static const double pio2 = 1.570796326794896558e+00; @@ -46,7 +52,7 @@ asinf(float x) } t = x*x; p = t*(pS0+t*(pS1+t*pS2)); - q = one+t*qS1; + q = one+t*(qS1+t*qS2); w = p/q; return x+x*w; } @@ -54,7 +60,7 @@ asinf(float x) w = one-fabsf(x); t = w*(float)0.5; p = t*(pS0+t*(pS1+t*pS2)); - q = one+t*qS1; + q = one+t*(qS1+t*qS2); s = sqrt(t); w = p/q; t = pio2-2.0*(s+s*w); From nobody Thu Aug 29 19:58:07 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WvsXP1QCtz52WFs; Thu, 29 Aug 2024 19:58:13 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-vs1-xe2e.google.com (mail-vs1-xe2e.google.com [IPv6:2607:f8b0:4864:20::e2e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WvsXN4QF0z4F3P; Thu, 29 Aug 2024 19:58:12 +0000 (UTC) (envelope-from markjdb@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-vs1-xe2e.google.com with SMTP id ada2fe7eead31-498d053f116so221837137.3; Thu, 29 Aug 2024 12:58:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724961490; x=1725566290; darn=freebsd.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:sender :from:to:cc:subject:date:message-id:reply-to; bh=XnxT51WBflOuVFdft36vRZkqjXC1vm6ONkCQR+8Pg4Y=; b=JrtkaTV8WK9Z3DYJpqtxhrqf1/KrK5zhV+CIUc4cqjD8qVt42c+CH4XNyqBvg3tMuq X3eeRBOpuyMd55aDSpVnI4uftyQH1opn7xKh4cI7yuPfYaYSjUv//3g7EAN88ONz0kka 1Oee4PctBHqNWrqZ3m74nSv9bH3NqqlYAbOZXLSDvMPliUscSm9gCHnYe6vyMOCy6AbM EmFaIIgR5Gw/VL3bFg+ZkGU0km3Rro4Gcl7kgp0U2SKA+LyTxO56R0w0nN9Kj3rnOIvx zUS9zGUHau7CdZ+EDLkyJDXQGlF7V59ca2/sMB/0iuL6oJPCj3j8iDQZdanagv8zZVvk 4oxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724961490; x=1725566290; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XnxT51WBflOuVFdft36vRZkqjXC1vm6ONkCQR+8Pg4Y=; b=dy2XKohv4O3oSjAx7sNrA3qvzS/mLF5MQ16suJ0UhoYHgi7Bf2bPcuSG3Rd0cYHyoe +jdtFrfvBvTvj808IHHkLjqTxb3kxK0WilKyTARy7Z5lXR5X9GP49tg7ANFNHmJW2FRM 5Uli3RUSIMrnuS38UFZduQWemlk3DkBa7u+tUOQiOyc0wTKg7tkVaQghMQLJDzAskV1b FgV5adG5IjUMVI1AAe8Eqr4/TCCCzgp/rCFoVCiAwz/lLWAVBuENoQhRglKrANXAzPtH elSlTwhlf9PdWdh93xLAB4FXTLRWE/+zt+Ux3Ue0+o6suHB2IfkUdLYr2x7xQVkKuRKJ XaRw== X-Forwarded-Encrypted: i=1; AJvYcCUc4rXSVeyvt4mN3pA/6zKJXSfpm6mgeYD4fESEa15kjgWliF5os45c1ieitItVMmtHv+Kr3B8yn4533Tzl/09Gdm7b@freebsd.org, AJvYcCUm6d8Nc7nNFjXWkWttmhOTIi0I9Y972My2+s/EJ8c8BYf3DlYEujwbtoXF8hs01MY0QUd6b0w5l41SyxZd52WE34a4dBY=@freebsd.org X-Gm-Message-State: AOJu0Yxbpr7GwBSXMUm+z/Uavix5nN9slfLE5r51XxTSZJsh+8smHhzP JX1YDNdLSzNL9I6DEjDUx6xDrN0S22gN1mPFBYu+jtu1Yxlt8HJmBqd+YA== X-Google-Smtp-Source: AGHT+IEnjj0Ux1afFKZLNfhFJeBeOVT7zKs2R6axzDPWIVJBhWMq6g3a7EgsPztug66E07ti+F8OXg== X-Received: by 2002:a05:6102:41ac:b0:48f:42c8:e0a9 with SMTP id ada2fe7eead31-49a5b1cc3b2mr4688034137.26.1724961490425; Thu, 29 Aug 2024 12:58:10 -0700 (PDT) Received: from nuc (192-0-220-237.cpe.teksavvy.com. [192.0.220.237]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7a806c24165sm81183385a.43.2024.08.29.12.58.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Aug 2024 12:58:09 -0700 (PDT) Date: Thu, 29 Aug 2024 15:58:07 -0400 From: Mark Johnston To: Alan Somers Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: a58ece87303f - main - zfsd tests: Update the mock zpool_handle Message-ID: References: <202408291745.47THjSOe049069@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4WvsXN4QF0z4F3P On Thu, Aug 29, 2024 at 11:53:14AM -0600, Alan Somers wrote: > On Thu, Aug 29, 2024 at 11:45 AM Mark Johnston wrote: > > > > The branch main has been updated by markj: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=a58ece87303f882367105c92a27268ed6befa655 > > > > commit a58ece87303f882367105c92a27268ed6befa655 > > Author: Mark Johnston > > AuthorDate: 2024-08-29 17:37:57 +0000 > > Commit: Mark Johnston > > CommitDate: 2024-08-29 17:40:44 +0000 > > > > zfsd tests: Update the mock zpool_handle > > > > The zfsd tests rely on this having the same layout as the real > > zpool_handle, which changed in the last OpenZFS import. > > > > Fixes: 62e7d3c89ebd ("ddt: add support for prefetching tables into the ARC") > > Reported by: Jenkins > > Oh, I already had https://reviews.freebsd.org/D46479 open for this, > but you beat me to it ;) Ah, sorry. I was going through some test failures and just pushed patches for a couple of "obvious" ones. From nobody Thu Aug 29 20:04:10 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WvsgP0Tg5z52XdR; Thu, 29 Aug 2024 20:04:17 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qv1-xf2e.google.com (mail-qv1-xf2e.google.com [IPv6:2607:f8b0:4864:20::f2e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WvsgN0mtBz4GHB; Thu, 29 Aug 2024 20:04:16 +0000 (UTC) (envelope-from markjdb@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20230601 header.b=WZHsMJGF; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=freebsd.org (policy=none); spf=pass (mx1.freebsd.org: domain of markjdb@gmail.com designates 2607:f8b0:4864:20::f2e as permitted sender) smtp.mailfrom=markjdb@gmail.com Received: by mail-qv1-xf2e.google.com with SMTP id 6a1803df08f44-6bf9ddfc2dcso5396336d6.1; Thu, 29 Aug 2024 13:04:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724961854; x=1725566654; darn=freebsd.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=O22jxAxMputcOsSSojMXvHXFGA+GsVvAJKFIxAfBnp8=; b=WZHsMJGFCAYF1aYxPZw4CmdlWeEDrFQobRhlCnA6+ErpXnTaj5aXZw6TTSL/5/UGfL w7Qn++U3lSNHYW2S88WlUlG9aCZIlglq2fS226F0uqTtbf31BrkfC6xp+aTjQc560l3j fslk6KKWSiNoNPY89eWIGlQBpIdDVK7vhvXfkgHWaHQjmKtbCs0eGwMOM7iGh8oTGT1T IIrJkKyUpBjX6r4giJIJPeniILsmSprGtKXJ1FmFENQLjRV7hQzoFY5GnBJKAc7K/yFT A3KGnusuGkKHF3ogjEfDGFpPk1uji8tyjTPueXpksX33WPMCXaAXLYWy64PfGjVxgXH2 DZBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724961854; x=1725566654; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=O22jxAxMputcOsSSojMXvHXFGA+GsVvAJKFIxAfBnp8=; b=pM9Tf1i/i2KCltwtMjOG030C7RDIoCXkxyviRxeUwUhUmfIScI2M4PtgeTajhkhv8S Yuv61RbnE+MV3E5Nr0vCuZzQrtef5x33pjJgpxSkUk3E4VY/LWqqsVXI5MuLNv20idz5 sZ+ygC7UTVuOWajvildZ+7nwfrJe1KWN5tRjoj9Kt2BULPp2lKBoodAvy8NxzYBd1QRe geq/xIevGaN5k14pS6MzCKHwrQj5b8l4lv1IDwSlKF6UcLzf+M7cQH6QCVsJasZN+Bjg U6Et9xZhCgMAnFwSmLc+RlNTNL7IGJEZgRmza+Eoh2KetBppUtkeP7AjJwr5s3LR74M8 KhuA== X-Forwarded-Encrypted: i=1; AJvYcCU5Bpa17iGDI2NCoEKoH1gms376exdj4UB2lLqfaezMqZ258u1s6teUSe6tLKXfQcapRI9A9M/G+Z4neHyC7tq7BUfb@freebsd.org, AJvYcCWsGtiR6MR6KN9k5ui3maOCeSgDnWeFTEP6nbnZTzFO7au38uNbtztOn4OGLXgih1fEdZNCCJC6sR0OCrg0mXRes+vKKyg=@freebsd.org X-Gm-Message-State: AOJu0YzyetvrhGTQeTvhrTcovwgbAf4BnWJP0R3hQpwXeMDlwkKDbtdc tbJq3idu3PrI3M/4PR3tTNPXDd7gzleVoDFSwzv9mNpn3dbzcg+FNYDIOQ== X-Google-Smtp-Source: AGHT+IG30aVeDAlKY9G66SK4lL+APhoEJz8Y1O/4fHD3pqPIUaPwWV2WCxOWkurddxyvNPsFMe/wLg== X-Received: by 2002:a05:6214:428e:b0:6bf:4fc4:cdd2 with SMTP id 6a1803df08f44-6c33e62a56fmr45830226d6.30.1724961853878; Thu, 29 Aug 2024 13:04:13 -0700 (PDT) Received: from nuc (192-0-220-237.cpe.teksavvy.com. [192.0.220.237]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6c340c1e65esm8350996d6.46.2024.08.29.13.04.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Aug 2024 13:04:13 -0700 (PDT) Date: Thu, 29 Aug 2024 16:04:10 -0400 From: Mark Johnston To: Konstantin Belousov Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: ff1ae3b3639d - main - rangelocks: restore caching of the single rl entry in the struct thread Message-ID: References: <202408060406.47646dvJ004709@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202408060406.47646dvJ004709@gitrepo.freebsd.org> X-Spamd-Bar: -- X-Spamd-Result: default: False [-2.59 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.99)[-0.989]; MID_RHS_NOT_FQDN(0.50)[]; FORGED_SENDER(0.30)[markj@freebsd.org,markjdb@gmail.com]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20230601]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), DKIM not aligned (relaxed),none]; MIME_GOOD(-0.10)[text/plain]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; TO_DN_SOME(0.00)[]; RCVD_TLS_LAST(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; DKIM_TRACE(0.00)[gmail.com:+]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org,dev-commits-src-main@freebsd.org]; RCVD_COUNT_TWO(0.00)[2]; FROM_NEQ_ENVFROM(0.00)[markj@freebsd.org,markjdb@gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MISSING_XM_UA(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::f2e:from]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim] X-Rspamd-Queue-Id: 4WvsgN0mtBz4GHB On Tue, Aug 06, 2024 at 04:06:39AM +0000, Konstantin Belousov wrote: > The branch main has been updated by kib: > > URL: https://cgit.FreeBSD.org/src/commit/?id=ff1ae3b3639d39a6485cfc655bf565cd04b9caa6 > > commit ff1ae3b3639d39a6485cfc655bf565cd04b9caa6 > Author: Konstantin Belousov > AuthorDate: 2023-08-23 23:29:50 +0000 > Commit: Konstantin Belousov > CommitDate: 2024-08-06 04:05:58 +0000 > > rangelocks: restore caching of the single rl entry in the struct thread > > Reviewed by: markj, Olivier Certner > Tested by: pho > Sponsored by: The FreeBSD Foundation > Differential revision: https://reviews.freebsd.org/D41787 > --- > sys/kern/kern_rangelock.c | 33 +++++++++++++++++++++++++++------ > sys/kern/kern_thread.c | 1 + > sys/sys/rangelock.h | 1 + > 3 files changed, 29 insertions(+), 6 deletions(-) > > diff --git a/sys/kern/kern_rangelock.c b/sys/kern/kern_rangelock.c > index 355b2125dd9b..2f16569b19aa 100644 > --- a/sys/kern/kern_rangelock.c > +++ b/sys/kern/kern_rangelock.c > @@ -82,8 +82,15 @@ static struct rl_q_entry * > rlqentry_alloc(vm_ooffset_t start, vm_ooffset_t end, int flags) > { > struct rl_q_entry *e; > - > - e = uma_zalloc_smr(rl_entry_zone, M_WAITOK); > + struct thread *td; > + > + td = curthread; > + if (td->td_rlqe != NULL) { > + e = td->td_rlqe; > + td->td_rlqe = NULL; > + } else { > + e = uma_zalloc_smr(rl_entry_zone, M_WAITOK); > + } > e->rl_q_next = NULL; > e->rl_q_free = NULL; > e->rl_q_start = start; > @@ -95,6 +102,12 @@ rlqentry_alloc(vm_ooffset_t start, vm_ooffset_t end, int flags) > return (e); > } > > +void > +rangelock_entry_free(struct rl_q_entry *e) > +{ > + uma_zfree_smr(rl_entry_zone, e); > +} > + > void > rangelock_init(struct rangelock *lock) > { > @@ -106,6 +119,7 @@ void > rangelock_destroy(struct rangelock *lock) > { > struct rl_q_entry *e, *ep; > + struct thread *td; > > MPASS(!lock->sleepers); > for (e = (struct rl_q_entry *)atomic_load_ptr(&lock->head); > @@ -386,8 +400,10 @@ rangelock_lock_int(struct rangelock *lock, bool trylock, vm_ooffset_t start, > vm_ooffset_t end, int locktype) > { > struct rl_q_entry *e, *free, *x, *xp; > + struct thread *td; > enum RL_INSERT_RES res; > > + td = curthread; > for (res = RL_LOCK_RETRY; res == RL_LOCK_RETRY;) { > free = NULL; > e = rlqentry_alloc(start, end, locktype); > @@ -401,10 +417,15 @@ rangelock_lock_int(struct rangelock *lock, bool trylock, vm_ooffset_t start, > e = NULL; > } > for (x = free; x != NULL; x = xp) { > - MPASS(!rl_e_is_marked(x)); > - xp = x->rl_q_free; > - MPASS(!rl_e_is_marked(xp)); > - uma_zfree_smr(rl_entry_zone, x); > + MPASS(!rl_e_is_marked(x)); > + xp = x->rl_q_free; > + MPASS(!rl_e_is_marked(xp)); > + if (td->td_rlqe == NULL) { > + smr_synchronize(rl_smr); I think I had the impression that this was a rare case, but empirically it is not. As far as I can see, this smr_synchronize() call happens every time an entry is freed, which could be very frequent. smr_synchronize() bumps the global sequence counter and blocks until all CPUs have had a chance to observe the new value, so is quite expensive. I didn't try benchmarking yet, but pwrite3 from will-it-scale should be a good candidate. Why do we maintain this per-thread cache at all? IMO it would make more sense to unconditionally free the entry here. Or perhaps I'm missing something here. > + td->td_rlqe = x; > + } else { > + uma_zfree_smr(rl_entry_zone, x); > + } > } > } > return (e); > diff --git a/sys/kern/kern_thread.c b/sys/kern/kern_thread.c > index c951e7297c89..9c3694feb945 100644 > --- a/sys/kern/kern_thread.c > +++ b/sys/kern/kern_thread.c > @@ -480,6 +480,7 @@ thread_fini(void *mem, int size) > EVENTHANDLER_DIRECT_INVOKE(thread_fini, td); > turnstile_free(td->td_turnstile); > sleepq_free(td->td_sleepqueue); > + rangelock_entry_free(td->td_rlqe); > umtx_thread_fini(td); > MPASS(td->td_sel == NULL); > } > diff --git a/sys/sys/rangelock.h b/sys/sys/rangelock.h > index 310371bef879..60f394b67677 100644 > --- a/sys/sys/rangelock.h > +++ b/sys/sys/rangelock.h > @@ -65,6 +65,7 @@ void *rangelock_wlock(struct rangelock *lock, vm_ooffset_t start, > vm_ooffset_t end); > void *rangelock_trywlock(struct rangelock *lock, vm_ooffset_t start, > vm_ooffset_t end); > +void rangelock_entry_free(struct rl_q_entry *e); > #if defined(INVARIANTS) || defined(INVARIANT_SUPPORT) > void _rangelock_cookie_assert(void *cookie, int what, const char *file, > int line); From nobody Thu Aug 29 20:22:51 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Wvt572c5lz52Z5M; Thu, 29 Aug 2024 20:23:07 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Wvt560mnyz4Km9; Thu, 29 Aug 2024 20:23:06 +0000 (UTC) (envelope-from kostikbel@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: from tom.home (kib@localhost [127.0.0.1] (may be forged)) by kib.kiev.ua (8.18.1/8.18.1) with ESMTP id 47TKMp86094278; Thu, 29 Aug 2024 23:22:54 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 47TKMp86094278 Received: (from kostik@localhost) by tom.home (8.18.1/8.18.1/Submit) id 47TKMpID094277; Thu, 29 Aug 2024 23:22:51 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 29 Aug 2024 23:22:51 +0300 From: Konstantin Belousov To: Mark Johnston Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: ff1ae3b3639d - main - rangelocks: restore caching of the single rl entry in the struct thread Message-ID: References: <202408060406.47646dvJ004709@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on tom.home X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US] X-Rspamd-Queue-Id: 4Wvt560mnyz4Km9 On Thu, Aug 29, 2024 at 04:04:10PM -0400, Mark Johnston wrote: > On Tue, Aug 06, 2024 at 04:06:39AM +0000, Konstantin Belousov wrote: > > The branch main has been updated by kib: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=ff1ae3b3639d39a6485cfc655bf565cd04b9caa6 > > > > commit ff1ae3b3639d39a6485cfc655bf565cd04b9caa6 > > Author: Konstantin Belousov > > AuthorDate: 2023-08-23 23:29:50 +0000 > > Commit: Konstantin Belousov > > CommitDate: 2024-08-06 04:05:58 +0000 > > > > rangelocks: restore caching of the single rl entry in the struct thread > > > > Reviewed by: markj, Olivier Certner > > Tested by: pho > > Sponsored by: The FreeBSD Foundation > > Differential revision: https://reviews.freebsd.org/D41787 > > --- > > sys/kern/kern_rangelock.c | 33 +++++++++++++++++++++++++++------ > > sys/kern/kern_thread.c | 1 + > > sys/sys/rangelock.h | 1 + > > 3 files changed, 29 insertions(+), 6 deletions(-) > > > > diff --git a/sys/kern/kern_rangelock.c b/sys/kern/kern_rangelock.c > > index 355b2125dd9b..2f16569b19aa 100644 > > --- a/sys/kern/kern_rangelock.c > > +++ b/sys/kern/kern_rangelock.c > > @@ -82,8 +82,15 @@ static struct rl_q_entry * > > rlqentry_alloc(vm_ooffset_t start, vm_ooffset_t end, int flags) > > { > > struct rl_q_entry *e; > > - > > - e = uma_zalloc_smr(rl_entry_zone, M_WAITOK); > > + struct thread *td; > > + > > + td = curthread; > > + if (td->td_rlqe != NULL) { > > + e = td->td_rlqe; > > + td->td_rlqe = NULL; > > + } else { > > + e = uma_zalloc_smr(rl_entry_zone, M_WAITOK); > > + } > > e->rl_q_next = NULL; > > e->rl_q_free = NULL; > > e->rl_q_start = start; > > @@ -95,6 +102,12 @@ rlqentry_alloc(vm_ooffset_t start, vm_ooffset_t end, int flags) > > return (e); > > } > > > > +void > > +rangelock_entry_free(struct rl_q_entry *e) > > +{ > > + uma_zfree_smr(rl_entry_zone, e); > > +} > > + > > void > > rangelock_init(struct rangelock *lock) > > { > > @@ -106,6 +119,7 @@ void > > rangelock_destroy(struct rangelock *lock) > > { > > struct rl_q_entry *e, *ep; > > + struct thread *td; > > > > MPASS(!lock->sleepers); > > for (e = (struct rl_q_entry *)atomic_load_ptr(&lock->head); > > @@ -386,8 +400,10 @@ rangelock_lock_int(struct rangelock *lock, bool trylock, vm_ooffset_t start, > > vm_ooffset_t end, int locktype) > > { > > struct rl_q_entry *e, *free, *x, *xp; > > + struct thread *td; > > enum RL_INSERT_RES res; > > > > + td = curthread; > > for (res = RL_LOCK_RETRY; res == RL_LOCK_RETRY;) { > > free = NULL; > > e = rlqentry_alloc(start, end, locktype); > > @@ -401,10 +417,15 @@ rangelock_lock_int(struct rangelock *lock, bool trylock, vm_ooffset_t start, > > e = NULL; > > } > > for (x = free; x != NULL; x = xp) { > > - MPASS(!rl_e_is_marked(x)); > > - xp = x->rl_q_free; > > - MPASS(!rl_e_is_marked(xp)); > > - uma_zfree_smr(rl_entry_zone, x); > > + MPASS(!rl_e_is_marked(x)); > > + xp = x->rl_q_free; > > + MPASS(!rl_e_is_marked(xp)); > > + if (td->td_rlqe == NULL) { > > + smr_synchronize(rl_smr); > > I think I had the impression that this was a rare case, but empirically > it is not. As far as I can see, this smr_synchronize() call happens > every time an entry is freed, which could be very frequent. > smr_synchronize() bumps the global sequence counter and blocks until all > CPUs have had a chance to observe the new value, so is quite expensive. > > I didn't try benchmarking yet, but pwrite3 from will-it-scale should be > a good candidate. > > Why do we maintain this per-thread cache at all? IMO it would make more > sense to unconditionally free the entry here. Or perhaps I'm missing > something here. Normally threads perform i/o syscalls, and for these syscalls, they need to perform just one rangelock op. In absence of the races with conflicting locks, the rangelock acquisition does not need another rl_q_entry item. In previous rangelock implementation, this was a significant improvement esp. on microbenchmarks where rangelock overhead could be reached, like repeated write or read of same single byte. Remembering that, I decided to keep the caching. From nobody Thu Aug 29 21:32:58 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Wvvdk2PQxz5MSrD; Thu, 29 Aug 2024 21:32:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Wvvdk1sjSz4VFf; Thu, 29 Aug 2024 21:32:58 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724967178; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=MTNUxmtowQVoJdoXk/Gx3+XUUTHkC+S25LWAjo8XaaE=; b=chnFq0yqBnq3TTLQfyronVxbLXzDeHWdAz5IB4FxESm4uDwIr1uhf9QYC3HksIp3FMK2fp ra+x4BMld9X6leTaphbLxK5CyBdTssJVtcnhuS+R3Wa53zbQw2KijdrCjipDi/WgU22k/A xYo29bwj3MSCMBJcIfGanhThvTFJV54iz6RkvIqBhBO+0Uw8KX5v4SrQZlywy8O48R+hpc EMMf96CWTa8l3woDMo3YkPqLJBmOj0EpUxslFD4gh3LoTIjUiJHTWbjgskRCU++TQMGGhF FgnLWX9mJ4meHt32tuGpHe1La6oxAyfvHTzAGXZ0xoXjY0fuDpGwQczqUeKT4g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724967178; a=rsa-sha256; cv=none; b=bU28Y6Thb/V6jBc1bJ0tEYiuud1GAIt1hanylGsP7Vbu3xGE9uBc1DkoK/GsJt26mycSLX d4MHQg6xqZJQKd+7wZjDKkHtH2pVghIfEXVDtJy+ZKp0D4t28ncHMbYD+5BzS99c9lyCb+ YdxwRX18HTL6lNivpNZ9EW6LuVsMw7tw3HUw1maQvyehz1zBE0LTnO4OSrKPPenCWIqa09 KtlLydiCtrmYInw6/V4VSGCeKWVq2TXSmh5MRJ58cgoARGHqpXpSzcWmT89yoB3IIJWalF Oe5sZQdXfybUlbtpqGatCjBL45pPN+m8NIGIqyPQWUuNeeEspQQLwrwfNgu2aQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724967178; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=MTNUxmtowQVoJdoXk/Gx3+XUUTHkC+S25LWAjo8XaaE=; b=PpXXuRprPBkjqqKEPM2g0cGIMMGN3kXrgvTcA1ewtL64IqtRXDaa7slxOOrcTIViOhy6yv sH58r/g9NGwAvNOXVQdErHTewzjHfY5ezxpnEBfpoyqc47hROgr3/bj20YzUH2UbYPO7ZN jy+CCJy1wAALcBqUFHHm8+UuouBrNK49uikaClzuboJmE74xnFSLdpFafYv39b1+pNTZN9 9qC0/CELLR+1zmWEPH7GdaZeuXkjdZzziwo65xcrXiURLbb1puyvovHJTodOODRf+ZSAMV fh2dlk9HJbjKvNJh1pbFvXOBjlTl5kRNOxUvT5u8ODAqZ56j5qxbzTwa9HJntg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Wvvdk1ShfzZbT; Thu, 29 Aug 2024 21:32:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47TLWwl6038914; Thu, 29 Aug 2024 21:32:58 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47TLWwjB038911; Thu, 29 Aug 2024 21:32:58 GMT (envelope-from git) Date: Thu, 29 Aug 2024 21:32:58 GMT Message-Id: <202408292132.47TLWwjB038911@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: 7e49f04c8839 - main - rangelocks: stop caching per-thread rl_q_entry List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 7e49f04c88390c4c07f90c733c0d35ad6ff00f1c Auto-Submitted: auto-generated The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=7e49f04c88390c4c07f90c733c0d35ad6ff00f1c commit 7e49f04c88390c4c07f90c733c0d35ad6ff00f1c Author: Konstantin Belousov AuthorDate: 2024-08-29 20:45:21 +0000 Commit: Konstantin Belousov CommitDate: 2024-08-29 21:32:48 +0000 rangelocks: stop caching per-thread rl_q_entry This should reduce the frequency of smr_synchronize() calls, that otherwise occur on almost each rangelock unlock. Reviewed by: markj Sponsored by: The FreeBSD Foundation Differential revision: https://reviews.freebsd.org/D46482 --- sys/kern/kern_rangelock.c | 26 +++----------------------- sys/kern/kern_thread.c | 2 -- sys/sys/proc.h | 2 +- sys/sys/rangelock.h | 1 - 4 files changed, 4 insertions(+), 27 deletions(-) diff --git a/sys/kern/kern_rangelock.c b/sys/kern/kern_rangelock.c index 3a11059a7f64..3437e3da77ba 100644 --- a/sys/kern/kern_rangelock.c +++ b/sys/kern/kern_rangelock.c @@ -313,15 +313,8 @@ static struct rl_q_entry * rlqentry_alloc(vm_ooffset_t start, vm_ooffset_t end, int flags) { struct rl_q_entry *e; - struct thread *td; - - td = curthread; - if (td->td_rlqe != NULL) { - e = td->td_rlqe; - td->td_rlqe = NULL; - } else { - e = uma_zalloc_smr(rl_entry_zone, M_WAITOK); - } + + e = uma_zalloc_smr(rl_entry_zone, M_WAITOK); e->rl_q_next = NULL; e->rl_q_free = NULL; e->rl_q_start = start; @@ -333,12 +326,6 @@ rlqentry_alloc(vm_ooffset_t start, vm_ooffset_t end, int flags) return (e); } -void -rangelock_entry_free(struct rl_q_entry *e) -{ - uma_zfree_smr(rl_entry_zone, e); -} - void rangelock_init(struct rangelock *lock) { @@ -401,19 +388,12 @@ static void rangelock_free_free(struct rl_q_entry *free) { struct rl_q_entry *x, *xp; - struct thread *td; - td = curthread; for (x = free; x != NULL; x = xp) { MPASS(!rl_e_is_marked(x)); xp = x->rl_q_free; MPASS(!rl_e_is_marked(xp)); - if (td->td_rlqe == NULL) { - smr_synchronize(rl_smr); - td->td_rlqe = x; - } else { - uma_zfree_smr(rl_entry_zone, x); - } + uma_zfree_smr(rl_entry_zone, x); } } diff --git a/sys/kern/kern_thread.c b/sys/kern/kern_thread.c index 9c3694feb945..4ccd6b26528e 100644 --- a/sys/kern/kern_thread.c +++ b/sys/kern/kern_thread.c @@ -460,7 +460,6 @@ thread_init(void *mem, int size, int flags) td->td_allocdomain = vm_phys_domain(vtophys(td)); td->td_sleepqueue = sleepq_alloc(); td->td_turnstile = turnstile_alloc(); - td->td_rlqe = NULL; EVENTHANDLER_DIRECT_INVOKE(thread_init, td); umtx_thread_init(td); td->td_kstack = 0; @@ -480,7 +479,6 @@ thread_fini(void *mem, int size) EVENTHANDLER_DIRECT_INVOKE(thread_fini, td); turnstile_free(td->td_turnstile); sleepq_free(td->td_sleepqueue); - rangelock_entry_free(td->td_rlqe); umtx_thread_fini(td); MPASS(td->td_sel == NULL); } diff --git a/sys/sys/proc.h b/sys/sys/proc.h index 57c910d8fce0..1e98cc84a60a 100644 --- a/sys/sys/proc.h +++ b/sys/sys/proc.h @@ -247,7 +247,7 @@ struct thread { struct seltd *td_sel; /* Select queue/channel. */ struct sleepqueue *td_sleepqueue; /* (k) Associated sleep queue. */ struct turnstile *td_turnstile; /* (k) Associated turnstile. */ - struct rl_q_entry *td_rlqe; /* (k) Associated range lock entry. */ + void *td_pad1; /* Available */ struct umtx_q *td_umtxq; /* (c?) Link for when we're blocked. */ lwpid_t td_tid; /* (b) Thread ID. */ sigqueue_t td_sigqueue; /* (c) Sigs arrived, not delivered. */ diff --git a/sys/sys/rangelock.h b/sys/sys/rangelock.h index accf33d7296b..32ccf3427b49 100644 --- a/sys/sys/rangelock.h +++ b/sys/sys/rangelock.h @@ -65,7 +65,6 @@ void *rangelock_wlock(struct rangelock *lock, vm_ooffset_t start, vm_ooffset_t end); void *rangelock_trywlock(struct rangelock *lock, vm_ooffset_t start, vm_ooffset_t end); -void rangelock_entry_free(struct rl_q_entry *e); void rangelock_may_recurse(struct rangelock *lock); #if defined(INVARIANTS) || defined(INVARIANT_SUPPORT) void _rangelock_cookie_assert(void *cookie, int what, const char *file, From nobody Fri Aug 30 01:05:02 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Ww0LQ4lphz5MmNW; Fri, 30 Aug 2024 01:05:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Ww0LQ44hQz4n1X; Fri, 30 Aug 2024 01:05:02 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724979902; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=aE8LjichO5nhXSVbdEZ6juXjyW/rP/2w7UYZw6tiPsw=; b=sRtIYY/6WihPWt7PbUAbcO0kJIyd4x8V738oJUXzbWAuPySMms0keeHM1TS67iaxBxJkK7 mS2ZHuh1s//hHNRc9yG8Wkltl9bZGnZMnHh8l3w5BlRoI6dBoWsVGPxrbyZPbVknWsFQGV /u8SHB1eqJeFkoiTnlhUFKk9OUIMHH+gWdjpeHgfIWc2/eVr7+UQkvV5O4hB4Yhl5O9T7q YdyiXBvIGZ4Nof4fUTHKOLSMbShBUoatQoVkkXxD2Yf3UEvipzoY9DgjVJYcHtPjj1oYSE vG8qxHGUGzvKuYRyPUDFUJEGqmuBW76s5jIolifRkjyCSjYV//Hs4wM19OGcJw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724979902; a=rsa-sha256; cv=none; b=H5NRDhlVJOgJDdfaCk+R6IKNLQ1eKJsUGg1lDMH9rs3skFL4Mkf1dyLS0Ir5PSu4eRz9gl Ro9ojqIPj0wAgJER5ki+skKss+FtjCWdvcoR6xqQ+3wYf8b1s3oRw+INl45dtn37Jm+dSV PPBO2netcSajv8JpBFdcf2eCLZWGpDYLHI2qDNS9HOjYGgKeRUyzgGJlttfrBgxv3HfdGc OKsr6LRvEO/cPnb2doEEuBK1sJu5RPLkbagni/euEsuqcRFbygH3ACfd07By9r+VmHXvU8 G3p0j+V+03Oo36z19EtfcCyxikoDWor22oG1vnoy295vVU2rj5mLrOYK0x17XQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724979902; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=aE8LjichO5nhXSVbdEZ6juXjyW/rP/2w7UYZw6tiPsw=; b=HUNtNhBD5HwsrdZX9yBV1t66AQYK9PYWxeJ3QL1fXR37LFvi7ysU28PMi/asbrHRE36IKZ 7uFtt4UA3nPfhITYO07jMJiwR2h8OCt++GhOuaF1QoIUMVVoRDiKLuGyGNoEC761e4bku4 WhLjY6+NWS23KZROc1znvSAqzz83T4qkXbnFmUzo7/AasNgUk8nSsWXV9cQpMrwpo13WRJ VQ1s7MZz5rOW98ePOLT7pqUal6z4c0EbvUtBqK8E390qB4J/lBI8l1RdrLZUdTbqSKlxXk 0yrQGYu+WEEPHguVUNEqRJoOevue75mfvI9I9Xn3LOlNIuAfamgEvVDn0jAdkw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Ww0LQ3Yyjzgxw; Fri, 30 Aug 2024 01:05:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47U152qe095211; Fri, 30 Aug 2024 01:05:02 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47U152s5095208; Fri, 30 Aug 2024 01:05:02 GMT (envelope-from git) Date: Fri, 30 Aug 2024 01:05:02 GMT Message-Id: <202408300105.47U152s5095208@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Navdeep Parhar Subject: git: 3b4dcc0feb41 - main - cxgbe/iw_cxgbe: c4iw_connect should return a negative errno. List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: np X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 3b4dcc0feb41120017381681d612d3cc21beb1d7 Auto-Submitted: auto-generated The branch main has been updated by np: URL: https://cgit.FreeBSD.org/src/commit/?id=3b4dcc0feb41120017381681d612d3cc21beb1d7 commit 3b4dcc0feb41120017381681d612d3cc21beb1d7 Author: Navdeep Parhar AuthorDate: 2024-08-30 00:43:43 +0000 Commit: Navdeep Parhar CommitDate: 2024-08-30 00:58:36 +0000 cxgbe/iw_cxgbe: c4iw_connect should return a negative errno. Avoid a pointless assignment while here. MFC after: 1 week Sponsored by: Chelsio Communications --- sys/dev/cxgbe/iw_cxgbe/cm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sys/dev/cxgbe/iw_cxgbe/cm.c b/sys/dev/cxgbe/iw_cxgbe/cm.c index c3d334aa0f62..d8def446d6f0 100644 --- a/sys/dev/cxgbe/iw_cxgbe/cm.c +++ b/sys/dev/cxgbe/iw_cxgbe/cm.c @@ -2655,8 +2655,7 @@ int c4iw_connect(struct iw_cm_id *cm_id, struct iw_cm_conn_param *conn_param) CTR2(KTR_IW_CXGBE, "%s:cc7 %p", __func__, ep); printk(KERN_ERR MOD "%s - cannot find route.\n", __func__); - err = EHOSTUNREACH; - return err; + return -EHOSTUNREACH; } if (!(if_getcapenable(nh_ifp) & IFCAP_TOE) || From nobody Fri Aug 30 07:06:11 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Ww8M75JDgz5TDPr; Fri, 30 Aug 2024 07:06:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Ww8M74lSZz4KHN; Fri, 30 Aug 2024 07:06:11 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725001571; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FGeU+3Mmf5iKdWA8aM80PKrc424wI97/GMr8TqLJN7Y=; b=M2JQoVW/fofcf6sN6tUbfy4pzVNkEttSIEBXDeKiVryfbZPY8OKjmMW1ojRocXtNsg9zCt 6LRN1RV6sH8pzoWRYJN5TeIYOceyqf0hvnOqaTGKd69p7JJt+g1qWC5UZVTKEfCoNmiZIy uK9fW/dMGdPgdA+KUtRLfpUQvgn4r1HeI0LuUYivLFRHgjEdEHomQgcExb/ejwvfZ8nN3o TJCYefWSoOUoet9aJUlFTKQqQZlScJnjMIfXSE5ESOYVXFP+lm4e/8G0pR2mR8J48L4vDY W1EOaF1Xo/IzHt6JQiSLkU4ofv3kgpDGcmiWttjxnT0Fl8OjUFtJjTnlE4e7SQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1725001571; a=rsa-sha256; cv=none; b=sQ4WJAHZEU8DLprVhJn/K8IObHHsMpOUGa7CC7PrW7CMQOdfeCtOd8IYImdtKL7vvwmy5d jirYrSzW2Fdo7T76iIkD+aTrM4IntJTrfLlJSCoRTPu9TdCruZ1YcbyVCNO4LFX/rbGEKX 4Hltv7yF4Ku8AIZvtmbgXq3xSR/F93DO/uMKgnhqSYU9OKoBg6356JOGmVpczhHcLAUu91 ilxI77sqG0w6tyv/jAgwezW6u10bE0r+QX+sPFWDhRoC/3XxTYaURS03ipr7jxX3jqmBZD 2OEhFFc56FFDDW2cOz279lOTJ5EDzZz21lf18h3GddE0XECXXEZM+HC8TbVOQg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725001571; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FGeU+3Mmf5iKdWA8aM80PKrc424wI97/GMr8TqLJN7Y=; b=bOSJP4rP4rxn3oG2XQnKa8Av+IZbQ7SgLYVoFbzO6FoNSux0qvfiseoWp2zpekk0HlkUWq ls+nnmdGQeA8Lr4PZeKnBYxqq5L9v5UdtuziSTcfEbRGwm4WnVjBoO7WqzbgkF//BT/yho IYiuxSYyWdpdbpl2xZPuKnZW07eIvyHDx7g+kPlW+IRLbe+0eMWGa+drezsVUpUdwOGAxf ArJ+ZKLBXKCc3tvJDSGwHzlEWNf3ngY3PZw3cXoluh2wVC6wCHP3rmMUfpyzb04X3AJsiC OaxR9yqk8IiorIlHgynGYfQ5+YdmSZoLqUtBZxDQ1GftgxGJtRVCgCvWSVQMxg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Ww8M74H3gzrPH; Fri, 30 Aug 2024 07:06:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47U76BVG010906; Fri, 30 Aug 2024 07:06:11 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47U76BDc010903; Fri, 30 Aug 2024 07:06:11 GMT (envelope-from git) Date: Fri, 30 Aug 2024 07:06:11 GMT Message-Id: <202408300706.47U76BDc010903@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Xin LI Subject: git: 4b6e76eff8b6 - main - u3g: add SIERRA AC340U List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: delphij X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 4b6e76eff8b63d691c05772520849b6c94d535e8 Auto-Submitted: auto-generated The branch main has been updated by delphij: URL: https://cgit.FreeBSD.org/src/commit/?id=4b6e76eff8b63d691c05772520849b6c94d535e8 commit 4b6e76eff8b63d691c05772520849b6c94d535e8 Author: Franco Fichtner AuthorDate: 2024-08-23 11:26:38 +0000 Commit: Xin LI CommitDate: 2024-08-30 07:05:30 +0000 u3g: add SIERRA AC340U Pull request: https://github.com/freebsd/freebsd-src/pull/1397 MFC after: 3 days --- sys/dev/usb/serial/u3g.c | 1 + sys/dev/usb/usbdevs | 1 + 2 files changed, 2 insertions(+) diff --git a/sys/dev/usb/serial/u3g.c b/sys/dev/usb/serial/u3g.c index 88f94ddaecc6..28a403a846bd 100644 --- a/sys/dev/usb/serial/u3g.c +++ b/sys/dev/usb/serial/u3g.c @@ -568,6 +568,7 @@ static const STRUCT_USB_HOST_ID u3g_devs[] = { U3G_DEV(SIERRA, MC5728, 0), U3G_DEV(SIERRA, MC7354, 0), U3G_DEV(SIERRA, MC7355, 0), + U3G_DEV(SIERRA, AC340U, 0), U3G_DEV(SIERRA, MC7430, 0), U3G_DEV(SIERRA, MC8700, 0), U3G_DEV(SIERRA, MC8755, 0), diff --git a/sys/dev/usb/usbdevs b/sys/dev/usb/usbdevs index e02289521095..27126b52e243 100644 --- a/sys/dev/usb/usbdevs +++ b/sys/dev/usb/usbdevs @@ -4357,6 +4357,7 @@ product SIERRA E6893 0x6893 E6893 product SIERRA MC8700 0x68A3 MC8700 product SIERRA MC7354 0x68C0 MC7354 product SIERRA MC7355 0x9041 MC7355 +product SIERRA AC340U 0x9051 Sierra Wireless AirCard 340U product SIERRA MC7430 0x9071 Sierra Wireless MC7430 Qualcomm Snapdragon X7 LTE-A product SIERRA AC313U 0x68aa Sierra Wireless AirCard 313U product SIERRA TRUINSTALL 0x0fff Aircard Tru Installer From nobody Fri Aug 30 07:30:45 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Ww8vT5mwDz5TG2s; Fri, 30 Aug 2024 07:30:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Ww8vT5Hj5z4Lwr; Fri, 30 Aug 2024 07:30:45 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725003045; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/q1dC5AweX4CWbp5MYOKaG/GQ28fSh4/nnknoKHVFzg=; b=IWBSqdY8hibYe94Jm7Nw5IW7UtPosP5tND06+fSzP0pi0+mOKr5Xd0cJOJiHCY3nCnOWYd I9Ls3k5yERgXHmL6O0+iMouApHzGYSa4qnAaKnlEwFZ0XUGU+Mvo9yKstndgobuQdfWjIL +g8s1zvKcWAun2wgX3DlhsiFRWdXT0bYxjvXo3v20LkZ86filUL/fAnorgaOEUCYp/FRtr 8u1qcFWWfDCVA9ps6z3JWSUXzu38b2sf2VQj0cJCPxmIEUf/5fpZrhfIF/sbAUVOV4UFp9 oHV+ClE/nlXDYEvJrNkQwih3WwpQQTOWdGzZwGxbw5HFeCz2rZACB0Ha3JpLUQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1725003045; a=rsa-sha256; cv=none; b=fBpALQJEz/MksIQsJ5g5iIadkDINPGH00uMiTN9iPNfZVkCuGMNprp85Xy8OxCLNr7BRWA 4+nQMlXRuQcOVuAMatnlXhX+WMAnc+PORks3ZpM9ioRJY7YNrK/CvMJM6RxNRf5WqwFTb9 yIQkPc/JjNRkrQrh0K8bsznQqKtkVFc6DPI9O5YUW0xBl2/6Ny4nKv0n+Or89/mpmLU5/k pk67lVC/Tu0SyQnFuF9S/olEXT3BflbeBqVNhtCpwFaeVRP/BM7LwXmXtP0/zBuGTpe9H/ VMgR6fXY0n9rSE2SteSWRSFccrjbwKiJ0FjWyDu5JquQXNqfx/COpRk6ecg+pw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725003045; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/q1dC5AweX4CWbp5MYOKaG/GQ28fSh4/nnknoKHVFzg=; b=BP+W0TR5i7P2jHWPXz4SCUizugV8YCUIRRpgERUxa5RhdJoH8rYZLuR+TqRsOWjHM0ab9C ORV3LUvzPWECvcPxFI3+nkpcKIYGJsB2uPQc2FN+r7Yk90Kv9Q+qOKPn8DKu2fptitZdz/ vv0iFjSeJxaRK5U9KUqPmSb/hr0px81FYsgCbCn8sYUvf0m2sfUzmBsdqr4y2kGKIXwErv Vuv6J0/ZfXBftQEr59d7do1CSZ8AWHaeCELW4jBpCa1M2Q6TI52+ihO/bLVTME6t47RGOd j0S+Be0kb9dwK9o+CdNFwPDSuHhgyBCmqHVyc+DRnapI4Djb1NSZw7kGq8NYEg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Ww8vT4rTbzrbw; Fri, 30 Aug 2024 07:30:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47U7UjT9054271; Fri, 30 Aug 2024 07:30:45 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47U7UjtS054268; Fri, 30 Aug 2024 07:30:45 GMT (envelope-from git) Date: Fri, 30 Aug 2024 07:30:45 GMT Message-Id: <202408300730.47U7UjtS054268@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Michael Tuexen Subject: git: b2044c455744 - main - tcp rack, bbr: improve handling of soft errors List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: b2044c4557443bbce974101f04e2b465d1bbe769 Auto-Submitted: auto-generated The branch main has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=b2044c4557443bbce974101f04e2b465d1bbe769 commit b2044c4557443bbce974101f04e2b465d1bbe769 Author: Michael Tuexen AuthorDate: 2024-08-30 07:26:41 +0000 Commit: Michael Tuexen CommitDate: 2024-08-30 07:26:41 +0000 tcp rack, bbr: improve handling of soft errors Do not report an error, if it is stored as a soft error. This avoids, for example, the dropping of TCP connections using an interface, while enabling or disabling LRO on that interface. Reviewed by: cc MFC after: 1 week Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D46427 --- sys/netinet/tcp_stacks/bbr.c | 1 + sys/netinet/tcp_stacks/rack.c | 1 + 2 files changed, 2 insertions(+) diff --git a/sys/netinet/tcp_stacks/bbr.c b/sys/netinet/tcp_stacks/bbr.c index cf64451f0c87..3f8c749583b4 100644 --- a/sys/netinet/tcp_stacks/bbr.c +++ b/sys/netinet/tcp_stacks/bbr.c @@ -13867,6 +13867,7 @@ nomore: case ENETUNREACH: if (TCPS_HAVERCVDSYN(tp->t_state)) { tp->t_softerror = error; + error = 0; } /* FALLTHROUGH */ default: diff --git a/sys/netinet/tcp_stacks/rack.c b/sys/netinet/tcp_stacks/rack.c index da28fd25d195..e77604820b63 100644 --- a/sys/netinet/tcp_stacks/rack.c +++ b/sys/netinet/tcp_stacks/rack.c @@ -22450,6 +22450,7 @@ nomore: case ENETDOWN: if (TCPS_HAVERCVDSYN(tp->t_state)) { tp->t_softerror = error; + error = 0; } /* FALLTHROUGH */ default: From nobody Fri Aug 30 07:37:15 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Ww92z3q08z5TGnb; Fri, 30 Aug 2024 07:37:15 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Ww92z1Rj7z4N8d; Fri, 30 Aug 2024 07:37:15 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725003435; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=HVPeKlPuOYUw0ebY0xtpWevjzBmYBAoXFPsQp0udOyU=; b=qf7jPCbCr/lufzpE4LFZjYzWOluZxe3mhMde3BelOb4HENblM0QRqt0gvq6oMunl1A5EAZ 2XGWnAifQCspzFxnfRj7tLhstQqNqISifOm8d2YJ6yEzBNhu/WvTcz1x1VJlPxlEWGsTz9 mFy9t2cUeazUsHGVqlXHaU7P9XUd66M7WgjVYFX1FlpZEQWdZgOsnKhKrDo32dSbRQfpKP 0n0CODsPJ3/bgGGCgROY0lh6rRl9syxlRD7iuBMGT2/pGJZQKbrn5Ikffam2FnfueJaPMl g+vU8IoQjTYfLc+MBv72a95J5xT0pNYzCEFmd23vLM60RhVlx1nA/RPYR2LoBw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1725003435; a=rsa-sha256; cv=none; b=QrX/oZ2GowejYxYoVjPEbKDiZdIR6AZTysLMmo6j/cQ/ao/ZtLjOsPCoU4pXL3AMgyiq0q kqhXQZhaCI08GPLKXV/GFv6/EHTddHAQ9MiKjs8geIhJykQem2CH839yooVJNxWoK2TflL mOHqgoZSawV0x9BtK0nwr1G26GhyDme8eB71MizwbZzYdkpAgqCkViZmqAeGgl2l6HUXNe Wmui465pRACtzEwAmvPhh5tEN9v+yWY5VCCkbwdL6jLMmIesF4GYE+z4rStCEznqN9TA0W KJZLRJw7VVTqhLucC+1p5QJ7F974ZpMJBZndPd9hr2ZrAz2brep8LWJWm19Ivg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725003435; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=HVPeKlPuOYUw0ebY0xtpWevjzBmYBAoXFPsQp0udOyU=; b=DeFqjf4jNy7ZCkzN2P1Tn9LLAyiHTKNJtE9gGNMMF5UrNMh3gZKtibE2+KMuldAaN0FiRc w6BHXGrbBGiqDwiU5e+zNif+4jHYi0QiAU5dddQ+LiYGCFZteRCDS/iPPhZz9x3otLvnhB w4G3VvBPoOYE7bd/aCHctlSzvhrmNHP03MbvT/QbkgONVGvvdlDlwq5smsbzGwhR+0WAEK RhhGagAHSycedYK4K+T+1CttBg6vurpugoB/1eQNHITN6/5CQBrqT5mmHsv8Dx4FLDAyy7 YxjExEFlQZa4ohpFeYCJsZt2g7S7uuI+FyGn62hPvZlIg06kdA1JRAX8r9B7cg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Ww92z13JJzs88; Fri, 30 Aug 2024 07:37:15 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47U7bF2b061879; Fri, 30 Aug 2024 07:37:15 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47U7bFBr061875; Fri, 30 Aug 2024 07:37:15 GMT (envelope-from git) Date: Fri, 30 Aug 2024 07:37:15 GMT Message-Id: <202408300737.47U7bFBr061875@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Michael Tuexen Subject: git: 6e25bccb989c - main - tcpsso: remove support for some IPPROTO_TCP-level socket option names List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 6e25bccb989c3fdea550833484f262d47910a249 Auto-Submitted: auto-generated The branch main has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=6e25bccb989c3fdea550833484f262d47910a249 commit 6e25bccb989c3fdea550833484f262d47910a249 Author: Michael Tuexen AuthorDate: 2024-08-30 07:32:50 +0000 Commit: Michael Tuexen CommitDate: 2024-08-30 07:32:50 +0000 tcpsso: remove support for some IPPROTO_TCP-level socket option names Remove support for IPPROTO_TCP-level socket option names, because these names will be removed from the source tree soon. The corresponding socket options are not implemented by the TCP stack at all. This change was suggested by Peter Lei. Reviewed by: cc Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D46437 --- usr.sbin/tcpsso/tcpsso.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/usr.sbin/tcpsso/tcpsso.c b/usr.sbin/tcpsso/tcpsso.c index 7d34f5559d2d..95773fe5a4d7 100644 --- a/usr.sbin/tcpsso/tcpsso.c +++ b/usr.sbin/tcpsso/tcpsso.c @@ -207,7 +207,6 @@ static struct so_name so_names[] = { tcp_entry(TCP_PACING_RATE_CAP), /* uint64_t */ #endif tcp_entry(TCP_HDWR_UP_ONLY), /* int */ - tcp_entry(TCP_FAST_RSM_HACK), /* int */ tcp_entry(TCP_DELACK), /* int */ tcp_entry(TCP_REC_ABC_VAL), /* int */ tcp_entry(TCP_USE_CMP_ACKS), /* int */ @@ -215,7 +214,6 @@ static struct so_name so_names[] = { tcp_entry(TCP_SHARED_CWND_ENABLE), /* int */ tcp_entry(TCP_DATA_AFTER_CLOSE), /* int */ tcp_entry(TCP_DEFER_OPTIONS), /* int */ - tcp_entry(TCP_MAXPEAKRATE), /* int */ tcp_entry(TCP_TIMELY_DYN_ADJ), /* int */ tcp_entry(TCP_RACK_TLP_REDUCE), /* int */ tcp_entry(TCP_RACK_PACE_ALWAYS), /* int */ @@ -256,10 +254,8 @@ static struct so_name so_names[] = { tcp_entry(TCP_BBR_IWINTSO), /* int */ tcp_entry(TCP_BBR_ALGORITHM), /* int */ tcp_entry(TCP_BBR_TSLIMITS), /* int */ - tcp_entry(TCP_BBR_RECFORCE), /* int */ tcp_entry(TCP_BBR_STARTUP_PG), /* int */ tcp_entry(TCP_BBR_DRAIN_PG), /* int */ - tcp_entry(TCP_BBR_RWND_IS_APP), /* int */ tcp_entry(TCP_BBR_PROBE_RTT_INT), /* int */ tcp_entry(TCP_BBR_PROBE_RTT_GAIN), /* int */ tcp_entry(TCP_BBR_PROBE_RTT_LEN), /* int */ From nobody Fri Aug 30 08:05:35 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Ww9gh0CLRz5TJcr; Fri, 30 Aug 2024 08:05:36 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Ww9gg6Yvwz4Ppk; Fri, 30 Aug 2024 08:05:35 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725005135; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=mTiUuKFw+/EZPwIXg2/xgpzZrkyeUiXj9GM+DbzCfOc=; b=FtI+w38CByN4IgWqdWjGS81TgPPUGdQMXF3xZDzbDc2YXo+jgyZRvU+cElrmu4sMFFCSO8 7ipBBtQfY1YonNUatDJKGgmesJu0tJXIE2dirQZ/a5XiOOVVeFzg/uoTbsNfRzcCmuS0RF BgI/7DJ/wync7YCReNIYuymp8kCuQVgdSNmdNla8IaUyAb59n20bcKYWByuCWkClqIlLCw WSawOUIHPhH6+FQVu8wiLnbs46Xb5pc8qGv6e7cU4dzRaJe/CdRcK61Z9hJus9P82qWLMX beaYEXBxV/ZJVA/cCwtCwkJGVUfD18Z0QB03zP+ck0MLgL1LFhyRFEXjmXeuHg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1725005135; a=rsa-sha256; cv=none; b=xdjZBM56dzFo3Kk3cmmRynOm03Pscjub0+7vfW/TRUH9XYQU+PBMBryRyVAnBn/teI487q NjeNd/Y3+mm84t6wSWwqkTfO4f46cW05g1qH2hH45YmrRPTJ5fZOadC0DZoBPaQAgQfbR8 5Vr/gs25e+6qIeKyljJK/rFTUJgV0JLmjtzxfRjD+DDldbVEwvBqIt+c18A5HwBTcnPop5 uybXCiguPqraYpdCnxZaocRFS0a867P+OioLdixJm8ArqtFyr85oUh2qnCHa9IF4K0rDPY pubSedY8855QrMo7ZetnEJCj9eOl2bADMXcG1TPxrtqm1caQAP20n76PrHdG5w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725005135; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=mTiUuKFw+/EZPwIXg2/xgpzZrkyeUiXj9GM+DbzCfOc=; b=dETm/N+sdhSTVDybLwilcQEJHRyJQwhjpSGj/ig85o9whAzb7F40/O8NstLcyklxUEEt3x tCZOWt0QCKVDvgMUd4m118pWhm5WqUXNJsOEKE9m8ctxkaywh/uFrFmlWIXSWQaS9RRJJV wrM90HpbOaIxYLL3xZ2z6gpo8tmkPjXrFOH8sh5mUEc2SFjCGgc5Mb2qeyW8wMtxvxynIO RRlrkbal9GcpNzEX4lrikZaID/lSWDnQhyoPxAwHZ5H2eE4UNrVZ/hD6sUiHIjGkE8CJ/t i3yNZMkF+oTZar+64F5zTAa8Ic5yQvQE+X4qxhfQb3ZnuindUaT8XhLG40TJEg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Ww9gg69Cqzsqx; Fri, 30 Aug 2024 08:05:35 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47U85ZMt012880; Fri, 30 Aug 2024 08:05:35 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47U85Ziq012877; Fri, 30 Aug 2024 08:05:35 GMT (envelope-from git) Date: Fri, 30 Aug 2024 08:05:35 GMT Message-Id: <202408300805.47U85Ziq012877@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Peter Holm Subject: git: f6fd5af80a37 - main - stress2: Do not wait forever for swap usage List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: pho X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: f6fd5af80a37ef0560959bd55c2c86d17ee2033f Auto-Submitted: auto-generated The branch main has been updated by pho: URL: https://cgit.FreeBSD.org/src/commit/?id=f6fd5af80a37ef0560959bd55c2c86d17ee2033f commit f6fd5af80a37ef0560959bd55c2c86d17ee2033f Author: Peter Holm AuthorDate: 2024-08-30 08:04:46 +0000 Commit: Peter Holm CommitDate: 2024-08-30 08:04:46 +0000 stress2: Do not wait forever for swap usage --- tools/test/stress2/misc/mmap40.sh | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/tools/test/stress2/misc/mmap40.sh b/tools/test/stress2/misc/mmap40.sh index 7f4d07885e05..2314596e2f5d 100755 --- a/tools/test/stress2/misc/mmap40.sh +++ b/tools/test/stress2/misc/mmap40.sh @@ -53,13 +53,14 @@ mount /dev/md$mdstart $mntpoint set +e u1=`swapinfo | tail -1 | awk '{print $3}'` -(nice $odir/../testcases/swap/swap -t 10m -i 30 -h -l 100) & -while [ $((`swapinfo | tail -1 | awk '{print $3}'` - $u1)) -le 100 ]; do +(nice $odir/../testcases/swap/swap -t 10m -i 30 -h -l 100) > /dev/null & +for i in `jot 120`; do + u2=`swapinfo | tail -1 | awk '{print $3}'` + [ $u2 -lt $u1 ] && u1=$u2 + [ $((u2 - $u1)) -gt 100 ] && break sleep 1 done - -$dir/mmap40 -s=0 +/usr/bin/timeout 10m $dir/mmap40; s=$? while pkill swap; do :; done wait [ -f mmap40.core -a $s -eq 0 ] && From nobody Fri Aug 30 08:55:54 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WwBp46h5wz52PVQ for ; Fri, 30 Aug 2024 08:56:12 +0000 (UTC) (envelope-from bT.v6n72r96s3jq2a3=igs2lrpm4m52=kcbwmr5xlan541@em790814.fubar.geek.nz) Received: from e2i270.smtp2go.com (e2i270.smtp2go.com [103.2.141.14]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4WwBp466FGz4VCd for ; Fri, 30 Aug 2024 08:56:12 +0000 (UTC) (envelope-from bT.v6n72r96s3jq2a3=igs2lrpm4m52=kcbwmr5xlan541@em790814.fubar.geek.nz) Authentication-Results: mx1.freebsd.org; none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=smtpservice.net; s=a1-4; h=X-Smtpcorp-Track:Feedback-ID:To:Message-Id:Date: From:Subject:Reply-To:Sender:List-Unsubscribe:List-Unsubscribe-Post; bh=XADESgTWy5H3SSRm8j8xOAXrrAn/50YBQg+LJKu/dJE=; b=RMstYTm0o6q1zbcl28DV1hUKuJ D92/nNTrWUJ3h+Jiv1hdu6VVimVwAz6JhEG/0+ke8DXX1oAkU1D+EtdrHCnZ3rXjN0Zywh6HYFlfA yYnKMx1tTeUX1kgTczwqchxb+/puP6vn/zPkq/dAFS4WTIiuzCBZ2aXKpq8TTUKfR9pGcsvmy4G3g j5XvCGYDz/JSR1EPKeM9qAyKCCdLL0JQaG3W57JmOmJuKQS4rDbiszECQXZaUCRFgZY//oI0vdn70 PchClOOJZqKAEPUoSPTMLkpq6+0thjgqoYWrqnMj1VwtcT9FqXNV32NpkDqiymt9NmFOk2IfpYlQi 4mA4NpVg==; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fubar.geek.nz; i=@fubar.geek.nz; q=dns/txt; s=s790814; t=1725008172; h=from : subject : to : message-id : date; bh=XADESgTWy5H3SSRm8j8xOAXrrAn/50YBQg+LJKu/dJE=; b=WW9Svg/DQDK00p8qcrXXsDqN9F+Y5QeYVwfOLZ6fCN0Nqf3jKQJ+P5wyMaTzKXGLaXCN6 n7sLSubPwSjpzfBeq0lFCCs5D1kq4KoeRYeS+dgP9tgT9X8FC4HrpAJP9R7Cy0yPXzlzUgF jYJGNpEW2KFfPC+A3amDdvF4JuGXHQPTfMZa72CxcVZIB2vcY03DkHCqDSetMVFcF8ahR+Q iyD3wMlI4NBqiKY6exiY+tER3izCc2oqcXjp1y68bfB56vIBnhEBc4XFwCz74P3L+soJ+/0 X7ywzgLEIpoXfeaJfdyGDbOfVnWfulowwSDJtb7QqCV3hbuzyHAzsQKK4sig== Received: from [10.176.58.103] (helo=SmtpCorp) by smtpcorp.com with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94.2-S2G) (envelope-from ) id 1sjxQN-TRjxvw-Hf; Fri, 30 Aug 2024 08:56:07 +0000 Received: from [10.99.243.232] (helo=morbo.fubar.geek.nz) by smtpcorp.com with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.97.1-S2G) (envelope-from ) id 1sjxQM-4o5NDgrplYW-s7Po; Fri, 30 Aug 2024 08:56:07 +0000 Received: from smtpclient.apple (92.40.184.78.threembb.co.uk [92.40.184.78]) by morbo.fubar.geek.nz (Postfix) with ESMTPSA id 9341C16931; Fri, 30 Aug 2024 08:56:05 +0000 (UTC) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.600.62\)) Subject: Re: git: 43e8849bc294 - main - conf: Enable BTI checking in the arm64 kernel From: Andrew Turner In-Reply-To: <19DBDC11-EB0F-48C0-9AAE-9EED087F0AB6@freebsd.org> Date: Fri, 30 Aug 2024 09:55:54 +0100 Cc: John Baldwin , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: <202408200902.47K92BsJ078096@gitrepo.freebsd.org> <77cbcd47-1778-4e71-b824-4e75e0e4b2d6@FreeBSD.org> <19DBDC11-EB0F-48C0-9AAE-9EED087F0AB6@freebsd.org> To: Jessica Clarke X-Mailer: Apple Mail (2.3774.600.62) X-Smtpcorp-Track: MouS1z8jUquh.ulnHn6xSXLYC.AD-4KQ9dM7_ Feedback-ID: 790814m:790814amQcrys:790814sU1FG6a83q X-Report-Abuse: Please forward a copy of this message, including all headers, to X-Smtpcorp-Track: MouS1z8jUquh.ulnHn6xSXLYC.AD-4KQ9dM7_ X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:23352, ipnet:103.2.140.0/22, country:US] X-Rspamd-Queue-Id: 4WwBp466FGz4VCd > On 29 Aug 2024, at 17:02, Jessica Clarke wrote: >=20 > On 21 Aug 2024, at 15:28, John Baldwin wrote: >>=20 >> On 8/20/24 05:02, Andrew Turner wrote: >>> The branch main has been updated by andrew: >>> URL: = https://cgit.FreeBSD.org/src/commit/?id=3D43e8849bc29414036ccaef7788de95a0= 7ad32ab5 >>> commit 43e8849bc29414036ccaef7788de95a07ad32ab5 >>> Author: Andrew Turner >>> AuthorDate: 2024-08-19 12:59:49 +0000 >>> Commit: Andrew Turner >>> CommitDate: 2024-08-20 08:49:15 +0000 >>> conf: Enable BTI checking in the arm64 kernel >>> To ensure new code has BTI support make it an error to not = have the >>> BTI ELF note when linking the kernel and kernel modules. >>> Reviewed by: kib, emaste >>> Sponsored by: Arm Ltd >>> Differential Revision: https://reviews.freebsd.org/D45469 >>=20 >> This has broken two of the GitHub CI actions using clang 12 and clang = 13. >> Please fix this to be conditional on a supported linker version (or = perhaps >> add a new linker feature to bsd.linker.mk). >=20 > This is still broken. If it=E2=80=99s not fixed promptly I will just = revert > this change; we can=E2=80=99t leave CI broken, especially when it gets = used to > test GitHub PRs. Please stop breaking building with older toolchains, > this isn=E2=80=99t the first time it=E2=80=99s happened. See https://github.com/freebsd/freebsd-src/pull/1393 and = https://github.com/freebsd/freebsd-src/pull/1399 Andrew From nobody Fri Aug 30 10:27:51 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WwDqq4tcGz52XsG; Fri, 30 Aug 2024 10:27:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WwDqq419yz4cf7; Fri, 30 Aug 2024 10:27:51 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725013671; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=eHL2x/PDENiwftZxOPI1fzscO6oFCfJRiVlAXOL6beg=; b=hZcYqzC10x8U+bhdwhaAsKlEDirnWEJGKr6Nl039odWvVfmodRkbDM3m1SPuvX66izHbE1 CWBEnETNmmf1rs3ghRTiBNyzICSDPG1DeoiJGIWeygTFNPobh8O6QJLsI9kpdW1fAy481E 7YnPZDq0pm8dPCYXrTsycK3SM0IlRkrlXOdhS236Q1NxmzdBQTX642ZbVM4un1YUszngRY dHCXQJAtVqESymBGoKmyguv4HvZELHt4GNNedIklWM7rlbTbEz0ZFN0qL0ojrqIlYZGOP8 6RfCTVfikuNlHxis4QxIuA4eA7izVa72XbiFw1pTicc38ifmraIddZ5Yw/cSIg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1725013671; a=rsa-sha256; cv=none; b=LbJ1mwFumebrMV9Z23V5JuETMP7h4On+6Gs1Um/FRbHYPE6KVOmlL3w7mtBe2HFqYO9/6t 2RFyaa7dhwPoAj7DlLPFVFWxhW/mLV0d7XYqLT6rTrDp9+UQ1rAtg3Fu7h09TR0H4T6vNK ujWlddhkY5z9dvtOaBS/sP6pBNhOIYdT1YJXDrjRNO777eJDQ0/MaFfGNYZFSScvp7URM2 yuu28/G/E92VWWGXi6pACoHISU3Y7XWWSI3L9ylLNOi2rYf2ZNiBu9eyXYf8bqI1l3kkJ7 t1DmuU5Ytua40tKko6rn5NZTEVWGzEJaXwaLoxrpAzFxi5aND27EHp7o62UHdw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725013671; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=eHL2x/PDENiwftZxOPI1fzscO6oFCfJRiVlAXOL6beg=; b=m1qBRwQ8bKPGQydoF3GmKU8vU7Wb2TK3ngl34O4lyAlBGI3IwHQNZ05BSZj7qjlIGk/oQE wrk5BH/iHgMT0dPH6lauA8m8w5zqXd/bX2A47q+P1bJal5ekr1dQ7GANQcpkxDEnLYnBTb 2YK10oHXWs6TY2WyDaynUgbx2umQjLX7zSrLajoRIc8bhTh9i1aZ6n2feoHmyIN1JvR06J RHGg4G6A9yg0+fezkvolmy7RfGAkGdQaOK0bDHMdDOrdSYM0JrxkUJrozduwPGVNI0Yf5m nDuFa5cYCb4S6hAVMGAYBYpHKdKg1cQH94aCAgLv0tVyW76nE4vKBgZwCR+vmg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WwDqq3d5QzxPs; Fri, 30 Aug 2024 10:27:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47UARpsA051321; Fri, 30 Aug 2024 10:27:51 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47UARpEn051318; Fri, 30 Aug 2024 10:27:51 GMT (envelope-from git) Date: Fri, 30 Aug 2024 10:27:51 GMT Message-Id: <202408301027.47UARpEn051318@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Zhenlei Huang Subject: git: 356be1348dac - main - kernel: Make some compile time constant variables const List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: zlei X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 356be1348dac94ba0d2dc1f479bc1f8a2ebaa03a Auto-Submitted: auto-generated The branch main has been updated by zlei: URL: https://cgit.FreeBSD.org/src/commit/?id=356be1348dac94ba0d2dc1f479bc1f8a2ebaa03a commit 356be1348dac94ba0d2dc1f479bc1f8a2ebaa03a Author: Zhenlei Huang AuthorDate: 2024-08-30 10:26:30 +0000 Commit: Zhenlei Huang CommitDate: 2024-08-30 10:26:30 +0000 kernel: Make some compile time constant variables const Those variables are not going to be changed at runtime. Make them const to avoid potential overwriting. This will also help spotting accidental global variables shadowing, since the variable's name such as `version` is short and commonly used. This change was inspired by reviewing khng's work D44760. No functional change intended. MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D45227 --- sys/arm/arm/identcpu-v6.c | 6 +++--- sys/arm64/arm64/identcpu.c | 2 +- sys/conf/newvers.sh | 14 +++++++------- sys/kern/init_main.c | 24 ++++++++++++------------ sys/kern/kern_mib.c | 16 ++++++++-------- sys/powerpc/powerpc/machdep.c | 5 +++-- sys/riscv/riscv/identcpu.c | 6 +++--- sys/sys/copyright.h | 4 ++-- sys/sys/sysctl.h | 8 ++++---- sys/sys/systm.h | 8 ++++---- sys/x86/x86/identcpu.c | 6 +++--- 11 files changed, 50 insertions(+), 49 deletions(-) diff --git a/sys/arm/arm/identcpu-v6.c b/sys/arm/arm/identcpu-v6.c index 34663dfa51e6..3dd218696a19 100644 --- a/sys/arm/arm/identcpu-v6.c +++ b/sys/arm/arm/identcpu-v6.c @@ -49,10 +49,10 @@ #include #include -char machine[] = "arm"; +const char machine[] = "arm"; -SYSCTL_STRING(_hw, HW_MACHINE, machine, CTLFLAG_RD | CTLFLAG_CAPRD, - machine, 0, "Machine class"); +SYSCTL_CONST_STRING(_hw, HW_MACHINE, machine, CTLFLAG_RD | CTLFLAG_CAPRD, + machine, "Machine class"); static char cpu_model[64]; SYSCTL_STRING(_hw, HW_MODEL, model, CTLFLAG_RD | CTLFLAG_CAPRD, diff --git a/sys/arm64/arm64/identcpu.c b/sys/arm64/arm64/identcpu.c index 5fec7cba385f..eead0051d315 100644 --- a/sys/arm64/arm64/identcpu.c +++ b/sys/arm64/arm64/identcpu.c @@ -59,7 +59,7 @@ static void print_cpu_caches(struct sbuf *sb, struct cpu_desc *desc); static u_long parse_cpu_features_hwcap32(void); #endif -char machine[] = "arm64"; +const char machine[] = "arm64"; #ifdef SCTL_MASK32 extern int adaptive_machine_arch; diff --git a/sys/conf/newvers.sh b/sys/conf/newvers.sh index 908e3bfa660a..481af5480399 100644 --- a/sys/conf/newvers.sh +++ b/sys/conf/newvers.sh @@ -312,13 +312,13 @@ $COPYRIGHT #define VERSTR "${VERSTR}" #define RELSTR "${RELEASE}" -char sccs[sizeof(SCCSSTR) > 128 ? sizeof(SCCSSTR) : 128] = SCCSSTR; -char version[sizeof(VERSTR) > 256 ? sizeof(VERSTR) : 256] = VERSTR; -char compiler_version[] = "${compiler_v}"; -char ostype[] = "${TYPE}"; -char osrelease[sizeof(RELSTR) > 32 ? sizeof(RELSTR) : 32] = RELSTR; -int osreldate = ${RELDATE}; -char kern_ident[] = "${i}"; +const char sccs[sizeof(SCCSSTR) > 128 ? sizeof(SCCSSTR) : 128] = SCCSSTR; +const char version[sizeof(VERSTR) > 256 ? sizeof(VERSTR) : 256] = VERSTR; +const char compiler_version[] = "${compiler_v}"; +const char ostype[] = "${TYPE}"; +const char osrelease[sizeof(RELSTR) > 32 ? sizeof(RELSTR) : 32] = RELSTR; +const int osreldate = ${RELDATE}; +const char kern_ident[] = "${i}"; EOF ) vers_content_old=$(cat vers.c 2>/dev/null || true) diff --git a/sys/kern/init_main.c b/sys/kern/init_main.c index 9d2663015027..fed5340695cf 100644 --- a/sys/kern/init_main.c +++ b/sys/kern/init_main.c @@ -365,36 +365,36 @@ print_version(const void *data __unused) printf("%s\n", compiler_version); } -SYSINIT(announce, SI_SUB_COPYRIGHT, SI_ORDER_FIRST, print_caddr_t, +C_SYSINIT(announce, SI_SUB_COPYRIGHT, SI_ORDER_FIRST, print_caddr_t, copyright); -SYSINIT(trademark, SI_SUB_COPYRIGHT, SI_ORDER_SECOND, print_caddr_t, +C_SYSINIT(trademark, SI_SUB_COPYRIGHT, SI_ORDER_SECOND, print_caddr_t, trademark); -SYSINIT(version, SI_SUB_COPYRIGHT, SI_ORDER_THIRD, print_version, NULL); +C_SYSINIT(version, SI_SUB_COPYRIGHT, SI_ORDER_THIRD, print_version, NULL); #ifdef WITNESS -static char wit_warn[] = +static const char wit_warn[] = "WARNING: WITNESS option enabled, expect reduced performance.\n"; -SYSINIT(witwarn, SI_SUB_COPYRIGHT, SI_ORDER_FOURTH, +C_SYSINIT(witwarn, SI_SUB_COPYRIGHT, SI_ORDER_FOURTH, print_caddr_t, wit_warn); -SYSINIT(witwarn2, SI_SUB_LAST, SI_ORDER_FOURTH, +C_SYSINIT(witwarn2, SI_SUB_LAST, SI_ORDER_FOURTH, print_caddr_t, wit_warn); #endif #ifdef DIAGNOSTIC -static char diag_warn[] = +static const char diag_warn[] = "WARNING: DIAGNOSTIC option enabled, expect reduced performance.\n"; -SYSINIT(diagwarn, SI_SUB_COPYRIGHT, SI_ORDER_FIFTH, +C_SYSINIT(diagwarn, SI_SUB_COPYRIGHT, SI_ORDER_FIFTH, print_caddr_t, diag_warn); -SYSINIT(diagwarn2, SI_SUB_LAST, SI_ORDER_FIFTH, +C_SYSINIT(diagwarn2, SI_SUB_LAST, SI_ORDER_FIFTH, print_caddr_t, diag_warn); #endif #if __SIZEOF_LONG__ == 4 -static char ilp32_warn[] = +static const char ilp32_warn[] = "WARNING: 32-bit kernels are deprecated and may be removed in FreeBSD 15.0.\n"; -SYSINIT(ilp32warn, SI_SUB_COPYRIGHT, SI_ORDER_FIFTH, +C_SYSINIT(ilp32warn, SI_SUB_COPYRIGHT, SI_ORDER_FIFTH, print_caddr_t, ilp32_warn); -SYSINIT(ilp32warn2, SI_SUB_LAST, SI_ORDER_FIFTH, +C_SYSINIT(ilp32warn2, SI_SUB_LAST, SI_ORDER_FIFTH, print_caddr_t, ilp32_warn); #endif diff --git a/sys/kern/kern_mib.c b/sys/kern/kern_mib.c index 0132478aa68a..f8f90fce87cf 100644 --- a/sys/kern/kern_mib.c +++ b/sys/kern/kern_mib.c @@ -94,20 +94,20 @@ SYSCTL_ROOT_NODE(OID_AUTO, regression, CTLFLAG_RW | CTLFLAG_MPSAFE, 0, "Regression test MIB"); #endif -SYSCTL_STRING(_kern, OID_AUTO, ident, CTLFLAG_RD, - kern_ident, 0, "Kernel identifier"); +SYSCTL_CONST_STRING(_kern, OID_AUTO, ident, CTLFLAG_RD, + kern_ident, "Kernel identifier"); SYSCTL_INT(_kern, KERN_OSREV, osrevision, CTLFLAG_RD | CTLFLAG_CAPRD, SYSCTL_NULL_INT_PTR, BSD, "Operating system revision"); -SYSCTL_STRING(_kern, KERN_VERSION, version, CTLFLAG_RD, - version, 0, "Kernel version"); +SYSCTL_CONST_STRING(_kern, KERN_VERSION, version, CTLFLAG_RD, + version, "Kernel version"); -SYSCTL_STRING(_kern, OID_AUTO, compiler_version, CTLFLAG_RD, - compiler_version, 0, "Version of compiler used to compile kernel"); +SYSCTL_CONST_STRING(_kern, OID_AUTO, compiler_version, CTLFLAG_RD, + compiler_version, "Version of compiler used to compile kernel"); -SYSCTL_STRING(_kern, KERN_OSTYPE, ostype, CTLFLAG_RD | CTLFLAG_CAPRD, - ostype, 0, "Operating system type"); +SYSCTL_CONST_STRING(_kern, KERN_OSTYPE, ostype, CTLFLAG_RD | CTLFLAG_CAPRD, + ostype, "Operating system type"); SYSCTL_INT(_kern, KERN_MAXPROC, maxproc, CTLFLAG_RDTUN | CTLFLAG_NOFETCH, &maxproc, 0, "Maximum number of processes"); diff --git a/sys/powerpc/powerpc/machdep.c b/sys/powerpc/powerpc/machdep.c index 638153ba49bc..899fb430e5d9 100644 --- a/sys/powerpc/powerpc/machdep.c +++ b/sys/powerpc/powerpc/machdep.c @@ -152,8 +152,9 @@ static char init_kenv[2048]; static struct trapframe frame0; -char machine[] = "powerpc"; -SYSCTL_STRING(_hw, HW_MACHINE, machine, CTLFLAG_RD | CTLFLAG_CAPRD, machine, 0, ""); +const char machine[] = "powerpc"; +SYSCTL_CONST_STRING(_hw, HW_MACHINE, machine, CTLFLAG_RD | CTLFLAG_CAPRD, + machine, "Machine class"); static void cpu_startup(void *); SYSINIT(cpu, SI_SUB_CPU, SI_ORDER_FIRST, cpu_startup, NULL); diff --git a/sys/riscv/riscv/identcpu.c b/sys/riscv/riscv/identcpu.c index 203edb3689bc..54eb302982f1 100644 --- a/sys/riscv/riscv/identcpu.c +++ b/sys/riscv/riscv/identcpu.c @@ -59,10 +59,10 @@ #include #endif -char machine[] = "riscv"; +const char machine[] = "riscv"; -SYSCTL_STRING(_hw, HW_MACHINE, machine, CTLFLAG_RD | CTLFLAG_CAPRD, machine, 0, - "Machine class"); +SYSCTL_CONST_STRING(_hw, HW_MACHINE, machine, CTLFLAG_RD | CTLFLAG_CAPRD, + machine, "Machine class"); /* Hardware implementation info. These values may be empty. */ register_t mvendorid; /* The CPU's JEDEC vendor ID */ diff --git a/sys/sys/copyright.h b/sys/sys/copyright.h index 0da33cec4eb8..4b74075c6712 100644 --- a/sys/sys/copyright.h +++ b/sys/sys/copyright.h @@ -45,5 +45,5 @@ #define COPYRIGHT_UCB \ "Copyright (c) 1979, 1980, 1983, 1986, 1988, 1989, 1991, 1992, 1993, 1994\n\tThe Regents of the University of California. All rights reserved.\n" -char copyright[] = COPYRIGHT_Vendor COPYRIGHT_FreeBSD COPYRIGHT_UCB; -char trademark[] = TRADEMARK_Foundation; +const char copyright[] = COPYRIGHT_Vendor COPYRIGHT_FreeBSD COPYRIGHT_UCB; +const char trademark[] = TRADEMARK_Foundation; diff --git a/sys/sys/sysctl.h b/sys/sys/sysctl.h index 7b27cb307e0c..66c6ff1640b7 100644 --- a/sys/sys/sysctl.h +++ b/sys/sys/sysctl.h @@ -1153,10 +1153,10 @@ SYSCTL_DECL(_regression); SYSCTL_DECL(_security); SYSCTL_DECL(_security_bsd); -extern char machine[]; -extern char osrelease[]; -extern char ostype[]; -extern char kern_ident[]; +extern const char machine[]; +extern const char osrelease[]; +extern const char ostype[]; +extern const char kern_ident[]; /* Dynamic oid handling */ struct sysctl_oid *sysctl_add_oid(struct sysctl_ctx_list *clist, diff --git a/sys/sys/systm.h b/sys/sys/systm.h index 61874a05e0b9..f542a9a86018 100644 --- a/sys/sys/systm.h +++ b/sys/sys/systm.h @@ -51,9 +51,9 @@ __NULLABILITY_PRAGMA_PUSH extern int cold; /* nonzero if we are doing a cold boot */ extern int suspend_blocked; /* block suspend due to pending shutdown */ extern int rebooting; /* kern_reboot() has been called. */ -extern char version[]; /* system version */ -extern char compiler_version[]; /* compiler version */ -extern char copyright[]; /* system copyright */ +extern const char version[]; /* system version */ +extern const char compiler_version[]; /* compiler version */ +extern const char copyright[]; /* system copyright */ extern int kstack_pages; /* number of kernel stack pages */ extern u_long pagesizes[]; /* supported page sizes */ @@ -109,7 +109,7 @@ extern bool scheduler_stopped; */ #define SCHEDULER_STOPPED() __predict_false(scheduler_stopped) -extern int osreldate; +extern const int osreldate; extern const void *zero_region; /* address space maps to a zeroed page */ diff --git a/sys/x86/x86/identcpu.c b/sys/x86/x86/identcpu.c index f24fdc1647e6..d3aec5b5e0c6 100644 --- a/sys/x86/x86/identcpu.c +++ b/sys/x86/x86/identcpu.c @@ -124,7 +124,7 @@ u_int cpu_power_eax; /* 06H: Power management leaf, %eax */ u_int cpu_power_ebx; /* 06H: Power management leaf, %ebx */ u_int cpu_power_ecx; /* 06H: Power management leaf, %ecx */ u_int cpu_power_edx; /* 06H: Power management leaf, %edx */ -char machine[] = MACHINE; +const char machine[] = MACHINE; SYSCTL_UINT(_hw, OID_AUTO, via_feature_rng, CTLFLAG_RD, &via_feature_rng, 0, @@ -158,8 +158,8 @@ sysctl_hw_machine(SYSCTL_HANDLER_ARGS) SYSCTL_PROC(_hw, HW_MACHINE, machine, CTLTYPE_STRING | CTLFLAG_RD | CTLFLAG_CAPRD | CTLFLAG_MPSAFE, NULL, 0, sysctl_hw_machine, "A", "Machine class"); #else -SYSCTL_STRING(_hw, HW_MACHINE, machine, CTLFLAG_RD | CTLFLAG_CAPRD, - machine, 0, "Machine class"); +SYSCTL_CONST_STRING(_hw, HW_MACHINE, machine, CTLFLAG_RD | CTLFLAG_CAPRD, + machine, "Machine class"); #endif char cpu_model[128]; From nobody Fri Aug 30 13:08:32 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WwJPD50hLz5MYvS; Fri, 30 Aug 2024 13:08:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WwJPD4ZL3z4r4V; Fri, 30 Aug 2024 13:08:32 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725023312; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0O1t5C2f0/BQPtCIrE80YtFx5hi4XEHjqY9LOeOvPJc=; b=KaWzVAsZY6judFuDgVOEhHV0RqwyUIptUCRKqoEiUXU43z7cfSjdfEAWOWkasv/SzGt8YF sqkcq4rdJg0kOHJ8U3iP5b1YgRAzSsjKHU3Kz9jH3YDEmN71N1Iu2xT/E9swC7bfP+BZgt fz+/KoNYffEmO6ceiwaHJNr+YYCAq/x8sTwyQkGzqDeXR9Lmw9PvYU8vlc8Q3E7sjGnfNI aeZuIWLMUXkz+lxakttOjCrKq7IpcGSP1V+DN2qfeMYsZ+iCmndSws87ytzvYoQbiELBvW QwDgU4lCekoJtm4mso0zxAEkYZ1jA3Wgah8l8S0i6Ap2HHEVSR0E+q9jjvfiAg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1725023312; a=rsa-sha256; cv=none; b=ByjWzPgITuXeE+d6gGlvpGZWJZ1iM+OB+FbJ9WgCIszU2CObu7tHHLF4biAAEHuKTzRSdV CGWkjcBFPdAGsJLbG75AAK8SLdLpQKg9EPOYFRT4dREllLcVNdkZJjCZq/6OxHR2CAZgHv 2qEOpKp1Q05sgG15OWODUs1B+W1UeuvZIxJ2ENXX2O44hOHKNexjruUduNmFmg6b+Wpcha yiqZMFn3JqPXBXrTFYmebL6n0p3hiqhmlXe4dM7RBvtayRZOI0JkhNszhDq1PBerfLM6nl jshaMS+3j+bkT6yCoV1ShBlPDw95iGhPPsgRM5HE8ipcf+I159Af/WHFdPBdNQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725023312; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0O1t5C2f0/BQPtCIrE80YtFx5hi4XEHjqY9LOeOvPJc=; b=mLZdVFsPsIRgzOAQ1c/5eBOVaaMCMoqOqRVYslN7zKnTmEnBoylIal1p39EGJuvbmAk4Ou dvTWhAakpBtrysCv6agCYt+diJ4CKXeXPRo/10T7qnR5/mQV6K84ILRbAl60mmWQtIvWYR 8Cu2Ko3/uzFLK2zeLB9DBiRXt5UaqGpfgAOVVSbZOoGFwCNkCLh6vSC7Qy2PTrGWVKa88k EKAa4n+0gpxPTxtChnfYrghTmrR7QT5gs1V8bWQ1HV4F/qDHILxyc/XMVYrpCxCyTAQ4At qleaHkEt2DgZNFpRGwsQWBLmRjZ1uEKo3JMUcN17ohIRRKCQVjLP7JsbwTTGxQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WwJPD49Smz12k8; Fri, 30 Aug 2024 13:08:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47UD8WPO022765; Fri, 30 Aug 2024 13:08:32 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47UD8WmU022762; Fri, 30 Aug 2024 13:08:32 GMT (envelope-from git) Date: Fri, 30 Aug 2024 13:08:32 GMT Message-Id: <202408301308.47UD8WmU022762@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: e196b12f4d4d - main - ipsec: Drain async ipsec_offload work when destroying a vnet List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: e196b12f4d4d13982d42cf7841b77dca1405effa Auto-Submitted: auto-generated The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=e196b12f4d4d13982d42cf7841b77dca1405effa commit e196b12f4d4d13982d42cf7841b77dca1405effa Author: Mark Johnston AuthorDate: 2024-08-30 00:44:45 +0000 Commit: Mark Johnston CommitDate: 2024-08-30 13:08:20 +0000 ipsec: Drain async ipsec_offload work when destroying a vnet The ipsec_offload code in some cases releases object references in an asynchronous context where it needs to set the current VNET. Make sure that all such work completes before the VNET is actually destroyed, otherwise a use-after-free is possible. Reported by: KASAN Reviewed by: kib Fixes: ef2a572bf6bd ("ipsec_offload: kernel infrastructure") Sponsored by: Klara, Inc. Differential Revision: https://reviews.freebsd.org/D46483 --- sys/netipsec/ipsec_offload.c | 2 +- sys/netipsec/key.c | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/sys/netipsec/ipsec_offload.c b/sys/netipsec/ipsec_offload.c index bbf98ac7a676..1ff91ec585c2 100644 --- a/sys/netipsec/ipsec_offload.c +++ b/sys/netipsec/ipsec_offload.c @@ -386,7 +386,7 @@ ipsec_accel_sa_newkey_impl(struct secasvar *sav) TASK_INIT(&tq->install_task, 0, ipsec_accel_sa_newkey_act, tq); tq->sav = sav; - tq->install_vnet = curthread->td_vnet; /* XXXKIB liveness */ + tq->install_vnet = curthread->td_vnet; taskqueue_enqueue(taskqueue_thread, &tq->install_task); } diff --git a/sys/netipsec/key.c b/sys/netipsec/key.c index 5a3e5727bc2e..ad1d6164f158 100644 --- a/sys/netipsec/key.c +++ b/sys/netipsec/key.c @@ -8713,6 +8713,9 @@ key_vnet_destroy(void *arg __unused) } SAHTREE_WUNLOCK(); + /* Wait for async work referencing this VNET to finish. */ + ipsec_accel_sync(); + key_freesah_flushed(&sahdrainq); hashdestroy(V_sphashtbl, M_IPSEC_SP, V_sphash_mask); hashdestroy(V_savhashtbl, M_IPSEC_SA, V_savhash_mask); From nobody Fri Aug 30 14:08:53 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WwKkt1fKnz5Mf9T; Fri, 30 Aug 2024 14:08:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WwKkt10vvz3wrF; Fri, 30 Aug 2024 14:08:54 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725026934; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=UZ6vd1shil5mM6hPBA4+p9jxE+tMBiHIYm59VDj2nKE=; b=ujNnc6mMQNWp1WgvS2BQt8/hfYYqVQDStaGiYk9cmLZPIjGaBXzofOcoQIVbHoTBfuFZyp ak1YxfulZqEejC3d5puRy/J/+p70LN4l10g/FATU5tbJP1rkJFf7QEXpi9+aHhrQEB5tZm 8sMYQPXkmXV4AHGk4iTWstCaLoEtIUtb9fYbFdO2sDO/bmgDFXrpgXk1Z1uxOMx22md2s+ yEqdWq4r0Z/Nnymh/6Hvc6KEDNtD6yKiUJxZEf3bP/RplgYoOJBI8yHf0bMNKmggLGlQbW XXeyg3ehly8p0dkojLKwZsLIuAw1A8WSLiGwpDabsarfYkNpu6PeVxCSGBDByg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1725026934; a=rsa-sha256; cv=none; b=MSnbZv7H3IS4zzxaz9NgZFPMXir2CIghVtlWWN16ZF5o+safbuQ5n5mooA8ceFPuIruxAK KZNCYkuRTlqSHhCUeM4kPSvYZTdN2DXQf6R6IVVhN/XCaASrTB17HrtYQpetZVl+KMbxSa 06fJd8FVgcsYPOUXa2NAL0d2+89V0mSRpKWHgeUwmJY372oHlb2WZHrm66CWIjdHpFWpF5 dm1fNYP3xdRwcalfhVDscs56Gbd7t6R1wg6B8jHVEic/ClUKAN0Y+bn+bF1Qun6FFCuca+ lhyb2XqAx/CICMQZnbuP0gvmgufGy9ePjhTj8fnf4zzquEKMdCPfBye7LrY+Kg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725026934; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=UZ6vd1shil5mM6hPBA4+p9jxE+tMBiHIYm59VDj2nKE=; b=VKYzTgwREDvNtiCMAgBj/5zJfs0bFpjWd3fk9Xp2hcuaaPmvQATYd5l40bSYU3heTleXJm mykt1qYGF1CspKBRj9co8J0FDa0qQBsNRcGDZwlEWT8mXLNHacY6Ew9lKLTaSxbSSZ1tAX imA5nszP8fTFvsIgISL110aBA8bKj0xBT2xF+XPcelsOWpRfH+Xb7RPWjwcvApB24CDmaz 9iYSGp+mucWWWIYuJ8uww5aNwGTcpfpjvaWCi4f63wIypdRFSSpDcIoSy1EXoQCtDVGZDf uUdT0TygolDN+e6ZIwcrq4CtvQpcMKqoBP1Ew+HgxdrUwX4vQNvXns1KcuUeLw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WwKkt0YpGz144b; Fri, 30 Aug 2024 14:08:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47UE8r16023494; Fri, 30 Aug 2024 14:08:53 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47UE8rgh023491; Fri, 30 Aug 2024 14:08:53 GMT (envelope-from git) Date: Fri, 30 Aug 2024 14:08:53 GMT Message-Id: <202408301408.47UE8rgh023491@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Olivier Certner Subject: git: 06986e899972 - main - pam_xdg: Fix user xdg runtime directory's descriptor leak List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 06986e899972ac3a127ab2ab46196672d0e1e5b2 Auto-Submitted: auto-generated The branch main has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=06986e899972ac3a127ab2ab46196672d0e1e5b2 commit 06986e899972ac3a127ab2ab46196672d0e1e5b2 Author: Olivier Certner AuthorDate: 2024-08-13 21:04:09 +0000 Commit: Olivier Certner CommitDate: 2024-08-30 14:08:14 +0000 pam_xdg: Fix user xdg runtime directory's descriptor leak Fixes: 6e69612d5df1 ("pam: Add pam_xdg module") MFC after: 3 days Sponsored by: The FreeBSD Foundation --- lib/libpam/modules/pam_xdg/pam_xdg.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/libpam/modules/pam_xdg/pam_xdg.c b/lib/libpam/modules/pam_xdg/pam_xdg.c index 2c80f0a0332f..10c6467776a3 100644 --- a/lib/libpam/modules/pam_xdg/pam_xdg.c +++ b/lib/libpam/modules/pam_xdg/pam_xdg.c @@ -108,6 +108,7 @@ _pam_xdg_open(pam_handle_t *pamh, int flags __unused, goto out; } } else { + close(rt_dir); /* Check that the already create dir is correctly owned */ rv = fstatat(rt_dir_prefix, user, &sb, 0); if (rv == -1) { From nobody Fri Aug 30 15:01:10 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WwLvC0mXrz5MjnC; Fri, 30 Aug 2024 15:01:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WwLvC0GZQz42Ml; Fri, 30 Aug 2024 15:01:11 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725030071; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=B6tTmhTCn/oVmmmhpT4t5UbB+1HyOT52BmP8Xi9D6is=; b=MtuY5gbfzzJWW2WDy/MwPo6aUaDvEImKOAFL5LzQFa+6SvgC5nn/nfogkyLK3GkfdrIsjW 9fg5sPrIAfD3D3BznuKc6wt5UdDkEl1fFju1xm9sh4Wwp0qhjaiRkLajwg6drEGtHJ3Tiz aD8YMQ84yS8OE0hy3be81Ws3IOmCuLMMFuIBSe1cW8euzcEoRyT3yMUMWjhnwNJgfuEUBp Iz0XQA8DrzsMb1Y6Bdv42Txh2ECVTcs5Ubp0S0cSqmXqvTu4EwTXolKNdiRGUR8P3OgR2q G7dwbSk6KB98mzDcYMFg/WG28H1dCGHlNj+Pe9teEYlBa5uBPiu5E7mZ5tgEHA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1725030071; a=rsa-sha256; cv=none; b=FhAdxzC+sruIXJfZ0tKmglRwv+gYBRaWzwSQgFzCunyQq078LKeYX7YkghulGN6W3I2q8/ u50N6HTu8ERpocX8k0ynkt/epskfDYxbxfrL/UxXaEBoJWZNCnS6cmpqMsbfBX9V3yTb5t gsqPbQgMGo18v7NLWRUkQ+I2Jg3ya+z3gggeBfWZyZPEwkkhebqB8hP6pJny8ktGGIq+bA 0ShX5VAmQgM3hwWc5MPQTtp8wj52uWR3dgNAk5ya/05JjcgAwpcm+AT0DHxxI/xNhFs9wW B6h+xg2dm26BpwuG7DaUXfj7Vf7laqsGKV8jS5cmMS5i1wyTmkoQJ4lci7GEeg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725030071; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=B6tTmhTCn/oVmmmhpT4t5UbB+1HyOT52BmP8Xi9D6is=; b=o0cBfDbHF95x9YoluiR5EdyygE3AThBJoe/UNS/66tf6+M+xJQniLxQhH/JbPW95IJslUi 55dbpDC0L9Q3uPfsTBCwzPAi6abG4y0zqTtkz4Zle7ypK8HJtbUCb/R0rAavEi0N3AyK0+ eU2zSuO4BME3Y2C9lw+VX2MvMxUwNQDI6XpteoBcwR7oT+WoYo8409bsjcYdD5oNPYbPuu jMZc2JDMzeMklxctjGIUpRa28njHevGmlOQwfMHm4o1W9hJiO//PlOmuig/MsobuY4V903 kCthlWCwlmVKmB1RtU3xI8O6NgnQMqZ3DLxBFp6gFHPCFszCRqG8sj0XtBvniQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WwLvB6zvTz14xq; Fri, 30 Aug 2024 15:01:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47UF1Ar8018859; Fri, 30 Aug 2024 15:01:10 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47UF1Arg018856; Fri, 30 Aug 2024 15:01:10 GMT (envelope-from git) Date: Fri, 30 Aug 2024 15:01:10 GMT Message-Id: <202408301501.47UF1Arg018856@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: 28294dc92476 - main - Revert "ipsec: Drain async ipsec_offload work when destroying a vnet" List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 28294dc92476031a3ce5228501f1429192cb3c8f Auto-Submitted: auto-generated The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=28294dc92476031a3ce5228501f1429192cb3c8f commit 28294dc92476031a3ce5228501f1429192cb3c8f Author: Mark Johnston AuthorDate: 2024-08-30 15:00:16 +0000 Commit: Mark Johnston CommitDate: 2024-08-30 15:00:16 +0000 Revert "ipsec: Drain async ipsec_offload work when destroying a vnet" This change can cause a deadlock in some cases, since it's possible for VNET teardown to happen in the context of taskqueue_thread, and ipsec_accel_sync() drains taskqueue_thread's work queue. This reverts commit e196b12f4d4d13982d42cf7841b77dca1405effa. --- sys/netipsec/ipsec_offload.c | 2 +- sys/netipsec/key.c | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/sys/netipsec/ipsec_offload.c b/sys/netipsec/ipsec_offload.c index 1ff91ec585c2..bbf98ac7a676 100644 --- a/sys/netipsec/ipsec_offload.c +++ b/sys/netipsec/ipsec_offload.c @@ -386,7 +386,7 @@ ipsec_accel_sa_newkey_impl(struct secasvar *sav) TASK_INIT(&tq->install_task, 0, ipsec_accel_sa_newkey_act, tq); tq->sav = sav; - tq->install_vnet = curthread->td_vnet; + tq->install_vnet = curthread->td_vnet; /* XXXKIB liveness */ taskqueue_enqueue(taskqueue_thread, &tq->install_task); } diff --git a/sys/netipsec/key.c b/sys/netipsec/key.c index ad1d6164f158..5a3e5727bc2e 100644 --- a/sys/netipsec/key.c +++ b/sys/netipsec/key.c @@ -8713,9 +8713,6 @@ key_vnet_destroy(void *arg __unused) } SAHTREE_WUNLOCK(); - /* Wait for async work referencing this VNET to finish. */ - ipsec_accel_sync(); - key_freesah_flushed(&sahdrainq); hashdestroy(V_sphashtbl, M_IPSEC_SP, V_sphash_mask); hashdestroy(V_savhashtbl, M_IPSEC_SA, V_savhash_mask); From nobody Fri Aug 30 15:33:06 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WwMc252bJz5Mlx5; Fri, 30 Aug 2024 15:33:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WwMc23Kjbz4648; Fri, 30 Aug 2024 15:33:06 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725031986; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=X4ZX6GBGOnXRS6DhqlVmi+LUG1v7+tXeJceeyJPfnKE=; b=OFIkuFkauc7lQvJlSZz8vZxvy6pP6khTJekCmLm6HEwM5Mu6E6GbhEZuR2a9MkMlynxx/5 UkimctMSrJRpzfLX97H50YYrKSRq2lVKwWhlaqLhgTH6ppEMAlzgNs/FkKmVDRKZ+y4sg9 9LOJ8I540nGa/iuvi4Abp5br1ODFsFA4EN58AhvWYyAq+b6LRMu+CtFZkkY58JJFEPsbYT 2h1RavfE53Wuj/Z4wSG6qScsVrmNG6kis/2prYi1UNSsNryW6cuWRft5oQtHvS+DKLjn/V rxIFK1gu5DYgsTeNEphhPg/f9lVAU9MuvexeZKSJm/1LVBq+yaGkurzkkGPkhA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1725031986; a=rsa-sha256; cv=none; b=B2WQU3h7GkdyRnPfWYQhZ/Jw9lolt3CcWgqdUnpPptyyUPQNUDZCtrIQTom/ViVDfy190E FcRugO+r8Rq8siKHPMQSI+SW/KFuRpWQum8Dq2+daHbuzlIHaAppOfd4I/cVWDXv7laJLf VX4Qu96mPg5UVpSD1WuKBPqgYxQV8oTD1jD2+o6b03U8KxomJ4E6OTdHbyYBPVtTeQHJIW 38ZNapY4nwtE7eJp0ez91horfR3xxei+HEGa82JMZtC8Uu8Wi2va3ppcjuK7b0yYFcfIVz nfcIRY8w6zoOHobNomimJ8boB6abUMvQiII8ps1EovFY8KY1qRokkTUloAfl3A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725031986; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=X4ZX6GBGOnXRS6DhqlVmi+LUG1v7+tXeJceeyJPfnKE=; b=EFYN6bUvpMqVxrihHiEfT0yxVtT/+AoQq7AnRwnh0DJv98KAQRAy4MgXegti9tuTTxTAs1 PfBRUCWF1oXFdLCC0EPXARL0AEyegVsS2cfCYK/0Rg/IOhU3pKGJVzavTcG4Sfy+4Dk5ge lwPtqaRFzb1CGPWhlwIKCkR+bI8EkiTG3c02ckuQlZs7HEsxTGSbUmPr9I+Nt+DvLeYuix BBaTGfADqEq4U6gksQ2xtzDP6Ag+4dQkF6X6qZgUCHFgtU3WYSFj/F6RsplNjvZgUb0fYF ZbfJ5/OPxp8I3gyL8JqLS+lF5drWcqhfurx/TwQeQIlISztuP/2h+qhhVpUP1w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WwMc22cdcz15vZ; Fri, 30 Aug 2024 15:33:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47UFX65n074879; Fri, 30 Aug 2024 15:33:06 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47UFX640074876; Fri, 30 Aug 2024 15:33:06 GMT (envelope-from git) Date: Fri, 30 Aug 2024 15:33:06 GMT Message-Id: <202408301533.47UFX640074876@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Navdeep Parhar Subject: git: 9fdb683d92b3 - main - cxgbe/iw_cxgbe: Fail early in some callbacks when the RNIC is stopped. List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: np X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 9fdb683d92b36cbd20bbd8d61f0c1138f8348dd4 Auto-Submitted: auto-generated The branch main has been updated by np: URL: https://cgit.FreeBSD.org/src/commit/?id=9fdb683d92b36cbd20bbd8d61f0c1138f8348dd4 commit 9fdb683d92b36cbd20bbd8d61f0c1138f8348dd4 Author: Navdeep Parhar AuthorDate: 2024-08-30 00:23:16 +0000 Commit: Navdeep Parhar CommitDate: 2024-08-30 15:31:45 +0000 cxgbe/iw_cxgbe: Fail early in some callbacks when the RNIC is stopped. Stop allocating new resources when the RNIC is stopped but continue to allow previously allocated resources to be freed. Note that t4_tom's uld_stop tears down all TOE connections, including those being used for iWARP, and that triggers the cleanup of iWARP resources. Fail post_send/post_recv early too to avoid the SQ doorbell. MFC after: 1 week Sponsored by: Chelsio Communications --- sys/dev/cxgbe/iw_cxgbe/cm.c | 2 ++ sys/dev/cxgbe/iw_cxgbe/cq.c | 4 ++++ sys/dev/cxgbe/iw_cxgbe/mem.c | 3 +++ sys/dev/cxgbe/iw_cxgbe/provider.c | 2 ++ sys/dev/cxgbe/iw_cxgbe/qp.c | 7 +++++++ 5 files changed, 18 insertions(+) diff --git a/sys/dev/cxgbe/iw_cxgbe/cm.c b/sys/dev/cxgbe/iw_cxgbe/cm.c index d8def446d6f0..d291eeeb4f40 100644 --- a/sys/dev/cxgbe/iw_cxgbe/cm.c +++ b/sys/dev/cxgbe/iw_cxgbe/cm.c @@ -2602,6 +2602,8 @@ int c4iw_connect(struct iw_cm_id *cm_id, struct iw_cm_conn_param *conn_param) CTR2(KTR_IW_CXGBE, "%s:ccB %p", __func__, cm_id); + if (__predict_false(c4iw_stopped(&dev->rdev))) + return -EIO; if ((conn_param->ord > c4iw_max_read_depth) || (conn_param->ird > c4iw_max_read_depth)) { diff --git a/sys/dev/cxgbe/iw_cxgbe/cq.c b/sys/dev/cxgbe/iw_cxgbe/cq.c index 9339d083cae3..197f2bcf8af0 100644 --- a/sys/dev/cxgbe/iw_cxgbe/cq.c +++ b/sys/dev/cxgbe/iw_cxgbe/cq.c @@ -106,6 +106,8 @@ create_cq(struct c4iw_rdev *rdev, struct t4_cq *cq, struct wrqe *wr; u64 cq_bar2_qoffset = 0; + if (__predict_false(c4iw_stopped(rdev))) + return -EIO; cq->cqid = c4iw_get_cqid(rdev, uctx); if (!cq->cqid) { ret = -ENOMEM; @@ -1037,6 +1039,8 @@ int c4iw_arm_cq(struct ib_cq *ibcq, enum ib_cq_notify_flags flags) unsigned long flag; chp = to_c4iw_cq(ibcq); + if (__predict_false(c4iw_stopped(chp->cq.rdev))) + return -EIO; spin_lock_irqsave(&chp->lock, flag); t4_arm_cq(&chp->cq, (flags & IB_CQ_SOLICITED_MASK) == IB_CQ_SOLICITED); diff --git a/sys/dev/cxgbe/iw_cxgbe/mem.c b/sys/dev/cxgbe/iw_cxgbe/mem.c index 348cd3985e87..4a1adc118b7c 100644 --- a/sys/dev/cxgbe/iw_cxgbe/mem.c +++ b/sys/dev/cxgbe/iw_cxgbe/mem.c @@ -621,6 +621,9 @@ struct ib_mr *c4iw_alloc_mr(struct ib_pd *pd, php = to_c4iw_pd(pd); rhp = php->rhp; + if (__predict_false(c4iw_stopped(&rhp->rdev))) + return ERR_PTR(-EIO); + if (mr_type != IB_MR_TYPE_MEM_REG || max_num_sg > t4_max_fr_depth(&rhp->rdev, use_dsgl)) return ERR_PTR(-EINVAL); diff --git a/sys/dev/cxgbe/iw_cxgbe/provider.c b/sys/dev/cxgbe/iw_cxgbe/provider.c index 729733a040d5..511caa436969 100644 --- a/sys/dev/cxgbe/iw_cxgbe/provider.c +++ b/sys/dev/cxgbe/iw_cxgbe/provider.c @@ -231,6 +231,8 @@ c4iw_allocate_pd(struct ib_pd *pd, struct ib_udata *udata) CTR4(KTR_IW_CXGBE, "%s: ibdev %p, pd %p, data %p", __func__, ibdev, pd, udata); rhp = (struct c4iw_dev *) ibdev; + if (__predict_false(c4iw_stopped(&rhp->rdev))) + return -EIO; pdid = c4iw_get_resource(&rhp->rdev.resource.pdid_table); if (!pdid) return -EINVAL; diff --git a/sys/dev/cxgbe/iw_cxgbe/qp.c b/sys/dev/cxgbe/iw_cxgbe/qp.c index 3aab07755101..0e374bc961c4 100644 --- a/sys/dev/cxgbe/iw_cxgbe/qp.c +++ b/sys/dev/cxgbe/iw_cxgbe/qp.c @@ -138,6 +138,9 @@ static int create_qp(struct c4iw_rdev *rdev, struct t4_wq *wq, struct wrqe *wr; u64 sq_bar2_qoffset = 0, rq_bar2_qoffset = 0; + if (__predict_false(c4iw_stopped(rdev))) + return -EIO; + wq->sq.qid = c4iw_get_qpid(rdev, uctx); if (!wq->sq.qid) return -ENOMEM; @@ -785,6 +788,8 @@ int c4iw_post_send(struct ib_qp *ibqp, const struct ib_send_wr *wr, qhp = to_c4iw_qp(ibqp); rdev = &qhp->rhp->rdev; + if (__predict_false(c4iw_stopped(rdev))) + return -EIO; spin_lock_irqsave(&qhp->lock, flag); if (t4_wq_in_error(&qhp->wq)) { spin_unlock_irqrestore(&qhp->lock, flag); @@ -920,6 +925,8 @@ int c4iw_post_receive(struct ib_qp *ibqp, const struct ib_recv_wr *wr, u16 idx = 0; qhp = to_c4iw_qp(ibqp); + if (__predict_false(c4iw_stopped(&qhp->rhp->rdev))) + return -EIO; spin_lock_irqsave(&qhp->lock, flag); if (t4_wq_in_error(&qhp->wq)) { spin_unlock_irqrestore(&qhp->lock, flag); From nobody Fri Aug 30 15:35:03 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WwMfK2z9Qz5MlxB; Fri, 30 Aug 2024 15:35:05 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WwMfK2RfRz46bR; Fri, 30 Aug 2024 15:35:05 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725032105; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3scL+nuvotNO5Lj1CmPp2XYw8cHT5+XEFOjt7WAaoH8=; b=RY6yhvYt1HrvLYgDYLRoXHI1AY+dlBh3YbBesbRWG4inAyLQYnIOjf2zu3Ppr6tCw3jN+i XaJibfHb5OUyGZ4Ng3is9RIH3w5AunE3MWcYWzF0kBDXT17JeLyS1TzvBmKmhUd0E/Ja2F O61LaZThwAoTg189Y692uswToqLpyNFNCSFQQDvFHMRsUwmP352VtBRD1UlzFM4jsBNznI 8hEs38M8RNKW+j9gabliWds4bSeMMKHFyuaw9uQ9kZ8j5em8qdLARCCC3exz/mp2X2nh+1 fSR2dUjJv9DsTfCH0+IcFCg6KMnnPBC90NOImrJCT295ySb1oX62qqKsnr5Mpg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1725032105; a=rsa-sha256; cv=none; b=dIr3xmZawFXVfhC7LrriIN4jllBXQIahf3aS0fcv7InY6TCIzbQboPThqLUfVoagZNxu+6 kgkgbPCVQ4IAdxmJ4cwoioJTGNdnrFpiDkLBAW5VNNvSeP+Ugzgx4HOotm53LOukfEQUzn /Ty2Ve85Z39WfwxN7jrpDnn30rhU93nGp9BzkDGlKZ1q2MsmRZ/uuJumORAfPFXj2xnqdH oJG3p+YyDPN/HmAwYrnM0kOkJVs6V+eFYoVT3F2Szr89roSFWywE/tl0niArHVjhMVVEn1 Eyg5xsZ/vOr2PmkZ49PvcXvw0MNUQb1r019lYWcS9JzKlZ+OGa7nyYfvTkHm+Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725032105; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3scL+nuvotNO5Lj1CmPp2XYw8cHT5+XEFOjt7WAaoH8=; b=sIrSaCmvWYQgSHFu2dULJyIaC8TXuJwxuXmaiWBkKSVd2MrsaJlEE6glC5z41HhOmEO6t6 RQ6dadiJ5oew2ZfqHtt4LuKPHxeDj1RrXVu4ypibWN2T7v86qVdJ9TyTmZMCA9VaWh+1Hb Kqwr8SUVLTUchT2XkWOBk8AfsioFAHNtbCiHvDsGkmf9raN+ninVBrr3JlShXLUW6XupHL s0hAPGZFLsdR3ht59goerbshx1WGJ/SPQioMI+dXYEgCr8Aw+kl7A4bcCaKOzBZg2gqamG +ZsjIh37Jo3A0CSEO8SW4C11ShIuONb06HoMs5BBNzJ9j1X9J4nnDIQyymh6qA== Received: from [IPV6:2601:5c0:4200:b830:d8b0:c858:39e:16a2] (unknown [IPv6:2601:5c0:4200:b830:d8b0:c858:39e:16a2]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4WwMfK0MJxz18jw; Fri, 30 Aug 2024 15:35:04 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <8a9faa7c-1f81-4aa8-adac-a6f07d7d73ff@FreeBSD.org> Date: Fri, 30 Aug 2024 11:35:03 -0400 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 43e8849bc294 - main - conf: Enable BTI checking in the arm64 kernel Content-Language: en-US To: Andrew Turner , Jessica Clarke Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" References: <202408200902.47K92BsJ078096@gitrepo.freebsd.org> <77cbcd47-1778-4e71-b824-4e75e0e4b2d6@FreeBSD.org> <19DBDC11-EB0F-48C0-9AAE-9EED087F0AB6@freebsd.org> From: John Baldwin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 8/30/24 04:55, Andrew Turner wrote: > > >> On 29 Aug 2024, at 17:02, Jessica Clarke wrote: >> >> On 21 Aug 2024, at 15:28, John Baldwin wrote: >>> >>> On 8/20/24 05:02, Andrew Turner wrote: >>>> The branch main has been updated by andrew: >>>> URL: https://cgit.FreeBSD.org/src/commit/?id=43e8849bc29414036ccaef7788de95a07ad32ab5 >>>> commit 43e8849bc29414036ccaef7788de95a07ad32ab5 >>>> Author: Andrew Turner >>>> AuthorDate: 2024-08-19 12:59:49 +0000 >>>> Commit: Andrew Turner >>>> CommitDate: 2024-08-20 08:49:15 +0000 >>>> conf: Enable BTI checking in the arm64 kernel >>>> To ensure new code has BTI support make it an error to not have the >>>> BTI ELF note when linking the kernel and kernel modules. >>>> Reviewed by: kib, emaste >>>> Sponsored by: Arm Ltd >>>> Differential Revision: https://reviews.freebsd.org/D45469 >>> >>> This has broken two of the GitHub CI actions using clang 12 and clang 13. >>> Please fix this to be conditional on a supported linker version (or perhaps >>> add a new linker feature to bsd.linker.mk). >> >> This is still broken. If it’s not fixed promptly I will just revert >> this change; we can’t leave CI broken, especially when it gets used to >> test GitHub PRs. Please stop breaking building with older toolchains, >> this isn’t the first time it’s happened. > > See https://github.com/freebsd/freebsd-src/pull/1393 and https://github.com/freebsd/freebsd-src/pull/1399 I do think we probably want to flesh out a bit more what kind of policy we want for the range of compiler versions to support. E.g. in the GDB project the policy is something like "will not use a version of C++ newer than a compiler from 10 years ago" (IIRC). There they will also look back to whatever LTS distros are active and what is the newest compiler that can be installed on those LTS via the equivalent of ports. Traditionally we used to only support compiling FreeBSD N on FreeBSD N-1 (though we have often supported older versions of FreeBSD). However, we now also support cross-compiling from Linux and macOS, so we probably want to widen the support base a bit. I would say a first stab perhaps is that main and any supported stable and release branches should be buildable on a host running any of those versions. That is, FreeBSD 13 is still supported so we should keep main building on it directly without requiring a jump to FreeBSD 14 first. Once 13 EOLs then we can stop supporting 13, and that would gives folks on 13 a way to step up to the supported version of 14 at the time of the EOL. That said, presuambly fairly recent versions of LLVM (and GCC for that matter) will be available in ports for supported versions, so that doesn't necessarily require a very wide range of supported compiler versions. Supporting the "native" compiler on those releases would be a nice goal that I think is probably achievable with minimal effort. Today our oldest supported release is 14.0 which shipped with clang 16, and 13.3 shipped with clang 17. Both of those are quite a bit newer than clang 12 that is current oldest version in CI. I have no idea what version range might be sensible for Linux and macOS. Presumably we'd want to settle on some range of ubuntu LTS versions and whatever is the newest version you can install on the oldest LTS as the minimum. clang 12 might have been used in 13.1 (not mentioned in the release notes, 13.0 used clang 11, 13.2 used clang 14) and 12.3 (12.4 used clang 13, 12.2 used clang 10, 12.3 didn't mention it). I know CHERI LLVM is still on LLVM 15 (though moving to LLVM 16 soon, but Morello LLVM is 14 still I think). libc++ is also making this more complicated as they are providing very little compatability at all. They've already ripped out support for GCC 14 I believe, so you can't build current libc++ with a released version of GCC or something crazy. -- John Baldwin From nobody Fri Aug 30 16:03:52 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WwNHY1j7Zz5Mp9R; Fri, 30 Aug 2024 16:03:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WwNHY14Pwz4BLK; Fri, 30 Aug 2024 16:03:53 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725033833; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=h6jT3QAZEeMl1IepwmQIffB0hmH/3vSTPuHVwGZfDKQ=; b=g6kSslvMbzszh3g1uxOy9d4WCSMHH1WrRZBuPFtYPtolFrhM+de/tVPEB4bz51l0AWqyVb 48Ogty5+LkJnw0m5Uy5YVQk0QOcILtqcdfg4lGhI+JiNr+K6T9asDUcdEpPD7Lf+kdUnp7 IL0cT2Ym98dyP6dAqx8p4vhIJyFFXAIzj4SyTA23xkQTjAAhrl8B54AixQvFuTYbMSipB6 6Rz5obcUb9YtwFVSkaJ3Rk0hN71SFpVoB9mw+FgVb2eJoIpiC5sum6BHZRQwfpPegAmvTB bf2jcGhCeWHDHtSNMdTdmlEIepyHKa7PqYXiPBlOm6T9zyxTI5UPs9jlTaZoYg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1725033833; a=rsa-sha256; cv=none; b=xn/JDtMpszLPr2+vzuLWyrGMqVIZCVv11RYt03kaPS1Phya4wDdXLb3L4yuiUwmP9VJDos PK/qVtV97IduHoR8ipxxWWgZ9lFCfqsUVxoIcfgtPBfsEQtmogTuERT0qnOH/lH/0ppA/r Pqw2T6/6jES9AOyZYchgKlKbvC8sEmZ1AUzMpYJGyt7fuhB9Pd5PF9ccUmHop6WBDpZ2jn Ho1pwfKBBN+d/uvMiv6bqiYl8ZRqmu9DN4yUubc8FontAiBtKrUCdsFGOt6ZXdm0/yet4S aE8RRq6gEsIc+Hgmd64unNEIf8eBjarNaSUgCAV2H8//94/8ayN/HdZnphZvMQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725033833; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=h6jT3QAZEeMl1IepwmQIffB0hmH/3vSTPuHVwGZfDKQ=; b=c3ArKXxfJLYeaWSSWV01mRPgzVcbmIMZsqHJQW2poxG/zAYm9wQz4zhKidHSK0wbZC7/YZ D4whpEF56nAy0+mzOn0Le2P5KJain4AOjuBxmfoMH8ZX8t1y2hTWwzStyrHj/YMbn80pEO F6Vj7d3io1oBUP3jI6dBaA2T0v/DX1bFj631K/J4GFXOAfseUfZw1ctFxZvKh825FX04i3 NvB/2aOFmQfmRYNQ1YmB9DLm15VVHDoqD6Nt5lUUAdOHXtV0R2PukXobyvsmad2j/f8OZm tgV2SEbgVAuZbZNiXcRfnkjicWXfgOrsIeUih+0gd7T4jgCGO4wJsC9zxPkhAQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WwNHY0gRrz16PY; Fri, 30 Aug 2024 16:03:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47UG3qc0026499; Fri, 30 Aug 2024 16:03:52 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47UG3quf026496; Fri, 30 Aug 2024 16:03:52 GMT (envelope-from git) Date: Fri, 30 Aug 2024 16:03:52 GMT Message-Id: <202408301603.47UG3quf026496@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Andrew Turner Subject: git: 973bbdab4703 - main - mk: Add a BTI-report linker feature List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: andrew X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 973bbdab47035ebd16200c63d095904924dc44d9 Auto-Submitted: auto-generated The branch main has been updated by andrew: URL: https://cgit.FreeBSD.org/src/commit/?id=973bbdab47035ebd16200c63d095904924dc44d9 commit 973bbdab47035ebd16200c63d095904924dc44d9 Author: Jose Luis Duran AuthorDate: 2024-08-22 03:23:59 +0000 Commit: Andrew Turner CommitDate: 2024-08-30 16:03:17 +0000 mk: Add a BTI-report linker feature Add support for specifying how to report the missing Branch Target Identification (BTI) linker feature on AArch64. For: Kernel: bti-report on when the linker supports it Userspace: bti-report on when the linker supports it and BTI_REPORT_ERROR is defined Fixes: 43e8849bc294 ("conf: Enable BTI checking in the arm64 kernel") Pull Request: https://github.com/freebsd/freebsd-src/pull/1393 --- share/mk/bsd.lib.mk | 2 +- share/mk/bsd.linker.mk | 11 ++++++++--- share/mk/bsd.prog.mk | 2 +- sys/conf/kern.mk | 2 +- 4 files changed, 11 insertions(+), 6 deletions(-) diff --git a/share/mk/bsd.lib.mk b/share/mk/bsd.lib.mk index 575b521bea55..6e288b9cd4ce 100644 --- a/share/mk/bsd.lib.mk +++ b/share/mk/bsd.lib.mk @@ -99,7 +99,7 @@ LDFLAGS+= -Wl,-zretpolineplt LDFLAGS.bfd+= -Wl,-znoexecstack .if ${MK_BRANCH_PROTECTION} != "no" CFLAGS+= -mbranch-protection=standard -.if ${MACHINE_ARCH} == "aarch64" && defined(BTI_REPORT_ERROR) +.if ${LINKER_FEATURES:Mbti-report} && defined(BTI_REPORT_ERROR) LDFLAGS+= -Wl,-zbti-report=error .endif .endif diff --git a/share/mk/bsd.linker.mk b/share/mk/bsd.linker.mk index 0e9477284ea3..cceeadd05b94 100644 --- a/share/mk/bsd.linker.mk +++ b/share/mk/bsd.linker.mk @@ -11,9 +11,11 @@ # LINKER_FEATURES may contain one or more of the following, based on # linker support for that feature: # -# - build-id: support for generating a Build-ID note -# - retpoline: support for generating PLT with retpoline speculative -# execution vulnerability mitigation +# - build-id: support for generating a Build-ID note +# - retpoline: support for generating PLT with retpoline speculative +# execution vulnerability mitigation +# - bti-report: support for specifying how to report the missing +# Branch Target Identification (BTI) property (AArch64) # # LINKER_FREEBSD_VERSION is the linker's internal source version. # @@ -112,6 +114,9 @@ ${X_}LINKER_FEATURES+= retpoline .if ${${X_}LINKER_TYPE} == "lld" && ${${X_}LINKER_VERSION} >= 90000 ${X_}LINKER_FEATURES+= ifunc-noplt .endif +.if ${${X_}LINKER_TYPE} == "lld" && ${${X_}LINKER_VERSION} >= 140000 +${X_}LINKER_FEATURES+= bti-report +.endif .endif .else # Use LD's values diff --git a/share/mk/bsd.prog.mk b/share/mk/bsd.prog.mk index 74a653057bda..89534b21d0e7 100644 --- a/share/mk/bsd.prog.mk +++ b/share/mk/bsd.prog.mk @@ -71,7 +71,7 @@ LDFLAGS+= -Wl,-zretpolineplt LDFLAGS.bfd+= -Wl,-znoexecstack .if ${MK_BRANCH_PROTECTION} != "no" CFLAGS+= -mbranch-protection=standard -.if ${MACHINE_ARCH} == "aarch64" && defined(BTI_REPORT_ERROR) +.if ${LINKER_FEATURES:Mbti-report} && defined(BTI_REPORT_ERROR) LDFLAGS+= -Wl,-zbti-report=error .endif .endif diff --git a/sys/conf/kern.mk b/sys/conf/kern.mk index 079bd1173fad..00492584921b 100644 --- a/sys/conf/kern.mk +++ b/sys/conf/kern.mk @@ -143,7 +143,7 @@ CFLAGS += -mgeneral-regs-only CFLAGS += -ffixed-x18 # Build with BTI+PAC CFLAGS += -mbranch-protection=standard -.if ${LINKER_TYPE} == "lld" +.if ${LINKER_FEATURES:Mbti-report} LDFLAGS += -Wl,-zbti-report=error .endif # TODO: support outline atomics From nobody Fri Aug 30 17:24:34 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WwQ4g1sYtz5MvHP; Fri, 30 Aug 2024 17:24:35 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WwQ4g1Cg6z4JDh; Fri, 30 Aug 2024 17:24:35 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725038675; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=SZ7fzrdLUJHCsMc0v2tICdzq8amavTk4dojuX9rRCvk=; b=nTy98ebQEcKyUB+S6JhChrU/6Tq3ovT0YfFAXowFlsr7Ua3ZITi50gyMIlt0Vu4Q1KnGlg tKBtBG+q8PDLAurur92DjDXQlwqrY3VOUwWrRlAVLjfksjiR32NGOMw1BeuJYUZhvvMt4j 0eN/GIpUvH0+dbcDYqKmieGaEciV2jQpBf6WhIRyy2gm/TaQN25HjATQEjLABqbKKNYd4l 9fWCh50bhLbrmcvkHH2qUdbPt1GwF+vNCFwR6k2YpR92WJEX4uhluxuK2OtKZDJvvWrSn2 ztpmkrtUQnABfLRKfL4QqGaoEXy9oX1XL4pUZx1HtD6ptncRcSaJ2eFTkJgMDw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1725038675; a=rsa-sha256; cv=none; b=ZvnKDHR/foDb2MHtY4q8MUvSiQu0xV19RVLedeuBAo43zC/AaKtoG8mvXOTpsckjAxFxKw 4VVKIWbN3ZVSxZ4YmyOfy6odp3NpZyzkhcozeuD3ELYKLIOR9K8OBcKGgwVFZ3rI69xhRc lyG09x/UmFMVPeONP2q4tlvnpbO3Q45E/XkDbTFOVOSfeJMjK3l7ISdRdLXDMkLu3+ltUS d8s9EMstrfSfpBn2pbFJPA/L0PDuuzMXbNgOKRtH3p5YcGhokUs0ydNR1sGNboOMthf9Al ZGqGzgy/rZCXgnGtIJ9IInhIKEFWL9xtw/R+dHv8lf5Wxl3opTUB38UdKFmTfg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725038675; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=SZ7fzrdLUJHCsMc0v2tICdzq8amavTk4dojuX9rRCvk=; b=O0/WIK6nj9aw6GOBMZMnDisGxIYxcyJSej6GxWRzb/P9+WXE61Yy5IPvaK2VWvuCaPHyS5 J3FrJz/WObOAbzCmaSbT57Z/MspUSR1QDywVr/WN4bhggZsrqcuFF8NXF0yW8cfvWpo+Jn uUNia9bmZHtPLv+8sQ5Nvlr2nAlABYtBY46KPf3HiUcxI6ilSwIQXAEZxSbD2u+ok1vf7u zutj8aY+55XU1oJmNPbVVDifirMRujCfbQdLU9fxsbSBkhR0aU9vUwtaY+nIdhJxkIfIFM Li/XLsZ0ZaplHZRnRiEihqsEk+t4YsWtkXKkxM4ZA42S8o/yYw+DnIE7US5Qvw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WwQ4g0h8Jz1801; Fri, 30 Aug 2024 17:24:35 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47UHOYRU061542; Fri, 30 Aug 2024 17:24:34 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47UHOYKR061539; Fri, 30 Aug 2024 17:24:34 GMT (envelope-from git) Date: Fri, 30 Aug 2024 17:24:34 GMT Message-Id: <202408301724.47UHOYKR061539@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Christos Margiolis Subject: git: 080c85127e3f - main - mixer(8) tests: Fix cleanup routine List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: christos X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 080c85127e3fba2c8cfb78cb75f7b306aee4028d Auto-Submitted: auto-generated The branch main has been updated by christos: URL: https://cgit.FreeBSD.org/src/commit/?id=080c85127e3fba2c8cfb78cb75f7b306aee4028d commit 080c85127e3fba2c8cfb78cb75f7b306aee4028d Author: Olivier Cochard-Labbé AuthorDate: 2024-08-30 17:23:29 +0000 Commit: Christos Margiolis CommitDate: 2024-08-30 17:23:29 +0000 mixer(8) tests: Fix cleanup routine The tests correctly skip if no snd_dummy neither mixer is found, but the cleanup is still called with the skip condition, which fails if there is no mixer. MFC after: 2 days Reviewed by: christos Differential Revision: https://reviews.freebsd.org/D46491 --- usr.sbin/mixer/tests/mixer_test.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/usr.sbin/mixer/tests/mixer_test.sh b/usr.sbin/mixer/tests/mixer_test.sh index e1321ad9ee13..45003251c460 100755 --- a/usr.sbin/mixer/tests/mixer_test.sh +++ b/usr.sbin/mixer/tests/mixer_test.sh @@ -66,7 +66,8 @@ set_default() restore_default() { - test -r "test_mixer_deflt_unit" && mixer -d $(cat test_mixer_deflt_unit) + test -r "test_mixer_deflt_unit" && + mixer -d $(cat test_mixer_deflt_unit) || true } atf_test_case o_flag cleanup From nobody Fri Aug 30 19:40:29 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WwT5V16W1z5PZbJ; Fri, 30 Aug 2024 19:40:30 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WwT5V0XrFz4YFw; Fri, 30 Aug 2024 19:40:30 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725046830; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=A12QntbDCs1nzzW6fBHNK0GseuHEJ7c+6vkTk3sawyI=; b=G8Msk2x0HoHr5h4IE3ua2DpXzluLG2aSXjRbISlot/fCfo8QPuzOysD8Lg9EbVbRVg+qIG kGphVxndVl8J6Y0NqMmOyJtELdWwbZF+rpegFHVS0qm/S0YZagOyizEduLJiv8Y6m2Qyz4 wDh8AfVQcLrBvjyJLyOuLUUk/XG++/Kk6AD1E9SBVxKHZ4vp28fqC5xQ4ItA/EFc2gyz7n FE22oPqIol1b3qBNkqVnTVKz9VxCG8Ou+IsnuEcyJS2cootNJXIGkb4UDEmRMVQ33CWeTs MpzfaDUiwlmDBy1R1O33F4Qn+sdGFpv/jmoaPPqsAGsNw08J9/id49DjFhc2Dg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1725046830; a=rsa-sha256; cv=none; b=Ov9Htqnh6Uqi8Y/+Uxcpdkxib0JERV6Qg5Cb7mF3HJDucCqS9zKlqO05dJ9kTfR7Y3qexU 95zKaRvOR+qMPFmCA8m+nrH7dnhJ66Fe5H9vj2FBGypj89qv8mKo1qdLkosmxVD7V+Y8ZA tphxVLb3VPfAGe4dShHH28KFgSJ0gTGs5F5uURWF0aTSlJHuaieTS8vhlYE7GRWjTrkTX/ Wxruyh1wDTkOjbCsBF3ZYprov+241Xvwsw//djeU9tF6xUKwbV3qMnii0ICwHiUf/7Sefu u7Yci0nuuVO9ZvTHpsv72CXBzWsmrLokbtTfmfqoxedHPrjAnXDjGr3wtpXNLg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725046830; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=A12QntbDCs1nzzW6fBHNK0GseuHEJ7c+6vkTk3sawyI=; b=kvN1ibND7wLIqbd1vZqP8QxeqysinfbkcFiIsxJ9D7thUK8R8a3Bur51F98cRzLXBWnWSv maSqexkBIfGP91UGXFEWmIDfkqmhziDSkThxcTvqKUO4CVUoaWhRHZRp6SPqGei2zW1cLl sQTcOq/w4BngjrmjYsenu9b+/xSQfbM0sGiT1wzv1SXy+hM6+mvPkBGNPveW62jGHotnYi ZeARled2UG0yyJOm3H9OJeNOOh4lP8utRBFxPRJJryV25cpgwkYolQZs8bX99QB3QbTNX5 pKDVKcyeeC41vp6uqwAsJ0lRQtmi7JUuvNruMwoWDoWLJ0h9Nj6c3TjzidB5Jw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WwT5V02T0z1CQW; Fri, 30 Aug 2024 19:40:30 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47UJeTl8090246; Fri, 30 Aug 2024 19:40:29 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47UJeTkg090243; Fri, 30 Aug 2024 19:40:29 GMT (envelope-from git) Date: Fri, 30 Aug 2024 19:40:29 GMT Message-Id: <202408301940.47UJeTkg090243@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mitchell Horne Subject: git: 38a08e45f194 - main - arm64: fix L1 pindex calculation in pmap_growkernel() List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mhorne X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 38a08e45f19447717726de4d41bd161f966d29da Auto-Submitted: auto-generated The branch main has been updated by mhorne: URL: https://cgit.FreeBSD.org/src/commit/?id=38a08e45f19447717726de4d41bd161f966d29da commit 38a08e45f19447717726de4d41bd161f966d29da Author: Mitchell Horne AuthorDate: 2024-08-29 15:25:52 +0000 Commit: Mitchell Horne CommitDate: 2024-08-30 19:39:56 +0000 arm64: fix L1 pindex calculation in pmap_growkernel() Use the pmap_l1_pindex() macro which accounts for the NUL2E offset. While here, use pmap_l2_pindex() macro further down (no change). Prompted by pull request and commit 2e33abc35460, making the change for the riscv pmap. --- sys/arm64/arm64/pmap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/arm64/arm64/pmap.c b/sys/arm64/arm64/pmap.c index 58795e25c82e..224ecbdc4577 100644 --- a/sys/arm64/arm64/pmap.c +++ b/sys/arm64/arm64/pmap.c @@ -2962,7 +2962,7 @@ pmap_growkernel(vm_offset_t addr) VM_ALLOC_NOFREE | VM_ALLOC_WIRED | VM_ALLOC_ZERO); if (nkpg == NULL) panic("pmap_growkernel: no memory to grow kernel"); - nkpg->pindex = kernel_vm_end >> L1_SHIFT; + nkpg->pindex = pmap_l1_pindex(kernel_vm_end); /* See the dmb() in _pmap_alloc_l3(). */ dmb(ishst); pmap_store(l1, VM_PAGE_TO_PTE(nkpg) | L1_TABLE); @@ -2982,7 +2982,7 @@ pmap_growkernel(vm_offset_t addr) VM_ALLOC_NOFREE | VM_ALLOC_WIRED | VM_ALLOC_ZERO); if (nkpg == NULL) panic("pmap_growkernel: no memory to grow kernel"); - nkpg->pindex = kernel_vm_end >> L2_SHIFT; + nkpg->pindex = pmap_l2_pindex(kernel_vm_end); /* See the dmb() in _pmap_alloc_l3(). */ dmb(ishst); pmap_store(l2, VM_PAGE_TO_PTE(nkpg) | L2_TABLE); From nobody Fri Aug 30 19:40:30 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WwT5W211wz5PZdw; Fri, 30 Aug 2024 19:40:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WwT5W15kvz4Xnb; Fri, 30 Aug 2024 19:40:31 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725046831; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=4EU3CaLsbXgNkum42fTKoO+ZaDTlY2t3mlMwCSP/aDs=; b=g0GVpD65rPxrcj/f/CNhzEqEmbsHDT3+0XYJDOHm+qeSUnh1wzvwesGZdTnROJR3NMOy6c EzqP8LKntHFpGx8x5MNiE9ddQHSb9E+Agx5KZZ7DweXfDfeFw1zg7aWYxrfQ8Wq0e9z8+A GPwFYxNv2PhKcO3EIMEIMsfeW5rWntNlb0kTYNkSDh4EFk3xkQ531MdiIhuifY4W0vSHoI d00aObL95f2O+9FhzgenAl661xbbZxjnTeRBVDRAlUev3L+zksnhyRutYNFtkrosb5xQlE e9v+R2+rfThhYbCgOJsefIgNZhRFNGaZO+Y4yHz2mXxRAsSFK9h+lF6xe8lMcQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1725046831; a=rsa-sha256; cv=none; b=wJECZWSjIMl9xLrDLGHN0Kr9zvNr92DAg6jwx6/tNll4sBFpy6vijLxvCiHjeDggCI8t8+ N1UprXyeM+PL1FO8FQ/IxwySG6jp3HeJ7J2iSkADM0Gq7Qtua23UexwFHTMHgEZOGbjeYs 0ZKMVMcKxkpgv2e+hCYQ3o028rjEGmGCqKF8+R5ZLrRoJ77cVlDMmxkt5MoFq/Z9PkzqAO 5amkO96H2ZWzA2weulDMCVSMgnCDfi1L3jMpo9xmCXHrsmtzOUtxOP7wzB+P4pnbnbnv+6 VnT5Kq25gdOVWUMd/exBAQId37uyewU112QThHnai7bamPybSyQ6bW4qkG5JgA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725046831; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=4EU3CaLsbXgNkum42fTKoO+ZaDTlY2t3mlMwCSP/aDs=; b=bnonAWHO72hVd5XYMnDU2DOWvea2aLLwH3zlti+fbL/TpZh8uEPcSsiDD15S767e1Z9MEh 3oVe3dbIlcc2sRxuF0eSj5JpmJ96FxcyQag+2EgdUVEV3MPOFB3d9fzMACuXUVQHu6AIFZ 2elooq1dM2Q3CYcCP4JjIO02wDNx+vtOKLyulHfrwnUYcsw6bPSa98GehuhQo4OfmB3d4a X+tRZmjGsR3bbdAVKHF3xJIqibda4DWKSqEIbcRQ5aHpl6woslOLXq4Pqs3Cy2jyUtaPQ9 MKupNEwDGspGJGUvHzMx0iOUPiviu6dqZ3mOtuwhDx7tA/Iqqh7Et584EwmZvg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WwT5W0jMYzDr1; Fri, 30 Aug 2024 19:40:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47UJeUt2090294; Fri, 30 Aug 2024 19:40:31 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47UJeULZ090291; Fri, 30 Aug 2024 19:40:30 GMT (envelope-from git) Date: Fri, 30 Aug 2024 19:40:30 GMT Message-Id: <202408301940.47UJeULZ090291@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mitchell Horne Subject: git: 9a3fa77585e5 - main - vale(4): refer to the valectl(8) management tool List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mhorne X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 9a3fa77585e55e78004cdc9467b986968a77e8de Auto-Submitted: auto-generated The branch main has been updated by mhorne: URL: https://cgit.FreeBSD.org/src/commit/?id=9a3fa77585e55e78004cdc9467b986968a77e8de commit 9a3fa77585e55e78004cdc9467b986968a77e8de Author: Tom Hukins AuthorDate: 2024-08-06 16:43:03 +0000 Commit: Mitchell Horne CommitDate: 2024-08-30 19:39:56 +0000 vale(4): refer to the valectl(8) management tool Signed-off-by: Tom Hukins Reviewed by: imp, mhorne MFC after: 3 days Pull Request: https://github.com/freebsd/freebsd-src/pull/1369 --- share/man/man4/vale.4 | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/share/man/man4/vale.4 b/share/man/man4/vale.4 index 77e4433d2742..a9f172e11fba 100644 --- a/share/man/man4/vale.4 +++ b/share/man/man4/vale.4 @@ -26,7 +26,7 @@ .\" distributed with 4.3BSD Unix. .\" $Id: $ .\" -.Dd March 6, 2022 +.Dd August 30, 2024 .Dt VALE 4 .Os .Sh NAME @@ -100,7 +100,8 @@ qemu -net nic -net netmap,ifname=vale2:c ... & qemu -net nic -net netmap,ifname=vale2:d ... & .Ed .Sh SEE ALSO -.Xr netmap 4 +.Xr netmap 4 , +.Xr valectl 8 .Pp Luigi Rizzo, Giuseppe Lettieri: VALE, a switched ethernet for virtual machines, June 2012, http://info.iet.unipi.it/~luigi/vale/ From nobody Fri Aug 30 19:40:32 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WwT5X4r4Pz5PZpr; Fri, 30 Aug 2024 19:40:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WwT5X2VRLz4Y5t; Fri, 30 Aug 2024 19:40:32 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725046832; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=qTLrnzbPN4/G4ffGEFQSUkBOvfVm3fjTgtJc3TkV+Mo=; b=nIgIEDXTru8YXuHiokDFU/TanVESA7dUMQNFxPw25za8LKO3QzZSOKrUFzpTTJGt182He0 KpACPOB/aeOreThC9YFyY5WEE+aRNONxrdOSw5TbDIGMpRilywj7n1jJQsph2gNBYdljAB VGkW4/ga/LTXDYqrsPECFsRULGOaepGX27jCWfKzOlo5IsN1v5E9rMOalfpTqF1M/lXnkX OUWf2ceOzamVa++QO/vjLYJdpCVqH4smEAWjjd9DetP46W1+kaOaP99t3XoyiNGX8zv+Fo l2XyQ/xjNxhTyIDpojllwnkg2+VU5pg8q4nRbOO3hkAawM4w4D6n90Gv+9wDhg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1725046832; a=rsa-sha256; cv=none; b=Hv66o0+azuB1IufufPmOEUDKg4HzsmNoG6Q87Z+VOEr5fqcycilABOkl6B3KkiVFeZwf+2 AdsHeBZLQdTSZoI6GwM+N61RoCAw5LIxQVTl0/nXeQBTNAn0jMC/dFsN6r7cbXSSfrp1zJ gsXe1gewU15GpU+Xu8U0tkJkAwbPMM7JPn5fGKnfLubHRxwJMvPVIU5+OLlF89HFIdmkGt 9GZI06Bfw5lmPqqlSGT5Ehk/EWKWPkpb9JQFCUCROduKQgZjsQXnGbto526VtKs9JDwUaQ azqZjIBb4bMy0F6OWTmdzHsEBXo4tAxhqks07b0xN29qellW+r/JCeeLIvZRLw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725046832; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=qTLrnzbPN4/G4ffGEFQSUkBOvfVm3fjTgtJc3TkV+Mo=; b=AJIrH6FTHomyeM5aaMtR+5DzEu+3vMz7DWkqFT5F4Ff25yDlj4sgbDx2rnEhkUY+2nLCcd SVranZDfuvKptcxS/KwoNuAT+dYA6yURqtbfkxS2U4ZSkYAZvhPpXvkVNbXpAaxp5wwiRO Dl9F2G9Wn5o/yfYqd525Qp+LScR+EXYVTEjqOqPysWdy1PUpeUEy385p0X81YIgAPcV5rp EsX5vHCIZYRrEvrsF0G+hWnL0rhIu0x00Vb1MMNlxWwFEVrWIRWTd2XGjd94tX28CrKMe3 I+yPk1MfAek2GpXo5Ea9SnBZOP4GJp/20eBpDCx81dYbM34HiC+lyIzJwN0UWw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WwT5X1jXkz1CKg; Fri, 30 Aug 2024 19:40:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47UJeWlx090336; Fri, 30 Aug 2024 19:40:32 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47UJeWlV090333; Fri, 30 Aug 2024 19:40:32 GMT (envelope-from git) Date: Fri, 30 Aug 2024 19:40:32 GMT Message-Id: <202408301940.47UJeWlV090333@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mitchell Horne Subject: git: a2f53837f0a8 - main - valectl(8): explicitly mention network switches List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mhorne X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: a2f53837f0a8934cfcf7ba3c1fdfc93f217d3703 Auto-Submitted: auto-generated The branch main has been updated by mhorne: URL: https://cgit.FreeBSD.org/src/commit/?id=a2f53837f0a8934cfcf7ba3c1fdfc93f217d3703 commit a2f53837f0a8934cfcf7ba3c1fdfc93f217d3703 Author: Tom Hukins AuthorDate: 2024-08-06 16:44:00 +0000 Commit: Mitchell Horne CommitDate: 2024-08-30 19:39:56 +0000 valectl(8): explicitly mention network switches Use the term "network switch" instead of the ambiguous term "switch". Signed-off-by: Tom Hukins Reviewed by: imp, mhorne MFC after: 3 days Pull Request: https://github.com/freebsd/freebsd-src/pull/1369 --- usr.sbin/valectl/valectl.8 | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/usr.sbin/valectl/valectl.8 b/usr.sbin/valectl/valectl.8 index deb660bb0e4a..805d785f52cf 100644 --- a/usr.sbin/valectl/valectl.8 +++ b/usr.sbin/valectl/valectl.8 @@ -22,12 +22,12 @@ .\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF .\" SUCH DAMAGE. .\" -.Dd April 2, 2021 +.Dd August 30, 2024 .Dt VALECTL 8 .Os .Sh NAME .Nm valectl -.Nd manage VALE switches provided by netmap +.Nd manage VALE network switches provided by netmap .Sh SYNOPSIS .Bk -words .Bl -tag -width "valectl" @@ -50,7 +50,7 @@ .Nm manages and inspects .Xr vale 4 -switches, for instance attaching and detaching interfaces, creating +network switches, for instance attaching and detaching interfaces, creating and deleting persistent VALE ports, or listing the existing switches and their ports. In the following, From nobody Fri Aug 30 19:45:14 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WwTC62KS6z5PbKD; Fri, 30 Aug 2024 19:45:22 +0000 (UTC) (envelope-from mhorne@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WwTC61pM0z4ZD8; Fri, 30 Aug 2024 19:45:22 +0000 (UTC) (envelope-from mhorne@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725047122; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=zPyCZX3Dg1ohRlsjGRYWKLUhFnjGSE6ldLM+/L0bSb4=; b=uYd/hC/GTFFkbCK9hdnv/kNljCzMQ1ptteLAjDJszfEVR+HCR1U4FqnhLaOsqBJ/GyMj07 x0JQEdbogACelf/wLES9xDWpDFDwhdATT8vDubbVxQ1sqsS1b3leV/Q0spf0uKwQL9UlDP kR7IZb4AIow92IRnO+dfeawYXp2VG1CS8wmF7nIx2Q2Q5TnZnJLXMI8OedP1w8XzCkQSdP MgdGWjjdT3NcTU52HU8LtOzEPjSO5dv5q4X+pC8dQ8dj31xkOKlEIm37jqhSBDdJRgUwAI Ha2iZMC79zY9ZxnLM4VfPd1jD1i6CVOhS4GrAkvFJuXnIR3gDlmgkGsh5rWu4A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1725047122; a=rsa-sha256; cv=none; b=fks3nKdxTuh6WANSMZ+I9yT2cWL9OeWCYiLi4Lnf7cTLOcD5OA77+y79O83IUcOcvIbyLw 9kuMd8haP8tO6vWB2oWXut/Rfd8W9FoRNGusCD5h79AOsKV6wptoE/QP0KxMjgIttEJX9G 5nv4t3ssSKNkWX37ZmYYGMlrgk0Za1yirGMm5HkMapxgyBH9Grd0RQ/EPAe5KsfOVQ1HIZ lWKG7qv/nhOXKpDmDHzkC86fQRb1M7JvD1A9U/mPvJygLiblN5bzQW5GDDvAWRndAi6pwt 8+RiIhrjJEeRLN/C0fn8q6jTLU//SspZxEAu7okO15T8cFrqXOK7OdD9hpYOtA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725047122; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=zPyCZX3Dg1ohRlsjGRYWKLUhFnjGSE6ldLM+/L0bSb4=; b=IQDegX5IPBCECOPyggBKEjMuOoALy0VfSBK5Cv99CVDma1n/37nR1NNEzEJbj0qNuteGLE u6MQ9/60Lt0BhOIVOccAZDUYtwM+1JN3G699McaRycQ7RBdS3fwAtLrzCtBqrs2CMjpbyM /ycNfG9SKvDyG2Ih2mdddmHL7P2Wfnf3dzDKnKQlpYqQHmUIcM2kCs0OBJ4wbChdMStrXC ykRZQ9p4FN1c36s+CVKNhU54ueGukYXW8y/7YrjQHZ1RpD0HzF4CHfkAXyMp/WK9FLc6tO nRG1J2+48rky0R2EGKp90c3FCZb9NiCc6KmnHCCDFS42RHK08zv0UC9E2nRzrg== Received: from [192.168.2.217] (hlfxns018gw-134-41-188-50.dhcp-dynamic.fibreop.ns.bellaliant.net [134.41.188.50]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mhorne) by smtp.freebsd.org (Postfix) with ESMTPSA id 4WwTC60LFtz1DC5; Fri, 30 Aug 2024 19:45:21 +0000 (UTC) (envelope-from mhorne@freebsd.org) Message-ID: <0edd6b5b-1a21-4101-9046-10e4955cf433@freebsd.org> Date: Fri, 30 Aug 2024 16:45:14 -0300 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 38a08e45f194 - main - arm64: fix L1 pindex calculation in pmap_growkernel() From: Mitchell Horne To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202408301940.47UJeTkg090243@gitrepo.freebsd.org> Content-Language: en-CA Autocrypt: addr=mhorne@freebsd.org; keydata= xsBNBFyS2dQBCADdiXBG8hBVLmYbxu7aSzbwLwUf3HkGFz3rooS1kwyy+SfmjZ4UKNnl9WMx WKrJ7OAZpiNH6bLQ5nsqfx09OnpWL8c/QuPbhNdUywQoqqYpRI0K8GEn//nS9Gs0KTYwVpWb XlrzP+jf3Uh/9L5mcQmStLIH4zaaqMYHW+pMuPrvBmLIHTvLj2QjOkxslrcUdord9uvxe5Ht LU8RuTpQpHOKz705Z9/v7twFdi2HtKzpLwO6SzVyu351di1J+GihsVpcT5josQV5cHbIP3Un x+kmtKBEEc/jl/zBglF7ruWUtwgbryID+2ZPEaO1Mj+RResX4LFVMusq3uUpWRb5WJXxABEB AAHNI01pdGNoZWxsIEhvcm5lIDxtaG9ybmVARnJlZUJTRC5vcmc+wsCUBBMBCgA+AhsDBQsJ CAcCBhUKCQgLAgQWAgMBAh4BAheAFiEEkp/cYPcfabAiQvACi/gnTOdUid8FAmIyDpUFCQtC z0EACgkQi/gnTOdUid8IsQf+N8IptrrCgifT5Z0/WUVFfnHThFOKf4zBjaGswsIM8+VKsKnF 15jCWHODUHP6s+dcQ4nQi81PHPsnMfBSkGPvN/X3ess2/1KUVkH+6tAJbqXDjXhD8HT+i0NM QEFIXlLnotpgIKW3yOHjKv3ZvKw9LCvUjyNY9vOJmLk/6AbbkFh+INo65nXtQWb/hM5FVEHW S+zUoU8AqZRJoVAQfj9wmIfg/HdsxeDGKL0zkv5AwKpccvb8VJNGJbCVMgoy5uQYcUeXxcie cg0VlbFLshNQTfyhVQ85vyuHahARrUWs/k8KiYODoBnW1ChtyF8yM6VZTzSYx7pINqPq2YZy i/Htd87ATQRcktnUAQgA3zt4M4ecoQqfxpjliNLujt9klDqvmkJvWmzMuMXdzlPgGRJ0doio 9YIeEdkOt6xN0pPTK/ReCZ8WqFQ8zo23u1pwGuo0CnR58XF19wyxyUuKu/PHbt+56mC8tNHm AXsMyXQmlDqWvn/WzLY7euNRtNS4QQIwtxfM5EC4GGa5KQwxn0kM7dkUSOE/cxr+/kNbHHzb gagZR4cnNUqtPPr3dYXcibCTzgz96Lyt3/qMLXX9RTBRzu+O6E+byxWOe8ar/ZlwY2b4wTQG mhgNttkSxKtxMpZnd8+DGV/bI1P5Ct/K2GeCwNyupQGON5ymn6o7jTch+qmFX0ItkBWO4zn4 9QARAQABwsB8BBgBCgAmAhsMFiEEkp/cYPcfabAiQvACi/gnTOdUid8FAmIyDtwFCQtCz4gA CgkQi/gnTOdUid/i5gf/aQ75pJR4TJFM2vVVr6PDIwTdl0b5EchB4w4s4g/zE84XNbMOQanb BginLYEhAacLQVAvM3XdvUEhwrhaMQdjdSEB1krResL3/mbxrtKwdHSMbHA3IS3XdvxFWTB7 P5JjUSPsW6hqgoidbn4w3OxaNHhs45H2b0Nx5QiKcSyepmCZuB52gCEHnEnrdaz8TFQMXOLq 94WbTmZeIjChW3FB61m1gTf0UEFjoZAfTAUB+pbwoCa4AykIeZnDC19vjsruVU9Gy5rLglwd bjsZNfXIJGOZNEvdF8FOBwM7DlXx7SYvTJcUNoNJjOKtQ0bYGVgGqYOB/y2mTjVuKeU0eOkN Uw== In-Reply-To: <202408301940.47UJeTkg090243@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/30/24 16:40, Mitchell Horne wrote: > The branch main has been updated by mhorne: > > URL: https://cgit.FreeBSD.org/src/commit/?id=38a08e45f19447717726de4d41bd161f966d29da > > commit 38a08e45f19447717726de4d41bd161f966d29da > Author: Mitchell Horne > AuthorDate: 2024-08-29 15:25:52 +0000 > Commit: Mitchell Horne > CommitDate: 2024-08-30 19:39:56 +0000 > > arm64: fix L1 pindex calculation in pmap_growkernel() > > Use the pmap_l1_pindex() macro which accounts for the NUL2E offset. > While here, use pmap_l2_pindex() macro further down (no change). > > Prompted by pull request and commit 2e33abc35460, making the change for > the riscv pmap. Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D46477 I pushed it slightly early by mistake, but the change is ready and so a revert seems silly. From nobody Fri Aug 30 20:22:14 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WwV1r02qXz5PdXV for ; Fri, 30 Aug 2024 20:22:24 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic312-24.consmr.mail.gq1.yahoo.com (sonic312-24.consmr.mail.gq1.yahoo.com [98.137.69.205]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4WwV1p4nYcz4d2j for ; Fri, 30 Aug 2024 20:22:22 +0000 (UTC) (envelope-from marklmi@yahoo.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=yahoo.com header.s=s2048 header.b=OlllHkGr; dmarc=pass (policy=reject) header.from=yahoo.com; spf=pass (mx1.freebsd.org: domain of marklmi@yahoo.com designates 98.137.69.205 as permitted sender) smtp.mailfrom=marklmi@yahoo.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1725049340; bh=qDlO0iGQoAsLrIqNAIngJjncFuiAGRgyK2aPqIMnIzM=; h=From:Subject:Date:To:References:From:Subject:Reply-To; b=OlllHkGrpT61HEoYIa/J6t8+CyOyvhnbaC9VJtd80kq3cIV5udhaDKfCjqGZpE7nu2K5QrGDqES+lfYtzXa/aI+Ghb9pXPbYlOBzcGICmyb4zvUQ+Ws5zkwr35GAVX+F/9UAXEG/qeMgen6xcX3kxoVfCU/3uOFh3qRph4hHvJ6uBq5UdplGq3Q9mwqhpbLDoNEwW4mJnmDdRNYUOTZCYudd9DHD4kYrAqqsfYLSigwO+fMABHoZ6NnhT/cmHOi45GpofZiDgvVFrS3eemTmBgWmsPa3N/QHIAnnOgHqBaDiDfbGlktcv8+6n7QdsF9CU3i0XSv1jVYt0UZG2o/2yQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1725049340; bh=RJKKLmJuIAAt6SiToQbXsfIpW/Lo1x3XYsNA3gfCcjk=; h=X-Sonic-MF:From:Subject:Date:To:From:Subject; b=mEWM0dBi9Zs9icv+QRQ/M1nBOZqGabw4s+pl3aHppR1Ro6GqTa5v1Mor3urCZQLEBLSlpqd9wtifG8K+ynZLeCfDVSsV+PTJit7iKBJH1MuEn063zQ+nStw83CLV2qVJyy9EJ89YOCTshO9GrvfWnseXleEqBSK27W0gyFkTJzvf9a0CbYBSB0sLasZmXDRITuuGMPgnwtah0Nmlxir7ML8bB9aYUvhlifH41TRb/qTRkZrtQeJdZ08tLhPIgVWSG+JqOarGXvkTmp3xZQcpB4IFHw1FFguvr12+ixbjbNMMqS4npQeTV+EEzbO2/weDb/X6OtLvOz8LbBFqN6m6AA== X-YMail-OSG: B8cvfJkVM1m7d4MDXgKCKpkJ1kHa3_Z2xO3RwVg7Ek9x8CJBcI4VMO17yx03sx9 lcLo8AMfZq0S6o6.g79nVm8SNlzgqRBbo9is74f5iJ5.tNrtyWrBUbna.F.BXLwQV_hLN98EMK41 sutiE6RwaWK5CJkdOnhzXCUOgVrPleWuMg0qsJFpVy_HHuHxBM1ZO9bJFR5KS5QuK4HT72euRiLd PwtuUIiKlYff0cnZG1jKAJaIoH04B_kuow2TXU_URtHfn4a9UMVh_H_d0b6GXEN1nfu8.06vHGJp gdOaN7YtebZwYXiw8NHJmiyKxUF7jiE2_4F7qJIUKep.jYTNz3LDADMmXhq72YfXUVn63cPPpsRF VmJqkVnQW36V2MWy6ExGopK3uNJFfneixnZVGXntnNJhEWJQW8X7VhlBaKDatXWO9IkyIX6tb2eP YRgz3jeZuwlbe4kAhuRWvd0NprHizFY5JtjmSVper8EPVti2ngiDqvl9LSnKl1t3mprBXdYmicnU UPsa2RDCn0HNXl8nELQiAv105902J97xjs7m.oLxzq7.uKhMNNEvYIFSSRGrelFdT5Oggn8pz_Li s6zqDARfS_KqfmqQQJ7oOnk85.UPbXraovXXewEi.aywziE.ohi99v5spzm3PeiNpUPDcdTEp1dk J_tIk.yIa6HejH56NuMOCVb6ny0v.l761c8II4oUje5YxvjYcZKAFcQxr7o596939tw1VhLXsJOU tlDdFZIL68Qpl_aFKxs1W_bx0yDEIUGLN901GAgYTvBMUgWNtHjTlx7pigBSFpOfcEroE6LRznc. cw8HW0Yi.DhpDAI0_9I6yE0ETdmpuF_dvqY5HWhlfX5yziiCym_4hnv.hFXRFccYs1nPsD9bry3Z mQ5NmiNubPrXuNP58rlk2WIinbZmtW_lhnuMg8FZuNWgNnrjjI4JD4XH77pKu4IocfRlz4VXeTwX Q9a9xvN6uRTNGISwsSpXuqh8nweLPRs1lqxfJYsbv0e6IDd9xD4qwWPFmTj4JD8QKUTM_OhVAr4P jq2CN7ArRfqGsqJR8It9WrJLMMGY.kiwWPVBLNZyndl0DLHU.GQr9qTBZHWaaqLJ.St8dWRWS_a6 afNIAIxm_oLImIVqUAzabm_U_TXqm4h4HLiOq5fC5ngZivIu2E2.j0PvYFNt6Ksfkpv7VVjJwdK0 oVrh8sI56PPKcnj1fbv2obU8LVCTo3FjWptXKHN4sYmCPe8.KBFxQ9WPe_e6zv1EIhJ97tztkuvj 1M1vzIbhIRQCizdAtlJq2.o6gpx04xEC6l2WXW8gxMXgAo235b24yAUoETDGdFssAeGoq1sNibem U7O7tWx7iqrS9Yzn5U3J9pa32aa_NKkCZ5c7qqI9VtkS0d1CXmS2OfFxyoaL0t0jz0izdJ4IaLP. syKE2stJd5BRdPNFB0DLIEoGqp9t4Sh7EK1oHnv81u1wfxqpsp7.HoTQUxjMVms7YSxvGx6TASSS iwGPQk82gkMCpsT7kQVN4losAPAvIanZsVEjxqHV.tiEStpbI5NO0qaa.BiFc31jXbV46o1ZSSNK n..PlTBxNiqAy_r01u7CXH.IAR45YfIl3b95YhwqdJ9XyKFjUH4.5v5EH9dSyXlEwcDVFXsdLcYs 6Jai3uJnCNvsmAk1UUBG_Ku_wiOrOxWeh74pXaVrrrGH.CEBQTrJyHPvFufKYNJVKjL3iF6GHDPW XfKNVVb2fPfX_OU3D4IfqaOT2oJOCMT8cVzrCx8kRuVmRHtYxzzA8IK1JEqdeMwmCU1XWpV97vnU lkwEg78dTfRNHL36Y1S5tlzaFQJTsD9cJuUFT_OLbpal61985WmzGomAphWpvm9t3RXE3hmX8.5s QdmXcMmEQSQ7ZQF9IykLrTxcCfHLFEDap78s77YPuaxHGsfahEQ4Ho5n7316C.l2k4xGN9_u7wAf 7lHx4ebfZX8iypHl8XD3WhPdHNm3oR.W3iFEmNBE1tGfRLBla3CTzT.rUAp_jGnHEEQZX53sCu.n 75wK9sWS2_gFrjzy4L5FlMD2XXGmj6uzDexTEwYXpuwciW1K5w_15npW5umCO7ZlazvG6S_xvLCP qVNu0Xf2CBQlN3kRAJRVr6XmvAPbeg5Iug.a712ZHBWkvsjb4.0KlEdVlc4GcPgkssO0_Aup5e5M VLk8.DcWkFgmGIPPQd4rJz4I6pozjYDw732coRTFb8DA3lEOOQn17kMlVxgDVSJp15d96KbCEgqu NV.bLi1Hyj5iUcEcj4bru_WWiwro6AN2YV3pTDBat1vh_fMbSb6ZfXtg.UXQ2OKJVeEKLZM1sbe6 dg7GA5rE2aM4UImGS X-Sonic-MF: X-Sonic-ID: c85c74c0-5782-4e9b-ad68-ebc18175660d Received: from sonic.gate.mail.ne1.yahoo.com by sonic312.consmr.mail.gq1.yahoo.com with HTTP; Fri, 30 Aug 2024 20:22:20 +0000 Received: by hermes--production-gq1-5d95dc458-m8nfd (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 1a502b1684136b87a06bc5f71edcb3d2; Fri, 30 Aug 2024 20:22:16 +0000 (UTC) From: Mark Millard Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51\)) Subject: Re: git: 43e8849bc294 - main - conf: Enable BTI checking in the arm64 kernel Message-Id: Date: Fri, 30 Aug 2024 13:22:14 -0700 To: John Baldwin , dev-commits-src-main@freebsd.org X-Mailer: Apple Mail (2.3776.700.51) References: X-Spamd-Bar: --- X-Spamd-Result: default: False [-3.94 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.94)[-0.939]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; DWL_DNSWL_NONE(0.00)[yahoo.com:dkim]; RCPT_COUNT_TWO(0.00)[2]; FREEMAIL_FROM(0.00)[yahoo.com]; TO_DN_SOME(0.00)[]; DKIM_TRACE(0.00)[yahoo.com:+]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/20, country:US]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org]; APPLE_MAILER_COMMON(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RWL_MAILSPIKE_POSSIBLE(0.00)[98.137.69.205:from]; RCVD_IN_DNSWL_NONE(0.00)[98.137.69.205:from] X-Rspamd-Queue-Id: 4WwV1p4nYcz4d2j John Baldwin wrote on Date: Fri, 30 Aug 2024 15:35:03 UTC : > libc++ is also making this more > complicated as they are providing very little compatability at all. = They've > already ripped out support for GCC 14 I believe, so you can't build = current > libc++ with a released version of GCC or something crazy. That would mean that the libc++ folks have not kept = https://libcxx.llvm.org/ up to date. For GCC it indicates "14" ("In C++11 or later only") and indicates a Support Policy of: "latest stable release per GCC=E2=80=99s release page" That might mean just 14.2 officially now. Interestingly, "Libc++ also supports common platforms and architectures" lists: arm64 for macOS 13+, Linux, and Android 5.0+ . arm for FreeBSD12+, Linux, and Android 5.0+ . But I do not expect this list is kept as up to date. =3D=3D=3D Mark Millard marklmi at yahoo.com From nobody Sat Aug 31 15:56:07 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Wx04P3f6Fz5MbPX for ; Sat, 31 Aug 2024 15:56:21 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ot1-x336.google.com (mail-ot1-x336.google.com [IPv6:2607:f8b0:4864:20::336]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Wx04N3WgHz4HvJ for ; Sat, 31 Aug 2024 15:56:20 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20230601.gappssmtp.com header.s=20230601 header.b=BDHFiJf4; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::336) smtp.mailfrom=wlosh@bsdimp.com Received: by mail-ot1-x336.google.com with SMTP id 46e09a7af769-70df4b5cdd8so1894716a34.1 for ; Sat, 31 Aug 2024 08:56:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1725119779; x=1725724579; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=75fxV43JOTZiFhd8EWNGWULZ7A1AQ7/H3XkK710mKb8=; b=BDHFiJf4cG8oSqeqCoKLEax5gg1/KW21SjRhRF6ftIrMydhV3nKqAmVI+6lODMqFLk R/XkcJsGeQS/TdNX0fe7lZzxD5w8dY+/2oo+l+pvK9ozScffWHGXzC1seJ8SElV9abZc +6R65cdS9C4Nv9H39Cex/Kst14So+qHobgolkLpDpVqDag9ymJ2nNhoeAfHTEO/BO/DL xvmeNIdz9a3eUJwTVqlBu8/1iWz5xkFXzJDBjw8v+4Ht3so11gFIDrTD5OcHoUm3zdA3 iwLvBT2NTQfFaDTAX23cTVk7C8/w4tBYMjyHZM/XKh8EERwjUHYEPcyZmEkCbc0M40Rb Iujw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725119779; x=1725724579; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=75fxV43JOTZiFhd8EWNGWULZ7A1AQ7/H3XkK710mKb8=; b=urNsySuKA8sFqzvp0mid5gGr3+TOnpNPVlznYAirWyNwBZ2hFfZzWAnbk64qAk2N4g HVPBFOPUcfuu1OEXEsWigl+28eWebv+ysJNijSBNwcqFxnukh/9uxAYBe692Q+TsOri/ 3OttaM5eMYM+ZEXbzAiinqjKwDblohcxtR6A1qxAug1Kn5JlHT8wCz6ybgTm2xPwR911 oJAFcZyH/d2H4PxNn1myup9zhTLkaYV6DjqIavYv+CaRHU+6niAyOoLDtimARIsvggWh HycSEnWDzVyTZvu5/yJhO2QdeqpZT0by4twQew3X2/X21fTQ8as0DmNvKgnOZlMC52Lw GUyQ== X-Forwarded-Encrypted: i=1; AJvYcCW/p/TVnXdLeKiHFce2s/Epin4Wv+P/SK44fZwhRTIrSaakKLK33bYIkD16/bmmQOe8AzowySV6CrsAW76MVYJZusjkVw==@freebsd.org X-Gm-Message-State: AOJu0YwEPVh1Fzu8HDyDoo00tvmgdRmIE7xDzRtvfaoAAW/RLvwu2USk AL0VdxvH7MHK2PT5xAp5JBalK+9e/l6YsIFFSKw+snjk6mrrEnDPT86dd9p2Siy/ZxOn74z/z4L Wsy/4kVnsfrCPCWlw1e+gT0H4coONa/Px5eaQvw== X-Google-Smtp-Source: AGHT+IGhwpuJ1BwH4balOklYTP5kKDDeCBu4LeVwT6EGB9UCvLKDtwpJJu6JtKdeJtLQ1H1LBsZjXsZnIARVpoLhjgk= X-Received: by 2002:a05:6358:7183:b0:1b5:fb78:fb9b with SMTP id e5c5f4694b2df-1b7ef691e7bmr334408155d.14.1725119778631; Sat, 31 Aug 2024 08:56:18 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 References: <202408200902.47K92BsJ078096@gitrepo.freebsd.org> <77cbcd47-1778-4e71-b824-4e75e0e4b2d6@FreeBSD.org> <19DBDC11-EB0F-48C0-9AAE-9EED087F0AB6@freebsd.org> <8a9faa7c-1f81-4aa8-adac-a6f07d7d73ff@FreeBSD.org> In-Reply-To: <8a9faa7c-1f81-4aa8-adac-a6f07d7d73ff@FreeBSD.org> From: Warner Losh Date: Sat, 31 Aug 2024 09:56:07 -0600 Message-ID: Subject: Re: git: 43e8849bc294 - main - conf: Enable BTI checking in the arm64 kernel To: John Baldwin Cc: Andrew Turner , Jessica Clarke , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Type: multipart/alternative; boundary="00000000000099ca480620fcbf30" X-Spamd-Bar: -- X-Spamd-Result: default: False [-3.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.999]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20230601.gappssmtp.com:s=20230601]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_COUNT_ONE(0.00)[1]; MIME_TRACE(0.00)[0:+,1:+,2:~]; TO_DN_SOME(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; MISSING_XM_UA(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::336:from]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org]; RCPT_COUNT_FIVE(0.00)[6]; R_SPF_NA(0.00)[no SPF record]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; FROM_HAS_DN(0.00)[]; DMARC_NA(0.00)[bsdimp.com]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_TLS_LAST(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-main@freebsd.org]; ARC_NA(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20230601.gappssmtp.com:+] X-Rspamd-Queue-Id: 4Wx04N3WgHz4HvJ --00000000000099ca480620fcbf30 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Aug 30, 2024 at 9:35=E2=80=AFAM John Baldwin wrot= e: > On 8/30/24 04:55, Andrew Turner wrote: > > > > > >> On 29 Aug 2024, at 17:02, Jessica Clarke wrote: > >> > >> On 21 Aug 2024, at 15:28, John Baldwin wrote: > >>> > >>> On 8/20/24 05:02, Andrew Turner wrote: > >>>> The branch main has been updated by andrew: > >>>> URL: > https://cgit.FreeBSD.org/src/commit/?id=3D43e8849bc29414036ccaef7788de95a= 07ad32ab5 > >>>> commit 43e8849bc29414036ccaef7788de95a07ad32ab5 > >>>> Author: Andrew Turner > >>>> AuthorDate: 2024-08-19 12:59:49 +0000 > >>>> Commit: Andrew Turner > >>>> CommitDate: 2024-08-20 08:49:15 +0000 > >>>> conf: Enable BTI checking in the arm64 kernel > >>>> To ensure new code has BTI support make it an error to not > have the > >>>> BTI ELF note when linking the kernel and kernel modules. > >>>> Reviewed by: kib, emaste > >>>> Sponsored by: Arm Ltd > >>>> Differential Revision: https://reviews.freebsd.org/D45469 > >>> > >>> This has broken two of the GitHub CI actions using clang 12 and clang > 13. > >>> Please fix this to be conditional on a supported linker version (or > perhaps > >>> add a new linker feature to bsd.linker.mk). > >> > >> This is still broken. If it=E2=80=99s not fixed promptly I will just r= evert > >> this change; we can=E2=80=99t leave CI broken, especially when it gets= used to > >> test GitHub PRs. Please stop breaking building with older toolchains, > >> this isn=E2=80=99t the first time it=E2=80=99s happened. > > > > See https://github.com/freebsd/freebsd-src/pull/1393 and > https://github.com/freebsd/freebsd-src/pull/1399 > > I do think we probably want to flesh out a bit more what kind of policy > we want for the range of compiler versions to support. E.g. in the GDB > project the policy is something like "will not use a version of C++ newer > than a compiler from 10 years ago" (IIRC). There they will also look bac= k > to whatever LTS distros are active and what is the newest compiler that > can be installed on those LTS via the equivalent of ports. > QEMU does similar things. > Traditionally we used to only support compiling FreeBSD N on FreeBSD N-1 > (though we have often supported older versions of FreeBSD). However, we > now also support cross-compiling from Linux and macOS, so we probably wan= t > to widen the support base a bit. I would say a first stab perhaps is tha= t > main and any supported stable and release branches should be buildable on > a host running any of those versions. That is, FreeBSD 13 is still > supported so we should keep main building on it directly without requirin= g > a jump to FreeBSD 14 first. Once 13 EOLs then we can stop supporting 13, > and that would gives folks on 13 a way to step up to the supported versio= n > of 14 at the time of the EOL. That said, presuambly fairly recent versio= ns > of LLVM (and GCC for that matter) will be available in ports for supporte= d > versions, so that doesn't necessarily require a very wide range of > supported > compiler versions. Supporting the "native" compiler on those releases > would be a nice goal that I think is probably achievable with minimal > effort. > Recent history has been such that all supported branches can jump to head. It's been more like N-2 or N-3 (12 -> head still works last I tried it, but it's likely to break at any random llvm import and we've had once since I (accidentally) tried it). In general, it's good policy if we can do it. In the earlier days of the project, there was considerably more API churn that required more compatibility shim= s than we need these days. It's usually just a matter of having a new enough C++ compiler for the latest language features used by llvm. I think the last breakage I looked into was like that (11 didn't have a new enough llvm for 14-current). As you note, we have ports/pkgs that can do that, but only if we keep the older recently not supported branches final packages around... Also to clarify one point: It's only the last supported release on the stable branch or newer that can jump to -current, not any point since the branch (though it often works, we dropped that effort some time ago when its main champion moved on from contributing to the FreeBSD project). I think stable-11 got a 'final' llvm update late in the branche's life because we hadn't had a release in too long, but I may be misremembering. But having said all that, I agree: this isn't going to widen things all that much. Today our oldest supported release is 14.0 which shipped with clang 16, and > 13.3 shipped with clang 17. Both of those are quite a bit newer than > clang 12 > that is current oldest version in CI. I have no idea what version range > might be sensible for Linux and macOS. Presumably we'd want to settle on > some range of ubuntu LTS versions and whatever is the newest version you > can > install on the oldest LTS as the minimum. > > clang 12 might have been used in 13.1 (not mentioned in the release notes= , > 13.0 used clang 11, 13.2 used clang 14) and 12.3 (12.4 used clang 13, > 12.2 used clang 10, 12.3 didn't mention it). > That gets back to the question of 'tip of the branch' or 'from the branch point'. I think that we should require only tip of branch (so we don't gate using new compiler features in head for something we shipped in 13.0), but encourage people to put the API compat shims into the build library for a wider range (since they will likely also be needed for Linux/MacOS too, independent of compiler version). > I know CHERI LLVM is still on LLVM 15 (though moving to LLVM 16 soon, but > Morello LLVM is 14 still I think). libc++ is also making this more > complicated as they are providing very little compatability at all. > They've > already ripped out support for GCC 14 I believe, so you can't build curre= nt > libc++ with a released version of GCC or something crazy. > Upstream will, perhaps sadly, drive a lot of our policy in this area. When upstream de-orbits support for something, it's hard for us to keep maintaining it and keep updating to upstream without some kind of compelling need. Though I recently spend a fair amount of time coming up with a fairly minimal tweak to our cdefs.h that makes it more compatible with the crazy things that libc++ does to still support compiling older C++ standards. Which brings up another possible issue. We don't support building FreeBSD, itself, with anything but a fairly up-to-date wrt standards compiler. However, we support building binaries from sources that compile with C89 and newer, and C++98 and newer (though really this is likely C++11 for most things, given the upstream de-orbiting of support for older standard binaries). We may need to carefully call this out as well... The older C++ standards don't matter too much (most of the C++ plorts actually want the newer C++), but there's still a lot of packages that compile with a strict C89 feature set that break in subtle ways when we break support for that... Warner --00000000000099ca480620fcbf30 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Fri, Aug 30, 2024 at 9:35=E2=80=AF= AM John Baldwin <jhb@freebsd.org&= gt; wrote:
On 8/= 30/24 04:55, Andrew Turner wrote:
>
>
>> On 29 Aug 2024, at 17:02, Jessica Clarke <jrtc27@freebsd.org> wrote:
>>
>> On 21 Aug 2024, at 15:28, John Baldwin <jhb@FreeBSD.org> wro= te:
>>>
>>> On 8/20/24 05:02, Andrew Turner wrote:
>>>> The branch main has been updated by andrew:
>>>> URL: https://cgit.FreeBSD.org/src/commit/?id=3D43e8849bc29414036ccaef7788de9= 5a07ad32ab5
>>>> commit 43e8849bc29414036ccaef7788de95a07ad32ab5
>>>> Author:=C2=A0 =C2=A0 =C2=A0Andrew Turner <andrew@FreeBS= D.org>
>>>> AuthorDate: 2024-08-19 12:59:49 +0000
>>>> Commit:=C2=A0 =C2=A0 =C2=A0Andrew Turner <andrew@FreeBS= D.org>
>>>> CommitDate: 2024-08-20 08:49:15 +0000
>>>>=C2=A0 =C2=A0 =C2=A0conf: Enable BTI checking in the arm64 = kernel
>>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 To ensure new code has B= TI support make it an error to not have the
>>>>=C2=A0 =C2=A0 =C2=A0BTI ELF note when linking the kernel an= d kernel modules.
>>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Reviewed by:=C2=A0 =C2= =A0 kib, emaste
>>>>=C2=A0 =C2=A0 =C2=A0Sponsored by:=C2=A0 =C2=A0Arm Ltd
>>>>=C2=A0 =C2=A0 =C2=A0Differential Revision:=C2=A0 h= ttps://reviews.freebsd.org/D45469
>>>
>>> This has broken two of the GitHub CI actions using clang 12 an= d clang 13.
>>> Please fix this to be conditional on a supported linker versio= n (or perhaps
>>> add a new linker feature to bsd.linker.mk).
>>
>> This is still broken. If it=E2=80=99s not fixed promptly I will ju= st revert
>> this change; we can=E2=80=99t leave CI broken, especially when it = gets used to
>> test GitHub PRs. Please stop breaking building with older toolchai= ns,
>> this isn=E2=80=99t the first time it=E2=80=99s happened.
>
> See https://github.com/freebsd/freebsd-src/pu= ll/1393 and https://github.com/freebsd/freebsd-s= rc/pull/1399

I do think we probably want to flesh out a bit more what kind of policy
we want for the range of compiler versions to support.=C2=A0 E.g. in the GD= B
project the policy is something like "will not use a version of C++ ne= wer
than a compiler from 10 years ago" (IIRC).=C2=A0 There they will also = look back
to whatever LTS distros are active and what is the newest compiler that
can be installed on those LTS via the equivalent of ports.
=

QEMU does similar things.
=C2=A0
Traditionally we used to only support compiling FreeBSD N on FreeBSD N-1 (though we have often supported older versions of FreeBSD).=C2=A0 However, = we
now also support cross-compiling from Linux and macOS, so we probably want<= br> to widen the support base a bit.=C2=A0 I would say a first stab perhaps is = that
main and any supported stable and release branches should be buildable on a host running any of those versions.=C2=A0 That is, FreeBSD 13 is still supported so we should keep main building on it directly without requiring<= br> a jump to FreeBSD 14 first.=C2=A0 Once 13 EOLs then we can stop supporting = 13,
and that would gives folks on 13 a way to step up to the supported version<= br> of 14 at the time of the EOL.=C2=A0 That said, presuambly fairly recent ver= sions
of LLVM (and GCC for that matter) will be available in ports for supported<= br> versions, so that doesn't necessarily require a very wide range of supp= orted
compiler versions.=C2=A0 Supporting the "native" compiler on thos= e releases
would be a nice goal that I think is probably achievable with minimal
effort.

Recent history has been such th= at all supported branches can jump to head. It's
been more li= ke N-2 or N-3 (12 -> head still works last I tried it, but it's like= ly to
break at any random llvm import and we've had once sinc= e I (accidentally) tried
it). In general, it's good policy if= we can do it. In the earlier days of the project,
there was cons= iderably more API churn that required more compatibility shims
th= an we need these days. It's usually just a matter of having a new enoug= h C++
compiler for the latest language features used by llvm. I t= hink the last breakage
I looked into was like that (11 didn't= have a new enough llvm for 14-current). As
you note, we have por= ts/pkgs that can do that, but only if we keep the older recently
= not supported branches final packages around...=C2=A0=C2=A0

<= /div>
Also to clarify one point: It's only the last supported relea= se on the stable branch or newer
that can jump to -current, not a= ny point since the branch (though it often works, we
dropped that= effort some time ago when its main champion moved on from contributing
to the FreeBSD project). I think stable-11 got a 'final' llv= m update late in the branche's
life because we hadn't had= a release in too long, but I may be misremembering.

But having said all that, I agree: this isn't going to widen things = all that much.

Today our oldest supported release is 14.0 which shipped with cl= ang 16, and
13.3 shipped with clang 17.=C2=A0 Both of those are quite a bit newer than = clang 12
that is current oldest version in CI.=C2=A0 I have no idea what version ran= ge
might be sensible for Linux and macOS.=C2=A0 Presumably we'd want to se= ttle on
some range of ubuntu LTS versions and whatever is the newest version you ca= n
install on the oldest LTS as the minimum.

clang 12 might have been used in 13.1 (not mentioned in the release notes,<= br> 13.0 used clang 11, 13.2 used clang 14) and 12.3 (12.4 used clang 13,
12.2 used clang 10, 12.3 didn't mention it).

<= /div>
That gets back to the question of 'tip of the branch' or = 'from the branch point'. I think
that we should require o= nly tip of branch (so we don't gate using new compiler features
in head for something we shipped in 13.0), but encourage people to put t= he API compat
shims into the build library for a wider range (sin= ce they will likely also be needed for
Linux/MacOS too, independe= nt of compiler version).
=C2=A0
I know CHERI LLVM is still on LLVM 15 (though moving to LLVM 16 soon, but Morello LLVM is 14 still I think).=C2=A0 libc++ is also making this more complicated as they are providing very little compatability at all.=C2=A0 T= hey've
already ripped out support for GCC 14 I believe, so you can't build cur= rent
libc++ with a released version of GCC or something crazy.
<= div>
Upstream will, perhaps sadly, drive a lot of our policy = in this area. When upstream de-orbits
support for something, it&#= 39;s hard for us to keep maintaining it and keep updating to upstream
=
without some kind of compelling need. Though I recently spend a fair a= mount of time coming
up with a fairly minimal tweak to our cdefs.= h that makes it more compatible with the crazy things
that libc++= does to still support compiling older C++ standards.

<= div>Which brings up another possible issue. We don't support building F= reeBSD, itself, with anything
but a fairly up-to-date wrt standar= ds compiler. However, we support building binaries from sources
t= hat compile with C89 and newer, and C++98 and newer (though really this is = likely C++11 for most
things, given the upstream de-orbiting of s= upport for older standard binaries). We may need to carefully
cal= l this out as well... The older C++ standards don't matter too much (mo= st of the C++ plorts actually
want the newer C++), but there'= s still a lot of packages that compile with a strict C89 feature set
<= div>that break in subtle ways when we break support for that...
<= br>
Warner=C2=A0
--00000000000099ca480620fcbf30-- From nobody Sat Aug 31 16:28:01 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Wx0mx5CFPz5MdRS; Sat, 31 Aug 2024 16:28:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Wx0mx4l0Vz4MPp; Sat, 31 Aug 2024 16:28:01 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725121681; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AqUHjULbNLLZCaGh0LBx1zTk+RRtcxPQaHppajR7lRY=; b=wAWXVj88vrDlJa+CHHX3bJg3Ta6/8nyw5hla368j43OOGXZWflLBMzD6mBCNqT22Do6+Ok 5aSfIO6nxAHaA6t6lgNSX1IMg3nuAvMxh2PFfBSDLzysMYhY3CDZU2E8BSQc3mxzsv5bpw yiYcXHkxAmo+VwE6ngfwAxnGVTUvlQ4QPFCz+UwtTCqlwxxypqXCNs9iomd2DEz+4g9eJu UpK/LhG2CREhh+WwD5qpInn1bTHccvoimWUniQF2mPoDkLgEOkoYHijqsUH20GALaOEeAu yDzGKFMkHOTvxnYi+c3GPRi0JyQi0g1v1R2x8s3JV488h9bVHk9+qLhpNGY0yw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1725121681; a=rsa-sha256; cv=none; b=MES0MlS68maaJWBkBH9xrbBY+8Ie3a/gANuP1as3Vr4rTsyEUY3q4PE3Ykde4nE3ylf+sK THR7IZMyClAwmxJhC97KfTuAyQ0iZCpWQ9Kg4Mva90gyLzW0uq1iZX+fvn6/ZZo9CH19PC VmFBuyJcorquf1UqRq9hFngxx/3cVJa4ePUF9ji1axGJw8g6kLRyyW1YztwPDSgc8HPTYZ 7r3iQusfQlVctEAXUvRCqOKYR2ehBpi+8Ln9VXhnWOl5V7rc+zS9LHdKf07d4RFa0cZ5Xd guCX4/BepaH9KRP/EWVu+K/82CyIxnrD1UuDc0WNeDfE0W0Ywst/OOx+WuDMLw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725121681; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AqUHjULbNLLZCaGh0LBx1zTk+RRtcxPQaHppajR7lRY=; b=g+MqELDm63rs6bhk0pm4rMfBEYYpECWFHAx3cM9fuJundPshJ8QREgtuFuAnsqIIyGhg7W 8g4dgdmrXLPScxdXyr7C/RoD3sYFonq4Rh/jAOxTh4hlIui6YBUu9VblzVZ+1ukPqpzfUK p19fl5ZoWRkQucJqUfCqb8O3KIOKACYCVAe9prcJl9/mJ4WYjRkEovSBqR1E/YwNc9HTwg nnz8zjjcLSckwnh9KTTNW5guaBmzG4+rVIvHGWD03fR8gpKsHwgRbrnM7PiFGri4sXb1cl UZAECN7PEtzrtZDHUMtNIoqebfkePO5vDJS4lKbRiNg5dyWhoOXW0xylGM5WWA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Wx0mx4LKkzrSP; Sat, 31 Aug 2024 16:28:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47VGS1nV098075; Sat, 31 Aug 2024 16:28:01 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47VGS1UW098072; Sat, 31 Aug 2024 16:28:01 GMT (envelope-from git) Date: Sat, 31 Aug 2024 16:28:01 GMT Message-Id: <202408311628.47VGS1UW098072@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Gordon Tetlow Subject: git: 86dd740dd73a - main - openssl: Remove fips module from base system. List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: gordon X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 86dd740dd73aa88477ff450b2359abda1ad68534 Auto-Submitted: auto-generated The branch main has been updated by gordon: URL: https://cgit.FreeBSD.org/src/commit/?id=86dd740dd73aa88477ff450b2359abda1ad68534 commit 86dd740dd73aa88477ff450b2359abda1ad68534 Author: Gordon Tetlow AuthorDate: 2024-08-04 21:10:46 +0000 Commit: Gordon Tetlow CommitDate: 2024-08-31 16:24:30 +0000 openssl: Remove fips module from base system. To comply with FIPS 140 guidance, you must be using a specifically validated and approved version of the fips module. Currently, only OpenSSL 3.0.8 and 3.0.9 have been approved by NIST for FIPS 140 validation. As such, we need to stop shipping later versions of the module in the base system. MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D46223 --- ObsoleteFiles.inc | 3 + secure/lib/libcrypto/modules/Makefile | 2 +- secure/lib/libcrypto/modules/fips/Makefile | 340 ----------------------------- 3 files changed, 4 insertions(+), 341 deletions(-) diff --git a/ObsoleteFiles.inc b/ObsoleteFiles.inc index 5ce960fdca82..fe1eb89f1c9c 100644 --- a/ObsoleteFiles.inc +++ b/ObsoleteFiles.inc @@ -51,6 +51,9 @@ # xargs -n1 | sort | uniq -d; # done +# 20240827: retire fips.so +OLD_LIBS+=usr/lib/ossl-modules/fips.so + # 20240824: sound examples: midi.c moved out of oss/ OLD_FILES+=share/examples/sound/oss/midi.c diff --git a/secure/lib/libcrypto/modules/Makefile b/secure/lib/libcrypto/modules/Makefile index 0e01eb3b8ef2..69a8470ff20b 100644 --- a/secure/lib/libcrypto/modules/Makefile +++ b/secure/lib/libcrypto/modules/Makefile @@ -1,4 +1,4 @@ -SUBDIR= fips legacy +SUBDIR= legacy SUBDIR_PARALLEL= .include diff --git a/secure/lib/libcrypto/modules/fips/Makefile b/secure/lib/libcrypto/modules/fips/Makefile deleted file mode 100644 index 0f4889f3ff81..000000000000 --- a/secure/lib/libcrypto/modules/fips/Makefile +++ /dev/null @@ -1,340 +0,0 @@ -SHLIB_NAME?= fips.so - -CFLAGS+= -DFIPS_MODULE - -SRCS+= fips_entry.c fipsprov.c self_test.c self_test_kats.c - -.include "../../Makefile.common" - -# crypto -SRCS+= provider_core.c provider_predefined.c \ - core_fetch.c core_algorithm.c core_namemap.c self_test_core.c - -SRCS+= cpuid.c ctype.c -.if defined(ASM_aarch64) -SRCS+= arm64cpuid.S armcap.c -ACFLAGS.arm64cpuid.S= -march=armv8-a+crypto -.elif defined(ASM_amd64) -SRCS+= x86_64cpuid.S -.elif defined(ASM_arm) -SRCS+= armv4cpuid.S armcap.c -.elif defined(ASM_i386) -SRCS+= x86cpuid.S -.elif defined(ASM_powerpc) -SRCS+= ppccpuid.S ppccap.c -.elif defined(ASM_powerpc64) -SRCS+= ppccpuid.S ppccap.c -.elif defined(ASM_powerpc64le) -SRCS+= ppccpuid.S ppccap.c -.else -SRCS+= mem_clr.c -.endif - -# crypto/aes -SRCS+= aes_cfb.c aes_ecb.c aes_ige.c aes_misc.c aes_ofb.c aes_wrap.c -.if defined(ASM_aarch64) -SRCS+= aes_cbc.c aes_core.c aesv8-armx.S vpaes-armv8.S -ACFLAGS.aesv8-armx.S= -march=armv8-a+crypto -.elif defined(ASM_amd64) -SRCS+= aes-x86_64.S aesni-mb-x86_64.S aesni-sha1-x86_64.S -SRCS+= aesni-sha256-x86_64.S aesni-x86_64.S bsaes-x86_64.S vpaes-x86_64.S -.elif defined(ASM_arm) -SRCS+= aes_cbc.c aes-armv4.S aesv8-armx.S bsaes-armv7.S -.elif defined(ASM_i386) -SRCS+= aes-586.S aesni-x86.S vpaes-x86.S -.elif defined(ASM_powerpc) -SRCS+= aes_cbc.c aes_core.c aes-ppc.S vpaes-ppc.S aesp8-ppc.S -.elif defined(ASM_powerpc64) -SRCS+= aes_cbc.c aes_core.c aes-ppc.S vpaes-ppc.S aesp8-ppc.S -.elif defined(ASM_powerpc64le) -SRCS+= aes_cbc.c aes_core.c aes-ppc.S vpaes-ppc.S aesp8-ppc.S -.else -SRCS+= aes_cbc.c aes_core.c -.endif - -# crypto/bn -SRCS+= bn_add.c bn_div.c bn_exp.c bn_lib.c bn_ctx.c bn_mul.c \ - bn_mod.c bn_conv.c bn_rand.c bn_shift.c bn_word.c bn_blind.c \ - bn_kron.c bn_sqrt.c bn_gcd.c bn_prime.c bn_sqr.c \ - bn_recp.c bn_mont.c bn_mpi.c bn_exp2.c bn_gf2m.c bn_nist.c \ - bn_intern.c bn_dh.c bn_rsa_fips186_4.c bn_const.c -.if defined(ASM_aarch64) -SRCS+= armv8-mont.S bn_asm.c -.elif defined(ASM_amd64) -SRCS+= rsaz-avx2.S rsaz-avx512.S rsaz-x86_64.S rsaz_exp.c rsaz_exp_x2.c -SRCS+= x86_64-gcc.c x86_64-gf2m.S x86_64-mont.S x86_64-mont5.S -.elif defined(ASM_arm) -SRCS+= armv4-gf2m.S armv4-mont.S bn_asm.c -.elif defined(ASM_i386) -SRCS+= bn-586.S co-586.S x86-gf2m.S x86-mont.S -.elif defined(ASM_powerpc) -SRCS+= bn_ppc.c bn-ppc.S ppc-mont.S -.elif defined(ASM_powerpc64) -SRCS+= bn_ppc.c bn-ppc.S ppc-mont.S -.elif defined(ASM_powerpc64le) -SRCS+= bn_ppc.c bn-ppc.S ppc-mont.S -.else -SRCS+= bn_asm.c -.endif - -# crypto/buffer -SRCS+= buffer.c - -# crypto/cmac -SRCS+= cmac.c - -# crypto/des -SRCS+= set_key.c ecb3_enc.c -.if defined(ASM_i386) -SRCS+= crypt586.S des-586.S -.else -SRCS+= des_enc.c fcrypt_b.c -.endif - -# crypto/dh -SRCS+= dh_lib.c dh_key.c dh_group_params.c dh_check.c dh_backend.c dh_gen.c \ - dh_kdf.c - -# crypto/dsa -SRCS+= dsa_sign.c dsa_vrf.c dsa_lib.c dsa_ossl.c dsa_check.c \ - dsa_key.c dsa_backend.c dsa_gen.c - -# crypto/ec -SRCS+= ec_lib.c ecp_smpl.c ecp_mont.c ecp_nist.c ec_cvt.c ec_mult.c \ - ec_curve.c ec_check.c ec_key.c ec_kmeth.c ecx_key.c ec_asn1.c \ - ec2_smpl.c \ - ecp_oct.c ec2_oct.c ec_oct.c ecdh_ossl.c \ - ecdsa_ossl.c ecdsa_sign.c ecdsa_vrf.c curve25519.c \ - curve448/f_generic.c curve448/scalar.c \ - curve448/curve448_tables.c curve448/eddsa.c curve448/curve448.c \ - ec_backend.c ecx_backend.c ecdh_kdf.c curve448/arch_64/f_impl64.c \ - curve448/arch_32/f_impl32.c -SRCS+= cryptlib.c params.c params_from_text.c bsearch.c ex_data.c o_str.c \ - threads_pthread.c threads_none.c initthread.c \ - context.c sparse_array.c asn1_dsa.c packet.c param_build.c \ - param_build_set.c der_writer.c threads_lib.c params_dup.c - -.include -.if ${MACHINE_ABI:Mlittle-endian} && ${MACHINE_ABI:Mlong64} -SRCS+= ecp_nistp224.c ecp_nistp256.c ecp_nistp521.c ecp_nistputil.c -.endif -.if defined(ASM_aarch64) -SRCS+= ecp_nistz256-armv8.S ecp_nistz256.c -.elif defined(ASM_amd64) -SRCS+= ecp_nistz256-x86_64.S ecp_nistz256.c x25519-x86_64.S -.elif defined(ASM_arm) -SRCS+= ecp_nistz256-armv4.S ecp_nistz256.c -.elif defined(ASM_i386) -SRCS+= ecp_nistz256-x86.S ecp_nistz256.c -.elif defined(ASM_powerpc64) -SRCS+= ecp_nistp521-ppc64.S ecp_nistz256-ppc64.S ecp_nistz256.c ecp_ppc.c x25519-ppc64.S -.elif defined(ASM_powerpc64le) -SRCS+= ecp_nistp521-ppc64.S ecp_nistz256-ppc64.S ecp_nistz256.c ecp_ppc.c x25519-ppc64.S -.endif - -# crypto/evp -SRCS+= digest.c evp_enc.c evp_lib.c evp_fetch.c evp_utils.c \ - mac_lib.c mac_meth.c keymgmt_meth.c keymgmt_lib.c kdf_lib.c kdf_meth.c \ - m_sigver.c pmeth_lib.c signature.c p_lib.c pmeth_gn.c exchange.c \ - evp_rand.c asymcipher.c kem.c dh_support.c ec_support.c pmeth_check.c - -# crypto/ffc -SRCS+= ffc_params.c ffc_params_generate.c ffc_key_generate.c \ - ffc_params_validate.c ffc_key_validate.c ffc_backend.c \ - ffc_dh.c - -# crypto/hmac -SRCS+= hmac.c - -# crypto/lhash -SRCS+= lhash.c - -# crypto/modes -SRCS+= cbc128.c ctr128.c cfb128.c ofb128.c gcm128.c ccm128.c xts128.c -SRCS+= wrap128.c -.if defined(ASM_aarch64) -SRCS+= ghashv8-armx.S aes-gcm-armv8_64.S -ACFLAGS.ghashv8-armx.S= -march=armv8-a+crypto -.elif defined(ASM_amd64) -SRCS+= aesni-gcm-x86_64.S ghash-x86_64.S -.elif defined(ASM_arm) -SRCS+= ghash-armv4.S ghashv8-armx.S -.elif defined(ASM_i386) -SRCS+= ghash-x86.S -.elif defined(ASM_powerpc) -SRCS+= ghashp8-ppc.S -.elif defined(ASM_powerpc64) -SRCS+= ghashp8-ppc.S -.elif defined(ASM_powerpc64le) -SRCS+= ghashp8-ppc.S -.endif - -# crypto/property -SRCS+= property_string.c property_parse.c property_query.c property.c defn_cache.c - -# crypto/rand -SRCS+= rand_lib.c - -# crypto/rsa -SRCS+= rsa_ossl.c rsa_gen.c rsa_lib.c rsa_sign.c rsa_pk1.c \ - rsa_none.c rsa_oaep.c rsa_chk.c rsa_pss.c rsa_x931.c rsa_crpt.c \ - rsa_sp800_56b_gen.c rsa_sp800_56b_check.c rsa_backend.c \ - rsa_mp_names.c rsa_schemes.c -SRCS+= rsa_acvp_test_params.c - -# crypto/sha -SRCS+= sha1dgst.c sha256.c sha512.c sha3.c -.if defined(ASM_aarch64) -SRCS+= keccak1600-armv8.S sha1-armv8.S sha256-armv8.S sha512-armv8.S -.elif defined(ASM_amd64) -SRCS+= keccak1600-x86_64.S sha1-mb-x86_64.S sha1-x86_64.S -SRCS+= sha256-mb-x86_64.S sha256-x86_64.S sha512-x86_64.S -.elif defined(ASM_arm) -SRCS+= keccak1600-armv4.S sha1-armv4-large.S sha256-armv4.S sha512-armv4.S -.elif defined(ASM_i386) -SRCS+= keccak1600.c sha1-586.S sha256-586.S sha512-586.S -.elif defined(ASM_powerpc) -SRCS+= keccak1600.c sha_ppc.c sha1-ppc.S sha256-ppc.S sha512-ppc.S sha256p8-ppc.S sha512p8-ppc.S -.elif defined(ASM_powerpc64) -SRCS+= keccak1600-ppc64.S sha_ppc.c sha1-ppc.S sha256-ppc.S sha512-ppc.S sha256p8-ppc.S sha512p8-ppc.S -.elif defined(ASM_powerpc64le) -SRCS+= keccak1600-ppc64.S sha_ppc.c sha1-ppc.S sha256-ppc.S sha512-ppc.S sha256p8-ppc.S sha512p8-ppc.S -.else -SRCS+= keccak1600.c -.endif - -# crypto/stack -SRCS+= stack.c - -# common -SRCS+= capabilities.c bio_prov.c digest_to_nid.c \ - securitycheck.c provider_seeding.c -SRCS+= securitycheck_fips.c - -# common/der -SRCS+= der_rsa_gen.c der_rsa_key.c -SRCS+= der_rsa_sig.c - -SRCS+= der_dsa_gen.c der_dsa_key.c -SRCS+= der_dsa_sig.c - -SRCS+= der_ec_gen.c der_ec_key.c -SRCS+= der_ec_sig.c - -SRCS+= der_ecx_gen.c der_ecx_key.c - -SRCS+= der_wrap_gen.c - -# asymciphers -SRCS+= rsa_enc.c - -# ciphers -SRCS+= ciphercommon.c ciphercommon_hw.c ciphercommon_block.c \ - ciphercommon_gcm.c ciphercommon_gcm_hw.c \ - ciphercommon_ccm.c ciphercommon_ccm_hw.c -SRCS+= cipher_aes.c cipher_aes_hw.c \ - cipher_aes_xts.c cipher_aes_xts_hw.c \ - cipher_aes_gcm.c cipher_aes_gcm_hw.c \ - cipher_aes_ccm.c cipher_aes_ccm_hw.c \ - cipher_aes_wrp.c \ - cipher_aes_cbc_hmac_sha.c \ - cipher_aes_cbc_hmac_sha256_hw.c cipher_aes_cbc_hmac_sha1_hw.c \ - cipher_cts.c -SRCS+= cipher_aes_xts_fips.c -SRCS+= cipher_tdes.c cipher_tdes_common.c cipher_tdes_hw.c - -# digests -SRCS+= digestcommon.c -SRCS+= sha2_prov.c -SRCS+= sha3_prov.c - -# exchange -SRCS+= dh_exch.c -SRCS+= ecx_exch.c -SRCS+= ecdh_exch.c -SRCS+= kdf_exch.c - -# kdfs -SRCS+= tls1_prf.c -SRCS+= hkdf.c -SRCS+= kbkdf.c -SRCS+= pbkdf2.c -SRCS+= pbkdf2_fips.c -SRCS+= sskdf.c -SRCS+= sshkdf.c -SRCS+= x942kdf.c - -# kem -SRCS+= rsa_kem.c - -# keymgmt -SRCS+= dh_kmgmt.c -SRCS+= dsa_kmgmt.c -SRCS+= ec_kmgmt.c -SRCS+= ecx_kmgmt.c -SRCS+= kdf_legacy_kmgmt.c -SRCS+= mac_legacy_kmgmt.c -SRCS+= rsa_kmgmt.c - -# macs -SRCS+= gmac_prov.c -SRCS+= hmac_prov.c -SRCS+= kmac_prov.c -SRCS+= cmac_prov.c - -# rands -SRCS+= drbg.c test_rng.c drbg_ctr.c drbg_hash.c drbg_hmac.c crngt.c - -# signature -SRCS+= dsa_sig.c -SRCS+= eddsa_sig.c ecdsa_sig.c -SRCS+= mac_legacy_sig.c -SRCS+= rsa_sig.c - -# ssl -SRCS+= record/tls_pad.c s3_cbc.c - -.include - -.if defined(ASM_${MACHINE_CPUARCH}) -.PATH: ${SRCTOP}/sys/crypto/openssl/${MACHINE_CPUARCH} -.if defined(ASM_amd64) -.PATH: ${LCRYPTO_SRC}/crypto/bn/asm -.endif -.elif defined(ASM_${MACHINE_ARCH}) -.PATH: ${SRCTOP}/sys/crypto/openssl/${MACHINE_ARCH} -.endif - -.PATH: ${LCRYPTO_SRC}/crypto \ - ${LCRYPTO_SRC}/crypto/aes \ - ${LCRYPTO_SRC}/crypto/bio \ - ${LCRYPTO_SRC}/crypto/bn \ - ${LCRYPTO_SRC}/crypto/buffer \ - ${LCRYPTO_SRC}/crypto/cmac \ - ${LCRYPTO_SRC}/crypto/des \ - ${LCRYPTO_SRC}/crypto/dh \ - ${LCRYPTO_SRC}/crypto/dsa \ - ${LCRYPTO_SRC}/crypto/ec \ - ${LCRYPTO_SRC}/crypto/evp \ - ${LCRYPTO_SRC}/crypto/ffc \ - ${LCRYPTO_SRC}/crypto/hmac \ - ${LCRYPTO_SRC}/crypto/lhash \ - ${LCRYPTO_SRC}/crypto/modes \ - ${LCRYPTO_SRC}/crypto/property \ - ${LCRYPTO_SRC}/crypto/rand \ - ${LCRYPTO_SRC}/crypto/rsa \ - ${LCRYPTO_SRC}/crypto/sha \ - ${LCRYPTO_SRC}/crypto/stack \ - ${LCRYPTO_SRC}/providers/fips \ - ${LCRYPTO_SRC}/providers/common/der \ - ${LCRYPTO_SRC}/providers/implementations/asymciphers \ - ${LCRYPTO_SRC}/providers/implementations/ciphers \ - ${LCRYPTO_SRC}/providers/implementations/digests \ - ${LCRYPTO_SRC}/providers/implementations/exchange \ - ${LCRYPTO_SRC}/providers/implementations/kdfs \ - ${LCRYPTO_SRC}/providers/implementations/kem \ - ${LCRYPTO_SRC}/providers/implementations/keymgmt \ - ${LCRYPTO_SRC}/providers/implementations/macs \ - ${LCRYPTO_SRC}/providers/implementations/rands \ - ${LCRYPTO_SRC}/providers/implementations/signature \ - ${LCRYPTO_SRC}/ssl From nobody Sat Aug 31 16:37:08 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Wx0zS3NnDz5Mfmt; Sat, 31 Aug 2024 16:37:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Wx0zS2rgzz4NRV; Sat, 31 Aug 2024 16:37:08 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725122228; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=HhxxyuA2mJ/R1AME8EH/STGrj9sXMtuYcRSdho3GcD8=; b=gF73m8OZJkJiw+NB7PS1/BUYUVu0o8Z1UWWoG4GXNzVu5PWZXZb5rRVakiAdbG2CQ2OUUL 3ISxD2BIWxV++MqIE8oZg9ouHSh1cidtJ/wDnVH1XO5vqQnUZmEFl96MJoz3Wd5f41uKOo OKdQsjCUJWQh1oWQ85tvdeMCBz4u8xlM01gXaEnGKRRaxyXjxJdX5BC2iR8H3Z4DDKYDAd ANYZU+yJXL++dDXc2FnDj4oma/JPddwSCG+zkKX3bEqIxifINjJcb4USwVAapyNzS61H2x 665hqAWX+1ML5SzCJmxkSAYCC3LPWBAkdXYegCkCdGkSyHt4YRi5uerWrWcbig== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1725122228; a=rsa-sha256; cv=none; b=KLPUO+P7uz1ZGHLU4lTfR44YjBoaIIV/XqR79pHV875F3uWzgzIvuel9ViuByEVn7H67Io ROv1NHy980VtKTcXnfbLjmpTVciryCRMX15ChANyKS3ZDUp3ucCwCZDRqA4MB2GW1JQ5HC A1okX/TkL+Cns7kYQgSo1kKhck0j+VEB2p+IvvAHHyUNc5WIVskBiJ309wQn05JVQqcBkB rjJeK4wxiZRgMbSALjD73dN7QnqP56YK02Jjjs1a+QzZhh0w0lPdSi9DA1eOyZorPttgF/ wzWNOhR0O1F+UHt/OwsniNycqWtPUq/6/oJxVzjVo/fzAf3lnZC3SR2XkT+uQw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725122228; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=HhxxyuA2mJ/R1AME8EH/STGrj9sXMtuYcRSdho3GcD8=; b=KzSUTaf2Wc0TRHeOcG2z5BHctvSUnua0VyKd88YXRrOgo4cwgqs722VW+Zy+pGivzbPu/k Ub787OlOhnOg3RmO4n5sfRGMxruAmcDtQDQDov20lkAalyDr2oNfa6jKfVjUu4cn61KKmz hAoNJh4Dqtbl+v6hGOYp8JH8IXp/nss9ZYpRWsDrYIrd2NpnIjHS5zCpk7MXLMQSRdpZBY 7atYEK88EVrKFcIBZbUVJyHCYWC/r3pDCZbt9VU4iEepsICUNIUOOtzyGTu3gjgiPSJ6Xs qogi9gNMXOlAcMYTgt6KoShZlMSFuC27IKoWS7gM/F7CzWXJytv4CTSB+Z5KiQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Wx0zS2HHVzslL; Sat, 31 Aug 2024 16:37:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47VGb8HM015319; Sat, 31 Aug 2024 16:37:08 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47VGb8J9015316; Sat, 31 Aug 2024 16:37:08 GMT (envelope-from git) Date: Sat, 31 Aug 2024 16:37:08 GMT Message-Id: <202408311637.47VGb8J9015316@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Christos Margiolis Subject: git: e9a30c90d31e - main - ObsoleteFiles.inc: Fix examples path List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: christos X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: e9a30c90d31ea86e30d06abcd91fdbd8065cf7f6 Auto-Submitted: auto-generated The branch main has been updated by christos: URL: https://cgit.FreeBSD.org/src/commit/?id=e9a30c90d31ea86e30d06abcd91fdbd8065cf7f6 commit e9a30c90d31ea86e30d06abcd91fdbd8065cf7f6 Author: Christos Margiolis AuthorDate: 2024-08-31 16:35:07 +0000 Commit: Christos Margiolis CommitDate: 2024-08-31 16:35:07 +0000 ObsoleteFiles.inc: Fix examples path Fixes: c3516c6533a1 ("ObsoleteFiles.inc: Update after sound changes") Sponsored by: The FreeBSD Foundation --- ObsoleteFiles.inc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/ObsoleteFiles.inc b/ObsoleteFiles.inc index fe1eb89f1c9c..29cfdc05a3d3 100644 --- a/ObsoleteFiles.inc +++ b/ObsoleteFiles.inc @@ -55,14 +55,14 @@ OLD_LIBS+=usr/lib/ossl-modules/fips.so # 20240824: sound examples: midi.c moved out of oss/ -OLD_FILES+=share/examples/sound/oss/midi.c +OLD_FILES+=usr/share/examples/sound/oss/midi.c # 20240824: sound examples: Remove ossinit.h and rename basic.c to audio.c -OLD_FILES+=share/examples/sound/oss/ossinit.h -OLD_FILES+=share/examples/sound/oss/basic.c +OLD_FILES+=usr/share/examples/sound/oss/ossinit.h +OLD_FILES+=usr/share/examples/sound/oss/basic.c # 20240824: sound examples: Remove ossmidi.h -OLD_FILES+=share/examples/sound/oss/ossmidi.h +OLD_FILES+=usr/share/examples/sound/oss/ossmidi.h # 20240729: rename quick_exit_test to libc_exit_test OLD_FILES+=usr/tests/lib/libc/stdlib/quick_exit_test From nobody Sat Aug 31 17:54:54 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Wx2jB42mFz5MmtX; Sat, 31 Aug 2024 17:54:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Wx2jB3SF2z4Tl6; Sat, 31 Aug 2024 17:54:54 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725126894; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=CebOoF3PTOEhy2ZETWGjgbSJ9k+YdfebdaASSjKYa48=; b=mVTtbASTMSuBYLHHovpirwKzSTP+YERXQ5aoqZJ30qYySKBsXaMLJQvMCane/7IsCInsaz hTduea3c+Zk9LfV5+Akhn5Y5MdDBfV1AssFeKDAmOjM8u+oIg5y8bOI7dIZnIkLDoHs4P1 PqPymy/lWIF1dWUE03TOesEn57ZV0QU1wxxny0dvDYaApfhiweJgAqjqqKdA0jqh1BXe2M rLpDPBTY0SWAMU+tk9ubKxu9M4a+VMadCeut5V5YjgLp+MLdVr/r8VGyIHxynDFVi4Bzk/ z+myq0aKGkDyI2dULkjY/u4FDKuBP4xcmREiBuBlCTWiZliu8ab/eDiJIv+RFg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1725126894; a=rsa-sha256; cv=none; b=rLM+lLLMnxFkXNjK4g2aAxdlUTIu7cJ7h5wi/nTQVGk+zUlsuBXa249lGQrocPkYJ/5y+2 0JR8gcgK5eluzy1AhpqsSZDUbwgAPovpOMmGgQpcBj0chKf8z57+hiY81s8KM2jGlA3px3 llfRH949HQH6bt0jRt+WKbk7mF3oxodzR1EoheD49m4SkpswvdmoMQKGMfNN09bT3FCKVy JRgm7/FmAZUiabqNZfGzNhcfyeZsd9QC8xEgXsCF9MgKFZ/ovBhwJkXWz1gVJO4NdWmfwP E/Vfy+CGSs0zI2/6DNRAygdQxm0vDbfiNyw+DZbuH0c44PapOrHzaDb/ZWDKyQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725126894; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=CebOoF3PTOEhy2ZETWGjgbSJ9k+YdfebdaASSjKYa48=; b=eri+2UfRvVGdArCQ1Gh7fObrL+hn6BI7PJFmoyfziI5Va3zJzXDZ0VgedkdLE4CGOIqfjZ FWJKcG2gk4/K9+WVrLXOEVDWHcBnvFLpHt0hNEXe5wFFKNDoMLBRrquUmco4jYvPE4Fyk9 KKHdprEoY1PBqC/6ogBh+WmLDSZrb3z2oJ4Rq8QI/j8DXo+lRr972hkrvu1yYYS9uDoEJz ayskyI0B3CgI8ty7UECA2aC1YaYtVw3thSWtpLEPhmZUkIodVOrz/2DqYaweo254Ufo2Xh uZviAfldE631o8u/LyGbgLWDVHIr0GnQipQguIGTinnpYCD4VBYVJtfsWD1KPA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Wx2jB33NczvLM; Sat, 31 Aug 2024 17:54:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47VHss3A049802; Sat, 31 Aug 2024 17:54:54 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47VHssg0049799; Sat, 31 Aug 2024 17:54:54 GMT (envelope-from git) Date: Sat, 31 Aug 2024 17:54:54 GMT Message-Id: <202408311754.47VHssg0049799@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kevin Bowling Subject: git: d7c87526b1c3 - main - tpm: Register TPM as entropy source List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: d7c87526b1c3d32d3ac3fee8c59d92405b7621b9 Auto-Submitted: auto-generated The branch main has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=d7c87526b1c3d32d3ac3fee8c59d92405b7621b9 commit d7c87526b1c3d32d3ac3fee8c59d92405b7621b9 Author: Jean-François Hren AuthorDate: 2024-08-31 17:53:02 +0000 Commit: Kevin Bowling CommitDate: 2024-08-31 17:53:02 +0000 tpm: Register TPM as entropy source TPM is defined as an entropy and is called every 10 seconds. However it was not registered and calls were discarded. Signed-off-by: Jean-François Hren MFC after: 1 week Pull Request: https://github.com/freebsd/freebsd-src/pull/1398 --- sys/dev/tpm/tpm20.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/dev/tpm/tpm20.c b/sys/dev/tpm/tpm20.c index 80f7d9e105a6..876dd0bcc40d 100644 --- a/sys/dev/tpm/tpm20.c +++ b/sys/dev/tpm/tpm20.c @@ -206,6 +206,7 @@ tpm20_init(struct tpm_sc *sc) tpm20_release(sc); #ifdef TPM_HARVEST + random_harvest_register_source(RANDOM_PURE_TPM); TIMEOUT_TASK_INIT(taskqueue_thread, &sc->harvest_task, 0, tpm20_harvest, sc); taskqueue_enqueue_timeout(taskqueue_thread, &sc->harvest_task, 0); @@ -222,6 +223,7 @@ tpm20_release(struct tpm_sc *sc) #ifdef TPM_HARVEST if (device_is_attached(sc->dev)) taskqueue_drain_timeout(taskqueue_thread, &sc->harvest_task); + random_harvest_deregister_source(RANDOM_PURE_TPM); #endif if (sc->buf != NULL) From nobody Sun Sep 1 13:28:00 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WxXkm71Trz5VD4W; Sun, 01 Sep 2024 13:28:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WxXkm6LRhz4Kbq; Sun, 1 Sep 2024 13:28:00 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725197280; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lO2HsRT02a38qbss9Hn2BfR0krBU/ZviwCfS8s6ZJIA=; b=hxf6MFMvQRiNUFTzvPu6qa6WVR5fpXx8BItTdyrOlO54h2mSRQh/vaK+hOxXlqbpEI4epG PB4F+EEkDleJlryTnCBUpO8CLRr+e2xCFH3r6GZAmPrGnrJ/5Flr+BkDeK2hSJB6sToREQ 152Z7wts5/sIIx96lt4q7XCph2V9YIfCBiWjFSWO/xgethIL9xD2ysDHT4cF0LUctzX2XS BuNzs/b6blva8rE7NP4mqFCtTRV7Wxjwxx2LRonlZjkqWYwQfHfXSflZQlpjoUPIppXHN4 2vZmzpWrUEKTc6WQzfYQKxBfhPnqLIZW5lfuhAvLxWk2YNy2k2b9806dT0HFnw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1725197280; a=rsa-sha256; cv=none; b=hf89goTcZ/+IU59xtriJK0cKZVcn4RHR2HTqmY30De6Hd4hSwAONeQm9gvTvCgujNEabhf GaSDI0O9gnM+tQKJ3cTkdrZSQDXElad5VkVeDfMXVnTLh910Nz9vNpSg7YbnAIYA7EShMz kO8iPU5C0MNShstBW/qQ2DMUwHWHIC99YZ+I0DjxZ9L9yJichlZzoMiVPtfLtVU2Y6RfbT OsMOGe7p1NR3Zs3zLtrq70eahCBAeXIiov4XFAgDG/P7tj2Dzm4Gon+6z1Yn96ankRamL6 DFkKEBuKcACsQyeuP8Sx6GhiH0zUNC6w+JCsXfGSg69UFx8lrxdyHAoc3m3goQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725197280; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lO2HsRT02a38qbss9Hn2BfR0krBU/ZviwCfS8s6ZJIA=; b=EWj0LTl8pPOnxlNYYKLZMWW+bDX0UTzLMW40Op37ZAYYR5qqRNJjfh84JAQE4VgHW5rEYt CxHxfBCpU6RujPJifU2yy+Rzt45aa76UowIha6BxCu4xy7y596n/YJRubremHiCay6diuu w54JPL/KCDFgZp721lkXgHxSzHwHPAvRPc1NrcLsPUU9REXHTFLxx9Rhj/Jn8EE8X8DL6i lSQXxx/nxWAj1vpSUV6DPTg/zFroDPQBpooMpcmZ+aW3kU/+LkNkHW6hyqFdfLTPTHmsuw 37xILxVBkmZrPFE++xih0hYBlFwDTYkm7moaH0YB3U+ung/qer2eMFTkeAWu4w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WxXkm5ybxzW4f; Sun, 1 Sep 2024 13:28:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 481DS0S4030705; Sun, 1 Sep 2024 13:28:00 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 481DS0Ji030702; Sun, 1 Sep 2024 13:28:00 GMT (envelope-from git) Date: Sun, 1 Sep 2024 13:28:00 GMT Message-Id: <202409011328.481DS0Ji030702@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: "Bjoern A. Zeeb" Subject: git: f29e915bc0d2 - main - LinuxKPI: add get_random_u8() List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: bz X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: f29e915bc0d216a87f222a208caeb2172c93e4ea Auto-Submitted: auto-generated The branch main has been updated by bz: URL: https://cgit.FreeBSD.org/src/commit/?id=f29e915bc0d216a87f222a208caeb2172c93e4ea commit f29e915bc0d216a87f222a208caeb2172c93e4ea Author: Bjoern A. Zeeb AuthorDate: 2024-08-27 21:20:09 +0000 Commit: Bjoern A. Zeeb CommitDate: 2024-08-31 21:32:11 +0000 LinuxKPI: add get_random_u8() Add a get_random_u8() implementation following the u36 and u64 versions. We'll likely want to macro-ify them in the future and add all the types which makes sense just to be done. Sponsored by: The FreeBSD Foundation MFC after: 3 days Reviewed by: emaste Differential Revision: https://reviews.freebsd.org/D46464 --- sys/compat/linuxkpi/common/include/linux/random.h | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/sys/compat/linuxkpi/common/include/linux/random.h b/sys/compat/linuxkpi/common/include/linux/random.h index 808c5bc55974..893ee2b7b728 100644 --- a/sys/compat/linuxkpi/common/include/linux/random.h +++ b/sys/compat/linuxkpi/common/include/linux/random.h @@ -54,6 +54,15 @@ get_random_int(void) return (val); } +static inline uint8_t +get_random_u8(void) +{ + uint8_t val; + + get_random_bytes(&val, sizeof(val)); + return (val); +} + #define get_random_u32() get_random_int() /* From nobody Sun Sep 1 13:28:01 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WxXkp0qC6z5VCrL; Sun, 01 Sep 2024 13:28:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WxXkp0D38z4KT8; Sun, 1 Sep 2024 13:28:02 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725197282; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ai6vc/GXmvT3s0b34aad9GV/JM6nP5J5o6OdydxXnLw=; b=TmCKwFXx9EKx7uDO1tmQUP2XCGajo9WR6PuWT6ytpCYMTci8YNpG6oLEYTppMgby1qpj+l peIJNVrNS2Q8VYT54EkrM2OdYqzHc/YYAEI1ejIe3N/2EQEQOVwKpzVuHFscbj4/0TZ114 PTmjuxUucsEyD4bdMZzLYjuUvjOC2z0G8XWhEfiXw/BRo0QB3S8De1njC+WbxKYjsyeVaH UZpGAyiSqo1Uw4wmTfMUTmfSxmrJMPYVb2LGeJNgwyfisqCx/5uOucCqT5rcQNUjHzsXs4 MXjc5jXS0Krgv7H2AohCnzWyOnd9wQzqP+fWBrEO4rKjOMAzm7vLxCMpFyLwVw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1725197282; a=rsa-sha256; cv=none; b=YdP1UInhxBQ7+PtKf7vBYdoYYhf/6L38znxenRrcVlUjvt9P1HJv5Y9QmZupnKHuBEzXic VEECjf2Nq64P2/ODODzfM83oZg14C+6JjDJJDF1oeOUsThpERMp3f6iBfKcoXJUWF61G1+ qwa83n9n2z9U7LjB1jPGfjTvWS5wnmTPfDO5IfqoCAlzRLmy0UaAphTTE0KPFKy68dvRSF vnBtXM2tKRxmgYTnnBudeFNyqCTcz7azvxGG3JS/P1UOx347LgaG2S/49ABHu94Xz7MPn3 f2s18ITnTNuL+w0F2W6intzB8EalYv2JLhQbevfrDmQmR9nKKpXew24EUaDcSA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725197282; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ai6vc/GXmvT3s0b34aad9GV/JM6nP5J5o6OdydxXnLw=; b=CsuetpSshVaykrkO7XRLaf4gp350ModPhzXZeZkkWeTYMmojhYvTXSaEC49uqh4sWBXGAy TcSffM6XQLJd1k491bpAB6zbZSatcpgeuy2ueGuTU2RXus3OZk3MvOGXqJ3j+1fy0M8rNs 3uEENPQ/y+OyGWBTJGL5cEYco1QfEr37dbfxydTg8/1hJVvK5pegyEcaugKB/JtdHNaqH9 SSKS2z2Ao5C3wAzVqGOpWPsAUc83Hsg2qtEr9+0gntCBY+NmAV1eB2jdZ9V/WoJsIBPUa9 c4d/c98jQ2poMXlrju2LOSTU5bsptlNvwMACVMFkRKJaSuyQvBI8Y2zLJ3X+4w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WxXkn6xjszW4h; Sun, 1 Sep 2024 13:28:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 481DS1ut030750; Sun, 1 Sep 2024 13:28:01 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 481DS1vx030747; Sun, 1 Sep 2024 13:28:01 GMT (envelope-from git) Date: Sun, 1 Sep 2024 13:28:01 GMT Message-Id: <202409011328.481DS1vx030747@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: "Bjoern A. Zeeb" Subject: git: 8adb745dc971 - main - LinuxKPI: add ENAVAIL error code List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: bz X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 8adb745dc9716e769ef0f7e993cea8a07735d5d8 Auto-Submitted: auto-generated The branch main has been updated by bz: URL: https://cgit.FreeBSD.org/src/commit/?id=8adb745dc9716e769ef0f7e993cea8a07735d5d8 commit 8adb745dc9716e769ef0f7e993cea8a07735d5d8 Author: Bjoern A. Zeeb AuthorDate: 2024-08-27 21:05:09 +0000 Commit: Bjoern A. Zeeb CommitDate: 2024-08-31 21:34:01 +0000 LinuxKPI: add ENAVAIL error code Used by an updated wireless driver. Sponsored by: The FreeBSD Foundation MFC after: 3 days Reviewed by: emaste Differential Revision: https://reviews.freebsd.org/D46461 --- sys/compat/linuxkpi/common/include/linux/errno.h | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/compat/linuxkpi/common/include/linux/errno.h b/sys/compat/linuxkpi/common/include/linux/errno.h index ea258587c6f7..d634675d43d0 100644 --- a/sys/compat/linuxkpi/common/include/linux/errno.h +++ b/sys/compat/linuxkpi/common/include/linux/errno.h @@ -68,5 +68,6 @@ #define ENOMEDIUM 532 #define ENOSR 533 #define ELNRNG 534 +#define ENAVAIL 535 #endif /* _LINUXKPI_LINUX_ERRNO_H_ */ From nobody Sun Sep 1 13:28:03 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WxXkq47FGz5VCrN; Sun, 01 Sep 2024 13:28:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WxXkq13Lkz4Kc7; Sun, 1 Sep 2024 13:28:03 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725197283; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=3BYlo+siynmO72SyI4HQVkLcx/RCxox/TahQIPa2SDY=; b=tMmfHiM9shKgWzSg+RgoVmndZh4KTu+gbBRBvn/pHerHdXUKz1WjNYKomUJ5VUnsJTRnrT Ks4JMYKbci8RmMY614u0wQZvz6L1k4z/2waOgvv51g/qRxImjyHbFAT8gGqGzdzRTQg6tc fxehs741aatR0zipcobSU5WD1/NKb4SB32tPiHoprCowqACHr7ltUcMdjfJcS6+VQe0MG+ Bpjjq/6iQfuPDFuAttLOR261rLO1OmO7YF3e5N2aGEJ9zNbKvdS11mxkrANN5tfliN2VtB 96akNr8oglNI/ZibcxZ7EApiCkjgrYWUS08B9yyhV/8IQ+uAtODjU89CNMH/7w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1725197283; a=rsa-sha256; cv=none; b=m4ya36CkIMBQdWDksnFK2q38Jd0V9QBDHU3RPPvSMWj3XGM3WMy+2EKJi7X1qI9xUmx2d2 6pvCQDu9e7fD6CywA74Sb4k+n59b8G8Jun2WdP4HbxsI8+164lI4Zmy3zTMmmEdg+LK645 qkn1DJY9EFbaXZCoe0NmxdT6WFb3GEPvjHXgEGA/Ov+SaeEItnXp62AzB3m7vRcFWeBtIH TTmQHS2pQQCgFOUdmgxMVIOnB+4sFyJ+zYqJj+0XULGTwkbk1bgsX2btCBHVru/EfeCMb5 y+h2Od5nZZgSXMegQSDn9fnmGOoiN01cei5Jh+Xnj+tf6GYBtIuQPLzN7jws7A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725197283; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=3BYlo+siynmO72SyI4HQVkLcx/RCxox/TahQIPa2SDY=; b=uJ2QtJaB2Ab4rMJXFugvZY0SphqRdM0M0corCL/hT7Bc5L1KqhhwZBRX1CpvLmIG6yY9Lr W/TrRbJeOA3BNGB2+trBQs3bL6eA68UV9eWHgV77GMKT/SNUODcaoeO4gpjVWUVzIdmI+N Fj5KKk5WRZ5RYK/Rd+dOecQcTv48/LGGnd+OoPimUQWoGJIpTOwCJHuDD9MLzhCyn1XBrC rtAayp34TQaUbcaN4SaOgEsUwEIuAPd/Ec/IJmOdNW60pQBvj+9hKOYYyUXT5RLD6JQd9/ QgjfPVmC4NIkWMWeDkr1r/x8eAfManN3k4kpWlPs2/Etzg6WZLk+mPCl4fQeGg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WxXkq0W7ZzW4j; Sun, 1 Sep 2024 13:28:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 481DS3gp030789; Sun, 1 Sep 2024 13:28:03 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 481DS3CR030786; Sun, 1 Sep 2024 13:28:03 GMT (envelope-from git) Date: Sun, 1 Sep 2024 13:28:03 GMT Message-Id: <202409011328.481DS3CR030786@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: "Bjoern A. Zeeb" Subject: git: 273cf7d36336 - main - LinuxKPI: add eth_hdr() List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: bz X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 273cf7d36336eeed5fc2ad42e5e12a36e36650a0 Auto-Submitted: auto-generated The branch main has been updated by bz: URL: https://cgit.FreeBSD.org/src/commit/?id=273cf7d36336eeed5fc2ad42e5e12a36e36650a0 commit 273cf7d36336eeed5fc2ad42e5e12a36e36650a0 Author: Bjoern A. Zeeb AuthorDate: 2024-08-27 21:07:52 +0000 Commit: Bjoern A. Zeeb CommitDate: 2024-08-31 21:35:02 +0000 LinuxKPI: add eth_hdr() Add an implementation of eth_hdr() needed by a wireless driver. Sponsored by: The FreeBSD Foundation MFC after: 3 days Reviewed by: emaste Differential Revision: https://reviews.freebsd.org/D46462 --- sys/compat/linuxkpi/common/include/linux/if_ether.h | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/sys/compat/linuxkpi/common/include/linux/if_ether.h b/sys/compat/linuxkpi/common/include/linux/if_ether.h index 3735ad2f5527..6676e8fc142f 100644 --- a/sys/compat/linuxkpi/common/include/linux/if_ether.h +++ b/sys/compat/linuxkpi/common/include/linux/if_ether.h @@ -34,6 +34,7 @@ #define _LINUXKPI_LINUX_IF_ETHER_H_ #include +#include #include @@ -69,4 +70,13 @@ struct ethhdr { uint16_t h_proto; } __packed; +static inline struct ethhdr * +eth_hdr(const struct sk_buff *skb) +{ + struct ethhdr *hdr; + + hdr = (struct ethhdr *)skb_mac_header(skb); + return (hdr); +} + #endif /* _LINUXKPI_LINUX_IF_ETHER_H_ */ From nobody Sun Sep 1 13:28:04 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WxXkr31blz5VCtr; Sun, 01 Sep 2024 13:28:04 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WxXkr1xr1z4KfK; Sun, 1 Sep 2024 13:28:04 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725197284; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vRDkzKruvAECBq+K31zetDerIjtjHDcUSn6FBxcg8aQ=; b=qHsOMMV/r6sGPprBzojIjk0pVV2ZIEFvOzgomyPmZLyeOWwQdeZDh0Vhf4uJm8XnNUxwxe pm73ln5PrAojwg+nweiVUZZBnpQwOdYQBjf6Yge9xzy71wdri0cNzI/pDsNeclBEgwZhzY bh2ORQuKW/BQI5XoeK1D75UB7ahpYJ9t78HTJW9qKLzZVG3be0fHWZxUSoF7+VOO42vxu3 PXiuMocbGmi+cQOS15kf6LBg3iD1Tee7c9Trp/1cPo22BmRE6IRQL5g1xpDou48SOoD0TJ xqx8s6u4NUHhoMUVU5IQrs8ZaQ7Iai34K3rME7Qc4X3r7WZEkHV+sxKCrT45jw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1725197284; a=rsa-sha256; cv=none; b=qUpRFKKoUKwcLWf4fV1UUEzecCX6wnlgeQxarox59v3IoNoto6HhNclxK4FG3BTuDmYJLu pft8rg+A/UmYe+cMxJr1xcGN8rn5CRusPHncs6qc/ZdiedhT8M+GZvLAGRO4hIj4sWNuiF 36/lQ4G0LfRcOTtETb3BIrcuo9kdOLQXMuarV9UHeSHAJK7BOg50A7VOO1CK2YtMB5ZbYR 8b3TWIXBoHSCjTJxtD3QmPoCGjPyA+i4CxqZ4bBYCGbpbDSH6rPKWo002W6MhzcrbflPFH Yh0VKxbXI/Iue0GljOGXxxQh1d/eIaYUe0vb0j+xPjqbIbSdgUwabZTzodbcQA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725197284; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vRDkzKruvAECBq+K31zetDerIjtjHDcUSn6FBxcg8aQ=; b=GShgHKdH/9lb3yzbkbFXx4Uc8Nx3sEq64HdrzbdC2t1+/AR4OBmO5Nx6A/iNIkslHD9698 dwMZYX26oRrYon+QUFhsuI+qByBqebeU7B2VZJMcqD4G+ZPfPc09Mc7onZi4AhdOSvl5Lr ywtr5StSnj2ADY0bOMUIuhN5iDodR+FwnmHMjeAuDlHX87X1QPknceLOebWQUbB3yyjyOY y5V76FnLFVR8UuaLUbiWSoIY5UvaE8sccvD3+ujNgx9zYUYPhCgiWO21wuGLaUS8fJwFnm G+nWYuBBOYABT056GQwlHW3qEpASe7XIKFSFi9Rn+EziUt2HIY9bLwpajyHouQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WxXkr1XdDzVwJ; Sun, 1 Sep 2024 13:28:04 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 481DS4rS030828; Sun, 1 Sep 2024 13:28:04 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 481DS4RW030825; Sun, 1 Sep 2024 13:28:04 GMT (envelope-from git) Date: Sun, 1 Sep 2024 13:28:04 GMT Message-Id: <202409011328.481DS4RW030825@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: "Bjoern A. Zeeb" Subject: git: 1847e63d63f4 - main - LinuxKPI: add no_printk List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: bz X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 1847e63d63f440cfcb2f4ee2c2ee8990f0272d88 Auto-Submitted: auto-generated The branch main has been updated by bz: URL: https://cgit.FreeBSD.org/src/commit/?id=1847e63d63f440cfcb2f4ee2c2ee8990f0272d88 commit 1847e63d63f440cfcb2f4ee2c2ee8990f0272d88 Author: Bjoern A. Zeeb AuthorDate: 2024-08-27 21:12:08 +0000 Commit: Bjoern A. Zeeb CommitDate: 2024-08-31 21:36:01 +0000 LinuxKPI: add no_printk Add a version of no_printk(), which seems to be there to have format string checking while never calling the printk. It seems a very weird thing and it needs a return code and for some reason my initial while (0) { } version hadn't worked while porting over new code but could have been further downstream format string problems. if (0) seems to do the job though I would have expected that to more likely simply get optimised out without any futher format checking. Sponsored by: The FreeBSD Foundation MFC after: 3 days Reviewed by: emaste Differential Revision: https://reviews.freebsd.org/D46463 --- sys/compat/linuxkpi/common/include/linux/printk.h | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/sys/compat/linuxkpi/common/include/linux/printk.h b/sys/compat/linuxkpi/common/include/linux/printk.h index 933d5aa6f94a..3840a6e5fb8a 100644 --- a/sys/compat/linuxkpi/common/include/linux/printk.h +++ b/sys/compat/linuxkpi/common/include/linux/printk.h @@ -125,4 +125,11 @@ print_hex_dump_bytes(const char *prefix_str, const int prefix_type, #define pr_info_ratelimited(fmt, ...) \ printk_ratelimited(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) +#define no_printk(fmt, ...) \ +({ \ + if (0) \ + printk(pr_fmt(fmt), ##__VA_ARGS__); \ + 0; \ +}) + #endif /* _LINUXKPI_LINUX_PRINTK_H_ */ From nobody Sun Sep 1 13:28:05 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WxXkt2Xtjz5VD09; Sun, 01 Sep 2024 13:28:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WxXks39Fqz4KYv; Sun, 1 Sep 2024 13:28:05 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725197285; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=2GNzfFP3B5DWbPT5QiPfO83RqTmmMXG1uZmz90U9YQE=; b=UtULhVPoVou683wxLj8FgX5WA22MBnPpDFpDJWRo9sszFgzZQ1TdpOLujX5dFjb1ZwX31x rATgprTViTqdORnsUtAWsV7YUuXE/2ZsgCw/0FcedvI2G35I1HLAiCjkzfp6F2eVic3sfF njML+Fn7X4q5y5sO1358qluZzkHpnrgOd9+8EFgggfTtYTcfyODfF3HIfDnrJK8ffWDjj4 NoJS68+i0cvSUgqfgLAFR96nsgu696Vn0CKW5SEltSUjjM5g5EkJYbNJNC8LVJk9VkepIh 8IZ0Aq/q4NL7x5bylrJ0YF25LmeP8H6hcL330iqKdkbBvVbra0IMJd83Gu8mHQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1725197285; a=rsa-sha256; cv=none; b=VYu3/CR3HflprCE5Ub7cSbi5W+XyNqS6Yctfp32gqxG4qB0Qo5i8yjdxPJfapC0+i2UswR q35GtQxtIGJikeyEeg90UACwmTR/n83g59LM4ClucaOYGsSdLKXMCeqEtK7rTLm/OiUXe7 czgaFHn0m/bO+woDYY7Y5xQFcDBmaLKg2us9UV9J3CK6Tb83HTl/2jUYYyBRKj3PdE9WUK gzSy/KbI0UwdqOt43ohZRo8IQKxc65VVbDs+1SA7Vj+QXRP3irJ5koPXSNzVmwvi7gzX4/ OWrlNYKLrbx55MmlWTfI7HqKwDfAKsc4VjfpW12sVRexA6IInu6XPykhObHerQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725197285; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=2GNzfFP3B5DWbPT5QiPfO83RqTmmMXG1uZmz90U9YQE=; b=m9UkvZrESn3R1p4GwzvoTRzdjhi9ZFXGe5CorIZ9uYnLQD1eeEoFNz5sTKE4Dk+w+yJMuC NB6CIMYVQXlmEGwg1aIxLHTXYl+g6qf+cVg5vVBCYyJh/5BRJRJiDMFayCzHyLSom4Ae9p SwWHWrHAGkgtcjOtNPZZfHTXIfY5NBWQbsHeBKmkYTA71cmLyPlmBnyEcFJWuFFV6pDWtv +wXVES0B8Q7Vn1F+5mdh0DpMpbgomMpNR4f486rmPtQn97GKyfWIeytXhRU34uYJoDEgpJ uvxgvta49XyuJpa+Cfi9+xcy47LVv1GoI+CZPGf6kiH8SjEDvCuyAOlErurDaA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WxXks2k0fzV89; Sun, 1 Sep 2024 13:28:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 481DS54I030874; Sun, 1 Sep 2024 13:28:05 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 481DS54q030871; Sun, 1 Sep 2024 13:28:05 GMT (envelope-from git) Date: Sun, 1 Sep 2024 13:28:05 GMT Message-Id: <202409011328.481DS54q030871@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: "Bjoern A. Zeeb" Subject: git: b4ef1b1be753 - main - tools/sdiodevs2h.awk: introduce palias List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: bz X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: b4ef1b1be753952a4aafa505817164624f712c37 Auto-Submitted: auto-generated The branch main has been updated by bz: URL: https://cgit.FreeBSD.org/src/commit/?id=b4ef1b1be753952a4aafa505817164624f712c37 commit b4ef1b1be753952a4aafa505817164624f712c37 Author: Bjoern A. Zeeb AuthorDate: 2024-08-27 18:41:17 +0000 Commit: Bjoern A. Zeeb CommitDate: 2024-08-31 21:37:53 +0000 tools/sdiodevs2h.awk: introduce palias Some of the defined names are not the direct 1:1 mapping with vendor and device names used by Linux device drivers. Introduce a p(roduct)alias so we can map the one device entry I came across without much extra hassle and generate a name device drivers know about: palias BROADCOM_CYPRESS_43439 CYPRESS_43439 Sponsored by: The FreeBSD Foundation MFC after: 3 days Reviewed by: emaste Differential Revision: https://reviews.freebsd.org/D46455 --- sys/tools/sdiodevs2h.awk | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/sys/tools/sdiodevs2h.awk b/sys/tools/sdiodevs2h.awk index 596d09531ab1..99735dc09a62 100644 --- a/sys/tools/sdiodevs2h.awk +++ b/sys/tools/sdiodevs2h.awk @@ -149,6 +149,18 @@ function product(hfile) printf("\n") > hfile } +function palias(hfile) +{ + nproducts++ + + products[nproducts, 1] = $2; # vendor name + products[nproducts, 2] = $3; # product id + products[nproducts, 3] = $4; # id + if (hfile) + printf("#define\tSDIO_DEVICE_ID_%s\tSDIO_DEVICE_ID_%s\n", \ + $2, $3) > hfile +} + function dump_dfile(dfile) { printf("\n") > dfile @@ -243,6 +255,10 @@ while ((getline < srcfile) > 0) { product(hfile) continue } + if ($1 == "palias") { + palias(hfile) + continue + } if ($0 == "") blanklines++ if (hfile) From nobody Sun Sep 1 13:28:06 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WxXkt6nTBz5VD4c; Sun, 01 Sep 2024 13:28:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WxXkt496Rz4Khq; Sun, 1 Sep 2024 13:28:06 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725197286; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WkuV+ac0sUo2HM2anfNknT9byuwU8l/lChmo9xRsnNM=; b=yzyngnZorScRKowOBtXtz1OC2VsThVa/GBGjSKWxtRJOX4VcBmBnaM0l9VQRUotVGoU8WA 2IAqW6d3kCCI6EVKQpjEqWBM7/IRv77X+WNTCvLpau5a3MgF+5qU8gb6f8UYq3BHjaDtCZ QUZXPNounk7RDPW+xZqwcjU2V4C20vGYn4uMgMRk9MiwkvH1vdVuMAoasp48usr2xphxyA GgAgOCG12Thyj6eDuXZGudor4ymn42azSfzRTsqXHTC+OWPUTScBpsu5P/7nBmfXzdF1/w 6kG46PGUjig5hjzSPZRhHvsLxBAIur/uuAMpDZJkpqW8939LnKJOLmnis8uQWg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1725197286; a=rsa-sha256; cv=none; b=eF65WPu2WTlWvv8G/P83t/NS18XwD7uylb9sCxWuI87I9Ayd+NMtRZ6HhZiMdJEcEUDsHX 69WPicebESb5ALhP7/6WjXkOzxUTx9irLiBFv8MJjZPYZ4qE2l4KD9OBhZedgj75R48S57 ODxuKnaWm09scMY2zZsOxoC/rRZ7BzFWsoHzF+vd86YUSXQdU9iKB8IWnBCuStmY1SldZO At8Opd+AqoFwBO+dxpux8hksXwtvo0wozEuWswDeat+bbr0pb9CLhPD9aGI3QxXMy421Lg pE0HVaSed0ubvGjJiKGWKbB1IdYLJXWv9mIiUPMJVyaxk6GVi/nND7ZoGd1jOw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725197286; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WkuV+ac0sUo2HM2anfNknT9byuwU8l/lChmo9xRsnNM=; b=nUqt7W4UVk16HXAybEf0J2yGgrciE/NEWWntZPuJC1RuIPm9dBq/j103IsoWXK08l1GW0K 2pesjWacQJxs6HHV1ULKUblyyi0/o98TcjHOn5rRmcDG4uM5CAbEQwY8nuymbOZGZloi76 nDDc2tgmi1+xemjqb5OOya1WgmYgMOytA2h4PzbjpXcXnxgXqaMXY1o+zX5eeKF5tEsuSC zi/b9F4VsBe4oM4Ku1o9L1pfAGyZjfgrDzf2w1zYvHMoDrD5obzOZW5wI4oWAv144jy20C yOK/vh3tWbrbUU8M4aPoQab0sjmzgwJxwgKza2Yl4EHKHsZ8e508+/bBf2Bb1Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WxXkt3lMszV3P; Sun, 1 Sep 2024 13:28:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 481DS6vl030922; Sun, 1 Sep 2024 13:28:06 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 481DS6L3030919; Sun, 1 Sep 2024 13:28:06 GMT (envelope-from git) Date: Sun, 1 Sep 2024 13:28:06 GMT Message-Id: <202409011328.481DS6L3030919@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: "Bjoern A. Zeeb" Subject: git: a800b5bcd1b6 - main - sdiodevs: add more vendors and devices List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: bz X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: a800b5bcd1b6638530d3a0759b17cd8d93b7e7ca Auto-Submitted: auto-generated The branch main has been updated by bz: URL: https://cgit.FreeBSD.org/src/commit/?id=a800b5bcd1b6638530d3a0759b17cd8d93b7e7ca commit a800b5bcd1b6638530d3a0759b17cd8d93b7e7ca Author: Bjoern A. Zeeb AuthorDate: 2024-08-27 20:12:20 +0000 Commit: Bjoern A. Zeeb CommitDate: 2024-08-31 21:38:57 +0000 sdiodevs: add more vendors and devices Add IDs for Realtek, Atheros (QCA), and Mediatek. While I am not sure we'll ever support the ath10k and possibly mt76 SDIO devices, rtw88 ones can be found with SoCs (e.g. r2s-plus) and are actively being worked on. Update Broadcom/Cypress entries. Sponsored by: The FreeBSD Foundation MFC after: 3 days Reviewed by: emaste Differential Revision: https://reviews.freebsd.org/D46460 --- sys/dev/sdio/sdiodevs | 32 +++++++++++++++++++++++++++++++- 1 file changed, 31 insertions(+), 1 deletion(-) diff --git a/sys/dev/sdio/sdiodevs b/sys/dev/sdio/sdiodevs index 194ef8e5d901..8c341e77d9f9 100644 --- a/sys/dev/sdio/sdiodevs +++ b/sys/dev/sdio/sdiodevs @@ -42,8 +42,11 @@ * List of TPLMID_MANF "vendor ID"s. * Please sort by vendor ID ascending. */ +vendor REALTEK 0x024c Realtek +vendor ATHEROS 0x0271 Atheros vendor BROADCOM 0x02d0 Broadcom vendor CYPRESS 0x02d0 Cypress/Broadcom +vendor MEDIATEK 0x037a MediaTek /* * -------------------------------------------------------------------------- @@ -51,6 +54,21 @@ vendor CYPRESS 0x02d0 Cypress/Broadcom * Please group by vendor in same order as above. */ +/* Realtek products */ +/* PR 251063 */ +product REALTEK RTW8723BS 0xb723 802.11bgn SDIO WLAN with Bluetooth 4.0 Single-Chip Controller +/* rtw88 */ +product REALTEK RTW8821BS 0xb821 +product REALTEK RTW8822BS 0xb822 802.11ac/abgn SDIO WLAN with Bluetooth 4.1 Single-Chip Controller +product REALTEK RTW8821CS 0xc821 802.11ac/abgn SDIO WLAN with Bluetooth 4.2 Single-Chip Controller +product REALTEK RTW8822CS 0xc822 802.11ac/abgn SDIO WLAN with Bluetooth x.x Single-Chip Controller +product REALTEK RTW8723DS_1ANT 0xd724 802.11bgn SDIO WLAN with Bluetooth 4.2 Single-Chip Controller +product REALTEK RTW8723DS_2ANT 0xd723 802.11bgn SDIO WLAN with Bluetooth 4.2 Single-Chip Controller + +/* Atheros/QCA products */ +product ATHEROS AR6005 0x050a Qualcomm Atheros 802.11ac WLAN SDIO +product ATHEROS QCA9377 0x0701 Qualcomm Atheros 802.11ac WLAN SDIO + /* Broadcom products */ product BROADCOM 43241 0x4324 BCM43241 fullmac SDIO WiFi product BROADCOM 4329 0x4329 BCM4329 fullmac SDIO WiFi @@ -61,13 +79,25 @@ product BROADCOM 4339 0x4339 BCM4339 fullmac SDIO WiFi product BROADCOM 4345 0x4345 BCM4345 fullmac SDIO WiFi product BROADCOM 4354 0x4354 BCM4354 fullmac SDIO WiFi product BROADCOM 4356 0x4356 BCM4356 fullmac SDIO WiFi +product BROADCOM 4359 0x4359 BCM4359 fullmac SDIO WiFi product BROADCOM 43143 0xa887 BCM43143 fullmac SDIO WiFi product BROADCOM 43340 0xa94c BCM43340 fullmac SDIO WiFi product BROADCOM 43341 0xa94d BCM43341 fullmac SDIO WiFi product BROADCOM 43362 0xa962 BCM43362 fullmac SDIO WiFi product BROADCOM 43364 0xa9a4 BCM43364 fullmac SDIO WiFi product BROADCOM 43430 0xa9a6 BCM43430 fullmac SDIO WiFi +product BROADCOM 43439 0xa9af BCM43439 fullmac SDIO WiFi product BROADCOM 43455 0xa9bf BCM43455 fullmac SDIO WiFi -product CYPRESS 4373 0x4373 CY4373 fullmac SDIO WiFi +product BROADCOM CYPRESS_4373 0x4373 BCMCY4373 fullmac SDIO WiFi +product BROADCOM CYPRESS_43012 0xa804 BCMCY43012 fullmac SDIO WiFi +product BROADCOM CYPRESS_43752 0xaae8 BCMCY43752 fullmac SDIO WiFi +product BROADCOM CYPRESS_89359 0x4355 BCMCY89359 fullmac SDIO WiFi + +product CYPRESS 43439 0xbd3d CY43439 fullmac SDIO WiFi +palias BROADCOM_CYPRESS_43439 CYPRESS_43439 + +/* MediaTek products */ +product MEDIATEK MT7663S 0x7603 MediaTek MT7663S SDIO WiFi +product MEDIATEK MT7921S 0x7901 MediaTek MT7921S SDIO WiFi /* end */ From nobody Sun Sep 1 14:09:40 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WxYfs0WKxz5VGcM; Sun, 01 Sep 2024 14:09:41 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WxYfr5R73z4Qfx; Sun, 1 Sep 2024 14:09:40 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725199780; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=5FsGTa4BPyawrhgoaPnxrh54ccANbd6G7NDH8uYlQOE=; b=f3Fh0Ivke5gqdOKMZFshZZ/Xpv6jzxZYs5pPfBnXgDf/Bq7uV1Mn18Ax0gPbVB9kBdvlOn uF/+Mabvjv41862SKFtT31KDqJRM7AeFZsePjMux5pkrAfTriEDayyWOJiV3FO5G1ElcRg J9h0Cnd3p8mgWsgHBcTsb1C5FtHuBKwOoUItUhgB783D+SDafnSbqM4+HQSq3klL+7SJtB UB1afdo/QdnM2fXoS91/gPdEdZis2X3q7nlANZtgxh7Ez5qy6vlIVsE/Y/4Ib5GcUbcdaK xPpwgwI0Q23fkQPN6DCYn4adpo2CoU87ZX3tHXAvQxkfn4sM1BMZeR/ijfDQuQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1725199780; a=rsa-sha256; cv=none; b=Iy+fS0nKbcdzB+CKl9B0LEmVSdILZ10xoKOIYfzEbUcW3udJkUiQkUIAnADTU0awfJE66l wsU+K9bVsFZgMSttuj6kthERWQRNJGsbFq4iDyQ0ZXi9g0Pk1Y9oej54Jg+D/kOPQsmllj yqaSl0zxxWHXkd83BNtcEoNw96w/Hj25TyN8qoymt8PJlof5HJEzT5lQU9HULmAXZz28h8 BJ2v3iEq6Qk0JWExRdi1iDUhdZ/CG7LBFPJeEpliX1J5dE/LEMWJvVR8w626Tz33syNaHc BIJieb1kb/dl7ut9wwd6BA9S5L9fiLSWHktwwh7iVi4oRe4/XLuSWkg4xzO9Zw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725199780; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=5FsGTa4BPyawrhgoaPnxrh54ccANbd6G7NDH8uYlQOE=; b=Wtgd7PJ4Yze/GQL6WcMhy+AI6eKzPP+7mQ3w1pjrzaCMdw5MZaY7xRvv6DIvYYsloArGE9 pk4756pBJ/4kfZ50DOzz25IHGtdZ0WwPykHqStrTfGtAG5VDW6WelByELYbqOSGtxyDj7p h7snS9NBzpCqqdl1NIC9I97dwGQJDAu2IZi4xgJeFtjesuypB2m/MY7PM/S9/31sD40Uxu W81JzpD+qiPvXuV2hEyNR9twy0E8uXelcc70qeeC9PzHUQ4d0l+CME3h6rWJNkobepWniX XqbidGT//1de8TM8Dx3+hhMBFwaVe6ehxKipDyvBrSsjVzMwaRMzQAZvG7zndw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WxYfr52R7zXcw; Sun, 1 Sep 2024 14:09:40 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 481E9eFp099555; Sun, 1 Sep 2024 14:09:40 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 481E9e3w099552; Sun, 1 Sep 2024 14:09:40 GMT (envelope-from git) Date: Sun, 1 Sep 2024 14:09:40 GMT Message-Id: <202409011409.481E9e3w099552@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: 780675e1bed9 - main - arm64: Fix the VM_MAX_NAMELEN definition List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 780675e1bed9fa8e328327e3b6416642a16b2a98 Auto-Submitted: auto-generated The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=780675e1bed9fa8e328327e3b6416642a16b2a98 commit 780675e1bed9fa8e328327e3b6416642a16b2a98 Author: Mark Johnston AuthorDate: 2024-09-01 14:00:20 +0000 Commit: Mark Johnston CommitDate: 2024-09-01 14:03:15 +0000 arm64: Fix the VM_MAX_NAMELEN definition The maximum VM name length has changed since the arm64 vmm code was forked. For now, just sync with the amd64 definitions, since they permit longer VM names. As arm64/vmm is implemented only in main, I won't bother dealing with backward compat. Reviewed by: jhb Differential Revision: https://reviews.freebsd.org/D46484 --- sys/arm64/include/vmm.h | 26 +++++++++++++++++++++----- 1 file changed, 21 insertions(+), 5 deletions(-) diff --git a/sys/arm64/include/vmm.h b/sys/arm64/include/vmm.h index 05b013557c06..acbd8f5cbcb9 100644 --- a/sys/arm64/include/vmm.h +++ b/sys/arm64/include/vmm.h @@ -102,14 +102,30 @@ enum vm_reg_name { #define VM_INTINFO_HWEXCEPTION (3 << 8) #define VM_INTINFO_SWINTR (4 << 8) -#define VM_MAX_SUFFIXLEN 15 - #define VM_GUEST_BASE_IPA 0x80000000UL /* Guest kernel start ipa */ -#ifdef _KERNEL - -#define VM_MAX_NAMELEN 32 +/* + * The VM name has to fit into the pathname length constraints of devfs, + * governed primarily by SPECNAMELEN. The length is the total number of + * characters in the full path, relative to the mount point and not + * including any leading '/' characters. + * A prefix and a suffix are added to the name specified by the user. + * The prefix is usually "vmm/" or "vmm.io/", but can be a few characters + * longer for future use. + * The suffix is a string that identifies a bootrom image or some similar + * image that is attached to the VM. A separator character gets added to + * the suffix automatically when generating the full path, so it must be + * accounted for, reducing the effective length by 1. + * The effective length of a VM name is 229 bytes for FreeBSD 13 and 37 + * bytes for FreeBSD 12. A minimum length is set for safety and supports + * a SPECNAMELEN as small as 32 on old systems. + */ +#define VM_MAX_PREFIXLEN 10 +#define VM_MAX_SUFFIXLEN 15 +#define VM_MAX_NAMELEN \ + (SPECNAMELEN - VM_MAX_PREFIXLEN - VM_MAX_SUFFIXLEN - 1) +#ifdef _KERNEL struct vm; struct vm_exception; struct vm_exit; From nobody Sun Sep 1 14:09:41 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WxYft01bfz5VGqZ; Sun, 01 Sep 2024 14:09:42 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WxYfs6RPNz4Qfy; Sun, 1 Sep 2024 14:09:41 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725199781; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=iWxAv0QwF4LvPi3vVaUr0gnACOrMIItv83G5z0SAWpA=; b=u+dIAJZiHP9UP8To4UjVWeR2d4JN2rF66iZE8hQpW1WmnWTBycZLOcPC8B0U8N8yPMnp9b /t3FCRxVsxZR41q8TehK7einDuJZVYL1hI+G/YikD22BSsyrqWapjKZ4exOntNLolrJf14 JjUzb3BsnvZ3xgMfrL/S29gRkDoNCvCt5Vvu0TY6D82zWMuJgiKpB4e2oTYnLiG3HvTRGL QCcPZ5AE0QN91tdgOr5w6iiTa+ef8PXQ+6s0u3Jc3ujD6CiWV+yXzb3utN1bj/JCT4bk6Q tj9D8N/3uRt4HSuU2VGVchjdF0z8o7dREf9jjFOzQrrK3K3GmbzAI0H44R8Hkg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1725199781; a=rsa-sha256; cv=none; b=M3L/wCJgerPJ81SOq6HxtFVGaeApoP1/9El2JScKNRk1H7HhGKQ66g+e6lqBEqbaQ/mSpF Zmqyy6ZusdHTHPj13kgznVjnZCE77X01qkFeb8EFE8t+9Lrl/IhcDHc9NK7t119nLqjA52 bVvcvPeEv7o9llKUaReWfEly9GEkta1g1yiGK4LcqPDen/92kP2m/omhGVJTZf+ykDOR1g Jtl+3xdQ0GS0IuQFFs8E5bsWRxaiYFJPOK8IYOPqTKv+W2EQHklIUp0QZE4Qxz9EjVkXJf yGvYHk8P8Adtkm/oHpuAKIwWZqQ8ecrNP6T/kgRcwLpQeAVarT49KFpbRFGEHg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725199781; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=iWxAv0QwF4LvPi3vVaUr0gnACOrMIItv83G5z0SAWpA=; b=SBEZbLRPNJ0+HkqJ0pmBlJLcH7hwSg56cR4HTLCcPoqoGSEuqw6ijYU22qudDqFmuEHsiV y8/IM9LtXJfZvhGTf+YmUce763Ku2M/tadshlbXlJ/JunnWWc1VtXznhsD7MEUZGCVmCtd 0NM2r09mHtrpH4xBzcdOZ9Upac0yRHBP3aAcHx+a/SZz0ohluSXJskt+uQtO/JokMLjtzI vGIDObhRitZrB+fsk4/D+AOH1FHtiJdGkPWyiRpvmXrHo0c/Mw++eWeTdB95QKXTrVRR6y rhHxeDQw3mL4Np/QuKJKMy+lh2trwTqL2CwrQRNHNkpaT7wx0BjWOp7x32oCUQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WxYfs62pszXbK; Sun, 1 Sep 2024 14:09:41 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 481E9fNx099597; Sun, 1 Sep 2024 14:09:41 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 481E9fhZ099594; Sun, 1 Sep 2024 14:09:41 GMT (envelope-from git) Date: Sun, 1 Sep 2024 14:09:41 GMT Message-Id: <202409011409.481E9fhZ099594@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: 133a513ddc9a - main - vmm: Make vmm_dev.h more self-contained List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 133a513ddc9aedf83489373f4af9971347bc6201 Auto-Submitted: auto-generated The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=133a513ddc9aedf83489373f4af9971347bc6201 commit 133a513ddc9aedf83489373f4af9971347bc6201 Author: Mark Johnston AuthorDate: 2024-09-01 14:00:26 +0000 Commit: Mark Johnston CommitDate: 2024-09-01 14:03:15 +0000 vmm: Make vmm_dev.h more self-contained vmm.h is required for VM_MAX_SUFFIXLEN. vmm_snapshot.h is required for struct vm_snapshot_meta. This is a prerequisite for including vmm_dev.h in the headers parsed by libsysdecode. Reviewed by: jhb Differential Revision: https://reviews.freebsd.org/D46485 --- sys/amd64/include/vmm_dev.h | 3 ++- sys/arm64/include/vmm_dev.h | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/sys/amd64/include/vmm_dev.h b/sys/amd64/include/vmm_dev.h index 5f347e46b9c4..b77b0ef5d996 100644 --- a/sys/amd64/include/vmm_dev.h +++ b/sys/amd64/include/vmm_dev.h @@ -29,7 +29,8 @@ #ifndef _VMM_DEV_H_ #define _VMM_DEV_H_ -struct vm_snapshot_meta; +#include +#include struct vm_memmap { vm_paddr_t gpa; diff --git a/sys/arm64/include/vmm_dev.h b/sys/arm64/include/vmm_dev.h index 08c237d31046..938bea47c7f8 100644 --- a/sys/arm64/include/vmm_dev.h +++ b/sys/arm64/include/vmm_dev.h @@ -27,6 +27,8 @@ #ifndef _VMM_DEV_H_ #define _VMM_DEV_H_ +#include + struct vm_memmap { vm_paddr_t gpa; int segid; /* memory segment */ From nobody Sun Sep 1 14:09:42 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WxYfv23SXz5VGjL; Sun, 01 Sep 2024 14:09:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WxYfv0K8Tz4Qd0; Sun, 1 Sep 2024 14:09:43 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725199783; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=tPN2cOMthTEcSylOs06U7IoekojfwgGOMbFasV/hjro=; b=Dg9y2VI1Qp09nLzRN0R90uqweKUU2yLrTqqXN4qJ1LuO/3vvyYTjKb8EuNAR7srTYUIcDD w/6OHDoUhcmCCsISg3AM6Ikfl5dyYwcsakYCQpD/C4rnRnAV0gLFYMT0S+k7tvfjsppJBi PP5m7eSNW4eeUatZP9bc/Qv/4mPzEODvME1m7skCMIPkjOXjEe1KP/1SsEOxJwpIyYXPLX 4fDy0yajrjiJ843ElmJRJbl9Qon026wxlyEqSwgF6eTx60bawGH1cdYskusDxjbLFuEkED 8jqXY5SBDQMQZurcbDy8A65q1hAwKngBVatVO94itJeZ2i3wDQSxnbIYX76DcA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1725199783; a=rsa-sha256; cv=none; b=RLXpQiekPlLzCTXuAWJ6n5GKL5KVrxZiZxMS20B2r2jGICtUgi/GDzhojTA4WD/UQLl25x pZdaeENki5MGBOZZ1HutAWCTX29ETVdT9sAVQ+vwMsI5m9n+2Jgbif4bP90ldZWnO/nWEK fLL1GLt97nvyMIDTVcvdLcp+oUj8c7LfPLyTQDaXS6M1RJ59bxrNCYCTwcrqlcfh51L1IZ WSmtKIjhx/x5ViJp0zX0d+rnL8SJDLLVg/EtqQY2UyG4Lu2+L/6xlNmKJA5N3bgHXVXP7f KPMttppGfdzAroF8Upl+I+fFNKJ+nErMXiCz9lUprT3eTVUsqDVvqWGbs8vlMA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725199783; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=tPN2cOMthTEcSylOs06U7IoekojfwgGOMbFasV/hjro=; b=c8jnm11Xwqlm2Y3GgJiCsJ5Ull/DpY2st23DMETDPhl9EwaMCQB347uNtaZA8joLNE6bN+ APxYmOPnMPqmiUTLkuBsH2zTJ4pK6QCJAm+NDyCfaamUc1MoNTeOZhb8aK9Jy0LD3avCI2 mYjh9HcYBlrPhNUcFVjWOBrcKYaAizyhCWa1saKgKNae8xwoKzhrPPxogjT6V4uHzZCUbJ pHpeXySX6UWkgoHP6Ch3IknX/kciP9sNebLr/O3kaBGAwc9uZDjSLSmIuZdf2z/unnJ/I4 AFa5OcdgPpo0Nl9IxsGnbE8ZegeX5b/3OFWhL0Ki/lVjO4uVmpRTbLzuVfBJ4w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WxYft731DzX4l; Sun, 1 Sep 2024 14:09:42 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 481E9gGm099648; Sun, 1 Sep 2024 14:09:42 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 481E9ghn099645; Sun, 1 Sep 2024 14:09:42 GMT (envelope-from git) Date: Sun, 1 Sep 2024 14:09:42 GMT Message-Id: <202409011409.481E9ghn099645@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: 4008758105a6 - main - vmm: Validate credentials when opening a vmmdev List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 4008758105a6da9eaa0b96b81dfb3042a33259be Auto-Submitted: auto-generated The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=4008758105a6da9eaa0b96b81dfb3042a33259be commit 4008758105a6da9eaa0b96b81dfb3042a33259be Author: Mark Johnston AuthorDate: 2024-09-01 14:00:32 +0000 Commit: Mark Johnston CommitDate: 2024-09-01 14:03:16 +0000 vmm: Validate credentials when opening a vmmdev Rather than performing privilege checks after a specific VM's device file is opened, do it once at the time the device file is opened. This means that one can continue to access a VM via its device fd after attaching to a jail which does not have vmm enabled, but this seems like a reasonable semantic to have anyway. Reviewed by: jhb Differential Revision: https://reviews.freebsd.org/D46486 --- sys/dev/vmm/vmm_dev.c | 39 +++++++++++++++++++++++++++------------ 1 file changed, 27 insertions(+), 12 deletions(-) diff --git a/sys/dev/vmm/vmm_dev.c b/sys/dev/vmm/vmm_dev.c index f43429de4d4c..b4ae2997006f 100644 --- a/sys/dev/vmm/vmm_dev.c +++ b/sys/dev/vmm/vmm_dev.c @@ -186,10 +186,6 @@ vmmdev_rw(struct cdev *cdev, struct uio *uio, int flags) void *hpa, *cookie; struct vmmdev_softc *sc; - error = vmm_priv_check(curthread->td_ucred); - if (error) - return (error); - sc = vmmdev_lookup2(cdev); if (sc == NULL) return (ENXIO); @@ -327,6 +323,32 @@ vm_set_register_set(struct vcpu *vcpu, unsigned int count, int *regnum, return (error); } +static int +vmmdev_open(struct cdev *dev, int flags, int fmt, struct thread *td) +{ + struct vmmdev_softc *sc; + int error; + + sc = vmmdev_lookup2(dev); + KASSERT(sc != NULL, ("%s: device not found", __func__)); + + /* + * A user can only access VMs that they themselves have created. + */ + if (td->td_ucred != sc->ucred) + return (EPERM); + + /* + * A jail without vmm access shouldn't be able to access vmm device + * files at all, but check here just to be thorough. + */ + error = vmm_priv_check(td->td_ucred); + if (error != 0) + return (error); + + return (0); +} + static const struct vmmdev_ioctl vmmdev_ioctls[] = { VMMDEV_IOCTL(VM_GET_REGISTER, VMMDEV_IOCTL_LOCK_ONE_VCPU), VMMDEV_IOCTL(VM_SET_REGISTER, VMMDEV_IOCTL_LOCK_ONE_VCPU), @@ -375,10 +397,6 @@ vmmdev_ioctl(struct cdev *cdev, u_long cmd, caddr_t data, int fflag, const struct vmmdev_ioctl *ioctl; int error, vcpuid; - error = vmm_priv_check(td->td_ucred); - if (error) - return (error); - sc = vmmdev_lookup2(cdev); if (sc == NULL) return (ENXIO); @@ -681,10 +699,6 @@ vmmdev_mmap_single(struct cdev *cdev, vm_ooffset_t *offset, vm_size_t mapsize, int error, found, segid; bool sysmem; - error = vmm_priv_check(curthread->td_ucred); - if (error) - return (error); - first = *offset; last = first + mapsize; if ((nprot & PROT_EXEC) || first < 0 || first >= last) @@ -833,6 +847,7 @@ SYSCTL_PROC(_hw_vmm, OID_AUTO, destroy, static struct cdevsw vmmdevsw = { .d_name = "vmmdev", .d_version = D_VERSION, + .d_open = vmmdev_open, .d_ioctl = vmmdev_ioctl, .d_mmap_single = vmmdev_mmap_single, .d_read = vmmdev_rw, From nobody Sun Sep 1 14:09:44 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WxYfw3xq9z5VGnN; Sun, 01 Sep 2024 14:09:44 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WxYfw1PTPz4Qd5; Sun, 1 Sep 2024 14:09:44 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725199784; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=SWcGKZsDMXGZ8ju+UCTOZlIicu/oKFKVKWTqN7tPIrk=; b=SJ4UErBF9jDGqGBBuTa6j+NfCpbRaSypObgx4WkR9ZWJWh87vFx9vr/+WqNQyAdNZcSx6K HQoedNjQ+UdfvUQ6GvwcM0Rphtx/De6QFnyXZou9omH84KiVeYwcpSxlKg8efvJCSVUpmH NXPGXlp5qEoC4SwXe6hue94Tc9kglx3c07uITZFged70MU4qJJcbZ1+EwMlck3IBDp3hZN KZvtJlqDD6zOviQnQWJeMY7C3wVSjrfI1k4z4cTsxa7KXb/imClsiOUU/rZ+znwnYYOX4L sBMn7T4SlqAbpUTfTcIdw5LBUspLjPjF9Gw6c1maup9f8xNwGeKZitYmhKu5Fw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1725199784; a=rsa-sha256; cv=none; b=C8oXWfUtNULB0jasvKZyOF4zHgQFKALGmORs7fzPWAWR85sdtOdULQZl2CuqAc2qs4nxYL 4c4UNlXwTztUmeJfLVVRR7GidkJicNi4IGh8fD9VTzvqdBGfnGjxMoUix7gBiaBmh+OHVS CqY2eQ+0dIg9zGFP6UPRX+Wi0y4Xy4YZuGN3RZ3vBmodOpo5ou+mYZ64KIETVTSicYD3ip 2EN53gokA47w3JsKxqD2Fqm5O3ISZuR9T+xu9RbxfbszJZSe8mEWMh92+eMaLuXPOtBaFR USVxEIWLeDGEzhIy7r5TUQW59nSs7RmLUoGJIAeaYaWTnTiX4bdgetAbQUntwQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725199784; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=SWcGKZsDMXGZ8ju+UCTOZlIicu/oKFKVKWTqN7tPIrk=; b=e7ZIWspJDtSJ6j1oShc0z93wRB9Jv1oVlQcGGVNuwqnQ5feSNiC+D3UCy9hMeWBNz28UG2 HzZDVa/J65dR856gPRXUsSphFYOyg2NkPlUE2s1TFisj62dYJLqYq+syS2c8ft175q6Hbm Ohx0cT3VJaDUEtPRBA3eDk7/VDW9vjN4qmsq46c5BLsJf193o34JvEwmbnb3KXCzymqoGQ 9Oh1/aoWhnrazWDqC/yFB0B8IGo+9OatS4OgUVQzlB9bgd0PDrFkJ6lTKs5ZYvOH0NW3aW 0gKHAa9Z8GFZnrut+fOUEG/P0Xb+lweldSygZIjQ8J/Qth8F1FiAaWozbkhDrQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WxYfw0zBQzX4m; Sun, 1 Sep 2024 14:09:44 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 481E9ifg099704; Sun, 1 Sep 2024 14:09:44 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 481E9ixt099701; Sun, 1 Sep 2024 14:09:44 GMT (envelope-from git) Date: Sun, 1 Sep 2024 14:09:44 GMT Message-Id: <202409011409.481E9ixt099701@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: 887c0877a642 - main - vmm: Use an sx lock for vmmdev_mtx List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 887c0877a642c7427aff0cfd0d844b2711e71e1e Auto-Submitted: auto-generated The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=887c0877a642c7427aff0cfd0d844b2711e71e1e commit 887c0877a642c7427aff0cfd0d844b2711e71e1e Author: Mark Johnston AuthorDate: 2024-09-01 14:00:36 +0000 Commit: Mark Johnston CommitDate: 2024-09-01 14:03:16 +0000 vmm: Use an sx lock for vmmdev_mtx This will make it easier to atomically create the device file and set its si_drv1 member. Reviewed by: jhb Differential Revision: https://reviews.freebsd.org/D46487 --- sys/dev/vmm/vmm_dev.c | 38 +++++++++++++++++++------------------- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/sys/dev/vmm/vmm_dev.c b/sys/dev/vmm/vmm_dev.c index b4ae2997006f..91d33ccba261 100644 --- a/sys/dev/vmm/vmm_dev.c +++ b/sys/dev/vmm/vmm_dev.c @@ -13,9 +13,9 @@ #include #include #include -#include #include #include +#include #include #include #include @@ -63,8 +63,8 @@ struct vmmdev_softc { static SLIST_HEAD(, vmmdev_softc) head; static unsigned pr_allow_flag; -static struct mtx vmmdev_mtx; -MTX_SYSINIT(vmmdev_mtx, &vmmdev_mtx, "vmm device mutex", MTX_DEF); +static struct sx vmmdev_mtx; +SX_SYSINIT(vmmdev_mtx, &vmmdev_mtx, "vmm device mutex"); static MALLOC_DEFINE(M_VMMDEV, "vmmdev", "vmmdev"); @@ -156,7 +156,7 @@ vmmdev_lookup(const char *name, struct ucred *cred) { struct vmmdev_softc *sc; - mtx_assert(&vmmdev_mtx, MA_OWNED); + sx_assert(&vmmdev_mtx, SA_XLOCKED); SLIST_FOREACH(sc, &head, link) { if (strcmp(name, vm_name(sc->vm)) == 0) @@ -785,9 +785,9 @@ vmmdev_destroy(struct vmmdev_softc *sc) crfree(sc->ucred); if ((sc->flags & VSC_LINKED) != 0) { - mtx_lock(&vmmdev_mtx); + sx_xlock(&vmmdev_mtx); SLIST_REMOVE(&head, sc, vmmdev_softc, link); - mtx_unlock(&vmmdev_mtx); + sx_xunlock(&vmmdev_mtx); } free(sc, M_VMMDEV); @@ -799,10 +799,10 @@ vmmdev_lookup_and_destroy(const char *name, struct ucred *cred) struct cdev *cdev; struct vmmdev_softc *sc; - mtx_lock(&vmmdev_mtx); + sx_xlock(&vmmdev_mtx); sc = vmmdev_lookup(name, cred); if (sc == NULL || sc->cdev == NULL) { - mtx_unlock(&vmmdev_mtx); + sx_xunlock(&vmmdev_mtx); return (EINVAL); } @@ -812,7 +812,7 @@ vmmdev_lookup_and_destroy(const char *name, struct ucred *cred) */ cdev = sc->cdev; sc->cdev = NULL; - mtx_unlock(&vmmdev_mtx); + sx_xunlock(&vmmdev_mtx); destroy_dev(cdev); vmmdev_destroy(sc); @@ -874,9 +874,9 @@ vmmdev_create(const char *name, struct ucred *cred) struct vm *vm; int error; - mtx_lock(&vmmdev_mtx); + sx_xlock(&vmmdev_mtx); sc = vmmdev_lookup(name, cred); - mtx_unlock(&vmmdev_mtx); + sx_xunlock(&vmmdev_mtx); if (sc != NULL) return (EEXIST); @@ -890,16 +890,16 @@ vmmdev_create(const char *name, struct ucred *cred) * Lookup the name again just in case somebody sneaked in when we * dropped the lock. */ - mtx_lock(&vmmdev_mtx); + sx_xlock(&vmmdev_mtx); sc2 = vmmdev_lookup(name, cred); if (sc2 != NULL) { - mtx_unlock(&vmmdev_mtx); + sx_xunlock(&vmmdev_mtx); vmmdev_destroy(sc); return (EEXIST); } sc->flags |= VSC_LINKED; SLIST_INSERT_HEAD(&head, sc, link); - mtx_unlock(&vmmdev_mtx); + sx_xunlock(&vmmdev_mtx); error = make_dev_p(MAKEDEV_CHECKNAME, &cdev, &vmmdevsw, sc->ucred, UID_ROOT, GID_WHEEL, 0600, "vmm/%s", name); @@ -908,10 +908,10 @@ vmmdev_create(const char *name, struct ucred *cred) return (error); } - mtx_lock(&vmmdev_mtx); + sx_xlock(&vmmdev_mtx); sc->cdev = cdev; sc->cdev->si_drv1 = sc; - mtx_unlock(&vmmdev_mtx); + sx_xunlock(&vmmdev_mtx); return (0); } @@ -1019,10 +1019,10 @@ devmem_create_cdev(struct vmmdev_softc *sc, int segid, char *devname) dsc = malloc(sizeof(struct devmem_softc), M_VMMDEV, M_WAITOK | M_ZERO); - mtx_lock(&vmmdev_mtx); + sx_xlock(&vmmdev_mtx); if (sc->cdev == NULL) { /* virtual machine is being created or destroyed */ - mtx_unlock(&vmmdev_mtx); + sx_xunlock(&vmmdev_mtx); free(dsc, M_VMMDEV); destroy_dev_sched_cb(cdev, NULL, 0); return (ENODEV); @@ -1033,7 +1033,7 @@ devmem_create_cdev(struct vmmdev_softc *sc, int segid, char *devname) dsc->cdev = cdev; dsc->sc = sc; SLIST_INSERT_HEAD(&sc->devmem, dsc, link); - mtx_unlock(&vmmdev_mtx); + sx_xunlock(&vmmdev_mtx); /* The 'cdev' is ready for use after 'si_drv1' is initialized */ cdev->si_drv1 = dsc; From nobody Sun Sep 1 14:09:45 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WxYfx5bDbz5VGjM; Sun, 01 Sep 2024 14:09:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WxYfx27ygz4Qrh; Sun, 1 Sep 2024 14:09:45 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725199785; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=grDxcspXMaSnbwBUgqBkUbLCWmyKwlELf1fblCPrMs4=; b=Uv8gZ1Mt+qHKt2g+VLIYY6rAgwqYWBYzpX0BTnx6CJE+BpILNn/a9acIEV1qhom5K5a3xh qeW/EEqbzeByN177SuRoojCNpnG/CDb9THan16UGuanPKD5/d/ZOHI0jSJiAlhIM36SDms BlbOzE3eqp9LJ65xFABGwV0Y9WSbQKymbH4KBJXI/HGPJr/RApdOx4BK30HK8wHf0wWy6v qy2rmkL2v82RC7DfM8AnCAqZo/ewfjMLOTdQ62tP5QypXKyj26EYWjhrrNUzbhd5MNNkCB TwXNx/7KvEEegNEdRe3+SPjjS7Wnl97CBUjuJy9Dum7feciVerO6ZXJdW4pa3Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1725199785; a=rsa-sha256; cv=none; b=Vx7lQguB9OajRpRYAJa6L3Kh4jD4fRJOE2WDK9pWdGcHbTxri5xPCheYRdBnILxB+RTqJX xBi5dnAwaxuR+9qwT9AaBteK0Es7Nch2U5boctdgMjOwLbNaUkhZIzc91sEX+3jhjxnXeY 28LrdP/oNcKMLIQ+FgVPjcZWWgMKrEIguX6ev10YLUuJPAGrdx2pIXD14NjmWNdBvSjeAy V0QXIaclhGTcbVqtKHnIXYC43LSVtwcU+HuxhiN9mPw20/Xn1MaF9Z1Qh+As+rrZ+Hx4lL 5vCp2ubq09y6Rmgy47BjtJdWjj5R3pko/kmVnN2f1ZXDgB7NT+W2ObyuJQCOfA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725199785; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=grDxcspXMaSnbwBUgqBkUbLCWmyKwlELf1fblCPrMs4=; b=OGBcl0uHmbDGXkwH+lmkpa9hZmMRNVw4CpYWHIRjpmBbHdvW3uR/om2tFeWWdbqJjK7sGb dXbieF87eJwoa5OI/u8/tn6HxkXf/2CCoKZh6W13lQiWSDqhQZXJ28jTFDeg5z4tX5GfI1 I0/eV7tDAMJ40qqStISWv7uy+erxQ8mAey5OCkJRaCa1PWHGT0fhZGirRCOeDbpbZc0LJ/ J7zujsTIFwbUrMugwZBAThvFLCh5JDDIWihmQkxXBWTVNBslfQHtvGRqVkS8U9Y83dnHIG YnVl3gb016SZX1xcqNS+v1yOEFxFgDjX9FGAFIshYCLJKqT8thCvr79AAMrdJA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WxYfx1lV2zX1s; Sun, 1 Sep 2024 14:09:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 481E9jqK099752; Sun, 1 Sep 2024 14:09:45 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 481E9jQx099749; Sun, 1 Sep 2024 14:09:45 GMT (envelope-from git) Date: Sun, 1 Sep 2024 14:09:45 GMT Message-Id: <202409011409.481E9jQx099749@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: cef5f43f819c - main - vmm: Use make_dev_s() to create vmm devices List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: cef5f43f819cecdbd16f9686e8186d055b19479e Auto-Submitted: auto-generated The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=cef5f43f819cecdbd16f9686e8186d055b19479e commit cef5f43f819cecdbd16f9686e8186d055b19479e Author: Mark Johnston AuthorDate: 2024-09-01 14:00:39 +0000 Commit: Mark Johnston CommitDate: 2024-09-01 14:09:17 +0000 vmm: Use make_dev_s() to create vmm devices This avoids creating windows where a device file is accessible but the device-specific field is not set. Now that vmmdev_mtx is a sleepable lock, avoid dropping it while creating devices files. This makes it easier to handle races and simplifies some code; for example, the VSC_LINKED flag is no longer needed. Suggested by: jhb Reviewed by: imp, jhb Differential Revision: https://reviews.freebsd.org/D46488 --- sys/dev/vmm/vmm_dev.c | 103 +++++++++++++++++++++----------------------------- 1 file changed, 44 insertions(+), 59 deletions(-) diff --git a/sys/dev/vmm/vmm_dev.c b/sys/dev/vmm/vmm_dev.c index 91d33ccba261..ea2aaace832c 100644 --- a/sys/dev/vmm/vmm_dev.c +++ b/sys/dev/vmm/vmm_dev.c @@ -58,7 +58,6 @@ struct vmmdev_softc { SLIST_HEAD(, devmem_softc) devmem; int flags; }; -#define VSC_LINKED 0x01 static SLIST_HEAD(, vmmdev_softc) head; @@ -750,6 +749,8 @@ vmmdev_destroy(struct vmmdev_softc *sc) struct devmem_softc *dsc; int error __diagused; + KASSERT(sc->cdev == NULL, ("%s: cdev not free", __func__)); + /* * Destroy all cdevs: * @@ -759,7 +760,6 @@ vmmdev_destroy(struct vmmdev_softc *sc) */ SLIST_FOREACH(dsc, &sc->devmem, link) { KASSERT(dsc->cdev != NULL, ("devmem cdev already destroyed")); - destroy_dev(dsc->cdev); devmem_destroy(dsc); } @@ -775,21 +775,15 @@ vmmdev_destroy(struct vmmdev_softc *sc) free(dsc, M_VMMDEV); } - if (sc->cdev != NULL) - destroy_dev(sc->cdev); - if (sc->vm != NULL) vm_destroy(sc->vm); if (sc->ucred != NULL) crfree(sc->ucred); - if ((sc->flags & VSC_LINKED) != 0) { - sx_xlock(&vmmdev_mtx); - SLIST_REMOVE(&head, sc, vmmdev_softc, link); - sx_xunlock(&vmmdev_mtx); - } - + sx_xlock(&vmmdev_mtx); + SLIST_REMOVE(&head, sc, vmmdev_softc, link); + sx_xunlock(&vmmdev_mtx); free(sc, M_VMMDEV); } @@ -869,50 +863,43 @@ vmmdev_alloc(struct vm *vm, struct ucred *cred) static int vmmdev_create(const char *name, struct ucred *cred) { + struct make_dev_args mda; struct cdev *cdev; - struct vmmdev_softc *sc, *sc2; + struct vmmdev_softc *sc; struct vm *vm; int error; sx_xlock(&vmmdev_mtx); sc = vmmdev_lookup(name, cred); - sx_xunlock(&vmmdev_mtx); - if (sc != NULL) + if (sc != NULL) { + sx_xunlock(&vmmdev_mtx); return (EEXIST); + } error = vm_create(name, &vm); - if (error != 0) - return (error); - - sc = vmmdev_alloc(vm, cred); - - /* - * Lookup the name again just in case somebody sneaked in when we - * dropped the lock. - */ - sx_xlock(&vmmdev_mtx); - sc2 = vmmdev_lookup(name, cred); - if (sc2 != NULL) { + if (error != 0) { sx_xunlock(&vmmdev_mtx); - vmmdev_destroy(sc); - return (EEXIST); + return (error); } - sc->flags |= VSC_LINKED; + sc = vmmdev_alloc(vm, cred); SLIST_INSERT_HEAD(&head, sc, link); - sx_xunlock(&vmmdev_mtx); - error = make_dev_p(MAKEDEV_CHECKNAME, &cdev, &vmmdevsw, sc->ucred, - UID_ROOT, GID_WHEEL, 0600, "vmm/%s", name); + make_dev_args_init(&mda); + mda.mda_devsw = &vmmdevsw; + mda.mda_cr = sc->ucred; + mda.mda_uid = UID_ROOT; + mda.mda_gid = GID_WHEEL; + mda.mda_mode = 0600; + mda.mda_si_drv1 = sc; + mda.mda_flags = MAKEDEV_CHECKNAME | MAKEDEV_WAITOK; + error = make_dev_s(&mda, &cdev, "vmm/%s", name); if (error != 0) { + sx_xunlock(&vmmdev_mtx); vmmdev_destroy(sc); return (error); } - - sx_xlock(&vmmdev_mtx); sc->cdev = cdev; - sc->cdev->si_drv1 = sc; sx_xunlock(&vmmdev_mtx); - return (0); } @@ -1005,39 +992,37 @@ static struct cdevsw devmemsw = { static int devmem_create_cdev(struct vmmdev_softc *sc, int segid, char *devname) { + struct make_dev_args mda; struct devmem_softc *dsc; - struct cdev *cdev; - const char *vmname; int error; - vmname = vm_name(sc->vm); - - error = make_dev_p(MAKEDEV_CHECKNAME, &cdev, &devmemsw, sc->ucred, - UID_ROOT, GID_WHEEL, 0600, "vmm.io/%s.%s", vmname, devname); - if (error) - return (error); - - dsc = malloc(sizeof(struct devmem_softc), M_VMMDEV, M_WAITOK | M_ZERO); - sx_xlock(&vmmdev_mtx); - if (sc->cdev == NULL) { - /* virtual machine is being created or destroyed */ - sx_xunlock(&vmmdev_mtx); - free(dsc, M_VMMDEV); - destroy_dev_sched_cb(cdev, NULL, 0); - return (ENODEV); - } + dsc = malloc(sizeof(struct devmem_softc), M_VMMDEV, M_WAITOK | M_ZERO); dsc->segid = segid; dsc->name = devname; - dsc->cdev = cdev; dsc->sc = sc; SLIST_INSERT_HEAD(&sc->devmem, dsc, link); + + make_dev_args_init(&mda); + mda.mda_devsw = &devmemsw; + mda.mda_cr = sc->ucred; + mda.mda_uid = UID_ROOT; + mda.mda_gid = GID_WHEEL; + mda.mda_mode = 0600; + mda.mda_si_drv1 = dsc; + mda.mda_flags = MAKEDEV_CHECKNAME | MAKEDEV_WAITOK; + error = make_dev_s(&mda, &dsc->cdev, "vmm.io/%s.%s", vm_name(sc->vm), + devname); + if (error != 0) { + SLIST_REMOVE(&sc->devmem, dsc, devmem_softc, link); + free(dsc->name, M_VMMDEV); + free(dsc, M_VMMDEV); + } + sx_xunlock(&vmmdev_mtx); - /* The 'cdev' is ready for use after 'si_drv1' is initialized */ - cdev->si_drv1 = dsc; - return (0); + return (error); } static void @@ -1045,7 +1030,7 @@ devmem_destroy(void *arg) { struct devmem_softc *dsc = arg; - KASSERT(dsc->cdev, ("%s: devmem cdev already destroyed", __func__)); + destroy_dev(dsc->cdev); dsc->cdev = NULL; dsc->sc = NULL; } From nobody Sun Sep 1 14:10:01 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WxYgF5YTBz5VGg9; Sun, 01 Sep 2024 14:10:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WxYgF3zR8z4RbD; Sun, 1 Sep 2024 14:10:01 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725199801; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vIGZ1e1vUwxFps+6s6V5AgSSBY4Yn0XtP+RI8rYuUvc=; b=BUxkEQZcfMrUjGEnDxmxFrJ2Rk2fNKnyjUmgXuocxEFe1KjpLJ0zHQmIOzB20n4UFamvds 4TBxWUB4Jicy1EEofSDud9M/X3Eg5Pa99HO5yLbXkHw4Mz2UoVHzXjqA2cTPg74RM42dKF 6B2UjmMt4eeF/rpTWh85rFSdCZDt21Rt/tN0PNBtMJWhStMQK12NmQNqbwLPetR+nNkuIG kvRo2iIJ7vv1CWiAucK7FkSnH3H/J4nkSJtXdTMoMaDCK1MDHIRuhO0YLmZS/SpfTAntBX qrcs+MvfGhhBUV44xizk0XFCFff1B8mge3K8qDMO/U9tbXCikbJ3OmtY2i7Bvg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1725199801; a=rsa-sha256; cv=none; b=sH7hsOqp3/SUPCKPzNNH6dVvFAFAdPDslmZ7iRw2d0YrwElV4qthXKX3M9r5Amx0llI/l7 NEEiDyK4T3HAOBO0PWe11L8NlvPUGDBXLOXLwR/eEkd4PSskupeqWo5IZhI5ggVfntL3Xy dax1wBS4thSTREkisAk1Kw33DAAM/0NEHN1Di0Do/F2Gy+CtgA77iSpsrX6waH/4sVCboK z60xy2+WBURk0O0kv0kPhtXy4ZgvOYZHZe09UcXleO79LSpsTnBcvPuoed6VJMUn46H7ec vSJLOyKUGTseiiNUbrqgBDcx6OEUG3mQI2jN7hS6a7IZF0hk73/Qcoga2blCrQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725199801; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vIGZ1e1vUwxFps+6s6V5AgSSBY4Yn0XtP+RI8rYuUvc=; b=EXAligQlVS0hJuonjWlTh2JTLdL+ge4GzrPtbAm4HVtsqdUK+soM6kG54GVOkaW7zHuBbS cxWlYdm1VxjT4gUG+ew9saGa9F1oup+McKCOl+L02vg9UJf56m6zKolT2tJomMmHpDLb5y JvLmFFM5916efGSTWcgMf+ckPAnUmSWI4qkfN+NNPeqYiiRh2sOgzxHLN5wqb8rgawY4nw 7rR3Lqhdf/tLf3CQuNxv0DvtrtZrCA6Mqz7fsXqnKrNSYVz33pyxXL1120t9+0ZK8tg+Y1 t4ypy1RwSHMHkVbcmYu1Fnue7Vmk00IjkJt1wOUgY++zLXoBtTirz4P2Yg9WkQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WxYgF3Wh1zXM5; Sun, 1 Sep 2024 14:10:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 481EA1mb001752; Sun, 1 Sep 2024 14:10:01 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 481EA1Er001747; Sun, 1 Sep 2024 14:10:01 GMT (envelope-from git) Date: Sun, 1 Sep 2024 14:10:01 GMT Message-Id: <202409011410.481EA1Er001747@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: 7d508464f56c - main - carp: Fix pullup checks List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 7d508464f56cf262465fd23ab96e357d8e42c927 Auto-Submitted: auto-generated The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=7d508464f56cf262465fd23ab96e357d8e42c927 commit 7d508464f56cf262465fd23ab96e357d8e42c927 Author: Mark Johnston AuthorDate: 2024-08-31 01:18:23 +0000 Commit: Mark Johnston CommitDate: 2024-09-01 14:09:53 +0000 carp: Fix pullup checks The conditions used to test whether a pullup is needed were inverted. While here: - Fix a bogus assignment to "iplen": it's already initialized to *offp. - Use in_cksum_skip() instead of manually adjusting the data pointer. Otherwise the mbuf is temporarily in an invalid state, since m_len isn't updated to match. Reported by: KMSAN Reviewed by: kp Sponsored by: Klara, Inc. Fixes: 37115154672f ("carp: support VRRPv3") Differential Revision: https://reviews.freebsd.org/D46492 --- sys/netinet/ip_carp.c | 23 +++++++++-------------- 1 file changed, 9 insertions(+), 14 deletions(-) diff --git a/sys/netinet/ip_carp.c b/sys/netinet/ip_carp.c index 9f163c1097ba..ab001d346313 100644 --- a/sys/netinet/ip_carp.c +++ b/sys/netinet/ip_carp.c @@ -516,7 +516,7 @@ static int carp_input(struct mbuf **mp, int *offp, int proto) { struct mbuf *m = *mp; - struct ip *ip = mtod(m, struct ip *); + struct ip *ip; struct vrrpv3_header *vh; int iplen; int minlen; @@ -532,9 +532,6 @@ carp_input(struct mbuf **mp, int *offp, int proto) return (IPPROTO_DONE); } - iplen = ip->ip_hl << 2; - totlen = ntohs(ip->ip_len); - /* Ensure we have enough header to figure out the version. */ if (m->m_pkthdr.len < iplen + sizeof(*vh)) { CARPSTATS_INC(carps_badlen); @@ -545,14 +542,15 @@ carp_input(struct mbuf **mp, int *offp, int proto) return (IPPROTO_DONE); } - if (iplen + sizeof(*vh) < m->m_len) { + if (m->m_len < iplen + sizeof(*vh)) { if ((m = m_pullup(m, iplen + sizeof(*vh))) == NULL) { CARPSTATS_INC(carps_hdrops); CARP_DEBUG("%s():%d: pullup failed\n", __func__, __LINE__); return (IPPROTO_DONE); } - ip = mtod(m, struct ip *); } + ip = mtod(m, struct ip *); + totlen = ntohs(ip->ip_len); vh = (struct vrrpv3_header *)((char *)ip + iplen); switch (vh->vrrp_version) { @@ -581,7 +579,7 @@ carp_input(struct mbuf **mp, int *offp, int proto) return (IPPROTO_DONE); } - if (iplen + minlen < m->m_len) { + if (m->m_len < iplen + minlen) { if ((m = m_pullup(m, iplen + minlen)) == NULL) { CARPSTATS_INC(carps_hdrops); CARP_DEBUG("%s():%d: pullup failed\n", __func__, __LINE__); @@ -596,15 +594,13 @@ carp_input(struct mbuf **mp, int *offp, int proto) struct carp_header *ch; /* verify the CARP checksum */ - m->m_data += iplen; - if (in_cksum(m, totlen - iplen)) { + if (in_cksum_skip(m, totlen, iplen)) { CARPSTATS_INC(carps_badsum); CARP_DEBUG("%s: checksum failed on %s\n", __func__, if_name(m->m_pkthdr.rcvif)); m_freem(m); break; } - m->m_data -= iplen; ch = (struct carp_header *)((char *)ip + iplen); carp_input_c(m, ch, AF_INET, ip->ip_ttl); break; @@ -689,7 +685,7 @@ carp6_input(struct mbuf **mp, int *offp, int proto) return (IPPROTO_DONE); } - if (sizeof (*ip6) + minlen < m->m_len) { + if (m->m_len < sizeof(*ip6) + minlen) { if ((m = m_pullup(m, sizeof(*ip6) + minlen)) == NULL) { CARPSTATS_INC(carps_hdrops); CARP_DEBUG("%s():%d: pullup failed\n", __func__, __LINE__); @@ -704,15 +700,14 @@ carp6_input(struct mbuf **mp, int *offp, int proto) struct carp_header *ch; /* verify the CARP checksum */ - m->m_data += *offp; - if (in_cksum(m, sizeof(struct carp_header))) { + if (in_cksum_skip(m, *offp + sizeof(struct carp_header), + *offp)) { CARPSTATS_INC(carps_badsum); CARP_DEBUG("%s: checksum failed, on %s\n", __func__, if_name(m->m_pkthdr.rcvif)); m_freem(m); break; } - m->m_data -= *offp; ch = (struct carp_header *)((char *)ip6 + sizeof(*ip6)); carp_input_c(m, ch, AF_INET6, ip6->ip6_hlim); break; From nobody Sun Sep 1 14:10:02 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WxYgG5zMMz5VGjV; Sun, 01 Sep 2024 14:10:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WxYgG4Vf0z4RQH; Sun, 1 Sep 2024 14:10:02 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725199802; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=iYBkoL/YIQeEB6oiTRUpvqcCu4jI3aa5/lLChaENyME=; b=JhP95OO96WOjD5/eXdcYgZMrUvzcSFsXjcTS6T4H0AJwSzRosECIyR9kebXzdVmDt6euhK e1RF9zbFX3lcQqFznEDj6hQsQUKvL97KwGkdQMQMRNR9J1pyLh35THAa0nxcKMeTfiZwW8 e5Ta1rdbpIIY4d0gOs/ar1oJW+w+7E+b7kmgwi8QYXAhboX+RthJvTN8jjC4UC9cf65IZC WV4Fetn4ITogLFZnBMFAHPGIbpiXX+SZs6hY0aDZt6ZjGEnFE+Py7qAd+oB9Otlk/tQduh PfhPKShVyqcIJvPG4MwVMg1A0MdP7MZ6JzZPCfdfyqloiK+l44nMNhSAxNtMKQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1725199802; a=rsa-sha256; cv=none; b=uRSerYAaghp7/t+R108uWvzBihCzDhqddyPQF6h94V31WusLbp8l0PKPe9r8EeDOANdg4K 7qg+WkmexmbXA3MMj31gsyQuwFFe0At6mJRQmwHyj2Ar/76QetQcI0loM0yWclxf0VCn0h THjTlwfqaMDXzWjDQgFRGvBNR5X348GRqnq7A/Bde0OiEMG8dY5XOPBAvpIBubP3S3gK1x n747SVBRUc+8YbFmngHybUvnGSXHRo1ZUjikA4+q/h+YKmopwuTcPIQD2S90rbh/VqMo6x IzHvzmow7f5mTj1+/WwEzLyLwYmdMIgYOBH+p1KsijSbJLH1wAmpITIUysYb0w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725199802; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=iYBkoL/YIQeEB6oiTRUpvqcCu4jI3aa5/lLChaENyME=; b=mRs9/qEr1Nw5STffrpkAb8RrLcJpNk5mueI+E4uvq/AeXS7FjtEc0e8MSPJgBGc6cr67S9 xnvhxG5MzZ1jRujGUTSdPJVqMnW5SY0TJOuMxcH0TbKr6J+Du9qsfiXf020pnLJVHuCaxM tpZOlBFMC0Y9fQEuQK4/Mqd4tbO1Eec5n5lCb7JR4VmbJecOgURoFCEFPVO7Qos/hdS8NS dspGSGAAZdOGIPE5vBbV7W+EVaB5lEl0zt+NSs7IosYf3anN3sn8iJiWRCxSYWJ3GARewO f+mFlkL1mokbYfVPex5eoKBRGXLp7EwUVe1ZV8zcmPiMhA0D0F3XbSLGbUQQCw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WxYgG46xWzXM6; Sun, 1 Sep 2024 14:10:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 481EA2at002066; Sun, 1 Sep 2024 14:10:02 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 481EA2H5002061; Sun, 1 Sep 2024 14:10:02 GMT (envelope-from git) Date: Sun, 1 Sep 2024 14:10:02 GMT Message-Id: <202409011410.481EA2H5002061@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: 61295e098599 - main - dummymbuf: Avoid copyout of uninitialized memory from the sysctl handler List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 61295e09859953cce5140daf9c2ff85b3feb0e74 Auto-Submitted: auto-generated The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=61295e09859953cce5140daf9c2ff85b3feb0e74 commit 61295e09859953cce5140daf9c2ff85b3feb0e74 Author: Mark Johnston AuthorDate: 2024-08-31 01:19:09 +0000 Commit: Mark Johnston CommitDate: 2024-09-01 14:09:53 +0000 dummymbuf: Avoid copyout of uninitialized memory from the sysctl handler If *rulesp was initially unset, we'll allocate a new buffer and pass it to sysctl_handle_string(), which copies the existing string out and then copies in the new string. We need to make sure the buffer containing the existing rules is initialized, otherwise we leak kernel memory to userspace. Fix some nearby style nits while here. Reported by: KMSAN Reviewed by: igoro, kp Fixes: 8aaffd78c0f5 ("Add dummymbuf module for testing purposes") Sponsored by: Klara, Inc. Differential Revision: https://reviews.freebsd.org/D46493 --- sys/net/dummymbuf.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/sys/net/dummymbuf.c b/sys/net/dummymbuf.c index 8c46421888ed..d4ba00b13235 100644 --- a/sys/net/dummymbuf.c +++ b/sys/net/dummymbuf.c @@ -74,7 +74,7 @@ dmb_sysctl_handle_rules(SYSCTL_HANDLER_ARGS) char **rulesp = (char **)arg1; if (req->newptr == NULL) { - // read only + /* read only */ DMB_RULES_SLOCK(); arg1 = *rulesp; if (arg1 == NULL) { @@ -84,10 +84,12 @@ dmb_sysctl_handle_rules(SYSCTL_HANDLER_ARGS) error = sysctl_handle_string(oidp, arg1, arg2, req); DMB_RULES_SUNLOCK(); } else { - // read and write + /* read and write */ DMB_RULES_XLOCK(); - if (*rulesp == NULL) - *rulesp = malloc(arg2, M_DUMMYMBUF_RULES, M_WAITOK); + if (*rulesp == NULL) { + *rulesp = malloc(arg2, M_DUMMYMBUF_RULES, + M_WAITOK | M_ZERO); + } arg1 = *rulesp; error = sysctl_handle_string(oidp, arg1, arg2, req); DMB_RULES_XUNLOCK(); @@ -99,8 +101,7 @@ dmb_sysctl_handle_rules(SYSCTL_HANDLER_ARGS) SYSCTL_PROC(_net_dummymbuf, OID_AUTO, rules, CTLTYPE_STRING | CTLFLAG_MPSAFE | CTLFLAG_RW | CTLFLAG_VNET, &VNET_NAME(dmb_rules), RULES_MAXLEN, dmb_sysctl_handle_rules, "A", - "{inet | inet6 | ethernet} {in | out} [ ];" - " ...;"); + "{inet | inet6 | ethernet} {in | out} []; ...;"); /* * Statistics From nobody Sun Sep 1 15:06:08 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WxZw04TXkz5MQsd; Sun, 01 Sep 2024 15:06:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WxZw03xFtz4Y9v; Sun, 1 Sep 2024 15:06:08 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725203168; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=iMFCas+9Wa5psixLpE2pgL9Xc7SZLDStyQbF8f7W1pA=; b=vI+B0F06xfv3cZD/HcoOz/29TDmrdFsONlowlFUYgaFQpTGDr+CsKfgnlMG6qWrsj9ZRMD fOApmNmcsL2CKQFKBtgiEScoj626zYxXggJB1dmIkHoXT6KJbZEdYVHbuyIBTSfgoAaZMU bP+bEUsxu/UYePCVLzL39byWQL6yb1O/eslX4H8DRKUDdTFzo4h+HXU8CjL3beSA6cG1bS fptaRZssr5VL1DEX0+pmFvlR+VmQpann5oAjSZklLxazOGYodjvjFVkjIb763mRUxNdYaW nDG7XDQmgVyEet7+wj8q8QpTjAbRcoRNjzadgwXyF88T5jSxDJpFnk+7AUlktg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1725203168; a=rsa-sha256; cv=none; b=pNy9YoOBWStBkwttIC6DZDEJ6OwhaMw84zKe65eXBtEQkjrglEpzLGHyeNdxCK/9S3luPe MFiaN7oRoLWH2i7yTV2Ycr3Xsv2DXSK6g7tqPW9geAQBNx4n9CDxVobbu7IIzBjxziIJDf N2V/hThJbeq5UNj7jOEF6UNNwe3VLCqAM9V720Ppb2CDhMUiWMe+eON1vmNSeqBciV+4xB q9LUBsj4nXkZwXrDBbPBTr0qEJyBgogG3f6tdp/UpVMJqfhHWOg+lWLqZPGM0oFYWFCKae lehDWEl4hUiIscKXtTnJf5ghioCkZnFCOQzLcL5DgDJWgvLrrZnqHZXtAlX7pA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725203168; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=iMFCas+9Wa5psixLpE2pgL9Xc7SZLDStyQbF8f7W1pA=; b=MoIJZ8T3zvVtGjKR7pihCd/+HT9wBXZ825Nr9mkV47jNaaNTY4anXm2WpJJxlROH1sMQhP z8JFXga0LFVDhlcgPFTI5KG1oTKUxRMsYm49SO4WhHdytuI6nwWnEWL6NfJ3p12TQ3dORh FXE/+2dxrkwZ7vYKmpEx4BQwIgh6Z2Yvqi30CDXfxJrApuqBg/+m+cjl5FQ7PuMiRmaxQV AadZJXx3EFbHXRLLe1w5ztCrjUbAp1dT5qBeaWf12yNQcbAKs9DnSIIQZprIMRW6M7TVhu f/vXokQNxkAIHduyJq749/fFiXRtAhh0QhNZAg2VrohUoFESpcVsBGENRkaoYg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WxZw03DPyzZ58; Sun, 1 Sep 2024 15:06:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 481F68mS002478; Sun, 1 Sep 2024 15:06:08 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 481F68IY002475; Sun, 1 Sep 2024 15:06:08 GMT (envelope-from git) Date: Sun, 1 Sep 2024 15:06:08 GMT Message-Id: <202409011506.481F68IY002475@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kristof Provost Subject: git: 5ab1e5f7e558 - main - pf: improve the ICMPv6 direction check List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 5ab1e5f7e5585558a73b723f07528977a82cee82 Auto-Submitted: auto-generated The branch main has been updated by kp: URL: https://cgit.FreeBSD.org/src/commit/?id=5ab1e5f7e5585558a73b723f07528977a82cee82 commit 5ab1e5f7e5585558a73b723f07528977a82cee82 Author: Kristof Provost AuthorDate: 2024-08-26 12:59:38 +0000 Commit: Kristof Provost CommitDate: 2024-09-01 15:05:28 +0000 pf: improve the ICMPv6 direction check Following bluhm's advice this changes the way we setup state keys and perform state lookups for ICMPv6 Neighbor Discovery packets: - replace the NS-dst with ND target address; - replace the NA-src with ND target address; - replace the NA-dst with unspecified address if it is a multicast. This allows pf to match Address Resolution, Neighbor Unreachability Detection and Duplicate Address Detection packets to the corresponding states without the need to create new ones or match unrelated ones. As a side effect we're doing now one state table lookup for ND packets instead of two. Fixes a bug uncovered by one of the previous commits that virtually breaks IPv6 connectivity after few minutes of use. ok stsp henning, with and ok bluhm PR: 280701 MFC after: 1 week Obtained from: OpenBSD, mikeb , 2633ae8c4c8a Sponsored by: Rubicon Communications, LLC ("Netgate") --- sys/net/pfvar.h | 4 +- sys/netpfil/pf/pf.c | 116 ++++++++++++++++++++++++++++++++++--------------- sys/netpfil/pf/pf_lb.c | 2 +- 3 files changed, 85 insertions(+), 37 deletions(-) diff --git a/sys/net/pfvar.h b/sys/net/pfvar.h index 10bf527c025d..43d4b908a407 100644 --- a/sys/net/pfvar.h +++ b/sys/net/pfvar.h @@ -2576,8 +2576,8 @@ u_short pf_get_translation(struct pf_pdesc *, struct mbuf *, uint16_t, uint16_t, struct pf_kanchor_stackframe *, struct pf_krule **); -struct pf_state_key *pf_state_key_setup(struct pf_pdesc *, struct pf_addr *, - struct pf_addr *, u_int16_t, u_int16_t); +struct pf_state_key *pf_state_key_setup(struct pf_pdesc *, struct mbuf *, int, + struct pf_addr *, struct pf_addr *, u_int16_t, u_int16_t); struct pf_state_key *pf_state_key_clone(const struct pf_state_key *); void pf_rule_to_actions(struct pf_krule *, struct pf_rule_actions *); diff --git a/sys/netpfil/pf/pf.c b/sys/netpfil/pf/pf.c index acbaf304995f..b4f8bdeeff24 100644 --- a/sys/netpfil/pf/pf.c +++ b/sys/netpfil/pf/pf.c @@ -331,6 +331,9 @@ static int pf_create_state(struct pf_krule *, struct pf_krule *, u_int16_t, u_int16_t, int *, struct pfi_kkif *, struct pf_kstate **, int, u_int16_t, u_int16_t, int, struct pf_krule_slist *); +static int pf_state_key_addr_setup(struct pf_pdesc *, struct mbuf *, + int, struct pf_state_key_cmp *, int, struct pf_addr *, + int, struct pf_addr *, int); static int pf_test_fragment(struct pf_krule **, struct pfi_kkif *, struct mbuf *, void *, struct pf_pdesc *, struct pf_krule **, struct pf_kruleset **); @@ -347,7 +350,7 @@ static int pf_test_state_udp(struct pf_kstate **, void *, struct pf_pdesc *); int pf_icmp_state_lookup(struct pf_state_key_cmp *, struct pf_pdesc *, struct pf_kstate **, struct mbuf *, - int, struct pfi_kkif *, u_int16_t, u_int16_t, + int, int, struct pfi_kkif *, u_int16_t, u_int16_t, int, int *, int, int); static int pf_test_state_icmp(struct pf_kstate **, struct pfi_kkif *, struct mbuf *, int, @@ -401,7 +404,7 @@ extern struct proc *pf_purge_proc; VNET_DEFINE(struct pf_limit, pf_limits[PF_LIMIT_MAX]); -enum { PF_ICMP_MULTI_NONE, PF_ICMP_MULTI_SOLICITED, PF_ICMP_MULTI_LINK }; +enum { PF_ICMP_MULTI_NONE, PF_ICMP_MULTI_LINK }; #define PACKET_UNDO_NAT(_m, _pd, _off, _s) \ do { \ @@ -1495,9 +1498,66 @@ pf_state_key_ctor(void *mem, int size, void *arg, int flags) return (0); } +static int +pf_state_key_addr_setup(struct pf_pdesc *pd, struct mbuf *m, int off, + struct pf_state_key_cmp *key, int sidx, struct pf_addr *saddr, + int didx, struct pf_addr *daddr, int multi) +{ +#ifdef INET6 + struct nd_neighbor_solicit nd; + struct pf_addr *target; + u_short action, reason; + + if (pd->af == AF_INET || pd->proto != IPPROTO_ICMPV6) + goto copy; + + switch (pd->hdr.icmp6.icmp6_type) { + case ND_NEIGHBOR_SOLICIT: + if (multi) + return (-1); + if (!pf_pull_hdr(m, off, &nd, sizeof(nd), &action, &reason, pd->af)) + return (-1); + target = (struct pf_addr *)&nd.nd_ns_target; + daddr = target; + break; + case ND_NEIGHBOR_ADVERT: + if (multi) + return (-1); + if (!pf_pull_hdr(m, off, &nd, sizeof(nd), &action, &reason, pd->af)) + return (-1); + target = (struct pf_addr *)&nd.nd_ns_target; + saddr = target; + if (IN6_IS_ADDR_MULTICAST(&pd->dst->v6)) { + key->addr[didx].addr32[0] = 0; + key->addr[didx].addr32[1] = 0; + key->addr[didx].addr32[2] = 0; + key->addr[didx].addr32[3] = 0; + daddr = NULL; /* overwritten */ + } + break; + default: + if (multi == PF_ICMP_MULTI_LINK) { + key->addr[sidx].addr32[0] = IPV6_ADDR_INT32_MLL; + key->addr[sidx].addr32[1] = 0; + key->addr[sidx].addr32[2] = 0; + key->addr[sidx].addr32[3] = IPV6_ADDR_INT32_ONE; + saddr = NULL; /* overwritten */ + } + } +copy: +#endif + if (saddr) + PF_ACPY(&key->addr[sidx], saddr, pd->af); + if (daddr) + PF_ACPY(&key->addr[didx], daddr, pd->af); + + return (0); +} + struct pf_state_key * -pf_state_key_setup(struct pf_pdesc *pd, struct pf_addr *saddr, - struct pf_addr *daddr, u_int16_t sport, u_int16_t dport) +pf_state_key_setup(struct pf_pdesc *pd, struct mbuf *m, int off, + struct pf_addr *saddr, struct pf_addr *daddr, u_int16_t sport, + u_int16_t dport) { struct pf_state_key *sk; @@ -1505,8 +1565,12 @@ pf_state_key_setup(struct pf_pdesc *pd, struct pf_addr *saddr, if (sk == NULL) return (NULL); - PF_ACPY(&sk->addr[pd->sidx], saddr, pd->af); - PF_ACPY(&sk->addr[pd->didx], daddr, pd->af); + if (pf_state_key_addr_setup(pd, m, off, (struct pf_state_key_cmp *)sk, + pd->sidx, pd->src, pd->didx, pd->dst, 0)) { + uma_zfree(V_pf_state_key_z, sk); + return (NULL); + } + sk->port[pd->sidx] = sport; sk->port[pd->didx] = dport; sk->proto = pd->proto; @@ -5210,7 +5274,7 @@ pf_create_state(struct pf_krule *r, struct pf_krule *nr, struct pf_krule *a, if (nr == NULL) { KASSERT((sk == NULL && nk == NULL), ("%s: nr %p sk %p, nk %p", __func__, nr, sk, nk)); - sk = pf_state_key_setup(pd, pd->src, pd->dst, sport, dport); + sk = pf_state_key_setup(pd, m, off, pd->src, pd->dst, sport, dport); if (sk == NULL) goto csfailed; nk = sk; @@ -6655,9 +6719,9 @@ pf_multihome_scan_asconf(struct mbuf *m, int start, int len, int pf_icmp_state_lookup(struct pf_state_key_cmp *key, struct pf_pdesc *pd, - struct pf_kstate **state, struct mbuf *m, int direction, struct pfi_kkif *kif, - u_int16_t icmpid, u_int16_t type, int icmp_dir, int *iidx, int multi, - int inner) + struct pf_kstate **state, struct mbuf *m, int off, int direction, + struct pfi_kkif *kif, u_int16_t icmpid, u_int16_t type, int icmp_dir, + int *iidx, int multi, int inner) { key->af = pd->af; key->proto = pd->proto; @@ -6670,25 +6734,9 @@ pf_icmp_state_lookup(struct pf_state_key_cmp *key, struct pf_pdesc *pd, key->port[pd->sidx] = type; key->port[pd->didx] = icmpid; } - if (pd->af == AF_INET6 && multi != PF_ICMP_MULTI_NONE) { - switch (multi) { - case PF_ICMP_MULTI_SOLICITED: - key->addr[pd->sidx].addr32[0] = IPV6_ADDR_INT32_MLL; - key->addr[pd->sidx].addr32[1] = 0; - key->addr[pd->sidx].addr32[2] = IPV6_ADDR_INT32_ONE; - key->addr[pd->sidx].addr32[3] = pd->src->addr32[3]; - key->addr[pd->sidx].addr8[12] = 0xff; - break; - case PF_ICMP_MULTI_LINK: - key->addr[pd->sidx].addr32[0] = IPV6_ADDR_INT32_MLL; - key->addr[pd->sidx].addr32[1] = 0; - key->addr[pd->sidx].addr32[2] = 0; - key->addr[pd->sidx].addr32[3] = IPV6_ADDR_INT32_ONE; - break; - } - } else - PF_ACPY(&key->addr[pd->sidx], pd->src, key->af); - PF_ACPY(&key->addr[pd->didx], pd->dst, key->af); + if (pf_state_key_addr_setup(pd, m, off, key, pd->sidx, pd->src, + pd->didx, pd->dst, multi)) + return (PF_DROP); STATE_LOOKUP(kif, key, *state, pd); @@ -6751,7 +6799,7 @@ pf_test_state_icmp(struct pf_kstate **state, struct pfi_kkif *kif, * ICMP query/reply message not related to a TCP/UDP packet. * Search for an ICMP state. */ - ret = pf_icmp_state_lookup(&key, pd, state, m, pd->dir, + ret = pf_icmp_state_lookup(&key, pd, state, m, off, pd->dir, kif, virtual_id, virtual_type, icmp_dir, &iidx, PF_ICMP_MULTI_NONE, 0); if (ret >= 0) { @@ -6759,7 +6807,7 @@ pf_test_state_icmp(struct pf_kstate **state, struct pfi_kkif *kif, icmp_dir == PF_OUT) { if (*state != NULL) PF_STATE_UNLOCK((*state)); - ret = pf_icmp_state_lookup(&key, pd, state, m, + ret = pf_icmp_state_lookup(&key, pd, state, m, off, pd->dir, kif, virtual_id, virtual_type, icmp_dir, &iidx, multi, 0); if (ret >= 0) @@ -7167,7 +7215,7 @@ pf_test_state_icmp(struct pf_kstate **state, struct pfi_kkif *kif, pf_icmp_mapping(&pd2, iih->icmp_type, &icmp_dir, &multi, &virtual_id, &virtual_type); - ret = pf_icmp_state_lookup(&key, &pd2, state, m, + ret = pf_icmp_state_lookup(&key, &pd2, state, m, off, pd2.dir, kif, virtual_id, virtual_type, icmp_dir, &iidx, PF_ICMP_MULTI_NONE, 1); if (ret >= 0) @@ -7222,7 +7270,7 @@ pf_test_state_icmp(struct pf_kstate **state, struct pfi_kkif *kif, pf_icmp_mapping(&pd2, iih->icmp6_type, &icmp_dir, &multi, &virtual_id, &virtual_type); - ret = pf_icmp_state_lookup(&key, &pd2, state, m, + ret = pf_icmp_state_lookup(&key, &pd2, state, m, off, pd->dir, kif, virtual_id, virtual_type, icmp_dir, &iidx, PF_ICMP_MULTI_NONE, 1); if (ret >= 0) { @@ -7231,7 +7279,7 @@ pf_test_state_icmp(struct pf_kstate **state, struct pfi_kkif *kif, if (*state != NULL) PF_STATE_UNLOCK((*state)); ret = pf_icmp_state_lookup(&key, pd, - state, m, pd->dir, kif, + state, m, off, pd->dir, kif, virtual_id, virtual_type, icmp_dir, &iidx, multi, 1); if (ret >= 0) diff --git a/sys/netpfil/pf/pf_lb.c b/sys/netpfil/pf/pf_lb.c index 68fc76233dab..6b0b95e9ce01 100644 --- a/sys/netpfil/pf/pf_lb.c +++ b/sys/netpfil/pf/pf_lb.c @@ -637,7 +637,7 @@ pf_get_translation(struct pf_pdesc *pd, struct mbuf *m, int off, return (PFRES_MAX); } - *skp = pf_state_key_setup(pd, saddr, daddr, sport, dport); + *skp = pf_state_key_setup(pd, m, off, saddr, daddr, sport, dport); if (*skp == NULL) return (PFRES_MEMORY); *nkp = pf_state_key_clone(*skp); From nobody Sun Sep 1 15:06:09 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WxZw16DD2z5VLJv; Sun, 01 Sep 2024 15:06:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WxZw14lgmz4YQ9; Sun, 1 Sep 2024 15:06:09 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725203169; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=B9xH8rGydmHQJxiQd4lcHzsRmer0n9qQEIp40Alp38Y=; b=jY3+uPVqNu7YNElcoGxtN4HR0JQsCkmhGe+K8GEgrK0P1c9/nhyt4cBdw6BBDHv4uzOK3M 8CXs0dERtAsxQ2Rw7zgduOD8A9gDWZelEsPuuD2twRyFUHMIP94+IR/Y86ORpYhjP8kRP1 e988kAw+u+Wu7+KGWug86FZvK94qIqwc/IxwH9PkP6+086mfoApzN1nh08v5zxJpHv1nXQ BmPgE9rc6oKkC4fYDHa+NzdsgXIevgeT9PxkERQPrh3vgNE9jqlyXZPNT3C2NTIUIqzd1t sAfsh/O0a5z88+KpSaq2xrxbIb3/umH9iDVQdt8TvvaMKtAsYDLzqr3E2mxZeA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1725203169; a=rsa-sha256; cv=none; b=k/+2M7Cjr7f2zZ18bacSjoEn49+hSsJrlTsYAyU2wuiibbYa5iP4+/d0MkBu0h6yW5/Ms2 5F8Q54Tnki5mG0KjPY8habM+1dzzOoRGXhjLS0j5Jr34AK5A+IHlKFygGjyJvb9xXafPu4 SvjzLjbqjvweQ/Qela2mOK5ogl9PfXXdRWfjBN0IiJwDG/D7QzPGyu3NYhCtj5F9OTaNSc 28mjlrMUyll+lINf4tA7YHSZQ2mXVAy1yu1W8BAtFtSlw/kYve1aWeJCi2xpNW9c3Yn1q9 z5cYysQIeSjh8u/UIqRUKcJ7Lnl/iNojakUWKeu0cUMPRFNieWewA/2QrUVCiQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725203169; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=B9xH8rGydmHQJxiQd4lcHzsRmer0n9qQEIp40Alp38Y=; b=fcMGvs5Ztv3CCTmZlMZ4Wk1sCXomrGrieZ2Ffd+hOv6o5TGM2GXRhEbA/vT12UrkrMV4Ig CaFpVqaNzQp7zpJkcINrXYQPgWCijro9wjuexBC6RT8cDcpLwoTW45xuvkhUC1GycnLlIH 6vMiwpkvsQ2fPVNBTZlyiHhpQHkCwwczvuuwzv8Y7+hJoxkP0VmHk+I7G/Hk+e9k3SE0to APvsD3HG+mXK+uSua8cKSX0ahnM1kNeNR59bGlj1jnwbcqe51gb3U5ZOSiyQskDFeLKAk5 aHVDko89fjMsJPo8wadpUd864kjjLZWFMPKjeE4O6r9v8Ew/W+0v3WYp7LMrFw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WxZw13pKDzZ61; Sun, 1 Sep 2024 15:06:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 481F69tG002532; Sun, 1 Sep 2024 15:06:09 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 481F693e002529; Sun, 1 Sep 2024 15:06:09 GMT (envelope-from git) Date: Sun, 1 Sep 2024 15:06:09 GMT Message-Id: <202409011506.481F693e002529@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kristof Provost Subject: git: d154dc21130b - main - pf tests: ensure that neighbour discovery works as expected List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: d154dc21130b607d7903f276dd6d463b990f33f7 Auto-Submitted: auto-generated The branch main has been updated by kp: URL: https://cgit.FreeBSD.org/src/commit/?id=d154dc21130b607d7903f276dd6d463b990f33f7 commit d154dc21130b607d7903f276dd6d463b990f33f7 Author: Kristof Provost AuthorDate: 2024-08-26 13:02:22 +0000 Commit: Kristof Provost CommitDate: 2024-09-01 15:05:28 +0000 pf tests: ensure that neighbour discovery works as expected Also check repeated calls. MFC after: 1 week Sponsored by: Rubicon Communications, LLC ("Netgate") --- tests/sys/netpfil/pf/icmp6.sh | 48 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 48 insertions(+) diff --git a/tests/sys/netpfil/pf/icmp6.sh b/tests/sys/netpfil/pf/icmp6.sh index b9b60a484afc..eb286e23ef4c 100644 --- a/tests/sys/netpfil/pf/icmp6.sh +++ b/tests/sys/netpfil/pf/icmp6.sh @@ -149,8 +149,56 @@ ttl_exceeded_cleanup() pft_cleanup } +atf_test_case "repeat" "cleanup" +repeat_head() +{ + atf_set descr 'Ensure that repeated NDs work' + atf_set require.user root + atf_set require.progs ndisc6 +} + +repeat_body() +{ + pft_init + + epair=$(vnet_mkepair) + ifconfig ${epair}a inet6 2001:db8::2/64 up no_dad + + vnet_mkjail alcatraz ${epair}b + jexec alcatraz ifconfig ${epair}b inet6 2001:db8::1/64 up no_dad + + # Sanity check + atf_check -s exit:0 -o ignore \ + ping -c 1 2001:db8::1 + + jexec alcatraz pfctl -e + pft_set_rules alcatraz \ + "block all" \ + "pass quick inet6 proto ipv6-icmp all icmp6-type neighbrsol keep state (if-bound) ridentifier 1000000107" + + jexec alcatraz pfctl -x loud + ndisc6 -m -n -r 1 2001:db8::1 ${epair}a + jexec alcatraz pfctl -ss -vv + + atf_check -s exit:0 -o ignore \ + ndisc6 -m -n -r 1 2001:db8::1 ${epair}a + jexec alcatraz pfctl -ss -vv + atf_check -s exit:0 -o ignore \ + ndisc6 -m -n -r 1 2001:db8::1 ${epair}a + jexec alcatraz pfctl -ss -vv + atf_check -s exit:0 -o ignore \ + ndisc6 -m -n -r 1 2001:db8::1 ${epair}a + jexec alcatraz pfctl -ss -vv +} + +repeat_cleanup() +{ + pft_cleanup +} + atf_init_test_cases() { atf_add_test_case "zero_id" atf_add_test_case "ttl_exceeded" + atf_add_test_case "repeat" } From nobody Sun Sep 1 15:06:10 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WxZw26T3Kz5VLJB; Sun, 01 Sep 2024 15:06:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WxZw25Pnyz4YXn; Sun, 1 Sep 2024 15:06:10 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725203170; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=78FXSSu7+Xz/y7x5f2PIKBAAsPt3kpC9UVdUPQGx4wY=; b=eS+KEOkWPcflpOws5GKStAAAg5UdY40LtpbftBwNc7HlxKqc/RSJly7a1Lb9NfnjwAsa54 wrFKBYBFgcO5lEzy+TlN1UAumUqwSL+Lja0rpWTxTTjVXLnSiKvh5rd3sOHsgXl08oI2+h hqEUSzOk0MHcFXnNnxpJCmGH5j8GwWdsYQhbOjZ+HqMwNXpu2qes3ViYXOYZxnx6NIrKju ZiNgQkT8JhJzZZgBE835ofXuJClYLVNawdyljbhSeuWDro8g6HtCp/ChV6xo+UZsmUVrVw vCSN/8p2s3zZ4z44lZkOon2XyMfJL/H/99CGOwitKutPPK0ZIAkdkGfWB0eRLA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1725203170; a=rsa-sha256; cv=none; b=tOFU4Xj6Z29Sry4ZCM2Iu9Eqzm+WMkLe5Oz1LHdcoeBURAABhMO1PDIKKN1gcJ2IAC8BW4 v/wwiE2ckurLPDyIZhPvwuTja5wmYsR25BDyWWGoTsED8IZWM5JUpTxXAQEvNcMp5eKzxm 3oJU2EEADZUcNHtDKQw+qIfidYeIq3KI0umW4yc7O4WvXmjwyqJx2Gl0vsrAXTN+8Fz3+N d8BQ7yS1BaDy4R/Y+I0BJebNpW/aSjPpdt/W1f5mn7AzLzeIvyzVsol3Bkv6sH2Jc3mo6e u9liWbPfdckjg8g3ElzZCos1w2hkJsk6O3HjQL3oTUT2Icwq016g6BsW0BeV/g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725203170; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=78FXSSu7+Xz/y7x5f2PIKBAAsPt3kpC9UVdUPQGx4wY=; b=fFOW8nvwEd+HmKrHOKad0ZQbtTyySAJSCQ5+KkF3oi7HN/3yTe0lxIunr+KRC3FK5aRpIm MoU6ztze/ee6h+von7ktdcC/TYem2xACjGUBC1QSiL8knDhkdnp3R5D6P7G0XdEYM/FlYB KQBuAdolitg97a4jjBptSsOES4tzBxXdVo4H38AAqLW+Mef6KPCMGGzXgArc80rwoG1Ell snoGmD9pwGqhGQJBcXZRTJL+y1qu5LYMMvzQowpqi79ZeugPqYJzB72TtoJVjGWBlyWNnt 1q2gknLATR7/bsuXAkTRJwAkf7jsD0bBCX6lYmhcAn9KDx0YBt3z5uaN18H2Xw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WxZw24d7fzYLK; Sun, 1 Sep 2024 15:06:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 481F6A6l002598; Sun, 1 Sep 2024 15:06:10 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 481F6AeA002595; Sun, 1 Sep 2024 15:06:10 GMT (envelope-from git) Date: Sun, 1 Sep 2024 15:06:10 GMT Message-Id: <202409011506.481F6AeA002595@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kristof Provost Subject: git: b8cd169efa6a - main - pf: try to lookup the icmp state based on a correct packet descriptor List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: b8cd169efa6ac0899b4998898129765ae5c685a6 Auto-Submitted: auto-generated The branch main has been updated by kp: URL: https://cgit.FreeBSD.org/src/commit/?id=b8cd169efa6ac0899b4998898129765ae5c685a6 commit b8cd169efa6ac0899b4998898129765ae5c685a6 Author: Kristof Provost AuthorDate: 2024-08-26 14:42:05 +0000 Commit: Kristof Provost CommitDate: 2024-09-01 15:05:28 +0000 pf: try to lookup the icmp state based on a correct packet descriptor MFC after: 1 week Obtained from: OpenBSD, mikeb , e467ea25dcd3 Sponsored by: Rubicon Communications, LLC ("Netgate") --- sys/netpfil/pf/pf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/netpfil/pf/pf.c b/sys/netpfil/pf/pf.c index b4f8bdeeff24..94c333e67c57 100644 --- a/sys/netpfil/pf/pf.c +++ b/sys/netpfil/pf/pf.c @@ -7274,11 +7274,11 @@ pf_test_state_icmp(struct pf_kstate **state, struct pfi_kkif *kif, pd->dir, kif, virtual_id, virtual_type, icmp_dir, &iidx, PF_ICMP_MULTI_NONE, 1); if (ret >= 0) { - if (ret == PF_DROP && pd->af == AF_INET6 && + if (ret == PF_DROP && pd2.af == AF_INET6 && icmp_dir == PF_OUT) { if (*state != NULL) PF_STATE_UNLOCK((*state)); - ret = pf_icmp_state_lookup(&key, pd, + ret = pf_icmp_state_lookup(&key, &pd2, state, m, off, pd->dir, kif, virtual_id, virtual_type, icmp_dir, &iidx, multi, 1); From nobody Sun Sep 1 15:06:11 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WxZw41YhZz5MQsg; Sun, 01 Sep 2024 15:06:12 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WxZw36nkPz4YBg; Sun, 1 Sep 2024 15:06:11 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725203172; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jEu8PHdAMyK8l0DZKnSZhg4V0S80m0OuUXmXvdlENyI=; b=Qlj1tdlZNFJgRMyoEy9sZVQx0MGaF9ysXzwGyaKxffBLM/7pOQczT1PJ3yI+xzAq9MWg0k oT7hjjNzoFGF/exEauK7AJEkjT/+m20kaUoJyqq+kREZFCUO7m2vPqFo02i9mtp28De8Nv PH1OYWBPKlSpVW1HRSxVQQ2xgtBweIluYUgvwO1rq8VsdEuML9lzwRr/58nXD8IZp7/f7Z QhowY49xc+Xa8j4P+a7QVgxBAWibuWNRnKWBHi5gx+jw9HcxmHcmaZl1DHZ+eNOQrHj5qA UJfYhXLi6eg9zBWYW0+iSqlqEdIS/rB1wmt34vSQNyIaaarxYJLC3fm3O5oMqA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1725203171; a=rsa-sha256; cv=none; b=vJMt0jCxyM+XvjVd792bxdxNzYqUQkTCjTSql7/YxXBZ41spjV24PKbUSKq4ue44Ik7yDa /yxHq4O68pFt8BUUgpzPG+fTwIua9ASf2aMEIBJaTXvLWWATU7YVcwsKp7UfmLD7OU0bfX va8abHxRktaksu8YrhtE6KfbD8CGynbfkOzBIdjHC9ewo6K0mDfBrxry3JvM9j1MtIW4BB 2ZeQP40eUTA2lX/UwvTJFpGQUGy6tLyNIk1xRIdxpkcVpDIkYxgKV1ECk9WaTVYZC1U7DF SOESxri/tSj09J1Ex28bfaLk8c1bSybGLk5U4pdn8x1uvRXQ5zKWURdO/hDBEw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725203171; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jEu8PHdAMyK8l0DZKnSZhg4V0S80m0OuUXmXvdlENyI=; b=niX+6EL4yN3a/+YPWiuxgFkvjI1V/y9MboGlsDbHXE+SYp9NwfhQ08iZdMzHbp0yPnkUrk ZzCLMtRjUdZAeXVOlb4c6Qq1bFcClzqlcpF12jZOJsuVKtf9d49lcJVZv2CreA4pSOM+zC 2mvMX7dtoEVaM0CfJzVnBFJW6pDSYSlOp+eVCIvoFQ+eojuj5sm5/9NON5D1Mut2ipHzD7 4lyDGaMO/gC4APjxqntCX243iFpELklZXcKU96hPqOPRzfihjKzaPS0q5AHNlzSlk8M7if 33h813jMiHIrQL98xW6zqfTOXCUlOMSDQnjD1InwVZZ8zYU/vMeBcnAl0MBl3Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WxZw36MHqzZ59; Sun, 1 Sep 2024 15:06:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 481F6BCR002661; Sun, 1 Sep 2024 15:06:11 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 481F6BGK002658; Sun, 1 Sep 2024 15:06:11 GMT (envelope-from git) Date: Sun, 1 Sep 2024 15:06:11 GMT Message-Id: <202409011506.481F6BGK002658@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kristof Provost Subject: git: 3da3eb6081a2 - main - pf: be less strict about icmp state checking for sloppy state tracking List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 3da3eb6081a2e2f6ea2fed1728d5dd7f9e8786e5 Auto-Submitted: auto-generated The branch main has been updated by kp: URL: https://cgit.FreeBSD.org/src/commit/?id=3da3eb6081a2e2f6ea2fed1728d5dd7f9e8786e5 commit 3da3eb6081a2e2f6ea2fed1728d5dd7f9e8786e5 Author: Kristof Provost AuthorDate: 2024-08-26 14:44:20 +0000 Commit: Kristof Provost CommitDate: 2024-09-01 15:05:29 +0000 pf: be less strict about icmp state checking for sloppy state tracking Sloppy state tracking renders ICMP direction check useless and harmful as we might see only half of the connection in the asymmetric setups but ignore the state match. The bug was reported and fix was verified by Insan Praja . Thanks! OK mcbride, henning MFC after: 1 week Obtained from: OpenBSD, mikeb , 538596657140 Sponsored by: Rubicon Communications, LLC ("Netgate") --- sys/netpfil/pf/pf.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sys/netpfil/pf/pf.c b/sys/netpfil/pf/pf.c index 94c333e67c57..e28bad8750f9 100644 --- a/sys/netpfil/pf/pf.c +++ b/sys/netpfil/pf/pf.c @@ -6740,6 +6740,9 @@ pf_icmp_state_lookup(struct pf_state_key_cmp *key, struct pf_pdesc *pd, STATE_LOOKUP(kif, key, *state, pd); + if ((*state)->state_flags & PFSTATE_SLOPPY) + return (-1); + /* Is this ICMP message flowing in right direction? */ if ((*state)->rule.ptr->type && (((!inner && (*state)->direction == direction) || From nobody Sun Sep 1 15:06:12 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WxZw5575tz5VLK1; Sun, 01 Sep 2024 15:06:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WxZw50SJgz4YTD; Sun, 1 Sep 2024 15:06:13 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725203173; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=c8PUBRWtgknrqsMnuifK7zKFm5+DPWkr0Fx9Vqf5JIw=; b=wF+Sjgfy7xbNHjluTBtALJVwzM6zTv7Onlri8uYsWtpXUAqpaMKDuiApLGG4QR+DJkdCZX mapl3zE+hNUUNegSPSEP0P3l5nHge3QD95tMsLZYqbY6Pxtd7hggVF4xdlWgjoH0gfhxjf pWbIqLW1AJZdfVY+3lSQB+B9N/KsLI6O3FBz7nobdzAvGBR/GxuSJfbia1ROdedIadZy2p He4JPaMaSmge7WtZ6gYSmP0IwjFpXTtjWegUl+qsQ6bVYqqUjCHu6Kjf5Ujw20yIVoF2lf JqU03iorCZZtVFbSmmYImvDr77tr4xkklsjxD/3g0ggZQtdSlpMzT0KlPai2EA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1725203173; a=rsa-sha256; cv=none; b=c16q95Z6LrA1asek4FmavNiTe5m5o5yPJzr+3Pd/rEPuL1AjEBzT0Py0H1GG+jP01qBRmI kyGC5j+uG+WEm/patRP4UFTLiceXI6H1ub6yUPoxl2ZeZG7QruBGvACf1Ra9+u/ty9XD9y 4zL3aqzBYlwFYfaUqlh7RCPd2asSqRbdqnEl6Yhwyut0IqUXwYXlfZCWZZRXlu4zMtqdJo E6eD/4QjmMXJoUWJR2ogY8uuGYiz+GSoOy3gTxVDm1ssrwvlrf/lA/XI7DfA2E3jv/eGeM nLzy2Hc+TAj7Wc7/Gsr+sB+jc0g3vA7qYvkCekDnNb+8ypls5esN7EUe3iGerw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725203173; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=c8PUBRWtgknrqsMnuifK7zKFm5+DPWkr0Fx9Vqf5JIw=; b=u5SlJUcLNDWhi57zGBMqINWnEZiPkZ5+mBYdVWo9kgfK8AggnnlWZxPETbZLfwGUtboFWb 3vhisu9QUSEVvfmAdOqkT3fH4Ao04PeUvZhgwZNzAKVTdVrglsifJ1Xy3JuXxHIp4tKwdm ocKblHyoCvRPtKrUNL5v1aTX9giVC9gm0bDxuK+j0DGEwCD0W45pVC88kA3FCep5LhOKWP cWGjTt6oJf5yki3YCs8fYROv/3+yx5GGZIKstFM80rtuUkCX8CAF2T0I7hDfl9Zr2s5jQ1 Xakx7VSixwQ/ZYAOIglAoU8Nt7rsLbW/mUjcA1qyXVvtlvzgcBKIB5FFCdOswQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WxZw501QBzZ5B; Sun, 1 Sep 2024 15:06:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 481F6CC5002710; Sun, 1 Sep 2024 15:06:12 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 481F6CtG002707; Sun, 1 Sep 2024 15:06:12 GMT (envelope-from git) Date: Sun, 1 Sep 2024 15:06:12 GMT Message-Id: <202409011506.481F6CtG002707@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kristof Provost Subject: git: 0578fe492284 - main - pf: rework pf_icmp_state_lookup() failure mode List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 0578fe492284ded4745167060be794032e6e22f0 Auto-Submitted: auto-generated The branch main has been updated by kp: URL: https://cgit.FreeBSD.org/src/commit/?id=0578fe492284ded4745167060be794032e6e22f0 commit 0578fe492284ded4745167060be794032e6e22f0 Author: Kristof Provost AuthorDate: 2024-08-30 11:36:39 +0000 Commit: Kristof Provost CommitDate: 2024-09-01 15:05:29 +0000 pf: rework pf_icmp_state_lookup() failure mode If pf_icmp_state_lookup() finds a state but rejects it for not matching the expected direction we should unlock the state (and NULL out *state). This simplifies life for callers, and also ensures there's no confusion about what a non-NULL returned state means. Previously it could have been left in there by the caller, resulting in callers unlocking the same state twice. MFC after: 1 week Sponsored by: Rubicon Communications, LLC ("Netgate") --- sys/net/pfvar.h | 4 ++-- sys/netpfil/pf/pf.c | 20 +++++++++++++------- 2 files changed, 15 insertions(+), 9 deletions(-) diff --git a/sys/net/pfvar.h b/sys/net/pfvar.h index 43d4b908a407..7b3c1c49696a 100644 --- a/sys/net/pfvar.h +++ b/sys/net/pfvar.h @@ -374,8 +374,8 @@ struct pfi_dynaddr { mtx_unlock(_s->lock); \ } while (0) #else -#define PF_STATE_LOCK(s) mtx_lock(s->lock) -#define PF_STATE_UNLOCK(s) mtx_unlock(s->lock) +#define PF_STATE_LOCK(s) mtx_lock((s)->lock) +#define PF_STATE_UNLOCK(s) mtx_unlock((s)->lock) #endif #ifdef INVARIANTS diff --git a/sys/netpfil/pf/pf.c b/sys/netpfil/pf/pf.c index e28bad8750f9..f7fe75184efd 100644 --- a/sys/netpfil/pf/pf.c +++ b/sys/netpfil/pf/pf.c @@ -6754,6 +6754,8 @@ pf_icmp_state_lookup(struct pf_state_key_cmp *key, struct pf_pdesc *pd, pf_print_state(*state); printf("\n"); } + PF_STATE_UNLOCK(*state); + *state = NULL; return (PF_DROP); } return (-1); @@ -6806,15 +6808,16 @@ pf_test_state_icmp(struct pf_kstate **state, struct pfi_kkif *kif, kif, virtual_id, virtual_type, icmp_dir, &iidx, PF_ICMP_MULTI_NONE, 0); if (ret >= 0) { + MPASS(*state == NULL); if (ret == PF_DROP && pd->af == AF_INET6 && icmp_dir == PF_OUT) { - if (*state != NULL) - PF_STATE_UNLOCK((*state)); ret = pf_icmp_state_lookup(&key, pd, state, m, off, pd->dir, kif, virtual_id, virtual_type, icmp_dir, &iidx, multi, 0); - if (ret >= 0) + if (ret >= 0) { + MPASS(*state == NULL); return (ret); + } } else return (ret); } @@ -7221,8 +7224,10 @@ pf_test_state_icmp(struct pf_kstate **state, struct pfi_kkif *kif, ret = pf_icmp_state_lookup(&key, &pd2, state, m, off, pd2.dir, kif, virtual_id, virtual_type, icmp_dir, &iidx, PF_ICMP_MULTI_NONE, 1); - if (ret >= 0) + if (ret >= 0) { + MPASS(*state == NULL); return (ret); + } /* translate source/destination address, if necessary */ if ((*state)->key[PF_SK_WIRE] != @@ -7277,16 +7282,17 @@ pf_test_state_icmp(struct pf_kstate **state, struct pfi_kkif *kif, pd->dir, kif, virtual_id, virtual_type, icmp_dir, &iidx, PF_ICMP_MULTI_NONE, 1); if (ret >= 0) { + MPASS(*state == NULL); if (ret == PF_DROP && pd2.af == AF_INET6 && icmp_dir == PF_OUT) { - if (*state != NULL) - PF_STATE_UNLOCK((*state)); ret = pf_icmp_state_lookup(&key, &pd2, state, m, off, pd->dir, kif, virtual_id, virtual_type, icmp_dir, &iidx, multi, 1); - if (ret >= 0) + if (ret >= 0) { + MPASS(*state == NULL); return (ret); + } } else return (ret); }