From nobody Sun Dec 31 02:08:33 2023 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T2jFt3YQyz55qhq for ; Sun, 31 Dec 2023 02:08:34 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T2jFt2Xwrz3WdG for ; Sun, 31 Dec 2023 02:08:34 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1703988514; a=rsa-sha256; cv=none; b=KMmllx7BJaHzi3qilAnbicqckK/guwmhCJFYaZGiMohpplImxhpZycoLZFfg5gNPW2LSUW wtVj4cu5JanHwm59yQvOBGmv6bbIRDJncyCT+tiR3kY3TS/+sjYtcYM92Wr+ozuxi+cclS zFjiImqlkehSXd3B1DTCLJtOBMcemlyWJxUeyE54vTccEnc8v9jX0f4Ghx5O5OFl4MqyIY HWd5yKfGWU+WT+lqMtqgWEakTBUSseehIVv9rV7gbd1lzQHuN/a3LNWXaW7x9lXEb/5+y4 Dj0TaZ1Q+HLwhWqmhbm86w0XhCpXQsWduLDv5XNLj0ScoESD4RSLY8k7o0HrZA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1703988514; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=m2yJ6y95f5KzdczzvlTXysxMVxBFTxe7NCnSDc74P4Q=; b=LbPWBBZXF09zA53qGzJF8xlVHKuPK9ijPGKe5cs/GpOSc4ajPu4pJyMmcmVMzcjGMmoiWx E+1XKx8RLnhBO36FFdRJnx9oUh+5CAi0kcWAGwnD+9c0PSlI141hqZrCi+IUmcdzvACPMp tX0V18gmUF7uNSOCXTWuXpBgJnsrmGHc1046idTtHgJfvceKH6bveGflKTwrx+yBdogebT KPFAknUxlFJQkp0a+0gxy11MT5zUXu1HyQFVhgyB21THyHwcmaxEk1TgqqDNiHE1ZT/BDr H96vjuc4wt+U0UH7CWC1o2CI8iGia9IMcWFlXT4yYAfxYtXA4jQhtDe5NvigbA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4T2jFt1VX4z1HP for ; Sun, 31 Dec 2023 02:08:34 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 3BV28Yn7003798 for ; Sun, 31 Dec 2023 02:08:34 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 3BV28Y9W003797 for fs@FreeBSD.org; Sun, 31 Dec 2023 02:08:34 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 252376] [zfs] cannot receive incremental stream from 12.1 to 12.2 Date: Sun, 31 Dec 2023 02:08:33 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 12.2-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: linimon@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: Overcome By Events X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugmeister@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_status assigned_to resolution Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D252376 Mark Linimon changed: What |Removed |Added ---------------------------------------------------------------------------- Status|New |Closed Assignee|fs@FreeBSD.org |bugmeister@FreeBSD.org Resolution|--- |Overcome By Events --- Comment #9 from Mark Linimon --- ^Triage: mark OBE. I'm sorry that this PR did not get looked at in a timely fashion. However,= in the interim, 12.X have gone out of support. --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Sun Dec 31 05:26:37 2023 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T2nfP3gkGz569wh for ; Sun, 31 Dec 2023 05:26:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T2nfP05z3z4TSW for ; Sun, 31 Dec 2023 05:26:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704000397; a=rsa-sha256; cv=none; b=v2/9034J6Sr/+rkTLsEdVm/+jDZBd3uTunVH3zvZJqUOg4OQg+acD4E4gzWV21eYsvU6QQ mpFUwWf1eW+RkJ6mDJVqz/GIMWxQQRdDlAsVbChF2fk4WW5n2wbSQFBQClaHvqK7fMMvUG Vw26DJlz6/F08kINDR51kngyC3A4NoisncZR8aoFeVoxzcCtjvDRcKvC4izVDPcgxFblNk zUg4GODGgasOK0p6rIcOy2RjtjCD/lRByW8Frn3OseXhgVktMCyQ3uVo+TZkT3cCwJzwub baVZ/A8XdkjhIG93U+I9efMIeHTqGUdx/8aU8JgfLYVJsokN7imKivFwFzF8OA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704000397; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=j+2KtO8Ap9Z7dl+6Pfqyw2dZGoScJhPuRIPTSWFKYb4=; b=j+UontnUVipV3gktYHcrttSOm4H1R2nxCumqKc2Y31zXF6VwlZ6jw+FkEv5wHJUw3f5MlT KlB+cCi1dDJ9+V4CVk2DlOvcl1u7qrk6/nROHqRtbVa7XfpJcUsX7Q6sVP1kXqUa5RD82R VakyVN/APTtwnFEFq4xj29z4u09QBS0N7zLnR/bzCI5clNOCSieuOouSFnpvnQFgDwmYYW HJ2ZjiKUZNVOOoSz6cY6rXEQZQSMt4qADi7wsmdz/4IdIKyFMxVlnLkpSi38IpUkb2n9aO LSDv4vievfiHjDCyFjHy90vFsO8n7n1lBGtcVZUxtiz0wn06m8ZiJFGyR5IzMw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4T2nfN640hz6gN for ; Sun, 31 Dec 2023 05:26:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 3BV5Qaet011072 for ; Sun, 31 Dec 2023 05:26:36 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 3BV5QaSU011071 for fs@FreeBSD.org; Sun, 31 Dec 2023 05:26:36 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 276002] nfscl: data corruption using both copy_file_range and mmap'd I/O Date: Sun, 31 Dec 2023 05:26:37 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 15.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: kib@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D276002 --- Comment #28 from Konstantin Belousov --- Could you please try with my latest patch from D43250? --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Sun Dec 31 13:39:01 2023 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T30Zd2XJZz55lxP for ; Sun, 31 Dec 2023 13:39:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T30Zd1SqWz4DfD for ; Sun, 31 Dec 2023 13:39:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704029945; a=rsa-sha256; cv=none; b=I6wA10Q9FoBCGNciPzvwchID7d9Zojp8plksUozDrO48wDlKPu1K7uWjAURCXEz3TcodWv H+dze5jm+TQZa2JMzgO4qzntidWQa0TYxv2DnSOAThxLUKpCBEf1rG2sFuS7u5AiJIw1Po OYrEhE/K+rEA2Aid7ULrvL/ZUkde0FBjFqTBBSvXWElb/+6mjvgTA1eqZOxCy+U/TIflw9 z0r6StcpSCi04Aw22668HJfc8fe+tkanEicS+jAK9orA9khJlFaxpL1p5lNJ+JI1doZG0K 9v/68wSPOMjtaTMu3JSmqRCNNBR2KlkHECTt3rcM+6E2KeJG2+4t+eCVbZYNWw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704029945; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l0tmM8Z1YGjB0sfmCUks2A1QB8z/SQQxr9W45GOr//g=; b=gb6vmOWCo2QXyTwDeMgCCWEuJLE/PSd7EbYaGoInaryGtpL0G7kDK7RdByQ30BuD8J8Gc/ 7W/+HrnxeHuf19agZCuRjo7SGG3od2WTI44IRfd61/BIbCHKdvEWs2uJiehwkmF2S2Gw6y YN+sVKnU7FU3sKH4ICh3CTKcVn7s8bIU1R/FFgaq03qhBom3OBUuzwVLX75RhrakBqs2xU 55w89BY/OT32E+YG+0tWaVzlAObpTUN80hk5cPawtjjIt6Ripurt+iODHYmojBAr/fMZz2 Nqs57hggGya7XbvO8BjTOTYowH1nQb+xcrSnTYhHoWpCryK1cxFyELm3BM2s+g== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4T30Zd0XrCzc77 for ; Sun, 31 Dec 2023 13:39:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 3BVDd4E1062357 for ; Sun, 31 Dec 2023 13:39:04 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 3BVDd4PX062356 for fs@FreeBSD.org; Sun, 31 Dec 2023 13:39:04 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 260160] zfs jailed: snapshots not accessible Date: Sun, 31 Dec 2023 13:39:01 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: urs.probst@triamec.com X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: resolution bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D260160 Urs changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|In Progress |Closed --- Comment #32 from Urs --- I have tested this issue on 14.0. The zfs snapshots work fine within jails, great! Time to update everything to 14.0! Many thanks to everyone who has helped to resolve this regression. It is ve= ry much appreciated. I close this issue, just before the 2023 ends! Happy New Year to everyone! -Urs --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Sun Dec 31 14:45:11 2023 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T322w6pgGz55tHZ for ; Sun, 31 Dec 2023 14:45:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T322w5hTxz4NFc for ; Sun, 31 Dec 2023 14:45:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704033912; a=rsa-sha256; cv=none; b=pEHq5mmOTe5tQPufblMrbpRl5nERGlWX+ZVPrqlXhzi94I61KR/nupELFha/OLk6s6W0/m llBf/CawjETgf1nWe+dhrxoLyqDVqV9mFcJuXq/SoU0lhK5/iOc2ay3sTpZ2STqvgbi4cl 1x/Se/RLuMKdu5HQs0fx7OwprbA15tZ9K7aij9G6KJUR5oHw2eQGvqCwy5oxNZ5QfC0d98 KiNw/S7+Z6QefT01vw4t2ZJeNpf59tycwM0++/2mdD03wdehGBHW/A3qm18/dsclSmmfBb QlVbm3+HdizQoqf/0C2aaPXbYvWejYMtG69mRirqQFnF9Wh6G4ImFkLn7NETcQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704033912; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lgvOUAniNUMDfNH/ATOqbKdNPb3dkg7zgj/rIvyMW4E=; b=cIWNZAkBQW7FHPC9l8S9L9PcWw3+AVYp5x0kOEv3lnXQKBVnIp8f3FW8UF0mSkDSRvCOKT o9+py8WuU8nEw02x0EI+wIfUCj20xfb3yJLzUA635+lOv+2FIW5bgMwIeJPdK3dq88moUT wjB2lmqdV4YFo+4Vx55YmQ3GXWGbbEEBvMdw29EGdy3B2wIy3r81rzMw3MH5yaxScT71rI et5ToloSNe7mG9x0WuJaZcuph+lLiDM0TBr5H3Yavjoif3nKOG+PGLTgHFYqP03BbYVyk6 fqhEJ7PvTZJaVrPYoAYkZkDoxyOtQRMyryT7NNyA2YICI9Vy3nLD/NVbdXnAKQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4T322w4nbTzdt4 for ; Sun, 31 Dec 2023 14:45:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 3BVEjCCV073163 for ; Sun, 31 Dec 2023 14:45:12 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 3BVEjCJ0073162 for fs@FreeBSD.org; Sun, 31 Dec 2023 14:45:12 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 276002] nfscl: data corruption using both copy_file_range and mmap'd I/O Date: Sun, 31 Dec 2023 14:45:11 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 15.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: asomers@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D276002 --- Comment #29 from Alan Somers --- With kib's latest patch, it's more difficult to produce a miscompare. But still possible. For example, using the toml file from Comment 4 with Seed 9675272854109691020 will crash in 95 steps. Or, without copy_file_range at all, it's possible to crash in 126 steps usi= ng seed 8637402481540764494 and this toml file: flen =3D 524288 nomsyncafterwrite =3D true [opsize] max =3D 131072 min =3D 65536 [weights] truncate =3D 1 fsync =3D 1 fdatasync =3D 1 punch_hole =3D 0 write =3D 10 read =3D 10 --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Sun Dec 31 21:00:12 2023 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T3BMc4rXDz55Hcn for ; Sun, 31 Dec 2023 21:00:12 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T3BMc2bcyz3WnK for ; Sun, 31 Dec 2023 21:00:12 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704056412; a=rsa-sha256; cv=none; b=Y1XHl2NiSyXi2QOgmJlb02Dx3aVPccDVM95jkuMK28x9MojP0Bm4ud88LPpNiRyljk4+p1 9pD5xUkXiN2HOhf9bluYTsEg3/D9ISDRtfXi+nic4HqOBuTkKG7ntOHberCMQoEov1z8wd P3/AE4Lo778EhZowN/tv6fJ93WXXL+Q2wm98kFOqYhbCp7seeVmdeP4D5Yy0f/byCl1NiB KnPIKfsg90rDnS+sK+sp8R5AMF/ubaN0djC/BhaiUf/mohSxNwskfPW/UNHFnP2Z+VQ7Kc zb8XAMceSnorwAaGIqn2eqBI80Sd10NuaoX5e4XLWnLc+UneBysR9tswVn9+ig== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704056412; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Ep6il5c85PkTzmo110+AMMs1Zb9G9lNqe3D15FkzKfo=; b=fLyC4N02+C1yuvqwMPalzbf/TsodlKQTyQ72rLVHrK1O+FYt7LTR5Sr6N6jtdtWH6LuCMg 3oZAtizFA8NFfkUF/4krAT6amLXC69HxCL/uO7kYEVdi/ShuHIiBUoF2OKSvbiRkOGyesu SlSGLWuwgj+teSulVquiKCXSFifbXsbbJCF9/KZuHg/mfHsQSdDb/wpSFDJ2reNtXOeiGk M3vdOa8U++IwB3u/RwNoNmtFrZBsfTpNrsThmFV16ok7nBVhEeOPD5NGFNs2VQtSrbk5me rz1WP5atGDRVvHr6U6h6U7/VQbY/XSFGRy900R3oAV/3nhV1yKZrcdpKzkVPMQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4T3BMc1dnmzpXK for ; Sun, 31 Dec 2023 21:00:12 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 3BVL0CWQ058398 for ; Sun, 31 Dec 2023 21:00:12 GMT (envelope-from bugzilla-noreply@FreeBSD.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 3BVL0CfG058397 for fs@FreeBSD.org; Sun, 31 Dec 2023 21:00:12 GMT (envelope-from bugzilla-noreply@FreeBSD.org) Message-Id: <202312312100.3BVL0CfG058397@kenobi.freebsd.org> X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@FreeBSD.org using -f From: bugzilla-noreply@FreeBSD.org To: fs@FreeBSD.org Subject: Problem reports for fs@FreeBSD.org that need special attention Date: Sun, 31 Dec 2023 21:00:12 +0000 List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="17040564121.956DAB426.56781" Content-Transfer-Encoding: 7bit --17040564121.956DAB426.56781 Date: Sun, 31 Dec 2023 21:00:12 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" To view an individual PR, use: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=(Bug Id). The following is a listing of current problems submitted by FreeBSD users, which need special attention. These represent problem reports covering all versions including experimental development code and obsolete releases. Status | Bug Id | Description ------------+-----------+--------------------------------------------------- Open | 231794 | zfs: Panic due to ARC related KVA memory exhausti Open | 237067 | ZFS: Crash in vdev_dtl_reassess when using GELI w Open | 244692 | gjournal: Does not support TRIM Open | 251035 | ZFS: Allow 64 bit ZFS to support 32 bit ioctls (W Open | 264139 | ata: NCQ_DSM_TRIM trim method for Seagate IronWol Open | 266409 | 13.1-RELEASE amd64 crashes in: sa_handle_destroy Open | 268162 | zfskeys_enable: each successful load of a key is Open | 269503 | docs.freebsd.org: default vfs.zfs.arc.meta_limit Open | 271384 | zfs_load is not suitably documented Open | 226130 | ZFS: solaris assert: zrl->zr_refcount == 0 (0x1 = 10 problems total for which you should take action. --17040564121.956DAB426.56781 Date: Sun, 31 Dec 2023 21:00:12 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" 
The following is a listing of current problems submitted by FreeBSD users,
which need special attention. These represent problem reports covering
all versions including experimental development code and obsolete releases.

Status      |    Bug Id | Description
------------+-----------+---------------------------------------------------
Open        |    231794 | zfs: Panic due to ARC related KVA memory exhausti
Open        |    237067 | ZFS: Crash in vdev_dtl_reassess when using GELI w
Open        |    244692 | gjournal: Does not support TRIM
Open        |    251035 | ZFS: Allow 64 bit ZFS to support 32 bit ioctls (W
Open        |    264139 | ata: NCQ_DSM_TRIM trim method for Seagate IronWol
Open        |    266409 | 13.1-RELEASE amd64 crashes in: sa_handle_destroy 
Open        |    268162 | zfskeys_enable: each successful load of a key is 
Open        |    269503 | docs.freebsd.org: default vfs.zfs.arc.meta_limit
Open        |    271384 | zfs_load is not suitably documented
Open        |    226130 | ZFS: solaris assert: zrl->zr_refcount == 0 (0x1 =

10 problems total for which you should take action.
--17040564121.956DAB426.56781-- From nobody Mon Jan 1 02:07:40 2024 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T3KBN3Z2pz55sQy for ; Mon, 1 Jan 2024 02:07:40 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T3KBN2W7cz4d7P for ; Mon, 1 Jan 2024 02:07:40 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704074860; a=rsa-sha256; cv=none; b=yfWGIsHrU9zVFIUqFO9Q1BaLje71Vu1tVYj7+DdKO307MYcCf0yd0vsDTn3Mfmuh7JAbUi q9Xe+EhT1M4pWTaGjki98aRimVckjS4kMllBU+S+a2G+ehnKR5VxLt1xYnT0HotfFgzh1G ZpaMOMoqZ75ySOdIwXpXlD5NvaAFPCfAr7LdwH+sgZHkLEpremhL8b7lj0DIwiz28hbY/y ES7G3iJJD8eQjzlO+O3MSWlSxDSATepGX6dP//UXxx+K+7p0Z4S1qDi+meq+hvP9jnKsN7 GFV+GnyfFn/4h/n1N4jkrKdvetBbFqsQctOmewpJzmRqtYtBgYRJd8cPA03gIA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704074860; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tRvjNegN6w396qYrp85hgG91NbgJgw5VnXSyzgo5zsI=; b=UySVeprtVRhcuBSYuxQNND3yGrlB8qwBsR+VfowOCtDvVcoIlYJgVgMh5vfKy5nZw+5Py+ rqEgIgctlCIEpOdcwAhao8gYmjIZlhDuFl01hyTbBxlPIx16a55TN3Gkp6iK70vnXPBBeq 2ubkAMnil9/YcFu7bzBE+xKy3Z3QK4d4tmsbufhKrXbLehUWeS4oXWX3rFKvgZkyym/BWk caR6YPh3bTB3bt45DkhTuXFAtNSTc33jysaeCVE6dxUmqxy8+/95/5xyMcH/pJx3Q7T1vX xXVAeXOC6SJ2uG8Tg0re23zhv35ryIegQWY8stqSpWinZcy4JyRr6lFrnj5JWA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4T3KBN1VVvzydM for ; Mon, 1 Jan 2024 02:07:40 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 40127eFf033554 for ; Mon, 1 Jan 2024 02:07:40 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 40127ecT033553 for fs@FreeBSD.org; Mon, 1 Jan 2024 02:07:40 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 276002] nfscl: data corruption using both copy_file_range and mmap'd I/O Date: Mon, 01 Jan 2024 02:07:40 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 15.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: rmacklem@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D276002 --- Comment #30 from Rick Macklem --- Alan, do you know if the test does any other syscalls like rename or link even though they are not listed under [weights]? I am wondering because both nfs_rename() and nfs_link() do VOP_FSYNC(), but they do not call vm_object_page_clean(). Also, could you try a test run with truncate =3D 0? (The nfs_setattr() code does seem that it should vnode_pager_setsize(), but maybe more needs to be done.) I notice ncl_vinvalbuf() only gets called when there are dirty buffers. --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Mon Jan 1 02:16:27 2024 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T3KNW3zVzz55tJh for ; Mon, 1 Jan 2024 02:16:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T3KNW26Hfz4fbD for ; Mon, 1 Jan 2024 02:16:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704075387; a=rsa-sha256; cv=none; b=uflZ9Kew7dA/qJJzOcRO7W/SQRFcyl68nbLkHJ7WnQpdd2y15VL5LHZDb7pEf/8aZtWAaE e0Qk/T1hR5mU/ja7HOd7Aw1hKYwTcpNwZEfQS1gHgw33akp88/7oSgxvd+E8bKhEmx1ir5 KELf4dh9OCSU+InOS7dnsw7leBrBaz048RV08uDXWaxhWwJ5ri7ZQZmU6RVJ32/ytkP8q6 VwlJsKrXbYD8pkkYq48+k+p2QmFsTddFXpuJHvqaGrWuvbfR+7XxJasrTpUz7Zts7uC8Qo JWyzqT+yal87ZOhGjh3cJHgGp3SeVyXFyv9l4GhEvE5+RkH7aTlZ4fOQc24Jww== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704075387; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7udZgczShJ7E7skhUo3HEX+hONDsEN1jlZ4Ccy7OgGQ=; b=PyToQJ3XfcSoQocbehJh9gqMhASpQ1YRMbgrUpWniTQaTtIcFN81zjQwVGDDEFM2hW8ILz of1sXX0Fu/mpsK+qzYRGfXm1hHrjiib0av8ci/L83EKUT4+5bAjDLISIs7MnJscbgwZ1M7 XgBg038s3FvxTS9b6JiqLCOPwOHYNxxB6RrnXi/V8AQxTA85oCg6k66bxPNiNYVoL5qzQ2 ylSTyZbMPIW0Ml2MNDJh2GuRphdJyIiU44U34K3Xenwroqd1/APWGBL5ieqRojWt2eRkQs mReQPePDTK7Lblk/+eVBduN/IAFSII2Z/H+0mlG5Uf1WcZLdCqcJ/cti0X01Hw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4T3KNW0zQCzytJ for ; Mon, 1 Jan 2024 02:16:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 4012GRm6054835 for ; Mon, 1 Jan 2024 02:16:27 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 4012GRR3054834 for fs@FreeBSD.org; Mon, 1 Jan 2024 02:16:27 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 276002] nfscl: data corruption using both copy_file_range and mmap'd I/O Date: Mon, 01 Jan 2024 02:16:27 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 15.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: asomers@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D276002 --- Comment #31 from Alan Somers --- (In reply to Rick Macklem from comment #30) It doesn't do rename or link. It does do some ftruncate calls that aren't shown, but I don't think there's anything else. And I'm out of time to help with testing until at least the 3rd, and probably the 6th. --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Mon Jan 1 14:18:38 2024 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T3dPp4BWQz56prm for ; Mon, 1 Jan 2024 14:18:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T3dPp1Bd5z4j6x for ; Mon, 1 Jan 2024 14:18:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704118718; a=rsa-sha256; cv=none; b=d9k2PzUjmt5p3APVJFD0+vkMSmqY9YXYWEOuFL9+em6oaBqCiwvC7yhJ59yxZpiYv/7+xV VD5dTZkmw1LqqgYjYDylkkImSdQaQxfyaaWFwhiyQCImJ2S29+8CBXKHYmirM7RuJJSYMR ePI0tsQYlP5mSM6ovMqHgEdwjG7ZVD+cSTpsxPyydLEv0tkVrQ+AoubPbdcTZQnrkujnZP P8xqwwFI8Mq4f2+sjDCWiSFd8qfwGmmybSwCLtvMQ8xfz7G5OpGa7bM9ptKzgG+cTRI9Q+ 7h+gOCjvkPd0U2ZFHfRfEW0zbuvu7oHT1KHpKBlY5ycNK5cGiLvmq6GZl4J7gA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704118718; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LY6vOlHlznfEdSQqLMwmg/qMiSbWTrhAFakxd27ufjU=; b=YFJGNAuAhZwLqwQrNpOIaGhE0L5yH90Mecp38cix68PQU2sHXL1RjsK7Y9MxgCGE4aiPJo nHzc72y5PzjwP/QLxLKRlE3CR1kJ4jYPIC62Kak+kZwjF1w+tpJKlQ0F3/QKt5E5IqqIe1 4ZZnHD9Imn66LUDDVUy7IVYdv1SIhoTC6q5w0RNX+KW8h4iL/w6e6Shbxhkt6SXlVDgj/p fCm5bC7sRzu5Upqpiw9ERNCJiHbQtV4juKEu84Mhi1xKw+HzSCBhLERx0ZP+1+FzIUMnmh HzVyKIrFxDsXwATuwiaQYSoi5uhdqEYiMBsSeSnD0QtJNDOVKdpKS30k2gH51g== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4T3dPp09c7z65D for ; Mon, 1 Jan 2024 14:18:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 401EIbLW000744 for ; Mon, 1 Jan 2024 14:18:37 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 401EIbWC000743 for fs@FreeBSD.org; Mon, 1 Jan 2024 14:18:37 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 261538] zfs panic: VERIFY3(l->blk_birth == r->blk_birth) failed Date: Mon, 01 Jan 2024 14:18:38 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 15.0-CURRENT X-Bugzilla-Keywords: crash, needs-qa, patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: pi@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D261538 --- Comment #13 from Kurt Jaeger --- (In reply to Kurt Jaeger from comment #12) Another crash with the error: VERIFY3(l->blk_birth =3D=3D r->blk_birth) fai= led (9909 =3D=3D 9902) https://people.freebsd.org/~pi/20240101-pr261538/ on a newly created zpool. I was able to recover the textdump this time. --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Mon Jan 1 15:48:32 2024 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T3gPX1rJCz56yG1 for ; Mon, 1 Jan 2024 15:48:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T3gPW70LJz4sP5 for ; Mon, 1 Jan 2024 15:48:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704124112; a=rsa-sha256; cv=none; b=ve6rKzsYrAXrCgFQbVxRPzr675y8+yKR6BZq+alD49mx7ZfwyURqN3d/5QkCqVpmgcZUqf 0l6jVblUu+iW7IwuG47nidNEk/41ciNqWsxwf3jRafb/Xfav/RuSh2qGlu8K46hexzhZAS hnsVAwSIxf+pmtmsrODH8YVlQVhzivzpXD73KmgLa1nVK9Ng7Flgs8myCPno25QcXJY1P/ 4nNKY2sMniauYZmBGTCGRbOZlyiXvMBEd7EbxaHdgVrgEWcx6v4gemu04RbU2LCmbfqGJT sv+jcVeOjBAvRDd3Vx9l/+d5FgM0NlayRqyMYMnibTqwg+Pq1zGw2nVmC/DRxQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704124112; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dzHnRIRiGIJK1fcApfS96UJjso9FOjc1hOSb0KTV0BM=; b=rduhgKGQGhX8WhGvkBOj1FTMye/EgJ41WJ/4YuZFe2pTxCbgYpBhX7EaRu3FTmWLajxuZ+ OgXeVu19SCnAN/nk+E0Q7argHgYHCsPJuIDAz0d8V3TMYfla67YlHwdmbCLoQkv7iLi02g vAlJWJxyO5smSFVordgXIqXkUY5taDq6gGGtMZo9W5PiDu4T2BelCZF5Te8S7zGAbtFf3J E/V1CBpSIX0dfBf4H9Q8yySYRF0O2Jj/MIjfW0xvP0ZkVQb8+oI+2DFA+w7Va5KHmpDhI+ YLKvk33UmDSFnMuqrthbXUrgwub4uoK+VVvlRA2t4O2tkzVm43BGo5hW+wYLmw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4T3gPW64PCz7r6 for ; Mon, 1 Jan 2024 15:48:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 401FmV7q031373 for ; Mon, 1 Jan 2024 15:48:31 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 401FmVCn031372 for fs@FreeBSD.org; Mon, 1 Jan 2024 15:48:31 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 276002] nfscl: data corruption using both copy_file_range and mmap'd I/O Date: Mon, 01 Jan 2024 15:48:32 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 15.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: rmacklem@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D276002 --- Comment #32 from Rick Macklem --- Righto. To be honest, this may not be fixable, given the way NFS does I/O below the buffer cache (no vnode lock, etc). The fix may be to document the need to use msync(2) when mmap'd I/O is mixed with syscall I/O for NFS mounts. --> An update to the msync man page maybe? --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Mon Jan 1 19:01:26 2024 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T3lh72r6Jz55L8m for ; Mon, 1 Jan 2024 19:01:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T3lh71l8Dz3W91 for ; Mon, 1 Jan 2024 19:01:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704135687; a=rsa-sha256; cv=none; b=wFBF0LUgjSxE7ATdh6SFbq5GJVzuptVUgNMBcE9jRHpD5yCaQKj6ryzanF1mj8VIdycbW0 JesJf+uEFda0XFoAxc5thXXI1psa2VXvmoB24pFuec/2R8JHguLpM+18dqa4i6VVLZl7ej i7AUF6ycLVTsQAcuKNqzqzWKf6JX4JkRY6l1XdZhYTE1RrhqLjBqKsJcvYikgf4HdtWjV9 eUDXR5idukkLUDggSou0MtaWddGnXtdydhsDjpeLj97YUgsSVUnlj9RfNxqr5UW3hIxCak NsDkQ+vAUkr0a9i2MT3mJ1Tw34dpcFiXEKCWWuzG09MKRxXxdc/ZxFC2DgKf0A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704135687; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sZYDQK6IEJukVhpHi7hBboyv2z3wYlTu6aRjCerWkyY=; b=gks7Hz++542SZLgamU/26lUhR8aVe2RzLhjjpQN65Gu7k3308uBFVRo7dWoaKdaH/8Xy4P lXvlG3LgUPK322js44DZLCZgbRAipynbWv/0FFD8wqQIUuGC1O7R5FZakQx2Y4jUP3SgJ0 P+kvX9RTXl0ISZzV2V8yAORB9ShpuigbZ6ooy5aesPnKIjJMCSdQFAbp3/8kLk0deWaxHN O/Neu5zT+w2JYp6OHEfpwCNW28OTPZnfvndmd32s3xx7igCZlO4P0Jw+chYg7VE4Jolmhp 6U7cIeyYLLlPQ7YszmWhCzebD5R4jp+KGKDD9M4EG6Mjl4/k5DXhdYDMvfM6GA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4T3lh70r7yzTyl for ; Mon, 1 Jan 2024 19:01:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 401J1Rus039274 for ; Mon, 1 Jan 2024 19:01:27 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 401J1Rfj039273 for fs@FreeBSD.org; Mon, 1 Jan 2024 19:01:27 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 276002] nfscl: data corruption using both copy_file_range and mmap'd I/O Date: Mon, 01 Jan 2024 19:01:26 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 15.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: lexi.freebsd@le-fay.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D276002 Lexi Winter changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lexi.freebsd@le-fay.org --- Comment #33 from Lexi Winter --- is this related to bug 270810 which reported data corruption using mmap()+msync() on NFS? (i have encountered issues with this in the past, b= ut i never got around to making a reproducible test case to file a PR.) --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Mon Jan 1 21:55:10 2024 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T3qXb54qtz55gH0 for ; Mon, 1 Jan 2024 21:55:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T3qXb1q8qz4NKr for ; Mon, 1 Jan 2024 21:55:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704146111; a=rsa-sha256; cv=none; b=p+y4RSuLMQCALC39YGKOssbIOOBejdSFdTu5FpDJGC5h29hBcKlHBtbPAFMA77uIGevd/S dpe8MotCyQAxq9aUyl3IZ4JedvJOMIShHZAFmwcXQAu5O+1T1B4+e4PrHOkPqagU5NU82x ZW3OXlS58NyZX5Kd8JwUpG80/u74RUXjo4A74yV/2J2pqADzM8p72o8bNwW/iGirbO2nzh MUpwblY8SjIwM7zAmy5lcAdCjIfLeza1w2b6HgZuC9d3kQ3rZA/Pv9s6DM/EHgLUlFTrpl LympnUdaX9mBxpKpfCsrber1cn4ra/rHGID2ajbeh9my1oAW2Po8/MkpGL7oNA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704146111; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z5d7qQ9r45CfCVVFx1bDYdReFqIgf/fwGj8mEImkiJw=; b=HbCUl6gUN3uush7zhfWiQx2HFq5mPS9yckyYGkuaQLuhqSBYolIzQnjumA6s+UTRdt0Yce X8TTFRY6mromFFNjfDqkBSCtjYedek5cGlQSr4B8gEsDgItiDydbuhFaJvss2OGcqwf8of 5p+Pml8Y+Xt8LdjE0VGG740WhCXRp7tFU/+n8W1I7YRQ82YR8ybgGHQd+mKxqpEJdL01+L ch9/hH+G3egpopmWfPmWxfuRqiN07D4evRdmnqSx18MI35c+TgQ6dyAN8a0jEoFABs6emh vbPHf54+mbnyGKJUOj+SZjcPh3+eon58aYsV1HxNlC4DiI5d3hZ/my+VYdk+Ag== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4T3qXZ6GsPzZnv for ; Mon, 1 Jan 2024 21:55:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 401LtANS026176 for ; Mon, 1 Jan 2024 21:55:10 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 401LtAQZ026175 for fs@FreeBSD.org; Mon, 1 Jan 2024 21:55:10 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 276002] nfscl: data corruption using both copy_file_range and mmap'd I/O Date: Mon, 01 Jan 2024 21:55:10 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 15.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: rmacklem@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D276002 Rick Macklem changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |geoffrey@dommett.com --- Comment #34 from Rick Macklem --- Ok, here is my understanding of what currently can happen. Hopefully Kostik will correct me if I have this wrong. #1 - File is open(2)'d. #2 - A byte range (lets say the 1st 100Mbytes) is mmap(2)'d into the address space #3 - Some addresses within this address space are modified by the process, dirtying the corresponding pages. #4 - File is read(2) sequentially. Now, when #4 happens, there will be read-aheads done by the nfsiod threads. These simply do Read RPCs against the NFS server to read the byte ranges of the file into the buffer cache blocks. They are done asynchronously and without any vnode lock. --> At this time, I do not see anything that stops these read-aheads from filling the buffer cache blocks/pages from the NFS server's now stale data. Now, I thought adding a msync(2) with MS_SYNC between #3 and #4 would be sufficient to cause the pages dirtied by #3 to be written to the NFS server (via VOP_PUTPAGES(), which is ncl_putpages()). I believe that an fsync(2) between #3 and #4 will also write the dirtied pages to the NFS server. Without either a msync(2) or fsync(2) between #3 and #4, what could be done to make this work? - Don't do read-ahead. This would be a major performance hit and is imho a non-starter. - Don't do read-ahead when a file is mmap(2)'d. This sounds better, since it will be a rare case that a file will be both mmap(2)'d and read via read(2) syscalls. --> To do this, the NFS client needs to know if the file has been mmap(2)'d. A flag could be set on the vnode when the file is mmap(2)'d and that flag can be checked by the NFS client. --> The problem is when can the flag be cleared? My recollection from a previous round of discussing this is...not until all the process(es) that mmap(2)'d the file exit. (I cannot recall if the vnode's v_usecount going to 0 is sufficient.) - Having some way that the nfsiod threads can check to see if there are dirty pages related to the buffer cache block and write those back to the NFS server before doing the read. (Recall that the buffer cache block will be quite a few pages, typically 128K to 1Mbyte in size.) --> This could be done by having the nfsiod thread LK_EXCLUSIVE lock the vnode, but that would be a major performance hit, as well. That's as far as I've gotten in previous discussions about this. Note that this PR started with a specific problem related to copy_file_range(2) and that has been fixed (or kib@'s patch will fix it when committed). The more general case as above, well?? --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Mon Jan 1 21:58:34 2024 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T3qcV6TX9z55gT4 for ; Mon, 1 Jan 2024 21:58:34 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T3qcV5S3Jz4Nk3 for ; Mon, 1 Jan 2024 21:58:34 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704146314; a=rsa-sha256; cv=none; b=JfjMwQSVjkALE/M1EDuNzcf8xrKCVf1sS0TEimMFW9O4lubOKsyzO7IKmI/fP386DKsBIv vH/K+QGp8+V+r37EDDsacSqs0xVIihDE4S3bv8ihP4qUdKqp8q3rx0o41zrVKB61Sqhn0P gAc3eotHemcv5FRKsaFk6TIpZ+//l53V4rcadXsNYiBhwxcB4QGj6ucZiiEBP8defgyMlp VhZjegkpp/LG4izCuAQNNW31juEAGrZn/OsOz6UINRA0MFJrLzFnmFI+/UkD9vaUMgvyK+ yrgAZuBDC03KOI2NfsKHPqHH8poZJ0nQ4RNeMuQCR+HMsKs8utGf+WUQzum1gQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704146314; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vgM5uPIP5UCvItvhFnpUN/RckUQn9sI7w/BQ6NMGM54=; b=YJaBLK/vXCzRyXR4SDrMn8AiEqheKxCJ/fNfQeX5OG2VaXzyCJjpn4krutdRH4mrV73qWP OKaWw4h7dkIW2JFSqtKPTQ7cLtroNOHEyinMwgaQn+9Ls12OZR7NhaiUEO1E3+GqzXfiNL I5+JHdCDaNpo+X62E3Jr+OC7GuMWYqyljxZEuOGsF7FQGp4+9cE5X1SzUAPfTRxf6rw1Dp CBS3/5qFZVOk5zj8+S2vcO56ROCe3eWfhIeH3KmjglOqkBFIXjI3bhxH5DypsntjeQuI9C Tn/h4DyG3OMfRRHPJYH3aO9DkOVRn/hbQp187LBw1JuIyqnjZ2ZJ2ggIiATHjw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4T3qcV4Jv9zZT2 for ; Mon, 1 Jan 2024 21:58:34 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 401LwYGY027735 for ; Mon, 1 Jan 2024 21:58:34 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 401LwYNC027734 for fs@FreeBSD.org; Mon, 1 Jan 2024 21:58:34 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 276002] nfscl: data corruption using both copy_file_range and mmap'd I/O Date: Mon, 01 Jan 2024 21:58:34 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 15.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: rmacklem@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D276002 --- Comment #35 from Rick Macklem --- I added Geoffrey as a cc, since he reported PR#270810. I think these two PRs are converging on the same problem. (He can remove himself from the cc list if he chooses to.) I do disagree that this affects many people, since I have only seen 1 or 2 PRs on this, but it does affect some people. --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Mon Jan 1 22:06:37 2024 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T3qnn2qlwz55h9G for ; Mon, 1 Jan 2024 22:06:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T3qnn1qJ6z4QJ5 for ; Mon, 1 Jan 2024 22:06:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704146797; a=rsa-sha256; cv=none; b=h0BZVlGiOwRYgK/ZrCSZ5Ns01RbtkNpLX4u/iceoUsEThb2H3+MCp+NF/0Ijq3u+EDgv+5 lux2qEp13V9bwLFtGbGRftVAmsErgn9Ry2iG//VuZgGFv15rGZVmzDYfCwlczl1TNuyMC8 2WxY82Kwa3nxOM+YcS5i8V7r9U2oTehCbyVaO1NH4hKvMYct/ybeIKJofg7UEdgw5npzmb /2MkZ80N0Ty1nxFFaoqWT7QaOv6tWgwK/aNMSh5fB/KokmXOzPdDwRBMJEHh+lg845fAUG Vn/W3FcPStwPgPB9NsgH/XV31q0rJBwCz0TDIelmNQ3NpHwJRN9zTLmP46A2qw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704146797; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2tGnlV2yx9kS2V2vQ6G0aBwI841nSoOF+UdWAnVAz88=; b=IAqDJ7hrkvZJCZknB9wfCeIFLqzoM4Brno1X6fJZXZi32oavBXHt0c8Dfewi0DpARUUJlT ZF+ffjgqltWhp53lHwbiANMVA70ePL03z37XlDPXmlhOVCfpIuDCYl6qtQC75KjZA2Ue5v sPVDYONJLakvv+hOkym/M2+oA7V+wviF/uOFwatdniQRk1cTuJ0WKxCNm+tL5JdE/rc+tJ AHtP4+mec1uFIjBmVogF4O9PJatBm5nNMx5fxPZmsi1Ew3NFZsBlfw7r5uX/WGOseMY72Q XAVPAgeJQGdydpCt197xZavi35UxxfUZwCJUzcNZEuENEiV0zNZ3CWDIcc373A== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4T3qnn0p6mzZxH for ; Mon, 1 Jan 2024 22:06:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 401M6bac044722 for ; Mon, 1 Jan 2024 22:06:37 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 401M6bGE044721 for fs@FreeBSD.org; Mon, 1 Jan 2024 22:06:37 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 276002] nfscl: data corruption using both copy_file_range and mmap'd I/O Date: Mon, 01 Jan 2024 22:06:37 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 15.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: lexi.freebsd@le-fay.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D276002 --- Comment #36 from Lexi Winter --- fwiw, my own issue with NFS+mmap() was using net-p2p/rtorrent, which is a fairly widely used application and which (famously) uses mmap() for nearly = all filesystem operations. when running it on NFS, i found it frequently repor= ted data corruption issues with the files it wrote to (i.e., it would write to files using mmap(), but on reading those files later, the data that was wri= tten was not as expected). that said, i am the only person (other than Geoffrey) who i've seen report issues related to this. i couldn't say whether this is because the number = of people who use FreeBSD NFS and mmap() is relatively small, or because the problem was caused by something else. i only mention this at all to add some context to the discussion :-) --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Mon Jan 1 22:21:24 2024 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T3r6s36Gkz55jfq for ; Mon, 1 Jan 2024 22:21:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T3r6s26N6z4RTT for ; Mon, 1 Jan 2024 22:21:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704147685; a=rsa-sha256; cv=none; b=vqihzryJISZsSCsz/KuPAW+yCe7oRFDsOI3pyvn4kmrtHEHZvfGkJwwr21Rfp08ZKrOO2L g1oHYLYA8nciDC7fSZFWMM92TybBE6qo0DDnDQohVMj1AvUsMRjSI5AAuSoUI1S2ltWBjF 6WbhuXoUGGbAifXYm7jTDRHRy5Or7f0tvzAasbdFKn9Fc9tPm9zkgCuKvQBs8aMp2TFtKU dtTS7t9aiJFpz3PN8ny1sqgUojrgNlwoJtZRJA1aXea0TQgiiN7xU9FD4yLT10QzEHqRod vG6CpeYtGKpQl3kEUadd+z4jhgEYFVQItsOTe/LbBSVHH3AVs82QQzYfPmgXUQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704147685; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5CBtDXdbcBF7TjjN3Qxdu5/lRVJKTB0x/k1csJdiaM8=; b=h1QirA9Cr7f/hF6KpRm4OBM0QfPX9UZeD8fv5UYjaeLQqX8T3bT7Uo+hSCUEp+Ikg3HA4B GHawrZMTebhqsm1dk9ARAhuKYV/J60d9tyKKpBI2Ikarv0AZXrQgMvzdDf41kU97G/FUfj kdWgzeHkfRTr9y1Lt1Gx8+y3u/7Hdp/SBDcQiPKERCH0uOuaoKqXCIF9NjCED9F0fDudd2 DJutP5F2vDAvZkur1QZH8+qaAt7SyysToo4cFBlrvNzSdmKHI9THfeQszW+yetvjFYAo9q Cst9r3BYED4H2N1Zi74mrwcc4EQMRvFRwD8eZ7tjvl29DdxSty8h04EPz57nNQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4T3r6s1B7zzb8l for ; Mon, 1 Jan 2024 22:21:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 401MLP4F076114 for ; Mon, 1 Jan 2024 22:21:25 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 401MLPY0076113 for fs@FreeBSD.org; Mon, 1 Jan 2024 22:21:25 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 276002] nfscl: data corruption using both copy_file_range and mmap'd I/O Date: Mon, 01 Jan 2024 22:21:24 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 15.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: rmacklem@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D276002 --- Comment #37 from Rick Macklem --- Going back to my example case (which sounds like what net-p2p/rtorrent might be doing), it is possible for the NFS client VOP_READ() to do a vm_object_page_clean() which should ensure that mmap(2)'d writing (as in modifying bytes within mmapped address space) is written to the server. This would not handle the case where mmap(2)'d writing is intermixed with read(2)s. Does that sound worth doing? And, is it likely that vm_object_mightbedirty() will return true when this is not needed? (If this is the case, a flag on the vnode that indicates it has been mmap(2)'d would be helpful.) --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Mon Jan 1 22:27:13 2024 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T3rFY4CRVz55kD5 for ; Mon, 1 Jan 2024 22:27:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T3rFY1yL7z4SJD for ; Mon, 1 Jan 2024 22:27:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704148033; a=rsa-sha256; cv=none; b=Hu6kE1HhNC86/dN0mh99+JKS2cBueW9ZZa2bLMbFJM/xr+Yc8WTu5FRBJjeHQT5ccbqO0p +Tn7QbDHXUPOyXZ9czuzxk0pxlNfNvL5+/mdczBSstbwooT1OuXylm+/zyJBgKezqhU3IG KW5nIW8+N3mUHRbuOxPw2afcRDFJ/IgJeEQf0h9fW9EWpf04tKgcyTydR5a2uj2kHtRLHP ZqLnQWzXdlUD2/kBX4UOfFIZzNRN0LPIQSWjB5JBaIZgnCywWth3b6b1Sz8Dtu1o/JrcxD odmBZX7VAPHZ8HNuxsC7nsmhSFClzuRkAN2wR5f9aJiO4epUsYuEp21WolBhdA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704148033; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k1tKpmIS8ClIRBamXxTMzexdatdlsYdlm4vS/boBIz0=; b=kd3c0wzsFB7K0u/U4xjfHUPb5nuaeObLCuViECyXnqkRZu0uNbRzJl1BidKfdgrNEvUFR1 pLse5zl7YwQFQ/VwaJr87rpqa8eDgMlDKl3uVDiWKwzi/4ta2y5GKqnswA6JljX91rRWfA B9nUaSujP5/rnmJNZIwXMwN2dDwl/2O+Rch3+vTpnKuWvtSJZSdGO8YeDoGD4CxPqbwteW cjyhnJI24Rf00GdZ/blpyR69YI6/sjIXDNGDCTfIzvNgjOI4ZLxIeJ7QkEGhR+FzuDif6V ZBAqonCpvhBZ44YoN6K3W6xaY+Sn/Yowy6RK2E8YgHzsFAXv/vzfB2rSgq4+aQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4T3rFY0wQczbZh for ; Mon, 1 Jan 2024 22:27:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 401MRD3C082724 for ; Mon, 1 Jan 2024 22:27:13 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 401MRDMh082723 for fs@FreeBSD.org; Mon, 1 Jan 2024 22:27:13 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 276002] nfscl: data corruption using both copy_file_range and mmap'd I/O Date: Mon, 01 Jan 2024 22:27:13 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 15.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: kib@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D276002 --- Comment #38 from Konstantin Belousov --- (In reply to Rick Macklem from comment #34) This sounds as an interesting theory, but please note that read-ahead initiators in nfs_clbio.c checks that the B_CACHE buffer flag is not set. This should prevent a situation where we have constructed buffer with valid (might be dirty) pa= ges but not valid content recorded at buf cache layer. But lets recheck the theory anyway, the patch below should prevent RA when there are writeable mappings: commit 2234d9d4f7595a78bf10c08b1e6b12d2115799cd Author: Konstantin Belousov Date: Tue Jan 2 00:22:44 2024 +0200 nfsclient: do not do (unlocked) read-ahead by nfsiod if there are write= able mappings diff --git a/sys/fs/nfsclient/nfs_clbio.c b/sys/fs/nfsclient/nfs_clbio.c index e6486af55daf..1f92fe0a4cf3 100644 --- a/sys/fs/nfsclient/nfs_clbio.c +++ b/sys/fs/nfsclient/nfs_clbio.c @@ -481,9 +481,13 @@ ncl_bioread(struct vnode *vp, struct uio *uio, int iof= lag, struct ucred *cred) on =3D uio->uio_offset - (lbn * biosize); /* - * Start the read ahead(s), as required. + * Start the read ahead(s), as required. Do not do + * read-ahead if there are writeable mappings, since + * unlocked read by nfsiod could obliterate changes + * done by userspace. */ - if (nmp->nm_readahead > 0) { + if (nmp->nm_readahead > 0 && + vp->v_object->un_pager.vnp.writemappings =3D=3D 0) { for (nra =3D 0; nra < nmp->nm_readahead && nra < seqcou= nt && (off_t)(lbn + 1 + nra) * biosize < nsize; nra++) { rabn =3D lbn + 1 + nra; @@ -671,6 +675,7 @@ ncl_bioread(struct vnode *vp, struct uio *uio, int iofl= ag, struct ucred *cred) */ NFSLOCKNODE(np); if (nmp->nm_readahead > 0 && + vp->v_object->un_pager.vnp.writemappings =3D=3D 0 && (bp->b_flags & B_INVAL) =3D=3D 0 && (np->n_direofoffset =3D=3D 0 || (lbn + 1) * NFS_DIRBLKSIZ < np->n_direofoffset) && --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Mon Jan 1 22:30:07 2024 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T3rJw0cdMz55kW0 for ; Mon, 1 Jan 2024 22:30:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T3rJv4KjPz4T6f for ; Mon, 1 Jan 2024 22:30:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704148207; a=rsa-sha256; cv=none; b=xcadilgNl7k4b+xWDmbUMlKi57pOHD+0htKb+RTToPFIhuVaV1IYW+mbpefaGhGvkY+MAj tgxfhf5aG90ivRvybr5FHZgA7I6TqS23JEst/yQpfdwhIlaHma0e984xUq/Ki7yY15rb1f RSv1GofYOnEMfIjdxCXgsfmC42ox/yUKJMa5+S0Tg5oghfiVxpqQO6xIhXULTsyws3eQMT FpGs+J22cNzXTC5I3ZJclNaZoxAcwiG1FWp55c+++CMTM5AuVQwfn8yGD5EZ+F8yksvaLi vrGu+kKuxLRiZwr77F4R2Zsr8vSFO6f0HxWBwvfsuuOzG/RvRiTT+hIPXG5U3Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704148207; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3AHCEQkRX5ZCpT4OUjZAFVrSbLXZnUNiBYWdcNlaCis=; b=bxnikndapoY4rY2nlBu04fYCI56iX9LMRA/12RXPRmojqnzYpRbjvB11Wsf2mY68Ty8+9c 2Uf9BZ6lsnnhAW5zPMOo0DDa/bNjBEU+HSHpcrWqy3qCixapOfGSGgd3DeMZYAvp4DqbLh OADuvrN7Ki8pQAPlFDP5joXeZ2vTEHs1IXIaN6KRTwikhz7FwxwSntEuhugXRJRHaBBiOK SM0DAceTCZ5i2GLvFcm2hjuIAAvGAw+s9V2+otJ/o6ZihwWGQaSaBm7KZKYWackk0kzXMP R77O+3PEdlJtMJxZ5Rxz4mAhxTF3z/TDDBQyif6Ua6L3DQ3KYFDEsM7hWXshJA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4T3rJv3KBLzZyZ for ; Mon, 1 Jan 2024 22:30:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 401MU7bk084331 for ; Mon, 1 Jan 2024 22:30:07 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 401MU7sg084330 for fs@FreeBSD.org; Mon, 1 Jan 2024 22:30:07 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 276002] nfscl: data corruption using both copy_file_range and mmap'd I/O Date: Mon, 01 Jan 2024 22:30:07 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 15.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: kib@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D276002 Konstantin Belousov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pho@FreeBSD.org --- Comment #39 from Konstantin Belousov --- (In reply to Rick Macklem from comment #37) I though about doing vm_object_page_clean() before starting RA, but the pro= blem is that current lock is shared, while we need exclusively locked vnode for write. Lets try my patch first. I added Peter Holm in a hope that he has some spa= re circles to reproduce the issue and to check my patchset. --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Mon Jan 1 22:44:03 2024 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T3rcz4NKjz55llm for ; Mon, 1 Jan 2024 22:44:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T3rcz2YZcz4VTy for ; Mon, 1 Jan 2024 22:44:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704149043; a=rsa-sha256; cv=none; b=QnimztcBL4dq+GP0c1QhlAS+Ss/6UHec8bZQ9QdktHhQfL8DMr1Ca7mt1BZckqD8v1XC68 IacU3RAJVOR5zelSl0jTXM9QyY5IvxwJd4HU4YTgfRM1yAMN39XlKXSow8Jv+9Sc8/0ShP Oql9SZ04nj0onqdQIZosQtXckQesbHJUDYzmm8zYclRnibnD4zV5lH4VPbdagMz2fqUtWU 2ar27yI+RAWfwtOWL5RowGuIB87aE+ADesbN2K74CQCI+9T6+Mh4Go5nECVpgUcUX7obGD 8Vg+lk8bwaOyrz+9nNztTm1aCMlwHHa3v5wG2jsXH+7dW1aqmMmQUfW/PjDxiQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704149043; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MzcXKztvcuSMHVS3/0VzVISxeG1M+C0SzOrqD1KLOpE=; b=F76BGbyZCXKpVHwx8iP9b+28ZmwNLqHMucLaPJoXlUK5dk2jdfq0HVRlmYUv9HAyPFRX/n zmqw66V//TEn/TlAFLf2+VbBaHwHug9zF6jyE9su04XLnat3VXC1ZIvjlhXF7eCB68DejG aP9msq9KfcolLtZsKuinZ1mhPt9NZ0sIbkRFbNnyQQBLH0X/ErDLAzZ6rQA4nL/Bn0gUEV xnN2kgv9y/Js5H+lYKtFuTXgfwYp+AiCNpvs4iR7qXc6+Fqa3uSrjFmgdYnoESMetJNpNb sawSI/KvlGpJkjkxfskDNYLba37Vr7207kbRG/qJRNgyWz5gP5XxbJc0cz7Q/A== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4T3rcz1chTzbrX for ; Mon, 1 Jan 2024 22:44:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 401Mi3d7012876 for ; Mon, 1 Jan 2024 22:44:03 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 401Mi3cI012875 for fs@FreeBSD.org; Mon, 1 Jan 2024 22:44:03 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 276002] nfscl: data corruption using both copy_file_range and mmap'd I/O Date: Mon, 01 Jan 2024 22:44:03 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 15.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: rmacklem@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D276002 --- Comment #40 from Rick Macklem --- Sounds good. I was about to try a patch which did the lock upgrade and vm_object_page_clean() when vm_object_mightbedirty() returns true, but I'll leave it until yours gets tested. --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Mon Jan 1 23:03:38 2024 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T3s3b6xgDz55nd2 for ; Mon, 1 Jan 2024 23:03:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T3s3b5pfGz4XKw for ; Mon, 1 Jan 2024 23:03:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704150219; a=rsa-sha256; cv=none; b=ZHi68ipHBF5ZrGz3IfJkDprrk9AwYiCsdjvkk58EU/W/WFA/z7MTb3eFeGpXz/EjHmDq2H /nFzu9TNuJOCbGj+ly+/9l2m6OoBZ1G25ol5iYzwJY2u6JYNouVmuzr5D+ca5sCCMo6nNj B5v8M2Olt+NqR3+HGIo6+n3fUAyAqtU7251cO9kGFfW++N6KU1xh4RI+omNs/nI46cLlz7 SgkIghx/p42VS1LTlyY7zdl426PhHm0zXSwUfCpLPlarf0/dqLRH42kWuOF7697IHFVUfr tngVAErQDXxHxuKJVy/LvEEuYLwnOr5JiCktAOge9Lx8ryqtap4GDlNaqQuepg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704150219; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6gOg6kUE3+RNEgsoaOCGZdiyR6mpRq5hhn+Y6t71OvU=; b=ufXYloubpbItMrVz8VP0UqH7hTtLV4/5ppWfG3c9wxN+SAxNkp1F+4RwoPtJaWsKP6H1f4 jY2H4mLRNV4m4be9/+VDgL2Uiznsxis3i3KO9EXkrpGrQPBsjuBgssfeQ7USGHz1NOYqjs rp2kjNWqQAaW5vNCtNathrvB8NX7hUMkJgYgyK9tItD2RdPquCi8UulmZp+AEJXATJbA0C yAc+D7P+u9PDhZB6dzV2RyH+u02Uwhr+aps8iWov3+W6FknbK+8gTQwvDIM7T7t4X885n0 ofKxo9w9L7N2RdajApjNdJ9AsEWDqY8mMLskFKMvIg0P5RDM5YxadbRWIj9KJw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4T3s3b4vQPzcBb for ; Mon, 1 Jan 2024 23:03:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 401N3dD9044278 for ; Mon, 1 Jan 2024 23:03:39 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 401N3drV044276 for fs@FreeBSD.org; Mon, 1 Jan 2024 23:03:39 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 276002] nfscl: data corruption using both copy_file_range and mmap'd I/O Date: Mon, 01 Jan 2024 23:03:38 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 15.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: kib@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D276002 --- Comment #41 from Konstantin Belousov --- (In reply to Konstantin Belousov from comment #38) I now believe that if this patch could work, we need to check both for writeable mappings (writeable > 0) or for previous existence of mappings that dirtied the vnode (vm_object_might_be_dirty()). I updated the patch on my WIP branch for testing. --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Mon Jan 1 23:21:10 2024 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T3sRp5CYQz55qZv for ; Mon, 1 Jan 2024 23:21:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T3sRp45jbz4Zls for ; Mon, 1 Jan 2024 23:21:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704151270; a=rsa-sha256; cv=none; b=IsbFTurIMrwISA4C/fkoSmEw5HHKYbrMG6Bs5/dCSCl/EkttOHfzI0hUtEGaPD8vxOMi1J 45ZUR0MuzTBXjc05wWoLVqGuazMv/7gM7ketZaV80E58KiVBO94BQPyoeTez4/qdQTDZBj +VxcgPpiYqjvF/qHrQSwDsBnFnWNg5O/ru01nJixohuv8tslBzIBxITfFR4z6BByPOwWlk wKzrgnzzJLWJQgS6UGF+3G2eKwbWL8LxzwqakhQGW+dI2FkE8CNrgY48LLHMUbVmFCkv/O hyRPdpd2bjllNReEl2CJdHT8xDw6xlsGJTQx2v26L3vsYhsn4c65NiiCZcGhOA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704151270; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vI4+wi6DBoJDL1+3leCdCFJt0lM1gxTCjt2oSIr9AoI=; b=TzWi7e/k4VBwskUfPYZm2ctIUDqMACzqLXrqFi7KZ+Ys31UaO+ZNgVEkTVUZl+vl03PPDw Bl+gZg5K1kvHssLxb45O849JYkTK6cM6zPS5sZSdt4yf3CaJWO5UoKF8Dk6L9MG0Sq+sw7 ALoaawPoJqYxD6KGG16b1B1kVyZFDFKCSshyHrs/Met14rYtzbovnO2er3XEZwhTEt494x AzTnNg6nqDjL60wtsyKwoG97VhN4uLQ3rQWfT5jhmIZnlBYmN3/ErpSUKEH87TSPqUGCq9 +kRsorPSxcKjcQzlNSiOdyeEqhR6liLe5sOsvx3kkoioZb16nbUdnxSQ7fIJ+A== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4T3sRp33qszcRm for ; Mon, 1 Jan 2024 23:21:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 401NLAnC062619 for ; Mon, 1 Jan 2024 23:21:10 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 401NLA4l062618 for fs@FreeBSD.org; Mon, 1 Jan 2024 23:21:10 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 276002] nfscl: data corruption using both copy_file_range and mmap'd I/O Date: Mon, 01 Jan 2024 23:21:10 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 15.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: rmacklem@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D276002 --- Comment #42 from Rick Macklem --- If I am reading the code correctly (I may not be), it seems that vfs_buf_test_cache() will clear B_CACHE if any of the pages allocbuf() has added to a new buffer are not valid. So, if a buffer cache block is for the first 1Mbyte of the file, but the mmap(2)'d process has only touched one page within that first 1Mbyte, does B_CACHE get cleared? (And then the read-ahead happens, overwriting the dirty page.) --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Mon Jan 1 23:24:29 2024 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T3sWd6XPdz55qSj for ; Mon, 1 Jan 2024 23:24:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T3sWd49zDz4bkP for ; Mon, 1 Jan 2024 23:24:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704151469; a=rsa-sha256; cv=none; b=q5UmgA5zXHxdJM6q576bIyqs3Smo0YnIyn7eM8tmubnaZyKG6cxQzR0nIy7z7YS9Yuah6U dcai61wYveC+FITb6HJWsDHfgW8Yku3RbtKZrBEMlv8YYGruMYCWW6ZKbLybVBagvOtTSH umoSdaYyAJlgWb0vNXZjpq9OOQ9epKppszj6JOyLMe1+3XKyVAZbvtmTAPIIJWsKsO3h6h Ne3owPn/I6EUNeGMkZnYmKu7O0NHIMA0AlRcCWvHs3eY+jWkQrTd6k+qHCRyUTE1ZmkZGy /D7uPdp4x1SvLF+0Kgq4vRulO4dMp06jQbhvIOyp3bRkkCN0QAOKHFfzlZTTqA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704151469; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EWxXh0AK93T4NCh1Pr6wUhBDNhXg/6zeBTs/SVylD7w=; b=NPeiQyeLZm49ZEiCZDtZKpRaB6eFNJYA09kjb2ZljWAOFhGJgfmYkyYnVMJ5jvsO2+uNYr wB9hxrwyKO581s5JbtArQJPYTA2UPpQcj/EPXOmR20DNThwtcIFqJazlThMbUkNjKhJKVy N65v8lxezaY7GjXLoSeNiBNvI9rqsVMzO9MDP5IywZW2VhJqzHjrvyopfmsEzkjSBpm5Yc cPiOZZrph4uEMTNQc6K/GT1pGKfXydWjhDWu4dG1pQcdyYocMakGeO4jn97ocGWXVJLi7E c5deur7xdFWa3SFRfX5NDjngILSM1Hz42Bfjcta2yqr9z9daHeJ2bcugWXU5MQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4T3sWd3FpzzcSR for ; Mon, 1 Jan 2024 23:24:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 401NOTBs076278 for ; Mon, 1 Jan 2024 23:24:29 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 401NOTcr076277 for fs@FreeBSD.org; Mon, 1 Jan 2024 23:24:29 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 276002] nfscl: data corruption using both copy_file_range and mmap'd I/O Date: Mon, 01 Jan 2024 23:24:29 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 15.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: rmacklem@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: attachments.isobsolete Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D276002 Rick Macklem changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #247360|0 |1 is obsolete| | --- Comment #43 from Rick Macklem --- Comment on attachment 247360 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D247360 Don't clear the dirty bits on pages being written through the buffer cache This patch is crap. Please ignore it. --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Tue Jan 2 00:03:53 2024 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T3tP60LCMz55vWK for ; Tue, 2 Jan 2024 00:03:54 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T3tP54qRlz3DYj for ; Tue, 2 Jan 2024 00:03:53 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704153833; a=rsa-sha256; cv=none; b=lHkDQmS9nT6dJXFsD+Y0ku386soq7GnNbZEO8N+xZqoIRVHHEsuMuzxTT3SQowPF7kdrR8 aSIYk7XdiR1uE/LjdA7pf3DO68VvZMONYo7t1mzFl+5Yu0WS+80ZVw0jwPb+PvlDYGk0dx 08923vuwC8+X7my2jnppSwAWbufHsuBzpQmXEjD10JboEST843MWU6u2jpcIpiyObgYYJk DS4DzS8JKKoCp9zXd+t5JHYgMOaZs1+00qPhjJMzdl3AmGk23kfb/ODc50kTPY57zAaB7v cfcDFurKYXct/MQBqkAepUh5hN2Ok0o6MlaXyN9/jKOnj9a/7mjinoxBc6ChaA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704153833; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ce6dkNAJZMZUYyuPi0OHCEgORUKpAEjHs1i2wYUauR0=; b=oEI3pU67YrZ3V/WOjYmxKyafkPak289m39GXH5MA55QveYEw7M+brta0z77/bvwOiPJeXl myEQFND+m5l1GKxZ3gWnMd31GlJmRu2lVjzn3bO5VyCBTomXK4/TC56wohAGynxLwTlTyH Qf5l3Fgj2kleJWFnd+zgoy6mjaGUvHQ4yLNkTj9cjjfMkLjrcb8DxhKGN5z+YJuUxcunfI zhhpAb6vvaLHEEDpp4PqdkOTiUeZ2MqX+FTCLg3D0nT4rW4tEvDbK6D/xPkTYj77L0fAm/ AVzb1oNWkKtNu4R45Gx0o6ERQV1ZsHObY3sxRhHizXov8AZVVZ7uUxfncSHWIw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4T3tP53vwczf5V for ; Tue, 2 Jan 2024 00:03:53 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 40203rwK040191 for ; Tue, 2 Jan 2024 00:03:53 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 40203rEL040190 for fs@FreeBSD.org; Tue, 2 Jan 2024 00:03:53 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 276002] nfscl: data corruption using both copy_file_range and mmap'd I/O Date: Tue, 02 Jan 2024 00:03:53 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 15.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: kib@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D276002 --- Comment #44 from Konstantin Belousov --- (In reply to Rick Macklem from comment #42) If the buffer size is 1M (shrug), then to map any page from this buffer, kernel would validate the whole buffer. At least this is the default setup where vfs.nfs.use_buf_pager is true. In other words, it should be not possible to have a buffer consisting of a single dirty page and rest of invalid pages. --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Tue Jan 2 01:06:12 2024 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T3vn20tNwz5626X for ; Tue, 2 Jan 2024 01:06:14 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T3vn16xZyz3YfW for ; Tue, 2 Jan 2024 01:06:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704157574; a=rsa-sha256; cv=none; b=p8GJDQIZXRXOqSii5ILcY65OFOO5dlPBxfgf1HiSNdBZkrDPcnKhaJgqpX6LqsrmE5ZtyB cJAtYT87viaLjqsiJ9dKRlJ2Xka38AETS73GYZRpVcHokSJYnfm9ez6BN5rN1kJ51RkRik 5i19cWVk0pUxduvzBPTk8pZS/uv9qw4XGOk7Px2GRQOQIla2J3yj9IyLlX5wtSsjdClckt EJ80DFfUwWhObw6Pm6EDWGJfx03PV+hB8R0i9J5GXd4MjNVFwsvnrGO6YNJf1b267EyjSd a+18EmBxxIsf0ocUSWwkB43GMwyke+ERrCjyLLgXCQPosFuKgG56VocaNNo6NQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704157574; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QtlD57qt2CqON11LAnRR4OUwSHZn1x0VTDNnAkd044A=; b=e4IFUOxpnbgxtkQk4hwNX5avwb0btdj5xEzDUO+j+J2fYanro/qInWcfusMgRIcf0+6hLu rzWDIMJXridb3ZVXGmHMVoZQRYwih7MbMz+HzvOgq3PWYaKYeObGrxUO31FRFzCrWRyBcB /hNqW9iVqG05B8aj71h71kIWY7X2hZTh6txuCmTpgjACJMRD+wOACXVXyDfFPTGQnyOkUb hNMslvNWYvh8JAl2uj4Dmcom90Vc2fFnuFpPAleKHAzPlVNvbuhXy96hq1QyxbI30lQrTv hmnrZ8Q8mk62RC5KqGljmS1IDjQTWhroBFV1xsR6Fhc8AWZmYrSO7H7wx2tV1g== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4T3vn161Jszg1x for ; Tue, 2 Jan 2024 01:06:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 40216DQW042471 for ; Tue, 2 Jan 2024 01:06:13 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 40216D3n042470 for fs@FreeBSD.org; Tue, 2 Jan 2024 01:06:13 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 276002] nfscl: data corruption using both copy_file_range and mmap'd I/O Date: Tue, 02 Jan 2024 01:06:12 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 15.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: rmacklem@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D276002 --- Comment #45 from Rick Macklem --- Yep. I just saw that (fills the whole buffer when a page is touched) using a trivial test program. This trivial program did not expose any problem. --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Tue Jan 2 01:37:16 2024 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T3wSs2Kqlz55qlb for ; Tue, 2 Jan 2024 01:37:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T3wSr69b6z4GL8 for ; Tue, 2 Jan 2024 01:37:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704159436; a=rsa-sha256; cv=none; b=qw+JqZx69PrkXL8rQQz5a2I2LzMpmvxd62ER+hZkWtuL6SStM3+nx0dWAy1c+yRAXfvIg+ uEDSTMgn7iv+TYybPaKaXBx3bgFGV34ElJT5VB5SmQeG59QO+7LYXG9nsAFBdEhf4x7lRP Sq/cwENgEzmHpwlhd+5BpcUPyFJXe77rlmPOt2Oo1PepVzJM4fyLSIGapp2G4h0bxk1TZp oFlMdKFtC3ufiC929GtUCVBheIKsB+SzRR+J5QAOBJxRoSPQ8X8JyJASaScxZqOh2F53X1 +9PpPliqA91A0H2eUjK2Q2jJLy25okg4jMFFcwLXoWau5/NEpZh8CedxmvohSg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704159436; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FtnPxNE8M3Kooe8a89X9zraNL1u7wdAqnts4/hbTC5w=; b=o3p0uBCbquGsbvvF1X5iTpa/CdZKKcNccv4vkP5qL5ldgDRaYu2eMwAoNC6SZzKL0ZLM+a dhg4LZXTDakUlDjzcmBWV5IynmK8Q5bC11mzX/dcmP2nEc5AZ33I0hTDzfsmnCQO4AHWMW SvOwDr4WQE/WEW0BjUTlqaXIbh5DumcpAIK4H9UnzA4eRucBVK1m5IuQE25PtKJIf/Ez3K MRny431VbsiZ328ZrPcl9/WTPhPPLGNCvxwf7YMamg2sgo6RAw54okHKbqSYpNw29/dM9X 347LGv8f9U1G0+OGgirSMh3SaoN/f2TylyRcEK4CYR5oKgPDbxYMAmKMG7EX3A== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4T3wSr5Gq4zhPX for ; Tue, 2 Jan 2024 01:37:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 4021bGA9091960 for ; Tue, 2 Jan 2024 01:37:16 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 4021bGxu091959 for fs@FreeBSD.org; Tue, 2 Jan 2024 01:37:16 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 276002] nfscl: data corruption using both copy_file_range and mmap'd I/O Date: Tue, 02 Jan 2024 01:37:16 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 15.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: geoffrey@dommett.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D276002 --- Comment #46 from geoffrey@dommett.com --- If this is related to the bug I reported PR#270810 , The problem isnt the p= age state, but the fact that when the process writing exits, the pages are immediately discarded before they are sent to the NFS server. As long as the process that has dirtied the pages is kept alive, there is no issue. This affects bsd nfs clients, linux nfs clients are unaffected. --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Tue Jan 2 06:44:22 2024 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T43HC0CWtz56QMd for ; Tue, 2 Jan 2024 06:44:23 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T43HB5VSsz3PbH for ; Tue, 2 Jan 2024 06:44:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704177862; a=rsa-sha256; cv=none; b=aYunUYihx/2muzcmlA2oJy6qe6KRg6Rpc0kKf0kUMmdAik6ygu31rycQDFdvycKgf/HY3M Ligafk5gmSRvquTQzUcsuvJd94rQXw4nlbCKOq65gu1r37YhMSZzUjCAaaU0s5uXsNsivM pHwj8Ed+rdTnPqmrEgYQZtpDbDpSaKXXuLjcf8YwT199+oNjyVacwcEoph5lbo/3d1/yso MI0ski2VBRZUVfoSOhqUIw0I1A5JCdDJeO8kPtqgJh2ljRFwHbC9znjMk5CpX3MJcvjuvC Zk4NWAzRSPuUXP3vj7X3Ay/mFvHFkJjPyjSdZHbl6RFRtXk+kXGtBWfgAKl9gQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704177862; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=X/9TQW2Ap2IqI/N4OCLLubITfhEOWT9jPVgqP8/jPBQ=; b=OLbn+rWG3HD0dEmsjAEpcbwu9wJ/9SwoIx9XjUJ1zmNRBQ/UO+bIB4zIY6a4xzl9eVrVT/ VGpiE00Q8qB50Mz2I5Gxzu/f90pjrRJ+0TFJe0c8H1OQ1iQq3xvJIJtZQ4w7TPDxgB9BhQ fENY4DRg2coe8TWL+tzvDpX+UZCUvdTyd7GruDz91KNvGNYseSc65BynYWsy0THKp+4Ox+ +kqMCfbGQV5O/CusOAz73eIoe3Od0YUcfZRT49UOxw/x6x11XJNoyEjQbFu+UXrGnPC0Qo ENh+AQ+EBUL6rDtsZcWoAOyrmCqrgbKka22uSI1563hZ2jIZko8JlPJapUxSIg== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4T43HB4Yb8zr8f for ; Tue, 2 Jan 2024 06:44:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 4026iMO8093221 for ; Tue, 2 Jan 2024 06:44:22 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 4026iMeX093220 for fs@FreeBSD.org; Tue, 2 Jan 2024 06:44:22 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 276002] nfscl: data corruption using both copy_file_range and mmap'd I/O Date: Tue, 02 Jan 2024 06:44:22 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 15.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: pho@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D276002 --- Comment #47 from Peter Holm --- (In reply to Konstantin Belousov from comment #39) Sure, I'll take a look. --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Tue Jan 2 08:09:45 2024 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T459j6vpDz56YsF for ; Tue, 2 Jan 2024 08:09:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T459j5s9Hz3bn3 for ; Tue, 2 Jan 2024 08:09:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704182985; a=rsa-sha256; cv=none; b=bKpGPVPAVq5BBoduTXszP/RwMw2lY4zOFH45/e+Fzc8uXEzkGVXia0y7prryfyER9H+SdH otre2/CLueNuBxjOu9a6ONjDRFuo7hvECFoFkpl7ZURxkefmz6lKh9b0VFl6GKbBJ4mzqO V0MZydUXIgqDXch6E2pUvmnVnnd+1/zZNJFJrmCo7eSk5WwyxgjXmJJ8xwmMK+hjHlr6Xe 97IHoTFzalqUwskWPeqLvN2Z6s/sxi8cS9fI071d5xVFG6r7KS0pActNGLtOV+mMN/eBAV TQwiaC6zMi9ZwPBVZPiekq5pBuGRbwS7EEP0PYln6EdhP4CaFoEM7EweREiStw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704182985; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WJChPIQFPmc0e89GY1rXa+f3L4UbEyxj/bA3fDEbQb8=; b=wFG0uX6DfJYPFJ682ZTrcCOl3+RdX9PxPCVFRGkT+vAlvrOMU4PBQR7V76US/Vz6gAX769 Wj+bEtryt44M3MbcDS3idnGb5l1XpscDNfCJaBGrA0eu3vJYsLdxvYXWtyDDQwdPG5pwDv Vn5BgQT0egkZVpU3TMohFJZRu44nTeUgHwosa097439CUiuJaL6jTSM7TTXOqB5njZls2I afcEhwvzLUn0C7DonekdxtnW2/UbbniDv5ySuUZXAKb2l+wGaLcUFiy265duVG1a1AgxRb 1e4QrRa78T+PsqGUmBl/7+/fGkGNWTImAszdmgpki78T1Zg60o6lDG0DbCbzWQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4T459j4r1Hzt8S for ; Tue, 2 Jan 2024 08:09:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 40289joV016363 for ; Tue, 2 Jan 2024 08:09:45 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 40289jaD016362 for fs@FreeBSD.org; Tue, 2 Jan 2024 08:09:45 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 261538] zfs panic: VERIFY3(l->blk_birth == r->blk_birth) failed Date: Tue, 02 Jan 2024 08:09:45 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 15.0-CURRENT X-Bugzilla-Keywords: crash, needs-qa, patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: pi@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D261538 --- Comment #14 from Kurt Jaeger --- (In reply to Kurt Jaeger from comment #13) Pointer from netchild@: use sysctl vfs.zfs.bclone_enabled=3D0 to avoid block-cloning. Testcase: build shells/bash using poudriere, lead to certain crash before, works now. --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Tue Jan 2 15:43:31 2024 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T4HFJ2dnnz55hBc for ; Tue, 2 Jan 2024 15:43:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T4HFJ1d96z3NCW for ; Tue, 2 Jan 2024 15:43:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704210212; a=rsa-sha256; cv=none; b=pPp+Cau0N2cZwGGYUjUl9j+Cg/IsbVpSUAGeODWhqHNrZJFtB5EK2CukjJI35DX5s7VXw6 ZUkN/r7j5G+CtPX7S4Ax8eWtH+6OaDx9oyPBZsnm/yDq2tDlc8wbE8U3S8dtK1a4SnwoCT vLaXbdEq2seBRGDeWwADtfZ2t17pgSywxpiQp+CnOAefnN9VgHfiyP2TlUaDjXpC2wbzSs BOR77HjqkM8qyRLtYaTBO9RhCDcshtNkkxcQxkyrwJLcsNrRNsocqc2dFw1YIjUbnb4OCm oIcwcLLWxRpjz2yNNypmzBuCLpj2w3U8HtS009T61b2KmlP8bBz/0rMI4XvkAQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704210212; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MWV2DMBENrngiLKeoBt9KdgXT6ufECYcHOSDHeyHD/w=; b=deO19BjNvtwwJKxmdhi1ez6YPLasRjPU4NzJdczcjEX44a5zjafgKAuDcduMdk/E7Gjw/4 G8TMNVNoVJW/Dj21GcjHgILLjEC8HDvYLEgrCIQ4XCPBaG7Q/6XrQabHtV6TbwJaWOrAm9 7Mj7fFLqU/5lDLmcDQuPgjr1yedckb9AlDUJLAWiN+t1nVv/ccdkpp1iFERGYl+LQc3oSD oTfvqJtEvxUL5zZLfKg5wnHZRrFtytzIpks3fH7/X/KAqrJvUmCrieyTLRo7zSYYpGBL8n 4RVhijJj+QhMY8LYWo4XeuLZWHcqdJp/TJTcYT8qhcB90fY3CcaKALsRAiUmrA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4T4HFJ0kBZz15NB for ; Tue, 2 Jan 2024 15:43:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 402FhWVK034278 for ; Tue, 2 Jan 2024 15:43:32 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 402FhWP8034277 for fs@FreeBSD.org; Tue, 2 Jan 2024 15:43:32 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 276002] nfscl: data corruption using both copy_file_range and mmap'd I/O Date: Tue, 02 Jan 2024 15:43:31 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 15.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: geoffrey@dommett.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D276002 --- Comment #48 from geoffrey@dommett.com --- (In reply to Konstantin Belousov from comment #27) As I have said before reading is irrelevant. It occurs when writing to a congested server, and not all writes have finished when the writing process exits.=20=20 It also does not occur using nfsv2 - the process stays in state nfsio unntil writes are finished, but nfsv2 is dog slow and has other problems. --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Tue Jan 2 22:44:36 2024 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T4Sb94XGpz562T2 for ; Tue, 2 Jan 2024 22:44:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T4Sb93Tfvz3N0G for ; Tue, 2 Jan 2024 22:44:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704235477; a=rsa-sha256; cv=none; b=o4bZXgkIL54HFn2ofOXLEtaFZaQ6TVwlQonYHaSxTR5WMqH3mwg9QnnhxihIM0/iRXcWPy 0LpGLESHM6oOvSNHwu6ElL+OYS3WNGt9UNQMzfi/iKl92wmnxjbHEyksPjPAmZdD99PtqN ScnyFQTYiGnCPk6vkT4auxQhtDq8my8fIaiZS/iF3HSRa4dX5YYpg4CSOUY9siIZRxN1ed AkdDg3jy9cNKfcwY3ycjrYK1IyzUdk2IQKrx7Fqf0a/BGOyBazzSCYLqe0cQWrUGRs+xU7 bMN5XgidYCgqRy1ADlMTDXj6nUwp7VEj8oad52JV6j6YS12bEyDP4NV9yFRqXw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704235477; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y3rfZLumFn/CHuOIwVSyAj/pasOnLZNc1zaeBI8nzFk=; b=HlbQLrhs21nfRYqyTtzVvonnW27UxN244HUcXg2Wgv7hzj/lJVMtvW7Z+kkhIuMIndHpx/ jZRYAx0qkOZ3g13q7s5ucG9kZ3jhXNBF64UY5ehLbV/qdKwRCT9JcHy4uQYya06eNvg7Wm EhtNOs1UiFo1QF8hHkLdtiCrlXUVjgFBOlxiAkh/ub93CaW3PQACwTlRncXvGauTt++YXx Jff6IzQyRfA2RRB60iFoOmCQnrjQasYguu1woGUkj7gxlxccK9cid+ELaOZXdV08xmrHkq 6nAghMroZbzX2ztxwfJzWF1bbSAdj9EA9SWeSnL3AYb0/KnQ006MWl3OmSeWNA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4T4Sb92Z25z1K4W for ; Tue, 2 Jan 2024 22:44:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 402MibP3098179 for ; Tue, 2 Jan 2024 22:44:37 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 402Mibow098178 for fs@FreeBSD.org; Tue, 2 Jan 2024 22:44:37 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 261538] zfs panic: VERIFY3(l->blk_birth == r->blk_birth) failed Date: Tue, 02 Jan 2024 22:44:36 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 15.0-CURRENT X-Bugzilla-Keywords: crash, needs-qa, patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: mav@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D261538 Alexander Motin changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mav@FreeBSD.org --- Comment #15 from Alexander Motin --- I was able to reproduce two different panics there, one specific to block cloning, another also happening for dedup. Seems to be an incorrect assertions. This should fix them: https://github.com/openzfs/zfs/pull/15732= . --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Tue Jan 2 22:57:11 2024 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T4Ssh27MMz563h9 for ; Tue, 2 Jan 2024 22:57:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T4Ssh0P0Mz3QKK for ; Tue, 2 Jan 2024 22:57:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704236232; a=rsa-sha256; cv=none; b=cFGN89mq95A+wiKrvm4/sU74YFKyjM8cxJ5oVupQLzrwHrNUYJhEWnVmzPYc3euLiJfb78 ly4Q0HaM6lxf4w1SX5f9kaWjk3sW3c3n7vTUUd7M4q6YAscETYyKukV0iZCg6sw9yXq3JJ KkFXROfKN6ZRM46gF90cD2p8wer54uiWHrtjFlc3kuULMWy/ojOluOKVknWp6/YknEVWFB +tJ4sPJyTJQm2WukDeevmteaMUo6aQkyPl/qn4XkWSsB5iaeBjItCu4jw5BSKz+pyOp9lf C5Qe2UFj7Vzsrxx4/OSyckiMukA/qI9ntAnFYwFBwsxYN6GmpcWhyAq/rcmkSQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704236232; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bf/rWJT59O8kUh7Pmu9cF7WHmhrST+ZhYIOpBHkuHms=; b=fOsT51OCWYS0b6kLQyVyvJjyVfp58b0O6Dinr6CA5n8+F6xkw7yyMewCpLWU9lJdVkUBP5 VMrM1qA9qEDRPaNAv3qRZnNYyTr/Xo6PxveTvTr2gFlVPep/WWUB15wdFSdfWZc5XpP0/U 4mfuhL3RbO+KqbGC0LKu1YmyVcYbII7KebbuDUEDBmo/UIeHtARBx4rEHV81y6mL9sr5wW L8xSO8qFv9jLhuyBSmPz1esbeYFlkBenjz8+OH74/XXQem6ufLXT3FwwFwwtvD8dOJt6qU 2Vxwdyz8yVoE+jl/EPqkkEkgybB/O6HCq0pqz/LncDq/qxA2Dfo03hb3lDS61Q== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4T4Ssg6764z1Jvh for ; Tue, 2 Jan 2024 22:57:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 402MvBZg014145 for ; Tue, 2 Jan 2024 22:57:11 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 402MvBah014144 for fs@FreeBSD.org; Tue, 2 Jan 2024 22:57:11 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 262760] Trying to import certain zpool leads to kernel panic on amd64 Date: Tue, 02 Jan 2024 22:57:11 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: crash X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: mav@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: DUPLICATE X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc resolution bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D262760 Alexander Motin changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mav@FreeBSD.org Resolution|--- |DUPLICATE Status|New |Closed --- Comment #4 from Alexander Motin --- *** This bug has been marked as a duplicate of bug 261538 *** --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Tue Jan 2 22:57:11 2024 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T4Ssh5djHz563kn for ; Tue, 2 Jan 2024 22:57:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T4Ssh3Kv7z3QP6 for ; Tue, 2 Jan 2024 22:57:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704236232; a=rsa-sha256; cv=none; b=N+K8nZhQygpVaUg0AWFyUCn+6q7ZrjPc0ecMA3HAtkT2Alv9xh0DKRCT0yM9r3//WalwRl 9NUEwnd4t0XKKVGOJE+FW5R4WmG3NyO0/u4LxkfWIwo2gy6m+03q7njPt8NQ5SvaxnSlst cmH0DRylNebI97RSEQrtZQIryd3Xd3Gk9sIutYRQha7uid5I4I/ryFzjROHT894k+7hwgZ 9rSXA/A9Q6u6zJD6xVf9Sgxsh4GAUzf5XoTNTQTCJamoVFhiRH8r8SS8VDz0xfw6dBCJo3 IN1iDEowgmosUQ0g8tUXmz4vncRkefJlg9ZKsrF61IJyw1VXp9ZzmMYz73dLeg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704236232; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MxaQsY8E3IpoBQZNud8Z+9Ld2yWhcjYFn/BkCylyYXM=; b=rrKpEDSzOWNwCr7w3ikcpFsNr74JxrUgm+HGrvcDtfAO30Q8aduEKZuGAd1LagrXyxKlEt 9MoDg4ycWwxrjgFB527dG4ClUwsUbkHljnQZpafkNHfbCZ5XPBRbV5y/+ucJFvEocZnyud D5tBNdfzADQiN1J+842p22hWDt3mu1BOYX8Hqn5NRoDXWT/5aZQ9ThoPoFY0jY8AAnivni U0U+vNFytk0uNHJA2UtvyIGTzKpE6OWh7wMg+aDzIIwne95/HCzwCJi8Fr3o8ZCDAT6sC9 FBBpaFT0tS96BxjEBYM38FP5jp11E/s4Ia5jpFs3Q0szbZ/1a6WZ4V3/zD7Bvw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4T4Ssh27pBz1Jqt for ; Tue, 2 Jan 2024 22:57:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 402MvC12014169 for ; Tue, 2 Jan 2024 22:57:12 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 402MvCi3014168 for fs@FreeBSD.org; Tue, 2 Jan 2024 22:57:12 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 261538] zfs panic: VERIFY3(l->blk_birth == r->blk_birth) failed Date: Tue, 02 Jan 2024 22:57:11 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 15.0-CURRENT X-Bugzilla-Keywords: crash, needs-qa, patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: mav@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D261538 Alexander Motin changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |beebeetles@posteo.de --- Comment #16 from Alexander Motin --- *** Bug 262760 has been marked as a duplicate of this bug. *** --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Tue Jan 2 23:14:37 2024 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T4TFp2Q6mz565s3 for ; Tue, 2 Jan 2024 23:14:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T4TFn6kY4z3TJD for ; Tue, 2 Jan 2024 23:14:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704237277; a=rsa-sha256; cv=none; b=Mp8Tu5TCpx92i4Aq27eGYFi/4+e5GXirlOMySdNeGs8lqVwfkSPH4FS6iEZKBPfwsLBHoE yODm0WMFlYDERmIeUquZxqvGnd0EXrAt8MVNNf5x3T4JO65jbEKblydfRSOkfi9bHwe3Gu T+yWaCpMu8z1jEq4Di5fgch61U5yFlIkLUwKu//+pCQKy/JN1fi2bP1uaFEx9Dm6W1PqEn eMhnFgQ8Spei0KBQbYWMMGpVBmr7nSCMVHnRBAFWJqRxE7dS+ye83vrV+dJkasaDHxxeac dGkSo+MX1GERilfT9KbxEGsP578Xq+c84uY/4LjMnyzDqc1b6Xxja1VFako6/A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704237277; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lD0z+WFTIC13OBB7Q3hTaEZssDxeNYYLU5G2XOMMztI=; b=knMAuPYVXBVQyvspMdAOVWb0IU4dgm3tV9nJMiD7Xnj+tOqEKETWLwksC/uDjiSOmg2I6o 6+GYemOteYWLY20RvRhRmhr4Z4qFv8WvQaPBUgltCTie/8XZ1KlrxRL0jS3X2jC7O1vnVo uo7Y1bNqDY5BeWZVHKdZHObCsXkZvcNb8tRbtwBJAsZI4DQgQsPJeXyUwIdXnn07YFjbo7 BvdTFf80yXTOnn+ExG4Fw/AZ0lJUrkdppnqQtGPDcnX2Nu/uc0R6h2cZRf/7diDNcQ0lY8 pzUSp397UUebtCriKErryxysFjNZjiJle5mIZWSdhGGRsmniZ5r6Jw1egKWt8Q== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4T4TFn3nXbz1Jws for ; Tue, 2 Jan 2024 23:14:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 402NEbDi040649 for ; Tue, 2 Jan 2024 23:14:37 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 402NEbjD040648 for fs@FreeBSD.org; Tue, 2 Jan 2024 23:14:37 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 276050] pijul clone on ZFS (Error: No error: 0 (os error 0)) Date: Tue, 02 Jan 2024 23:14:37 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 14.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: linimon@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: assigned_to Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D276050 Mark Linimon changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|linimon@FreeBSD.org |fs@FreeBSD.org --- Comment #4 from Mark Linimon --- ^Triage: note feedback received. --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Tue Jan 2 23:48:34 2024 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T4V0y477Rz568k6 for ; Tue, 2 Jan 2024 23:48:34 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T4V0y15TZz3XMg for ; Tue, 2 Jan 2024 23:48:34 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704239314; a=rsa-sha256; cv=none; b=IUPOATNBL8jAboFtm58D8uFs7wYMKRjJTtmvbnGYCZwRCXd+1FcCwCErs4Ux2/sB3vMk+N pdR6PF8mBy7yyGBessJ6oAW1GMBi6OWB37d5ez5vAiGv4JLQL5u2C9p01oG2cYG1aDHWae mM2YLeQq0tUqpX/drfukWwSLguzeFB1pkzAgQBWChNmMl563u3ralJujR2fb/lq11PUSxv 8V4MLRPhVn2c7dhh00ih4xkmAF5OKtDUTMwuf0M5joVuffOKsHD0lQIW/Cfd8ljsy5df1g kHKJeuiAqx4EOpohsjTfuKoz1TJLvkGnA2wSYJ+BqrFSCQAT2MoWT6tC9twIfw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704239314; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9Npl4rOTS1GQeOQkO48W2Dq6uRqa3Dkb8bUib3WfekU=; b=AzLfbI2VlczK3UeCnvUXOlu8OXclRjQggBlf3pm9+GWZc7AtMHsi1NNZe1kYE+oC+F7gSQ ACNffdNASsa2EOZFPT2hVPfbTg2A5NdLjE5/7mwsM0o3R1UjtJD8oYEAQAch5iNJOqQorN 6L9uOZZ93u7EaT6PWtlHEZqamQvqI2Dg30VxW/DMXv3aHWkV8i1SYczR5YplODkE3a9Qqy 93RM9r4So0m7SDGF7RJ2uaKZf9hlVMmUgfh10R64vHDYyk+3e0cGUI/PuGI81ZNXB0TQm3 vuvmiseQPViLD8lKRRFmrZIuANHUUZmYUEt7uqfXJb0cfl98vi82Zsxovw3mNQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4T4V0y03Zlz1LBv for ; Tue, 2 Jan 2024 23:48:34 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 402NmXut086237 for ; Tue, 2 Jan 2024 23:48:33 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 402NmX8R086236 for fs@FreeBSD.org; Tue, 2 Jan 2024 23:48:33 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 276002] nfscl: data corruption using both copy_file_range and mmap'd I/O Date: Tue, 02 Jan 2024 23:48:34 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 15.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: rmacklem@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D276002 --- Comment #49 from Rick Macklem --- Created attachment 247424 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D247424&action= =3Dedit Make Setattr invalidate for setting size if mmap'd writing might have occur= red This is another patch that Alan can hopefully test, since his test does include truncation. The patch adds a check for vm_obect_mightbedirty() as well as NMODIFIED (which is set for writes into the buffer cache, but not writes to mmap'd pages) to decide that flushing/invalidation should occur when a Setattr of size is done. --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Fri Jan 5 05:01:27 2024 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T5rs3731Rz56HZv for ; Fri, 5 Jan 2024 05:01:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T5rs33g96z4YDd for ; Fri, 5 Jan 2024 05:01:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704430887; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OGg2RG7bBkTUVY46byA5UkpYJOTiTse0pOaRYJPCKfg=; b=dU/6Vnni6Xeoc9SgbX00+gED80Ww+qyzF6y9AkhulG/WH6h6Ja+RpxdeKX/yj+XGG2nbum Api5dKvAmHvCnJKff1sBot7TsqihUtS5WYnk/GnVN4iGBJmExg8K9ULRSeOKEywT5i5PVa OBTJcQSe/QUcED3Xiuiimnanj2F5zDqplzfNtj12WC409EuMNMiPSNT4m8whA70cumcQlZ AyCR9GFy/1qi4O9jABUVGKgoAPk9jZmitCzXa0oAHM7IDPw3oborv66nuxUF2zgbcURYIw l+hriANOOiej65whmPrGKmG3eKKZFyAtyyh2QYBndnGyAHiHtII5iOvSxYZbTQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704430887; a=rsa-sha256; cv=none; b=mAAD9YaH5DnhWLGbxbjYn2+UYo3E3nYmu9jF9qtPaxjZ73a0taSdd5qMKxJlsr1RegMMlQ DDN6B6qD2xHYOQR8VbKdpFuMcVdcKhpJWWW06Ivrl4wq1TCN9NtAZ/GIS0f8/LavS5p8pP w/7zjtihoL5M+DHnDXZP5X+xh032DC/xRYGXbLxFVcGv7puquUdploYJ8Wps6opHlHSL5y 9/oIvwnKEI0LwyLD+wrAKTtmwDiIash0aiKGCiGeul5hZJCgeBrfuPfQ9PS5H96ThgYMsg 6w4xnc6lT4M11TnDxyKQdsldMD5JF1T1UZLvW1/F7bu5STM68ntw4zuSXLen5A== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4T5rs32cvGzkZt for ; Fri, 5 Jan 2024 05:01:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 40551RNj049135 for ; Fri, 5 Jan 2024 05:01:27 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 40551RqJ049095 for fs@FreeBSD.org; Fri, 5 Jan 2024 05:01:27 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 276002] nfscl: data corruption using both copy_file_range and mmap'd I/O Date: Fri, 05 Jan 2024 05:01:27 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 15.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D276002 --- Comment #50 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D47ec00d9d6071bbb0ee5ed0bdca3c4a46= 8334d9d commit 47ec00d9d6071bbb0ee5ed0bdca3c4a468334d9d Author: Konstantin Belousov AuthorDate: 2023-12-30 00:15:50 +0000 Commit: Konstantin Belousov CommitDate: 2024-01-05 04:56:30 +0000 nfsclient: flush dirty pages of the vnode before ncl_flush() when done to ensure that the server sees our cached data, because it potentially changes the server response. This is relevant for copy_file_range(), seek(), and allocate(). Convert LK_SHARED invp lock into LK_EXCLUSIVE if needed to properly call vm_object_page_clean(). Reported by: asomers PR: 276002 Noted and reviewed by: rmacklem Tested by: pho Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D43250 sys/fs/nfsclient/nfs_clvnops.c | 45 ++++++++++++++++++++++++++++++++++++--= ---- 1 file changed, 39 insertions(+), 6 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Fri Jan 5 05:01:29 2024 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T5rs63Dmsz56HtX for ; Fri, 5 Jan 2024 05:01:30 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T5rs60k2Qz4YKm for ; Fri, 5 Jan 2024 05:01:30 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704430890; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9gSQsaX5gy+LCqAlFj2Wi5EU9nHlmj6QdkC9XY+eoG4=; b=SUD/tBLQ6bvZUaaJOyROhzxSk6RVsCgn+O0MIzZWsyreezwqFOItJoNmhNbzzH5PUQCefp jz/bc3tHeuMmH0wqiBIx5p9I/JJf/n0ryTLCq+O/+0qId0iCh+HbJwvFZ+l8Az7/Di2IUB /fu6dD2mHpt89XY1pZg3/8lDtdH/e5cqTaCHe7P4n4f1KT5qYjYUZW7yosVL8RS5J+2akp 2Ypdypv8Ay/9AICj0PLMRjowkLQZcbWG7EsznHlQVNZ6JQzkytroc1aewru17NbLKHGOdF OCQPeFN+3owM3m93sm6b3w5cY2KR9peGkZYIt37WNmE+2pIdebdeRjBMz0+ukA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704430890; a=rsa-sha256; cv=none; b=B42K+3u0mAf20oi23XNr09k18rF2EJvYgj+Nl6v4onFiXepNdoQev+QjumKZccECnSFiTC vLyGGBQ9c8/n2FzoYp/mu36qGWvKsnHQPsC4HPEtKk2k8lYroApEDPBB3Q4/t/F1xv7/pW kzZ+En6076nr7a6CVAE53OEpm1ZRftksbzFoNq8jZeUxk3UF4CigVz9AI9nmJmWzmtIVDA bt4cIAyge3cas1PyQEjPlHHl3Ny1FzWXBFN8Re9llkYiqKPb+p/LNJnrJdgqJ0074H9FGZ RRv4WHVu2BBMPUahRbxY/kUoPYMYFbYyJuAXVxWnJ9dhg0PEIV2Waqq4VlesWA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4T5rs56xYJzk4Q for ; Fri, 5 Jan 2024 05:01:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 40551TfH049332 for ; Fri, 5 Jan 2024 05:01:29 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 40551TBd049331 for fs@FreeBSD.org; Fri, 5 Jan 2024 05:01:29 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 276002] nfscl: data corruption using both copy_file_range and mmap'd I/O Date: Fri, 05 Jan 2024 05:01:29 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 15.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D276002 --- Comment #51 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D7dae1467d72ae1f5c8f7be0f7444da23a= 457d98b commit 7dae1467d72ae1f5c8f7be0f7444da23a457d98b Author: Konstantin Belousov AuthorDate: 2023-12-29 23:22:40 +0000 Commit: Konstantin Belousov CommitDate: 2024-01-05 04:56:17 +0000 nfsclient copy_file_range(): flush dst vnode data Otherwise server-side copy makes the client cache inconsistent with the server data. Reported by: asomers PR: 276002 Reviewed by: rmacklem Tested by: pho Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D43250 sys/fs/nfsclient/nfs_clvnops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Fri Jan 5 17:21:40 2024 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T69H90qMwz55N9G for ; Fri, 5 Jan 2024 17:21:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T69H86lLdz54RG for ; Fri, 5 Jan 2024 17:21:40 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704475300; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l3/SHthmWiq2enc8goo1WTh1XMqQogAK9pe45/gB9BE=; b=saHIK+5FmXbEqacP/y9m2ReSlH4b/OW+ZP8DOx9v1V0HwAeNsxve61c4Lrbcus7QNv2YJX TSeD5AIabhsktCCcciE+ilju16VK7mWE/2vO0n+WyFQVP57aF5eGoOxOVX6sGpgTqt8vyt TvS85VAWX9QkQAWx79Kp2SDENXj7wDQqbRhty7FHNjpQwm1YiWwpO1EFPieWxXcIhb80kZ gVbAtWja0kni5imyafefGVRmyccA6VwLAKiWWaaQh4GawThB7FMKcs8takAhqQWX12JJf7 pdldidvY8FSUosJEDcY6JMpD4crSHaZzlxpM9tXIiqSTK0wAf4NwRFPdDETSvQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704475300; a=rsa-sha256; cv=none; b=EOqfb/rqEAeoUJA9P9NL/Z3yw6s/GRVchgaK/tXNNI8OkyqiOJXyNiEEWIZxZRnD+o9j0L qBtW8ciZrOQqgPWri00ec+YXrNpA7FecU5tUB/1o01fXInzc5XC1JrpPLE0Qa2krZI/Mpi XRaXK4DQstUil4OhkhTdRjCUJAqfGZhdcNSBrHMDJfzfw6Z4yuqMR/wBI3auETqT5MJSwo fn0q/wBqdZl0gkgF/RxhlSzxBxnzWiXD1kcJ7dxJRrZScRq+hZc1NcNcEZz9eny4GR9zK3 EOso1OKFXGgXA143YKfisttxFp69q7c+925J4TiE/xezfmmJBcm8rvlaK87fLg== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4T69H85rG8z169S for ; Fri, 5 Jan 2024 17:21:40 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 405HLeJM070240 for ; Fri, 5 Jan 2024 17:21:40 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 405HLehw070239 for fs@FreeBSD.org; Fri, 5 Jan 2024 17:21:40 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 275594] High CPU usage by arc_prune; analysis and fix Date: Fri, 05 Jan 2024 17:21:40 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 14.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: seigo.tanimura@gmail.com X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D275594 --- Comment #20 from Seigo Tanimura --- Created attachment 247465 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D247465&action= =3Dedit The result charts for Comment 22. (1 / 2) --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Fri Jan 5 17:22:05 2024 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T69Hf0lWdz55NRC for ; Fri, 5 Jan 2024 17:22:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T69Hd6fwLz54fD for ; Fri, 5 Jan 2024 17:22:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704475325; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9cYI729ScFxraD3mRdwceWndCw/dGz7wmKsP6i7m77U=; b=iIdEqqAzNHp1FMGzvOa2UfvVftaoPuqmaLaTJJEK7BHqZzFR3I5na0DH4/9lhVBUaNtPwM zR1W6wLqSyF5lOwXsseL/jj3SXUWuDBttM6LNqbAoO9XHP8xnZnXm6RgEYegwfh0BsUCx/ cY9Sim3ObaTwdlyoMjI/5ceaikPyN7PN8NRqXDElWg7GEURAOMR806tEUOWspve1TitSrA n7RIdIl+JB/UNBGB7scfkUEBveGzFDTAa/aYBcKD/DwUMwgU8KR7DBTg2Se+XchP4j3TD3 wy5HkZySJTH+8sJU0XWkFLFSOa0QU3mfgCZa1J72oSj8ZnreNrNIGlqxCauplg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704475325; a=rsa-sha256; cv=none; b=ixQ/QrjtWl409gJhJz11y3BV9psQyigOE432VNUJvx9dFFbSemYENpAY5G5Id2OE7863dS fnRImMA2x/JVz1KYkcl+WYmGSphEjw2uSlVkpLYca38i/zSf42ucc9AcW1Iol8z/ZGi4nk hdymnkTw+nrDNdBonGrmHBUzGehEKSIdufOhPyG01GcsSCAkUGzOM/E6rPaIeUL0V5Nmag o8lRUR4t8fKoK0slO9miItnkPICcqBGALsc2GtJmh2HhxyjJrWlj1ZHk4JWF5omFJ0C/K8 rSOd6tZ2aokJxgjkQPhHpxdIlwdMVYRl9CRObn8zG4KkbC7OkhppoIx1BiBYeQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4T69Hd5mVCz169Z for ; Fri, 5 Jan 2024 17:22:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 405HM5tf070555 for ; Fri, 5 Jan 2024 17:22:05 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 405HM5vr070553 for fs@FreeBSD.org; Fri, 5 Jan 2024 17:22:05 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 275594] High CPU usage by arc_prune; analysis and fix Date: Fri, 05 Jan 2024 17:22:05 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 14.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: seigo.tanimura@gmail.com X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D275594 --- Comment #21 from Seigo Tanimura --- Created attachment 247466 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D247466&action= =3Dedit The result charts for Comment 22. (2 / 2) --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Fri Jan 5 17:27:20 2024 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T69Pj1Qvsz55NcR for ; Fri, 5 Jan 2024 17:27:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T69Pj0KTKz55s1 for ; Fri, 5 Jan 2024 17:27:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704475641; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zew4NvKPVvygoUf0wkzjXi5MUbH44ZQNJUX0dKS+lF4=; b=rM+uNlq7DoHMQZITX44gqwSYrSuuqunBQ5JMm0CYzkrQKNlEqR7T8paqwbXuUMV2ADtCws 9OXr5AI3XFh4YhK3TcdxgmvUi6+3ymbw4nYO+GNoYupKW/c4xkBHzgA1jqNVHvD0yDM5+j mh4KmBtPFvGgaEG6I7SunoKjNm/L0m4bHK8d8iXTDenH76kUNLYhXzo0neBGUZ4dgMAN/n LvrdKh6775riWhZmD5H7NTtPQWVqJ5o9KA/bv36QYs6e/TM9SsDRC04zkr8W9ZaZKgUaSC PUInnVM5glfWMr4Atd/kDrr9NVDjRkU4EfnYpLY7gWjq2g1KJSFnyuHNT16w1Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704475641; a=rsa-sha256; cv=none; b=LZEh4yBi8mPhV5964L0hMXYOIy0i8MSf70ZnTdRYOlFQBZgMBPdeDA0PpecAU+A5f5XH+P LiPKPJoyZwBPpiLDXl2E17TXXS3GmdzOULu2+x3r1ToMuMkxSj9NN8xSZrkcDLSa1kJ4+r OOksbFPDkQAqc8oIkeOhHIRlykMRLIolHev7Z7Qy6L7W7akCKgxahGCbxEUB6Kx2qg6iQw dQGB+B6XJCkBIXpK3P0UUn6B6R96wEB2PTps2das4cneAQbHOEIHsm9NM7hmb5Mfn6i7fK BCCwT3tFZhT9GkAwcl0+IILdMDzGjXQHEgaFxGoleiaYZ/HZDdFm04VTzLlH6w== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4T69Ph6PKhz167S for ; Fri, 5 Jan 2024 17:27:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 405HRKtF076253 for ; Fri, 5 Jan 2024 17:27:20 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 405HRKwc076252 for fs@FreeBSD.org; Fri, 5 Jan 2024 17:27:20 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 275594] High CPU usage by arc_prune; analysis and fix Date: Fri, 05 Jan 2024 17:27:20 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 14.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: seigo.tanimura@gmail.com X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D275594 --- Comment #22 from Seigo Tanimura --- (In reply to Seigo Tanimura from comment #18) > It may be good to account the number of the ZFS vnodes not in use. Befor= e starting an ARC pruning, we can check that count and defer pruning if tha= t is too low. > (snip) > Figure out the requirement and design of the accounting above. Done. * Sources on GitHub: - Repo - https://github.com/altimeter-130ft/freebsd-freebsd-src - Branches - Fix only - release/14.0.0/release-14_0_0-p2-topic-openzfs-arc_prune-interval-fix - Fix and counters - release/14.0.0/release-14_0_0-p2-topic-openzfs-arc_prune-interval-counters * New ZFS vnode / znode counters for ARC pruning - Total ZFS vnodes - sysctl(3): vfs.zfs.znode.count - Counter variable: zfs_znode_count - ZFS vnodes in use (v_usecount > 0) - sysctl(3): vfs.zfs.znode.inuse - Counter variable: zfs_znode_inuse_count - ARC-prunable ZFS vnodes - sysctl(3): vfs.zfs.znode.prunable - Formula: zfs_znode_count - zfs_znode_inuse_count - ARC pruning requests - sysctl(3): vfs.zfs.znode.pruning_requested - Counter variable: zfs_znode_pruning_requested - Skipped ARC pruning requests - sysctl(3): vfs.zfs.znode.pruning_skipped - Counter variable: zfs_znode_pruning_skipped * Design of counter operations - Total ZFS vnodes (zfs_znode_count) - Increment upon creating a new ZFS vnode. - zfs_znode_alloc() - Decrement upon reclaiming a ZFS vnode. - zfs_freebsd_reclaim() - ZFS vnodes in use ("v_usecount > 0") - Export to the VFS via mnt_fsvninusep of struct mount. - Both the VFS and ZFS have to operate on the counter. - struct vnode cannot be expanded anymore. - Increment upon inserting a new ZFS vnode into a ZFS mountpoint. - zfs_mknode() - zfs_zget() - Increment upon vget() and alike. - vget_finish_ref() - Decrement upon vput() and alike. - vput_final() * Design of ARC pruning regulation - Required condition - zfs_prune_task(uint64_t nr_to_scan, void *arg __unused) - Condition: (zfs_znode_count - zfs_znode_inuse_count) * dn / zfs_znode_inuse_count >=3D nr_to_scan - dn: The number of the dnodes. - Scale the prunable znodes to the dnodes linearly because a znode may span across multiple dnodes. - Call vnlru_free_vfsops() only when the condition above satisfies. - Other changes on ARC pruning - Refactor the extra vnode recycling into 2 togglable features. - sysctl(3): vfs.vnode.vnlru.recycle_bufs_pages - Recycle the vnodes with the clean buffers and clean/dirty VM pages. - sysctl(3): vfs.vnode.vnlru.recycle_nc_src - Recycle the vnodes working as the namecache sources. - Both enabled by default. - Retire the interval between the ARC pruning, the initial fix. - The ARC pruning regulation above is more precise. * Test results Test Summary: - Date: 03 Jan 2024 01:30Z - 03 Dec 2023 08:13Z - Build time: 06:43:25 (317 pkgs / hr) - Failed port(s): 1 - Setup - sysctl(3) - vfs.vnode.vnlru.max_free_per_call: 4000000 - =3D=3D vfs.vnode.param.limit. - vfs.zfs.arc_max: 4294967296 - 4GB. - vfs.zfs.arc.dnode_limit=3D8080000000 - 2.5 * (vfs.vnode.param.limit) * sizeof(dnode_t) - 2.5: experimental average dnodes per znode (2.0) + margin (0.5) - poudriere-bulk(8) - USE_TMPFS=3D"wrkdir data localbase" Result Chart Archive (1 / 2): (poudriere-bulk-2024-01-03_10h30m00s.7z) - zfs-znodes-and-dnodes.png - The counts of the ZFS znodes and dnodes. - zfs-dnodes-and-freeing-activity.png - The freeing activity of the ZFS znodes and dnodes. - vnode-free-calls.png - The calls to the ZFS vnode freeing functions. Result Chart Archive (2 / 2): (poudriere-bulk-2024-01-03_10h30m00s-zfs-arc.= 7z) - zfs-arc/zfs-arc-meta.png - The balancing of the ZFS ARC metadata and data. - zfs-arc/zfs-arc-(A)-(B)-(C).png - The ZFS ARC stats. (A): MRU (mru) or MFU. (mfu) (B): Metadata (metadata) or data (data); the "ghost-" prefix denotes the evicted cache. (C): Size (size) or hits (hits); the hits count the hit sizes, not the = hit counts. Finding Summary: - The ZFS ARC meta was lowered strongly, contradicting the high metadata de= mand in the ZFS ARC. - They are both the designed behaviours. - The low ZFS ARC meta value triggered the aggressive ARC pruning. - Again, this is as designed. - The ARC pruning regulation throttled the load as expected. - Virtually no load happened when only one or two builders were running. - The fruitless pruning was eliminated. Analysis in Detail: - ZFS znode and dnode counts (zfs-znodes-and-dnodes.png) The green and blue traces show the counts of the total and in-use ZFS znode= s, respectively. The gap between these lines denote the prunable ZFS znodes, = also shown as the red trace. Those traces show that there are almost no prunable znodes, so it is useless to perform the ARC pruning too often. - ZFS znode and dnode freeing activity (zfs-dnodes-and-freeing-activity.png) The red trace is the count of the znodes freed by the ARC pruning. It work= ed in the first hour because the build happened upon many small ports, where t= he builder cleaning released many znodes. After that, the build moved to the = big long ones (lang/rust, lang/gcc12, ...) and the znode release ceased. A cou= ple of the occational bumps happened upon the builder cleanups after finishing = the build of such the ports. - Vnode free calls (vnode-free-calls.png) The non-zero traces are vfs.zfs.znode.pruning_requested and vfs.zfs.znode.pruning_skipped, almost completely overlapped. After 02:45Z, there were no counts on vfs.vnode.free.* shown by the median. This means t= he ARC pruning was either not performed at all or merely exceptionally. The magnitude of vfs.zfs.znode.pruning_requested shows the high pressure of= the ARC pruning from ZFS. The top peak at 02:20Z is ~1.8M / 5 mins =3D=3D 6K /= sec.=20 The ARC pruning request definitely needs a solid throttling because a typic= al ARC pruning work takes up to ~0.2 seconds when there are actually no prunab= le vnodes. [1] Even under a steady light load in 06:25Z - 08;05Z (working on emulators/mame, where ccache does not work somehow), vfs.zfs.znode.pruning_requested recorded ~50K / 5 mins =3D~ 167 / sec. [1] Observed under my first fix where the interval of 1 second was enforced between each ARC pruning. The max ARC pruning rate was ~0.8 / sec. - The ZFS ARC stats (zfs-arc/zfs-arc-*.png) The ZFS ARC stats show how the high pressure upon the ARC pruning happened. The ZFS ARC stats of the sizes (zfs-arc/zfs-arc-*-size.png) show the follow= ing properties: - Except for the first hour, there were almost no evictable sizes. - The metadata stayed solidly while the data was driven away. - The trace of the ZFS ARC MRU metadata size (zfs-arc-mru-metadata-size.p= ng) is similar to that of the znode and dnode counts. Out of these properties, I suspect that the znodes and dnodes in use domina= ted the ARC. Although not confirmed by the code walk, it makes a sense to secu= re such the metadata in the memory because they are likely to be updated often. Another parameter affecting the ZFS ARC is the balancing of the metadata and data. The ZFS ARC meta (zfs-arc-meta.png) is the auto-tuned target ratio of the metadata size in the 32 bit fixed point decimal. Since vfs.zfs.arc_max= is 4GB in my setup, this value can be straightly read as the metadata size tar= get in bytes. The ZFS ARC meta is tuned by the ghost-hit sizes. (zfs-arc-*-ghost-*-hits.p= ng)=20 It is designed to favour either the metadata or data with the more ghost-hit sizes, so that the further caching lessens that. As the data was dominant = so much in the ghost-hit sizes, the ZFS ARC meta was pushed so low; the minimum was ~197M at 05:20Z, and mostly less than 1G, the default (1/4 of vfs.zfs.arc_max), except for the first hour. The low target of the metadata size then caused the aggressive ARC pruning as implemented in arc_evict(), = in conjunction with the high demand of the unevictable metadata. --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Fri Jan 5 17:28:55 2024 X-Original-To: freebsd-fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T69Rc6tZ6z55NxV; Fri, 5 Jan 2024 17:29:00 +0000 (UTC) (envelope-from lev@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T69Rc6Jqjz56Jg; Fri, 5 Jan 2024 17:29:00 +0000 (UTC) (envelope-from lev@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704475740; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=9flr6SSfYF155xUHIMgvwpRLAu/oCTD80kkHszSIMkc=; b=h2Gm9janLRzJPwjOrlkEuARFDT1ogG7HG6C6YzlxYzrX0X8CAJa3Ksx9Ew8EhXmsugg/mi kBnBloPZMjuFI5WxeGTxWydBam4oAyGhgaHueJBzzMVFVLqT+9YTEm7yGwoUzZdW8jzwa9 5kaVu8D3jL1+rpvQmhT8VidBOl7EvwUwad32uEeYu2WBUst3XoXIJGBbIXJ9tQAZdFSx34 Y6gkEGK0he7d0o/Vsmjpk+fgWJPpWAms29sFCUEKGizXZckvFuOHeMizh2ncr5RE7C3v6e dQKEJC8YQgI/LVwdiSYFc01cRuaT7wqJKDYJmIS7l/IGxBC0hDYAYimsTcrSNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704475740; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=9flr6SSfYF155xUHIMgvwpRLAu/oCTD80kkHszSIMkc=; b=KbYU3d/Up4oiZMGymCAmitdGBecwsePuKlokgVJR9XD7F0mS8Qu5IyXMqRwDW2OuXgw4mQ +LMm4iSqRcO9clJSkW81f8lIbTFJayMXgFtFUbINyvIMw4/KFvZgnf+WWRFPsoGBxwXnqG 06jEHoZ46Bd0pAQa0fuFdB8CnaM+prUjpQbKLQp6hHEbmVThW7yXxmlU2nrLRfBeaB+XEM 07SgTlf9x2wambSJYnVt7aflQ+T3s/hX3/oiOoQTALo4mw/oJdgwHZO62cxx6/lgosGYy3 5leNeLj4lGJ9wXHQMlrKSiO1GFeTg4EreOm5orQGMzPYHQdhw7unyHypzNffBw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704475740; a=rsa-sha256; cv=none; b=dOvTpHrvAuB/fJgphZgQK7wEEzCMvViAOYTp4Iuo+6sG+cBC9K60IOmoOkZEDII+dVwM19 ayfs8hrDS+/LXz32mQBnEuZKn98UjkwCvrhN/e6uEFy8FsESTJ4HrxcdBHvi+fs8qwr7gD MxRk8XgYnK/cnWmgWLtnZnnX79BnuSK05xf9L8lOMqfKzC6cSql45oOx5J4Z7eLEBbw5Jr Qs6NLIvpjaVnGEr/qOAqHy3kYpNXuby5hOGH7cVDFSP7dKh/aZQOlhkCQXtzhCzCZNsYe4 Qco0tojjjp8UZWZkrb446gAigYtXbi1qA4pNADAKXG4W4sXc5+495sbWo9OWTw== Received: from onlyone.not-for.work (onlyone.not-for.work [IPv6:2a01:4f8:201:6350::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: lev/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4T69Rc4bYtzYZ7; Fri, 5 Jan 2024 17:29:00 +0000 (UTC) (envelope-from lev@FreeBSD.org) Received: from [IPV6:2001:470:923f:1:8c5d:e3a1:bb4c:7024] (unknown [IPv6:2001:470:923f:1:8c5d:e3a1:bb4c:7024]) (Authenticated sender: lev@serebryakov.spb.ru) by onlyone.not-for.work (Postfix) with ESMTPSA id 4287E15; Fri, 5 Jan 2024 20:28:56 +0300 (MSK) Message-ID: Date: Fri, 5 Jan 2024 18:28:55 +0100 List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: freebsd-fs , freebsd-stable , Alexander Motin Content-Language: en-US From: Lev Serebryakov Reply-To: lev@FreeBSD.org Subject: FreeBSD 13.2-STABLE can not boot from damaged mirror AND pool stuck in "resilver" state even without new devices. Organization: FreeBSD Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hello! I have (remote) physical server with 2 SATA disks. These disks were partitioned with GPT into "freebsd-boot" (ada{0|1}p1, legacy one, not EFI), "freebsd-swap" (ada{0|1}p2) and "freebsd-zfs" (ada{0|1}p3). Both disks were 512/512 (it looks important). I have only one ZFS pool "zroot", mirror of "ada0p3" and "ada1p3". I have very fresh "gptzfsboot" on both "ada0p1" and "ada1p1". Now, ada0 failed. It was replaced by DC support with new disk, which is 512/4096. After that my server fails to boot, gtpzfsboot from second disk (ada1) reports several "zio_read error: 5" and ZFS: i/o error - all block copies unavailable ZFS: can't read MOS of pool zroot after that. I've booted to rescue Linux (unfortunately, there is NO rescue FreeBSD at Hetzner anymore), and Linux could import (degraded) pool no problem. But Linux has problems with detecting pool on partition, so I don't do nothing under Linux. I've checked "live" disk under Linux, though: it reads, SMART is clear, everything is Ok. I've booted FreeBSD 13.2 from installation ISO under qemu with physical devices as disks. Then I partitioned fresh HDD and started disk replacement in mirror. It worked, but resilver was unbearable slow. I stopped VM with FreeBSD to continue process after normal boot. NO LUCK. "zio_read error: 5", boot failed. Then I've overwrite ada0 (new disk) with FreeBSD memstick IMG and boot it - it can import pool from ada1p3 but, of course, resilver is stopped. I've removed all faulted components, effectivly converting mirror to "simple" device. But "zpool status" shows that there is resilver! And "gptzfsboot" still CAN NOT read this ZFS pool and find loader! Ok, I've converted swap to UFS boot form UFS. It works. It can use pool as root. But pool still is "reslivering". Now I have very strange situation: (1) I have ZFS pool with 1 device which says: % zpool status -v zroot pool: zroot state: ONLINE status: One or more devices is currently being resilvered. The pool will continue to function, possibly in a degraded state. action: Wait for the resilver to complete. scan: resilver in progress since Fri Jan 5 19:24:07 2024 750G scanned at 472B/s, 40.5G issued at 25B/s, 974G total 0B resilvered, 4.16% done, no estimated completion time config: NAME STATE READ WRITE CKSUM zroot ONLINE 0 0 0 ada1p3 ONLINE 0 0 0 errors: No known data errors % (2) gtpzfsboot from very this system version can not read this pool and bot from it (3) kernel can use this pool as source of root (and all other) filesystems. -- // Lev Serebryakov From nobody Fri Jan 5 17:29:36 2024 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T69SJ4xC5z55PGB for ; Fri, 5 Jan 2024 17:29:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T69SJ34Tdz57gM for ; Fri, 5 Jan 2024 17:29:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704475776; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Kj+GBa8gMCzXx6TybIRLceFga4o8upwDgCLLIiRPZKw=; b=q3VWX5Fq4eJmI5bbegenrv7J1jnHUFNMARNAfLDKAF3rJyV3SKsF/B7SZ0Ch3JTb2V2v4H iLW12uhRLAVKG1pD7dGI7CXkzYLoK4BjKkfGiNYkXBmUecjYIW3jOZyYrmqyIx8ZvtWGga G8tdqCgi5CZ/J+2ucIE5rP0hKfMQApeIDA/RKDJMrofXnTKAtfDYxOG1lovIe9esvTmkdG CA01Re5hgHcYK7LoxEDw8Y+oBI8ygsLWXt4AY7gggtoHicl7j8/5KPDnankB2BrVr2K0C9 b5k5YEG/mC8lLlFO02pfFqiXzGM2cLS+f0GAv+YC4NwiXHWmoL9HeYcaFvaTFg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704475776; a=rsa-sha256; cv=none; b=ul+bQ9zkLJM4MklM6J6yQROUH4davznHV0Y078Ck566AeLAdXSSgSp74oMvP57Gc1ocSqE JBuREdJSv0iEbT1WswoN5QzuBm89ARn9sSIAKIU9tzJuVzKsUvxAvFn6UGKGxPmZramF40 /ouUQyDeakZ/iBiizuTQ8FuWV5pUMpQXZ0qEIcO/Tf0Y0C7NnuTDDOMnP5vH3wHwfJZIgH F1oc03hIN7CYbWmm+TASj270R+939eGd+rT1Yt/+ep+PnpOf5FSFmekF3uAaJHcjidkK4E QfpcFFv3VPEYbTyIhU8VuyksjxJmkI8oa4lu2drkfEoNJLEwxKymuVgXdN4HYw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4T69SJ28bjz167T for ; Fri, 5 Jan 2024 17:29:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 405HTaKp077072 for ; Fri, 5 Jan 2024 17:29:36 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 405HTawq077071 for fs@FreeBSD.org; Fri, 5 Jan 2024 17:29:36 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 275594] High CPU usage by arc_prune; analysis and fix Date: Fri, 05 Jan 2024 17:29:36 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 14.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: seigo.tanimura@gmail.com X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D275594 --- Comment #23 from Seigo Tanimura --- (In reply to Mark Johnston from comment #1) > > - vfs.vnode.vnlru.max_free_per_call=3D100000 > This value is 10 times larger than the default. Why did you change this = parameter? What happens if you leave it at the default value? Out of the tests so far, I now believe that the default value of vfs.vnode.vnlru.max_free_per_call (10K) was chosen in order to polish the l= oad under the uncontrollable and unreasonable ARC pruning requests. Now that the ARC pruning is precisely throttled for the efficient execution= , it should be all right to increase vfs.vnode.vnlru.max_free_per_call up to vfs.vnode.param.limit and let ZFS determine the actual work load.=20 vnode_list_mtx is an expensive lock, so once we acquire it, we should prune= as many vnodes as we can. --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Sat Jan 6 07:10:52 2024 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T6Wgx55LZz55fHf for ; Sat, 6 Jan 2024 07:10:53 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T6Wgx31LMz4ZTZ for ; Sat, 6 Jan 2024 07:10:53 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704525053; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=X8hfZIJ7/PXKte9Qta3TRaB+VjWwHh91uzxUA4GJy2Q=; b=XjXJzU6daSsCLeDTbHv+01hbA5yMg86hzZ1cMV8fQzvGUN5IyR0jZHfzgZ/E/XMtYI+3tL IAtLkOG3kQzWRnusGFXE66wQxCQ6uVeVH0O630BzigXH9erLqmFxDXxogqRL5mrkfyJkdK pOQ4g4ffm5lPUx76PS6UkqUCjjtcjiJbbHOKK/mPYbEBP3BTl13OV2GUCjqQ4pXD2T0CEu EIwcI2NqmHPH7DU7zQcEPEnznADHi/vArNKqjr8xy6vzC9X99fogrRT5rUosGz0xPQ1UJE o7E+ye7jDYEdbsPIcsiT4yY9hxPDkHyA4B9FXCG4tDWuqlmYhIRq8yjlOLmUsw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704525053; a=rsa-sha256; cv=none; b=jg3slwiyvpnOP6ZMO9mJks4W+nUvxyeLsD9+2F07cBtpIiQE0a4Iad5uqXDheB35zPT+Kj 268QmSJiz3Zq6pML/OBcwYX4Rp0vdn85GLLBBikBxWLuYDfLjJ2I+PZ/gZyw+H7346PiLD W3IAENcSpF0URSonpaBZgOo+0zGsAI9DKl1kxWWxU7jE7uqzLCry5wqlwGwl052ZGaa7NQ cZBqELy5+Ok07wQ3fGSdz1PqQ3u7kpnyiO0IL+vsusi39A1t7ADRvCSOBvWRdSuCWxEBWb vwXSuzkX3op9UZCM+fMbbGuyZofcvTpDGgWMn1HTILREGhUT1TlbFr3l5MFeIQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4T6Wgx24hZzXJc for ; Sat, 6 Jan 2024 07:10:53 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 4067Ar9J036106 for ; Sat, 6 Jan 2024 07:10:53 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 4067ArPV036073 for fs@FreeBSD.org; Sat, 6 Jan 2024 07:10:53 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 276050] pijul clone on ZFS (Error: No error: 0 (os error 0)) Date: Sat, 06 Jan 2024 07:10:52 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 14.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: tankf33der@disroot.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D276050 --- Comment #5 from Mike --- Correct package is pkgconf. Thank you. --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Sat Jan 6 18:27:50 2024 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T6pj42L6Zz56tNN for ; Sat, 6 Jan 2024 18:27:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T6pj41J0gz4pYW for ; Sat, 6 Jan 2024 18:27:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704565672; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KKov3SJui3e1wiLokufzpl6XCpz85kt5hh81rGb1YQ4=; b=BJnzUnBJnlO8PKJPL/CCx/TknQmxfMZCWmkQEbx3+kKBl0rK87X9cBHvbeYIrP3w1BAhTx 2aOfVcPPw6F+mXacu7BmaxdTJ/eBKrqlB6IP8yy1b49NqqvfmdEVgppSvqYtcAaNUtDJIB t3jIh5lyatKyiNXdQoU37NqrJkzxmb2nrpLlLdK7HNzpJk7uR3WFKZRZKFgZyBC2PRT3gg 6piKeM60nDx9zg7lyua0+rpfaN6GbGGN4b1pU3NLjT1r3wElkoGQcmF/aBbW9aS6/eALv7 XtvJFwIdDy4lCIC27jvYDE5Ahz1tONd4v9CiwPn6GJCiqjx7V8Wzl+yG+Pijhw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704565672; a=rsa-sha256; cv=none; b=C/qqOXHl/MX4pvROPXr4LQeAkoYhJ3dE6uo7KxScXIsBNDSCByAKLaG0zxfDLVU1Tm/CVq qGOTLy7FfHOhgcjpBUQRZ4wDxYsDlY7KOdYOpmk7ulEaL1FbJXE1ZgTubo0+dwbDJ9Z34/ g6FyITvIl5MEAvLvc01Qp6uOwUogGedVnkFU67OGrbNbdPRux5TuKEC0VwKgoiACulLgeC rfRBmXiscFyWANtjE6OLZZvoUB0+Zcu3mzQnERatgFfq5JZ+ZPZhrJpwjPrek5tGpbCl0J y9idddu0IOoES3BU4rKXrgFGOmgye3DvvhrGTpS5lz0jmVYqRv0fRubBCaASTA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4T6pj40N6Gzs0B for ; Sat, 6 Jan 2024 18:27:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 406IRp39001429 for ; Sat, 6 Jan 2024 18:27:51 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 406IRpo7001428 for fs@FreeBSD.org; Sat, 6 Jan 2024 18:27:51 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 275594] High CPU usage by arc_prune; analysis and fix Date: Sat, 06 Jan 2024 18:27:50 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 14.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: allanjude@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D275594 Allan Jude changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |allanjude@FreeBSD.org --- Comment #24 from Allan Jude --- Something that might be worth looking at is these changes from upstream: https://github.com/openzfs/zfs/pull/15511 https://github.com/openzfs/zfs/pull/15659 They could result in a lot more vnode's being reclaimable --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Sun Jan 7 14:49:56 2024 X-Original-To: freebsd-fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T7KqD32d4z578pB; Sun, 7 Jan 2024 14:50:00 +0000 (UTC) (envelope-from lev@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T7KqD2Wztz4pdX; Sun, 7 Jan 2024 14:50:00 +0000 (UTC) (envelope-from lev@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704639000; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gYfVJWNu+kitpVo9SMKxn+PcNuADexH3WNKXqEykXFo=; b=VpKj1zOhiFFPHvBCDFs5v4aVcGhXH6RCi19v/7NmvIz6lwrEu6GQmXSRuIVMvx3mhzVjMD 2EKAYn1sC8wiTWAX99ZFBVk6jFHKwJacu/D7LHN5jsD5QfEnnh0X+0aiM6jAhQCXUejXp+ 3GXRStIFmpmPEMzIbrlPtHvvu2oef2sklvgH3VHXYrefmRA2wFV6pM6rQ09sps/39LfUCy U5ll2YrZL2rPuLw9VC+4wm2s8tafmYyCEM1WsbbLGBQgZaVM44GsHulynsM4Ws+b6sYzN6 N5EWktwoj7d/F6nFDEJ/jgCe8AqUgUw2qt34xEz1H3bIshsWKCOg0E3TW3Zl2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704639000; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gYfVJWNu+kitpVo9SMKxn+PcNuADexH3WNKXqEykXFo=; b=gpotw3RbJew7sOentpih9HyrQADRJmGat650wnda3L3Xt2JupTUoHWBWRrJuGeOIlNgl+7 6vZqLWsVYAbTKPcy42NGGzjwRLKvXbnV3ryXHR5zT/P1V3cYUcSYA7xtcSyL7+jHr/JJ5L dFNqW8ugDkgl7zs3MBGcVDCTPRTCvIcKXtYe1io+rEEKvR5chcf+9rF+Ys1E40YIARmTp2 zxP4+McajxnE3fBfK/51lnFwcgPXBBab/QoaDs+3Ak44KTBGkHCKGPMmPaU+MlBjBjQW69 EVFLzjEsXegKL0zV3x3OLQDL3LyOGTvZ6l5eWK8f/CVxc2imsKMXrFOFXDJmUA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704639000; a=rsa-sha256; cv=none; b=UHNdG9v3tUDqzM+LKJW39onk/jgYrdWPHhopwjDxxnDGU23kNLn7PHcjg7mk5P9vCnqvnu Ibw2ZsFGQl4id1IqOmPhpEiOIvkL/mAMWkr+uLhuzmijbX+N6hcW7JLeEz0jV3+8/xJD/X 9exX1edPdSJFJLRIDE/HBYxiVz+OyqkoLPI6bn/0ZxrRdGi342PLEJDyLwuI4lpY9JmITf pvMx7Rq2WjCDNqbqyAW3fBae+vyhyHtU1I6JyIlNK+iarqZagyxCx+1ODcVDsJDEqAPVvt z6vr77dUV7B9a5MJgruWsp2EDOhg23qXYC46263Etymzas6MNAmH4xYe8f+8gw== Received: from onlyone.not-for.work (onlyone.not-for.work [148.251.9.81]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: lev/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4T7KqD0pMbzSQM; Sun, 7 Jan 2024 14:50:00 +0000 (UTC) (envelope-from lev@FreeBSD.org) Received: from [IPV6:2001:470:923f:1:795b:6f6e:6bbc:d02c] (unknown [IPv6:2001:470:923f:1:795b:6f6e:6bbc:d02c]) (Authenticated sender: lev@serebryakov.spb.ru) by onlyone.not-for.work (Postfix) with ESMTPSA id 20BAA50; Sun, 7 Jan 2024 17:49:57 +0300 (MSK) Message-ID: Date: Sun, 7 Jan 2024 15:49:56 +0100 List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: FreeBSD 13.2-STABLE can not boot from damaged mirror AND pool stuck in "resilver" state even without new devices. Content-Language: en-US From: Lev Serebryakov To: freebsd-fs , freebsd-stable , Alexander Motin Reply-To: lev@FreeBSD.org, lev@FreeBSD.org References: Organization: FreeBSD In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 05.01.2024 18:28, Lev Serebryakov wrote: >    After that my server fails to boot, gtpzfsboot from second disk (ada1) reports several "zio_read error: 5" and > > ZFS: i/o error - all block copies unavailable > ZFS: can't read MOS of pool zroot > >    after that. I've re-created pool from scratch zpool create znewroot ada0p3 && zfs send zroot | zfs receive znewroot && zpool destroy zroot && zpool attach znewroot ada0p3 ada1p3 but gptzfsboot still can not boot from it with same diagnostics :-( -- // Lev Serebryakov From nobody Sun Jan 7 15:38:04 2024 X-Original-To: freebsd-fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T7Ltp0qtLz57FRW; Sun, 7 Jan 2024 15:38:10 +0000 (UTC) (envelope-from SRS0=GM30=IR=quip.cz=000.fbsd@elsa.codelab.cz) Received: from elsa.codelab.cz (elsa.codelab.cz [94.124.105.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4T7Ltn50P6z41wg; Sun, 7 Jan 2024 15:38:09 +0000 (UTC) (envelope-from SRS0=GM30=IR=quip.cz=000.fbsd@elsa.codelab.cz) Authentication-Results: mx1.freebsd.org; none Received: from elsa.codelab.cz (localhost [127.0.0.1]) by elsa.codelab.cz (Postfix) with ESMTP id C20E7D788C; Sun, 7 Jan 2024 16:38:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quip.cz; s=private; t=1704641886; bh=957MXApsj9xlddtQHv/VyW8E2u9tQcdfWlSGlI4FFSk=; h=Date:Subject:To:References:From:In-Reply-To; b=Bjfvc/xkdYJzwV/5aZgJS/kvstrmKPvGTOdKxFWU6PvacCJu6lj+FXW45eut3GdRL aGIo0z1CvA+JmQQRdnGLFQML1eBr6YqkVoMNJZIMNMC/XWjriYFGb3uJzMVWWn+igP O8otu3zufJ2i03eyySuMrBO+SJKoVKUXRYxySsK4= Received: from [192.168.145.49] (ip-89-177-27-225.bb.vodafone.cz [89.177.27.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by elsa.codelab.cz (Postfix) with ESMTPSA id 29193D7888; Sun, 7 Jan 2024 16:38:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quip.cz; s=private; t=1704641885; bh=957MXApsj9xlddtQHv/VyW8E2u9tQcdfWlSGlI4FFSk=; h=Date:Subject:To:References:From:In-Reply-To; b=KcDUPi1Ljaay3dlxi4Pvm/iSpwFVkyD8VgIfarwyCj3DrpmY2hYy/5fZS6qMilNCd HD/bIgGz7lUwHB1Hv/3g7k7fWmXbWomp33EDPrnSHNAcLRxEPi2etgup9eg0VDQ0PY teyRDtv1m3BC3ATXj+JQlClOwFRACQ4no3svSrec= Message-ID: Date: Sun, 7 Jan 2024 16:38:04 +0100 List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: FreeBSD 13.2-STABLE can not boot from damaged mirror AND pool stuck in "resilver" state even without new devices. Content-Language: en-US To: lev@FreeBSD.org, freebsd-fs , freebsd-stable , Alexander Motin References: From: Miroslav Lachman <000.fbsd@quip.cz> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4T7Ltn50P6z41wg X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:42000, ipnet:94.124.104.0/21, country:CZ] On 07/01/2024 15:49, Lev Serebryakov wrote: > On 05.01.2024 18:28, Lev Serebryakov wrote: > >>     After that my server fails to boot, gtpzfsboot from second disk >> (ada1) reports several "zio_read error: 5" and >> >> ZFS: i/o error - all block copies unavailable >> ZFS: can't read MOS of pool zroot >> >>     after that. >  I've re-created pool from scratch > >  zpool create znewroot ada0p3 && zfs send zroot | zfs receive znewroot > && zpool destroy zroot && zpool attach znewroot ada0p3 ada1p3 > >  but gptzfsboot still can not boot from it with same diagnostics :-( How large are your disks in a question? I was bitten by this not a long time ago when migrating my 2TB pool by zfs send to larger disks (4TB), then I see the error: ZFS: i/o error - all block copies unavailable ZFS: can't read MOS of pool zroot As far as I search the internet it is caused by the boot code (later stage which is in a file in /boot directory) was moved too far from the beginning of the disk and some old BIOS cannot allow the system to continue booting. I am not a boot expert so my words can be wrong but I hope you get the point. It can be result of the system update, or zfs send | zfs recv. In my case the pool was unbootable in HP Miniserver Ge 8 but boots perfectly fine in an old Supermicro with X9SCA-F board. The problem is not in a pool, nor disks, nor FreeBSD but in a BIOS. I solved it by creating new mirrored pool of the size about 40GB at the beginning of the disks (40GB GPT partition for freebsd-zfs) where I installed the FreeBSD system and next freebsd-zfs partition covering the rest of the 4TB disks for data storage. Everything works fine. You can also have just a small /boot partition for the boot and later overlayed by main ZFS pool, but it seems to me as bad for maintaining. example of my partitions layout # gpart show -p => 40 7814037088 ada0 GPT (3.6T) 40 1024 ada0p1 freebsd-boot (512K) 1064 40960 ada0p2 efi (20M) 42024 83886080 ada0p3 freebsd-zfs (40G) 83928104 20971520 ada0p4 freebsd-swap (10G) 104899624 7707033600 ada0p5 freebsd-zfs (3.6T) 7811933224 2103904 - free - (1.0G) It can also be avoided if your machine supports EFI boot, but my HP Microserver Gen 8 does not support it. Kind regards Miroslav Lachman From nobody Sun Jan 7 17:56:58 2024 X-Original-To: freebsd-fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T7Pz32LZ9z55YG6; Sun, 7 Jan 2024 17:57:03 +0000 (UTC) (envelope-from lev@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T7Pz31Swrz4V98; Sun, 7 Jan 2024 17:57:03 +0000 (UTC) (envelope-from lev@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704650223; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HGStHKmNPazPmWtR7oEhpy4qTf/4ZQS3U6FARk4litA=; b=YPo4TFZL6YB3hlmj+HJufyanbFOpa6ue5NfRu2VuCK3MzBUGqPUpNr7XRJha9jeKL/ssDp kxga4vuYplfSf+Xx11iTiNODpvKLbUemBAcTQzFWSeBGCpKsAXjCMNu+IVjzRoQC2Jxu18 XExiDiKjvoh2NwKdY6RRpv2F1XNZ5DRl9sx2GdjPnnzHDjTH/CkIkiH0HsLILWcju/Ye+x MJEwZWhU2HH3WNK71IWcb8qORdwKdZpRGjzr9F5CPxmqZzPXULmooqC8p8Fml2YCc8vJUK KA7ZKCv01g9BGJZbfj2dKQkQonkKJQviKtCTgzEBjaep9FA+iaNyn+AmkiWBxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704650223; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HGStHKmNPazPmWtR7oEhpy4qTf/4ZQS3U6FARk4litA=; b=T8jezpsaLvh9H8GkUrTk0mUdicBztmqMszrxBAezk3deotfczbWjqtC3kbT+0zGJSKlMrw A40oj1K3Gav37YuxNydhq3f+Ps1mD0am/5Fj6mt2oRcN2mPkfuUXuVRjG9fimuVeEVLDDz pZveXAm480cxptM50rSk3fKpwzB+u1cyUXvzIVXQBQfvg4pu7cUq4kEkA+RCOjoJTRob6k D0JbMUFsZvslNsHn2fbCbAvRrdSMSnSGlI3Btb61ER1iM4Ze6jjwB5kWRjnCSWKtsmVm7X 4h/xMhK+quFtwDU5Z+nR3lWQZWZjg9hbh723Lxt0tMGSsNgI25nY0mEYBQuvww== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704650223; a=rsa-sha256; cv=none; b=dU/oNAnFZZW9ojUI59q4iwTL6BDrMNJvp6i8ivyVaih4OmHOpJA58CSn0YOyp4403lOUEi qhus5eJ7UzbfRmuQjKfyi76m2VPSu4nvSijINWi23E9uwpJMIKjJvw9RMQZkR314XQg1Wx uYNBEoTHdz9Ha8x4t8gSXjUXnfts4hpXeUVImTzRn7tLmxXTTkFqwQ3Ghfv3S6WLhXfkG9 ZzJGguDMG3MaJ9aTF9jhNgGL3FDtkIqfVL13GbrSLEokHeOvX7Fycipjyf4D9qaeVMApbq ZOTyoqsGxKxQf+lXuaGZi+SzW51N3nQ0Is5eNyiP2Z6gAa7A3S8vvuJGNyzpiQ== Received: from onlyone.not-for.work (onlyone.not-for.work [IPv6:2a01:4f8:201:6350::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: lev/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4T7Pz26tRszVLM; Sun, 7 Jan 2024 17:57:02 +0000 (UTC) (envelope-from lev@FreeBSD.org) Received: from [192.168.136.24] (83-84-181-95.cable.dynamic.v4.ziggo.nl [83.84.181.95]) (Authenticated sender: lev@serebryakov.spb.ru) by onlyone.not-for.work (Postfix) with ESMTPSA id 1EDA532D; Sun, 7 Jan 2024 20:56:58 +0300 (MSK) Message-ID: <065f4f5c-f38b-45f4-b7e7-5248f871f7e6@FreeBSD.org> Date: Sun, 7 Jan 2024 18:56:58 +0100 List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Reply-To: lev@FreeBSD.org Subject: Re: FreeBSD 13.2-STABLE can not boot from damaged mirror AND pool stuck in "resilver" state even without new devices. To: Miroslav Lachman <000.fbsd@quip.cz>, freebsd-fs , freebsd-stable References: Content-Language: en-US From: Lev Serebryakov Organization: FreeBSD In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 07.01.2024 16:38, Miroslav Lachman wrote: >>> ZFS: i/o error - all block copies unavailable >>> ZFS: can't read MOS of pool zroot >>> >>>     after that. >>   I've re-created pool from scratch >> >>   zpool create znewroot ada0p3 && zfs send zroot | zfs receive znewroot && zpool destroy zroot && zpool attach znewroot ada0p3 ada1p3 >> >>   but gptzfsboot still can not boot from it with same diagnostics :-( > > How large are your disks in a question? 2TB ada0 at ahcich0 bus 0 scbus0 target 0 lun 0 ada0: ACS-2 ATA SATA 3.x device ada0: Serial Number K5HPZZLD ada0: 600.000MB/s transfers (SATA 3.x, UDMA6, PIO 8192bytes) ada0: Command Queueing enabled ada0: 1907729MB (3907029168 512 byte sectors) ada1 at ahcich1 bus 0 scbus1 target 0 lun 0 ada1: ATA8-ACS SATA 3.x device ada1: Serial Number WD-WMC1P0504169 ada1: 600.000MB/s transfers (SATA 3.x, UDMA6, PIO 8192bytes) ada1: Command Queueing enabled ada1: 1907729MB (3907029168 512 byte sectors) > As far as I search the internet it is caused by the boot code (later stage which is in a file in /boot directory) was moved too far from the beginning of the disk and some old BIOS cannot allow the system to continue booting. Oh, it is good hypothesis. It is Haswell-time MSI board (old Hetzner EX40 instance)... > It can also be avoided if your machine supports EFI boot, but my HP Microserver Gen 8 does not support it. I'll try to switch to EFI, but it needs some luck to get to BIOS with provided KVM, it is very unstable :-) -- // Lev Serebryakov From nobody Sun Jan 7 18:34:06 2024 X-Original-To: freebsd-fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T7Qp4353vz55dvH for ; Sun, 7 Jan 2024 18:34:20 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T7Qp41JqJz4ZTG for ; Sun, 7 Jan 2024 18:34:20 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-a28fb463a28so103886966b.3 for ; Sun, 07 Jan 2024 10:34:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1704652458; x=1705257258; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=dBMcbWknmEeiLCmm6juxjLzU8YNhAOJUpO5ANn/muuc=; b=ZvEWqX1IqdTdeCWQ04qqte+y193MLyB+/LSQZtnC5PZxRCNQ77+1FhUHlDZp/4wIm6 0VQdG7J5XJtLCisDytqG0dpGxUsilVTitK4mQYwMyB6/ZuSqTrKVcYyFP+r7beR1pAWB hq0Y9juNtKujr91CYjmWW37FaN+XMrbhuiYGLgzNXGzBf/NudE5NR+qiqDchTWF+gCWw QjGDbN0yxceAD92Npi+6Fa0lbF3mNrNnph5h/nXZFS8qJn16Ipzjx7ut0vDPFXmasVw2 qhIMbyzJ5ugyvz0hVg2YCoaLoN5XuOCwT6bBhN0/1SuTuJaBnXjj+DPp2mcx5HSpIJRG usmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704652458; x=1705257258; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dBMcbWknmEeiLCmm6juxjLzU8YNhAOJUpO5ANn/muuc=; b=cahXrdKC9uS3KUaqASv269GzTJmzx5FNVm+Fp8BnkWMLmSMQTG1uqlzkTzKqRDVeVH q80N7w2XmrMBur+DwJD3FazCVMAnrcWOQDhhW/BbxWBszRuGu5OXDnNXV1tKMO/l78Oc miqYXhr2TzWnlFne3I+A9B1K30Z60wraJ2PqPKMFWYtK1TOIFh6/E1qbm8VqSTnNZGlQ S6NiYJgBndR64aDmDccnRXnZBHBpZVWG9xJvQDSX0MoQeIuK4zspNRsqrSjYb5vbLIKw gyxv/HJkzhBoVgmaGWfMjMlm6khgqX3OHt0gWWncuwDDO5x14m2+7izC1LSt+91oJPtQ j2Mw== X-Gm-Message-State: AOJu0Yx8SOKRttHgYGdZiOPqBegA1ckc0C8vfoK4wHTleJyvGQLjYLpb yY3l+gLJyOHqtbR8RA6+mHAmLLdtKW+nQ1KtMEm8UccPERKnr/z0labW4mw74lNhlw== X-Google-Smtp-Source: AGHT+IE66MuDCSajV1hdhhJ/pX7xKewBtGmG4U3kYk05yB0o/S1q7cZjTiCCNWFUrjfEOkoG9z/kjxjVvVpO2TwVIRs= X-Received: by 2002:a17:906:d9c7:b0:a27:5343:d3e8 with SMTP id qk7-20020a170906d9c700b00a275343d3e8mr1068109ejb.97.1704652457829; Sun, 07 Jan 2024 10:34:17 -0800 (PST) List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 References: <065f4f5c-f38b-45f4-b7e7-5248f871f7e6@FreeBSD.org> In-Reply-To: <065f4f5c-f38b-45f4-b7e7-5248f871f7e6@FreeBSD.org> From: Warner Losh Date: Sun, 7 Jan 2024 11:34:06 -0700 Message-ID: Subject: Re: FreeBSD 13.2-STABLE can not boot from damaged mirror AND pool stuck in "resilver" state even without new devices. To: lev@freebsd.org Cc: Miroslav Lachman <000.fbsd@quip.cz>, freebsd-fs , freebsd-stable Content-Type: multipart/alternative; boundary="00000000000036f5f2060e5f548d" X-Rspamd-Queue-Id: 4T7Qp41JqJz4ZTG X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] --00000000000036f5f2060e5f548d Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, Jan 7, 2024 at 10:57=E2=80=AFAM Lev Serebryakov w= rote: > On 07.01.2024 16:38, Miroslav Lachman wrote: > > >>> ZFS: i/o error - all block copies unavailable > >>> ZFS: can't read MOS of pool zroot > >>> > >>> after that. > >> I've re-created pool from scratch > >> > >> zpool create znewroot ada0p3 && zfs send zroot | zfs receive znewroo= t > && zpool destroy zroot && zpool attach znewroot ada0p3 ada1p3 > >> > >> but gptzfsboot still can not boot from it with same diagnostics :-( > I must have missed it. What were the diagnostics? > > How large are your disks in a question? > 2TB > > ada0 at ahcich0 bus 0 scbus0 target 0 lun 0 > ada0: ACS-2 ATA SATA 3.x device > ada0: Serial Number K5HPZZLD > ada0: 600.000MB/s transfers (SATA 3.x, UDMA6, PIO 8192bytes) > ada0: Command Queueing enabled > ada0: 1907729MB (3907029168 512 byte sectors) > ada1 at ahcich1 bus 0 scbus1 target 0 lun 0 > ada1: ATA8-ACS SATA 3.x device > ada1: Serial Number WD-WMC1P0504169 > ada1: 600.000MB/s transfers (SATA 3.x, UDMA6, PIO 8192bytes) > ada1: Command Queueing enabled > ada1: 1907729MB (3907029168 512 byte sectors) > < 4294967296 sectors should be good. So these drives shouldn't see this problem. the BIOS interfaces should have no trouble here. > > As far as I search the internet it is caused by the boot code (later > stage which is in a file in /boot directory) was moved too far from the > beginning of the disk and some old BIOS cannot allow the system to contin= ue > booting. > Oh, it is good hypothesis. It is Haswell-time MSI board (old Hetzner > EX40 instance)... > Yes. If the drives are > 2TB you lose. BIOS is not for you... Unless you make special partitions that are in the first 2TB of the drive and only boot off of those. Also, if the drives are 4k, you likely lose, though it's hit or miss. Those are the hard limits of the BIOS ABI. > It can also be avoided if your machine supports EFI boot, but my HP > Microserver Gen 8 does not support it. > I'll try to switch to EFI, but it needs some luck to get to BIOS with > provided KVM, it is very unstable :-) > BIOS booting is dying. It will be unsupportable in not too many more years and the code removed. The rapid proliferation of ZFS crypto and compression types is hastening the race to see who can use up the most space in the boot loader. We can do marginal things to make it better wrt the 640k limit, sure, but then we hit other limits like the 2TB address space, like not being able to reliably support 4k drives, etc. BIOS booting likely will support an increasingly small subset of all possible booting methods as we go forward. The current crazy mix of different alternative firmwares makes it hard to know what will survive, but as we hit these limitations, it will make it harder and harder to configure, deploy and manage these systems. The Linux on ZFS root pages, btw, recommend having two pools on two partitions on the disk. One that's a few GB that's the bool that has the kernel in it, and the other, rest of the disk, that's rpool for the root pool. If people want to continue to support BIOS booting (or rather, booting using the CSM interfaces), then somebody is going to need to step up to the plate and implement a similar option in bsdinstall, bectl, freebsd-update, etc. Warner --00000000000036f5f2060e5f548d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Sun, Jan 7, 2024 at 10:57=E2=80=AF= AM Lev Serebryakov <lev@freebsd.org> wrote:
On= 07.01.2024 16:38, Miroslav Lachman wrote:

>>> ZFS: i/o error - all block copies unavailable
>>> ZFS: can't read MOS of pool zroot
>>>
>>> =C2=A0=C2=A0=C2=A0 after that.
>> =C2=A0=C2=A0I've re-created pool from scratch
>>
>> =C2=A0=C2=A0zpool create znewroot ada0p3 && zfs send zroot= | zfs receive znewroot && zpool destroy zroot && zpool att= ach znewroot ada0p3 ada1p3
>>
>> =C2=A0=C2=A0but gptzfsboot still can not boot from it with same di= agnostics :-(

> How large are your disks in a question?
=C2=A0 =C2=A02TB

ada0 at ahcich0 bus 0 scbus0 target 0 lun 0
ada0: <HGST HUS726020ALE610 APGNTD05> ACS-2 ATA SATA 3.x device
ada0: Serial Number K5HPZZLD
ada0: 600.000MB/s transfers (SATA 3.x, UDMA6, PIO 8192bytes)
ada0: Command Queueing enabled
ada0: 1907729MB (3907029168 512 byte sectors)
ada1 at ahcich1 bus 0 scbus1 target 0 lun 0
ada1: <WDC WD2000FYYZ-01UL1B1 01.01K02> ATA8-ACS SATA 3.x device
ada1: Serial Number WD-WMC1P0504169
ada1: 600.000MB/s transfers (SATA 3.x, UDMA6, PIO 8192bytes)
ada1: Command Queueing enabled
ada1: 1907729MB (3907029168 512 byte sectors)

<=C2=A04294967296 sectors should be good. So these drives shouldn= 't see this problem. the BIOS interfaces should have no trouble here.
=C2=A0
> As far as I search the internet it is caused by the boot code (later s= tage which is in a file in /boot directory) was moved too far from the begi= nning of the disk and some old BIOS cannot allow the system to continue boo= ting.
=C2=A0 =C2=A0Oh, it is good hypothesis. It is Haswell-time MSI board (old H= etzner EX40 instance)...

Yes. If the dr= ives are > 2TB you lose. BIOS is not for you...=C2=A0 Unless you make sp= ecial partitions that are in the first 2TB of the drive and only boot off o= f those. Also, if the drives are 4k, you likely lose, though it's hit o= r miss. Those are the hard limits of the BIOS ABI.

> It can also be avoided i= f your machine supports EFI boot, but my HP Microserver Gen 8 does not supp= ort it.
=C2=A0 =C2=A0I'll try to switch to EFI, but it needs some luck to get t= o BIOS with provided KVM, it is very unstable :-)

=
BIOS booting is dying. It will be unsupportable in not too many = more years and the code removed. The rapid proliferation of ZFS crypto and = compression types is hastening the race to see who can use up the most spac= e in the boot loader. We can do marginal things to make it better wrt the 6= 40k limit, sure, but then we hit other limits like the 2TB address space, l= ike not being able to reliably support 4k drives, etc. BIOS booting likely = will support an increasingly small subset of all possible booting methods a= s we go forward. The current crazy mix of different alternative firmwares m= akes it hard to know what will survive, but as we hit these limitations, it= will make it harder and harder to configure, deploy and manage these syste= ms.

The Linux on ZFS root pages, btw, recommend ha= ving two pools on two partitions on the disk. One that's a few GB that&= #39;s the bool that has the kernel in it, and the other, rest of the disk, = that's rpool for the root pool. If people want to continue to support B= IOS booting (or rather, booting using the CSM interfaces), then somebody is= going to need to step up to the plate and implement a similar option in bs= dinstall, bectl, freebsd-update, etc.

Warner
--00000000000036f5f2060e5f548d-- From nobody Sun Jan 7 19:01:18 2024 X-Original-To: freebsd-fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T7RPH05dmz55hN6; Sun, 7 Jan 2024 19:01:23 +0000 (UTC) (envelope-from SRS0=GM30=IR=quip.cz=000.fbsd@elsa.codelab.cz) Received: from elsa.codelab.cz (elsa.codelab.cz [94.124.105.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4T7RPG508bz4d6q; Sun, 7 Jan 2024 19:01:22 +0000 (UTC) (envelope-from SRS0=GM30=IR=quip.cz=000.fbsd@elsa.codelab.cz) Authentication-Results: mx1.freebsd.org; none Received: from elsa.codelab.cz (localhost [127.0.0.1]) by elsa.codelab.cz (Postfix) with ESMTP id BC5BFD78B9; Sun, 7 Jan 2024 20:01:19 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quip.cz; s=private; t=1704654079; bh=IjzlT/4D0rQsJbQoss+iGDW7eZv4CBXPAhmlMBhqp/k=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=XvtKmAF4BBtFESkV+5T69EXxyvOGv6l/6X1g2w64P2+fjJ1fKgAZAv69YVgOCbSgW EvOZL1TpRSpFDV+YAwtFBYO1AAzkZbu7ZMU8NaV6agGQZwLvAU87pgpOEUK4V9xcyM ZwReKgC3x6xjtWH706cjI0GKdMnEYuGKnXat+2Ro= Received: from [192.168.145.49] (ip-89-177-27-225.bb.vodafone.cz [89.177.27.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by elsa.codelab.cz (Postfix) with ESMTPSA id 9435DD7884; Sun, 7 Jan 2024 20:01:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quip.cz; s=private; t=1704654078; bh=IjzlT/4D0rQsJbQoss+iGDW7eZv4CBXPAhmlMBhqp/k=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=MILcixeIRkEgJL8yogua4Ct32xJMyEzdzeeaURyq+rP92vfGf3senCk4mBTnKhkg6 hBmu5jP8AIWNz4ewH6NB3sUwj/Gvy3tCZ2UFnHYDS47/y5ubRFM0v3bHmQniFXtRMH smusd1G+U+ysz4wknL+a8/ZFgEK9MGhd5Mn14UlA= Message-ID: Date: Sun, 7 Jan 2024 20:01:18 +0100 List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: FreeBSD 13.2-STABLE can not boot from damaged mirror AND pool stuck in "resilver" state even without new devices. Content-Language: en-US To: Warner Losh , lev@freebsd.org Cc: freebsd-fs , freebsd-stable References: <065f4f5c-f38b-45f4-b7e7-5248f871f7e6@FreeBSD.org> From: Miroslav Lachman <000.fbsd@quip.cz> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4T7RPG508bz4d6q X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:42000, ipnet:94.124.104.0/21, country:CZ] On 07/01/2024 19:34, Warner Losh wrote: > < 4294967296 sectors should be good. So these drives shouldn't see this > problem. the BIOS interfaces should have no trouble here. [...] > Yes. If the drives are > 2TB you lose. BIOS is not for you...  Unless > you make special partitions that are in the first 2TB of the drive and > only boot off of those. Also, if the drives are 4k, you likely lose, > though it's hit or miss. Those are the hard limits of the BIOS ABI. It is not always that simple math. As I wrote in my previous reply, my pool was unbootable in one machine but boots fine in the other. Both were Intel based amd64 with BIOS, not EFI. I think there are some buggy BIOSes where it cannot boot even on smaller pools than 2TB. (or maybe some improved BIOSes supporting larger boundaries than 2TB? I don't know in what exact position bootloader / kernel was on my 4TB pool) Kind regards Miroslav Lachman From nobody Sun Jan 7 20:49:24 2024 X-Original-To: freebsd-fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T7Tp31ngLz55wBc; Sun, 7 Jan 2024 20:49:31 +0000 (UTC) (envelope-from lev@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T7Tp31JTcz4qyd; Sun, 7 Jan 2024 20:49:31 +0000 (UTC) (envelope-from lev@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704660571; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=moJLxTRm4w6sk8CN21OufYz+qGwGUupMr1SNWmDFC1Q=; b=W8P3/dEzRcF4tth0VLGB3GbZeETlEEU8uMOdUKg6Eez4HvpljD3gTHN6VfRVoW5E9YZGzg GpF3QFz7Z35hEBzTiewXyAnOTAGoUAbuVzbFQhgbYsa1X7bBB3Ze5sv+wQsKgGfB151MlU 5PKH6m5FcIVnIO/qkstjGOkiWqAQA+YTp6jVIme+Ql9zFvk+YldrMP2uVHWDI8JrMmhHhu sgYkeIoqSSpoKhMFdIQDn76edAR5EMelbMlRFXTbCF2Sobj58MfNZPH63+TrHMazYOAehP lfUS2Bd8Iu2HJuErvPEJohrGfh/LMjJdMox7+dkktf+2bxeUFu3pY8xciFoATw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704660571; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=moJLxTRm4w6sk8CN21OufYz+qGwGUupMr1SNWmDFC1Q=; b=L60jcZwsNHL1kjr1H1ARnsAm3L8JcFnIUhitK7FWGAjNkt4HpKXFO5m2N0IJT44ALgzFPL /vCIdLPZEeBrzKL4s+iT/QEovIOwBQ9vAxt1h68tDObj9I+MwEeuG/6Gh/M/uDw5neBoI7 QhHib7KO0Ph27Ce/EiiBMcYVqCGcDoggaj3DQO4hU4rDa7ICx1xo7lZPguY7z4/PGWY5d1 P+rcKAXj6VyM6TbLgeBaz6hhvjTPS0sEgh4vRaGQLBXZY+J0jFTvtml8+q8Q9ozOlbY97U xyz3Q+u7skCr9TyXqxwabBBzWnK606EAmc8YU3xD5q7LVffaMqYhiMy5s8Lrwg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704660571; a=rsa-sha256; cv=none; b=ddezyY86Sf3CjFNXmpd8gaaoPQJ1/MB8YBtEi8/o375BElPhFrD36+LBMpYHmjP/uvyxWd V0kPr2gZhhOADfTSlQxBLH168KjBmgehaDIdz68zONA2vo5B59pyMnzy1yTVPXb8EZHKJc pSvEJtQedG7vBwmg+SGuP7B4LLcgQjn/j7HPrs8+nRvzwW8s5cmrXz81IO69RgH9kQpPhh aAx0LgejwW9N/gGKTxBZ/OeeMzAgZaPYWXZWPxNwPslNyeRifZbK5Rgf7JbOC0fP0vLh7g SyexvL6x706W8SRljXas/RSMt+AlXhPh2ERb0cFXTSVLFYHOrgnRUNYgua26oQ== Received: from onlyone.not-for.work (onlyone.not-for.work [IPv6:2a01:4f8:201:6350::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: lev/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4T7Tp26ksKzZ7X; Sun, 7 Jan 2024 20:49:30 +0000 (UTC) (envelope-from lev@FreeBSD.org) Received: from [192.168.136.24] (83-84-181-95.cable.dynamic.v4.ziggo.nl [83.84.181.95]) (Authenticated sender: lev@serebryakov.spb.ru) by onlyone.not-for.work (Postfix) with ESMTPSA id 419AC1A2; Sun, 7 Jan 2024 23:49:25 +0300 (MSK) Message-ID: Date: Sun, 7 Jan 2024 21:49:24 +0100 List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Reply-To: lev@FreeBSD.org Subject: Re: FreeBSD 13.2-STABLE can not boot from damaged mirror AND pool stuck in "resilver" state even without new devices. To: Warner Losh Cc: Miroslav Lachman <000.fbsd@quip.cz>, freebsd-fs , freebsd-stable References: <065f4f5c-f38b-45f4-b7e7-5248f871f7e6@FreeBSD.org> Content-Language: en-US From: Lev Serebryakov Organization: FreeBSD In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 07.01.2024 19:34, Warner Losh wrote: > I must have missed it. What were the diagnostics? zio_read error: 5 zio_read error: 5 zio_read error: 5 ZFS: i/o error - all block copies unavailable ZFS: can't read MOS of pool zroot To be honest, I thinks there is something else. Because sequence of events were (sorry, too long, but I think, tht every detail matters here): (1) Update to 13.2 from 12.4. With installation of new gptzfsboot with gpart on both disks. It could place new /boot far away, but see (2) (2) Reboot, which completed, but showed that ada0 has problems (3) Replacement of ada0 by DC technicians, new disk is 512/4096, old disk is 512/512, pool has ashift=9 (4) Server refuses to boot from ada1 (ada0 is empty) with diagnostics (see above) (5) Linux rescue system, passing 2 devices to qemu with FreeBSD (because Linux shows that ZFS is on whole disk, not on partition!). (6) Re-creation of GPT on ada0, start of resilver (with sub-optimal ashift!). (7) Interruption of resilver with reboot, because it is painfully slow under qemu. (8) Wipe of ada0 (at this point resilver status of pool becomes crazy) to put live FreeBSD image to boot somehow. (9) Many tries to cancel resilver and boot from single-disk "historical" pool on ada1, no success. I've attributed it to the strange state of pool: one component, no mirrior, but "resilvering". (10) Boot from small UFS partition (which replaces swap partition). (11) Pool on ada1 (old, live, 512/512 disk) is still "Reslivering" without any additional components (with zero speed, of course). (12) Prepare partitions on ada0 again, creating new pool with ashift=12, send|receive. (13) Removing partition on ada1 (old one, ashift=9, still resilvering after many-many reboots with only one device in it). (14) Boot from fresh ada0 pool - same errors from gptzfsboot, fail, and gptzfsboot says about OLD pool (which should not be available as GPT on ada1 was wiped out!!!!) (15) Boot from UFS again. (16) Adding parition of ada1 as second component of new pool, resilvering successful. (17) Boot with gptzfsboot still fails! With brand-new ashift=12 pool! Now bootloader reports new pool name, but still fails to boot. You see, buildworld update could place /boot too far away. But there was one last successful boot between (1) and (3)! And state of pool on live disk ada1 was very strange: I can not cancel resilver no matter what I've tried till I zap GPT and start over. > If people want to continue to support BIOS booting (or rather, booting using the CSM interfaces), then somebody is going to need to step up to the plate and implement a similar option in bsdinstall, bectl, freebsd-update, etc. I can use UEFI boot without problems, but now I'm not sure, will it work for me now. -- // Lev Serebryakov From nobody Sun Jan 7 20:56:59 2024 X-Original-To: freebsd-fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T7Tyl0Wvlz55x4S; Sun, 7 Jan 2024 20:57:03 +0000 (UTC) (envelope-from lev@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T7Tyk6hgXz4sYn; Sun, 7 Jan 2024 20:57:02 +0000 (UTC) (envelope-from lev@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704661022; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GovAzm586aX1tFxsxjyg7XMYUy6unepRRsd0F5nEXa0=; b=BAWcgtWO/FFCC4OsdS4rXuaVJl2gvLa6wjC+CDRNpN2JvJnf4cQdG6pMHb0E8pLgP5gt0x 36c/qo0YJa8FYJFeF495g6t/HZpWuSAmVZpvORmzFpnDlQ605fEvLayPugN7aFqNBNMT9q GgMhRmulzOo8NJ7rdsmTUu7iuvnKcRvfSDKxs0KImBznAzeGW/ZDsdjfkgoYLTEbtgTcgJ nkKnsJMclCtJkIj7lLh35zKg0YEF8NPPuNUa3r1xMqxQMrqtbTxy1V/nOWQMm4o4paqWgc Pbkiz+k6oQiqk56scLk/WY5an6J6rUPRJz06Gxli7432CThYkqUk1i/L/bGBcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704661022; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GovAzm586aX1tFxsxjyg7XMYUy6unepRRsd0F5nEXa0=; b=Y3Q/05BzYGfeZoI2etAA1fqCTmrzBQMKdmYIXvwL21nW/Y8RZNLaS2+zkP5EmNP2Hqu4RI JNpYc7YM4NPxv7aN4979DUfO1qaGkjt+CWoxXJOg2mxUkIHkX8qs1t7gqQQiFfkFeIi6+W 0iRlK2nEJ3K8YZzvwSQH0La5WWw2JNmMNzzx7L5GDV8gxXHkXbUZfNfNdlpsHg/lxkLYed ZYq3dPLJbclqDd3zfNV5ohaunmaeC4RVG7QDQONDlnJDJ3avOvO0vwKTRAhU4JJpM7G3QX +0LKJaxbJa7MZfstUpF1J/53S0O3OCUw7BoIH5FbwZroxnhqwmh12elujrb7Iw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704661022; a=rsa-sha256; cv=none; b=uj1taT38/WGPMkkSdf8E6afJdc/pRv+A8/wXntZYhSFop0jW0C97F702LvA3Yw6kRQsJO0 6rSlQCnmo+StxhOXwmTufg+RY7VqDPXFoBw9fUoY3iNBKX/aBeBIJCD3vFIZIJ6qSULHVK UKe+uOD/8ooxPRG7XrY+O3kB/ZjC9p0AxmZZT4UN5a5vbzlHnTGvDfYKUeYX/5L4yOxTX1 xxedGQ+vQpldQOawgXupoQSmWf6+1vBkm53RocHzivcE59jJ2hkNtAw7Mkgwmium/qeQKf DejQ+YA05nqA929v/iGs1LMZ+++psF32k3GULD95IZBTiF4EcWwt06AmLNfyRg== Received: from onlyone.not-for.work (onlyone.not-for.work [IPv6:2a01:4f8:201:6350::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: lev/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4T7Tyk526NzZVZ; Sun, 7 Jan 2024 20:57:02 +0000 (UTC) (envelope-from lev@FreeBSD.org) Received: from [192.168.136.24] (83-84-181-95.cable.dynamic.v4.ziggo.nl [83.84.181.95]) (Authenticated sender: lev@serebryakov.spb.ru) by onlyone.not-for.work (Postfix) with ESMTPSA id 95589332; Sun, 7 Jan 2024 23:56:59 +0300 (MSK) Message-ID: <2f91eeb7-430b-49e2-817b-5acd0f445fe9@FreeBSD.org> Date: Sun, 7 Jan 2024 21:56:59 +0100 List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: FreeBSD 13.2-STABLE can not boot from damaged mirror AND pool stuck in "resilver" state even without new devices. Content-Language: en-US From: Lev Serebryakov To: Warner Losh Cc: freebsd-fs , freebsd-stable Reply-To: lev@FreeBSD.org, lev@FreeBSD.org References: <065f4f5c-f38b-45f4-b7e7-5248f871f7e6@FreeBSD.org> Organization: FreeBSD In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 07.01.2024 21:49, Lev Serebryakov wrote: > On 07.01.2024 19:34, Warner Losh wrote: > >> I must have missed it. What were the diagnostics? Oh, and two "nvlist inconsistency" before that vvvv > zio_read error: 5 > zio_read error: 5 > zio_read error: 5 > ZFS: i/o error - all block copies unavailable > ZFS: can't read MOS of pool zroot > > >  To be honest, I thinks there is something else. Because sequence of events were (sorry, too long, but I think, tht every detail matters here): > > (1) Update to 13.2 from 12.4. With installation of new gptzfsboot with gpart on both disks. It could place new /boot far away, but see (2) > (2) Reboot, which completed, but showed that ada0 has problems > (3) Replacement of ada0 by DC technicians, new disk is 512/4096, old disk is 512/512, pool has ashift=9 > (4) Server refuses to boot from ada1 (ada0 is empty) with diagnostics (see above) > (5) Linux rescue system, passing 2 devices to qemu with FreeBSD (because Linux shows that ZFS is on whole disk, not on partition!). > (6) Re-creation of GPT on ada0, start of resilver (with sub-optimal ashift!). > (7) Interruption of resilver with reboot, because it is painfully slow under qemu. > (8) Wipe of ada0 (at this point resilver status of pool becomes crazy) to put live FreeBSD image to boot somehow. > (9) Many tries to cancel resilver and boot from single-disk "historical" pool on ada1, no success. I've attributed it to the strange state of pool: one component, no mirrior, but "resilvering". > (10) Boot from small UFS partition (which replaces swap partition). > (11) Pool on ada1 (old, live, 512/512 disk) is still "Reslivering" without any additional components (with zero speed, of course). > (12) Prepare partitions on ada0 again, creating new pool with ashift=12, send|receive. > (13) Removing partition table on ada1 (with old pool, ashift=9, still resilvering after many-many reboots with only one device in it). And pleas note: this pool on ada1 (old, live disk) was NOT upgraded after 12-STABLE. It was old, 12-STABLE "level" pool with all new features disabled. -- // Lev Serebryakov From nobody Sun Jan 7 21:00:06 2024 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T7V2G68hcz55xGy for ; Sun, 7 Jan 2024 21:00:06 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T7V2G35Y5z4vVh for ; Sun, 7 Jan 2024 21:00:06 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704661206; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=mW7QeBYPCmYKeT0KGzH1NaEZJSL8X2sY9BRuQwzGwts=; b=JE3hXgAZnBX9kfS2ieswgSd3gL35Yb+jUStZSz/RekacJWUR1HFRnteZzCFQX0vcoNB98i ECDiJ7MT8YvBNBNa+nlSixBawwhNPd/PgNy60KmrpoLzZ34Hq6IlMJzfZIAqXqFIae4wQM OBxRp2cQ6+ortGQ5Ny7dds1a1vrrR8NLrb7hhen2+pT86WaLmIkBt/acnNi8sH44ofezBk Sch+juweBaMdfavyyBHrxFXDCSrvoPdPvaC6KLEZn66DWG35jxcJGf2s1cxa1RpmC81/mv K9VEtPnBiwCIHToIeNhPJLo9NygXoHNXsFoVbRaR556XU845RY1COZyJKLm4WA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704661206; a=rsa-sha256; cv=none; b=TY7zraosXQ1y8f4KVfv27UgtswUDgcUnmUqgOjpCDxQ5TDt5Vmqc8p75UhrWBQUv7Rump2 KEnkdOSk91GxDsZwOn8zxJxeJkCscZE2WqzpM9zr4iA0xB/qDfBUKaY737X83ghxVXMsdo VSKfejha9GTOzTBt+OzagZK8VKBYINJHCntYIV6W1hp6wHfYf0+OCOvGIH11BsLCHBykRu UjhkZrrd5eVu3C8QWymGCVMluU9+Wr5ueUDdYgBbjaFOoIUuJYGRAibNWp3sFWSawovGnd lfGImYU3yHDukwGzvTmlO//siqWQ/QrC8AbF65h7BhNDCv1e+jpD/xWBaIw1dw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4T7V2G22JQzg4q for ; Sun, 7 Jan 2024 21:00:06 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 407L06Tq098821 for ; Sun, 7 Jan 2024 21:00:06 GMT (envelope-from bugzilla-noreply@FreeBSD.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 407L06Po098820 for fs@FreeBSD.org; Sun, 7 Jan 2024 21:00:06 GMT (envelope-from bugzilla-noreply@FreeBSD.org) Message-Id: <202401072100.407L06Po098820@kenobi.freebsd.org> X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@FreeBSD.org using -f From: bugzilla-noreply@FreeBSD.org To: fs@FreeBSD.org Subject: Problem reports for fs@FreeBSD.org that need special attention Date: Sun, 7 Jan 2024 21:00:06 +0000 List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="17046612061.BF381.97384" Content-Transfer-Encoding: 7bit --17046612061.BF381.97384 Date: Sun, 7 Jan 2024 21:00:06 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" To view an individual PR, use: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=(Bug Id). The following is a listing of current problems submitted by FreeBSD users, which need special attention. These represent problem reports covering all versions including experimental development code and obsolete releases. Status | Bug Id | Description ------------+-----------+--------------------------------------------------- Open | 231794 | zfs: Panic due to ARC related KVA memory exhausti Open | 237067 | ZFS: Crash in vdev_dtl_reassess when using GELI w Open | 244692 | gjournal: Does not support TRIM Open | 251035 | ZFS: Allow 64 bit ZFS to support 32 bit ioctls (W Open | 264139 | ata: NCQ_DSM_TRIM trim method for Seagate IronWol Open | 266409 | 13.1-RELEASE amd64 crashes in: sa_handle_destroy Open | 268162 | zfskeys_enable: each successful load of a key is Open | 269503 | docs.freebsd.org: default vfs.zfs.arc.meta_limit Open | 271384 | zfs_load is not suitably documented Open | 226130 | ZFS: solaris assert: zrl->zr_refcount == 0 (0x1 = 10 problems total for which you should take action. --17046612061.BF381.97384 Date: Sun, 7 Jan 2024 21:00:06 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" 
The following is a listing of current problems submitted by FreeBSD users,
which need special attention. These represent problem reports covering
all versions including experimental development code and obsolete releases.

Status      |    Bug Id | Description
------------+-----------+---------------------------------------------------
Open        |    231794 | zfs: Panic due to ARC related KVA memory exhausti
Open        |    237067 | ZFS: Crash in vdev_dtl_reassess when using GELI w
Open        |    244692 | gjournal: Does not support TRIM
Open        |    251035 | ZFS: Allow 64 bit ZFS to support 32 bit ioctls (W
Open        |    264139 | ata: NCQ_DSM_TRIM trim method for Seagate IronWol
Open        |    266409 | 13.1-RELEASE amd64 crashes in: sa_handle_destroy 
Open        |    268162 | zfskeys_enable: each successful load of a key is 
Open        |    269503 | docs.freebsd.org: default vfs.zfs.arc.meta_limit
Open        |    271384 | zfs_load is not suitably documented
Open        |    226130 | ZFS: solaris assert: zrl->zr_refcount == 0 (0x1 =

10 problems total for which you should take action.
--17046612061.BF381.97384-- From nobody Sun Jan 7 21:06:26 2024 X-Original-To: freebsd-fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T7V9q59zMz55yFL for ; Sun, 7 Jan 2024 21:06:39 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T7V9q2VfBz43KW for ; Sun, 7 Jan 2024 21:06:39 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-553ba2f0c8fso1332145a12.1 for ; Sun, 07 Jan 2024 13:06:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1704661598; x=1705266398; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=r40KQBPRA3q4Kx8Augm8TyuFOoZXmCoz+NYIaTV/oq8=; b=IjvvrIqAraXbiMl5TkgSsiewdSV0Whb61keKgb3cVfBjuwf3qzhy1vPlacux+pDWFt 3MAiKKIwNbAo7roCkiRtCKdAQtKJ3PBz9sg1ojyrcH+gVpbJfTRIhw+5FL04AyXkOfM2 H8gAsGAxGOqTAQa2nDwkR7C/nAgQ8EmLWxPtialnAS5iuLoN/InVP00JDxW34feP1iMg Ue5XPxAmC9F233TAvrl7knCe6McUu67K9uoBwUTFedJIl5A7RBjMuqtz8DNWOvyjfuDA I285oviGP+Nvjnf5B3w4r+xmgjWZgP4LePMd4mgv7Ow50ngxWtxzN/QmzT+eguM/o0Fo 2//Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704661598; x=1705266398; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=r40KQBPRA3q4Kx8Augm8TyuFOoZXmCoz+NYIaTV/oq8=; b=W/L5faDn03HouBfs6iKijR+d18OdTIBTRzOO+0gpta4cPas2F3qUy1Q5Ih+j441i1D qfvJMhzray3bCf0UEaaF+KTGUhkkcN7vcAU62CBxS7x+A7vmoMZTUjqRU+ZOEegQZOYH BUsfySR/G62azFRb/UXF7rZlXQwrXa7h//+lzdQa3ORGnEyiKv4KHycbBPkSuXp1YuJ0 mmx3B4XFk3AuY1ilEr8a9dOH/muUkSVlvxl8g3voVj+WdgDJxzQh/iHFSZB3o+9nzKxx yJjTyzc2/GVVnyz60ezffo+Vl/55tPXP++Y5pCm/zeloHDAhNQ3aZRAivP88qT82isFi 3NnQ== X-Gm-Message-State: AOJu0Yx7kcSuY4JIkD1/NXZc15KlvbAG28VFwfYU9K60jnbQffRv/SmX b1v3Bu7kl/mjHmn0VBhuNR828bhDv2beD1Kw9VKx7qqQdgteBA== X-Google-Smtp-Source: AGHT+IFokWdN5h8upavvIYSj7qNcUk4QfxU2+Z0cR/bheYt68OSZCktpnmYeZyYss2dJtypP1Irr5HvXyNDdzTAtYlg= X-Received: by 2002:a17:906:310b:b0:a28:1916:6cc9 with SMTP id 11-20020a170906310b00b00a2819166cc9mr423605ejx.270.1704661597664; Sun, 07 Jan 2024 13:06:37 -0800 (PST) List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 References: <065f4f5c-f38b-45f4-b7e7-5248f871f7e6@FreeBSD.org> In-Reply-To: From: Warner Losh Date: Sun, 7 Jan 2024 14:06:26 -0700 Message-ID: Subject: Re: FreeBSD 13.2-STABLE can not boot from damaged mirror AND pool stuck in "resilver" state even without new devices. To: Miroslav Lachman <000.fbsd@quip.cz> Cc: lev@freebsd.org, freebsd-fs , freebsd-stable Content-Type: multipart/alternative; boundary="000000000000fdcd44060e61747d" X-Rspamd-Queue-Id: 4T7V9q2VfBz43KW X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] --000000000000fdcd44060e61747d Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, Jan 7, 2024 at 12:01=E2=80=AFPM Miroslav Lachman <000.fbsd@quip.cz>= wrote: > On 07/01/2024 19:34, Warner Losh wrote: > > > < 4294967296 sectors should be good. So these drives shouldn't see this > > problem. the BIOS interfaces should have no trouble here. > > [...] > > > Yes. If the drives are > 2TB you lose. BIOS is not for you... Unless > > you make special partitions that are in the first 2TB of the drive and > > only boot off of those. Also, if the drives are 4k, you likely lose, > > though it's hit or miss. Those are the hard limits of the BIOS ABI. > > It is not always that simple math. As I wrote in my previous reply, my > pool was unbootable in one machine but boots fine in the other. Both > were Intel based amd64 with BIOS, not EFI. I think there are some buggy > BIOSes where it cannot boot even on smaller pools than 2TB. (or maybe > some improved BIOSes supporting larger boundaries than 2TB? I don't know > in what exact position bootloader / kernel was on my 4TB pool) > OK. If the problem is that int13 has only 32-bits in the ABI, the math is that simple. The limit is 2^32 blocks, and there's no reliable provision for 4k sector sizes (there's some BIOSes that will do it, others that won't... it's a bit muddled looking at the problem reports, though we do try to support that). There's no BIOS64 implementation that extends the int13 interfaces to do wider block sizes that I've seen... It's just that it's so close it's easy to gravitate to a known issue... If other weird things are happening, then that means that we may have a typ= e problem that's truncating the logical block size (which the BIOS doesn't care about) to 32-bit (or maybe sometimes) which then leads to weird things happening. But... UEFI should suffer this same problem and we should hear about it a lot I'd think (though maybe how gptzfsboot is compiled might be the culprit, since that's the only thing that's confined to the gpt boot blocks that's not common binary code (we #include the implementation to make two different binary things....)). It shouldn't care that the copy of /boot/loader is past the 2TB logical limit, because the drives are smaller than 2TB and so none of their LBAs will be > 2^32 and should all work. If that's indeed the issue, then there's something weird about how we build it for gptzfsloader. The other thing it could be, though, is that if there's a resilvering, there's some subtle state that's confusing the simple reimplementation of ZFS reading that's in the boot loader. Though I'd expect to have heard about that before now. Especially since this would hit UEFI booting as well. Warner --000000000000fdcd44060e61747d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Sun, Jan 7, 2024 at 12:01=E2=80=AF= PM Miroslav Lachman <000.fbsd@quip.c= z> wrote:
On 07/01/2024 19:34, Warner Losh wrote:

> <=C2=A04294967296 sectors should be good. So these drives shouldn&#= 39;t see this
> problem. the BIOS interfaces should have no trouble here.

[...]

> Yes. If the drives are > 2TB you lose. BIOS is not for you...=C2=A0= Unless
> you make special partitions that are in the first 2TB of the drive and=
> only boot off of those. Also, if the drives are 4k, you likely lose, <= br> > though it's hit or miss. Those are the hard limits of the BIOS ABI= .

It is not always that simple math. As I wrote in my previous reply, my
pool was unbootable in one machine but boots fine in the other. Both
were Intel based amd64 with BIOS, not EFI. I think there are some buggy BIOSes where it cannot boot even on smaller pools than 2TB. (or maybe
some improved BIOSes supporting larger boundaries than 2TB? I don't kno= w
in what exact position bootloader / kernel was on my 4TB pool)

OK. If the problem is that int13 has only 32-bits i= n the ABI, the math is that simple.
The limit is 2^32 blocks, and= there's no reliable provision for 4k sector sizes (there's
some BIOSes that will do it, others that won't... it's a bit mud= dled looking at the problem
reports, though we do try to support = that). There's no BIOS64 implementation that
extends the int1= 3 interfaces to do wider block sizes that I've seen... It's just th= at it's
so close it's easy to gravitate to a known issue.= ..

If other weird things are happening, then that = means that we may have a type
problem that's truncating the l= ogical block size (which the BIOS doesn't care
about) to 32-b= it (or maybe sometimes) which then leads to weird things happening.
But... UEFI should suffer this same problem and we should hear about it = a lot
I'd think (though maybe how gptzfsboot is compiled migh= t be the culprit, since
that's the only thing that's conf= ined to the gpt boot blocks that's not common
binary code (we= #include the implementation to make two different binary
things.= ...)). It shouldn't care that the copy of /boot/loader is past the 2TB<= /div>
logical limit, because the drives are smaller than 2TB and so non= e of their
LBAs will be > 2^32 and should all work. If that= 9;s indeed the issue, then there's
something weird about how = we build it for gptzfsloader.

The other thing it c= ould be, though, is that if there's a resilvering, there's some
subtle state that's confusing the simple reimplementation of ZFS= reading that's
in the boot loader. Though I'd expect to = have heard about that before now. Especially
since this would hit= UEFI booting as well.

Warner

=
--000000000000fdcd44060e61747d-- From nobody Sun Jan 7 21:15:14 2024 X-Original-To: freebsd-fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T7VMy5Vs8z560qv for ; Sun, 7 Jan 2024 21:15:26 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T7VMy3pbPz452C for ; Sun, 7 Jan 2024 21:15:26 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-556c3f0d6c5so1337647a12.2 for ; Sun, 07 Jan 2024 13:15:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1704662125; x=1705266925; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=vgHAAVGVnuMYvEQ3QnRnNsHbKlCKig/3HCPsAT5KGZU=; b=aKrEo8Hmc8oilm3o+C8F+KiCRmgtYyt9gzVQVXW470qBIJMbLKpjBLq/BagkBobQlD GFqC6wZKENMIbV53brGN2AIo7pzFMBqnnsDNlnu3dfElAGF7+cO5UqsgreOzh+WuM9sd UFxhFdzo57kL1xzgq7UcQwTXZoBnad6MsT+SkeEkOpCKTptZRxvLnxVKd4+dVPoBCzem QWgofQ0tOqC3e9SxO6gs5QXc38pet+IKcxVRiw2c9hQhNqwW8jmPR6rvY5tGLjPsxfjG kfDDpIGVPHTwdG2Ty8dZOX02JH8PUvroJkuXaYE5o7thDAGx8cED6tU97uKwzei5/Hzy 2qwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704662125; x=1705266925; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vgHAAVGVnuMYvEQ3QnRnNsHbKlCKig/3HCPsAT5KGZU=; b=aOzYZHrX38V5T1MkVQtsiEQCBoXbEJ1qy73RTQFDGamjAL9drXdHFV7Xx5bgzw0VLQ HyoKB+/kjbhlsJ086TGek+0xvnzTlutBDWsURdvdYUk27WThyxRaw3Mt2tyYhtSHHmGe vayWNyTvWIicjfiJIrZODi7xly0/qlFaE5pmQc+v5xcfld5Y/exBkCeEjTUDViTd/Jg5 j/vrrLOqFvb2Htv8ojpo6/X0RCTrBAOwSmRVQmmt7kfSeCehK0gwfLzOteG/xoOnOMk4 NUz6dHkKcPCfHeZgU/rY8NYq0TTMf0UjWjPD3Qavljnxw+yl8/9HQI0/NH8Ly5f6PPkD Lnrw== X-Gm-Message-State: AOJu0YxcGIn+V9WiGUuLQRb6ww71oJZU7fT88fZqQ3TEjzbWikbA1JNi 7Tvn//pIfwxR185McyXpNuG4qNIenYSAjBt7Fnt+8lB0IOJxyw== X-Google-Smtp-Source: AGHT+IHFhioVO+WSOS73stbnwyNMxN77R5XrtFVLfzanDmMUJu9h6D/pAJZBbTJ6adefF93zun91Vs5Y+5oZZYYXOX4= X-Received: by 2002:a17:907:a05:b0:a28:dfe4:1d0b with SMTP id bb5-20020a1709070a0500b00a28dfe41d0bmr860061ejc.31.1704662125138; Sun, 07 Jan 2024 13:15:25 -0800 (PST) List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 References: <065f4f5c-f38b-45f4-b7e7-5248f871f7e6@FreeBSD.org> <2f91eeb7-430b-49e2-817b-5acd0f445fe9@FreeBSD.org> In-Reply-To: <2f91eeb7-430b-49e2-817b-5acd0f445fe9@FreeBSD.org> From: Warner Losh Date: Sun, 7 Jan 2024 14:15:14 -0700 Message-ID: Subject: Re: FreeBSD 13.2-STABLE can not boot from damaged mirror AND pool stuck in "resilver" state even without new devices. To: lev@freebsd.org Cc: freebsd-fs , freebsd-stable Content-Type: multipart/alternative; boundary="0000000000006e66a9060e619437" X-Rspamd-Queue-Id: 4T7VMy3pbPz452C X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] --0000000000006e66a9060e619437 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, Jan 7, 2024 at 1:57=E2=80=AFPM Lev Serebryakov wr= ote: > On 07.01.2024 21:49, Lev Serebryakov wrote: > > > On 07.01.2024 19:34, Warner Losh wrote: > > > >> I must have missed it. What were the diagnostics? > > Oh, and two "nvlist inconsistency" before that vvvv > > > zio_read error: 5 > > zio_read error: 5 > > zio_read error: 5 > 5 is EIO which the loader uses internally for any error that the disk reports. I've not read through all the code involved here, but I think that means there might be read errors for real. Though the nvlist inconsistency might be an issue. So, if this is a mirror, then ada0 blank and ada1 with good data, in theory you should be fine. However, perhaps ZFS is finding that there's an error from ada1 for real. Does all of ada1 read with a simple dd? Not sure about the losing devices you described later on. > ZFS: i/o error - all block copies unavailable > > ZFS: can't read MOS of pool zroot > > > > > > To be honest, I thinks there is something else. Because sequence of > events were (sorry, too long, but I think, tht every detail matters here)= : > Yea. There's something that's failing, which zio_read is woefully under reporting for our diagnostic efforts. And/or something is getting confused by the blank disk and/or the partially resilvered disk. > (1) Update to 13.2 from 12.4. With installation of new gptzfsboot with > gpart on both disks. It could place new /boot far away, but see (2) > > (2) Reboot, which completed, but showed that ada0 has problems > > (3) Replacement of ada0 by DC technicians, new disk is 512/4096, old > disk is 512/512, pool has ashift=3D9 > > (4) Server refuses to boot from ada1 (ada0 is empty) with diagnostics > (see above) > > (5) Linux rescue system, passing 2 devices to qemu with FreeBSD (becaus= e > Linux shows that ZFS is on whole disk, not on partition!). > > (6) Re-creation of GPT on ada0, start of resilver (with sub-optimal > ashift!). > > (7) Interruption of resilver with reboot, because it is painfully slow > under qemu. > > (8) Wipe of ada0 (at this point resilver status of pool becomes crazy) > to put live FreeBSD image to boot somehow. > > (9) Many tries to cancel resilver and boot from single-disk "historical= " > pool on ada1, no success. I've attributed it to the strange state of pool= : > one component, no mirrior, but "resilvering". > > (10) Boot from small UFS partition (which replaces swap partition). > > (11) Pool on ada1 (old, live, 512/512 disk) is still "Reslivering" > without any additional components (with zero speed, of course). > > (12) Prepare partitions on ada0 again, creating new pool with ashift=3D= 12, > send|receive. > > (13) Removing partition table on ada1 (with old pool, ashift=3D9, still > resilvering after many-many reboots with only one device in it). > > And pleas note: this pool on ada1 (old, live disk) was NOT upgraded > after 12-STABLE. It was old, 12-STABLE "level" pool with all new features > disabled. > Yea, this isn't *THAT*OtHER* problem :). Warner > -- > // Lev Serebryakov > > --0000000000006e66a9060e619437 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Sun, Jan 7, 2024 at 1:57=E2=80=AFP= M Lev Serebryakov <lev@freebsd.org> wrote:
On = 07.01.2024 21:49, Lev Serebryakov wrote:

> On 07.01.2024 19:34, Warner Losh wrote:
>
>> I must have missed it. What were the diagnostics?

=C2=A0 Oh, and two "nvlist inconsistency" before that vvvv

> zio_read error: 5
> zio_read error: 5
> zio_read error: 5



So= , if this is a mirror, then ada0 blank and ada1 with good data, in theory
you should be fine. However, perhaps ZFS is finding that there'= ;s an error from
ada1 for real. Does all of ada1 read with a simp= le dd?

Not sure about the losing devices you descr= ibed later on.

> ZFS: i/o error - all block copies unavailable
> ZFS: can't read MOS of pool zroot
>
>
>=C2=A0 =C2=A0To be honest, I thinks there is something else. Because se= quence of events were (sorry, too long, but I think, tht every detail matte= rs here):

Yea. There's something th= at's failing, which zio_read is woefully under reporting for our diagno= stic efforts. And/or something is
getting confused by the blank d= isk and/or the partially resilvered disk.


> (1) Update to 13.2 from 12.4. With installation of new gptzfsboot with= gpart on both disks. It could place new /boot far away, but see (2)
> (2) Reboot, which completed, but showed that ada0 has problems
> (3) Replacement of ada0 by DC technicians, new disk is 512/4096, old d= isk is 512/512, pool has ashift=3D9
> (4) Server refuses to boot from ada1 (ada0 is empty) with diagnostics = (see above)
> (5) Linux rescue system, passing 2 devices to qemu with FreeBSD (becau= se Linux shows that ZFS is on whole disk, not on partition!).
> (6) Re-creation of GPT on ada0, start of resilver (with sub-optimal as= hift!).
> (7) Interruption of resilver with reboot, because it is painfully slow= under qemu.
> (8) Wipe of ada0 (at this point resilver status of pool becomes crazy)= to put live FreeBSD image to boot somehow.
> (9) Many tries to cancel resilver and boot from single-disk "hist= orical" pool on ada1, no success. I've attributed it to the strang= e state of pool: one component, no mirrior, but "resilvering". > (10) Boot from small UFS partition (which replaces swap partition). > (11) Pool on ada1 (old, live, 512/512 disk) is still "Reslivering= " without any additional components (with zero speed, of course).
> (12) Prepare partitions on ada0 again, creating new pool with ashift= =3D12, send|receive.
> (13) Removing partition table on ada1 (with old pool, ashift=3D9, stil= l resilvering after many-many reboots with only one device in it).

=C2=A0 And pleas note: this pool on ada1 (old, live disk) was NOT upgraded = after 12-STABLE. It was old, 12-STABLE "level" pool with all new = features disabled.

Yea, this isn't = *THAT*OtHER* problem :).=C2=A0

Warner
= =C2=A0
--
// Lev Serebryakov

--0000000000006e66a9060e619437-- From nobody Sun Jan 7 21:19:33 2024 X-Original-To: freebsd-fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T7VSm0qB4z561Gl; Sun, 7 Jan 2024 21:19:36 +0000 (UTC) (envelope-from lev@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T7VSl6ttKz46hp; Sun, 7 Jan 2024 21:19:35 +0000 (UTC) (envelope-from lev@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704662376; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Tg/IoX2r7626nl2FGGM3y4zlJB3O1AF5MWoK1EcwkpU=; b=k/jEy2sDVd1RCMH84prpz8uR7fa9/dZ3R7cixAVMOL51ksrrOexHYw5Uk8cYyLvlnyR5aP Gjeeqi7/YhPapzj/y+A2JAE7FiYc6Q6cg8OJMWBuInKkd7QfpAG4dgtBcdEFkoFD7T6wMz OSakZFlumu6821IUObA61/TeeImRmAGVOrfTqlpLZFOb67bpHC3GZsuhIkmw+5q/ScZuJA TDRHvz2cOfQnxUxE2pMcJuTHOE48VgLFGc0I1hQpwv21AWaaUi9/xSBovkoGqR3n3YWiHt EBdxuKOhRqO8oM5AWl1ydLQIKB2cW86Y+5xuwNYV+e/mIzh/UPmaoHo47WTcuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704662376; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Tg/IoX2r7626nl2FGGM3y4zlJB3O1AF5MWoK1EcwkpU=; b=bFDOLEhKyIU5N/of/+7Tb4pNfVkXWyTabzh6LucyFXnYEc/6SeRIge4jfW68Q/+Jg+Dzru eiI2wslKGzKH3BtntFK+oakNZjDHFV/iNBvpagksDiXtX2Xxwm/3+NeAGb1u3xWa6aSrxB nQZlH1j36QdYtlIM+xVTbWD/O5RtFXigj0Xz66+VGUZOHFXMOq//S/L66o6VNLq1ZkzW7u p1GfJgIfCnma65nQZwlY8Ud97V+Qze7YiJ8u3v33Xp/nF/FTXiIuBJ0iyyEwTFFGwpX1eY 6FwNuUyC8UrJ8eVEdTYB4uR+1tq75avKQz4hv8gLCGn34jgRMXAW3xmynzsrGw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704662376; a=rsa-sha256; cv=none; b=T+pn7GkMuahbcvW2yRNY3NUlAjJrDo7sutAWo16ezTyy9jZ7dTAoUBp491IUig9BpxoiKV 6U5d58u4IfQnAUQSpVHYWfhs5yh0w9SYkW0oHDe3NMk2CyThAAcZ/RGS3/oEW/UxQMy6kt KCWD+Pb1L0lhVIvvGwgmTBU4AwCn7Bd6SkcZSwYyNn+xYScVfwpAsY6Q8Mv90bWGuTL/Kg EuwlZ3TIeR8qigbHO1cvDgffuhzqTGkkQdXdUFRVevb8wOMgG9aVcoclf+fuESJ89HnC+E pjwnKKBLPe08XaSqdmvhN/iCSU9nYeBnjr8fT4DTcZ+5/rpFQGxUa+CnrHbpPQ== Received: from onlyone.not-for.work (onlyone.not-for.work [IPv6:2a01:4f8:201:6350::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: lev/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4T7VSl5FyfzZfS; Sun, 7 Jan 2024 21:19:35 +0000 (UTC) (envelope-from lev@FreeBSD.org) Received: from [192.168.136.24] (83-84-181-95.cable.dynamic.v4.ziggo.nl [83.84.181.95]) (Authenticated sender: lev@serebryakov.spb.ru) by onlyone.not-for.work (Postfix) with ESMTPSA id EC91F299; Mon, 8 Jan 2024 00:19:33 +0300 (MSK) Message-ID: <962b242d-546f-46ce-9eb2-9bd2a10f4608@FreeBSD.org> Date: Sun, 7 Jan 2024 22:19:33 +0100 List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Reply-To: lev@FreeBSD.org Subject: Re: FreeBSD 13.2-STABLE can not boot from damaged mirror AND pool stuck in "resilver" state even without new devices. Content-Language: en-US To: Warner Losh Cc: freebsd-fs , freebsd-stable References: <065f4f5c-f38b-45f4-b7e7-5248f871f7e6@FreeBSD.org> <2f91eeb7-430b-49e2-817b-5acd0f445fe9@FreeBSD.org> From: Lev Serebryakov Organization: FreeBSD In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 07.01.2024 22:15, Warner Losh wrote: > So, if this is a mirror, then ada0 blank and ada1 with good data, in theory > you should be fine. However, perhaps ZFS is finding that there's an error from > ada1 for real. Does all of ada1 read with a simple dd? Yep, it is read with dd, I've checked it > Not sure about the losing devices you described later on. > > > ZFS: i/o error - all block copies unavailable > > ZFS: can't read MOS of pool zroot > > > > > >   To be honest, I thinks there is something else. Because sequence of events were (sorry, too long, but I think, tht every detail matters here): > > > Yea. There's something that's failing, which zio_read is woefully under reporting for our diagnostic efforts. And/or something is > getting confused by the blank disk and/or the partially resilvered disk. My theory, that something is confused when one disk is 512/4096 and other is 512/512. I want to check it on VM, but can not find VM that both (1) allows CMS boot and (2) allows to configure logical and physical sector of virtual HDD. bhyve could configure sector sizes, but doesn't support BIOS, and VBox and qemu-system can not emulate sector sizes (or I can not google proper configuration). -- // Lev Serebryakov From nobody Sun Jan 7 21:29:12 2024 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T7Vgr5kcBz562N5 for ; Sun, 7 Jan 2024 21:29:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T7Vgr3pztz4DPV for ; Sun, 7 Jan 2024 21:29:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704662952; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lwEAgxHwrNC5D2QzfoGlTrfYMWcKDLS/xFq09I33SZ4=; b=D8D5w6XMkHReHwe6BnMaCXarZZ8dLtHgUmfdG3ZUetPNL6aCf6n4clImXB4C3gEBirw4qh NC4xKXMqm2t7GK66XHm9NootAfqpHo5CoIJe2ZG9PvOWNYb7HXjZMh2O81Gar8e03xgmdC fa26BNayhckRPVgplgy2SDiRMkW9BEOuUUvKvFB8cniidqcY9hsoG9rhLi6AMno8ho6jtv 3q+FDabe3eMaAB/HsUoYdMQp57vJSxpt5p6ny8pJsc1CE5TdndV8U+1PTFNU7YIpDKI/QQ zbPYpLaBYYIzhc3kAiftuc6rAh/NOJZtkFElV8WFvmBcz2uI2LhN8abCQed7JA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704662952; a=rsa-sha256; cv=none; b=PqQu2CDugxhgmPCV/H5DN8PZO3t7mbG1BiI5GeThwjh3lcd9c4aD2AOkqfHi/lM/O5NEiS jP0hT6c+Ly9/jrhqsQMeTAvAdbdGDlZDEn9vGyWOrA/vJPoO7ig/fLGD1cgSfcs8OpNbJ6 +vOI0KUmUfGvSZHGRlM2uePZum5nMdyLHq777FCKGkckNucgD/8DXkpqFqrCELGbpi7+IO ykjUKbXK+clEZo1W3Ua3D/mndwISfYa08075ZjCBVRfKpRa7SLMIineSE4cuVDeG7frmQ4 54hzh3IHS+ceLwtm58JdJTvh2Cu7FE69EMN+h10xJtOVtVhYhgizLL27IBbX5w== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4T7Vgr2v40zgS9 for ; Sun, 7 Jan 2024 21:29:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 407LTCwf043055 for ; Sun, 7 Jan 2024 21:29:12 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 407LTCIC043054 for fs@FreeBSD.org; Sun, 7 Jan 2024 21:29:12 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 269330] fusefs: data corruption with mmap and either o_direct or fspacectl Date: Sun, 07 Jan 2024 21:29:12 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: asomers@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D269330 --- Comment #2 from Alan Somers --- Update: I can also produce the same corruption by mixing mmap'd writes and copy_file_range, using fsx-rs 0.2.0 with a config like this: flen =3D 524288 nomsyncafterwrite =3D true [opsize] max =3D 131072 min =3D 65536 [weights] truncate =3D 0 fsync =3D 0 fdatasync =3D 0 punch_hole =3D 0 write =3D 0 mapwrite =3D 10 mapread =3D 0 read =3D 10 copy_file_range =3D 10 I also have a not-yet-committed test case in the fusefs test suite that demonstrates the problem. --=20 You are receiving this mail because: You are on the CC list for the bug.= From nobody Sun Jan 7 22:19:57 2024 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T7WpP2t3Yz568Bf for ; Sun, 7 Jan 2024 22:19:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T7WpN6WkGz4JLl for ; Sun, 7 Jan 2024 22:19:56 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704665996; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=reZS8Cx4su66hKQPwZo9d0jF9eTE9K767XqH0IBtKKM=; b=Vi793dZrOXi61g2vpwXZtbvkSMBTHGsC0vWPSijQ0BOV/nAVmbJl6lM3kuUshK8PqcMWEG 1wROttw/4uA4BSzwF8zfhIi6lri3uL1s408F1ZyoadHRErOxsRh+4+xrxt5u+rmblEaoyP 6WpvOD8ief9mYgHGjNSJ0I5N4RGXl1szum+tnwKM7W9PT9U6axZTCtURwKuabyc5Hn0VrH 2loA0XWlTbV9M1diqDNHjWplaI2jN9Y6pjmoi3NkTmaBKIQ0a1av3dOkMmnS1iHHzFXBdj 3AuoB/N8zYOdQrhARmzirB5uKlt01jVQi7eYJmd42JduP5rb08hx11QAociUlQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704665996; a=rsa-sha256; cv=none; b=Vfo/96c5XZvmV+AsKLWtrUte25uUsxqb0yo0xzMMtjrbjoJ3YLqNnF9mn9mL21WH4StMNj Fsxs2MC6ZgAPkUIvIVW0iHzzNjGo13lfeOdJ1I7BPLjlY/cziwpkBGRKWiR49vXGt6RICZ WU6y5DP0MtPAWgDJUxC3TaLDQAVqpJB88/rzoz/tizaL/ugLxFSQERmzXaLzY64xSdkm+Q XuUtItQlAvgEJkBvZ/+f3aXJj7jYKmFbwA0gSMboE/sh/dUTf/UshDh6PjiIqd4mRM4eUQ kn6pyZTNozPzK8QNgE3/dZOaMAG6zWKyqvXS0Qq4V92in4aKtI/ClrZBl2zBYA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4T7WpN5bTDzj7B for ; Sun, 7 Jan 2024 22:19:56 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 407MJuvm025231 for ; Sun, 7 Jan 2024 22:19:56 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 407MJur6025230 for fs@FreeBSD.org; Sun, 7 Jan 2024 22:19:56 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 276002] nfscl: data corruption using both copy_file_range and mmap'd I/O Date: Sun, 07 Jan 2024 22:19:57 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 15.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: asomers@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D276002 --- Comment #52 from Alan Somers --- With the latest code in main, including kib's two commits, I can no longer reproduce the bug using the second copy_file_range.toml file I posted. But= I can still reproduce it using the original file. In fact, I can reproduce it without using copy_file_range or truncate at all, using this config file. = This may be a different bug: nomsyncafterwrite =3D true [weights] truncate =3D 0 fsync =3D 1 fdatasync =3D 1 punch_hole =3D 0 sendfile =3D 0 write =3D 10 read =3D 10 copy_file_range =3D 0 --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Sun Jan 7 22:21:47 2024 X-Original-To: fs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4T7WrW59z4z56887 for ; Sun, 7 Jan 2024 22:21:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4T7WrW49gwz4KLn for ; Sun, 7 Jan 2024 22:21:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1704666107; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tNTwjLhL3Y4QYECLCs8h1lrLOSgcW+5KlD/f42G3YIw=; b=vCsuNkrdKrH1DV2/zVUWYsXKG7s31aQkLXmczMeAw+jFFaTgjdFLSmeGieKhGcqFdlMka7 Pk5rBiV/itMJwMLeA05CoucWruIEHRbFCZ3dcV4VVRpS3df8G1JsAcYR5h+7EirdyzfaXI 5WaXxo21X/Ui9jCyaAWM8Caz+1N9pcudxrtLCbnO2aM0pIA0Tu5oJF2AN/+KWe2A0Qwdd9 WUOdnF+0Q+3/V86wCWJ0RIi1xcZXo1RCz6W0dkmI/h+vGUf+6xC7L18sgGg3gbRFChVv5P Y3C3t2AzwAZD0vQn7kcXJ337p8NMQCXZNrc/+TPwGIAY8j4YUp/oG6ocu4GP8w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1704666107; a=rsa-sha256; cv=none; b=jSqv9PPHfOkHh4b65LF2Od4zscHARD2C9GP6+On5ZTSstrlt9wFZMgqCfnnss1YydjwGwI iSpwp/PPCzHU6c1P1IRATV6ZXwJTxAOQBIGWKn/Y56qcDvuVWR62CEaLjMwhohC+xD9al+ VwMD8NHGNfW9mtYrtAglkw2Xz+G+SIxJqspZ2XHkHdbExj6EM/7Zll99xZPTNzu9ur4lUD efJgH1xWyf9MsDY7JAbBHZhScuAeFWopFmajtTCVwhOmklWk+gyh58bX7IRttxZl/PxQsb c8/ZHuQ6vdzoVJ2zaRMmY2/iPAOjp1jlrABPyWe0oaQeRUIALYc2gnsjjpyZVQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4T7WrW2rXRzjK7 for ; Sun, 7 Jan 2024 22:21:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 407MLlOX035074 for ; Sun, 7 Jan 2024 22:21:47 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 407MLlgI035073 for fs@FreeBSD.org; Sun, 7 Jan 2024 22:21:47 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 269330] fusefs: data corruption with mmap and either o_direct or fspacectl Date: Sun, 07 Jan 2024 22:21:47 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: asomers@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Filesystems List-Archive: https://lists.freebsd.org/archives/freebsd-fs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-fs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D269330 --- Comment #3 from Alan Somers --- kib, do you think that I could fix this bug by doing a vm_object_page_clean followed by vinvalbuf just prior to FUSE_COPY_FILE_RANGE, FUSE_FALLOCATE, o= r a FUSE_WRITE with O_DIRECT ? --=20 You are receiving this mail because: You are on the CC list for the bug.=