From nobody Mon Feb 26 16:25:45 2024 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Tk5Zq4K1Dz5BjCb for ; Mon, 26 Feb 2024 16:25:55 +0000 (UTC) (envelope-from igor.ostapenko@pm.me) Received: from mail-40133.protonmail.ch (mail-40133.protonmail.ch [185.70.40.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "protonmail.com", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Tk5Zp3CB5z4QLS for ; Mon, 26 Feb 2024 16:25:54 +0000 (UTC) (envelope-from igor.ostapenko@pm.me) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=pm.me header.s=protonmail3 header.b=ZvrUcpsW; dmarc=pass (policy=quarantine) header.from=pm.me; spf=pass (mx1.freebsd.org: domain of igor.ostapenko@pm.me designates 185.70.40.133 as permitted sender) smtp.mailfrom=igor.ostapenko@pm.me DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pm.me; s=protonmail3; t=1708964751; x=1709223951; bh=nNj5WxbqLx98aTgVMdQZjvneuMdVRQcDZiTqMWP+h+4=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=ZvrUcpsWvNrpBMCtegRrv2EQvyweaU479vln6qnvGEwdy/3G4UwMvgOeybrK5TJLN Kl7EU2LiGXv++65iEOJgLKhbcM0wAKHOIg+qTybXjUZ3h2YqE9mPjGqio4gqSVHTUv ldVSdVxi1DRvt1dULGP9SkoawHmMOpb6e1oL2XG32Z8Rq8f3Bf8Bu6vVzVhRM2LFto oXr41uRVx1ScmXBKfsnpQdVBHEdknZzbf5FuYqc+bQ+aRtiQppKxAXq1W803EQunZt Sd1vhD4Z7L/l2w9D77GRXCeqrnbGQWnli27EE28uzYPcgmpBFa9qqzIgGuAfNWxteu xJQuWjEbr5zKA== Date: Mon, 26 Feb 2024 16:25:45 +0000 To: Paul Floyd From: Igor Ostapenko Cc: freebsd-hackers@freebsd.org Subject: Re: Add jail execution environment support to the FreeBSD test suite Message-ID: In-Reply-To: References: <2bjQNp1msrv-_AqyamMun6kY-SCqbgPm3Q7DqVQHAYlqvFkiE1i85svfIT-QQdUG1cg3cKippyTyv8Z-5nbLu4WaMutgZQ7KT-YYo_5Pbro=@pm.me> <188b3537-11b1-4169-aae2-070d349b6016@gmail.com> <5XGsuxCWojiK7f1wBuoC73PWMtjVB3oCvsy1vHQtNr5UHC_2LN8zNGczKwpQEs4Pcc8g1G3Rir4uIrQ9iUxKbWmonsEu5f_mHzldy4vuYk4=@pm.me> Feedback-ID: 8300135:user:proton List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.20 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; DMARC_POLICY_ALLOW(-0.50)[pm.me,quarantine]; R_SPF_ALLOW(-0.20)[+ip4:185.70.40.0/24]; R_DKIM_ALLOW(-0.20)[pm.me:s=protonmail3]; RWL_MAILSPIKE_VERYGOOD(-0.20)[185.70.40.133:from]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; ASN(0.00)[asn:62371, ipnet:185.70.40.0/24, country:CH]; TO_DN_SOME(0.00)[]; MISSING_XM_UA(0.00)[]; FREEMAIL_TO(0.00)[gmail.com]; MID_RHS_MATCH_FROM(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_COUNT_ZERO(0.00)[0]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; MLMMJ_DEST(0.00)[freebsd-hackers@freebsd.org]; DKIM_TRACE(0.00)[pm.me:+] X-Rspamd-Queue-Id: 4Tk5Zp3CB5z4QLS On Friday, February 23rd, 2024 at 7:57 PM, Paul Floyd = wrote: > On 23-02-24 16:08, Igor Ostapenko wrote: >=20 > > On Friday, February 23rd, 2024 at 10:30 AM, Paul Floyd paulf2718@gmail.= com wrote: > >=20 > > > Will there be an option to turn this off globally? > > >=20 > > > I sometimes run test suits with Valgrind. I'm not aware of any option= to > > > do that cleanly so I just do it with brute force: run kyua and all > > > children under Valgrind. > > >=20 > > > valgrind --trace-children=3Dyes -q kyua test -k Kyuafile > > >=20 > > > Adding jails into the mix is likely to give worse results. I did try > > > using an x86 jail as an alternative to VirtualBox but I gave up as I = got > > > too many test failures. > >=20 > > Thanks for your attention and mention of your use case. > >=20 > > I've added this point to my TODO. I guess it could look as the followin= g: > >=20 > > valgrind --trace-children=3Dyes -q kyua -v execenv=3Dhost test -k Kyuaf= ile >=20 >=20 > Sounds good, but I'd need to test in order to make sure. I don't run > that kind of test very often. >=20 > > Does it look like something that would cover your production needs? >=20 >=20 > It's not to test FreeBSD for prod, it's to test Valgrind is working with > all those tests (any FreeBSD errors picked up are a bonus). >=20 Paul, it would be appreciated if you have time to test the patch. The gener= al test plan is covered here: https://reviews.freebsd.org/D42350, but specific= ally for your case the following extra check could be run in addition: valgrind --trace-children=3Dyes -q kyua -v execenv=3Dhost test -k /usr/test= s/sys/netpfil/pf/Kyuafile It should report that pass_block:* tests are skipped due to the given "-v execenv=3Dhost" runtime configuration. I hope current implementation meets your expectations. Best regards, Igor.