From nobody Tue Feb 13 02:48:40 2024 X-Original-To: ipfw@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TYm3r41PZz59b3b for ; Tue, 13 Feb 2024 02:48:40 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TYm3r2LXqz40QV for ; Tue, 13 Feb 2024 02:48:40 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1707792520; a=rsa-sha256; cv=none; b=O3qjDPEVRpaOZ/TwrcaaPaGtzuCv/j4tVCWdW9aSFhR5Z/6Bydj8dpzLbMNpJ1/5yEWRnK I4a5n8Z6K4R0/bGCYtZEoeQtoETCUXHFfDjBQGz/IowBF1Ya5CtVocabxS3VsBf8MPmPab WkD0iJV1kx/JejkBLraONgmCB+lz/Ks1qdBe9Z1ZpY6RRIj2QabIgQtaAE4ca0FP7h1ic8 f5COp8jiuSYplnMer7YgnHKa5X/ALeQOJwGx1HloCpl3Y4UptHIND8hvqD6IjdiPJ0hk6Z 0kH6OcqMKeQ5vWfnxKMi/nHadLC0Z/+O/Q2GpTP3/wc9fLVpaoTAX2h6Fgr5qQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1707792520; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tYDqECe538uP0jJ2qmZkxuj+kx/9KzmOW/6utmvzHNQ=; b=bBxAA7+WU3ThO7gi8UmqFqWopOFqds6w6b5t1NLD4eFaQTDlK1Q4HcqF6FPFHcvPI+oAqk dUMNFnrXEbShq6HB0Kc4/CtyrsPVDcM8smujfLmT1xQses0u5+gUXlJDVq39ybZzewSUN0 Zy9LCtpkpdzdKuhH8IHhLw8of6H7aEC6wfRYh29qfvl4ZPc28e3rNqx8sbnyqCOuW9OGKc yk7PjF3g8H6beRlQkUV96+M3RDzLoWf1pEwuCIsZS9NZXEBIBWVLrQqyK4lQkyzDr9S6ke RnI8ogaj8Y5nxcLkTrPMN5jqdeoo32cG8FQ6acgAE9VsktZsJcSUncGHznxJSg== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4TYm3r1KMMzxZ6 for ; Tue, 13 Feb 2024 02:48:40 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 41D2meRq092216 for ; Tue, 13 Feb 2024 02:48:40 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 41D2metF092209 for ipfw@FreeBSD.org; Tue, 13 Feb 2024 02:48:40 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ipfw@FreeBSD.org Subject: [Bug 276732] IPFW keep-state rules with untag do not go through parent rule cmd Date: Tue, 13 Feb 2024 02:48:40 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: ae@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ipfw@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: IPFW Technical Discussions List-Archive: https://lists.freebsd.org/archives/freebsd-ipfw List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ipfw@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D276732 --- Comment #4 from Andrey V. Elsukov --- (In reply to John Baldwin from comment #2) I agree. I just hope the change will not become a big surprise for someone = when it start to work :) --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Thu Feb 15 18:23:58 2024 X-Original-To: ipfw@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TbNk62cZKz59pn8 for ; Thu, 15 Feb 2024 18:23:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TbNk60K42z4rGh for ; Thu, 15 Feb 2024 18:23:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1708021438; a=rsa-sha256; cv=none; b=t5rU93f+aHAYOAr9WEVV/upLNmDzMIHxauqKO3MMPJfgokgbRbzzvjvR/EcMOpvhQxWZAm mGnGjgIVZWWJu5aGtlvsupKcGM011JdKTD1xjoE1CjubE7BqZUWks7hOwQ0gUHC1RB6ug4 3HGOzC7PG3S2MWNXp7OyQm53kiQos1RHiQ/fsrCSAh2T0+W0pGmI7QO0G6mGv6aoNBiXIk Q7hFXABONqk/XfLM8UNtASHB7kprLhwp3ZqU36YGT8KGmnQ1Z5OhnQJ3o7AsJJXX/NBrO8 PimvviXSb0Og1kHoskKCt/baxsINur6xjOXaPGC1xsDHCwlLdmzfoAjtzV2xUw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1708021438; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jywOsC9ZGFdcMiJUMbG0YCbzmZAt5zX+J/32mdF1wSg=; b=xGYISATgpxRQnajZlVPx/VgYev+3iSys0VCv6AHprhA5u1wF7BKDsou5HY+t36ZNsYNAwI mrHZ8qbG4OrA4hYDdlXLs+6ZsfSwshPYmIDS94w9ouSkMzJr3iW0J9sde1S6yNoiigYG+6 WBXqajtD87v/uwl2I66igodLy77wQfdZIWHEGSMIHNSeuYwbmhuu5kt1rMfXDPQ0X8honc 3qJ0O8id2WAV4lqbLDauJsP1IpeUZa9n8Z72y+dTvvWivEZpZztekz0gsCu41PBU9B0AMZ 2E+Zu45ZOioUm+B86vtFgwzaQsIipZD1G6LMSm0WBDTAUSkfTRZm70XiJYtSVA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4TbNk56QL3zsNg for ; Thu, 15 Feb 2024 18:23:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 41FINvag015489 for ; Thu, 15 Feb 2024 18:23:57 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 41FINvpr015488 for ipfw@FreeBSD.org; Thu, 15 Feb 2024 18:23:57 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ipfw@FreeBSD.org Subject: [Bug 276732] IPFW keep-state rules with untag do not go through parent rule cmd Date: Thu, 15 Feb 2024 18:23:58 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: jhb@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ipfw@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: IPFW Technical Discussions List-Archive: https://lists.freebsd.org/archives/freebsd-ipfw List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ipfw@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D276732 --- Comment #5 from John Baldwin --- (In reply to fodillemlinkarim from comment #3) Do you have a full name you'd like me to use as the author of the git commit for this fix? So far what I would use is "Karim " --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Thu Feb 15 21:18:41 2024 X-Original-To: ipfw@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TbSbj37SQz5BFkD for ; Thu, 15 Feb 2024 21:18:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TbSbj1H0tz4MtF for ; Thu, 15 Feb 2024 21:18:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1708031921; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eX8vor+1+UZIXSwfSNPSrIY1sHoKKbZjWr7iPavF/60=; b=WN4ojmdYsPG1i5lZcR9FMsiAQdwf02mqKbb/p9ubSKhB7CijlwvOqtyb5xo45mbhLhS6Ti AR9VqEVPavnnW9FMkQ0WB7a3FDULs4S7BD4shvKR4PmT9y79z4J/ie7REJHmyR8XsgiY5H RIEU2tcM3+FlMzDQR+O+L83qJHE4l71h54p5bKGbgKPqW2+pgGI64qGV6EyCDVNi0FK9PF yItfu8gm4vNSvpRUwwYSTlO2+5yw4UOycx3MSbaWRpbJO2YsP4peY0PIois+5VF5y29XZu ifJQs1ppqjUb0mvHWiPH+Srga8ktIWQjhlZuZdglPh/RLBPM28dSG6bUHX9fxA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1708031921; a=rsa-sha256; cv=none; b=NLo1PjCx30ZUCW+7u/cBxwQT4bJYhEtGBn2mcQoKSF136Qlq7kOimy64czvhDEO4CPwg0w +rdnw8fC5fliVoF3w0z6AR0opaJuxCBhaV3AzrVH/mFwtdblo3gDJlfw2s4zrS8NNt9VYT GgepwCL3VBvrez2uQF77atvqvKK9q1g8OwCl491t1grh6IipJ+9yEipkRx02SFGXbnL7T8 gQf1s9ceCX6IwlbZrpnZM3QUJJM1jgX3j9sSP/YGIxvG52X3X9LQRLKnOfIfSAmp966GlR ABdvCJa3bbcV3ltirYoEdNCyrF9O7d1SaDW1LHlFJ0XupQ6lnbSfQTHG7xaGzg== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4TbSbj0M7yzy2Y for ; Thu, 15 Feb 2024 21:18:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 41FLIeul017930 for ; Thu, 15 Feb 2024 21:18:40 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 41FLIe1P017929 for ipfw@FreeBSD.org; Thu, 15 Feb 2024 21:18:40 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ipfw@FreeBSD.org Subject: [Bug 276732] IPFW keep-state rules with untag do not go through parent rule cmd Date: Thu, 15 Feb 2024 21:18:41 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: fodillemlinkarim@gmail.com X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ipfw@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: IPFW Technical Discussions List-Archive: https://lists.freebsd.org/archives/freebsd-ipfw List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ipfw@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D276732 --- Comment #6 from fodillemlinkarim@gmail.com --- (In reply to John Baldwin from comment #5) Please use Karim Fodil-Lemelin Thanks --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Thu Feb 15 21:28:48 2024 X-Original-To: ipfw@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TbSqP1ypdz5BGxg for ; Thu, 15 Feb 2024 21:28:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TbSqN6d1zz4RhJ for ; Thu, 15 Feb 2024 21:28:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1708032529; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z/tQJ2q3HOXaSP0lBmSfKMBxgwxATQKvTd1Mu365T7I=; b=WkPZYrgcB86mQZIHh+PD2EICPCFI1Q2uHnrS6G865xbjdVX5yXIaGZbf9ZrvpWMKFtk32G 7g0mY+6kQ+AvgdCE92tf6iiwsq6FIn7HH1bX/TsjjPHpjUQvPW/mQKUWpFQgAw7mXPnVz5 4KWjNko9PFGYcfFKD6yjpozXnGSG/hkM+A23iv3kHq1DfC6/cou0FVzKp1xY2+qsQ53gmX mV8P/VW5bJ1jEs9RsjV0vSskfYNZim1iOpB119KEa7pizHPY8OXcP2D8zmix+3971CJqc9 iJ4frB/66w9pcaYSgUiYbvDuUEA6yHEkfBHl0O0OVxYIbTgYMoyfixJv4lODIQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1708032529; a=rsa-sha256; cv=none; b=mUqW2RGMwTzPY/k3htXXmpjoDdwAT0sPTH+MUYePTztqkv6Yy39XvZZ0XVb3MrpAZmUbtD wN89IGYHBmfKaNaj7+58G5sPgdlnlib94wTkGx9OuHpcHOUWDzLv+N4w0oL+e7qiVbfmE8 aqqXk60CYdVV4Ewdp9iPycgcE0HfBCF4Q9IsF5xeYFBUwhoH06x6XoW6OPRw9K56rGcV3+ w2tdih5j8CR5oFzQ8xyy6vQUzovibe3oSuc0hodaSyXVCYnDyapBojIcH4MiZmJtE1jBD+ z5TMPeVlMUczSn5fRlbHKczFXu2stXUhWf87Y1NL9yJpgX7U72LgeaeZJncFig== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4TbSqN5RNqzxTn for ; Thu, 15 Feb 2024 21:28:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 41FLSm0n069884 for ; Thu, 15 Feb 2024 21:28:48 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 41FLSmmo069883 for ipfw@FreeBSD.org; Thu, 15 Feb 2024 21:28:48 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ipfw@FreeBSD.org Subject: [Bug 276732] IPFW keep-state rules with untag do not go through parent rule cmd Date: Thu, 15 Feb 2024 21:28:48 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: fodillemlinkarim@gmail.com X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ipfw@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: IPFW Technical Discussions List-Archive: https://lists.freebsd.org/archives/freebsd-ipfw List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ipfw@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D276732 --- Comment #7 from fodillemlinkarim@gmail.com --- (In reply to John Baldwin from comment #5) Since this was work founded by my employer XipLink Inc. might as well use my work email: kfl@xiplink.com Thanks. --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Fri Feb 16 02:11:03 2024 X-Original-To: ipfw@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Tbb542dJQz51s3K for ; Fri, 16 Feb 2024 02:11:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Tbb5365jbz43lH for ; Fri, 16 Feb 2024 02:11:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1708049463; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EnqUzILRRtvBXvdNoTRz0L+GJkU2c/jVkhx3kQJxolY=; b=pwJZ5F+xePfHyzFr9feD9mjILKbgDHNGQYWZEZK4PhTxZbPaqiOmOOX6WSlywJ67p58Kzx sR1PbWoZZrmbS6yP78Xa04HL2evSXg4f4b+uT1rn/gtQg1mi9mkP9jTagcg6Ha12mB1e2b gN4r5U8VAXYI3LLR9iqGdh43Yztrz+RvNSWLkFv+7PSGS/7YnGgUNHvUVtcp0XD4xqTXcw m4gPrO/44apcGv46CkR5YqZN2uA9+VQ8GVkO0HYiLTJBpbroPRjBu/H/h89v+Rc2k7D3j2 hW03Nh24IE0LpqiPlA0CF6JR4RyfwBUWBSACFfWmpBQ6MglAMmBaXn+J4HGkDA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1708049463; a=rsa-sha256; cv=none; b=PdWKksCApYuzEtsrcFLR/5FshkdWiXZx9JiDAYP6XKTgqCXEJzS6ZIHfgKc/J9pKzRunEp 2W3bh63oRMQPpIpf5qTPmozY8+fz8+Lydm4r8QXT5iEHk3q/V3vnlzqD998mt8WjHE1xdV x5WJ6N/T5nujdyhDWt510DEbxR0x2s2av/qEMeHXT80rE5CjTTDHZ69bkACwRzKrVb4lzP Qm1KGKmDwzUciiL4y7U4V7QVY/rjd761UNVLO3f51P74yKAm7P0dfBiihPmxP0o5WRxygm 8WRybElVpKpKRL3NZ/g1UYpRTr3fEtO49H8AJw3keiMOo2g7tk1Lk+siIr0FDQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Tbb5359QZz16G7 for ; Fri, 16 Feb 2024 02:11:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 41G2B3au067408 for ; Fri, 16 Feb 2024 02:11:03 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 41G2B32g067407 for ipfw@FreeBSD.org; Fri, 16 Feb 2024 02:11:03 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ipfw@FreeBSD.org Subject: [Bug 276732] IPFW keep-state rules with untag do not go through parent rule cmd Date: Fri, 16 Feb 2024 02:11:03 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ipfw@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: IPFW Technical Discussions List-Archive: https://lists.freebsd.org/archives/freebsd-ipfw List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ipfw@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D276732 --- Comment #8 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D62b1faa3b7495de22a3225e42dabe6ce8= c371e86 commit 62b1faa3b7495de22a3225e42dabe6ce8c371e86 Author: Karim Fodil-Lemelin AuthorDate: 2024-02-16 01:57:51 +0000 Commit: John Baldwin CommitDate: 2024-02-16 01:57:51 +0000 ipfw: Skip to the start of the loop when following a keep-state rule When a packet matches an existing dynamic rule for a keep-state rule, the matching engine advances the "instruction pointer" to the action portion of the rule skipping over the match conditions. However, the code was merely breaking out of the switch statement rather than doing a continue, so the remainder of the loop body after the switch was still executed. If the first action opcode contains an F_NOT but not an F_OR (such as an "untag" action), then match is toggled to 0, and the code exits the inner loop via a break which aborts processing of the actions. To fix, just use a continue instead of a break. PR: 276732 Reviewed by: jhb, ae MFC after: 2 weeks sys/netpfil/ipfw/ip_fw2.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Fri Feb 16 02:11:56 2024 X-Original-To: ipfw@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Tbb644C3Yz51sBG for ; Fri, 16 Feb 2024 02:11:56 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Tbb643BC8z44Jb for ; Fri, 16 Feb 2024 02:11:56 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1708049516; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BTeUBnSp9eAro0KEHPxaKZcT3DW+EuD5z/6xRIdP8hM=; b=flwk0TlDMM9rc4EbeInEMJH2FtBBEhKbIAU0vlXC50zi9WpiZJiK2q6qW5fX/p7ZlUmjYz EKlAEnzx+MOFznc5kJdblesjBm5hnkpn4hbRz4I+iX9Dlviiz84AnAU95rLoj9XiSjkcJ1 Xb+wg58e/ncyt7ot0w5Df0jfEj0ABYPz/PXIcKdvSvyXR0OM2UiK1WJGFATeSm3xw6ty56 7lYfHRnk+PWRjIrRlCbMZvBlJ1C7r6pvX8HWCVg5M8K84L5GTPkR7sa/Qk5EwfIHcP8mqN M9jcsSwOld22YtNou2gRRmqFz4MNf8Mgh2kDAeHJvhcCi8X7FQwrBuEJUCdGjg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1708049516; a=rsa-sha256; cv=none; b=nFFD4RQSSlIk0Ds0GAhinzI5iiKITmtUT4fPMP09TWhlFY6Fsfv7D+O9LQoU2ZuOPvl5S8 s6njhfa4I0RowPCVuDZLhihr68EhNuD7b83AVXwAg70Zgzl6cf50dKmSux07pIcWKDQXxM WRXUR4XkeY5EF8aIlyTTk2VMGiHavGcw6DcSLKIpvOySw/kGesMuJJ4HisH34UsJyF3eyH fsKLMxEHlkm+qPtKB8a1+S6pGa8Dr4ibXcldwhHcJWkaVdp4XwCIDgj1kZhnTLVNy4DkAt K2eYvxincpkTfAY9oX+D0+KpsfhlCXLA6QsRPoWBEASt1Ih5TihIpY0EF0f5sQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Tbb642H4Cz15cG for ; Fri, 16 Feb 2024 02:11:56 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 41G2BuXE078271 for ; Fri, 16 Feb 2024 02:11:56 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 41G2BuGB078236 for ipfw@FreeBSD.org; Fri, 16 Feb 2024 02:11:56 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ipfw@FreeBSD.org Subject: [Bug 276732] IPFW keep-state rules with untag do not go through parent rule cmd Date: Fri, 16 Feb 2024 02:11:56 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: jhb@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: jhb@FreeBSD.org X-Bugzilla-Flags: mfc-stable14? mfc-stable13? X-Bugzilla-Changed-Fields: assigned_to flagtypes.name bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: IPFW Technical Discussions List-Archive: https://lists.freebsd.org/archives/freebsd-ipfw List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ipfw@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D276732 John Baldwin changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|ipfw@FreeBSD.org |jhb@FreeBSD.org Flags| |mfc-stable14?, | |mfc-stable13? Status|Open |In Progress --=20 You are receiving this mail because: You are the assignee for the bug.=