From nobody Sat Feb 3 18:32:27 2024 X-Original-To: jail@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TS1TR5PMGz588KY for ; Sat, 3 Feb 2024 18:32:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TS1TR3LKpz4pjf for ; Sat, 3 Feb 2024 18:32:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1706985147; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TpoPqEuEztS8bDkzp6xI7AOoOMbpE8YD1PUcvcHiRLo=; b=bJl6iL/H6s2vegH96jEg4Jse2hKLGSAM69Nbiwde0YmOnqmI0l/uM4gTemyua7/Qa5/3mj qymka7S8hLVaX7gBE9QwvCL4FwZEQY+3aW6SPc1iJKpZSJSnEkQ46h1ixlKKhmNI8EtQkL Sr0PGx2MWSc2qw9umyg8JL6qdRHF6Pi1O2iXSKO69RxRSYGWlgjGwQplTRevB1k72xKvl0 1lZ8jKIgHbNVI/hehQhiRrNN06+U0fwpmL3fFRAez+HyhKLJd39V0h9RT/fiQRPq65BkZc lunDKQglAFgN7wpiC2AMqGeJVRUkDS1E0GEEn7V8w7qpjMbxEoMCC7h8QlxrTg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1706985147; a=rsa-sha256; cv=none; b=TC3zYei1czKw25/FU0CFh4ECBT9vsXaw2shjaiVizJWcB3P/Qx0yu65rAEA5kZifnodUcK oeeqDzvFjD0kibli934At3CiRQJB34Fpms8EhmyYWQ09fREDH/eAdu66chlgQiCLebbX2Y VoZjMOA0YUXwUc/4Gw5QNc+Uu7IEka6EOZd5ahbRSgV78tZtl/mAxgSOzkdJtotN9M+dnY jDFH8c1tXzEm4WI+7X5pmuzFfto/xVz0m6e1Nn4vY8qb6CSr0CCQ3+8aKMD2fHoTRSfapN Wf/PmyjtngevDrqa/hK8HBUG7yuhkn3ydwcg6XVMTQpOHwxTbpYq9eejdgTfUA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4TS1TR2HVfzPXT for ; Sat, 3 Feb 2024 18:32:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 413IWRZ9018270 for ; Sat, 3 Feb 2024 18:32:27 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 413IWRMc018257 for jail@FreeBSD.org; Sat, 3 Feb 2024 18:32:27 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: jail@FreeBSD.org Subject: [Bug 276809] SEGFAULTs using libjail Date: Sat, 03 Feb 2024 18:32:27 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 13.2-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: markj@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: jail@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc assigned_to bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Discussion about FreeBSD jail(8) List-Archive: https://lists.freebsd.org/archives/freebsd-jail List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-jail@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D276809 Mark Johnston changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |markj@FreeBSD.org Assignee|bugs@FreeBSD.org |jail@FreeBSD.org Status|New |Open --- Comment #1 from Mark Johnston --- The problem is that your code is not calling jailparam_import() or jailparam_get() (with some JID specified in the parameters). In this case, there is no value to export, i.e., jd_value =3D=3D NULL and we trigger a nu= ll pointer dereference. But, the library should probably check for this case = and return an error instead of crashing. --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Sat Feb 3 19:58:32 2024 X-Original-To: jail@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TS3Nm6931z58JpT for ; Sat, 3 Feb 2024 19:58:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TS3Nm53txz44tJ for ; Sat, 3 Feb 2024 19:58:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1706990312; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LZbcqeWjy9GKHYzlmTNGZJZ7TFUBBAa4sNCZ+MN93do=; b=ehggMDx69zshaPoQTZLBilDuu2kaUjSDyU/6FlN6XpVA3871PKtMGvn1o2Cbgswc2IRtPg 6eNldASBOHpnCVETZVI1B9MU6aknqhjkKSXY9bpAZZwXRqZZua/u7q6Yt9Jr2lci8+s36t LJ6CSAqs1tHw2dVAzEBPwhsBfpTdvgEFt1rJeL0f6EXVyVA6SwoYV4nCuqAVWF2usGhdt1 gqoyJoiXD0+lMXukzNB9ZErLLpXrodeBKw0GSOR7MjcweqlPFtxE2Jt30nWZ+JJZu/J1Db 8KyC1y/OS+v8FerYIgvMKwVYT+UHvwyFlrbjdJXs0TWa+C3Wxuf5HK1BkOI85g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1706990312; a=rsa-sha256; cv=none; b=f2ERAOa8offrhX38bC1nDlWPLeZU7UHrWmmSh8/ULIZ6eG7Sv9I/YXpRTVduLEnQZBaSTa x8uPF4QO2uv4oVyGfkZa/g/ug1mkXgLMCkLuPtjptopNbKwh//926i+LMlHBFHllBAGbw0 jlE9ZfKn2Bf3yG5tk7YGfDtVxrLN2DVfesOH2N7Tgt51kAn0BjYRS6Q1ZtqDmXAFdgFyFP qVFZlP1zO6xi2CI68xbT5fBSOc6LiN3MCPGyOnTGhPi3OSdH8p8jkEWmnQ1AaRQ+Wq933R wbwFUPD9Gaxlas5n6mc8aHgOs80s970uFohc+2hQms5K1tuel+S6TdyY7gfZrQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4TS3Nm474xzRL7 for ; Sat, 3 Feb 2024 19:58:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 413JwWHS042105 for ; Sat, 3 Feb 2024 19:58:32 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 413JwWhw042104 for jail@FreeBSD.org; Sat, 3 Feb 2024 19:58:32 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: jail@FreeBSD.org Subject: [Bug 276809] SEGFAULTs using libjail Date: Sat, 03 Feb 2024 19:58:32 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 13.2-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: freebsd-bugs@aliases.systohc.net X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: jail@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Discussion about FreeBSD jail(8) List-Archive: https://lists.freebsd.org/archives/freebsd-jail List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-jail@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D276809 --- Comment #2 from Fabiano Sidler --- Ah, of course I'm an idiot! How can I expect any param to have a value in s= uch a "list all possible param NAMES" call? The C program works now as expected, but I still get the SEGFAULT in Python after the first parameter (zfs.mount_snapshot). What is there still a probl= em? --- listjailparams.c.old 2024-02-03 20:07:04.525535000 +0100 +++ listjailparams.c 2024-02-03 19:55:56.447438000 +0100 @@ -8,7 +8,7 @@ printf("number of params: %d\n", nparams); for (int i=3D0; i; Sun, 4 Feb 2024 02:13:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TSCjW2Dqqz4hYk for ; Sun, 4 Feb 2024 02:13:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1707012815; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DqKwrZTus2bPo9phPxTzT9iWk0S0S03qFHK6bwjZAEA=; b=mdgeDsscn2czr2bE/cVIjTVIlqshoPmWS5nGkXH2kCgeOJ8nG0Akdn3g4X/7F8z/U5hpaX IKdoKFPyTTaYNsoin6Sixf4ShsKdbm9AcMQlNswvF2CKE4Cjpf2l2HQd2l9CSwOeGbyNb6 Vwzase9zvw1zsmEjByO3KKN5/lYwH9Bx7k26D4tidhLP5imbypCEqVETvuVAg+QJXHfjT5 LB5/DZNKhmLGYiLJRAx38AiAwrhYxSBrTuqt6githhNOVXMUTB6LllFg0n5Xzqg2Ey7JtQ YyB3l2AVis0yBRx2e/e1G2rm0yaihqLhjwylCSgKPRT0pqjQpQE40iQS/CvMUw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1707012815; a=rsa-sha256; cv=none; b=YaCEaRBZqjPQLYZRO+HmaDQOlNhrI0iSOO/LLimQVGUpNp82uTiXY+XI9iVfCvCVeQz9KA kWv4KcDeCIfsenRZRe5SqaV5jdSrIyG/UrYhPyWNmnMtCWMgaUhMno5/X7oJBxljnINzrJ acgDtHRgJioK0HeXcVqYh7DBcoQOh2ehe+NbcRaG8FFK4YFnlR/48Hr91bfeSBSiMiebIH zp4hdwCu8DDIhF9+DhLEpVelhcnZhJm5J6+yeQYgBVHPMAqWaT2aAztIpH9ufFOdgp9x+3 CfoW3ouU0u2UEo1+UuHwuj+eWVuWO313toZGH6tRrAI/z5Eyc9eNKeuNxK7EQw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4TSCjW1Jk6zdRZ for ; Sun, 4 Feb 2024 02:13:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 4142DZp9052870 for ; Sun, 4 Feb 2024 02:13:35 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 4142DZnJ052866 for jail@FreeBSD.org; Sun, 4 Feb 2024 02:13:35 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: jail@FreeBSD.org Subject: [Bug 276809] SEGFAULTs using libjail Date: Sun, 04 Feb 2024 02:13:35 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 13.2-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: markj@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: Not A Bug X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: jail@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: resolution bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Discussion about FreeBSD jail(8) List-Archive: https://lists.freebsd.org/archives/freebsd-jail List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-jail@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D276809 Mark Johnston changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |Not A Bug Status|Open |Closed --- Comment #3 from Mark Johnston --- (In reply to Fabiano Sidler from comment #2) The python representation of struct jailparam is incomplete. To access params[1], it needs to know the size of params[0], but JailParam's definiti= on would yield an incorrect result. --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Sun Feb 4 02:24:08 2024 X-Original-To: jail@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TSCxh1v0Kz58xWP for ; Sun, 4 Feb 2024 02:24:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TSCxh0TzQz4jJ4 for ; Sun, 4 Feb 2024 02:24:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1707013448; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OHa+BYNHlOmEGI8V4LiVsJooytLtczPMWilbP3BLDWQ=; b=iq5xGUZEXAASBhdYVaMSpH4yfwnC3uP6bKvp0MXBiDx66XRhfKoA6bSnBljRpeNC1Liuse vQE/7Cnk5xXMrkupsmJBmTnL6ukxM05hL4KB5oCf+1eLnSdFOW/6Ri+yWpRVi3y0dHz422 EySqly5DjwA7Rw/4n2UJIetBqKLdV6Dz4WhL6+eO2visWXuFVC1uM8Mbtvsl13AHN+GGkV FzfZjmJkSm06Ea1dQQv6CVkBFhZDS0xkw9o6wHWbDWtbXbQMPn+PXITNDf7q1jJc0O5NRs a2sB9Pf2dVc0MrThDQVm0xEAHAHRikqF6cjbS0O0w9zLkojShER5t5bvMbpm0Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1707013448; a=rsa-sha256; cv=none; b=VSbHID7odSebhjE+rwwp+yQSf0X6oCLV4GlSa//5DLC15dPw1RPlSuffAOIgRnHaRznXfC CIQdhk1xnVG1ZFvdNNxCIWFGgsreObytE7HbXy1ojLbmniFmWvqVUUzy/EpYrGY1i1KKJ+ z4lte31TZ5EDulOsCYGIw6lePRg0dIFUXhti3stS+bBk8OgCLJVXT/PCg9+ii01TFuv71T XztmVPPnDuXEIy7b3t8TbbIvn6IB9Zfozpr23v9laCTmGgN2+DrqV8mdUiiv0GoLrfM9A+ 51lhF9IqdsDLrGTGbWUwhxRay1Vr6Mlg24CPhNVnffTd33qPT/k4z5QpElf4Jw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4TSCxg6j3SzfSD for ; Sun, 4 Feb 2024 02:24:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 4142O7Nn003802 for ; Sun, 4 Feb 2024 02:24:07 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 4142O7EE003801 for jail@FreeBSD.org; Sun, 4 Feb 2024 02:24:07 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: jail@FreeBSD.org Subject: [Bug 276809] SEGFAULTs using libjail Date: Sun, 04 Feb 2024 02:24:08 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 13.2-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: markj@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: Not A Bug X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: jail@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Discussion about FreeBSD jail(8) List-Archive: https://lists.freebsd.org/archives/freebsd-jail List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-jail@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D276809 --- Comment #4 from Mark Johnston --- https://reviews.freebsd.org/D43732 makes jailparam_export() fail cleanly if= the value hasn't already been exported. --=20 You are receiving this mail because: You are the assignee for the bug.= From nobody Sun Feb 4 22:54:13 2024 X-Original-To: jail@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TSlF14Nk6z590gj for ; Sun, 4 Feb 2024 22:54:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TSlF138Xqz4YsM for ; Sun, 4 Feb 2024 22:54:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1707087253; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fzZQoaF7KpMxGa/kYEhLwnYJra45xIzne3Dkrv2MaBs=; b=qE0q4M71hL5eV1i0UkB2D6Tb2rzvrfUEAzLuCUavFWt3KBOzxxiixCBWZ9kBgLYcnQ0zD3 CnsAyrTZXMjRDtlBjz+3BuAmDOBA5OsqgEw5BCy6kmDaJlxX77DzXTIJsG4F2L4S6StOif 44GLV87h18WkJYAMFEdw5jq2JxmzKZLuT955BI5Ns2NajTidFBz1+Q2uF1NwZqgr6cgxxy bbbiEomw8AEjgdAs5krjVuQakGSR2cz0pBFdxM+UaSoIJcffGkUne4KVBrMkHsLAUB0Nnt YCrcjmIbX6ISUmi9EbtN61hdVpmU//YKvnb9e/c7gsNiot7lXonxDP2NS436ww== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1707087253; a=rsa-sha256; cv=none; b=WO2HaZHGS6Kt6g4dmnE7vGyVo3kOvz7HJlkbTQpon2kk8isaKKNy6Oc4bSFY/LIRi+D86V EvqPWgTLG0e7vr+WnO/z4Gq80pC00b1ictpiqGoZOI8r3aVjq/RrjUjtEKwYb7p1P/mNBA gsF3X8WYQwZjRUm674LyNh2nIp4FoI4S/8Sc5nxYTfLk8QHTpHLgkxZgdinq98149gexJA LEixJChMTuK15anLCt+emw1czaciGB7NqsyOfKnFKHrAOOwM3PP86JCAbB5uA78Ip5jl6V BZG295/ILqZnOtiJc3nNewdBHeRgsD2bUXdOAl3vnlICkwtGZnyXqtvSpsBEhQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4TSlF12DFvzGg3 for ; Sun, 4 Feb 2024 22:54:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 414MsDfm011258 for ; Sun, 4 Feb 2024 22:54:13 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 414MsDmQ011257 for jail@FreeBSD.org; Sun, 4 Feb 2024 22:54:13 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: jail@FreeBSD.org Subject: [Bug 276809] SEGFAULTs using libjail Date: Sun, 04 Feb 2024 22:54:13 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 13.2-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: Not A Bug X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: jail@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Discussion about FreeBSD jail(8) List-Archive: https://lists.freebsd.org/archives/freebsd-jail List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-jail@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D276809 --- Comment #5 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3Ddfabf3efaa795e657f3858b7e2d0b11f8= a51ecb5 commit dfabf3efaa795e657f3858b7e2d0b11f8a51ecb5 Author: Mark Johnston AuthorDate: 2024-02-04 02:22:09 +0000 Commit: Mark Johnston CommitDate: 2024-02-04 22:52:30 +0000 libjail: Guard against programmer error in jailparam_export() If the caller didn't use jailparam_import() to fetch the parameter value, an attempt to export it will trigger a segfault. Make it a bit easier to figure out what's happening in this situation. PR: 276809 Reviewed by: jamie MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D43732 lib/libjail/jail.c | 6 ++++++ 1 file changed, 6 insertions(+) --=20 You are receiving this mail because: You are the assignee for the bug.=