From nobody Mon May 6 13:25:27 2024 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VY2GH6yccz5KDBg for ; Mon, 06 May 2024 13:25:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VY2GH5w52z4Gh8 for ; Mon, 6 May 2024 13:25:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1715001927; a=rsa-sha256; cv=none; b=fLAkzpvBpp8rc/LllRhFUexTW+dYPgEUupCbWW5xZBCEsMlndWWS85CA/p6d9Qsnhk1lRB ywas51PQShjTQ1nTVSri7PYaJMMHDVunKpqnjVx1Z0iMLes4XsioIUf46ktQtCGea6kSnh +TOynotFf5KEJw/SME0YYGN6h6vz1Gt6yAYWHIRnB756jakNDaVxQ+S+XmVey0kmaHy4ff J0ISBGWoDpsyJuP/rAvQN4Pn9FwPV6zGr0ncX+uEkwi+Wx+M1h2jNSqWiq2EPgb42li+eG x5BO0GtnQ8xVNGCrNxEiMRAGbGh0y6pM0Ijwc8a7rVaEMl6bacHOV5WmF/5/EQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1715001927; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4sd7gu/8uP1bQWL9Po6WoyddgsKb32PmhB+PDI4AN6o=; b=tRZhDYYFybWh7icb1HNvVpjxFBzCoGf/5PpW15/4QmRp9Brwq/ylQOFwqszaPRTafQTJJH bWLmLvm7UH3Hx8dDsKpu0Vhs4A/x317hx8i6RI2H+eaC6pMQfeSr+2KStPtMZnahaU4qwb mdTvRdqyec6Xn7osXs0lSXqlEBbiEus8V+WHDcuBuTMpZLHrKrSy3eGcGDOX0j7fC0IkYc cZ2FoIAOgvhd/tpv87unS3neeKtzSSrGQRVGyOl5PzYBBqpwKuMVIcBu2dHOKx8hf9+1Ra JIgqe9xAujij3SDPYySctfTFoUf81aaLM5n7Qw5DFYoeEKZiU8TpGUqCMs4m9Q== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4VY2GH5Q4jzyS9 for ; Mon, 6 May 2024 13:25:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 446DPR3F042158 for ; Mon, 6 May 2024 13:25:27 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 446DPRwo042157 for net@FreeBSD.org; Mon, 6 May 2024 13:25:27 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 275920] Kernel crash in sys/netlink/route/iface.c:124 Date: Mon, 06 May 2024 13:25:27 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 14.0-RELEASE X-Bugzilla-Keywords: crash X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D275920 --- Comment #6 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D43387b4e574043b78a58c8bcb7575161b= 055fce1 commit 43387b4e574043b78a58c8bcb7575161b055fce1 Author: Kristof Provost AuthorDate: 2024-05-06 09:39:08 +0000 Commit: Kristof Provost CommitDate: 2024-05-06 09:39:08 +0000 if: guard against if_ioctl being NULL There are situations where an struct ifnet has a NULL if_ioctl pointer. For example, e6000sw creates such struct ifnets for each of its ports s= o it can call into the MII code. If there is then a link state event this calls do_link_state_change() -> rtnl_handle_ifevent() -> dump_iface() -> get_operstate() -> get_operstate_ether(). That wants to know if the link is up or down, so= it tries to ioctl(SIOCGIFMEDIA), which doesn't go well if if_ioctl is NULL. Guard against this, and return EOPNOTSUPP. PR: 275920 MFC ater: 3 days Sponsored by: Rubicon Communications, LLC ("Netgate") sys/net/if.c | 3 +++ 1 file changed, 3 insertions(+) --=20 You are receiving this mail because: You are the assignee for the bug.=