From nobody Mon Oct 7 14:52:19 2024 X-Original-To: freebsd-net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XMhvg2h1Rz5YHVj for ; Mon, 07 Oct 2024 14:52:31 +0000 (UTC) (envelope-from zlei@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XMhvg29mMz4Lyr; Mon, 7 Oct 2024 14:52:31 +0000 (UTC) (envelope-from zlei@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1728312751; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OfQEuhw+bJXHnLl4eiWuKONkxdg5mDO1OxSKHr2DiPg=; b=UlHfogpk5LzJFZGBSVfieoRBUPSzd+FDGoQY0q6OVciOmmyFUJArMFlh+G9nB9Pe+yNRem HotNKZVKsZB0eHbWUGxJodTrZT7bNPlowyR0QSuZl4QH38EzLhf1QeLWfVDsYwHIcAC1qt CFHlXsUoTibH4VxbQUrygWCTt9fz2SPpqqiUdwjc3oxeXOuix+iA2e5oO9Xtv7FU0jEomc tO5bZMIgI1dp12J2nFJsPD3ltzgD5jcg9fTQDRWD8lHdhVmNhfB9vLsBrYq3hiOYzw2o2b eBhPs/0k5acUNvTrDbg5Q9olI6f7uxYcr8lMhPdDFAEcOxsDG5cFP+6+klgvvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1728312751; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OfQEuhw+bJXHnLl4eiWuKONkxdg5mDO1OxSKHr2DiPg=; b=TVXtg5ztuVRdthuE1WNPbegVNAdv0JkCV7+osvOeBP5gatlIJGhjEH1sb+j3sdW9Py1E6U Zaemoj+hLYZDk0g2xKH01SMlCbrfVZi6OAWqNsrHCH/vvvyQNXTAXCJoDg7KXydtfmRT1e r4KqaKi2RQlSPqpctrYogS4Ya2zekgXQyQ+PLfI0fJ9jyeyiS+tnyWtM07/VJ6CiYXhqIT xB3zy6Uj4fx/FMQMaLxHJNMNDFC/I4Ai2m2h8TV0H7ajo1vvKw7rLkYj2y4u0Sy99UNpSr j5jJvpVFSiM8hcZanKwK7NyshuXj9cmDz2eHkAFjH3tZUuzf9PskmWlgZwsNng== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1728312751; a=rsa-sha256; cv=none; b=MxR5dNENscy5V3xFO0I0AS/kz50xH2U2ME44AWsb7gU9iYCapsoIdwM8uOG6B8bUbB4PPJ qDMirbfaduczVU5kmL6yqw08HFEr/N/qVjyKTz9M536lhDHvdzTtnzVMdg9fWQGcjmf3iS uouO3RMEmJw5sEP2jeUC841++Lxcnp/q6C4/OoPH8QaFDfG1rWlfywdwjOKhsiB2EGOrgz r8a+s2oIxT9h4JjhiA3tZqD9NNqXK3UkAn8EYS/j2IFcJAmsHUDhZV7pvWiCpvUSFNb2aJ mWsW3ztuBDN7Bz1zQTMwhhy4NOfhwNrcE+4+GPkgncjr669GZe12dAQN/46DxQ== Received: from smtpclient.apple (ns1.oxydns.net [45.32.91.63]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: zlei/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4XMhvf1hVfz17rT; Mon, 7 Oct 2024 14:52:29 +0000 (UTC) (envelope-from zlei@FreeBSD.org) Content-Type: text/plain; charset=utf-8 List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.10\)) Subject: Re: CALL FOR TEST axgbe promisc mode From: Zhenlei Huang In-Reply-To: Date: Mon, 7 Oct 2024 22:52:19 +0800 Cc: Franco Fichtner , FreeBSD Net Content-Transfer-Encoding: quoted-printable Message-Id: References: <31932BD6-8427-4E68-8496-81AADCE9E290@FreeBSD.org> <54063277-FDC6-4B69-914E-08044E09346F@opnsense.org> To: Mark Johnston X-Mailer: Apple Mail (2.3696.120.41.1.10) > On Oct 2, 2024, at 3:42 PM, Mark Johnston wrote: >=20 > On Tue, Oct 01, 2024 at 12:46:07PM +0000, Franco Fichtner wrote: >> Hi, >>=20 >>> On 1. Oct 2024, at 02:47, Zhenlei Huang wrote: >>>=20 >>> The test plan is simple, either of the following should suffice: >>>=20 >>> =E2=80=A2 Do traffic sniffing on axgbe interface. The interface will = enter promisc mode and should see packets not for us. >>=20 >> I tested this with and without the patch and it's inconclusive: >>=20 >> 1. tcpdump sees foreign packets with and without patch >> 2. tcpdump -p sees foreign packets with and without patch >=20 > That's somewhat surprising. Maybe the firmware / hardware happens to been ( wrongly ) set to promisc = mode already ? >=20 >>=20 >> This oddly enough matches my expectation that nobody raised issues = about >> promisc not working so far, but it leaves the question if we are/I am = testing the >> right thing? >=20 > I think you are. BPF uses ifpromisc() to enable promiscuous mode, and > tcpdump uses that interface rather than setting IFF_PPROMISC directly, > and without the patch I expect that that's a bit broken. >=20 > There is perhaps an unrelated driver bug there. I wonder what flags = get > printed by ifconfig before and during your experiments. It'd also be > useful to try enabling debug logging (sysctl > dev.ax.0.axgbe_debug_level=3D1, I think) to see if = axgbe_if_promisc_set() > is getting executed as expected. Probably I should firstly check D46794 in. Any idea ? >=20 >>=20 >>=20 >> Cheers, >> Franco >>=20 >> ax0: mem = 0x80160000-0x8017ffff,0x80140000-0x8015ffff,0x80188000-0x80189fff at = device 0.4 on pci6 >> ax0: Using 512 TX descriptors and 512 RX descriptors >> ax0: Using 4 RX queues 4 TX queues >> ax0: Using MSI-X interrupts with 8 vectors >> ax0: Ethernet address: XX:XX:XX:XX:XX:XX >> ax0: xgbe_config_sph_mode: SPH disabled in channel 0 >> ax0: xgbe_config_sph_mode: SPH disabled in channel 1 >> ax0: xgbe_config_sph_mode: SPH disabled in channel 2 >> ax0: xgbe_config_sph_mode: SPH disabled in channel 3 >> ax0: RSS Enabled >> ax0: Receive checksum offload Enabled >> ax0: VLAN filtering Enabled >> ax0: VLAN Stripping Enabled >> ax0: Checking GPIO expander validity >> ax0: GPIO configuration valid >> ax0: SFP detected: >> ax0: vendor: FS ax0: part number: SFP-10G-T = ax0: revision level: A ax0: serial number: XXXXXXXXXXX = ax0: netmap queues/slots: TX 4/512, RX 4/512 >> ax0: Link is UP - 10Gbps/Full - flow control off >> ax0: link state changed to UP >> ax0: xgbe_config_sph_mode: SPH disabled in channel 0 >> ax0: xgbe_config_sph_mode: SPH disabled in channel 1 >> ax0: xgbe_config_sph_mode: SPH disabled in channel 2 >> ax0: xgbe_config_sph_mode: SPH disabled in channel 3 >> ax0: RSS Enabled >> ax0: Receive checksum offload Disabled >> ax0: VLAN filtering Disabled >> ax0: VLAN Stripping Disabled >> ax0: promiscuous mode enabled >> ax0: promiscuous mode disabled